[Koha-bugs] [Bug 12805] Proposed changes to Koha plugins system (.KPZ) structure
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12805 Viktor Sarge viktor.sa...@regionhalland.se changed: What|Removed |Added CC||viktor.sarge@regionhalland. ||se --- Comment #5 from Viktor Sarge viktor.sa...@regionhalland.se --- I can only provide partial feedback here. An optional command line tool would be a welcome addition. It's practical when you are afraid to to mess the file up, while still making it possible to edit it manually and learn a little more about whats going on under the hood. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12806] Adding 'Koha as a CMS' to the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12806 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl --- Comment #3 from M. de Rooy m.de.r...@rijksmuseum.nl --- Indranil: Interesting patch! I wonder if we should move the page contents to another database table instead of putting them in the preferences? You would only need an extra form to handle CRUD ops. It would make translation of these local pages easier too. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12806] Adding 'Koha as a CMS' to the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12806 --- Comment #4 from Jonathan Druart jonathan.dru...@biblibre.com --- Why do you want to add these files into the Koha src? What append if a library has already created these files (pages.pl and pages.tt)? I know the answer: Boom :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12806] Adding 'Koha as a CMS' to the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12806 Viktor Sarge viktor.sa...@regionhalland.se changed: What|Removed |Added CC||viktor.sarge@regionhalland. ||se --- Comment #5 from Viktor Sarge viktor.sa...@regionhalland.se --- +1 for shipping the needed .tt-files with a standard install in general. If I remember correctly that would it possible for IT-librarians to activate CMS-mode without having to ask the admin to manhandle any files on the server. Boom should be avoided of course :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12806] Adding 'Koha as a CMS' to the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12806 Indranil Das Gupta indr...@gmail.com changed: What|Removed |Added Status|Needs Signoff |In Discussion --- Comment #6 from Indranil Das Gupta indr...@gmail.com --- (In reply to Jonathan Druart from comment #4) Why do you want to add these files into the Koha src? Jonathan: The Koha as a CMS as it has existed in the wiki and manual (Appendix E) is essentially an user-driven hack. There has been discussion before http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7840 about integrating it. This is a feature I use a bit, and when I wrote a small KPZ plugin to provide the WYSIWYG feature for CMS add/edit window, it seemed work well. However, apparently people who wanted to use it had trouble with the pages.tt / pages.pl hand edits. What append if a library has already created these files (pages.pl and pages.tt)? I know the answer: Boom :) So, this patch was the next step to make user adoption more seamless. I assume, that if @Marcel's suggestion in included and the pages namespace is re-defined, then there should be no reason for a BLAST? :-) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12806] Adding 'Koha as a CMS' to the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12806 --- Comment #7 from Indranil Das Gupta indr...@gmail.com --- (In reply to M. de Rooy from comment #3) Indranil: Interesting patch! I wonder if we should move the page contents to another database table instead of putting them in the preferences? You would only need an extra form to handle CRUD ops. It would make translation of these local pages easier too. Marcel: I think I can manage that! Right now I had written a simple KPZ to take care of things on that side. I'm sure I can re-factor that. https://github.com/l2c2technologies/KohaCMS/releases/tag/1.2.2 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11759] Batch checkout
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11759 --- Comment #34 from Viktor Sarge viktor.sa...@regionhalland.se --- 1) Do we need to have a separate batch checkout page? Or can we add batch checkout functionality to the existing checkout page? (Perhaps having Single and Batch tabs in the UI) Both works for me but If possible I personally prefer not ever having to say Oh, but you see that's a batch checkout and has it's own module. If the existing interface could handle it I'd prefer to just expand it's functionality. 2) As Viktor pointed out, how could this work with a RFID scanner providing multiple barcodes at once? In my case, I have a RFID scanner that is returning comma-separated barcodes (e.g. 12345,67890,111213). I suppose this case is similar to the textarea case, except for a difference with separator, and the RFID scanner sends a carriage return at the end of the concatenated barcode string to trigger a submit... Tricky... I guess the first choice is handling it server side or client wise. With the Ajax circulation I guess you could actually have a javascript that slices the barcodes and sends them one by one(?). I guess you could even make it possible to do multiple batch scans and just append all new barcodes to the queue to be handled by the script. Not an authority on the internals of Koha though so it's really just my two cents. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10105] Gate register module
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10105 --- Comment #6 from vimal kumar vimal0...@gmail.com --- (In reply to Indranil Das Gupta from comment #5) I need this feature for a client. I'll be taking it up. Thank you Indra. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 643] Allow override of 'debarred' status
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=643 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #12 from Jonathan Druart jonathan.dru...@biblibre.com --- The second patch does not fix correctly the problem. If I set forceallow=1 in the url, I can checkout an item without the force_checkout_permission. Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12545] Add EditorConfig file to the source tree
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12545 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12545] Add EditorConfig file to the source tree
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12545 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #30263|0 |1 is obsolete|| --- Comment #5 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 31070 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31070action=edit Bug 12545: Add EditorConfig.org file to the source tree This patch adds a .editorconfig file to the source tree, that enforces some of our coding guidelines. Some editors try to detect the desired configurations from the currently opened file. As we have tons of old code that doesn't follow our current coding guidelines, this can lead to unintended QA problmes. To test: - Apply the patch - Verify the .editorconfig file is in the top-level directory - See the .editorconfig file expresses our coding guidelines Regards To+ Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12576] search links need style id
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12576 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12576] search links need style id
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12576 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #30489|0 |1 is obsolete|| --- Comment #4 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 31071 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31071action=edit Bug 12576: Make the more/fewer options and new search links on the advanced search page look better. How to test: 1/ Visit /cgi-bin/koha/opac-search.pl 2/ Assert the More/Fewer options buttons look like bootstrap default buttons 3/ Assert the New search button looks like a bootstrap default button 4/ Assert the visited colour of the buttons remains #333 (light grey) 5/ Assert the buttons still function as expected Signed-off-by: Nick Clemens n...@quecheelibrary.org Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12576] search links need style id
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12576 --- Comment #5 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 31072 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31072action=edit Bug 12576: Update opac.css file This file had a conflict. I prefer to put the changes in a specific commit. Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12576] search links need style id
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12576 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #31072|0 |1 is obsolete|| --- Comment #6 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 31073 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31073action=edit Bug 12576: Update opac.css file This file had a conflict. I prefer to put the changes in a specific commit. Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12576] search links need style id
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12576 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added CC||jonathan.dru...@biblibre.co ||m --- Comment #7 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to Jonathan Druart from comment #5) Created attachment 31072 [details] [review] I forgot the --compress flag -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12222] members-update.tt has a giant hash variable
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12222] members-update.tt has a giant hash variable
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #30682|0 |1 is obsolete|| --- Comment #6 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 31074 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31074action=edit Bug 1: members-update.tt has a giant hash variable This patch changes that giant hash by a TT block to find apropriate strings To test: 1) Apply the patch 2) On opac log as some user and request some modifications on personal data 3) On staff, reload main, will see a notice that a patron has requested modification, clic on the link 4) All modified data must show with apropriate legends for each db column, check for regressions 5) Update translation files for your preferred language, xx-YY Check for new strings, e.g. egrep Alternate address misc/translator/po/xx-YY* You must find old and new instances (old with #~ , in particular the hash one) Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz Works as advertised, strings are now translatable. Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12222] members-update.tt has a giant hash variable
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added CC||jonathan.dru...@biblibre.co ||m --- Comment #7 from Jonathan Druart jonathan.dru...@biblibre.com --- Works great with patch on bug 12623. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added CC||jonathan.dru...@biblibre.co ||m --- Comment #12 from Jonathan Druart jonathan.dru...@biblibre.com --- Kyle, I am sorry but this patch c/p almost all the code from tools/import_borrowers.pl. I am not sure this is the right way to do. The script should also use Pod2Usage (instead of the print_help routine). I am completely aware of the quantity of work to provide to reach a correct quality of core here: refactoring, unit tests, etc. But I am pretty sure this script should not be pushed as it. I let this bug report in the NQA queue in order to get more feedback. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11633] Cannot use the override function AllowFineOverride on the Staff client because this stops the pay function working on the SelfCheck (SC) machines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11633 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added CC||jonathan.dru...@biblibre.co ||m --- Comment #6 from Jonathan Druart jonathan.dru...@biblibre.com --- I am not able to test SIP, so I cannot test this patch. But looking at the code, it smells good to me. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12801] Koha::Calendar is caching holidays for the wrong branch!
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12801 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #31053|0 |1 is obsolete|| Attachment #31056|0 |1 is obsolete|| --- Comment #10 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 31075 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31075action=edit [SIGNED-OFF] Bug 12801: Use the branchcode to cache holidays Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12801] Koha::Calendar is caching holidays for the wrong branch!
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12801 --- Comment #11 from Kyle M Hall k...@bywatersolutions.com --- Looks good. Thanks! (In reply to Jonathan Druart from comment #9) (In reply to Kyle M Hall from comment #7) Would you be able to submit a replacement for my second patch? Something like that? Note: I didn't test this patch! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11577] [ENH] Automatic renewal feature
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 Holger Meißner h.meissner...@web.de changed: What|Removed |Added Attachment #30693|0 |1 is obsolete|| --- Comment #73 from Holger Meißner h.meissner...@web.de --- Created attachment 31077 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31077action=edit Bug 11577: Add Automatic renewal to the circulation and fine rules This patch adds a column Automatic renewal to the circulation and fine rules table. To test: 1) Add or edit some issuing rules. 2) Confirm that Automatic Renewal is set to No by default and can be switched to Yes. Sponsored-by: Hochschule für Gesundheit (hsg), Germany Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11577] [ENH] Automatic renewal feature
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 Holger Meißner h.meissner...@web.de changed: What|Removed |Added Attachment #30692|0 |1 is obsolete|| --- Comment #72 from Holger Meißner h.meissner...@web.de --- Created attachment 31076 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31076action=edit Bug 11577: Add auto_renew flags to the database - issues.auto_renew - old_issues.auto_renew - issuingrules.auto_renew Default value is zero. To test: 1) Run installer/data/mysql/updatedatabase.pl 2) Create SQL reports like: SELECT * FROM issues LIMIT 0,1 3) Confirm that a column auto_renew was added to each of the three tables. Sponsored-by: Hochschule für Gesundheit (hsg), Germany Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11577] [ENH] Automatic renewal feature
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 Holger Meißner h.meissner...@web.de changed: What|Removed |Added Attachment #30694|0 |1 is obsolete|| --- Comment #74 from Holger Meißner h.meissner...@web.de --- Created attachment 31078 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31078action=edit Bug 11577: Code and intranet template changes This patch adds a checkbox for Automatic renewal to the checkout page. CanBookBeRenewed is modified to include two new errors: - auto_renew (renewal shouldn't be done manually) - auto_too_soon (renewal is premature and shouldn't be done manually) To test: 1) Add or edit an issuing rule with Automatic renewal and another one without it. 2) Issue at least three items: - automatic renewal by issuing rule - automatic renewal by Checkbox on the checkout page - no automatic renewal 3) Test the following steps for both: Home Circulation Checkouts Home Patrons Patron details 4) Confirm that issues with automatic renewal cannot be renewed manually, even if there are still renewals left and it's not too soon to renew. 5) Confirm that Scheduled for automatic renewal and the remaining renewals are displayed. If no renewals are left Not renewable should be displayed. 6) Confirm that issues without automatic renewal behave as usual. Sponsored-by: Hochschule für Gesundheit (hsg), Germany Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11577] [ENH] Automatic renewal feature
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 Holger Meißner h.meissner...@web.de changed: What|Removed |Added Attachment #30695|0 |1 is obsolete|| --- Comment #75 from Holger Meißner h.meissner...@web.de --- Created attachment 31079 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31079action=edit Bug 11577: Add 'auto_renew' and 'auto_too_soon' to renewal page This patch adds the new renewal errors 'auto_renew' and 'auto_too_soon' to the renewal interface. To test: 1) Issue two items: - one with automatic renewal and no value for No renewal before - another with automatic renewal and a value for No renewal before 2) Try to renew: Home Circulation Renew 3) Confirm there are error messages explaining that the items have been scheduled for automatic renewal and that one of the renewals is also premature. 4) If global syspref AllowRenewalLimitOverride is set to Allow you should be given the option to override. Sponsored-by: Hochschule für Gesundheit (hsg), Germany Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11577] [ENH] Automatic renewal feature
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 Holger Meißner h.meissner...@web.de changed: What|Removed |Added Attachment #30697|0 |1 is obsolete|| --- Comment #77 from Holger Meißner h.meissner...@web.de --- Created attachment 31081 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31081action=edit Bug 11577: OPAC bootstrap theme changes This patch makes opac-user.pl and the bootstrap version of opac-user.tt handle the new renewal errors auto_renew and auto_too_soon. To test: 1) Set global syspref opacthemes to bootstrap. 2) Set global syspref OpacRenewalAllowed to Allow. 3) Test the same things as in previous patch, this time for the OPAC summary page. Sponsored-by: Hochschule für Gesundheit (hsg), Germany Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11577] [ENH] Automatic renewal feature
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 Holger Meißner h.meissner...@web.de changed: What|Removed |Added Attachment #30696|0 |1 is obsolete|| --- Comment #76 from Holger Meißner h.meissner...@web.de --- Created attachment 31080 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31080action=edit Bug 11577: Expand description of AllowRenewalLimitOverride With the introduction of the new automatic renewal feature global syspref AllowRenewalLimitOverride is expanded in meaning. It now gives the option to override blocks if: - the number of allowed renewals is exceeded - the renewal is premature (No renewal before) - the item is scheduled for automatic renewal - the renewal is premature and the item is scheduled for automatic renewal Sponsored-by: Hochschule für Gesundheit (hsg), Germany Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11577] [ENH] Automatic renewal feature
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 Holger Meißner h.meissner...@web.de changed: What|Removed |Added Attachment #30698|0 |1 is obsolete|| --- Comment #78 from Holger Meißner h.meissner...@web.de --- Created attachment 31082 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31082action=edit Bug 11577: OPAC prog theme changes This patch makes the prog version of opac-user.tt handle the new renewal errors auto_renew and auto_too_soon. To test: 1) Set global syspref opacthemes to prog. 2) Test the same things as in previous patch. Sponsored-by: Hochschule für Gesundheit (hsg), Germany Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11577] [ENH] Automatic renewal feature
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 Holger Meißner h.meissner...@web.de changed: What|Removed |Added Attachment #30699|0 |1 is obsolete|| --- Comment #79 from Holger Meißner h.meissner...@web.de --- Created attachment 31083 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31083action=edit Bug 11577: Add an automatic renewal cronjob This patch adds a new cron script automatic_renewals.pl and a new entry in crontab.example. To test: 1) You need a few issues, some with automatic renewal and some without. 2) Confirm that each time you run misc/cronjobs/automatic_renewals.pl those issues are renewed that meet all of the following criteria: - automatic renewal has been scheduled either by issuing rule or by checkbox on the checkout page - the number of allowed renewals isn't exceeded - renewal isn't premature (No renewal before) 3) Confirm that all other issues are not affected. Sponsored-by: Hochschule für Gesundheit (hsg), Germany Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11577] [ENH] Automatic renewal feature
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 --- Comment #81 from Holger Meißner h.meissner...@web.de --- Created attachment 31085 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31085action=edit Bug 11577: Add Hochschule für Gesundheit to contributing institutions Automatic renewal is the second feature sponsored by the hsg. Sponsored-by: Hochschule für Gesundheit (hsg), Germany Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11577] [ENH] Automatic renewal feature
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 Holger Meißner h.meissner...@web.de changed: What|Removed |Added Attachment #30700|0 |1 is obsolete|| --- Comment #80 from Holger Meißner h.meissner...@web.de --- Created attachment 31084 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31084action=edit Bug 11577: Unit tests This patch fixes two unit tests that broke because of the new feature. Also adds some new test cases. To test: 1) prove t/db_dependent/Circulation.t 2) prove t/db_dependent/Circulation_Issuingrule.t Sponsored-by: Hochschule für Gesundheit (hsg), Germany Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11577] [ENH] Automatic renewal feature
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 Holger Meißner h.meissner...@web.de changed: What|Removed |Added Attachment #30702|0 |1 is obsolete|| --- Comment #82 from Holger Meißner h.meissner...@web.de --- Created attachment 31086 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31086action=edit Bug 11577 : Fixing a tiny typo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11577] [ENH] Automatic renewal feature
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 Holger Meißner h.meissner...@web.de changed: What|Removed |Added Attachment #30701|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8836] Resurrect Rotating Collections
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #23967|0 |1 is obsolete|| Attachment #23968|0 |1 is obsolete|| Attachment #23970|0 |1 is obsolete|| Attachment #23971|0 |1 is obsolete|| Attachment #23976|0 |1 is obsolete|| Attachment #28141|0 |1 is obsolete|| Attachment #30838|0 |1 is obsolete|| Attachment #30921|0 |1 is obsolete|| --- Comment #48 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 31087 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31087action=edit Bug 8836 - Resurrect Rotating Collections Test Plan: In Tools - Rotating Collections - Add/Remove items: When adding item barcodes to the collection, the input field input type=text id=barcode name=barcode should become active automatically so it is easy to add multiple barcodes rapidly without touching the mouse or keyboard. Enter-press is dealt by the barcode reader so automatic form submittal should be handled by the barcode reader. In Rotating collections - Transfer Collection: When the collection is initially transferred, items are set to trasfer correctly. When the collection is transferred while items are still being transferred, the transfer destination library doesn't change from the original one. The holding library changes for all items in the collection to the destination library on retransfers as well. This is tricky if a user accidentally places the wrong destination. When I try to checkin these items to their new retransfer location, I get the following messages: -This item is part of a rotating collection and needs to be transferred to original transfer destination -Please return Valkoinen ihmissyj / to original transfer destination -Print slip or Cancel transfer When I checkin a Item to a arbitrary branch, I get the following messages: This item is part of a rotating collection and needs to be transferred to retransfer destination Please return Valkoinen ihmissyj / to original trasfer destination Bug 8836 - Resurrect Rotating Collections - QA Followup Bug 8836 - Resurrect Rotating Collections - Followup 2 - Perltidy rotating collections scripts Bug 8836 - Resurrect Rotating Collections - Followup 3 * Fix bad TT Tag * Fix bad sql query * Fix capitalization ( HTML4 ) * Allow a rotating collection's location to keep AutomaticItemReturn from sending it back to the branch of origin * Fix bad query Bug 8836 - Resurrect Rotating Collections - Followup 4 - Autofocus on barcode field Bug 8836 - Resurrect Rotating Collections - Followup 5 - Don't transfer issued and waiting items Items in a rotating collection are automatcially transferred when a collection is transferred. This is a problem for currently checked out items and items on hold marked as Waiting. This patch resolves this issue by skipping the transfer for those items. When the items are then returned, the librarian will be alerted to transfer the item to the library currently holding that rotating collection. Bug 8836 - Resurrect Rotating Collections - Followup 5 - Link collections.colBranchcode to branches.branchcode Signed-off-by: jmbroust jean-manuel.bro...@univ-lyon2.fr -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8836] Resurrect Rotating Collections
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12807] New: Rotating Collections Enhancements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12807 Bug ID: 12807 Summary: Rotating Collections Enhancements Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: k...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12807] Rotating Collections Enhancements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12807 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |jsep...@student.uef.fi |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12807] Rotating Collections Enhancements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12807 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12807] Rotating Collections Enhancements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12807 --- Comment #2 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 31089 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31089action=edit Bug 12807 [QA Followup] - Fix koha-qa failures -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12807] Rotating Collections Enhancements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12807 --- Comment #1 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 31088 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31088action=edit Bug 12807 - Resurrect Rotating Collections: additions This is patch is an enchancement patch based on our requirements (sending in hopes that it could be useful to someone) and is ment to be applied on top of my squashed rotating collections patch and focuses mainly on the interface, aiming to streamline workflow and and to reduce unnecessary page reloads. Core rotating collection functionality is also changed in that transfers are now handled on the item level instead of on the collection level. This allows individual items in the collection to have their own transfer branches - you can still of course have all items transferred to the same destination by using the collection transfer feature in the main view or in the additems-view. Note: as this is a fairly large change in how collections are handled, this patch cannot be used directly with collections managed by the old system. List of larger changes (of the top of my head): - transferCollection-view has been made redundant with the addition of a transfer button and branch select input in the main view. - editCollections-view has been made redundant with addition of the edit button in the main view. Note that Edit collection still exists - datatables used in all the views. - The main view table has been revamped and some columns have been moved around or removed. New columns: Owner(branch of the signed in user on creation), Items(count), Transferred(how many items in collection are transferred), Transfer collection, Edit and Delete. - New collections can be created directly from the main view using the New collection-button. - Item's original home branch (before a transfer) is now recorded on transfer (a new database column 'origin_branchcode' in collection_tracking). The old collection-level transfer branch in collections is no longer needed but is not touched by this patch. - Item's transfer location is now recored on item-level basis (a new database column: 'transfer_branch). - Item's tranfer status is now recorded (a new database column in collection_tracking: 'transferred'). - When removing a collection, all items (if any) in that collection get removed from collection_tracking and returned to their origin branch. - addItems-view: - Table now shows the item's origin branch, home branch and current loc. In addition to these, new columns: Transferred, Transfer, Return and Remove. - Item's title and barcode are now links to the relevant page in catalogue. - Buttons for individual item transfer, return and removal. The transfer button can be used to transfer an individual item to a branch (branch selection happens in a bootsrap modal-view). The return button can be used to return an item to its origin branch. The remove button allows removing an item from the collection without the need for reading a barcode. - A button for whole collection transfer. Sadly, this is *not* a complete list of changes. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12807] Rotating Collections Enhancements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12807 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Depends on||8836 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8836] Resurrect Rotating Collections
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Blocks||12807 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12807] Rotating Collections Enhancements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12807 --- Comment #3 from Kyle M Hall k...@bywatersolutions.com --- Issues: 1) There is no test plan 2) The unit tests for rotating collections fail with it applied If you can fix these I'd be happy to continue testing. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8836] Resurrect Rotating Collections
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836 --- Comment #49 from Kyle M Hall k...@bywatersolutions.com --- The squashing was fine, except you removed my authorship from the patches! I've uploaded a fixed version. In addition, your patch makes large changes, so I've moved it to a separate bug and made this one a blocker for it. The biggest problems with your patch are 1) There is no test plan 2) The unit tests for rotating collections fail with it applied (In reply to Juhani Seppälä from comment #46) Did you mean to test the squashed patch? I didn't set anything obsolete because I'm unsure as to whether squashing these old patches like this is actually welcome at all - I was hoping for comments and reactions. I guess I shouldn't have a set needs signoff - sorry. I can fix the old separate patches if that's how they should be kept. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11577] [ENH] Automatic renewal feature
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 Holger Meißner h.meissner...@web.de changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment #83 from Holger Meißner h.meissner...@web.de --- Hi Martin, thank you once again, for QA-ing my patches! I fixed the typo, added the cron line, added new test cases and rebased again. Not sure if those test cases are sufficient, but they are all I can think of right now. Setting back to Signed Off. :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8836] Resurrect Rotating Collections
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836 --- Comment #50 from Juhani Seppälä jsep...@student.uef.fi --- (In reply to Kyle M Hall from comment #49) The squashing was fine, except you removed my authorship from the patches! I've uploaded a fixed version. In addition, your patch makes large changes, so I've moved it to a separate bug and made this one a blocker for it. The biggest problems with your patch are 1) There is no test plan 2) The unit tests for rotating collections fail with it applied (In reply to Juhani Seppälä from comment #46) Did you mean to test the squashed patch? I didn't set anything obsolete because I'm unsure as to whether squashing these old patches like this is actually welcome at all - I was hoping for comments and reactions. I guess I shouldn't have a set needs signoff - sorry. I can fix the old separate patches if that's how they should be kept. The patch authorship thing was, probably among other stuff, something I completely missed at the time - sorry about that. I agree with the separate bug and am aware of the missing test stuff. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12743] Allow default values from the ACQ framework to be used when creating a record in acquisitions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12743 --- Comment #2 from Gaetan Boisson gaetan.bois...@biblibre.com --- Created attachment 31090 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31090action=edit [SIGNED-OFF] Bug 12743: ACQ: default values for catalogue records At the moment, it is possible to create records in acquisitions, but the ACQ framework is only used for items created in this module. This patch allows to defined default values in the ACQ framework for records created on the acquisition module. Test plan: 1/ Make sure you have the ACQ framework created (otherwise create it from the default framework). 2/ Define a default value for a field (for instance 099$z=1). 3/ Go in the acquisition module and create a new order from a new record. 4/ Fill mandatory information and save. 5/ Go on the detail page of this record and verify the default value exist. Signed-off-by: Gaetan Boisson gaetan.bois...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12743] Allow default values from the ACQ framework to be used when creating a record in acquisitions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12743 Gaetan Boisson gaetan.bois...@biblibre.com changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #3 from Gaetan Boisson gaetan.bois...@biblibre.com --- Tested, works! Almost a bugfix as i always found it hard to explain that the ACQ framework only affected items. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10402] Add multiple contacts for vendors
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #30460|0 |1 is obsolete|| Attachment #30461|0 |1 is obsolete|| Attachment #30462|0 |1 is obsolete|| Attachment #30463|0 |1 is obsolete|| Attachment #30464|0 |1 is obsolete|| --- Comment #91 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 31091 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31091action=edit Bug 10402: Use an object for contacts In preparation for adding the ability to handle multiple contacts, this patch moves booksellers' contacts into their own class, C4::Bookseller::Contact. To test: 1) Apply patch. 2) Run database update. 3) Edit a bookseller, making sure to add a contact. 4) View the bookseller's information, making sure the contact information is there. 5) Run the unit test: prove t/db_dependent/Bookseller.t Signed-off-by: Owen Leonard oleon...@myacpl.org Signed-off-by: Jared Camins-Esakov jcam...@cpbibliography.com Signed-off-by: Paola Rossi paola.ro...@cineca.it Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10402] Add multiple contacts for vendors
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402 --- Comment #93 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 31093 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31093action=edit Bug 10402: Add ability to enter multiple contacts Some vendors may have more than one contact. For example, a technical contact and a billing contact, or a contact for journals and a contact for monographs. Rather than require that each contact be either made into a separate vendor or recorded somewhere outside of Koha, it would be really useful of Koha had the ability to add multiple additional contacts to vendors in the Acquisitions module. To test: 1) Apply patch. 2) Edit a bookseller, making sure to add a contact. 3) View the bookseller's information, making sure the contact information is there. 4) Run the unit test: prove t/db_dependent/Bookseller.t 5) Add multiple contacts to a vendor, see that they show up. 6) Delete one contact from a vendor with multiple contacts, see that the result is correct. 7) Sign off. Note: This test plan can supersede that on the previous two patches, as all functionality of the previous two patches is required by this one. Signed-off-by: Owen Leonard oleon...@myacpl.org Signed-off-by: Jared Camins-Esakov jcam...@cpbibliography.com Signed-off-by: Paola Rossi paola.ro...@cineca.it Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10402] Add multiple contacts for vendors
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402 --- Comment #94 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 31094 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31094action=edit Bug 10402 [Template follow-up] Add multiple contacts for vendors This template-only follow-up tweaks the button labels and restructures the vendor view layout a little bit to make it more amenable to multiple contacts: - Add spaces after button icons - Change Add contact to Add another contact in hopes of making it less ambiguous whether clicking it will submit the whole form. - Eliminate duplicate headers on the vendor view page by making the contact name the subheading for each individual contact. To test, view details for vendors with one or more contacts, and try editing to add additional contacts. Everything should look good and work correctly. Signed-off-by: Jared Camins-Esakov jcam...@cpbibliography.com Signed-off-by: Paola Rossi paola.ro...@cineca.it Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10402] Add multiple contacts for vendors
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402 --- Comment #95 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 31095 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31095action=edit Bug 10402 follow-up: choose contacts for claims This patch makes it possible to choose a particular contact for acquisitions and serials claims. To test: 1) Select a contact to use for claiming late orders and a contact to use for claiming late issues. 2) Send a claim for a late order and a claim for a late issue. 3) Note that the claims went out to the proper people. 4) Run the unit test with: prove t/db_dependent/Letters.t 5) Sign off. Note: the claim messages are recorded in the logs in the *Acquisitions* module, not the Letters module as you might expect This patch also fixes several perlcritic violations and centralizes contact-related unit testing in Bookseller.t. Signed-off-by: Paola Rossi paola.ro...@cineca.it Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10402] Add multiple contacts for vendors
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402 --- Comment #92 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 31092 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31092action=edit Bug 10402: Move contacts to separate table This patch normalizes the data structures used for bookseller contacts. To test: 1) Repeat tests described on previous patch. Signed-off-by: Owen Leonard oleon...@myacpl.org Signed-off-by: Jared Camins-Esakov jcam...@cpbibliography.com Signed-off-by: Paola Rossi paola.ro...@cineca.it Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10402] Add multiple contacts for vendors
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402 --- Comment #96 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 31096 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31096action=edit Bug 10402: FIX conflicts in Letters.t Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10402] Add multiple contacts for vendors
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Passed QA QA Contact||jonathan.dru...@biblibre.co ||m --- Comment #97 from Jonathan Druart jonathan.dru...@biblibre.com --- QA comment: not blocker: On a editing a supplier with 1 contact, the Delete contact button will remove the contact form. It is not blocker since you can click on the add contact to add another contact. Still in master: 1/ The letter generated contains the order/order tags. 2/ The validation on claiming serials does not work (no warning/error/ok message on sending the emails). This should be done with bug 5342 (pending for 2 years...). No regression found, all works as expected. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12776] Capitalization: confirmation messages in circulation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12776 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12669] Template process failed: undef error - Invalid local time for date in time zone
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12669 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added CC||jonathan.dru...@biblibre.co ||m Assignee|koha-b...@lists.koha-commun |rolando.isid...@gmail.com |ity.org | Severity|normal |major -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12776] Capitalization: confirmation messages in circulation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12776 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||tomasco...@gmail.com --- Comment #4 from Tomás Cohen Arazi tomasco...@gmail.com --- Patch pushed to master. Thanks Katrina! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12576] search links need style id
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12576 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||tomasco...@gmail.com --- Comment #8 from Tomás Cohen Arazi tomasco...@gmail.com --- Patches pushed to master. Thanks Sean! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12669] Template process failed: undef error - Invalid local time for date in time zone
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12669
--- Comment #9 from Jonathan Druart jonathan.dru...@biblibre.com ---
I am not sure this is the right way to fix it.
For instance, in Paris the DST is at 2:
perl -MDateTime -E'say DateTime-new(year = 2014, month = 9, day = 7, hour
= 0, time_zone = America/Santiago);';
Invalid local time for date in time zone: America/Santiago
perl -MDateTime -E'say DateTime-new(year = 2014, month = 3, day = 30, hour
= 2, time_zone = Europe/Paris);';
Invalid local time for date in time zone: Europe/Paris
perl -MDateTime -E'say DateTime-new(year = 2014, month = 3, day = 30,
time_zone = Europe/Paris);';
2014-03-30T00:00:00
The DateTime doc mentions This may change in future version of this module.
http://search.cpan.org/~drolsky/DateTime-1.10/lib/DateTime.pm#Invalid_Local_Times
What about something like:
my $dt = eval { DateTime-new($params) };
if ( $@ ) {
$params-{hours}++;
$dt = Datetime-new($params);
}
?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12545] Add EditorConfig file to the source tree
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12545 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #6 from Tomás Cohen Arazi tomasco...@gmail.com --- Patch pushed to master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12743] Allow default values from the ACQ framework to be used when creating a record in acquisitions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12743 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #31028|0 |1 is obsolete|| CC||k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12743] Allow default values from the ACQ framework to be used when creating a record in acquisitions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12743 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12743] Allow default values from the ACQ framework to be used when creating a record in acquisitions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12743 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #31090|0 |1 is obsolete|| --- Comment #4 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 31098 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31098action=edit [PASSED QA] Bug 12743: ACQ: default values for catalogue records At the moment, it is possible to create records in acquisitions, but the ACQ framework is only used for items created in this module. This patch allows to defined default values in the ACQ framework for records created on the acquisition module. Test plan: 1/ Make sure you have the ACQ framework created (otherwise create it from the default framework). 2/ Define a default value for a field (for instance 099$z=1). 3/ Go in the acquisition module and create a new order from a new record. 4/ Fill mandatory information and save. 5/ Go on the detail page of this record and verify the default value exist. Signed-off-by: Gaetan Boisson gaetan.bois...@biblibre.com Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12176] Remove HTML from additem.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12176 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Failed QA CC||jonathan.dru...@biblibre.co ||m --- Comment #4 from Jonathan Druart jonathan.dru...@biblibre.com --- My 995$e is mapped to the a AV and I got the following dropdown list: option value=Langues étrangères/option option value=AdosAdos/option option value=AlbumAlbum/option option value=BD adulteBD adulte/option option value=BD enfantBD enfant/option option value=BureauBureau/option option value=Cédéroms adulte/option option value=Cédéroms enfant/option option value=ContesContes/option etc. When the description contains a diacritic, the option is empty. Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8337] System preferences for longoverdue cron
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8337 --- Comment #15 from Jonathan Druart jonathan.dru...@biblibre.com --- I don't understand the usefulness of these 3 sysprefs. I know everybody loves sysprefs but do you have another argument? The longoverdue script is a cronjob and if you want to call this script with default parameters you just have to set them in the crontab. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11633] Cannot use the override function AllowFineOverride on the Staff client because this stops the pay function working on the SelfCheck (SC) machines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11633 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #30731|0 |1 is obsolete|| Attachment #30732|0 |1 is obsolete|| --- Comment #7 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 31099 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31099action=edit [PASSED QA] Bug 11633 : Block Issue if fines require staff override If a patrons fines exceed noissuescharge and we allow staff to allow issue at their discretion via an override the SIP process allowed charges to go ahead. This patch closes the loophole which allowed self issue to subvert the usual library loan policy Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11633] Cannot use the override function AllowFineOverride on the Staff client because this stops the pay function working on the SelfCheck (SC) machines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11633 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11633] Cannot use the override function AllowFineOverride on the Staff client because this stops the pay function working on the SelfCheck (SC) machines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11633 --- Comment #8 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 31100 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31100action=edit [PASSED QA] Bug 11633 Return Correct status if patron blocked by fines If the patron has amassed charges that block borrowing, but we allow staff override the information that the patron cannot issue should be included the patron information response This patch sets the appropriate status fields in the patron object It restores the fee_limit member to the patron object and calls a local subroutine to set it. This could be done more elegantly but that would require more major refactoring of the rather messy initializer code in ILS::Patron Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8337] System preferences for longoverdue cron
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8337 --- Comment #16 from Blou philippe.blo...@inlibro.com --- These prefs are the whole objective of this patch: allow the librarian to set things up without having to rely on IT people. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 --- Comment #13 from Kyle M Hall k...@bywatersolutions.com --- (In reply to Jonathan Druart from comment #12) Kyle, I am sorry but this patch c/p almost all the code from tools/import_borrowers.pl. I am not sure this is the right way to do. That is why my initial patch allowed the existing tools/import_borrowers.pl script to be used from the command line. However, I was told that is no longer allowed ( tools/export.pl has this behavior ), though it is not stated in the coding guidelines. The script should also use Pod2Usage (instead of the print_help routine). Is this in the coding guidelines? I am completely aware of the quantity of work to provide to reach a correct quality of core here: refactoring, unit tests, etc. Not sure why this would be required for code we already know works... While I agree in general, this is proven code, and your proposal would add an order of magnitude to the development with no real gains. I would much prefer we allow tools/import_borrowers.pl to be used from the command line for this exact reason. But I am pretty sure this script should not be pushed as it. I would respectfully disagree ; ) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8337] System preferences for longoverdue cron
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8337 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl --- Comment #17 from M. de Rooy m.de.r...@rijksmuseum.nl --- (In reply to Blou from comment #16) These prefs are the whole objective of this patch: allow the librarian to set things up without having to rely on IT people. If we increase the number of sysprefs, we may end up relying even more on IT people :) Looking at your argument, I would agree with Jonathan: You only have to put the correct arguments once (or very incidentally) in your crontab. No need for extra sysprefs. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12800] Can't access MARC bibliographic frameworks and other pages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12800 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12800] Can't access MARC bibliographic frameworks and other pages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12800 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #31067|0 |1 is obsolete|| --- Comment #7 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 31101 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31101action=edit [PASSED QA] Bug 12800: running unit tests that use Koha::Cache breaks cache usage from Apache If the user runs: $ prove t/Cache.t with it's system user, two situations can happen: 1) If MEMCACHED_NAMESPACE is set on koha-httpd.xml other than the default 'koha', then Apache sets /tmp/sharefile-koha-namespace and the problem is not present: running the test creates /tmp/sharefile-koha-koha != /tmp/sharefile-koha-namespace = SUCCESS: no problem 2) If MEMCACHED_NAMESPACE is not set (or eq 'koha'), then there is a permission problem either running the unit tests, or when using any funcitonality on the UI that needs Koha::Cache. Explanation: the one that is run first will set the /tmp/sharefile-koha-koha ownership so it will be either the dev's sys user, or www-data (or whatever apache is using). This patch sets a namespace for the unit tests, so there is no collision. To test: - On your dev setup, having MEMCACHED_NAMESPACE unset on koha-httpd.conf - Edit a marc framework. If it fails, remove /tmp/sharefile-koha-koha, and try again - fixed. Now try running $ prove t/Cache.t = FAIL: test fails because of permission problem - Apply the patch - Re-run the test = SUCCESS: test passes Try changing the order, etc. The temporary file that is used is deleted after the tests are run. Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Chris Cormack chr...@catalyst.net.nz Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8337] System preferences for longoverdue cron
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8337 --- Comment #18 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to Blou from comment #16) These prefs are the whole objective of this patch: allow the librarian to set things up without having to rely on IT people. 1 new pref for every argument of each script in misc/cronjob, outch :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 --- Comment #14 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to Kyle M Hall from comment #13) That is why my initial patch allowed the existing tools/import_borrowers.pl script to be used from the command line. However, I was told that is no longer allowed ( tools/export.pl has this behavior ), though it is not stated in the coding guidelines. We all know it's a very bad idea. tools/export.pl is the perfect example, it's a pain to maintain it. The script should also use Pod2Usage (instead of the print_help routine). Is this in the coding guidelines? I don't know, all new scripts in misc use Pod2Usage. I think it's a good way to follow, don't you think? I am completely aware of the quantity of work to provide to reach a correct quality of core here: refactoring, unit tests, etc. Not sure why this would be required for code we already know works... If the code is moved to a new subroutine, it will require to be covered by UT. While I agree in general, this is proven code, and your proposal would add an order of magnitude to the development with no real gains. I would much prefer we allow tools/import_borrowers.pl to be used from the command line for this exact reason. The gain is the maintainability (this word exist?) of the code. In the current state, the code is duplicated. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12808] remove useless diags from t/db_dependent/Context.t
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12808 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12808] remove useless diags from t/db_dependent/Context.t
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12808 --- Comment #1 from Tomás Cohen Arazi tomasco...@gmail.com --- Created attachment 31102 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31102action=edit Bug 12808: remove useless diags from t/db_dependent/Context.t Sponsored-by: Universidad Nacional de Cordoba -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11714] GetBudgetHierarchy needs optimization
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11714 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #30942|0 |1 is obsolete|| Attachment #30943|0 |1 is obsolete|| --- Comment #14 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 31103 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31103action=edit [PASSED QA] Bug 11714 - GetBudgetHierarchy needs optimization The method C4::Budgets::GetBudgetHierarchy() retreives from database budgets in an array containing a tree of budgets (parent - children - children, ...). The code generating this tree with the SQL results needs optimization because when a lot of budgets exists, it can run during several minutes. This patch rewites the code using a recurive method. Test plan : - Create a active budget MyBudget with 1000 - Click Add found on this budget - Create a found Parent with 1000, set you has owner - Click Add child found on found Parent - Create a found Child with 100, set you has owner - Click Add child found on found Child - Create a found Grand-child with 10, set you has owner | - Create a new acquisition basket - Add a new order with Child budget - Select Child found and set all costs to 2 - Save order - Add a new order with Grand-Child budget - Select Child found and set all costs to 2 - Save order - Close basket - Perform the receive of the two orders | - Go to founds of MyBudget = You see a table with 3 founds - in Fund filters, select no library and uncheck Show my funds only and click on Go = You see a table with Parent found - Click on small arrow left of the fund code of Parent = You see a new line with Child found - Click on small arrow left of the fund code of Child = You see a new line with Grand-Child found | = You see in Grand-Child row Base-level spent = 2 and Total sublevels spent = 2 = You see in Child row Base-level spent = 2 and Total sublevels spent = 4 This confirms the founds are used in a hierarchie. Signed-off-by: Paola Rossi paola.ro...@cineca.it Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11714] GetBudgetHierarchy needs optimization
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11714 --- Comment #15 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 31104 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31104action=edit [PASSED QA] Bug 11714: A fund is a top-level fund if it does not have any parent Signed-off-by: Paola Rossi paola.ro...@cineca.it Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8337] System preferences for longoverdue cron
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8337 Anthony Laquerre anthony.laque...@ccsr.qc.ca changed: What|Removed |Added CC||anthony.laque...@ccsr.qc.ca --- Comment #19 from Anthony Laquerre anthony.laque...@ccsr.qc.ca --- I jump in the conversation since we are the schools consortia that initially create the ticket. In a context of school library systems such preferences are likely to change on average 2-3 times per year. Unfortulalty, many library does not have the money available to make requests for changes to IT company. Unlike Jonathan, I beleive that each cronjob parameter useful for the end user should be in the sys pref table. This allows the librarian to make his own choix and not always having to go through a process of change by the IT provider. I understand that right now there is a lot of parameters but this is also one the of biggest strenght of Koha ! Hard to start but once you understand how every sys pref work you can do anything you want. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11714] GetBudgetHierarchy needs optimization
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11714 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12808] New: remove useless diags from t/db_dependent/Context.t
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12808 Bug ID: 12808 Summary: remove useless diags from t/db_dependent/Context.t Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: tomasco...@gmail.com QA Contact: testo...@bugs.koha-community.org There's no need to print to stdout from the test script. Those diags should be preserved as comments. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12809] New: Failures in Koha notifications systems
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12809 Bug ID: 12809 Summary: Failures in Koha notifications systems Change sponsored?: --- Product: Koha Version: 3.16 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: fred.pie...@smfpl.org QA Contact: testo...@bugs.koha-community.org Created attachment 31105 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31105action=edit There are too many unrealistic letter and delay combinations. The Koha notifications system has four main components: 1. A message_transport_type for each notification method 2. A letter or notice for each of the message_transports 3. A delay and letter selection process for overdue actions. 4. The option of EnhancedMessagingPreferences allowing patrons and staff to define specific patron notifications. In the staff interface, we refer to defined letters both as notices and sometimes as letters. Overdue notices get a separate interface, allowing three letters to be selected to send. Creating a single framework for pre-due and overdue notifications would simplify the process of configuring specific patron settings. Goals for improvement should include: 1. Define a more consistent notifications failover chain - either user-defined or pre-set to SMS Email Phone Print Notice. Consider points #4 and #5 below - how is this affected when we add a new message_transport_type, or if we combine all notifications into one framework? A numeric priority should be set for the message_transport_type, and should failover in that order. Adding a new message_transport_type would force re-sequencing of those priorities. 2. Combine SMS number (Patron Messaging Preferences) with patron's mobile phone number. I can't imagine these would ever be different in practice. Instead of requiring a separate SMS number to be defined, we should simply use the patron messaging preference's SMS checkbox to select SMS messaging to the mobile number. At the very least the mobile number should populate the SMS field, because there is no way to define the SMS number through the New Patron memberentry.pl script. 3. Allow Days in Advance to function for Advance notices, by enabling user to activate the takes_days flag in the message_attributes table. 4. The letter selection process in overduerules.pl is extremely flawed. For example, you can set a delay on an advance notice, but it in practice, this doesn't function the way you would logically expect. We need to combine pre-due and overdue notifications, perhaps by using a negative days in advance value, or a days before and days after pull-down. Combining pre-due and overdue notices will reduce confusion both in the user interface and in the batch processing of notifications. We already define all notices or letters through a single letter.pl script. We should also implement one process to send out both pre-due and overdue notifications, and one interface to specify every outgoing message, with a goal of simplicity and de-duplication of function. 5. Allow new notification methods to be defined in the message_transport_type table. For example, we should be able to tag specific patrons for automated phone calling through I-Tiva with a user-defined Itiva message_transport_type. Thank for considering these idea! I may be missing different use cases, but I can see clear advantages to streamlining and combining the notifications processes. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12809] Failures in Koha notifications systems
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12809 Fred P fred.pie...@smfpl.org changed: What|Removed |Added Severity|enhancement |major -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12632] Hold limits ignored for record level holds with item level itemtypes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12632 --- Comment #2 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 31106 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31106action=edit Bug 12632 - Hold limits ignored for record level holds with item level itemtypes The crux of the issue is that if you are using item level itemtypes, but are allowing biblio levels holds, those holds do not have items. So, in CanItemBeReserved, when Koha counts the number of holds to compare against the given rule, it will always give 0 ( except of course for found holds, and the occasional item-level hold ). So the query is saying link each of these reserves to the reserved item, and count the number of reserves this patron where the itemtype is DVD. However, since these are all record level reserves, there are no items to link to, and so when it looks for all reserves this and item whose itemtype is DVD, it finds zero reserves! This patch solves the problem by looking first at the item level itemtype, and if it does not exist, then it looks at the record level itemtype. Since Koha installations using record-level itemtypes will not have item-level itemtypes, it will fall back to record-level itemtypes gracefully. Test plan: 1) Enable item level itemtypes 2) Create two records with one item each of a given itemtype 3) Create a single issuing rule and limit the holds allowed for that itemtype to 1 4) Place a record level hold on your first record 5) Attempt to place a record level hold for the same patron on your second record. You should not be able to but you can! 6) Apply this patch 7) Repeat step 5, note you can no longer place the hold! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12632] Hold limits ignored for record level holds with item level itemtypes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12632 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12632] Hold limits ignored for record level holds with item level itemtypes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12632 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12632] Hold limits ignored for record level holds with item level itemtypes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12632 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #31106|0 |1 is obsolete|| --- Comment #3 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 31107 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31107action=edit Bug 12632 - Hold limits ignored for record level holds with item level itemtypes The crux of the issue is that if you are using item level itemtypes, but are allowing biblio levels holds, those holds do not have items. So, in CanItemBeReserved, when Koha counts the number of holds to compare against the given rule, it will always give 0 ( except of course for found holds, and the occasional item-level hold ). So the query is saying link each of these reserves to the reserved item, and count the number of reserves this patron where the itemtype is DVD. However, since these are all record level reserves, there are no items to link to, and so when it looks for all reserves this and item whose itemtype is DVD, it finds zero reserves! This patch solves the problem by looking first at the item level itemtype, and if it does not exist, then it looks at the record level itemtype. For installations using record level itemtypes, the behavior remains unchanged. Test plan: 1) Enable item level itemtypes 2) Create two records with one item each of a given itemtype 3) Create a single issuing rule and limit the holds allowed for that itemtype to 1 4) Place a record level hold on your first record 5) Attempt to place a record level hold for the same patron on your second record. You should not be able to but you can! 6) Apply this patch 7) Repeat step 5, note you can no longer place the hold! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7143] Bug for tracking changes to the about page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 --- Comment #160 from Tomás Cohen Arazi tomasco...@gmail.com --- Created attachment 31108 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31108action=edit Bug 7143: Full 3.18 release team acknowledged Signed-off-by: Tomas Cohen Arazi tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7143] Bug for tracking changes to the about page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 --- Comment #161 from Tomás Cohen Arazi tomasco...@gmail.com --- Created attachment 31109 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31109action=edit Bug 7143: Ohloh is now Open HUB Ohloh.net links are used in the about page. Their FQDN has changed a while ago. Old one is still redirected, but we need to fix it just in case the redirection is removed. Signed-off-by: Tomas Cohen Arazi tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7143] Bug for tracking changes to the about page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 --- Comment #162 from Tomás Cohen Arazi tomasco...@gmail.com --- Created attachment 31110 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31110action=edit Bug 7143: Universidad Nacional de Cordoba is an institution that contributed to Koha Signed-off-by: Tomas Cohen Arazi tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7143] Bug for tracking changes to the about page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 --- Comment #163 from Tomás Cohen Arazi tomasco...@gmail.com --- Created attachment 3 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3action=edit Bug 7143: update the es-ES translation attribution as of 3.12 onwards The currently maintained stable releases translations are/were done by the following individuals and it should be acknowledged in the about page. This patch also removes the venezuelian spanish translation, that was removed long time ago. Signed-off-by: Tomas Cohen Arazi tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7143] Bug for tracking changes to the about page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10060] Self Checkout module does not honour circ control
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10060 jdem...@roseville.ca.us jdem...@roseville.ca.us changed: What|Removed |Added CC||jdem...@roseville.ca.us -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8446] Shibboleth authentication patch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 --- Comment #91 from Zeno Tajoli z.taj...@cineca.it --- There is a site that seems useful to test the patch: http://testshib.org/index.html But is not clear to me if it is possible to use it as IdP and my Koha install as Service Provider. For example, do you undestand how to create a user/pwd in the IdP of http://testshib.org/ ? Probably it is possible to use also this test service: https://openidp.feide.no/. But probably is better to be Norse. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12796] Default Messaging Preferences not Applied
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12796 Fred P fred.pie...@smfpl.org changed: What|Removed |Added CC||fred.pie...@smfpl.org --- Comment #1 from Fred P fred.pie...@smfpl.org --- This may be the intended functionality. Activating the Enhanced Messaging Preferences allows patrons to select their messaging preferences. Changing their category should not necessarily change their selected preferences. Koha 3.16 behaves as you describe, however when creating a new patron, the correct default messaging preferences are correctly applied. It is only on a change of category that this problem manifests. The solution might be a system preference to override patron messaging preferences on category change or something to that effect. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12810] New: After MTT gather_print_notices includes overdues
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12810 Bug ID: 12810 Summary: After MTT gather_print_notices includes overdues Change sponsored?: --- Product: Koha Version: 3.16 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: la...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org After the inclusion of MTT in 3.16, the gather_print_notices is no longer restricted to print holds notices; it now also includes the print overdues as well. I have not tested, but suspect it would now include any notice with transport type of 'print'. There are a couple of options for dealing with this. 1) If this is the new post-MTT *intended* behavior, then the documentation should be updated to reflect the broader coverage of gather_print_notices, and the output file should no longer start with 'holdnotices-', but should be something more generic, e.g. 'notices-'. Optionally, could modify cronjob to split notices into files reflecting their type, e.g. 'holdnotices-', 'overduenotices-', 'preduenotices-', etc. 2) Revert the script back to only dealing with holds notices. There are currently bugs in place to address the issue of print overdues no longer being emailed to the library, as well as a bug to allow gather_print_notices to email the output file. This bug fix should take work on those bugs into consideration. - Larry -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
