[Koha-bugs] [Bug 3186] invalid or uninstalled SMSSendDriver (or bad number format) causes process_message_queue to fail

2014-10-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3186

--- Comment #9 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi ---
Must be my lucky week!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11211] Move calculation code out of C4::Calendar

2014-10-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11211

--- Comment #21 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Working on this now.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11211] Move calculation code out of C4::Calendar

2014-10-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11211

--- Comment #22 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Ok, some first findings, noting here, I will keep testing, but please fix:

 FAILkoha-tmpl/intranet-tmpl/prog/en/modules/tools/calendar.tt
   OK  forbidden patterns
   OK  tt_valid
   FAIL  valid_template
JavaScript: plugin not found
 FAILtools/calendar.pl
   OK  critic
   FAIL  forbidden patterns
forbidden pattern: You should not use a .tmpl extension for the
template name (see bug 11349) (line 35)
   OK  pod
   OK  valid

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8133] hourly loans doesn't know when library closed

2014-10-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8133

--- Comment #23 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Running first tests on top of 11211, please fix and make sure both still apply
on top of each other:

FAILtools/calendar.pl
   OK  critic
   FAIL  forbidden patterns
forbidden pattern: You should not use a .tmpl extension for the
template name (see bug 11349) (line 35)
   OK  pod
   FAIL  valid
given is experimental 
when is experimental

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11211] Move calculation code out of C4::Calendar

2014-10-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11211

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #23 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Hm, I can't keep testing this, because when I get to the calendar tool page, I
have a perl error blocking my way:
Template process failed: file error -
/home/katrin/kohaclone/koha-tmpl/intranet-tmpl///modules/tools/calendar.tmpl:
not found at /home/katrin/kohaclone/C4/Templates.pm line 127.

The same still happens with 8133 appied on top. 

Please fix, I can continue testing tonight. I will probably be testing both
bugs together, please make sure 8133 still applies with a follow-up here!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8133] hourly loans doesn't know when library closed

2014-10-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8133

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Signed Off  |BLOCKED

--- Comment #24 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Blocked by 11211 being failed QA right now.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7673] New patron permissions to manage items (edit, batchmod, delete all)

2014-10-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

  Attachment #32928|0   |1
is obsolete||

--- Comment #109 from Chris Cormack ch...@bigballofwax.co.nz ---
Created attachment 32962
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32962action=edit
Bug 7673 [Terminology follow-up] New patron permissions to manage items

This bug adds a new preference, SubfieldsToAllowForRestrictedEdition,
but the use of the term Edition in this context is incorrect. I think
it would be more clear to change the preference name to
SubfieldsToAllowForRestrictedEditing. This patch makes this change.

I realize this isn't a big issue since the preference has a good
description, but I thought that if we were going to make this as clear
as possible now would be the time to do it.

To test, start with a database which hasn't previously been used to test
Bug 7673. Apply all patches and run the database update. Follow the test
plan as described in the bug.

Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7673] New patron permissions to manage items (edit, batchmod, delete all)

2014-10-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13164] Incorrect ISSN visualization on the normal view if invalid/cancelled ISSN present

2014-10-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13164

Frédéric Demians frede...@tamil.fr changed:

   What|Removed |Added

  Attachment #32939|0   |1
is obsolete||

--- Comment #2 from Frédéric Demians frede...@tamil.fr ---
Created attachment 32963
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32963action=edit
Bug 13164: Incorrect ISSN visualization on the normal view if invalid/cancelled
ISSN present

Currently, 022$z (and 011$z for UNIMARC) occurences are not shown, but the XSLT
logic used introduces punctuation characters for those $z occurences.

This patch adds a check for the existence of subfield a, and only loops
on $a subfields.

To test:
- Create/have a record with 022$z (or 011$z on UNIMARC) but no 022$a (no 011$a
on UNIMARC).
- Open the detail page for the record (on both OPAC and staff).
= FAIL: the ISSN label and ';' and '.' characters incorrectly shown.
- Repeat mixing with 022$a occurences to notice the bug.
- Apply the patch, reload
= SUCCES: ISSN label shows only on the presence of a $a, and $z are skipped.
   no matter how many ISSN fields you add.
- Sign off :-D

Regards
To+

Signed-off-by: Frederic Demians f.demi...@tamil.fr

Works as described on an UNIMARC DB. Mimics what's done for ISBN field.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13164] Incorrect ISSN visualization on the normal view if invalid/cancelled ISSN present

2014-10-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13164

Frédéric Demians frede...@tamil.fr changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13163] Duplicate records in Zebra after editing NORMARC records with DOM

2014-10-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13163

Frédéric Demians frede...@tamil.fr changed:

   What|Removed |Added

  Attachment #32937|0   |1
is obsolete||

--- Comment #2 from Frédéric Demians frede...@tamil.fr ---
Created attachment 32964
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32964action=edit
Bug 13163: NORMARC DOM config missing id entry

This patch fixes the biblio-koha-indexdefs.xml for NORMARC, so
it includes the id element.

Because of how our DOM files work, the resulting biblio-zebra-indexdefs.xsl
for NORMARC picked the whole MARC record as ID, so every time the record
was edited, the id wouldn't match and a new record was created.

To test:
- Have a MARCXML record
- run:
  $ xsltproc etc/zebradb/marc_defs/normarc/biblios/biblio-zebra-indexdefs.xsl
the_record | less
= FAIL: verify the z:id property on the z:record line contains all subfields
concatenated
- Apply the patch
- re-run the xsltproc line
= SUCCESS: z:id contains the 999$c number
- Sign off :-D

Regards

Signed-off-by: Frederic Demians f.demi...@tamil.fr

Known bug with DOM: Without z:id indexing biblionumber Zebra hasn't it record
unique ID, and so fails to identify existing records. Works as described. 999$c
is linked to biblionumber in default Normarc framework.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13163] Duplicate records in Zebra after editing NORMARC records with DOM

2014-10-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13163

Frédéric Demians frede...@tamil.fr changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13166] add all restrictions purge to cleanup_database.pl

2014-10-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13166

Fridolin SOMERS fridolyn.som...@biblibre.com changed:

   What|Removed |Added

 Depends on||12760

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12760] add restrictions purge to cleanup_database.pl

2014-10-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12760

Fridolin SOMERS fridolyn.som...@biblibre.com changed:

   What|Removed |Added

 Blocks||13166

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13166] New: add all restrictions purge to cleanup_database.pl

2014-10-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13166

Bug ID: 13166
   Summary: add all restrictions purge to cleanup_database.pl
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Command-line Utilities
  Assignee: gmcha...@gmail.com
  Reporter: fridolyn.som...@biblibre.com
QA Contact: testo...@bugs.koha-community.org

Bug 12760 adds the ability to purge expired restrictions older than some days.

But if you want to purge all expired restrictions, using --restrictions 0
does not work, its like --restrictions so it uses default purge days.

I propose to add a new option --all-restrictions to purge all expired
restrictions.

This feature is asked by one of our libraries.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13159] Enhancements to the SIP2 command line emulator

2014-10-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13159

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #32924|0   |1
is obsolete||

--- Comment #5 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 32965
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32965action=edit
Bug 13159 - Enhancements to the SIP2 command line emulator

I needed to be able to perform checkout operations for testing from the
command line. I ended up reengineering the SIP2 command line tester
quite a bit.

Enhancements:
* Moved message generation code to subroutines
* Added checkout message support
* Added command line switches for each supported message
* Enabled use of Sip::Constants to keep code DRY and more understandable
* Moved script from misc to C4/SIP
* Designed with an eye towards possibly moving some code to CPAN in the future
* Also designed to make adding new messages much easier in the future

Test Plan:
1) Apply this patch
2) Look at help via ./C4/SIP/sip_cli_emulator.pl --help
3) Test patron status request and patron information, should work as before
   except you need to pass the command line switche -m message_name
4) Test the new checkout option using -m checkout -i item barcode

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13159] Enhancements to the SIP2 command line emulator

2014-10-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13159

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #32965|0   |1
is obsolete||

--- Comment #6 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 32966
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32966action=edit
Fixed typo in help

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13166] add all restrictions purge to cleanup_database.pl

2014-10-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13166

Fridolin SOMERS fridolyn.som...@biblibre.com changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |fridolyn.som...@biblibre.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13163] Duplicate records in Zebra after editing NORMARC records with DOM

2014-10-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13163

Magnus Enger mag...@enger.priv.no changed:

   What|Removed |Added

  Attachment #32964|0   |1
is obsolete||

--- Comment #3 from Magnus Enger mag...@enger.priv.no ---
Created attachment 32967
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32967action=edit
Bug 13163: NORMARC DOM config missing id entry

This patch fixes the biblio-koha-indexdefs.xml for NORMARC, so
it includes the id element.

Because of how our DOM files work, the resulting biblio-zebra-indexdefs.xsl
for NORMARC picked the whole MARC record as ID, so every time the record
was edited, the id wouldn't match and a new record was created.

To test:
- Have a MARCXML record
- run:
  $ xsltproc etc/zebradb/marc_defs/normarc/biblios/biblio-zebra-indexdefs.xsl
the_record | less
= FAIL: verify the z:id property on the z:record line contains all subfields
concatenated
- Apply the patch
- re-run the xsltproc line
= SUCCESS: z:id contains the 999$c number
- Sign off :-D

Regards

Signed-off-by: Frederic Demians f.demi...@tamil.fr

Known bug with DOM: Without z:id indexing biblionumber Zebra hasn't it record
unique ID, and so fails to identify existing records. Works as described. 999$c
is linked to biblionumber in default Normarc framework.

Signed-off-by: Magnus Enger mag...@enger.priv.no

I have applied the patch to my production server, and at least one customer has
confirmed that it fixes the problem with multiple copies of records in search
results.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13166] add all restrictions purge to cleanup_database.pl

2014-10-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13166

--- Comment #1 from Fridolin SOMERS fridolyn.som...@biblibre.com ---
Created attachment 32968
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32968action=edit
Bug 13166 - add all restrictions purge to cleanup_database.pl

Bug 12760 adds the ability to purge expired restrictions older than some days.

But if you want to purge all expired restrictions, using --restrictions 0
does not work, it's like --restrictions so it uses default purge days.

This patch adds a new option --all-restrictions to purge all expired
restrictions.

Test plan :
- Select a borrower
- Create a restriction with expiration date in the futur
- Create a restriction expired since 1 day
- Create a restriction expired since 10 days
- run without argument misc/cronjobs/cleanup_database.pl
= You see help text for --all-restrictions option
- run misc/cronjobs/cleanup_database.pl -v --restrictions --all-restrictions
= You get the message : You can not specify both --restrictions and
--all-restrictions
- run misc/cronjobs/cleanup_database.pl -v --restrictions 30
= no restriction is removed
- run misc/cronjobs/cleanup_database.pl -v --restrictions 9
= restriction expired since 10 days is removed
- run misc/cronjobs/cleanup_database.pl -v --all-restrictions
= restriction expired since 1 day is removed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13166] add all restrictions purge to cleanup_database.pl

2014-10-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13166

Fridolin SOMERS fridolyn.som...@biblibre.com changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13096] Send account notice with login details in more situations

2014-10-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13096

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

Summary|Send an ACCTDETAILS notice  |Send account notice with
   |when staff changes user or  |login details in more
   |password or ?   |situations

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13167] New: Stage MARC for Import hangs

2014-10-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13167

Bug ID: 13167
   Summary: Stage MARC for Import hangs
 Change sponsored?: ---
   Product: Koha
   Version: 3.16
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Tools
  Assignee: gmcha...@gmail.com
  Reporter: tiburce.euphra...@aupaysdescrevettes.org
QA Contact: testo...@bugs.koha-community.org

Created attachment 32969
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32969action=edit
Zip contains 2 UNIMARC ISO-8859-1 records + a scan of the ISBN on the original
book

Aloha,
I have detected un problem while trying to import a large set of UNIMARC
records.
I tried with a Koha 3.16.01 and a Koha 3.16.03, same issue :

If the ISBN of a UNIMARC record begins with 979 then the 'Stage MARC for
import' hangs.
If I use the same UNIMARC record and change 979 to 978 in the ISBN, 'Stage MARC
for import' works perfectly.

You can find 2 UNIMARC Records (ISO8859-1) in the attachment if you wish to
make tests by yourself (same records, one with ISBN 979-..., one with ISBN
978-...).

I think I've also detected a small problem in
cataloguing::value_builder::unimarc_field_010 :
[...] Line 94 to 96 :
if (length ($isbn) == 13){
$isbn = substr($isbn, 3, length($isbn)-3);
}
[...] Then, line 143 :
$sth-execute($seg2, 978$seg2);

This 978 on line 143 is hard-coded and there's no relation with the original
data inside $isbn. I don't know if this is a real problem but it might be
better to keep the original data than replacing it with 978.
Aloha.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12347] Search performance improvements

2014-10-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12347

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

 Status|In Discussion   |RESOLVED
 Resolution|--- |INVALID

--- Comment #7 from Tomás Cohen Arazi tomasco...@gmail.com ---
I think this bug should be closed, and more precise ones should be filled,
like:

We shouldn't create MARC::Record objects out of MARCXML, use the XSLTs
instead

The bug title is also wrong, as it sounds like an omnibus bug instead of a real
one. I'm closing it, so we fill new ones for specific things we could improve
(because I agree with Frederic).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12944] There is no way to search orders by creator

2014-10-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12944

--- Comment #11 from Paola Rossi paola.ro...@cineca.it ---
NB. On patron list, there is a little redundancy in the removing patrons'
options.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13168] New: Today's checkouts sort improperly because issuedate lacks seconds.

2014-10-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13168

Bug ID: 13168
   Summary: Today's checkouts sort improperly because issuedate
lacks seconds.
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: olli-antti.kivila...@jns.fi
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

TO REPLICATE:

Prepare a bunch of Items (6+) for checking out, or have a set of barcodes ready
for copy-pasting.
Check-out those items quickly within one minute and observe that the sorting
order is not always from the first checkout to the last.

This is because the issuedate doesn't have seconds defined.

AFTER THIS

The bunch of Items is sorted properly.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13168] Today's checkouts sort improperly because issuedate lacks seconds.

2014-10-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13168

Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed:

   What|Removed |Added

 Depends on||11703

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable

2014-10-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703

Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed:

   What|Removed |Added

 Blocks||13168

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13168] Today's checkouts sort improperly because issuedate lacks seconds.

2014-10-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13168

--- Comment #1 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi ---
Created attachment 32970
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32970action=edit
Bug 13168 - Today's checkouts sort improperly because issuedate lacks
seconds.

TO REPLICATE:

Prepare a bunch of Items (6+) for checking out, or have a set of barcodes ready
for copy-pasting.
Check-out those items quickly within one minute and observe that the sorting
order is not always from the first checkout to the last.

This is because the issuedate doesn't have seconds defined.

AFTER THIS

The bunch of Items is sorted properly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13168] Today's checkouts sort improperly because issuedate lacks seconds.

2014-10-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13168

Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13166] add all restrictions purge to cleanup_database.pl

2014-10-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13166

Fridolin SOMERS fridolyn.som...@biblibre.com changed:

   What|Removed |Added

  Attachment #32968|0   |1
is obsolete||

--- Comment #2 from Fridolin SOMERS fridolyn.som...@biblibre.com ---
Created attachment 32971
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32971action=edit
Bug 13166 - add all restrictions purge to cleanup_database.pl

Bug 12760 adds the ability to purge expired restrictions older than some days.

But if you want to purge all expired restrictions, using --restrictions 0
does not work, it's like --restrictions so it uses default purge days.

This patch adds a new option --all-restrictions to purge all expired
restrictions.

Test plan :
- Select a borrower
- Create a restriction with expiration date in the futur
- Create a restriction expired since 1 day
- Create a restriction expired since 10 days
- run without argument misc/cronjobs/cleanup_database.pl
= You see help text for --all-restrictions option
- run misc/cronjobs/cleanup_database.pl -v --restrictions --all-restrictions
= You get the message : You can not specify both --restrictions and
--all-restrictions
- run misc/cronjobs/cleanup_database.pl -v --restrictions 30
= no restriction is removed
- run misc/cronjobs/cleanup_database.pl -v --restrictions 9
= restriction expired since 10 days is removed
- run misc/cronjobs/cleanup_database.pl -v --all-restrictions
= restriction expired since 1 day is removed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12258] Datatable in Patrons Account Fines

2014-10-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12258

--- Comment #5 from Owen Leonard oleon...@myacpl.org ---
Created attachment 32972
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32972action=edit
Bug 12258 [Template follow-up] Datatable in Patrons Account Fines

This follow-up corrects some of the QA issues affecting the other patch,
as well as changing the way the filter option is displayed:

- Added the use of the DataTables include file
- Removed redundant document.ready
- Fixed single quotes
- Fixed default sort (should be date descending to match the current
  functionality)
- Adding missing tr
- Converted filter button to a link

The last change is a judgement call, but the button in the DataTables
toolbar looked awkward and caused ugly wrapping at narrower viewport
sizes. I think a link is more keeping with the pattern established by
select all / clear all links.

To test, apply both patches and view the account page
(members/boraccount.pl) for a patron who has paid and unpaid fines (the
more the better).

- Confirm that the default sort is by date descending.
- Confirm that DataTables controls (paging, search, result count) work
  correctly.
- Confirm that clicking the Filter paid transactions link works
  correctly to toggle display of paid transactions.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12258] Datatable in Patrons Account Fines

2014-10-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12258

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff
   Patch complexity|Medium patch|Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13169] New: On master 3.17.00.043 the web installing doesn'r work

2014-10-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13169

Bug ID: 13169
   Summary: On master 3.17.00.043 the web installing doesn'r work
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: critical
  Priority: P5 - low
 Component: Installation and upgrade (web-based installer)
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: paola.ro...@cineca.it
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

On master 3.17.00.043 the web installing send the error message:

Software error:

Template process failed: file error - doc-head-open.inc: not found at
/var/root-koha/bug-7162/C4/Templates.pm line 127.

For help, please send mail to the webmaster (webmaster@linux-test), giving this
error message and the time and date of the error. 

So the master can't be installed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13169] On master 3.17.00.043 the web installing doesn'r work

2014-10-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13169

Paola Rossi paola.ro...@cineca.it changed:

   What|Removed |Added

   Priority|P5 - low|P1 - high

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13169] On master 3.17.00.043 the web installing doesn't work

2014-10-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13169

Paola Rossi paola.ro...@cineca.it changed:

   What|Removed |Added

Summary|On master 3.17.00.043 the   |On master 3.17.00.043 the
   |web installing doesn'r work |web installing doesn't work

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8836] Resurrect Rotating Collections

2014-10-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8836] Resurrect Rotating Collections

2014-10-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #32773|0   |1
is obsolete||
  Attachment #32774|0   |1
is obsolete||

--- Comment #73 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 32973
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32973action=edit
Bug 8836 - Resurrect Rotating Collections

Test Plan:
In Tools - Rotating Collections - Add/Remove items:
When adding item barcodes to the collection, the input field
  input type=text id=barcode name=barcode
should become active
automatically so it is easy to add multiple barcodes rapidly without touching
the
mouse or keyboard.
Enter-press is dealt by the barcode reader so automatic form submittal should
be handled
by the barcode reader.

In Rotating collections - Transfer Collection:
When the collection is initially transferred, items are set to trasfer
correctly.
When the collection is transferred while items are still being transferred, the
transfer
destination library doesn't change from the original one.
The holding library changes for all items in the collection to the destination
library on
retransfers as well.
This is tricky if a user accidentally places the wrong destination.
When I try to checkin these items to their new retransfer location, I get the
following messages:
-This item is part of a rotating collection and needs to be transferred to
original transfer destination
-Please return Valkoinen ihmissyj / to original transfer destination
-Print slip or Cancel transfer

When I checkin a Item to a arbitrary branch, I get the following messages:
This item is part of a rotating collection and needs to be transferred to
retransfer destination
Please return Valkoinen ihmissyj / to original trasfer destination

Bug 8836 - Resurrect Rotating Collections - QA Followup

Bug 8836 - Resurrect Rotating Collections - Followup 2 - Perltidy rotating
collections scripts

Bug 8836 - Resurrect Rotating Collections - Followup 3

* Fix bad TT Tag
* Fix bad sql query
* Fix capitalization ( HTML4 )
* Allow a rotating collection's location to keep AutomaticItemReturn
  from sending it back to the branch of origin
* Fix bad query

Bug 8836 - Resurrect Rotating Collections - Followup 4 - Autofocus on barcode
field

Bug 8836 - Resurrect Rotating Collections - Followup 5 - Don't transfer issued
and waiting items

Items in a rotating collection are automatcially transferred when a
collection is transferred. This is a problem for currently checked out
items and items on hold marked as Waiting.

This patch resolves this issue by skipping the transfer for those items.
When the items are then returned, the librarian will be alerted to
transfer the item to the library currently holding that rotating
collection.

Bug 8836 - Resurrect Rotating Collections - Followup 5 - Link
collections.colBranchcode to branches.branchcode

Signed-off-by: jmbroust jean-manuel.bro...@univ-lyon2.fr
Signed-off-by: Cindy Murdock Ames cmurd...@ccfls.org

http://bugs.koha-community.org/show_bug.cgi?id=8835

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8836] Resurrect Rotating Collections

2014-10-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #32973|0   |1
is obsolete||

--- Comment #74 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 32974
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32974action=edit
Bug 8836 - Resurrect Rotating Collections

Test Plan:
In Tools - Rotating Collections - Add/Remove items:
When adding item barcodes to the collection, the input field
  input type=text id=barcode name=barcode
should become active
automatically so it is easy to add multiple barcodes rapidly without touching
the
mouse or keyboard.
Enter-press is dealt by the barcode reader so automatic form submittal should
be handled
by the barcode reader.

In Rotating collections - Transfer Collection:
When the collection is initially transferred, items are set to trasfer
correctly.
When the collection is transferred while items are still being transferred, the
transfer
destination library doesn't change from the original one.
The holding library changes for all items in the collection to the destination
library on
retransfers as well.
This is tricky if a user accidentally places the wrong destination.
When I try to checkin these items to their new retransfer location, I get the
following messages:
-This item is part of a rotating collection and needs to be transferred to
original transfer destination
-Please return Valkoinen ihmissyj / to original transfer destination
-Print slip or Cancel transfer

When I checkin a Item to a arbitrary branch, I get the following messages:
This item is part of a rotating collection and needs to be transferred to
retransfer destination
Please return Valkoinen ihmissyj / to original trasfer destination

Bug 8836 - Resurrect Rotating Collections - QA Followup

Bug 8836 - Resurrect Rotating Collections - Followup 2 - Perltidy rotating
collections scripts

Bug 8836 - Resurrect Rotating Collections - Followup 3

* Fix bad TT Tag
* Fix bad sql query
* Fix capitalization ( HTML4 )
* Allow a rotating collection's location to keep AutomaticItemReturn
  from sending it back to the branch of origin
* Fix bad query

Bug 8836 - Resurrect Rotating Collections - Followup 4 - Autofocus on barcode
field

Bug 8836 - Resurrect Rotating Collections - Followup 5 - Don't transfer issued
and waiting items

Items in a rotating collection are automatcially transferred when a
collection is transferred. This is a problem for currently checked out
items and items on hold marked as Waiting.

This patch resolves this issue by skipping the transfer for those items.
When the items are then returned, the librarian will be alerted to
transfer the item to the library currently holding that rotating
collection.

Bug 8836 - Resurrect Rotating Collections - Followup 5 - Link
collections.colBranchcode to branches.branchcode

Signed-off-by: jmbroust jean-manuel.bro...@univ-lyon2.fr
Signed-off-by: Cindy Murdock Ames cmurd...@ccfls.org

http://bugs.koha-community.org/show_bug.cgi?id=8835

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8836] Resurrect Rotating Collections

2014-10-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836

--- Comment #75 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 32975
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32975action=edit
Bug 8836 [QA Followup] - Fix koha-qa.pl errors reported

Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz

Trusting the sign off on the other page, I only tested the QA changes

Signed-off-by: Cindy Murdock Ames cmurd...@ccfls.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8836] Resurrect Rotating Collections

2014-10-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836

--- Comment #76 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 32976
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32976action=edit
Bug 8836 [QA Followup 2]

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8836] Resurrect Rotating Collections

2014-10-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836

--- Comment #77 from Kyle M Hall k...@bywatersolutions.com ---
I believe this followup should fix most all your issues. There is a small
visual bug with the alert divs that I'm hoping Owen can take a look at.

As far as the your functionality test, I think Cindy can speak more to its
accuracy, but it helps to think of the the rotating collections as something of
a floating collection. For this reason, automatic transfers are disabled for
rotating items. If you need to transfer an item, you must use the transfer tool
from the circulation page. Does that make sense?

Kyle

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item

2014-10-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011

--- Comment #93 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 32977
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32977action=edit
Bug 9011 [QA Followup 5] - Depend on bug 9303 for issue_id

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9303] relative's checkouts in the opac

2014-10-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Blocks||9011

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item

2014-10-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Depends on||9303

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item

2014-10-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

--- Comment #94 from Kyle M Hall k...@bywatersolutions.com ---
You are correct! And it does a much better job of it too. I'm making bug 9303 a
dependency for this bug.

(In reply to Katrin Fischer from comment #92)
 I tried it again... restored my database pre-patch, ran the update again,
 new checkout = issue_id = 4 :( Should have been 27.
 
 I have a feeling of de ja vu... didn't we fight this problem on another
 patch? Looks like bug 9303 is also adding an issue_id.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12803] Add ability to skip closed libraries when generating the holds queue

2014-10-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803

--- Comment #14 from Kyle M Hall k...@bywatersolutions.com ---
This is actually a bug fix. If you read the preference, it reads that
RandomizeHoldsQueueWeight should work even if StaticHoldsQueueWeight is empty.
However, in the original code this was not true.

This change otherwise has no effect on the behavior of the feature. Previously,
if load_branches_to_pull returned undef,
GetItemsAvailableToFillHoldRequestsForBib would use all branches. This is still
true, it just makes more logical sense now.

If you would like me to revert the RandomizeHoldsQueueWeight behavior so the
bug can be fixed separately, I'd be more than happy to do so.


(In reply to Jonathan Druart from comment #13)
 Before this patch, load_branches_to_pull_from return undef if
 StaticHoldsQueueWeight was empty, now RandomizeHoldsQueueWeight and
 HoldsQueueSkipClosed are take into account.
 Kyle, could you please confirm it is an error?
 I am not comfortable enough to fix it in a followup.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12803] Add ability to skip closed libraries when generating the holds queue

2014-10-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11211] Move calculation code out of C4::Calendar

2014-10-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11211

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #32867|0   |1
is obsolete||

--- Comment #24 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 32978
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32978action=edit
Bug 11211 - Move calculation code out of C4::Calendar

This patch moves the calculation code out of C4::Calendar, replacing any
references to it with Koha::Calendar. Additionally, it moves the
administration interface to a single script, tools/calendar.pl.

NOTE: This is intended as a bridge to bug 8133, so the UI is a bit
awkward, and C4::Calendar has an API designed for adding hours to the
calendar. All features should still work, and 8133 will make things
better.

Test plan:
  1) Install the new dependency, Template::Plugin::JavaScript.
  2) prove t/db_dependent/Calendar.t t/db_dependent/Holidays.t to verify
 that the new C4::Calendar API works correctly.
  3) prove t/Calendar.t
  4) Add, remove and modify events of each type using the administrative
 interface. In this version, changing a repeating event to Open
 deletes it.
  5) Check out items to verify that the calculation code is using the
 events you just created.
  6) If possible, verify that the two affected cronjobs still function
 correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10860] On-site checkouts (was In-House Use)

2014-10-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #32579|0   |1
is obsolete||
  Attachment #32580|0   |1
is obsolete||
  Attachment #32581|0   |1
is obsolete||
  Attachment #32954|0   |1
is obsolete||

--- Comment #64 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 32979
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32979action=edit
Bug 10860: In-House Use

This patch implements the In-House Use feature for Koha.

It adds:
- 2 new sysprefs:
  'In-House Use' to enable/disable this feature
  'In-House Use Forced' to enable/disable the feature for *all* users.
- 2 new columns issues.inhouse_use and old_issues.inhouse_use
- Datatable on the circulation history pages (readingrec) at the OPAC
  and the intranet.

A new checkbox in the Circulation tab. If checked, the issue become a
in-house use (in the statistics and issues tables).
When you check it, the due date changes to the today date.

The syspref In-House Use Force allows to force the in-house use to
permit the checkout even if the borrower is debarred or others problems.

In the issue table, a new string (in red) marks the issue as in-house use.

The circulation history contains 3 tabs : all, checkout and
in-house use (OPAC and intranet).

The cronjob script:
If AutomaticItemReturn if off, a library would like not to do a transit
operation manually. This script (to launch each night) do returns
for a specific branches.

Test plan:
1/ Execute the updatedatabase entry
2/ Enable the 'In-House Use' pref.
3/ Checkout a biblio for a patron and check the 'in-house use' checkbox.
4/ Check that the due date is the today date (with 23:59) and is not
modifiable.
5/ Click on the check out button and check that the new check out
appears in the table bellow with the (In-house use) string.
6/ Go on the circulation history pages (readingrec and opac-readingrec)
and try the 3 tabs. In the last one, your last checkout should appear.
7/ Check in.
8/ Check readingrec pages.
9/ Choose a debarred patron and check that you cannot checkout a biblio
for him.
10/ Switch on the 'In-House Use Forced' pref
11/ You are now allowed to checkout a biblio for the debarred patron.

Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11211] Move calculation code out of C4::Calendar

2014-10-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11211

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

   Keywords||rel_3_18_candidate
 CC||tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12831] local only logins should still work when ldap authentication is enabled

2014-10-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12831

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

   Keywords||rel_3_18_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10860] On-site checkouts (was In-House Use)

2014-10-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860

--- Comment #67 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 32982
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32982action=edit
Bug 10860 [QA Followup] - Fix misc issues

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10860] On-site checkouts (was In-House Use)

2014-10-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #32979|0   |1
is obsolete||

--- Comment #65 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 32980
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32980action=edit
Bug 10860: In-House Use

This patch implements the In-House Use feature for Koha.

It adds:
- 2 new sysprefs:
  'In-House Use' to enable/disable this feature
  'In-House Use Forced' to enable/disable the feature for *all* users.
- 2 new columns issues.inhouse_use and old_issues.inhouse_use
- Datatable on the circulation history pages (readingrec) at the OPAC
  and the intranet.

A new checkbox in the Circulation tab. If checked, the issue become a
in-house use (in the statistics and issues tables).
When you check it, the due date changes to the today date.

The syspref In-House Use Force allows to force the in-house use to
permit the checkout even if the borrower is debarred or others problems.

In the issue table, a new string (in red) marks the issue as in-house use.

The circulation history contains 3 tabs : all, checkout and
in-house use (OPAC and intranet).

The cronjob script:
If AutomaticItemReturn if off, a library would like not to do a transit
operation manually. This script (to launch each night) do returns
for a specific branches.

Test plan:
1/ Execute the updatedatabase entry
2/ Enable the 'In-House Use' pref.
3/ Checkout a biblio for a patron and check the 'in-house use' checkbox.
4/ Check that the due date is the today date (with 23:59) and is not
modifiable.
5/ Click on the check out button and check that the new check out
appears in the table bellow with the (In-house use) string.
6/ Go on the circulation history pages (readingrec and opac-readingrec)
and try the 3 tabs. In the last one, your last checkout should appear.
7/ Check in.
8/ Check readingrec pages.
9/ Choose a debarred patron and check that you cannot checkout a biblio
for him.
10/ Switch on the 'In-House Use Forced' pref
11/ You are now allowed to checkout a biblio for the debarred patron.

Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10860] On-site checkouts (was In-House Use)

2014-10-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10860] On-site checkouts (was In-House Use)

2014-10-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860

--- Comment #66 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 32981
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32981action=edit
Bug 10860 - Change in-house use to on-site checkout

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10860] On-site checkouts (was In-House Use)

2014-10-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860

--- Comment #68 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 32983
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32983action=edit
Bug 10860: Follow-up - staff reading record

- capitalization fix Checked out
- display new tabs only when feature is activated
- fixes a qa script complaint about POD in Items.pm

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10860] On-site checkouts (was In-House Use)

2014-10-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860

--- Comment #69 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 32984
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32984action=edit
Bug 10860 [QA Followup] - Rename system preferences

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11211] Move calculation code out of C4::Calendar

2014-10-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11211

Brendan Gallagher bren...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level

2014-10-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367

Paola Rossi paola.ro...@cineca.it changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #89 from Paola Rossi paola.ro...@cineca.it ---
(In reply to Olli-Antti Kivilahti from comment #88)
 [...] Hope to hear from you soon 

Thanks, Olli-Antti, for your kind feedbacks.

Today I've applied the patch against master 3.17.00.043.

After having applied, I've created a hold reserving an item that was checked
out. So the reserve/hold's status became W after checking in it. On the
browser I refreshed the cache (Ctrl r, Ctrl F5): so I saw the hold by the 4
*.tt as required in step 4.

In particular: on OPAC, for a logged patron with holds, the lastpickupdate was
in the until part of the Status column of the hold.
On circ/waitingreserves.tt (Home › Circulation › Holds awaiting pickup) the
lastpickupdate was in the until part of the first column Available of n
Hold(s) waiting tag.

The tables with holds with NULL lastpickupdate (holds created reserving items
not checked out, as allowed by syspref AllowOnShelfHolds set to Allow) were
shown OK too.

So I pass the patch back to Needs Signoff status.

I've changed the syspref 'ReservesMaxPickUpDelay' from the default 0 value,
thank you again.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8133] hourly loans doesn't know when library closed

2014-10-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8133

--- Comment #26 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 32986
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32986action=edit
Bug 8133 [QA Followup] - Fix koha-qa.pl violations

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8133] hourly loans doesn't know when library closed

2014-10-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8133

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #32176|0   |1
is obsolete||
  Attachment #32327|0   |1
is obsolete||

--- Comment #25 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 32985
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32985action=edit
Bug 8133 - hourly loans doesn't know when library closed

This adds support for storing library hours in the calendar, and using
those hours to compute hourly loan duetimes.

A large amount of cleanup was also performed to expunge duplication of
code between C4::Calendar and Koha::Calendar.

Test plan:
1) Apply patch.
2) Update database.
3) Verify that the calendar administration interface still exists and
   works as expected.
4) Run t/Calendar.t and t/db_dependent/Calendar.t.

Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11876] Add a diff view to staged MARC Records.

2014-10-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11876

--- Comment #20 from simith.dolive...@inlibro.com ---
Created attachment 32987
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32987action=edit
unit test added

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11876] Add a diff view to staged MARC Records.

2014-10-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11876

simith.dolive...@inlibro.com changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8836] Resurrect Rotating Collections

2014-10-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836

--- Comment #78 from Owen Leonard oleon...@myacpl.org ---
Some issues I see:

- The list of collections should show a count of the
  items in that collection

- Should collections require unique titles?
  I was able to add multiple collections with the same title.

- Why are descriptions required?

- Transfer library list isn't in alphabetical order

- No confirmation of deletion operation, including 
  for collections which contain items.

- Shouldn't the detail page for an item in a collection show
  that it is in a collection?

- Add/edit/delete/transfer operations should redirect sensibly
  instead of showing a blank page with a confirmation message.

  For instance: After a successful collection edit the user
  should be redirected to the collections home page and a
  message displayed there.

- Templates are a mess. I'm preparing a follow-up.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11517] MARC21slim2intranetResults.xsl has swapped braille and combination

2014-10-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11517

Brendan Gallagher bren...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #32868|0   |1
is obsolete||

--- Comment #3 from Brendan Gallagher bren...@bywatersolutions.com ---
Created attachment 32988
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32988action=edit
Bug 11517: Braille and combination swapped in XSLT result lists

http://www.loc.gov/marc/bibliographic/bd007f.html

- Catalog a record:
  * 007 - choose 'Tactile material'
  * Pos. 1 - choose b = Braille or C = combination
  * Reindex!
  * Verify the result list shows the format correctly.

Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com

Problem exist, fixed with this patch.
No koha-qa errors

Signed-off-by: Brendan Gallagher bren...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11517] MARC21slim2intranetResults.xsl has swapped braille and combination

2014-10-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11517

Brendan Gallagher bren...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12334] Make it easier to hide parts of material type and format information in OPAC

2014-10-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12334

Brendan Gallagher bren...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #32858|0   |1
is obsolete||

--- Comment #3 from Brendan Gallagher bren...@bywatersolutions.com ---
Created attachment 32989
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32989action=edit
Bug 12334: Make it easy to hide parts of material type and format information
in results

With the system preferences DisplayIconsXSLT and DisplayOPACiconsXSLT we
control
the visibility of the material type, format and audience information in staff
and OPAC.

Sometimes a library might only want to hide a part of that information - for
example, hide audience but keep the material type icon.

This patch adds CSS classes to make it easier to style this section of the page
and hide parts of the information.

To test:
- Verify that OPAC and staff result lists for various types of materials
  still display nicely.
- Take a look at the HTML and verify, that label and text are now
  wrapped into a new span with a results_* class.
- Try hiding a part of the information, for example in OpacUserCSS:

.results_material_type {
  display none;
}

Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com
Works as described... but for a missing colon on example CSS

.results_material_type {
  display: none;
}

No koha-qa errors

Signed-off-by: Brendan Gallagher bren...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12334] Make it easier to hide parts of material type and format information in OPAC

2014-10-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12334

Brendan Gallagher bren...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8836] Resurrect Rotating Collections

2014-10-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836

--- Comment #79 from Owen Leonard oleon...@myacpl.org ---
Another issue:

I happened to add to a collection an item which was already in mid-transfer
between two libraries. When I transferred that collection to another library
the in-progress transfer was still active.

When I tried checking in that item at another library (not the collection's
library, not the library to which the item had originally been transferred) I
got conflicting messages: Both a message telling me where the collection
belonged and also a message about the original transfer.

If I understand the feature correctly the original in-progress transfer should
have been cancelled when I initiated the transfer of the collection.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8133] hourly loans doesn't know when library closed

2014-10-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8133

--- Comment #27 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 32990
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32990action=edit
Bug 8133 [QA Followup 2] - Fix unit tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level

2014-10-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367

--- Comment #90 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi ---
(In reply to Paola Rossi from comment #89)
 (In reply to Olli-Antti Kivilahti from comment #88)
  [...] Hope to hear from you soon 
 
 Thanks, Olli-Antti, for your kind feedbacks.
 
 Today I've applied the patch against master 3.17.00.043.
 
 After having applied, I've created a hold reserving an item that was checked
 out. So the reserve/hold's status became W after checking in it. On the
 browser I refreshed the cache (Ctrl r, Ctrl F5): so I saw the hold by the 4
 *.tt as required in step 4.
 
 In particular: on OPAC, for a logged patron with holds, the lastpickupdate
 was in the until part of the Status column of the hold.
 On circ/waitingreserves.tt (Home › Circulation › Holds awaiting pickup) the
 lastpickupdate was in the until part of the first column Available of n
 Hold(s) waiting tag.
  
 The tables with holds with NULL lastpickupdate (holds created reserving
 items not checked out, as allowed by syspref AllowOnShelfHolds set to
 Allow) were shown OK too.
 
 So I pass the patch back to Needs Signoff status.
 
 I've changed the syspref 'ReservesMaxPickUpDelay' from the default 0 value,
 thank you again.

Nice to hear from you!

Is there anything here that prevents your from signing this off?
I believe this feature needs more than one sign off to be considered fit for QA
and yours would be a great start!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8133] hourly loans doesn't know when library closed

2014-10-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8133

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #32990|0   |1
is obsolete||

--- Comment #28 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 32991
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32991action=edit
Bug 8133 [QA Followup 2] - Fix unit tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8836] Resurrect Rotating Collections

2014-10-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836

--- Comment #80 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi ---
Canceling an in-progress transport causes issues in real life.
When a book is being moved between cities, it is essential to know that the
item is on the move. When the Item in the rotating collection reaches the
transfer destination, it is automatically sent back to the new home library
(depending on the sysprefs).

Initially the idea back here was to be able to create these Rotating
Collections by utilizing the normal consortial transportation features. So we
could put items from multiple branches to one rotating collection destined to
one place. For example if we want to make a collection of a special topic from
all the books available throughout the consortium.

Ofcourse the items need to be checked-in to activate the transfer and this
needs some manual work in notifying each branch about the desired items which
are waiting in shelves. Items on normal circulation tend to move towards the
rotating collection home after they are checked-in.
I guess there are still some issues with the idea, but I don't think canceling
transfers is the way to go. It would be better to force items in a rotating
collection to be sent to the rotating collection home after they reach their
destination.
Regarding holds queue for items on a rotating collection. We thought that it
will be something the librarian needs to consider, maybe as a follow up feature
to block placing holds on rotating collections via syspref or via a option in
the rotating collection itself (better!).

I just don't feel like missing the opportunity to providing a tool to do cool
things with our material, is worth the price of assuming that all the Items are
immediately available when they are put to the collection. Even if that would
be the easy way out.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8836] Resurrect Rotating Collections

2014-10-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836

--- Comment #81 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi ---
(In reply to Owen Leonard from comment #78)
 Some issues I see:
 
 - The list of collections should show a count of the
   items in that collection
 
true

 - Should collections require unique titles?
   I was able to add multiple collections with the same title.
 
a good idea

 - Why are descriptions required?
If we have a special rotating collection we want to tell about. Or maybe to
tell others to not touch the material in here until 14.4.2015? Its handy to
have a freeword place to leave messages and extra info.
 
 - Transfer library list isn't in alphabetical order
 
 - No confirmation of deletion operation, including 
   for collections which contain items.
 
we got complaints of that as well, I thought Juhani already fixed that?

 - Shouldn't the detail page for an item in a collection show
   that it is in a collection?
 
It should.

 - Add/edit/delete/transfer operations should redirect sensibly
   instead of showing a blank page with a confirmation message.
 
   For instance: After a successful collection edit the user
   should be redirected to the collections home page and a
   message displayed there.
 
 - Templates are a mess. I'm preparing a follow-up.

I'll ask Juhani to comment on these.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12964] GST / VAT rewrite - Overview

2014-10-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12964

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Signed Off  |BLOCKED

--- Comment #19 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Moving this out of the queue for now - all other patches are blocked or passed
QA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11211] Move calculation code out of C4::Calendar

2014-10-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11211

--- Comment #25 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 32992
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32992action=edit
Bug 11211 [QA Followup] - Remove use of dt_add_type_uk_date

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8836] Resurrect Rotating Collections

2014-10-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836

--- Comment #82 from Owen Leonard oleon...@myacpl.org ---
(In reply to Olli-Antti Kivilahti from comment #81)
  - Why are descriptions required?
 If we have a special rotating collection we want to tell about.

Yes, I can see why a description is a useful option. I just don't understand
why the description would be a required field.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7673] New patron permissions to manage items (edit, batchmod, delete all)

2014-10-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7673] New patron permissions to manage items (edit, batchmod, delete all)

2014-10-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

  Attachment #32962|0   |1
is obsolete||

--- Comment #110 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 32993
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32993action=edit
[PASSED QA] Bug 7673 [Terminology follow-up] New patron permissions to manage
items

This bug adds a new preference, SubfieldsToAllowForRestrictedEdition,
but the use of the term Edition in this context is incorrect. I think
it would be more clear to change the preference name to
SubfieldsToAllowForRestrictedEditing. This patch makes this change.

I realize this isn't a big issue since the preference has a good
description, but I thought that if we were going to make this as clear
as possible now would be the time to do it.

To test, start with a database which hasn't previously been used to test
Bug 7673. Apply all patches and run the database update. Follow the test
plan as described in the bug.

Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz
Signed-off-by: Katrin Fischer katrin.fischer...@web.de
Works as described, change appears complete.
All tests and QA script still pass.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8836] Resurrect Rotating Collections

2014-10-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

 Status|Signed Off  |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8836] Resurrect Rotating Collections

2014-10-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836

--- Comment #83 from Owen Leonard oleon...@myacpl.org ---
Created attachment 32994
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32994action=edit
Bug 8836 [Template follow-up] Resurrect Rotating Collections

This follow-up makes drastic changes to the templates in order to bring
them into compliance with established patterns and markup guidelines.
Only minor changes are made to perl scripts.

Changes:

- Add a toolbar include for displaying new, edit, transfer, and delete
  buttons.
- Improve title and breadcrumbs with collection titles and better
  specificity.
- Correct page structure which was inconsistent with the markup of
  similarly-structured pages.
- Correct styling of error and informational messages.
- Added detailed error messages for a couple of conditions which were
  not defined in the template.
- Add link to the detail page of titles which are in a collection using
  the view defined in the IntranetBiblioDefaultView preference.
- Add a link to remove an item from a collection directly without having
  to scan the barcode.
- Add client-side validation to collection creation form.
- In RotatingCollections.pm, add biblionumber to the list of columns
  returned by GetItemsInCollection.
- In rotating_collections/*.pl, remove obsolete declaration of system
  preference variables.

To test, perform all the operations associated with Rotating
Collections:

- Add a new collection
- Edit an existing collection
- Add items to a collection
- Remove items from a collection (via barcode and link)
- Test the behavior of all new toolbar buttons
- Verify that titles and breadcrumbs look correct and links work
  correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11876] Add a diff view to staged MARC Records.

2014-10-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11876

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11876] Add a diff view to staged MARC Records.

2014-10-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11876

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

  Attachment #32987|0   |1
is obsolete||

--- Comment #21 from Owen Leonard oleon...@myacpl.org ---
Created attachment 32995
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32995action=edit
[SIGNED-OFF] Bug 11876 [Unit test] Add a diff view to staged MARC Records

Unit test added

http://bugs.koha-community.org/show_bug.cgi?id=11876
Signed-off-by: Owen Leonard oleon...@myacpl.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13170] New: Remove of prog theme broke the OPAC's view plain option for MARC details

2014-10-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13170

Bug ID: 13170
   Summary: Remove of prog theme broke the OPAC's view plain
option for MARC details
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
   URL: /cgi-bin/koha/opac-showmarc.pl?id=XXXviewas=html
OS: All
Status: NEW
  Severity: major
  Priority: P5 - low
 Component: Templates
  Assignee: tomasco...@gmail.com
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org

In the OPAC if you view the MARC details for a title (and have 
OPACXSLTDetailsDisplay enabled) there is a view plain link which displays the
output of opac-showmarc.pl. This is broken in master:

opac-showmarc.pl: XSLT file not found. at kohaclone/Koha/XSLT_Handler.pm

git bisect blames Bug 12233: Remove the prog and ccsr themes files.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13171] New: Check box for email is missing for hold notifications in patron messaging preferences.

2014-10-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13171

Bug ID: 13171
   Summary: Check box for email is missing for hold notifications
in patron messaging preferences.
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Patrons
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: bar...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

After upgrade to 3.16, I've seen two partners who have the 'Email' check-box
missing in the 'Patron Messaging Preferences' area on moremember.pl.

There is a '-' where the check box should appear.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13171] Check box for email is missing for hold notifications in patron messaging preferences.

2014-10-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13171

Jesse Maseto je...@bywatersolutions.com changed:

   What|Removed |Added

   Priority|P5 - low|P1 - high
 CC||je...@bywatersolutions.com
   Severity|enhancement |blocker

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12258] Datatable in Patrons Account Fines

2014-10-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12258

--- Comment #6 from Marc Véron ve...@veron.ch ---
Created attachment 32996
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32996action=edit
[Signed-off] Bug 12258 [Template follow-up] Datatable in Patrons Account Fines

This follow-up corrects some of the QA issues affecting the other patch,
as well as changing the way the filter option is displayed:

- Added the use of the DataTables include file
- Removed redundant document.ready
- Fixed single quotes
- Fixed default sort (should be date descending to match the current
  functionality)
- Adding missing tr
- Converted filter button to a link

The last change is a judgement call, but the button in the DataTables
toolbar looked awkward and caused ugly wrapping at narrower viewport
sizes. I think a link is more keeping with the pattern established by
select all / clear all links.

To test, apply both patches and view the account page
(members/boraccount.pl) for a patron who has paid and unpaid fines (the
more the better).

- Confirm that the default sort is by date descending.
- Confirm that DataTables controls (paging, search, result count) work
  correctly.
- Confirm that clicking the Filter paid transactions link works
  correctly to toggle display of paid transactions.

Works as expected. Passed koha-qa.pl.
Signed-off-by: Marc Véron ve...@veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10860] On-site checkouts (was In-House Use)

2014-10-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860

--- Comment #71 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 32998
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32998action=edit
Bug 10860: Follow-up - fix some template variable issues

Fixing some simple display issues caused by missing/misnamed
variables, probably consequence of the renaming before.

Amended test plan:
- Make sure that if OnSiteCheckoutsForce is set, you can
  still perform onsite checkouts and only those.
- Check the detail page in staff says *currently in local use by*
  for an on-site checked out item
- Check the detail page in OPAC with OPACShowCheckoutName active
  for the same.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10860] On-site checkouts (was In-House Use)

2014-10-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

  Attachment #32984|0   |1
is obsolete||

--- Comment #70 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 32997
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32997action=edit
[PASSED QA] Bug 10860 [QA Followup] - Rename system preferences

Signed-off-by: Katrin Fischer katrin.fischer...@web.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9303] relative's checkouts in the opac

2014-10-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #153 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Sorry Kyle, but I tried with various old databases I have and the databaes
update always gives me trouble :(


Upgrade to 3.17.00.043 done (Bug 7162: Add aqorders.cancellationreason)
DBD::mysql::db do failed: Can't DROP 'PRIMARY'; check that column/key exists at
./installer/data/mysql/updatedatabase.pl line 8964.
DBD::mysql::db do failed: Can't DROP 'itemnumber_idx'; check that column/key
exists at ./installer/data/mysql/updatedatabase.pl line 8970.
DBD::mysql::db do failed: Can't DROP 'PRIMARY'; check that column/key exists at
./installer/data/mysql/updatedatabase.pl line 8973.
DBD::mysql::db do failed: Cannot drop index 'itemnumber_idx': needed in a
foreign key constraint at ./installer/data/mysql/updatedatabase.pl line 8979.
DBD::mysql::db do failed: Duplicate key name 'itemnumber_idx' at
./installer/data/mysql/updatedatabase.pl line 8982.

Can you please take a look?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item

2014-10-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Signed Off  |BLOCKED

--- Comment #95 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
This is now blocked by 9303 database update problems.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12803] Add ability to skip closed libraries when generating the holds queue

2014-10-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #15 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Looking at this now.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12803] Add ability to skip closed libraries when generating the holds queue

2014-10-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #16 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
I am sorry, but t/db_dependent/HoldsQueue.t is failing in my installation:

t/db_dependent/HoldsQueue.t . 2/23 
#   Failed test 'Holds not filled with items from closed libraries'
#   at t/db_dependent/HoldsQueue.t line 310.
#  got: '2'
# expected: '1'

#   Failed test 'Holds not filled with items from closed libraries'
#   at t/db_dependent/HoldsQueue.t line 327.
#  got: '3'
# expected: '2'
# Looks like you failed 2 tests of 23.
t/db_dependent/HoldsQueue.t . Dubious, test returned 2 (wstat
512, 0x200)
Failed 2/23 subtests 

Could this conflict with the calendar changes for hourly?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8133] hourly loans doesn't know when library closed

2014-10-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8133

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|BLOCKED |Signed Off

--- Comment #29 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
We still need to get rid of given-when here:
 FAILtools/calendar.pl
   OK  critic
   OK  forbidden patterns
   OK  pod
   FAIL  valid
given is experimental 
when is experimental 

But I will keep testing.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8836] Resurrect Rotating Collections

2014-10-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836

Brendan Gallagher bren...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #32974|0   |1
is obsolete||

--- Comment #84 from Brendan Gallagher bren...@bywatersolutions.com ---
Created attachment 32999
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32999action=edit
Bug 8836 - Resurrect Rotating Collections

Test Plan:
In Tools - Rotating Collections - Add/Remove items:
When adding item barcodes to the collection, the input field
  input type=text id=barcode name=barcode
should become active
automatically so it is easy to add multiple barcodes rapidly without touching
the
mouse or keyboard.
Enter-press is dealt by the barcode reader so automatic form submittal should
be handled
by the barcode reader.

In Rotating collections - Transfer Collection:
When the collection is initially transferred, items are set to trasfer
correctly.
When the collection is transferred while items are still being transferred, the
transfer
destination library doesn't change from the original one.
The holding library changes for all items in the collection to the destination
library on
retransfers as well.
This is tricky if a user accidentally places the wrong destination.
When I try to checkin these items to their new retransfer location, I get the
following messages:
-This item is part of a rotating collection and needs to be transferred to
original transfer destination
-Please return Valkoinen ihmissyj / to original transfer destination
-Print slip or Cancel transfer

When I checkin a Item to a arbitrary branch, I get the following messages:
This item is part of a rotating collection and needs to be transferred to
retransfer destination
Please return Valkoinen ihmissyj / to original trasfer destination

Bug 8836 - Resurrect Rotating Collections - QA Followup

Bug 8836 - Resurrect Rotating Collections - Followup 2 - Perltidy rotating
collections scripts

Bug 8836 - Resurrect Rotating Collections - Followup 3

* Fix bad TT Tag
* Fix bad sql query
* Fix capitalization ( HTML4 )
* Allow a rotating collection's location to keep AutomaticItemReturn
  from sending it back to the branch of origin
* Fix bad query

Bug 8836 - Resurrect Rotating Collections - Followup 4 - Autofocus on barcode
field

Bug 8836 - Resurrect Rotating Collections - Followup 5 - Don't transfer issued
and waiting items

Items in a rotating collection are automatcially transferred when a
collection is transferred. This is a problem for currently checked out
items and items on hold marked as Waiting.

This patch resolves this issue by skipping the transfer for those items.
When the items are then returned, the librarian will be alerted to
transfer the item to the library currently holding that rotating
collection.

Bug 8836 - Resurrect Rotating Collections - Followup 5 - Link
collections.colBranchcode to branches.branchcode

Signed-off-by: jmbroust jean-manuel.bro...@univ-lyon2.fr
Signed-off-by: Cindy Murdock Ames cmurd...@ccfls.org

http://bugs.koha-community.org/show_bug.cgi?id=8835

Signed-off-by: Brendan Gallagher bren...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8836] Resurrect Rotating Collections

2014-10-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836

Brendan Gallagher bren...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8836] Resurrect Rotating Collections

2014-10-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836

Brendan Gallagher bren...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #32975|0   |1
is obsolete||

--- Comment #85 from Brendan Gallagher bren...@bywatersolutions.com ---
Created attachment 33000
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33000action=edit
Bug 8836 [QA Followup] - Fix koha-qa.pl errors reported

Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz

Trusting the sign off on the other page, I only tested the QA changes

Signed-off-by: Cindy Murdock Ames cmurd...@ccfls.org

Signed-off-by: Brendan Gallagher bren...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8836] Resurrect Rotating Collections

2014-10-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836

Brendan Gallagher bren...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #32994|0   |1
is obsolete||

--- Comment #87 from Brendan Gallagher bren...@bywatersolutions.com ---
Created attachment 33002
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33002action=edit
Bug 8836 [Template follow-up] Resurrect Rotating Collections

This follow-up makes drastic changes to the templates in order to bring
them into compliance with established patterns and markup guidelines.
Only minor changes are made to perl scripts.

Changes:

- Add a toolbar include for displaying new, edit, transfer, and delete
  buttons.
- Improve title and breadcrumbs with collection titles and better
  specificity.
- Correct page structure which was inconsistent with the markup of
  similarly-structured pages.
- Correct styling of error and informational messages.
- Added detailed error messages for a couple of conditions which were
  not defined in the template.
- Add link to the detail page of titles which are in a collection using
  the view defined in the IntranetBiblioDefaultView preference.
- Add a link to remove an item from a collection directly without having
  to scan the barcode.
- Add client-side validation to collection creation form.
- In RotatingCollections.pm, add biblionumber to the list of columns
  returned by GetItemsInCollection.
- In rotating_collections/*.pl, remove obsolete declaration of system
  preference variables.

To test, perform all the operations associated with Rotating
Collections:

- Add a new collection
- Edit an existing collection
- Add items to a collection
- Remove items from a collection (via barcode and link)
- Test the behavior of all new toolbar buttons
- Verify that titles and breadcrumbs look correct and links work
  correctly.

Signed-off-by: Brendan Gallagher bren...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8836] Resurrect Rotating Collections

2014-10-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836

Brendan Gallagher bren...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #32976|0   |1
is obsolete||

--- Comment #86 from Brendan Gallagher bren...@bywatersolutions.com ---
Created attachment 33001
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33001action=edit
Bug 8836 [QA Followup 2]

Signed-off-by: Brendan Gallagher bren...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >