[Koha-bugs] [Bug 10486] Allow external Z39.50 targets to be searched from the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10486 Bob Birchall b...@calyx.net.au changed: What|Removed |Added CC||b...@calyx.net.au --- Comment #89 from Bob Birchall b...@calyx.net.au --- What's the status of this? Is it still being pursued? I guess its going to miss 3.18? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12886] shelfbrowser script should write headers
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12886 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12886] shelfbrowser script should write headers
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12886 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #32351|0 |1 is obsolete|| --- Comment #4 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 33142 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33142action=edit Bug 12886: shelfbrowser script should write headers opac/svc/shelfbrowser.pl does not write http headers. On a production server, this patch resolves a server internal error (500): Bad header=div id=shelfbrowser I did not reproduce on my local instance, but this should be fixed. Test plan: Verify there is no regression on browsing a shelf (with en and translated templates) Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12886] shelfbrowser script should write headers
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12886 --- Comment #5 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to Katrin Fischer from comment #3) I am not sure why this happens, but with the patch applied for every time I use the 'arrow' picture, a 1 appears in the bottom left corner. This doesn't happen without the patch applied. Silly error, print should have been removed, done. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12803] Add ability to skip closed libraries when generating the holds queue
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 Magnus Enger mag...@enger.priv.no changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=12450 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12450] Closing libraries for the summer
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12450 Magnus Enger mag...@enger.priv.no changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=12803 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12633] SQLHelper replacement - C4::Members
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633 --- Comment #12 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to Katrin Fischer from comment #11) Do we need a new patch here? It looks like this is the last missing piece to get rid of SQLHelper. see comment 9. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12633] SQLHelper replacement - C4::Members
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #30547|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12068] label-create-pdf.pl Add support for RTL languages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12068 --- Comment #27 from M. de Rooy m.de.r...@rijksmuseum.nl --- (In reply to Katrin Fischer from comment #26) Hi Marcel, can you explain? Installing Text::Bidi gives headaches: 0) I installed a fribidi with yum already (not on debian!) 1) After last error, installed ExtUtils::PkgConfig 2) Package fribidi was not found in the pkg-config search path. Made a fribidi.pc file 3) After several warnings and editing several lines in this fribidi.pc, I came one step further: 'YAML' not installed, will not store persistent state. 4) After installing YAML, got this fatal error: fribidi.h: No such file or directory. The installed fribidi appears to be a problem. So I am still stuck with this. Since I am not using this feature at all, I would not like to waste much more time on it.. Not sure if other people on other distros will have similar problems. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12068] label-create-pdf.pl Add support for RTL languages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12068 --- Comment #28 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Hi Marcel, hope I didn't miss it, but which distro are you using? I think all I did was something like 'sudo apt-get install libtext-bidi-perl' - as it seemed to be ok on Ubuntu and Debian, I didn't see a problem here when we discussed the patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12068] label-create-pdf.pl Add support for RTL languages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12068 --- Comment #29 from Katrin Fischer katrin.fisc...@bsz-bw.de --- (12:15:07) marcelr: cait: fedora -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12964] GST / VAT rewrite - Overview
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12964 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|BLOCKED |Signed Off --- Comment #20 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to Katrin Fischer from comment #19) Moving this out of the queue for now - all other patches are blocked or passed QA. There is no patch on this one. It's a document to review, see description. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12964] GST / VAT rewrite - Overview
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12964 --- Comment #21 from Katrin Fischer katrin.fisc...@bsz-bw.de --- I know - I just moved it when I had qa'd everything I could. We don't really have a good status for documentation :( -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13157] improving facet definitions for unimarc
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13157 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Keywords||rel_3_18_candidate CC||tomasco...@gmail.com Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13157] Fix holdingbranch facet for UNIMARC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13157 mathieu saby mathsaby...@gmail.com changed: What|Removed |Added Summary|improving facet definitions |Fix holdingbranch facet for |for unimarc |UNIMARC -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 1861] Unique patrons logins not (totally) enforced
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1861 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 1861] Unique patrons logins not (totally) enforced
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1861 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #30828|0 |1 is obsolete|| --- Comment #9 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 33143 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33143action=edit Bug 1861 - Unique patrons logins not (totally) enforced The Koha 3.0 patron admin page will prevent you from creating a user who has an identical OPAC login as someone else (though I would change the error message from Login/password already exists. to Login already exists., since it's not the password that's the problem). However, there's nothing enforced in the MySQL database to prevent patrons from being imported or manually inserted with duplicate logins. Would it be better to change the MySQL spec from this: KEY `userid` (`userid`) to this: UNIQUE KEY `userid` (`userid`) Test plan: 1) Enter mysql console 2) Attempt to create two borrowers with identical user id's 3) Note you are able to do so 4) Delete these bororwers 5) Apply this patch 6) Run updatedatabase.pl 7) Repeat step 2 8) Note you are now unable to do so Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com Work as described, no koha-qa errors Signed-off-by: Katrin Fischer katrin.fischer...@web.de Leaves deletedborrowers as it is, deleting patrons still works ok. Works according to test plan. Database update will only be successful, when no duplicate entries exist in the database. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 1861] Unique patrons logins not (totally) enforced
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1861 --- Comment #10 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 33144 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33144action=edit Bug 1861 [QA Followup] - Fix Check_Userid and unit tests Check_Userid assumes that a borrowernumber will always be passed in and thus fails to to return 0 for an already used userid when creating a new patron. Unit tests must now also me modified to no longer assume it is possible to create multiple patrons with the same userid. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11998] Syspref caching issues
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 Martin Renvoize martin.renvo...@ptfs-europe.com changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com --- Comment #25 from Martin Renvoize martin.renvo...@ptfs-europe.com --- QA Comment: Should these db action in Context.pm use the dbic variation now days? Other than that, the code looks good to me. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11948] last name browse on patron card creator searching anywhere
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11948 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|NEW |RESOLVED CC||k...@bywatersolutions.com Resolution|--- |FIXED --- Comment #2 from Kyle M Hall k...@bywatersolutions.com --- I believe this behavior has now been fixed in master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11998] Syspref caching issues
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 --- Comment #26 from Martin Renvoize martin.renvo...@ptfs-europe.com --- QA Comment: I also get qa script failure. FAIL C4/Context.pm FAIL critic # Variables::ProhibitConditionalDeclarations: Got 1 violation(s). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11998] Syspref caching issues
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 --- Comment #27 from Martin Renvoize martin.renvo...@ptfs-europe.com --- I also get all Bernardo's failures too.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11998] Syspref caching issues
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11413] Marc modification template has not the expected behavior if the condition and source fields are on the same field
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11413 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment #29 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to M. de Rooy from comment #28) QA Comment: This looks promising, but currently generates a problem: stage-marc-import.pl: Can't call method update on an undefined value at /usr/share/koha/testclone/Koha/SimpleMARC.pm line 214, GEN19 chunk 1. Steps to reproduce: Add/Update field 946 a with value Hi 946. Could you please test this patch set with bug 11395 please? I got the same error without patches from bug 11395. I did not manage to maintain both bug reports bug free independently of each other. They should be tested, QAed and pushed together. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11395] Batch modifications for records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #32240|0 |1 is obsolete|| --- Comment #62 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 33146 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33146action=edit Bug 11395: Add links to the new tool page This patch adds links in the tool module to the new batch tool and in the basket. Signed-off-by: Brendan Gallagher bren...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11395] Batch modifications for records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #32239|0 |1 is obsolete|| --- Comment #61 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 33145 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33145action=edit Bug 11395: Add a batch record modification This patch offers a new tool to modify records in a batch. This feature adds: - a new pl/tt files tools/batch_record_modification - a new permission: tools records_batchmod Test plan for biblios: 0/ Create a new marc modification template with some actions. 1/ Generate a list of biblionumbers you want to modify. There are two ways to generate a list of biblionumbers: - using the basket: do a search, add some biblio to your basket, open the basket and click on the Action button Modify - generating a list from a report 2/ On the Batch record modification tool verify: - information is correct. - the preview link show you the needed record. 3/ After clicking on the Modify selected recors button, verify the records have been modified as you wanted. Test plan for authority: 0/ Create a new marc modification template with some actions. 1/ Generate a list of authid using a report: 2/ On the Batch record modification tool verify: - authorities are display with the summary. - the preview link show you the needed record. 3/ After clicking on the Modify selected recors button, verify the records have been modified as you wanted. Catch of errors: if an error occurs during the modification process, the tool displays an error message. Signed-off-by: Brendan Gallagher bren...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11395] Batch modifications for records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #32241|0 |1 is obsolete|| --- Comment #63 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 33147 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33147action=edit Bug 11395: Fix return for ModifyRecordWithTemplate Make sure the ModifyRecordWithTemplate routine returns undef. This patch also removes a warning if GetModificationTemplates is called without parameter. Verify prove t/db_dependent/MarcModificationTemplates.t returns green. Signed-off-by: Brendan Gallagher bren...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11395] Batch modifications for records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #32242|0 |1 is obsolete|| --- Comment #64 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 33148 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33148action=edit Bug 11395: New service to preview a record. The main patch adds the ability to preview a record. This is done using an AJAX way. The preview record is processed on the server side. Note: I don't think an authentification check is necessary here. Signed-off-by: Brendan Gallagher bren...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11395] Batch modifications for records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #32245|0 |1 is obsolete|| --- Comment #67 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 33151 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33151action=edit Bug 11395: Fix field_numbers This fix is a global fix for the MarcModificationTemplate feature. Some unit tests were missing and some behaviors were wrong. For instance, if you tried to update a non existent field, the script crashed. The following line was completely stupid: if $from_field ne $to_subfield The field_number equals 1 if the user wants to update the first field and 0 for all fields. The field_numbers (note the s) variable contains the field numbers to update. This array is filled if a condition exists (field exists or field equals). Signed-off-by: Brendan Gallagher bren...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11395] Batch modifications for records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #32243|0 |1 is obsolete|| --- Comment #65 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 33149 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33149action=edit Bug 11395: The modification template should be changed on the list view This patch fixes the following issue: If the user comes from a basket, the list view is displayed but there is no way to select the modification template. Now the template can be chosen on the list view. This way, the user is able to change the modifications to apply and see the previewed records. Signed-off-by: Brendan Gallagher bren...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11395] Batch modifications for records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #32244|0 |1 is obsolete|| --- Comment #66 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 33150 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33150action=edit Bug 11395: DB: Add permission tools_records_batchmod Signed-off-by: Brendan Gallagher bren...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11395] Batch modifications for records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #32247|0 |1 is obsolete|| --- Comment #69 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 33153 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33153action=edit Bug 11395: prevent processing no record If no record is selected, the modification should not be launched. Signed-off-by: Brendan Gallagher bren...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11395] Batch modifications for records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #32249|0 |1 is obsolete|| --- Comment #71 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 33155 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33155action=edit Bug 11395: exit should be done after displaying the output Signed-off-by: Brendan Gallagher bren...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11395] Batch modifications for records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #32248|0 |1 is obsolete|| --- Comment #70 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 33154 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33154action=edit Bug 11395: Raise an alert if control field is used If a control field is used with a copy or move action, the interface should block the user in some cases: - If a control field is used with a regular field - The subfield should be empty Signed-off-by: Brendan Gallagher bren...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11395] Batch modifications for records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|BLOCKED |Signed Off --- Comment #72 from Jonathan Druart jonathan.dru...@biblibre.com --- Patches rebased. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11395] Batch modifications for records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #32246|0 |1 is obsolete|| --- Comment #68 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 33152 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33152action=edit Bug 11395: Fix path for the checkboxes jQuery plugin This patch fixes a bad resolution conflict (bug 12107). Signed-off-by: Brendan Gallagher bren...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11413] Marc modification template has not the expected behavior if the condition and source fields are on the same field
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11413 --- Comment #30 from M. de Rooy m.de.r...@rijksmuseum.nl --- (In reply to Jonathan Druart from comment #29) (In reply to M. de Rooy from comment #28) QA Comment: This looks promising, but currently generates a problem: stage-marc-import.pl: Can't call method update on an undefined value at /usr/share/koha/testclone/Koha/SimpleMARC.pm line 214, GEN19 chunk 1. Steps to reproduce: Add/Update field 946 a with value Hi 946. Could you please test this patch set with bug 11395 please? I got the same error without patches from bug 11395. I did not manage to maintain both bug reports bug free independently of each other. They should be tested, QAed and pushed together. If so, please merge them. A squash of patches that edit the same lines multiple items would be helpful too. I appreciate that you did a lot of work here. But QAing these sets takes time too. Just setting the status back to Signed off is not my solution.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11882] Add a new button to the checkout confirmation dialog when checking out a reserved item.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11882 --- Comment #10 from simith.dolive...@inlibro.com --- Created attachment 33156 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33156action=edit Add a new button to the checkout confirmation dialog when checking out a reserved item Bug 11882 - Add a new button to the checkout confirmation dialog when checking out a reserved item -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7380] Can't filter patron search on detail page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7380 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #29697|0 |1 is obsolete|| --- Comment #8 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 33157 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33157action=edit Bug 7380: Refactor the patron search box header A lot of page uses the patron search box header include (git grep patron-search.inc for the list) and the branch and category lists are not generated for all of them. For instance, on a patron detail page, there is a [+] link, but nothing append on clicking on it. This patch add a new template plugin Categories to get all patron categories from the templates. Test plan: 1/ Verify the [+] is working on all patron page (if that works for 2, that should work for all). 2/ Launch a search from the header box and verify the library and category dropdown lists select the correct value. 3/ Launch a search on the patron search page (patron home) and verify the search is working correctly on selecting a category and/or a library -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11882] Add a new button to the checkout confirmation dialog when checking out a reserved item.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11882 simith.dolive...@inlibro.com changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7380] Can't filter patron search on detail page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7380 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff --- Comment #9 from Jonathan Druart jonathan.dru...@biblibre.com --- It applied correctly here but with some Auto-merging. Could you retry with this new patch please? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13096] Send account notice with login details in more situations
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13096 --- Comment #8 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 33158 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33158action=edit Bug 13096: Template changes for memberentry in staff. If AutoEmailOpacUser is enabled, Koha will send an email with account details to the patron at creation time. This report makes it possible to also send this mail when updating patron details, perhaps finishing the registration process at a later stage. This patch makes the needed template changes. It adds a checkbox when a patron is modified (not created/duplicated). It adds javascript to check this checkbox on a username or password change. The staff user can uncheck it again if needed. Test plan: Disable AutoEmailOpacUser. Test adding, duplicating and modifying a patron. You should not see the checkbox. Enable AutoEmailOpacUser. Test adding or duplicating. You should not see the checkbox. Test modifying a patron. If you edit username or password, the checkbox should automatically be checked. You can uncheck it again. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13096] Send account notice with login details in more situations
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13096 --- Comment #9 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 33159 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33159action=edit Bug 13096: Send account notice at patron modification time Instead of sending an account notice only at creation time, this patch makes it possible to generate the same notice when changing account details of the patron. In memberentry.pl, the code for selecting an email address and sending the alert is replaced by calling SendAutoEmail in Members.pm. An additional call is made for the op=save situation; if in that case param mailacctdetails is true (checkbox), a mail will be sent. Note that the script refers to op=duplicate several times. Inspecting the template shows that the duplicate operation also goes via op=insert however. If the password is '!' (disabled), the form now shows the password as blank. If no password is entered, AddMember will insert the ! again. This makes staff more aware of a missing password than showing *. Test plan: [1] Disable AutoEmailOpacUser. Add, duplicate, modify patron. No mails? [2] Enable AutoEmailOpacUser. Add, duplicate patron. Check mail. [3] Modify patron. Check the email checkbox. Did you receive it? [4] Modify patron. Uncheck the email checkbox. No mail? [5] Create a new patron without userid and password. No mail. [6] Edit this patron: a userid has been generated, but the password should be blank. Enter a password. Check mail. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13096] Send account notice with login details in more situations
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13096 --- Comment #10 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 33160 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33160action=edit Bug 13096: Send account notice when user completes self-registration If you have enabled AutoEmailOPACUser, a notice is sent to a patron at creation time. This patch will make Koha send a notice when someone self-registers and submits or follows the verification link. The usercode and password are prefilled on the form, but many patrons will find it helpful to have them in a mail. Instead of creating a new pref for this specific case, I have chosen to extend pref AutoEmailOpacUser. These situations are very similar. The pref text is adjusted in a follow-up. Note: If the user does not enter an email address, he will not receive any notice. (No verification link either.) Test plan: [1] Enable the prefs AutoEmailOPACUser and PatronSelfRegistration. [2] Enable PatronSelfRegistrationVerifyByEmail. [3] Self-register an account. Verify the account with the link in the mail. Check that you receive another mail with account details now. [4] Disable PatronSelfRegistrationVerifyByEmail. [5] Self-register again. Check if you receive a mail when submitting. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13096] Send account notice with login details in more situations
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13096 --- Comment #12 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 33162 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33162action=edit Bug 13096: Adjusting description of pref AutoEmailOPACUser. Test plan: Check the pref rewording in Systempreferences. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13096] Send account notice with login details in more situations
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13096 --- Comment #11 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 33161 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33161action=edit Bug 13096: Send account notice when changing password with member-password Send an alert with account details if AutoEmailOpacUser is enabled and the checkbox was not unchecked. Added license statement and modern perl line to the code. Fixed some other minor issues too: When changing password, the ajax call used userid instead of borrowernumber. Current master does not allow you to change userid only. Test on newpassword in the template was dead. Removed dead destination parameter. Test plan: Disable AutoEmailOpacUser. Goto a patron. Click the Change Password button. No checkbox, no mail. Enable AutoEmailOpacUser. Click Change Password again. Do you receive a mail when saving? Uncheck the checkbox: no mail? Test changing the userid only. Test saving without any changes. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10353] Fines in days (aka suspensions) should be first-class citizen in Koha
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10353 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #5 from Tomás Cohen Arazi tomasco...@gmail.com --- Even when they weren't strictly related, it was fixed as part of bug 2720. So closing this one. Maybe future enhancements will be requested on new bug reports. *** This bug has been marked as a duplicate of bug 2720 *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 2720] Overdues which debar automatically should undebar automatically when returned
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2720 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added CC||tomasco...@gmail.com --- Comment #52 from Tomás Cohen Arazi tomasco...@gmail.com --- *** Bug 10353 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10860] On-site checkouts (was In-House Use)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 --- Comment #86 from Tomás Cohen Arazi tomasco...@gmail.com --- Created attachment 33163 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33163action=edit Bug 10860: Update DBIx Signed-off-by: Tomas Cohen Arazi tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13184] Circulation template problems if OnSiteCheckouts is off but OnSiteCheckoutsForce is on
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13184 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added CC||tomasco...@gmail.com Depends on||13179 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13179] Circulation page layout problem when OnSiteCheckoutsForce is enabled
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13179 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Blocks||13184 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12896] Move the bookseller-related code into its own module
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12896 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #31730|0 |1 is obsolete|| --- Comment #19 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 33164 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33164action=edit Bug 12896: Move the bookseller-related code into Koha::Acquisition::Bookseller The C4::Acquisition module should be exploded in order to add readability and maintainability to this part of the code. This patch is a POC, it introduces a new Koha::Acquisition::Bookseller module and put in it the code from GetBookSeller and GetBookSellerFromId. Test plan: 1/ Create a bookseller, modify it. 2/ Add contacts for this bookseller 3/ Create an order, receive it, transfer it 4/ Launch the prove command on all unit tests modified by this patch and verify that all pass. Signed-off-by: Paola Rossi paola.ro...@cineca.it -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12896] Move the bookseller-related code into its own module
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12896 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Patch doesn't apply |Signed Off --- Comment #20 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to Paola Rossi from comment #18) There only was a small conflict on the number of unit tests. Falling back to patching base and 3-way merge... error: The following untracked working tree files would be overwritten by merge: Koha/Acquisition/Bookseller.pm Please move or remove them before you can merge. Aborting Failed to merge in the changes. Patch failed at 0001 Bug 12896: Move the bookseller-related code into Koha::Acquisition::Bookseller You should remove the file and retry to apply this patch. Back to needs signoff. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12896] Move the bookseller-related code into its own module
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12896 --- Comment #21 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to Jonathan Druart from comment #20) Back to needs signoff. I meant to Signed off! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13188] New: Mandatory fields are wrong in patron personal details page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13188 Bug ID: 13188 Summary: Mandatory fields are wrong in patron personal details page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: fridolyn.som...@biblibre.com QA Contact: testo...@bugs.koha-community.org For an registered patron, the page /cgi-bin/koha/opac-memberentry.pl displays his personal details and allow him to ask for a change. In this page mandatory fields are wrong. It uses PatronSelfRegistrationBorrowerMandatoryField instead of BorrowerMandatoryField. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13188] Mandatory fields are wrong in patron personal details page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13188 Fridolin SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added Assignee|oleon...@myacpl.org |fridolyn.som...@biblibre.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11413] Marc modification template has not the expected behavior if the condition and source fields are on the same field
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11413 --- Comment #31 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to M. de Rooy from comment #30) If so, please merge them. A squash of patches that edit the same lines multiple items would be helpful too. I would not prefer. One is a bugfix (this one), the other is a new feature (11395). I could try to find what fix the problem, but I don't have enough time to do it soon and I don't think it is worth a try. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10860] On-site checkouts (was In-House Use)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 --- Comment #87 from Tomás Cohen Arazi tomasco...@gmail.com --- Created attachment 33165 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33165action=edit Bug 10860: (RM followup) checkout-related sysprefs belong to the checkouts section Signed-off-by: Tomas Cohen Arazi tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12969] VAT and price calculation should be done in a subroutine
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12969 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|BLOCKED |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12976] Refactor VAT and price calculation - invoice page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12976 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|BLOCKED |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12970] Refactor VAT and price calculation - basket page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12970 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|BLOCKED |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13001] Refactor VAT and price calculation - parcel page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13001 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|BLOCKED |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12975] Refactor VAT and price calculation - basketgroup page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12975 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|BLOCKED |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13189] New: Patron card creator patron search browse by last name broken by extended attributes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13189 Bug ID: 13189 Summary: Patron card creator patron search browse by last name broken by extended attributes Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: gmcha...@gmail.com Reporter: k...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org The browse by last name letters on the patron search for the patron card creator doesn't work quite right. If extended patron attributes are disabled, it works fine, but if they are enabled, they are searched even when using the browse last name. Thus, if a searchable attribute has a D in it, and one clicks the D link for the last name browser, that patron will show even if he or she has no D in his or her hame! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13189] Patron card creator patron search browse by last name broken by extended attributes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13189 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Assignee|gmcha...@gmail.com |k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13189] Patron card creator patron search browse by last name broken by extended attributes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13189 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13184] Circulation template problems if OnSiteCheckouts is off but OnSiteCheckoutsForce is on
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13184 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #4 from Tomás Cohen Arazi tomasco...@gmail.com --- Patch pushed to master. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10860] On-site checkouts (was In-House Use)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||tomasco...@gmail.com --- Comment #88 from Tomás Cohen Arazi tomasco...@gmail.com --- Patches pushed to master. Thanks everyone! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13190] New: Export checkout list does not work anymore
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13190 Bug ID: 13190 Summary: Export checkout list does not work anymore Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.dru...@biblibre.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com Bug 11703 breaks the export feature present on the checkout list. On circ/circulation.pl, the export column is there but not the export button. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13190] Export checkout list does not work anymore
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13190 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|NEW |ASSIGNED Depends on||11703 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Blocks||13190 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13190] Export checkout list does not work anymore
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13190 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |jonathan.dru...@biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13179] Circulation page layout problem when OnSiteCheckoutsForce is enabled
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13179 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||tomasco...@gmail.com --- Comment #4 from Tomás Cohen Arazi tomasco...@gmail.com --- Patch pushed to master. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13190] Export checkout list does not work anymore
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13190 --- Comment #1 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 33166 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33166action=edit Bug 13190: Reintroduce the checkouts export feature Bug 11703 breaks the checkouts export feature. To reproduce: Fill the ExportWithCsvProfile pref and go on the circ/circulation.pl page. The export column appears, but not the export button. Test plan: Go on the checkout list (circ/circulation.pl and members/moremember.pl) and verify the export column and the export button appears. If you click on the button, a file should be generated. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 --- Comment #188 from Jonathan Druart jonathan.dru...@biblibre.com --- This feature introduces a bug: it's not possible to export the checkout list. See bug 13190 for a fix. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13190] Export checkout list does not work anymore
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13190 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13190] Export checkout list does not work anymore
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13190 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #33166|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13190] Export checkout list does not work anymore
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13190 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Needs Signoff |ASSIGNED --- Comment #2 from Jonathan Druart jonathan.dru...@biblibre.com --- It does not work. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11201] List pending in-house uses
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11201 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Keywords||rel_3_18_candidate CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13190] Export checkout list does not work anymore
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13190 --- Comment #3 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 33167 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33167action=edit Bug 13190: Reintroduce the checkouts export feature Bug 11703 breaks the checkouts export feature. To reproduce: Fill the ExportWithCsvProfile pref and go on the circ/circulation.pl page. The export column appears, but not the export button. Test plan: Go on the checkout list (circ/circulation.pl and members/moremember.pl) and verify the export column and the export button appears. If you click on the button, a file should be generated. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13190] Export checkout list does not work anymore
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13190 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12404] CSV profiles improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12404 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Depends on||13190 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13190] Export checkout list does not work anymore
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13190 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Blocks||12404 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13183] Improve visibility of automatic on-site checkout rule when OnSiteCheckoutsForce is on
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13183 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13183] Improve visibility of automatic on-site checkout rule when OnSiteCheckoutsForce is on
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13183 --- Comment #2 from Owen Leonard oleon...@myacpl.org --- Created attachment 33168 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33168action=edit Bug 13183 - Improve visibility of automatic on-site checkout rule when OnSiteCheckoutsForce is on This patch addresses the case where OnSiteCheckoutsForce is enabled and the user is checking out to a patron who is blocked from checking out. Instead of showing the 'specify due date' form (which is disabled) this patch hides it and highlights the on-site checkout controls. This patch adds some CSS and consolidates some redundant CSS. To test, load a patron for checkout under the following conditions: 1. OnSiteCheckoutsForce is off and patron is not blocked from checkout 2. OnSiteCheckoutsForce is off, patron is blocked from checkout (for being expired or restricted). 3. OnSiteCheckoutsForce is on and patron is not blocked from checkout 4. OnSiteCheckoutsForce is on and patron is blocked from checkout -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13190] Export checkout list does not work anymore
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13190 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #33167|0 |1 is obsolete|| --- Comment #4 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 33169 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33169action=edit Bug 13190: Reintroduce the checkouts export feature Bug 11703 breaks the checkouts export feature. To reproduce: Fill the ExportWithCsvProfile pref and go on the circ/circulation.pl page. The export column appears, but not the export button. Test plan: Go on the checkout list (circ/circulation.pl and members/moremember.pl) and verify the export column and the export button appears. If you click on the button, a file should be generated. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12404] CSV profiles improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12404 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #28768|0 |1 is obsolete|| --- Comment #8 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 33171 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33171action=edit Bug 12404: Add new unit tests These unit tests reflect the changes done in next patches. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12404] CSV profiles improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12404 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #28770|0 |1 is obsolete|| --- Comment #10 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 33173 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33173action=edit Bug 12404: tools/export.pl allows CSV export -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12404] CSV profiles improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12404 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #28767|0 |1 is obsolete|| --- Comment #7 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 33170 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33170action=edit Bug 12404: Add UT for marcrecord2csv Verify that these unit tests pass before any changes and after applying all patches. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12404] CSV profiles improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12404 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #28769|0 |1 is obsolete|| --- Comment #9 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 33172 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33172action=edit Bug 12404: Allow TT tags for csv profiles This patch is the main patch. It contains the changes in C4::Record::marcrecord2csv. The goal of this development is to provide a better flexibility on creating a CSV profile. Currently it is not possible to: - Concatenate specific subfields into a csv column - Display a field/subfield using a condition - Extract a substring of a subfield value and a lot of other actions. This patch allows to write Template Toolkit code and to extract only data you want. See the help page for more information (in next patch). Test plan: Create some CSV profiles (MARC, not SQL) using some TT methods. Use the basket export and the export tool and verify the CSV file generated is what you expected. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12404] CSV profiles improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12404 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #28771|0 |1 is obsolete|| --- Comment #11 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 33174 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33174action=edit Bug 12404: Add some documentation in the help page. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12404] CSV profiles improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12404 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff --- Comment #12 from Jonathan Druart jonathan.dru...@biblibre.com --- Bug 10703 introduces a big regression, see bug 13190. Has to be apply before this patch set. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13096] Send account notice with login details in more situations
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13096 --- Comment #13 from M. de Rooy m.de.r...@rijksmuseum.nl --- Will still make some small adjustments before setting to Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13191] New: Null borrowernumber in reserves table
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13191 Bug ID: 13191 Summary: Null borrowernumber in reserves table Change sponsored?: --- Product: Koha Version: 3.16 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: hbr...@nekls.org QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com Occasionally, we have reserves placed on our system without a linked borrowernumber. It displays as NULL in the reserves table of the database. I cannot recreate how this behavior is happening so far, except to say it appears to originate on the public side of the system. Some debugging code was added to C4::Reserves::AddReserve on our system, and the logs revealed it's a call to AddReserve where no borrowernumber is passed in -- on the OPAC side. Has anyone else seen this behavior? Know why it's happening? Thanks! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12823] Add some hints for Host, Database and SRU search fields mappings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12823 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Keywords||rel_3_18_candidate CC||tomasco...@gmail.com Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8753] Add forgot password link to OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #55 from simith.dolive...@inlibro.com --- Created attachment 33175 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33175action=edit Bug 8753 - Add forgot password link to OPAC - Updated -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8753] Add forgot password link to OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 simith.dolive...@inlibro.com changed: What|Removed |Added Status|ASSIGNED|Needs Signoff CC||simith.dolive...@inlibro.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8753] Add forgot password link to OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #56 from simith.dolive...@inlibro.com --- Created attachment 33176 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33176action=edit Bug 8753 - Add forgot password link to OPAC - DBIx Schema Added -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13192] New: Hard-coded value (ISBN Prefix '978') in cataloguing::value_builder::unimarc_field_010
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13192
Bug ID: 13192
Summary: Hard-coded value (ISBN Prefix '978') in
cataloguing::value_builder::unimarc_field_010
Change sponsored?: ---
Product: Koha
Version: unspecified
Hardware: All
OS: All
Status: NEW
Severity: trivial
Priority: P5 - low
Component: MARC Bibliographic data support
Assignee: gmcha...@gmail.com
Reporter: tiburce.euphra...@aupaysdescrevettes.org
QA Contact: testo...@bugs.koha-community.org
Aloha,
Frédéric Demians suggests me to open a new bug report for this case (please
read http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13167 for more
information):
...I think I've also detected a small problem in
cataloguing::value_builder::unimarc_field_010 :
[...] Line 94 to 96 :
if (length ($isbn) == 13){
$isbn = substr($isbn, 3, length($isbn)-3);
}
[...] Then, line 143 :
$sth-execute($seg2, 978$seg2);
This 978 on line 143 is hard-coded and there's no relation with the original
data inside $isbn (lost on line 95 via the substr function). I don't know if
this is a real problem but it might be better to keep the original data than
replacing it with 978.
Thanks to Frédéric Demians for resolving bug 13167.
Aloha.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6681] When importing a biblio record via Z39.50, authority links and items also get imported
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6681 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Attachment #31181|0 |1 is obsolete|| --- Comment #19 from Tomás Cohen Arazi tomasco...@gmail.com --- Created attachment 33177 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33177action=edit Bug 6681: introduce XSLT scripts to remove items and links This patch adds the following sample files: - Del952.xsl - Del995.xsl - Del9LinksExcept952.xsl - Del9LinksExcept995.xsl Thay can be used on the new SRU/Z39.50 XSLT processing feature. At the same time they can be used to solve this bug. To test: - Have an SRU/Z39.50 target configured - Have a search that returns at least a record with the following properties: * It contains $9 links * It contains items (952 or 995 fields in MARC21/NORMARC and UNIMARC respectively). MARC21/NORMARC test: - Do a Z39.50/SRU cataloguing search that retrieves the desired record - Verify it includes $9 and 952 field(s) by clicking on the MARC link - Edit your Z39.50 target and add Del952.xsl to the XSLT File(s) for transforming results: field - Re-run the search = SUCCESS: the MARC view of the imported record doesn't contain the 952 field - Edit your Z39.50 target and add Del9LinksExcept952.xsl to the XSLT File(s) for transforming results: field - Re-run the search = SUCCESS: the MARC view contains the 952 field (including the $9 subfield), and all other $9 subfields have been removed - Edit your Z39.50 target and add Del952.xsl, Del9LinksExcept952.xsl to the XSLT File(s) for transforming results: field (both, comma separated) - Re-run the search = SUCCESS: the MARC view doesn't contain $9 subfields nor items. - Repeat for UNIMARC, replacing 952 for 995. - Sign off :-D Regards Tomas Sponsored-by: Universidad Nacional de Cordoba -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
