[Koha-bugs] [Bug 12718] Show extended patron attributes in the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12718 Fridolin SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added CC||fridolyn.som...@biblibre.co ||m --- Comment #8 from Fridolin SOMERS fridolyn.som...@biblibre.com --- *** Bug 12053 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12053] Borrower attributes not visible anymore at OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12053 Fridolin SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added Resolution|INVALID |DUPLICATE --- Comment #3 from Fridolin SOMERS fridolyn.som...@biblibre.com --- I found the correction in Bug 12718 *** This bug has been marked as a duplicate of bug 12718 *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12718] Show extended patron attributes in the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12718 --- Comment #9 from Fridolin SOMERS fridolyn.som...@biblibre.com --- (In reply to Nicole C. Engard from comment #7) Will this be backported to 3.16.x ? I'd like this too. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13459] Datatables paging slightly broken
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13459 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #34735|0 |1 is obsolete|| Attachment #34736|0 |1 is obsolete|| --- Comment #6 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 34779 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34779action=edit Bug 13459: Fix datatables paging for admin itemtypes To test: - Go to administration itemtypes - Verify the display of the paging options is broken - Apply patch - Verify the display is now correct and works nicely Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13459] Datatables paging slightly broken
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13459 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13459] Datatables paging slightly broken
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13459 --- Comment #7 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 34780 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34780action=edit Bug 13459: Fix datatables paging for patron lists The display of the datatables paging options for the patron list feature is broken. To test: - Go to tools patron lists - The paging for the 'list of lists' is broken - Select a patron list 'Add more patrons' - Notice the paging on this page is also broken - Apply patch - Verify both pages now display the paging correctly Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12944] There is no way to search orders by creator
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12944 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12944] There is no way to search orders by creator
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12944 --- Comment #19 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 34781 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34781action=edit Bug 12944: Fix regression on translating This patch fixes the translation for the Remove button. Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11023] Toggle new status for items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #33226|0 |1 is obsolete|| --- Comment #66 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 34782 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34782action=edit Bug 11023: Toggle new status This patch adds: - a new DB field items.new. - a new page to configure this new status (tools/toggle_new_status.pl). - a new cronjob script (misc/cronjob/toggle_new_status.pl). Why this status is useful for some libraries ? The use cases are: - to know easily what are the new items (with a simple sql query). - to display an icon in the search results. - issuing rules can be adapt for new items. Automatically (using the cronjob script), the status change (depending the configuration) and the item can be issued, for example. - a RSS/Atom feeds can be created on these new items. Test plan: - log in with a librarian having the tools items_batchmod permission. - navigate to Home Tools Toggle new status - click on the edit button - there are 3 blocks: * duration: the duration during an item is considered as new. * conditions: the status will change only if the conditions are meet. * substitutions: if there is no substitution, no action will be done. You can add some change to apply to the matching items. E.g. ccode=3 new='' If the value is an empty string (in other words, the input does not contain anything), the field will be deleted. You can create as many rules as you want. - test the interface : add/remove rule, conditions, substitutions, submit the form, edit, etc. (There is a looot of JS everywhere, so certainly a looot of bugs...). - when you have your rules defined, you can now launch the cronjob script without any parameter. A report will be displayed with the matching itemnumber and the substitutions to apply. Verify results are consistent. - launch the script with the -c argument and verify values have been modified depending the substitution rules. Signed-off-by: juliette et rémy juliette.lev...@iepg.fr -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11023] Toggle new status for items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #33229|0 |1 is obsolete|| --- Comment #69 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 34785 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34785action=edit Bug 11023: FIX - condition on biblioitems table does not work If a rule contains a condition on the biblioitems table, the match won't work. This patch fixes this issue. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11023] Toggle new status for items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #33230|0 |1 is obsolete|| --- Comment #70 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 34786 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34786action=edit Bug 11023: Use DBIx-Class to retrieve column names -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11023] Toggle new status for items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #33228|0 |1 is obsolete|| --- Comment #68 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 34784 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34784action=edit Bug 11023: Add UT for C4::Items::ToggleNewStatus Test plan: prove t/db_dependent/Items/ToggleNewStatus.t Signed-off-by: juliette et rémy juliette.lev...@iepg.fr -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11023] Toggle new status for items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #33227|0 |1 is obsolete|| --- Comment #67 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 34783 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34783action=edit Bug 11023: Add the ability to specify fields from biblioitems table. Test plan: Same as before but try with fields from the biblioitems table. Signed-off-by: juliette et rémy juliette.lev...@iepg.fr -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11023] Toggle new status for items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #33231|0 |1 is obsolete|| --- Comment #71 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 34787 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34787action=edit Bug 11023: Don't use the biblioitems fields for the subtitution It's dangerous to allow a change on the biblioitems fields with this feature. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11023] Toggle new status for items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #33232|0 |1 is obsolete|| --- Comment #72 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 34788 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34788action=edit Bug 11023: DB changes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11023] Toggle new status for items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Patch doesn't apply |Signed Off --- Comment #76 from Jonathan Druart jonathan.dru...@biblibre.com --- Patches rebased. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11023] Toggle new status for items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #33235|0 |1 is obsolete|| --- Comment #75 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 34791 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34791action=edit Bug 11023: Change the name of the feature Originaly this feature only permits to update the new field. Now all item fields can be updated. The name of the feature is now Automatic item modifications by age. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11023] Toggle new status for items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #33234|0 |1 is obsolete|| --- Comment #74 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 34790 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34790action=edit Bug 11023: The age parameter should be a number The template should check if the age parameter is correctly filled (should be a number). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11023] Toggle new status for items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #33233|0 |1 is obsolete|| --- Comment #73 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 34789 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34789action=edit Bug 11023: Rename the duration parameter with 'age' -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13014] Sent an email to budget owner when a suggestion can be treated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13014 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #33267|0 |1 is obsolete|| --- Comment #16 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 34794 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34794action=edit Bug 13014: Notify budget owner on new suggestion - cronjob Test plan: 0/ Create a new notice suggestions TO_PROCESS You can use the one defined in the other patch. 1/ Create a suggestion and link it to a fund 2/ Add a owner to this fund and make sure this patron has an email address (the email address used should be the one defined in the AutoEmailPrimaryAddress syspref). 3/ Execute the cronjob script with the -v and without the -c argument 4/ The output should tell you that an email will be sent 5/ Execute the cronjob script with the -v and with the -c argument 6/ Verify the notice is generated in the message_queue table and it is correctly formatted. Signed-off-by: Frederic Demians f.demi...@tamil.fr -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13014] Sent an email to budget owner when a suggestion can be treated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13014 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #33293|0 |1 is obsolete|| --- Comment #17 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 34795 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34795action=edit Bug 13014: (follow-up) Notify budget owner on new suggestion - sample notices This patch adds the new notice for all other languages. Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13014] Sent an email to budget owner when a suggestion can be treated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13014 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Patch doesn't apply |Signed Off --- Comment #19 from Jonathan Druart jonathan.dru...@biblibre.com --- Patches rebased. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13014] Sent an email to budget owner when a suggestion can be treated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13014 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #33294|0 |1 is obsolete|| --- Comment #18 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 34796 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34796action=edit Bug 13014: (follow-up 2) Notify budget owner on new suggestion - sample notices This patch updates the 2 optional sample_notices.sql files for ru-RU and uk-UA. Not sure if it is relevant but I don't understand why they are not up-to-date. Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13014] Sent an email to budget owner when a suggestion can be treated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13014 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #33266|0 |1 is obsolete|| --- Comment #15 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 34793 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34793action=edit Bug 13014: Notify budget owner on new suggestion - sample notices This patch add the new notice suggestion TO_PROCESS Others will be added when the patch will be signed off. Signed-off-by: Frederic Demians f.demi...@tamil.fr Followup expected :-) It would be nice also to have an updatabase.pl entry to insert the new TO_PROCESS notification. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13014] Sent an email to budget owner when a suggestion can be treated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13014 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #33265|0 |1 is obsolete|| --- Comment #14 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 34792 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34792action=edit Bug 13014: Notify budget owner on new suggestion - UT When a suggestion is created and linked to a fund, a mail will be generated, using a cronjob, to notify the budget owner. A suggestion is considered as can be treated if its status is ASKED. Signed-off-by: Frederic Demians f.demi...@tamil.fr -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12993] Add a default tax rate on item types
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12993 --- Comment #17 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 34797 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34797action=edit Bug 12993: Add a default tax rate on item types - DB changes This patch adds a new DB field: itemtypes.gstrate Signed-off-by: Paola Rossi paola.ro...@cineca.it -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12993] Add a default tax rate on item types
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12993 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #33306|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12993] Add a default tax rate on item types
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12993 --- Comment #18 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to Katrin Fischer from comment #16) Note for later: Add bug number to datebase update message Done. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12975] Refactor VAT and price calculation - basketgroup page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12975
--- Comment #10 from Jonathan Druart jonathan.dru...@biblibre.com ---
(In reply to Katrin Fischer from comment #8)
Comment on attachment 31981 [details] [review]
Bug 12975: Use the centralize VAT and prices calculation - basketgroup.pl
Review of attachment 31981 [details] [review]:
-
::: acqui/basketgroup.pl
@@ -212,5 @@
}
}
-my $ba_order = {
-isbn = ($ord-{isbn} ? $ord-{isbn} : undef),
Hi Jonathan, bit irritated by this line - was removing it intentional? I see
that that PDF should be printing the ISBN, but have a bit of trouble making
it work in my installation currently.
Hi Katrin,
Yes it is intentional.
Actually before the patch, the $ba_order was pushed to @ba_orders.
Now, the order $ord is pushed.
We could add:
$ord-{isbn} = $ord-{isbn} ? $order-{isbn} : undef;
But it does not make sense, except if we need to manage the empty string or 0,
but it would not be a valid ISBN.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13264] Test about UTF-8 (bug 11944)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264 Zeno Tajoli z.taj...@cineca.it changed: What|Removed |Added Attachment #34766|0 |1 is obsolete|| --- Comment #58 from Zeno Tajoli z.taj...@cineca.it --- Created attachment 34798 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34798action=edit UNIMARC and MARC21 records to test UTF-8 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13264] Test about UTF-8 (bug 11944)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264 Zeno Tajoli z.taj...@cineca.it changed: What|Removed |Added Attachment #34767|0 |1 is obsolete|| --- Comment #59 from Zeno Tajoli z.taj...@cineca.it --- Created attachment 34799 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34799action=edit Test for utf-8 on Opac search -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13264] Test about UTF-8 (bug 11944)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264 Zeno Tajoli z.taj...@cineca.it changed: What|Removed |Added Attachment #34768|0 |1 is obsolete|| --- Comment #60 from Zeno Tajoli z.taj...@cineca.it --- Created attachment 34800 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34800action=edit Test for utf-8 on authorised values input/display/delete -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13264] Test about UTF-8 (bug 11944)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264 Zeno Tajoli z.taj...@cineca.it changed: What|Removed |Added Attachment #34769|0 |1 is obsolete|| --- Comment #61 from Zeno Tajoli z.taj...@cineca.it --- Created attachment 34801 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34801action=edit no need to test for MySQL -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13264] Test about UTF-8 (bug 11944)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264 Zeno Tajoli z.taj...@cineca.it changed: What|Removed |Added Attachment #34771|0 |1 is obsolete|| --- Comment #63 from Zeno Tajoli z.taj...@cineca.it --- Created attachment 34803 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34803action=edit Follow up: in opac_utf8.t insert also delete of biblio -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13264] Test about UTF-8 (bug 11944)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264 Zeno Tajoli z.taj...@cineca.it changed: What|Removed |Added Attachment #34770|0 |1 is obsolete|| --- Comment #62 from Zeno Tajoli z.taj...@cineca.it --- Created attachment 34802 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34802action=edit Make opac_utf8.t launch its own helper processes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13264] Test about UTF-8 (bug 11944)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264 Zeno Tajoli z.taj...@cineca.it changed: What|Removed |Added Attachment #34772|0 |1 is obsolete|| --- Comment #64 from Zeno Tajoli z.taj...@cineca.it --- Created attachment 34804 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34804action=edit Additional test for search in intranet calatogue -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13264] Test about UTF-8 (bug 11944)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264 Zeno Tajoli z.taj...@cineca.it changed: What|Removed |Added Attachment #34773|0 |1 is obsolete|| --- Comment #65 from Zeno Tajoli z.taj...@cineca.it --- Created attachment 34805 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34805action=edit Refactor search utf8 tests and add some more -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13264] Test about UTF-8 (bug 11944)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264 Zeno Tajoli z.taj...@cineca.it changed: What|Removed |Added Attachment #34774|0 |1 is obsolete|| --- Comment #66 from Zeno Tajoli z.taj...@cineca.it --- Created attachment 34806 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34806action=edit QA followup - prevent double-encoding on the tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13264] Test about UTF-8 (bug 11944)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264 Zeno Tajoli z.taj...@cineca.it changed: What|Removed |Added Attachment #34775|0 |1 is obsolete|| --- Comment #67 from Zeno Tajoli z.taj...@cineca.it --- Created attachment 34807 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34807action=edit Duplicate record in marc21 and unimarc files to show more than one result -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13264] Test about UTF-8 (bug 11944)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264 --- Comment #68 from Zeno Tajoli z.taj...@cineca.it --- Created attachment 34808 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34808action=edit Add a test for Auth values to check chars that could be utf-8 or latin-1 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13346] The type of the OpacExportOptions pref should be multiple
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13346 --- Comment #4 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to Katrin Fischer from comment #3) The new list is much nicer, but it adds a small regression - you can no longer change the sequence the options are displayed in. I think if someone really wanted to, they can do so via SQL, so probably not worth holding this up. To be fair, I did not think about that. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13264] Test about UTF-8 (bug 11944)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264 Zeno Tajoli z.taj...@cineca.it changed: What|Removed |Added Attachment #34776|0 |1 is obsolete|| --- Comment #69 from Zeno Tajoli z.taj...@cineca.it --- Created attachment 34809 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34809action=edit Add two new file .mrc for marc21 and unimarc to test chars utf8/latin1 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13264] Test about UTF-8 (bug 11944)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264 --- Comment #70 from Zeno Tajoli z.taj...@cineca.it --- Created attachment 34810 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34810action=edit Update of unimarc and marc21 new test files to seach publisher -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13264] Test about UTF-8 (bug 11944)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264 --- Comment #71 from Zeno Tajoli z.taj...@cineca.it --- Created attachment 34811 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34811action=edit New test in search_utf8.t to manage chars in utf8/latin1 ambiguity -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13264] Test about UTF-8 (bug 11944)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264 Zeno Tajoli z.taj...@cineca.it changed: What|Removed |Added Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13264] Test about UTF-8 (bug 11944)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264 --- Comment #72 from Zeno Tajoli z.taj...@cineca.it --- Now I have complete tests also for the chars that could be utf-8 and latin-1 i the same time. There are new test .mrc files in www/data: unimarclatin1utf8rec.mrc marc21latin1utf8rec.mrc In search_utf8.t now the test on search is a routine, so it is more easy to add new records and new test cases. I insert 'Needs Signoff' because there are many new situations. To test: prove search_utf8.t prove auth_values_input_www.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13264] Test about UTF-8 (bug 11944)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264
--- Comment #73 from Jonathan Druart jonathan.dru...@biblibre.com ---
Quick notes:
1/ I had to add a 'b7' branches to remove the following error in koha logs:
manage-marc-import.pl: DBD::mysql::st execute failed: Cannot add or update a
child row: a foreign key constraint fails (`koha_ut`.`items`, CONSTRAINT
`items_ibfk_2` FOREIGN KEY (`homebranch`) REFERENCES `branches` (`branchcode`)
ON UPDATE CASCADE) at /home/koha/src/C4/Items.pm line 2171.
2/ With the last patches, the tests don't pass:
t/db_dependent/www/search_utf8.t .. 18/64 Error GETing
http://pro.koha-qa.vm/cgi-bin/koha/catalogue/search.pl?idx=kwq=%CE%91%CE%B8%CE%AE%CE%BD%CE%B1idx=kwidx=kwsort_by=relevance:
Internal Server Error at t/db_dependent/www/search_utf8.t line 245.
# Looks like you planned 64 tests but ran 18.
# Looks like your test exited with 255 just after 18.
To make them pass, I need to (manually) revert the Tomas's patch:
diff --git a/t/db_dependent/www/search_utf8.t
b/t/db_dependent/www/search_utf8.t
index be5ac96..12dbc41 100644
--- a/t/db_dependent/www/search_utf8.t
+++ b/t/db_dependent/www/search_utf8.t
@@ -233,7 +233,7 @@ sub test_search{
$agent-get_ok( $intranet/cgi-bin/koha/catalogue/search.pl , got search
on intranet);
$agent-form_number(1);
$agent-field('idx', 'kw');
-$agent-field('q', $search_key);
+$agent-field('q', Encode::encode('UTF-8', $search_key));
$agent-click();
my $intra_text = $agent-text() ;
like( $intra_text, qr|Publisher: $publisher|, );
@@ -241,12 +241,12 @@ sub test_search{
$agent-get_ok( $intranet/cgi-bin/koha/catalogue/search.pl , got search
on intranet);
$agent-form_number(1);
$agent-field('idx', 'kw');
-$agent-field('q', $publisher);
+$agent-field('q', Encode::encode('UTF-8', $publisher));
$agent-click();
$intra_text = $agent-text();
like( $intra_text, qr|Publisher: $publisher|, );
-my $expected_base = q|search.pl\?idx=kwq=| . uri_escape_utf8( $publisher
);
+my $expected_base = q|search.pl\?idx=kwq=| . uri_escape_utf8(
Encode::encode('UTF-8', $publisher ));
$agent-base_like(qr|$expected_base|, );
ok ( ( length(Encode::encode('UTF-8', $intra_text)) != length($intra_text)
) , 'UTF-8 are multi-byte. Goog') ;
@@ -269,7 +269,7 @@ sub test_search{
$opac_text = $agent-text();
like( $opac_text, qr|Publisher: $publisher|, );
-$expected_base = q|opac-search.pl\?idx=q=| . uri_escape_utf8( $publisher
);
+$expected_base = q|opac-search.pl\?q=| . uri_escape_utf8( $publisher );
$agent-base_like(qr|$expected_base|, );
ok ( ( length(Encode::encode('UTF-8', $opac_text)) != length($opac_text) )
, 'UTF-8 are multi-byte. Goog') ;
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12975] Refactor VAT and price calculation - basketgroup page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12975 --- Comment #11 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Hi Jonathan, I think you lost me there, but I believe you :) It looks like the printed PDF should include the ISBN, which also seems crucial for an order to a vendor. Does it print for you? It didn't for me, so maybe that's a separate bug to file. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13320] Some prices calculation are done in template side
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13320 --- Comment #7 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 34812 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34812action=edit on master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13320] Some prices calculation are done in template side
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13320 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #34812|0 |1 is obsolete|| --- Comment #8 from Jonathan Druart jonathan.dru...@biblibre.com --- Comment on attachment 34812 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34812 on master forget that. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11982] Show local cover images in the biblio details page in the intranet.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11982 --- Comment #21 from simith.dolive...@inlibro.com --- Created attachment 34813 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34813action=edit Bug 11982 - Images now display properly in the details section. If the a cover image exists, it will be displayed on the details page. Nothing is displayed of there is no cover available. modified: koha-tmpl/intranet-tmpl/prog/en/js/localcovers.js modified: koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt Signed-off-by: Owen Leonard oleon...@myacpl.org Signed-off-by: Katrin Fischer katrin.fischer...@web.de Works as described, passes tests and QA script. Checked Amazon covers and local covers display correctly in staff on results and detail pages. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13320] Some prices calculation are done in template side
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13320 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment #9 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to Katrin Fischer from comment #5) Created attachment 34759 [details] invoice - master Hi Jonathan, I hope I applied all the dependencies correctly: 12896 12969 13001 13320 Bug 13001 depends on bug 12976, which is missing. The issue is fixed when the patches from bug 12976 are applied. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12975] Refactor VAT and price calculation - basketgroup page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12975 --- Comment #12 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to Katrin Fischer from comment #11) Hi Jonathan, I think you lost me there, but I believe you :) It looks like the printed PDF should include the ISBN, which also seems crucial for an order to a vendor. Does it print for you? It didn't for me, so maybe that's a separate bug to file. Yes, I see it with English 3-pages with and without the patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11982] Show local cover images in the biblio details page in the intranet.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11982 simith.dolive...@inlibro.com changed: What|Removed |Added Attachment #34813|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13264] Test about UTF-8 (bug 11944)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264 --- Comment #74 from Zeno Tajoli z.taj...@cineca.it --- Created attachment 34814 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34814action=edit Follow up on record files: deleted fields with item info (952/995) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13264] Test about UTF-8 (bug 11944)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264 --- Comment #75 from Zeno Tajoli z.taj...@cineca.it --- (In reply to Jonathan Druart from comment #73) 1/ I had to add a 'b7' branches to remove the following error in koha logs: manage-marc-import.pl: DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key constraint fails (`koha_ut`.`items`, CONSTRAINT `items_ibfk_2` FOREIGN KEY (`homebranch`) REFERENCES `branches` (`branchcode`) ON UPDATE CASCADE) at /home/koha/src/C4/Items.pm line 2171. The last commit [ Follow up on record files: deleted fields with item info (952/995)] fixes this problem. In fact item's info are not useful for this test so I delete the fields with item's info inside. The fields deleted are: 952 (MARC21) and 995 (UNIMARC) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11982] Show local cover images in the biblio details page in the intranet.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11982 --- Comment #22 from simith.dolive...@inlibro.com --- Created attachment 34815 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34815action=edit Bug 11982 - Show local cover image in the intranet biblio details page Also, fix useless No cover image block when using Amazon and local cover images at the same time. http://bugs.koha-community.org/show_bug.cgi?id=11982 Signed-off-by: Owen Leonard oleon...@myacpl.org Signed-off-by: Katrin Fischer katrin.fischer...@web.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12954] Questionable logic regarding session handling in C4::Auth::checkauth()
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12954
--- Comment #7 from Martin Renvoize martin.renvo...@ptfs-europe.com ---
Comment on attachment 34551
-- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34551
Bug 12954 - Questionable logic regarding session handling in
C4::Auth::checkauth()
Review of attachment 34551:
--
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.htmlbug=12954attachment=34551)
-
First comments, but nothing really important so far..
Still working my way through the logic for the second part
::: C4/Auth.pm
@@ +780,4 @@
}
elsif ( !$lasttime || ($lasttime time() - $timeout) ) {
# timed logout
+$info{'timed_out'} = 1 if $lasttime;
This feels unrelated to me, as such I'de rather see it in it's own bug rather
than confusing the issue here.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11982] Show local cover images in the biblio details page in the intranet.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11982 simith.dolive...@inlibro.com changed: What|Removed |Added Attachment #34815|0 |1 is obsolete|| --- Comment #23 from simith.dolive...@inlibro.com --- Created attachment 34816 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34816action=edit Bug 11982 - Show local cover image in the intranet biblio details page - conflit fixed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11982] Show local cover images in the biblio details page in the intranet.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11982 simith.dolive...@inlibro.com changed: What|Removed |Added Attachment #32746|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11982] Show local cover images in the biblio details page in the intranet.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11982 simith.dolive...@inlibro.com changed: What|Removed |Added Attachment #32747|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11982] Show local cover images in the biblio details page in the intranet.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11982 simith.dolive...@inlibro.com changed: What|Removed |Added Attachment #32748|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12954] Questionable logic regarding session handling in C4::Auth::checkauth()
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12954 --- Comment #8 from Martin Renvoize martin.renvo...@ptfs-europe.com --- I think I would prefer to see this done 'properly', i.e. setting the session to anon and ensuring it's tested for to prevent the loop we're finding here. I'll have a play around and see if I can achieve this, unless you want to refine your attempt Jacek -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11982] Show local cover images in the biblio details page in the intranet.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11982 simith.dolive...@inlibro.com changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13497] New: The pref AddPatronLists should be removed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13497 Bug ID: 13497 Summary: The pref AddPatronLists should be removed Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcha...@gmail.com Reporter: jonathan.dru...@biblibre.com QA Contact: testo...@bugs.koha-community.org The pref AddPatronLists does not work as expected if 'generic' is selected. Indeed a patron should be linked to a valid patron category (see the constraint borrowers_ibfk_1 in the DB structure). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13458] Add new patron shows default / hardcoded patron categories after search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13458 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=13497 --- Comment #6 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to Katrin Fischer from comment #4) Note: I am not sure if AddPatronLists makes sense - if you set it to general patron types, it still preselects the wrong category type (tried organization, a child patron category was selected). Also the name is confusiong nowadays with the Patron list feature. Agreed, cf bug 13497. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13497] The pref AddPatronLists should be removed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13497 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=13458 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13497] The pref AddPatronLists should be removed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13497 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|gmcha...@gmail.com |jonathan.dru...@biblibre.co ||m Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13497] The pref AddPatronLists should be removed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13497 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13497] The pref AddPatronLists should be removed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13497 --- Comment #1 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 34817 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34817action=edit Bug 13497: Remove the pref AddPatronsLists The pref AddPatronLists does not work as expected if 'generic' is selected. Indeed a patron should be linked to a valid patron category (see the constraint borrowers_ibfk_1 in the DB structure). Test plan: 0/ Confirm that the AddPatronLists does not work as expected if you choose the generic patron types. 1/ Delete all you patron categories and check that the interface invites you to create one. 2/ Confirm that you are able to create a patron and to link it to a patron category you have created. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13498] New: ISSUESLIP, ISSUEQSLIP use 'email' template for print.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13498 Bug ID: 13498 Summary: ISSUESLIP, ISSUEQSLIP use 'email' template for print. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: bar...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org I set up print slips for ISSUESLIP and ISSUEQSLIP using the 'print' template. When I print from circ/circulation.pl using either Print Slip or Print Quick Slip, I get the text from the the email template. To reproduce: Edit the 'email' and 'print' templates for ISSUEQSLIP and ISSUESLIP. Make sure that the email and print templates contain different text. koha staff client URL/cgi-bin/koha/tools/letter.pl?op=add_formbranchcode=module=circulationcode=ISSUEQSLIP koha staff client URL/cgi-bin/koha/tools/letter.pl?op=add_formbranchcode=module=circulationcode=ISSUESLIP Check out items to a test patron. On the check-out page, select Print-Print Slip. Print the slip. Do the same for 'Print quick slip'. Note that the text from the 'email' template is used. When resolving this bug, a bit of thought is going to be required, because 'Print' is the primary use of this slip, so it should come first in the list, but we don't want to create a slap-dash one-off of the print slip template page just to accommodate that. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13498] ISSUESLIP, ISSUEQSLIP use 'email' template for print.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13498 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #1 from Katrin Fischer katrin.fisc...@bsz-bw.de --- I think the slips are different to the other notices, as they can only be printed and are not made to be used with other transport options. Maybe it would be worth hiding the other options in this case and only offer print? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677 Paola Rossi paola.ro...@cineca.it changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #46 from Paola Rossi paola.ro...@cineca.it --- I've applied the patches against master 3.19.00.003 [it needed a trivial rebase] I set makePreviousSerialAvailable syspref to Make as required. I kept the item-level_itypes syspref to specific item. I created a subscription, which didn't create an item record when it received the serial. When I received (Arrived) issues, no item was created: so this bug is not about this case. So I created another subscription, which created an item record when receiving the serial, and I set its 2 new fields [Item type and Previous item type] to Continuing Resources. Then I Edited the subscription: the Item type and Previous item type fields were not set to Continuing Resources anymore! (ERROR) Anyway I went on: Was the previously received serial's itemtype set as defined in the subscription? When I received (Arrived) an issue [in DB: table serial] of the subscription (the first issue), I saw that the default value of the: y - Koha item type field of the new item was set to nothing (why?). I didn't change it to Continuing Resources [because koha should do it for me, shouldn't it?]; then I filled the other fields (barcode, aso), and I saved the new item. Then I looked at the biblio: In the biblio's Holdings tag, the item was Available and its item type is CR as required (RIGHT). I received another issue [the 2-nd] for the same subscription. Now, in the biblio's Holdings, the new (2-nd) item was Available and CR, as required. But the previous (1-st) item [still Available] lost its type: it had no type anymore! (ERROR) But I could have been wrong: as Katrin wrote in comment 38: It would be good to add a test plan and description. I think the feature evolved a bit over time, as this is one of the older bug reports. Anyway: prove t/db_dependent/Serials_2.t t/db_dependent/Serials_2.t .. 3/40 # Failed test 'With IndependentBranches, superserials can edit a subscription from his branch' # at t/db_dependent/Serials_2.t line 106. # got: '0' # expected: '1' # Failed test 'With IndependentBranches, superserials can edit a subscription from another branch' # at t/db_dependent/Serials_2.t line 109. # got: '0' # expected: '1' # Failed test 'With IndependentBranches, superserials can show a subscription from his branch' # at t/db_dependent/Serials_2.t line 112. # got: '0' # expected: '1' # Failed test 'With IndependentBranches, superserials can show a subscription from another branch' # at t/db_dependent/Serials_2.t line 115. # got: '0' # expected: '1' # Failed test 'With IndependentBranches, edit_subscription can edit a subscription from his branch' # at t/db_dependent/Serials_2.t line 121. # got: '0' # expected: '1' # Failed test 'With IndependentBranches, show_subscription can show a subscription from his branch' # at t/db_dependent/Serials_2.t line 127. # got: '0' # expected: '1' # Failed test 'With IndependentBranches, renew_subscription can show a subscription from his branch' # at t/db_dependent/Serials_2.t line 141. # got: '0' # expected: '1' # Failed test 'Without IndependentBranches, superserials can edit a subscription from his branch' # at t/db_dependent/Serials_2.t line 166. # got: '0' # expected: '1' # Failed test 'Without IndependentBranches, superserials can edit a subscription from another branch' # at t/db_dependent/Serials_2.t line 169. # got: '0' # expected: '1' # Failed test 'Without IndependentBranches, superserials can show a subscription from his branch' # at t/db_dependent/Serials_2.t line 172. # got: '0' # expected: '1' # Failed test 'Without IndependentBranches, superserials can show a subscription from another branch' # at t/db_dependent/Serials_2.t line 175. # got: '0' # expected: '1' # Failed test 'Without IndependentBranches, edit_subscription can edit a subscription from his branch' # at t/db_dependent/Serials_2.t line 180. # got: '0' # expected: '1' # Failed test 'Without IndependentBranches, edit_subscription can edit a subscription from another branch' # at t/db_dependent/Serials_2.t line 183. # got: '0' # expected: '1' # Failed test 'Without IndependentBranches, show_subscription can show a subscription from his branch' # at t/db_dependent/Serials_2.t line 186. # got: '0' # expected: '1' # Failed test 'Without IndependentBranches, show_subscription can show a subscription from another branch' # at t/db_dependent/Serials_2.t line 189. # got: '0' # expected: '1' # Failed
[Koha-bugs] [Bug 9351] item type not recorded correctly in statistics for returns and some local use
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351
Fridolin SOMERS fridolyn.som...@biblibre.com changed:
What|Removed |Added
Attachment #23692|0 |1
is obsolete||
--- Comment #33 from Fridolin SOMERS fridolyn.som...@biblibre.com ---
Created attachment 34818
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34818action=edit
Bug 9351 - item type not recorded correctly in statistics for returns and some
local use
When returning a loan, or when returning an item for local use, the
corresponding entry in the statistics table takes the item type from the bib
level. This is incorrect when item-level item types is enabled.
This patch corrects this problem by getting itemtype from $item-{'itype'}
which comes from item or biblio level in GetItem().
Test plan :
- On a catalogue with itemtype on item level, perform a return an look at
statistics table
- Idem for a catalogue with itemtype on biblio level
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9351] item type not recorded correctly in statistics for returns and some local use
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351 --- Comment #34 from Fridolin SOMERS fridolyn.som...@biblibre.com --- Created attachment 34819 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34819action=edit Bug 9351 - sql update on existing statistics -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9351] item type not recorded correctly in statistics for returns and some local use
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351 Fridolin SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added Depends on|11463 | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11463] GetItem must use item-level_itypes syspref
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11463 Fridolin SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added Blocks|9351| -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9351] item type not recorded correctly in statistics for returns and some local use
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351 Fridolin SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #35 from Fridolin SOMERS fridolyn.som...@biblibre.com --- (In reply to David Cook from comment #31) Fridolin, if you add some SQL to update the statistics, I'd be happy to sign off on this one. Here it is. I've added a LIMIT 1 to the query in the unlikely case the same itemnumber exists in items and deleteditems. I've also rebased first patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13488] FastMmap can not be disable
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13488 Marc Véron ve...@veron.ch changed: What|Removed |Added CC||ve...@veron.ch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12849] Sending a list has malformed links
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12849 Fridolin SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added CC||fridolyn.som...@biblibre.co ||m --- Comment #6 from Fridolin SOMERS fridolyn.som...@biblibre.com --- Pushed to 3.14.x, will be in 3.14.13 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13296] error when using z3950 with UNIMARC authorities
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13296 --- Comment #16 from Fridolin SOMERS fridolyn.som...@biblibre.com --- Pushed to 3.14.x, will be in 3.14.13 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12315] MTT FIX: Advanced notices are duplicated and not sent to the right patron
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12315 Fridolin SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added Status|Pushed to Stable|RESOLVED CC||fridolyn.som...@biblibre.co ||m Resolution|--- |FIXED --- Comment #7 from Fridolin SOMERS fridolyn.som...@biblibre.com --- Bug 10833 is only since 3.16 so this patch is not needed for 3.14 and below. I set as fixed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12596] Backdating returns with SpecifiyReturnDate causes fines for items not overdue!
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12596 Fridolin SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added CC||fridolyn.som...@biblibre.co ||m --- Comment #12 from Fridolin SOMERS fridolyn.som...@biblibre.com --- Pushed to 3.14.x, will be in 3.14.13 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13017] Login page image replacement technique fails when browser width exceeds 2000 pixels
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13017 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||ch...@bigballofwax.co.nz --- Comment #7 from Chris Cormack ch...@bigballofwax.co.nz --- Pushed to 3.18.x will be in 3.18.3 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 1861] Unique patrons logins not (totally) enforced
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1861 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable --- Comment #25 from Chris Cormack ch...@bigballofwax.co.nz --- Pushed to 3.18.x will be in 3.18.3 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12768] Replacement cost and processing fee management
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12768 Peggy Thrasher p.thras...@dover.nh.gov changed: What|Removed |Added CC||p.thras...@dover.nh.gov -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13453] Koha.t daily quote tests assume sample data
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13453 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||ch...@bigballofwax.co.nz --- Comment #5 from Chris Cormack ch...@bigballofwax.co.nz --- Pushed to 3.18.x will be in 3.18.3 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13360] C4::Ris considers that hashes are ordered
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13360 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||ch...@bigballofwax.co.nz --- Comment #5 from Chris Cormack ch...@bigballofwax.co.nz --- Pushed to 3.18.x will be in 3.18.3 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 1861] Unique patrons logins not (totally) enforced
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1861 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Status|Pushed to Stable|ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 1861] Unique patrons logins not (totally) enforced
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1861
--- Comment #26 from Chris Cormack ch...@bigballofwax.co.nz ---
There is massive issue with this
Specifically the Fix Check_Userid
sub Check_Userid {
-my ($uid,$member) = @_;
-my $dbh = C4::Context-dbh;
-my $sth =
- $dbh-prepare(
-SELECT * FROM borrowers WHERE userid=? AND borrowernumber != ?);
-$sth-execute( $uid, $member );
-if ( (( $uid ne '' ) ( my $row = $sth-fetchrow_hashref)) or
- (( $uid ne '' ) ( $uid eq C4::Context-config('user') )) ) {
-return 0;
-}
-else {
-return 1;
-}
+my ( $uid, $borrowernumber ) = @_;
+
+return 1 unless ($uid);
+
+return 0 if ( $uid eq C4::Context-config('user') );
+
+my $rs = Koha::Database-new()-schema()-resultset('Borrower');
+
+my $params;
+$params-{userid} = $uid;
+$params-{borrowernumber} = { '!=' = $borrowernumber } if
($borrowernumber);
+
+my $count = $rs-count( $params );
+
+return $count ? 0 : 1;
}
So we return 1 if it's unique.
Then we did this
-$data{'userid'} = Generate_Userid($data{'borrowernumber'},
$data{'firstname'}, $data{'surname'}) if $data{'userid'} eq '';
+$data{'userid'} = Generate_Userid( $data{'borrowernumber'},
$data{'firstname'}, $data{'surname'} )
+ if ( $data{'userid'} eq '' || Check_Userid( $data{'userid'} ) );
Which says essentially, if it is unique .. don't use it, if it isn't unique ..
then use it. (and the db insert then fails).
So we can insert borrowers who have a unique userid, but it will never use that
userid it will generate one.
Quite broken. Patch to follow
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 1861] Unique patrons logins not (totally) enforced
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1861 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 1861] Unique patrons logins not (totally) enforced
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1861
--- Comment #27 from Chris Cormack ch...@bigballofwax.co.nz ---
Created attachment 34820
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34820action=edit
BUg 1861 : There is a problem introduced with an earlier patch, on this
patchset
-$data{'userid'} = Generate_Userid($data{'borrowernumber'},
$data{'firstname'}, $data{'surname'}) if $data{'userid'} eq '';
+$data{'userid'} = Generate_Userid( $data{'borrowernumber'},
$data{'firstname'}, $data{'surname'} )
+ if ( $data{'userid'} eq '' || Check_Userid( $data{'userid'} ) );
Check_Userid returns 1 if it is unique. So this means unique userids
will always be discarded and new ones created.
This is why all the tests depending on a userid are now failing
To test
1/ run perl t/db_dependent/Serials_2.t
2/ Notice lots of tests fail
3/ OR Add a borrower with a userid set, notice the userid is ignored
and one is generated instead
4/ Apply patch
5/ Add a new borrower, notice the userid sticks (if it is unique)
6/ Run perl t/db_dependent/Serials_2.t notice tests pass
7/ Run perl t/db_dependent/Members.t notice tests still pass
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
