[Koha-bugs] [Bug 7710] multiple holds per title
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7710 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7710] multiple holds per title
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7710 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #30218|0 |1 is obsolete|| --- Comment #74 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 35397 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35397action=edit Bug 7710 - multiple holds per title Adds the ability to allow multiple holds on the same record for the same borrower. Adds new system preference MaxHoldsPerRecord, which controls how many holds one person can have on items for the same record. Test Plan: 1) Apply patch for Bug 9394 2) Apply this patch 3) Run updatedatabase.pl 4) Attempt to place 2 holds for the same patron on the same record, you should not be able to ( default is 1 per record ) 5) Set MaxHoldsPerRecord to 3 6) Attempt to place multiple holds for one patron on one record, you should be able to place 3 holds for one patron on a given record. A 4th hold should result in a message stating the patron has placed the max number of holds allowed on this record. Signed-off-by: Maxime Pelletier maxime.pellet...@libeo.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7710] multiple holds per title
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7710 --- Comment #75 from Jonathan Druart jonathan.dru...@biblibre.com --- I rebased this patch manually (using git apply --reject) and recreated the patch. Note that I did *not* test it! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13373] Update Polish web installer sample data files
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13373 Rafal Kopaczka rkopac...@afm.edu.pl changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12381] show patron barcode on self registration confirmation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12381 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added CC||k...@bywatersolutions.com Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Kyle M Hall k...@bywatersolutions.com --- *** This bug has been marked as a duplicate of bug 13599 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13599] Add patron cardnumber to self registration confirmation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13599 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added CC||neng...@gmail.com --- Comment #3 from Kyle M Hall k...@bywatersolutions.com --- *** Bug 12381 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11120] The date option for the overdue_notices cronjob is broken
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11120 --- Comment #24 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to Katrin Fischer from comment #23) Could the problem be similar to what we saw on the patch for the parcels page? Yes, actually I noticed this problem for the first time when I worked on this one. I started a discussion on koha-devel this morning [1], it seems that DateTime::Format::DateParse introduces more problems than it is supposed to help. [1] http://lists.koha-community.org/pipermail/koha-devel/2015-January/041095.html -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10654] Add feature: export basket in CSV, list of custom formats for various vendors
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10654 Josef Moravec josef.mora...@gmail.com changed: What|Removed |Added CC||josef.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13599] Add patron cardnumber to self registration confirmation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13599 --- Comment #1 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 35401 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35401action=edit Bug 13599 - Add patron cardnumber to self registration confirmation Some libraries wish to display the patron's cardnumber on the confirmation screen for patron self registration, rather than make the patron locate it his or her cardnumber by logging in and browsing to the personal details page. We should also add ids to these fields for easy css styling/hiding. Test Plan: 1) Apply this patch 2) Self-register a new patron 3) Note confirmation screen now displays the patron cardnumber -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13599] Add patron cardnumber to self registration confirmation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13599 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Patch complexity|--- |String patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13599] Add patron cardnumber to self registration confirmation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13599 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #35402|0 |1 is obsolete|| --- Comment #4 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 35403 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35403action=edit Bug 13599 - Add patron cardnumber to self registration confirmation Some libraries wish to display the patron's cardnumber on the confirmation screen for patron self registration, rather than make the patron locate it his or her cardnumber by logging in and browsing to the personal details page. We should also add ids to these fields for easy css styling/hiding. Test Plan: 1) Apply this patch 2) Ensure that autoMemberNum is enabled 3) Self-register a new patron 4) Note confirmation screen now displays the patron cardnumber -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13373] Update Polish web installer sample data files
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13373 --- Comment #11 from Rafal Kopaczka rkopac...@afm.edu.pl --- Hi Katrin, thanks for testing. I've could replicate only one issue: ERROR 1062 (23000) at line 4090: Duplicate entry 'CF-952-i' for key 'PRIMARY'. It's fixed in followup. Other errors are from files, that are deleted in patch. It looks like you have applied only first patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13599] Add patron cardnumber to self registration confirmation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13599 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Assignee|oleon...@myacpl.org |k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13599] New: Add patron cardnumber to self registration confirmation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13599 Bug ID: 13599 Summary: Add patron cardnumber to self registration confirmation Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: k...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org Some libraries wish to display the patron's cardnumber on the confirmation screen for patron self registration, rather than make the patron locate it his or her cardnumber by logging in and browsing to the personal details page. We should also add ids to these fields for easy css styling/hiding. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13373] Update Polish web installer sample data files
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13373 --- Comment #9 from Rafal Kopaczka rkopac...@afm.edu.pl --- Created attachment 35399 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35399action=edit Bug 13373 - Update Polish web installer sample data files. Part 2/2 - optional files. Changes: - Deleted unnecessary files - Translated description files and some values in sql files To test: - Aplly patch - Run webinstaller on empty database (drop database and create new if necessary) - Verify everything works, especially verify you have permission to all modules, eg. Tools, Catalouging etc. - Check spelling and grammar if you can :) Signed-off-by: Chris ch...@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13373] Update Polish web installer sample data files
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13373 --- Comment #10 from Rafal Kopaczka rkopac...@afm.edu.pl --- Created attachment 35400 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35400action=edit Bug 13373 - [QA Followup] - Update Polish web installer sample data files Fixed Duplicate entry CF-952-i error in marc21_simple_bib_frameworks.sql -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7710] multiple holds per title
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7710
--- Comment #76 from Jonathan Druart jonathan.dru...@biblibre.com ---
(In reply to M. de Rooy from comment #65)
Another question too:
Why do you remove this line:
-('XSLTResultsDisplay','default','','Enable XSL stylesheet control over
results page display on intranet','Free'),
I reintroduced this line in the last patch.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13373] Update Polish web installer sample data files
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13373 Rafal Kopaczka rkopac...@afm.edu.pl changed: What|Removed |Added Attachment #34612|0 |1 is obsolete|| Attachment #34613|0 |1 is obsolete|| --- Comment #8 from Rafal Kopaczka rkopac...@afm.edu.pl --- Created attachment 35398 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35398action=edit Bug 13373 - Update Polish web installer sample data files. Part 1/2 - mandatory files. Changes: - Translated user permission and user flags. - Changed untranslated different files from en version - Deleted unnecessary files To test: - Aplly patch - Run webinstaller on empty database (drop database if necessary) - Verify everything works, especially verify you have permission to all modules, eg. Tools, Catalouging etc. - Check spelling and grammar if you can :) Signed-off-by: Chris ch...@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6968] Show items expired before today in check expiration of serials page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6968 Paola Rossi paola.ro...@cineca.it changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply --- Comment #14 from Paola Rossi paola.ro...@cineca.it --- (In reply to Charles Farmer from comment #13) Created attachment 35314 [details] [review] Bug 6968 - Check expiration in serials expired before today I'm resubmitting the last patch, which I could apply on master 3.19.00.006, in a slightly different format. Hoping this solves your issue. Kind Charles, I've applied the patch against master 3.19.00.006 head 13526. Soon after having applied, when I: git format-patch -s origin/master, 1-A) I got a file where From is: charles char...@inlibro.com instead of : charles charles.far...@inlibro.com It could be an error. 1-B) In that file there was this: Subject: [PATCH] Patch sponsored by our client http://www.ccsr.qc.ca/ instead of the usual commit message: Bug 6968 - Show items expired before today in check expiration of serials page identifying the patch and describing the content of the patch. [The patches' commit messages will be seen in the master branch: http://git.koha-community.org/gitweb/?p=koha.git;a=summary] So I pass the patch to Patch doesn't apply again. Anyway I've gone on and tested your patch, that is fixing a lasting bug. I'm not a QA, I don't know precisely the QA guidelines. I write some considerations of mine you can evaluate. The patch you wrote added a true difference between: subscriptions already expired until today [included] (added to the selection by the new checkbox) subscriptions that will expire (from tomorrow [included] to the input date [excluded], chosen by the calendar). But IMO in master this difference was not so present: as you can see, the calendar is not limited from tomorrow on. So I think that your patch could match this error not so well. Perhaps : A) extending the current selection to all the end-dates of the subscriptions, and B) adding a From and a To dates input fields (as an improvement), could be a more matching solution. The default values of From and To could be the MIN and MAX end-date of the subscriptions in DB, whilst today could be set as the default in the 2 calendars. C) moreover, the resulting table could be sortable, on end-date at least (as a further improvement). Otherwise, if the solution provided by the patch has been already considered as being the best one, consider that some inaccuracies occur: 1-A) when I checked the checkbox and I chose an year ago as input date, the selection is not about before today, but before an year ago: the result is shown (IMO right). 1-B) if I didn't check the checkbox and I chose an year ago as input date, the selection is null, as you know [this result is wrong IMO]. If you limit the calendar from tomorrow on, the user will not be able to get a selection limited like 1-A). If you don't limit the calendar from tomorrow on, B) is an available case of choice to the user, and it is unfriendly to the user (misleading). Anyway, if the solution provided by the patch has been already considered as being the best one, in the form before won't be used in the same meaning: once , and the other time as =. This difference is unfriendly to the user: the resulting table could miss some particular subscriptions. To solve, a better solution can choose one of the 2 cases: hypothesis 2-1) () before excluding the upper limit: Adding Show expired before tomorrow: instead of adding Show expired before today: could be better. hypothesis 2-2) (=) before including the upper limit (better, IMO): The patch should keep Show expired before today:. But the patch should also modify the Expiring before: behaviour, to include the chosen value too in the selection. Anyway, if the solution provided by the patch has been already considered as being the best one, being the form a Filters one, its default should be better set to select all the subscriptions. So I think that: 3-A) a default could be set in the input fields: checked checkbox (!), usefull upper limit [=MAX end-date+included (2-2), or greater than MAX end-date]. As a further inprovement, the sort could be add to the table. If the expiring' time is so important to the user, the default sorting could be set to end-data DESC [in spite of the current subscription code, not related]. I hope these considerations can be of some help. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git :
[Koha-bugs] [Bug 13599] Add patron cardnumber to self registration confirmation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13599 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #35401|0 |1 is obsolete|| --- Comment #2 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 35402 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35402action=edit Bug 13599 - Add patron cardnumber to self registration confirmation Some libraries wish to display the patron's cardnumber on the confirmation screen for patron self registration, rather than make the patron locate it his or her cardnumber by logging in and browsing to the personal details page. We should also add ids to these fields for easy css styling/hiding. Test Plan: 1) Apply this patch 2) Self-register a new patron 3) Note confirmation screen now displays the patron cardnumber -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13600] New: XSLT: 8xx not showing if there is no 4xx
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13600 Bug ID: 13600 Summary: XSLT: 8xx not showing if there is no 4xx Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: neng...@gmail.com QA Contact: testo...@bugs.koha-community.org In records with series field(s) 800/810/830 only (no 4XX series), no series are displayed. The MARC21 rules say: An 810 field is usually justified by a series statement (field 490) or a general note (field 500) relating to the series. usually means it should show even if there is no 490 http://www.loc.gov/marc/bibliographic/bd810.html -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13601] Get rid of DateTime::Format::DateParse
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601 --- Comment #3 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 35407 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35407action=edit Bug 13601: get rid of DateTime::Format::DateParse This module is used in C4::Members::GetPendingIssues too, but we can use dt_from_string. Test plan: 1/ Verify that prove t/db_dependent/Members/GetPendingIssues.t returns green 2/ On the patron pending issue list, verify that the issue and the due dates are correctly displayed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13537] Focus should move to barcode after renewing via checkouts table
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13537 Mason James m...@kohaaloha.com changed: What|Removed |Added Blocks||13258 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13601] Get rid of DateTime::Format::DateParse
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added CC||colin.campbell@ptfs-europe. ||com --- Comment #5 from Jonathan Druart jonathan.dru...@biblibre.com --- Colin, As you are the main author of Koha::DateUtils, I really would like to get your opinion on this patch set :) Especially on the QA comment (second patch). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13253] Unnecessary white space above checkouts table in circulation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13253 Mason James m...@kohaaloha.com changed: What|Removed |Added CC||m...@kohaaloha.com Keywords||rel_3_16_candidate --- Comment #5 from Mason James m...@kohaaloha.com --- Pushed to 3.16.x, patch will be in 3.16.7 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13595] Checking out an issued item doesn't return it after confirmation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13595 --- Comment #1 from Owen Leonard oleon...@myacpl.org --- (In reply to Josef Moravec from comment #0) But after clicking Yes button, the item is just issued to current member, but is NOT checked in before! Are you saying that the item remains checked out to both patrons, or that some action which is supposed to be performed upon check-in is not being performed? When I test it in master it works as I expect it to: The item is removed from the previous patron's account and checked out to the current one. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13196] Always show checkouts immediately cookie should persist across sessions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13196 Mason James m...@kohaaloha.com changed: What|Removed |Added CC||m...@kohaaloha.com Keywords||rel_3_16_candidate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13601] Get rid of DateTime::Format::DateParse
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Assignee|gmcha...@gmail.com |jonathan.dru...@biblibre.co ||m Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11577] Automatic renewals
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 Mason James m...@kohaaloha.com changed: What|Removed |Added CC||m...@kohaaloha.com --- Comment #126 from Mason James m...@kohaaloha.com --- Skipping patch for 3.16.x series -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13603] autoBarcode setting hbyymmincr not taking month into account when looking up next increment
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13603 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13601] New: Get rid of DateTime::Format::DateParse
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601
Bug ID: 13601
Summary: Get rid of DateTime::Format::DateParse
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: P5 - low
Component: Architecture, internals, and plumbing
Assignee: gmcha...@gmail.com
Reporter: jonathan.dru...@biblibre.com
QA Contact: testo...@bugs.koha-community.org
For a couple of reasons, dt_from_string should not use
DateTime::Format::DateParse:
1/ It does not manage date 1900 (certainly caused by l.47 of this module:
$p{ year } = $year ? $year + 1900 : DateTime-now-year;
2/ It considers 31/01/2015 as a valid us date, which is not.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13602] New: Username/password already exists when editing borrower attributes and messaging preferences
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13602
Bug ID: 13602
Summary: Username/password already exists when editing borrower
attributes and messaging preferences
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Patrons
Assignee: koha-bugs@lists.koha-community.org
Reporter: olli-antti.kivila...@jns.fi
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com
When editing a Patron's messaging preferences or borrower attributes, one
cannot save changes because 'userid' is not given as a parameter.
It shouldn't, but the
Check_Userid($newdata{'userid'},$borrowernumber) -check must have it.
AFTER THIS PATCH:
Check_Userid() is not called when modifying or saving partial borrower
properties.
Userid is changed using a separate module.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13603] New: autoBarcode setting hbyymmincr not taking month into account when looking up next increment
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13603 Bug ID: 13603 Summary: autoBarcode setting hbyymmincr not taking month into account when looking up next increment Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: gmcha...@gmail.com Reporter: k...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl The hbyymmincr autoBarcode builder looks up all barcodes that begin with any number of letters ( the branchcode ) and a two-digit year directly afterward ( e.g. MPL15 ), then grabs the last four digits as the increment counter. The problem is, this does not take months into account, so unlike the description that says the system is limited to 10,000 items a month, it is limited to 10,000 items per *year*. This situation can easily be corrected my adding the month into the lookup ( e.g. MPL1501 ). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8753] Add forgot password link to OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #72 from M. Tompsett mtomp...@hotmail.com --- simith.dolive...@inlibro.com, could you squash your patches together too? Just my preference. :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13595] Checking out an issued item doesn't return it after confirmation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13595 --- Comment #2 from Josef Moravec josef.mora...@gmail.com --- Yes, but now I tested it on master and on another 3.18.2 stable installation and everything went right, so It looks like there is something wrong with one concrete installation... I'll investigate it deeper... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13595] Checking out an issued item doesn't return it after confirmation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13595 Josef Moravec josef.mora...@gmail.com changed: What|Removed |Added CC||josef.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8753] Add forgot password link to OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #74 from M. Tompsett mtomp...@hotmail.com --- The patches were never signed off. I figure a squash isn't so bad at this stage. :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13602] Username/password already exists when editing borrower attributes and messaging preferences
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13602
--- Comment #1 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi ---
Created attachment 35404
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35404action=edit
Bug 13602 - Username/password already exists when editing borrower attributes
and messaging preferences
When editing a Patron's messaging preferences or borrower attributes, one
cannot
save changes because 'userid' is not given as a parameter.
It shouldn't, but the
Check_Userid($newdata{'userid'},$borrowernumber) -check must have it.
AFTER THIS PATCH:
Check_Userid() is not called when modifying or saving partial borrower
properties.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13602] Username/password already exists when editing borrower attributes and messaging preferences
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13602 Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8753] Add forgot password link to OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #73 from Owen Leonard oleon...@myacpl.org --- (In reply to M. Tompsett from comment #72) Just my preference. :) Last I heard it was not the RM's preference, but that may have been a previous RM. Perhaps this is something we should add to the coding guidelines? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13236] Regression: Table of checkouts no longer preselects overdue items for rewewal
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13236 Mason James m...@kohaaloha.com changed: What|Removed |Added CC||m...@kohaaloha.com Keywords||rel_3_16_candidate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13237] Regression: List of previous checkouts should be ordered by due date ascending
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13237 Mason James m...@kohaaloha.com changed: What|Removed |Added Keywords||rel_3_16_candidate CC||m...@kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8753] Add forgot password link to OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10860] On-site checkouts (was In-House Use)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 Mason James m...@kohaaloha.com changed: What|Removed |Added CC||m...@kohaaloha.com --- Comment #89 from Mason James m...@kohaaloha.com --- Skipping patch for 3.16.x series -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13601] Get rid of DateTime::Format::DateParse
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601 --- Comment #1 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 35405 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35405action=edit Bug 13601: Add tests to highlight the problems with DateTime::Format::DateParse -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12954] Questionable logic regarding session handling in C4::Auth::checkauth()
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12954 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #35341|0 |1 is obsolete|| --- Comment #16 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 35412 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35412action=edit Bug 12954: Failed login should retain anonymous session A failed login should not leave the user in a half logged authenticated state, but rather return them to an anonymouse session as per the pre-login attempt state. To replicate error: 1. Try to log in with some nonexisting user id or wrong password in the OPAC 2. Go directly to /opac-user.pl (e.g., enter it in the browser address bar, or just click on the Log in link) 3. Observe a DBI error displayed on the screen 4. You are now in the deadloop of sorts (opac/opac-user.pl refuses to display the login screen, no matter how many times you try to reload it); to break the deadloop, one needs to: - remove session cookie from the browser (or cause the session to expire in some other way - closing browser window would be probably enough for that) - remove offending session on the server (from mysql sessions table, ..) - log in with proper credentials using some other page (like opac/opac-main.pl right-side panel), which does not involve opac/opac-user.pl being called without userid CGI parameter. To test: 1. Test as above, the DBI error should no longer be present 2. Check that search history works across failed and sucessful login attempts Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12954] Questionable logic regarding session handling in C4::Auth::checkauth()
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12954 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added CC||jonathan.dru...@biblibre.co ||m --- Comment #17 from Jonathan Druart jonathan.dru...@biblibre.com --- This is a very bad bug! I tried to fix something in opac-user.pl, to avoid the script to continue (a redirect if get_template_and_user does not return a $borrowernumber?), but don't know how to do it correctly. I confirm this patch fixes the issues. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5501] why is there a 'do not notify' option?
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5501 Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed: What|Removed |Added CC||olli-antti.kivila...@jns.fi --- Comment #3 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi --- We have confusion as well. The worst thing is that it actually doesn't do what it says. We still have print messages even if the do not notify-option is used. Looking into adding a new message-transport-type do not notify used to catch that. So instead of clicking an clear-button in the GUI we actually select a viable transport alternative overriding message sending behaviour. Sometimes the message_transport_type defaults to print if no transport is defined. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13604] CSS incorrectly formatted
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13604 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #1 from Owen Leonard oleon...@myacpl.org --- The OPAC now uses a LESS file (opac.less) which compiles into minified CSS. opac.css should not be modified. http://wiki.koha-community.org/wiki/Working_with_Bootstrap_OPAC_LESS_files -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13603] autoBarcode setting hbyymmincr not taking month into account when looking up next increment
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13603 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13603] autoBarcode setting hbyymmincr not taking month into account when looking up next increment
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13603 --- Comment #1 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 35409 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35409action=edit Bug 13603 - autoBarcode setting hbyymmincr not taking month into account when looking up next increment The hbyymmincr autoBarcode builder looks up all barcodes that begin with any number of letters ( the branchcode ) and a two-digit year directly afterward ( e.g. MPL15 ), then grabs the last four digits as the increment counter. The problem is, this does not take months into account, so unlike the description that says the system is limited to 10,000 items a month, it is limited to 10,000 items per *year*. This situation can easily be corrected my adding the month into the lookup ( e.g. MPL1501 ). Test Plan: 1) Enable autoBarcode, set to hbyymmincr 2) Catalog an item, let the barcode.pl plugin generate the next barcode. 3) Catalog an item with the barcode MPL1500 4) Catalog another item, use the barcode.pl plugin to generate the next barcode. 5) Note the barcode is generated ends with '0001' instead of the correct increment 6) Apply this patch 7) Repeat step 4 8) Note the barcode now ends with the correct increment -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13364] Add a call number browser in item edition page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 --- Comment #23 from Jonathan Druart jonathan.dru...@biblibre.com --- Note: The tablesorter jquery plugin has been removed from the src. Does not it possible to do the same thing using DataTables? +table style=margin: auto;width:90%; id=course_reserves = This is wrong -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13601] Get rid of DateTime::Format::DateParse
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601
--- Comment #6 from Colin Campbell colin.campb...@ptfs-europe.com ---
(In reply to Jonathan Druart from comment #0)
For a couple of reasons, dt_from_string should not use
DateTime::Format::DateParse:
1/ It does not manage date 1900 (certainly caused by l.47 of this module:
$p{ year } = $year ? $year + 1900 : DateTime-now-year;
2/ It considers 31/01/2015 as a valid us date, which is not.
The reason dates before 1900 are not handled is in the doc for Date::Parse
Date::Parse uses Time::Local internally, so is limited to only parsing
dates which result in valid values for Time::Local::timelocal. This
generally means dates between 1901-12-17 00:00:00 GMT and 2038-01-16
23:59:59 GMT
That wasnt a problem with DateUtils as it was just ensuring the old C4::Dates
routines could be handled which were also unable to handle pre 1900 dates
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13521] Auth.pm code issues
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13521 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #35339|0 |1 is obsolete|| Attachment #35340|0 |1 is obsolete|| --- Comment #6 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 35410 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35410action=edit Bug 13521: Removed superflous semicolon Removed an uneeded semicolon from the end of an 'if' block. This should not affect operation of the script. Note: With Bug 13499 we did a non-destructive perltidy, as such we only affected indenting and whitespace to maintain blame history. However, a number of minor code issues were also highlighted, in this series of patches I hope to correct other minor style issues. Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13521] Auth.pm code issues
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13521 --- Comment #7 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 35411 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35411action=edit Bug 13521: Add missing semicolon Add a missing semicolon to the end of a template variable assignment line. This patch should not affect operation. Note: With Bug 13499 we did a non-destructive perltidy, as such we only affected indenting and whitespace to maintain blame history. However, a number of minor code issues were also highlighted, in this series of patches I hope to correct other minor style issues. Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13521] Auth.pm code issues
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13521 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added CC||jonathan.dru...@biblibre.co ||m Patch complexity|--- |Trivial patch Severity|enhancement |trivial Assignee|gmcha...@gmail.com |martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13521] Auth.pm code issues
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13521 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13301] Call number link in search results is broken
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13301 --- Comment #6 from Barton Chittenden bar...@bywatersolutions.com --- (In reply to Katrin Fischer from comment #5) Hm, could you check ICU vs. CHR? I think that might be it. The 'UseICU' system preference is set to 'Using'. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13258] Clicking the show checkouts button should return focus to the barcode field
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13258 Mason James m...@kohaaloha.com changed: What|Removed |Added Depends on||13537 CC||m...@kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13540] Item's permanent_location is set to CART|PROC if an Item is edited when it's location is CART|PROC.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13540 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Failed QA CC||jonathan.dru...@biblibre.co ||m --- Comment #9 from Jonathan Druart jonathan.dru...@biblibre.com --- Looks like something is wrong for me: % prove t/db_dependent/Circulation.t t/db_dependent/Circulation.t .. 23/67 # Failed test 'ReturnToShelvingCart: Adding a new Item with location also sets the permanent_location.' # at t/db_dependent/Circulation.t line 648. # Looks like you failed 1 test of 67. Does it come from my DB? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13499] Auth.pm needs a tidy
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13499 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added CC||jonathan.dru...@biblibre.co ||m --- Comment #13 from Jonathan Druart jonathan.dru...@biblibre.com --- I was a little bit uncertain with this patch, there are something like 25 patches modifying C4/Auth.pm in the bug queue. Most of them are FQA and won't help the rebase. But they are mainly 1 or 2 lines patches, it should not be too difficult to rebase them. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12954] Questionable logic regarding session handling in C4::Auth::checkauth()
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12954 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13604] CSS incorrectly formatted
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13604 David Roberts david.robe...@ptfs-europe.com changed: What|Removed |Added Assignee|oleon...@myacpl.org |david.roberts@ptfs-europe.c ||om -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13604] New: CSS incorrectly formatted
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13604
Bug ID: 13604
Summary: CSS incorrectly formatted
Change sponsored?: ---
Product: Koha
Version: 3.18
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: OPAC
Assignee: oleon...@myacpl.org
Reporter: david.robe...@ptfs-europe.com
QA Contact: testo...@bugs.koha-community.org
opac.css is no longer formatted correctly. All elements are running into each
other, for example:
.shadowed{-webkit-box-shadow:0 1px 1px 0 rgba(0,0,0,0.2);-moz-box-shadow:0 1px
1px 0 rgba(0,0,0,0.2);box-shadow:0 1px 1px 0
rgba(0,0,0,0.2)}body{background-color:#eaeae6}html,body{height:100%}.no-js
.dateformat{display:inline;white-space:nowrap}.no-js .modal-body{padding:0}
(etc.)
This makes it impossible to read and to work with. It ought to be formatted as,
for example:
.shadowed {
-webkit-box-shadow:0 1px 1px 0 rgba(0,0,0,0.2);
-moz-box-shadow:0 1px 1px 0 rgba(0,0,0,0.2);
box-shadow:0 1px 1px 0 rgba(0,0,0,0.2)
}
body {
background-color:#eaeae6
}
(etc)
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5501] Improve the 'do not notify' option
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5501 --- Comment #5 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi --- Created attachment 35414 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35414action=edit Bug 5501 - Improve the 'do not notify' option. HOLD-letter. TEST PLAN: 1. Find a Borrower and edit Patron messaging preferences. 2. Check the Do not notify for Hold filled -letter. 3. Check any other checkboxes for Hold filled -letter. The Do not notify-checkbox should get unchecked. 4. Check the Do not notify -checkbox again for the Hold filled -letter. Other selections for the row get unchecked. 5. Save changes. 6. Make a hold for a borrower. 7. Check-in the reserved Item and catch the hold. 8. In the notices-tab for the Borrower, there should be no message for the borrower about getting the caught Hold. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5501] Improve the 'do not notify' option
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5501 --- Comment #6 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi --- This feature is about enabling explicit message rejection for selectable message types. Default behaviour is only overridden if the Do not notify-checkbox is checked. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13601] Get rid of DateTime::Format::DateParse
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601 --- Comment #4 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 35408 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35408action=edit Bug 13601: Add a fallback check for compability with existing code There are a lot of places where the date comes from the DB but the dateformat parameter is not set to 'sql'. dt_from_string needs to fallback with this format if the pref format does not match. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13601] Get rid of DateTime::Format::DateParse
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601
--- Comment #2 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 35406
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35406action=edit
Bug 13601: Make dt_from_string not using DateTime::Format::DateParse
For a couple of reasons, dt_from_string should not use
DateTime::Format::DateParse:
1/ It does not manage date 1900, certainly caused by l.47 of this
module:
$p{ year } = $year ? $year + 1900 : DateTime-now-year;
2/ It considers 31/01/2015 as a valid us date, which is not.
Test plan:
1/ Verify that
prove t/DateUtils.t
returns green
2/ Play with dates in Koha (yes I know, it's vague...)
3/ Try to find a regression with dates
4/ Create a date with year = 1900 and confirm it works
QA comment:
Why the sql format switch was:
-$date_string =~
-s/(\d{4})(\d{2})(\d{2})\s+(\d{2})(\d{2})(\d{2})/$1-$2-$3T$4:$5:$6/;
From where a date like mmdd hhmmss can come?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13601] Get rid of DateTime::Format::DateParse
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13603] autoBarcode setting hbyymmincr not taking month into account when looking up next increment
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13603 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Assignee|gmcha...@gmail.com |k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13601] Get rid of DateTime::Format::DateParse
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601
--- Comment #7 from Colin Campbell colin.campb...@ptfs-europe.com ---
(In reply to Jonathan Druart from comment #2)
Created attachment 35406 [details] [review]
Bug 13601: Make dt_from_string not using DateTime::Format::DateParse
For a couple of reasons, dt_from_string should not use
DateTime::Format::DateParse:
1/ It does not manage date 1900, certainly caused by l.47 of this
module:
$p{ year } = $year ? $year + 1900 : DateTime-now-year;
2/ It considers 31/01/2015 as a valid us date, which is not.
Test plan:
1/ Verify that
prove t/DateUtils.t
returns green
2/ Play with dates in Koha (yes I know, it's vague...)
3/ Try to find a regression with dates
4/ Create a date with year = 1900 and confirm it works
QA comment:
Why the sql format switch was:
-$date_string =~
-s/(\d{4})(\d{2})(\d{2})\s+(\d{2})(\d{2})(\d{2})/$1-$2-$3T$4:$5:$6/;
From where a date like mmdd hhmmss can come?
C4::Dates supported the format so DateUtils had to accept it.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13364] Add a call number browser in item edition page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added CC||jonathan.dru...@biblibre.co ||m --- Comment #22 from Jonathan Druart jonathan.dru...@biblibre.com --- Kyle, Does this pass qa? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5501] Improve the 'do not notify' option
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5501 Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed: What|Removed |Added Summary|why is there a 'do not |Improve the 'do not notify' |notify' option? |option -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5501] why is there a 'do not notify' option?
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5501 --- Comment #4 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi --- Created attachment 35413 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35413action=edit Bug 5501 - Improve the 'do not notify' option Introducing the message_transport_type 'none' and enabling it for all messages. Enabling print-option for HOLD Fulfilled. Print option can be added for other messages as well, but HOLD seems to make the most sense. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13450] Title and breadcrumb of Patron form can look weird in translations
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13450 --- Comment #15 from sandbo...@biblibre.com sandbo...@biblibre.com --- Created attachment 35417 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35417action=edit Bug 13450 - Title and breadcrumb of Patron form can look weird in translations This patch moves the patron category name or category type at the end of title and breadcrumb for better translatability. Note: It does not change anything in functionallity, it only changes display of strings. To test: Apply patch Search a patron and edit it in all possible ways: 'Edit' button on top of details page, 'Edit' links in details page, 'Edit' links in search result table if multiple patrons are found) Duplicate a patron Create a new patron Make sure that title and breadcrumb appear in a meaningful way with pattern similar to the following: Modify patron Hansli Meier (Juvenile) (Missing /div added) Signed-off-by: Aleisha aleishaamo...@hotmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13450] Title and breadcrumb of Patron form can look weird in translations
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13450 sandbo...@biblibre.com sandbo...@biblibre.com changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||sandbo...@biblibre.com --- Comment #14 from sandbo...@biblibre.com sandbo...@biblibre.com --- Patch tested with a sandbox, by Aleisha aleishaamo...@hotmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13450] Title and breadcrumb of Patron form can look weird in translations
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13450 sandbo...@biblibre.com sandbo...@biblibre.com changed: What|Removed |Added Attachment #35258|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13598] Tax Rate displays different from Acquisition Preference gist
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13598 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #1 from Katrin Fischer katrin.fisc...@bsz-bw.de --- I think you can only use the 0.0875 syntax in the gist preference, but there is another bug about the number of decimals to show: bug 10253. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7143] Bug for tracking changes to the about page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #35349|0 |1 is obsolete|| --- Comment #221 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 35420 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35420action=edit Bug 7143: Adding back version numbers Adding back version numbers to the former release team members in the list of developers. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9303] relative's checkouts in the opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9303] relative's checkouts in the opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #166 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Hi Kyle, I tried to retest the problem, but the database update gives me problems :( bumblebee:~/kohaclone (38-9303-relativecheckouts|AM 1/1) $ ./installer/data/mysql/updatedatabase.pl DBD::mysql::db do failed: Can't DROP 'PRIMARY'; check that column/key exists at ./installer/data/mysql/updatedatabase.pl line 9681. DBD::mysql::db do failed: Can't DROP 'itemnumber_idx'; check that column/key exists at ./installer/data/mysql/updatedatabase.pl line 9687. DBD::mysql::db do failed: Can't DROP 'PRIMARY'; check that column/key exists at ./installer/data/mysql/updatedatabase.pl line 9690. DBD::mysql::db do failed: Cannot drop index 'itemnumber_idx': needed in a foreign key constraint at ./installer/data/mysql/updatedatabase.pl line 9696. DBD::mysql::db do failed: Duplicate key name 'itemnumber_idx' at ./installer/data/mysql/updatedatabase.pl line 9699. Upgrade to 3.19.00.XXX done (Bug 9303 - relative's checkouts in the opac) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13544] admin/auth_subfields_structure.pl does not compile in older perls
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13544 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13544] admin/auth_subfields_structure.pl does not compile in older perls
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13544 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #35088|0 |1 is obsolete|| --- Comment #4 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 35419 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35419action=edit [SIGNED OFF] Bug 13544: Make it explicit that getauthtypes returns a hash ref Prior to perl 5.12 keys can only operate on a hash. Test plan: With perl 5.10, access to admin/auth_subfields_structure.pl. Without this patch, you get: Type of arg 1 to keys must be hash (not subroutine entry) at /home/koha/src/admin/auth_subfields_structure.pl line 102, near getauthtypes) Signed-off-by: Katrin Fischer katrin.fischer...@web.de Confirmed problem and tested patch on a sandbox, signed off locally. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13373] Update Polish web installer sample data files
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13373 --- Comment #17 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 35425 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35425action=edit [SIGNED OFF] Bug 13373 - Update Polish web installer sample data files. Part 2/2 - optional files. Changes: - Deleted unnecessary files - Translated description files and some values in sql files To test: - Aplly patch - Run webinstaller on empty database (drop database and create new if necessary) - Verify everything works, especially verify you have permission to all modules, eg. Tools, Catalouging etc. - Check spelling and grammar if you can :) Signed-off-by: Chris ch...@bigballofwax.co.nz Signed-off-by: Katrin Fischer katrin.fischer...@web.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13602] Username/password already exists when editing borrower attributes and messaging preferences
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13602 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #3 from Katrin Fischer katrin.fisc...@bsz-bw.de --- I don't have time to test this thoroughly, but I can confirm the problem: If you use the small 'edit' links for a section of the patron record instead of the 'edit' link in the toolbar, you can't save changes - as you get an error message: The following fields are wrong. Please fix them. Username/password already exists. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9303] relative's checkouts in the opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment #167 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Just realized I didn't have all the patches... and that it might be a bit too late tonight for this -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7143] Bug for tracking changes to the about page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 --- Comment #222 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Corrected the typos Marcel pointed out and replaced 3.x by 3.0+/3.2+ as discussed on IRC. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13373] Update Polish web installer sample data files
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13373 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #35422|0 |1 is obsolete|| --- Comment #16 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 35424 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35424action=edit [SIGNED OFF] Bug 13373 - Update Polish web installer sample data files. Part 1/2 - mandatory files. Changes: - Translated user permission and user flags. - Changed untranslated different files from en version - Deleted unnecessary files To test: - Aplly patch - Run webinstaller on empty database (drop database if necessary) - Verify everything works, especially verify you have permission to all modules, eg. Tools, Catalouging etc. - Check spelling and grammar if you can :) Signed-off-by: Chris ch...@bigballofwax.co.nz Signed-off-by: Katrin Fischer katrin.fischer...@web.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13373] Update Polish web installer sample data files
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13373 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #35423|0 |1 is obsolete|| --- Comment #18 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 35426 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35426action=edit [SIGNED OFF] Bug 13373 - [QA Followup] - Update Polish web installer sample data files Fixed Duplicate entry CF-952-i error in marc21_simple_bib_frameworks.sql Signed-off-by: Katrin Fischer katrin.fischer...@web.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13373] Update Polish web installer sample data files
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13373 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13373] Update Polish web installer sample data files
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13373 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #35421|0 |1 is obsolete|| --- Comment #14 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 35422 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35422action=edit [SIGNED OFF] Bug 13373 - Update Polish web installer sample data files. Part 2/2 - optional files. Changes: - Deleted unnecessary files - Translated description files and some values in sql files To test: - Aplly patch - Run webinstaller on empty database (drop database and create new if necessary) - Verify everything works, especially verify you have permission to all modules, eg. Tools, Catalouging etc. - Check spelling and grammar if you can :) Signed-off-by: Chris ch...@bigballofwax.co.nz Signed-off-by: Katrin Fischer katrin.fischer...@web.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13373] Update Polish web installer sample data files
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13373 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #35398|0 |1 is obsolete|| Attachment #35399|0 |1 is obsolete|| Attachment #35400|0 |1 is obsolete|| --- Comment #13 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 35421 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35421action=edit [SIGNED OFF] Bug 13373 - Update Polish web installer sample data files. Part 1/2 - mandatory files. Changes: - Translated user permission and user flags. - Changed untranslated different files from en version - Deleted unnecessary files To test: - Aplly patch - Run webinstaller on empty database (drop database if necessary) - Verify everything works, especially verify you have permission to all modules, eg. Tools, Catalouging etc. - Check spelling and grammar if you can :) Signed-off-by: Chris ch...@bigballofwax.co.nz Signed-off-by: Katrin Fischer katrin.fischer...@web.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13373] Update Polish web installer sample data files
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13373 --- Comment #15 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 35423 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35423action=edit [SIGNED OFF] Bug 13373 - [QA Followup] - Update Polish web installer sample data files Fixed Duplicate entry CF-952-i error in marc21_simple_bib_frameworks.sql Signed-off-by: Katrin Fischer katrin.fischer...@web.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13536] Date due without time on CHECKOUT alert
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13536 Aleisha Amohia aleishaamo...@hotmail.com changed: What|Removed |Added CC||aleishaamo...@hotmail.com Status|Needs Signoff |Failed QA --- Comment #2 from Aleisha Amohia aleishaamo...@hotmail.com --- Can't see issues.date_due_without_time to replace issues.date_due when editing the notice - setting to Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11193] Update Queryparser conf file to take into account changes made by bug 8252
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11193 --- Comment #8 from David Cook dc...@prosentient.com.au --- (In reply to mathieu saby from comment #7) My personal opinion is that QP having been introduced in 2012, it should be well documented and bug-proof, and the older code should have been deprecated. Mathieu That would imply that someone was still working on QP ;). As far as I know, no one is actually actively maintaining or enhancing that code. I have some ideas about how to do that, but I don't have the time/money/sponsorship/whatever to do it. The older code is still used in many many cases even when QP is activated, so deprecating the older code is really not an option at this stage. As for documentation, http://evergreen-ils.org/dokuwiki/doku.php?id=documentation:technical:search_grammar might give you some guidance, although obviously it won't be the same since it's implemented differently in Koha. As far as I know, Evergreen doesn't have a search engine per se. Rather, it uses special tables and full-text indexing within PostgreSQL, so a lot of things (like facets) are totally irrelevant for Koha. But yeah... in the end there's no one who is currently maintaining QP, as far as I know, so I wouldn't expect too much from it at the moment. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11193] Update Queryparser conf file to take into account changes made by bug 8252
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11193 --- Comment #9 from David Cook dc...@prosentient.com.au --- (In reply to M. de Rooy from comment #5) Rebased a trivial merge conflict in the yaml file. Note that running koha qa tools on this patch produces quite some output. And finally: FAIL etc/searchengine/queryparser.yaml FAIL yaml_valid YAML Error: Inconsistent indentation level Moving to FQA to express need for clarification. Why are there two patches at the moment? Is one with a correct indentation level and the other is not? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11961] Add a Z39.50 search button to the authority creation and modfication forms.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11961 Aleisha Amohia aleishaamo...@hotmail.com changed: What|Removed |Added Attachment #30772|0 |1 is obsolete|| --- Comment #7 from Aleisha Amohia aleishaamo...@hotmail.com --- Created attachment 35418 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35418action=edit This patch fix the QA critical error, fix the capitalization and the UNIMARC support. http://bugs.koha-community.org/show_bug.cgi?id=11961 Signed-off-by: Aleisha aleishaamo...@hotmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11961] Add a Z39.50 search button to the authority creation and modfication forms.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11961 Aleisha Amohia aleishaamo...@hotmail.com changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
