[Koha-bugs] [Bug 13621] OpacTopissue

2015-02-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13621

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #1 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Hi Christopher,
maybe this would be better on the mailing list? - Only a few people are reading
the bugs list, so not a lot of people will notice your question here. On the
other hand for a bug report we'd need more information on the problems you see.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7710] multiple holds per title

2015-02-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7710

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #81 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Hi Nick, reading your comment - good catch! Moving to Failed QA for now.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata

2015-02-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA
 CC||katrin.fisc...@bsz-bw.de

--- Comment #16 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Hi Héctor,

I took a quick look at the list of files in your patch - there are a lot of
permission changes on files in there, that I think were not intentional - could
you check please?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13661] Prevent sabotaging Zebra indexing from the cataloguing module by creating a subfield with a very long word.

2015-02-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13661

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #1 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
I wonder, shouldn't the max length definition on the subfield configuration
page stop you from doing this?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata

2015-02-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 CC||ro...@catalyst.net.nz

--- Comment #17 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Also adding Robin here, because of the new dependencies added by this patch.
All dependencies needed for Koha should be available as packages later
(comment#15).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13602] Username/password already exists when editing borrower attributes and messaging preferences

2015-02-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13602

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

   Severity|normal  |major

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13636] Search results item status incorrect for holds

2015-02-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13636

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13636] Search results item status incorrect for holds

2015-02-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13636

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

  Attachment #35608|0   |1
is obsolete||

--- Comment #4 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 35730
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35730action=edit
[PASSED QA] Bug 13636 - Staff search results item status incorrect for holds

Imagine this scenario: we have one record with four items. Two of those
items are checked out, one of those items is a waiting hold, and one of
those items is available. We would expect to see this on the search
results page. Instead, we will see both non-checked out items as
unavailable due to waiting holds.

This is due to a semantic issue GetReserveStatus.
C4::Search::searchResults uses GetReserveStatus to get the reserve
status of each item, but unlike all other calls to the sub, this one
passes in not only itemnumber, but biblionumber.

When no reserve is found for the available item, the subroutine uses the
biblionumber to grab what is essentially an arbitrary reserve to use for
the status. This makes no sense and this functionality should be
entirely removed from the subroutine so regressions like this will be
prevented in the future.

Test Plan:
1) Create one record with 4 items
   a) check two of the items out to patrons
   b) set one of the items as a waiting hold
   c) leave the fourth item as available
2) Run a search where this record will be in the results list
3) Note that the results list 2 items on loan, two unavailable
4) Apply this patch, reload the search results
5) Note that the results list 1 available, 2 on loan, 1 unavailable

Signed-off-by: John Andrews jandr...@washoecounty.us
Signed-off-by: Sheila Kearns sheila.kea...@state.vt.us

Signed-off-by: Katrin Fischer katrin.fischer...@web.de
Note: This is for the staff search result list!

Works as expected.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13682] New: Capitalization: Holds Queue

2015-02-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13682

Bug ID: 13682
   Summary: Capitalization: Holds Queue
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org

Holds Queue should be Holds queue on the Circulation  Holds queue page.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13682] Capitalization: Holds Queue

2015-02-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13682

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

   Keywords||Academy

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13683] Display library name on holds queue page

2015-02-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13683

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

   Keywords||Academy

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13683] New: Display library name on holds queue page

2015-02-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13683

Bug ID: 13683
   Summary: Display library name on holds queue page
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org

On the holds queue report page if holds are found for a library, it displays:

x items found for MPL

above the table. Instead of showing 'MPL' it should show the library's name
using the TT plugin.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13352] Editing amount in Acquisitions budget causes error due to formatting

2015-02-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13352

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

  Attachment #35703|0   |1
is obsolete||

--- Comment #6 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 35724
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35724action=edit
[PASSED QA] Bug 13352: On editing, prices should not be formatted

Bug 12979 refactored the way to display prices.
The price format configuration was duplicated everywhere it was used.

All calls looks good except the one in admin/aqbudgetperiods.pl
In this one, the prices are formatted for an edition field (input).
This means the input is incorrectly filled even if the user does not
update the field.

At the end, maybe should we manage formatted prices everywhere, even in
inputs, but it's not in the scope of this bug.

Technically, a new subroutine format_for_editing is added to the
Koha::Number::Price module.
It should be called everywhere a price is displayed in an input field.
At the moment, it only does a sprintf(%.2f), but it is a first step to
let the number of decimals to display configurable.

To test:
1/ Verify the issue described is fixed (editing a budget with a total
amount  1000 (With CurrencyFormat is US or FR).
2/ Verify you can edit a fund with a total amount  1000

Signed-off-by: Paola Rossi paola.ro...@cineca.it
Signed-off-by: Katrin Fischer katrin.fischer...@web.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13431] Shared FastMmap file causes issues

2015-02-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13431

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

  Attachment #35726|0   |1
is obsolete||

--- Comment #28 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 35728
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35728action=edit
[SIGNED OFF] Bug 13431 [QA Follow-up]: Shared FastMmap file causes issues

1) Removed 'use C4::Context;' because it can lead to introduction
of circular reference in the near future
2) Put fastmmap initialization code into an eval {} block, to catch
various kinds of errors which can still occur during it's init in
some [less usual] Koha setups and/or more unusual circumstances
3) Do not include UID in the sharefile name (it will be constructed
using namespace + database name + database host instead).

Test plan addendum:

   s/and UID//

Signed-off-by: Katrin Fischer katrin.fischer...@web.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13431] Shared FastMmap file causes issues

2015-02-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13431

--- Comment #27 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 35727
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35727action=edit
[SIGNED OFF] Bug 13431 - Shared FastMmap file causes issues

Koha::Cache package does not take into account that, when using
fastmmap caching variant, mmaped cache file created in /tmp
(typically: /tmp/sharefile-koha-koha), would only be further
accessible to the one given OS user - the one which created it.
In many Koha setups, in the circumstances when various system scripts
are executed by 2+ users with diffrent UIDs (like multi-tenant servers,
for example) this may cause many kinds of issues. Observable symptom
is usually the appearance of the below error when searching, or looking
at MARC Framework pages and a few other places:

Open of share file /tmp/sharefile-koha-koha failed: Permission denied
at /usr/lib/perl5/Cache/FastMmap.pm line 640.

This patch:
- disables initialisation of fastmmap caching subsystem unless it is
explicitly requested by the user (CACHING_SYSTEM=fastmmap)
- disables fastmmap cache usage for command line scripts
(i.e. when GATEWAY_INTERFACE environment variable is not defined)
- adds the database name, host name and an ID of the OS user to the
mmaped file name created in /tmp, to prevent various kinds of
unintentional conflicts and/or permission problems from happening

To test:

1) remove the /tmp/sharefile-koha-* file[s] (if any)
2) do something which would lead to its re-creation (e.g., performing
any search in OPAC should be sufficient to cause that)
3) observe that /tmp/sharefile-koha-koha got created
4) remove it
5) apply patch
6) redo step 2)
7) observe that aforementioned file is no longer created in /tmp
8) set CACHING_SYSTEM environment variable to 'fastmmap'
9) redo step 2), observe that /tmp/sharefile-koha-* file got created
and that it's name now contains hostname, database name and UID
10) ensure that everything still works like it should and that there
are no regressions of any kinds anywhere in the system ;)

Signed-off-by: Katrin Fischer katrin.fischer...@web.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11998] Syspref caching issues

2015-02-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
 Status|Needs Signoff   |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13431] Shared FastMmap file causes issues

2015-02-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13431

--- Comment #24 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Tested with both patches applied after running into the FastMmap issue again.
This seems to work fine, but there is a small discrepancy to the test plan:

3) Do not include UID in the sharefile name (it will be constructed
using namespace + database name + database host instead).

Test plan addendum:

   s/and UID//

My files were created in:

/tmp/sharefile-koha-koha-localhost-koha

So it looks like the UID is still present?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13431] Shared FastMmap file causes issues

2015-02-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13431

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

  Attachment #34453|0   |1
is obsolete||
  Attachment #34826|0   |1
is obsolete||

--- Comment #26 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 35726
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35726action=edit
[SIGNED OFF] Bug 13431 [QA Follow-up]: Shared FastMmap file causes issues

1) Removed 'use C4::Context;' because it can lead to introduction
of circular reference in the near future
2) Put fastmmap initialization code into an eval {} block, to catch
various kinds of errors which can still occur during it's init in
some [less usual] Koha setups and/or more unusual circumstances
3) Do not include UID in the sharefile name (it will be constructed
using namespace + database name + database host instead).

Test plan addendum:

   s/and UID//

Signed-off-by: Katrin Fischer katrin.fischer...@web.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13431] Shared FastMmap file causes issues

2015-02-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13431

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
   Patch complexity|Trivial patch   |Medium patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13488] FastMmap can not be disable

2015-02-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13488

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|NEW |RESOLVED

--- Comment #2 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
bug 13431 will fix this problem by making it necessary to turn it on
explicitly.

*** This bug has been marked as a duplicate of bug 13431 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13431] Shared FastMmap file causes issues

2015-02-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13431

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 CC||stephane.delaune@biblibre.c
   ||om

--- Comment #30 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
*** Bug 13488 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13672] OPAC locks up browser when browsing items from series link with NoveList and OpacHighlightedWords

2015-02-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13672

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

Version|unspecified |master
 CC||katrin.fisc...@bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13672] OPAC locks up browser when browsing items from series link with NoveList and OpacHighlightedWords

2015-02-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13672

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13672] OPAC locks up browser when browsing items from series link with NoveList and OpacHighlightedWords

2015-02-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13672

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

  Attachment #35675|0   |1
is obsolete||

--- Comment #3 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 35729
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35729action=edit
[PASSED QA] Bug 13672 - OPAC locks up browser when browsing items from series
link with NoveList and OpacHighlightedWords

It appears that an empty string is sneaking into the list of words
to highlight and that is causing the browser to freak out.

Test Plan:
1) Enable NoveList
2) Enable OpacHighlightedItems
3) Search a title with a series (i.e. The Hunger Games)
4) Click into the record
5) Click on the series to search it
6) Click on a title in the search results
7) If Firefox doesn't crash, it gives the unresponsive script message
8) Apply this patch
9) Repeat steps 3-6
10) Browser doesn't freak our

Signed-off-by: Jason Robb jr...@sekls.org
Signed-off-by: Katrin Fischer katrin.fischer...@web.de
could not confirm the problem, but small change and
highlighting terms on result list and couldn't find any
regressions in highlighting.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13352] Editing amount in Acquisitions budget causes error due to formatting

2015-02-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13352

--- Comment #5 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Comment on attachment 35703
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35703
[SIGNED OFF] Bug 13352: On editing, prices should not be formatted

Review of attachment 35703:
 -- 
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.htmlbug=13352attachment=35703)
-

::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqbudgets.tt
@@ +462,5 @@
  /li
  
  li
label for=budget_encumbWarning at (%): /label
 +  input type=text name=budget_encumb id=budget_encumb value=[% 
 budget_encumb | $Price on_editing = 1 %] size=10 /

I think it's not needed here - this is a percentage, not a price.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13352] Editing amount in Acquisitions budget causes error due to formatting

2015-02-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13352

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13352] Editing amount in Acquisitions budget causes error due to formatting

2015-02-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13352

--- Comment #7 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 35725
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35725action=edit
Bug 13352: QA Follow-up: Remove Price filter from Warning at (%)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13488] FastMmap can not be disable

2015-02-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13488

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #1 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Running into this again right now...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13431] Shared FastMmap file causes issues

2015-02-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13431

--- Comment #25 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Maybe just a documentation issue?

Test plan says:
namespace + database name + database host

But code looks more like:

namespace + database host + database name

+$share_file = join( '-',
+/tmp/sharefile-koha, $self-{'namespace'},
+C4::Context-config('hostname'), C4::Context-config('database')
);

Signing off - please check my assumptions are correct.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13431] Shared FastMmap file causes issues

2015-02-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13431

--- Comment #29 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
One last note: How can we best document the new CACHING_SYSTEM=fastmmap?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13648] OPAC = hidden removes pull down from item form

2015-02-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13648

--- Comment #1 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 35735
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35735action=edit
Bug 13648: OPAC = hidden removes pull down from edit item form

If you uncheck the checkbox OPAC in the bibliographic framework
definition for an item subfield that is linked to an authorized
value list, the pull down will disappear from the item edit
form on staff. The label still shows.

1) Go to administration  bibliographic frameworks
2) Select a framework and go to the item field (MARC21: 952)
3) Edit a subfield with an authorized values list like damaged,
   lost or withdrawn
4) Uncheck the checkbox for OPAC visibility
5) Edit or add an item within your chosen framework
6) Verify the subfield code and description are shown, but the
   pull down has disappeared
7) Apply patch, verify the pull down shows now
8) Also test following hidden combination works correctly:
   OPAC: checked
   All other options: unchecked

Documentation of hidden values:
http://wiki.koha-community.org/wiki/Hidden_values

With special thanks to Jonathan Druart for helping me figure this out!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13648] OPAC = hidden removes pull down from item form

2015-02-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13648

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13612] Remove old YUI javacript libraries from opac-tmpl

2015-02-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13612

--- Comment #3 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Hi Marc, 

I have the same result, but the css files don't seem to be linked to from
anywhere. My guess is, that we kept them around for look-up, but that they are
not used any longer. Owen, could you confirm?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13643] Can't subscribe to serial emails anymore

2015-02-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13643

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #1 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Hi Nicole,
I have tested this on 3.18.3 and current master and the link shows alright for
me. Conditions: In the subscription a notification template has been chosen and
the user is logged in.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13648] OPAC = hidden removes pull down from item form

2015-02-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13648

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

  Attachment #35735|0   |1
is obsolete||

--- Comment #2 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 35736
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35736action=edit
Bug 13648: OPAC = hidden removes pull down from edit item form

If you uncheck the checkbox OPAC in the bibliographic framework
definition for an item subfield that is linked to an authorized
value list, the pull down will disappear from the item edit
form on staff. The label still shows.

1) Go to administration  bibliographic frameworks
2) Select a framework and go to the item field (MARC21: 952)
3) Edit a subfield with an authorized values list like damaged,
   lost or withdrawn
4) Uncheck the checkbox for OPAC visibility
5) Edit or add an item within your chosen framework
6) Verify the subfield code and description are shown, but the
   pull down has disappeared
7) Apply patch, verify the pull down shows now
8) Also test following hidden combination works correctly:
   OPAC: checked
   All other options: unchecked

Documentation of hidden values:
http://wiki.koha-community.org/wiki/Hidden_values

With special thanks to Jonathan Druart for helping me figure this out!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11982] Show local cover images in the biblio details page in the intranet.

2015-02-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11982

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|In Discussion   |Failed QA

--- Comment #25 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
I tested with one patch visible on the bug report right now and found a small
regression:

Problem:
Amazon cover exists, no local cover 
With patch: no cover is shown in detail page
Without patch: Amazon cover shows

Problem?:
Amazon cover and local cover exist
With patch: local cover is shown
Without patch: Amazon cover is shown

OK:
Only local cover exists
With patch: local cover is shown
Without patch: no cover is shown


Simith or Maxime, can you please take a look?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13404] More »System information« about GRS1 vs DOM settings

2015-02-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13404

--- Comment #10 from Mirko Tietgen mi...@abunchofthings.net ---
(In reply to M. de Rooy from comment #9)
 QA Comment:

 What about: Your configuration file seems to be setup for dom.
 And for grs1: Your configuration file still seems to be setup for grs1.

OK.

 
 Warning message: The zebra_auth_index_mode entry is set to dom, but your
 system appears to be set up for grs1 indexing. It is safe to ignore this
 warning if biblio search is working.
 I would recommend to remove the last sentence. There is something wrong
 here. Let them find out and correct. If we already add 'safe to ignore',
 does this warning still have any function?

OK.

As GRS1 seems to be kicked out pretty soon now, I agree with your changes.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7843] Create RSS for OPAC news

2015-02-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7843

Viktor Sarge viktor.sa...@regionhalland.se changed:

   What|Removed |Added

  Attachment #28926|0   |1
is obsolete||

--- Comment #8 from Viktor Sarge viktor.sa...@regionhalland.se ---
Created attachment 35733
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35733action=edit
Bug 7843 Create an RSS feed for news in Opac

Test plan:
* Install the patch
* Make shure there is news in the Opac
* Go to the Opac (opac-main.pl)
* Make shure you see an RSS icon below the news and a short text.
* Click the RSS icon and verify that you get an RSS feed that validates.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5144] Duplicate holds allowed if patron clicks back button after placing hold

2015-02-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #22 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
I fail to replicate the issue in the bootstrap OPAC. I am not able to place
another hold, but there is no good feedback - the button just won't work.
Investigating further.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7843] Create RSS for OPAC news

2015-02-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7843

Viktor Sarge viktor.sa...@regionhalland.se changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

--- Comment #9 from Viktor Sarge viktor.sa...@regionhalland.se ---
Ok first of all - sorry I forgot about this one for a long time. But here's a
new patch. 

Validation of the feed is ok but it still wants an unique identifier. I chose
however to rather keep it a small patch and update if people are ok with the
additional changes to news. Especially since I'd like to have a newsarchive + a
view for single newsitems to link to.

The text RSS for the librarys general newsfeed. on opac-main.pl is there to
try and explain to people will se only news directed to all libraries and will
not get the news they might be seeing if they are logged in to a branch. We
will need a way to switch between branches since both news, CSS and other
content might be different on the branches.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13603] autoBarcode setting hbyymmincr not taking month into account when looking up next increment

2015-02-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13603

--- Comment #5 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
After testing this I understand better - the problem is that the last bit of
the number is not reset each month but keeps counting.

I feel ok about changing it now.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13670] Patron holds table not loading when holds tab anchor is used

2015-02-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13670

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13670] Patron holds table not loading when holds tab anchor is used

2015-02-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13670

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

  Attachment #35676|0   |1
is obsolete||

--- Comment #4 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 35731
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35731action=edit
[PASSED QA] Bug 13670 - Patron holds table not loading when holds tab anchor is
used

If a link to a patron record ends with #reserves, the holds tab is selected
on page load, but the holds table does not load.

Test Plan:
1) Build your holds queue
2) From the holds queue report, open any patron link
3) Note the patron's reserves do not load
4) Apply this patch
5) Clear your browser cache
6) Repeat step 2
7) Note the holds table now loads

Signed-off-by: Sean McGarvey se...@pascolibraries.org

Signed-off-by: Katrin Fischer katrin.fischer...@web.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13675] the budget of an order is set to null if not changed on receiving

2015-02-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13675

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

  Attachment #35710|0   |1
is obsolete||

--- Comment #3 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 35732
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35732action=edit
[PASSED QA] Bug 13675: Do not set aqorders.budget_id to NULL

C4::Acquisition::ModReceiveOrder updates the aqorders with
budget_id=NULL if no budget_id given in parameter.
Actually the same budget_id should be used.
In tests (especially t/db_dependent/Acquisition/TransferOrder.t),
ModReceiveOrder is not called with a budget_id param and set to NULL the
budget_id value.

test plan:
  prove t/db_dependent/Acquisition/TransferOrder.t
should return green

Note that this bug should not appear using the interface.

Signed-off-by: Tomas Cohen Arazi tomasco...@gmail.com
The fix makes sense, and running
 $ prove t/db_dependent/Acq*
returns all green. koha-qa.pl also likes it.

Signed-off-by: Katrin Fischer katrin.fischer...@web.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13675] the budget of an order is set to null if not changed on receiving

2015-02-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13675

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9351] item type not recorded correctly in statistics for returns and some local use

2015-02-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #46 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Ok, it works now alright for item-level itypes = specific item, but setting the
syspref to bibio level it still takes the itype from the item level?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5144] Duplicate holds allowed if patron clicks back button after placing hold

2015-02-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #23 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
I fail to see a message on the bootstrap OPAC with the patches as well.

Test done:
- Place an item level hold on a record
- Get redirected to patron account
- Use back button of the browser
- Hit 'place hold' button again - it's not functional, nothing happens

Kyle, can you please take a look?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13603] autoBarcode setting hbyymmincr not taking month into account when looking up next increment

2015-02-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13603

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13603] autoBarcode setting hbyymmincr not taking month into account when looking up next increment

2015-02-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13603

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

  Attachment #35450|0   |1
is obsolete||

--- Comment #4 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 35734
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35734action=edit
[PASSED QA] Bug 13603 - autoBarcode setting hbyymmincr not taking month into
account when looking up next increment

The hbyymmincr autoBarcode builder looks up all barcodes that begin with
any number of letters ( the branchcode ) and a two-digit year directly
afterward ( e.g. MPL15 ), then grabs the last four digits as the
increment counter. The problem is, this does not take months into
account, so unlike the description that says the system is limited to
10,000 items a month, it is limited to 10,000 items per *year*.

This situation can easily be corrected my adding the month into the
lookup ( e.g. MPL1501 ).

Test Plan:
1) Enable autoBarcode, set to hbyymmincr
2) Catalog an item, let the barcode.pl plugin generate
   the next barcode.
3) Catalog an item with the barcode MPL1500
4) Catalog another item, use the barcode.pl plugin to
   generate the next barcode.
5) Note the barcode is generated ends with '0001' instead of the
   correct increment
6) Apply this patch
7) Repeat step 4
8) Note the barcode now ends with the correct increment

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

Signed-off-by: Jeanne Heicher nppub...@pa.net

Signed-off-by: Katrin Fischer katrin.fischer...@web.de
Problem confirmed - the continuing number bit was not reset
to start counting from 1 again on the beginning of a new month.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9303] relative's checkouts in the opac

2015-02-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Passed QA   |Failed QA

--- Comment #198 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
(In reply to Kyle M Hall from comment #165)
 (In reply to Katrin Fischer from comment #164)
  Hi Kyle,
  
  have you been able to reproduce/fix the first issue with the javascript
  error in the OPAC?
 
 Not yet, would it be possible for you to create a video to demonstrate the
 issue? That way I can see if I'm making mistakes in my attempt to reproduce
 the problem.

I can't do a video - but I found the reason:
NetworkError: 404 Not Found -
http://localhost/cgi-bin/koha/svc/patron/show_checkouts_to_relatives;

This file is not added by this patch set, but referenced in opac-memberentry.tt
on line 829.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10276] Extend IndependentBranches to support groups of libraries

2015-02-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276

--- Comment #62 from M. Tompsett mtomp...@hotmail.com ---
Comment on attachment 28360
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28360
Bug 10276 [QA Followup 2] - Remove stringify, use placeholders for db queries

Review of attachment 28360:
 -- 
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.htmlbug=10276attachment=28360)
-

::: C4/Acquisition.pm
@@ +2414,5 @@
 +my @branches = GetIndependentGroupModificationRights();
 +$query .=
 +   AND ( borrowers.branchcode = ? OR borrowers.branchcode IN ( 
 +  . join( ',', ('?') x @branches ) .  ) ) ;
 +push( @query_params, @branches );

2416 has a ? in addition to the join'd ones on 2417. This leads to an off by
one error. :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9351] item type not recorded correctly in statistics for returns and some local use

2015-02-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351

--- Comment #48 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Hm, are you sure?

This patch corrects this problem by getting itemtype from $item-{'itype'} 
which comes from item or biblio level in GetItem().

Maybe the reason is that I had both and it only falls back if you have no item
level itypes? Fridolin, could you take a quick look and confirm what is he
correct default behaviour?

I would be really interesting to know if record level itypes still used by a
lot of libraries.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved

2015-02-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999

--- Comment #14 from M. de Rooy m.de.r...@rijksmuseum.nl ---
(In reply to Julian Maurice from comment #13)
 Patch rebased on master (and consequently on top of bug 13116)
 
 There is one unit test that fails in t/db_dependent/Holds.t (line 331), but
 it fails on master too.
 Should I open a separate bug for this ?

Current master e5b834a1c474f761c9f9c8c01dd6abeb99ee5eac does not fail this test
with me.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata

2015-02-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642

--- Comment #18 from Robin Sheat ro...@catalyst.net.nz ---
(In reply to Katrin Fischer from comment #17)
 Also adding Robin here, because of the new dependencies added by this patch.
 All dependencies needed for Koha should be available as packages later
 (comment#15).

Packages need to be created for:

HTML::Entities
XML::Entities

Please verify that the versions specified for:

RDF::Trine
RDF::Helper

are actually the real minimum required, as they are not in any released debian
version as they are specified, and that makes life substantially harder.

Hopefully the dependency issues noted by Marc aren't too serious, or it simply
might not be possible to backport these modules to squeeze.

It might be a while before I get to look into doing these (though they are
added to my todo list) as I'm quite busy, if someone wants to help speed it
along, try building the packages using dh-make-perl and testing them under
squeeze (a pbuilder environment helps here), and noting anything special that
has to be done.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12916] Use of uninitialized values $max and $min in C4/Tags.pm

2015-02-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12916

--- Comment #16 from M. Tompsett mtomp...@hotmail.com ---
Could this be included in 3.16.x? It applies cleanly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9351] item type not recorded correctly in statistics for returns and some local use

2015-02-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351

--- Comment #47 from David Cook dc...@prosentient.com.au ---
(In reply to Katrin Fischer from comment #46)
 Ok, it works now alright for item-level itypes = specific item, but setting
 the syspref to bibio level it still takes the itype from the item level?

Yes, but that's already the default behaviour for the other existing instances
of UpdateStats() (e.g. issues and renewals).

I think requiring handling of biblio level itypes would be scope creep for this
bug, since this bug is just trying to create consistency.

If we want to support biblio level itypes, I think that should be a separate
bug which then fixes it across the board for all calls of UpdateStats().

But that's just my 2 cents :).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13607] Patron management API

2015-02-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13607

--- Comment #12 from Robin Sheat ro...@catalyst.net.nz ---
Created attachment 35737
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35737action=edit
Bug 13607: fix to account for _ in fieldnames

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13607] Patron management API

2015-02-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13607

Robin Sheat ro...@catalyst.net.nz changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13607] Patron management API

2015-02-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13607

--- Comment #13 from Robin Sheat ro...@catalyst.net.nz ---
(In reply to Magnus Enger from comment #11)
 Also, the message in the response would look better without the trailing
 newline, I think.

I agree, but if you remove the \n then die adds in file blah.pl line 123,
which I think is even worse than a trailing newline.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/