[Koha-bugs] [Bug 14395] Two different ways to calculate 'No renewal before' (days or hours)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395 Jonathan Druart jonathan.dru...@bugs.koha-community.org changed: What|Removed |Added Status|Signed Off |Patch doesn't apply CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #24 from Jonathan Druart jonathan.dru...@bugs.koha-community.org --- Applying: Bug 14395: Add new syspref NoRenewalBeforePrecision Applying: Bug 14395: Code changes fatal: sha1 information is lacking or useless (C4/Circulation.pm). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11431] Add additional sound options for warnings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #83 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 41661 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41661action=edit Bug 11431 [QA Followup] - Unit Tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10988] Allow login via Google OAuth2
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10988 --- Comment #41 from Jonathan Druart jonathan.dru...@bugs.koha-community.org --- Created attachment 41663 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41663action=edit Bug 10988: Fix the svc script path -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14693] New: t/db_dependent/Contract.t fails do to fixed date
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14693 Bug ID: 14693 Summary: t/db_dependent/Contract.t fails do to fixed date Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: ch...@bigballofwax.co.nz Reporter: tomasco...@gmail.com QA Contact: gmcha...@gmail.com To reproduce: - Run (on master) $ prove t/db_dependent/Contract.t = FAIL: tests fail due to a fixed date (2015-07-31) being set as a future date which hasn't arrived yet. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11584] Add wysiwyg editor to system preferences dealing with HTML
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11584 --- Comment #24 from Jonathan Druart jonathan.dru...@bugs.koha-community.org --- Created attachment 41673 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41673action=edit Bug 11584 - Add wysiwyg editor to system preferences dealing with HTML (add system preference) This patch adds a system preference UseWYSIWYGinSystemPreferences to the Staff Client tab. By default, it is off, which means that the TinyMCE WYSIWYG editor won't be shown for system preferences with a type of htmlarea. However, when it's on, it will show the editor for Local Use preferences with a htmlarea type, and for other system preferences in the Opac, Circulation, and Staff Client tabs, which I have re-assigned. (Basically, I grepped for HTML and changed the type for all the system preferences I found except for IntranetNav, OpacCustomSearch, and OPACSearchForTitleIn, as a WYSIWYG editor would potentially break the output for these system preferences or add no value to them...) _TEST PLAN_ 0) Run `perl installer/data/mysql/updatedatabase.pl` after setting your environmental variables 1) Check the Opac tab to make sure that the WYSIWYG is nowhere to be seen 2) Change the UseWYSIWYGinSystemPreferences preference in Staff Client to Show 3) Refresh the Opac tab and notice that many system preferences now have a WYSIWYG editor 4) Try typing some text into these fields 5) Note that it gets marked as modified 6) Save the preference, and refresh the page 7) Note that the content has been saved 8) Take a look at how it's rendered on the actual webpage! Signed-off-by: Martin Persson xarra...@gmail.com Signed-off-by: Jonathan Druart jonathan.dru...@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11584] Add wysiwyg editor to system preferences dealing with HTML
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11584 --- Comment #25 from Jonathan Druart jonathan.dru...@bugs.koha-community.org --- Created attachment 41674 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41674action=edit Bug 11584: Syspref WYSIWYG, dropdown added This patch adds the 'Htmlarea' type to the dropdown box introduced by bug 14268, commit 6e3bcc38. Sponsored-By: Halmstad County Library Signed-off-by: Jonathan Druart jonathan.dru...@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14579] 'You are not logged in' should link to log in page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14579 Joonas Kylmälä j.kylm...@gmail.com changed: What|Removed |Added Attachment #41106|0 |1 is obsolete|| --- Comment #4 from Joonas Kylmälä j.kylm...@gmail.com --- Created attachment 41658 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41658action=edit Bug 14579: 'You are not logged in' should link to log in page I fixed the aligment of the two links but the padding still needs to be set right. I also fixed mismatching html tags. To test: 1) Go to any page on the staff client and make sure you are not logged in (ie an error page, cgi-bin/koha/errors/400.pl) 2) Try click on 'You are not logged in |' 3) Notice it is not really a link and doesn't take you anywhere 4) Apply patch 5) Refresh page 6) Click on what now says 'Log in |' 7) Confirm that you are redirected to the intranet log in page -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12632] Hold limits ignored for record level holds with item level itemtypes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12632 Jonathan Druart jonathan.dru...@bugs.koha-community.org changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #20 from Jonathan Druart jonathan.dru...@bugs.koha-community.org --- One test does not pass for me: # Failed test 'Patron cannot reserve item with hold limit of 1, 1 bib level hold placed' # at t/db_dependent/Holds.t line 449. # got: 'OK' # expected: 'tooManyReserves' -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14174] Home suspension and / or in situ
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14174 Héctor hectore...@yahoo.com.ar changed: What|Removed |Added Priority|P5 - low|P4 Version|unspecified |master Severity|enhancement |new feature Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14101] auto renewal is tied to 'no renewal before'
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14101 Jonathan Druart jonathan.dru...@bugs.koha-community.org changed: What|Removed |Added Status|Signed Off |Failed QA CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #21 from Jonathan Druart jonathan.dru...@bugs.koha-community.org --- Holger, please provide tests for the changes done to CanBookBeRenewed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11431] Add additional sound options for warnings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Kyle M Hall kyle.m.h...@gmail.com changed: What|Removed |Added CC||kyle.m.h...@gmail.com --- Comment #85 from Kyle M Hall kyle.m.h...@gmail.com --- (In reply to Kyle M Hall from comment #84) Created attachment 41662 [details] [review] Bug 11431 [QA Followup] - Simplify audio_alert_id to just id audio_alert_id is very wordy and it's a better convention to just give the table id the name 'id'. No changes in the code were needed since I was already using the id() method. Unit tests pass pre and post patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14375] DBIx::Connector should be stored in C4::Context instead of dbh
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14375 --- Comment #15 from Jonathan Druart jonathan.dru...@bugs.koha-community.org --- (In reply to Fridolin SOMERS from comment #14) Created attachment 41439 [details] test module Test module. It saves a record and tries to get it each 15 minutes 4 times. Without patch, it fails with : database has run away. Why 900sec? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14685] Cannot set guarantor for a child account
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14685 Jonathan Druart jonathan.dru...@bugs.koha-community.org changed: What|Removed |Added Version|3.20|master Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13811] Silent Cronjobs
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13811 Jonathan Druart jonathan.dru...@bugs.koha-community.org changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14621] Messaging preferences table needs to be sorted
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14621 Joonas Kylmälä j.kylm...@gmail.com changed: What|Removed |Added CC||j.kylm...@gmail.com Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14337] AllowRenewalIfOtherItemsAvailable counts holdable not for loan items when checking renewability
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14337 Jonathan Druart jonathan.dru...@bugs.koha-community.org changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #7 from Jonathan Druart jonathan.dru...@bugs.koha-community.org --- Kyle, the test you have provided passes against master. I would expect something to fail, and then to be fixed by your patch. Why is the version set to 3.18? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14589] Replace fetch CGI::Cookie calls
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14589 Marcel de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Attachment #41457|0 |1 is obsolete|| --- Comment #4 from Marcel de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 41675 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41675action=edit Bug 14589: Replace fetch CGI::Cookie calls This patch is inspired by the change in bug 14588. It replaces the indirect object syntax for CGI::Cookie. Some trivial corrections are made to authorities/merge_ajax.pl just as bug 14588 does for cataloguing. Test plan: Run the URL authorities/merge_ajax.pl in staff. Upload a file with Stage MARC records for import. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14100] Generic solution for language overlay
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14100 Josef Moravec josef.mora...@gmail.com changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14100] Generic solution for language overlay
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14100 Josef Moravec josef.mora...@gmail.com changed: What|Removed |Added Attachment #41654|0 |1 is obsolete|| --- Comment #16 from Josef Moravec josef.mora...@gmail.com --- Created attachment 41660 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41660action=edit Bug 14100: (follow-up) Language overlay for item types Display the translated description for item types in the following pages: admin/smart-rules.pl catalogue/detail.pl catalogue/itemsearch.pl catalogue/moredetail.pl reports/acquisitions_stats.pl reports/bor_issues_top.pl reports/cat_issues_top.pl reports/catalogue_out.pl reports/catalogue_stats.pl reports/issues_avg_stats.pl reports/issues_stats.pl reports/itemslost.pl reports/manager.pl reports/reserves_stats.pl suggestion/suggestion.pl tools/export.pl Opac: opac-detail.pl opac-MARCdetail.pl opac-search.pl Signed-off-by: Josef Moravec josef.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11431] Add additional sound options for warnings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14588] Simplify merge_ajax.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14588 --- Comment #7 from M. Tompsett mtomp...@hotmail.com --- (In reply to Jonathan Druart from comment #5) (In reply to Marcel de Rooy from comment #1) (Note that Class::-method is preferred above Class-method. See perlobj.) I did not find where it's written it's better. I personally think you are adding a third way where we already have new CGI and CGI-new... I agree that better is not the word used. However, it is expressly explicit in how Perl should interpret the call. There is something to be said positively for explicitness. Because Perl allows you to use barewords for package names and subroutine names, it sometimes interprets a bareword's meaning incorrectly. http://perldoc.perl.org/perlobj.html#Invoking-Class-Methods Though, I do share Jonathan's view that CGI-new is sufficient. This explicit syntax is an example of confusing ugliness that I personally would prefer to avoid. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14683] Unable to clear SMS number
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14683 Joonas Kylmälä j.kylm...@gmail.com changed: What|Removed |Added Status|NEW |Needs Signoff CC||j.kylm...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14683] Unable to clear SMS number
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14683 --- Comment #1 from Joonas Kylmälä j.kylm...@gmail.com --- Created attachment 41664 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41664action=edit Bug 14683: Unable to clear SMS number Enables to clear SMS number. To test: 1. Go to opac-messaging.pl 2. Insert SMS number and submit 3. Clear SMS number and submit 4. Observe that the sms number did not change 5. Apply patch 6. Clear SMS number and submit 7. Observe that the sms number changes Sponsored-by: Vaara-kirjastot -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14174] Home suspension and / or in situ
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14174 Héctor hectore...@yahoo.com.ar changed: What|Removed |Added Severity|new feature |enhancement -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3333] item status for not for loan by item type / item is different
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id= --- Comment #14 from Marcel de Rooy m.de.r...@rijksmuseum.nl --- (In reply to Jonathan Druart from comment #13) (In reply to Nick Clemens from comment #12) Additionally, a Place hold link should disappear in the opac, when it is not possible to place a hold on any item of one biblio. Everything got marked 'Not for loan' as expected, but I didn't see the above triggered 'Item available for reference' statement in OPAC search results also seems a big presumption for a not for loan item type, but that is pre-existing / not your problem Marcel, is it still valid? Should we remove from the test plan or it's a bug? I think so, but will verify. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14674] koha-create should set upload_path in koha-conf.xml
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14674 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |julian.maur...@biblibre.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14588] Simplify merge_ajax.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14588 --- Comment #8 from Marcel de Rooy m.de.r...@rijksmuseum.nl --- If there is widespread concensus for removing this *ugly* construction, I will be happy to remove it quickly :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11431] Add additional sound options for warnings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #84 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 41662 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41662action=edit Bug 11431 [QA Followup] - Simplify audio_alert_id to just id -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14646] Koha::RecordProcessor only accepts one filter at a time
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14646 --- Comment #8 from M. Tompsett mtomp...@hotmail.com --- (In reply to Jonathan Druart from comment #7) (In reply to M. Tompsett from comment #4) NOTE: Read code. Don't like the ? operator logic, but it is functional despite readability issues. Something better to suggest? As noted it is merely readability issues. I do not have anything better to suggest. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14321] Merge UploadedFile and UploadedFiles into Koha::Upload
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321 Marcel de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Attachment #41562|0 |1 is obsolete|| --- Comment #19 from Marcel de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 41669 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41669action=edit Bug 14321: Final cleanup, removing obsolete files The new Upload.pm, unit test and file-upload.js obsolete a number of files, including an older jQuery plugin. The test files progressbar.pl and progressbarsubmit.pl are outdated and do not serve any purpose in this form. (Actually, we could argue if they should be here or just be part of a debugging phase.) Test plan: [1] Git grep on file-progress, file-upload.inc, UploadedFile, ajaxfileupload, ajaxFileUpload UploadedFile: Only a reference to DBIx file is found ajaxfileupload: Only release notes [2] Upload a file with tools/upload and stage-marc-import. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14321] Merge UploadedFile and UploadedFiles into Koha::Upload
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321 --- Comment #18 from Marcel de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 41668 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41668action=edit Bug 14321: Just some documentation lines added or fixed Test plan: Actually, you cannot really test this. But you could run the unit test again. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14321] Merge UploadedFile and UploadedFiles into Koha::Upload
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321 Marcel de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Attachment #41560|0 |1 is obsolete|| --- Comment #16 from Marcel de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 41666 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41666action=edit Bug 14321: Unit test for Koha::Upload This unit test replaces the test for UploadedFiles.pm. That one used dependency Test::CGI::Multipart. We are now mocking CGI and its hook to achieve the same result. Some tests are added to cover additional routines in Upload.pm. Test plan: Run the test! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14321] Merge UploadedFile and UploadedFiles into Koha::Upload
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321 Marcel de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Attachment #41559|0 |1 is obsolete|| --- Comment #15 from Marcel de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 41665 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41665action=edit Bug 14321: Switch to Upload in opac-retrieve A last step to obsolete UploadedFiles.pm. Note that we now also check for the public flag. If that flag is not set, the uploaded file cannot be reached via the opac. This patch also the encode step to tools/upload for the http header that could include a filename with special chars (just as in opac-retrieve). Test plan: [1] Check downloading a file marked public in OPAC without logging in. If possible, include some special chars in the filename. [2] Check another file (not marked as public). Should not be possible. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14321] Merge UploadedFile and UploadedFiles into Koha::Upload
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321 Marcel de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Attachment #41561|0 |1 is obsolete|| --- Comment #17 from Marcel de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 41667 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41667action=edit Bug 14321: Fix permissions check in upload-file.pl This fixes an error in one of the patches of bug 6874. The userid of the Koha admin user is passed to haspermission, but we should pick the userid from the session. NOTE: Bug 14686 will add a specific permission for tools/upload.pl. At that time we can add the script to the Tools menu too. For now, you need edit_catalogue to start upload.pl and you will additionally need a permission like upload_local_cover_images (see tools/upload-file) to successfully upload a new file. Searching for files and copying URLs to the editor can still be done with edit_catalogue. Test plan: [1] Pick a staff user that only has catalogue and edit_catalogue. [2] Without this patch, you can upload a file on tools/upload.pl. [3] Apply this patch. [4] Retry. Should not work: Upload status is Denied. [5] Login with enough permissions. Upload again. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14588] Simplify merge_ajax.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14588 --- Comment #6 from Marcel de Rooy m.de.r...@rijksmuseum.nl --- (In reply to Jonathan Druart from comment #5) (In reply to Marcel de Rooy from comment #1) (Note that Class::-method is preferred above Class-method. See perlobj.) I did not find where it's written it's better. I personally think you are adding a third way where we already have new CGI and CGI-new... ThereIsMoreThanOneWayToDoIt The reference is few comments up, but for the rest it is completely unimportant. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 Jonathan Druart jonathan.dru...@bugs.koha-community.org changed: What|Removed |Added Status|Signed Off |Patch doesn't apply --- Comment #49 from Jonathan Druart jonathan.dru...@bugs.koha-community.org --- Kyle, could you please rebase this patch? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14321] Merge UploadedFile and UploadedFiles into Koha::Upload
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321 --- Comment #20 from Marcel de Rooy m.de.r...@rijksmuseum.nl --- Small consistency adjustment in patch 5 and new patch 8 for some pod lines in Upload.pm. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14588] Simplify merge_ajax.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14588 Marcel de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Attachment #41462|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14100] Generic solution for language overlay
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14100 Josef Moravec josef.mora...@gmail.com changed: What|Removed |Added Attachment #40965|0 |1 is obsolete|| --- Comment #15 from Josef Moravec josef.mora...@gmail.com --- Created attachment 41659 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41659action=edit Bug 14100: Generic solution for language overlay - Item types Test plan: 1/ update the Schema (misc/devel/update_dbix_class_files.pl) 2/ Translate templates for some languages (es-DE, de-DE for instance) 3/ Enable them in the pref (search for 'lang') for the staff interface 4/ Go on the item type admin page (admin/itemtypes.pl) 5/ Edit one 6/ Click on the 'translate for other languages' link 7/ You are now on the interface to translate the item type's description in the languages you want. So translate some :) 8/ Go back on the item type list view (admin/itemtypes.pl) 9/ You should see the original description (non translated) 10/ Switch the language 11/ You should see the translated description in the correct language. If the description is non translated, the original description is displayed. 12/ On the different page where the item type is displayed, confirm that the translated description appears. Think further / Todo: 1/ Update all occurrences of the item type's description (DONE) 2/ Implement for authorised values 3/ Implement for syspref value (at least textarea) 4/ Implement for branch names 5/ Centralize all the translation on a single page in the admin area ... N/ Implement a webservice to centralize all the translations and give the ability to sync the item types/authorised values description with the rest of the world (push and pull). Signed-off-by: Josef Moravec josef.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12748] Serials - two issues with status of Expected
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12748 --- Comment #8 from Jonathan Druart jonathan.dru...@bugs.koha-community.org --- Yes, thanks -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14598] itemtype is not set on statistics by C4::Circulation::AddReturn
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 --- Comment #20 from Jonathan Druart jonathan.dru...@bugs.koha-community.org --- I am not sure it's a good idea to use existing subroutines/methods in the updatedb process. It cans work now but how to know it won't be broken in several versions? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14597] Reverting a batch where a record overlaid is now deleted record will fail
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14597
--- Comment #6 from Jonathan Druart jonathan.dru...@bugs.koha-community.org
---
Comment on attachment 41170
-- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41170
[SIGNED-OFF] Bug 14597 - Reverting a batch where a record overlaid is now
deleted record will fail
Review of attachment 41170:
--
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.htmlbug=14597attachment=41170)
-
::: C4/ImportBatch.pm
@@ +813,4 @@
sub BatchRevertRecords {
my $batch_id = shift;
+my $logger = Koha::Logger-get( { category =
'C4.ImportBatch.BatchRevertRecords' } );
Really?
We are going to create an instance of Log::Log4perl for each subroutine call?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10988] Allow login via Google OAuth2
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10988 Jonathan Druart jonathan.dru...@bugs.koha-community.org changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #40 from Jonathan Druart jonathan.dru...@bugs.koha-community.org --- I can take a look again with a detailed test plan using a non-public IP. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3333] item status for not for loan by item type / item is different
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id= --- Comment #13 from Jonathan Druart jonathan.dru...@bugs.koha-community.org --- (In reply to Nick Clemens from comment #12) Additionally, a Place hold link should disappear in the opac, when it is not possible to place a hold on any item of one biblio. Everything got marked 'Not for loan' as expected, but I didn't see the above triggered 'Item available for reference' statement in OPAC search results also seems a big presumption for a not for loan item type, but that is pre-existing / not your problem Marcel, is it still valid? Should we remove from the test plan or it's a bug? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11584] Add wysiwyg editor to system preferences dealing with HTML
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11584 Jonathan Druart jonathan.dru...@bugs.koha-community.org changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11584] Add wysiwyg editor to system preferences dealing with HTML
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11584 Jonathan Druart jonathan.dru...@bugs.koha-community.org changed: What|Removed |Added Attachment #41517|0 |1 is obsolete|| Attachment #41518|0 |1 is obsolete|| Attachment #41520|0 |1 is obsolete|| Attachment #41521|0 |1 is obsolete|| --- Comment #22 from Jonathan Druart jonathan.dru...@bugs.koha-community.org --- Created attachment 41671 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41671action=edit Bug 11584 - Add wysiwyg editor to system preferences dealing with HTML This patch adds the ability to use a WYSIWYG editor for system preferences. The key files that I touch are: 1) admin/systempreferences.pl 2) koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt 3) koha-tmpl/intranet-tmpl/prog/en/modules/admin/systempreferences.tt I also add: 4) koha-tmpl/intranet-tmpl/prog/en/includes/wysiwyg-systempreferences.inc and 5) koha-tmpl/intranet-tmpl/lib/tiny_mce/plugins/advimage This plugin is part of the TinyMCE distribution. It used to be in Koha, but then someone removed it. It's useful for preferences like opacheader though. *If you're using anything except IE, this should work super well. If you're using IE, it'll probably only work for keyboard input and dragging text within the editor box but not from outside of it. IE has worse security, so you can probably paste using the context menu paste. *While I think a WYSIWYG editor can be useful, there might be times where the content is displayed differently than it is in the editor because of higher level CSS and Javascript. Signed-off-by: Martin Persson xarra...@gmail.com Signed-off-by: Jonathan Druart jonathan.dru...@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11584] Add wysiwyg editor to system preferences dealing with HTML
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11584 --- Comment #23 from Jonathan Druart jonathan.dru...@bugs.koha-community.org --- Created attachment 41672 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41672action=edit Bug 11584 - Add wysiwyg editor to system preferences dealing with HTML (add licence) This patch adds the TinyMCE license info to about.pl Signed-off-by: Martin Persson xarra...@gmail.com Signed-off-by: Jonathan Druart jonathan.dru...@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14588] Simplify merge_ajax.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14588 Marcel de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Attachment #41670|0 |1 is obsolete|| --- Comment #10 from Marcel de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 41676 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41676action=edit Bug 14588: Simplify merge_ajax.pl This script does not need a few modules: IO::File; CGI::Session; C4::UploadedFile. Warnings can be enabled (with Modern::Perl). Indirect object syntax replaced for CGI and CGI::Cookie. Moved the $reply line upwards (not needed twice anymore). Test plan: [1] Log in as staff user. Run the URL cataloguing/merge_ajax.pl. You should see the JSON reponse in the browser. [2] Logout. Run the URL again. Blank screen. [3] Go to addbooks.pl (Cataloging Search). Search something, select two biblios and click Merge selected, etc. Signed-off-by: Joonas Kylmala j.kylm...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12311] Batch modification of checked out and lost items checks them in
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12311 Jonathan Druart jonathan.dru...@bugs.koha-community.org changed: What|Removed |Added CC||gaetan.bois...@biblibre.com ||, katrin.fisc...@bsz-bw.de --- Comment #3 from Jonathan Druart jonathan.dru...@bugs.koha-community.org --- I need help on this one to provide a fix. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13585] HEA - Cronjob Setup
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13585 --- Comment #6 from Jonathan Druart jonathan.dru...@bugs.koha-community.org --- Comment on attachment 41024 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41024 Bug 13585 : Add a cronjob which send UsageStats monthly. Review of attachment 41024: -- (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.htmlbug=13585attachment=41024) - ::: debian/koha-common.cron.monthly @@ +15,5 @@ +# You should have received a copy of the GNU General Public License +# along with this program. If not, see http://www.gnu.org/licenses/. + + +koha-foreach --enabled /usr/share/koha/bin/cronjobs/share_usage_with_koha_community.pl The problem is that the share_usage_with_koha_community.pl considers it's an error to launch it if the pref is not enabled. There is a warning message and an exit 1 in this case. I suppose it's not what we want, the admin will receive an email every month. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14608] HEA : add possibility of sharing usage statistics in Administration page and Web installer
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14608 Jonathan Druart jonathan.dru...@bugs.koha-community.org changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #6 from Jonathan Druart jonathan.dru...@bugs.koha-community.org --- Otherwise everything looks good. Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3186] invalid or uninstalled SMSSendDriver (or bad number format) causes process_message_queue to fail
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3186 --- Comment #14 from Jonathan Druart jonathan.dru...@bugs.koha-community.org --- *** Bug 14611 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11559] Professional cataloger's interface
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 --- Comment #121 from Christopher Davis mr.catalo...@gmail.com --- Step 29 of the test plan: the Substitute link to the right of the results list disappears after the first one or two searches, leaving only View MARC and Import links. Also, when viewing the search results within this interface, clicking the Next buttons located near the top and bottom of this list only works for the first two pages. Thereafter, clicking the Next buttons simply redisplays the same page (page two) except that the search results of page two fail to display (blank page). One must click on the number button of the next page (e.g. page three) in order to sequentially move through the pages. FWIW Christopher -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14321] Merge UploadedFile and UploadedFiles into Koha::Upload
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321 Marcel de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Attachment #41669|0 |1 is obsolete|| --- Comment #21 from Marcel de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 41677 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41677action=edit Bug 14321: Final cleanup, removing obsolete files The new Upload.pm, unit test and file-upload.js obsolete a number of files, including an older jQuery plugin. The test files progressbar.pl and progressbarsubmit.pl are outdated and do not serve any purpose in this form. (Actually, we could argue if they should be here or just be part of a debugging phase.) Test plan: [1] Git grep on file-progress, file-upload.inc, UploadedFile, ajaxfileupload, ajaxFileUpload UploadedFile: Only a reference to DBIx file is found ajaxfileupload: Only release notes [2] Upload a file with tools/upload and stage-marc-import. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14536] PageObject-pattern base implementation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14536 --- Comment #11 from Lari Taskula la...@student.uef.fi --- Created attachment 41678 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41678action=edit Bug 14536: (follow-up) Adds polling to Page.pm and enhances navigation. This follow-up adds a subroutine poll to superclass Page.pm. Polling will execute an anonymous subroutine for as long as defined or until the subroutine is successful. Also adds enchancements to navigation success confirmations. In earlier versions, the modify patron page (memberentry.pl) defines page title as follows: Modify category patron name But in current version it is defined as follows: Modify patron name (category) Instead of checking for title Modify patron, we now check for Modify(.*)patron for determining if we are on the right memberentry.pl page. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14611] SMS::Send hangs on malformed mobile #, process_message_queue fails
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14611 Jonathan Druart jonathan.dru...@bugs.koha-community.org changed: What|Removed |Added Resolution|--- |DUPLICATE Status|NEW |RESOLVED CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #5 from Jonathan Druart jonathan.dru...@bugs.koha-community.org --- *** This bug has been marked as a duplicate of bug 3186 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14588] Simplify merge_ajax.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14588 --- Comment #9 from Marcel de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 41670 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41670action=edit Bug 14588: Simplify merge_ajax.pl This script does not need a few modules: IO::File; CGI::Session; C4::UploadedFile. Warnings can be enabled (with Modern::Perl). Indirect object syntax replaced for CGI and CGI::Cookie. (Note that Class::-method is preferred above Class-method. See perlobj.) Moved the $reply line upwards (not needed twice anymore). Test plan: [1] Log in as staff user. Run the URL cataloguing/merge_ajax.pl. You should see the JSON reponse in the browser. [2] Logout. Run the URL again. Blank screen. [3] Go to addbooks.pl (Cataloging Search). Search something, select two biblios and click Merge selected, etc. Signed-off-by: Joonas Kylmala j.kylm...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10009] self check out not really logging out
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10009 Jonathan Druart jonathan.dru...@bugs.koha-community.org changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9913] String::Random should not be required given its limited usage
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9913 Jonathan Druart jonathan.dru...@bugs.koha-community.org changed: What|Removed |Added Resolution|--- |INVALID CC||jonathan.dru...@bugs.koha-c ||ommunity.org Status|NEW |RESOLVED --- Comment #1 from Jonathan Druart jonathan.dru...@bugs.koha-community.org --- It's now used for the captcha at the OPAC. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13073] Search in Russian and in Armenian
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13073 Joonas Kylmälä j.kylm...@gmail.com changed: What|Removed |Added CC||j.kylm...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14694] New: Make decreaseloanHighHolds more flexible
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14694 Bug ID: 14694 Summary: Make decreaseloanHighHolds more flexible Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: kyle.m.h...@gmail.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com This enhancement will add an option to the decreaseloanHighHolds preferences so that users have the ability to choose A) based on the number of holds, as Koha currently does or B) set a number of holds past the number of holdable items in that record Work to be done: l) Add new system Preferences o decreaseloanHighHoldsOffset o decreaseloanHighHoldslgnoreDamaged o decreaseloanHighHoldslgnoreLost o decreaselnanHighHoldslgnoreWthdrawn o decreaseloanHighHoldslgnoreNotForloan 2) Implement logic for new system preferences 3) Add unit tests We could possibly use the multi-select enhancement for system preferences from bug 9043 to avoid having 4 prefs -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14695] New: Add ability to place multiple item holds on a given record per patron
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 Bug ID: 14695 Summary: Add ability to place multiple item holds on a given record per patron Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: kyle.m.h...@gmail.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com Currently Koha only allows one hold to be placed on a given bib per patron, even it the record has multiple items. This enhancement will give Koha the ability to place a hold on at least two items on the same bibliographic record. For example, in the case of a television season DVD which has one record but many unique items. Work to be done: 1) Locate all code in Koha that checks for a patron already having a hold on a record 2) Add a new system preference to define the number of holds allowed per record 3) Create new subroutine/method to check for this 4) Implement call to new sub in areas defined in part 1 5) Ensure no code in C4::Reserves assumes that it can modify holds based on borrowernumber only This is not the first attempt at such a feature, but previous iterations are far out of date. It's time for a fresh start. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 Kyle M Hall kyle.m.h...@gmail.com changed: What|Removed |Added Change sponsored?|--- |Sponsored Assignee|koha-b...@lists.koha-commun |kyle.m.h...@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14608] HEA : add possibility of sharing usage statistics in Administration page and Web installer
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14608 --- Comment #5 from Jonathan Druart jonathan.dru...@bugs.koha-community.org --- The UsageStatsLastDisplay pref should be hidden (like UsageStatsID and usagestatslastupdatetime). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10855] Additional fields for subscriptions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 --- Comment #223 from Jonathan Druart jonathan.dru...@bugs.koha-community.org --- (In reply to Nicole C. Engard from comment #222) The query works for me, maybe you was using an old patchset? With the last patches, the correct collation (utf8_unicode_ci) is used for the new tables. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6514] Save book price in different currencies (cataloging)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6514 Jonathan Druart jonathan.dru...@bugs.koha-community.org changed: What|Removed |Added Severity|major |enhancement CC||jonathan.dru...@bugs.koha-c ||ommunity.org -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14608] HEA : add possibility of sharing usage statistics in Administration page and Web installer
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14608 Jonathan Druart jonathan.dru...@bugs.koha-community.org changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #4 from Jonathan Druart jonathan.dru...@bugs.koha-community.org --- The new pref should be added to the updatedb (atomicupdate file). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10454] Duplicate card numbers may be generated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10454 Jonathan Druart jonathan.dru...@bugs.koha-community.org changed: What|Removed |Added Severity|major |normal CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #24 from Jonathan Druart jonathan.dru...@bugs.koha-community.org --- No activity for 2 years, lowering the severity. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3333] item status for not for loan by item type / item is different
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id= --- Comment #15 from Marcel de Rooy m.de.r...@rijksmuseum.nl --- (In reply to Jonathan Druart from comment #13) (In reply to Nick Clemens from comment #12) Additionally, a Place hold link should disappear in the opac, when it is not possible to place a hold on any item of one biblio. Everything got marked 'Not for loan' as expected, but I didn't see the above triggered Marcel, is it still valid? Should we remove from the test plan or it's a bug? The Place hold link disappears for a biblio with (all) items marked not for loan via the special itemtype. But here is the misunderstanding: The test plan does not include this specific case mentioned in the commit message. (Since the second biblio in the test plan only has one item of the itemtype with NFL.) So no bug, no actual change of test plan needed. Could have been an additional test in the test plan.. And it works for me :) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14143] Patron cards: Crash (confusion between table names creator_templates and club_template_enrollment_fields
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14143 Jonathan Druart jonathan.dru...@bugs.koha-community.org changed: What|Removed |Added Status|Needs Signoff |BLOCKED CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #7 from Jonathan Druart jonathan.dru...@bugs.koha-community.org --- Blocked. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11559] Professional cataloger's interface
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 --- Comment #120 from Christopher Davis mr.catalo...@gmail.com --- Anyone care to reply to comment 115? I think that step 15 of the test plan is referring to Koha authorized values (HomeAdministrationAuthorized values) and not authorized access points from the authority file. Your thoughts? Thanks -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14696] useless use of String::Random in catalogue/search.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14696 --- Comment #1 from Jonathan Druart jonathan.dru...@bugs.koha-community.org --- Created attachment 41680 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41680action=edit Bug 14696: useless use of String::Random in catalogue/search.pl Bug 10404 adds the use of String::Random to catalogue/search.pl but bug 11369 removes it without removing the import line. Test plan: git grep String::Random catalogue/search.pl should not return anything -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14696] useless use of String::Random in catalogue/search.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14696 Jonathan Druart jonathan.dru...@bugs.koha-community.org changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14321] Merge UploadedFile and UploadedFiles into Koha::Upload
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321 --- Comment #22 from Marcel de Rooy m.de.r...@rijksmuseum.nl --- Rebased last patch for change on dependency patches. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14694] Make decreaseloanHighHolds more flexible
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14694 Kyle M Hall kyle.m.h...@gmail.com changed: What|Removed |Added Change sponsored?|--- |Sponsored Assignee|koha-b...@lists.koha-commun |kyle.m.h...@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14628] anonymization of patron data ignores refund lost
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14628 Jonathan Druart jonathan.dru...@bugs.koha-community.org changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #1 from Jonathan Druart jonathan.dru...@bugs.koha-community.org --- Sorry, I don't understand what you mean. Could you provide a step-by-step plan to reproduce the issue? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14697] Extend and enhance Claims returned lost status
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14697 Kyle M Hall kyle.m.h...@gmail.com changed: What|Removed |Added Change sponsored?|--- |Seeking cosponsors Assignee|koha-b...@lists.koha-commun |kyle.m.h...@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14697] New: Extend and enhance Claims returned lost status
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14697
Bug ID: 14697
Summary: Extend and enhance Claims returned lost status
Change sponsored?: ---
Product: Koha
Version: unspecified
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Circulation
Assignee: koha-bugs@lists.koha-community.org
Reporter: kyle.m.h...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com
A group of librarians have been brainstorming about claimed returns in Koha.
They think this would be a good list of features for a claims returned system
in Koha:
* Add a system preference to flag which lost status is Claims returned.
Not setting this pref would disable the feature.
* Add ability to mark item as Claims returned
* Add the ability to mark an item as claims returned from the checkouts
table on the checkouts and patron details pages
* This functionality would operate in the same way checkins and
renewals do.
* It may be better to slim down to one column of checkboxes for all
three
functions ( that is, one at a time with one set of checkboxes )
* The ability mark an item as Claims returned from the item details would
be
disabled when the feature is enabled. All claims returned marking would
happen
through the checkouts table.
* Charge or don't charge for claims returned
* Some libraries charge the lost fee on claimed returns, some don't.
* Add system preference to ask ‘charge’, ‘don’t charge’, or ‘ask for
confirmation’
when marking an item claimed returned
* Some libraries want to alerted of repeat offenders.
* Add a sys pref to offer an option to block a patron, or alert staff
somehow,
after a set number of claimed returns.
* This will be a running total over the lifetime of the patron,
not the current number of outstanding claimed returns.
* There will need to be a table that stores basic information about the
item on
patron’s record so you can track how many times they’ve said ‘i returned
that’
* This allows us to track claimed returns even for returned and deleted
items
* This data will display on a new tab on the patron record (
moremember.pl )
for claims returned items
* Will store the status so we know if the claim is open or resolved
* ex. [title 1] / checked out {date} / claimed {date} / not returned /
notes
* Remove item from patron's current checkouts on marking claims returned (
e.g. current lost behavior )
* Will stop fines from continuing to accrue for said item
* show as missing in the opac and claimed returned in the staff client
( e.g. current lost behavior, no change needed )
* Be able to mark item as ‘found’ from claimed tab if item happens to be found
( using standard 'found' behavior Koha already has )
* Offer options of “returned by patron” or “found in library” in a pull
down to
the side of every item that has been claimed.
* next to each claimed item have a ‘notes’ field.
Should be in line editable for ease of use
* Claimed items should be easily distinguishable on staff side
(compared to other types of lost items) on patron check out under ‘Attention’
so alert ‘Patron has claimed returns’ that links to the ‘Claimed’ tab below
( in a similar fashion to the current restrictions system )
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8753] Add forgot password link to OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 Jonathan Druart jonathan.dru...@bugs.koha-community.org changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #115 from Jonathan Druart jonathan.dru...@bugs.koha-community.org --- FAIL opac/opac-password-recovery.pl FAIL spelling doesnt == doesn't FAIL valid defined(@array) is deprecated Smartmatch is experimental shift on reference is experimental (Maybe you should just omit the defined()?) FAIL C4/Passwordrecovery.pm FAIL pod *** ERROR: Spurious text after =cut in file C4/Passwordrecovery.pm *** ERROR: Spurious =cut command in file C4/Passwordrecovery.pm FAIL koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-password-recovery.tt FAIL spelling occured == occurred -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14696] New: useless use of String::Random in catalogue/search.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14696 Bug ID: 14696 Summary: useless use of String::Random in catalogue/search.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.dru...@bugs.koha-community.org Reporter: jonathan.dru...@bugs.koha-community.org QA Contact: testo...@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11559] Professional cataloger's interface
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 --- Comment #122 from Jesse Weaver jwea...@bywatersolutions.com --- (In reply to Christopher Davis from comment #120) Anyone care to reply to comment 115? I think that step 15 of the test plan is referring to Koha authorized values (HomeAdministrationAuthorized values) and not authorized access points from the authority file. Your thoughts? Thanks Apologies, I responded via email out of habit, and forgot that doesn't work with Bugzilla. Yes, this is referring to the latter (CCODES, locations, etc.). However, the exact same infrastructure is used for item types (942$c), so you can test it that way. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14693] t/db_dependent/Contract.t fails do to fixed date
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14693 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Assignee|ch...@bigballofwax.co.nz|tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14693] t/db_dependent/Contract.t fails do to fixed date
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14693 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14693] t/db_dependent/Contract.t fails do to fixed date
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14693 --- Comment #1 from Tomás Cohen Arazi tomasco...@gmail.com --- Created attachment 41682 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41682action=edit Bug 14693: Contract.t should generate dates based on current date The current test for still-active contracts fails because it was written with fixed dates, which already passed :-D This patch calculates the current date, and uses it to generate a future one, so the tests serve their purpose no matter what the current date is. To test: - Run: $ prove t/db_dependent/Contract.t = FAIL: activeonly compares contractenddate with now(), and fails because a fixed 2015-07-31 is writteng on the test data - Apply the patch - Run: $ prove t/db_dependent/Contract.t = SUCCESS: the sample data has been calculated using the current date and the tests pass. - Sign off :-D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3333] item status for not for loan by item type / item is different
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id= --- Comment #16 from Jonathan Druart jonathan.dru...@bugs.koha-community.org --- Using an existing record, I get 1 item available for loan and 1 available for reference. The one available for reference is the one with an item type not for loan. The display is the same before and after the patch. I don't manage to know why it has this status. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14337] AllowRenewalIfOtherItemsAvailable counts holdable not for loan items when checking renewability
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14337 Kyle M Hall kyle.m.h...@gmail.com changed: What|Removed |Added Version|3.18|master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14337] AllowRenewalIfOtherItemsAvailable counts holdable not for loan items when checking renewability
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14337 --- Comment #8 from Kyle M Hall kyle.m.h...@gmail.com --- (In reply to Jonathan Druart from comment #7) Kyle, the test you have provided passes against master. I would expect something to fail, and then to be fixed by your patch. Why is the version set to 3.18? My bad. I assumed the test would fail on master but failed to test my assumption! Not sure why the version was set that way. Updated to master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14180] Make Always show checkouts immediately a global setting
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14180 Agnes Rivers-Moore a...@hanover.ca changed: What|Removed |Added CC||a...@hanover.ca --- Comment #4 from Agnes Rivers-Moore a...@hanover.ca --- I would like a global preference to turn always show checkouts on or off. It is not something we would want to select daily or per session or per staff person. There is also an extra row below specify due date in checkout that reports the barcode that was last checked out. If always show is turned on - this is no longer needed, as the information is displayed twice. I would wish to have that associated with the Always show function so that it only appears if always show is turned off. It uses up screen space we would rather use to see the last several items we checked out - and there is already room for only one or two rows to show unless the screen resolution is dialed up. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14588] Simplify merge_ajax.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14588 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Attachment #41676|0 |1 is obsolete|| --- Comment #11 from M. Tompsett mtomp...@hotmail.com --- Created attachment 41683 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41683action=edit Bug 14588: Simplify merge_ajax.pl This script does not need a few modules: IO::File; CGI::Session; C4::UploadedFile. Warnings can be enabled (with Modern::Perl). Indirect object syntax replaced for CGI and CGI::Cookie. Moved the $reply line upwards (not needed twice anymore). Test plan: [1] Log in as staff user. Run the URL cataloguing/merge_ajax.pl. You should see the JSON reponse in the browser. [2] Logout. Run the URL again. Blank screen. [3] Go to addbooks.pl (Cataloging Search). Search something, select two biblios and click Merge selected, etc. Signed-off-by: Joonas Kylmala j.kylm...@gmail.com Signed-off-by: Mark Tompsett mtomp...@hotmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14337] AllowRenewalIfOtherItemsAvailable counts holdable not for loan items when checking renewability
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14337 --- Comment #9 from Kyle M Hall kyle.m.h...@gmail.com --- I just wanted to publicly observe that these unit tests are such a mess that I'm spending hours writing unit tests for a patch that took minutes to complete. We really need to think about how to clean these tests up. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13624] Remove columns branchcode, categorytype from table overduerules_transport_types
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624 Martin Persson xarra...@gmail.com changed: What|Removed |Added Attachment #40330|0 |1 is obsolete|| --- Comment #29 from Martin Persson xarra...@gmail.com --- Created attachment 41685 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41685action=edit Bug 13624 - Tidying the atomicupdate file and kohastructure.sql Signed-off-by: Martin Persson xarra...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11299] Add a button that automatically links authority records to a biblio record during edition. (AJAX)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299
--- Comment #21 from M. Tompsett mtomp...@hotmail.com ---
Comment on attachment 39477
-- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39477
Bug 11299 - Add a button to the biblio edition page to automatically add
authority links in the current biblio record via AJAX. Also adds a button to
easily create missing authority records.
Review of attachment 39477:
--
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.htmlbug=11299attachment=39477)
-
::: cataloguing/automatic_linker.pl
@@ +29,5 @@
+my $input= new CGI;
+print $input-header('application/json');
+
+# Check the user's permissions
+my %cookies = fetch CGI::Cookie;
Bug 14589 is attempting to standardize to CGI::Cookie-fetch;
Please change your syntax.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Heather Braum hbr...@nekls.org changed: What|Removed |Added CC||hbr...@nekls.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14180] Make Always show checkouts immediately a global setting
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14180 Nick Clemens n...@quecheelibrary.org changed: What|Removed |Added CC||n...@quecheelibrary.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11299] Add a button that automatically links authority records to a biblio record during edition. (AJAX)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=14589 CC||mtomp...@hotmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14589] Replace fetch CGI::Cookie calls
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14589 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=11299 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13624] Remove columns branchcode, categorytype from table overduerules_transport_types
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624 Martin Persson xarra...@gmail.com changed: What|Removed |Added Attachment #40329|0 |1 is obsolete|| --- Comment #28 from Martin Persson xarra...@gmail.com --- Created attachment 41684 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41684action=edit Bug 13624 - Remove columns branchcode, categorytype from table overduerules_transport_types This patch is a _requirement_ to Bug #12771, and will be necessary once we start managing more than 3 levels of overdue notice TEST PLAN 1) Create or improve on overduerules data .1) Intranet - tools - overdue notices .2) Make sure to have data in first, second and third tabs .3) Make sure to have checked mixes of Email/Phone/Print/SMS (depending on availability) .4) Make sure to have different letters and delay on first/second/third tab for at least one category .5) Remember it all. 2) Apply patch 3) run installer/data/mysql/atomicupdate/update_13624_overduerules_transport_type.pl 4) run t/db_dependant/Overdues.t 5) Validate Overdue Notice page .1) validate data entered previously is still there .2) Add some more, save changes, validate In installer/data/mysql/atomicupdate/update_13624_overduerules_transport_type.pl - A new column and primary key, 'overduerules_id', is added to the table 'overduerules' - A new column referencing a foreign key, 'overduerules_id', is added to the table 'overduerules_transport_types' - The columns 'branchcode' and 'categorytype' are removed from the table 'overduerules_transport_types' - Data is migrated from the old tables to the new ones In installer/data/mysql/kohastructure.sql : - Table 'overduerules' - Added a primary key named 'overduerules_id' - Table 'overduerules_transport_types' - Added a foreign key named 'overduerules_id' - Dropped columns 'branchcode', 'categorycode' since we now have them referenced through 'overduerules_id' In tools/overduerules.pl - INSERT and DELETE queries on 'overduerules_transport_types' were changed to reflect the new schema In C4/Overdues.pm : - The SQL query of the function 'GetOverdueMessageTransportTypes' is changed to take into account the new design of 'overduerules_transport In t/db_dependent/Overdues.t : - The INSERT calls before the tests were changed to take into account the new design of 'overduerules' and 'overduerules_transport_types' Sponsored by : Halland County Library Signed-off-by: Jesse Maseto je...@bywatersolutions.com Signed-off-by: Martin Persson xarra...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13624] Remove columns branchcode, categorytype from table overduerules_transport_types
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624 Martin Persson xarra...@gmail.com changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||xarra...@gmail.com --- Comment #30 from Martin Persson xarra...@gmail.com --- Tested these patches against origin/master commit 75d123d760d86f0e0d9f58d65874b40f6816008d. Both patches merged perfectly and both manual and automated tests passed. Tested with 3 categories and all tabs filled with complex, unique combinations of rules. Verified by screenshot before and after. Code looks good to me but I am unfamiliar with some SQL details. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14589] Replace fetch CGI::Cookie calls
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14589 --- Comment #5 from M. Tompsett mtomp...@hotmail.com --- Comment on attachment 41675 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41675 Bug 14589: Replace fetch CGI::Cookie calls Review of attachment 41675: -- (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.htmlbug=14589attachment=41675) - There is scope creep as noted below. It would make more sense to have a Replace 'new CGI' calls bug separately, as this occurs in more than just these places. ::: tools/background-job-progress.pl @@ +30,4 @@ use CGI::Cookie; # need to check cookies before # having CGI parse the POST request +my $input = CGI-new; Scope creep. @@ +51,4 @@ $job_status = $job-status(); } +my $reply = CGI-new; Scope creep. ::: tools/upload-file-progress.pl @@ +47,4 @@ } } +my $reply = CGI-new; Scope creep. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8753] Add forgot password link to OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 Liz Rea l...@catalyst.net.nz changed: What|Removed |Added Attachment #41455|0 |1 is obsolete|| --- Comment #117 from Liz Rea l...@catalyst.net.nz --- Created attachment 41687 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41687action=edit Bug 8753 - [followup] fix error when no information is provided To test: All normal checks plus make sure that a nice error is displayed when no data is provided. fixing the deprecated thing -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
