[Koha-bugs] [Bug 9809] Get rid of reserveconstraints
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 --- Comment #32 from Kyle M Hall kyle.m.h...@gmail.com --- (In reply to Marcel de Rooy from comment #22) Looks good to me! Thanks, Kyle. I added two small follow-ups and a see-also to a new report for GetReserveFee. Thanks for the followups Marcel! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9809] Get rid of reserveconstraints
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 --- Comment #31 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 41774 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41774action=edit [SIGNED-OFF] Bug 9809: [QA Follow-up] Remove an erroneous call to GetReserveFee The call to GetReserveFee in opac-reserve.pl is useless in its current form. The first parameter undef takes care of receiving 0. But note that the user is warned correctly for the charge via param variable RESERVE_CHARGE on the opac form. When the hold is placed, AddReserve calls GetReserveFee. So if the routine would work correctly, we would not need this extra call in opac-reserve in the whole place. Unfortunately, the routine is not working correctly. I will submit a fix for GetReserveFee under a new report (14702). Test plan: [1] Add a hold fee to some category. [2] Check the warn for placing a hold on such a book in OPAC. [3] Observe that the actual fee is not charged. This is a current bug and it will be addressed on report 14702. Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14526] MoveReserve should look at future holds too
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14526 Jonathan Druart jonathan.dru...@bugs.koha-community.org changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=14337 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14155] Placing holds via ILSDI bypass some checks
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14155 Jonathan Druart jonathan.dru...@bugs.koha-community.org changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=14526 CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #15 from Jonathan Druart jonathan.dru...@bugs.koha-community.org --- Be care, AddReserve prototype changed by bug 14526 (contrainst param removed). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14526] MoveReserve should look at future holds too
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14526 Jonathan Druart jonathan.dru...@bugs.koha-community.org changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=14155 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14337] AllowRenewalIfOtherItemsAvailable counts holdable not for loan items when checking renewability
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14337 Jonathan Druart jonathan.dru...@bugs.koha-community.org changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=14526 --- Comment #15 from Jonathan Druart jonathan.dru...@bugs.koha-community.org --- Be care, AddReserve prototype changed by bug 14526 (contrainst param removed). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9809] Get rid of reserveconstraints
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 --- Comment #33 from Jonathan Druart jonathan.dru...@bugs.koha-community.org --- Bug 14464 is passed QA and will be in conflict with this patch. Please provide a followup build on top of it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14526] MoveReserve should look at future holds too
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14526 Jonathan Druart jonathan.dru...@bugs.koha-community.org changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=13930 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13930] Add supporting service svc/ncip for xnciptoolkit driver
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13930 Jonathan Druart jonathan.dru...@bugs.koha-community.org changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=14526 CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #18 from Jonathan Druart jonathan.dru...@bugs.koha-community.org --- Be care, AddReserve prototype changed by bug 14526 (contrainst param removed). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14526] MoveReserve should look at future holds too
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14526 Jonathan Druart jonathan.dru...@bugs.koha-community.org changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=13903 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13903] Add API routes to list, create, update, delete reserves
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13903 Jonathan Druart jonathan.dru...@bugs.koha-community.org changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=14526 CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #10 from Jonathan Druart jonathan.dru...@bugs.koha-community.org --- Be care, AddReserve prototype changed by bug 14526 (contrainst param removed). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12632] Hold limits ignored for record level holds with item level itemtypes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12632 Jonathan Druart jonathan.dru...@bugs.koha-community.org changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=14526 --- Comment #21 from Jonathan Druart jonathan.dru...@bugs.koha-community.org --- Be care, AddReserve prototype changed by bug 14526 (contrainst param removed). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14526] MoveReserve should look at future holds too
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14526 Jonathan Druart jonathan.dru...@bugs.koha-community.org changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=12632 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14526] MoveReserve should look at future holds too
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14526 Jonathan Druart jonathan.dru...@bugs.koha-community.org changed: What|Removed |Added See Also|http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13930| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13903] Add API routes to list, create, update, delete reserves
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13903 Jonathan Druart jonathan.dru...@bugs.koha-community.org changed: What|Removed |Added See Also|http://bugs.koha-community. |http://bugs.koha-community. |org/bugzilla3/show_bug.cgi? |org/bugzilla3/show_bug.cgi? |id=14526|id=9809 --- Comment #11 from Jonathan Druart jonathan.dru...@bugs.koha-community.org --- I meant bug 9809. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13930] Add supporting service svc/ncip for xnciptoolkit driver
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13930 Jonathan Druart jonathan.dru...@bugs.koha-community.org changed: What|Removed |Added See Also|http://bugs.koha-community. |http://bugs.koha-community. |org/bugzilla3/show_bug.cgi? |org/bugzilla3/show_bug.cgi? |id=14526|id=9809 --- Comment #19 from Jonathan Druart jonathan.dru...@bugs.koha-community.org --- I meant bug 9809. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14526] MoveReserve should look at future holds too
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14526 Jonathan Druart jonathan.dru...@bugs.koha-community.org changed: What|Removed |Added See Also|http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14155| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14526] MoveReserve should look at future holds too
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14526 Jonathan Druart jonathan.dru...@bugs.koha-community.org changed: What|Removed |Added See Also|http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13903| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14526] MoveReserve should look at future holds too
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14526 Jonathan Druart jonathan.dru...@bugs.koha-community.org changed: What|Removed |Added See Also|http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12632| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12632] Hold limits ignored for record level holds with item level itemtypes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12632 Jonathan Druart jonathan.dru...@bugs.koha-community.org changed: What|Removed |Added See Also|http://bugs.koha-community. |http://bugs.koha-community. |org/bugzilla3/show_bug.cgi? |org/bugzilla3/show_bug.cgi? |id=14526|id=9809 --- Comment #22 from Jonathan Druart jonathan.dru...@bugs.koha-community.org --- I meant bug 9809. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9809] Get rid of reserveconstraints
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 Jonathan Druart jonathan.dru...@bugs.koha-community.org changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=13903 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14155] Placing holds via ILSDI bypass some checks
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14155 Jonathan Druart jonathan.dru...@bugs.koha-community.org changed: What|Removed |Added See Also|http://bugs.koha-community. |http://bugs.koha-community. |org/bugzilla3/show_bug.cgi? |org/bugzilla3/show_bug.cgi? |id=14526|id=9809 --- Comment #16 from Jonathan Druart jonathan.dru...@bugs.koha-community.org --- I meant bug 9809. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9809] Get rid of reserveconstraints
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 Jonathan Druart jonathan.dru...@bugs.koha-community.org changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=14337 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9809] Get rid of reserveconstraints
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 Jonathan Druart jonathan.dru...@bugs.koha-community.org changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=13930 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14097] Add unit tests to C4::UsageStats
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14097 Jonathan Druart jonathan.dru...@bugs.koha-community.org changed: What|Removed |Added See Also|http://bugs.koha-community. |http://bugs.koha-community. |org/bugzilla3/show_bug.cgi? |org/bugzilla3/show_bug.cgi? |id=14526|id=9809 --- Comment #20 from Jonathan Druart jonathan.dru...@bugs.koha-community.org --- I meant bug 9809. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14526] MoveReserve should look at future holds too
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14526 Jonathan Druart jonathan.dru...@bugs.koha-community.org changed: What|Removed |Added See Also|http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14097| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14337] AllowRenewalIfOtherItemsAvailable counts holdable not for loan items when checking renewability
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14337 Jonathan Druart jonathan.dru...@bugs.koha-community.org changed: What|Removed |Added See Also|http://bugs.koha-community. |http://bugs.koha-community. |org/bugzilla3/show_bug.cgi? |org/bugzilla3/show_bug.cgi? |id=14526|id=9809 --- Comment #16 from Jonathan Druart jonathan.dru...@bugs.koha-community.org --- I meant bug 9809. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14526] MoveReserve should look at future holds too
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14526 Jonathan Druart jonathan.dru...@bugs.koha-community.org changed: What|Removed |Added See Also|http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14337| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9809] Get rid of reserveconstraints
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 Jonathan Druart jonathan.dru...@bugs.koha-community.org changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=14155 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9809] Get rid of reserveconstraints
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 Jonathan Druart jonathan.dru...@bugs.koha-community.org changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=5144 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7376] Transfer limits should be checked at check-in
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 Jonathan Druart jonathan.dru...@bugs.koha-community.org changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=9809 CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #36 from Jonathan Druart jonathan.dru...@bugs.koha-community.org --- Be care, AddReserve prototype changed by bug 9809 (contrainst param removed). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9809] Get rid of reserveconstraints
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 Jonathan Druart jonathan.dru...@bugs.koha-community.org changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=12632 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9809] Get rid of reserveconstraints
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 Jonathan Druart jonathan.dru...@bugs.koha-community.org changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=14097 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5144] Duplicate holds allowed if patron clicks back button after placing hold
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144 Jonathan Druart jonathan.dru...@bugs.koha-community.org changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=9809 CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #26 from Jonathan Druart jonathan.dru...@bugs.koha-community.org --- Be care, AddReserve prototype changed by bug 9809 (contrainst param removed). -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14704] members/statistics.pl crashes because the SQL 'return'-keyword might be reserved at 'return FROM ('
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14704
--- Comment #1 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi ---
Created attachment 41775
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41775action=edit
Bug 14704 - members/statistics.pl crashes because the SQL 'return'-keyword
might be reserved at 'return FROM ('
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9809] Get rid of reserveconstraints
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 --- Comment #34 from Marcel de Rooy m.de.r...@rijksmuseum.nl --- (In reply to Jonathan Druart from comment #33) Bug 14464 is passed QA and will be in conflict with this patch. Please provide a followup build on top of it. Well. maybe we should wait to see it get pushed first. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #47 from Jonathan Druart jonathan.dru...@bugs.koha-community.org --- Created attachment 41776 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41776action=edit Bug 13618: Specific for other prefs opacmainuserblock opacnav opacnavright opaccredits opacheader opaccustomsearch opacmysummaryhtml opacmysummarynote opacnavbottom opacnoresultsfound opacresultssidebar opacsearchfortitlein restrictedpagecontent PatronSelfRegistrationAdditionalInstructions intranetmainuserblock intranetnav intranetslipprinterjs OpacSuppressionMessage SCOUserCSS SCOUserJS SelfCheckHelpMessage NoLoginInstructions -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14704] members/statistics.pl crashes because the SQL 'return'-keyword might be reserved at 'return FROM ('
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14704 Jonathan Druart jonathan.dru...@bugs.koha-community.org changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #2 from Jonathan Druart jonathan.dru...@bugs.koha-community.org --- I got the following if I execute directly the second query in my MariaDB CLI: ERROR 1054 (42S22): Unknown column 'tmp.return' in 'field list' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14510] Allow column visibility in additem.pl to be customized
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14510 Jonathan Druart jonathan.dru...@bugs.koha-community.org changed: What|Removed |Added Status|Signed Off |ASSIGNED --- Comment #7 from Jonathan Druart jonathan.dru...@bugs.koha-community.org --- Joubu: pianohacker: for instance stocknumber is not mapped by default, but can be mapped pianohacker: hrm, decent point. pianohacker: Joubu: based on my patch, and your work with the datatables stuff, even if I throw in all those columns it will only show the ones that are actually visible in the show/hide columns menu, and in the correct order, right? Joubu: I think so, yes matts est désormais connu sous le nom de matts_away Joubu: that's the point, I think it's better to show all columns pianohacker: agreed nengard est désormais connu sous le nom de nengard_webinar Joubu: and display them either the order on admin/koha2marclinks.pl either the DB order edveal-afk est désormais connu sous le nom de edveal Joubu: DB order ie. kohastructure.sql pianohacker: yeah, to be consistent with something pianohacker: Joubu: all right, have that on my todo list. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14705] Allow .pl too in atomicupdate
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14705 Marcel de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14705] Allow .pl too in atomicupdate
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14705 --- Comment #1 from Marcel de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 41777 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41777action=edit Bug 14705: Allow .pl too in atomicupdate Bug 13893 added perl files with the extension .perl. In practice you always tend to add a .pl file. I suggest to add it. Test plan: [1] Add a .pl file in atomicupdate. [2] Try the update step in webinstaller. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14705] Allow .pl too in atomicupdate
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14705 Marcel de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Assignee|gmcha...@gmail.com |m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14705] Allow .pl too in atomicupdate
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14705 Marcel de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Attachment #41777|0 |1 is obsolete|| --- Comment #2 from Marcel de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 41778 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41778action=edit Bug 14705: Allow .pl too in atomicupdate Bug 13893 added perl files with the extension .perl. In practice you always tend to add a .pl file. I suggest to add it. Test plan: [1] Add a .pl file in atomicupdate. [2] Try the update step in webinstaller. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14702] Fix GetReserveFee
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14702 --- Comment #1 from Marcel de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 41779 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41779action=edit Bug 14702: Fix GetReserveFee The code in this sub of Reserves is unneeded and erroneous. The old code checked via biblioitems if there still was an item not issued and if so, it checked reserves: if there was no no hold yet for the biblio, the reserve fee went to zero. (Strange !) So only the second hold would trigger a charge. (But Koha does NOT allow that second hold at this time!) So it actually does nothing! This can/should be drastically simplified: We only call GetReserveFee from AddReserve. So there is an item free and it is possible to place a hold. Since it is currently not possible to place a second hold, and even if it was, we just charge our hold fee from patron categories! NOTE: It somehow seems a bit odd to have hold fee in the patron categories. Maybe it should be added to itemtypes (on another report)? This is a fix that changes behavior! A follow-up will print a warning for libraries upgrading. Test plan: [1] Add a hold for a patron without hold fee. Check the patron account if there is no charge for the new hold. [2] Add a hold for a ptron with hold fee. Check account again. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14702] Fix GetReserveFee
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14702 --- Comment #3 from Marcel de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 41781 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41781action=edit Bug 14702: Database revision for GetReserveFee change This patch adds a warning when upgrading. Test plan: [1] Have a patron category with a hold fee. [2] Run the webinstaller upgrade. Check for the warning. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14702] Fix GetReserveFee
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14702 Marcel de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Patch complexity|--- |Small patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14702] Fix GetReserveFee
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14702 --- Comment #2 from Marcel de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 41780 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41780action=edit Bug 14702: Unit test for GetReservesFee Test plan: Run the test! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9809] Get rid of reserveconstraints
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 Jonathan Druart jonathan.dru...@bugs.koha-community.org changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=14526 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14526] MoveReserve should look at future holds too
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14526 Jonathan Druart jonathan.dru...@bugs.koha-community.org changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=9809 --- Comment #4 from Jonathan Druart jonathan.dru...@bugs.koha-community.org --- Be care, AddReserve prototype changed by bug 14526 (contrainst param removed). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14526] MoveReserve should look at future holds too
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14526 Jonathan Druart jonathan.dru...@bugs.koha-community.org changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=14097 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14097] Add unit tests to C4::UsageStats
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14097 Jonathan Druart jonathan.dru...@bugs.koha-community.org changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=14526 --- Comment #19 from Jonathan Druart jonathan.dru...@bugs.koha-community.org --- Be care, AddReserve prototype changed by bug 14526 (contrainst param removed). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14526] MoveReserve should look at future holds too
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14526 --- Comment #5 from Jonathan Druart jonathan.dru...@bugs.koha-community.org --- I meant bug 9809. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9809] Get rid of reserveconstraints
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 Jonathan Druart jonathan.dru...@bugs.koha-community.org changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=7376 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14704] New: members/statistics.pl crashes because the SQL 'return'-keyword might be reserved at 'return FROM ('
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14704
Bug ID: 14704
Summary: members/statistics.pl crashes because the SQL
'return'-keyword might be reserved at 'return FROM ('
Change sponsored?: ---
Product: Koha
Version: unspecified
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Patrons
Assignee: koha-bugs@lists.koha-community.org
Reporter: olli-antti.kivila...@jns.fi
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com
At Ubuntu 14.04 using MariaDB, the following SQL doesn't work:
SELECT COUNT(*) as count_precedent_state,issues,onloan,return
FROM (
SELECT it.* FROM issues i, items it
WHERE i.borrowernumber = 1234 AND
i.itemnumber = it.itemnumber AND
DATE(i.issuedate) CAST(now() AS date)
UNION
SELECT it.* FROM old_issues oi, items it
WHERE oi.borrowernumber = 1234 AND
oi.itemnumber = it.itemnumber AND
DATE(oi.issuedate) CAST(now() AS date) AND
DATE(oi.returndate) = CAST(now() AS date)
) tmp
GROUP BY issues,onloan,return;
We get Syntax error near 'return FROM ('
This patch changes the SQL to prefix the selected columns with a table name
prefix, so we get:
SELECT COUNT(*) as count_precedent_state,tmp.issues,tmp.onloan,tmp.return
FROM (
SELECT it.* FROM issues i, items it
WHERE i.borrowernumber = 1234 AND
i.itemnumber = it.itemnumber AND
DATE(i.issuedate) CAST(now() AS date)
UNION
SELECT it.* FROM old_issues oi, items it
WHERE oi.borrowernumber = 1234 AND
oi.itemnumber = it.itemnumber AND
DATE(oi.issuedate) CAST(now() AS date) AND
DATE(oi.returndate) = CAST(now() AS date)
) tmp
GROUP BY tmp.issues,tmp.onloan,tmp.return;
Which is more formal and less implicit.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #48 from Jonathan Druart jonathan.dru...@bugs.koha-community.org --- Thanks for the pref list! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13231] ISBD/AACR2 punctuation causes double facets
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13231 Joonas Kylmälä j.kylm...@gmail.com changed: What|Removed |Added CC||j.kylm...@gmail.com --- Comment #9 from Joonas Kylmälä j.kylm...@gmail.com --- (In reply to Katrin Fischer from comment #8) Hm, 2 things here: I think the described case can only happen when not using authorities as there seems no way to include ISBD punctuation at the end when you do. No way to include ISBD punctuation when adding/changing authorities? What do you mean? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14705] New: Allow .pl too in atomicupdate
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14705 Bug ID: 14705 Summary: Allow .pl too in atomicupdate Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcha...@gmail.com Reporter: m.de.r...@rijksmuseum.nl QA Contact: testo...@bugs.koha-community.org Bug 13893 added perl files with the extension .perl. In practice you always tend to add a .pl file. I suggest to add it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14702] Fix GetReserveFee
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14702 --- Comment #4 from Marcel de Rooy m.de.r...@rijksmuseum.nl --- hmm maybe it still needs some attention for the biblio level hold -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14706] New: Allow enabling/disabled Plack for OPAC and Intranet individually
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14706 Bug ID: 14706 Summary: Allow enabling/disabled Plack for OPAC and Intranet individually Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: gmcha...@gmail.com Reporter: tomasco...@gmail.com QA Contact: testo...@bugs.koha-community.org CC: ro...@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6874] Attach files to bibliographic records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 --- Comment #375 from Tomás Cohen Arazi tomasco...@gmail.com --- Created attachment 41783 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41783action=edit Bug 6874: (QA followup) fix templates Signed-off-by: Tomas Cohen Arazi tomasco...@unc.edu.ar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12388] IssueSlip output should be sorted by date_due, not timestamp
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12388 Joonas Kylmälä j.kylm...@gmail.com changed: What|Removed |Added CC||j.kylm...@gmail.com --- Comment #1 from Joonas Kylmälä j.kylm...@gmail.com --- Created attachment 41784 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41784action=edit Patch Here is a patch from Pasi which I just found for this bug. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14652] Change gender option N/A to None specified
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14652 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||tomasco...@gmail.com --- Comment #6 from Tomás Cohen Arazi tomasco...@gmail.com --- Patches pushed to master. Thanks Liz and Jonathan! I think we should go further and rename sex = gender all over the place at some point. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14337] AllowRenewalIfOtherItemsAvailable counts holdable not for loan items when checking renewability
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14337 --- Comment #18 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 41788 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41788action=edit Bug 14337 - AllowRenewalIfOtherItemsAvailable counts holdable not for loan items when checking renewability AllowRenewalIfOtherItemsAvailable checks C4::Reserves::IsAvailableForItemLevelRequest to see if the item is holdable, which catches not for loan values less than 0 ( i.e. holdable, but not circ-able ). However, since this feature is about actually checking out items to patrons, we should not count *any* not for loan items when deciding if the available items will satisfy all current holds. Test Plan: 1) Enable AllowRenewalIfOtherItemsAvailable 2) Create a record with two items 3) Check out one item to a patron 4) Ensure the item is renewable 5) Place a hold on the record 6) The item should now be non-renewable 7) Add a second item to the record, but with a not for loan value 0 8) Note the checkout is still renewable 9) Apply this patch 10) Note the checkout is now non-renewable Works ok. Signed-off-by: Amit Gupta amit.gu...@informaticsglobal.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14337] AllowRenewalIfOtherItemsAvailable counts holdable not for loan items when checking renewability
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14337 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #41708|0 |1 is obsolete|| Attachment #41709|0 |1 is obsolete|| --- Comment #17 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 41787 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41787action=edit Bug 14337 - Add Unit Tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14693] t/db_dependent/Contract.t fails do to fixed date
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14693 Jonathan Druart jonathan.dru...@bugs.koha-community.org changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14693] t/db_dependent/Contract.t fails do to fixed date
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14693 Jonathan Druart jonathan.dru...@bugs.koha-community.org changed: What|Removed |Added Attachment #41785|0 |1 is obsolete|| --- Comment #6 from Jonathan Druart jonathan.dru...@bugs.koha-community.org --- Created attachment 41786 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41786action=edit Bug 14693: Contract.t should generate dates based on current date The current test for still-active contracts fails because it was written with fixed dates, which already passed :-D This patch calculates the current date, and uses it to generate a future one, so the tests serve their purpose no matter what the current date is. To test: - Run: $ prove t/db_dependent/Contract.t = FAIL: activeonly compares contractenddate with now(), and fails because a fixed 2015-07-31 is writteng on the test data - Apply the patch - Run: $ prove t/db_dependent/Contract.t = SUCCESS: the sample data has been calculated using the current date and the tests pass. - Sign off :-D Edit: added missing use DateTime::Duration, Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Jonathan Druart jonathan.dru...@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14707] Change UsageStatsCountry and UsageStatsLibraryType from free text to a dropdown list
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14707 --- Comment #1 from Julian FIOL julian.f...@biblibre.com --- Created attachment 41789 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41789action=edit Bug 14707 : Replace UsageStatsCountry and UsageStatsLibraryType syspref from free text to a dropdown list. This will avoid syntax problems with Hea when a user will fill this 2 sysprefs The default choice for UsageStatsLibraryType and UsageStatsCountry is 'empty' Test Plan - 1. Create a new Koha install 2. Go to the 'Administration' page 3. Go to 'Global system preferences' 4. Go to 'Administration' 5. At the end of this page you should see a dropdown menu for - UsageStatsCountry with all countries - UsageStatsLibraryType with all type of library They both should be empty by default. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14707] Change UsageStatsCountry and UsageStatsLibraryType from free text to a dropdown list
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14707 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added CC||tomasco...@gmail.com --- Comment #2 from Tomás Cohen Arazi tomasco...@gmail.com --- Is it a good idea to have a country dropdown? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14707] Change UsageStatsCountry and UsageStatsLibraryType from free text to a dropdown list
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14707 Julian FIOL julian.f...@biblibre.com changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14706] Allow enabling/disabled Plack for OPAC and Intranet individually
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14706 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Depends on||13791 Change sponsored?|--- |Seeking cosponsors Assignee|gmcha...@gmail.com |tomasco...@gmail.com Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13791 [Bug 13791] Plack - Out of the box support on packages -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #65 from Fridolin SOMERS fridolin.som...@biblibre.com --- (In reply to Jonathan Druart from comment #64) (In reply to Fridolin SOMERS from comment #62) There is a little error in opac/opac-addbybiblionumber.pl : Line 120 : $shelf- This brakes the addition of records in a list. Oops, fixed! It works fine, i continue testing -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14464] Add ability to cancel waiting holds from checkin screen
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14464 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added CC||tomasco...@gmail.com Status|Passed QA |Pushed to Master --- Comment #9 from Tomás Cohen Arazi tomasco...@gmail.com --- Patches pushed to master. Thanks Jesse! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12224] Allow easy printing of patron check-in slip
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12224 Joonas Kylmälä j.kylm...@gmail.com changed: What|Removed |Added Assignee|pasi.kalli...@pttk.fi |j.kylm...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14337] AllowRenewalIfOtherItemsAvailable counts holdable not for loan items when checking renewability
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14337 --- Comment #19 from Kyle M Hall kyle.m.h...@gmail.com --- (In reply to Jonathan Druart from comment #14) Comment on attachment 41708 [details] [review] Bug 14337 - Add Unit Tests Review of attachment 41708 [details] [review]: - ::: t/db_dependent/Circulation.t @@ +649,5 @@ +my $borrower2 = GetMember( borrowernumber = $borrowernumber2 ); + +my $issue = AddIssue( $borrower1, $barcode1 ); + +my ( $renewokay, $error ) = CanBookBeRenewed( $borrowernumber2, $itemnumber1 ); Shouldn't be borrowernumber1? Chelsea didn't check out itemnumber1. @@ +667,5 @@ + +( $renewokay, $error ) = CanBookBeRenewed( $borrowernumber2, $itemnumber1 ); +is( $renewokay, 1, 'Bug 14337 - Verify the borrower can renew with a hold on the record if AllowRenewalIfOtherItemsAvailable is enabled' ); + +diag(Setting item not checked out to be not for loan but holdable); No need to overload the output, just a comment would be enough, don't you think? You are correct. Unit test patch is updated based on your comments! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7957] Routing lists: manage several routing list for each subscription, and export them as CSV
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957 --- Comment #47 from Jonathan Druart jonathan.dru...@bugs.koha-community.org --- MariaDB [koha] select * from subscriptionroutinglist; +---++-++ | routingid | borrowernumber | ranking | subscriptionid | +---++-++ [SKIP] | 195 | 7874 | 38 | 2 | | 196 | 7874 | 39 | 2 | [SKIP] I don't know if it's a DB data error or if it comes from the updatedb entry. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10276] Extend IndependentBranches to support groups of libraries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 Jonathan Druart jonathan.dru...@bugs.koha-community.org changed: What|Removed |Added Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14693] t/db_dependent/Contract.t fails do to fixed date
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14693 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #41715|0 |1 is obsolete|| --- Comment #5 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 41785 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41785action=edit [SIGNED-OFF] Bug 14693: Contract.t should generate dates based on current date The current test for still-active contracts fails because it was written with fixed dates, which already passed :-D This patch calculates the current date, and uses it to generate a future one, so the tests serve their purpose no matter what the current date is. To test: - Run: $ prove t/db_dependent/Contract.t = FAIL: activeonly compares contractenddate with now(), and fails because a fixed 2015-07-31 is writteng on the test data - Apply the patch - Run: $ prove t/db_dependent/Contract.t = SUCCESS: the sample data has been calculated using the current date and the tests pass. - Sign off :-D Edit: added missing use DateTime::Duration, Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14693] t/db_dependent/Contract.t fails do to fixed date
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14693 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14031] Itemnumber should be a numeric search in ccl.properties
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14031 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added CC||tomasco...@gmail.com Status|Passed QA |Pushed to Master --- Comment #11 from Tomás Cohen Arazi tomasco...@gmail.com --- Patch pushed to master. Thanks David! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14588] Simplify merge_ajax.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14588 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||tomasco...@gmail.com --- Comment #13 from Tomás Cohen Arazi tomasco...@gmail.com --- Patch pushed to master. Thanks Marcel! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14661] space needed in added to staff side cart message, if items added are already in cart
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14661 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added CC||tomasco...@gmail.com Status|Passed QA |Pushed to Master --- Comment #11 from Tomás Cohen Arazi tomasco...@gmail.com --- Patch pushed to master. Thanks Kyle! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13734] RDA: Display 33xs
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13734 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||tomasco...@gmail.com --- Comment #18 from Tomás Cohen Arazi tomasco...@gmail.com --- Patch pushed to master. Good job Winona! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14707] New: Change UsageStatsCountry and UsageStatsLibraryType from free text to a dropdown list
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14707 Bug ID: 14707 Summary: Change UsageStatsCountry and UsageStatsLibraryType from free text to a dropdown list Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: julian.f...@biblibre.com Reporter: julian.f...@biblibre.com QA Contact: testo...@bugs.koha-community.org This patch avoid issues with Hea. With Bug 14608 we add UsageStatsCountry and UsageStatsLibraryType in the stats for Hea (http://hea.koha-community.org/). But if this 2 syspref are free text, we could have some syntax issues. (ex : US / United States / USA will be count in 3 different country) This patch is supposed to normalize the country and type possibilities. The default choice for UsageStatsLibraryType and UsageStatsCountry is 'empty' Test Plan - 1. Create a new Koha install 2. Go to the 'Administration' page 3. Go to 'Global system preferences' 4. Go to 'Administration' 5. At the end of this page you should see a dropdown menu for - UsageStatsCountry with all countries - UsageStatsLibraryType with all type of library They both should be empty by default. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7957] Routing lists: manage several routing list for each subscription, and export them as CSV
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957 --- Comment #46 from Jonathan Druart jonathan.dru...@bugs.koha-community.org --- On updating the DB, I got several lines of this type: DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key constraint fails (`koha`.`subscriptionrouting`, CONSTRAINT `subscriptionrouting_ibfk_2` FOREIGN KEY (`borrowernumber`) REFERENCES `borrowers` (`borrowernumber`) ON DELETE CASCADE) at /home/koha/src/installer/data/mysql/atomicupdate/bug_7957.perl line 62. DBD::mysql::st execute failed: Duplicate entry '2-7363' for key 'PRIMARY' at /home/koha/src/installer/data/mysql/atomicupdate/bug_7957.perl line 62. Any ideas of why? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13791] Plack - Out of the box support on packages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13791 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Blocks||14706 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14706 [Bug 14706] Allow enabling/disabled Plack for OPAC and Intranet individually -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12224] Allow easy printing of patron check-in slip
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12224 Joonas Kylmälä j.kylm...@gmail.com changed: What|Removed |Added CC||j.kylm...@gmail.com --- Comment #7 from Joonas Kylmälä j.kylm...@gmail.com --- (In reply to Katrin Fischer from comment #6) Would be great to see this moving. It's starting to move. Follow-up coming soon! :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9809] Get rid of reserveconstraints
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 Heather Braum hbr...@nekls.org changed: What|Removed |Added CC||hbr...@nekls.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14464] Add ability to cancel waiting holds from checkin screen
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14464 Heather Braum hbr...@nekls.org changed: What|Removed |Added CC||hbr...@nekls.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14708] The patron set as the anonymous patron should not be deletable.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708 Nicole C. Engard neng...@gmail.com changed: What|Removed |Added CC||neng...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14510] Allow column visibility in additem.pl to be customized
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14510 --- Comment #8 from Jesse Weaver jwea...@bywatersolutions.com --- Created attachment 41800 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41800action=edit Bug 14510: (QA followup) Add more columns, resort Per a conversation with Jonathan Druart, add all columns that could be reasonably mapped, and order them the same as in kohastructure.sql. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14510] Allow column visibility in additem.pl to be customized
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14510 Jesse Weaver jwea...@bywatersolutions.com changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14510] Allow column visibility in additem.pl to be customized
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14510 Jesse Weaver jwea...@bywatersolutions.com changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14693] t/db_dependent/Contract.t fails do to fixed date
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14693 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||tomasco...@gmail.com --- Comment #7 from Tomás Cohen Arazi tomasco...@gmail.com --- Fix pushed to master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13387] Uniform titles (130 / 240 / 730) Display in XSLT
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13387 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added CC||tomasco...@gmail.com Status|Passed QA |Pushed to Master --- Comment #17 from Tomás Cohen Arazi tomasco...@gmail.com --- Patch pushed to master. Thanks Winona! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14597] Reverting a batch where a record overlaid is now deleted record will fail
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14597
Kyle M Hall kyle.m.h...@gmail.com changed:
What|Removed |Added
CC||kyle.m.h...@gmail.com
--- Comment #7 from Kyle M Hall kyle.m.h...@gmail.com ---
(In reply to Jonathan Druart from comment #6)
Comment on attachment 41170 [details] [review]
[SIGNED-OFF] Bug 14597 - Reverting a batch where a record overlaid is now
deleted record will fail
Review of attachment 41170 [details] [review]:
-
::: C4/ImportBatch.pm
@@ +813,4 @@
sub BatchRevertRecords {
my $batch_id = shift;
+my $logger = Koha::Logger-get( { category =
'C4.ImportBatch.BatchRevertRecords' } );
Really?
We are going to create an instance of Log::Log4perl for each subroutine call?
Yes, otherwise we cannot do the namespacing as far as I know. This is intrinsic
with Log4Perl and not a limitation of Koha::Logger. Without namespacing we may
was well stick to using warn()
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11625] Default to logged in library for circ rules and notices slips
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11625] Default to logged in library for circ rules and notices slips
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625 --- Comment #51 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 41796 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41796action=edit [SIGNED-OFF] Bug 11625 - Implement DefaultToLoggedInLibraryCircRules This patch set makes the default circ rules and notices/slips to edit the logged in branch, if one is set. Test Plan: 1) Apply this patch 2) Log into staff side, and set your library 3) Browse to Administration/Circulation and fines rules 4) Note the rule set selected is for your library 5) Select All libraries 6) Note the rule set selected is for All libraries 7) Browse to Toos/Notices slips 8) Note the notice set selected is for your library 9) Select All libraries 10) Not the rule set selected is for All libraries 11) Click New Notice 12) Note the Library field is set to All libraries Signed-off-by: Owen Leonard oleon...@myacpl.org Signed-off-by: Katrin Fischer katrin.fischer...@web.de Passes QA script and tests. Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14708] New: The patron set as the anonymous patron should not be deletable.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708 Bug ID: 14708 Summary: The patron set as the anonymous patron should not be deletable. Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: kyle.m.h...@gmail.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com Right now it's possible to delete the anonymous patron at any time. When this happens the system will break just as if anonymouspatron was unset but patrons still have an always anonymize privacy setting. This issue occurs more frequently than one would expect. We should make it so that the patron set in AnonymousPatron is not deletable. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13723] OPAC cart not pulling date from RDA tag 264 only tag 260
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13723 Marjorie Barry-Vila marjorie.barry-v...@ccsr.qc.ca changed: What|Removed |Added CC||marjorie.barry-v...@ccsr.qc ||.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12756] Koha to MARC mapping 264$a, $b, and, $c
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12756 Marjorie Barry-Vila marjorie.barry-v...@ccsr.qc.ca changed: What|Removed |Added CC||marjorie.barry-v...@ccsr.qc ||.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
