date:20151013

[Koha-bugs] [Bug 14676] UI/UX enhancements for the patron card creator

2015-10-13 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14676

--- Comment #1 from Liz Rea  ---
Created attachment 43393
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43393=edit
Bug 14676 - UI/UX improvements to patron card creator

Reasoning

Librarians will be doing patron card things in the following frequencies, from
most frequent to least frequent:
1. Creating new patron card batches - every day/every few days
2. Managing existing card batches - every day/every few days
3. Managing existing card layouts - as needed, infrequent
5. Managing existing card templates - as needed, infrequent
6. Creating new card layouts - as needed, infrequent
7. Creating new card templates - as needed, infrequent
8. Managing existing printer profiles - possibly once only!
9. Creating new printer profiles - possibly once only!

This change to the patron card creator aims to make the most frequently used
items easily accessible at the top of the main area,
reduces clutter on the page, and makes the label creator fall in line with UI
paradigms found elsewhere in Koha.
I think I've also improved the translatability here somewhat, please check
that.

To test:

Open the patron card creator: More -> Tools -> Patron card creator
Note that the toolbar has changed. It should be consistent across all of the
patron card creator (it is an include).

+ New menu:

patron card batch
1. make sure it looks ok - toolbar buttons are consistent at the top of the
main block.
2. add patrons both by borrowernumber, and by search
3. note that the usual buttons have moved below the textarea, and now have
icons.
4. delete and export single patrons using the buttons corresponding to each
patron
5. select multiple and use the buttons above the table to remove and export
selected patrons
6. export a full batch
7. deduplicate a batch
There should be no regressions in functionality.

Image
1. This menu item should take you directly to the upload/delete images
interface
2. Upload an image, note success message is now below the form, eliminating the
jumping box.
3. Delete single images using the buttons
4. Delete multiple images using the tickboxes and "Delete selected"
5. Not deletion success message is below the table, eliminating the jumping
box.

Layout
1. This menu item should take you directly to the "Edit layout" screen.
2. no functional changes here.
3. note toolbar at top is consistent

Card template
1. this menu item should take you directly to the "Edit patron card template"
page.
2. no functional changes here.
3. note toolbar at top is consistent.

Printer profile
1. this menu item should take you directly to the "Edit printer profile" page.
2. no functional changes here.
3. note toolbar at top is consistent.

+ Manage menu:

Card batches
1. This menu item should take you directly to the "currently available batches"
page.
2. select a batch to edit using the buttons - it should take you to the editing
interface
3. select a batch to delete using the buttons - it should ask for confirm.
4. select several batches using the tickboxes, and select Export selected.
Batches should be exported as normal.
5. note toolbar at top is consistent.

Images (this is actually the same page as on the new menu, I included it in
both because it does both functions - can change if requested)
1. This menu item should take you directly to the upload/delete images
interface
2. Upload an image, note success message is now below the form, eliminating the
jumping box.
3. Delete single images using the buttons
4. Delete multiple images using the tickboxes and "Delete selected"
5. Not deletion success message is below the table, eliminating the jumping
box.

Layouts
1. This menu item should take you directly to the "currently available layouts"
page.
2. select a layout to edit using the buttons
3. select a layout to delete using the buttons
4. note toolbar at top is consistent.

Card templates
1. This menu item should take you directly to the "currently available
templates" page.
2. select a template to edit using the buttons
3. select a template to delete using the buttons
4. note toolbar at top is consistent.

Printer profiles
1. This menu item should take you directly to the "currently available
profiles" page.
2. select a profile to edit using the buttons
3. select a profile to delete using the buttons
4. note toolbar at top is consistent

+ General
* note that sidebar now only has "labels home" instead of the full "manage"
list. It seemed redundant with the toolbar tidied up.

Please note that I am happy to take suggestions/amendments to these changes.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14676] UI/UX enhancements for the patron card creator

2015-10-13 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14676

Liz Rea  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14131] Patroncard: Add possibility to print from patron lists

2015-10-13 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14131

Marc Véron  changed:

   What|Removed |Added

 Depends on||14676


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14676
[Bug 14676] UI/UX enhancements for the patron card creator
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14676] UI/UX enhancements for the patron card creator

2015-10-13 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14676

Marc Véron  changed:

   What|Removed |Added

 Blocks||14131

--- Comment #2 from Marc Véron  ---
Hi Liz,

Great! (However I could not yet test).

I note here following Bug because I think it will depend from that one:

Bug 14131 - Patroncard: Add possibility to print from patron lists

Marc


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14131
[Bug 14131] Patroncard: Add possibility to print from patron lists
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14100] Generic solution for language overlay

2015-10-13 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14100

Jonathan Druart  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14388] add sorting to funds

2015-10-13 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14388

Joonas Kylmälä  changed:

   What|Removed |Added

 CC||j.kylm...@gmail.com

--- Comment #7 from Joonas Kylmälä  ---
(In reply to M. Tompsett from comment #6)
> I wrote:
> > I was not able to duplicate issue with Debian Jessie on Master.
> > Though, this patch clearly forces sorting.
> 
> (In reply to Jonathan Druart from comment #5)
> > They are currently sorted by budget_id.
> 
> My screen says otherwise. I'm wondering if this is a hashes are stored in a
> random order issue, because it ordered 2,1,3 on my screen without the patch.

Mine too. But this happened only when I had first applied the patch and then
retracted it. Before I applied the patch they were ordered by the budget_id.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15002] New: All system resources get used if user refreshes a web page

2015-10-13 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15002

Bug ID: 15002
   Summary: All system resources get used if user refreshes a web
page
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: gmcha...@gmail.com
  Reporter: j.kylm...@gmail.com
QA Contact: testo...@bugs.koha-community.org

All system resources get used if the user refreshes a web page multiple times
(and then database services etc. start to get killed by the system etc.).
Couldn't we have some way to kill the previous perl scripts which were running
(I guess the user won't need them), or how could we solve this problem? Could
there happen some data loss if we kill the already running perl scripts?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14100] Generic solution for language overlay

2015-10-13 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14100

--- Comment #31 from Jonathan Druart  
---
Created attachment 43366
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43366=edit
Bug 14100: Move add form to the top

Not sure this is the best: now the messages will make the table moves.

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14100] Generic solution for language overlay

2015-10-13 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14100

--- Comment #30 from Jonathan Druart  
---
Created attachment 43365
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43365=edit
Bug 14100: Better errors handling

This patch mainly improves the errors handling.
It's now not possible to add a translation for the same entity-code-lang
combination.
Note that we could add entity,code,lang,translation as a unique key but
translation is TEXT (TEXT column 'translation' used in key
specification without a key length). Let's see later what's is best
here.

It also:
- wording: Translate for other languages => into
- fixes encoding issues on add/update (was just display)
- add entity and code to the title of the pop-up window

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14100] Generic solution for language overlay

2015-10-13 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14100

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #43365|0   |1
is obsolete||

--- Comment #32 from Jonathan Druart  
---
Created attachment 43367
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43367=edit
Bug 14100: Better errors handling

This patch mainly improves the errors handling.
It's now not possible to add a translation for the same entity-code-lang
combination.
Note that we could add entity,code,lang,translation as a unique key but
translation is TEXT (TEXT column 'translation' used in key
specification without a key length). Let's see later what's is best
here.

It also:
- wording: Translate for other languages => into
- fixes encoding issues on add/update (was just display)
- add entity and code to the title of the pop-up window

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14100] Generic solution for language overlay

2015-10-13 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14100

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #43366|0   |1
is obsolete||

--- Comment #33 from Jonathan Druart  
---
Created attachment 43368
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43368=edit
Bug 14100: Move add form to the top

Not sure this is the best: now the messages will make the table moves.

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12993] Add a default tax rate on item types

2015-10-13 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12993

Joonas Kylmälä  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA
 CC||j.kylm...@gmail.com

--- Comment #28 from Joonas Kylmälä  ---
If I go to koha/admin/itemtypes.pl I get:

Software error:

Template process failed: file error - parse error -
/home/putti/kohaclone/koha-tmpl/intranet-tmpl/prog/en/modules/admin/itemtypes.tt
line 197: unexpected token (eq)
  [% IF Koha.Preference('AcqCreateItem') eq 'ordering' and
Koha.Preference('item-level_itypes') eq '0' %] at
/home/putti/kohaclone/C4/Templates.pm line 121.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC

2015-10-13 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618

--- Comment #75 from Jonathan Druart  
---
(In reply to Joonas Kylmälä from comment #74)
> Jonathan, The commits in GitHub branch look good.

I have added you signed-off-by line on the 2 last patch.
Feel free to mark the bug report as Signed off if you feel confident enough.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14100] Generic solution for language overlay

2015-10-13 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14100

--- Comment #34 from Jonathan Druart  
---
(In reply to Katrin Fischer from comment #28)
> Hi Joubu,

Thanks Katrin for QAing this!

> I started testing with the itemtypes administration page and the new modal
> for adding the translations. Some first findings:
> 
> 1) I think "Translate for other languages" would work better as "Translate
> into other languages".

Fixed.

> 2) I added "Bücher" as the German translation for "Books" and the umlauts in
> the table with the translated strings are broken.

Oops, fixed!

> 3) I accidentally added the "Bücher" string twice - should we allow multiple
> translations for the same lang and entity combination?

I added a check on update/insert. You should now get a warning/error message.

> 4) There should be a way to delete strings accidentally added, but I don't
> see one. There is an empty last cell in the last column, only when you open
> the modal a second time the X appears.

It should yes, but... I would prefer to see this feature push as it and receive
feedback: is it useful? how could we improve it? etc.
This will take me ages (because js...) and I don't think the added value is
high. And there is a workaround...

> 5) I think it would be good to switch the sequence and have the entry field
> above the table. 
> 6) It would be good to show the entity and code you are translating for in
> the window somewhere.

Done in a separate patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14388] add sorting to funds

2015-10-13 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14388

--- Comment #8 from Joonas Kylmälä  ---
(In reply to Joonas Kylmälä from comment #7)
> (In reply to M. Tompsett from comment #6)
> > I wrote:
> > > I was not able to duplicate issue with Debian Jessie on Master.
> > > Though, this patch clearly forces sorting.
> > 
> > (In reply to Jonathan Druart from comment #5)
> > > They are currently sorted by budget_id.
> > 
> > My screen says otherwise. I'm wondering if this is a hashes are stored in a
> > random order issue, because it ordered 2,1,3 on my screen without the patch.
> 
> Mine too. But this happened only when I had first applied the patch and then
> retracted it. Before I applied the patch they were ordered by the budget_id.

It happened because in acqui-home.tt there is a javascript line which states:
'aaSortingFixed': [[ 1, 'asc' ]],

So the table shown to the user is sorted with that. I'm just wondering why it
started to only work after I applied the patch...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12027] Shibboleth authentication for staff client

2015-10-13 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12027

--- Comment #10 from Martin Renvoize  ---
Rebased again

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14916] Remove C4::Dates from circ/overdue.pl

2015-10-13 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14916

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #43344|0   |1
is obsolete||

--- Comment #4 from Jonathan Druart  
---
Created attachment 43375
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43375=edit
Bug 14916: Display overdues if due on 23:59

If an item is due on today 23:59 and the filter is from yesterday to today, the
overdue won't appear on the list.

Test plan:
Be sure you have an item due on DATE 23:59
Search for overdues from DATE-1 to DATE
Without this patch, the item won't appear.
With this patch, it will.

Regression test: test the CSV download.

Note: On the way, this patch remove the deps to C4::Dates (which was the
original goal of the bug report).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14916] Overdues are not listed if due on 23:59 of the 'to date' (Was: Remove C4::Dates from circ/overdue.pl)

2015-10-13 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14916

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
Summary|Remove C4::Dates from   |Overdues are not listed if
   |circ/overdue.pl |due on 23:59 of the 'to
   ||date' (Was: Remove
   ||C4::Dates from
   ||circ/overdue.pl)
   Severity|enhancement |normal
   Assignee|ve...@veron.ch  |jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #5 from Jonathan Druart  
---
Marc,
Sorry to steal your bug (again), but I think I have found a bug on master.
Could you please confirm?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14916] Remove C4::Dates from circ/overdue.pl

2015-10-13 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14916

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11300] Add a new authority linker which searches for authority links on a Z39.50 server.

2015-10-13 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11300

Joonas Kylmälä  changed:

   What|Removed |Added

 CC||j.kylm...@gmail.com
 Status|Needs Signoff   |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12478] Elasticsearch support for Koha

2015-10-13 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478

--- Comment #168 from Jonathan Druart  
---
(In reply to Robin Sheat from comment #166)
> Commit cd4905c2 (Display facet terms ordered by number of occurrences)
> introduces a bug when searching with zebra (i.e. it makes it break.) I will
> roll it back until we get a better solution. Feel free to unroll it back if
> you get the chance to make one.

Oops, sorry about that!
The last patch should work now.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14975] Fine grace period label is incorrect

2015-10-13 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14975

Jonathan Druart  changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=14923
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14975] Fine grace period label is incorrect

2015-10-13 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14975

Jonathan Druart  changed:

   What|Removed |Added

   See Also|http://bugs.koha-community. |http://bugs.koha-community.
   |org/bugzilla3/show_bug.cgi? |org/bugzilla3/show_bug.cgi?
   |id=14923|id=14293

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14923] Remove C4::Dates from labels/label-item-search.pl

2015-10-13 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14923

Jonathan Druart  changed:

   What|Removed |Added

   See Also|http://bugs.koha-community. |
   |org/bugzilla3/show_bug.cgi? |
   |id=14975|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14923] Remove C4::Dates from labels/label-item-search.pl

2015-10-13 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14923

Jonathan Druart  changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=14975

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14293] Error in the calculation of the suspension of users per day

2015-10-13 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14293

Jonathan Druart  changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=14975

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11122] publisher code and publication year not fetched in acq orders

2015-10-13 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11122

Joonas Kylmälä  changed:

   What|Removed |Added

 CC||j.kylm...@gmail.com
 Status|Needs Signoff   |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14955] "Show more" link contains double encoded characters

2015-10-13 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14955

--- Comment #3 from Jonathan Druart  
---
I have retried and it works here.
What is the url for the [x] link?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12993] Add a default tax rate on item types

2015-10-13 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12993

Jonathan Druart  changed:

   What|Removed |Added

   Assignee|jonathan.dru...@bugs.koha-c |claire.hernandez@biblibre.c
   |ommunity.org|om

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12993] Add a default tax rate on item types

2015-10-13 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12993

--- Comment #29 from Jonathan Druart  
---
The 3 occurrences of
+[% IF Koha.Preference('AcqCreateItem') eq 'ordering' and
Koha.Preference('item-level_itypes') eq '0' %]
should be s/eq/==

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12478] Elasticsearch support for Koha

2015-10-13 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #43345|0   |1
is obsolete||
  Attachment #43346|0   |1
is obsolete||
  Attachment #43347|0   |1
is obsolete||
  Attachment #43348|0   |1
is obsolete||
  Attachment #43349|0   |1
is obsolete||
  Attachment #43350|0   |1
is obsolete||
  Attachment #43351|0   |1
is obsolete||

--- Comment #167 from Jonathan Druart  
---
Created attachment 43373
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43373=edit
Bug 12478: Display facet terms ordered by number of occurrences

By default ES returns the facet terms ordered by most used, which makes
sense.

This patch removes resort done in the scripts (catalogue/search.pl and
opac/opac-search.pl) and moves it to the module.

For Zebra it's now done in C4::Search::getRecords, and there is no
change to expect (still alphabetically).

On the Elastic search side, we could imagine to let the library define
the order of the facets. The facet terms are now sorted by most used.

To test easily this change, turn on the displayFacetCount pref.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15003] New: Help should be a wiki, not translatable via po-files

2015-10-13 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15003

Bug ID: 15003
   Summary: Help should be a wiki, not translatable via po-files
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Staff Client
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: pasi.kalli...@pttk.fi
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

[Note: This is brainstorming based on feedback from Vaarakirjastot]

Po-files split the help pages into sentences, or worse, into sentence
fragments.
This makes translating them into fluent language nearly impossible, because
they
are text articles and direct sentence translation makes bad prose.

Each help page should be a single translatable element.

As the help pages are already sort-of like wiki, and editable in Koha itself,
it would make sense to package the actual help pages for each language
separately, which could then be installed (either in Koha itself, or by
external means).

And/Or perhaps there could be a syspref to use external URL instead of
local help, with some substitutions for language, Koha version, and
the help article. For example, setting the syspref value to
"http://help.koha-community.org/wiki/${lang}/${version}/${article};
would open that page on a wiki set up there.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14920] Remove C4::Dates from circ/reserveratios.pl

2015-10-13 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14920

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14920] Remove C4::Dates from circ/reserveratios.pl

2015-10-13 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14920

--- Comment #11 from Jonathan Druart  
---
Created attachment 43377
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43377=edit
Bug 14920: Simplify the date management on reserveratios

Note that the previous patch was wrong, the start date defaulted to yesterday,
the original behavior is to default to last year.

This patch removes some unecessary variable declarations and tests.

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14920] Remove C4::Dates from circ/reserveratios.pl

2015-10-13 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14920

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #43361|0   |1
is obsolete||

--- Comment #10 from Jonathan Druart  
---
Created attachment 43376
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43376=edit
Bug 14920 - Remove C4::Dates from circ/reserveratios.pl

This patch removes C4::Dates from circ/reserveratios.pl

To test:
- Make sure you have many holds for biblios with not so much items (e.g. 5
holds, 1 item)
  or follow hint below
- Go to Home > Circulation > Hold ratios
- Verify that everything works the same without an dwith patch

Hint: To get a big table you can set 'Hod ratio' in the filter to 0.1  (default
value is 3).
This was will trigger biblios with less holds than items.

Signed-off-by: Hector Castro 
Works as advertised. Tested with dateformat syspref, datepiker Ok

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14100] Generic solution for language overlay

2015-10-13 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14100

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #43367|0   |1
is obsolete||

--- Comment #35 from Jonathan Druart  
---
Created attachment 43369
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43369=edit
Bug 14100: Better errors handling

This patch mainly improves the errors handling.
It's now not possible to add a translation for the same entity-code-lang
combination.
Note that we could add entity,code,lang,translation as a unique key but
translation is TEXT (TEXT column 'translation' used in key
specification without a key length). Let's see later what's is best
here.

It also:
- wording: Translate for other languages => into
- fixes encoding issues on add/update (was just display)
- add entity and code to the title of the pop-up window

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC

2015-10-13 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618

--- Comment #74 from Joonas Kylmälä  ---
Jonathan, The commits in GitHub branch look good.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9305] Attach adults to each other

2015-10-13 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9305

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #1 from Katrin Fischer  ---
Is this a duplicate with bug 12446?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14100] Generic solution for language overlay

2015-10-13 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14100

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #43368|0   |1
is obsolete||

--- Comment #36 from Jonathan Druart  
---
Created attachment 43370
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43370=edit
Bug 14100: Move add form to the top

Not sure this is the best: now the messages will make the table moves.

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12027] Shibboleth authentication for staff client

2015-10-13 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12027

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #35554|0   |1
is obsolete||

--- Comment #9 from Martin Renvoize  ---
Created attachment 43372
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43372=edit
BUG 12027 [Followup]: Added missing documentation

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12027] Shibboleth authentication for staff client

2015-10-13 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12027

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #35553|0   |1
is obsolete||

--- Comment #8 from Martin Renvoize  ---
Created attachment 43371
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43371=edit
BUG 12027: Added shibboleth authentication to the staff client

- This patch adds shibboleth authentication to the staff client.
- Depending upon how your url structure works, you may or may not need a
  second native shibboleth service provider profile configured for this
  to work.

http://bugs.koha-community.org/show_bug.cgi?id=12026

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14955] "Show more" link contains double encoded characters

2015-10-13 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14955

Joonas Kylmälä  changed:

   What|Removed |Added

 CC||j.kylm...@gmail.com

--- Comment #2 from Joonas Kylmälä  ---
After doing the test plan you can't remove the filter item (author). If you
click the |x| it will stay still there (and if you try again, it will just stay
there).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14975] Fine grace period label is incorrect

2015-10-13 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14975

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #43343|0   |1
is obsolete||

--- Comment #3 from Jonathan Druart  
---
Created attachment 43374
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43374=edit
Bug 14975 - Fine grace period label is incorrect

The column heading for grace period is "Fine grace period (day)" but the
grace period works based on the unit selected ( hours or days ). The
"(day)" part should be removed as it caused confusion for librarians.

Test Plan:
1) Apply this patch
2) Go to the circ rules editor
3) Note the header and footer columns for grace period no longer
   have "(days)" at the end.

Signed-off-by: Marc Véron 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14975] Fine grace period label is incorrect

2015-10-13 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14975

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11299] Add a button that automatically links authority records to a biblio record during edition. (AJAX)

2015-10-13 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299

Mike  changed:

   What|Removed |Added

 CC||blac...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11300] Add a new authority linker which searches for authority links on a Z39.50 server.

2015-10-13 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11300

Mike  changed:

   What|Removed |Added

 CC||blac...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14956] Remove C4::Dates from files opac/*.pl

2015-10-13 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14956

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #8 from Jonathan Druart  
---
The second patch is not the way to do, especially at the OPAC: if the user
turned off JS, he cannot enter a date.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15004] Allow to change amounts of duplicated budgets

2015-10-13 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15004

Julian Maurice  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15004] Allow to change amounts of duplicated budgets

2015-10-13 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15004

--- Comment #1 from Julian Maurice  ---
Created attachment 43380
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43380=edit
Bug 15004: Allow to change amounts of duplicated budgets

When duplicating a budget we now have the possibility to change amounts
of budget and funds by a given percentage.
Additionally, we can configure how to round the amounts.

Test plan:
1. Create a budget and several funds with different amounts
2. Duplicate it using the 2 new options
3. Check that the amounts are correct

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14727] koha-indexer tab completion in bash

2015-10-13 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14727

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #4 from Jonathan Druart  
---
The completion works but:

root@kohadevbox:~# koha-indexer --start kohadev 
[ ok ] Starting Koha indexing daemon for kohadev:.
root@kohadevbox:~# koha-indexer --stop kohadev 
[FAIL] Error: Indexer not running for kohadev: failed!

root@kohadevbox:~# ps aux | grep zebra
kohadev+   509  0.0  0.0  18596   188 ?S11:45   0:00 daemon
--name=kohadev-koha-zebra --pidfiles=/var/run/koha/kohadev/
--errlog=/var/log/koha/kohadev/zebra-error.log
--stdout=/var/log/koha/kohadev/zebra.log
--output=/var/log/koha/kohadev/zebra-output.log --verbose=1 --respawn
--delay=30 --user=kohadev-koha.kohadev-koha -- zebrasrv -v none,fatal,warn -f
/etc/koha/sites/kohadev/koha-conf.xml
kohadev+   511  0.0  0.8 121780  9148 ?S11:45   0:00 zebrasrv -v
none,fatal,warn -f /etc/koha/sites/kohadev/koha-conf.xml
kohadev+  3017  0.0  0.0  18596   188 ?S11:52   0:00 daemon
--name=kohadev-koha-indexer --errlog=/var/log/koha/kohadev/indexer-error.log
--stdout=/var/log/koha/kohadev/indexer.log
--output=/var/log/koha/kohadev/indexer-output.log --verbose=1 --respawn
--delay=30 --user=kohadev-koha.kohadev-koha --
/usr/share/koha/bin/migration_tools/rebuild_zebra.pl -daemon -x -sleep 5
kohadev+  3020  0.8 11.0 341964 113288 ?   S11:52   0:01 /usr/bin/perl
/usr/share/koha/bin/migration_tools/rebuild_zebra.pl -daemon -x -sleep 5

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14955] "Show more" link contains double encoded characters

2015-10-13 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14955

--- Comment #6 from Jonathan Druart  
---
Indeed, it worked for the intranet, not for the OPAC.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14955] "Show more" link contains double encoded characters

2015-10-13 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14955

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #43117|0   |1
is obsolete||

--- Comment #5 from Jonathan Druart  
---
Created attachment 43382
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43382=edit
Bug 14955: Don't double encode chars in the "Show more" link

Bug 13789 has fixed this issue for the facet links (select/unselect) but
not for the "Show more" facets link.

This patch reuses the "url" variable, generated for the facets, for
these links. A new "local_url" variable is used to build links for each
entry.

Test plan (for OPAC and intranet):
- Search for a very common term
- Filter the results using facets
- You should get more than 5 entries for a facet and 1 selected:
Author
 author 1
 author 2 [x] # Selected
 author 3
 author 4
 author 5
 Show more # you see this link if there is 5+ values for this facet
- Click on the Show more link
Without this patch, the url contains double-encoded characters and you
will certainly don't get any results
With this patch, you should get results.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15005] (Plack) Use of SCRIPT_NAME makes Koha generate wrong URIs

2015-10-13 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15005

--- Comment #1 from Tomás Cohen Arazi  ---
Created attachment 43383
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43383=edit
Wrong links generated

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15005] (Plack) Use of SCRIPT_NAME makes Koha generate wrong URIs

2015-10-13 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15005

Tomás Cohen Arazi  changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |jonathan.dru...@bugs.koha-c
   ||ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14653] Acq planning filter and export always use default active period

2015-10-13 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14653

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #43308|0   |1
is obsolete||
  Attachment #43309|0   |1
is obsolete||

--- Comment #6 from Jonathan Druart  
---
Created attachment 43378
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43378=edit
Bug 14653 - Acq planning filter always use default active period

In Acq planning /cgi-bin/koha/admin/aqplan.pl, left side filter and export
forms have no parameter budget_period_id nor authcat, so the use the default
active period.
As said in code :
- IF PERIOD_ID IS DEFINED,  GET THE PERIOD - ELSE GET THE ACTIVE PERIOD BY
DEFAULT
my $period = GetBudgetPeriod($budget_period_id);

This patch corrects the filter form.

Test plan :
- Create an active budget "B_ACTIVE" with 1 fund
- Create an inactive budget "B_OLD" with 3 funds
- Go to "B_OLD" planning by libraries
- You see 3 funds
- In filter form, select "by months" in "Select planning type"
=> Without patch, you see planning of "B_ACTIVE" with 1 fund
=> Without patch, you see planning of "B_OLD" with 3 funds

Signed-off-by: Hector Castro 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15004] New: Allow to change amounts of duplicated budgets

2015-10-13 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15004

Bug ID: 15004
   Summary: Allow to change amounts of duplicated budgets
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Acquisitions
  Assignee: julian.maur...@biblibre.com
  Reporter: julian.maur...@biblibre.com
QA Contact: testo...@bugs.koha-community.org

Use case:
"I want to create a '2016' budget, same as '2015' budget, but I will have 15%
more (or less) money in 2016, and I don't want to update all the funds
manually"

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14727] koha-indexer tab completion in bash

2015-10-13 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14727

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14246] Add borrowernumber to koha_news

2015-10-13 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14246

Joonas Kylmälä  changed:

   What|Removed |Added

 CC||j.kylm...@gmail.com
 Status|Needs Signoff   |In Discussion

--- Comment #16 from Joonas Kylmälä  ---
I guess this feature should be also be used by OPAC/Staff side. Now the user
itself cannot use the feature (only people with access to the db).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14653] Acq planning filter and export always use default active period

2015-10-13 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14653

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #8 from Jonathan Druart  
---
So it seems that only 1 library uses this feature :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14653] Acq planning filter and export always use default active period

2015-10-13 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14653

--- Comment #7 from Jonathan Druart  
---
Created attachment 43379
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43379=edit
Bug 14653 - Acq planning export always use default active period

In Acq planning /cgi-bin/koha/admin/aqplan.pl, left side filter and export
forms have no parameter budget_period_id nor authcat, so the use the default
active period.
As said in code
- IF PERIOD_ID IS DEFINED,  GET THE PERIOD - ELSE GET THE ACTIVE PERIOD BY
DEFAULT
my $period = GetBudgetPeriod($budget_period_id);

This patch corrects the export form.

Test plan :
- Create an active budget "B_ACTIVE" with 1 fund
- Create an inactive budget "B_OLD" with 3 funds
- Go to "B_OLD" planning by libraries
- You see 3 funds
- Click on "Submit" in export form
=> Without patch, you get the planning of "B_ACTIVE" with 1 fund
=> Without patch, you get the planning of "B_OLD" with 3 funds by libraries

Signed-off-by: Hector Castro 
Works as advertised

Signed-off-by: Hector Castro 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14653] Acq planning filter and export always use default active period

2015-10-13 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14653

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14727] koha-indexer tab completion in bash

2015-10-13 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14727

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #43314|0   |1
is obsolete||

--- Comment #3 from Jonathan Druart  
---
Created attachment 43381
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43381=edit
Bug 14727: koha-indexer tab completion in bash

This patch introduces tab-completion in bash to the koha-indexer
command. It completes using valid option switches and instance names.
It stops completing then -h or --help are issued, and once a command
switch is chosen (either --start, --stop or --restart) it goes ahead
with valid instances completion.

To test:
- Have a packages install (kohadevbox works)
- Run:
  $ . debian/koha-common.bash-completion
- Type
  koha-indexer 
- Play with all the options
=> SUCCESS: They work as they should.
- Sign off :-D

Note: it fixes a small glitch on the plack completion.

Signed-off-by: Jesse Weaver 
Verified working, including filtering out already used options and
instances.

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15005] New: (Plack) Use of SCRIPT_NAME makes Koha generate wrong URIs

2015-10-13 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15005

Bug ID: 15005
   Summary: (Plack) Use of SCRIPT_NAME makes Koha generate wrong
URIs
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: major
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: gmcha...@gmail.com
  Reporter: tomasco...@gmail.com
QA Contact: testo...@bugs.koha-community.org

The current plack-on-packages schema points the apache vhost (for example for
the intranet) like this:

  /cgi-bin/koha/ => /intranet/

So the code that uses ENV{SCRIPT_NAME} "sees" it is being called for example
like /intranet/mainpage.pl. This gets problematic in some scenarios, because it
is used to then redirect the browser, or to create links to things.

Steps to reproduce:
- Check out an old DBRev in the koha repo (1 step older is ok)
- Pick the ansible branch from the kohadevbox [1]
- Launch it, on jessie:
  $ vagrant up jessie
- Log into it
  $ vagrant ssh jessie
- Enable Plack for the automatically created instance
  $ sudo koha-plack --enable kohadev
  $ sudo koha-plack --start  kohadev
  $ sudo service apache2 restart
- Get the DB password to be able to login
  $ koha-pass
- Point your browser to the staff interface:
  http://localhost:8081
- Login with koha_kohadev and the retrieved password
=> FAIL: You cannot login
- Disable Plack for the instance
  $ sudo koha-plack --disable kohadev
  $ sudo koha-plack --stop  kohadev
  $ sudo service apache2 restart
- Point your browser to the staff interface:
  http://localhost:8081
- Login with koha_kohadev and the retrieved password
=> SUCCESS: You can login
- Proceed to install with the default data (you can try enabling plack and you
will notice it works)
- Once you are in, enable plack
  $ sudo koha-plack --enable kohadev
  $ sudo koha-plack --start  kohadev
  $ sudo service apache2 restart
- Checkout the latest master (so it triggers an update)
- Go somewhere inside (about?)
- You are required to login (which is expected)
=> FAIL: the links back are pointing to /intranet/ so they are shortcircuited
to the installer cyclically (see screenshot)

[1] https://github.com/digibib/kohadevbox/tree/ansible

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14955] "Show more" link contains double encoded characters

2015-10-13 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14955

--- Comment #4 from Joonas Kylmälä  ---
(In reply to Jonathan Druart from comment #3)
> I have retried and it works here.
> What is the url for the [x] link?

http://10.0.3.132/cgi-bin/koha/opac-search.pl?idx=kw=a=au%3AHurme-Ker%C3%A4nen%2C%20Auli._by=relevance_dsc

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15006] New: Need to distinguish client timeout from login timeout

2015-10-13 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006

Bug ID: 15006
   Summary: Need to distinguish client timeout from login timeout
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: SIP2
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: colin.campb...@ptfs-europe.com
QA Contact: testo...@bugs.koha-community.org
CC: colin.campb...@ptfs-europe.com

Since patch 13432 was applied the main sip loop times out according to the
timeout value. This can cause considerable instability and cause client
machines to shutdown if the value is too low. As the timeout variable is a
login timeout it is typically on the low side (30sec) for client connections it
needs to be over 5mins typically possibly more. Suggest a the time out for
active connections be separated from the login timeout. we also need the
possibility to switch it off completely. Submit a  patch adding a
'client_timeout' parameter

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14716] opac-detail.pl -- Series link fails when series title ends with semicolon preceded by space.

2015-10-13 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716

Kyle M Hall  changed:

   What|Removed |Added

 CC||kyle.m.h...@gmail.com

--- Comment #1 from Kyle M Hall  ---
This is happening because the query is malformed.

Take for example the query se,phr:"Frank%20Einstein%20;" which is 

se,phr:"Frank Einstein"

but the semicolon is truncating the query so it looks to Koha 

se,phr:"Frank Einstein

which is not a problem on the staff side. Zebra seems to deal with this ok.

On the opac side though, we are adding on supression, so the query ends up like
this:

(se,phr:"Frank Einstein ) not Suppress=1

which zebra chokes on.

Removing the semicolon from the subject heading would fix this, but I imagine
that's a band-aid as the semi is part of the standard.

The semi is being treated as an ampersand. This is deep in the machinery (
http://www.w3.org/TR/1999/REC-html401-19991224/appendix/notes.html#h-B.2.2 )

Basically, the semi needs to be url encoded as %3B

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14727] koha-indexer tab completion in bash

2015-10-13 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14727

--- Comment #5 from Tomás Cohen Arazi  ---
(In reply to Jonathan Druart from comment #4)
> The completion works but:
> 
> root@kohadevbox:~# koha-indexer --start kohadev 
> [ ok ] Starting Koha indexing daemon for kohadev:.
> root@kohadevbox:~# koha-indexer --stop kohadev 
> [FAIL] Error: Indexer not running for kohadev: failed!
> 
> root@kohadevbox:~# ps aux | grep zebra
> kohadev+   509  0.0  0.0  18596   188 ?S11:45   0:00 daemon
> --name=kohadev-koha-zebra --pidfiles=/var/run/koha/kohadev/
> --errlog=/var/log/koha/kohadev/zebra-error.log
> --stdout=/var/log/koha/kohadev/zebra.log
> --output=/var/log/koha/kohadev/zebra-output.log --verbose=1 --respawn
> --delay=30 --user=kohadev-koha.kohadev-koha -- zebrasrv -v none,fatal,warn
> -f /etc/koha/sites/kohadev/koha-conf.xml
> kohadev+   511  0.0  0.8 121780  9148 ?S11:45   0:00 zebrasrv -v
> none,fatal,warn -f /etc/koha/sites/kohadev/koha-conf.xml
> kohadev+  3017  0.0  0.0  18596   188 ?S11:52   0:00 daemon
> --name=kohadev-koha-indexer --errlog=/var/log/koha/kohadev/indexer-error.log
> --stdout=/var/log/koha/kohadev/indexer.log
> --output=/var/log/koha/kohadev/indexer-output.log --verbose=1 --respawn
> --delay=30 --user=kohadev-koha.kohadev-koha --
> /usr/share/koha/bin/migration_tools/rebuild_zebra.pl -daemon -x -sleep 5
> kohadev+  3020  0.8 11.0 341964 113288 ?   S11:52   0:01
> /usr/bin/perl /usr/share/koha/bin/migration_tools/rebuild_zebra.pl -daemon
> -x -sleep 5

Please fill a bug for that...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10020] Remove old code related to 'ethnicity'

2015-10-13 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10020

--- Comment #25 from Tomás Cohen Arazi  ---
Created attachment 43384
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43384=edit
Bug 10020: (RM followup) DBIx update / delete leftover file

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14045] Add specific quotas to on-site checkout

2015-10-13 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14045

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||tomasco...@gmail.com

--- Comment #41 from Tomás Cohen Arazi  ---
Patches pushed to master.

Thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14727] koha-indexer tab completion in bash

2015-10-13 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14727

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||tomasco...@gmail.com

--- Comment #6 from Tomás Cohen Arazi  ---
Patch pushed to master.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14841] Columns settings on checkouts table have 2 bugs

2015-10-13 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14841

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||tomasco...@gmail.com

--- Comment #10 from Tomás Cohen Arazi  ---
Patches pushed to master.

Thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14920] Remove C4::Dates from circ/reserveratios.pl

2015-10-13 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14920

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||tomasco...@gmail.com

--- Comment #12 from Tomás Cohen Arazi  ---
Patches pushed to master.

Thanks Marc!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14975] Fine grace period label is incorrect

2015-10-13 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14975

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com
 Status|Passed QA   |Pushed to Master

--- Comment #4 from Tomás Cohen Arazi  ---
Patch pushed to master.

Thanks Kyle!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14653] Acq planning filter and export always use default active period

2015-10-13 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14653

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||tomasco...@gmail.com

--- Comment #9 from Tomás Cohen Arazi  ---
Patches pushed to master.

Thanks Frido!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14966] Table header broken at detail.tt

2015-10-13 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14966

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com
 Status|Passed QA   |Pushed to Master

--- Comment #5 from Tomás Cohen Arazi  ---
Patch pushed to master.

Thanks Rafal!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12368] Rebuild Zebra improvement: allow to specify a DB table

2015-10-13 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12368

Fridolin SOMERS  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #14 from Fridolin SOMERS  ---
in my opinion, -t should not be used for --table, it is usually used for --test

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14716] opac-detail.pl -- Series link fails when series title ends with semicolon preceded by space.

2015-10-13 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716

Kyle M Hall  changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |kyle.m.h...@gmail.com
   Severity|enhancement |normal

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14045] Add specific quotas to on-site checkout

2015-10-13 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14045

--- Comment #42 from Nicolas Legrand  ---
\o/ thanks !

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14716] opac-detail.pl -- Series link fails when series title ends with semicolon preceded by space.

2015-10-13 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716

--- Comment #2 from Kyle M Hall  ---
Created attachment 43385
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43385=edit
MARC21 File for testing

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14716] opac-detail.pl -- Series link fails when series title ends with semicolon preceded by space.

2015-10-13 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716

--- Comment #3 from Kyle M Hall  ---
Created attachment 43386
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43386=edit
Bug 14716 - opac-detail.pl -- Series link fails when series title ends with
semicolon preceded by space.

This is happening because the query is malformed.

Take for example the query se,phr:"Frank%20Einstein%20;" which is

se,phr:"Frank Einstein"

but the semicolon is truncating the query so it looks to Koha

se,phr:"Frank Einstein

which is not a problem on the staff side. Zebra seems to deal with this
ok.

On the opac side though, we are adding on supression, so the query ends
up like this:

(se,phr:"Frank Einstein ) not Suppress=1

which zebra chokes on.

Removing the semicolon from the subject heading would fix this, but I
imagine that's a band-aid as the semi is part of the standard.

The semi is being treated as an ampersand. This is deep in the machinery
( http://www.w3.org/TR/1999/REC-html401-19991224/appendix/notes.html#h-B.2.2 )

Basically, the semi needs to be url encoded as %3B

Test Plan:
1) Import the records in the attached MARC21 file, re-index
2) From the OPAC search for "Frank Einstein and the antimatter motor"
3) Click the series link, note you get no results
4) Apply this patch
5) Refresh the record details page
6) Click the series link
7) Results!

NOTE: This bug does not occurr with all Koha server configurations.
  I have yet to determine the specific variable that creates
  this truncation behavior.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14716] opac-detail.pl -- Series link fails when series title ends with semicolon preceded by space.

2015-10-13 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716

Kyle M Hall  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15007] New: Slips and notices table 'letters' should have an 'id' primary key column

2015-10-13 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15007

Bug ID: 15007
   Summary: Slips and notices table 'letters' should have an 'id'
primary key column
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: gmcha...@gmail.com
  Reporter: kyle.m.h...@gmail.com
QA Contact: testo...@bugs.koha-community.org

The recent issues related to duplicate notices have demonstrated that it would
be much better to have an id column on letters so these issues not do re-emerge
at a later date.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15007] Slips and notices table 'letters' should have an 'id' primary key column

2015-10-13 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15007

Kyle M Hall  changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |kyle.m.h...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15005] (Plack) Use of SCRIPT_NAME makes Koha generate wrong URIs

2015-10-13 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15005

--- Comment #3 from Jonathan Druart  
---
Created attachment 43388
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43388=edit
Bug 15005: Remove CGI->url calls from pl scripts

Same as previous patch for calls in pl scripts.

Test plan:
- delete an entry of your search history from intranet and opac
- with IndependentBranches=OFF, go on the waiting holds and confirm that the
link next to 'Holds awaiting pickup for your library on' is correct.
- search for items, the pagination should work correctly

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15005] (Plack) Use of SCRIPT_NAME makes Koha generate wrong URIs

2015-10-13 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15005

--- Comment #2 from Jonathan Druart  
---
Created attachment 43387
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43387=edit
Bug 15005: Replace CGI->url with the corresponding url

CGI->url does not return the correct url on install using packages.

Test plan:
1/ Try to reproduce the bug from the description of bug 15005.
You should be able to login to the intranet and the OPAC
2/ Send a basket and a list from the intranet and the OPAC.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15005] (Plack) Use of SCRIPT_NAME makes Koha generate wrong URIs

2015-10-13 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15005

Jonathan Druart  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13628] clicking + on patron does nothing

2015-10-13 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13628

Heather Braum  changed:

   What|Removed |Added

 CC||hbr...@nekls.org

--- Comment #1 from Heather Braum  ---
This was also reported on import_borrowers.pl, on bug 14690. It looks like a
patch needs signoff there. Could it apply to this bug, too? 

I can confirm this continues to be an issue, at least in 3.18.8.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14690] Patron import tool page missing extra search patron options

2015-10-13 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14690

--- Comment #3 from Heather Braum  ---
This is also an issue for bug 13628. Would this patch fix that bug, too?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15005] (Plack) Use of SCRIPT_NAME makes Koha generate wrong URIs

2015-10-13 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15005

--- Comment #4 from Jonathan Druart  
---
Created attachment 43389
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43389=edit
Bug 15005: Fix pagination_bar calls

Test plan:
Create an order for an existing biblio, confirm that the pagination links work
correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14364] Allow automatically canceled expired waiting holds to fill the next hold

2015-10-13 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14364

Marjorie Barry-Vila  changed:

   What|Removed |Added

 CC||marjorie.barry-v...@ccsr.qc
   ||.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14235] Items appear as LOST when Missing

2015-10-13 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14235

Karl Holten  changed:

   What|Removed |Added

 CC||khol...@switchinc.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15009] Planning dropdown button in aqbudget can have empty line

2015-10-13 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15009

Blou  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
   Assignee|koha-b...@lists.koha-commun |philippe.blo...@inlibro.com
   |ity.org |
 CC||eric.be...@inlibro.com,
   ||francois.charbonnier@inlibr
   ||o.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14937] Expiration date for holds based onReservesMaxPickUpDelay should not require ExpireReservesMaxPickUpDelay

2015-10-13 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14937

Nicole C. Engard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15009] Planning dropdown button in aqbudget can have empty line

2015-10-13 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15009

--- Comment #1 from Blou  ---
Created attachment 43392
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43392=edit
Bug 15009 - Planning dropdown button in aqbudget can have empty line

When displaying a budget, the Planning button in the admin toolbar displays

Plan by months
Plan by libraries
Plan by item types
Plan by

The last one is empty, due to C4::Budgets::GetBudgetAuthCats returning an empty
field if the budget has no sort defined.
This prevents returning an array with empty element(s)

TEST:
1) Admin -> Budgets
2) Select a budget
   a) you must have '' (empty) in your aqbudgets.sort1_authcat field.
   b) edit the budget (direct DB or interface) to get that.
3) Click on Planning dropdown, see the "Plan by  " entry.
4) apply the patch, revalidate.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15009] Planning dropdown button in aqbudget can have empty line

2015-10-13 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15009

Blou  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14937] Expiration date for holds based onReservesMaxPickUpDelay should not require ExpireReservesMaxPickUpDelay

2015-10-13 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14937

Nicole C. Engard  changed:

   What|Removed |Added

  Attachment #43024|0   |1
is obsolete||

--- Comment #2 from Nicole C. Engard  ---
Created attachment 43390
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43390=edit
[SIGNED-OFF] Bug 14937 - Expiration date for holds based
onReservesMaxPickUpDelay should not require ExpireReservesMaxPickUpDelay

C4::Letters::_parseletter will replace reserves.expirationdate with the
date a hold will be marked as problematic ( holds over ) if both
ReservesMaxPickUpDelay and ExpireReservesMaxPickUpDelay are enabled.
There is no reason this feature needs to rely on
ExpireReservesMaxPickUpDelay as there are many libraries that would like
to send the last day to pick up a hold in notices, but would rather deal
with the expired waiting holds manually rather than have Koha cancel
them automatically.

Test Plan:
1) Apply this patch
2) Set ReservesMaxPickUpDelay to 7
3) Disable ExpireReservesMaxPickUpDelay
4) Add reserves.expirationdate to your HOLD notice
5) Fill a hold for a patron
6) View the message, not that reserves.expirationdate is replaced
   with the date the hold will be marked as problematic

Signed-off-by: Karl Holton 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14713] remaining_permissions permission under the "updatecharges" permission not working

2015-10-13 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14713

J Schmidt  changed:

   What|Removed |Added

 CC||jschm...@switchinc.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4948] canceling a hold missing steps for existing holds

2015-10-13 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4948

Marjorie Barry-Vila  changed:

   What|Removed |Added

 CC||marjorie.barry-v...@ccsr.qc
   ||.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15009] New: Planning dropdown button in aqbudget can have empty line

2015-10-13 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15009

Bug ID: 15009
   Summary: Planning dropdown button in aqbudget can have empty
line
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: trivial
  Priority: P5 - low
 Component: System Administration
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: philippe.blo...@inlibro.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

Created attachment 43391
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43391=edit
Planning dropdown having useless fourth row

When displaying a budget, the Planning button in the admin toolbar displays

Plan by months
Plan by libraries
Plan by item types
Plan by

The last one is empty, due to C4::Budgets::GetBudgetAuthCats returning an empty
field if the budget has no sort defined.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13950] Sort Item search home library list by branch name

2015-10-13 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13950

Karl Holten  changed:

   What|Removed |Added

 CC||khol...@switchinc.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

1 2 >

1 - 100 of 114 matches

Mail list logo