[Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532

Francois Charbonnier  changed:

   What|Removed |Added

 Status|In Discussion   |Signed Off

--- Comment #22 from Francois Charbonnier  ---
We won't (In reply to Jonathan Druart from comment #21)
> (In reply to Maxime Beaulieu from comment #20)
> > Indeed, the "guarantor" option could be added to the syspref.
> > If you agree to add this feature to bug 12802, we can close this one and/or
> > mark it as duplicate.
> 
> As you can see on bug 12802, I am not in charge of this bug anymore.
> And I would be very surprised that it will be included.

Then, we will stay focus on this patch. :)

I change the status to "signed off" since it was by Nick Clemens (see
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532#c15)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14577] Allow restriction of checkouts based on fines of guarantor/guarantee

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14577

Nicole C. Engard  changed:

   What|Removed |Added

 CC||neng...@gmail.com
 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14790] Link to OPAC view from within subscriptions, search and item editor

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14790

Nicole C. Engard  changed:

   What|Removed |Added

 CC||neng...@gmail.com
   Assignee|jwea...@bywatersolutions.co |k...@bywatersolutions.com
   |m   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15294] Move the C4::Branch related code to Koha::Libraries - part 1

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15294

--- Comment #12 from Jonathan Druart  
---
(In reply to Brendan Gallagher from comment #9)
> Didn't apply cleanly for me - can you rebase this Jonathan?  (ping me when
> you've rebased so I can test it and push it).
> 
> Thanks!

Trivial conflicts with bug 15373, bug 13517 and bug 13853 fixed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14199] Unify all organization code plugins

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14199

--- Comment #13 from Katrin Fischer  ---
Ah sorry, missed looking at the second patch - but I think some more frameworks
updated since (it-IT?)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14224] patron notes about item shown at check in

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224

--- Comment #6 from Jonathan Druart  
---
Additional note: the ajax part should be moved to svc/ and some of this code
put in a subroutine.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618

--- Comment #101 from Jonathan Druart  
---
Branch rebased against master.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618

--- Comment #100 from Jonathan Druart  
---
Branches rebased against master.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14199] Unify all organization code plugins

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14199

--- Comment #11 from Marcel de Rooy  ---
(In reply to Katrin Fischer from comment #10)
> Hi Marcel,
> 
> can you please fix the patches to work with the renamed files from bug 15181?

The big change that affects this patch, comes from:
b2c302440b7d33e8dc3923b645286a70111dd305 Bug 15097: Update MARC21 de-DE
frameworks to Update 21 (September 2015)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14199] Unify all organization code plugins

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14199

--- Comment #12 from Katrin Fischer  ---
How is that? Maybe it's bug 10963?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14199] Unify all organization code plugins

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14199

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #44020|0   |1
is obsolete||

--- Comment #14 from Marcel de Rooy  ---
Created attachment 46223
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46223=edit
Bug 14199: Modify webinstaller sql files for marc21_orgcode plugin

This patch updates the sql installer files for new installations.
Occurrences to the three plugins marc21_field_003, 040c and 040d are
replaced by marc21_orgcode.pl.
This has been generated by one sed statement.

Test plan:
[1] Run a new installation or run some of the changed sql files manually.
[2] Verify that marc21_orgcode is linked to fields previously linked to
the three old plugins.
[3] Do a git grep on the three plugin file names. No occurrences expected.

Signed-off-by: Marcel de Rooy 
Have tested the three english sql files:
authorities_normal_marc21.sql: 18 rows with marc21_orgcode (003 and 040a
for 9 auth codes)
marc21_framework_DEFAULT.sql: 1 row with marc21_orgcode (003) -- this patch
does not add them to 040c or 040d; no behavior change..
marc21_simple_bib_frameworks.sql: 8 rows (003 for 8 frameworks)

Signed-off-by: Bernardo Gonzalez Kriegel 

Signed-off-by: Marcel de Rooy 
The following files do no longer need an adjustment:
installer/data/mysql/de-DE/marcflavour/marc21/optional/marc21_simple_bib_frameworks.sql
installer/data/mysql/es-ES/marcflavour/marc21/optional/marc21_simple_bib_frameworks.sql
installer/data/mysql/it-IT/marcflavour/marc21/optional/marc21_simple_bib_frameworks.sql
For details, check Bug 15097: Update MARC21 de-DE frameworks to Update 21.
And similar reports for es-ES and it-IT.
Verified this change by installing de-DE in the webinstaller. The plugin for
field 003 was correctly set to marc21_orgcode.pl.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14060] Remove readonly on date inputs

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14060

--- Comment #17 from Jonathan Druart  
---
Created attachment 46224
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46224=edit
Bug 14060: Add support for dmydot

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14224] patron notes about item shown at check in

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224

--- Comment #5 from Jonathan Druart  
---
(In reply to Martin Stenberg from comment #4)
> Hi Jonathan,
> 
> Do you think it's worth adding a new subroutine GetIssue for this special
> case of GetIssues? GetIssues will still return an arrayref when called with
> issue_id, so the return type matches the plural "s" at least.

GetIssue would not return an array, but the matching issue.

> I'm doing an ajax request to minimize overhead when sending the request
> (i.e. no need to send note data for all issues when only one has been
> changed) and when recieving (i.e. no need to render a new template and send
> a whole document when only an "ok" or "nok" is needed). And as a bonus it
> allows the user to write a second note while the first one is beeing
> sent/processed to the server. 
> 
> To be honest I thought javascript was concidered a requirment for Koha. I'm
> using NoScript myself, and am always positivly surprised when a page works
> without having to enable javascript.
> 
> How about keeping the ajax-version and adding a fallback for browsers
> without javascript?

You can add 2 forms in the page, the one needing JS can be hidden with a css
rule.
When the page is loading, a JS code could hide one and display the other one.
I suppose it's the way to go.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14306] Show URL from MARC21 field 555$u in basket and detail

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14306

--- Comment #20 from Marc Véron  ---
Hi Marcel, a question about the test plan:
Do you expect the values (500$a, 555$a and a URL in 555$u) to be inserted into
the mails? Or should we test only that the mails still work?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15458] New: Marc21 leader 07 error in translation: "a- Serial component" part is not in format

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15458

Bug ID: 15458
   Summary: Marc21 leader 07 error in translation: "a- Serial
component" part is not in format
 Change sponsored?: ---
   Product: Koha
   Version: 3.20
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: translate.koha-community.org
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: paivi.knuuti...@jns.fi
QA Contact: testo...@bugs.koha-community.org

Created attachment 46225
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46225=edit
a- Monographic component part; b- Serial component part

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13774] Add the unique anchors of news as links in the RSS for news in Opac

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13774

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13774] Add the unique anchors of news as links in the RSS for news in Opac

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13774

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #46154|0   |1
is obsolete||

--- Comment #7 from Jonathan Druart  
---
Created attachment 46227
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46227=edit
Bug 13774 Add the unique anchors of news as links in the RSS for news in Opac

This patch adds the unique anchors of bugs from bug13729 into the rss stream of
the news in opac from bug7843.
Since 7843 is already passed QA and I'm new to Git and mess things up I chose
to post this update in a separate patch even if it's a tiny change.

The addition of a unique guid tag both help users and keeps validators happy.

Test plan:
* Make sure you are on master in order to get the anchors from bug 13729 (or
you could apply it manually).
* Apply bug 7843
* Apply this patch.
* Make shure you have enough news to make the Opac main page scroll.
* Find the RSS link at the bottom om opac main and klick it.
* Verify that the link displayed for each newsitem takes you to the right
anchor.

Followed test plan, works as expected. Signed-off-by: Marc Véron


Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15354] item types aren't showing in default hold policies

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15354

--- Comment #6 from Jonathan Druart  
---
(In reply to Jesse Weaver from comment #4)
> Minor whitespace issues:
> 
>  FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt
>FAIL   forbidden patterns
> forbidden pattern: tab char (line 188)
>SKIP   spelling
>OK tt_valid
>OK valid_template
> 
> (These aren't really your fault; I put a patch to fix all this mess on bug
> 15456 that you can rebase onto if you'd prefer.)

I think it should be fixed asap and not depend on something else to ease a
possible backport.

> More importantly, though, I noticed that while the item type descriptions
> now correctly show, and the list of rules is sorted by the translated
> description, the item type selection dropdown is not sorted by the
> translated description.

Good catch. I have fixed it.
Not that C4::Koha::GetItemTypes should be fixed for a global fix.
It will be easy to do on top of bug 14828.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14060] Remove readonly on date inputs

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14060

--- Comment #18 from Jonathan Druart  
---
(In reply to Marc Véron from comment #16)
> Hi Jonathan,
> 
> Sorry, I found following issues:
> 
> 1)
> Syspref dateformat = dmydot (01.10.2017) is not covered by the function
> is_valid_date
> 
> Symptom 1:
>   - Set syspref dateformat to dmydot, clear browser chache
>   - Try to add a manual restriction on moremember.pl
>   - manually enter 26.01.2017
>   - hit 'Add restriction'
> Result: restriction is added with empty date = indefinite restriction.
> 
> Symptom 2:
>   - manually enter 1.1.2018
>   - hit enter
>   - Message appears "Please enter valid date...", closes automatically after
> ca. 1 second
> Result: restriction is added with empty date = indefinite restriction.


Should be fixed with the last patch.

> 2)
> Software error in following cases
> 
> Case 1:
>   - Set syspref dateformat to dd/mm/, clear browser cache
>   - manually enter 1/10/2017
>   - hit 'Add restriction'
>   Result: Software error: The given date (1/10/2017) does not match the date
> format (metric) at /usr/share/kohaclone/Koha/DateUtils.pm line 153.
> 
> Case 2:
>   - Set syspref to -mm-dd
>   - manually enter 2017-2-2
>   - hit 'Add Restiction'
>   Result: Software error: The given date (2018-2-2) does not match the date
> format (iso) at /usr/share/kohaclone/Koha/DateUtils.pm line 153.
> 
> It seems that the timepicker's function parseDate accepts such dates.

I don't manage to force the leading zeros, suggestions are welcome.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14199] Unify all organization code plugins

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14199

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15443] Re-code RESERVESLIP as HOLD_SLIP

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15443

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #46153|0   |1
is obsolete||

--- Comment #4 from Jonathan Druart  
---
Created attachment 46226
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46226=edit
Bug 15443 - Re-code RESERVESLIP as HOLD_SLIP

It's a bit confusing to have RESERVESLIP named "Hold Slip", we should
finish the job and recode the slip.

Test Plan:
1) Apply this patch
2) Run updatedatabase.pl
3) Try printing a hold slip, you should note no difference
   from pre-patch behavior

Followed test plan. The slip is triggered if you want to check out
an item that is reserved / on hold for another patron. Works as expected.
Signed-off-by: Marc Véron 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15443] Re-code RESERVESLIP as HOLD_SLIP

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15443

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15354] item types aren't showing in default hold policies

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15354

--- Comment #5 from Jonathan Druart  
---
Created attachment 46222
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46222=edit
Bug 15354: Sort itemtypes by translated description everywhere on circ rules
admin page

It's better to cmp on lc.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15354] item types aren't showing in default hold policies

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15354

Jonathan Druart  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15442] Checkouts table will not display due to javascript error

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15442

--- Comment #7 from Jonathan Druart  
---
(In reply to Frédéric Demians from comment #6)
> This patch has been pushed to 3.20.x, will be in 3.20.8.

This patch is a bug fix for bug 15289, which is not in 3.20.x.
It was not needed for this branch but won't cause any regression.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14306] Show URL from MARC21 field 555$u in basket and detail

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14306

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

--- Comment #19 from Marcel de Rooy  ---
Rebased. Who adds a signoff?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14306] Show URL from MARC21 field 555$u in basket and detail

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14306

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #42013|0   |1
is obsolete||

--- Comment #18 from Marcel de Rooy  ---
Created attachment 46221
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46221=edit
Bug 14306: Remove call to GetMarcNotes from sendshelf

Just as mentioned in the first patch for sendbasket, I discovered that
the call of GetMarcNotes is not really used in sendshelf. The array is
passed to the template, but the template does not use it. (It uses the
information from GetBiblioData.)

Test plan:
[1] Send a list that includes a record with some notes (opac and staff).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12528] Enable staff to deny message setting access to patrons on the OPAC

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #46156|0   |1
is obsolete||

--- Comment #54 from Jonathan Druart  
---
Created attachment 46217
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46217=edit
Bug 12528: Bug 9254: Followup - Rename pref to EnhancedMessagingPreferencesOPAC

If the new pref is named EnhancedMessagingPreferencesOPAC, it will show
up adjacent to EnhancedMessagingPreferences

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12528] Enable staff to deny message setting access to patrons on the OPAC

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528

--- Comment #56 from Jonathan Druart  
---
Please keep authorship

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12528] Enable staff to deny message setting access to patrons on the OPAC

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528

--- Comment #55 from Jonathan Druart  
---
Created attachment 46218
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46218=edit
Bug 12528: redirect to 404 if at least 1 pref is off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15190] Bad utf8 decode to unapi and fixing blank screen error status

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15190

--- Comment #11 from Marcel de Rooy  ---
http://code4lib.org/files/unapi_revision_1-14.html

https://www.google.nl/url?sa=t=j==s=web=4=0ahUKEwjFvafUzPbJAhWCDhoKHarGDJUQFgg4MAM=https%3A%2F%2Fir.library.oregonstate.edu%2Fxmlui%2Fbitstream%2Fhandle%2F1957%2F2359%2Fintro-unapi-draftV15.doc%3Fsequence%3D8=AFQjCNEGxssbXiRQmzUPElGJkGQd1hjx5w=bv.110151844,d.bGQ

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15294] Move the C4::Branch related code to Koha::Libraries - part 1

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15294

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #45922|0   |1
is obsolete||

--- Comment #10 from Jonathan Druart  
---
Created attachment 46219
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46219=edit
Bug 15294: Koha::Libraries - Move existing Koha::Branch[es]

There was already 2 Koha::Branch[es] using Koha::Object[s] before.
For this new rewrite, it seems preferable to start with good basis and
name the new modules Koha::Library and Koha::Libraries.

Tested both patches together, works as expected.
Signed-off-by: Marc Véron 

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15294] Move the C4::Branch related code to Koha::Libraries - part 1

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15294

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #45923|0   |1
is obsolete||

--- Comment #11 from Jonathan Druart  
---
Created attachment 46220
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46220=edit
Bug 15294: Koha::Libraries - Rewrite the admin scripts

This patch rewrites the admin/branches.pl script to use the new modules
instead of C4::Branches.

Test plan:
1/ Create libraries using all the fields available
2/ Create groups of libraries
3/ Assign 1+ libraries to some groups
4/ Delete libraries and groups of libraries
You should not able to delete a library if items or patrons use it.
You should not able to delete a group of libraries if there are still
libraries using it.
5/ Update libraries and groups of libraries

Followed test plan, works as expected.
Signed-off-by: Marc Véron 

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15444] MARC21: Repeated 508 not correctly formatted (missing separator)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15444

Winona Salesky  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612

Nick Clemens  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15456] Fix tabs and inconsistent indentation in smart-rules.tt

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15456

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

  Attachment #46161|0   |1
is obsolete||

--- Comment #2 from Bernardo Gonzalez Kriegel  ---
Created attachment 46241
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46241=edit
[SIGNED-OFF] Bug 15456: Fix tabs and inconsistent indentation in smart-rules.tt

To verify patch, run `git diff -w HEAD^' and note that the only changes
shown are where [% IF %] statements are expanded/unexpanded onto
multiple lines to match the prevailing style.

Signed-off-by: Bernardo Gonzalez Kriegel 
Looks like refactoring :)
No regressions, no koha-qa errors

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15456] Fix tabs and inconsistent indentation in smart-rules.tt

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15456

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14748] REST API Testing framework

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14748

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

 CC||bgkrie...@gmail.com

--- Comment #5 from Bernardo Gonzalez Kriegel  ---
Hi, trying to test.
1) Need to install YAML::XS
2) Can't find Koha/ApiKeys.pm. Are there other dependencies for this bug?
Listed one (Bug 13799) is already in master.

Can't locate Koha/ApiKeys.pm in @INC (you may need to install the Koha::ApiKeys
module)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14749] Add API route to get top issues

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14749

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

 CC||bgkrie...@gmail.com

--- Comment #5 from Bernardo Gonzalez Kriegel  ---
Please, can you provide a test plan?
Don't know what to do with this.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14658] Split PatronSelfRegistrationBorrowerUnwantedField into two preferences for creating and editing

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14658

Jesse Weaver  changed:

   What|Removed |Added

  Attachment #46074|0   |1
is obsolete||

--- Comment #11 from Jesse Weaver  ---
Created attachment 46235
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46235=edit
Bug 14658 - Split PatronSelfRegistrationBorrowerUnwantedField into two
preferences for creating and editing

Test plan:
  1) Make sure there is at least one field in
PatronSelfRegistrationBorrowerUnwantedField.
  2) Apply patch, and update database.
  3) Check to make sure that the new system preference
 PatronSelfModificationBorrowerUnwantedField has the same value as
 PatronSelfRegistrationBorrowerUnwantedField.
  4) Verify that the same fields are hidden for self-registering a new
 borrower and edting a new one (both on the OPAC).
  5) Change PatronSelfModificationBorrowerUnwantedField, and verify that
 the two preferences correctly apply to editing vs. creating.

Signed-off-by: Michael Sauers 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14658] Split PatronSelfRegistrationBorrowerUnwantedField into two preferences for creating and editing

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14658

Jesse Weaver  changed:

   What|Removed |Added

  Attachment #46075|0   |1
is obsolete||

--- Comment #12 from Jesse Weaver  ---
Created attachment 46236
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46236=edit
Bug 14658 - (QA followup) make it easier to grep for these syspref names

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14658] Split PatronSelfRegistrationBorrowerUnwantedField into two preferences for creating and editing

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14658

Jesse Weaver  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14658] Split PatronSelfRegistrationBorrowerUnwantedField into two preferences for creating and editing

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14658

Jesse Weaver  changed:

   What|Removed |Added

  Attachment #46235|0   |1
is obsolete||

--- Comment #13 from Jesse Weaver  ---
Created attachment 46237
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46237=edit
Bug 14658 - Split PatronSelfRegistrationBorrowerUnwantedField into two
preferences for creating and editing

Test plan:
  1) Make sure there is at least one field in
PatronSelfRegistrationBorrowerUnwantedField.
  2) Apply patch, and update database.
  3) Check to make sure that the new system preference
 PatronSelfModificationBorrowerUnwantedField has the same value as
 PatronSelfRegistrationBorrowerUnwantedField.
  4) Verify that the same fields are hidden for self-registering a new
 borrower and edting a new one (both on the OPAC).
  5) Change PatronSelfModificationBorrowerUnwantedField, and verify that
 the two preferences correctly apply to editing vs. creating.

Signed-off-by: Michael Sauers 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15464] New: Fast Cataloguing gateway timeout

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15464

Bug ID: 15464
   Summary: Fast Cataloguing gateway timeout
 Change sponsored?: ---
   Product: Koha
   Version: 3.22
  Hardware: PC
OS: Linux
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Cataloging
  Assignee: gmcha...@gmail.com
  Reporter: patrick.fratc...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

Hello. And happy new year !

I am using Koha from debian packages v3.22.01 and i cannot add from fast
cataloguing since the last update to this version. It results in a gateway
timeout.

AH01220: Timeout waiting for output from CGI script
/usr/share/koha/intranet/cgi-bin/cataloguing/addbiblio.pl, referer:
http://.../cgi-bin/koha/cataloguing/addbiblio.pl?frameworkcode=FA

It's running on Ubuntu 14.04
apache2   2.4.7-1ubuntu4. i386
mysql-server  5.5.46-0ubuntu0 all

I don't know what's wrong since the last update.
Could you help me please ?

Thanks in advance

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14658] Split PatronSelfRegistrationBorrowerUnwantedField into two preferences for creating and editing

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14658

--- Comment #15 from Jesse Weaver  ---
Sorry for spam, accidentally obliterated Joubu's signoffs.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14658] Split PatronSelfRegistrationBorrowerUnwantedField into two preferences for creating and editing

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14658

Jesse Weaver  changed:

   What|Removed |Added

  Attachment #46236|0   |1
is obsolete||

--- Comment #14 from Jesse Weaver  ---
Created attachment 46238
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46238=edit
Bug 14658 - (QA followup) make it easier to grep for these syspref names

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612

Nick Clemens  changed:

   What|Removed |Added

  Attachment #41363|0   |1
is obsolete||
  Attachment #41364|0   |1
is obsolete||
  Attachment #41365|0   |1
is obsolete||

--- Comment #46 from Nick Clemens  ---
Created attachment 46239
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46239=edit
Bug 10612 - Add ability to delete patrons with batch patron deletion tool

This patch adds the ability to select a patron list for deletetion
when using the Batch patron deletion/anonymization tool. It also adds
buttons to the the patron lists table to access both the batch deletion
and batch modification directly from the lists view.

This is a squash of previous patches with a check added for issues
before deleting borrowers.

Test Plan:
1) Apply this patch
2) Create a list of patrons with the new Patron Lists feature
3) Try using the batch edit link form the lists table
4) Try using the batch delete link from the lists table

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15463] New: view_holdsqueue.tt uses a search for cardnumber instead of borrowernumber direct link

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15463

Bug ID: 15463
   Summary: view_holdsqueue.tt uses a search for cardnumber
instead of borrowernumber direct link
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: n...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

This line:


Should be:


or something similar

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15451] Move the CSV related code to Koha::CsvProfile[s]

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15451

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

 CC||bgkrie...@gmail.com

--- Comment #8 from Bernardo Gonzalez Kriegel  ---
Hi Jonathan and Happy new year :)

With all patches applied Tools > CSVprofiles fails with

Software error:
DBIx::Class::Schema::resultset(): resultset() expects a source name at
/home/bgkriegel/kohaclone/Koha/Objects.pm line 237

Test fails with similar error.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15444] MARC21: Repeated 508 not correctly formatted (missing separator)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15444

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |ASSIGNED

--- Comment #1 from Katrin Fischer  ---
Hi Winona - should there be a patch attached? I am resetting the status to NEW
until there is a patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15444] MARC21: Repeated 508 not correctly formatted (missing separator)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15444

Katrin Fischer  changed:

   What|Removed |Added

 Status|ASSIGNED|NEW

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7963] Parallel HTTP requests when checking URLs

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7963

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

--- Comment #24 from David Cook  ---
I'm thinking about using AnyEvent::HTTP for bug 10662, and I see that
libanyevent-http-perl is now a part of Debian Stable (Jessie) and Debian Old
Stable (Wheezy).

https://packages.debian.org/wheezy/libanyevent-http-perl

I wonder if we should now include it as a required rather than optional
dependency? 

For my purposes, I could probably just display a message telling users that
they need to install the library before they can use the feature, but it'd
probably be nice to have it already available.

That said, I haven't decided whether or not to use AnyEvent::HTTP quite yet.
Just one of a few options I'm pondering... but thought I'd mention how it's now
in Debian.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13774] Add the unique anchors of news as links in the RSS for news in Opac

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13774

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com
 Status|Passed QA   |Pushed to Master

--- Comment #8 from Kyle M Hall  ---
Pushed to master, thanks Viktor!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14571] using_https check for ssl connections doesn't work in some situations

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14571

Owen Leonard  changed:

   What|Removed |Added

  Attachment #41102|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15206] Show patron's age when filling date of birth in memberentry.pl

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15206

Alex Arnaud  changed:

   What|Removed |Added

 Status|In Discussion   |Needs Signoff

--- Comment #36 from Alex Arnaud  ---
The last patch replace all others. It removes showing of age in patron's detail
page (duplicate of bug 14763) and it remove the use of perl sub getAge() via
ajax call (bad performances).
Also it handles better plural forms.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13381] RDA: 245 field changes in XSLT

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13381

Ian Bays  changed:

   What|Removed |Added

 CC||ian.b...@ptfs-europe.com

--- Comment #36 from Ian Bays  ---
It seems that the change in the xslt to put span around subfields c and h has
removed the space that was generated between the subfields.
In koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl there is
an:
 
at line 125 in the otherwise clause that spaces out the subfields.  The two
that were singled out do not have this.  Adding them back in within the 
achieves the normal, desired spacing.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13381] RDA: 245 field changes in XSLT

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13381

--- Comment #37 from Katrin Fischer  ---
Hi Ian, can you please file this as a separate bug report linked to this one?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15443] Re-code RESERVESLIP as HOLD_SLIP

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15443

Kyle M Hall  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #5 from Kyle M Hall  ---
Pushed to master!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13572] Add onlyactives parameter to force_borrower_messaging_defaults script

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13572

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #7 from Jonathan Druart  
---
It would make more sense to have a --active[s] instead of --onlyactives, it
will allow to add another flag later.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15445] DateUtils.t fails on Jenkins due to server sluggishness

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15445

--- Comment #5 from Frédéric Demians  ---
(In reply to Jonathan Druart from comment #3)
> You are removing the usefulness of this test :)

I don't. When this test is supposed to 'normally' fail it take minutes to
calculate duration in the far futur (). So, changing the 'normal' duration
from 1s to 4s doesn't change the ability of this test to detect the fix
introduced by bug 13342 to the way Koha::DateUtils calculate - dates. 

> This test should not take more than 1s, do you know if it's new?

No. It seems to occur randomly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Patch doesn't apply

--- Comment #92 from Jonathan Druart  
---
CONFLICT (content): Merge conflict in Koha/Item.pm
CONFLICT (content): Merge conflict in Koha/Borrower.pm
CONFLICT (content): Merge conflict in Koha/Biblio.pm

Did you make the changes asked in comments 79 and 80?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15445] DateUtils.t fails on Jenkins due to server sluggishness

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15445

--- Comment #4 from Jonathan Druart  
---
A workaround would be to get the loadavg of the server at the moment the tests
run.
If it's > x and the test fails, then skip it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14751] Allow C4::Context->interface to be set to 'sip' or 'commandline'

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14751

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #3 from Jonathan Druart  
---
I don't find where interface is set to "sip" or "commandline".
Can we get a test plan please?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15374] Translatability: Fix issues on OPAC summary page

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15374

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
 Status|Signed Off  |Failed QA

--- Comment #12 from Jonathan Druart  
---
CONFLICT (content): Merge conflict in opac/opac-user.pl
CONFLICT (content): Merge conflict in
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15206] Show patron's age when filling date of birth in memberentry.pl

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15206

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #45597|0   |1
is obsolete||
  Attachment #45598|0   |1
is obsolete||
  Attachment #45599|0   |1
is obsolete||
  Attachment #45600|0   |1
is obsolete||
  Attachment #45601|0   |1
is obsolete||

--- Comment #35 from Alex Arnaud  ---
Created attachment 46228
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46228=edit
Bug 15206 - Show patron's age under date of birth in memberentry.pl

Test plan:

Create or edit a patron (members/memberentry.pl),
enter a date of birth (for a new patron),
patron'a age should be shown under

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14571] using_https check for ssl connections doesn't work in some situations

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14571

Owen Leonard  changed:

   What|Removed |Added

  Attachment #41100|0   |1
is obsolete||

--- Comment #5 from Owen Leonard  ---
Created attachment 46229
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46229=edit
[SIGNED-OFF] Bug 14571: using_https check for ssl connections doesn't work in
some situations

To test:

* turn on Amazon images for result and detail in the OPAC
* do a search that will result in an Amazon image being displayed on the
  result page
* inspect the cover image that is returned on the result page, it should
  be using a https://images-na... Amazon URL.
* click through to the detail for that item
* inspect the cover image that is returned on the detail page, it should
  be using a https://images-na... Amazon URL.

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14571] using_https check for ssl connections doesn't work in some situations

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14571

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14658] Split PatronSelfRegistrationBorrowerUnwantedField into two preferences for creating and editing

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14658

Kyle M Hall  changed:

   What|Removed |Added

 Status|Passed QA   |Patch doesn't apply
 CC||k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15460] New: Bug 13381 accidentally removed spaces after subfields c and h of 245

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15460

Bug ID: 15460
   Summary: Bug 13381 accidentally removed spaces after subfields
c and h of 245
 Change sponsored?: ---
   Product: Koha
   Version: 3.20
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: ian.b...@ptfs-europe.com
QA Contact: testo...@bugs.koha-community.org

It seems that the change in the xslt (bug 13381) to put span around subfields c
and h has removed the space that was generated between the subfields.
In koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl there is
an:
 
at line 125 in the otherwise clause that spaces out the subfields.  The two
that were singled out do not have this.  Adding them back in within the 
achieves the normal, desired spacing.

All four xsl files are affected:
koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl
koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetResults.xsl
koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl
koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetResults.xsl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15135] Remove Warning Subroutine HasOverdues redefined

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15135

--- Comment #12 from Jonathan Druart  
---
(In reply to Jonathan Druart from comment #11)

I should read before clicking the submit button...

> The current code tricks us using not exporting the IsDebarred method:

s/using//

> But I am pretty sure that introducing another workaround is a good idea.

is *not* a good idea

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15459] New: Allow to select 'Any library' for suggestions

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15459

Bug ID: 15459
   Summary: Allow to select 'Any library' for suggestions
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org

When AllowPurchaseSuggestionBranchChoice is set to allow, the patron can pick
the library the suggestion is for in the OPAC.

It would be nice if there was also an option "Any library" if the user doesn't
care which library the book is purchased for. Suggestions for any library would
be visible to all libraries in the staff interface until the status is switched
and a library is set.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11807] Add categorycode conversions to LDAP authentication.

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11807

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
 Status|Signed Off  |Failed QA

--- Comment #8 from Jonathan Druart  
---
It cannot work, C4::Dates has been removed from the codebase.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14571] using_https check for ssl connections doesn't work in some situations

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14571

--- Comment #7 from Owen Leonard  ---
Created attachment 46231
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46231=edit
[SIGNED-OFF] Bug 14571 - More switching of Amazon image source URL to https

modified:   modules/opac-opensearch.tt
   modified:   modules/opac-results-grouped.tt
   modified:   modules/opac-shelves.tt
   modified:   modules/opac-showreviews-rss.tt
   modified:   modules/opac-showreviews.tt

Basically, just inspect these places and make sure the Amazon images are
using https://images-na instead of http://images

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14571] using_https check for ssl connections doesn't work in some situations

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14571

Owen Leonard  changed:

   What|Removed |Added

  Attachment #41101|0   |1
is obsolete||

--- Comment #6 from Owen Leonard  ---
Created attachment 46230
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46230=edit
[SIGNED-OFF] Bug 14571: HTTPS Amazon images [follow up]

I found a couple more places where we should be using images-na, so I
updated them

* in the shelf browser
* in XISBN related works (honestly not sure how to test this one, but
  changing from the http:// url won't hurt anything.)

To test:

* Turn on the shelf browser, and browse for an item that has an amazon
  image,
* inspect it, it should be using https://images-na... url.

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6934] New report Cash Register Statistics

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #38 from Jonathan Druart  
---
QA comments:
1/ +function isNull(f,noalert) {
not used later

2/ The datepicker from/to should be done using the datepickerfrom and
datepickerto css class (see acqui/histsearch.tt for an example).

3/ Why do we have to fill a date?

4/ Ergonomic: the date interval is in a table with only 1 column and 1 row, it
could be better to move them in the same fieldset as the 2 dropdown lists.

5/ $fullreportname is only used once, not needed.

6/ +my $fromDate = dt_from_string;
and later
+beginDate=> dt_from_string($fromDate),
You are passing a DT to dt_from_string, a string is expected.

7/ Remove the unneeded commented lines ("^###")

8/ The csv file should be generated using Text::CSV::Encoded

9/ The column names should be retrieved using C4::Reports::Guided to get the
translated values

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8688] Add a recall button to the biblio record details page.

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8688

Jonathan Druart  changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=12426

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12426] Allow resending of emails from the notices tab in the patron account

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426

Jonathan Druart  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12426] Allow resending of emails from the notices tab in the patron account

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426

Jonathan Druart  changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=8688

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8688] Add a recall button to the biblio record details page.

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8688

--- Comment #32 from Jonathan Druart  
---
I have set the status to "Failed QA", but it's more a "In discussion".

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8688] Add a recall button to the biblio record details page.

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8688

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org,
   ||m.de.r...@rijksmuseum.nl,
   ||martin.renvoize@ptfs-europe
   ||.com
 Status|Signed Off  |Failed QA

--- Comment #31 from Jonathan Druart  
---
QA comments:
This is a very simple implementation, but could be considered as a first step.
I would like to get feedback from someone else (ccing some QA people).
For instance 1. there is no way to sent an sms instead of an email, 2. the
letter is generated even if the patron does not have an email address defined,
3. there is no way to know if a recall has already been generated

I don't understand the use case, why don't you use the overdue_notices script
instead?

Technical review:
1/ A variable items_checked_out is passed to the template but never used.
2/ ajax script should be moved to the svc/ directory
3/ The Recall button is display if the pref is set, then the user get an
unauthorised message if does not have the permission.
It would be easier not to display the button in this case... (and sent a 403 if
the script is called).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15135] Remove Warning Subroutine HasOverdues redefined

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15135

Jonathan Druart  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com,
   ||martin.renvoize@ptfs-europe
   ||.com
 Status|Signed Off  |In Discussion

--- Comment #11 from Jonathan Druart  
---
Marc,
The problem is that we have the same issue with IsDebarred.
The current code tricks us using not exporting the IsDebarred method:

  use Koha::Borrower::Debarments qw();

Either we continue to trick:

  -use C4::Members qw(HasOverdues);
  +use C4::Members qw();

Or we fix both.
But I am pretty sure that introducing another workaround is a good idea.

I would like to get Martin and Kyle POV here.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15445] DateUtils.t fails on Jenkins due to server sluggishness

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15445

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #3 from Jonathan Druart  
---
You are removing the usefulness of this test :)

This test should not take more than 1s, do you know if it's new?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15462] Unable to renew books via circ/renew.pl

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15462

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532

--- Comment #23 from Jonathan Druart  
---
(In reply to Francois Charbonnier from comment #22)
> > As you can see on bug 12802, I am not in charge of this bug anymore.
> > And I would be very surprised that it will be included.

I have absolutely no idea why I have written this last sentence.
I was not wanted to tell that the patches on bug 12802 won't be included/pushed
into master.
But certainly more that the new author/maintainer of bug 12802 won't write the
changes I have proposed on comment 19.

Sorry for the misunderstanding and please provide an answer.
If the solution seems better to you, please provide a followup on top of bug
12802.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7963] Parallel HTTP requests when checking URLs

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7963

--- Comment #25 from David Cook  ---
In hindsight, it looks like libanyevent-perl was available in Squeeze, so they
were halfway there already.

https://packages.debian.org/squeeze/libanyevent-perl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15451] Move the CSV related code to Koha::CsvProfile[s]

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15451

--- Comment #9 from Jonathan Druart  
---
(In reply to Bernardo Gonzalez Kriegel from comment #8)
> Hi Jonathan and Happy new year :)
> 
> With all patches applied Tools > CSVprofiles fails with
> 
> Software error:
> DBIx::Class::Schema::resultset(): resultset() expects a source name at
> /home/bgkriegel/kohaclone/Koha/Objects.pm line 237
> 
> Test fails with similar error.

Thanks for testing Bernardo, happy new year too ;)
You should apply bug 15446 before.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13906] TestObjectFactory(ies) for Koha objects. Enable easy Test object creation from HASHes or from preconfigured test groups.

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13906

M. Tompsett  changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com

--- Comment #22 from M. Tompsett  ---
*ping* Is this moving forward?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15343] Allow patrons to choose their own password on self registration.

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15343

Nicole C. Engard  changed:

   What|Removed |Added

 CC||neng...@gmail.com,
   ||nic...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15156] Get all Borrowers with pending/unpaid fines/accountlines

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156

M. Tompsett  changed:

   What|Removed |Added

 Status|Patch doesn't apply |BLOCKED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15170] Add 264 field to MARC21*DC.xsl

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15170

--- Comment #16 from Frédéric Demians  ---
This patch has been pushed to 3.20.x, will be in 3.20.8.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13022] Hardcoded limit causes records with more than 20 items to show inaccurate statuses

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13022

Frédéric Demians  changed:

   What|Removed |Added

 CC||frede...@tamil.fr

--- Comment #30 from Frédéric Demians  ---
This patch has been pushed to 3.20.x, will be in 3.20.8.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15086] Creators layout and template sql has warnings

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15086

M. Tompsett  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15304] Norwegian patron database: translatable strings added to all po files

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15304

--- Comment #18 from Frédéric Demians  ---
This patch has been pushed to 3.20.x, will be in 3.20.8.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14034] User logged out on refresh after Shibboleth authentication

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14034

Frédéric Demians  changed:

   What|Removed |Added

 CC||frede...@tamil.fr

--- Comment #8 from Frédéric Demians  ---
This patch has been pushed to 3.20.x, will be in 3.20.8.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15240] Performance issue running overdue_notices.pl

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15240

Jonathan Druart  changed:

   What|Removed |Added

 Status|In Discussion   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14659] Allow patrons to enter card number and patron category on OPAC registration page

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14659

Nicole C. Engard  changed:

   What|Removed |Added

 CC||neng...@gmail.com
 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15156] Get all Borrowers with pending/unpaid fines/accountlines

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156

M. Tompsett  changed:

   What|Removed |Added

  Attachment #44642|0   |1
is obsolete||

--- Comment #5 from M. Tompsett  ---
Created attachment 46232
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46232=edit
Bug 15156 - Get all Borrowers with pending/unpaid  fines/accountlines

A new API call.
Useful when doing group operations for Borrowers with fines.
Includes some test-coverage for C4::Accountlines since it was missing any.

NOTE: Renamed test file to t/db_dependent/Accounts/...

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15086] Creators layout and template sql has warnings

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15086

M. Tompsett  changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |mtomp...@hotmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15383] Opac: Authority details: Fix translation issues with tags

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15383

--- Comment #9 from Frédéric Demians  ---
This patch has been pushed to 3.20.x, will be in 3.20.8.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15444] MARC21: Repeated 508 not correctly formatted (missing separator)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15444

Winona Salesky  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/