date:20160202

[Koha-bugs] [Bug 15632] Move the messages related code to Koha::Patron::Messages

2016-02-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15632

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch

--- Comment #14 from Marc Véron  ---
I get an error in circ/del_message.pl line 26:

Can't locate Koha/Patrons/Messages.pm in @INC (@INC contains:
/usr/share/kohaclone /etc/perl /usr/local/lib/perl/5.14.2
/usr/local/share/perl/5.14.2 /usr/lib/perl5 /usr/share/perl5 /usr/lib/perl/5.14
/usr/share/perl/5.14 /usr/local/lib/site_perl .) at
/usr/share/kohaclone/circ/del_message.pl line 26.
BEGIN failed--compilation aborted at /usr/share/kohaclone/circ/del_message.pl
line 26.

The line should read 
use Koha::Patron::Messages; ( instead of use Koha::Patrons::Messages; )

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12426] Allow resending of emails from the notices tab in the patron account

2016-02-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426

M. Tompsett  changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com
 Status|Patch doesn't apply |Needs Signoff

--- Comment #37 from M. Tompsett  ---
Except for moving the $op line, this is a rebase, which applies. I have not
signed off. The sign off change is identical, so I left it marked as such.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12239] Errors loading script under https in chrome

2016-02-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12239

--- Comment #3 from Owen Leonard  ---
Is this bug still valid? I don't see any errors when I look at our OPAC in
Chrome.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15054] Get items from database instead of search engine in search results

2016-02-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15054

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

 Status|Needs Signoff   |In Discussion
 CC||hector.hecax...@gmail.com

--- Comment #4 from Héctor Eduardo Castro Avalos  ---
Hi Fridolin

Sorry but fail in Merge step, could you please rebase/fix, I think IMHO your
patch is a good solution. The problem you describe is very annoying.

Applying: Bug 15054 - Get items from database instead of search engine in
search results
Using index info to reconstruct a base tree...
Falling back to patching base and 3-way merge...
Auto-merging C4/Search.pm
CONFLICT (content): Merge conflict in C4/Search.pm
Failed to merge in the changes.
Patch failed at 0001 Bug 15054 - Get items from database instead of search
engine in search results
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15416] Warns on Guided Reports page

2016-02-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15416

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

 CC||hector.hecax...@gmail.com
 Status|Needs Signoff   |In Discussion

--- Comment #2 from Héctor Eduardo Castro Avalos  ---
Hi Aleisha

I can't reproduce the issue, could you please confirm?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14523] Google jackets being blocked when OPAC using HTTPS

2016-02-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14523

Owen Leonard  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com

--- Comment #13 from Owen Leonard  ---
*** Bug 13527 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13527] Mixed content warnings in results and detail with Google images on https

2016-02-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13527

Owen Leonard  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #1 from Owen Leonard  ---


*** This bug has been marked as a duplicate of bug 14523 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12426] Allow resending of emails from the notices tab in the patron account

2016-02-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426

M. Tompsett  changed:

   What|Removed |Added

  Attachment #42418|0   |1
is obsolete||

--- Comment #34 from M. Tompsett  ---
Created attachment 47563
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47563=edit
[Signed-off] Bug 12426: Allow resending of messages from the notices tab in the
patron account

This patch adds a link 'Resend' under a notice in 'failed' status
in the Patron's Notices tab.

By clicking the link, we will request notices.pl with parameter
"resendnotice=X" where X is message_id. In notices.pl,
we then check whether the given message is actually in 'failed'
status. If so, we use the C4::Letters::ResendMessage(123) to
change the status of the message into 'pending'. This way it
will be processed again by the cronjob process_message_queue.pl.

To test, find/create a Patron that has failed notices in message_queue:
1. Enable EnchancedMessagingPreferences system preference
2. Go to Patrons -> Notices
3. In the Notice column, click the title of the failed message
4. Observe that there is nothing for resending the failed message
5. Apply patch.
6. Reload Notices page and repeat step 3
7. Observe that there is now a link "Resend" in the Status-column
8. Click Resend
9. Observe that the message gets into 'pending' status

Works as expected.
Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12426] Allow resending of emails from the notices tab in the patron account

2016-02-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426

M. Tompsett  changed:

   What|Removed |Added

  Attachment #42621|0   |1
is obsolete||

--- Comment #36 from M. Tompsett  ---
Created attachment 47565
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47565=edit
Bug 12426: Allow resend for sent messages

This patch allows to resend both sent and failed messages.

With messages in 'sent' status, we have to be careful not to accidentally send
sent messages again. With the previous patch using GET request, this was likely
to happen because of browser storing the GET parameters.

This patch changes request method from GET to POST. Instead of a simple link,
we now have a form element.

In notices.pl we redirect back to notices.pl, because with POST there is a risk
of resending the message accidentally by form resubmission at refresh.

To test, find/create a Patron that has sent or failed notices in message_queue:
1. Enable EnchancedMessagingPreferences system preference
2. Go to Patrons -> Notices
3. In the Notice column, click the title of the sent or failed message
4. Observe that there is nothing for resending the sent or failed message
5. Apply the patches.
6. Reload Notices page and repeat step 3
7. Observe that there is now a link "Resend" in the Status-column
8. Click Resend
9. Observe that the message gets into 'pending' status

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12426] Allow resending of emails from the notices tab in the patron account

2016-02-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426

M. Tompsett  changed:

   What|Removed |Added

  Attachment #42512|0   |1
is obsolete||

--- Comment #35 from M. Tompsett  ---
Created attachment 47564
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47564=edit
Bug 12426: Simplify the code adding a new subroutine GetMessage

The C4::Letters module does not have a GetMessage subroutine, which
could be quite useful.
This patch adds it and simplifies the code added by the previous patch.
It also adds a few tests and fixes POD typos.

Note that ResendNotice only resends failed messages. This will avoid to
resend already sent messages (using an url from the browser history for
instance).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15551] checked out items not showing on returns.pl

2016-02-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15551

Karl Holten  changed:

   What|Removed |Added

 CC||khol...@switchinc.org

--- Comment #2 from Karl Holten  ---
(In reply to Katrin Fischer from comment #1)
> Hm, I am not sure about this - the new change should only avoid showing
> items which actually haven't been checked in - like items not checked out
> when performing the check in.
> 
> Also - I don't think it ever showed other items checked out by the patron?
> Maybe they just followed the link from the checked in item? That should
> still work, if the patch you are referring didn't cause a bug.

Our institutions preferred being able to see other items checked out by the
same patron. Two institutions reported this issue to us after our update to
3.20, so it was definitely something that was present and that staff were using
that went away.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13420] sorting on volume number is not sorting right

2016-02-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13420

Karl Holten  changed:

   What|Removed |Added

 CC||khol...@switchinc.org

--- Comment #6 from Karl Holten  ---
Created attachment 47566
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47566=edit
Screenshot of bug in context in the staff view

While the duplicate bug has been marked as fixed, I am not entirely clear on if
that bug will address this issue, so I will update this ticket. Attached is a
screenshot of the bug in context in the staff view. The OPAC view sorts in a
similar way.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15584] Staff client list errors are incorrectly styled

2016-02-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15584

--- Comment #18 from Owen Leonard  ---
At this time I guess my preferences is for the "error" instances to be
corrected. 

It would be nice to find a good example of where all three messages ('message',
'alert', and a new 'error' type) could be shown to be useful in one workflow.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15399] MARCXML records larger than 1 MB (1048576 bytes) are not searchable.

2016-02-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15399

Karl Holten  changed:

   What|Removed |Added

 CC||khol...@switchinc.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15551] checked out items not showing on returns.pl

2016-02-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15551

--- Comment #3 from Katrin Fischer  ---
I am really confused by this - I am pretty sure the table below the checkin
input field only showed items scanned. Could they mean the link back to the
patron record by chance, that was accessible from lines in the table?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15531] Add support for standing orders

2016-02-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15531

Jesse Weaver  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15415] Warn when creating new printer profile for patron card creator

2016-02-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15415

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

  Attachment #46760|0   |1
is obsolete||

--- Comment #2 from Héctor Eduardo Castro Avalos  ---
Created attachment 47567
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47567=edit
[SIGNED-OFF]Bug 15415: Warn when creating a new print profile

This warn is hard-coded in Profile.pm

sub get_attr {
my $self = shift;
if (_check_params(@_) eq 1) {
return -1;
}
my ($attr) = @_;
if (exists($self->{$attr})) {
return $self->{$attr};
}
else {
warn sprintf('%s is currently undefined.', $attr); <-- THIS LINE
return -1;
}
}

So I have removed this line because I don't think it's really necessary.

To test:
1) Go to Tools -> Patron Card Creator -> New printer profile
2) Notice warn
3) Apply patch
4) Refresh page
5) Confirm warn is gone and page still works as expected

Signed-off-by: Hector Castro 
Warn is gone and working correctly

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15415] Warn when creating new printer profile for patron card creator

2016-02-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15415

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15416] Warns on Guided Reports page

2016-02-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15416

--- Comment #4 from Héctor Eduardo Castro Avalos  ---
(In reply to Aleisha Amohia from comment #3)
> This is still valid for me on version 3.23 of Koha

Pardon me I didn't know that i needed to consult the log files.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15551] checked out items not showing on returns.pl

2016-02-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15551

J Schmidt  changed:

   What|Removed |Added

 CC||jschm...@switchinc.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15531] Add support for standing orders

2016-02-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15531

--- Comment #4 from Jesse Weaver  ---
Created attachment 47569
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47569=edit
Bug 15531: (followup) Use a quantity of 1, not null, for standing orders

This seems to cause fewer problems with the existing acquisitions code.

Test plan is unchanged.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8133] hourly loans doesn't know when library closed

2016-02-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8133

J Schmidt  changed:

   What|Removed |Added

 CC||jschm...@switchinc.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14539] Introduction to castToObject(), aka. make a Koha::Object from various input types

2016-02-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14539

M. Tompsett  changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com
   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=15473
 Status|Needs Signoff   |Patch doesn't apply

--- Comment #8 from M. Tompsett  ---
bug 15473 conflicts with this.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11211] Move calculation code out of C4::Calendar

2016-02-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11211

J Schmidt  changed:

   What|Removed |Added

 CC||jschm...@switchinc.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15473] Koha::Objects->find should find if the key is an empty string

2016-02-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15473

M. Tompsett  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=14539

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15416] Warns on Guided Reports page

2016-02-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15416

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

  Attachment #46761|0   |1
is obsolete||

--- Comment #5 from Héctor Eduardo Castro Avalos  ---
Created attachment 47568
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47568=edit
[SIGNED-OFF]Bug 15416: Warns on guided_reports.pl

Initialising $phase variable to be '' if not defined.

To test:
1) Go to Reports -> Guided Reports Wizard
2) Notice warns
3) Apply patch
4) Refresh page
5) Confirm warns are gone and page still works as it should

Signed-off-by: Hector Castro 
Warns are gone. Page still works as expected

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15416] Warns on Guided Reports page

2016-02-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15416

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

 Status|In Discussion   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15303] Letsencrypt option for Debian package installations

2016-02-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15303

Mike  changed:

   What|Removed |Added

 CC||blac...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3144] anti-spam for opac-suggestions

2016-02-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3144

--- Comment #31 from Christopher Vella  ---
Potentially the bot could be trying input forms at random, or more advanced and
only reading through the visible elements of the page.

Rather than go down the positive captcha route yet. We could attempt to make
this negcaptcha smarter. One idea could be to IP ban any user who submits
content to that form (I don't see any reason why a normal user would). We could
also have the field name randomise per instance.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15416] Warns on Guided Reports page

2016-02-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15416

--- Comment #3 from Aleisha Amohia  ---
This is still valid for me on version 3.23 of Koha

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3144] anti-spam for opac-suggestions

2016-02-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3144

--- Comment #28 from David Cook  ---
I think that this was working for a time, but it appears that some bots may
have wised up...

I'm noticing spam coming through once again, which I assume means that someone
is having their bot ignore the "negcap" field or fields that are located off
screen. Both would be easy to do.

We're going to look at blocking some IP addresses to start, but this one is a
distributed spamming of the system so that will likely only be partially
successful. 

I have a couple curl commands that I could use to easily spam
opac-suggestions.pl...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3144] anti-spam for opac-suggestions

2016-02-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3144

--- Comment #30 from David Cook  ---
Ideally, it wouldn't always be the third word. It would sometimes be the first
word or the last word of the paragraph. Something like that...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3144] anti-spam for opac-suggestions

2016-02-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3144

--- Comment #29 from David Cook  ---
You know... we could do a text-based positive captcha. That should be
accessible.

Something like... "write the third word from the previous paragraph in the
following box". 

A human should be able to understand that instruction, and it should require 
fairly sophisticated natural language processing for a bot to figure out.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13795] Delete unused columns from statistics table.

2016-02-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13795

M. Tompsett  changed:

   What|Removed |Added

  Attachment #36578|0   |1
is obsolete||

--- Comment #6 from M. Tompsett  ---
Created attachment 47555
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47555=edit
Bug 13795: Delete unused columns from statistics table

The following 4 fields are never used in the statistics table:

associatedborrower
other
proccode
usercode

This patch removes them.

To test:

* check the database and make sure columns are gone

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13795] Delete unused columns from statistics table.

2016-02-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13795

M. Tompsett  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13795] Delete unused columns from statistics table.

2016-02-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13795

M. Tompsett  changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com

--- Comment #7 from M. Tompsett  ---
I made it apply, but Bernardo Gonzalez Kriegel raises a valid problem in
comment #5.

$ git grep associatedborrower
-- There is mention of it in installer/data/mysql/backfill_statistics.pl
Is this script used at all? Obviously people aren't going to need it after
upgrading from 2.x to 3.x versions. Perhaps safe to remove? Perhaps
backfill_statistics.pl needs a rewrite?

other is used in C4::Circulation::AddIssue related to SIP mode.

In C4/Accounts.pm and C4/Circulation.pm (only places to use UpdateStats), the
following fields are used:
branch
type
amount
other
itemnumber
itemtype
borrowernumber
ccode
accountno

schema says that usercode and associatedborrower is unused.
Looking at C4/Stats.pm it becomes painfully clear (painful, because they
shouldn't have renamed the field like that) that accountno is proccode. I
wonder if people are expecting it to be longer than varchar(4).

I would resubmit this modified with:
1) Just usercode and associatedborrower removed
2) an atomic update instead of a updatedatabase.pl
(https://wiki.koha-community.org/wiki/Database_updates)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14272] Allow OPAC to show a single news item

2016-02-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272

M. Tompsett  changed:

   What|Removed |Added

  Attachment #45846|0   |1
is obsolete||

--- Comment #14 from M. Tompsett  ---
Created attachment 47556
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47556=edit
Bug 14272: Show single news item (tests)

Updates tests to match the modified NewsChannels module.

Sponsored-by: Halland County Library

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14209] opacserialdefaulttab ignored with bibs having items <1 or >50

2016-02-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14209

Alex Arnaud  changed:

   What|Removed |Added

 CC||alex.arn...@biblibre.com
   Assignee|oleon...@myacpl.org |alex.arn...@biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15697] Unnecessary comma between title and subtitle on opac-detail.pl

2016-02-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15697

Nick Clemens  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15697] Unnecessary comma between title and subtitle on opac-detail.pl

2016-02-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15697

--- Comment #5 from Nick Clemens  ---
Created attachment 47554
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47554=edit
Bug 15697 - [QA Followup] Apply change to NORMARC

This patch switches from UNLESS MARC21 to IF UNIMARC - this way changes
apply to MARC21 and NORMARC and UNIMARC remains unaffected

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15697] Unnecessary comma between title and subtitle on opac-detail.pl

2016-02-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15697

--- Comment #6 from Nick Clemens  ---
(In reply to Jonathan Druart from comment #4)
> What about NORMARC? I guess it micmics MARC21.

I wasn't certain so erred on leaving as is.  Updated patch to use IF UNIMARC
instead of UNLESS MARC21

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14272] Allow OPAC to show a single news item

2016-02-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272

M. Tompsett  changed:

   What|Removed |Added

  Attachment #45937|0   |1
is obsolete||

--- Comment #16 from M. Tompsett  ---
Created attachment 47558
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47558=edit
Bug 14272: Show single news item (OPAC)

This change makes the news shown on opac-main-pl have
clickable headings which shows just that news item in isolation.
This is to allow further patches that adds commentary functions.

Sponsored-By: Halland County Library

Test plan:
  * Apply this patch.
  * Go to OPAC main, you should see multiple news items by default.
* If you do not see any, go to Staff interface and add a few.
  * Each nees item heading should be clickable.
  * When clicked only that item should be shown.
* When 'news_id' is present, only a single news item should show.
* The breadcrumb should say 'News item' after 'Home'.

Updates:
  * Renamed URL parameter and local variables with 'news_' prefix.
  * Fixed Search-And-Replace error; 'news_news_id' => 'news_id'
  * Added breadcrumb for viewing single news item.
  * Updated OPAC to use new GetNewsToDisplay parameters
  * Fixed template formatting and calling of GetNewsToDisplay

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14272] Allow OPAC to show a single news item

2016-02-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272

M. Tompsett  changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com

--- Comment #17 from M. Tompsett  ---
I did not sign this off. I rebased it to apply cleanly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14272] Allow OPAC to show a single news item

2016-02-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272

M. Tompsett  changed:

   What|Removed |Added

  Attachment #45935|0   |1
is obsolete||

--- Comment #15 from M. Tompsett  ---
Created attachment 47557
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47557=edit
Bug 14272: Show single news item (backend)

Updates:
  * Date formatting added to get_opac_new()
  * Proper filtering by way of GetNewsToDisplay

Sponsored-by: Halland County Library

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15666] Automatic_renewals.pl fails when OverduesBlockRenewing and RestrictionBlockRenewing are set to "block"

2016-02-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15666

--- Comment #8 from Holger Meißner  ---
(In reply to bondiurbano from comment #2)
> "No renewal before" is an optional setting so it could be absent in the
> rule.

Yes, but bug 14101 introduced a fallback. If the setting is absent (undef) then
automatic renewal works just like "No renewal before" was zero. Do you get
different results with undef and zero??

> Automatic_renewals.pl must be executed BEFORE the item date_due
> expires.
I think this cannot be done with a cron job running just once or a few times
per day. Due date might be any time of the day, especially with hourly loans.

> Otherwise it will be a due item and so OverduesBlockRenewing will
> block it.
Yes, but I suppose that is exactly what should happen, if the patron has both
automatic and manual loans and some of the manual loans are overdue?

But I see the problem! It should renew if ONLY automatic renewals are overdue!
So maybe that's the solution. Check if all overdue loans are automatic, then
override the block?

I need to think about it some more, but does think this makes sense? :)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15717] Installer: Step 3 has showing

2016-02-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15717

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||13618


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618
[Bug 13618] Prevent XSS in the Staff Client and the OPAC
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15717] Installer: Step 3 has showing

2016-02-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15717

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC

2016-02-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||15717


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15717
[Bug 15717] Installer: Step 3 has  showing
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15717] Installer: Step 3 has showing

2016-02-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15717

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #47529|0   |1
is obsolete||

--- Comment #5 from Jonathan Druart  
---
Created attachment 47536
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47536=edit
Bug 15717: Installer: Step 3 has  showing

The step to install optional/mandatory things is broken with
many 's instead of line breaks.

TEST PLAN
-
1) Back up database
2) Drop database
3) Create empty database
4) Run web installer
   -- Notice that step 3 has ugly 's at the last
  part of step 3.
5) Apply patch
6) Repeat steps 2-4
   -- Notice the 's are now nice line breaks.
   NOTE: No promises of perfect positioning!
7) Run koha qa test tools.

Signed-off-by: Nick Clemens 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15343] Allow patrons to choose their own password on self registration.

2016-02-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15343

--- Comment #24 from Jonathan Druart  
---
(In reply to Nick Clemens from comment #23)
> (In reply to Jonathan Druart from comment #22)
> > > +return ( $borrowernumber, $borrower{'password'} );
> > 
> > Why do you return the password?
> 
> This was already done before my change. 

Ha yes, I misread the diff!
Fix not needed :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15431] svc/checkouts dies due to undefined variable (13024 merge problem)

2016-02-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15431

--- Comment #10 from Frédéric Demians  ---
(In reply to Sophie MEYNIEUX from comment #9)
> In 3.20.7

Try upgrading to 3.20.8, and confirm it solves the issue.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15206] Show patron's age when filling date of birth in memberentry.pl

2016-02-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15206

--- Comment #52 from Jonathan Druart  
---
Created attachment 47541
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47541=edit
Bug 15206 - Make CalculateAge a reusable function

Signed-off-by: Owen Leonard 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15206] Show patron's age when filling date of birth in memberentry.pl

2016-02-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15206

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15358] merge.pl does not populate values to merge

2016-02-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358

Julian Maurice  changed:

   What|Removed |Added

  Attachment #47537|0   |1
is obsolete||
  Attachment #47538|0   |1
is obsolete||
  Attachment #47539|0   |1
is obsolete||

--- Comment #41 from Julian Maurice  ---
Created attachment 47543
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47543=edit
Bug 15358: Fix authorities merge

Bug 8064 (Merge several biblio records) change some code used in both
biblios and authorities merge tool without updating the authorities
merge tool.
This patch fixes that.

Signed-off-by: Nick Clemens 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14523] Google jackets being blocked when OPAC using HTTPS

2016-02-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14523

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #47511|0   |1
is obsolete||

--- Comment #12 from Jonathan Druart  
---
Created attachment 47544
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47544=edit
Bug 14523 - Google jackets being blocked when OPAC using HTTPS

This patch changes the Google jackets URL to use HTTPS instead of HTTP.

Test Plan:
1) Enable Google Jackets
2) Ensure the Koha OPAC instance is configued to use HTTPS
3) Confirm Google jackets display correctly.

Signed-off-by: Frédéric Demians 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15358] merge.pl does not populate values to merge

2016-02-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358

--- Comment #43 from Julian Maurice  ---
(In reply to Jonathan Druart from comment #40)
> Julian, I have found a bug when testing:
> I a non-repeatable subfield is added when a repeatable field is added, there
> is no warning.
> If I click on the subfield, I get "The subfield is non-repeatable and
> already exists in the destination record. Therefore, you cannot add it." and
> it is not added to the destination record.

I think it's normal behaviour if I understand correctly. The subfield is not
repeatable in its own field, but here you add a new field in the destination
record, so it's valid.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14523] Google jackets being blocked when OPAC using HTTPS

2016-02-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14523

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15721] New: About page does not display Apache version

2016-02-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15721

Bug ID: 15721
   Summary: About page does not display Apache version
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: About
  Assignee: neng...@gmail.com
  Reporter: ve...@veron.ch
QA Contact: testo...@bugs.koha-community.org

The About page does not display the Apache version.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15713] Restart zebra when rotating logfiles

2016-02-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15713

Marc Véron  changed:

   What|Removed |Added

  Attachment #47504|0   |1
is obsolete||

--- Comment #3 from Marc Véron  ---
Created attachment 47535
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47535=edit
Bug 15713: Restart zebra when rotating logfiles

Somehow, it may happen that Zebra keeps writing to the old rotated logfile
with extension .log.1. I must add that although I saw that happen (a new
log was created and was empty, while Zebra kept writing to log.1 for weeks),
I cannot reproduce it every time.

By stopping the zebra server in prerotate and starting it again in
postrotate, this should not happen at all. In practice, this implies that
your Zebra server is restarted once a week.

Note: The existing sharedscripts directive makes sure that these actions
are not executed for all individual logfiles but once for all matching
logfiles (even when running multiple instances).

Test plan:
[1] Apply the change in koha-common.logrotate to the file
/etc/logrotate.d/koha-common.
[2] Run logrotate -f /etc/logrotate.conf (forcing a logrotate).
[3] Check in zebra-error.log that your zebra server was stopped
('killed by signal 15').
[4] Verify that your Zebra server runs (read: has been restarted).
(Do a search..)

Signed-off-by: Marcel de Rooy 
Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15713] Restart zebra when rotating logfiles

2016-02-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15713

Marc Véron  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||ve...@veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15406] Very SLOW OAI server performance

2016-02-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15406

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #2 from Jonathan Druart  
---
(In reply to Frédéric Demians from comment #1)
> Bug 15106 contains the solution.

Must be a typo, bug 15106 is about batch patron modification.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12357] Enhancements to RIS and BibTeX exporting

2016-02-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12357

--- Comment #52 from Jonathan Druart  
---
(In reply to M. Tompsett from comment #51)
> Comment on attachment 39803 [details] [review]
> Bug 12357 - Enhancements to RIS and BibTeX exporting
> 
> Review of attachment 39803 [details] [review]:
> -
> 
> ::: C4/Ris.pm
> @@ +1016,4 @@
> > ## return unaltered if already utf-8
> > return @_;
> >  }
> > +elsif (my $uniout eq "t") {
> 
> This runs with warns, but where is uniout defined?!

On the same line...
Please open a new bug report.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15431] svc/checkouts dies due to undefined variable (13024 merge problem)

2016-02-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15431

--- Comment #9 from Sophie MEYNIEUX  ---
In 3.20.7

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15358] merge.pl does not populate values to merge

2016-02-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358

--- Comment #42 from Julian Maurice  ---
All 3 patches squashed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15699] Opac: Course reserves instructors should be in form "Surname, Firstname" for sorting purposes

2016-02-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15699

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15699] Opac: Course reserves instructors should be in form "Surname, Firstname" for sorting purposes

2016-02-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15699

--- Comment #12 from Jonathan Druart  
---
Created attachment 47546
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47546=edit
Bug 15699 [QA followup] - Only display firstname if present

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15699] Opac: Course reserves instructors should be in form "Surname, Firstname" for sorting purposes

2016-02-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15699

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #47423|0   |1
is obsolete||
  Attachment #47513|0   |1
is obsolete||

--- Comment #11 from Jonathan Druart  
---
Created attachment 47545
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47545=edit
Bug 15699 - Course reserves instructors should be in form "Surname, Firstname"
for sorting purposes

This patch changes the order of the name fields and adds a span class around
each in case of library wanting to customize further

To test:
1 - Enable course reserves
2 - Add some courses with instrcutors
3 - Note they are of form "Firstname Surname"
4 - Apply patch
5 - Note the change
6 - Note span tags
7 - Note you can hide firstname by adding to intranet user js:
$(".instr_firstname, instr_separator").hide();

Sing-off note: This patch displays the names as advertised on
cgi-bin/koha/opac-course-reserves.pl Sorting
the names would need some more actions but seems not to be intended by this
patch.
Signed-off-by: Marc Véron 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15721] About page does not display Apache version

2016-02-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15721

Marc Véron  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15471] Add column settings and filters to Holds queue table

2016-02-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15471

Jonathan Druart  changed:

   What|Removed |Added

 Status|BLOCKED |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15108] OAI-PMH provider improvements

2016-02-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108

Frédéric Demians  changed:

   What|Removed |Added

 Blocks||15406


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15406
[Bug 15406] Very SLOW OAI server performance
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15406] Very SLOW OAI server performance

2016-02-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15406

Frédéric Demians  changed:

   What|Removed |Added

 Depends on|15106   |15108

--- Comment #3 from Frédéric Demians  ---
Yes, sorry. It's bug 15108.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15106
[Bug 15106] Batch Patron Modification Performance Improvement
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108
[Bug 15108] OAI-PMH provider improvements
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15106] Batch Patron Modification Performance Improvement

2016-02-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15106

Frédéric Demians  changed:

   What|Removed |Added

 Blocks|15406   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15406
[Bug 15406] Very SLOW OAI server performance
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12357] Enhancements to RIS and BibTeX exporting

2016-02-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12357

--- Comment #53 from Jonathan Druart  
---
Note that uniout is an argument of the original script
http://sourceforge.net/p/refdb/code/HEAD/tree/refdb/trunk/scripts/marc2ris.in

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15358] merge.pl does not populate values to merge

2016-02-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #47508|0   |1
is obsolete||
  Attachment #47509|0   |1
is obsolete||
  Attachment #47510|0   |1
is obsolete||

--- Comment #37 from Jonathan Druart  
---
Created attachment 47537
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47537=edit
Bug 15358: Attempt to fix authorities merge

This is a quick fix, and I'm quite sure there are other bugs hiding...
but I managed to display both authority in tabs and merge them.

The result preview requires at least one click on checkboxes to show up,
I haven't looked at this issue yet.

Signed-off-by: Nick Clemens 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15358] merge.pl does not populate values to merge

2016-02-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358

--- Comment #38 from Jonathan Druart  
---
Created attachment 47538
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47538=edit
Bug 15358: Build result preview after page load

Signed-off-by: Nick Clemens 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15358] merge.pl does not populate values to merge

2016-02-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358

--- Comment #39 from Jonathan Druart  
---
Created attachment 47539
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47539=edit
Bug 15358: Authorities merge - submit only result record

This patch removes parts of form that should not be submitted just
before submit. The same is done on biblio merge.

Signed-off-by: Nick Clemens 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15358] merge.pl does not populate values to merge

2016-02-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15358] merge.pl does not populate values to merge

2016-02-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358

--- Comment #40 from Jonathan Druart  
---
Julian, I have found a bug when testing:
I a non-repeatable subfield is added when a repeatable field is added, there is
no warning.
If I click on the subfield, I get "The subfield is non-repeatable and already
exists in the destination record. Therefore, you cannot add it." and it is not
added to the destination record.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15206] Show patron's age when filling date of birth in memberentry.pl

2016-02-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15206

--- Comment #53 from Jonathan Druart  
---
Created attachment 47542
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47542=edit
Bug 15206: Make strings translatable

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15206] Show patron's age when filling date of birth in memberentry.pl

2016-02-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15206

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #47505|0   |1
is obsolete||
  Attachment #47506|0   |1
is obsolete||

--- Comment #51 from Jonathan Druart  
---
Created attachment 47540
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47540=edit
Bug 15206 - Show patron's age under date of birth in memberentry.pl

Test plan:

Create or edit a patron (members/memberentry.pl), enter a date of birth
(for a new patron), patron'a age should be shown under

Signed-off-by: Owen Leonard 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15206] Show patron's age when filling date of birth in memberentry.pl

2016-02-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15206

--- Comment #54 from Jonathan Druart  
---
Maybe "display_age" is a better function name than "write_age", I let the RM
cut.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15694] Date/time-last-modified not searchable

2016-02-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15694

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #5 from Jonathan Druart  
---
Nicole,
I think the files biblio-koha-indexdefs.xml and biblio-zebra-indexdefs.xsl need
to be updated when a zebra index is added/deleted/modified.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15721] About page does not display Apache version

2016-02-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15721

--- Comment #1 from Marc Véron  ---
Created attachment 47547
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47547=edit
Bug 15721: About page does not display Apache version

This patch changes about.pl to get version information from
C4::Context where applicable and fixes missing display of
the Apache version e.g. for Apache/2.2.22

To test:
- Without patch, open about page in staff client
- Remember contents of tab 'Server information'
  (e.g. make a screenshot)
- Apply patch
- Verify, that the About page displays the same information
  as before rsp. additionally displays Apache version if
  it was missing without patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15724] New: Add possibility to export notice in marc format in z39.50 results

2016-02-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15724

Bug ID: 15724
   Summary: Add possibility to export notice in marc format in
z39.50 results
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Z39.50 / SRU / OpenSearch Servers
  Assignee: gmcha...@gmail.com
  Reporter: marjorie.barry-v...@ccsr.qc.ca
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

Hi,

Preview marc of a notice exist in a Z39.50 list result, but it would be great
to have a way to export file in format marc.

This file can then be processed in MarcEdit.

Regards,

Marjorie

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15721] About page does not display Apache version

2016-02-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15721

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

  Attachment #47547|0   |1
is obsolete||

--- Comment #3 from Héctor Eduardo Castro Avalos  ---
Created attachment 47562
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47562=edit
[SIGNED-OFF]Bug 15721: About page does not display Apache version

This patch changes about.pl to get version information from
C4::Context where applicable and fixes missing display of
the Apache version e.g. for Apache/2.2.22

To test:
- Without patch, open about page in staff client
- Remember contents of tab 'Server information'
  (e.g. make a screenshot)
- Apply patch
- Verify, that the About page displays the same information
  as before rsp. additionally displays Apache version if
  it was missing without patch.

Signed-off-by: Hector Castro 
Works as described

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15721] About page does not display Apache version

2016-02-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15721

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15694] Date/time-last-modified not searchable

2016-02-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15694

--- Comment #7 from Héctor Eduardo Castro Avalos  ---
(In reply to Jonathan Druart from comment #5)
> Nicole,
> I think the files biblio-koha-indexdefs.xml and biblio-zebra-indexdefs.xsl
> need to be updated when a zebra index is added/deleted/modified.

Hi Jonathan and Nicole

This really works without update the files. My question is why?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7728] Fixing subscription endddate inconsistency: should be empty when the subscription is running

2016-02-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7728

--- Comment #12 from Jonathan Druart  
---
Comment on attachment 47303
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47303
BZ 7728 adding unit test

Review of attachment 47303:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=7728=47303)
-

1/ Should not we update the histenddate if it has been set?
2/ Could we imagine fixing existing DB entries?

::: t/db_dependent/Serials/ReNewSubscription.t
@@ +40,5 @@
> +
> +#my $mContext = new Test::MockModule('C4::Context');
> +#$mContext->mock( 'userenv', sub {
> +#return { branch => $library->{branchcode} };
> +#});

Useless commented lines, please remove.

@@ +94,5 @@
> +# Actual testing starts here!
> +
> +# Renew the subscription and check that enddate has not been set
> +ReNewSubscription($subscription->{subscriptionid},'',"2016-01-01",'','',12,'');
> +my @history = Koha::Subscription::Histories->search( {subscriptionid => 
> $subscription->{subscriptionid} } );

use
  Koha::Subscription::Histories->find( $subscription->{subscriptionid} )
when you already have the primary key.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15697] Unnecessary comma between title and subtitle on opac-detail.pl

2016-02-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15697

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #4 from Jonathan Druart  
---
What about NORMARC? I guess it micmics MARC21.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15108] OAI-PMH provider improvements

2016-02-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #12 from Jonathan Druart  
---
Olli, Could you provide a rebased patch?
It seems that bug 15406 would need the second patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15713] Restart zebra when rotating logfiles

2016-02-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15713

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15666] Automatic_renewals.pl fails when OverduesBlockRenewing and RestrictionBlockRenewing are set to "block"

2016-02-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15666

--- Comment #9 from bondiurbano  ---
(In reply to Holger Meißner from comment #8)
> (In reply to bondiurbano from comment #2)
> > "No renewal before" is an optional setting so it could be absent in the
> > rule.
> 
> Yes, but bug 14101 introduced a fallback. If the setting is absent (undef)
> then automatic renewal works just like "No renewal before" was zero. Do you
> get different results with undef and zero??
> 
> > Automatic_renewals.pl must be executed BEFORE the item date_due
> > expires.
> I think this cannot be done with a cron job running just once or a few times
> per day. Due date might be any time of the day, especially with hourly loans.
> 
> > Otherwise it will be a due item and so OverduesBlockRenewing will
> > block it.
> Yes, but I suppose that is exactly what should happen, if the patron has
> both automatic and manual loans and some of the manual loans are overdue?
> 
> But I see the problem! It should renew if ONLY automatic renewals are
> overdue! So maybe that's the solution. Check if all overdue loans are
> automatic, then override the block?
> 
> I need to think about it some more, but does think this makes sense? :)

Hi Holger! I will check the fallback. Give a couple of days...I think that the
fallback definition is right. But I will check. Meanwhile you can see my
attached PDF.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15358] merge.pl does not populate values to merge

2016-02-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358

--- Comment #44 from Jonathan Druart  
---
(In reply to Julian Maurice from comment #43)
> (In reply to Jonathan Druart from comment #40)
> > Julian, I have found a bug when testing:
> > I a non-repeatable subfield is added when a repeatable field is added, there
> > is no warning.
> > If I click on the subfield, I get "The subfield is non-repeatable and
> > already exists in the destination record. Therefore, you cannot add it." and
> > it is not added to the destination record.
> 
> I think it's normal behaviour if I understand correctly. The subfield is not
> repeatable in its own field, but here you add a new field in the destination
> record, so it's valid.

Indeed!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15108] OAI-PMH provider improvements

2016-02-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108

--- Comment #13 from Frédéric Demians  ---
(In reply to Jonathan Druart from comment #12)
> Olli, Could you provide a rebased patch?
> It seems that bug 15406 would need the second patch.

And this part of the 1st patch:

diff --git a/installer/data/mysql/kohastructure.sql
b/installer/data/mysql/kohastructure.sql
index e9d836c..c2eec84 100644
--- a/installer/data/mysql/kohastructure.sql
+++ b/installer/data/mysql/kohastructure.sql
@@ -209,6 +209,7 @@ CREATE TABLE `biblioitems` ( -- information related to
bibliographic records in
   KEY `isbn` (`isbn`(255)),
   KEY `issn` (`issn`(255)),
   KEY `publishercode` (`publishercode`),
+  KEY `timestamp_bibno` (`timestamp`, `biblionumber`),
   CONSTRAINT `biblioitems_ibfk_1` FOREIGN KEY (`biblionumber`) REFERENCES
`biblio` (`biblionumber`) ON DELETE CASCADE ON UPDATE CASCADE
 ) ENGINE=InnoDB DEFAULT CHARSET=utf8;

@@ -866,7 +867,8 @@ CREATE TABLE `deletedbiblioitems` ( -- information about
bibliographic records t
   KEY `bibnoidx` (`biblionumber`),
   KEY `itemtype_idx` (`itemtype`),
   KEY `isbn` (`isbn`(255)),
-  KEY `publishercode` (`publishercode`)
+  KEY `publishercode` (`publishercode`),
+  KEY `timestamp_bibno` (`timestamp`, `biblionumber`)
 ) ENGINE=InnoDB DEFAULT CHARSET=utf8;

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15713] Restart zebra when rotating logfiles

2016-02-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15713

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #47535|0   |1
is obsolete||

--- Comment #4 from Jonathan Druart  
---
Created attachment 47548
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47548=edit
Bug 15713: Restart zebra when rotating logfiles

Somehow, it may happen that Zebra keeps writing to the old rotated logfile
with extension .log.1. I must add that although I saw that happen (a new
log was created and was empty, while Zebra kept writing to log.1 for weeks),
I cannot reproduce it every time.

By stopping the zebra server in prerotate and starting it again in
postrotate, this should not happen at all. In practice, this implies that
your Zebra server is restarted once a week.

Note: The existing sharedscripts directive makes sure that these actions
are not executed for all individual logfiles but once for all matching
logfiles (even when running multiple instances).

Test plan:
[1] Apply the change in koha-common.logrotate to the file
/etc/logrotate.d/koha-common.
[2] Run logrotate -f /etc/logrotate.conf (forcing a logrotate).
[3] Check in zebra-error.log that your zebra server was stopped
('killed by signal 15').
[4] Verify that your Zebra server runs (read: has been restarted).
(Do a search..)

Signed-off-by: Marcel de Rooy 
Signed-off-by: Marc Véron 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14244] viewing a bib item's circ history requires circulation permissions

2016-02-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14244

Jonathan Druart  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7728] Fixing subscription endddate inconsistency: should be empty when the subscription is running

2016-02-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7728

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA
Version|3.8 |master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record

2016-02-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565

Alex Arnaud  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron

2016-02-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply

--- Comment #57 from Owen Leonard  ---
Applying: Bug 14695 - Warn librarian if max_holds_per_record is reached
fatal: sha1 information is lacking or useless
(koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt).
Repository lacks necessary blobs to fall back on 3-way merge.
Cannot fall back to three-way merge.
Patch failed at 0001 Bug 14695 - Warn librarian if max_holds_per_record is
reached

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14770] Use $9 in GetMarcSeries to build search link

2016-02-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14770

Julian Maurice  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

1 2 >

1 - 100 of 133 matches

Mail list logo