[Koha-bugs] [Bug 12236] Collapse unused message transport types in notice editor

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12236

M. Tompsett  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|Patch doesn't apply |RESOLVED
 CC||mtomp...@hotmail.com

--- Comment #4 from M. Tompsett  ---
I believe upon further inspection that:

 $( "#transport-types" ).accordion({ collapsible: true, active:false, animate:
200 });

accomplishes what the point of this patch was. Marking as resolved/fixed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12236] Collapse unused message transport types in notice editor

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12236

--- Comment #3 from M. Tompsett  ---
Comment on attachment 28200
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28200
Collapse unused message transport types in notice editor

Review of attachment 28200:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=12236=28200)
-

::: koha-tmpl/intranet-tmpl/prog/en/modules/tools/letter.tt
@@ +344,4 @@
>[% letter.message_transport_type %]
>  [% END %]
>
> +   1) %] class="noshow_mtt noshow_mtt_[% letter.message_transport_type%]"[% END 
> %]>

https://wiki.koha-community.org/wiki/Coding_Guidelines#HTML1:_Template_Toolkit_markup_inside_HTML

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15503] Grab Item Information from Order Files

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503

--- Comment #7 from Benjamin Daeuber  ---
Created attachment 54660
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54660=edit
Test Case of 2 bibs, 1 item on one bib, 3 on the other

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15503] Grab Item Information from Order Files

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503

Benjamin Daeuber  changed:

   What|Removed |Added

 CC||bdaeu...@cityoffargo.com

--- Comment #6 from Benjamin Daeuber  ---
> You will have to select a budget for each item before being able to save.

What do you mean by this? If the fund is in the file, it should auto-populate,
correct?

Tested:

1. Staged a MARC file with two bibs, one with 1 item and the other with 3.
2. Added the staged file to the basket.
3. At this point everything looks good, other than the fact that I needed to
manually select the fund. Price populates, I see two records, one with one item
and the other with 3.
4. After saving, two bib records are created, but they both have 4 items. It
was like it added all the items to both records.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16573] Web installer fails to load structure and sample data on MySQL 5.7

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16573

--- Comment #26 from M. Tompsett  ---
Comment on attachment 54658
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54658
Bug 16573: (RM followup) Update DBIx schema and prevent upgrade issues

Review of attachment 54658:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=16573=54658)
-

::: installer/data/mysql/updatedatabase.pl
@@ +12789,4 @@
>  $DBversion = '16.06.00.012';
>  if ( CheckVersion($DBversion) ) {
>  $dbh->do(q{
> +ALTER IGNORE TABLE virtualshelves MODIFY COLUMN created_on DATETIME 
> not NULL;

"As of MySQL 5.7.4, the IGNORE clause for ALTER TABLE is removed and its use
produces an error."
(https://dev.mysql.com/doc/refman/5.7/en/alter-table.html)
I'd leave out the ignore.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17143] Popup Notification for decreaseloanhighholds preference

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17143

Christopher Brannon  changed:

   What|Removed |Added

 Depends on||16387

--- Comment #2 from Christopher Brannon  ---
I just added some information to bug 16387 that may be related to this.

1178 my $issuedate = DateTime->now( time_zone => C4::Context->tz() );
1179 
1180 my $calendar = Koha::Calendar->new( branchcode => $branch );
1181 
1182 my $itype =
1183   ( C4::Context->preference('item-level_itypes') )
1184   ? $biblio->{'itype'}
1185   : $biblio->{'itemtype'};
1186 
1187 my $orig_due = C4::Circulation::CalcDateDue( $issuedate, $itype,
$branch, $borrower );
1188 
1189 my $decreaseLoanHighHoldsDuration =
C4::Context->preference('decreaseLoanHighHoldsDuration');
1190 
1191 my $reduced_datedue = $calendar->addDate( $issuedate,
$decreaseLoanHighHoldsDuration );
1192 
1193 if ( DateTime->compare( $reduced_datedue, $orig_due ) == -1 ) {
1194 $return_data->{exceeded} = 1;
1195 $return_data->{duration} = $decreaseLoanHighHoldsDuration;
1196 $return_data->{due_date} = $reduced_datedue;

I think because the time index in $reduced_datedue isn't the same as the time
index in $orig_due, the two will never be equal, unless checked out at the time
indicated in the $org_due.  Therefore, if the original due date is in 14 days,
and reduced due date is set to 14 days, the two are not going to match because
of the time index.

I'm thinking that if the other bug is resolved, this will be as well.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16387
[Bug 16387] Incorrect loan period calculation when using  decreaseLoanHighHolds
feature
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16387] Incorrect loan period calculation when using decreaseLoanHighHolds feature

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16387

Christopher Brannon  changed:

   What|Removed |Added

 Blocks||17143


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17143
[Bug 17143] Popup Notification for decreaseloanhighholds preference
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16387] Incorrect loan period calculation when using decreaseLoanHighHolds feature

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16387

Christopher Brannon  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=17143

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17143] Popup Notification for decreaseloanhighholds preference

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17143

Christopher Brannon  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=16387

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8030] Change pickup location of a hold from patron record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8030

--- Comment #12 from Nick Clemens  ---
(In reply to Katrin Fischer from comment #10)
> Nick, can you please take a look at the questions and comments? Thx!
All set

I did an admittedly rough job of inserting the icon, some feedback from Owen on
placement and preferred icon would be apreciated

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16387] Incorrect loan period calculation when using decreaseLoanHighHolds feature

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16387

Christopher Brannon  changed:

   What|Removed |Added

   Severity|normal  |major

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8030] Change pickup location of a hold from patron record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8030

Nick Clemens  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8030] Change pickup location of a hold from patron record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8030

--- Comment #11 from Nick Clemens  ---
Created attachment 54659
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54659=edit
Bug 8030 (QA Followup) - Use REST api and provide feedback

Use REST API
If cancelled return to previous selection
If fail return to previous selection
Use fa spinning icon while waiting
Disable select while waiting

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16387] Incorrect loan period calculation when using decreaseLoanHighHolds feature

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16387

Christopher Brannon  changed:

   What|Removed |Added

 CC||cbran...@cdalibrary.org

--- Comment #1 from Christopher Brannon  ---
I was just noticing this.  I talked with Nick Clemens, and he thinks it might
be this in circulation.pm:

1178 my $issuedate = DateTime->now( time_zone => C4::Context->tz() );
1179 
1180 my $calendar = Koha::Calendar->new( branchcode => $branch );
1181 
1182 my $itype =
1183   ( C4::Context->preference('item-level_itypes') )
1184   ? $biblio->{'itype'}
1185   : $biblio->{'itemtype'};
1186 
1187 my $orig_due = C4::Circulation::CalcDateDue( $issuedate, $itype,
$branch, $borrower );
1188 
1189 my $decreaseLoanHighHoldsDuration =
C4::Context->preference('decreaseLoanHighHoldsDuration');
1190 
1191 my $reduced_datedue = $calendar->addDate( $issuedate,
$decreaseLoanHighHoldsDuration );
1192 
1193 if ( DateTime->compare( $reduced_datedue, $orig_due ) == -1 ) {
1194 $return_data->{exceeded} = 1;
1195 $return_data->{duration} = $decreaseLoanHighHoldsDuration;
1196 $return_data->{due_date} = $reduced_datedue;

Line 1196 is assigning the value in $reduced_datedue.
Line 1191 is basing the value of $reduced_datedue from $issuedate
Line 1178 is assigning $issuedate a value based on now(the time at this very
moment).

So somehow we need $reduced_datedue to use the same time as $orig_due, but only
adjust the date, and not reference $issuedate.

I would do this, but I barely understand what I am looking at, thanks to Nick's
help.

Hope this helps.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16874] Making serials collections actions buttons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16874

Aliki Pavlidou  changed:

   What|Removed |Added

 CC||pavlidoual...@gmail.com

--- Comment #7 from Aliki Pavlidou  ---
Hello,

I tried to test this patch with the sandbox system, but it does not work.

I've got this log in message in which the test/test credentials don't apply.

"Welcome to the Koha web installer

Before we begin, please verify you have the correct credentials to continue.
Please log in with the username and password given to you by your systems
administrator and located in your koha-conf.xml configuration file.

Please enter your username and password:"


Kind regards

Aliki

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16573] Web installer fails to load structure and sample data on MySQL 5.7

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16573

--- Comment #25 from Tomás Cohen Arazi  ---
Back to the RM queue.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16573] Web installer fails to load structure and sample data on MySQL 5.7

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16573

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16573] Web installer fails to load structure and sample data on MySQL 5.7

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16573

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16573] Web installer fails to load structure and sample data on MySQL 5.7

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16573

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16573] Web installer fails to load structure and sample data on MySQL 5.7

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16573

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Pushed to Stable|ASSIGNED
 CC||tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16573] Web installer fails to load structure and sample data on MySQL 5.7

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16573

--- Comment #24 from Tomás Cohen Arazi  ---
Created attachment 54658
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54658=edit
Bug 16573: (RM followup) Update DBIx schema and prevent upgrade issues

This patch updates the DBIx::Class schema files, and introduces the IGNORE
option to the updatedatabase.pl's ALTER TABLE to prevent issues for users
upgrading from 3.22 onwards.

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17153] Logging in during a search navigates to account page instead of back to search results

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17153

Lee Jamison  changed:

   What|Removed |Added

 CC|ldjami...@marywood.edu  |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17153] Logging in during a search navigates to account page instead of back to search results

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17153

Lee Jamison  changed:

   What|Removed |Added

 CC||ldjami...@marywood.edu

--- Comment #1 from Lee Jamison  ---
Created attachment 54657
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54657=edit
Forces redirect to search results after logging in on opac-search.pl

To test:
- Perform a catalog or EDS search
- Login from opac-search.pl
- Without the patch, the page should redirect to opac-user.pl
- Log out
- Apply patch
- Perform a search again
- Login again from opac-search.pl
- The page should redirect back to search results

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17153] New: Logging in during a search navigates to account page instead of back to search results

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17153

Bug ID: 17153
   Summary: Logging in during a search navigates to account page
instead of back to search results
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: ldjami...@marywood.edu
QA Contact: testo...@bugs.koha-community.org

When a patron logs in the OPAC on any page, except opac-reserve.pl, they are
always redirected to opac-user.pl.

This can prove to be problematic in regards to tasks such as navigating search
results (including both catalog and EDS searches if the EDS plugin is
installed), adding tags, adding comments, or nearly any other action which
requires a patron to login.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4249] Can't place multiple holds if one record has no holdable items (staff)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4249

Owen Leonard  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #3 from Owen Leonard  ---


*** This bug has been marked as a duplicate of bug 7703 ***

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7703] Don' t block bulk hold action on search results if some items can' t be placed on hold

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7703

--- Comment #34 from Owen Leonard  ---
*** Bug 4249 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11979] Display correct not for loan status description on course reserves

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11979

--- Comment #6 from Owen Leonard  ---
It turns out the template /tries/ to show the correct not for loan status, but
the notforloan data which is passed to item-status.inc is incomplete. Compare
the item data pulled by GetBiblioFromItemNumber in Biblio.pm (from which the
course reserves information comes) to GetItemsInfo in Items.pm (from which the
item data comes for pages like opac-detail.pl).

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16579] Use separate memcached namespace for caching koha-conf.xml

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16579

--- Comment #42 from Jacek Ablewicz  ---
(In reply to Kyle M Hall from comment #41)
> (In reply to Nick Clemens from comment #40)
> > I haven't fully tested, but initial read through and applying looks good.
> > This makes it much easier to get memcached functioning with plack and is a
> > good improvement
> 
> I agree! This is a huge improvement and greatly simplifies the setup.
> 
> Jacek, what do you think?

I think generally it's good, and certainly good enough for the 'promotion' from
"In discussion" to "Needs sign-off". I have some doubts re/ certain parts
(mostly about an introduction of that 'namespace' thingy to the Koha caching
system - not entirely sure if it's strictly necessary, and - in case it is - if
doing it in this particular way is the best way possible).

But it's more the matter of opinion / personal preferences (and/or my lack of
understanding why it's needed to be done, and/or why in that way) than any real
concerns.

So far I haven't spotted any regressions in this patch set - looks like there
may be some (= most likely very-very slight) performance hits involved for the
caching system, because of the 'namespaces' introduction, but IMO sorting out
inconsistencies of the memcached config / setups problems in the systemic way
is _much_ more important then that.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11979] Display correct not for loan status description on course reserves

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11979

Owen Leonard  changed:

   What|Removed |Added

Summary|items status not for loan   |Display correct not for
   |on course reserve   |loan status description on
   ||course reserves

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11529] Add subtitle field to biblio table

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529

--- Comment #3 from Owen Leonard  ---
Adding a single field to the biblio table seems much too limiting. Would you
combine all the 245 subfields > 'a' into one string and store it that way?

Is anyone thinking about a better way to do this?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17050] Accessing the REST API through Plack kicks the session out

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17050

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||tomasco...@gmail.com
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17050] Accessing the REST API through Plack kicks the session out

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17050

--- Comment #13 from Tomás Cohen Arazi  ---
Created attachment 54656
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54656=edit
Bug 17050: (QA followup) Use Mojo::Transaction to get the remote address

While the original patch fixes the issue, reading at Mojolicious source code,
revealed
that Mojo::Transaction already has proper processing for detecting the remote
address:

sub remote_address {
  my $self = shift;

  return $self->original_remote_address(@_) if @_;
  return $self->original_remote_address unless $self->req->reverse_proxy;

  # Reverse proxy
  return ($self->req->headers->header('X-Forwarded-For') // '') =~ /([^,\s]+)$/
? $1
: $self->original_remote_address;
}

Without this patch, if there's a request without HTTP_X_FORWARDED_FOR, then the
remote
address would be empty. Such would be the case of a dev/standard setup without
Plack.

This patch makes Koha::REST::V1::startup use tx->remote_address instead of
dealing with the
headers on its own.

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17050] Accessing the REST API through Plack kicks the session out

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17050

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #54054|0   |1
is obsolete||

--- Comment #12 from Tomás Cohen Arazi  ---
Created attachment 54655
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54655=edit
Bug 17050: Do not kick the session out when accessing the REST API

Mojolicious does not set $ENV{REMOTE_ADDR} (neither $ENV{HTTP_*}) as
it may share ENV between different requests.
Fortunately for us, Plack does not!

This is a dirty patch to fix this issue but it seems that there is not
lot of solutions. It adds a remote_addr parameter to
C4::Auth::check_cookie_authin order to send it from
Koha::Rest::V1::startup reading the headers sent by Mojolicious.

Test plan:
Hit /cgi-bin/koha/mainpage.pl
Hit /api/v1/patrons/42
Hit /cgi-bin/koha/mainpage.pl

With this patch applied, everything will be fine and you won't be
logged out.

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8173] Have Full title (245) to always display in system

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8173

Owen Leonard  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |INVALID

--- Comment #1 from Owen Leonard  ---
This issue has been fixed in many places via the 'Keywords to MARC mapping'
system and via bug reports for individual cases. I think specific reports are
better than this broad one, so I'm closing it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14576] Allow arbitrary automatic update of location on checkin

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576

Nick Clemens  changed:

   What|Removed |Added

  Attachment #54648|0   |1
is obsolete||

--- Comment #36 from Nick Clemens  ---
Created attachment 54654
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54654=edit
Bug 14576 - (QA Followup) Remove other instances of
ReturnToShelvingCart/InprocessingToShelvingCart

This patch eliminates ReturnToShelvingCart and
InProcessingToShelvingCart,
Deletes Returns.t (it only tested those two
prefs and new tests are in issue.t)

Remaining instances found by:
git grep "ReturnToShelvingCart\|InProcessingToShelvingCart" | grep -v
translator | wc -l
are db update files and release notes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17135] Fine for the previous overdue may get overwritten by the next one

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17135

Barton Chittenden  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=15675

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15675] Add issue_id column to accountlines and use it for updating fines

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15675

Barton Chittenden  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=17135

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15164] Allow editing of the invoice number after initial saving

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15164

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15164] Allow editing of the invoice number after initial saving

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15164

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #54568|0   |1
is obsolete||

--- Comment #5 from Jonathan Druart  
---
Created attachment 54653
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54653=edit
Bug 15164 - Allow editing of the invoice number after initial saving

When you notice a typo in your invoice number after finishing with the
receiving process, the only way to correct it right now is in the
database - or by undoing all the steps and starting over.

It would be nice if the invoice number could be edited.

Test Plan:
1) Apply this patch
2) Browse to acqui/invoice.pl for an invoice
3) Note the new "Invoice number" field contains the existing invoice
4) Alter the invoice number
5) Save the invoice
6) Note the invoice number has been updated
7) Edit the invoice again
8) Attempt to save the invoice with an empty invoice number field
9) Note that you cannot save the invoice without having an invoice number

Followed test plan, works as expected.
Signed-off-by: Marc Véron 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14520] Prevent to override the existing currency code.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14520

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch

--- Comment #9 from Marc Véron  ---
Created attachment 54652
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54652=edit
It is no longer possible to add currency with same code

See attachment. Issue seems to be fixed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13171] Check box for email is missing for hold notifications in patron messaging preferences.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13171

Barton Chittenden  changed:

   What|Removed |Added

 Resolution|--- |LATER
 Status|NEW |RESOLVED

--- Comment #9 from Barton Chittenden  ---
(In reply to Marc Véron from comment #8)
> Is this bug still valid?

I don't think that I've seen it happen since 3.16 -- given that we have a
work-around in the form of the inserts into message_transports, I'm happy to
close; we can re-open later if necessary.

I suspect that the original issue happened due to a cascading delete on the
'letter' table.

I'm closing the bug, if it pops up again, we can always re-open.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14520] Prevent to override the existing currency code.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14520

Marc Véron  changed:

   What|Removed |Added

 Resolution|--- |WORKSFORME
 Status|ASSIGNED|RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16809] Silence CGI param warnings from C4::Biblio:: TransformHtmlToMarc

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16809

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #54536|0   |1
is obsolete||

--- Comment #7 from Jonathan Druart  
---
Created attachment 54650
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54650=edit
Bug 16809: Follow-up for scalarizing biblionumber

Still resolves another multi_param warning.

Test plan:
Look at your logs before and after this patch when saving a biblio
record (you may have to start plack again).
If your biblionumber is mapped to 999c, you should no longer have a warn
about line 2563 (disclaimer: line numbers are subject to change).

Signed-off-by: Marcel de Rooy 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16809] Silence CGI param warnings from C4::Biblio:: TransformHtmlToMarc

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16809

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13501] Allow autocompletion on drop-down lists

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13501

--- Comment #40 from Jonathan Druart  
---
(In reply to Julian Maurice from comment #37)
> Created attachment 54637 [details] [review]
> Bug 13501: Highlight select2 control if field is required and value is
> missing

Are you sure you want to remove select2.min.css?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14612] Overdue notice triggers should show branchname instead of branchcode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14612

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #54582|0   |1
is obsolete||

--- Comment #3 from Jonathan Druart  
---
Created attachment 54651
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54651=edit
Bug 14612 - Overdue notice triggers should show branchname instead of
branchcode

This patch adds the Branches template plugin to the overdue notice
triggers template so that the library name can be shown instead of the
branchcode.

Also changed: Updated page title to match the name used in tools menus.

To test, apply the patch and go to Tools -> Overdue notice/status
triggers.

- Select a library.
- When the page reloads, the 'Defining overdue actions for...' and
  'Rules for overdue actions: ' headings should show the library name
  instead of the branchcode.

Signed-off-by: Marc Véron 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14612] Overdue notice triggers should show branchname instead of branchcode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14612

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16809] Silence CGI param warnings from C4::Biblio:: TransformHtmlToMarc

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16809

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #54535|0   |1
is obsolete||

--- Comment #6 from Jonathan Druart  
---
Created attachment 54649
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54649=edit
Bug 16809: Silence authority warnings C4::Biblio::TransformHtmlToMarc

Most of the floodiness is caused by accessing the cgi parameters
in a context which is hard to determine. By purposefully saving
the value to a scalar variable and using the variable, the issue
disappears, and it will likely be a tiny tad faster as variable
access is faster than multiple function calls.

TEST PLAN
-
 1) Back up your intranet error log
-- for example:
   cp ~/koha-dev/var/log/koha-error-log ~/koha-error-log.backup
 2) Blank your intranet error log
-- for example:
   echo > ~/koha-dev/var/log/koha-error-log
 3) Log into your staff client
 4) Click 'Authorities'
 5) Click 'New from Z39.50'
 5) Type 'Seuss' into 'Name (any):' and press enter
 6) Click 'Import' beside the first link
 7) Click 'Save'
 8) Check your koha-error-log
-- floody!
 9) Apply patch
10) repeat steps 2-8
-- blank!
11) restore your intranet error log
   -- for example:
  mv ~/koha-error-log.backup ~/koha-dev/var/log/koha-error-log
12) run koha qa test tools

Signed-off-by: Marcel de Rooy 
Tested with addbiblio.pl. I would have preferred the scalar option in terms
of simpler code, but this works too.

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13552] Add debar option to batch patron modification

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13552

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17104] svc/checkin does not use UpdateNotForLoanStatusOnCheckin

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17104

Nick Clemens  changed:

   What|Removed |Added

 Resolution|--- |INVALID
 Status|NEW |RESOLVED

--- Comment #1 from Nick Clemens  ---
Nevermind, wasn't thinking, this work is done in AddReturn, called by
svc/checkin

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14576] Allow arbitrary automatic update of location on checkin

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576

--- Comment #35 from Nick Clemens  ---
(In reply to Jonathan Druart from comment #29)
> (In reply to Nick Clemens from comment #28)
> > Adds the UpdateItemLocationOnCheckin to svc/checkin
> 
> Why is it needed?
> svc/checkin calls AddReturn (which deals with UpdateItemLocationOnCheckin).

Yeahnevermind that bit, removed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14576] Allow arbitrary automatic update of location on checkin

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576

Nick Clemens  changed:

   What|Removed |Added

  Attachment #54281|0   |1
is obsolete||

--- Comment #34 from Nick Clemens  ---
Created attachment 54648
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54648=edit
Bug 14576 - (QA Followup) Remove other instances of
ReturnToShelvingCart/InprocessingToShelvingCart

This patch eliminates ReturnToShelvingCart and
InProcessingToShelvingCart,
Deletes Returns.t (it only tested those two
prefs and new tests are in issue.t)

Remaining instances found by:
git grep "ReturnToShelvingCart\|InProcessingToShelvingCart" | grep -v
translator | wc -l
are db update files and release notes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14576] Allow arbitrary automatic update of location on checkin

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576

Nick Clemens  changed:

   What|Removed |Added

  Attachment #53115|0   |1
is obsolete||

--- Comment #33 from Nick Clemens  ---
Created attachment 54647
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54647=edit
Bug 14576 (QA Folllowup) Address issues

use mock for tests
use a separate variable for yaml
fix indentation

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14576] Allow arbitrary automatic update of location on checkin

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576

Nick Clemens  changed:

   What|Removed |Added

  Attachment #53114|0   |1
is obsolete||

--- Comment #32 from Nick Clemens  ---
Created attachment 54646
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54646=edit
Bug 14576 - (QA followup) Fix message for use of value not in authorized values

Signed-off-by: Cathi Wiggins 

Signed-off-by: Megan Wianecki  

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14576] Allow arbitrary automatic update of location on checkin

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576

Nick Clemens  changed:

   What|Removed |Added

  Attachment #53113|0   |1
is obsolete||

--- Comment #31 from Nick Clemens  ---
Created attachment 54645
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54645=edit
Bug 14576 - Unit tests

Signed-off-by: Cathi Wiggins 

Signed-off-by: Megan Wianecki  

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14576] Allow arbitrary automatic update of location on checkin

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576

Nick Clemens  changed:

   What|Removed |Added

  Attachment #53112|0   |1
is obsolete||

--- Comment #30 from Nick Clemens  ---
Created attachment 54644
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54644=edit
Bug 14576 - Allow arbitrary automatic update of location on checkin

This patch adds a new syspref "UpdateItemLocationOnCheckin" which
accepts pairs of shelving locations.  On check-in the items location is
compared ot the location on the left and, if it matches, is updated to
the location on the left.

This preference replaces ReturnToShelvingCart and
InProcessingToShelvingCart preferences.  The update statement should
insert values that replciate these functions.  Note existing
functionality of all items in PROC location being returned to
permanent_location is preserved by default.  Also, any items issued from
CART location will be returned to their permanent location on issue (if
it differs)

Special values for this pref are:
_ALL_ - used on left side only to affect all items
_BLANK_ - used on either side to match on/set to blank (actual blanks
will work, but this is an easier to read option)
_PERM_ - used on right side only to return items to permanent location

Test Plan:
1) Apply this patch
2) Run updatedatabase.pl
3) Set the new system preference UpdateitemLocationOnCheckin
   to the following (assuming sample data):
   NEW: FIC
   FIC: GEN
4) Create an item, set its location to NEW
5) Check in the item, note its location is now FIC
6) Check in the item again, note its location is now GEN
7) Check in the item again, note its location remains GEN
8) Test using _ALL_, _BLANK_ and _PERM_ for updates
9) Try entering various incorrect syntax in the pref and note you are warned

Sponsored by:
Arcadia Public Library (http://library.ci.arcadia.ca.us/)
Middletown Township Public Library (http://www.mtpl.org/)

Signed-off-by: Cathi Wiggins 

Signed-off-by: Megan Wianecki  

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17140] Incorrect rounding in total fines calculations, part 2

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140

--- Comment #12 from Marc Véron  ---
Created attachment 54643
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54643=edit
Screenshots with some notes added

Added the same screenshots with some notes on them.

See comment #11

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12644] Add subtitles staff client cart

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12644

Owen Leonard  changed:

   What|Removed |Added

 CC||gmcha...@gmail.com
Summary|Add subtitles to all cart   |Add subtitles staff client
   |views   |cart
   Assignee|oleon...@myacpl.org |koha-b...@lists.koha-commun
   ||ity.org
  Component|OPAC|Staff Client

--- Comment #1 from Owen Leonard  ---
This bug doesn't appear valid for the OPAC, but does affect the staff client.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17140] Incorrect rounding in total fines calculations, part 2

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140

--- Comment #11 from Marc Véron  ---
Created attachment 54642
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54642=edit
Illustration of precision problem with calculated rental fees and manual
invoices

I made some screenshots to explain what I mean.
(Screenshots made with patch applied).

I still think that
- it should not be possible to manually enter values like 1.003 (manual
invoices, payment, credit, item rental fees, others?)
- a calculated rental fee (from item rental fee and patron category discount)
should be rounded to 2 decimals

Otherwise, after payement, you will have remainders in the database that lead
to strange behaviour (see attachment).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17118] Regression: Bug 15381 triggers error when trying to clear a linked authority

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17118

--- Comment #1 from Jonathan Druart  
---
Created attachment 54641
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54641=edit
Bug 17118: (follow-up 15381) Fix regression when clearing a linked authority

Changes made on bug 15381 assumed that the authid was always set.
But if the user wants to clear the field of the authority, the script is
called with authid=0 (FIXME...)

To fix this issue, it's better to move the new calls to
  Koha::Authorities->find($authid)->authtypecode
and
  Koha::Authority::Types->find($authtypecode);
at the correct place

Test plan:
1. Edit a record which has a field linked to an
   authority record (100a for instance).
2. Click the link which triggers the tag editor.
   A pop-up window should be displayed.
3. In the pop-up window, click the "Clear field"
   button.
=> Without this patch A second pop-up window opens and displays an error:
  Can't call method "authtypecode" on an undefined value at
/authorities/blinddetail-biblio-search.pl line 61.
=> With this patch applied the field is correctly cleared.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17118] Regression: Bug 15381 triggers error when trying to clear a linked authority

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17118

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12814] Authority cataloging problem

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12814

Owen Leonard  changed:

   What|Removed |Added

Summary|KOHA Cataloging |Authority cataloging
   |(Authorities) Problem   |problem

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17118] Regression: Bug 15381 triggers error when trying to clear a linked authority

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17118

Jonathan Druart  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|gmcha...@gmail.com  |jonathan.dru...@bugs.koha-c
   ||ommunity.org
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
 Depends on||15381


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15381
[Bug 15381] Move the authority types related code to Koha::Authority::Type[s] -
part 2
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17140] Incorrect rounding in total fines calculations, part 2

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140

--- Comment #10 from Jacek Ablewicz  ---
(In reply to Jonathan Druart from comment #4)
> I think we should remove the * 1000 / 1000

+1, it isn't really serving any useful purpose, it's not warranted that the
result of the multiplication will be an integer anyway.

BTW, there is another one like that (*100, /100) in GetBorNotifyAcctRecord().
Still with an int() thing, which is definitely incorrect.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15381] Move the authority types related code to Koha::Authority::Type [s] - part 2

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15381

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||17118


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17118
[Bug 17118] Regression: Bug 15381 triggers error when trying to clear a linked
authority
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17140] Incorrect rounding in total fines calculations, part 2

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140

--- Comment #9 from Jacek Ablewicz  ---
(In reply to Jonathan Druart from comment #8)
> Prices should be stored with a big precision (6 is largely enough) and
> displayed with 2 decimals.

Hm, maybe charges / fines should be treated a bit differently.. When there is a
fine like 1.342, and it displays as 1.32, how do you know what exact amount to
enter to make account balanced? Doing a math (comparisons etc.) with amounts
casted to .2f would solve some kinds of this problems (I think that's like
accountants do it [on Discovery Channel]) to solve < .01 difference problems on
invoices etc.

Fine calculations in Koha a mostly done in floating-point - it's probably good
enough for 99.9(9) of cases (~16 significant decimal digits precision with
64bit floats) as long as you are doing a casting (btw, to .2f or .6f ?) in most
important places.

Mysql calculations for decimal(x,y) are allegedly precise, though, and fine
calculations in koha are not always floating-point, e.g. in
GetMemberIssuesAndFines():

SELECT SUM(amountoutstanding) FROM accountlines

Storing all fines/charges amounts rounded to .2f and doing most of the math in
.2 precision is tempting (but that alone would not be enough to prevent all
kinds of such problems) - hopefully nobody is using bitcoin as a main currency
in Koha..

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13552] Add debar option to batch patron modification

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13552

Owen Leonard  changed:

   What|Removed |Added

Summary|Added: debarredcomment and  |Add debar option to batch
   |debarreddate in batch   |patron modification
   |patrons modification|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11887] Add script for collections agency reports

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11887

--- Comment #8 from Owen Leonard  ---
Should this be 'Needs signoff?'

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7204] Deleting a framework which still has biblios attached to it end up in subtle problems

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7204

Owen Leonard  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEW |RESOLVED

--- Comment #3 from Owen Leonard  ---
This appears to be fixed in master. Koha does not give you the option of
deleting a framework if it is use:

This framework cannot be deleted

Books, Booklets, Workbooks (BKS)

The framework is used 14 times.

[ <- Return to frameworks ]

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14838] Coding issue on reports header row

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14838

Owen Leonard  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #1 from Owen Leonard  ---
This appears to be fixed in master.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13452] Average checkout report always uses biblioitems.itemtype

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13452

--- Comment #12 from Jonathan Druart  
---
Still the same.
Actually $itype is set to undef because not defined in the same scope.
If you are not using plack it should work correctly, with plack it will fail.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7649] remove kw,wrdl from search history

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7649

Owen Leonard  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #1 from Owen Leonard  ---
This appears to be fixed in master.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13921] XSLT Literary Formats Not Showing

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13921

--- Comment #2 from Owen Leonard  ---
Created attachment 54640
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54640=edit
Bug 13921 - XSLT Literary Formats Not Showing

This patch adds some missing literary formats to the staff client and
OPAC's search results XSLT display.

To test you must have DisplayOPACiconsXSLT and DisplayIconsXSLT system
preferences enabled.  XSLTResultsDisplay and OPACXSLTResultsDisplay
should be set to 'default.'

Perform searches in the staff client and the OPAC and confirm that the
following literary forms (defined in 008 position 33) display correctly:
Not fiction; Fiction; Dramas; Essays; Novels; Humor, satires, etc.;
Letters; Short stories; Mixed forms; Poetry; Speeches.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13921] XSLT Literary Formats Not Showing

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13921

Owen Leonard  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17152] New: Duplicating a subfield should not copy the data

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17152

Bug ID: 17152
   Summary: Duplicating a subfield should not copy the data
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Cataloging
  Assignee: gmcha...@gmail.com
  Reporter: sophie.meyni...@biblibre.com
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

When cataloguing, if you want to duplicate a subfield that is not empty, the
new subfield is created with a copy of data in it.
This is not the case when you duplicate an whole field. The new one is created
with subfields but without data in it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17135] Fine for the previous overdue may get overwritten by the next one

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17135

Josef Moravec  changed:

   What|Removed |Added

 CC||josef.mora...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14576] Allow arbitrary automatic update of location on checkin

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576

--- Comment #29 from Jonathan Druart  
---
(In reply to Nick Clemens from comment #28)
> Adds the UpdateItemLocationOnCheckin to svc/checkin

Why is it needed?
svc/checkin calls AddReturn (which deals with UpdateItemLocationOnCheckin).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17067] Missing field "sms_provider_id" in database schema

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17067

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
 Depends on||9021


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9021
[Bug 9021] Add SMS via email as an alternative to SMS services via SMS::Send
drivers
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17140] Incorrect rounding in total fines calculations, part 2

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140

--- Comment #8 from Jonathan Druart  
---
Prices should be stored with a big precision (6 is largely enough) and
displayed with 2 decimals.
That is how it's done in the acq module and almost everywhere else I think.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13921] XSLT Literary Formats Not Showing

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13921

Owen Leonard  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17067] Missing field "sms_provider_id" in database schema

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17067

Jonathan Druart  changed:

   What|Removed |Added

 Depends on|9021|
  Component|Database|Project website
   Assignee|gmcha...@gmail.com  |wizzy...@gmail.com
Product|Koha|Project Infrastructure
 QA Contact|testo...@bugs.koha-communit |
   |y.org   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9021
[Bug 9021] Add SMS via email as an alternative to SMS services via SMS::Send
drivers
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16485] collection column in Item search is always empty

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16485

Andy Boze  changed:

   What|Removed |Added

 CC|boz...@nd.edu   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17067] Missing field "sms_provider_id" in database schema

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17067

--- Comment #1 from Jonathan Druart  
---
Liz, do you know who is supposed to update the schema?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9021] Add SMS via email as an alternative to SMS services via SMS:: Send drivers

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9021

Jonathan Druart  changed:

   What|Removed |Added

 Blocks|17067   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17067
[Bug 17067] Missing field "sms_provider_id" in database schema
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17067] Missing field "sms_provider_id" in database schema

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17067

Jonathan Druart  changed:

   What|Removed |Added

   Assignee|wizzy...@gmail.com  |gmcha...@gmail.com
Product|Project Infrastructure  |Koha
  Component|Project website |Database
 QA Contact||testo...@bugs.koha-communit
   ||y.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9021] Add SMS via email as an alternative to SMS services via SMS:: Send drivers

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9021

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||17067


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17067
[Bug 17067] Missing field "sms_provider_id" in database schema
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17048] Authority search result list page scrolling not working properly

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17048

Jonathan Druart  changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |jonathan.dru...@bugs.koha-c
   ||ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13452] Average checkout report always uses biblioitems.itemtype

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13452

Julian Maurice  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

--- Comment #11 from Julian Maurice  ---
(In reply to Jonathan Druart from comment #10)
> On reports/issues_avg_stats.pl, select row=patron category and column=item
> type
> 
> DBD::mysql::st execute failed: You have an error in your SQL syntax

I tried just now and saw no errors.

Generated SQL:

SELECT borrowers.categorycode, items.itype,  issuedate, returndate, COUNT(*)
FROM `old_issues`,borrowers,biblioitems
  LEFT JOIN items ON (biblioitems.biblioitemnumber=items.biblioitemnumber)
WHERE old_issues.itemnumber=items.itemnumber
  AND old_issues.borrowernumber=borrowers.borrowernumber
group by borrowers.categorycode, items.itype, issuedate, returndate
order by borrowers.categorycode, items.itype

I tried to change the value of item-level_itypes syspref, but it works as well.
Could you give it another try ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17140] Incorrect rounding in total fines calculations, part 2

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140

--- Comment #7 from Marc Véron  ---
In table accountlines, definition of amount is decimal 28,6
http://schema.koha-community.org/tables/accountlines.html

I am able to enter a manual invoice like 0.008 (displays as 0.01) or 0.004
(displays as 0.00)

The table then contains:
mysql> select amount from accountlines where borrowernumber = 13;
+--+
| amount   |
+--+
| 0.008000 |
| 0.004000 |
+--+

The 'Pay fines' tab shows an amount of 0.01 and an amount of 0.00

I payed the first one (0.01), it asked 0.01

mysql> select amount from accountlines where borrowernumber = 13;
+---+
| amount|
+---+
|  0.008000 |
|  0.004000 |
| -0.01 |
+---+

The 'Pay fines tab then shows an amount of 0.00
If I want to pay using 'Pay' on the line, it asks for 0.00, but obviously it is
not possible to pay the amount.

Same with 'Pay amount'

Now I add manual invoices, let's say 3 times 0.003

mysql> select amount from accountlines where borrowernumber = 13;
+---+
| amount|
+---+
|  0.008000 |
|  0.004000 |
| -0.01 |
|  0.003000 |
|  0.003000 |
|  0.003000 |
+---+

The Account tab shows all 0.00 in 'Outstanding' column, but a 'Total due' of
0.01

A similar situation occurs with Rental discounts in Circulation and fines rules
(smart-rules.pl), e.g. values like 2.961000

That will lead to confusion... 

What to do? Maybe the following:

 - Define a systemwide decimal precision for data entry of amounts?
 - Maybe depending on the decimal places in syspref CurrencyFormat?
 - Make Rental discounts round to that precision?
 - Allow 'Price' plug-in to override if more precision is necessary, e.g. for
calculating / displaying taxes in acquisition? (Koha/Number/Price.pm)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17048] Authority search result list page scrolling not working properly

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17048

--- Comment #5 from Jonathan Druart  
---
Created attachment 54639
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54639=edit
Bug 17048: Fix pagination offset for authority searches

At the intranet, the pagination has been broken by bug 12478 (Elastic
Search). There was a confusion between the offset and the page number.

At the OPAC, it is broken since bug 2735 which has mimicked the intranet
script.

Test plan:
Search for a term which will return more than 1 page of results.
Click on the second page
=> Without this patch, the first result of the second page is the second
result of the first page
=> With this patch applied, the offset will be corrected

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17048] Authority search result list page scrolling not working properly

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17048

Jonathan Druart  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13501] Allow autocompletion on drop-down lists

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13501

Julian Maurice  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

--- Comment #39 from Julian Maurice  ---
Patches rebased on master + 2 more patches for comment 32 and comment 33

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13501] Allow autocompletion on drop-down lists

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13501

--- Comment #37 from Julian Maurice  ---
Created attachment 54637
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54637=edit
Bug 13501: Highlight select2 control if field is required and value is missing

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13501] Allow autocompletion on drop-down lists

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13501

--- Comment #38 from Julian Maurice  ---
Created attachment 54638
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54638=edit
Bug 13501: Fix behavior of 'Delete subfield' button on select2 controls

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13501] Allow autocompletion on drop-down lists

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13501

Julian Maurice  changed:

   What|Removed |Added

  Attachment #48370|0   |1
is obsolete||

--- Comment #36 from Julian Maurice  ---
Created attachment 54636
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54636=edit
Bug 13501: Move "Required" and checkbox after input/select

Signed-off-by: Aleisha 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13501] Allow autocompletion on drop-down lists

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13501

Julian Maurice  changed:

   What|Removed |Added

  Attachment #48368|0   |1
is obsolete||

--- Comment #34 from Julian Maurice  ---
Created attachment 54634
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54634=edit
Bug 13501: Add JS library select2 3.5.4

use it on cataloguing and batch items edit pages

Signed-off-by: Aleisha 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13501] Allow autocompletion on drop-down lists

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13501

Julian Maurice  changed:

   What|Removed |Added

  Attachment #48369|0   |1
is obsolete||

--- Comment #35 from Julian Maurice  ---
Created attachment 54635
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54635=edit
Bug 13501: Indentation fix (batchMod-edit.tt)

Signed-off-by: Aleisha 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17048] Authority search result list page scrolling not working properly

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17048

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||2735

--- Comment #4 from Jonathan Druart  
---
Same at the OPAC, because of bug 2735.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2735
[Bug 2735] Authority search in OPAC stops at 15 pages
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2735] Authority search in OPAC stops at 15 pages

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2735

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||17048


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17048
[Bug 17048] Authority search result list page scrolling not working properly
-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12478] Elasticsearch support for Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||17048


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17048
[Bug 17048] Authority search result list page scrolling not working properly
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/