[Koha-bugs] [Bug 17246] GetPreparedLetter should not allow multiple FK defined in arrayref

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17246

Chris Cormack  changed:

   What|Removed |Added

 CC||ch...@bigballofwax.co.nz

--- Comment #2 from Chris Cormack  ---
We aren't using this feature anywhere in Koha, except in
t/db_dependent/Letters/TemplateToolkit.t

So yes, I agree we should remove it, because it is dangerous and someone may
start using it. Testing now

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15419] Sipserver problem with stale db handles

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15419

Srdjan Jankovic  changed:

   What|Removed |Added

  Attachment #53071|0   |1
is obsolete||

--- Comment #3 from Srdjan Jankovic  ---
Created attachment 55273
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55273=edit
Bug 15419 SIP: handle requests with timeout, and refresh dbh if need be

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11921] memcached configuration should be moved back to koha-conf.xml

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11921

Chris Cormack  changed:

   What|Removed |Added

  Attachment #55258|0   |1
is obsolete||

--- Comment #18 from Chris Cormack  ---
Created attachment 55271
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55271=edit
Bug 11921: C4::Context->memcached does no longer exist

Signed-off-by: Chris Cormack 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11921] memcached configuration should be moved back to koha-conf.xml

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11921

Chris Cormack  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11921] memcached configuration should be moved back to koha-conf.xml

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11921

Chris Cormack  changed:

   What|Removed |Added

  Attachment #55259|0   |1
is obsolete||

--- Comment #19 from Chris Cormack  ---
Created attachment 55272
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55272=edit
Bug 11921: Fix logic in C4::Context->new to init the config

Signed-off-by: Chris Cormack 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11921] memcached configuration should be moved back to koha-conf.xml

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11921

Chris Cormack  changed:

   What|Removed |Added

  Attachment #55171|0   |1
is obsolete||

--- Comment #17 from Chris Cormack  ---
Created attachment 55270
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55270=edit
Bug 11921: Update remaining occurrences of ->ismemcached

TODO: Would be better to provide a better way to know if memcache is correctly
set
Signed-off-by: Chris Cormack 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11921] memcached configuration should be moved back to koha-conf.xml

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11921

Chris Cormack  changed:

   What|Removed |Added

  Attachment #55170|0   |1
is obsolete||

--- Comment #16 from Chris Cormack  ---
Created attachment 55269
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55269=edit
Bug 11921: Restore memcached infos to koha-conf - Koha::Config

Move C4::Context->read_config_file to Koha::Config
That permits to reuse it from Koha::Cache without needing C4::Context
(and introduce a circular deps).

TODO: Add decent POD to Koha::Config
Signed-off-by: Chris Cormack 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11921] memcached configuration should be moved back to koha-conf.xml

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11921

Chris Cormack  changed:

   What|Removed |Added

  Attachment #55169|0   |1
is obsolete||

--- Comment #15 from Chris Cormack  ---
Created attachment 55268
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55268=edit
Bug 11921: Restore memcached infos to koha-conf

MEMCACHED_SERVERS and MEMCACHED_NAMESPACE should be moved back to
koha-conf instead of an ENV var to let command line scripts use
the cache mechanism.

TODO:
- Add the entries to koha-conf.xml
- Remove occurrences of MEMCACHED_SERVERS in package, apache and plack files

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11921] memcached configuration should be moved back to koha-conf.xml

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11921

--- Comment #14 from Chris Cormack  ---
It takes a bit to get set up to test, the main thing is make sure you are using
the latest plack.psgi.

But once it is set up it seems to work well, plack is now running using
memcached using the variables from the config file.

I will sign off.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11921] memcached configuration should be moved back to koha-conf.xml

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11921

--- Comment #13 from Chris Cormack  ---
Trap for young testers

Bug 17189 updates plack.psgi .. make sure you are running that version before
you test (you will probably need to manually copy it)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17248] Koha::AuthorisedValues - Remove GetKohaAuthorisedValueLib

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17248

Claire Gravely  changed:

   What|Removed |Added

  Attachment #55183|0   |1
is obsolete||

--- Comment #5 from Claire Gravely  ---
Created attachment 55267
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55267=edit
Bug 17248 - Koha::AuthorisedValues - Remove GetKohaAuthorisedValueLib

The subroutine C4::Koha::GetKohaAuthorisedValueLib just retrieves a description
(lib) for a given authorised value.

We can easily replace it using:
  Koha::AuthorisedValues->search({ category => $cat, authorised_value => $av
})->lib
or
  Koha::AuthorisedValues->search({ category => $cat, authorised_value => $av
})->opac_description

Test plan:
- On the detail page of a bibliographic record, the description for notforloan,
restricted and stack (?) should be correctly displayed
- View a shelf, the location (LOC) description should be displayed
- On the search result page, the location description should be displayed in
the
  facets
- Set AcqCreateItem=ordering and receiving items.
The description for notforloan, restricted, location, ccode, etc. field
should be displayed.
- When creating item in the acquisition module, the dropdown list for
  field linked to AV should display the AV' descriptions
- On the transfers page, the description of the location should be
  displayed.
- On the checkout list from the circulation.pl and returns.pl pages, the
  description for "materials" should be displayed
- Fill some OPAC_SUG AV and create a suggestion, the reason dropdown
  list should display the description of OPAC_SUG

Signed-off-by: Claire Gravely 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17248] Koha::AuthorisedValues - Remove GetKohaAuthorisedValueLib

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17248

Claire Gravely  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17262] Plack on packages is not having memcached set properly

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17262

--- Comment #3 from Chris Cormack  ---
Have you seen bug 11921

That shifts the config back out of ENV variables. I feel like signing that off
and getting that in will be better than bandaiding what we do now.

What do you think?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17262] Plack on packages is not having memcached set properly

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17262

--- Comment #2 from Tomás Cohen Arazi  ---
Sorry for adding you all to the CC for this bug, but I think it deserves some
urgent attention.

Note: The patch itself cannot be pushed without solving the bigger problem.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17262] Plack on packages is not having memcached set properly

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17262

--- Comment #1 from Tomás Cohen Arazi  ---
Created attachment 55266
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55266=edit
Bug 17262: Inject MEMCACHED_* variables into Plack's env

This patch adds two functions to koha-functions.sh to read the MEMCACHED_*
variables from configured instances' apache files (the only source for that
info for now).

It then tweaks koha-plack's start_plack() function so it exports the variables
to env before launching starman.

The patch seems trivial, but it highlights a bigger problem with our Plack
integration
as the starman server seems to hang if those environment variables are defined!

Sponsored-by: ByWater Solutions

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17262] Plack on packages is not having memcached set properly

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17262

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17262] Plack on packages is not having memcached set properly

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17262

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||ch...@bigballofwax.co.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17261] Add memcached configuration info to about.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17261

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||ch...@bigballofwax.co.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17261] Add memcached configuration info to about.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17261

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Blocks||17262


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17262
[Bug 17262] Plack on packages is not having memcached set properly
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17262] Plack on packages is not having memcached set properly

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17262

Tomás Cohen Arazi  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com
   |ity.org |
 Depends on||17261
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org,
   ||kyle.m.h...@gmail.com,
   ||n...@bywatersolutions.com


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17261
[Bug 17261] Add memcached configuration info to about.pl
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17262] New: Plack on packages is not having memcached set properly

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17262

Bug ID: 17262
   Summary: Plack on packages is not having memcached set properly
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: major
  Priority: P5 - low
 Component: Packaging
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: tomasco...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: mi...@abunchofthings.net

Using the patches from bug 17261, you will notice the running Plack backends
are not getting the MEMCACHED_SERVERS and MEMCACHED_NAMESPACE variables filled
as they should.

Steps to reproduce:
- Be on top of bug 17261
- Have a working memcached setup, plack disbaled (default in kohadevbox)
=> About page shows:
  Memcached:Servers: 127.0.0.1:11211 | Namespace: koha_kohadev | Status:
running
- Enable Plack:
  sudo koha-plack --enable kohadev
  sudo koha-plack --start kohadev
  sudo service apache2 restart
- Reload about page
=> FAIL: You get:
  Memcached:Servers: undefined| Namespace: undefined | Status: unknown

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17261] Add memcached configuration info to about.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17261

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
 CC||tomasco...@gmail.com
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17261] Add memcached configuration info to about.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17261

--- Comment #1 from Tomás Cohen Arazi  ---
Created attachment 55265
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55265=edit
Bug 17261: Add memcached configuration info to about.pl

This patch adds a row in the About > System information tab, showing
the current configuration for memcached.

To test:
- Apply this patch, have memcached configured for the current instance (this is
the
  default in kohadevbox)
- Make sure you have the memcached server running:
  $ sudo service memcached start
- Open the about page in the browser
=> SUCCESS: You get something like:
  Memcached:Servers: 127.0.0.1:11211 | Namespace: koha_kohadev | Status:
running
- Stop the memcached server:
  $ sudo service memcached stop
- Reload the about page
=> SUCCESS: You get something like
  Memcached:Servers: 127.0.0.1:11211 | Namespace: koha_kohadev | Status:
not running
- Set both MEMCACHED_* variables in the apache config for intranet the empty
string:
  $ sudo vim /etc/apache2/sites-enabled/kohadev.conf
..
   SetEnv MEMCACHED_SERVERS ""
#"127.0.0.1:11211"
   SetEnv MEMCACHED_NAMESPACE ""
#"koha_kohadev"
..
- Restart apache:
  $ sudo service apache2 restart
- Reload the about page
=> SUCCESS: You get something like:
  Memcached:  Servers: undefined| Namespace: undefined | Status: unknown
- Sign off :-D

Sponsored-by: ByWater Solutions

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17261] Add memcached configuration info to about.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17261

Tomás Cohen Arazi  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com
   |ity.org |
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org,
   ||kyle.m.h...@gmail.com,
   ||n...@bywatersolutions.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17261] New: Add memcached configuration info to about.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17261

Bug ID: 17261
   Summary: Add memcached configuration info to about.pl
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: System Administration
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: tomasco...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

It would be helpful in several situations to have that information at hand, as
we do for other stuff (zebra, apache, plack, etc).

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11375] Improve patrons permissions display

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11375

Katrin Fischer  changed:

   What|Removed |Added

Summary|Patron permission names are |Improve patrons permissions
   |untranslatable  |display

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17215] Cardnumbers of patrons created using LDAP Replication not using autoMemberNum if configured

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17215

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #55092|0   |1
is obsolete||

--- Comment #10 from Kyle M Hall  ---
Created attachment 55264
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55264=edit
Bug 17215 - Cardnumbers of patrons created using LDAP Replication not using
autoMemberNum if configured

To test:
1. Set the autoMemberNum System Preference to "Don't".
2. Login to the OPAC with an LDAP account that does not currently exist as a
patron record.
3. Check the patron record's cardnumber.
4. the cardnumber should equal the patron's LDAP username.
5. Delete the patron record.
6. Apply the patch.
7. Set the autoMemberNum System Preference to "Do".
8. Login to the OPAC with an LDAP account that does not currently exist as a
patron record.
9. Check the patron record's cardnumber.
10. The cardnumber should now be the next highest cardnumber based on
autoMemberNum.

Signed-off-by: Lee Jamison 
Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12285] Allow easy printing of patron's fines

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285

NancyK.  changed:

   What|Removed |Added

 CC||nkee...@washoecounty.us

--- Comment #8 from NancyK.  ---
Hi, is anyone still considering his bug.  I have had a request from staff for
this very feature.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17134] Facet's area shows itemtypes' code instead of item' s description

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17134

--- Comment #10 from Claudio  ---
Owen, Katrin, would you please help me with this? It's a specific 16.05
error... Thanks a lot...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17260] updatedatabase.pl fails on invalid entries in ENUM and BOOLEAN columns

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17260

Blou  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17260] updatedatabase.pl fails on invalid entries in ENUM and BOOLEAN columns

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17260

--- Comment #1 from Blou  ---
Created attachment 55263
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55263=edit
Bug 17260 - updatedatabase.pl fails on invalid entries in ENUM and BOOLEAN
columns

The loading of file admin/searchengine/elasticsearch/mappings.yaml specifies
'type' as empty, which fails with Mysql 5.7+ which is more stringent.

Also, forcing an empty value into a boolean also fails.

Both issues arise when updatedatabase.pl hit 3.23.00.050.

NOTE: both issues could also be resolved by actually setting values in the load
file.
  This doesn't make this solution incorrect, though.

To Test/reproduce:
   -1) Happens with Mysql 5.7.4.  Maybe earlier, but certainly at that point.
   0) Find a database on 3.22 or earlier, save it.
   1) Set your code base to master)
   2) run updatedatabase.pl
   3) See the errors on 3.23.00.050
   4) Apply the patch
   5) Reload the 3.22 db.
   6) succeed with updatedatabase.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17189] Add the ability to define several memcached namespaces

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17189

--- Comment #4 from Jacek Ablewicz  ---
(In reply to Jonathan Druart from comment #2)

> We need to define several namespaces for our cache system.
> For instance sysprefs, koha conf (koha-conf.xml) and unit tests
> should be defined in a separate namespace.

Hmm, IMO most serious limitation of this approach/implementation is that having
separate cache object instances for 1) sysprefs 2) config and 3) everything
else will result in opening 3 different connections to (the very same)
memcached daemon per script/plack worker. Under plack, the 2nd connection will
be used just once.

IMO separate object instance (& connection) for sysprefs would have rather
limited usability too

> This will permit to
> - and flush the sysprefs cache without flushing all other values

because it will allow to flush only L1 syspref cache selectively, while no such
thing would be possible for L2/upstream cache. Unfortunately, with memcached,
it's either a flush of the given key or the whole cache flush (all keys in all
namespaces & subnamespaces). In memcached, keys from different namespaces are
not distinguishable in any way, and deleting keys by wildcard is not possible.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17234] ALTER IGNORE TABLE is invalid in mysql 5.7. This breaks updatedatabase.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234

Blou  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=17260

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17260] updatedatabase.pl fails on invalid entries in ENUM and BOOLEAN columns

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17260

Blou  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=17234

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17260] updatedatabase.pl fails on invalid entries in ENUM and BOOLEAN columns

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17260

Blou  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 CC||eric.be...@inlibro.com,
   ||franch...@gmail.com
   Assignee|gmcha...@gmail.com  |philippe.blo...@inlibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17260] New: updatedatabase.pl fails on invalid entries in ENUM and BOOLEAN columns

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17260

Bug ID: 17260
   Summary: updatedatabase.pl fails on invalid entries in ENUM and
BOOLEAN columns
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: major
  Priority: P5 - low
 Component: Installation and upgrade (command-line installer)
  Assignee: gmcha...@gmail.com
  Reporter: philippe.blo...@inlibro.com
QA Contact: testo...@bugs.koha-community.org

See also Bug 17234

The loading of file admin/searchengine/elasticsearch/mappings.yaml specifies
'type' as empty, which fails with Mysql 5.7+ which is more stringent.

Also, forcing an empty value into a boolean also fails.

Both issues arise when updatedatabase.pl hit 3.23.00.050.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16140] Only clear L1 cache when needed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16140

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com

--- Comment #30 from Kyle M Hall  ---
(In reply to Marcel de Rooy from comment #29)
> What is the current status of this discussion? ;)

As far as I know Jesse is no longer working on this since he's moved on. I'm
not exactly sure what we should do about this.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17132] Availability search broken when using Elastic

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17132

--- Comment #5 from J Schmidt  ---
I checked out Once upon a time 316376... to patron aitken, bailey then
performed searches as the title is not available and it was retrieved in basic
and advanced search (I did a title search using 'the time')... listed correctly
as on loan and retrieve other results.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17132] Availability search broken when using Elastic

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17132

PTFS Europe Sandboxes  changed:

   What|Removed |Added

  Attachment #54490|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17132] Availability search broken when using Elastic

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17132

--- Comment #4 from PTFS Europe Sandboxes  ---
Created attachment 55262
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55262=edit
Bug 17132 - Availability search broken when using Elastic

Elastic appears to be indexing onloan as a string, but our code assumes
it is a boolean.

Test Plan:
1) Ensure you are set up using Elastic as your search engine
2) Search only for available items from the advanced search
3) Note you get no results
4) Apply this patch
5) Re-run the search
6) You should now get results!

Signed-off-by: Jennifer Schmidt 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17132] Availability search broken when using Elastic

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17132

PTFS Europe Sandboxes  changed:

   What|Removed |Added

 CC||sandbo...@ptfs-europe.com

--- Comment #3 from PTFS Europe Sandboxes  ---
Patch tested with a sandbox, by Jennifer Schmidt 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17132] Availability search broken when using Elastic

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17132

J Schmidt  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||jschm...@switchinc.org

--- Comment #2 from J Schmidt  ---
I went into the PTFS Sandbox (1) and did a search for 'the' to find items in
the test database. I found some titles having status of available.. I then went
to "Search the Catalog" and did numerous searches (e.g., The middle east and
brazil)...I was able to bring up results (Success). I went under the Advanced
Search area and did the same. I was able to again retrieve results
successfully. Following the test plan below this bug appears to meet the status
of signed off.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15900] Remove use of recordpayment in ProcessOfflinePayment

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15900

--- Comment #6 from Kyle M Hall  ---
Created attachment 55261
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55261=edit
Bug 15900 [QA Followup] - Use Koha::Patrons instead of Koha::Borrowers

Since the initial submission of this patch, the module Koha::Borrowers
has been moved to Koha::Patrons. This patch changes the call from
Koha::Borrowers to Koha::Patrons.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15900] Remove use of recordpayment in ProcessOfflinePayment

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15900

Kyle M Hall  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15902] Remove use of recordpayment in process_koc.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15902

--- Comment #7 from Kyle M Hall  ---
Created attachment 55260
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55260=edit
Bug 15902 [QA Followup] - Use Koha::Patrons instead of Koha::Borrowers

Since the initial submission of this patch, the module Koha::Borrowers
has been moved to Koha::Patrons. This patch changes the call from
Koha::Borrowers to Koha::Patrons.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15902] Remove use of recordpayment in process_koc.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15902

Kyle M Hall  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15985] Include transacting library in fines

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15985

Kyle M Hall  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15985] Include transacting library in fines

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15985

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com
 Depends on||14826

--- Comment #1 from Kyle M Hall  ---
Steps 1 through 3 are completed, only step 4 remains!


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826
[Bug 14826] Resurrect account offsets table
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14826] Resurrect account offsets table

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826

Kyle M Hall  changed:

   What|Removed |Added

 Blocks||15985


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15985
[Bug 15985] Include transacting library in fines
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11921] memcached configuration should be moved back to koha-conf.xml

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11921

--- Comment #11 from Jonathan Druart  
---
Created attachment 55258
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55258=edit
Bug 11921: C4::Context->memcached does no longer exist

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11921] memcached configuration should be moved back to koha-conf.xml

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11921

--- Comment #12 from Jonathan Druart  
---
Created attachment 55259
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55259=edit
Bug 11921: Fix logic in C4::Context->new to init the config

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17234] ALTER IGNORE TABLE is invalid in mysql 5.7. This breaks updatedatabase.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234

Blou  changed:

   What|Removed |Added

  Attachment #55144|0   |1
is obsolete||

--- Comment #11 from Blou  ---
Comment on attachment 55144
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55144
Bug 17234 - updatedatabase.pl fails on invalid entry in ENUM column

I'll remove the second patch.  I'll submit it in a new bug, along with the
other similar fixes.  Along the way, I'll comment how it would be maybe
preferable to fix the .yml rather than allowing ''.

At least the first patch will move ahead.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17234] ALTER IGNORE TABLE is invalid in mysql 5.7. This breaks updatedatabase.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234

--- Comment #10 from M. Tompsett  ---
`type` ENUM('', 'string', 'date', 'number', 'boolean', 'sum') NOT NULL COMMENT
'what type of data this holds, relevant when storing it in the search engine',

(In reply to Blou from comment #9)
> That said, the entries in admin/searchengine/elasticsearch/mappings.yaml
> specify '' as type.

$ grep "\stype:" admin/searchengine/elasticsearch/mappings.yaml | sort -u
Confirms what you have said.

But I can't help but wonder if perhaps 58 tweaks to the mappings.yaml file is
more correct.

Perhaps you may wish to split this off to its own bug, obsolete it here, and
then the ALTER IGNORE can more forward?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11921] memcached configuration should be moved back to koha-conf.xml

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11921

--- Comment #10 from Jacek Ablewicz  ---
C4/Auth.pm, in get_session():

1731:elsif ( $storage_method eq 'memcached' &&
Koha::Caches->get_instance->memcached_cache ) {
 $session = new CGI::Session(
"driver:memcached;serializer:yaml;id:md5", $sessionID, { Memcached =>
C4::Context->memcached } );

looks like ->memcached method doesn't exist in C4::Context anymore

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11921] memcached configuration should be moved back to koha-conf.xml

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11921

--- Comment #9 from Jacek Ablewicz  ---
in C4/Contex.pm ->new():

251: unless ( %$self ) {
 $self = Koha::Config->read_from_file($conf_fname);
 }

$self is always an empty hash at this point, so config file would be rereaded
and reparsed no matter what?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17240] Allow processes that rely on background jobs run in Plack mode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17240

--- Comment #11 from Fridolin SOMERS  ---
Created attachment 55257
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55257=edit
Bug 17240 - Allow processes that rely on background jobs run in Plack mode -
followup

Followup
If not running in background mode, some calls are made on $job var.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14637] Add patron category fails with MySQL 5.6.26

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14637

--- Comment #5 from Jonathan Druart  
---
I am still not sure if this is the way to go.
Actually update_or_insert should set the default value defined at the DB level
if the field is not passed to the constructor.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17226] Improve AUTOLOAD of Koha::Object

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17226

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||17251


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17251
[Bug 17251] Koha::AuthorisedValues - Remove GetKohaAuthorisedValuesMapping
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17251] Koha::AuthorisedValues - Remove GetKohaAuthorisedValuesMapping

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17251

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||17226


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17226
[Bug 17226] Improve AUTOLOAD of Koha::Object
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14060] Remove readonly on date inputs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14060

Nick Clemens  changed:

   What|Removed |Added

  Attachment #55018|0   |1
is obsolete||

--- Comment #62 from Nick Clemens  ---
Created attachment 55253
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55253=edit
Bug 14060: Force leading zeros on date

If a date does not contain leading zeros for day and month, the date
will be refused.
parseDate function considers 1/1/1990 as a valid date, but our perl code
does not. We must refuse it.

Signed-off-by: Owen Leonard 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14060] Remove readonly on date inputs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14060

Nick Clemens  changed:

   What|Removed |Added

  Attachment #55019|0   |1
is obsolete||

--- Comment #63 from Nick Clemens  ---
Created attachment 55254
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55254=edit
Bug 14060: Add the datepicker class to dateofbirth

Signed-off-by: Owen Leonard 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14060] Remove readonly on date inputs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14060

Nick Clemens  changed:

   What|Removed |Added

  Attachment #55246|0   |1
is obsolete||

--- Comment #65 from Nick Clemens  ---
Created attachment 55256
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55256=edit
Bug 14060: Improve regex to limit year to 4 integers

01/01/01984 should not be considered as a valid date.

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14060] Remove readonly on date inputs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14060

Nick Clemens  changed:

   What|Removed |Added

  Attachment #55165|0   |1
is obsolete||

--- Comment #64 from Nick Clemens  ---
Created attachment 55255
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55255=edit
Bug 14060: Consider an empty string as a valid date

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14060] Remove readonly on date inputs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14060

Nick Clemens  changed:

   What|Removed |Added

  Attachment #55017|0   |1
is obsolete||

--- Comment #61 from Nick Clemens  ---
Created attachment 55252
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55252=edit
Bug 14060: Display date format pattern instead of date format name

Signed-off-by: Owen Leonard 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17234] ALTER IGNORE TABLE is invalid in mysql 5.7. This breaks updatedatabase.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234

--- Comment #9 from Blou  ---
(In reply to M. Tompsett from comment #4)
> > + `type` ENUM('', 'string', 'date', 'number', 'boolean', 'sum') 
> > NOT NULL COMMENT 'what type of data this holds, relevant when storing it in 
> > the search engine',
> 
> I haven't looked yet, but this seems like a bad solution. Invalid entries in
> the ENUM column are likely caused by applying patches that didn't get into
> master. I may get around to looking further, but this patch portion doesn't
> seem right to me.

Maybe I shouldn't have mixed the two patches.  But both issues prevent me from
completing updatedatabase.pl with mysql 5.7, related to its stringent
requirements.

That said, the entries in admin/searchengine/elasticsearch/mappings.yaml
specify '' as type.  So this to fix updatedatabase, there are two options:
1) correct a few (hundreds?) entries in mappings.yaml, knowing what you're
doing with elastic search.
2) allow for empty types.


NOTE: there are more blockers.  More small patches coming.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14060] Remove readonly on date inputs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14060

Nick Clemens  changed:

   What|Removed |Added

  Attachment #55014|0   |1
is obsolete||

--- Comment #58 from Nick Clemens  ---
Created attachment 55249
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55249=edit
Bug 14060: Display the date format on the warning popup

The date format is now displayed on the warning popup.

Signed-off-by: Owen Leonard 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14060] Remove readonly on date inputs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14060

Nick Clemens  changed:

   What|Removed |Added

  Attachment #55016|0   |1
is obsolete||

--- Comment #60 from Nick Clemens  ---
Created attachment 55251
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55251=edit
Bug 14060: Add support for dmydot

Signed-off-by: Owen Leonard 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14060] Remove readonly on date inputs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14060

Nick Clemens  changed:

   What|Removed |Added

  Attachment #55015|0   |1
is obsolete||

--- Comment #59 from Nick Clemens  ---
Created attachment 55250
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55250=edit
Bug 14060: Force the input to contain a valid date

Before this patch, the user was still allowed to enter a valid date.
Now, if the date is not valid, the input is emptied.

Signed-off-by: Owen Leonard 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14060] Remove readonly on date inputs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14060

Nick Clemens  changed:

   What|Removed |Added

  Attachment #55013|0   |1
is obsolete||

--- Comment #57 from Nick Clemens  ---
Created attachment 55248
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55248=edit
Bug 14060: Add OnClose event on missing datepicker

The "suspend until" inputs (hold list on circ/circulation.pl and
members/moremember.pl) were not set in the same way.
The minDate option should be set for both (bug 10703 removed it for
circ/circulation.pl).
This patch reintroduces the option and add the OnClose event on both.

Signed-off-by: Owen Leonard 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14060] Remove readonly on date inputs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14060

Nick Clemens  changed:

   What|Removed |Added

  Attachment #55012|0   |1
is obsolete||

--- Comment #56 from Nick Clemens  ---
Created attachment 55247
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55247=edit
Bug 14060: Remove readonly attributes on date inputs

In order to remove accessibility issues due to the readonly attributes
on date inputs, this patch will remove them and introduce a javascript
validation on them.

This patch is not perfect for some reason:
I didn't manage to force the user to select a valid date. One solution
would be to reopen the datepicker plugin until a valid date is inserted.
But it could be annoying for users (and for me: I did not manage to
implement this solution).
You will note that input is emptied if the date is not valid. This is a
quick and efficient solution to prevent submitting invalid date and make
Koha explodes. A proper solution would be to implement the check server
side send a friendly message to the user.

Test plan:
For all inputs, try an invalid and a valid date.
 1/ Debar a patron
 2/ On the checkout tables (circulation and moremember), add a renewal
due date (at the bottom of the tables)
 3/ On the checkout page, specify a due date
 4/ On the return page, specify a return date
 5/ On the invoice page (acquisition module), enter a shipment and
billing date
 6/ On the invoice search page (invoices.pl) use filters shipment and
billing dates
 7/ On the offline circ page, specify a due date
 8/ On the edit patron page (memberentry), add a debarment
 9/ On the reserve page (reserve/request.pl), use the date inputs to
suspend until a defined date
10/ Edit patrons in a batch (tools/modborrowers.pl) and use the
registration and expiry date inputs

Signed-off-by: Owen Leonard 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14060] Remove readonly on date inputs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14060

Nick Clemens  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

--- Comment #194 from Marcel de Rooy  ---
This feature may also be referred to as Scan and Deliver.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17234] ALTER IGNORE TABLE is invalid in mysql 5.7. This breaks updatedatabase.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234

--- Comment #8 from M. Tompsett  ---
(In reply to Jonathan Druart from comment #7)
> Could someone explain me why I don't get the same error:
> 
> mysql> set sql_mode="STRICT_TRANS_TABLES";
> Query OK, 0 rows affected (0.00 sec)
> 
> mysql> ALTER IGNORE TABLE suggestions ADD KEY biblionumber (biblionumber);
> ERROR 1061 (42000): Duplicate key name 'biblionumber'
> 
> And so I don't understand the IGNORE keyword :)
> 
> Server version: 5.6.30-1 (Debian) # And not 5.7

"As of MySQL 5.7.4, the IGNORE clause for ALTER TABLE is removed and its use
produces an error."
(https://dev.mysql.com/doc/refman/5.7/en/alter-table.html)
I'd leave out the ignore.

This affects Ubuntu 16.04 LTS currently, and will affect Debian in the future.
This is a pre-emptive patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17254] Scan and Deliver-feature (mail selected digitized material)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17254

--- Comment #4 from Marcel de Rooy  ---
(In reply to Owen Leonard from comment #2)
> (In reply to Katrin Fischer from comment #1)
> > Maybe this could build on 14610 - a feature to order articles.
> 
> In fact is sounds like a duplicate:

True. Thanks.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

--- Comment #193 from Marcel de Rooy  ---
*** Bug 17254 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17254] Scan and Deliver-feature (mail selected digitized material)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17254

Marcel de Rooy  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #3 from Marcel de Rooy  ---


*** This bug has been marked as a duplicate of bug 14610 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17254] Scan and Deliver-feature (mail selected digitized material)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17254

--- Comment #2 from Owen Leonard  ---
(In reply to Katrin Fischer from comment #1)
> Maybe this could build on 14610 - a feature to order articles.

In fact is sounds like a duplicate:

>From Bug 14610:

> In essence it is somewhat similar to how holds work,
> but instead of a hold for a item, it's a request for a photocopy ( or
> digital copy ) of part of an item.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14060] Remove readonly on date inputs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14060

--- Comment #55 from Mirko Tietgen  ---
(In reply to Jonathan Druart from comment #54)
> Created attachment 55246 [details] [review]
> Bug 14060: Improve regex to limit year to 4 integers
> 
> 01/01/01984 should not be considered as a valid date.

I hope Koha stays free software until the year 1, or this will lead to some
library having to sponsor a new ILS again.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14060] Remove readonly on date inputs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14060

Jonathan Druart  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14060] Remove readonly on date inputs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14060

--- Comment #54 from Jonathan Druart  
---
Created attachment 55246
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55246=edit
Bug 14060: Improve regex to limit year to 4 integers

01/01/01984 should not be considered as a valid date.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

--- Comment #96 from Jonathan Druart  
---
Comment on attachment 45940
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45940
Bug 7677: UT: add unit tests for GetPreviousSerialid

Review of attachment 45940:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=7677=45940)
-

::: t/db_dependent/Serials_2.t
@@ +255,5 @@
> +is( GetPreviousSerialid( $subscriptionid, 1 ), $serialid2, "get previous 
> serialid with 1" );
> +is( GetPreviousSerialid( $subscriptionid, 2 ), $serialid1, "get previous 
> serialid with 2" );
> +is( GetPreviousSerialid( $subscriptionid, 3 ), undef, "get previous serialid 
> with 3, does not exist" );
> +
> +$dbh->rollback;

This rollback should not have been added by this patch (added by a wrong merge
conflict).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17245] Untranslatable abbreviated names of seasons.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17245

Jacek Ablewicz  changed:

   What|Removed |Added

 CC||a...@biblos.pk.edu.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

--- Comment #95 from Katrin Fischer  ---
I am not sure I understand how to fix - can you please provide a new patch for
the last patch? I think that's the one adding it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13371] Add filters to the supplier list view

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371

Julian Maurice  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

--- Comment #69 from Julian Maurice  ---
Paola, you did not sign off all the patches but I left the Signed-off-by line
in the squashed commit message. Tell me if you want it to be removed.
The simple view still needs to be tested.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13371] Add filters to the supplier list view

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371

Julian Maurice  changed:

   What|Removed |Added

  Attachment #55235|0   |1
is obsolete||
  Attachment #55236|0   |1
is obsolete||
  Attachment #55237|0   |1
is obsolete||
  Attachment #55238|0   |1
is obsolete||
  Attachment #55239|0   |1
is obsolete||
  Attachment #55240|0   |1
is obsolete||
  Attachment #55241|0   |1
is obsolete||
  Attachment #55242|0   |1
is obsolete||
  Attachment #55243|0   |1
is obsolete||
  Attachment #55244|0   |1
is obsolete||

--- Comment #68 from Julian Maurice  ---
Created attachment 55245
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55245=edit
Bug 13371: Add filters on the supplier list view

This patch adds the ability to filter the basket list depending on its
creator name, basketgroup name, dates (creation, close), etc.
It also adds a new link to filter on opened baskets only and the ability
to switch to a simple view if the complete view is to complex

Test plan:
Go on the supplier list view (acqui/booksellers.pl) and confirm that the
view is more ergonomic and the filters permit to the librarians to find
a basket more easily than before.

Signed-off-by: Paola Rossi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13371] Add filters to the supplier list view

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371

Julian Maurice  changed:

   What|Removed |Added

 CC||julian.maur...@biblibre.com

--- Comment #67 from Julian Maurice  ---
There is a lot of patches there, it makes the rebase process tedious.
Since they are all from the same author (and many are simple fixes), I think
it's time to squash them all!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17240] Allow processes that rely on background jobs run in Plack mode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17240

--- Comment #10 from Fridolin SOMERS  ---
(In reply to Jonathan Druart from comment #7)
> Not sure it makes sense to disable the background mode. Did you try and edit
> 100k bibliographic records or items or patrons?

(In reply to Tomás Cohen Arazi from comment #8)
> I don't agree with the proposed solution (we should make it work).

But since in PSGI mode it is broken, why not make it work quickly ?
A revamping may take a while.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17259] New: Allow batch removal of restrictions

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17259

Bug ID: 17259
   Summary: Allow batch removal of restrictions
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Patrons
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: n...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

It would be nice to have a ways for librarians to remove blocks of debarments
(end of the school year, etc) using the batch patron modification tools

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13371] Add filters to the supplier list view

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371

Julian Maurice  changed:

   What|Removed |Added

  Attachment #49021|0   |1
is obsolete||

--- Comment #64 from Julian Maurice  ---
Created attachment 55242
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55242=edit
Bug 13371: Add a simple view

This patch adds the ability to switch to a simple view if the complete
view to too complex.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13371] Add filters to the supplier list view

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371

Julian Maurice  changed:

   What|Removed |Added

  Attachment #49020|0   |1
is obsolete||

--- Comment #63 from Julian Maurice  ---
Created attachment 55241
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55241=edit
Bug 13371: Move firstname and surname closer

On this way, they can be searched together ("my_firstname my_surname").

Signed-off-by: Paola Rossi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13371] Add filters to the supplier list view

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371

--- Comment #66 from Julian Maurice  ---
Created attachment 55244
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55244=edit
Bug 13371: calendar.inc needed for date-range filter to parse dates correctly

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13371] Add filters to the supplier list view

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371

--- Comment #65 from Julian Maurice  ---
Created attachment 55243
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55243=edit
Bug 13371: Re-add what was lost in the rebase process

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13371] Add filters to the supplier list view

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371

Julian Maurice  changed:

   What|Removed |Added

  Attachment #49018|0   |1
is obsolete||

--- Comment #61 from Julian Maurice  ---
Created attachment 55239
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55239=edit
Bug 13371: List suppliers even if they don't have basket.

Signed-off-by: Paola Rossi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13371] Add filters to the supplier list view

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371

Julian Maurice  changed:

   What|Removed |Added

  Attachment #49019|0   |1
is obsolete||

--- Comment #62 from Julian Maurice  ---
Created attachment 55240
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55240=edit
Bug 13371: Fix filtering on numbers

This patch fixes a weird bug on some instances.
Since the sort is disabled on this table, we don't care on the type of
the data.
It should allow to filter on all columns of the table.

Signed-off-by: Paola Rossi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13371] Add filters to the supplier list view

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371

Julian Maurice  changed:

   What|Removed |Added

  Attachment #49017|0   |1
is obsolete||

--- Comment #60 from Julian Maurice  ---
Created attachment 55238
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55238=edit
Bug 13371: change the filters wording

Signed-off-by: Paola Rossi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13371] Add filters to the supplier list view

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371

Julian Maurice  changed:

   What|Removed |Added

  Attachment #49015|0   |1
is obsolete||

--- Comment #58 from Julian Maurice  ---
Created attachment 55236
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55236=edit
Bug 13371: Reintroduce the action buttons

Confirm the the "New basket" and "Receive shipment" buttons work as
before.

Signed-off-by: Paola Rossi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13371] Add filters to the supplier list view

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371

Julian Maurice  changed:

   What|Removed |Added

  Attachment #49016|0   |1
is obsolete||

--- Comment #59 from Julian Maurice  ---
Created attachment 55237
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55237=edit
Bug 13371: Add a filter for opened baskets

This patch adds a new link to filter on opened baskets only.

Signed-off-by: Paola Rossi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13371] Add filters to the supplier list view

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371

Julian Maurice  changed:

   What|Removed |Added

  Attachment #49014|0   |1
is obsolete||

--- Comment #57 from Julian Maurice  ---
Created attachment 55235
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55235=edit
Bug 13371: Add filters on the supplier list view

This patch adds the ability to filter the basket list depending on its
creator name, basketgroup name, dates (creation, close), etc.

Test plan:
Go on the supplier list view (acqui/booksellers.pl) and confirm that the
view is more ergonomic and the filters permit to the librarians to find
a basket more easily than before.

Signed-off-by: Paola Rossi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14060] Remove readonly on date inputs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14060

Nick Clemens  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #53 from Nick Clemens  ---
Hmm..and now one more I ran across:

At checkout, specify due date of: January 1, 01984

No error on setting this date, but attempting to checkout gives an invalid date
error.

Checking in items you can set and keep 01/01/01984 and items are marked as
returned 0198-01-01 00:00:00

I am not sure if these dates should be handled, or simply rejected (I think the
latter)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/