[Koha-bugs] [Bug 13640] Holds To Pull List includes items unreserveable items

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640

--- Comment #3 from David Cook  ---
Just a note that I have no plans to work on this currently, so I'm happy for
someone else to work on fixing this bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7187] Prioritize cover image sources such as Amazon, Google and add fail over i.e. if first source fails, go to next

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7187

--- Comment #44 from David Cook  ---
Ah, bug 9580 I'm guessing.

I really need to look into Coce...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7187] Prioritize cover image sources such as Amazon, Google and add fail over i.e. if first source fails, go to next

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7187

--- Comment #43 from David Cook  ---
(In reply to Chris Cormack from comment #42)
> Yes, bug 9850 meets all the requirements of this. We have it in production
> for our sites. So we will not be doing any more work on this. 
> 
> Our recommendation is to use coce for book covers

Bug 9850 is about Koha 3.12 help files. Was that a typo, Chris?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17815] Problems with search for dateaccessioned

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17815

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

--- Comment #1 from David Cook  ---
I don't have time to look at this one at the moment, but it sounds
interesting...

Can you give us any more data?

I trust with the SQL that the dateaccessioned would be between '2011-09-01' and
'2011-09-30', but what about those 9461 results? If you look at a sample of
them, do they all have dateaccessioned within that range, or do they have
different data?

Can you share a link to your results?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14861] Accession date comparison does not work in advanced search

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14861

--- Comment #31 from David Cook  ---
(In reply to Katrin Fischer from comment #30)
> Hm, tested this on a 3.22 database with the example from the test plan:
> 
> Search from advanced search by accession date:
> 2011-09-01 - 2011-09-30 
> 9461 results
> 
> Searched with SQL: 
> select distinct biblionumber from items where dateaccessioned between
> '2011-09-01' and '2011-09-30'
> 805 results
> 
> The date range search doesn't seem to work right.
> 
> The search for a single date seems to work correctly. You can also truncate
> with *.
> 
> Also filed this as a new bug report: bug 17815.

I'll comment there. Sounds interesting!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17509] Notify patrons to return items requested on hold by another person

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16376] Koha::Calendar-> is_holiday date truncation creates fatal errors for TZ America/Santiago

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16376

--- Comment #27 from David Cook  ---
Hurray! Take that invalid local time for date in time zone...

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #44 from M. Tompsett  ---
Last piece... better handling of when passwords mismatch. :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17888] New: quickbooks enterprise support phone number 1 8884364111 quickbooks error support phone number

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17888

Bug ID: 17888
   Summary: quickbooks enterprise support phone number 1
8884364111 quickbooks error support phone number
 Change sponsored?: ---
   Product: Koha
   Version: 16.11
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: gmcha...@gmail.com
  Reporter: adam00...@yopmail.com
QA Contact: testo...@bugs.koha-community.org

quickbooks enterprise support phone number 1 8884364111 quickbooks error
support phone number tum jo ho mere quickbooks enterprise support phone number
1 8884364111 quickbooks error support phone number

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #43 from Alex Buckley  ---
Created attachment 58862
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58862=edit
Bug 17855- Fourth update following testing feedback.

Changed button and link names in web installer and onboarding tool

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17871] Can't retrieve facets (or zebra::snippet) from Zebra with YAZ 5.8.1

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17871

--- Comment #6 from David Cook  ---
Found the original email I wrote about this last year:

http://www.mail-archive.com/koha-devel@lists.koha-community.org/msg08132.html

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12930] Web installer does not show login errors

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12930

Alex Buckley  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |alexbuck...@catalyst.net.nz
   |ity.org |
 CC||alexbuck...@catalyst.net.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16733] More flexible paths in debian scripts (for dev installs)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16733

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

--- Comment #20 from David Cook  ---
I like this idea, but I don't use Debian often enough to be useful in terms of
testing...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #42 from Alex Buckley  ---
Created attachment 58861
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58861=edit
Bug 17855 -Third update follwing testing feedback

Removed the second path to creating a library, patron category, patron,
item type, and circulation rule. In onboarding .tt files and summary.tt

Fixed typo in summary.tt

Made consistent single space before and after -> in all onboarding .tt
and summary.tt files.

Made single  tag before path to create library, patron category,
item type, and circulation rule in the onboarding .tt files (patron does
not need this as its layout is slightly different)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #41 from M. Tompsett  ---
Comment on attachment 58860
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58860
Bug 17855 - Second update following testing feedback

Review of attachment 58860:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=17855=58860)
-

Very close! I can feel it.

::: koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep1.tt
@@ +37,1 @@
>  Administration->Libraries and groups

Sorry I was unclear, I mean this line too. The More->Administration->Libraries
and groups is part of the top of practically every page. Administration is only
on the main page.

::: koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep2.tt
@@ -298,1 @@
>   Administration->Patron categories

This line too.

::: koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep3.tt
@@ +105,5 @@
>   New Patron 
>  
>Success: New patron created!
> +  To create another patron, go to Patrons -> New Patron. 
> 
> +More->Set Permissions in a user page to gain superlibrarian 
> permissions.

Top line has spaces, bottom line doesn't with respect to ->.

::: koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep4.tt
@@ -46,1 @@
>  Administration->Item types

This line too.

::: koha-tmpl/intranet-tmpl/prog/en/modules/summary.tt
@@ +16,4 @@
>  
>  Library
>   To add another library and for more settings, go to 
> +More -> Administration -> Libraries and groups  OR

Okay. Standardized on ->, that's okay with me. But now this has spaces before
and after the ->, while the others don't. Choose how to make them consistent. I
personally like the lack of space, but it really doesn't matter. With spaces is
a quicker fix, so I'll understand. I may be being a tad pedantic in this
matter. And, the whole "OR ..." pieces (part of this line at the end, and the
next line) don't make sense to me, here and in the sections below.

@@ +25,1 @@
>  Administration->Patron categories

"OR ..." here.

@@ +25,5 @@
>  Administration->Patron categories
>  
>  Patron
> +To create another patron, go to Patrons -> New Patron. To set 
> the 
> +permissions of the patron, go to the patron's page and More -> 
> Set Permissions

YAY! See? Consistent. Nice!

@@ +34,1 @@
>  Administration->Item types

"OR ..." here.

@@ +34,5 @@
>  Administration->Item types
>  
>  Circulation Rule
>  To create another circulation rule, go to 
> +More -> Administration -> Circulation and Fine Rules.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #40 from Alex Buckley  ---
In reply to M. Tompsett from comment 38)
I removed that comment because I had already added that if statement to check
if the creation of the library was successful, see line 27 of
onboardingstep1.tt

I have now made all arrows -> throughout the onboarding tool, thank you for
noticing that.

The reason I added the additional paths in the summary.tt is because I wanted
to make the summary.tt consistent with the onboarding tool pages outlining how
to create a new library, patron category, patron, item type and circulation
rule. 

I have added back in the 'use CGI qw ( -utf8 );' into summary.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #39 from Alex Buckley  ---
Created attachment 58860
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58860=edit
Bug 17855 - Second update following testing feedback

Made arrows in onboarding tool pages
-> for consistency. Additionally removed the 'OR'

Added the use CGI qw ( -utf8 );

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17710] C4::Matcher::get_matches and C4::ImportBatch:: GetBestRecordMatch should use same logic

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17710

David Cook  changed:

   What|Removed |Added

   Severity|enhancement |minor

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17880] C4::Installer:: PerlModules lexicographical comparison is incorrect

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17880

David Cook  changed:

   What|Removed |Added

   Keywords||Academy

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17710] C4::Matcher::get_matches and C4::ImportBatch:: GetBestRecordMatch should use same logic

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17710

--- Comment #3 from David Cook  ---
Created attachment 58859
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58859=edit
Bug 17710 - C4::Matcher::get_matches and C4::ImportBatch::GetBestRecordMatch
should use same logic

C4::ImportBatch::GetBestRecordMatch uses SQL to sort by score descending
then candidate_match_id descending. With C4::Matcher::get_matches, I
implement the same sort but use Perl code to do it, since we're sorting
search results.

It's a simple change, but it's in a big block of code, so I don't have
unit tests.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17710] C4::Matcher::get_matches and C4::ImportBatch:: GetBestRecordMatch should use same logic

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17710

David Cook  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17882] C4::Installer::PerlModules::version_info() drops data during error handling

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17882

David Cook  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=17887

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17887] New: Dependency usage doesn' t show for upgrades or installed modules using version_info

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17887

Bug ID: 17887
   Summary: Dependency usage doesn't show for upgrades or
installed modules using version_info
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Installation and upgrade (command-line installer)
  Assignee: gmcha...@gmail.com
  Reporter: dc...@prosentient.com.au
QA Contact: testo...@bugs.koha-community.org

When using version_info with the module parameter, the usage information won't
show for modules that are installed or needing upgrade.

The cause is the same as bug 17882.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17887] Dependency usage doesn' t show for upgrades or installed modules using version_info

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17887

David Cook  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=17882

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17880] C4::Installer:: PerlModules lexicographical comparison is incorrect

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17880

--- Comment #5 from David Cook  ---
Created attachment 58858
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58858=edit
Bug 17880 - Use version.pm to parse version numbers in
C4::Installer::PerlModules

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17880] C4::Installer:: PerlModules lexicographical comparison is incorrect

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17880

David Cook  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

--- Comment #6 from David Cook  ---
Test Plan:

1) Apply patch "Bug 17880 - Add test to check version number comparison"
2) Run "perl t/Installer_PerlModules.t"
3) Note the following output:

not ok 19 - Version 0.9.13 is greater than 0.9.3, so no upgrade needed

#   Failed test 'Version 0.9.13 is greater than 0.9.3, so no upgrade needed'
#   at t/Installer_PerlModules.t line 51.
#  got: '1'
# expected: '0'
# Looks like you failed 1 test of 19.

4) Apply patch "Bug 17880 - Use version.pm to parse version numbers in
C4::Installer::PerlModules"
5) Run "perl t/Installer_PerlModules.t"
6) Note the following output:

ok 19 - Version 0.9.13 is greater than 0.9.3, so no upgrade needed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17880] C4::Installer:: PerlModules lexicographical comparison is incorrect

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17880

--- Comment #4 from David Cook  ---
Created attachment 58857
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58857=edit
Bug 17880 - Add test to check version number comparison

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17882] C4::Installer::PerlModules::version_info() drops data during error handling

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17882

--- Comment #7 from David Cook  ---
Arg... just noticed the usage doesn't show up for upgrades and installed
modules...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17880] C4::Installer:: PerlModules lexicographical comparison is incorrect

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17880

--- Comment #3 from David Cook  ---
(In reply to David Cook from comment #2)
> Removed the dependency on bug 17882 as they can actually be done
> separately...

Although whichever one comes second will need to be rebased...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17880] C4::Installer:: PerlModules lexicographical comparison is incorrect

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17880

--- Comment #2 from David Cook  ---
Removed the dependency on bug 17882 as they can actually be done separately...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17880] C4::Installer:: PerlModules lexicographical comparison is incorrect

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17880

David Cook  changed:

   What|Removed |Added

 Depends on|17882   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17882
[Bug 17882] C4::Installer::PerlModules::version_info() drops data during error
handling
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17882] C4::Installer::PerlModules::version_info() drops data during error handling

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17882

David Cook  changed:

   What|Removed |Added

 Blocks|17880   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17880
[Bug 17880] C4::Installer::PerlModules lexicographical comparison is incorrect
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7143] Bug for tracking changes to the about page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143

rjb  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
 CC||rjb-...@yandex.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7143] Bug for tracking changes to the about page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143

--- Comment #344 from rjb  ---
Created attachment 58856
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58856=edit
update about.tt with new devs

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17882] C4::Installer::PerlModules::version_info() drops data during error handling

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17882

David Cook  changed:

   What|Removed |Added

   Keywords||Academy

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17882] C4::Installer::PerlModules::version_info() drops data during error handling

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17882

--- Comment #6 from David Cook  ---
Test Plan:

1) Apply patch "Bug 17882 - Add missing module test to
Installer_PerlModules.t".
2) Run "perl t/Installer_PerlModules.t"
3) Note the following at the end of the test output:

not ok 18 - Minimum version found for missing module

#   Failed test 'Minimum version found for missing module'
#   at t/Installer_PerlModules.t line 48.
#  got: undef
# expected: '0.9.3'
# Looks like you planned 17 tests but ran 18.
# Looks like you failed 1 test of 18 run.

4) Apply patch "Bug 17882 - Fix C4::Installer::PerlModules::version_info()".
5) Run "perl t/Installer_PerlModules.t"
6) Note the following at the end of the test output:

ok 18 - Minimum version found for missing module

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17882] C4::Installer::PerlModules::version_info() drops data during error handling

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17882

David Cook  changed:

   What|Removed |Added

  Attachment #58853|0   |1
is obsolete||

--- Comment #5 from David Cook  ---
Created attachment 58855
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58855=edit
Bug 17882 - Fix C4::Installer::PerlModules::version_info()

If you're doing version_info() for a single uninstalled module,
you'll currently get null values and default values instead of
the values defined in C4::Installer::PerlDependencies.

This patch fixes the variable name for the module, and that
allows the correct data to be used.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17882] C4::Installer::PerlModules::version_info() drops data during error handling

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17882

David Cook  changed:

   What|Removed |Added

  Attachment #58851|0   |1
is obsolete||

--- Comment #4 from David Cook  ---
Created attachment 58854
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58854=edit
Bug 17882 - Add missing module test to Installer_PerlModules.t

Adds a test that checks the values declared for a missing Perl
dependency.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17882] C4::Installer::PerlModules::version_info() drops data during error handling

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17882

David Cook  changed:

   What|Removed |Added

  Attachment #58852|0   |1
is obsolete||

--- Comment #3 from David Cook  ---
Created attachment 58853
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58853=edit
Bug 17882 - Fix C4::Installer::PerlModules::version_info()

If you're doing version_info() for a single uninstalled module,
you'll currently get null values and default values instead of
the values defined in C4::Installer::PerlDependencies.

This patch fixes the variable name for the module, and that
allows the correct data to be used.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17882] C4::Installer::PerlModules::version_info() drops data during error handling

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17882

--- Comment #2 from David Cook  ---
Created attachment 58852
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58852=edit
Bug 17882 - Fix C4::Installer::PerlModules::version_info()

If you're doing version_info() for a single uninstalled module,
you'll currently get null values and default values instead of
the values defined in C4::Installer::PerlDependencies.

This patch fixes the variable name for the module, and that
allows the correct data to be used.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17882] C4::Installer::PerlModules::version_info() drops data during error handling

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17882

David Cook  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17882] C4::Installer::PerlModules::version_info() drops data during error handling

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17882

--- Comment #1 from David Cook  ---
Created attachment 58851
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58851=edit
Bug 17882 - Add missing module test to Installer_PerlModules.t

Adds a test that checks the values declared for a missing Perl
dependency.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7143] Bug for tracking changes to the about page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143

--- Comment #343 from rjb  ---
Created attachment 58850
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58850=edit
update history file

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063

Christopher Davis  changed:

   What|Removed |Added

 CC||cgda...@uintah.utah.gov

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4126] bulkmarcimport.pl allows -b and -a to be specified simultaneously

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4126

M. Tompsett  changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com

--- Comment #5 from M. Tompsett  ---
(In reply to Jonathan Druart from comment #4)
> Should not we also add the same exit if none are given instead of assuming
> it's biblio?
> 
> I can provide a patch if you agree with that.

While I agree that for clarity sake forcing people to specify is good, that
seems to be a problem beyond the scope of this bug. Also, one has to consider:
do you really want to have to type an extra 3 characters to run the command
when, for the most part, it will likely be biblios?

I think the default behaviour is adequate and see no reason to change it,
unless there is going to be a sweeping "we must be explicit about everything"
in all the parameters for all scripts. I vote for keeping it moving on to Pass
QA. :)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #38 from M. Tompsett  ---
Comment on attachment 58846
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58846
Bug 17855 - Removed html regex on patron password fields. Ran perltidy to
indent and space code appropriately. Ran git bz configuration commands to
remove whitespace. Removed unnecissary uses in the summary.pl script

Review of attachment 58846:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=17855=58846)
-

Nice improvements. Sorry if I was a little harsh before. You are doing great
for your first major attempt. I say major, because you are affecting more than
one file and adding a really nice pre-configuration setup. The fact that you
are trying and listening to feedback is plus in my books! Keep up the effort.
:) I'll test it in a bit.

::: koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep1.tt
@@ -43,4 @@
>  
>  
>  [%ELSE %]
> -

I'm just eyeballing this right now, but was this already dealt with? Why remove
it?

::: koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep3.tt
@@ -191,4 @@
>  
>  
>   class="required">Password: 
> - pattern="[A-Za-z1-9 ]+" title="Please only enter letters or numbers into this 
> password field" id="password" size="20" value="[% member.password |html %]" 
> class="required" required="required">

Thank you for removing this pattern stuff. The alternative was to include those
special characters, but then you would have to escape some of them.

::: koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep4.tt
@@ +42,5 @@
>   To create another item type later and for more 
> setttings 
> +go to: 
> +More->Administration->Item types 
> +or
> +Administration->Item types

Everything with - or not. And if there are things without, then without is the
way you should do it to maintain consistency. Plus, I do not think the or part
is necessary.

::: koha-tmpl/intranet-tmpl/prog/en/modules/summary.tt
@@ +16,5 @@
>  
>  Library
>   To add another library and for more settings, go to 
> +More > Administration > Libraries and groups  OR
> +Administration->Libraries and groups

There is no - in the original line. Also, no need for this change.

@@ +21,5 @@
>  
>  Patron Category
>  To add another patron category and for more settings, go 
> to
> +More > Administration > Patron Categories OR 
> +Administration->Patron categories

There is no - in the original line. Also, no need for this change.

@@ +30,5 @@
>  
>  Item Type
>  To create another item type and for more settings, go to
> +More > Administration > Item types  OR 
> +Administration->Item types

There is no - in the original line. Also, no need for this change.

::: summary.pl
@@ -21,5 @@
>  # along with Koha; if not, see .
>  
>  use Modern::Perl;
> -
> -use CGI qw ( -utf8 );

I would have kept this, since you have my $query = new CGI; later.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14398] Duplicate inventory results when an item is in the wrong place ( ie using branch/location filter)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14398

Mike  changed:

   What|Removed |Added

 CC||blac...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11405] Inventory tool enhancements

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11405

Mike  changed:

   What|Removed |Added

 CC||blac...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4037] Inventory Tool Missing Item Type Filter

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4037

Mike  changed:

   What|Removed |Added

 CC||blac...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14677] Inventory: Compare Barcodes List to Result function

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14677

Mike  changed:

   What|Removed |Added

 CC||blac...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8685] Inventory tool fails in timeout with large CB files

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8685

Mike  changed:

   What|Removed |Added

 CC||blac...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10707] inventory not removing lost status

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10707

Mike  changed:

   What|Removed |Added

 CC||blac...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12733] Interactive inventory tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12733

Mike  changed:

   What|Removed |Added

 CC||blac...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17817] Repeat this Tag (cloning) not working

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17817

Josef Moravec  changed:

   What|Removed |Added

  Attachment #58845|0   |1
is obsolete||

--- Comment #20 from Josef Moravec  ---
Created attachment 58849
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58849=edit
[SIGNED-OFF] Bug 17817: (Follow up) Fix reordering subfields issues

Authority controlled subfields have invisible divs which produced
a strange behavior when reordering (multiple clicks were needed
to push a subfield up over an authority controlled subfield)

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17817] Repeat this Tag (cloning) not working

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17817

Josef Moravec  changed:

   What|Removed |Added

  Attachment #58847|0   |1
is obsolete||

--- Comment #19 from Josef Moravec  ---
Created attachment 58848
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58848=edit
[SIGNED-OFF] Bug 17817: Fix cloning subfields using select2

Based on Jonathan's patch (the DO NOT PUSH one), I put together this fix.
What was changed is that select2 is reinitialized only after the cloned element
has been appended to the DOM (so that select2 can correctly calculate the
field's
width). Also, I changed the selectors that searched for the line divs (for
reordering)
and for the subfield's input element (for erasing the field's value) to be more
specific,
since select2 introduced divs that broke some assumptions about the expected
HTML structure

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17817] Repeat this Tag (cloning) not working

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17817

Josef Moravec  changed:

   What|Removed |Added

  Attachment #58844|0   |1
is obsolete||

--- Comment #18 from Josef Moravec  ---
Created attachment 58847
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58847=edit
[SIGNED-OFF] Bug 17817: Fix cloning subfields using select2

Based on Jonathan's patch (the DO NOT PUSH one), I put together this fix.
What was changed is that select2 is reinitialized only after the cloned element
has been appended to the DOM (so that select2 can correctly calculate the
field's
width). Also, I changed the selectors that searched for the line divs (for
reordering)
and for the subfield's input element (for erasing the field's value) to be more
specific,
since select2 introduced divs that broke some assumptions about the expected
HTML structure

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17817] Repeat this Tag (cloning) not working

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17817

Josef Moravec  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #37 from Alex Buckley  ---
I have gone through and made the changes recommended in comments 33, 34, and
35, and attached the commit (see its name below) to this bug:

Bug 17855 - Removed html regex on patron password fields. Ran perltidy to
indent and space code appropriately. Ran git bz configuration commands to
remove whitespace. Removed unnecissary uses in the summary.pl script 

I have tested the bug in a clean branch and it applies successfully for me.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #36 from Alex Buckley  ---
Created attachment 58846
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58846=edit
Bug 17855 - Removed html regex on patron password fields. Ran perltidy to
indent and space code appropriately. Ran git bz configuration commands to
remove whitespace. Removed unnecissary uses in the summary.pl script

These changes are based on feedback from testing.

Test plan:
1. Go through the web installer and onboarding tool as outlined in this
guide:
https://koha-community.org/manual/installation/html/

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17817] Repeat this Tag (cloning) not working

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17817

--- Comment #17 from Patricio Marrone  ---
I added fixes to the regressions discovered by Jonathan. Are there more places
where these select2 fields need to be cloned?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17817] Repeat this Tag (cloning) not working

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17817

Patricio Marrone  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17817] Repeat this Tag (cloning) not working

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17817

Patricio Marrone  changed:

   What|Removed |Added

  Attachment #58828|0   |1
is obsolete||

--- Comment #16 from Patricio Marrone  ---
Created attachment 58845
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58845=edit
Bug 17817: (Follow up) Fix reordering subfields issues

Authority controlled subfields have invisible divs which produced
a strange behavior when reordering (multiple clicks were needed
to push a subfield up over an authority controlled subfield)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17817] Repeat this Tag (cloning) not working

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17817

Patricio Marrone  changed:

   What|Removed |Added

  Attachment #58827|0   |1
is obsolete||

--- Comment #15 from Patricio Marrone  ---
Created attachment 58844
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58844=edit
Bug 17817: Fix cloning subfields using select2

Based on Jonathan's patch (the DO NOT PUSH one), I put together this fix.
What was changed is that select2 is reinitialized only after the cloned element
has been appended to the DOM (so that select2 can correctly calculate the
field's
width). Also, I changed the selectors that searched for the line divs (for
reordering)
and for the subfield's input element (for erasing the field's value) to be more
specific,
since select2 introduced divs that broke some assumptions about the expected
HTML structure

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8685] Inventory tool fails in timeout with large CB files

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8685

Josef Moravec  changed:

   What|Removed |Added

 CC||josef.mora...@gmail.com

--- Comment #7 from Josef Moravec  ---
It's still an issue, also after bug 14057. 

I did just few thousands inventory, and I faced time out (version 16.05.04).

I like the background job idea...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17809] ER country twice in fr-FR database files

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809

--- Comment #10 from Jonathan Druart  
---
yep

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9157] Enhance inventory tool to skip checked out barcodes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9157

Josef Moravec  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME
 CC||josef.mora...@gmail.com

--- Comment #7 from Josef Moravec  ---
(In reply to Marc Véron from comment #6)
> Still valid?

I don't think so, we have "Skip items on loan" option in inventory tool, it
should do the trick

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17809] ER country twice in fr-FR database files

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809

--- Comment #9 from M. Tompsett  ---
(In reply to Jonathan Druart from comment #8)
> Nope, I'd suggest just to display a warning message if (ER, Allemagne)
> exists.

So, don't correct it. Just give pretty red upgrade messages?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15905] Remove use of makepayment

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15905

--- Comment #17 from Jonathan Druart  
---
Created attachment 58843
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58843=edit
Bug 15905: Remove one last occurrence of makepayment in comment

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17886] New: Don' t show option to add to existing list if there are no lists

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17886

Bug ID: 17886
   Summary: Don't show option to add to existing list if there are
no lists
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
   URL: /cgi-bin/koha/virtualshelves/addbybiblionumber.pl?bibl
ionumber=X
OS: All
Status: NEW
  Keywords: Academy
  Severity: minor
  Priority: P5 - low
 Component: Lists
  Assignee: gmcha...@gmail.com
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

If you add a title to a list by choosing 'Add To' -> 'List' from the toolbar on
the detail page, a pop-up window is triggered. This window has a section for
"Select an existing list" and "Add to a new list." The first should not display
if there are no existing lists.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15905] Remove use of makepayment

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15905

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15905] Remove use of makepayment

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15905

--- Comment #16 from Jonathan Druart  
---
Created attachment 58842
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58842=edit
Bug 15905 - Remove use of makepayment

Test Plan:
1) Apply these patches
2) prove t/db_dependent/Accounts.t
3) 'git grep makepayment' should return no results

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15907] Remove use of makepayment in opac/ opac-account-pay-paypal-return.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15907

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #20 from Jonathan Druart  
---
I have squashed the 2 patches.
I did not test the paypal payment but the code looks good.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15905] Remove use of makepayment

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15905

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #58831|0   |1
is obsolete||
  Attachment #58832|0   |1
is obsolete||

--- Comment #15 from Jonathan Druart  
---
Created attachment 58841
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58841=edit
Bug 15905 - Update unit tests

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15907] Remove use of makepayment in opac/ opac-account-pay-paypal-return.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15907

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #58829|0   |1
is obsolete||
  Attachment #58830|0   |1
is obsolete||

--- Comment #19 from Jonathan Druart  
---
Created attachment 58840
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58840=edit
Bug 15907 - Remove use of makepayment in opac/opac-account-pay-paypal-return.pl

Test Plan:
1) Apply this patch
2) Make a payment via PayPal in sandbox mode
3) Note the payment succeeds

Signed-off-by: Josef Moravec 

Bug 15907 [QA Followup] - Simplify code and call pay() only once

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15907] Remove use of makepayment in opac/ opac-account-pay-paypal-return.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15907

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4126] bulkmarcimport.pl allows -b and -a to be specified simultaneously

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4126

Jonathan Druart  changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |mag...@libriotech.no

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4126] bulkmarcimport.pl allows -b and -a to be specified simultaneously

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4126

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #4 from Jonathan Druart  
---
Should not we also add the same exit if none are given instead of assuming it's
biblio?

I can provide a patch if you agree with that.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5670] Housebound Readers Module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

--- Comment #140 from Jonathan Druart  
---
Yep, IIRC the goal with this first patch was to get a first shoot in.
As you can see with the quantity of patches and the low number of this bug
report, it was a long standing one.

AFAIK there is nothing planned yet to improve this feature.
But Alex must know better than me: )

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

Chris Cormack  changed:

   What|Removed |Added

 CC||ch...@bigballofwax.co.nz

--- Comment #35 from Chris Cormack  ---
(In reply to M. Tompsett from comment #32)
> Oh wow! Okay, I didn't understand the coolness of this until I started
> testing. It's going to take too long to test, and I need sleep, but so far
> so good.
> 
> Oh no! Spoke too soon. Seriously?! What is it with programmers taking away
> my symbols as part of passwords? Sorry, but I experienced this on another
> website (www.scene.ca) that I use as well, so the issue is a hot spot for me
> right now.
> 
> https://www.owasp.org/index.php/Password_special_characters
> http://www.ibm.com/support/knowledgecenter/SSEQTP_8.5.5/com.ibm.websphere.
> base.doc/ae/csec_chars.html
> 

This must be just a JavaScript regex Alex, I'd drop that part of the check.

> I can't enter a password for Koha that I have used before. :(
Mark what? Koha can't possibly know what you old password was. Do you mean you
can't enter a password that is already in use? That's way outside the scope of
this then.

Please remember too to keep chill when you are dealing with a first time
commiter. Or we will never have 2nd time commiters :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17817] Repeat this Tag (cloning) not working

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17817

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #14 from Jonathan Druart  
---
Still 2 regressions:
1/ On the add item form, it does not work
2/ Try to clone a whole field containing select2: TypeError:
divs[i].getAttribute(...) is null

You know, I really think that we should go first with my patch, then try to fix
it on another bug report. This is critical as it impacts stable releases.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5670] Housebound Readers Module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

--- Comment #139 from Paul Poulain  ---
thx for your quick answer joubu.
Then, in my opinion, it lowers a lot the interest of the feature. Anyone around
planning/thinking of adding this kind of feature (a kind of "housebound
dashboard")

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14608] HEA : add possibility of sharing usage statistics in Administration page and Web installer

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14608

--- Comment #23 from Jonathan Druart  
---
(In reply to M. Tompsett from comment #22)
> But they could, if they were onboard'd. See bug 17855 for some enhancement
> dreaming. :)

Bug 17855 is huge and does not seem to be ready to be pushed.
I'd prefer not to wait for it to get this one in.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5670] Housebound Readers Module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

--- Comment #138 from Jonathan Druart  
---
(In reply to Paul Poulain from comment #136)
> OK, guys, I've a functional question:
>  * I'm a chooser = how do I know that today (or tomorrow, or next weeks)
> I'll have to do some choices ?
>  * I'm a deliverer = same question : how do I know I've to deliver ?

The information is only displayed on the patron detail pages at the intranet
(show+edit views) and on the housebound page (tab HouseBound in the member
module). Nothing at the OPAC.

>  * I want to take profit of this service, can I register from the OPAC ?

Nope :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #58834|0   |1
is obsolete||
  Attachment #58835|0   |1
is obsolete||
  Attachment #58836|0   |1
is obsolete||

--- Comment #30 from Kyle M Hall  ---
Created attachment 58837
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58837=edit
Bug 14570 - Make it possible to add multiple guarantors to a record

This patch adds the ability to set an unlimited number of guarantors
for a given patron. As before, each guarantor may be linked to another
Koha patron, and all the behavior that applies to a given guarantor
remains the same.

Test Plan:
 1) Apply this patch
 2) Run updatedatabase.pl
 3) Find some patrons with guarantors, verify the still have their guarantor
 4) Test adding and removing guarantors on a patron record, both Koha users and
not
 5) Verify the "Add child" button works
 6) Verify NoIssuesChargeGuarantees still works
 7) Verify tools/cleanborrowers.pl will not delete a guarantor
 8) Verify the guarantors are displayed on moremember.pl
 9) Verify the guarantor is removed by members/update-child.pl
10) Verify the guarantor is removed by misc/cronjobs/j2a.pl
11) Verify import patrons converts guarantor_id, relationship,
contactfirstname,
  and contactsurname into a guarantor
12) prove t/Patron.t
13) prove t/db_dependent/Circulation.t
14) prove t/db_dependent/Circulation/NoIssuesChargeGuarantees.t
15) prove t/db_dependent/Items.t
16) prove t/db_dependent/Koha/Patrons.t
17) prove t/db_dependent/Members.t
18) prove t/db_dependent/Patron/Relationships.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

--- Comment #32 from Kyle M Hall  ---
Created attachment 58839
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58839=edit
Bug 14570 - Followup

Fix small errors in update child script

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

--- Comment #31 from Kyle M Hall  ---
Created attachment 58838
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58838=edit
Bug 14570 - Update Schema

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

M. Tompsett  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=14608

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14608] HEA : add possibility of sharing usage statistics in Administration page and Web installer

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14608

M. Tompsett  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=17855

--- Comment #22 from M. Tompsett  ---
(In reply to Owen Leonard from comment #17)
> I would like to see a new last step at the end of the installation process
> where the usage statistics preferences could be saved directly. That is,
> show the whole form from admin/usage_statistics.pl.

In bug 17855, the whole onboarding (must be regional or expertise lingo)
process could deal with that.


(In reply to Jonathan Druart from comment #21)
> That was the first idea, but finally I don't know if it is a good one.
> For instance if we want to add geoloc info (bug 17802) or other info at
> branch level, the form will not be complete at the end of the installer
> (branches do not exist yet).

But they could, if they were onboard'd. See bug 17855 for some enhancement
dreaming. :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12353] Reserves last pickup date needs to respect holidays, and everybody need to know the last pickup date for reserves, even notices.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12353

David Kuhn  changed:

   What|Removed |Added

 CC||techservs...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

--- Comment #29 from Kyle M Hall  ---
Created attachment 58836
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58836=edit
Bug 14570 - Followup

Fix small errors in update child script

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #58762|0   |1
is obsolete||
  Attachment #58763|0   |1
is obsolete||
  Attachment #58764|0   |1
is obsolete||

--- Comment #27 from Kyle M Hall  ---
Created attachment 58834
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58834=edit
Bug 14570 - Make it possible to add multiple guarantors to a record

This patch adds the ability to set an unlimited number of guarantors
for a given patron. As before, each guarantor may be linked to another
Koha patron, and all the behavior that applies to a given guarantor
remains the same.

Test Plan:
 1) Apply this patch
 2) Run updatedatabase.pl
 3) Find some patrons with guarantors, verify the still have their guarantor
 4) Test adding and removing guarantors on a patron record, both Koha users and
not
 5) Verify the "Add child" button works
 6) Verify NoIssuesChargeGuarantees still works
 7) Verify tools/cleanborrowers.pl will not delete a guarantor
 8) Verify the guarantors are displayed on moremember.pl
 9) Verify the guarantor is removed by members/update-child.pl
10) Verify the guarantor is removed by misc/cronjobs/j2a.pl
11) Verify import patrons converts guarantor_id, relationship,
contactfirstname,
  and contactsurname into a guarantor
12) prove t/Patron.t
13) prove t/db_dependent/Circulation.t
14) prove t/db_dependent/Circulation/NoIssuesChargeGuarantees.t
15) prove t/db_dependent/Items.t
16) prove t/db_dependent/Koha/Patrons.t
17) prove t/db_dependent/Members.t
18) prove t/db_dependent/Patron/Relationships.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

--- Comment #28 from Kyle M Hall  ---
Created attachment 58835
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58835=edit
Bug 14570 - Update Schema

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

Kyle M Hall  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063

Lisette  changed:

   What|Removed |Added

 CC||lisettesla...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12353] Reserves last pickup date needs to respect holidays, and everybody need to know the last pickup date for reserves, even notices.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12353

Lisette  changed:

   What|Removed |Added

 CC||lisettesla...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5670] Housebound Readers Module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

--- Comment #137 from Paul Poulain  ---
PS : sorry Claire, I know you're not a guy ;-)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5670] Housebound Readers Module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

Paul Poulain  changed:

   What|Removed |Added

 CC||paul.poul...@biblibre.com

--- Comment #136 from Paul Poulain  ---
OK, guys, I've a functional question:
 * I'm a chooser = how do I know that today (or tomorrow, or next weeks) I'll
have to do some choices ?
 * I'm a deliverer = same question : how do I know I've to deliver ?
 * I want to take profit of this service, can I register from the OPAC ?

Thank you for any answer/feedback ;-)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15894] Unify all account fine payment functions

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15894

M. Tompsett  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=5620

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5620] Capture Mode of payment

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5620

M. Tompsett  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=15894
 CC||mtomp...@hotmail.com

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7046] subscription renewal period should be a pull down

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7046

Josef Moravec  changed:

   What|Removed |Added

 CC||josef.mora...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/