[Koha-bugs] [Bug 17907] Sessions Table disappearing continuously

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17907

Mubassir Ahsan  changed:

   What|Removed |Added

Summary|Sessions Table disappearing |Sessions Table disappearing
   |continuously while google   |continuously
   |authentication is on|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17907] New: Sessions Table disappearing continuously while google authentication is on

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17907

Bug ID: 17907
   Summary: Sessions Table disappearing continuously while google
authentication is on
 Change sponsored?: ---
   Product: Project Infrastructure
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Continuous Integration
  Assignee: tomasco...@gmail.com
  Reporter: mahsa...@gmail.com

Created attachment 58984
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58984=edit
Messages when the problem occurs.

>From recent days after upgrading to Koha-16.11 Sessions table dissappearing
like it is not there. We need to re-enter the table to login to staff area. 

Steps to reproduce: 
I am unable to give any steps. But when the problem occurs. Staff login is
impossible.

Possible Solution: 
If you restore the sessions table or drop and recreate. It works again
perfectly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17808] When editing circulation conditions, only ask for confirmation when there is already a rule selected

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17808

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com

--- Comment #7 from Nick Clemens  ---
This is definitely an improvement but a case worth mentioning:

Change a bunch of the dropdowns and enter no other data, no warning on editing
a new rule. I don't know if it would be feasible to tackle this, and the
current patches offer huge improvement so marking PQA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17808] When editing circulation conditions, only ask for confirmation when there is already a rule selected

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17808

Nick Clemens  changed:

   What|Removed |Added

  Attachment #58652|0   |1
is obsolete||

--- Comment #6 from Nick Clemens  ---
Created attachment 58983
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58983=edit
Bug 17808: Fix behavior when editing a circ rule

The original behavior is broken, see
https://stackoverflow.com/questions/21410484/jquery-selector-to-find-out-count-of-non-empty-inputs

Test plan:
Edit a circ rule
=> Without this patch you get a useless message
=> With this patch, no message
Edit a circ rule with content in inputs
=> With or without this patch you get a useful message

Signed-off-by: Katrin Fischer 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17808] When editing circulation conditions, only ask for confirmation when there is already a rule selected

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17808

Nick Clemens  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5594] Option to configure default sort order for items on bib records

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5594

Marjorie Barry-Vila  changed:

   What|Removed |Added

 CC||marjorie.barry-v...@ccsr.qc
   ||.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17906] New: Add possibility to blacklist MARC subfield with notesblacklist

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17906

Bug ID: 17906
   Summary: Add possibility to blacklist MARC subfield with
notesblacklist
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: marjorie.barry-v...@ccsr.qc.ca
QA Contact: testo...@bugs.koha-community.org

Hi,

We have ability to blacklist a entire field with sys pref notesblacklist but it
would be great to have possibility to only blacklist a subfield like "583 $x".

Regards
Marjorie

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17697] Notes Blacklist only blacklists fields on the OPAC main detail view ( not the OPAC MARC display)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17697

Marjorie Barry-Vila  changed:

   What|Removed |Added

 CC||marjorie.barry-v...@ccsr.qc
   ||.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17836] (ILSDI) 'charges' always '1'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17836

Nick Clemens  changed:

   What|Removed |Added

  Attachment #58574|0   |1
is obsolete||

--- Comment #9 from Nick Clemens  ---
Created attachment 58982
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58982=edit
Bug 17836: (ILSDI) Regression test

Sponsored-by: ByWater Solutions

Signed-off-by: Mark Tompsett 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17836] (ILSDI) 'charges' always '1'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17836

Nick Clemens  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17836] (ILSDI) 'charges' always '1'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17836

Nick Clemens  changed:

   What|Removed |Added

  Attachment #58575|0   |1
is obsolete||

--- Comment #8 from Nick Clemens  ---
Created attachment 58981
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58981=edit
Bug 17836: (ILSDI) Make GetPatronInfo fill 'charges' correctly

This trivial fix corrects a typo on C4/ILSDI/Services.pm.
It was hidden because the tests for ILSDI only cover the 'attributes'
portion of the response. I added regression tests for this.

To test:
- Have the regression test patch applied
- Run:
  $ prove t/db_dependent/ILSDI_Services.t
=> FAIL: Tests fail because 'charges' is always set to 1
- Apply the patch
- Run:
  $ prove t/db_dependent/ILSDI_Services.t
=> SUCCESS: Tests pass
- Sign off :-D

Sponsored-by: ByWater Solutions

Signed-off-by: Mark Tompsett 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15273] Fines Payment receipt should include all account lines selected for this pay

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15273

Marjorie Barry-Vila  changed:

   What|Removed |Added

 CC||marjorie.barry-v...@ccsr.qc
   ||.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

M. Tompsett  changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com

--- Comment #48 from M. Tompsett  ---
Rebased, and corrected atomic update filename. :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

M. Tompsett  changed:

   What|Removed |Added

  Attachment #58976|0   |1
is obsolete||

--- Comment #46 from M. Tompsett  ---
Created attachment 58979
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58979=edit
Bug 14570 - Update Schema

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

M. Tompsett  changed:

   What|Removed |Added

  Attachment #58977|0   |1
is obsolete||

--- Comment #47 from M. Tompsett  ---
Created attachment 58980
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58980=edit
Bug 14570 - Followup

Fix small errors in update child script

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

M. Tompsett  changed:

   What|Removed |Added

  Attachment #58975|0   |1
is obsolete||

--- Comment #45 from M. Tompsett  ---
Created attachment 58978
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58978=edit
Bug 14570 - Make it possible to add multiple guarantors to a record

This patch adds the ability to set an unlimited number of guarantors
for a given patron. As before, each guarantor may be linked to another
Koha patron, and all the behavior that applies to a given guarantor
remains the same.

Test Plan:
 1) Apply this patch
 2) Run updatedatabase.pl
 3) Find some patrons with guarantors, verify the still have their guarantor
 4) Test adding and removing guarantors on a patron record, both Koha users and
not
 5) Verify the "Add child" button works
 6) Verify NoIssuesChargeGuarantees still works
 7) Verify tools/cleanborrowers.pl will not delete a guarantor
 8) Verify the guarantors are displayed on moremember.pl
 9) Verify the guarantor is removed by members/update-child.pl
10) Verify the guarantor is removed by misc/cronjobs/j2a.pl
11) Verify import patrons converts guarantor_id, relationship,
contactfirstname,
  and contactsurname into a guarantor
12) prove t/Patron.t
13) prove t/db_dependent/Circulation.t
14) prove t/db_dependent/Circulation/NoIssuesChargeGuarantees.t
15) prove t/db_dependent/Items.t
16) prove t/db_dependent/Koha/Patrons.t
17) prove t/db_dependent/Members.t
18) prove t/db_dependent/Patron/Relationships.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

M. Tompsett  changed:

   What|Removed |Added

  Attachment #58973|0   |1
is obsolete||

--- Comment #43 from M. Tompsett  ---
Created attachment 58976
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58976=edit
Bug 14570 - Update Schema

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

M. Tompsett  changed:

   What|Removed |Added

  Attachment #58974|0   |1
is obsolete||

--- Comment #44 from M. Tompsett  ---
Created attachment 58977
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58977=edit
Bug 14570 - Followup

Fix small errors in update child script

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

M. Tompsett  changed:

   What|Removed |Added

  Attachment #58972|0   |1
is obsolete||

--- Comment #42 from M. Tompsett  ---
Created attachment 58975
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58975=edit
Bug 14570 - Make it possible to add multiple guarantors to a record

This patch adds the ability to set an unlimited number of guarantors
for a given patron. As before, each guarantor may be linked to another
Koha patron, and all the behavior that applies to a given guarantor
remains the same.

Test Plan:
 1) Apply this patch
 2) Run updatedatabase.pl
 3) Find some patrons with guarantors, verify the still have their guarantor
 4) Test adding and removing guarantors on a patron record, both Koha users and
not
 5) Verify the "Add child" button works
 6) Verify NoIssuesChargeGuarantees still works
 7) Verify tools/cleanborrowers.pl will not delete a guarantor
 8) Verify the guarantors are displayed on moremember.pl
 9) Verify the guarantor is removed by members/update-child.pl
10) Verify the guarantor is removed by misc/cronjobs/j2a.pl
11) Verify import patrons converts guarantor_id, relationship,
contactfirstname,
  and contactsurname into a guarantor
12) prove t/Patron.t
13) prove t/db_dependent/Circulation.t
14) prove t/db_dependent/Circulation/NoIssuesChargeGuarantees.t
15) prove t/db_dependent/Items.t
16) prove t/db_dependent/Koha/Patrons.t
17) prove t/db_dependent/Members.t
18) prove t/db_dependent/Patron/Relationships.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

M. Tompsett  changed:

   What|Removed |Added

  Attachment #58953|0   |1
is obsolete||

--- Comment #40 from M. Tompsett  ---
Created attachment 58973
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58973=edit
Bug 14570 - Update Schema

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

M. Tompsett  changed:

   What|Removed |Added

  Attachment #58952|0   |1
is obsolete||

--- Comment #39 from M. Tompsett  ---
Created attachment 58972
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58972=edit
Bug 14570 - Make it possible to add multiple guarantors to a record

This patch adds the ability to set an unlimited number of guarantors
for a given patron. As before, each guarantor may be linked to another
Koha patron, and all the behavior that applies to a given guarantor
remains the same.

Test Plan:
 1) Apply this patch
 2) Run updatedatabase.pl
 3) Find some patrons with guarantors, verify the still have their guarantor
 4) Test adding and removing guarantors on a patron record, both Koha users and
not
 5) Verify the "Add child" button works
 6) Verify NoIssuesChargeGuarantees still works
 7) Verify tools/cleanborrowers.pl will not delete a guarantor
 8) Verify the guarantors are displayed on moremember.pl
 9) Verify the guarantor is removed by members/update-child.pl
10) Verify the guarantor is removed by misc/cronjobs/j2a.pl
11) Verify import patrons converts guarantor_id, relationship,
contactfirstname,
  and contactsurname into a guarantor
12) prove t/Patron.t
13) prove t/db_dependent/Circulation.t
14) prove t/db_dependent/Circulation/NoIssuesChargeGuarantees.t
15) prove t/db_dependent/Items.t
16) prove t/db_dependent/Koha/Patrons.t
17) prove t/db_dependent/Members.t
18) prove t/db_dependent/Patron/Relationships.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

M. Tompsett  changed:

   What|Removed |Added

  Attachment #58954|0   |1
is obsolete||

--- Comment #41 from M. Tompsett  ---
Created attachment 58974
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58974=edit
Bug 14570 - Followup

Fix small errors in update child script

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14608] HEA : add possibility of sharing usage statistics in Administration page and Web installer

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14608

M. Tompsett  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #32 from M. Tompsett  ---
I've signed off on this, but given that my patch is an attempt to address #26
and #27, I'll let someone else like Owen or Jonathan sign it off to get it
ready for QA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14608] HEA : add possibility of sharing usage statistics in Administration page and Web installer

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14608

M. Tompsett  changed:

   What|Removed |Added

  Attachment #58341|0   |1
is obsolete||

--- Comment #29 from M. Tompsett  ---
Created attachment 58969
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58969=edit
Bug 14608: Add a link from the admin home page

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14608] HEA : add possibility of sharing usage statistics in Administration page and Web installer

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14608

--- Comment #31 from M. Tompsett  ---
Created attachment 58971
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58971=edit
Bug 14608: Follow up on labels and search box

This addresses concerns raised in comment #26 and comment #27.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14608] HEA : add possibility of sharing usage statistics in Administration page and Web installer

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14608

M. Tompsett  changed:

   What|Removed |Added

  Attachment #58342|0   |1
is obsolete||

--- Comment #30 from M. Tompsett  ---
Created attachment 58970
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58970=edit
Bug 14608: Add a reference to Hea at the end of the installer process

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14608] HEA : add possibility of sharing usage statistics in Administration page and Web installer

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14608

M. Tompsett  changed:

   What|Removed |Added

  Attachment #58340|0   |1
is obsolete||

--- Comment #28 from M. Tompsett  ---
Created attachment 58968
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58968=edit
Bug 14608: Add a page to configure shared statistics

This patch set adds:
- a reference to Hea at the end of the installation process
- a link to the new page from the admin home page
- a new page to easily configure shared statistics

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14608] HEA : add possibility of sharing usage statistics in Administration page and Web installer

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14608

--- Comment #27 from M. Tompsett  ---
Comment on attachment 58340
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58340
Bug 14608: Add a page to configure shared statistics

Review of attachment 58340:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=14608=58340)
-

::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/usage_statistics.tt
@@ +8,5 @@
> +
> +
> +
> +[% INCLUDE 'header.inc' %]
> +[% INCLUDE 'patrons-admin-search.inc' %]

I'm not sure this is the correct search area to have at the top of the page.
The value of script_name isn't defined, and while empty works on patron
categories administrative page, it doesn't work here.
I'm thinking cat-search.inc might be better.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8361] Issuing rule if no rule is defined

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8361

--- Comment #11 from Nick Clemens  ---
Created attachment 58967
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58967=edit
Bug 8361 (QA Followup) Add warnings

- Added message to mainpage.pl if no rules defined
 - Added message to circulation.tt to warn if rule undefined for
patron/itemtype combination

To test:
1 - Remove all rules
2 - Note that there is a warning on mainpage
3 - Add one rule
4 - Checkout to patron an itemtype that is outside of rule
defined above
5 - Note explanation that no rule is deifned

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8361] Issuing rule if no rule is defined

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8361

Nick Clemens  changed:

   What|Removed |Added

  Attachment #57717|0   |1
is obsolete||

--- Comment #10 from Nick Clemens  ---
Created attachment 58966
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58966=edit
Bug 8361: Do not allow checkouts if no rules are defined

We should require a circulation rule to allow checkouts and reject them
if no rules are defined.

Test plan:
- Delete all issuing rules
- Check an item out
=> Without this patch the checkout is allowed
=> With this patch applied it is rejected

Signed-off-by: Mark Tompsett 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #76 from M. Tompsett  ---
(In reply to Owen Leonard from comment #75)
> (In reply to M. Tompsett from comment #73)
> > There is system preference setting code run when that page is displayed.
> > This ties into the notion of advanced would let you skip onboarding
> > completely or particular steps.
> 
> I'm sorry, I don't understand this comment.



"koha-tmpl/intranet-tmpl/prog/en/modules/installer/step3.tt"

elsif ( $op && $op eq 'finish' ) {
$installer->set_version_syspref();
...
$template->param( "$op" => 1 );
}
"installer/install.pl"

[% IF ( finish ) %]
Congratulations, installation complete
If this page does not redirect in 5 seconds, click here.
[% END %]
"koha-tmpl/intranet-tmpl/prog/en/modules/installer/step3.tt"

-- which reminds me. Can someone change this to 10, or the 10 in the meta to 5?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16034] Integration with OverDrive Patron API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034

Nick Clemens  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17602] Integrate support for ONeclickDigital/Recorded Books API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

Nick Clemens  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #75 from Owen Leonard  ---
(In reply to M. Tompsett from comment #73)
> (In reply to Owen Leonard from comment #71)
> > I think if you have chosen the basic installation the "Select all options"
> > button should be down next to the options which one can select.
> 
> How about floating near the top (or bottom) like the save/cancel on... is it
> the system preference pages?

No, that's not necessary. It's on the page where you select data to import. The
"select all" control is only relevant, in this case, to the options which can
be checked or unchecked. It should be displayed at the top of that section of
the page.

> > I don't think there needs to be a "We're just going to set up a few more
> > things..." page.
> 
> There is system preference setting code run when that page is displayed.
> This ties into the notion of advanced would let you skip onboarding
> completely or particular steps.

I'm sorry, I don't understand this comment.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #74 from Owen Leonard  ---
koha-tmpl/intranet-tmpl/prog/en/modules/installer/Backupstep3.tt

Is this file used for something?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #73 from M. Tompsett  ---
(In reply to Owen Leonard from comment #71)
> I think if you have chosen the basic installation the "Select all options"
> button should be down next to the options which one can select.

How about floating near the top (or bottom) like the save/cancel on... is it
the system preference pages?


> I don't think there needs to be a "We're just going to set up a few more
> things..." page. We were told on the previous page that this step was coming.

There is system preference setting code run when that page is displayed.
This ties into the notion of advanced would let you skip onboarding completely
or particular steps.


[SNIP Other great suggestions]
> I think this is going to be a really good addition to Koha. It just needs a
> few fixups!

Which is why I was working really hard on this sign off. I think it is a
fantastic idea. :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #72 from M. Tompsett  ---
Forgive the interjection, but I have commentary on some of this.

> 1/ I have tried the basic and advanced mode, the only difference I noticed
> is that checkboxes do not appear on the next screen.
> If it is the only difference, I do not see the point of that parameter.

http://irc.koha-community.org/koha/2017-01-12#i_1893213


> 2/ Before your patch, the "Select all options" was a button. It was intended
> and is the correct element to use

Sorry for not catching that.


> 3/ When all the default data are select, we get pages saying "there is
> nothing to do because the data are already inserted". I think it would be
> better to skip these screen and not to see them at all.

Sometimes it is educational to see what you are skipping. Not to mention it is
easier to code that way. ;)


> 4/ The forms are not using the usual Koha style

Granted. I think Owen's commentary covers that. And given the Owen's expertise,
some good suggestions in that regard.


> 5/ About the circulation rule, how did you pick the value to define?
> For instance "Current on-site checkouts allowed" is not configurable and the
> default value becomes "unlimited". I do not think it is the desirable
> behavior.

Is this a "keep it blank it still goes" problem?


> 6/ I would suggest to add an option to skip the onboarding Should be an
> option, we need a way to skip it

http://irc.koha-community.org/koha/2017-01-12#i_1893279
This would give Advanced more meaning. But rather than keep expanding the scope
of this bug, let's push that to another bug.


> 7/ At the end of the installer, the button "finish" has been replaced with
> "set koha version system preference". The wording sounds wrong.

http://irc.koha-community.org/koha/2017-01-12#i_1893252
If you read the code, that is what actually seems to happen.


> Maybe we need to have 2 choices at that point:
> - Set up Koha with the onboarding tool
> - Finish (and skip the onboarding tool)

See back to the Basic/Advanced discussion.


> 8/ Cardnumber:
> From the template you use "minlength_cardnumber", but it's not pass from the
> script (I may missed something).
> The behavior of the validation is not correct, a cardnumber can be composed
> with alpha chars.

Oops. Sorry for missing that.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6782] Move auto member cardnumber generation to occur when record is "Saved" (avoid collisions)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6782

--- Comment #19 from Jonathan Druart  
---
(In reply to Jonathan Druart from comment #18)
> This broke t/db_dependent/Reserves.t
> 
> t/db_dependent/Reserves.t .. 1/72 Can't use an undefined value as a HASH
> reference at /home/vagrant/kohaclone/C4/Members.pm line 502.
> 
> Please fix ASAP

And 17 other files.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6782] Move auto member cardnumber generation to occur when record is "Saved" (avoid collisions)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6782

--- Comment #18 from Jonathan Druart  
---
This broke t/db_dependent/Reserves.t

t/db_dependent/Reserves.t .. 1/72 Can't use an undefined value as a HASH
reference at /home/vagrant/kohaclone/C4/Members.pm line 502.

Please fix ASAP

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9047] show hold info on self check out

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9047

Agnes Rivers-Moore  changed:

   What|Removed |Added

  Component|Hold requests   |Self checkout

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9047] show hold info on self check out

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9047

Agnes Rivers-Moore  changed:

   What|Removed |Added

 CC||a...@hanover.ca

--- Comment #1 from Agnes Rivers-Moore  ---
I definitely think it would be useful if an item that is awaiting pickup would
show up as a message on the self-checkout screen.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17898] Add a way to automatically convert SQL reports

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17898

Josef Moravec  changed:

   What|Removed |Added

 CC||josef.mora...@gmail.com

--- Comment #4 from Josef Moravec  ---
As of bug 16239 is pushed, the templates should use bootstrap 3.

Also, I tried to update one of my custom reports, but it looks like only first
occurence of marcxml was changed...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17898] Add a way to automatically convert SQL reports

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17898

--- Comment #3 from Josef Moravec  ---
Created attachment 58961
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58961=edit
Bug 17898: Followup - udpate templates for bootstrap 3

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17899] Show only mine does not work in newordersuggestion.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17899

Fridolin SOMERS  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17899] Show only mine does not work in newordersuggestion.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17899

--- Comment #1 from Fridolin SOMERS  ---
Created attachment 58957
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58957=edit
Bug 17899 - Show only mine does not work in newordersuggestion.pl

Bug 12775 added a link "Show only mine" in newordersuggestion.pl.
This does not work, no results.

Also corrects the fact that click must not do default action by adding
e.preventDefault().

Test plan :
- You must have suggestions you have accepted
- Create a new order from suggestion :
/cgi-bin/koha/acqui/newordersuggestion.pl
- Click on Show only mine
=> Without patch the table is empty showing "No matching records found"
=> With patch you see only suggestions you have accpeted

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12775] Only suggestion manager can order from accepted suggestion

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12775

Fridolin SOMERS  changed:

   What|Removed |Added

 Blocks||17899


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17899
[Bug 17899] Show only mine does not work in newordersuggestion.pl
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17851] Add elasticsearch config to koha-conf.xml

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17851

--- Comment #2 from Olli-Antti Kivilahti  ---
Created attachment 58956
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58956=edit
Bug 17851 - Add elasticsearch config to koha-conf.xml - Add missing entries to
koha-install-log

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17899] New: Show only mine does not work in newordersuggestion.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17899

Bug ID: 17899
   Summary: Show only mine does not work in newordersuggestion.pl
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: fridolin.som...@biblibre.com
QA Contact: testo...@bugs.koha-community.org

Bug 12775 added a link "Show only mine" in newordersuggestion.pl.
This does not work, no results.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17899] Show only mine does not work in newordersuggestion.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17899

Fridolin SOMERS  changed:

   What|Removed |Added

 Depends on||12775


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12775
[Bug 12775] Only suggestion manager can order from accepted suggestion
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17898] Add a way to automatically convert SQL reports

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17898

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17898] Add a way to automatically convert SQL reports

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17898

--- Comment #1 from Jonathan Druart  
---
Created attachment 58955
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58955=edit
Bug 17898: Automagically convert SQL reports

Bug 17196 move the marcxml out of the biblioitems table.
That will break SQL reports using it.
It would be handy to propose an automagically way to convert the SQL
reports.

We do not want to update the reports automatically without user inputs,
it will be too hasardous.
However we can lead the user to convert them.

In this patchset I suggest to warn the user if a report is subject to be
updated.

TODO: Add a way to mark this job done (using a pref?) to remove the
check and not to display false positives.

Test plan:
- Create some SQL reports (see
https://wiki.koha-community.org/wiki/SQL_Reports_Library)
- Go on the report list page (/reports/guided_reports.pl?phase=Use saved)
- For the reports using biblioitems.marcxml you will see a new column
warning you that it is obsolete
- Click on update link
=> that will open a modal with the converted SQL query
- Click on the update button
=> you will be informed that the query has been updated

If all the reports are updated, the new column "Update" will no longer
be displayed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17898] Add a way to automatically convert SQL reports

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17898

--- Comment #2 from Jonathan Druart  
---
Note that this is not polish, but not needed to as it won't be something used
on a daily basis.
If someone wants, feel free :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||17898


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17898
[Bug 17898] Add a way to automatically convert SQL reports
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17898] Add a way to automatically convert SQL reports

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17898

Jonathan Druart  changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |jonathan.dru...@bugs.koha-c
   ||ommunity.org
 Status|NEW |ASSIGNED
 Depends on||17196


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196
[Bug 17196] Move marcxml out of the biblioitems table
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17898] New: Add a way to automatically convert SQL reports

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17898

Bug ID: 17898
   Summary: Add a way to automatically convert SQL reports
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Reports
  Assignee: gmcha...@gmail.com
  Reporter: jonathan.dru...@bugs.koha-community.org
QA Contact: testo...@bugs.koha-community.org

Bug 17196 move the marcxml out of the biblioitems table.
That will break SQL reports using it.
It would be handy to propose an automagically way to convert the SQL reports.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #71 from Owen Leonard  ---
I agree that the inconsistent style is a problem. I wonder if we shouldn't
simply include the default staff client CSS in addition to the
installer-specific CSS.

I think if you have chosen the basic installation the "Select all options"
button should be down next to the options which one can select.

I don't think there needs to be a "We're just going to set up a few more
things..." page. We were told on the previous page that this step was coming.

I think the "Add a patron category" stage should make it clear that the
category you define is going to be the one which the new administrator patron
will have.

I think the "Create patron" stage should say something like "Create Koha
administrator patron" so that it is very clear that the patron you create will
will be a superlibrarian.

The "Create patron" stage wouldn't accept the card number I typed in. The
validator said it wasn't a number. It would only let me increment the number
that was prefilled.

The "Create a new Item type" should have some text explaining what an item type
is, including the important point that it is what Koha uses to apply
circulation rules.

Please run all the onboarding steps through an HTML validator. I use this addon
in Firefox: http://users.skynet.be/mgueury/mozilla/

Capitalization is all over the place. Only the first letter of heading, label,
etc. should be capitalized:

https://wiki.koha-community.org/wiki/Coding_Guidelines#HTML4:_Upper_and_lower_cases_in_strings

I think this is going to be a really good addition to Koha. It just needs a few
fixups!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17874] Bug 16239 followup - update bootstrap 3 usage

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17874

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com
 Status|Passed QA   |Pushed to Master

--- Comment #5 from Kyle M Hall  ---
Pushed to master for 17.05, thanks Josef!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16239] Upgrade Bootstrap in the staff client

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239

Kyle M Hall  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||k...@bywatersolutions.com

--- Comment #100 from Kyle M Hall  ---
Pushed to master for 17.05, thanks Josef, Owen!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com
 Status|Passed QA   |Pushed to Master

--- Comment #128 from Kyle M Hall  ---
Pushed to master for 17.05, thanks Jonathan, Nick, Marcel!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14608] HEA : add possibility of sharing usage statistics in Administration page and Web installer

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14608

Owen Leonard  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #26 from Owen Leonard  ---
Can I add one small request before this goes to QA?

In the form, instead of:

Your country: 

It should be a real  tag:

Your country: 

 is used when we want to have a line in a form which isn't
a label/form field pair, but we want the style to look consistent. See for
example, the "City ID" line when editing a city in Administration.

Along with that, each corresponding  or  should have an "id"
attribute which matches the "for" attribute of the label. This allows the user
to click the label to move the focus to the corresponding form field.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14608] HEA : add possibility of sharing usage statistics in Administration page and Web installer

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14608

Hugo Agud  changed:

   What|Removed |Added

 CC||ha...@orex.es
 Status|Needs Signoff   |Signed Off

--- Comment #25 from Hugo Agud  ---
I have tested and it works fine! I have not activated the cronjobs because
we're on development environment.

I have not create the signed patch, because I stll doesn'r know how to do it,
soon I will do.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #3 from Owen Leonard  ---
I think this looks good, but there are some issues that need to be looked at:

I think that if there is no email address for the logged-in user's library the
page should not offer to email the librarian. In my test if I submit a report
to the librarian and there is no email address for my home library, the entry
saved in message_queue has an empty 'to_address' field.

There are HTML validation errors triggered by duplicate id attributes on form
fields. The form fields on the two different tabs should not have the same ids
(note that input name and id attributes do not have to match);

Also, in the OPAC (and soon to be the case in the staff client), page-specific
JavaScript goes into a special BLOCK which is processed in the footer include.
So instead of this, at the end of opac-reportaproblem.tt:

[% BLOCK jsinclude %][% END %]


$(document).ready(function(){
$("#reportproblem").tabs();
});


It should be:

[% BLOCK jsinclude %]

$(document).ready(function(){
$("#reportproblem").tabs();
});

[% END %]

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17775] Add new user with LDAP not works under Plack

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17775

Fridolin SOMERS  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4031] Expand EnableOpacSearchHistory options for controlling search history

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4031

Magnus Enger  changed:

   What|Removed |Added

 CC||mag...@libriotech.no

--- Comment #3 from Magnus Enger  ---
What is the default behaviour today? Looking at the search_history table of one
of my sites it looks like logging is only done for logged in users?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17799] MARC bibliographic frameworks breadcrumbs broken for Default framework

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17799

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com
 Status|Passed QA   |Pushed to Master

--- Comment #4 from Kyle M Hall  ---
Pushed to master for 17.05, thanks Aleisha!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17629] Koha::Biblio - Remove ModBiblioframework

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17629

Kyle M Hall  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||k...@bywatersolutions.com

--- Comment #6 from Kyle M Hall  ---
Pushed to master for 17.05, thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17486] Remove 'Mozilla Persona' as an authentication method

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17486

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com
 Status|Passed QA   |Pushed to Master

--- Comment #10 from Kyle M Hall  ---
Pushed to master for 17.05, thanks Marcel, Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17466] Show number of outstanding issues when checking in

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17466

Kyle M Hall  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||k...@bywatersolutions.com

--- Comment #10 from Kyle M Hall  ---
Pushed to master for 17.05, thanks Josef!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17181] Patron card creator replaces existing image when uploading image with same name

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17181

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com
 Status|Passed QA   |Pushed to Master

--- Comment #8 from Kyle M Hall  ---
Pushed to master for 17.05, thanks Aleisha, Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14187] branchtransfer needs a primary key (id) for DBIx and common sense.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14187

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com
 Status|Passed QA   |Pushed to Master

--- Comment #20 from Kyle M Hall  ---
Pushed to master for 17.11, thanks Olli, Tomas!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196

Marcel de Rooy  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
   |y.org   |
   Patch complexity|--- |Medium patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196

--- Comment #127 from Marcel de Rooy  ---
(In reply to Josef Moravec from comment #126)
> (In reply to Marcel de Rooy from comment #125)
> > Last comments:
> > 
> > > Changes in Koha/OAI/Server/ListRecords.pm is planned on bug 15108.
> > Failed QA several weeks ago. The author did not respond until now.
> > 
> 
> Ere Maijala is primerly working on VuFind development, so probably we could
> try to contact them by e-mail directly to ask if he is plannig to work a bit
> on this OAI enhancement.

Josef,
If you know him, could you please ask him for rebase and feedback.
Thanks

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

--- Comment #38 from Kyle M Hall  ---
Created attachment 58954
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58954=edit
Bug 14570 - Followup

Fix small errors in update child script

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

--- Comment #37 from Kyle M Hall  ---
Created attachment 58953
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58953=edit
Bug 14570 - Update Schema

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #58949|0   |1
is obsolete||
  Attachment #58950|0   |1
is obsolete||
  Attachment #58951|0   |1
is obsolete||

--- Comment #36 from Kyle M Hall  ---
Created attachment 58952
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58952=edit
Bug 14570 - Make it possible to add multiple guarantors to a record

This patch adds the ability to set an unlimited number of guarantors
for a given patron. As before, each guarantor may be linked to another
Koha patron, and all the behavior that applies to a given guarantor
remains the same.

Test Plan:
 1) Apply this patch
 2) Run updatedatabase.pl
 3) Find some patrons with guarantors, verify the still have their guarantor
 4) Test adding and removing guarantors on a patron record, both Koha users and
not
 5) Verify the "Add child" button works
 6) Verify NoIssuesChargeGuarantees still works
 7) Verify tools/cleanborrowers.pl will not delete a guarantor
 8) Verify the guarantors are displayed on moremember.pl
 9) Verify the guarantor is removed by members/update-child.pl
10) Verify the guarantor is removed by misc/cronjobs/j2a.pl
11) Verify import patrons converts guarantor_id, relationship,
contactfirstname,
  and contactsurname into a guarantor
12) prove t/Patron.t
13) prove t/db_dependent/Circulation.t
14) prove t/db_dependent/Circulation/NoIssuesChargeGuarantees.t
15) prove t/db_dependent/Items.t
16) prove t/db_dependent/Koha/Patrons.t
17) prove t/db_dependent/Members.t
18) prove t/db_dependent/Patron/Relationships.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

--- Comment #34 from Kyle M Hall  ---
Created attachment 58950
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58950=edit
Bug 14570 - Update Schema

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

--- Comment #35 from Kyle M Hall  ---
Created attachment 58951
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58951=edit
Bug 14570 - Followup

Fix small errors in update child script

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #58837|0   |1
is obsolete||
  Attachment #58838|0   |1
is obsolete||
  Attachment #58839|0   |1
is obsolete||

--- Comment #33 from Kyle M Hall  ---
Created attachment 58949
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58949=edit
Bug 14570 - Make it possible to add multiple guarantors to a record

This patch adds the ability to set an unlimited number of guarantors
for a given patron. As before, each guarantor may be linked to another
Koha patron, and all the behavior that applies to a given guarantor
remains the same.

Test Plan:
 1) Apply this patch
 2) Run updatedatabase.pl
 3) Find some patrons with guarantors, verify the still have their guarantor
 4) Test adding and removing guarantors on a patron record, both Koha users and
not
 5) Verify the "Add child" button works
 6) Verify NoIssuesChargeGuarantees still works
 7) Verify tools/cleanborrowers.pl will not delete a guarantor
 8) Verify the guarantors are displayed on moremember.pl
 9) Verify the guarantor is removed by members/update-child.pl
10) Verify the guarantor is removed by misc/cronjobs/j2a.pl
11) Verify import patrons converts guarantor_id, relationship,
contactfirstname,
  and contactsurname into a guarantor
12) prove t/Patron.t
13) prove t/db_dependent/Circulation.t
14) prove t/db_dependent/Circulation/NoIssuesChargeGuarantees.t
15) prove t/db_dependent/Items.t
16) prove t/db_dependent/Koha/Patrons.t
17) prove t/db_dependent/Members.t
18) prove t/db_dependent/Patron/Relationships.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17817] Repeat this Tag (cloning) not working

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17817

--- Comment #27 from Patricio Marrone  ---
(In reply to Kyle M Hall from comment #24)
> Pushed to master for 17.05, thanks Patricia!

(In reply to Kyle M Hall from comment #25)
> Apologies, thanks Patricio!

Thanks Kyle! No problem :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16083] Accept CLI params for the Makefile.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16083

Kyle M Hall  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||k...@bywatersolutions.com

--- Comment #9 from Kyle M Hall  ---
Pushed to master for 17.05, thanks Alex!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17817] Repeat this Tag (cloning) not working

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17817

--- Comment #26 from Patricio Marrone  ---
(In reply to Jonathan Druart from comment #23)
> Great job Patricio!
> Do not forget to add a test plan, for you next patches :)

Thanks Jonathan :) . I'm glad to help. I'll try to put together the steps
needed to test the changes and won't forget to add them next time.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6782] Move auto member cardnumber generation to occur when record is "Saved" (avoid collisions)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6782

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com
 Status|Passed QA   |Pushed to Master

--- Comment #17 from Kyle M Hall  ---
Pushed to master for 17.05, thanks Meenakshi!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17879] Possible to upload images with no image name

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17879

Kyle M Hall  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||k...@bywatersolutions.com

--- Comment #4 from Kyle M Hall  ---
Pushed to master for 17.05, thanks Aleisha!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17859] Move JavaScript to the footer on about and auth pages

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17859

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com
 Status|Passed QA   |Pushed to Master

--- Comment #6 from Kyle M Hall  ---
Pushed to master for 17.05, thanks Owen!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17817] Repeat this Tag (cloning) not working

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17817

--- Comment #25 from Kyle M Hall  ---
Apologies, thanks Patricio!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17778] Make "Earliest Registered Date" in OAI-PMH dynamic

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17778

Josef Moravec  changed:

   What|Removed |Added

 Blocks||15108


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108
[Bug 15108] OAI-PMH provider improvements
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15108] OAI-PMH provider improvements

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108

Josef Moravec  changed:

   What|Removed |Added

 Depends on||17778

--- Comment #75 from Josef Moravec  ---
Needs rebase due to bug 17778


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17778
[Bug 17778] Make "Earliest Registered Date" in OAI-PMH dynamic
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17741] Use Koha::Patron->holds in Koha::Patron->delete

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17741

Kyle M Hall  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||k...@bywatersolutions.com

--- Comment #8 from Kyle M Hall  ---
Pushed to master for 17.05, thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17800] Add admin sidebar menu to marc-subfields-structure.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17800

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com
 Status|Passed QA   |Pushed to Master

--- Comment #6 from Kyle M Hall  ---
Pushed to master for 17.05, thanks Aleisha!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17740] Add the Koha::Patron->holds method

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17740

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com
 Status|Passed QA   |Pushed to Master

--- Comment #4 from Kyle M Hall  ---
Pushed to master for 17.05, thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17447] Remove unused vars from batchRebuildItemsTables.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17447

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com
 Status|Passed QA   |Pushed to Master

--- Comment #19 from Kyle M Hall  ---
Pushed to master for 17.05, thanks Marcel, Mark!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17794] Menu items in Tools menu and Admin menu not bold when active but not on linked page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17794

Kyle M Hall  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||k...@bywatersolutions.com

--- Comment #10 from Kyle M Hall  ---
Pushed to master for 17.05, thanks Aleisha!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17778] Make "Earliest Registered Date" in OAI-PMH dynamic

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17778

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com
 Status|Passed QA   |Pushed to Master

--- Comment #6 from Kyle M Hall  ---
Pushed to master for 17.05, thanks Magnus, Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17265] Make koha-create and koha-dump-defaults less greedy

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17265

Kyle M Hall  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||k...@bywatersolutions.com

--- Comment #9 from Kyle M Hall  ---
Pushed to master for 17.05, thanks Magnus!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17766] Patron notification does not work with multi item holds

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17766

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com
 Status|Passed QA   |Pushed to Master

--- Comment #5 from Kyle M Hall  ---
Pushed to master for 17.05, thanks Benjamin!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17766] Patron notification does not work with multi item holds

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17766

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #58536|0   |1
is obsolete||

--- Comment #4 from Kyle M Hall  ---
Created attachment 58948
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58948=edit
Bug 17766 - Patron notification does not work with multi item holds

This patch fixes notification when same biblio has multiple reserves with same
borrower,
introduced in Bug 14695. C4::Reserves::ModReserveAffect uses internal method
_koha_notify_reserve but sends itemnumber and biblionumber instead of
record_id.

To test:
Prerequisites:
- One biblio with two items attached
- A patron with hold_filled notification activated
- A letter for HOLD with <> in it
1) Place two reservations on same biblio
2) checkin item x on pickup branch, observe patron message generated
3) checkin item y on pickup branch, observe patron message generated
4) note that reserve_id is the same on both messages, which is wrong
5) apply this patch and repeat 1-3
6) now observe notifications have correct (different) reserve_id

Signed-off-by: Hugo Agud 
Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17870] Call to include file incorrectly moved into the footer

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17870

Kyle M Hall  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #5 from Kyle M Hall  ---
Pushed to master for 17.05, thanks Owen!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196

--- Comment #126 from Josef Moravec  ---
(In reply to Marcel de Rooy from comment #125)
> Last comments:
> 
> > Changes in Koha/OAI/Server/ListRecords.pm is planned on bug 15108.
> Failed QA several weeks ago. The author did not respond until now.
> 

Ere Maijala is primerly working on VuFind development, so probably we could try
to contact them by e-mail directly to ask if he is plannig to work a bit on
this OAI enhancement.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17725] Repeating a field or subfield clones content

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17725

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com
 Status|Passed QA   |Pushed to Master

--- Comment #13 from Kyle M Hall  ---
Pushed to master for 17.05, thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17817] Repeat this Tag (cloning) not working

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17817

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com
 Status|Passed QA   |Pushed to Master

--- Comment #24 from Kyle M Hall  ---
Pushed to master for 17.05, thanks Patricia!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/