[Koha-bugs] [Bug 3782] delivered z39.50 targets wrong for NY Public Library and NY University Library

2017-01-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3782

g...@rabbat.net  changed:

   What|Removed |Added

 CC||g...@rabbat.net

--- Comment #19 from g...@rabbat.net  ---
Most recent information I have that works for the New York City Public Library
is:

host: ilsstaff.nypl.org
port: 210
db name: innopac

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17856] Add API endpoint for item types

2017-01-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17856

--- Comment #1 from Jiri Kozlovsky  ---
Created attachment 58994
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58994&action=edit
Added REST API endpoint for item types

To test:
1) Go to /api/v1/item_types
2) Check there were returned all item types

I'm sorry I couldn't create unit tests because I have somehow broken
kohadevbox installation :/ .. nor "koha-shell kohadevbox" works :(

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17856] Add API endpoint for item types

2017-01-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17856

Jiri Kozlovsky  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12656] Send a notice to patrons when their hold was cancelled

2017-01-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12656

Lisette  changed:

   What|Removed |Added

 CC||lisettesla...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17314] REST API: Add API route to create, list and delete a purchase suggestion

2017-01-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314

Jiri Kozlovsky  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17314] REST API: Add API route to create, list and delete a purchase suggestion

2017-01-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314

--- Comment #11 from Jiri Kozlovsky  ---
Created attachment 58993
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58993&action=edit
QA followup

test plan unchanged

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17908] Authority merge omnibus

2017-01-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17908

Josef Moravec  changed:

   What|Removed |Added

 CC||josef.mora...@gmail.com

--- Comment #6 from Josef Moravec  ---
(In reply to Marcel de Rooy from comment #5)

Sounds reasonable, I'll be happy to test and sign off. Thanks for your
attention!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17909] Add unit tests for authority merge

2017-01-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17909

Zeno Tajoli  changed:

   What|Removed |Added

 CC||z.taj...@cineca.it

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17908] Authority merge omnibus

2017-01-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17908

Zeno Tajoli  changed:

   What|Removed |Added

 CC||z.taj...@cineca.it

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16018] merges not modifying biblios properly

2017-01-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16018

Marcel de Rooy  changed:

   What|Removed |Added

  Component|Cataloging  |MARC Authority data support

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16018] merges not modifying biblios properly

2017-01-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16018

Marcel de Rooy  changed:

   What|Removed |Added

Version|3.22|master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15032] [Plack] Scripts that fork (like stage-marc-import.pl) don' t work as expected

2017-01-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15032

Marcel de Rooy  changed:

   What|Removed |Added

Summary|(Plack) Stage MARC records  |[Plack] Scripts that fork
   |for import breaks in Plack  |(like stage-marc-import.pl)
   ||don't work as expected

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17908] Authority merge omnibus

2017-01-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17908

--- Comment #5 from Marcel de Rooy  ---
This subject is touched in many reports and we have a lot of duplicated code.
The solutions under 5572/11315/11700 are more comprehensive and make merge
behavior pref controlled. Somehow we need to *merge* the best of code from
11315, 11700 and 5572 in order to get further.
I would suggest to copy tests from 11315/11700 and my own extended test
originally aimed for 9988 to report 17909 as a starting point to verify the
current merge routine.
On that we should build the core changes from 5572/11315/11700. (Include the
the $field->replace fix from 5572.) My suggestion for the pref name is
AuthorityMergeMode btw.

I checked the following reports and propose the following order to get some
progress:

[CLOSED] 03343 Duplicates
[CLOSED] 05821 Enable cron job
[CLOSED] 16802 Clearing subfields
[CLOSED] 12791 dontmerge is confusing
[CLOSED] 14583 Deleting subfields
[CLOSED] 13760 What about two 700s linking to the same authority

[START] 17909 Add tests for authority merge
[PHASE2] 05572 Improve C4::AuthoritiesMarc->merge() + syspref AuthCleanBiblios
[PHASE2] 11315 Subfield deletion (overwriteSubfieldsOnMerge)
[PHASE2] 11700 C4::AuthoritiesMarc::merge enhancements/fixes 
[PHASE3] 14769 Correct indicators in merge
[PHASE4/BLOCKED] 16018 Not properly merged (authorities/merge.pl) 
[PHASE5] 09988 AuthorityMergeLimit (instead of dontmerge) 
[PHASE6] 14026 Deleting an authority

Did I forget a report, or would you suggest a different order, please tell.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17908] Authority merge omnibus

2017-01-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17908

Marcel de Rooy  changed:

   What|Removed |Added

 CC||philippe.blo...@inlibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17908] Authority merge omnibus

2017-01-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17908

Marcel de Rooy  changed:

   What|Removed |Added

 CC||charles.far...@inlibro.com,
   ||fcapovi...@live.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17908] Authority merge omnibus

2017-01-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17908

Marcel de Rooy  changed:

   What|Removed |Added

 CC||frede...@tamil.fr

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17908] Authority merge omnibus

2017-01-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17908

Marcel de Rooy  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17908] Authority merge omnibus

2017-01-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17908

Marcel de Rooy  changed:

   What|Removed |Added

 CC||julian.maur...@biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13760] Authorities merge sometimes create duplicate fields in biblio

2017-01-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13760

Marcel de Rooy  changed:

   What|Removed |Added

 Blocks|17908   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17908
[Bug 17908] Authority merge omnibus
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17908] Authority merge omnibus

2017-01-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17908

Marcel de Rooy  changed:

   What|Removed |Added

 Depends on|13760   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13760
[Bug 13760] Authorities merge sometimes create duplicate fields in biblio
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17908] Authority merge omnibus

2017-01-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17908

Marcel de Rooy  changed:

   What|Removed |Added

 CC||rkopac...@afm.edu.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17908] Authority merge omnibus

2017-01-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17908
Bug 17908 depends on bug 13760, which changed state.

Bug 13760 Summary: Authorities merge sometimes create duplicate fields in biblio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13760

   What|Removed |Added

 Status|In Discussion   |RESOLVED
 Resolution|--- |DUPLICATE

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17908] Authority merge omnibus

2017-01-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17908

Marcel de Rooy  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #4 from Marcel de Rooy  ---
*** Bug 13760 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13760] Authorities merge sometimes create duplicate fields in biblio

2017-01-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13760

Marcel de Rooy  changed:

   What|Removed |Added

 Status|RESOLVED|CLOSED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13760] Authorities merge sometimes create duplicate fields in biblio

2017-01-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13760

Marcel de Rooy  changed:

   What|Removed |Added

 Status|In Discussion   |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #9 from Marcel de Rooy  ---
I am closing this report in favor of more comprehensive solutions under
5572/11315/11700.
See omnibus bug 17908.
Thanks for your work.

*** This bug has been marked as a duplicate of bug 17908 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17908] Authority merge omnibus

2017-01-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17908

Marcel de Rooy  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=12791

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17908] Authority merge omnibus

2017-01-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17908

Marcel de Rooy  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=5821

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5821] Enable cron job for merge_authorities.pl

2017-01-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5821

Marcel de Rooy  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=17908

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12791] 'dontmerge' syspref has confusing/incorrect usage description

2017-01-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12791

Marcel de Rooy  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=17908

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16018] merges not modifying biblios properly

2017-01-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16018

Marcel de Rooy  changed:

   What|Removed |Added

 Blocks||17908


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17908
[Bug 17908] Authority merge omnibus
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14769] Authorities merge: Set correct indicators in biblio field

2017-01-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14769

Marcel de Rooy  changed:

   What|Removed |Added

 Blocks||17908


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17908
[Bug 17908] Authority merge omnibus
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17909] Add unit tests for authority merge

2017-01-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17909

Marcel de Rooy  changed:

   What|Removed |Added

 Blocks||17908


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17908
[Bug 17908] Authority merge omnibus
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17908] Authority merge omnibus

2017-01-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17908

Marcel de Rooy  changed:

   What|Removed |Added

 Depends on||5572, 9988, 11315, 11700,
   ||13760, 14026, 14769, 16018,
   ||17909


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5572
[Bug 5572] Improve C4::AuthoritiesMarc->merge() + syspref AuthCleanBiblios
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988
[Bug 9988] Leave larger authority merges to merge_authority cronjob (pref
AuthorityMergeLimit)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11315
[Bug 11315] Add support for subfield deletion when doing authority merges.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
[Bug 11700] C4::AuthoritiesMarc::merge enhancements/fixes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13760
[Bug 13760] Authorities merge sometimes create duplicate fields in biblio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14026
[Bug 14026] Deleting Authority record tag does not update bibliographic marc
record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14769
[Bug 14769] Authorities merge: Set correct indicators in biblio field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16018
[Bug 16018] merges not modifying biblios properly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17909
[Bug 17909] Add unit tests for authority merge
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14026] Deleting Authority record tag does not update bibliographic marc record

2017-01-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14026

Marcel de Rooy  changed:

   What|Removed |Added

 Blocks||17908


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17908
[Bug 17908] Authority merge omnibus
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11700] C4::AuthoritiesMarc::merge enhancements/fixes

2017-01-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700

Marcel de Rooy  changed:

   What|Removed |Added

 Blocks||17908


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17908
[Bug 17908] Authority merge omnibus
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13760] Authorities merge sometimes create duplicate fields in biblio

2017-01-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13760

Marcel de Rooy  changed:

   What|Removed |Added

 Blocks||17908


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17908
[Bug 17908] Authority merge omnibus
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11315] Add support for subfield deletion when doing authority merges.

2017-01-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11315

Marcel de Rooy  changed:

   What|Removed |Added

 Blocks||17908


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17908
[Bug 17908] Authority merge omnibus
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5572] Improve C4::AuthoritiesMarc->merge() + syspref AuthCleanBiblios

2017-01-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5572

Marcel de Rooy  changed:

   What|Removed |Added

 Blocks||17908


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17908
[Bug 17908] Authority merge omnibus
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authority cronjob ( pref AuthorityMergeLimit)

2017-01-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988

Marcel de Rooy  changed:

   What|Removed |Added

 Blocks||17908


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17908
[Bug 17908] Authority merge omnibus
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16018] merges not modifying biblios properly

2017-01-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16018

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Needs Signoff   |BLOCKED

--- Comment #10 from Marcel de Rooy  ---
Interesting patch! I will add it to the omnibus bug 17908 in order to get all
authority merge reports further.
I temporarily change the status of this patch to Blocked, but will be coming
back to it (hopefully) shortly.
You refer to a new pref overwriteSubfieldsOnMerge that does not yet exist and
comes in several flavors: AuthCleanBiblios or AuthorityMergeMode etc.
If we get the pref in and some changes in merge, this should follow.
Have some patience. Thanks.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14583] Subfields not deleted when automatically merging authorities.

2017-01-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14583

Marcel de Rooy  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|In Discussion   |RESOLVED

--- Comment #5 from Marcel de Rooy  ---
I am closing this report in favor of the bugs under omnibus bug 17908. This
subject is touched in many reports and we have a lot of duplicated code. The
solution under 5572/11315/11700 are more comprehensive and make this behavior
pref controlled.

*** This bug has been marked as a duplicate of bug 17908 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14583] Subfields not deleted when automatically merging authorities.

2017-01-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14583

Marcel de Rooy  changed:

   What|Removed |Added

 Status|RESOLVED|CLOSED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17908] Authority merge omnibus

2017-01-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17908

Marcel de Rooy  changed:

   What|Removed |Added

 CC||maxime.beaul...@inlibro.com

--- Comment #3 from Marcel de Rooy  ---
*** Bug 14583 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11315] Add support for subfield deletion when doing authority merges.

2017-01-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11315

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl

--- Comment #11 from Marcel de Rooy  ---
I am putting this one in the merge omnibus bug 17908.
The pref overwriteSubfieldsOnMerge is called AuthCleanBiblios on 5572. I
thought of a name like AuthorityMergeMode. The loose mode would not touch, the
strict mode would clear/overwrite. I am not sure if the loose mode conflicts
with cataloguing rules btw..

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12791] 'dontmerge' syspref has confusing/incorrect usage description

2017-01-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12791

Marcel de Rooy  changed:

   What|Removed |Added

 Status|RESOLVED|CLOSED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12791] 'dontmerge' syspref has confusing/incorrect usage description

2017-01-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12791

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl
 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #5 from Marcel de Rooy  ---
Closing this bug in favor of bug 9988. See also bug omnibus 17908

*** This bug has been marked as a duplicate of bug 9988 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12798] 'dontmerge' syspref has incorrect usage description, in manual

2017-01-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12798
Bug 12798 depends on bug 12791, which changed state.

Bug 12791 Summary: 'dontmerge' syspref has confusing/incorrect usage description
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12791

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authority cronjob ( pref AuthorityMergeLimit)

2017-01-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m...@kohaaloha.com

--- Comment #5 from Marcel de Rooy  ---
*** Bug 12791 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13760] Authorities merge sometimes create duplicate fields in biblio

2017-01-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13760

--- Comment #8 from Marcel de Rooy  ---
(In reply to Jacek Ablewicz from comment #6)
>700 $9 11 $a Son Goku $t Aaa Bbb
>700 $9 12 $a Vegeta $t Ddd Ccc
>700 $9 12 $a Vegeta $t Eee Fff

> While having 2+ $9 links to the same
> authority record from one biblio record is probably not very common
> (depending on the material type, local cataloguing rules etc.), AFAIK this
> can happen occasionally and in such cases it's not always necessarily an
> error and/or a duplicate.

Can anyone confirm that this case is a valid one with reference to cataloguing
rules etc.?

This discussion comes up actually on several of the reports in this category.
Suppose that we would have a 'strict' merge mode and a 'loose' merge mode, that
either removes all extra subfields or leaves them untouched in the biblio
record while merging, would that be sufficient? See also the AuthCleanBiblios
pref of bug 5572; I would btw rather call it something like AuthorityMergeMode.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16802] Linking to a new authority does not clear subfields appropriately

2017-01-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16802

Marcel de Rooy  changed:

   What|Removed |Added

 Status|RESOLVED|CLOSED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16802] Linking to a new authority does not clear subfields appropriately

2017-01-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16802

Marcel de Rooy  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|NEW |RESOLVED

--- Comment #2 from Marcel de Rooy  ---
Closing this one in favor of bugs under omnibus bug 17908.
Could be 5572/11315/14583

*** This bug has been marked as a duplicate of bug 17908 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17908] Authority merge omnibus

2017-01-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17908

Marcel de Rooy  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com

--- Comment #2 from Marcel de Rooy  ---
*** Bug 16802 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17908] Authority merge omnibus

2017-01-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17908

Jacek Ablewicz  changed:

   What|Removed |Added

 CC||a...@biblos.pk.edu.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8579] Need script for updating authority 001s

2017-01-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8579

Marcel de Rooy  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=12722

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12722] Population of Authority 001 is inconsistent

2017-01-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12722

Marcel de Rooy  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=8579
 CC||m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14026] Deleting Authority record tag does not update bibliographic marc record

2017-01-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14026

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12734] Authority 001 should be set to authid in AddAuthority()

2017-01-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12734

Marcel de Rooy  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=8579

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8579] Need script for updating authority 001s

2017-01-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8579

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl
   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=12734

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12734] Authority 001 should be set to authid in AddAuthority()

2017-01-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12734

Marcel de Rooy  changed:

   What|Removed |Added

 Resolution|FIXED   |---
 Status|CLOSED  |REOPENED

--- Comment #3 from Marcel de Rooy  ---
Oops, not read very well.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12734] Authority 001 should be set to authid in AddAuthority()

2017-01-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12734

Marcel de Rooy  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 CC||m.de.r...@rijksmuseum.nl
 Status|NEW |RESOLVED

--- Comment #2 from Marcel de Rooy  ---
>From AddAuthority:

unless ($record->field('001') && $record->field('001')->data() eq $authid){
$record->delete_field($record->field('001'));
$record->insert_fields_ordered(MARC::Field->new('001',$authid));
}

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12734] Authority 001 should be set to authid in AddAuthority()

2017-01-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12734

Marcel de Rooy  changed:

   What|Removed |Added

 Status|RESOLVED|CLOSED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17908] Authority merge omnibus

2017-01-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17908

Marcel de Rooy  changed:

   What|Removed |Added

 CC||ch...@bigballofwax.co.nz

--- Comment #1 from Marcel de Rooy  ---
*** Bug 3343 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 3343] duplicate subfields in authority

2017-01-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3343

Marcel de Rooy  changed:

   What|Removed |Added

 Status|RESOLVED|CLOSED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 3343] duplicate subfields in authority

2017-01-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3343

Marcel de Rooy  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|NEW |RESOLVED
 CC||m.de.r...@rijksmuseum.nl

--- Comment #1 from Marcel de Rooy  ---
Closing this one in favor of the current bugs in omnibus bug 17908

*** This bug has been marked as a duplicate of bug 17908 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5821] Enable cron job for merge_authorities.pl

2017-01-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5821

Marcel de Rooy  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|NEW |RESOLVED

--- Comment #4 from Marcel de Rooy  ---
Closing this one in favor of bug 9988. See also omnibus bug 17908

*** This bug has been marked as a duplicate of bug 9988 ***

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5821] Enable cron job for merge_authorities.pl

2017-01-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5821

Marcel de Rooy  changed:

   What|Removed |Added

 Status|RESOLVED|CLOSED

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authority cronjob ( pref AuthorityMergeLimit)

2017-01-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988

Marcel de Rooy  changed:

   What|Removed |Added

 CC||hans...@gmail.com

--- Comment #4 from Marcel de Rooy  ---
*** Bug 5821 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17909] Add unit tests for authority merge

2017-01-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17909

Marcel de Rooy  changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |m.de.r...@rijksmuseum.nl
 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17909] New: Add unit tests for authority merge

2017-01-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17909

Bug ID: 17909
   Summary: Add unit tests for authority merge
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: MARC Authority data support
  Assignee: gmcha...@gmail.com
  Reporter: m.de.r...@rijksmuseum.nl
QA Contact: testo...@bugs.koha-community.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authority cronjob ( pref AuthorityMergeLimit)

2017-01-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988

--- Comment #3 from Marcel de Rooy  ---
(In reply to Marcel de Rooy from comment #0)
> But in case I just update e.g. a 551 tag for the auth record, there is no
> need at all to update all those bib records.

Will leave this case out. Sometimes we may expect to trigger an authority merge
by saving an authority, and perhaps do not want a 'smart' merge to do nothing.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authority cronjob ( pref AuthorityMergeLimit)

2017-01-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988

Marcel de Rooy  changed:

   What|Removed |Added

Summary|Unneeded timeouts when  |Leave larger authority
   |saving authorities (Can we  |merges to merge_authority
   |merge smarter?) |cronjob (pref
   ||AuthorityMergeLimit)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authority cronjob ( pref AuthorityMergeLimit)

2017-01-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988

Marcel de Rooy  changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |m.de.r...@rijksmuseum.nl
 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17908] Authority merge omnibus

2017-01-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17908

Marcel de Rooy  changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |m.de.r...@rijksmuseum.nl
 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17908] New: Authority merge omnibus

2017-01-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17908

Bug ID: 17908
   Summary: Authority merge omnibus
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: MARC Authority data support
  Assignee: gmcha...@gmail.com
  Reporter: m.de.r...@rijksmuseum.nl
QA Contact: testo...@bugs.koha-community.org

In order to coordinate some developments on this subject, I will add some bug
reports here and *try* to plan getting them further.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket

2017-01-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612

Josef Moravec  changed:

   What|Removed |Added

 Status|Signed Off  |Needs Signoff

--- Comment #64 from Josef Moravec  ---
Rebased on master, added another followup. Asking for new sign off - too many
followups and conflicts with new work pushed to master. Also note, that the
test plan should be amended. 

New test plan:

1) Apply the patches
2) Go to Tools › CSV export profiles and create a profile of type "SQL for
basket export in acquisition"
  example:
biblionumber=biblio.biblionumber|auteur=biblio.author|titre=biblio.title|date=biblioitems.copyrightdate|editeur=biblioitems.publishercode|isbn=biblioitems.isbn|quantite=aqorders.quantity|prix=aqorders.rrp|panier=aqorders.basketno
3) In acquisition module, create a new basket and add an order to the basket
4) On basket detail page, there should be the split button labelled "Export to
CSV"
5) Try to use the button and export CSV with your CSV profile you defined in
step 2
6) Validate the CSV file.
7) Repeat 4-6 with a closed basket.
 a) close the basket
 b) View the basket
 c) validate that there is an export button
 d) test it with an export
8) prove t/db_dependent/Acquisition/GetBasketAsCSV.t
t/db_dependent/Koha/CsvProfiles.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket

2017-01-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612

--- Comment #63 from Josef Moravec  ---
Created attachment 58992
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58992&action=edit
Bug 8612: Fix test due to bug 13726

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket

2017-01-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612

Josef Moravec  changed:

   What|Removed |Added

  Attachment #58078|0   |1
is obsolete||

--- Comment #61 from Josef Moravec  ---
Created attachment 58990
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58990&action=edit
Bug 8612: Add tests for GetBasketAsCSV

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket

2017-01-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612

Josef Moravec  changed:

   What|Removed |Added

  Attachment #58076|0   |1
is obsolete||

--- Comment #59 from Josef Moravec  ---
Created attachment 58988
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58988&action=edit
Bug 8612 - Followup - use Koha::CsvProfile[s] module (see bug 15451)

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket

2017-01-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612

Josef Moravec  changed:

   What|Removed |Added

  Attachment #58079|0   |1
is obsolete||

--- Comment #62 from Josef Moravec  ---
Created attachment 58991
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58991&action=edit
Bug 8612: QA follow-up - distinguish between late issues and basket export csv
profiles

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket

2017-01-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612

Josef Moravec  changed:

   What|Removed |Added

  Attachment #58077|0   |1
is obsolete||

--- Comment #60 from Josef Moravec  ---
Created attachment 58989
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58989&action=edit
Bug 8612: QA followup - Make export button split button, unify button labels

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket

2017-01-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612

Josef Moravec  changed:

   What|Removed |Added

  Attachment #58075|0   |1
is obsolete||

--- Comment #58 from Josef Moravec  ---
Created attachment 58987
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58987&action=edit
Bug 8612 - Clean basket.pl getting rid of subroutines with sql query and use
GetBasketAsCSV instead

GetBasketAsCSV now has a new argument the profile_csv_id, when this param is
defined, it loads the profile_content, searches the value of the predefined
fields and assembles the data to create the output of the csv file.

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket

2017-01-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612

Josef Moravec  changed:

   What|Removed |Added

  Attachment #58073|0   |1
is obsolete||

--- Comment #56 from Josef Moravec  ---
Created attachment 58985
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58985&action=edit
Bug 8612 - System preference to have custom fields in export csv basket

This patch allows the user use a CSV export profile to create the fields to
export the basket as CSV in a basket page.

To test:

1) Apply the patch;
2) Create a CSV export profile - type sql -  Home › Tools › CSV export profiles
  ex:
biblionumber=biblio.biblionumber|auteur=biblio.author|titre=biblio.title|date=biblioitems.copyrightdate|editeur=biblioitems.publishercode|isbn=biblioitems.isbn|quantite=aqorders.quantity|prix=aqorders.rrp|panier=aqorders.basketno
3) Create a new basket and add an order to the basket
4) Validate: the text "Select CSV profile:" and a dropdown in the basket view
5) In the new dropdown, select the CSV export profile created
6) Validate the CSV file.
7) Do the same validation with a closed basket.
 a) close the basket
 b) View the basket
 c) validate that there is a dropdown
 d) test it with an export

Signed-off-by: Josef Moravec 

Works as expected for me

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket

2017-01-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612

Josef Moravec  changed:

   What|Removed |Added

  Attachment #58074|0   |1
is obsolete||

--- Comment #57 from Josef Moravec  ---
Created attachment 58986
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58986&action=edit
Bug 8612 - Cleans basket.tt by using TT blocks

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/