[Koha-bugs] [Bug 17453] Inter-site holds improvement

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17453

--- Comment #19 from Jonathan Druart  
---
Created attachment 60102
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60102=edit
Bug 17453: Take into account items that are lost or damaged

If all the items are either lost, damaged or checked out, then pickup
should be allowed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17813] Table borrower_attributes needs a primary key

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17813

--- Comment #13 from Jonathan Druart  
---
(In reply to Katrin Fischer from comment #12)
> Just wondering - why don't we replace the old for the new variable in the
> notices with SQL? I think we have done that once when we added the new
> syntax for <> already.

There is no old column, only a new one.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #161 from Jonathan Druart  
---
(In reply to Alex Buckley from comment #159)
> The installer-strings.inc file is created in bug 17942 and so there must be
> a bad conflict in the merge to make the most recent patch of 17855. So I
> would suggest trying the merge again.

Silly me, I think I understood.
I certainly apply patches from 17942, then generated the translated languages.
Then back on this one but forgot to regenerate the templates.

To make thing clear: I did not want to obsolete the other patches because of
the error, and I was a bit tired yesterday and the last patch does not contain
any commit message.

If you agree with the plan, we can go with try to get 18039 first, then this
one.
But I have no idea how we can test 18039 widely and make sure it will not
introduce any regressions.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13920] API authentication system - proposal

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13920

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

--- Comment #29 from David Cook  ---
Where are we at with this?

I've been thinking about how API keys would be nice...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17942] Update style of the web installer with Bootstrap 3

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942

Liz Rea  changed:

   What|Removed |Added

  Attachment #60101|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17942] Update style of the web installer with Bootstrap 3

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942

--- Comment #32 from Liz Rea  ---
I also checked this in other languages, as long as the languages have been
regenerated all looks just great.

Finally, our installer looks like the modern web! So exciting!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17942] Update style of the web installer with Bootstrap 3

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942

--- Comment #31 from Liz Rea  ---
Created attachment 60101
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60101=edit
Bug 17942 - follow up - add anticlickjack style id to remove js error

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17942] Update style of the web installer with Bootstrap 3

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942

Liz Rea  changed:

   What|Removed |Added

 CC||l...@catalyst.net.nz
  Attachment #60099|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17942] Update style of the web installer with Bootstrap 3

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942

Liz Rea  changed:

   What|Removed |Added

  Attachment #59721|0   |1
is obsolete||
  Attachment #60098|0   |1
is obsolete||

--- Comment #30 from Liz Rea  ---
Created attachment 60100
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60100=edit
Bug 17942 - Update style of the web installer with Bootstrap 3

This patch makes style and markup changes to the web installer and new
onboarding tool (Bug 17855).

- Markup has been corrected, improved, and in many places reindented.
- Some page titles have been made more specific.
- Some JavaScript and CSS have been moved to separate files.

In the onboarding tool I have removed form validation from the markup
and JavaScript in many cases where the requirements were not matched
elsewhere in Koha. For instance, we shouldn't limit item type
descriptions to only letters because the database doesn't require such a
limit.

To test, apply the patch and run the web installer with an empty
database. Confirm that the installation process completes correctly and
that each page looks good and works correctly.

Signed-off-by: Josef Moravec 
Signed-off-by: Liz Rea 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17942] Update style of the web installer with Bootstrap 3

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942

Liz Rea  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17942] Update style of the web installer with Bootstrap 3

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942

--- Comment #29 from Liz Rea  ---
Created attachment 60099
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60099=edit
Bug 17942 - follow up - add anticlickjack style id to remove js error

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15118] Accidental Branch transfer on hold is not handled gracefully.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15118

jdem...@roseville.ca.us  changed:

   What|Removed |Added

 CC||jdem...@roseville.ca.us

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12556] SelfCheck machine starts the hold instantly with an email sent out

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556

jdem...@roseville.ca.us  changed:

   What|Removed |Added

 CC||jdem...@roseville.ca.us

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17942] Update style of the web installer with Bootstrap 3

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #28 from Katrin Fischer  ---
Tried to resolve the conflicts - nothing explodes in an obvious way. Conflict
files were:
 koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep2.tt
 koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep3.tt

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #160 from Liz Rea  ---
Katrin is kindly providing a resolved-by-her patch on Owen's bug. She's awesome
and stuff.

Liz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17942] Update style of the web installer with Bootstrap 3

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942

Katrin Fischer  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17942] Update style of the web installer with Bootstrap 3

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942

--- Comment #27 from Katrin Fischer  ---
Created attachment 60098
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60098=edit
Bug 17942 - Update style of the web installer with Bootstrap 3

This patch makes style and markup changes to the web installer and new
onboarding tool (Bug 17855).

- Markup has been corrected, improved, and in many places reindented.
- Some page titles have been made more specific.
- Some JavaScript and CSS have been moved to separate files.

In the onboarding tool I have removed form validation from the markup
and JavaScript in many cases where the requirements were not matched
elsewhere in Koha. For instance, we shouldn't limit item type
descriptions to only letters because the database doesn't require such a
limit.

To test, apply the patch and run the web installer with an empty
database. Confirm that the installation process completes correctly and
that each page looks good and works correctly.

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18059] Add further explanation of the steps in the onboarding tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18059

Alex Buckley  changed:

   What|Removed |Added

 Status|Needs Signoff   |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #159 from Alex Buckley  ---
(in reply to Jonathan Druart in comment 156)

Liz and I discovered the source of the problem after looking at the patches in
bug 17855 and 18039 and we saw that installer-strings.inc does not exist in
either. 

The installer-strings.inc file is created in bug 17942 and so there must be a
bad conflict in the merge to make the most recent patch of 17855. So I would
suggest trying the merge again.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18092] Serial Enumeration (enumchron) truncated to 2 characters in by label creator

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18092

Barton Chittenden  changed:

   What|Removed |Added

   Severity|enhancement |normal

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18092] Serial Enumeration (enumchron) truncated to 2 characters in by label creator

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18092

--- Comment #2 from Barton Chittenden  ---
Created attachment 60097
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60097=edit
Exported pdf (enumchron is truncated)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18092] Serial Enumeration (enumchron) truncated to 2 characters in by label creator

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18092

--- Comment #1 from Barton Chittenden  ---
Created attachment 60096
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60096=edit
exported csv (enumchron is not truncated)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18092] New: Serial Enumeration (enumchron) truncated to 2 characters in by label creator

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18092

Bug ID: 18092
   Summary: Serial Enumeration (enumchron) truncated to 2
characters in by label creator
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Label/patron card printing
  Assignee: cnighswon...@foundations.edu
  Reporter: bar...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

Created attachment 60095
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60095=edit
example bib with 2 items.

When printing a spine label where the layout includes 'enumchron' in the fields
to print, that field is truncated to a width of two characters in the PDF
export. The field shows in its entirety in the CSV export.

For example the serial enumeration 'Discs 17 & 18' is truncated to 'Di'.

To replicate:

Set up Layout koha-spine

Layout name: koha-spine
barcode type   : Code 39
layout type: Biblio
Data fields: 952a, itemcallnumber, enumchron
Draw guide boxes   : True
Split call numbers : True
Text justification : Left
Font   : Times-Roman
Font size  : 10
Oblique title  : True

Set template Avery 5460 spine labels

Template code   : Avery 5460 spine labels
Units   : Si Centimeters
Page height : 28
Page width  : 21.5
Label width : 2.1
Label height: 3
Top page margin : 1.2
Left page margin: 0.8
Top text margin : 0.52
Left text margin: 0.52
Number of columns   : 8
Number of rows  : 8
Gap between columns : 0.44
Gap between rows: 0.2
Profile : none

Set up batch using item that has enumchron wider than 2 characters (I've
attached a sample marc record)

Export using the layout and template above.

See that the serial enumeration is truncated.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #158 from Liz Rea  ---
Hi Jonathan,

I haven't been able to make mine error in your way either. Here's what I did:

Applied the patches, 17855, your squashed patch, and then 18039 - all went ok.

Installed fr-FR in my developer install: 
sudo env KOHA_CONF=/etc/koha/sites/library/koha-conf.xml
PERL5LIB=/home/liz/koha-src/koha/ perl translate install fr-FR
(I also installed de-DE, for funsies, but I haven't run through the installer
in de-DE)

Dropped my koha database
Created a new db in it's place

Ran through the installer in fr-FR, and made it all the way through to logging
in as our newly created super librarian. 

As a note, there were lots of "C4::Carp redefined" warnings in the intranet
log, but they didn't seem to cause any noticeable problem.

One thing I did note was that the fr-FR DB templates have some additional
mandatory options re: UNIMARC, and the default MARC flavour is the 3rd one in
the list. That might not be right but I think not a problem for this bug to
fix.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18091] No documentation for SMS via email in 16.05 or 16.11 documentation

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18091

--- Comment #1 from Barton Chittenden  ---
I was incorrect -- SMS via email *is* documented, but SMS:Send is not.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18087] Clarification on File type when using file of biblionumbers to export data

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18087

--- Comment #1 from Joy Nelson  ---
Created attachment 60094
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60094=edit
Bug 18087 - Clarification on File type when using file of biblionumbers to
export data

Added a line to the screen  detailing the types of files that can be used to
upload a list of biblionumbers.

Test plan:
1. Go to tools->export data
2. under File option,  (File types accepted: .csv and .txt)  should appear

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18087] Clarification on File type when using file of biblionumbers to export data

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18087

Joy Nelson  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |String patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #157 from Alex Buckley  ---
(in reply to Jonathan Druart in comment 155)
At this stage yes that does all make sense thank you.

(in reply to Jonathan Druart in comment 156)
Interestingly I cannot seem to replicate the error you are getting. I am not
getting that error displayed in the web browser or the intranet-error.log file. 

Is the error appearing when running the web installer/onboarding tool in a
particular language?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9021] Add SMS via email as an alternative to SMS services via SMS:: Send drivers

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9021

Barton Chittenden  changed:

   What|Removed |Added

 Blocks||18091


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18091
[Bug 18091] No documentation for SMS via email in 16.05 or 16.11 documentation
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18091] No documentation for SMS via email in 16.05 or 16.11 documentation

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18091

Barton Chittenden  changed:

   What|Removed |Added

 Depends on||9021


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9021
[Bug 9021] Add SMS via email as an alternative to SMS services via SMS::Send
drivers
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9021] Add SMS via email as an alternative to SMS services via SMS:: Send drivers

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9021

Barton Chittenden  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=18091

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18091] No documentation for SMS via email in 16.05 or 16.11 documentation

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18091

Barton Chittenden  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=9021

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11677] Limit to Only items currently available for loan or reference not working

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11677

Kyle M Hall  changed:

   What|Removed |Added

 Status|REOPENED|NEW

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11677] Limit to Only items currently available for loan or reference not working

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11677

Kyle M Hall  changed:

   What|Removed |Added

 Status|CLOSED  |REOPENED
 Resolution|WORKSFORME  |---

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18091] New: No documentation for SMS via email in 16.05 or 16.11 documentation

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18091

Bug ID: 18091
   Summary: No documentation for SMS via email in 16.05 or 16.11
documentation
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Documentation
  Assignee: neng...@gmail.com
  Reporter: bar...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

Bug 9021 -- Add an exception to SMS via email documentation in the Koha manua
--  was added to 16.05, but there is no documentation for adding SMS gateways
nor adding the provider and sms number in the patron's messaging preferences.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18081] New EU General Data Protection Regulation 2018

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18081

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18061] Enhance items page (moredetail.pl) with Bootstrap 3 panels

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18061

--- Comment #4 from Owen Leonard  ---
If I were approaching this interface and thinking to myself that it needed to
be improved, I'd ask myself some questions:

1. What are the problems with it the way it is? Is it not readable enough? Are
the controls not usable in some way.
2. Based on the problems identified in step 1, what are some ways to directly
address them?
3. If this interface follows a pattern which is used in other areas of Koha can
we easily apply the new style to those places? If not, can we find a way to
adjust the new version to be more universal?

I don't find this to be more readable. It also doesn't handle a smaller browser
window size very nicely. I feel like this is a change for change's sake rather
than a change which accomplishes a goal.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17453] Inter-site holds improvement

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17453

Claire Gravely  changed:

   What|Removed |Added

 CC||claire_grav...@hotmail.com

--- Comment #18 from Claire Gravely  ---
(In reply to Jonathan Druart from comment #15)
> (In reply to Nick Clemens from comment #12)
> > Patch doesn't apply, I also wonder about last patch:
> > Allow pickup at a library where all items are checked out
> > 
> > It only checks if items are checked out, but what about case of items
> > waiting for pickup or damaged/lost?
> 
> Hum yes you may be right. But that sounds like a very specific situation and
> that would make the code much complicated.
> I'd suggest to go first with these patches and improve them later if it is
> really needed.
> If you think it has to be handled, I can try and provide a patch on this bug
> report.

I would agree with Nick that items that are on hold for someone or otherwise
marked as unavailable ( such as lost) should be taken into consideration. 

No items should be "available" at the pick up location in order for it to
qualify as a pick up location perhaps?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17453] Inter-site holds improvement

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17453

--- Comment #17 from Jonathan Druart  
---
Created attachment 60093
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60093=edit
Bug 17453: Add a visible notification to patron to explain why the hold
locations are disabled

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14414] add field for processing fee for invoices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14414

Jessie Zairo  changed:

   What|Removed |Added

 CC||jza...@bywatersolutions.com

--- Comment #1 from Jessie Zairo  ---
This enhancement would be great for libraries to add processing fees per vendor
and enter a processing fee and a processing fee fund on the invoice management
screen. Many libraries pay a fee for record and label processing and need a
separate line to retain that information.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #156 from Jonathan Druart  
---
Note sure what's is going on, I get 
  Template process failed: file error - installer-strings.inc: not found at
/home/vagrant/kohaclone/C4/Templates.pm line 121.

on /installer/onboarding.pl?step=2

I do not manage to know where it comes from.

(With and without my changes)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17453] Inter-site holds improvement

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17453

--- Comment #16 from Nick Clemens  ---
Chatted with Claire in IRD, I think this needs some sort of visible
notification to patron to explain why the hold locations are disabled (the
hover notification is appreciated but not sufficient I think)

 Would you agree to some sort of notification that this pref is
active to explain why the location is disabled?
 my original plan said for there to be a message that says item
is availabel for collection at that library 
 or similar when they go to place the reservation
 "Note: Library policy does not allow hold/pickup of an item
avialable locally. Please come to the library to retrieve these items"
 along those lines
 yeah or what you said, okay I will post that for Joubu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18042] Update buttons in batch record modification and deletion

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18042

J Schmidt  changed:

   What|Removed |Added

 CC||jschm...@switchinc.org
 Status|Needs Signoff   |Signed Off

--- Comment #4 from J Schmidt  ---
Tested bug #18042 on 2/9/2017 using ByWater Sandbox. Steps taken:
1.) Koha Cataloging > New Record on Default Framework. 
2.) Using the simple editor, filled in these MARC fields: 000, 005, 006, 007,
008, 020, 100, 245, 300, 650 tied to one authority record, 942$c for BOOK.
3.) Saved the new record. Koha prompted me to fill in the required fields: 003
and 040. Then saved
4.) Koha prompts me to create a new item (Add item). Fields filled in include:
952$3, $8, $d, $p, $y, $t, $v. Add item was successful.
5.) Test record is now done. #439.
6.) Search to find two more bib numbers: #171, #272.
7.) Koha > Tools > Batch Record Modification. Received the message: " No MARC
modification template is defined. You have to create at least one template for
this tool. 
8.) Click Manage MARC Modification Templates. Message here is "There are no
defined templates. Please create a template first.
9.) Tools>MARC Modification templates > New Template created. Add in New
Action. I like the new buttons. 
10.) Under Add a new action, Add/Update 942$n  with value 1. Add action. 
11.) Add in a second action to new template. Add/update 650 x with value
Massachusetts. Add Action. 
12.) Click on Batch Record Modification. Selected option to enter a list of
three bib numbers: 439, 171, 272. Select modification template and Continue.
13.) Next screen gives me a new area where users can still DESELECT individual
records which is nice.  There is a SHOW MARC button which is also nice. Show
MARC does pop up dialog with MARC fields
14.) I clicked Modify selected records. I receive a message that the three bibs
were successfully modified. Prompted to do a new batch record modification. 
15.) I click on record #171. I go to edit bib mode. I see 942$n has a 1. 650
has a $x for Massachusetts. 
16.) I  click on Batch record deletion under Tools.
17.) I enter in a list of three bib numbers: 439, 171, 272. I click Continue.
Buttons look clean.
18.) Next screen for batch record deletion gives me the option to deselect
individual records; select all, clear all, select without holds, select without
items.  I clicked Delete selected records. Success. Prompted to do another
batch record deletion. 
19.) I search for deleted bibs but they are removed.  

Functionality and buttons work well. jls. 
19.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #155 from Jonathan Druart  
---
(In reply to Jonathan Druart from comment #154)
> Created attachment 60092 [details] [review]
> Bug 17855: Onboarding tool

So... I hope I did not break everything.
I extracted the installer files from this patchset and move them to bug 18039.
Then I have squashed all the patches together and here is the resulting
squashed patch. Please apply it alone!

I have tried to move the installer files for the translated languages. Take a
look at bug 18039.
That sounds a quite big work and I am not confident with the patchset, we will
need to test it deeply.

So the plan would be to
1/ Apply patches from 18039
2/ Apply the squashed patch
3/ Test the different languages (how to make sure nothing has been missed??)
4/ Pushed everything altogether

Does that make sense?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #154 from Jonathan Druart  
---
Created attachment 60092
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60092=edit
Bug 17855: Onboarding tool

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18039] Move the mandatory and optional files for non-english languages into ' default' directory so bug 17855 permits use of other languages

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18039

--- Comment #14 from Jonathan Druart  
---
Created attachment 60091
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60091=edit
[DO NOT PUSH] Add move_installer_files.pl

https://bugs.koha-community.org/show_bug.cgi?id=17855

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18039] Move the mandatory and optional files for non-english languages into ' default' directory so bug 17855 permits use of other languages

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18039

--- Comment #11 from Jonathan Druart  
---
Created attachment 60088
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60088=edit
pl-PL

fatal: bad source, source=installer/data/mysql/pl-PL/optional/csv_profiles.sql,
destination=installer/data/mysql/pl-PL/default/csv_profiles.sql
fatal: bad source, source=installer/data/mysql/pl-PL/optional/csv_profiles.txt,
destination=installer/data/mysql/pl-PL/default/csv_profiles.txt
fatal: bad source, source=installer/data/mysql/pl-PL/mandatory/auth_values.txt,
destination=installer/data/mysql/pl-PL/default/auth_values.txt

https://bugs.koha-community.org/show_bug.cgi?id=17855

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18039] Move the mandatory and optional files for non-english languages into ' default' directory so bug 17855 permits use of other languages

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18039

--- Comment #13 from Jonathan Druart  
---
Created attachment 60090
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60090=edit
uk-UA

fatal: bad source, source=installer/data/mysql/uk-UA/optional/auth_val.sql,
destination=installer/data/mysql/uk-UA/default/auth_val.sql
fatal: bad source, source=installer/data/mysql/uk-UA/optional/auth_val.txt,
destination=installer/data/mysql/uk-UA/default/auth_val.txt
fatal: bad source, source=installer/data/mysql/uk-UA/optional/csv_profiles.sql,
destination=installer/data/mysql/uk-UA/default/csv_profiles.sql
fatal: bad source, source=installer/data/mysql/uk-UA/optional/csv_profiles.txt,
destination=installer/data/mysql/uk-UA/default/csv_profiles.txt
fatal: bad source, source=installer/data/mysql/uk-UA/optional/parameters.sql,
destination=installer/data/mysql/uk-UA/default/parameters.sql
fatal: bad source, source=installer/data/mysql/uk-UA/optional/parameters.txt,
destination=installer/data/mysql/uk-UA/default/parameters.txt
fatal: bad source, source=installer/data/mysql/uk-UA/mandatory/auth_values.txt,
destination=installer/data/mysql/uk-UA/default/auth_values.txt
fatal: bad source,
source=installer/data/mysql/uk-UA/mandatory/sample_notices.txt,
destination=installer/data/mysql/uk-UA/default/sample_notices.txt

https://bugs.koha-community.org/show_bug.cgi?id=17855

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18039] Move the mandatory and optional files for non-english languages into ' default' directory so bug 17855 permits use of other languages

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18039

--- Comment #12 from Jonathan Druart  
---
Created attachment 60089
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60089=edit
ru-RU

fatal: bad source, source=installer/data/mysql/ru-RU/optional/auth_val.sql,
destination=installer/data/mysql/ru-RU/default/auth_val.sql
fatal: bad source, source=installer/data/mysql/ru-RU/optional/auth_val.txt,
destination=installer/data/mysql/ru-RU/default/auth_val.txt
fatal: bad source, source=installer/data/mysql/ru-RU/optional/csv_profiles.sql,
destination=installer/data/mysql/ru-RU/default/csv_profiles.sql
fatal: bad source, source=installer/data/mysql/ru-RU/optional/csv_profiles.txt,
destination=installer/data/mysql/ru-RU/default/csv_profiles.txt
fatal: bad source, source=installer/data/mysql/ru-RU/optional/parameters.sql,
destination=installer/data/mysql/ru-RU/default/parameters.sql
fatal: bad source, source=installer/data/mysql/ru-RU/optional/parameters.txt,
destination=installer/data/mysql/ru-RU/default/parameters.txt
fatal: bad source, source=installer/data/mysql/ru-RU/mandatory/auth_values.txt,
destination=installer/data/mysql/ru-RU/default/auth_values.txt

https://bugs.koha-community.org/show_bug.cgi?id=17855

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18039] Move the mandatory and optional files for non-english languages into ' default' directory so bug 17855 permits use of other languages

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18039

--- Comment #10 from Jonathan Druart  
---
Created attachment 60087
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60087=edit
nb-NO

csv_profiles does not exist

fatal: bad source,
source=installer/data/mysql/nb-NO/2-Valgfritt/csv_profiles.sql,
destination=installer/data/mysql/nb-NO/default/csv_profiles.sql
fatal: bad source,
source=installer/data/mysql/nb-NO/2-Valgfritt/csv_profiles.txt,
destination=installer/data/mysql/nb-NO/default/csv_profiles.txt
fatal: bad source,
source=installer/data/mysql/nb-NO/1-Obligatorisk/auth_values.txt,
destination=installer/data/mysql/nb-NO/default/auth_values.txt

https://bugs.koha-community.org/show_bug.cgi?id=17855

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18039] Move the mandatory and optional files for non-english languages into ' default' directory so bug 17855 permits use of other languages

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18039

--- Comment #9 from Jonathan Druart  
---
Created attachment 60086
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60086=edit
it-IT

fatal: bad source, source=installer/data/mysql/it-IT/necessari/auth_values.sql,
destination=installer/data/mysql/it-IT/default/auth_values.sql
fatal: bad source, source=installer/data/mysql/it-IT/necessari/auth_values.txt,
destination=installer/data/mysql/it-IT/default/auth_values.txt
fatal: bad source,
source=installer/data/mysql/it-IT/necessari/sample_notices.sql,
destination=installer/data/mysql/it-IT/default/sample_notices.sql
fatal: bad source,
source=installer/data/mysql/it-IT/necessari/sample_notices.txt,
destination=installer/data/mysql/it-IT/default/sample_notices.txt

=> OK

https://bugs.koha-community.org/show_bug.cgi?id=17855

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18039] Move the mandatory and optional files for non-english languages into ' default' directory so bug 17855 permits use of other languages

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18039

--- Comment #8 from Jonathan Druart  
---
Created attachment 60085
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60085=edit
fr-FR

Does not exist for this language
csv_profiles.sql
parameters.sql (currency)
auth_values.sql (YES_NO)

fatal: bad source, source=installer/data/mysql/fr-FR/2-Optionel/auth_val.sql,
destination=installer/data/mysql/fr-FR/default/auth_val.sql
fatal: bad source, source=installer/data/mysql/fr-FR/2-Optionel/auth_val.txt,
destination=installer/data/mysql/fr-FR/default/auth_val.txt
fatal: bad source,
source=installer/data/mysql/fr-FR/2-Optionel/csv_profiles.sql,
destination=installer/data/mysql/fr-FR/default/csv_profiles.sql
fatal: bad source,
source=installer/data/mysql/fr-FR/2-Optionel/csv_profiles.txt,
destination=installer/data/mysql/fr-FR/default/csv_profiles.txt
fatal: bad source, source=installer/data/mysql/fr-FR/2-Optionel/parameters.sql,
destination=installer/data/mysql/fr-FR/default/parameters.sql
fatal: bad source, source=installer/data/mysql/fr-FR/2-Optionel/parameters.txt,
destination=installer/data/mysql/fr-FR/default/parameters.txt
fatal: bad source,
source=installer/data/mysql/fr-FR/1-Obligatoire/auth_values.sql,
destination=installer/data/mysql/fr-FR/default/auth_values.sql
fatal: bad source,
source=installer/data/mysql/fr-FR/1-Obligatoire/auth_values.txt,
destination=installer/data/mysql/fr-FR/default/auth_values.txt
fatal: can not move directory into itself,
source=installer/data/mysql/fr-FR/marcflavour/marc21/default/authorities_normal_marc21.sql,
destination=installer/data/mysql/fr-FR/marcflavour/marc21/default/authorities_normal_marc21.sql

Replace with
git mv installer/data/mysql/fr-FR/1-Obligatoire/authorised_values.*
installer/data/mysql/fr-FR/default

https://bugs.koha-community.org/show_bug.cgi?id=17855

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18039] Move the mandatory and optional files for non-english languages into ' default' directory so bug 17855 permits use of other languages

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18039

--- Comment #7 from Jonathan Druart  
---
Created attachment 60084
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60084=edit
fr-CA

https://bugs.koha-community.org/show_bug.cgi?id=17855

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18039] Move the mandatory and optional files for non-english languages into ' default' directory so bug 17855 permits use of other languages

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18039

--- Comment #4 from Jonathan Druart  
---
Created attachment 60081
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60081=edit
Why do we add this empty file?

https://bugs.koha-community.org/show_bug.cgi?id=17855

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18039] Move the mandatory and optional files for non-english languages into ' default' directory so bug 17855 permits use of other languages

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18039

--- Comment #5 from Jonathan Druart  
---
Created attachment 60082
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60082=edit
de-DE

https://bugs.koha-community.org/show_bug.cgi?id=17855

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18039] Move the mandatory and optional files for non-english languages into ' default' directory so bug 17855 permits use of other languages

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18039

--- Comment #6 from Jonathan Druart  
---
Created attachment 60083
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60083=edit
es-ES

Missing:
installer/data/mysql/en/default/csv_profiles.sql

https://bugs.koha-community.org/show_bug.cgi?id=17855

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18039] Move the mandatory and optional files for non-english languages into ' default' directory so bug 17855 permits use of other languages

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18039

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18039] Move the mandatory and optional files for non-english languages into ' default' directory so bug 17855 permits use of other languages

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18039

--- Comment #3 from Jonathan Druart  
---
Created attachment 60080
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60080=edit
Bug 18039: en

This patches comes from bug 17855.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15235] Add column filters to checkouts table

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15235

Julian Maurice  changed:

   What|Removed |Added

  Attachment #45096|0   |1
is obsolete||

--- Comment #2 from Julian Maurice  ---
Created attachment 60079
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60079=edit
Bug 15235: Add column filters to checkouts table

This adds a switch that allow to enable/disable column filters on
checkouts table (disabled by default)

Depends on bug 15219

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15235] Add column filters to checkouts table

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15235

--- Comment #3 from Julian Maurice  ---
Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18087] Clarification on File type when using file of biblionumbers to export data

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18087

Nick Clemens  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Severity|enhancement |minor

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18087] Clarification on File type when using file of biblionumbers to export data

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18087

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com
   Assignee|gmcha...@gmail.com  |j...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14608] HEA : add possibility of sharing usage statistics in Administration page and Web installer

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14608

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18079] Cleanup of holds to pull page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18079

Marcel de Rooy  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18079] Cleanup of holds to pull page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18079

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #8 from Marcel de Rooy  ---
Looks good to me.
Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18079] Cleanup of holds to pull page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18079

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #60070|0   |1
is obsolete||

--- Comment #7 from Marcel de Rooy  ---
Created attachment 60078
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60078=edit
Bug 18079: Holds to pull cleanup

Changes made:

  - remove obsolete comment in pendingreserves.pl
  - use Modern::Perl in circ/pendingreserves.pl
  - get rid of unusable param run_report - followup for bug 8454
  - get rid of references to hold status - followup for bug 9320
  - remove unused data from SQL and reservedata structure

Test plan:
1) Apply patch from bug 18073
2) Apply patch on this bug
3) Enable on shelf hold in administration -> circulation and fines rules
4) Create some holds on avalaible items
5) Confirm that circulation -> holds to pull page works as expected
6) Try to find any regression

Signed-off-by: Katrin Fischer 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18079] Cleanup of holds to pull page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18079

Marcel de Rooy  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
   |y.org   |
 CC||m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18073] Holds to pull UI improvements

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18073

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18073] Holds to pull UI improvements

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18073

Marcel de Rooy  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
   |y.org   |
 CC||m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18073] Holds to pull UI improvements

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18073

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #60040|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18073] Holds to pull UI improvements

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18073

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #60069|0   |1
is obsolete||

--- Comment #8 from Marcel de Rooy  ---
Created attachment 60077
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60077=edit
Bug 18073: Followup - don't use CONCAT_WS

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18073] Holds to pull UI improvements

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18073

--- Comment #7 from Marcel de Rooy  ---
Created attachment 60076
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60076=edit
Bug 18073: Holds to pull table enhancement

Test plan:
0) apply the patch
1) enable on shelf hold in administration -> circulation and fines rules
2) create some holds on avalaible items
3) go to administration -> columns settings and confirm there is new
holds-to-pull table in circulation section
4) go to circulation -> holds to pull page and confirm that
4a) that the page does work as before
4b) there is ne "Column visibility" button in datatable toolbar
4c) the column configuration does work as expected
4d) there is new column "First patron" with link to patron which is
first in holds queue for given record
4e) sorting works ax expected
4f) filters (in teh bottom of table) work as expected

Signed-off-by: Katrin Fischer 
Works nicely!

https://bugs.koha-community.org/show_bug.cgi?id=18079

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17932] Koha::Object should provide a TO_JSON method

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17932

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #24 from Marcel de Rooy  ---
Looks good to me.
One small thing: the isvstring test looks somewhat useless to me. It also
passes on other borrower text columns like phonepro or B_streetnumber.
Could be handled on a follow-up.

Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18072] Add Koha objects for Branch Transfer Limits

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18072

--- Comment #10 from Lari Taskula  ---
(In reply to Jonathan Druart from comment #8)
> I'd suggest to swap $to, $from in the parameters.
>   ->can_be_transferred( $from, $to )
> sounds more logical.
> When could even pass $hashref { from => $from, to => $to } to avoid
> ambiguity.
I used this particular order because one may leave $from undefined, in which
case the item's holdingbranch will be used as $from, and the typical use case
would be simply $item->can_be_transferred($to). I agree with your point for the
advantage of using hashref.

(In reply to Jonathan Druart from comment #9)
> (In reply to Josef Moravec from comment #6)
> > Created attachment 60010 [details] [review] [review]
> > Bug 18072: Add deprecation warning to C4::Circulation Branch Transfer Limit
> > functions
> 
> Do you plan to replace this subroutine?
No. I would like to replace all of them and write proper tests for that, but
unfortunately I don't have time to work with that now.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17932] Koha::Object should provide a TO_JSON method

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17932

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #59696|0   |1
is obsolete||

--- Comment #20 from Marcel de Rooy  ---
Created attachment 60072
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60072=edit
Bug 17932: Add a TO_JSON method to Koha::Object(s)

Bug 17927 fixes data types on the current REST endpoints. If you
test those endpoints, you will notice trying to access them (for listing
or retrieving single objects yields a data type error. Notably on
booleans but also on integers.

Integers fail due to https://rt.cpan.org/Ticket/Display.html?id=119904
but it needs some global solution until there's a DBD::mysql release
backported to the supported distros. There's the option to use
http://search.cpan.org/~frew/DBIx-Class-Helpers-2.033002/lib/DBIx/Class/Helper/Row/NumifyGet.pm
to get the integer columns fixed as a workaround:

 __PACKAGE__->add_columns(
borrowernumber => {
data_type => 'integer',
is_nullable   => 0,
is_numeric=> 1,
}
);

I didn't find bug reports related to this (maybe because we don't use
warnings everywhere) But I don't think is worth going such a heavy
overhead.

A similar situation takes place for Boolean values. They need to be
prepared for JSON output. This could have been done using DBIx filters
as pointed out by Martin:

__PACKAGE__->filter_column(
lost => {
   filter_to_storage => sub { $_[1] ? 1 : 0 },
   filter_from_storage =>
   sub { $_[1] ? Mojo::JSON->true :
 Mojo::JSON->false }
   }
);

but this could have other consequences that are worth exploring on
another bug (i.e. it would mean we need to take care of every place
where this boolean data is used/set needs to handle this data types
nicely. Such would be the case if we were a Mojo-only app, but we
aren't. We use Koha::Obect(s) in the whole app. Period.

This patch adds the need to specify on the schema files, columns that
are actually boolean, because we have no way to detect them for now
(i.e. they are all tinyint, but we use tinyint for non-boolean stuff
 too).
So if this patch is accepted, we would need to specify boolean columns
like this:

__PACKAGE__->add_columns(
'+lost' => {
is_boolean => 1
}
);

This patch adds a TO_JSON method for Koha::Object(s) to be used for
serializing Koha::Object-derived objects into JSON strings.

To test it (as Koha::Object(s) need to be instantiated) I provide tests
on top of the Koha::Patron(s) classes in the followup patches.

[1] Yes, we use TINYINT(1) for booleans, but from DBIC's perspective
there's no way to read the (1) in runtime.

Sponsored-by: ByWater Solutions

Signed-off-by: Nick Clemens 
Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17932] Koha::Object should provide a TO_JSON method

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17932

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #59698|0   |1
is obsolete||

--- Comment #22 from Marcel de Rooy  ---
Created attachment 60074
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60074=edit
Bug 17932: Unit tests

This patch adds unit tests for the Koha::Object::TO_JSON function.
It tests on top of Koha::Patron as Koha::Object needs to be
instantiated.

To test:
- Apply the patch
- Run:
  $ prove -v t/db_dependent/Koha/Object.t
=> SUCCESS: New tests for TO_JSON are run and return green.
- Sign off :-D

Signed-off-by: Nick Clemens 
Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17932] Koha::Object should provide a TO_JSON method

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17932

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #59699|0   |1
is obsolete||

--- Comment #23 from Marcel de Rooy  ---
Created attachment 60075
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60075=edit
Bug 17932: (followup) Tidy tests

This patch makes the tests create its own data instead of searching the
DB for a branchcode and a categorycode. It does so on each subtest,
because there shouldn't be side effects between subtests.

I also wrapped each subtest inside a transaction, for the same reason.

To test:
- Apply this patch
- Run:
  $ prove t/db_dependent/Koha/Object.t
=> SUCCESS: Tests return green with this patch
- Sign off :-D

Signed-off-by: Nick Clemens 
Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17932] Koha::Object should provide a TO_JSON method

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17932

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #59697|0   |1
is obsolete||

--- Comment #21 from Marcel de Rooy  ---
Created attachment 60073
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60073=edit
Bug 17932: (followup) Fix /patrons endpoint

Bug 17927 introduced data type fixes on the /patrons endpoint (integer
and boolean types got fixed). This led to the /patrons endpoint not to
work because the underlying code didn't provide the right data.

With the introduction of TO_JSON on Koha::Object(s) we now have a way to
output the proper data types.

This patch does so by:
- Adding is_boolean => 1 to the relevant columns on the Borrower.pm
  schema file.
- Tweaking the controller class for the /patrons endpoint so it doesn't
  use the $object(s)->unblessed call but just let the Mojo::JSON library
  pick out TO_JSON implementation instead on rendering the output.
- It adds a new test for booleans.

To test:
- Have 17927 applied
- Run:
  $ prove t/db_dependent/api/v1/patrons.t
=> FAIL: Tests fail [1]
- Apply this patches
- Run:
  $ prove t/db_dependent/api/v1/patrons.t
=> SUCCESS: Tests pass!
- Sign off! :-D

[1] It is self explanatory to just try the API using any of the
available tools (I use HttpRequester on Firefox)

Signed-off-by: Nick Clemens 
Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15219] Server-side processing and pagination on checkouts tables

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15219

Julian Maurice  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

--- Comment #11 from Julian Maurice  ---
Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15219] Server-side processing and pagination on checkouts tables

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15219

Julian Maurice  changed:

   What|Removed |Added

  Attachment #50075|0   |1
is obsolete||

--- Comment #10 from Julian Maurice  ---
Created attachment 60071
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60071=edit
Bug 15219: Server-side processing and pagination on checkouts tables

Some libraries have patrons with more than 1000 checkouts. Loading all
of them at once can be very long, and sometimes can cause timeout
errors.
This patch prevent that by enabling server-side processing and
pagination on checkouts tables.
This affects patron's checkouts and patron's relatives' checkouts tables
on pages circ/circulation.pl and members/moremember.pl.

As server-side processing can be useless and cumbersome with small
sets of data, a new system preference is introduced to control this
behaviour (server-side processing is disabled by default).

Additionally, this patch:
- adds a switch to turn off and on row grouping (today's checkouts vs
  previous checkouts) (on by default)
- adds "column settings" for relatives' checkouts tables
- factorize some code that was duplicated across the two DataTables
  configurations (mDataProp)

Test plan:
1. Find (or create) a patron that have at least 10 checkouts and where
   the relatives checkouts table contain at least 10 checkouts.
2. Go to the patron's detail page and check everything works fine
   in both tables (sorting, pagination, the data itself, ...)
3. Do the same on circulation page (circulation.pl)
4. Enable system preference ServerSideCheckoutsTable
5. Repeat steps 2 and 3

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18039] Move the mandatory and optional files for non-english languages into ' default' directory so bug 17855 permits use of other languages

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18039

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
Version|17.05   |unspecified
   Assignee|alexbuck...@catalyst.net.nz |jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #2 from Jonathan Druart  
---
It breaks them.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

Jonathan Druart  changed:

   What|Removed |Added

 Blocks|18039   |
 Depends on||18039


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18039
[Bug 18039] Move the mandatory and optional files for non-english languages
into 'default' directory so bug 17855 permits use of other languages
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18039] Move the mandatory and optional files for non-english languages into ' default' directory so bug 17855 permits use of other languages

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18039

Jonathan Druart  changed:

   What|Removed |Added

 Depends on|17855   |
 Blocks||17855


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855
[Bug 17855] Updated Koha web installer and new onboarding tool feature to guide
users through setting up Koha
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18079] Cleanup of holds to pull page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18079

--- Comment #6 from Jonathan Druart  
---
Yes thanks!
I was QA both at the same time. Will come back soon.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17461] Make plugins-home.pl complain about plugins that can not be loaded

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17461

Tomás Cohen Arazi  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=18090

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18090] New: Administration > Manage plugins should display problematic plugins

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18090

Bug ID: 18090
   Summary: Administration > Manage plugins should display
problematic plugins
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: gmcha...@gmail.com
  Reporter: tomasco...@gmail.com
QA Contact: testo...@bugs.koha-community.org

Installed plugins that fail to load should me noticed in the Administration >
Manage plugins page

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18090] Administration > Manage plugins should display problematic plugins

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18090

Tomás Cohen Arazi  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=17461

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18039] Move the mandatory and optional files for non-english languages into ' default' directory so bug 17855 permits use of other languages

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18039

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #1 from Katrin Fischer  ---
I think this might be quite a blocker - do the ohter installers still work just
without the onboarding? Or does it break them?
What is needed to make them work?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17932] Koha::Object should provide a TO_JSON method

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17932

Marcel de Rooy  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #153 from Jonathan Druart  
---
I am sorry but this patchset can go without bug 18039.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18061] Enhance items page (moredetail.pl) with Bootstrap 3 panels

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18061

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18061] Enhance items page (moredetail.pl) with Bootstrap 3 panels

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18061

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org,
   ||oleon...@myacpl.org

--- Comment #3 from Jonathan Druart  
---
Sounds good to me, but I'd like more signoff on this one.
Owen maybe? :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18079] Cleanup of holds to pull page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18079

Josef Moravec  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

--- Comment #5 from Josef Moravec  ---
s(In reply to Jonathan Druart from comment #3)
> CONCAT_WS is a mysqlism, I would prefer to build the patron's name on TT
> side.

As this was introduced on bug 18073 I added a followup up there and rebased
this one on top of it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18072] Add Koha objects for Branch Transfer Limits

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18072

--- Comment #9 from Jonathan Druart  
---
(In reply to Josef Moravec from comment #6)
> Created attachment 60010 [details] [review]
> Bug 18072: Add deprecation warning to C4::Circulation Branch Transfer Limit
> functions

Do you plan to replace this subroutine?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18079] Cleanup of holds to pull page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18079

Josef Moravec  changed:

   What|Removed |Added

  Attachment #60038|0   |1
is obsolete||

--- Comment #4 from Josef Moravec  ---
Created attachment 60070
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60070=edit
Bug 18079: Holds to pull cleanup

Changes made:

  - remove obsolete comment in pendingreserves.pl
  - use Modern::Perl in circ/pendingreserves.pl
  - get rid of unusable param run_report - followup for bug 8454
  - get rid of references to hold status - followup for bug 9320
  - remove unused data from SQL and reservedata structure

Test plan:
1) Apply patch from bug 18073
2) Apply patch on this bug
3) Enable on shelf hold in administration -> circulation and fines rules
4) Create some holds on avalaible items
5) Confirm that circulation -> holds to pull page works as expected
6) Try to find any regression

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18072] Add Koha objects for Branch Transfer Limits

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18072

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #8 from Jonathan Druart  
---
I'd suggest to swap $to, $from in the parameters.
  ->can_be_transferred( $from, $to )
sounds more logical.
When could even pass $hashref { from => $from, to => $to } to avoid ambiguity.

I am not sure the tests on the existence of the libraries are necessary.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17932] Koha::Object should provide a TO_JSON method

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17932

--- Comment #19 from Marcel de Rooy  ---
What about this output for /api/v1/patrons/xxx after the second patch:

{"errors":[{"message":"([0] Expected string - got boolean. [1] Not
null.)","path":"\/gonenoaddress"},{"message":"([0] Expected string - got
number. [1] Not null.)","path":"\/flags"},{"message":"Expected string - got
number.","path":"\/privacy"},{"message":"Expected string - got
number.","path":"\/borrowernumber"},{"path":"\/guarantorid","message":"([0]
Expected string - got number. [1] Not null.)"},{"message":"([0] Expected string
- got number. [1] Not
null.)","path":"\/sms_provider_id"},{"path":"\/privacy_guarantor_checkouts","message":"Expected
string - got number."},{"path":"\/lost","message":"([0] Expected string - got
boolean. [1] Not null.)"}]}

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18073] Holds to pull UI improvements

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18073

--- Comment #6 from Josef Moravec  ---
Created attachment 60069
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60069=edit
Bug 18073: Followup - don't use CONCAT_WS

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18079] Cleanup of holds to pull page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18079

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
 Status|Signed Off  |Failed QA

--- Comment #3 from Jonathan Druart  
---
CONCAT_WS is a mysqlism, I would prefer to build the patron's name on TT side.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11450] Hold Request Confirm Deletion

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11450

--- Comment #18 from Jonathan Druart  
---
(In reply to Christopher Brannon from comment #16)
> Works as described, but it looks like a generic alert window is being used
> instead of a modal confirmation.  It has been standard for confirmations to
> be done through modal.  The alert includes information from the browser that
> could be confusing.
> 
> It would be preferred that this follow standard formatting before being
> pushed, but if all we are after here is the functionality, then it works.

I'd say we need it asap in stable release.
It will be easier to backport it as it is, rather than with a modal.
We could improve it later if needed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/