date:20170330

[Koha-bugs] [Bug 18357] On-site checkouts issues with 'Unlimited'

2017-03-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18357

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18356] Prediction pattern wrong, skips years, for some year based frequencies

2017-03-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18356

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18358] New: koha item-status.inc variable name

2017-03-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18358

Bug ID: 18358
   Summary: koha item-status.inc variable name
 Change sponsored?: ---
   Product: Koha
   Version: 16.05
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: long_sam...@yahoo.com.tw
QA Contact: testo...@bugs.koha-community.org

http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=koha-tmpl/opac-tmpl/bootstrap/en/includes/item-status.inc;h=5bb76ec85f312148f1118f51e5640c74434bde81;hb=refs/heads/16.05.x

I found the item.itemnotforloan variable, but opac-course-details.tt has used
this codes.


  54 [% IF ( item.itemnotforloan ) %]
  55 [% SET itemavailable = 0 %]
  56 [% IF ( item.notforloanvalueopac ) %]
  57 [% item.notforloanvalueopac
%] [% IF ( item.restrictedopac ) %]([%
item.restrictedopac %])[% END %]
  58 [% ELSE %]
  59 Not for loan [% IF (
item.restrictedopac ) %]([% item.restrictedopac
%])[% END %]
  60 [% END %]
  61 [% ELSIF ( item.notforloan_per_itemtype ) %]
  62 [% SET itemavailable = 0 %]
  63 Not for loan [% IF (
item.restrictedopac ) %]([% item.restrictedopac
%])[% END %]
  64 [% END %]

opac-course-details.tt  line 76

  76 [% INCLUDE 'item-status.inc'
item=cr.item issue=cr.issue %]
  77 [% cr.issue.date_due | $KohaDates as_due_date => 1 %]
  78 [% IF ( cr.public_note ) %]


Dump opac-course-details.pl codes. 
http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=opac/opac-course-details.pl;h=3afa8a921a3e94ab61de75052da015d85868fd35;hb=refs/heads/16.05.x

  47 my $course_reserves = GetCourseReserves( course_id => $course_id,
include_items => 1, include_count => 1 );

$course_reserves has no item.itemnotforloan variables, but has item.notforloan
variables.

 course_reserves  $VAR1 = [
   {
 'itemnumber' => '19349',
 'course_item' => {
'itemnumber' => '19349',
'ccode' => undef,
'location' => undef,
'ci_id' => '18',
'course_reserves' => [
   {
 'timestamp' =>
'2017-02-22 17:16:50',
 'ci_id' => '18',
 'staff_note' => '',
 'course_id' => '7',
 'cr_id' => '18',
 'public_note' => ''
   }
 ],
'holdingbranch' => undef,
'timestamp' => '2017-02-23 11:11:33',
'itype' => 'BOOKC',
'enabled' => 'yes'
  },
 'ci_id' => '18',
 'item' => {
 'withdrawn' => '0',
 'coded_location_qualifier' => undef,
 'marc' => '00501nam a2200157Ia
45300060005001760080042304800063168000712450097001392580023626000490024471800293942001700311999001500328AOGST20161028172127.0141108s1986
   che  000   chi d  aaog1 a賀西納 Harold Vinson Synan 著/魏玉琴 譯c(Vinson
Synan)10a靈恩運動 c賀西納 (Vinson Synan)著 ; 魏玉琴譯b美國聖潔及五旬節運動史  a初  b教會更新研究發展中心c1986a台北1
aSynanbVinson  2AOGSTcBOOKC  c6589d6589',
 'url' => undef,
 'isbn' => undef,
 'copyrightdate' => '1986',
 'itemnumber' => '19349',
 'ccode' => undef,
 'serial' => undef,
 'cn_suffix' => undef,
 'barcode' => 'B1010102217',
 'cn_item' => undef,
 'uri' => undef,
 'marcxml' => "
 http://www.w3.org/2001/XMLSchema-instance\;
 xsi:schemaLocation=\"http://www.loc.gov/MARC21/slim
http://www.loc.gov/standards/marcxml/schema/MARC21slim.xsd\;
 xmlns=\"http://www.loc.gov/MARC21/slim\;>

   00501nam a2200157Ia 4500
   AOGST
   20161028172127.0
   141108s1986che  000   chi
d
   
 aog
   
   
 \x{8cc0}\x{897f}\x{7d0d} Harold Vinson Synan
\x{8457}/\x{9b4f}\x{7389}\x{7434} \x{8b6f}
 (Vinson Synan)
   
   
 \x{9748}\x{6069}\x{904b}\x{52d5} 
 \x{8cc0}\x{897f}\x{7d0d} (Vinson Synan)\x{8457} ;

[Koha-bugs] [Bug 18357] New: On-site checkouts issues with 'Unlimited'

2017-03-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18357

Bug ID: 18357
   Summary: On-site checkouts issues with 'Unlimited'
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: n...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

When on-site checkouts are 'Unlimited' the checkouts can be blocked if there is
a limit for checkouts in general

To reproduce:
Set All/All rule with Unlimited/unlimited for normal/onsite checkouts
Will be able to perform onsite checkout 
Edit rule to be 15/Unlimited normal/onsite
Will get error  'Too many: 1 on site checkout, only  are allowed'
Set rule to 15/15
Onsite checkouts work again

Similar issue with 
Default checkout, hold and return policy
and
Default checkout limit by patron category

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18356] Prediction pattern wrong, skips years, for some year based frequencies

2017-03-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18356

Nick Clemens  changed:

   What|Removed |Added

 CC||jschm...@switchinc.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18356] New: Prediction pattern wrong, skips years, for some year based frequencies

2017-03-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18356

Bug ID: 18356
   Summary: Prediction pattern wrong, skips years, for some year
based frequencies
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Serials
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: n...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: colin.campb...@ptfs-europe.com

To reproduce:
Set a frequency with:
Unit: Year
Issues per unit: 9
Units per issue: 1

OR 

Unit: Year
Issues per unit: 12
Units per issue: 1


Notice the prediction pattern works for about 1 cycle, then crossed to next
year, then jumps a year:

No. 82  03/01/2017  
No. 83  03/31/2017  
No. 84  04/30/2017  
No. 85  05/30/2017  
No. 86  06/29/2017  
No. 87  07/29/2017  
No. 88  08/28/2017  
No. 89  09/27/2017  
No. 90  10/27/2017  
No. 91  11/26/2017  
No. 92  12/26/2017  
No. 93  01/25/2018  
No. 94  03/01/2019 WRONG!!
No. 95  03/31/2019  
No. 96  04/30/2019  
No. 97  05/30/2019  
No. 98  06/29/2019  
No. 99  07/29/2019  
No. 100 08/28/2019  
No. 101 09/27/2019  
No. 102 10/27/2019  
No. 103 11/26/2019  
No. 104 12/26/2019  
No. 105 01/25/2020  
No. 106 03/01/2021 WRONG!!

Seems to be a problem in some cases when we call:

($year) = Add_Delta_YM($year,$month,$day, $freqdata->{"unitsperissue"},0);

As this call will always add a year, it ends up in:
/usr/share/perl5/Date/Calc/PP.pm
sub DateCalc_add_year_month

Where we add $year + $freqdata->{"unitsperissue"} and return 1 if it is greater
than 1

Suspecting the pass of $freqdata->{"unitsperissue"} is incorrect

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17015] New Koha Calendar

2017-03-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

--- Comment #64 from Andreas Hedström Mace  ---
It lines and lines of this type:

DBD::mysql::st execute failed: Duplicate entry 'FRESC-2017-03-24 00:00:00' for
key 'PRIMARY' [for Statement "INSERT INTO discrete_calendar
(date,branchcode,isopened,holidaytype,note,openhour,closehour) VALUES
(?,?,?,?,?,?,?)" with ParamValues: 0=DateTime=HASH(0x57ab3f0), 1='FRESC', 2=1,
3='', 4='', 5='09:00:00', 6='17:00:00'] at (eval 1087) line 163.
DBD::mysql::st execute failed: Duplicate entry 'GEO-2017-03-24 00:00:00' for
key 'PRIMARY' [for Statement "INSERT INTO discrete_calendar
(date,branchcode,isopened,holidaytype,note,openhour,closehour) VALUES
(?,?,?,?,?,?,?)" with ParamValues: 0=DateTime=HASH(0x57ab3f0), 1='GEO', 2=1,
3='', 4='', 5='09:00:00', 6='17:00:00'] at (eval 1087) line 163.
DBD::mysql::st execute failed: Duplicate entry 'DFLT-2017-03-25 00:00:00' for
key 'PRIMARY' [for Statement "INSERT INTO discrete_calendar
(date,branchcode,isopened,holidaytype,note,openhour,closehour) VALUES
(?,?,?,?,?,?,?)" with ParamValues: 0=DateTime=HASH(0x57ab3f0), 1='DFLT', 2=1,
3='', 4='', 5='09:00:00', 6='17:00:00'] at (eval 1087) line 163.
DBD::mysql::st execute failed: Duplicate entry 'FRESC-2017-03-25 00:00:00' for
key 'PRIMARY' [for Statement "INSERT INTO discrete_calendar
(date,branchcode,isopened,holidaytype,note,openhour,closehour) VALUES
(?,?,?,?,?,?,?)" with ParamValues: 0=DateTime=HASH(0x57ab3f0), 1='FRESC', 2=1,
3='', 4='', 5='09:00:00', 6='17:00:00'] at (eval 1087) line 163.
DBD::mysql::st execute failed: Duplicate entry 'GEO-2017-03-25 00:00:00' for
key 'PRIMARY' [for Statement "INSERT INTO discrete_calendar
(date,branchcode,isopened,holidaytype,note,openhour,closehour) VALUES
(?,?,?,?,?,?,?)" with ParamValues: 0=DateTime=HASH(0x57ab3f0), 1='GEO', 2=1,
3='', 4='', 5='09:00:00', 6='17:00:00'] at (eval 1087) line 163.

FRESC, GEO and DFLT are of course the branchcodes. It can be as you say that
this is not important for testing.

But when I try to go to Tools > Discrete calendar in the staff interface I
encounter a "not found" page.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18353] Fix "Save" button on add/edit patron in IE11

2017-03-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18353

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch

--- Comment #5 from Marc Véron  ---
Could not reproduce with current master 16.12.00.016 and IE 11.0.9600.18618

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18228] Make list permissions easier to use/understand

2017-03-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18228

--- Comment #15 from Jonathan Druart  
---
So you are suggesting to... loose features?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17669] Add purging temporary uploads to cleanup_database

2017-03-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17669

--- Comment #33 from Jonathan Druart  
---
I did not find where it is referenced, not in the syspref's description nor POD
of the script nor tests.

To me today is 0, not -1

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14578] Allow merging of records upon import match

2017-03-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14578

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
 Status|Signed Off  |Patch doesn't apply

--- Comment #11 from Jonathan Druart  
---
CONFLICT (content): Merge conflict in
koha-tmpl/intranet-tmpl/prog/en/modules/tools/manage-marc-import.tt

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14826] Resurrect account offsets table

2017-03-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #40 from Jonathan Druart  
---
What would be a test plan for the 2 calls to _FixAccountForLostAndReturned in
AddIssue and AddReturn?
It would be good to have tests to cover these 2 changes.

Same for _FixOverduesOnReturn

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17669] Add purging temporary uploads to cleanup_database

2017-03-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17669

--- Comment #32 from Marcel de Rooy  ---
(In reply to Jonathan Druart from comment #31)
> Marcel, just wondering: It seems that there is no way to delete *all*
> temporary uploads (the ones from today). If we handle differently 0 and NULL
> for UploadPurgeTemporaryFilesDays, it would be possible.
> 
> Does it make sense?

Step 5 from the test plan:
Run cleanup_database with --temp-uploads --temp-uploads-override -1
All temporary files are gone

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18355] New: Permanent location should show with cart location

2017-03-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355

Bug ID: 18355
   Summary: Permanent location should show with cart location
 Change sponsored?: ---
   Product: Koha
   Version: 3.22
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: cbran...@cdalibrary.org
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

It would be helpful if the permanent location would show even when the cart
location is in use.  For example:

Location
CART (Adult Non-fiction)

It is difficult to track an item if it has an unusual location, like a display
location, and it is recently returned.

This information should show anywhere the shelving location is displayed.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18354] New: Adding item type attribute to cover image div

2017-03-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18354

Bug ID: 18354
   Summary: Adding item type attribute to cover image div
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: mich...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

A library wants to add default cover images based on item type. Adding item
type attribute to cover images div so I can specify default images for each,
using javascript. Modifying opac-results.tt

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17669] Add purging temporary uploads to cleanup_database

2017-03-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17669

--- Comment #31 from Jonathan Druart  
---
Marcel, just wondering: It seems that there is no way to delete *all* temporary
uploads (the ones from today). If we handle differently 0 and NULL for
UploadPurgeTemporaryFilesDays, it would be possible.

Does it make sense?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10357] Send email when serial received subscription link is hard to find

2017-03-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10357

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #14 from Jonathan Druart  
---
Aleisha, sorry again some more things:
1/ The style of buttons is not exactly the same (text is blue vs black)
2/  [% IF ( subscription.letter ) %]
should be
   [% IF ( subscription.letter ) %]
 
To avoid an empty span element
3/ I think we should be redirected to the detail page when we
subscribe/unsubscribe from the detail page.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15705] Notify the user on auto renewing

2017-03-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15705

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Needs Signoff

--- Comment #56 from Jonathan Druart  
---
Last minute bug found, resetting the status to request another signoff on the
last patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15705] Notify the user on auto renewing

2017-03-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15705

--- Comment #55 from Jonathan Druart  
---
Created attachment 61739
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61739=edit
Bug 15705: Reset the last error when an auto renew successes

The auto_renew_error has to be reset when an auto renew successes,
otherwise the patron is not going to receive the correct notice.

Test plan;
- Checkin an item and mark it as auto renewal (specify a due date in the past
to allow auto renewals)
- Set OPACFineNoRenewalsBlockAutoRenew to 'Block' and 'OPACFineNoRenewals' to
'1'
- Execute the script
=> Auto renewed, column auto_renew_error is null
- Add a fine of '2' to the patron
- Execute the script
=> Not auto renewed, column auto_renew_error is 'auto_too_much_oweing'
=> On the interface youo see the correct message "Automatic renewal failed,
patron has unpaid fines"
- Pay the fine
- Execute the script

Without this patch the auto_renew_error is not reset and the patron is going to
receive a letter telling him he own too much money to the library
With this patch the patron will receive a letter to inform him the renew has
been done!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17015] New Koha Calendar

2017-03-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

Jason Palmer  changed:

   What|Removed |Added

 CC||jpal...@switchinc.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17015] New Koha Calendar

2017-03-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

--- Comment #63 from Blou  ---
I also have the  "Duplicate entry 'DFLT' " error.  But as I said, it had no
impact.  

Then it takes a lng time (you can see the progress through a "select
count(*) from discrete_calendar".  This part will be improved, I have a note.

But then "with failed insert into lines.".  Could you elaborate ?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

2017-03-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560

--- Comment #48 from Jonathan Druart  
---
As you may have noticed the Circulation code is not robust and does not give us
useful return values or enough trust in the actions that have been done (or
maybe not).
I would like not to add anything to this enhancement to add feedback to the
users, it is not easy to provide a good patch to do such a job at the moment
(i.e. with the current code).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18298] Enforce password complexity

2017-03-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18298

--- Comment #30 from Jonathan Druart  
---
(In reply to Martin Renvoize from comment #29)
> > Maybe we could just have different strength settings? Instead of
> > "RequireStrongPassword" we could name this PasswordStrength and then have
> > the current and alphanumeric+digits as first two options.
> 
> Are you ok to provide this last followup Jonathan?

To me it's outside the scope of this bug report. I consider this as an
improvement of this new feature.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15438] Checking out an on-hold item sends holder' s borrowernumber in AF (screen message) field.

2017-03-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15438

Colin Campbell  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #19 from Colin Campbell  ---
Have done some testing on the patch and while inelegant - it does suppress the
random data elements. This bit of debug shows the nature of the problem:

The debug statements were in the wrapper the patch adds It outputs the keys
found in the issuingimposible and needsconfirmation hashes (2 indicates
needsconfirmation) and the keys "Remaining" in those hashs after sanitization


Mar 30 15:38:49 zazou koha_sip[28864]: Key 2:RESERVED
Mar 30 15:38:49 zazou koha_sip[28864]: Key 2:resfirstname
Mar 30 15:38:49 zazou koha_sip[28864]: Key 2:resreservedate
Mar 30 15:38:49 zazou koha_sip[28864]: Key 2:resbranchcode
Mar 30 15:38:49 zazou koha_sip[28864]: Key 2:ressurname
Mar 30 15:38:49 zazou koha_sip[28864]: Key 2:resborrowernumber
Mar 30 15:38:49 zazou koha_sip[28864]: Key 2:rescardnumber
Mar 30 15:38:49 zazou koha_sip[28864]: Remaining I:
Mar 30 15:38:49 zazou koha_sip[28864]: Remaining C:RESERVED

TBH reading the code of CanBookBeIssued is a bit dispiriting parameters have
been tacked on that are used in one place and its logic is full of special (and
not so special) cases. I'm sure it could be made clearer and more efficient as 
befits such a central routine. I'm taking the liberty of reseting the status to
Needs Signoff as some people are getting burned by this (some sites dont suffer
because their syspreferences avoid setting of fields like the above). 
If testing remember to stop and restart the sipsever you are testing against
after code changes as the sip server runs persistently unlike cgi processes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17015] New Koha Calendar

2017-03-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

--- Comment #62 from Andreas Hedström Mace  ---
Sorry, I tried today with a fresh new branch, but the same problem still
persists. The first part of the error message reads:

C4::Installer::load_sql returned the following errors while attempting to load
/home/vagrant/kohaclone/installer/data/mysql/atomicupdate/bug_17015_part1_create_discrete_calendar.sql:
DEV atomic update: bug_17015_part2_fill_discrete_calendar.perl
DBD::mysql::st execute failed: Duplicate entry 'DFLT' for key 'PRIMARY' [for
Statement "INSERT INTO branches (branchname, branchcode) VALUES(?,?)" with
ParamValues: 0='Default', 1='DFLT'] at (eval 1087) line 58.
DBD::mysql::st execute failed: Duplicate entry 'DFLT-2015-03-26 00:00:00' for
key 'PRIMARY' [for Statement "INSERT INTO discrete_calendar
(date,branchcode,isopened,holidaytype,note,openhour,closehour) VALUES
(?,?,?,?,?,?,?)" with ParamValues: 0=DateTime=HASH(0x57ab3f0), 1='DFLT', 2=1,
3='', 4='', 5='09:00:00', 6='17:00:00'] at (eval 1087) line 163.

And then it goes on for quite a while, with failed insert into lines.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15438] Checking out an on-hold item sends holder' s borrowernumber in AF (screen message) field.

2017-03-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15438

Colin Campbell  changed:

   What|Removed |Added

  Attachment #54827|0   |1
is obsolete||

--- Comment #18 from Colin Campbell  ---
Created attachment 61738
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61738=edit
Patch rebased

Patch rebased against master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17015] New Koha Calendar

2017-03-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

--- Comment #61 from Blou  ---
Thanks Andreas.  

I reproduced your problem, caused because we got two files in atomtic update,
and due to alphabets(duh!) they were called in wrong order.  Basically, that
hadn't been tested with latest patch, it seems.

I fixed the problem, you should be able to run it without glitch.  Please note
I had one error appear during update (dublicate bla) and took a note for the
dev to fix it later.  It should have no impact on your testing.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17015] New Koha Calendar

2017-03-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

Blou  changed:

   What|Removed |Added

  Attachment #60986|0   |1
is obsolete||

--- Comment #60 from Blou  ---
Created attachment 61737
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61737=edit
Bug 17015 - DiscreteCalendar UI, Back-End and necessary scripts

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16610] Regression in SIP2 user password handling

2017-03-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16610

Stefan Berndtsson  changed:

   What|Removed |Added

 CC||stefan.berndts...@ub.gu.se

--- Comment #8 from Stefan Berndtsson  ---
> Previous to bug 14507, SIP2 only did internal authentication. A change
> to the way we check empty passwords has caused any empty password to
> send back a CQ of Y. Previous to that patch set, a CQ of Y would only be
> sent back of the patron password column was NULL. Now, an empty AD field
> *always* returns a CQ of Y.

We recently began testing our selfcheck terminals with Koha. This causes an
issue with our setup. The machines we use (Tor3 from Bibliotheca) has an option
for disabling pincode/password entry (which is the situation we want). However,
this does not remove the AD fields from the transaction, just sends an empty
AD. I have no idea how common this behaviour is, but it seems to be similar to
the issue mentioned in bug 15124.

We also need the users to have a password field for web access, so we cannot
leave that field empty.

The combined consequence of this is that getting a CQN back makes it impossible
to use the selfcheck system. Changing the way the selfcheck system creator
implements their things is not really something we can do.

This whole thing could be made into a syspref, allowing for empty AD fields.

I'm not sure how to proceed with this, since this is a resolved bug. Should
adding a syspref for this be done using a new bug entry?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import

2017-03-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

--- Comment #56 from David Gustafsson  ---
Ops, wrong copy paste. Fixed missing "String::Similarity" include in Biblio.pm,
and changed $filter argument in ModBiblio to more flexible $options to avoid
future merge conflicts and provide a more stable API.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import

2017-03-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

--- Comment #55 from David Gustafsson  ---
As another criticism, some of the things that should be easy are not, in
particular, Server-Side Rendering. Ember’s implementation of SSR requires two
simple entries on the command-line. Vue’s requires a simple wrapper around
standard objects. AngularJS’ implementation is honestly kind of awful but at
least well documented with a whole dedicated sub-site.
This is Meteor’s implementation: ¯\_(ツ)_/¯

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import

2017-03-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

David Gustafsson  changed:

   What|Removed |Added

  Attachment #61641|0   |1
is obsolete||

--- Comment #54 from David Gustafsson  ---
Created attachment 61736
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61736=edit
Bug 14957 - Rule based permission for MARC fields

Add a rule based permission system for MARC field modifications.

Test plan:
1. Apply this patch
2. Run updatedatabase.pl
3. Log in to staff client
4. Enable new syspref MARCPermissions
5. You should see a new link "MARC field permissions" in the "Catalog"
   section under "Koha administrtion".
6. Go to the "MARC field permissions" page
7. Next to the page heading ("Manage MARC field permissions") there is a
   button with a question mark, click this for more information about the
   rule system.
8. Add desired rules to the rule table, press the +-button to add.
9. Clicking the pen-icon (edit) should allow you to edit corresponding
rule.
10. Clicking the x-icon should remove corresponding rule after
confirmation.
11. Selecting one or more rules followed by clicking the trash-icon
should remove all selected rules after confirmation.
12. To test your rules, import or in other way modify a record.
13. Check that the record was modified as defined by your rules.

Sponsored-by: Halland County Library

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

2017-03-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560

--- Comment #47 from Marcel de Rooy  ---
(In reply to Marcel de Rooy from comment #46)
> What may happen is this: I set rental to 6, hold fee to 7 and noissuecharge
> to 5 (a weird combination), Koha still allows me to checkout the book,
> charges me 13 AND says Cannot check out ! This is definitely a bug but not
> from this report.

Or my interpretation. Should we read it as: Can no longer check out !

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

2017-03-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560

--- Comment #46 from Marcel de Rooy  ---
I obsoleted the last patch. It is not really what I had in mind.
I found out what my problem was in the charges display:
HoldsInNoissuesCharge = Dont include
RentalsInNoissuesCharge = Include
If you set HoldsInNoissuesCharge to include, you will have the same display as
a rental fee. But what would be the side effects?

I am not sure if the current code really works fine if you would e.g. combine a
hold fee with a rental fee (playing with noissuescharge too). But we are
leaving the scope of this bug here.

In the issuing process CanBookBeIssued is called, it does not care about the
hold fee charged later. And in this case it should not block the issue here for
a hold fee only.

What may happen is this: I set rental to 6, hold fee to 7 and noissuecharge to
5 (a weird combination), Koha still allows me to checkout the book, charges me
13 AND says Cannot check out ! This is definitely a bug but not from this
report.

In conclusion: Since Koha does not handle these charges correctly here, I would
not enforce point 1 from comment 40. Since we move point 2 to another report,
point 3 makes no sense yet..

Before passing QA: Do you still have any feedback to these last findings?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

2017-03-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #61691|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18353] Fix "Save" button on add/edit patron in IE11

2017-03-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18353

--- Comment #4 from Magnus Enger  ---
(In reply to Mirko Tietgen from comment #3)
> Is your library on 16.11.x? I am building 16.11.06 now, they could check if
> that fixes it.

16.11.5 yes, with a plan to upgrade to .06 this weekend. :-)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18353] Fix "Save" button on add/edit patron in IE11

2017-03-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18353

--- Comment #3 from Mirko Tietgen  ---
Is your library on 16.11.x? I am building 16.11.06 now, they could check if
that fixes it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18353] Fix "Save" button on add/edit patron in IE11

2017-03-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18353

--- Comment #2 from Magnus Enger  ---
(In reply to Mirko Tietgen from comment #1)
> Check https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18305
> It sounds like a duplicate. At least the floating toolbar part, maybe both.

Probably the same problem, but not a duplicate, since that was MARC editor and
this is patron entry?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18353] Fix "Save" button on add/edit patron in IE11

2017-03-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18353

Mirko Tietgen  changed:

   What|Removed |Added

 CC||mi...@abunchofthings.net

--- Comment #1 from Mirko Tietgen  ---
Check https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18305
It sounds like a duplicate. At least the floating toolbar part, maybe both.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18353] New: Fix "Save" button on add/edit patron in IE11

2017-03-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18353

Bug ID: 18353
   Summary: Fix "Save" button on add/edit patron in IE11
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: major
  Priority: P5 - low
 Component: Patrons
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: mag...@libriotech.no
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

A customer has reported this and cait has confirmed it. When you try to add or
edit a patron in Internet Explorer 11 the "Save" button does not work. It seems
the floating toolbar that should make sure "Save" and "Cancel" are always
visible is also broken. Not sure if these two things are related or just
accidental. 

I would look into solving this myself, but I do not have access to IE.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

2017-03-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560

--- Comment #45 from Marcel de Rooy  ---
> > [2] Provide a message to the SIP terminal at checkout time. (a.o. comment31,
> > 34)
> > Note that Colin suggested to do this on another report.
> > In that case we could perhaps add a small "disclaimer" to the preference
> > that SIP does apply, but not show the fee at checkout time.
> > And as a side note, SIP currently does not show a fee when placing a hold.
> > But this is just a theoretical thing; not really used.
> 
> Same as previously, the message did not show up before. Why should we add a
> warning to the pref?
Same as before too. You changed behavior. But as stated before, this could go
to another report.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

2017-03-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560

--- Comment #44 from Marcel de Rooy  ---
(In reply to Jonathan Druart from comment #41)
> (In reply to Marcel de Rooy from comment #40)
> > [1] If we checkout in the staff client, wouldn't it be good to also show a
> > message? (Just like the sco message.) 
> > See comment23, 27 and 30. Show the fee under Attention just like rental 
> > fees.
> 
> I would consider this as a new enhancement, the info did not show up before
> this patch set.
> I will submit a patch anyway.

The info did not show up before since the hold fee was not charged at checkout
time before. So this is not a new enhancement.
I am still looking at your patch btw. You may have a point somehow, since the
rental charge is not presented as an individual charge but as a total amount.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays

2017-03-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063

Alex Arnaud  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

--- Comment #59 from Alex Arnaud  ---
Patch above fix Marcel's QA comments. Also, i added some minor changes:

in the sub Koha::Hold::set_waiting:
 => Remove the test "if (
C4::Context->preference("ExpireReservesMaxPickUpDelay") )".
I think we want to calculate the expiration date even if
ExpireReservesMaxPickUpDelay is set to dont't allow

in C4::Reserves::CancelExpiredReserves:
return if ExpireReservesMaxPickUpDelay is set to don't allow. Do nothing

turn this BZ back to Signed off status. Tell me if the changes make i should
pass it to Needs Signoff again.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays

2017-03-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063

--- Comment #58 from Alex Arnaud  ---
Created attachment 61735
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61735=edit
Bug 12063 - Fix QA failures

- Remove expiration date calculation in C4::Letter since it's done
when setting the reserve waiting,
  - remove expiration date calculation in circ/waitingreserves.pl. Use
the one in DB,
  - add a new atomic update that calculate expiration date for
waiting reserves,
  - add tests for days_foward function and fix the infinite loop.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17560] Hold fee placement at point of checkout

2017-03-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560

--- Comment #43 from Marcel de Rooy  ---
+$hold_existed = Koha::Holds->search({ -or => { 'biblionumber'
=> $item->biblionumber, 'itemnumber' => $item->itemnumber}})->count;

versus

+my $had_an_hold_placed_on_it = Koha::Holds->search({
borrowernumber => $borrower->{borrowernumber}, itemnumber => $item->itemnumber
})->count;

This difference may actually illustrate why a consolidation would be nice.
Will amend it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18138] Use MARC modification template when adding/ updating bibliographic records

2017-03-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138

David Gustafsson  changed:

   What|Removed |Added

 CC||glask...@gmail.com

--- Comment #4 from David Gustafsson  ---
Added some tests.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18138] Use MARC modification template when adding/ updating bibliographic records

2017-03-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138

David Gustafsson  changed:

   What|Removed |Added

  Attachment #61443|0   |1
is obsolete||

--- Comment #3 from David Gustafsson  ---
Created attachment 61734
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61734=edit
Bug 18138: Use MARC modification template when adding/updating bibliographic
records

Add a preference that enables a specific marc modification template to be
applied on bibliographic records saved using simple or advanced MARC editor or
the HTTP API.

To test:
1) Create a MARC modification template containg one or more actions.
2) Under "Global system preferences" and "Cataloging" set the
"EditBiblioMarcModificationTemplate" preference to the name of the previously
created template.
3) Edit (or create) a bibliographic record using either the simple or advanced
MARC editor.
4) Save the record.
5) Verify that the action(s) have been applied.

Sponsored-by: Gothenburg University Library

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18352] New: Need barcode along with record details in fines section

2017-03-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18352

Bug ID: 18352
   Summary: Need barcode along with record details in fines
section
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: vimal0...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

Created attachment 61733
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61733=edit
Fine page

Its nice to see barcode with book details in fines section.
Many books have similar titles.
Its necessary to identify the each titles with fine.
In this context identify book by barcode is very convenient.
Please see the screen shot attached with this message.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18352] Need barcode along with record details in fines section

2017-03-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18352

vimal kumar  changed:

   What|Removed |Added

Version|master  |16.11

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18298] Enforce password complexity

2017-03-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18298

Martin Renvoize  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com

--- Comment #29 from Martin Renvoize  ---
> Maybe we could just have different strength settings? Instead of
> "RequireStrongPassword" we could name this PasswordStrength and then have
> the current and alphanumeric+digits as first two options.

Are you ok to provide this last followup Jonathan?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15408] Timestamp not updated when you duplicate a budget

2017-03-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15408

--- Comment #11 from Baptiste  ---
Hi,
Working on mine, did you follow a testplan like this one ? And I'm surprized
about all tests being fine, because the test about budget is supposed to be
false : checkout all file except test 

1 - go on mysql "select * from aqbudgets \G"
2 - duplicate a budget
3 - "select * from aqbudgets \G" => new budgets should have the same timestamp
as the others
4 - apply patch
5 - "select * from aqbudgets \G" => new budget have new timestamp

Errors I think you can have done testing my patch:
- look at aqbudgetperiods
- look at the date of creation or enddate and not timestamp

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18035] Front-end changes to serials -> Numbering patterns

2017-03-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18035

Marc Véron  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18035] Front-end changes to serials -> Numbering patterns

2017-03-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18035

Marc Véron  changed:

   What|Removed |Added

  Attachment #61722|0   |1
is obsolete||

--- Comment #8 from Marc Véron  ---
Created attachment 61731
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61731=edit
Bug 18035: Front-end changes to serials -> numbering patterns

This patch:
1) Uses datatables functionality on numbering patterns table
2) Shows breadcrumbs when using the form to add or modify numbering
patterns
3) Updates the Save, Reset, and Test Pattern buttons in the form to be
bootstrap 3 buttons

To test:
1) Confirm that datatable sorting works on all columns EXCEPT Actions
column
2) Click 'New numbering pattern'
3) Confirm breadcrumbs reads 'New numbering pattern'
4) Go back to numbering patterns and Edit an existing one
5) Confirm breadcrumbs reads 'Modifying number pattern ''
6) Confirm Save, Reset and Test pattern buttons now show as bootstrap3
buttons
7) Confirm all buttons work as expected

Sponsored-by: Catalyst IT

Followed test plan works as expected.
Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18035] Front-end changes to serials -> Numbering patterns

2017-03-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18035

Marc Véron  changed:

   What|Removed |Added

  Attachment #59763|0   |1
is obsolete||

--- Comment #7 from Marc Véron  ---
Comment on attachment 59763
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59763
Bug 18035: Front-end changes to serials -> Claims

Obsoleting first patch (with wrong title).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17669] Add purging temporary uploads to cleanup_database

2017-03-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17669

--- Comment #30 from Marcel de Rooy  ---
(In reply to Jonathan Druart from comment #25)
> The pref name contains '_', it's unusual. Not blocker
> 
> I'd rename the option's name of the script with --temp-uploads-days
> (currently --temp-uploads-override). What do you think?

Always in for changing names or wording :)
Done

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17669] Add purging temporary uploads to cleanup_database

2017-03-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17669

--- Comment #28 from Marcel de Rooy  ---
Created attachment 61729
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61729=edit
Bug 17669: [QA Follow-up] Rename preference by removing underscores

Requested by QA on comment25.
Result of:
git grep -l Upload_PurgeTemporaryFiles_Days | xargs sed -i -e
"s/Upload_PurgeTemporaryFiles_Days/UploadPurgeTemporaryFilesDays/g"

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17669] Add purging temporary uploads to cleanup_database

2017-03-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17669

--- Comment #29 from Marcel de Rooy  ---
Created attachment 61730
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61730=edit
Bug 17669: [QA Follow-up] Rename --temp-uploads-override parameter

As requested by QA on comment25.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18307] Branchname is no more displayed in subscription tab wiew

2017-03-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18307

Marc Véron  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=18350

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18350] Moving call number in subscriptions tab in OPAC biblio detail

2017-03-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18350

Marc Véron  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=18307

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18350] Moving call number in subscriptions tab in OPAC biblio detail

2017-03-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18350

Marc Véron  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||ve...@veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18350] Moving call number in subscriptions tab in OPAC biblio detail

2017-03-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18350

Marc Véron  changed:

   What|Removed |Added

  Attachment #61725|0   |1
is obsolete||

--- Comment #2 from Marc Véron  ---
Created attachment 61728
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61728=edit
Bug 18350: Moving call number in subscriptions tab in OPAC biblio detail

This patches moves the call number up to be under the library name, so
it is equivalent to the staff client

To test:
1) Go to the detail page of a biblio with subscriptions in the staff
client
2) Notice callnumber sits under the library name
3) Go to the detail page of the same biblio in OPAC
4) Notice callnumber is not in the same order
5) Apply patch, refresh page
6) Notice callnumber is now in same order

Sponsored-by: Catalyst IT

Followed test plan, works as expected.
Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10357] Send email when serial received subscription link is hard to find

2017-03-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10357

Marc Véron  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=18350
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18350] Moving call number in subscriptions tab in OPAC biblio detail

2017-03-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18350

Marc Véron  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=10357

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17669] Add purging temporary uploads to cleanup_database

2017-03-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17669

--- Comment #27 from Marcel de Rooy  ---
Created attachment 61727
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61727=edit
Bug 17669: Rename preference by removing underscores

Requested by QA on comment25.
Result of:
git grep -l Upload_PurgeTemporaryFiles_Days | xargs sed -i -e
"s/Upload_PurgeTemporaryFiles_Days/UploadPurgeTemporaryFilesDays/g"

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10357] Send email when serial received subscription link is hard to find

2017-03-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10357

Marc Véron  changed:

   What|Removed |Added

  Attachment #61724|0   |1
is obsolete||

--- Comment #13 from Marc Véron  ---
Created attachment 61726
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61726=edit
Bug 10357: Adding link for email notification for new subscription issues to
opac-detail

This patch adds the link to the opac-detail.pl page so it is less hard
to find.
Update: Fixing link to look like button, adding span ID around element
Update: Changing ID to Class

To test:
1) Add a subscription, attach it to a record and select a notice under
'Patron notification'. Hit Next, fill in some fields and save the
subscription
2) Go to that record detail page in the OPAC. Go to the subscriptions
tab, click 'More details'. Notice how many clicks it takes to see the
'Subscribe' button
3) Apply patch and go back to the details page for the record
4) Notice now there is a 'subscribe' link
5) Confirm this link still works as expected

Sponsored-by: Catalyst IT

Signed-off-by: Séverine QUEUNE 
Signed-off-by: Séverine QUEUNE 

Followed test plan, works as expected.
Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17669] Add purging temporary uploads to cleanup_database

2017-03-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17669

--- Comment #26 from Marcel de Rooy  ---
(In reply to Jonathan Druart from comment #25)
> Right, I forgot that, makes sense.
> It sounds weird to have ->delete behaving differently than
> Koha::Objects->delete, not blocker

Should be solved on a general level, not here.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries

2017-03-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

--- Comment #170 from Martin Renvoize  ---
I've not really been following this one too closely yet, though it is
interesting.

I agree that we need a clear inheritance model defined, and personally would
agree with the above comments.

As a further note, I see you've chosen to use Adjacency List, and you've coded
the queries yourself.  Did you investigate any of the other options for storing
hierarchies in a database.. Nested Set or Materialized Path perhaps, and did
you not consider leaning on the shoulders of giants and using one of the
DBIx::Class modules to construct the queries for you in the most optimal way
for the data you require?

It's important to consider future use cases, each hierarchical data model has
it's strengths and it's weaknesses in terms of performance and space
requirements.  In general, I think Materialized Path is the defacto recommended
way of doing hierarchies in relational databases now.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

67 matches

Mail list logo