[Koha-bugs] [Bug 18626] Add ability to track cardnumber changes for patrons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18626

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18626] Add ability to track cardnumber changes for patrons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18626

Marc Véron  changed:

   What|Removed |Added

  Attachment #63532|0   |1
is obsolete||

--- Comment #2 from Marc Véron  ---
Created attachment 63560
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63560=edit
Bug 18626 - Add ability to track cardnumber changes for patrons

Some libraries want to keep a history of cardnumber changes for a
patron. This is a feature that another ILS has.

Test Plan:
1) Apply this patch
2) Enable the BorrowersLog
3) Modify a patron, update his or her cardnumber
4) Notice the entry in the action log containing the old and new cardnumbers
5) Edit a patron, leave the cardnumber the same
6) Note there is no cardnumber change entry in the action logs
7) Disable BorrowersLog, modify a patron cardnumber
8) Note there is no cardnumber change entry in teh action logs

Followed test plan, works as expected
Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18627] Items created via MarcItemFieldsToOrder are not linked to orders

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18627

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl

--- Comment #3 from Marcel de Rooy  ---
QA: Looking here now

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18635] Koha::Patron->guarantees() should return results alphabetically

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18635

Marc Véron  changed:

   What|Removed |Added

  Attachment #63553|0   |1
is obsolete||

--- Comment #4 from Marc Véron  ---
Created attachment 63559
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63559=edit
Bug 18635 - Koha::Patron->guarantees() should return results alphabetically

To test:
1 - Add the same guarantor to a number of patrons, ensuring random order
alphabetically
2 - View the guarantors record, note unordered list of guarantees
3 - Apply patch
4 - Guarantees are alphabetical

Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18635] Koha::Patron->guarantees() should return results alphabetically

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18635

Marc Véron  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||ve...@veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18635] Koha::Patron->guarantees() should return results alphabetically

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18635

Marc Véron  changed:

   What|Removed |Added

  Attachment #63552|0   |1
is obsolete||

--- Comment #3 from Marc Véron  ---
Created attachment 63558
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63558=edit
Bug 18635 - Unit tests

To test:
1 - Apply this patch only
2 - Prove t/db_dependent/Patron.t
3 - Tests fail
4 - Apply other patch
5 - Tests pass

Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18634] Missing empty line at end of opac.pref

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18634

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch

--- Comment #4 from Marc Véron  ---
I could not reproduce on current master with de-DE and it-IT

However an empty line 826 seems to be superfluous. Other *.pref-files do not
have an empty line at the end. So I think it is better to just remove line 826.

What do you think about?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18552] Borrower debarments do not show on member detail page.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18552

Marc Véron  changed:

   What|Removed |Added

  Attachment #63551|0   |1
is obsolete||

--- Comment #2 from Marc Véron  ---
Created attachment 63557
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63557=edit
Bug 18552: Borrower debarments not showing on member detail page

To test:
1) Go to a borrowers details page and create a manual restriction
2) Notice the restriction shows at the top of the page but the
restriction tab says the member is currently unrestricted
3) Apply patch and refresh page
4) Restrictions tab should now correctly show debarments and correct
number is shown
5) Confirming deleting and adding restrictions still works as expected

Sponsored-by: Catalyst IT

Followed test plan, works as expected
Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18552] Borrower debarments do not show on member detail page.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18552

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18598] Quick add form doesn't clear values when switching

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18598

Marc Véron  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18598] Quick add form doesn't clear values when switching

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18598

Marc Véron  changed:

   What|Removed |Added

  Attachment #63554|0   |1
is obsolete||

--- Comment #5 from Marc Véron  ---
Created attachment 63556
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63556=edit
Bug 18598 - Quick add form doesn't clear values when switching

To test:
1 - Fill out some fields in quick add
2 - Switch to full form and clear fields
3 - Switch back and fields are still populated
4 - Fill a field in long form
5 - Switch to quick add and clear it
6 - Save
7 - Value set in 4 is saved
8 - Apply patch
9 - Repeat 1-6 - values should be cleared and not saved

Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18636] New: Can not save new patron on fresh install ( Conflict between autoMemberNum and BorrowerMandatoryField)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18636

Bug ID: 18636
   Summary: Can not save new patron on fresh install (Conflict
between autoMemberNum and BorrowerMandatoryField)
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Patrons
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: ve...@veron.ch
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

Tested on a fresh install on current master

To reproduce:
- Go to Koha > Patrons > Add patron (full form)
- Verify that label for card number reads: "Card number(leave blank for auto
calc during registration):"
- Do not enter anything in field card number
- Enter surname, try to save
- Form does not save because field card number is required

Reason:
- autoMemberNum is on by default 
 (sysprefs.sql line 65)
- BorrowerMandatoryField contains surname|cardnumber by default
 (sysprefs.sql line 86)
- Full form does not save because card number is mandatory and empty

Note: With quick add form and settings above, cardnumber is not displayed, form
saves properly.

What to do?
- Better explanation for autoMemberNum and BorrowerMandatoryField
- Set defaults for autoMemberNum and BorrowerMandatoryField in a way that they
do not conflict?
- Ignore cardnumber being a mandatory field if autoMemberNum is on?
- Ask for settings in onboarding tool?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18231] Add the missing id-column to koha.issuingrules-table for DBIC fixtures

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18231

--- Comment #18 from M. Tompsett  ---
Comment on attachment 61219
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61219
Bug 18231: Make sure we will not add the column twice

Review of attachment 61219:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=18231=61219)
-

I was just expecting the .perl and removal of the .sql when I went to eyeball
this.

::: Koha/Schema/Result/BorrowerAttributeType.pm
@@ +154,5 @@
>  );
>  
>  
> +# Created by DBIx::Class::Schema::Loader v0.07042 @ 2017-03-17 11:43:14
> +# DO NOT MODIFY THIS OR ANYTHING ABOVE! md5sum:0jCQN4xSJYbQC5e7fGn5WQ

Why add this?

::: Koha/Schema/Result/Issue.pm
@@ +222,5 @@
>  );
>  
>  
> +# Created by DBIx::Class::Schema::Loader v0.07042 @ 2017-03-17 11:43:14
> +# DO NOT MODIFY THIS OR ANYTHING ABOVE! md5sum:zGLKwoUmq4pcvY16ei3VPg

Why add this?

::: Koha/Schema/Result/Issuingrule.pm
@@ +330,5 @@
>  );
>  
>  
> +# Created by DBIx::Class::Schema::Loader v0.07042 @ 2017-03-17 11:43:14
> +# DO NOT MODIFY THIS OR ANYTHING ABOVE! md5sum:3K9yYzzg9IYRAuxSXd7CPg

Why add this?

::: Koha/Schema/Result/OldIssue.pm
@@ +207,5 @@
>  );
>  
>  
> +# Created by DBIx::Class::Schema::Loader v0.07042 @ 2017-03-17 11:43:14
> +# DO NOT MODIFY THIS OR ANYTHING ABOVE! md5sum:yTyCAau9EZHBgdqN4Ptljg

Why add this?

::: Koha/Schema/Result/SearchField.pm
@@ +48,4 @@
>  =head2 type
>  
>data_type: 'enum'
> +  extra: {list => ["","string","date","number","boolean","sum"]}

Is this from another bug?

@@ +65,4 @@
>"type",
>{
>  data_type => "enum",
> +extra => { list => ["", "string", "date", "number", "boolean", "sum"] },

Is this from another bug?
I think it may be valid, but I don't think this bug originally added it.

::: installer/data/mysql/atomicupdate/Bug-18231-id_to_ussingrules_table.perl
@@ +1,3 @@
> +$DBversion = 'XXX';  # will be replaced by the RM
> +if( CheckVersion( $DBversion ) ) {
> +unless ( column_exists( 'issuingrules', 'issuingrules_id' ) ) {

This column_exists() has been a fantastic add, since it was put in. :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18596] Quick add form duplicating password confirm

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18596

--- Comment #6 from Nick Clemens  ---
Created attachment 63555
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63555=edit
Bug 18596 (QA Followup)

Use TT in a less awkward way

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18596] Quick add form duplicating password confirm

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18596

Nick Clemens  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18598] Quick add form doesn't clear values when switching

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18598

--- Comment #4 from Nick Clemens  ---
Yeah, I removed one too many lines in that first patch ( meant to remove the if
condtiion, removed the whole block )

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18598] Quick add form doesn't clear values when switching

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18598

Nick Clemens  changed:

   What|Removed |Added

  Attachment #63445|0   |1
is obsolete||

--- Comment #3 from Nick Clemens  ---
Created attachment 63554
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63554=edit
Bug 18598 - Quick add form doesn't clear values when switching

To test:
1 - Fill out some fields in quick add
2 - Switch to full form and clear fields
3 - Switch back and fields are still populated
4 - Fill a field in long form
5 - Switch to quick add and clear it
6 - Save
7 - Value set in 4 is saved
8 - Apply patch
9 - Repeat 1-6 - values should be cleared and not saved

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18598] Quick add form doesn't clear values when switching

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18598

Nick Clemens  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18635] Koha::Patron->guarantees() should return results alphabetically

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18635

Nick Clemens  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18635] Koha::Patron->guarantees() should return results alphabetically

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18635

--- Comment #2 from Nick Clemens  ---
Created attachment 63553
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63553=edit
Bug 18635 - Koha::Patron->guarantees() should return results alphabetically

To test:
1 - Add the same guarantor to a number of patrons, ensuring random order
alphabetically
2 - View the guarantors record, note unordered list of guarantees
3 - Apply patch
4 - Guarantees are alphabetical

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18635] Koha::Patron->guarantees() should return results alphabetically

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18635

--- Comment #1 from Nick Clemens  ---
Created attachment 63552
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63552=edit
Bug 18635 - Unit tests

To test:
1 - Apply this patch only
2 - Prove t/db_dependent/Patron.t
3 - Tests fail
4 - Apply other patch
5 - Tests pass

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18635] Koha::Patron->guarantees() should return results alphabetically

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18635

Nick Clemens  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18635] New: Koha::Patron->guarantees() should return results alphabetically

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18635

Bug ID: 18635
   Summary: Koha::Patron->guarantees() should return results
alphabetically
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Patrons
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: n...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

Currently there is no sort here so patrons are returned in db order (unordered)

We should return them alphabetically for display and other purposes

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18552] Borrower debarments do not show on member detail page.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18552

Aleisha Amohia  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |alei...@catalyst.net.nz
   |ity.org |
  Change sponsored?|--- |Sponsored
 CC||alei...@catalyst.net.nz

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18552] Borrower debarments do not show on member detail page.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18552

Aleisha Amohia  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18552] Borrower debarments do not show on member detail page.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18552

--- Comment #1 from Aleisha Amohia  ---
Created attachment 63551
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63551=edit
Bug 18552: Borrower debarments not showing on member detail page

To test:
1) Go to a borrowers details page and create a manual restriction
2) Notice the restriction shows at the top of the page but the
restriction tab says the member is currently unrestricted
3) Apply patch and refresh page
4) Restrictions tab should now correctly show debarments and correct
number is shown
5) Confirming deleting and adding restrictions still works as expected

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18634] Missing empty line at end of opac.pref

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18634

--- Comment #3 from Blou  ---
Sponsored by : CCSR

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18634] Missing empty line at end of opac.pref

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18634

Blou  changed:

   What|Removed |Added

  Change sponsored?|--- |Sponsored
 CC||philippe.blo...@inlibro.com
   Patch complexity|--- |String patch
 Status|NEW |Needs Signoff
   Assignee|oleon...@myacpl.org |philippe.blo...@inlibro.com

--- Comment #2 from Blou  ---
It's a shame to have a commit line just for that, but really, that's the reason
this is not translatable.  Or rather, it translates but don't show up.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18634] Missing empty line at end of opac.pref

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18634

--- Comment #1 from Blou  ---
Created attachment 63550
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63550=edit
Bug 18634 - Missing empty line at end of opac.pref

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18634] New: Missing empty line at end of opac.pref

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18634

Bug ID: 18634
   Summary: Missing empty line at end of opac.pref
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: philippe.blo...@inlibro.com
QA Contact: testo...@bugs.koha-community.org

The subject line says it all.

When this line is missing, all Payment(PayPal) sysprefs don't show up in
translated pages.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18438] Check in: Modal about holds hides important check in messages

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18438

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #63458|0   |1
is obsolete||

--- Comment #28 from Jonathan Druart  
---
Created attachment 63549
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63549=edit
Bug 18438 - Implemented data-dismiss="modal" in returns.tt so that any warning
messages hidden by a hold modal are displayed after it is dismissed

Test plan:
1. Check out an item to one patron whilst having that item also being on
hold to another patron

2. Check the item back in

3. Notice a modal box appears greying out the background with three
buttons 'Confirm hold', 'Print and confirm' and 'Ignore'. Click confirm
and notice that the page refreshes and no yellow warning messages are
able to be displayed

4. Now that you have checked the item in. Try checking it in a second
time by clicking on the Checkin tab and writing in the barcode.

5. The modal box will appear again, this time with three buttons
'Confirm', 'Print and confirm' and 'Cancel hold'

6. Click the 'Confirm' button and the page refreshes again and the
yellow warning message hidden by the modal box is not properly displayed
to the user. Notice that the focus is on the barcode input box.

7. Apply patch

8. Try checking in the item again, and this time after clicking the
'confirm' button on the modal box notice that the yellow warning message
is displayed telling the user the item was "Not checked out". Also
notice the focus is in the barcode inputbox.

9. Drop the hold on the item and make sure it is not checked out.

10. Repeat steps 1 and 2 and notice after clicking the 'Confirm hold'
button the page refreshes and the item is successfully checked back in.
With the focus on the barcode input.

11. View koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt and
notice that the button on line 345 does not use an onclick parameter

Followed test plan, works as expected.
Signed-off-by: Marc Véron 

Signed-off-by: Jonathan Druart 
Amended-patch: remove spaces

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18438] Check in: Modal about holds hides important check in messages

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18438

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18632] CGI::param called in list context flooding erro logs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18632

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18632] CGI::param called in list context flooding erro logs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18632

--- Comment #1 from Jonathan Druart  
---
Created attachment 63548
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63548=edit
Bug 18632: Remove 'CGI::param called in list context' warnings

Once again, after bug 16154 and bug 16259 we need to remove more
occurrence of CGi->param called in list context.
Refer to bug 15809 for more information.

Test plan:
Make sure you do not see the error on the modified scripts.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17456] Cataloging plugins: change of behaviour at fileds driven by plugins

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17456

--- Comment #5 from Mike  ---
OK, we can close it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18633] Logs are full of CGI:: param called in list context - itemsearch.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18633

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||16154


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16154
[Bug 16154] Replace CGI->param with CGI->multi_param in list context
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18632] CGI::param called in list context flooding erro logs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18632

Jonathan Druart  changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |jonathan.dru...@bugs.koha-c
   ||ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18632] CGI::param called in list context flooding erro logs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18632

Jonathan Druart  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=18633

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16154] Replace CGI->param with CGI->multi_param in list context

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16154

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||18633


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18633
[Bug 18633] Logs are full of CGI::param called in list context - itemsearch.pl
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11425] Search form for items

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11425

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||18633

--- Comment #72 from Jonathan Druart  
---
See bug 18633


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18633
[Bug 18633] Logs are full of CGI::param called in list context - itemsearch.pl
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18633] Logs are full of CGI:: param called in list context - itemsearch.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18633

Jonathan Druart  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=18632

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18633] Logs are full of CGI:: param called in list context - itemsearch.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18633

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||11425


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11425
[Bug 11425] Search form for items
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18633] New: Logs are full of CGI:: param called in list context - itemsearch.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18633

Bug ID: 18633
   Summary: Logs are full of CGI::param called in list context -
itemsearch.pl
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: normal
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: julian.maur...@biblibre.com
  Reporter: jonathan.dru...@bugs.koha-community.org
QA Contact: testo...@bugs.koha-community.org

The use of the CGI TT plugin in  catalogue/itemsearch.tt floods logs with:

itemsearch.pl: CGI::param called in list context from package
Template::Document line 118, this can lead to vulnerabilities. See the warning
in "Fetching the value or values of a single named parameter" at
/usr/share/perl5/CGI.pm line 436., referer: http://xxx/cgi-bin/koha/about.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11425] Search form for items

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11425

--- Comment #71 from Jonathan Druart  
---
The use of the CGI TT plugin floods logs with:

itemsearch.pl: CGI::param called in list context from package
Template::Document line 118, this can lead to vulnerabilities. See the warning
in "Fetching the value or values of a single named parameter" at
/usr/share/perl5/CGI.pm line 436., referer: http://xxx/cgi-bin/koha/about.pl

Julian, can you check how we can fix that?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18632] CGI::param called in list context flooding erro logs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18632

Jonathan Druart  changed:

   What|Removed |Added

   Severity|enhancement |normal
 Status|NEW |ASSIGNED
   Assignee|neng...@gmail.com   |gmcha...@gmail.com
  Component|About   |Architecture, internals,
   ||and plumbing
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
Version|16.11   |master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16154] Replace CGI->param with CGI->multi_param in list context

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16154

Jonathan Druart  changed:

   What|Removed |Added

  Component|Acquisitions|Architecture, internals,
   ||and plumbing

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18632] CGI::param called in list context flooding erro logs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18632

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||16154


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16154
[Bug 16154] Replace CGI->param with CGI->multi_param in list context
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16154] Replace CGI->param with CGI->multi_param in list context

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16154

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||18632


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18632
[Bug 18632] CGI::param called in list context flooding erro logs
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18551] Hide with CSS dynamic elements in member search

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18551

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18551] Hide with CSS dynamic elements in member search

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18551

--- Comment #19 from Jonathan Druart  
---
Created attachment 63547
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63547=edit
Bug 18551: followup - hide advanced filters in header, move hidding to css file

Test plan:
The same as first patch, but also with advanced search form in header hidden
on page load - see comment 4

Issue with advanced search form is gone.
Signed-off-by: Marc Véron 

Signed-off-by: Philippe 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18551] Hide with CSS dynamic elements in member search

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18551

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #63491|0   |1
is obsolete||
  Attachment #63492|0   |1
is obsolete||

--- Comment #18 from Jonathan Druart  
---
Created attachment 63546
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63546=edit
Bug 18551 - Hide with CSS dynamic elements in member search

In member search page, the result table is in Ajax so fully managed by
Javascript. There is also a yellow dialog message prepared in HTML.

Thoses elements are hidden by JS code : ie $("#patron_list_dialog").hide().

The problem is that the static page is first loaded an displayed then the JS
code runs an hides the elements.
On a low performance computer, this action is visible and looks like there is a
blinking yellow message.

I propose to hide with CSS so that thoses elements are not displayed in static
page and are there shown in dynamic JS code.

Test plan :
Check display is unchanged :
- Go to home page /cgi-bin/koha/members/members-home.pl
- Perform patron search from header search box
- Perform patron search by clicking on a letter
- Perform patron search from filters (left of results table)
- Select a patron and add it to a list => you see the yellow message

Yellow message does no longer appear with this patch.
Signed-off-by: Marc Véron 

Signed-off-by: Philippe 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18376] authority framework creation fails under Plack

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18376

Jonathan Druart  changed:

   What|Removed |Added

   Severity|normal  |major

--- Comment #9 from Jonathan Druart  
---
Upping the severity a bit as Plack is considered stable.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18376] authority framework creation fails under Plack

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18376

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #8 from Jonathan Druart  
---
(In reply to Katrin Fischer from comment #3)
> I can see the error, trying to sign off.

Same, confirmed!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18376] authority framework creation fails under Plack

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18376

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18376] authority framework creation fails under Plack

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18376

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #63401|0   |1
is obsolete||

--- Comment #6 from Jonathan Druart  
---
Created attachment 63544
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63544=edit
Bug 18376 - authority framework creation fails under Plack

With plack, when creating a new authority framework from another, you get the
error :
Can't call method "prepare" on an undefined value at
(...)/src/admin/auth_tag_structure.pl line 267.

Looks like plack does not like when the var $dbh from the script is called
inside a sub.

This patch adds a local var $dbh inside sub duplicate_auth_framework(), like in
sub StringSearch().

Also correctes a redefine of my $sth.

Test plan:
- Go to Administration > Authority types
- Create a new type
- On this new type click on Actions > MARC Structure
- Select another type and click OK
=> You must get a table filled with the tag structure
Check with and without plack
You may not be able to reproduce the error with plack.

Signed-off-by: Katrin Fischer 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18376] authority framework creation fails under Plack

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18376

--- Comment #7 from Jonathan Druart  
---
Created attachment 63545
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63545=edit
Bug 18376: Do not need to prepare a single statement, use do

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18597] Quick add form does not transfer patron attributes values when switching forms /saving

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18597

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18597] Quick add form does not transfer patron attributes values when switching forms /saving

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18597

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #63448|0   |1
is obsolete||

--- Comment #6 from Jonathan Druart  
---
Created attachment 63543
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63543=edit
Bug 18597 - Quick add form does not transfer patron attributes values when
switching forms/saving

The function that switches between quick add/fulll form assumes labels
are followed by values - patron_attr don't follow this pattern. This
patch just moves the hidden input field

To test:
1 - Have some patron attributes (with/without auth values set)
2 - Add them to QuickAddFields (patron_attr2 for example)
3 - view quick add form and set some values
4 - Switch to full form, values not transferred
5 - Switch to quick add, view values, save
6 - Values are not saved :-(
7 - Apply patch
8 - Repeat 3 - 5
9 - Values are transferred and saved :-)

Signed-off-by: Peggy Thrasher 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18597] Quick add form does not transfer patron attributes values when switching forms /saving

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18597

--- Comment #5 from Jonathan Druart  
---
(In reply to Jonathan Druart from comment #4)
> I do not manage to see the patron attributes on the quick add form.

Ha, we have to guess the id of the attribute in DB. That's very badly
implemented.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18597] Quick add form does not transfer patron attributes values when switching forms /saving

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18597

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #4 from Jonathan Druart  
---
I do not manage to see the patron attributes on the quick add form.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17456] Cataloging plugins: change of behaviour at fileds driven by plugins

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17456

Marjorie Barry-Vila  changed:

   What|Removed |Added

 CC||marjorie.barry-v...@ccsr.qc
   ||.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18434] Elasticsearch indexing broken with newer catmandu version

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18434

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #14 from Jonathan Druart  
---
2 Tests fail for me:

t/db_dependent/Koha_Elasticsearch_Indexer.t .. 1/6 
#   Failed test 'First mapped author should be 100a'
#   at t/db_dependent/Koha_Elasticsearch_Indexer.t line 120.
#  got: 'ARRAY(0x67369d8)'
# expected: 'Author'

#   Failed test 'Second mapped author should be 110a'
#   at t/db_dependent/Koha_Elasticsearch_Indexer.t line 121.
#  got: 'ARRAY(0x66f79c0)'
# expected: 'Corp Author'
# Looks like you failed 2 tests of 2.

#   Failed test '_convert_marc_to_json() tests'
#   at t/db_dependent/Koha_Elasticsearch_Indexer.t line 124.
# Looks like you failed 1 test of 6.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18450] Renew in header bypasses hold block and renewal limits

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #14 from Jonathan Druart  
---
Nope, the last patch does:
IF A AND B:
  Do the stuffs
ELSIF ( NOT A AND B ) OR ( A AND NOT B ):
  Do the same stuffs

Alex, could you submit another patch replacing this one, update the commit
message with a shorter first line (ideally should be < 80chars), remove the
signed-off by line and switch the status to "Needs Signoff" please?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18627] Items created via MarcItemFieldsToOrder are not linked to orders

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18627

Kyle M Hall  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18627] Items created via MarcItemFieldsToOrder are not linked to orders

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18627

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #63534|0   |1
is obsolete||

--- Comment #2 from Kyle M Hall  ---
Created attachment 63542
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63542=edit
Bug 18627 - Items created via MarcItemFieldsToOrder are not linked to orders

If using MarcItemFieldsToOrder with AcqCreateItem = Create,
the order and the items will be created, but they will not be linked via
aqorders_items!

Test Plan:
1) Enable creation of items when ordering
2) Set up MarcItemFieldsToOrder
3) Upload an order record that uses the fields in step 2
4) Create a basket and add the records from the file
5) Note the order and items are created, but no rows in aqorders_items are
created
6) Apply this patch
7) Repeat steps 3-4
8) Note the rows in aqorders_items are created!

Signed-off-by: Kyle M Hall 
Signed-off-by: Marci Chen 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18632] New: CGI::param called in list context flooding erro logs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18632

Bug ID: 18632
   Summary: CGI::param called in list context flooding erro logs
 Change sponsored?: ---
   Product: Koha
   Version: 16.11
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: About
  Assignee: neng...@gmail.com
  Reporter: eric.vantill...@evaxion.fr
QA Contact: testo...@bugs.koha-community.org

see https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16154

Here are the error logs (I have removed duplicated errors)

authorised_values.pl: CGI::param called in list context from package main line
195, this can lead to vulnerabilities. See the warning in "Fetching the value
or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436.,
referer: http://xxx/cgi-bin/koha/admin/authorised_values.pl
classsources.pl: CGI::param called in list context from package main line 68,
this can lead to vulnerabilities. See the warning in "Fetching the value or
values of a single named parameter" at /usr/share/perl5/CGI.pm line 436.,
referer:
http://xxx/cgi-bin/koha/admin/classsources.pl?op=edit_source_source=ddc
import_export_framework.pl: CGI::param called in list context from package main
line 87, this can lead to vulnerabilities. See the warning in "Fetching the
value or values of a single named parameter" at /usr/share/perl5/CGI.pm line
436., referer: http://xxx/cgi-bin/koha/admin/biblio_framework.pl
install.pl: CGI::param called in list context from package main line 207, this
can lead to vulnerabilities. See the warning in "Fetching the value or values
of a single named parameter" at /usr/share/perl5/CGI.pm line 436., referer:
http://xxx/cgi-bin/koha/installer/install.pl
itemsearch.pl: CGI::param called in list context from package
Template::Document line 118, this can lead to vulnerabilities. See the warning
in "Fetching the value or values of a single named parameter" at
/usr/share/perl5/CGI.pm line 436., referer: http://xxx/cgi-bin/koha/about.pl
itemsearch.pl: CGI::param called in list context from package
Template::Document line 370, this can lead to vulnerabilities. See the warning
in "Fetching the value or values of a single named parameter" at
/usr/share/perl5/CGI.pm line 436., referer: http://xxx/cgi-bin/koha/about.pl
itemsearch.pl: CGI::param called in list context from package
Template::Document line 375, this can lead to vulnerabilities. See the warning
in "Fetching the value or values of a single named parameter" at
/usr/share/perl5/CGI.pm line 436., referer: http://xxx/cgi-bin/koha/about.pl
itemsearch.pl: CGI::param called in list context from package
Template::Document line 41, this can lead to vulnerabilities. See the warning
in "Fetching the value or values of a single named parameter" at
/usr/share/perl5/CGI.pm line 436., referer: http://xxx/cgi-bin/koha/about.pl
itemsearch.pl: CGI::param called in list context from package
Template::Document line 43, this can lead to vulnerabilities. See the warning
in "Fetching the value or values of a single named parameter" at
/usr/share/perl5/CGI.pm line 436., referer: http://xxx/cgi-bin/koha/about.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18596] Quick add form duplicating password confirm

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18596

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #5 from Jonathan Druart  
---
My brain scratched just after the first line:
  var passwd_mandatory = [% IF mandatorypassword %]0[% ELSE %]1[% END %];

I'd suggest to not use a JS var and simply:

  [% UNLESS mandatorypassword %]
  if( input_label == 'password' ) $("#entryform
label[for='password2']").parent().clone().appendTo("#quick_add_list");
  [% END %]

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18578] Use subdirectory in / tmp for session storage during installation

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18578

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #63423|0   |1
is obsolete||

--- Comment #4 from Jonathan Druart  
---
Created attachment 63541
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63541=edit
Bug 18578: Use subdirectory in /tmp for session storage during installation

Apply the change from bug 15553 to InstallAuth.pm too.

Test plan:
[1] Remove all cgisess_* files from your /tmp directory.
[2] Remove directory /tmp/cgisess_koha_[your instance], if there.
[3] Run the webinstaller
/cgi-bin/koha/installer/install.pl?step=1=updatestructure
[4] Check if you have cgisess_ files in /tmp/cgisess_koha_[your instance].

Signed-off-by: Marcel de Rooy 

Signed-off-by: Josef Moravec 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18578] Use subdirectory in / tmp for session storage during installation

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18578

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11122] Fix display of publication year/ copyrightdate and publishercode on various pages in acquisitions

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11122

--- Comment #40 from Jonathan Druart  
---
Created attachment 63540
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63540=edit
Bug 11122: Follow up - Fix some display issues and typos

This patch fixes the display of copyrightdate for MARC21 installations.
As MARC21 already requires you to add punctuation in cataloguing, there
is usually no need for punctutation in the templates.

Also fixes a template variable name typo and the basket summary page.

To test (all 3 patches):
- Add several order lines to an order, one should be uncertain
- Verify that the publisher and publication year are displayed
- Check the uncertain price page
- Verify that the publisher code and publication year are displayed
- Fix uncertain price and close your order
- Basket summary: Verify... (you know what)
- Cancel one of your orders
- Verify... for cancelled orders
- Receive shipment
- Verify... for unreceived orders
- Receive order
- Verify ... for received orders
- Finish receiving
- Verify ... on the invoice summary page

Signed-off-by: Josef Moravec 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11122] Fix display of publication year/ copyrightdate and publishercode on various pages in acquisitions

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11122

--- Comment #39 from Jonathan Druart  
---
Created attachment 63539
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63539=edit
Bug 11122: Address MARC21 vs. UNIMARC issue

In comment #6 and comment #17, Katrin pointed out the discrepancy
between UNIMARC (using publisheryear) vs. Other MARC installations
(using copyrightdate). This was dealt with in invoice.tt already.
This patch does similar logic for the other 3 template files.

Signed-off-by: Katrin Fischer 

Signed-off-by: Josef Moravec 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11122] Fix display of publication year/ copyrightdate and publishercode on various pages in acquisitions

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11122

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #63405|0   |1
is obsolete||
  Attachment #63406|0   |1
is obsolete||
  Attachment #63407|0   |1
is obsolete||

--- Comment #38 from Jonathan Druart  
---
Created attachment 63538
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63538=edit
Bug 11122 - publisher code and publication year not fetched in acq orders

In acquisition, several templates try to display publisher code and publication
year : invoice.tt, parcel.tt, transferorder.tt.
Thoses pages use C4::Acquisition methods GetPendingOrders or GetInvoiceDetails.
The bug is that in the SQL query of those methods, biblioitems.publishercode
and biblioitems.publicationyear.
In uncertainprice.pl those datas are fetch using GetBiblioData.
It whould be better to fetch them in GetPendingOrders and GetInvoiceDetails.

This patch changes SQL queries to fetch wanted datas :
aqorders.*,biblio.title,biblio.author,biblioitems.isbn,biblioitems.publishercode,biblioitems.publicationyear.
GetInvoiceDetails also needs : biblio.seriestitle,biblioitems.volume.
This patch also unifies the way biblio datas are displayed :
  [title] by [author]
 [isbn]
  Publisher: [publishercode], [publicationyear]

Test plan :
- Choose a biblio record containing a data in :
biblio.title,
biblio.author,
biblioitems.isbn,
biblioitems.publishercode,
biblioitems.publicationyear,
biblio.seriestitle,
biblioitems.volume.
- Create an order using this biblio.
- Look at this order in pages : parcel.pl, transferorder.pl, uncertainprice.pl
=> You see publisher code and publication year
- Look at this order in page : invoice.pl
=> You see publisher code, publication year, series title and volume

Signed-off-by: Katrin Fischer 

Signed-off-by: Josef Moravec 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11122] Fix display of publication year/ copyrightdate and publishercode on various pages in acquisitions

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11122

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18631] Cleanup_database.pl should take an option for modules in action_logs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18631

Nick Clemens  changed:

   What|Removed |Added

 CC||bar...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14625] LDAP: mapped ExtendedPatronAttributes cause error when updated on authentication

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14625

Jonathan Druart  changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |oliver.b...@aei.mpg.de
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18631] New: Cleanup_database.pl should take an option for modules in action_logs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18631

Bug ID: 18631
   Summary: Cleanup_database.pl should take an option for modules
in action_logs
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Command-line Utilities
  Assignee: gmcha...@gmail.com
  Reporter: n...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: ro...@catalyst.net.nz

Cataloging log is a big one that often needs to be cleaned, other logs can be
useful to keep longer, we should take the modules as an option and clear only
those specified or exclude specified logs

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14625] LDAP: mapped ExtendedPatronAttributes cause error when updated on authentication

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14625

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #63410|0   |1
is obsolete||

--- Comment #15 from Jonathan Druart  
---
Created attachment 63537
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63537=edit
Bug 14625 - LDAP: skip extended patron attributes in 'borrowers' attribute
update

* Any extended patron attributes will cause the update to fail as those
attributes don't exist in the 'borrowers' table
* The update of the extended patron attributes is already dealt with in
checkpw_ldap()
* Ergo: just skip those attributes here

Signed-off-by: Martin Renvoize 
Signed-off-by: Jonathan Druart 
I did not test this patch but code looks good

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14625] LDAP: mapped ExtendedPatronAttributes cause error when updated on authentication

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14625

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10382] collection not returning to null when removed from course reserves

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382

--- Comment #30 from Jonathan Druart  
---
I do not like the way this bug is fixed (especially the drop of the FK).
I will not oppose to a push as I do not have anything else to suggest.

I let the QA step to someone else.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18630] Translatability (Clubs): 'Cancel' is ambiguous and leads to mistakes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18630

Marc Véron  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |String patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18630] Translatability (Clubs): 'Cancel' is ambiguous and leads to mistakes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18630

--- Comment #1 from Marc Véron  ---
Created attachment 63536
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63536=edit
Bug 18630: Translatability (Clubs): 'Cancel' is ambiguous and leads to mistakes

The button to cancel a club enrollement is labelled with 'Cancel'. That is
ambiguous and translates e.g. in German to 'Abbrechen' which can lead to
mistakes.

To test:
- Apply patch
- Enroll a patron to a club
- Enable public enrollment in OPAC
- Verify that the button to cancel enrollment in both OPAC and staff client
  reads 'Cancel enrollement' (instead of 'Cancel' without patch)
  (The button appears on the patron's detail pages in OPAC and staff client)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18630] Translatability (Clubs): 'Cancel' is ambiguous and leads to mistakes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18630

Marc Véron  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |ve...@veron.ch
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18630] New: Translatability (Clubs): 'Cancel' is ambiguous and leads to mistakes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18630

Bug ID: 18630
   Summary: Translatability (Clubs): 'Cancel' is ambiguous and
leads to mistakes
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: trivial
  Priority: P5 - low
 Component: Patrons
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: ve...@veron.ch
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

The button to cancel a club enrollement is labelled with 'Cancel'. That is
ambiguous and translates e.g. in German to 'Abbrechen' which can lead to
mistakes.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18629] New: Web installer 17.05 not properly translatable

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18629

Bug ID: 18629
   Summary: Web installer 17.05 not properly translatable
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: major
  Priority: P5 - low
 Component: Installation and upgrade (web-based installer)
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: ve...@veron.ch
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

Web installer displays a mix between translated languages and English.
That is ugly, because installing is the first contact with Koha.

Tested with 17.05 de-DE and it-IT (both 100% translated)
(Note: Results below are the similar for both it-IT and de-DE, same parts not
translated)

To test:
Download po files from http://translate.koha-community.org/de/17.05/ or
http://translate.koha-community.org/it/17.05/

Install the languages
cd misc/translator
perl translate -v install it-IT
or
perl translate -v install de-DE

Drop database
Create database

Restart memcached and plack

Go to staff client (calls web installer), enter database user and pw

Select one of the languages de-DE or it-IT, Continue to the next step

Result:

Web installer › Check Perl dependencies

Alle erforderlichen Perl-Module sind installiert.

Alle erforderlichen Abhängigkeiten sind installiert.

Continue to the next step


Continue...

Result:

Web installer › Database settings
Datenbankeinstellungen:

Database type : mysql
Database name : koha_kohadev
Database host : localhost
Database port : 3306 (probably okay if blank)
Database user : koha_kohadev

Continue to the next step
-

Continue...

Result: Similar as above

Continue:

Result:
-
Web installer › Set up database

Jetzt sind wir soweit, dass die Datenbanktabellen angelegt und mit
Beispieldaten gefüllt werden können.
Continue to the next step
-

Continue... (Result similar)
Continue... (Result similar)
Continue...

Result (this time title translated, but not the text):
---
MARC-Format auswählen

MARC stands for Machine Readable Cataloging. A MARC record contains
bibliographic information about an item. MARC21 is used globally, whereas
UNIMARC tends to be used in Europe.

Marc21

Continue to the next step


Continue...
Result:
---
Web installer › Selecting default settings
MARC-Frameworks: MARC21
Mandatory

Select none (but toggles to 'Alle auswählen'
(...) 
Text at the end in English: 'When you've made aour selections
Import

Result:

(...)
Optional Daten hinzugefügt (first word English)
Mandatory Daten hinzugefügt (same)
At the end:

Basic installation complete.

In the next steps you will be guided through some basic requirements like
defining Koha user with all administrative privileges (superlibrarian).
Sie können die Koha Community unterstützen, indem Sie Ihre Nutzungsdaten
teilen.

If you wish to share some of your data, please enable the functionality in the
"Share your usage statistics" section of the Administration module. 

Set up some of Koha's basic requirements


Then:

Web installer › Installation complete
Gratulation, die Installation ist abgeschlossen

If this page does not redirect in 10 seconds, start onboarding process.


Then in forms:
Only field labels are translated, but not h3 tiltes and text

For the first time, button is translated ('Bestätigen')

Then:
Web installer › Create a new circulation rule
Administrator account created!
Form fields translated

Then finally:
---
Web installer › Complete
Ausleihregel erstellt!
Congratulations you have finished and are ready to use Koha
Koha nun benutzen
---

More findings:
- Some of the strings are not picked for translation (are not in the po files)
- Some of the strings are in the po files, but seem not to be applied while
installing

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18628] New: Reference books shows as unavailable

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18628

Bug ID: 18628
   Summary: Reference books shows as unavailable
 Change sponsored?: ---
   Product: Koha
   Version: 16.11
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Staff Client
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: mishrav...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

Created attachment 63535
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63535=edit
Search result

The search result in Staff client treat reference book as item unavailable so
if there is a lost/damaged book than it counts both and shows total number of
unavailable items.

Suppose there is one damage and one reference book than total count of
unavailable books is (2) screen shot available, even if there is single
reference item it shows unavailable.

Koha 16.11.07 on debian jessie 8 installed via package.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18627] Items created via MarcItemFieldsToOrder are not linked to orders

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18627

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18627] Items created via MarcItemFieldsToOrder are not linked to orders

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18627

--- Comment #1 from Kyle M Hall  ---
Created attachment 63534
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63534=edit
Bug 18627 - Items created via MarcItemFieldsToOrder are not linked to orders

If using MarcItemFieldsToOrder with AcqCreateItem = Create,
the order and the items will be created, but they will not be linked via
aqorders_items!

Test Plan:
1) Enable creation of items when ordering
2) Set up MarcItemFieldsToOrder
3) Upload an order record that uses the fields in step 2
4) Create a basket and add the records from the file
5) Note the order and items are created, but no rows in aqorders_items are
created
6) Apply this patch
7) Repeat steps 3-4
8) Note the rows in aqorders_items are created!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18627] Items created via MarcItemFieldsToOrder are not linked to orders

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18627

Kyle M Hall  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18627] Items created via MarcItemFieldsToOrder are not linked to orders

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18627

Kyle M Hall  changed:

   What|Removed |Added

   Severity|critical|blocker

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18627] New: Items created via MarcItemFieldsToOrder are not linked to orders

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18627

Bug ID: 18627
   Summary: Items created via MarcItemFieldsToOrder are not linked
to orders
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: critical
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: k...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

If using MarcItemFieldsToOrder with AcqCreateItem = Create, the order and the
items will be created, but they will not be linked via aqorders_items!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18627] Items created via MarcItemFieldsToOrder are not linked to orders

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18627

Kyle M Hall  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18625] update borrower last seen from SIP

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18625

Jonathan Field  changed:

   What|Removed |Added

 CC||jonathan.field@ptfs-europe.
   ||com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10382] collection not returning to null when removed from course reserves

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382

Alex Arnaud  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18625] update borrower last seen from SIP

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18625

Colin Campbell  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |colin.campbell@ptfs-europe.
   |ity.org |com
 Status|NEW |Needs Signoff

--- Comment #1 from Colin Campbell  ---
Created attachment 63533
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63533=edit
proposed patch

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18538] OPAC database user login internal server error

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18538

--- Comment #6 from Jonathan Druart  
---
(In reply to Jonathan Druart from comment #5)
> I'd prefer to handle the error (more or less gracefully) raising an
> exception from C4::Auth, rather than assuming that it's possible to login
> with this user.

Make me think to "Bug 18403: Add sub output_and_exit_if_error - unknown_patron
 & cannot_see_patron_infos"

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18620] t/db_dependent/Letters.t failing on master

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18620

--- Comment #6 from Jonathan Druart  
---
Waiting for bug 18478, to QA them altogether.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18478] Some notices sent via SMS gateway fail

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18478

Jonathan Druart  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18478] Some notices sent via SMS gateway fail

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18478

--- Comment #10 from Jonathan Druart  
---
The call to _update_message_to_address just before _send_message_by_email
should not be needed, it is already called from _send_message_by_email.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18478] Some notices sent via SMS gateway fail

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18478

--- Comment #9 from Jonathan Druart  
---
This:

  $message->{to_address} = $message->{to_address} ? $message->{to_address} :
$member->{'smsalertnumber'};

is actually:

  $message->{to_address} ||= $member->{smsalertnumber};

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17233] Add 008 value builder plugin for MARC21 classifications

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17233

--- Comment #14 from Héctor Eduardo Castro Avalos  
---
(In reply to Chris Cormack from comment #13)

Hi Chris

> This is both unhelpful, insulting and blatantly wrong.
> Many of the developers are trained librarians, and I doubt a single feature
> in Koha has been added without being specced and asked for by librarians.
> 
> Trying to divide the community will not result in a better system
> 
> Please stop

I wasn't try to insult anybody with a simple commentary. Ok, I accept that
commentary is in the wrong way, but at the same time, I think it's not the way
to react. I accept that you call my attention, but not in that way.
And of course I do not want to divide the community, I think that this project
is a good effort of many people around the world like you, who has spent a lot
of time developing Koha.

Please accept my apologize.

Regards

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/