[Koha-bugs] [Bug 17765] Hide 'Holds' link in staff result list when user has no permission to place holds

2017-06-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17765

Katrin Fischer  changed:

   What|Removed |Added

   Keywords||Academy

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18313] Remove Delicious icon from OPAC social network links

2017-06-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18313

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
   Keywords||Academy

--- Comment #1 from Katrin Fischer  ---
To get started here, turn on the SocialNetworks system preference.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18449] Renewal limit button on renew.pl misleading

2017-06-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18449

Katrin Fischer  changed:

   What|Removed |Added

   Keywords||Academy
 CC||katrin.fisc...@bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17682] Change URL for Google Scholar in OPACSearchForTitleIn

2017-06-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17682

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
   Keywords||Academy

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18661] Make "Replace only included patron attributes" default on patron import

2017-06-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18661

Katrin Fischer  changed:

   What|Removed |Added

   Keywords||Academy

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14786] Use text «MARC file» instead of «ISO2709» everywhere

2017-06-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14786

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
   Keywords||Academy

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client

2017-06-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662

--- Comment #120 from David Cook  ---
Hey everyone, 

Here's the latest release of the OAI-PMH harvester (along with code for
harvesting RDFXML as well as MARCXML via OAI-PMH, as requested and sponsored by
Stockholm University Library).

I think this will be the last major iteration. After this, I'll work on bugs
that people find in testing, and do whatever is necessary to work it through
the QA process, but in terms of design I think this is mostly it. 

__TEST PLAN__
0a) Apply bugs 18585, 18586, 18713
0b) Upgrade your git dev system by using "make" and "make upgrade". I haven't
tried this on a gitified system, but I doubt it will work because of the
changes to koha-conf.xml and the added oai-pmh-harvester.yaml file (as well as
the added triplestore.yaml file from 18585). (Note that I have included Debian
scripts. I haven't tried building a DEB package yet, but you could try building
a package from your Git and use that for testing.)
0c) If you want to test the RDF functionality, you'll need a triplestore
(preferably Apache Jena Fuseki) and to update triplestore.yaml with the details
for the SPARQL endpoint.

1) On the command line, run KOHA_CONF=/path/to/etc/koha-conf.xml perl
misc/harvesterd.pl
OPTIONALLY: Add the --log-level DEBUG option for verbose debugging logging
2) Go to /cgi-bin/koha/tools/tools-home.pl
3) Click on "OAI-PMH harvester"
(/cgi-bin/koha/tools/oai-pmh-harvester/dashboard.pl)
4) At the toolbar choose "New request"
5) Give the request a "Name", add "URL" for an OAI-PMH repository, and fill in
the OAI-PMH parameters as desired/required. Everything else is probably fine as
a default, although if you want your request to run periodically, change
"Interval (seconds)" to something you think it reasonable. 
6) Click "Test parameters" to make sure your inputs are all valid. 
7) Click "Save" (note that you can save without validating your inputs for
works in progress)
8) Click "Actions" and choose "Send"
9) If the send is successful, go to the "Submitted requests" tab
10) Click "Actions" and choose "Start"
11) Go to the "Import history" tab
12) Click "Refresh import history" to update the table and see your results. If
nothing is coming up, you may have to go back to the "Submitted requests" tab
and double-check the status of your result and if there were any errors.
NOTE: If your request isn't periodic, it will disappear from the "Submitted
requests" table once it's finished, so you may have to check your command line
screen. If you enabled the DEBUG logging, you should be able to see any
problems that arose during the harvest. If you're not getting output on your
terminal screen, it may be going to your log file. Double-check
oai-pmh-harvester.yaml to see if you have a log file defined.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18586] Create module to mint RDF subject URIs

2017-06-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18586

David Cook  changed:

   What|Removed |Added

 Blocks||10662


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662
[Bug 10662] Build OAI-PMH Harvesting Client
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18713] Add support for named graphs and rfds:seeAlso to Koha::RDF

2017-06-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18713

David Cook  changed:

   What|Removed |Added

 Blocks||10662


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662
[Bug 10662] Build OAI-PMH Harvesting Client
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18585] Connect to RDF triplestore

2017-06-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18585

David Cook  changed:

   What|Removed |Added

 Blocks||10662


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662
[Bug 10662] Build OAI-PMH Harvesting Client
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client

2017-06-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662

David Cook  changed:

   What|Removed |Added

 Depends on||18585, 18586, 18713


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18585
[Bug 18585] Connect to RDF triplestore
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18586
[Bug 18586] Create module to mint RDF subject URIs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18713
[Bug 18713] Add support for named graphs and rfds:seeAlso to Koha::RDF
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client

2017-06-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662

--- Comment #119 from David Cook  ---
Created attachment 64446
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64446=edit
Bug 10662 - Modify OAI-PMH harvester to import RDFXML

Typically, the OAI-PMH harvester only imports MARCXML, but this
patch allows you to also import RDFXML.

This functionality was requested by Stockholm University Library,
and importing RDFXML requires a parallel import of MARCXML if you
want to be able to use the RDFXML. That is to say, you can download
and import RDFXML using this patch, but it will probably only be
useful if you're also importing MARCXML which can be linked to the RDFXML
using the OAI-PMH repository and identifier as a link. This might change
in the future if Koha moves away from MARCXML as the central required
metadata format.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client

2017-06-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662

--- Comment #118 from David Cook  ---
Created attachment 64445
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64445=edit
Bug 10662 - Remove workaround for pre-17710 behaviour

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client

2017-06-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662

--- Comment #117 from David Cook  ---
Created attachment 6
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6=edit
Bug 10662 - Build OAI-PMH Harvesting Client

This patch adds an OAI-PMH harvesting client to Koha.

The client runs as a daemon in the background. Users interact with the client
via the Koha web user interface, which communicates with the daemon via a unix
socket
using a simple JSON-based protocol.

The harvester ingests MARCXML. You can harvest other metadata formats, but you
must use a XSLT to transform them into MARCXML, if you want them to be imported
into Koha.

You can supply your own download and import modules via the
oai-pmh-harvester.yaml
configuration file, but the default modules supplied in this patch should
be good enough for your purposes. If they're not, raise a Bugzilla issue.

There is a cleanup_database.pl addition, because high volume harvesting
will cause the oai_harvester_import_queue table to fill quickly. This table
is not required for adding/updating records. It's mostly just for general
monitoring and audit purposes.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client

2017-06-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662

David Cook  changed:

   What|Removed |Added

 Status|In Discussion   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 2093] Add OPAC dashboard for logged-in users

2017-06-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2093

Lee Jamison  changed:

   What|Removed |Added

 CC||ldjami...@marywood.edu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18428] move of holds to old_reserves is not handled correctly.

2017-06-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18428

--- Comment #3 from Barton Chittenden  ---
(In reply to Jonathan Druart from comment #2)
> To me the only clean and safe way to do that is to merge the tables. I plan
> to work on that.

I don't disagree that merging the tables is probably the right thing to do, but
I think that we *can* safely fix the problem by adjusting the auto_increment at
startup, as mentioned in IRC:

21:22   barton  rangi: I think the right place to fix this is in the mysql init
file.
21:22   ... we fix the problem on server startup, then we don't have to
worry about it.
21:24   rangi   thats not so hard for debian
21:24   there is a /etc/mysql/conf.d/
21:24   barton  by 'fix the problem' I mean set the auto_increment for issues
and reserves.
21:25   rangi   and my.cnf does includedir /etc/mysql/conf.d/
21:25   so you can put a koha.cnf in there
21:25   and it will be used
21:25   and not overwritten by mysql upgrades
21:25   barton  excellent. We should probably do the same thing for the
deleted* tables.

... all told, I think that the tables that need to be merged or twiddled at
startup is issues/old_issues, reserves/old_reserves, biblios/oldbiblios,
biblioitems/oldbiblioitems, items/olditems, borrowers/deletedborrowers --
that's a lot fix at once. If we figure out how to fix one table in koha.cnf, we
can do all six, then work on the plumbing.

Just my two cents.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12365] Notes for rules

2017-06-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12365

--- Comment #10 from Lee Jamison  ---
(In reply to Jonathan Druart from comment #9)
> Academy keyword, please do not sign it off. Let it to KohaCon17 hackfesters.

Thanks for the information...wasn't aware of the significance of the academy
keyword!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12365] Notes for rules

2017-06-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12365

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Needs Signoff

--- Comment #9 from Jonathan Druart  
---
Academy keyword, please do not sign it off. Let it to KohaCon17 hackfesters.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12365] Notes for rules

2017-06-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12365

M. Tompsett  changed:

   What|Removed |Added

  Attachment #64441|0   |1
is obsolete||

--- Comment #8 from M. Tompsett  ---
Created attachment 64443
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64443=edit
Bug 12365 - Notes for rules

Lee Jamison  rescued this patch.
It is a clean re-build of attachments 61865 and 63902
to fix the merge conflict introduced during application of both
attachments.

To test:
Follow test plan in Comment 2

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12365] Notes for rules

2017-06-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12365

M. Tompsett  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18820] The different parts in the main don' t automatically adjust with the available space.

2017-06-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18820

Philippe Audet-Fortin  changed:

   What|Removed |Added

 CC||philippe.audet-fortin@inlib
   ||ro.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18101] "Internal server error" when accessing audio alerts

2017-06-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18101

Jonathan Druart  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

--- Comment #6 from Jonathan Druart  
---
Closing, please reopen if it persists.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18774] Internal Server Error in Price.pm with big numbers

2017-06-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18774

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
 Resolution|--- |DUPLICATE
 Status|NEW |RESOLVED

--- Comment #4 from Jonathan Druart  
---


*** This bug has been marked as a duplicate of bug 15770 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15770] Number::Format issues with large numbers

2017-06-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15770

--- Comment #2 from Jonathan Druart  
---
*** Bug 18774 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18819] Correct "whereas UNIMARC tends to be used in Europe." in web installer files

2017-06-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18819

Katrin Fischer  changed:

   What|Removed |Added

   Keywords||Academy

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18629] Translatability: Fix problems with web installer 17.05

2017-06-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18629

--- Comment #25 from Marc Véron  ---
(In reply to Jonathan Druart from comment #24)
> Before and after:
>   msgid "Database name : "
> 
> => OK
> 
> Before:
>   msgid "%s (probably OK if blank)"
> 
> After:
>   msgid "(probably okay if blank)"
> 
> => This may remove flexibility in some languages?

I do not think that this is a big issue.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18428] move of holds to old_reserves is not handled correctly.

2017-06-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18428

Barton Chittenden  changed:

   What|Removed |Added

Summary|Duplicate key error in  |move of holds to
   |old_reserves table. |old_reserves is not handled
   ||correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18639] Separate replacement cost and retail price fields in acquisitions

2017-06-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639

Jonathan Druart  changed:

   What|Removed |Added

   Severity|enhancement |major
   Assignee|jonathan.dru...@bugs.koha-c |koha-b...@lists.koha-commun
   |ommunity.org|ity.org

--- Comment #2 from Jonathan Druart  
---
I am not sure I will have time to work on this one.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18428] Duplicate key error in old_reserves table.

2017-06-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18428

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #2 from Jonathan Druart  
---
To me the only clean and safe way to do that is to merge the tables. I plan to
work on that.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18242] Move of checkouts to old_issues is not handled correctly

2017-06-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18242

Barton Chittenden  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=18428

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18428] Duplicate key error in old_reserves table.

2017-06-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18428

Barton Chittenden  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=18242

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14899] Mapping configuration page for Elastic search

2017-06-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14899

Nick Clemens  changed:

   What|Removed |Added

 Blocks||18827


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18827
[Bug 18827] Elasticsearch mappings - not displayed or retrieved in saved order
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18428] Duplicate key error in old_reserves table.

2017-06-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18428

Barton Chittenden  changed:

   What|Removed |Added

   Severity|normal  |major

--- Comment #1 from Barton Chittenden  ---
The underlying problem is that innodb doesn't keep auto_increment across SQL
server restarts -- it simply sets auto_increment to max(reserves.reserve_id)+1
on startup.

Because the action of moving rows from reserves to old_reserves makes
old_reserves.reserve_id higher than reserves.reserve_id, rebooting the server
when it's in that state will create duplicate reserve_ids between reserves and
old_reserves.

since we treat deleted* tables the same way, we should also fix

select distinct table_name from information_schema.columns where table_name
like 'deleted%';  
++
| table_name |
++
| deletedbiblio  |
| deletedbiblioitems |
| deletedborrowers   |
| deleteditems   |
++

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11944] Cleanup Koha UTF-8

2017-06-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944

Nick Clemens  changed:

   What|Removed |Added

 Blocks|18827   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18827
[Bug 18827] Elasticsearch mappings - not displayed or retrieved in saved order
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18827] Elasticsearch mappings - not displayed or retrieved in saved order

2017-06-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18827

Nick Clemens  changed:

   What|Removed |Added

 Depends on|11944   |14899


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944
[Bug 11944] Cleanup Koha UTF-8
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14899
[Bug 14899] Mapping configuration page for Elastic search
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18684] Translatability: Get rid of %%] in translation for currency.tt

2017-06-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18684

--- Comment #7 from Marc Véron  ---
Created attachment 64442
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64442=edit
Bug 18684: (followup) Move 2 closing h3 tags to end of previous lines

See comment #4

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18817] Screenshots not appearing in the manual linked to the Help tab

2017-06-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18817

--- Comment #8 from Chris Cormack  ---
Hi All

The main difference is 17.05 and up do not use docbook XML anymore, but use
sphinx

This is a markdown style syntax that is way way easier to edit (we already have
more different people submitting doc than we did in the last 5 years, docbook
xml was just too hard)

The readme is here
http://git.koha-community.org/gitweb/?p=kohadocs.git;a=blob;f=README.md;h=5d18feacd50c2414b59447cc1aa45c1ad9c0767d;hb=e442b169a940fbf09a9a56d4dfbc4633a8eed15f

The upshot is, 17.05 generated from docbook is old and out of date and missing
a chunk. 

So if we can leave the old manuals on manual.koha-community.org and new ones on
koha-community.org  that should be the simplest

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18826] REST API tests do not clean up

2017-06-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18826

Lee Jamison  changed:

   What|Removed |Added

 CC||ldjami...@marywood.edu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18651] Move of checkouts is still not correctly handled

2017-06-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651

Jonathan Druart  changed:

   What|Removed |Added

   Severity|critical|blocker
 CC||alex.sassmannshausen@ptfs-e
   ||urope.com,
   ||julian.maur...@biblibre.com
   ||,
   ||martin.renvoize@ptfs-europe
   ||.com

--- Comment #37 from Jonathan Druart  
---
This is now blocker, new stable releases have to include it!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18827] New: Elasticsearch mappings - not displayed or retrieved in saved order

2017-06-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18827

Bug ID: 18827
   Summary: Elasticsearch mappings - not displayed or retrieved in
saved order
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Searching
  Assignee: n...@bywatersolutions.com
  Reporter: n...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

The mappings listed under 'Biblios' and 'Authorities' are draggable - this
allows ordering of fields.

The ordering affects the id field in the search_marc_map table

When retrieving for display or mapping we are not ordering by the this field.


In general I am not sure if we are gaining anything with this ordering:

https://www.elastic.co/guide/en/elasticsearch/guide/current/_sorting.html
" When sorting on fields with more than one value, remember that the values do
not have any intrinsic order; a multivalue field is just a bag of values. Which
one do you choose to sort on?"

I think we can switch to the idea that a single field per index should be
chosen for ordering:
author = 100 (only make this one sortable)
author = 700
author = 245c


or, in the case of authorities, we should expect a single field to populate the
field for sorting (100, 110, 150 ... are alldefined as 'main-heading' - but
each record should only have a single one of these field)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11944] Cleanup Koha UTF-8

2017-06-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944

Nick Clemens  changed:

   What|Removed |Added

 Blocks||18827


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18827
[Bug 18827] Elasticsearch mappings - not displayed or retrieved in saved order
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18827] Elasticsearch mappings - not displayed or retrieved in saved order

2017-06-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18827

Nick Clemens  changed:

   What|Removed |Added

 Depends on||11944


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944
[Bug 11944] Cleanup Koha UTF-8
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18826] New: REST API tests do not clean up

2017-06-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18826

Bug ID: 18826
   Summary: REST API tests do not clean up
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: major
  Priority: P5 - low
 Component: Test Suite
  Assignee: ch...@bigballofwax.co.nz
  Reporter: jonathan.dru...@bugs.koha-community.org
QA Contact: testo...@bugs.koha-community.org

prove -r t/db_dependent/api/v1
will modify DB data, they should not

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18817] Screenshots not appearing in the manual linked to the Help tab

2017-06-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18817

Larry Baerveldt  changed:

   What|Removed |Added

 CC||la...@bywatersolutions.com

--- Comment #7 from Larry Baerveldt  ---
Some comments on this:

The current manual links on the help page, up through 17.05, are pointing to
'manual.koha-community.org'. That site is maintained by ByWater, but the actual
manual pages are generated using this git repository:
git://git.koha-community.org/kohadocs.git

On that repository, the branch for manual16.05.x includes images in directory
en/images. However I just checked and discovered that for the 16.11 and 17.05
branches, the images are now in en/source/images. I've updated the links on the
manual.koha-community.org site, and now images are showing up in the manual
pages.

It sounds like the Community wants to get away from using the manual.k-c site.
We will leave the manual.k-c site up until such time as the links for the help
pages have all been changed over to use the new address. Let me know when that
has been done, and we'll shut down the manual.k-c site. 

- Larry

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12365] Notes for rules

2017-06-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12365

Lee Jamison  changed:

   What|Removed |Added

  Attachment #61865|0   |1
is obsolete||
  Attachment #63902|0   |1
is obsolete||

--- Comment #7 from Lee Jamison  ---
Created attachment 64441
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64441=edit
[MERGE CONFLICT FIX] Bug 12365 - Notes for rules

This patch is a clean re-build of attachments 61865 and 63902
to fix the merge conflict introduced during application of both
attachments.

To test:
Follow test plan in Comment 2

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18684] Translatability: Get rid of %%] in translation for currency.tt

2017-06-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18684

--- Comment #6 from Jonathan Druart  
---
follow-up please, I will squash them.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18825] Elasticsearch - Update default authority mappings

2017-06-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18825

--- Comment #1 from Nick Clemens  ---
Created attachment 64440
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64440=edit
Bug 18825 - Elasticsearch - Update heading main-heading and see fields

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18825] Elasticsearch - Update default authority mappings

2017-06-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18825

Nick Clemens  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18825] New: Elasticsearch - Update default authority mappings

2017-06-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18825

Bug ID: 18825
   Summary: Elasticsearch - Update default authority mappings
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: MARC Authority data support
  Assignee: n...@bywatersolutions.com
  Reporter: n...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

We currently only include a few if they authority types in the initial mappings
- we need to round these out

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18807] www/batch.t is failing

2017-06-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18807

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #14 from Jonathan Druart  
---
Pushed to master for 17.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18806] Cannot revert a batch

2017-06-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18806

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #5 from Jonathan Druart  
---
Pushed to master for 17.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18697] Fix date calculations for day/week frequencies in Serials

2017-06-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18697

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #64025|0   |1
is obsolete||
  Attachment #64026|0   |1
is obsolete||
  Attachment #64027|0   |1
is obsolete||
  Attachment #64028|0   |1
is obsolete||
  Attachment #64029|0   |1
is obsolete||
 CC||k...@bywatersolutions.com
 Status|Signed Off  |Passed QA

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #15 from Kyle M Hall  ---
Created attachment 64317
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64317=edit
Bug 18697: Fix date calculations for weekly frequencies in Serials

Same solution applied as in bug 18356/18607. Consistency++

The code in _get_next_date_week is again very similar to the code in
_get_next_date_month or _get_next_date_year. I will not merge them here,
but we could consider that in the future.

Code in GetFictiveIssueNo has been adjusted similarly to month and year.

Test plan:
[1] Do not apply this patch. Create a subscription for 3/week.
When the first issue date is on a Saturday or Sunday, the
intervals in the prediction pattern are 0,0,7,0,0,7,etc.
Starting on Wed-Fri 1,1,5,etc. Starting on Mon-Tue 2,2,3,etc.
[2] Apply this patch. Check again.
The interval should be always 2,2,3 now and no longer depend on the
day_of_week of first issue date.
[3] Check another weekly frequency with multiple units per issue.
Say 1 issue/3 weeks.

Signed-off-by: Marcel de Rooy 

Signed-off-by: Josef Moravec 

Signed-off-by: Kyle M Hall 

--- Comment #16 from Kyle M Hall  ---
Created attachment 64318
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64318=edit
Bug 18697: Adjusting unit tests for weekly serial frequencies

Corrections and added unit tests following the changes of the first patch.

GetFictiveIssueNumber.t: New subtest for weekly frequencies.

GetNextDate.t: Correcting a few dates one day. If we use 2/week, we will
calculate an interval of 3 days and correct with 4 days at the end of
the cycle. The connection with firstacqui is not relevant anymore.

Test plan:
[1] Run t/db_dependent/Serials/GetFictiveIssueNumber.t
[2] Run t/db_dependent/Serials/GetNextDate.t

Signed-off-by: Marcel de Rooy 

Signed-off-by: Josef Moravec 

Signed-off-by: Kyle M Hall 

--- Comment #17 from Kyle M Hall  ---
Created attachment 64319
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64319=edit
Bug 18697: Fix date calculation for dayly frequencies in Serials

The changes in _get_next_date_day are actually only cosmetic. The sub
now reads exactly the same as its counterparts for other units, but
the results are exactly the same as before.

In GetFictiveIssueNumber we now call _delta_units for each type of unit.
The two Delta_Days calls are moved to _delta_units. Note that this also
is a cosmetic change; results should be exactly the same.

Test plan:
[1] Edit a subscription. Test predication pattern for some daily freq.
[2] Run t/db_dependent/GetNextDate.t

Signed-off-by: Marcel de Rooy 

Signed-off-by: Josef Moravec 

Signed-off-by: Kyle M Hall 

--- Comment #18 from Kyle M Hall  ---
Created attachment 64320
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64320=edit
Bug 18697: Adjusting unit tests for dayly serial frequencies

No changes were needed for GetNextDate.t.
In GetFictiveIssueNumber.t we add a subtest for daily frequencies.

Test plan:
[1] Run t/db_dependent/Serials/GetFictiveIssueNumber.t

Signed-off-by: Marcel de Rooy 

Signed-off-by: Josef Moravec 

Signed-off-by: Kyle M Hall 

--- Comment #19 from Kyle M Hall  ---
Created attachment 64321
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64321=edit
Bug 18697: Final polishing

GetFictiveIssueNumber:
Returns undef instead of 0 for irregular frequencies. 

[Koha-bugs] [Bug 18607] Fix date calculations for monthly frequencies in Serials

2017-06-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18607

Kyle M Hall  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
  Attachment #64023|0   |1
is obsolete||
  Attachment #64024|0   |1
is obsolete||

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #9 from Kyle M Hall  ---
Created attachment 64315
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64315=edit
Bug 18607: Fix date calculations for monthly frequencies in Serials

Similarly to the solution of bug 18356, this patch fixes the date
calculation for monthly frequencies.

The calculation in GetFictiveIssueNumber now makes use of the new
_delta_units sub introduced on bug 18356.

The calculation in _get_next_date_month is also very similar to the one
in _get_next_date_year. I do not merge them here, but this could still
be considered later on. At least consistency is achieved now between
both routines. The connection with firstacquidate has been cut thru
just like for year units.

Test plan:
[1] Without this patch, look at the prediction pattern for a
subscription with first issue on Feb 21 and 5 per month. The first
issues will be 21, 22, 23, 24, 25. Then jumping to 21, 23, 25, etc.
[2] Apply the patch. Look at the same prediction pattern. You will now
see 6 day intervals and a new cycle starting on the 21st.
So Feb 21, 27, Mar 5, 11, 17 and Mar 21, 27, etc.
[3] Edit an subscription. Try a few other monthly frequencies.
[4] The next patch adjusts related unit tests.

Signed-off-by: Marcel de Rooy 

Signed-off-by: Josef Moravec 

Signed-off-by: Kyle M Hall 

--- Comment #10 from Kyle M Hall  ---
Created attachment 64316
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64316=edit
Bug 18607: Adjusting unit tests for monthly serial frequencies

The changes in the first patch require some corrections as well as
additional test cases.

GetNextDate.t: Since the calculation for multiple issues per unit has
slightly changed, a few dates (day 15 or day 16) have been changed in the
unit test; when we use 2/month, the algorithm now always adds 15 days.
Added a few test descriptions in this regard too.

GetFictiveIssueNumber.t: Add the monthly subtest with two test cases. In
the first case we tests multiple units per issue, and in the second case
we test multiple issues per unit (month).

Test plan:
[1] Run t/db_dependent/Serials/GetFictiveIssueNumber.t
[2] Run t/db_dependent/Serials/GetNextDate.t

Signed-off-by: Marcel de Rooy 

Signed-off-by: Josef Moravec 

Signed-off-by: Kyle M Hall 

--- Comment #11 from Jonathan Druart  
---
Pushed to master for 17.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18582] Hide empty rows in detailed suggestion view

2017-06-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18582

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #4 from Jonathan Druart  
---
Pushed to master for 17.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18356] Prediction pattern wrong, skips years, for some year based frequencies

2017-06-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18356

Kyle M Hall  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
  Attachment #64021|0   |1
is obsolete||
  Attachment #64022|0   |1
is obsolete||

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #12 from Kyle M Hall  ---
Created attachment 64310
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64310=edit
Bug 18356: Extend GetNextDate.t, add GetFictiveIssueNumber.t (unit=year)

This patch deals with tests for yearly frequencies.

Adjust/extend GetNextDate.t:
[1] Adjust mixup of units/issues in a description.
[2] Add testing +2 years on 29-2 of leap year for freq 1 issue/2 years.
[3] Add tests for freq 9 issues/year.

Add GetFictiveIssueNumber.t:
[1] Two subtests are provided for irregular frequencies (very trivial) and
for year frequencies (with four specific test cases).

Test plan:
[1] Run t/db_dependent/Serials/GetNextDate.t
[2] Run t/db_dependent/Serials/GetFictiveIssueNumber.t

Note: Without the second patch both tests should fail. This shows the need
of the adjustments in the second patch.

Signed-off-by: Marcel de Rooy 

Signed-off-by: Josef Moravec 

Signed-off-by: Kyle M Hall 

--- Comment #13 from Kyle M Hall  ---
Created attachment 64311
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64311=edit
Bug 18356: Fix date calculations for yearly frequencies in Serials

The problem as described on BZ 18356 is a combination of an error in
GetFictiveIssueNumber and GetNextDate for unit==year.

[1] In GetNextDate the Add_Delta_YM calculation should be applied only to
frequencies based on years per unit.
In the case of multiple units per year we calculate the number of days to
add. And if we have reached the end of a cycle, we correct the
rounding applied in the cycle.
NOTE 1: We obsolete the idea here of rebasing dates on firstacqui. In case
of manual adjustments, we probably do not want it. And otherwise we do not
need it anymore due to the correction at the end of a cycle.
NOTE 2: The calls to Add_Delta_YM are intentionally not corrected for leap
years. Say you start at 2016-02-29. If you use 1/yr or 1/2yr, you will
switch to the Feb 28th in the following years. In 2020 there will be no
switch to Feb 29 again; if someone should need it, please use a manual
adjustment. This is probably highly exceptional.

[2] In GetFictiveIssueNumber the year should be decreased by one if you
have more units per year and you did not yet reach firstacqui day and
month. This affects calculations in GetNextDate with irregularities.
NOTE 1: I added a wrapper around Date::Calc::N_Delta_YMD in order to improve
its results; this will especially be needed when we use it later for
month units.
NOTE 2: In case of manual adjustments this calculation does not really make
sense. Another report should deal with improving irregularities.

Test plan:
[1] Verify that both GetNextDate.t as well as GetFictiveIssueNumber.t pass.
[2] Look at the prediction pattern for a few frequencies.
For example: 1 iss/y, 1 iss/2y, 5 iss/y.

Signed-off-by: Marcel de Rooy 

Signed-off-by: Josef Moravec 

Signed-off-by: Kyle M Hall 

--- Comment #14 from Jonathan Druart  
---
Pushed to master for 17.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18684] Translatability: Get rid of %%] in translation for currency.tt

2017-06-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18684

--- Comment #5 from Marc Véron  ---
(In reply to Jonathan Druart from comment #4)
> Why the closing h3 tags is on a new line?

Seems to be a mistake?
How do you want it fixed? Amend patch or a follow-up.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18824] Remove stray i from matching-rules.tt

2017-06-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18824

Marc Véron  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18824] Remove stray i from matching-rules.tt

2017-06-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18824

Marc Véron  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |ve...@veron.ch
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18824] Remove stray i from matching-rules.tt

2017-06-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18824

--- Comment #1 from Marc Véron  ---
Created attachment 64439
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64439=edit
Bug 18824: Remove stray i from matching-rules.tt

The file
koha-tmpl/intranet-tmpl/prog/en/modules/admin/matching-rules.tt
contains a stray i that should not be there.
This patch removes it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18824] New: Remove stray i from matching-rules.tt

2017-06-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18824

Bug ID: 18824
   Summary: Remove stray i from matching-rules.tt
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: trivial
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: ve...@veron.ch
QA Contact: testo...@bugs.koha-community.org

The file koha-tmpl/intranet-tmpl/prog/en/modules/admin/matching-rules.tt
contains a stray i that should not be there (first char of line 516)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18434] Elasticsearch indexing broken with newer catmandu version

2017-06-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18434

Nick Clemens  changed:

   What|Removed |Added

 CC||mi...@abunchofthings.net

--- Comment #19 from Nick Clemens  ---
I am looking here, it seems we have some version issues - I sent an email to
Mirko and going to talk about versions/packagin to see what we can do

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18684] Translatability: Get rid of %%] in translation for currency.tt

2017-06-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18684

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #4 from Jonathan Druart  
---
Why the closing h3 tags is on a new line?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18817] Screenshots not appearing in the manual linked to the Help tab

2017-06-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18817

--- Comment #6 from Chris Cormack  ---
It doesn't exist yet, but if it did it would be /es/ instead of /en/

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18817] Screenshots not appearing in the manual linked to the Help tab

2017-06-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18817

--- Comment #5 from Joy Nelson  ---
The link was found 212 times in the system. I suppose we could updated each one
individually.  But is this the most efficient way?

Additionally, I cannot find how the translations are done for the new 17.05
manual.  for example, what is the url for the spanish translation?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool

2017-06-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

Jonathan Druart  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #127 from Jonathan Druart  
---
I tried to revive these patches, I had to squash all patches to rebase them
(authorship lost, sorry!).

I have pushed a branch with all previous patches applied on
https://github.com/joubu/Koha/tree/old/20160701_bug_12598 (so not up-to-date).

I switched the status to Needs Signoff to get feedback and know/estimate what
need to be done to get something ready for push.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool

2017-06-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

--- Comment #126 from Jonathan Druart  
---
Created attachment 64438
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64438=edit
Bug 12598: Update code to use new modules

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool

2017-06-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #52323|0   |1
is obsolete||
  Attachment #52324|0   |1
is obsolete||
  Attachment #52325|0   |1
is obsolete||
  Attachment #52326|0   |1
is obsolete||
  Attachment #52327|0   |1
is obsolete||
  Attachment #52328|0   |1
is obsolete||
  Attachment #52329|0   |1
is obsolete||
  Attachment #52330|0   |1
is obsolete||
  Attachment #52331|0   |1
is obsolete||
  Attachment #52332|0   |1
is obsolete||
  Attachment #52333|0   |1
is obsolete||
  Attachment #52540|0   |1
is obsolete||

--- Comment #125 from Jonathan Druart  
---
Created attachment 64437
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64437=edit
Bug 12598: New misc/import_borrowers.pl command line tool

Test Plan:
1) Apply this patch
2) Test importing patrons from command line,
   options are availble with --help.

Signed-off-by: Bernardo Gonzalez Kriegel 

Tested with minimal csv
(cardnumber,surname,firstname,categorycode,branchcode,password,userid)

Overwrite does not change category or branch.
Patrons are loaded, userid & password works

Updated license to GPLv3
No other koha-qa errors.

Signed-off-by: Benjamin Rokseth 

Signed-off-by: Kyle M Hall 

Bug 12598 - Tidy import_borrowers.pl

Signed-off-by: Benjamin Rokseth 

Signed-off-by: Kyle M Hall 

Bug 12598 - Move importing code to a subroutine

Signed-off-by: Benjamin Rokseth 

Signed-off-by: Kyle M Hall 

Bug 12598 - Update command line script to use patron import subroutine

Signed-off-by: Benjamin Rokseth 

Signed-off-by: Kyle M Hall 

Bug 12598 [QA Followup]

* Fix copyright on import_borrowers.pl
* Changes -c --csv to -f --file
* Adds -c --confirm option
* Renames misc/import_borrowers.pl to misc/import_patrons.pl
* Restore userid matchpoint option

Signed-off-by: Kyle M Hall 

Bug 12598 - Fix merge to master. Backport 3 updates from latest
import_borrowers.pl

Signed-off-by: Kyle M Hall 

Bug 12598 - Started regression tests. Fix missing C4::Members::Attributes
package

Signed-off-by: Kyle M Hall 

Bug 12598 - More refactoring and regression tests in Koha::Patrons::Import

Signed-off-by: Kyle M Hall 

Bug 12598 - Creating objects in misc/import_patrons.pl and
tools/import_borrowers.pl

Signed-off-by: Kyle M Hall 

Bug 12598 - Refactoring Koha::Patrons::Import includes bug fixed for critical
date types and header column parsing

Signed-off-by: Kyle M Hall 

Bug 12598 - Rebase + backport of 16426 plus fixing 16426

Signed-off-by: Kyle M Hall 

Bug 12598: catch warnings raised by import_patrons in tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12145] Lock for Move up buttons with Marc tag

2017-06-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12145

Jonathan Druart  changed:

   What|Removed |Added

   Keywords||Academy
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12365] Notes for rules

2017-06-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12365

Jonathan Druart  changed:

   What|Removed |Added

   Keywords||Academy
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15235] Add column filters to checkouts table

2017-06-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15235

Jonathan Druart  changed:

   What|Removed |Added

   Keywords||Academy

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15644] City dropdown default selection when modifying a patron matches only on city

2017-06-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15644

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
   Keywords||Academy

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16726] Text in Preferences search box does not clear

2017-06-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16726

Jonathan Druart  changed:

   What|Removed |Added

   Keywords||Academy

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16726] Text in Preferences search box does not clear

2017-06-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16726

Jonathan Druart  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16796] Patron categories: Crash if enrolment date is not valid

2017-06-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16796

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|NEW

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16796] Patron categories: Crash if enrolment date is not valid

2017-06-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16796

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
 Status|Needs Signoff   |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18667] Show a diff view of SQL reports when converting

2017-06-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18667

Jonathan Druart  changed:

   What|Removed |Added

   Keywords||Academy

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17898] Add a way to automatically convert SQL reports

2017-06-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17898

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17898] Add a way to automatically convert SQL reports

2017-06-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17898

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17898] Add a way to automatically convert SQL reports

2017-06-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17898

Jonathan Druart  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17898] Add a way to automatically convert SQL reports

2017-06-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17898

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17898] Add a way to automatically convert SQL reports

2017-06-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17898

Jonathan Druart  changed:

   What|Removed |Added

 Status|REOPENED|ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18739] Add SVG version of staff-home-icons-sprite image

2017-06-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18739

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
   Keywords||Academy

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18434] Elasticsearch indexing broken with newer catmandu version

2017-06-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18434

--- Comment #18 from Jonathan Druart  
---
{
author   [
[0] [
[0] [
[0] "Author"
]
],
[1] [
[0] [
[0] "Corp Author"
]
]
],
author__facet[
[0] [
[0] [
[0] "Author"
]
],
[1] [
[0] [
[0] "Corp Author"
]
]
],
author__sort [
[0] [
[0] [
[0] "Author"
]
],
[1] [
[0] [
[0] "Corp Author"
]
]
],
author__suggestion   {
input   [
[0] "Author",
[1] "Corp Author"
]
},
es_idundef,
record   [ 
   
   [21/108]
[0] [
[0] "LDR",
[1] undef,
[2] undef,
[3] "_",
[4] ""
],
[1] [
[0] 001,
[1] undef,
[2] undef,
[3] "_",
[4] 1234567
],
[2] [
[0] 020,
[1] " ",
[2] " ",
[3] "a",
[4] 1234567890123
],
[3] [
[0] 100,
[1] " ",
[2] " ",
[3] "a",
[4] "Author"
],
[4] [
[0] 110,
[1] " ",
[2] " ",
[3] "a",
[4] "Corp Author"
],
[5] [
[0] 245,
[1] " ",
[2] " ",
[3] "a",
[4] "Title"
]
]
}

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18817] Screenshots not appearing in the manual linked to the Help tab

2017-06-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18817

Michael Kuhn  changed:

   What|Removed |Added

 CC||m...@adminkuhn.ch

--- Comment #4 from Michael Kuhn  ---
The patch will solve the problem only on one single page (the mainpage). But
since the Koha help is context-sensitive all the hundreds of other pages
linking to the manual are still linking to the old manual with the broken image
links.

This was already the case in Koha 16.11. And I'm afraid it applies to every
single help page in EVERY additional language (not only English) which do all
link to the respective pages of the English manual.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16330] REST API: add routes to add, update and delete patrons

2017-06-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330

Blou  changed:

   What|Removed |Added

 CC||philippe.blo...@inlibro.com

--- Comment #51 from Blou  ---
If i understand correctly, this patch is "In Discussion" since March(2017)
because of "borrowernumber vs patron_id".

Is it still on?  Has it been settled?  I'd love to test (live) this code, but I
don't want to tell our associates to deploy on a naming convention that will
change.  

Ready to sign off...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18817] Screenshots not appearing in the manual linked to the Help tab

2017-06-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18817

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #3 from Katrin Fischer  ---
I talked to Chris this morning and I think he prefers the k-c.org so this patch
should be fine. I will try to test.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17864] Increase test coverage on admin pages

2017-06-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17864

Lee Jamison  changed:

   What|Removed |Added

  Attachment #58686|0   |1
is obsolete||

--- Comment #10 from Lee Jamison  ---
Created attachment 64436
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64436=edit
Bug 17864: Follow up to add missing tests

This adds tests for the missing items.
Remember the kohadevbox has annoying caching issues,
so close tab, vagrant halt, vagrant up just to be
certain you are not failing because of caching.

Signed-off-by: Lee Jamison 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17864] Increase test coverage on admin pages

2017-06-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17864

Lee Jamison  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17864] Increase test coverage on admin pages

2017-06-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17864

Lee Jamison  changed:

   What|Removed |Added

  Attachment #58685|0   |1
is obsolete||

--- Comment #9 from Lee Jamison  ---
Created attachment 64435
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64435=edit
Bug 17864: Test Cases

There was no form of testing for the change. In order to test
the perl-side of the changes, I just went to a variety of
URLs to see if they have the expected three tabs.

TEST PLAN
-
1) Apply this patch
2) At the bash prompt, export KOHA_INTRANET_URL=http://localhost:8080/
   -- Or whatever yours is. With or without the trailing /
3) prove -v t/db_dependent/www/prefs-admin_search.t
   -- before applying the other patch, there should be failures.
4) Apply both patches
5) prove -v t/db_dependent/www/prefs-admin_search.t
   -- there should be no failures now.
6) run koha qa test tools

Signed-off-by: Mark Tompsett 

https://bugs.koha-community.org/show_bug.cgi?id=17864

Signed-off-by: Lee Jamison 
Updated commit subject to reflect correct bug number.
Works as directed according to test plan and passes QA tools.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches

2017-06-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823

Nick Clemens  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches

2017-06-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823

--- Comment #1 from Nick Clemens  ---
Created attachment 64434
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64434=edit
Rancor DGI: add support for editing/searching records from import batches

Add the ability to edit records in import batches

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18822] Advanced editor - Rancor - searching broken

2017-06-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18822

Nick Clemens  changed:

   What|Removed |Added

 Blocks||18823


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823
[Bug 18823] Advanced editor - Rancor - add ability to edit records in import
batches
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches

2017-06-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823

Nick Clemens  changed:

   What|Removed |Added

 Depends on||18822


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18822
[Bug 18822] Advanced editor - Rancor - searching broken
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18823] New: Advanced editor - Rancor - add ability to edit records in import batches

2017-06-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823

Bug ID: 18823
   Summary: Advanced editor - Rancor - add ability to edit records
in import batches
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Cataloging
  Assignee: n...@bywatersolutions.com
  Reporter: n...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

These patches allow the use of import batches as targets in the advanced editor

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18748] Noisy t/db_dependent/AuthorisedValues.t

2017-06-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18748

Lee Jamison  changed:

   What|Removed |Added

  Attachment #64312|0   |1
is obsolete||

--- Comment #7 from Lee Jamison  ---
Created attachment 64433
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64433=edit
Bug 18748: Noisy t/db_dependent/AuthorisedValues.t

This noise is from a failure. This patch expands the delete
to 952$c for the ACQ framework as per comment #5.

TEST PLAN
-

insert into marc_subfield_structure (tagfield,tagsubfield,liblibrarian,
libopac, repeatable, mandatory,
kohafield,tab,authorised_value,authtypecode,value_builder,isurl,hidden,frameworkcode,seealso,link,defaultvalue,maxlength)
values (952,'c','Shelving location','Shelving
location',0,0,'items.location',10,'LOC','','',0,0,'ACQ','','',null,);
-- this makes sure you have a pre-existing 952$c ACQ record.

prove t/db_dependent/AuthorisedValues.t
-- should have ugly message like in comment #0
apply patch
prove t/db_dependent/AuthorisedValues.t
-- should be green
run koha qa test tools

Signed-off-by: Lee Jamison 
Works as described following the test plan.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18748] Noisy t/db_dependent/AuthorisedValues.t

2017-06-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18748

M. Tompsett  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff
  Attachment #64112|0   |1
is obsolete||

Lee Jamison  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #6 from M. Tompsett  ---
Created attachment 64312
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64312=edit
Bug 18748: Noisy t/db_dependent/AuthorisedValues.t

This noise is from a failure. This patch expands the delete
to 952$c for the ACQ framework as per comment #5.

TEST PLAN
-

insert into marc_subfield_structure (tagfield,tagsubfield,liblibrarian,
libopac, repeatable, mandatory,
kohafield,tab,authorised_value,authtypecode,value_builder,isurl,hidden,frameworkcode,seealso,link,defaultvalue,maxlength)
values (952,'c','Shelving location','Shelving
location',0,0,'items.location',10,'LOC','','',0,0,'ACQ','','',null,);
-- this makes sure you have a pre-existing 952$c ACQ record.

prove t/db_dependent/AuthorisedValues.t
-- should have ugly message like in comment #0
apply patch
prove t/db_dependent/AuthorisedValues.t
-- should be green
run koha qa test tools

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18822] Advanced editor - Rancor - searching broken

2017-06-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18822

--- Comment #2 from Nick Clemens  ---
Created attachment 64432
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64432=edit
Bug 18822 - Better error response

Apply this patch first to see a change in the error feedback - instead
of [Object object] you should get a text readable error

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18822] Advanced editor - Rancor - searching broken

2017-06-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18822

Nick Clemens  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18822] Advanced editor - Rancor - searching broken

2017-06-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18822

--- Comment #1 from Nick Clemens  ---
Created attachment 64431
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64431=edit
Bug 18822 - Advanced editor - Rancor - searching broken

This patch attempt to convert records before processing as we sometimes
get XML instead of record objects.

To test:
1 - Perform an advanced search from the advanced editor, make sure to
select 'Local catalog' and a remote source
2 - Error 'Internal search error [Object object]'
3 - Apply patch
4 - Repeat search, success!
5 - Select and deselect various servers, search should still work

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >