[Koha-bugs] [Bug 18841] Punctuations in normal view is different from ISBD view.

2017-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18841

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #1 from Katrin Fischer  ---
Hi, the ISBD view is generated via the ISBD related system preferences, the
normal view is created with XSLT. We'll need more information to what is
different in order to work on this.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18007] Interface updates to notices and notice previews

2017-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18007

Paul Poulain  changed:

   What|Removed |Added

   Keywords||Academy
 CC||paul.poul...@biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18184] Subscriptions summaries don' t show if seeing all subs attached to a biblio

2017-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18184

Paul Poulain  changed:

   What|Removed |Added

 CC||paul.poul...@biblibre.com
   Keywords||Academy

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18355] Permanent location should show with cart location

2017-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355

Paul Poulain  changed:

   What|Removed |Added

   Keywords||Academy
 CC||paul.poul...@biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18422] Add Select2 to authority editor

2017-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18422

Paul Poulain  changed:

   What|Removed |Added

   Keywords||Academy
 CC||paul.poul...@biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18426] Subscriptions batch editing

2017-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18426

Paul Poulain  changed:

   What|Removed |Added

   Keywords||Academy
 CC||paul.poul...@biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18437] Acquisitions fund edit repair

2017-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18437

Paul Poulain  changed:

   What|Removed |Added

   Keywords||Academy
 CC||paul.poul...@biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18490] Transfer message confusing, cancel button missing

2017-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18490

Paul Poulain  changed:

   What|Removed |Added

 CC||paul.poul...@biblibre.com
   Keywords||Academy

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18775] The "Password Reset" notice should use the patron's homebranch 's email as "from" address

2017-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18775

Paul Poulain  changed:

   What|Removed |Added

 CC||paul.poul...@biblibre.com
   Keywords||Academy

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18790] Add ability to void payments

2017-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18790

Paul Poulain  changed:

   What|Removed |Added

 CC||paul.poul...@biblibre.com
   Keywords||Academy

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen

2017-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803

Paul Poulain  changed:

   What|Removed |Added

 CC||paul.poul...@biblibre.com
   Keywords||Academy

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18839] suggestion.pl: 'unknown' is spelled 'unkown'

2017-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18839

Paul Poulain  changed:

   What|Removed |Added

   Keywords||Academy
 CC||paul.poul...@biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18742] Circulation statistics wizard no longer exports the total row

2017-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18742

Paul Poulain  changed:

   What|Removed |Added

 CC||paul.poul...@biblibre.com
   Keywords||Academy

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18613] Deleting a Letter from a library as superlibrarian deletes the " All libraries" rule

2017-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18613

Paul Poulain  changed:

   What|Removed |Added

   Keywords||Academy
 CC||paul.poul...@biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18821] GetPatronLastActivity is a performance killer

2017-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821

Paul Poulain  changed:

   What|Removed |Added

 CC||paul.poul...@biblibre.com
   Keywords||Academy

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18842] When cataloguing 300$a, I get this and that

2017-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18842

Paul Poulain  changed:

   What|Removed |Added

 Resolution|--- |INVALID
 Status|Needs Signoff   |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18842] When cataloguing 300$a, I get this and that

2017-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18842

Paul Poulain  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Assignee|koha-b...@lists.koha-commun |paul.poul...@biblibre.com
   |ity.org |

--- Comment #1 from Paul Poulain  ---
Created attachment 64503
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64503=edit
nota real patch

bla bla

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18844] New: embedding flip books or pdf files hosted elsewhere in 856$u

2017-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18844

Bug ID: 18844
   Summary: embedding flip books or pdf files hosted elsewhere in
856$u
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: new feature
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: eugen...@yahoo.com
QA Contact: testo...@bugs.koha-community.org

Created attachment 64502
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64502=edit
Embed pdf/flipbook file

The KohaCon2017 Main Conference host Ayala Museum through Filipinas Heritage
Library wishes to be able to embed flipbooks in 856$u such that it will show
the books as embedded in the OPAC page. Currently, videos and audios can be
embedded in both the intranet and the OPAC, but not for PDF files. Uploading of
files is already available in Koha ILS, so it will also be best that this
feature be added to Koha ILS. See image for reference.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18843] New: When cataloguing 300$a, I get this and that

2017-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18843

Bug ID: 18843
   Summary: When cataloguing 300$a, I get this and that
 Change sponsored?: ---
   Product: Koha
   Version: 16.05
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Cataloging
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: caballeromari...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

not really a bug

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18842] New: When cataloguing 300$a, I get this and that

2017-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18842

Bug ID: 18842
   Summary: When cataloguing 300$a, I get this and that
 Change sponsored?: ---
   Product: Koha
   Version: 16.05
  Hardware: All
OS: All
Status: NEW
  Severity: blocker
  Priority: P5 - low
 Component: Cataloging
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: paul.poul...@biblibre.com
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

Im explaining at the kohacon17 how to deal with bugs. not really a bug then

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18841] New: Punctuations in normal view is different from ISBD view.

2017-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18841

Bug ID: 18841
   Summary: Punctuations in normal view is different from ISBD
view.
 Change sponsored?: ---
   Product: Koha
   Version: 16.05
  Hardware: All
OS: All
Status: NEW
  Severity: blocker
  Priority: P5 - low
 Component: Cataloging
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: jddomingo...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

punctuation in normal view is different from isbd view

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client

2017-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662

--- Comment #131 from David Cook  ---
Thanks for the feedback, Josef! I'll try to address it as soon as I can. I have
a busy day today, but I'll do my best to get to it.

That reminds me that I should double-check the RDF::Query versions for
compatibility as well. 

According to https://packages.qa.debian.org/libr/librdf-query-perl.html, Debian
Stretch is on 2.918, which is the same version that I've been using on openSUSE
Leap 42.2. But Debian Jessie is on 2.912. I don't know if that will be
significant or not, so I'll have to check that later.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18617] starting plack on reboot can fail on non-standard apache configs

2017-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18617

--- Comment #2 from Liz Rea  ---
Bump, we'll need this if we want to ever split up the apache configuration
files as we should.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18713] Add support for named graphs and rfds:seeAlso to Koha::RDF

2017-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18713

--- Comment #10 from David Cook  ---
Hey Brendan, I just noticed that Debian Stretch is the new Debian stable. It
looks like it has RDF::Trine 1.015, which should pass these tests.

Alternatively, Mirko has uploaded RDF::Trine 1.018 to Koha unstable (and Jonas
Smedegaard has uploaded RDF::Trine 1.018 to Debian unstable):

"I have backported librdf-trine-perl 1.018-1 to the Koha unstable repository.
Please use option 1: install the package from our repository and report
problems if you encounter any."
(https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18840] Unable to delete Duplicate Report Group

2017-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18840

Joseph Alway  changed:

   What|Removed |Added

 Resolution|--- |WORKSFORME
 Status|NEW |RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18840] Unable to delete Duplicate Report Group

2017-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18840

--- Comment #1 from Joseph Alway  ---
Apparently it's an "Authorized Value" and can be removed from the REPORT_GROUP
category.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18840] New: Unable to delete Duplicate Report Group

2017-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18840

Bug ID: 18840
   Summary: Unable to delete Duplicate Report Group
 Change sponsored?: ---
   Product: Koha
   Version: 17.05
  Hardware: All
OS: All
Status: NEW
  Severity: trivial
  Priority: P5 - low
 Component: Reports
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: jbal...@gmail.com
QA Contact: testo...@bugs.koha-community.org

Created attachment 64501
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64501=edit
Page the problem occured and the code that is generating the duplicate.

There is a duplicate Serials tab when using a Saved Report. There doesn't seem
to be a way to delete one of the duplicate tabs.

I viewed the source for the page and found that there's a Report Group "SER"
and a group "Serials".

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18651] Move of checkouts is still not correctly handled

2017-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651

Jonathan Druart  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m, katrin.fisc...@bsz-bw.de

--- Comment #59 from Jonathan Druart  
---
@Rmaints, this should be pushed everywhere bug 18242 is present (read all
stable maintained releases: 16.05, 16.11, 17.05).

Please test it before (at least checkin and make sure the tests pass).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18836] Patron login is erroring out after failing to find table

2017-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18836

--- Comment #5 from Katrin Fischer  ---
I know ;)

I was thinking of bug 18741 - it might be a fix, but I am not sure. Maybe
someone else could run a test?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18836] Patron login is erroring out after failing to find table

2017-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18836

--- Comment #4 from C.J.S. Hayward  ---
Thank you; I tried and ran into an error. Ducked into chat, and they said a
bugfix that might address my current difficulty is slated for announcement in
the next few days.


Thanks,

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18835] SQL syntax error in overdue_notices.pl

2017-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18835

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
 Resolution|--- |FIXED
 Status|Pushed to Stable|RESOLVED

--- Comment #7 from Katrin Fischer  ---
Not relevant for 16.11.x as it does not contain the change from 17952.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18836] Patron login is erroring out after failing to find table

2017-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18836

--- Comment #3 from Katrin Fischer  ---
You could create and try with another instance - this might be the easiest and
you might be able to compare the 2 databases.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18836] Patron login is erroring out after failing to find table

2017-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18836

--- Comment #2 from C.J.S. Hayward  ---
I don't remember seeing errors. Would it make sense to wipe the installation
and re-run the installer, and if so, how can I do that?

Thx,

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18839] suggestion.pl: 'unknown' is spelled 'unkown'

2017-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18839

Chris Kirby  changed:

   What|Removed |Added

Summary|suggestion.pl: 'unknown' in |suggestion.pl: 'unknown' is
   |spelled 'unkown'|spelled 'unkown'

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18839] suggestion.pl: 'unknown' in spelled 'unkown'

2017-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18839

Chris Kirby  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18839] suggestion.pl: 'unknown' in spelled 'unkown'

2017-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18839

Chris Kirby  changed:

   What|Removed |Added

  Attachment #64499|0   |1
is obsolete||

--- Comment #3 from Chris Kirby  ---
Created attachment 64500
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64500=edit
Bug 18839: Suggestion.pl spelling mistake

On the suggestion management page, 'unknown' is spelled 'unkown'

This patch corrects this spelling mistake in

suggestion/suggestion.pl

koha-tmpl/intranet-tmpl/prog/en/include/strings.inc

koha-tmpl/intranet-tmpl/prog/en/include/search_indexes.inc

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18836] Patron login is erroring out after failing to find table

2017-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18836

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #1 from Katrin Fischer  ---
Did you have any errors running the web installer?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14572] insert_single_holiday() forces a value on an AUTO_INCREMENT column, during an INSERT

2017-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14572

Rodrigo Santellan  changed:

   What|Removed |Added

 CC||rsantel...@gmail.com
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18839] suggestion.pl: 'unknown' in spelled 'unkown'

2017-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18839

Chris Kirby  changed:

   What|Removed |Added

  Attachment #64497|0   |1
is obsolete||

--- Comment #2 from Chris Kirby  ---
Created attachment 64499
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64499=edit
Bug 18839: Suggestion.pl spelling mistake On the suggestion management page,
'unknown' is spelled 'unkown' This patch corrects this spelling mistake in
suggestion/suggestion.pl koha-tmpl/intranet-tmpl/prog/en/include/strings.inc
koha-tmpl/intranet-tmpl/pr

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14572] insert_single_holiday() forces a value on an AUTO_INCREMENT column, during an INSERT

2017-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14572

--- Comment #1 from Rodrigo Santellan  ---
Created attachment 64498
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64498=edit
Bug 14572 - insert_single_holiday() forces a value on an AUTO_INCREMENT column,
during an INSERT

Removing all the id from the columns on the inserts and removing the
parameter '' of the values for the id.

Test plan:
1) Go to tools -> calendar
2) Add a Holiday only on this day.
3) Add a Holiday repeated every same day of the week.
4) Add a Holiday repeated yearly on the same date.
5) Add a Holidays on a range.
6) Add a Holidays repeated yearly on a range.
7) You should have the five calendars displayed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18839] suggestion.pl: 'unknown' in spelled 'unkown'

2017-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18839

--- Comment #1 from Chris Kirby  ---
Created attachment 64497
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64497=edit
Bug 18839: Suggestion.pl spelling mistake On the suggestion management page,
'unknown' is spelled 'unkown' This patch corrects this spelling mistake in
suggestion/suggestion.pl koha-tmpl/intranet-tmpl/prog/en/include/strings.inc
koha-tmpl/intranet-tmpl/pr

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18839] suggestion.pl: 'unknown' in spelled 'unkown'

2017-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18839

Chris Kirby  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |chris.kirby@ilsleypubliclib
   |ity.org |rary.org

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18839] New: suggestion.pl: 'unknown' in spelled 'unkown'

2017-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18839

Bug ID: 18839
   Summary: suggestion.pl: 'unknown' in spelled 'unkown'
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: chris.ki...@ilsleypubliclibrary.org
QA Contact: testo...@bugs.koha-community.org

Created attachment 64496
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64496=edit
screenshot of the Suggestion Management

On the Suggestion Management page, 'unknown' is spelled 'unkown'.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18792] Batch Patron Modification does not modify borrower home branch

2017-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18792

Marjorie Barry-Vila  changed:

   What|Removed |Added

 CC||marjorie.barry-v...@ccsr.qc
   ||.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18651] Move of checkouts is still not correctly handled

2017-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651

--- Comment #58 from Jonathan Druart  
---
(In reply to DEVINIM from comment #55)
> (In reply to Marcel de Rooy from comment #54)
> > (In reply to DEVINIM from comment #53)
> > > Signed-off-by: Marcel de Rooy 
> > 
> > What's up, DEVINIM ?
> 
> Hi Marcel,
> So sorry. How can I delete this attachment, I don't know.
> Can you tell me?

To obsolete/unobsolete patch you need to Edit > Details > obsolete
I did it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18651] Move of checkouts is still not correctly handled

2017-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651

--- Comment #57 from Jonathan Druart  
---
(In reply to Jonathan Druart from comment #56)
> Created attachment 64495 [details] [review]
> Bug 18651: Do no LOCK/UNLOCK the table

Pushed to master!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18651] Move of checkouts is still not correctly handled

2017-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #64490|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18651] Move of checkouts is still not correctly handled

2017-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #64455|1   |0
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18651] Move of checkouts is still not correctly handled

2017-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651

--- Comment #56 from Jonathan Druart  
---
Created attachment 64495
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64495=edit
Bug 18651: Do no LOCK/UNLOCK the table

We cannot LOCK the old_issues table here, other tables are accessed and
DBIx::Class rename it with "me":
DBD::mysql::st execute failed: Table 'me' was not locked with LOCK
TABLES [for Statement "SELECT `me`.`issue_id`, `me`.`borrowernumber`,
`me`.`itemnumber`, `me`.`date_due`, `me`.`branchcode`,
`me`.`returndate`, `me`.`lastreneweddate`, `me`.`renewals`,
`me`.`auto_renew`, `me`.`auto_renew_error`, `me`.`timestamp`,
`me`.`issuedate`, `me`.`onsite_checkout`, `me`.`note`, `me`.`notedate`
FROM `old_issues` `me` WHERE ( `me`.`issue_id` = ? )" with ParamValues:
0='2'] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1832.

Consequence: We could have a checkin refused if there is a race, but
this is the simplest and safest way to fix it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18835] SQL syntax error in overdue_notices.pl

2017-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18835

Fridolin SOMERS  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18835] SQL syntax error in overdue_notices.pl

2017-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18835

Fridolin SOMERS  changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable

--- Comment #6 from Fridolin SOMERS  ---
Oh its realy simple, I do it now.

Pushed to 17.05.x, will be in 17.05.01

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18835] SQL syntax error in overdue_notices.pl

2017-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18835

--- Comment #5 from Fridolin SOMERS  ---
Ok I'll intergrate it tomorrow

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18824] Remove stray i from matching-rules.tt

2017-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18824

Chris Kirby  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||chris.kirby@ilsleypubliclib
   ||rary.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18824] Remove stray i from matching-rules.tt

2017-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18824

Chris Kirby  changed:

   What|Removed |Added

  Attachment #64439|0   |1
is obsolete||

--- Comment #2 from Chris Kirby  ---
Created attachment 64494
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64494=edit
Bug 18824: Remove stray i from matching-rules.tt

The file
koha-tmpl/intranet-tmpl/prog/en/modules/admin/matching-rules.tt
contains a stray i that should not be there.
This patch removes it.

Signed-off-by: Chris Kirby 
Applied patch.
Checked line 516. Stray i had been removed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18214] Cannot edit list permissions of a private list

2017-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18214

--- Comment #9 from Katrin Fischer  ---
I understand, but not sure if the bigger solution can be backported as it also
changes behaviour.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18651] Move of checkouts is still not correctly handled

2017-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651

DEVINIM  changed:

   What|Removed |Added

 CC||kohadevi...@devinim.com.tr

--- Comment #55 from DEVINIM  ---
(In reply to Marcel de Rooy from comment #54)
> (In reply to DEVINIM from comment #53)
> > Created attachment 64490 [details] [review] [review]
> > Bug 18651: [QA Follow-up] Fix the MAX(issue_id) calculation
> > 
> > Found this by inserting the same issue_id in old_issues before checkin:
> > The call to ->search( )->get_column is in scalar context and will
> > return the number of results, i.e. always 1.
> > If you have an issue_id 2 in old_issues, it will crash:
> > DBIx::Class::Storage::DBI::_dbh_execute(): Duplicate entry '2' for key
> > 'PRIMARY'
> > 
> > The fix is fairly simple: Put get_column in list context and pick the first
> > array entry.
> > NOTE: Using DBIx's get_column()->max here might look simpler here.
> > 
> > Signed-off-by: Marcel de Rooy 
> 
> What's up, DEVINIM ?

Hi Marcel,
So sorry. How can I delete this attachment, I don't know.
Can you tell me?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18838] New: Add a list without name in OPAC

2017-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18838

Bug ID: 18838
   Summary: Add a list without name in OPAC
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Lists
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: m.de.r...@rijksmuseum.nl
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

Due to a js error on addshelf it is now possible to add lists without name. The
third patch on bug 18834 resolves it and much more :)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18834] Show "Anyone seeing this list" permission only for shared and public lists

2017-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18834

Marcel de Rooy  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18834] Show "Anyone seeing this list" permission only for shared and public lists

2017-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18834

--- Comment #3 from Marcel de Rooy  ---
Created attachment 64493
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64493=edit
Bug 18834: Remove js function Check from opac-shelves

This function only serves to check if the shelf name is not empty. It
does not even work since it incorrectly refers to f.addshelf (while it
should test #shelfname).
We can solve this and improve consistency by doing the same as in the
staff template with html5 required.

Test plan:
[1] Without this patch it was possible to add a list without a name in
OPAC (with js error: TypeError: f.addshelf is undefined).
[2] With this patch, verify that you cannot do this anymore.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18834] Show "Anyone seeing this list" permission only for shared and public lists

2017-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18834

--- Comment #2 from Marcel de Rooy  ---
Created attachment 64492
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64492=edit
Bug 18834: Add js to dynamically alter the permission options

If we we move from Private to Public or vice versa, this actually has an
impact on the permissions combo. If we go back to a private list without
shares, we could remove Anyone. If we switch to public and the list had
no shares, we could add Anyone.

Handled in a js sub AdjustPerms, triggered by onchange of the category
combo.

Test plan:
[1] Edit a private list without shares in OPAC. Toggle category. Check
if the permissions combo changes accordingly.
[2] Edit a public list in staff. Toggle category and check.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18834] Show "Anyone seeing this list" permission only for shared and public lists

2017-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18834

--- Comment #1 from Marcel de Rooy  ---
Created attachment 64491
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64491=edit
Bug 18834: Show "Anyone seeing this list" permission only for shared and public
lists

This is a follow-up of report 18228 that simplifies the permissions for
lists. It reapplies the idea of bug 10865, but with one difference: It does
not completely hide all permissions if adding public or shared lists is not
allowed; it only hides the Anyone-permission if it is not relevant.

Note: The Anyone permission is not relevant if it is a private list that
has no shares. Note that looking at the prefs OpacAllowPublicListCreation
and/or OpacAllowSharingPrivateLists is not decisive. You should look at
list permissions and shares in the database; turning off the Sharing pref
does not automatically remove all shares in the system. It only blocks
creating new shares.

We only need changes in opac-shelves.tt and virtualshelves/shelves.tt.

Test plan:
[1] Disable OpacAllowPublicListCreation and OpacAllowSharingPrivateLists.
[2] Edit a public list in staff view. Toggle permissions, save and reopen
to check the value you saved. Is Anyone permission included?
[3] Edit a private list (without shares) in staff. Is Anyone excluded?
[4] Edit the same private list in OPAC. Is Anyone excluded too?
[5] Enable OpacAllowPublicListCreation. Create a public list in OPAC.
[6] Edit this list in OPAC. Do you see Anyone? Save with Anyone.
[7] Change category to Private. Save and reopen. Is Owner selected now,
and Anyone excluded?
[8] Enable sharing. Share a list and accept it with another user.
[You can also manually insert a record in virtualshelfshares.]
Edit the list in OPAC as owner. Do you see Anyone?

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18838] Add a list without name in OPAC

2017-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18838

Marcel de Rooy  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=18834

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18834] Show "Anyone seeing this list" permission only for shared and public lists

2017-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18834

Marcel de Rooy  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=18838

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18651] Move of checkouts is still not correctly handled

2017-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651

--- Comment #54 from Marcel de Rooy  ---
(In reply to DEVINIM from comment #53)
> Created attachment 64490 [details] [review]
> Bug 18651: [QA Follow-up] Fix the MAX(issue_id) calculation
> 
> Found this by inserting the same issue_id in old_issues before checkin:
> The call to ->search( )->get_column is in scalar context and will
> return the number of results, i.e. always 1.
> If you have an issue_id 2 in old_issues, it will crash:
> DBIx::Class::Storage::DBI::_dbh_execute(): Duplicate entry '2' for key
> 'PRIMARY'
> 
> The fix is fairly simple: Put get_column in list context and pick the first
> array entry.
> NOTE: Using DBIx's get_column()->max here might look simpler here.
> 
> Signed-off-by: Marcel de Rooy 

What's up, DEVINIM ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18837] Add an unmediated Interlibrary Loans workflow

2017-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18837

Alex Sassmannshausen  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |alex.sassmannshausen@ptfs-e
   |ity.org |urope.com
 Depends on||7317


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317
[Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC

2017-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317

Hugo Agud  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||ha...@orex.es

Alex Sassmannshausen  changed:

   What|Removed |Added

 Blocks||18837

--- Comment #54 from Hugo Agud  ---
HI

I have tried to apply the patch on master, but I get an error

Applying: Bug 7317: DO NOT PUSH: Update OPAC CSS
Using index info to reconstruct a base tree...
M   koha-tmpl/opac-tmpl/bootstrap/css/opac.css
Falling back to patching base and 3-way merge...
Auto-merging koha-tmpl/opac-tmpl/bootstrap/css/opac.css
CONFLICT (content): Merge conflict in
koha-tmpl/opac-tmpl/bootstrap/css/opac.css
Failed to merge in the changes.
Patch failed at 0001 Bug 7317: DO NOT PUSH: Update OPAC CSS
The copy of the patch that failed is found in:
   /home/vagrant/kohaclone/.git/rebase-apply/patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in /tmp/Bug-7317-DO-NOT-PUSH-Update-OPAC-CSS-xvmzXj.patch

--- Comment #55 from Magnus Enger  ---
Iam ready to sign off on this, when Alex has provided the missing tests (and
possibly a rebase).


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18837
[Bug 18837] Add an unmediated Interlibrary Loans workflow
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18837] New: Add an unmediated Interlibrary Loans workflow

2017-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18837

Bug ID: 18837
   Summary: Add an unmediated Interlibrary Loans workflow
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: alex.sassmannshau...@ptfs-europe.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

Some libraries may wish to allow their patrons to place Interlibrary loan
requests without those requests going through a formal moderation process.

The ILLModule cannot guarantee an unmediated workflow for every backend.

I propose the following approach:
- A system preference switching this functionality on & off.
- Use ILL module's generic capabilities functionality to allow execution of
unmediated requests on a per backend basis, but falling back on the normal
process for backends that don't support unmediated.

Alex

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18651] Move of checkouts is still not correctly handled

2017-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651

DEVINIM  changed:

   What|Removed |Added

  Attachment #64455|0   |1
is obsolete||

--- Comment #53 from DEVINIM  ---
Created attachment 64490
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64490=edit
Bug 18651: [QA Follow-up] Fix the MAX(issue_id) calculation

Found this by inserting the same issue_id in old_issues before checkin:
The call to ->search( )->get_column is in scalar context and will
return the number of results, i.e. always 1.
If you have an issue_id 2 in old_issues, it will crash:
DBIx::Class::Storage::DBI::_dbh_execute(): Duplicate entry '2' for key
'PRIMARY'

The fix is fairly simple: Put get_column in list context and pick the first
array entry.
NOTE: Using DBIx's get_column()->max here might look simpler here.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18800] Patron card images: Add some more explanation to upload page and fix small translatability issue

2017-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18800

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #4 from Jonathan Druart  
---
Pushed to master for 17.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18684] Translatability: Get rid of %%] in translation for currency.tt

2017-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18684

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #8 from Jonathan Druart  
---
Pushed to master for 17.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18665] Translatability: Add tt filter to allow html tags inside tt directives

2017-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18665

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #12 from Jonathan Druart  
---
Pushed to master for 17.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18800] Patron card images: Add some more explanation to upload page and fix small translatability issue

2017-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18800

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
  Attachment #64281|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18836] New: Patron login is erroring out after failing to find table

2017-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18836

Bug ID: 18836
   Summary: Patron login is erroring out after failing to find
table
 Change sponsored?: ---
   Product: Koha
   Version: 17.05
  Hardware: Macintosh
OS: Linux
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Patrons
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: c...@cjshayward.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

(Checked the Wiki, tried chat, and searched bugs before reporting.)

I tried to log in as a user and got:

Software error:

Template process failed: undef error -
DBIx::Class::Storage::DBI::_dbh_execute(): Table
'koha_library.club_enrollments' doesn't exist at
/usr/share/koha/lib/Koha/Objects.pm line 260
For help, please send mail to the webmaster ([no address given]), giving this
error message and the time and date of the error.

The VirtualHost below is the only one listening on its special port:

Listen 7026

# OPAC

  = 2.4>
   Define instance "library"
  
   Include /etc/koha/apache-shared.conf
#  Include /etc/koha/apache-shared-disable.conf
#  Include /etc/koha/apache-shared-opac-plack.conf
   Include /etc/koha/apache-shared-opac.conf

   ServerName library.myDNSname.org
   SetEnv KOHA_CONF "/etc/koha/sites/library/koha-conf.xml"
   AssignUserID library-koha library-koha

   ErrorLog/var/log/koha/library/opac-error.log
#  TransferLog /var/log/koha/library/opac-access.log
#  RewriteLog  /var/log/koha/library/opac-rewrite.log


What can I do to either create missing tables like
koha_libary.club_enrollments, or mark them as not needed for the patron screen
to do its work?


Thanks,
C.J.S. Hayward
https://CJSHayward.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18835] SQL syntax error in overdue_notices.pl

2017-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18835

--- Comment #4 from Jonathan Druart  
---
Fridolin, you need it for 17.05.01

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18835] SQL syntax error in overdue_notices.pl

2017-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18835

Jonathan Druart  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #3 from Jonathan Druart  
---
Fridolin, you need it for 17.11.01

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18835] SQL syntax error in overdue_notices.pl

2017-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18835

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18835] SQL syntax error in overdue_notices.pl

2017-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18835

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18835] SQL syntax error in overdue_notices.pl

2017-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18835

Jonathan Druart  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c
   |ity.org |ommunity.org
 Status|Needs Signoff   |Signed Off

--- Comment #2 from Jonathan Druart  
---
Need it for stable release ASAP.

Patch pushed to master.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18651] Move of checkouts is still not correctly handled

2017-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651

--- Comment #52 from Jonathan Druart  
---
Last patch pushed to master.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18651] Move of checkouts is still not correctly handled

2017-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651

--- Comment #51 from Jonathan Druart  
---
Created attachment 64489
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64489=edit
Bug 18651: Fix tests if no circ rule exist

The following test is failing on Jenkins:
 # Subtest: Handle ids duplication
1..4
ok 1 - No account lines should exist on old issue_id
not ok 2 - Two account lines should exist on new issue_id
ok 3 - AddReturn should return the issue with the new issue_id
ok 4 - If an item is checked-in, it should be moved to old_issues even if
the issue_id already existed in the table
not ok 4 - Handle ids duplication

When no circ rule exist

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18651] Move of checkouts is still not correctly handled

2017-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651

--- Comment #50 from Jonathan Druart  
---
The following test is failing on Jenkins:
# Subtest: Handle ids duplication
1..4
ok 1 - No account lines should exist on old issue_id
not ok 2 - Two account lines should exist on new issue_id
ok 3 - AddReturn should return the issue with the new issue_id
ok 4 - If an item is checked-in, it should be moved to old_issues even if
the issue_id already existed in the table
not ok 4 - Handle ids duplication

I guess it is because there is no issuing rules defined.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18835] SQL syntax error in overdue_notices.pl

2017-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18835

Jonathan Druart  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18835] SQL syntax error in overdue_notices.pl

2017-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18835

--- Comment #1 from Jonathan Druart  
---
Created attachment 64488
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64488=edit
Bug 18835: Fix SQL syntax error in overdue_notices.pl

Caused by bug 17952, an extra / is in the middle of the query.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18835] SQL syntax error in overdue_notices.pl

2017-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18835

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||17952


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17952
[Bug 17952] Lost items not skipped by overdue_notices.pl
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17952] Lost items not skipped by overdue_notices.pl

2017-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17952

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||18835

--- Comment #15 from Jonathan Druart  
---
(In reply to Benjamin Rokseth from comment #14)
> seems a slash snuck into the patch?
> 
> @@ -466,7 +467,8 @@ SELECT biblio.*, items.*, issues.*,
> biblioitems.itemtype, branchname
>  AND biblio.biblionumber   = biblioitems.biblionumber
>  AND issues.borrowernumber = ?
>  AND issues.branchcode = ?
> -AND TO_DAYS($date)-TO_DAYS(issues.date_due) >= 0
> +AND items.itemlost = 0
> +/   AND TO_DAYS($date)-TO_DAYS(issues.date_due) >= 0
>  END_SQL
> 
> this breaks the query

This is terrible, I should have caught that.
See bug 18835.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18835
[Bug 18835] SQL syntax error in overdue_notices.pl
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18835] New: SQL syntax error in overdue_notices.pl

2017-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18835

Bug ID: 18835
   Summary: SQL syntax error in overdue_notices.pl
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: critical
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: jonathan.dru...@bugs.koha-community.org
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

Caused by bug 17952, an extra / is in the middle of the query.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18828] 16.05.05.000

2017-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18828

Jonathan Druart  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |INVALID

--- Comment #1 from Jonathan Druart  
---
This is a support question, please ask on the mailing list or IRC channel
instead.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13178] cardnumber field length is too short

2017-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13178

Baptiste  changed:

   What|Removed |Added

  Attachment #64428|0   |1
is obsolete||

--- Comment #7 from Baptiste  ---
Created attachment 64487
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64487=edit
Bug 13178: increase max value of CardnumberLength

testplan
1 - Apply patch
2 - Run updatedatabase.pl
3 - set the value of CardnumberLength to a value between 16 and 20
4 - Check you can enter a propper cardnumber
(modify to 32 instead 20)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15000] Adding patron card images with duplicate descriptions causes data loss

2017-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15000

--- Comment #12 from Marc Véron  ---
(In reply to MHH Chowdhury from comment #11)
> (In reply to Marc Véron from comment #10)
> > Just tested on current master: You get a warning if you want to upload an
> > image with the same image name. It is no longer possible to accidentally
> > overwrite it.
> > 
> > See Bug 17181 (Pushed to master for 17.05, not backported to 16.11.x
> > 
> > *** This bug has been marked as a duplicate of bug 17181 ***
> 
> Thanks for your suggestions. We are using card numbers of patron images and
> it is not a problem for us. We are mainly facing problem when same names
> entered in fields Surname and first name. However, we found that many
> patrons are not giving their date of birth. We checked that by providing
> date of birth at present we can overcome the problem. Is this solution right?

I can not reproduce your issue, and I think it is not related to this Bug
15000.

Can you please file a new bug and describe step by step how to reproduce? 
Maybe adding some screenshots could help.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18834] Show "Anyone seeing this list" permission only for shared and public lists

2017-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18834

Marcel de Rooy  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=10865

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10865] Don't show list permissions when adding public lists/ sharing lists is not allowed

2017-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10865

Marcel de Rooy  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=18834

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18834] Show "Anyone seeing this list" permission only for shared and public lists

2017-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18834

Marcel de Rooy  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |m.de.r...@rijksmuseum.nl
   |ity.org |
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18228] Make list permissions easier to use/understand

2017-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18228

Marcel de Rooy  changed:

   What|Removed |Added

 Blocks||18834


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18834
[Bug 18834] Show "Anyone seeing this list" permission only for shared and
public lists
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18834] Show "Anyone seeing this list" permission only for shared and public lists

2017-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18834

Marcel de Rooy  changed:

   What|Removed |Added

 Depends on||18228


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18228
[Bug 18228] Make list permissions easier to use/understand
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18834] New: Show "Anyone seeing this list" permission only for shared and public lists

2017-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18834

Bug ID: 18834
   Summary: Show "Anyone seeing this list" permission only for
shared and public lists
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Lists
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: m.de.r...@rijksmuseum.nl
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

This is a follow-up of report 18228 that simplifies the permissions for lists.
It reapplies the idea of bug 10865, but with one difference: It does not
completely hide all permissions if adding public or shared lists is not
allowed; it only hides the Anyone-permission if it is not relevant.

Note: The Anyone permission is not relevant if it is a private list that has no
shares. Note that looking at the prefs OpacAllowPublicListCreation and/or
OpacAllowSharingPrivateLists is not decisive. You should look at list
permissions and shares in the database; turning off the Sharing pref does not
automatically remove all shares in the system. It only blocks creating new
shares.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18214] Cannot edit list permissions of a private list

2017-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18214

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #60822|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18228] Make list permissions easier to use/understand

2017-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18228

--- Comment #32 from Marcel de Rooy  ---
*** Bug 18214 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18214] Cannot edit list permissions of a private list

2017-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18214

Marcel de Rooy  changed:

   What|Removed |Added

 Status|BLOCKED |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #8 from Marcel de Rooy  ---
(In reply to Katrin Fischer from comment #7)
> We just ran into this:
> 
> If OpacAllowPublicListCreation is turned off, you can't allow users to add
> to your shared list. This renders the sharing a bit useless :(
> 
> It's especially odd since the system preference OpacAllowSharingPrivateLists
> talks about sharing private lists and I would expect that to enable the
> permission options.

This problem is definitely solved with bug 18228. The trivial change on this
report is incorporated in the larger solution on that report.

*** This bug has been marked as a duplicate of bug 18228 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results

2017-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995

--- Comment #64 from Magnus Enger  ---
If anyone needs an OpenURL linkresolver to test these patches against, I have a
customer that has one that can be used. Please contact me for details.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10112] add test for ./debian/control file

2017-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10112

Mason James  changed:

   What|Removed |Added

 Status|In Discussion   |Needs Signoff
  Attachment #17751|0   |1
is obsolete||
  Attachment #64313|0   |1
is obsolete||

Josef Moravec  changed:

   What|Removed |Added

 CC||josef.mora...@gmail.com

--- Comment #6 from Mason James  ---
Created attachment 64313
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64313=edit
Bug 10112 - add test for ./debian/control* files

to test, apply patch...

1/ install libparse-debcontrol-perl package
apt-get install libparse-debcontrol-perl

2/ run successful tests
$ perl ./t/00-valid-debian-control-file.t  
1..2
ok 1 - parsed ./debian/control file cleanly
ok 2 - parsed ./debian/control.in file cleanly

3/ add some bad syntax to a file
$ sed -i -e '20i ---\' ./debian/control.in

4/ run failed tests
$ perl ./t/00-valid-debian-control-file.t
1..2
ok 1 - parsed ./debian/control file cleanly
not ok 2 - parsed ./debian/control.in file cleanly

--- Comment #7 from Josef Moravec  ---
What is an appropriate statuse of this?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >