[Koha-bugs] [Bug 19066] Add branchcode to accountlines

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066

--- Comment #17 from M. Tompsett  ---
Comment on attachment 73186
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73186
Bug 19066 - Add branchcode to accountlines

Review of attachment 73186:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=19066=73186)
-

::: Koha/Account.pm
@@ +76,4 @@
>  my $account_type = $params->{account_type};
>  my $offset_type  = $params->{offset_type} || $type eq 'writeoff' ? 
> 'Writeoff' : 'Payment';
>  
> +$library_id ||= C4::Context->userenv ? C4::Context->userenv->{'branch'} 
> : undef;

why not below the $userenv below? Less referencing, shorter line, and easier to
read. :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19735] Move Perl deps definitions into a cpanfile

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19735

M. Tompsett  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=20103
 CC||mtomp...@hotmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20103] Remove Readonly::XS

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20103

M. Tompsett  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=19735

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20116] Cache language list

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116

--- Comment #5 from M. Tompsett  ---
Comment on attachment 71098
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71098
Bug 20116: Cache language list

Review of attachment 71098:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=20116=71098)
-

::: C4/Languages.pm
@@ +122,3 @@
>  if ($interface && $interface eq 'opac' ) {
>  my $htdocs = C4::Context->config('opachtdocs');
>  @languages = _get_opac_language_dirs( $htdocs, $theme );

Forgot to delete this line, I think.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20419] Current location not updated correctly on the return of an item on hold

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20419

M. Tompsett  changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com
 Status|Needs Signoff   |Failed QA

--- Comment #2 from M. Tompsett  ---
Please include unit tests when modifying C4 or Koha libraries. This prevents
regression. It would be nice if they fail before the fix, and then pass after
the fix.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18889] Item number in biblio description in fine page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18889

M. Tompsett  changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com

--- Comment #9 from M. Tompsett  ---
Counter Patch Test Plan

1) Add a manual fine with a barcode to a member.
2) Look at the pay invoice tab.
   -- no barcode shown.
3) apply counter patch only patch
   -- and no updatedatabase or rebuilding tables required!
4) restart_all (silly plack caching)
5) refresh the pay invoice tab.
   -- barcode now displayed.
6) run koha qa test tools.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18889] Item number in biblio description in fine page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18889

--- Comment #8 from M. Tompsett  ---
Created attachment 73519
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73519=edit
Bug 18889: Simpler counter-patch

There is no need to add barcode into the accountlines
table, as a relationship via itemnumber can easily look it up.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18889] Item number in biblio description in fine page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18889

--- Comment #7 from M. Tompsett  ---
Comment on attachment 73362
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73362
Bug 18889 - Storing and display of barcode with fines in intranet

Review of attachment 73362:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=18889=73362)
-

::: C4/Accounts.pm
@@ +281,4 @@
>  date  => \'NOW()',
>  amount=> $amount,
>  description   => $desc,
> +barcode   => $barcode,

Why pass barcode when the itemnumber is available?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20505] Selenium tests fail if server not running

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20505

M. Tompsett  changed:

   What|Removed |Added

   Severity|enhancement |minor

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20505] Selenium tests fail if server not running

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20505

M. Tompsett  changed:

   What|Removed |Added

   Assignee|ch...@bigballofwax.co.nz|mtomp...@hotmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20304] Warnings in cataloguing scripts need to be removed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20304

--- Comment #4 from M. Tompsett  ---
Comment on attachment 72272
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72272
Bug 20304: Remove warnings from cataloguing scripts

Review of attachment 72272:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=20304=72272)
-

::: cataloguing/additem.pl
@@ +157,5 @@
>  my $temp2 = $temp->field($CNtag);
>  if ($temp2) {
> +my $value = q{};
> +$value .= $temp2->subfield($CNsubfield)  if 
> $temp2->subfield($CNsubfield);
> +$value .= $temp2->subfield($CNsubfield2) if 
> $temp2->subfield($CNsubfield2);

Where's the space gone?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20428] MARC import fails on Debian Stretch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20428

--- Comment #12 from M. Tompsett  ---
Comment on attachment 73430
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73430
Bug 20428: Make Koha::UploadedFile use the new config entry for tmp files

Review of attachment 73430:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=20428=73430)
-

::: Koha/UploadedFile.pm
@@ +169,5 @@
>  sub temporary_directory {
>  my ( $class ) = @_;
> +return (C4::Context->config('upload_tmp_path'))
> +? C4::Context->config('upload_tmp_path')
> +: File::Spec->tmpdir;

Why a trinary when a || File::Spec->tmpdir would work more nicely?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20158] add a new column in the tables of the list's module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20158

--- Comment #4 from Katrin Fischer  ---
Hi Marjorie, I see what you mean, but I am not sure putting more and more item
information on the display is the best solution, especially as it will clutter
the display for libraries with a lot of items on some of the records.

What is your use case? Why would you want to see the barcodes?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20434] Updating Unimarc existing frameworks with IFLA updates

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20434

Katrin Fischer  changed:

   What|Removed |Added

 CC||bdiazmu...@gmail.com,
   ||katrin.fisc...@bsz-bw.de

--- Comment #3 from Katrin Fischer  ---
Hi Julian, 

this is an interesting approach.

Are you aware that we can currently already translate the SQL files for the
frameworks using pootle?

For an example:
http://translate.koha-community.org/de/marc21/

Bernardo provides the auto-generated SQL files for creating patches for the web
installer.

Could there be a way to bring this together? Use po files to create the .yml
file?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19817] Merge local and online documentations

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

Katrin Fischer  changed:

   What|Removed |Added

 Status|In Discussion   |Patch doesn't apply

--- Comment #9 from Katrin Fischer  ---
Hi Jonathan, can you please rebase? I tried but it got a bit chaotic.

I think you are missing the change to
koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc for the new
permission.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19817] Merge local and online documentations

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

--- Comment #8 from Katrin Fischer  ---
(In reply to Jonathan Druart from comment #7)
> Next step is to re-add the ability to "edit the manual".
> I would suggest to remove the possibility to edit the manual, but allow to
> create new pages (which will not be erased on update).
> 
> I need to know what are the different use cases and needs.

Possible use cases I could see for local help files:
- Being able to explain custom fields like authorised values, patron attributes
etc.
- Being able to explain how to use collections, locations, item types
- Offer local help for cataloguing like explanations for fields and subfields,
internal standards and agreements


> We need also to think about an ergonomic way to manage these additional help
> files.
> For instance: in the top right of the staff pages we will have a "Help"
> group buttons with
>   Link to the official manual | Add a new page
> And when new pages are created:
>   Link to the official manual | Additional pages 1..N | Add a new page
> 
> The additional pages would be linked to a specific page of the staff
> interface (see the mapping in Koha::Manual)
> 
> Does it make sense? Other ideas/opinions?

That makes sense to me. I think having a HTML based editor would be better than
.rst for the local help files and that we should store them in the database.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19014] Patrons should not get a on_reserve notification if the checkout is due in the future

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014

--- Comment #9 from Katrin Fischer  ---
I am not sure all libraries can generally agree to send the notice on date due,
because then the user has no way to return the item on time usually. 

I think there are separate issues thinking about the notice:

- Don't send a notice every day the item is not returned, sent a notice once or
at least not too often
- Be able to inform the patrons on time before the due date so they are able to
return the item on time
- Don't inform the user weeks ahead 

Could it help to set the "No renewal before" to a lower number of days? This
would prevent auto renewals from happening and together with "No automatic
renewal after" could limit the timeframe for sending the notice to a few days.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19910] Download report as 'Comma separated' is misleading

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19910

Victor Grousset/tuxayo  changed:

   What|Removed |Added

  Attachment #73494|0   |1
is obsolete||

--- Comment #21 from Victor Grousset/tuxayo  ---
Created attachment 73518
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73518=edit
Bug 19910 - Use the delimiter syspref to name download link

To test:
1 - Set delimiter syspref to anything but comma
2 - Download report results as comma separated text
3 - They actually follow the syspref
4 - Apply patch
5 - Download link should now match pref selection
6 - Change pref, note link changes
7 - Verify things still work as expected

Signed-off-by: Owen Leonard 
Signed-off-by: Victor Grousset 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20489] Prevent DB user login

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20489

--- Comment #10 from M. Tompsett  ---
Attempted steps to go to urls which should trigger modified code in both logged
in and logged out states. Failures and successes as expected.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20489] Prevent DB user login

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20489

--- Comment #11 from M. Tompsett  ---
Comment on attachment 73400
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73400
Bug 20489: Prevent DB user login

Review of attachment 73400:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=20489=73400)
-

::: acqui/neworderempty.pl
@@ +203,5 @@
>  my $order_patron = Koha::Patrons->find( $order_user_id );
>  push @order_users, $order_patron if $order_patron;
>  }
> +if ( $data->{subscriptionid} ) {
> +$template->param( subscriptionid => $data->{subscriptionid} );

This tweak is the one I don't understand.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20489] Prevent DB user login

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20489

M. Tompsett  changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com

--- Comment #9 from M. Tompsett  ---
Tested:
Staff
OPAC
Self-checkout
And fresh install

Only the fresh install allowed the system log in, as desired.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20505] Selenium tests fail if server not running

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20505

M. Tompsett  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20505] Selenium tests fail if server not running

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20505

--- Comment #1 from M. Tompsett  ---
Created attachment 73517
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73517=edit
Bug 20505: Patch selenium tests to skip gracefully

TEST PLAN
-
1) In a koha shell on kohadevbox, run
prove -v t/db_dependent/selenium
   until it doesn't skip because of missing
   dependencies, but rather because of not running
   a selenium server.
2) apply this patch and restart_all
3) rerun the tests
   -- they will skip gracefully and informatively.
4) run koha qa test tools

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20505] New: Selenium tests fail if server not running

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20505

Bug ID: 20505
   Summary: Selenium tests fail if server not running
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Test Suite
  Assignee: ch...@bigballofwax.co.nz
  Reporter: mtomp...@hotmail.com
QA Contact: testo...@bugs.koha-community.org

If the dependencies for the Selenium tests are installed, but the steps
recommended on https://wiki.koha-community.org/wiki/Using_Selenium_with_Koha
are not taken before running the selenium tests, they die non-gracefully. Patch
them to skip informatively.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20488] Manual renewal due date ignore closed day in calendar

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20488

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #3 from Katrin Fischer  ---
I think a warning with the option to confirm would be good instead of
automatically moving to the next opening day.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2797] Add Summary records to represent summary holdings

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2797

Katrin Fischer  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |DUPLICATE
 CC||katrin.fisc...@bsz-bw.de

--- Comment #2 from Katrin Fischer  ---


*** This bug has been marked as a duplicate of bug 20447 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20447] Add support for MARC holdings records

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447

Katrin Fischer  changed:

   What|Removed |Added

 CC||ch...@bigballofwax.co.nz

--- Comment #2 from Katrin Fischer  ---
*** Bug 2797 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20478] Advance notices: send separate digest messages per branch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20478

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
 Status|NEW |Needs Signoff

--- Comment #4 from Katrin Fischer  ---
Hi Andreas,

thx for your patches! Some things:

1) Once you submitted your patches it's important to switch the status to
'Needs Signoff' in order to get the attention of the testers, otherwise patches
can get easily lost in the saved searches.

2) The QA test tools can help you to find problems with your code easily. For
your patches the report is:

 FAIL   misc/cronjobs/advance_notices.pl
   OK critic
   FAIL   forbidden patterns
forbidden pattern: tab char (line 367)
forbidden pattern: tab char (line 479)
forbidden pattern: tab char (line 366)
forbidden pattern: tab char (line 374)
forbidden pattern: tab char (line 357)
forbidden pattern: tab char (line 373)
forbidden pattern: tab char (line 372)
forbidden pattern: tab char (line 348)
forbidden pattern: tab char (line 356)
forbidden pattern: tab char (line 350)
forbidden pattern: tab char (line 368)
forbidden pattern: tab char (line 358)
forbidden pattern: tab char (line 347)
forbidden pattern: tab char (line 349)
forbidden pattern: tab char (line 355)
forbidden pattern: tab char (line 365)
forbidden pattern: tab char (line 353)
forbidden pattern: tab char (line 369)
forbidden pattern: tab char (line 371)
forbidden pattern: tab char (line 352)
forbidden pattern: tab char (line 354)
forbidden pattern: tab char (line 364)
forbidden pattern: tab char (line 351)
forbidden pattern: tab char (line 370)

 FAIL   t/db_dependent/cronjobs/advance_notices_digest.t
   FAIL   critic
Expression form of "eval" at line 167, column 1. See page 161
of PBP.
Bareword file handle opened at line 158, column 1. See pages
202,204 of PBP.
   FAIL   forbidden patterns
forbidden pattern: tab char (line 67)


3) This can all be fixed, but I see another problem here: libraries are
differently organized and we support a lot of different use cases with Koha.
Some libraries want Koha to only send one email instead of many, others like
yours don't want this behaviour. So we need to find a compromise here and a way
to make this configurable. I think a system preference could work here as I
don't see how to add it to the notices configuration in a good way.

4) We usually don't test .pl files yet... but not opposed to more tsts :) Tests
are failing for me right now:
t/db_dependent/cronjobs/advance_notices_digest.t .. 1/5 
#   Failed test 'There are two messages in the queue'
#   at t/db_dependent/cronjobs/advance_notices_digest.t line 175.
#  got: '0'
# expected: '2'
# Looks like you planned 5 tests but ran 1.
# Looks like you failed 1 test of 1 run.
t/db_dependent/cronjobs/advance_notices_digest.t .. Dubious, test returned 1
(wstat 256, 0x100)
Failed 5/5 subtests 

5) If you want, you could also add an individual Sponsord-By line for each
sponsoring library. It depends on how you want the output in the release notes
later on.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20478] Advance notices: send separate digest messages per branch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20478

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

Katrin Fischer  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com

--- Comment #67 from Katrin Fischer  ---
Hi David, thx for submitting. Peeking at the code I am not quite sure how it
works, but notice it adds a lot of code to C4. Would probably need quite a bit
of work.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14224] patron notes about item shown at check in

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224

Katrin Fischer  changed:

   What|Removed |Added

 Blocks|19772   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19772
[Bug 19772] Wrong success message if CHECKOUT_NOTE is not defined
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19772] Wrong success message if CHECKOUT_NOTE is not defined

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19772

Katrin Fischer  changed:

   What|Removed |Added

 Depends on|14224   |17698

--- Comment #8 from Katrin Fischer  ---
(In reply to Aleisha Amohia from comment #7)
> (In reply to Katrin Fischer from comment #6)
> > Could there be a case where a library wants to activate the feature, but use
> > it without email? We have some cases like the suggestions emails where you
> > just delete the notice in that case. Maybe we could just adapt the text a
> > little and remove the error/warning? Making the options dependent seems more
> > hassle.
> 
> I'm still working on the patch for Bug 17698 where the checkout notes will
> be shown on the staff dashboard, similar to how patron modifications are
> shown. I could add a patch to this bug that depends on 17698 where, if no
> notice is defined, it will not try to send an email and instead just show
> the note on the staff dashboard? hope that makes sense.

Yep, makes sense to me! I have taken a look on bug 17698 and it looks
promising. Linking both reports now.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224
[Bug 14224] patron notes about item shown at check in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17698
[Bug 17698] Make patron notes show up on staff dashboard
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17698] Make patron notes show up on staff dashboard

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17698

Katrin Fischer  changed:

   What|Removed |Added

 Blocks||19772


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19772
[Bug 19772] Wrong success message if CHECKOUT_NOTE is not defined
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17698] Make patron notes show up on staff dashboard

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17698

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #42 from Katrin Fischer  ---
There are some mostly small issues:

1) Small rebase conflict in SQL files for permissions

2) Capitalization
+Home  Circulation  Checkout Notes

2) Translatability
$("#status_" + $issue_id).text("Not seen");
$("#status_" + $issue_id).text("Seen");

3) Move JavaScript to the bottom - we are currently migrating all pages to do
that. See: Bug 17858 - Omnibus: Move staff client JavaScript to the footer 

4) Missing [% VERSION %] variable for JavaScript libraries:
+
See: Bug 12904 - Force browser to load new JavaScript and CSS files after
upgrade

5) Typo:
+   ( 1, 'manage_checkout_nots', 'Mark checkout notes as seen/not seen'),

6) There are also some issues noted by the QA script:

 FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/circ/checkout-notes.tt
   FAIL   forbidden patterns
forbidden pattern: Include [% KOHA_VERSION %] in css paths (bug
12904) - May be false positive (line 7)
forbidden pattern: Include [% KOHA_VERSION %] in js paths (bug
12904) - May be false positive (line 76)
   FAIL   valid_template
parse error -
/home/vagrant/kohaclone/koha-tmpl/intranet-tmpl/prog/en/modules/circ/checkout-notes.tt
line 134: unexpected token ([)
  [% note.patron.title [% END %]

 FAIL   circ/on-site_checkouts.pl
   FAIL   valid
Global symbol "$pending_onsite_notes" requires explicit package
name 
circ/on-site_checkouts.pl had compilation errors.


I've tried to test, but I can't see the link on the circulation home page,
possibly to a problem (typo?) with the permissions. Please fix and test. Thank
you!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20123] Allow multiple instances of Koha to have different timezones on the same server

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20123

--- Comment #30 from Tomás Cohen Arazi  ---
(In reply to Katrin Fischer from comment #29)
> I like the idea of a wiki page with information on how this will work and
> where the limits might be. Do you need to change MySQL configuration as well
> or is the koha-conf variable enough?

Only koha-conf.xml! Isn't that beautiful?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17961] TT syntax for notices - Prove we have an equivalent for our historical custom syntax

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17961

Katrin Fischer  changed:

   What|Removed |Added

 Depends on||19578


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19578
[Bug 19578] TT syntax for notices - There is no way to pre-process DB fields
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19578] TT syntax for notices - There is no way to pre-process DB fields

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19578

Katrin Fischer  changed:

   What|Removed |Added

 Blocks||17961
 CC||katrin.fisc...@bsz-bw.de

--- Comment #11 from Katrin Fischer  ---
I think it seems the safest bet to keep the current behavour and do the
processing for all fields from biblio and biblioitems. 

Could you provide a test plan Jonathan? Not quite sure yet how to work with the
TT syntax in notices.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17961
[Bug 17961] TT syntax for notices - Prove we have an equivalent for our
historical custom syntax
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9634] Allow for parameters re-use on SQL reports

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9634

--- Comment #12 from Katrin Fischer  ---
What I think is:

Don't make the option, because the chance of messing up existing reports is
very very slim. 

They will remain working as they work now if parameters are named differently.
If there exist parameters who already are named the exactly same, the patch
will take effect, but then we can also assume that this is indeed the wanted
behaviour.

Of course we should add a nice note to the release notes to highlight the new
feature!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19204] Fines in days restriction calculation is not taking calender into account

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19204

--- Comment #3 from Katrin Fischer  ---
Actually looking at Bug 13909 - Suspension days calculation doesn't honour
finesCalendar I think finesCalendar would be best. And update the description
to say: Calculate fines and suspensions based on days overdue  ...

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19204] Fines in days restriction calculation is not taking calender into account

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19204

--- Comment #2 from Katrin Fischer  ---
useDaysMode is used for calculating the due dates and usually not involved in
the overdues process. I am not sure it's the right one. 

Maybe finesCalendar would be a better fit as it's already used to count the
days overdue? So it would make sense to use it for determining the suspension
date as well. With an update to the description. We could also have a new
preference SuspensionCalendar mimicking the behaviour.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17961] TT syntax for notices - Prove we have an equivalent for our historical custom syntax

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17961

--- Comment #5 from Katrin Fischer  ---
Added to next meeting's agenda:
https://wiki.koha-community.org/wiki/General_IRC_meeting_4_April_2018#Agenda

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17489] Allow Koha plugins to have translations

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17489

--- Comment #3 from Katrin Fischer  ---
Hi Kyle, this looks promising! I am not sure I can figure it out myself, any
chance you could spend some time on a prototype?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20123] Allow multiple instances of Koha to have different timezones on the same server

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20123

--- Comment #29 from Katrin Fischer  ---
I like the idea of a wiki page with information on how this will work and where
the limits might be. Do you need to change MySQL configuration as well or is
the koha-conf variable enough?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20127] Label Making Solution

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20127

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #1 from Katrin Fischer  ---
This sounds like extensive functionality planned. Why a plugin and not a
solution within Koha? Because it wouldn't fit besides the existing label
editor? Maybe it could use a part of it like the batch process? We also have
the quick label printing where a little of that is possible, but not quite. But
they are formatted to be changed by CSS easily.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20131] Inventory optional filters always shows "For loan" for value 0

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20131

--- Comment #10 from Katrin Fischer  ---
Hm, ok, I might not understand the reasoning behind this patch or even the bug
it tries to fix :(

>From my testing:

6) Create in authorized values category "NFL" a value 0 with description
"Available"
7) Go to inventory /cgi-bin/koha/tools/inventory.pl
8) Without patch you see "For loan" in items.notforloan for value 0
9) With patch you see "Available" in items.notforloan for value 0

When I do that, I end up with 2 values showing on the inventory form: 
For loan and Available - both actually meaning the same.

Also: On the edit item form the Available appears twice(!) in the pull down and
the X to empty the field is no longer present.

What I can see is an inconsistency on the inventory form as we only have a "0"
value for not for loan, while we don't have that for lost, withdrawn and
damaged. I'd suggest to either remove it  or add an empty option for all of
them. But also not using 'for loan' - because it still might not be, but
something like 'not set'. Or: Not lost, not withdrawn, not damaged,...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20131] Inventory optional filters always shows "For loan" for value 0

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20131

--- Comment #9 from Katrin Fischer  ---
(In reply to Fridolin SOMERS from comment #8)
> (In reply to Katrin Fischer from comment #7)
> > >8) Without patch you see "For loan" in items.notforloan for value 0
> > >9) With patch you see "Available" in items.notforloan for value 0
> > 
> > Still 'For loan' for me. Please fix test plan or patch!
> 
> If you have memcached and/or plack, you need to restart them when you change
> authorized values.

Hi Frido, that should not be necessary in current versions, but I am retesting
anyway.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19562] Inventory: How can we skip convolutes marked as problematic with no_barcode?

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19562

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #5 from Katrin Fischer  ---
In German it's slightly different: Konvolut.

I think having a proper solution in Koha for these kinds of items would be
nice. EasyAnalytics is one way, but because of the way it uses fields in the
record it's not usable in our union catalog setting.

We have implemented something for the OPAC using the notes fields to create
linkings, here is an example:

https://bbf.bsz-bw.de/cgi-bin/koha/opac-detail.pl?biblionumber=22022

Note says: bound with... clicking on the search link brings up the other items,
it's bound with and that have no barcode (in this case 1, but can be many). 

>From the items without barcode a link leads back to the barcode item.

Links are created by putting ## callnumber or %% callnumber into the item
notes, with the option to have specific notes before the separator.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20325] C4::Accounts::purge_zero_balance_fees does not check account_offsets

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20325

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #73350|0   |1
is obsolete||

--- Comment #5 from Katrin Fischer  ---
Created attachment 73516
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73516=edit
Bug 20325: C4::Accounts::purge_zero_balance_fees does not check account_offsets

purge_zero_balance_fees is used in cleanup_database.pl to determine which fees
can be cleaned up.

It uses a simple SQL query to determine which rows in accountlines need to be
removed:

463 my $sth = $dbh->prepare(
464 q{
465 DELETE FROM accountlines
466 WHERE date < date_sub(curdate(), INTERVAL ? DAY)
467   AND ( amountoutstanding = 0 or amountoutstanding IS NULL );
468 }

The function comes with the following warning:

451 B Because fines and payments are not linked in accountlines, it
is
452 possible for a fine to be deleted without the accompanying payment,
453 or vise versa. This won't affect the account balance, but might be
454 confusing to staff.

This was a reasonable solution prior to the addition of account_offsets in
17.11. The problem now is that rows in accountlines which are linked as credits
in accountlines will *always* have amountoutstanding marked as 0. These are
linked to debits via account_offsets. purge_zero_balance_fees will delete
credits and leave rows in account_offsets which link to deleted credits.

Sites using the --fees option cleanup_database.pl which upgrade to 17.11 may
have all of their credits removed without warning.

Test Plan:
1) Apply this patch
2) prove t/db_dependent/Accounts.t

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20325] C4::Accounts::purge_zero_balance_fees does not check account_offsets

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20325

Katrin Fischer  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20325] C4::Accounts::purge_zero_balance_fees does not check account_offsets

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20325

--- Comment #4 from Katrin Fischer  ---
Hi Kyle, this checks out well for me and I am signing off to move this along.
Just one question:

Would it be safe to remove this warning now from the docs of cleanup_database?

WARNING: Fees and payments may not be deleted together. This will not affect
the account balance but may be confusing to staff.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/