[Koha-bugs] [Bug 20592] updateitem.pl causes database errors when empty non-public item notes updated

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20592

--- Comment #6 from David Cook  ---
(In reply to M. Tompsett from comment #2)
> I believe this is the wrong way to do it. The problem is ModItem requires an
> itemnumber, and the itemnumber check is too late in the function.

No, that's not the problem. The problem is an an empty $item hashref being
passed into C4::Items::_koha_modify_item(), which creates an invalid SQL query.

But I agree that a better solution would be to change ModItem rather than
updateitem.pl. I considered that, but I figured I would make the lightest touch
possible and test the one place where I knew there was a problem. Do you know
whether or not it's appropriate to return early from ModItem? What impact does
that have across Koha?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20400] Add routing list tab to the patron account in OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20400

Dilan Johnpullé  changed:

   What|Removed |Added

  Attachment #74300|0   |1
is obsolete||

--- Comment #28 from Dilan Johnpullé  ---
Created attachment 74402
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74402=edit
Bug 20400: (follow-up) Use Asset TT plugin on opac-routing-lists.tt

Patch applies and functions as described.
Signed-off-by: Dilan Johnpullé 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20400] Add routing list tab to the patron account in OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20400

Dilan Johnpullé  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18677] issue_id is not added to accountlines for lost item fees

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18677

M. Tompsett  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #6 from M. Tompsett  ---
While I think Maksim Sim's error is bad data, I'll mark this Failed QA due to
comments #2 and #3. #3 is a request for test coverage of a code change in a C4
library. Given how tests make code changes easier to check and our current RM,
please provide them.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20580] create_superlibrarian.pl should accept parameters

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20580

M. Tompsett  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA
 CC||mtomp...@hotmail.com

--- Comment #2 from M. Tompsett  ---
reset_all
kshell
./misc/devel/create_superlibrarian.pl --user admin --password admin
--branchcode CPL --categorycode S --cardnumber SEE_THIS_BREAKS

A new user is added, but the userid isn't admin. In my test case it was 4. Ran
it 2 more times: 5 and 6. This case needs to be reported and/or prevented. If
the userid exists, perhaps a nice warning and either die, or spit out the new
userid.

Otherwise, it works great in "normal" circumstances.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20581] Allow manual selection of custom ILL request statuses

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581

M. Tompsett  changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com

--- Comment #8 from M. Tompsett  ---
Let's say I install multiple languages.
If the Authorized Value is not keyed partially on language, then how well will
this work in a multilingual setting where one user might use one language, and
another one might use some other language.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16486] Display the TIME a fine was collected/written off

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16486

Aleisha Amohia  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20599] Add the Koha::Subscription->vendor method

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20599

M. Tompsett  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20599] Add the Koha::Subscription->vendor method

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20599

M. Tompsett  changed:

   What|Removed |Added

  Attachment #74392|0   |1
is obsolete||

--- Comment #2 from M. Tompsett  ---
Created attachment 74401
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74401=edit
Bug 20599: Add the Koha::Subscription->vendor method

Test plan:
  prove t/db_dependent/Koha/Subscription.t
must return green

NOTE: My preference is for $subscription to be object,
  and perhaps something like $built_subscription to
  be from the builder. Because, $object is a poor
  variable name.

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20582] Turn Koha into a Mojolicious application (?)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20582

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20592] updateitem.pl causes database errors when empty non-public item notes updated

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20592

--- Comment #5 from M. Tompsett  ---
Test plan is the same as comment #1.
Testing on a kohadevbox after a reset all.
blanking the log before clicking update:
 echo | sudo tee /var/log/koha/kohadev/plack-error.log
Used the same url given:

http://localhost:8081/cgi-bin/koha/catalogue/moredetail.pl?biblionumber=1=1

Before my two patches, noise and update triggers more.
After my two patches, no noise.

David's patch works, but if there are other places which need the same check
they would have to be modified too. The ModItem function should be validating
its parameters. Also, I don't believe you need to check for biblionumber in
your condition, David.

My first patch adds that validation, so other functions receive the same fix.
My second just cleans up some noise, since the first warning wasn't the only
noise triggered.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20592] updateitem.pl causes database errors when empty non-public item notes updated

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20592

--- Comment #3 from M. Tompsett  ---
Created attachment 74399
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74399=edit
Bug 20592: Checks for itemnumber sooner

Two lines of code and move them earlier.
Add a check to make sure there are changes.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20592] updateitem.pl causes database errors when empty non-public item notes updated

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20592

--- Comment #4 from M. Tompsett  ---
Created attachment 74400
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74400=edit
Bug 20592: Scope creep - fix other noise

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736

--- Comment #49 from M. Tompsett  ---
Created attachment 74398
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74398=edit
Bug 18736: Add missing test cases [BUGGY]

The ELSE case is flawed. This needs fixing.
The third parameter is budgets, and needs to
be valid. It currently is passing, because
undef+0= 0, and the expected values are set
to zero. They should be non-zero!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736

--- Comment #48 from M. Tompsett  ---
Created attachment 74397
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74397=edit
Bug 18736: [DO NOT PUSH] Print scaffolding for C4/Budgets.pm

The ELSE case is a pain. Please get it to return something
rather than undef.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #237 from Katrin Fischer  ---
Sorry Julian, patches apply, but still some problems:

1) QA scripts

Lots of those:
 FAIL   Koha/Baskets.pm
   FAIL   git manipulation
The file has been added and deleted in the same patchset
Maybe see if you can squash some with the same sign-offer?

And:

 FAIL   t/db_dependent/Acquisition/close_reopen_basket.t
   OK critic
   OK forbidden patterns
   OK git manipulation
   OK pod
   OK spelling
   FAIL   valid
Global symbol "$order1" requires explicit package name 
Global symbol "$order2" requires explicit package name 
t/db_dependent/Acquisition/close_reopen_basket.t had
compilation errors.

 FAIL   t/db_dependent/Acquisition/Basketgroups.t
   OK critic
   OK forbidden patterns
   OK git manipulation
   OK pod
   OK spelling
   FAIL   valid
"AddBookseller" is not exported by the C4::Bookseller module
Can't continue after import errors 

2) Code review

a) Koha/Acquisition/Baskets.pm
-# Copyright 2017 Aleisha Amohia 
-#
Why remove the Copyright statement? And POD?

b) Similar: Koha/Acquisition/Orders.pm

+my $pdfformatfile = './' . ($pdfformat =~ s,::,/,gr) . '.pm';
+require $pdfformatfile;
Seems to be an unrelated change? I remember that we hardcoded the valid
template names once for added security. could only find one mention of it tho:
bug 11459#c11

c) admin/currency.pl
+use Koha::Acquisition::Currency;
Unrelated change?

d) koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basketgroups.tt
Bookseller
Should be vendor!

e) Generate EDIFACT Order
Capitalization: Generate EDIFACT order

f) Changes to koha-tmpl/intranet-tmpl/prog/js/datatables.js
Do you remember why those changes were needed or was it not intentional? Trying
to figure out what needs to be tested with this patch and it turns out a lot of
code is touched.

g) Merge atomicupdates?

3) Unit tests

prove t/db_dependent/Acquisition/Basketgroups.t
t/db_dependent/Acquisition/Basketgroups.t .. "AddBookseller" is not exported by
the C4::Bookseller module
Can't continue after import errors at t/db_dependent/Acquisition/Basketgroups.t
line 9.
BEGIN failed--compilation aborted at t/db_dependent/Acquisition/Basketgroups.t
line 9.

prove t/db_dependent/Acquisition/close_reopen_basket.t
t/db_dependent/Acquisition/close_reopen_basket.t .. Global symbol "$order1"
requires explicit package name at
t/db_dependent/Acquisition/close_reopen_basket.t line 58.
Global symbol "$order2" requires explicit package name at
t/db_dependent/Acquisition/close_reopen_basket.t line 68.
Execution of t/db_dependent/Acquisition/close_reopen_basket.t aborted due to
compilation errors.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17674] Allow UI to delete serials issues in batch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674

--- Comment #53 from Katrin Fischer  ---
This if for serials issues, not subscriptons. I think it will be useful if
libraries bind issues or regularly throw out older ones.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17674] Allow UI to delete serials issues in batch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674

Katrin Fischer  changed:

   What|Removed |Added

Summary|Allow UI to delete serials  |Allow UI to delete serials
   |in batch|issues in batch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17674] Allow UI to delete serials in batch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674

--- Comment #52 from Jonathan Druart  
---
For information: I have added a "modify selected serials" link on bug 18426,
but on the other screen (subscription search result)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20599] Add the Koha::Subscription->vendor method

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20599

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||18426


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18426
[Bug 18426] Subscriptions batch editing
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18426] Subscriptions batch editing

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18426

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||20599
   Keywords|Academy |

--- Comment #19 from Jonathan Druart  
---
Trying to unstuck this one.

(In reply to Nick Clemens from comment #8)
> 1 - The edit button is inconsistent, it should be a link as the others, and
> I would suggest 'Edit selected serials'

Replaced with the "action" links we already have on the biblio detail page and
the items lost report.

> 2 - On the edit page we should display all editable values - when the
> dropdown is 'No change' I cannot know what the original value was for things
> like 'Create items when receiving

Done.

> 3 - We should have a 'Cancel' button if we choose not to edit the subs

Done.

> 4 - It might be nice to be able to select/deselect subs before applying the
> edits - not a blocker but saves from going back a page on wrong click

TODO later I'd say

> 5 - Maybe 'Save' instead of 'Start batch edit'?

Done

(In reply to Katrin Fischer from comment #13)
> 1) Agree with Nick: "Edit" button would be nicer as a link, matching other
> pages like the details page.

So, done.

> 2) If you select no subscriptions and click on edit, there should be a
> warning. Or it should be inactive until you have selected some.

No longer valid.

> 3) It would be nice to have a checkbox like on the batch item edit in order
> to allow emptying the note fields. At the moment you'd have to add a space
> or something to clear them out.

We had lot of issue about that, I'd avoid to add it now.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20599
[Bug 20599] Add the Koha::Subscription->vendor method
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18426] Subscriptions batch editing

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18426

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #62119|0   |1
is obsolete||
  Attachment #64198|0   |1
is obsolete||

--- Comment #15 from Jonathan Druart  
---
Created attachment 74393
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74393=edit
Bug 18426: Refactor subscriptions tables code in a BLOCK

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18426] Subscriptions batch editing

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18426

--- Comment #18 from Jonathan Druart  
---
Created attachment 74396
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74396=edit
Bug 18426: Address QA issues

- Replaced with the "action" links we already have on the biblio detail
page and the items lost report.
- Display all the editable values in the table
- Add a 'Cancel' link

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18426] Subscriptions batch editing

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18426

--- Comment #16 from Jonathan Druart  
---
Created attachment 74394
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74394=edit
Bug 18426: Allow to edit subscriptions in batch

This adds a checkbox column in serials-search.pl tables that allow to edit
selected subscriptions.
The following fields can be modified:
 - Bookseller
 - Location
 - Library
 - Item type
 - Public note
 - Nonpublic note
 - "Create item when receiving" flag
 - Expiration date
+ the additional fields defined in serials/add_fields.pl

Test plan:

1. Go to Serials module
2. If there is no additional fields defined, define some (at least one with an
   authorized value and one without)
3. Start a subscription search
4. Select some results using the checkboxes and click the "Edit" button above
   the table
5. Select values for some fields (not all) and click "Start batch edit"
6. Verify you are being redirected to the previous search results
7. Verify that the fields for which you selected a value were modified and that
   the others fields weren't
8. Repeat steps 4 to 7 but this time, modify the other fields.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18426] Subscriptions batch editing

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18426

--- Comment #17 from Jonathan Druart  
---
Created attachment 74395
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74395=edit
Bug 18426: Fix datepicker

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18426] Subscriptions batch editing

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18426

Jonathan Druart  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20599] New: Add the Koha::Subscription->vendor method

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20599

Bug ID: 20599
   Summary: Add the Koha::Subscription->vendor method
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: jonathan.dru...@bugs.koha-community.org
  Reporter: jonathan.dru...@bugs.koha-community.org
QA Contact: testo...@bugs.koha-community.org

To access the vendor of a subscription easily

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20599] Add the Koha::Subscription->vendor method

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20599

--- Comment #1 from Jonathan Druart  
---
Created attachment 74392
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74392=edit
Bug 20599: Add the Koha::Subscription->vendor method

Test plan:
  prove t/db_dependent/Koha/Subscription.t
must return green

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20599] Add the Koha::Subscription->vendor method

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20599

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17674] Allow UI to delete serials in batch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674

Séverine Queune  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #51 from Séverine Queune  ---
(In reply to Owen Leonard from comment #47)
>  - Confirm that the "Delete selected" button works correctly.
When serials of several years exist, only the button of the first tab works,
not the buttons "Delete selected issues" displayed on the tabs of previous
years.
The other buttons work as expected on all tabs.
Except that point, the rest of the patch works correctly, but I prefer not sign
it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20402] Implement OAuth2 authentication for REST API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20402

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
  Text to go in the|This development adds the   |This development adds the
  release notes|OAuth2 client credentials   |OAuth2 client credentials
   |grant support to Koha. This |grant support to Koha. This
   |way, securitizing the REST  |way securing the REST API
   |api for using it from other |for using it from other
   |systems gets easier as it   |systems gets easier as it
   |follows current standards.  |follows current standards.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20507] Shelf browser does not update image sources when paging

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20507

Eric Phetteplace  changed:

   What|Removed |Added

 CC||ephettepl...@cca.edu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12759] Add ability to pass list contents to batch record modification/deletion tools

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12759

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #17 from Katrin Fischer  ---
I think tabs. Could we keep the content or is that not possible?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18327] Add the ability to set the received date to today on multi receiving serials

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18327

--- Comment #6 from Séverine Queune  ---
The use of checkbox works as expected.
Behaviours of others buttons are the same as before.

I messed bug 18237 when I first this one, I confused myself between numbers...
I hope it won't cause touble.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18327] Add the ability to set the received date to today on multi receiving serials

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18327

Séverine Queune  changed:

   What|Removed |Added

  Attachment #74376|0   |1
is obsolete||

--- Comment #5 from Séverine Queune  ---
Created attachment 74391
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74391=edit
Bug 18327: Same change for serials-edit

And use an include file to avoid copy/paste

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18327] Add the ability to set the received date to today on multi receiving serials

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18327

Séverine Queune  changed:

   What|Removed |Added

  Attachment #74375|0   |1
is obsolete||

--- Comment #4 from Séverine Queune  ---
Created attachment 74390
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74390=edit
Bug 18327: Add the ability to set the received date to today on multi receiving
serials

When receiving several issues for a subscription (Serials > Serial
collection > Multi receiving), the reception date is always identical to the
publication date.
In some use cases we would like to set this "date received" value to
today.
Note: "date received" refers to the DB column serial.planneddate

To make this possible this patch replaces the JS prompt with a modal
dialog asking for
 1. the number of issues to receive
 2. if the received date must be set to today

Ergonomic note: bootstrap styled buttons are used, but they do not display
correctly
We may need to improve that (later)

Test plan:
- Receive 1 or more serials using the "Multi receiving" buttons
Note that this button appears twice, on the "serial collection
information" and the "serial edition" pages
- Try with and without the new checkbox ticked and confirm the behaviour
is correct (i.e. date received is set to today or set to the publish
date)
- Make sure "Edit serials" and "Generate next" buttons still work as
before

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18327] Add the ability to set the received date to today on multi receiving serials

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18327

Séverine Queune  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20402] Implement OAuth2 authentication for REST API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20402

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Text to go in the||This development adds the
  release notes||OAuth2 client credentials
   ||grant support to Koha. This
   ||way, securitizing the REST
   ||api for using it from other
   ||systems gets easier as it
   ||follows current standards.
   Severity|enhancement |new feature

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18237] Can't use a hash as a reference at docs/CAS/CASProxy/examples/proxy_cas_data.pl line 60.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18237

Séverine Queune  changed:

   What|Removed |Added

 Status|Signed Off  |ASSIGNED
 CC||severine.que...@bulac.fr

--- Comment #5 from Séverine Queune  ---
(In reply to Séverine Queune from comment #4)
> Created attachment 74387 [details] [review]
> Bug 11674: DBRev 17.12.00.031
> 
> Signed-off-by: Jonathan Druart 

I'm s sorry !! I wrote 18237 instead of 18327 when I signed it
I set it back to "ASSIGNED"

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20568] Add API key management interface for patrons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20568

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #74348|0   |1
is obsolete||

--- Comment #27 from Tomás Cohen Arazi  ---
Created attachment 74389
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74389=edit
Bug 20568: Move value => client_id + secret

This patch addresses the request from Julian that api keys are expected
to be client id/secret pairs.

It does so by
- Adding 'client_id' and 'secret' columns
- Removing 'value'

Tests got adjusted and so controller scripts and templates.
Both libs and tests changes have been squashed. This ones remain in
order to keep Owen's attribution on the template changes and avoid
rebase conflicts.

Signed-off-by: Kyle M Hall 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20568] Add API key management interface for patrons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20568

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #74347|0   |1
is obsolete||

--- Comment #26 from Tomás Cohen Arazi  ---
Created attachment 74388
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74388=edit
Bug 20568: (follow-up) Interface and markup changes

This patch makes some interface changes to bring things better in line
with existing interface patterns. This patch also re-indents the
modified templates with 4 spaces instead of 2 and makes s
self-closing.

Also changed: Corrected system preference check in opac-apikeys.pl.

To test, apply the patch and:

In the staff client:

 - Open a patron record and choose More -> Manage API keys.
   - There should be a standard message dialog containing a link to
 "Generate a new key."
 - Clicking the link should show the form for adding a new key.
 - Test that clicking the "Cancel" link hides the form.
 - Test that creating the new key works correctly.
   - You should now see a table showing existing keys and a "Generate a
 new key" button above it.
 - Test that the "Delete" button asks for confirmation, and that
   confirming and denying both work correctly.
 - Test that "Revoke" and "Activate" actions still work correctly.

In the OPAC:

 - Set the AllowPatronsManageAPIKeysInOPAC system preference to "Allow."
 - Log in to the OPAC and click the "your API keys" link in the sidebar.
   - Clicking the "Generate new key" button should display the form for
 adding a new key.
 - Clicking the "cancel" link should hide the form.
 - Submitting the form should add a new key.
   - You should now see a table showing existing keys.
 - Test that the "Delete" link asks for confirmation, and that
   confirming and denying both work correctly.
 - Test that "Revoke" and "Activate" actions still work correctly.
 - Set the AllowPatronsManageAPIKeysInOPAC system preference to "Don't
   allow."
   - Log in to the OPAC and confirm that the "your API keys" link in the
 sidebar is no longer visible.
 - Confirm that navigating directly to /cgi-bin/koha/opac-apikeys.pl
   results in a 404 error.

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: Kyle M Hall 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20402] Implement OAuth2 authentication for REST API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20402

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #47 from Tomás Cohen Arazi  ---
Only minor fixes were needed. Works as expected.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18237] Can't use a hash as a reference at docs/CAS/CASProxy/examples/proxy_cas_data.pl line 60.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18237

Séverine Queune  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18237] Can't use a hash as a reference at docs/CAS/CASProxy/examples/proxy_cas_data.pl line 60.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18237

--- Comment #4 from Séverine Queune  ---
Created attachment 74387
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74387=edit
Bug 11674: DBRev 17.12.00.031

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20402] Implement OAuth2 authentication for REST API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20402

--- Comment #46 from Tomás Cohen Arazi  ---
Created attachment 74386
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74386=edit
Bug 20402: Add missing POD

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20402] Implement OAuth2 authentication for REST API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20402

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #74368|0   |1
is obsolete||

--- Comment #43 from Tomás Cohen Arazi  ---
Created attachment 74383
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74383=edit
Bug 20402: Remove dependency on Mojo::Plugin::OAuth2::Server

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20402] Implement OAuth2 authentication for REST API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20402

--- Comment #45 from Tomás Cohen Arazi  ---
Created attachment 74385
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74385=edit
Bug 20402: Atomic update and kohastructure.sql fixes

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20402] Implement OAuth2 authentication for REST API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20402

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #74369|0   |1
is obsolete||

--- Comment #44 from Tomás Cohen Arazi  ---
Created attachment 74384
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74384=edit
Bug 20402: Use TestBuilder->build_object in oauth.t

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20402] Implement OAuth2 authentication for REST API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20402

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #74367|0   |1
is obsolete||

--- Comment #42 from Tomás Cohen Arazi  ---
Created attachment 74382
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74382=edit
Bug 20402: Don't look at cookies if OAuth2 is attempted and has failed

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20402] Implement OAuth2 authentication for REST API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20402

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #74366|0   |1
is obsolete||

--- Comment #41 from Tomás Cohen Arazi  ---
Created attachment 74381
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74381=edit
Bug 20402: Fix oauth.t

GET /patrons now requires { "borrowers": 1 } instead of
{ "borrowers": "edit_borrowers" }

Signed-off-by: Josef Moravec 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20402] Implement OAuth2 authentication for REST API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20402

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #74365|0   |1
is obsolete||

--- Comment #40 from Tomás Cohen Arazi  ---
Created attachment 74380
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74380=edit
Bug 20402: Implement OAuth2 authentication for REST API

It implements only the "client credentials" flow with no scopes
support. API clients are tied to an existing patron and have the same
permissions as the patron they are tied to.
API Clients are defined in $KOHA_CONF.

Test plan:
0. Install Net::OAuth2::AuthorizationServer 0.16
1. In $KOHA_CONF, add an  element under :
 
   $CLIENT_ID
   $CLIENT_SECRET
   X 
 
2. Apply patch, run updatedatabase.pl and reload starman
3. Install Firefox extension RESTer [1]
4. In RESTer, go to "Authorization" tab and create a new OAuth2
   configuration:
   - OAuth flow: Client credentials
   - Access Token Request Method: POST
   - Access Token Request Endpoint: http://$KOHA_URL/api/v1/oauth/token
   - Access Token Request Client Authentication: Credentials in request
 body
   - Client ID: $CLIENT_ID
   - Client Secret: $CLIENT_SECRET
5. Click on the newly created configuration to generate a new token
   (which will be valid only for an hour)
6. In RESTer, set HTTP method to GET and url to
   http://$KOHA_URL/api/v1/patrons then click on SEND
   If patron X has permission 'borrowers', it should return 200 OK
   with the list of patrons
   Otherwise it should return 403 with the list of required permissions
   (Please test both cases)
7. Wait an hour (or run the following SQL query:
   UPDATE oauth_access_tokens SET expires = 0) and repeat step 6.
   You should have a 403 Forbidden status, and the token must have been
   removed from the database.
8. Create a bunch of tokens using RESTer, make some of them expires
   using the previous SQL query, and run the following command:
 misc/cronjobs/cleanup_database.pl --oauth-tokens
   Verify that expired tokens were removed, and that the others are
   still there
9. prove t/db_dependent/api/v1/oauth.t

[1] https://addons.mozilla.org/en-US/firefox/addon/rester/

Signed-off-by: Josef Moravec 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19368] Add syspref to ignore words when sorting serials

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368

Charles Farmer  changed:

   What|Removed |Added

  Attachment #72657|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11317] Add a way to access files from the intranet

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317

Roch D'Amour  changed:

   What|Removed |Added

  Attachment #72456|0   |1
is obsolete||
  Attachment #72457|0   |1
is obsolete||
  Attachment #72458|0   |1
is obsolete||
  Attachment #72459|0   |1
is obsolete||
  Attachment #72460|0   |1
is obsolete||
  Attachment #72461|0   |1
is obsolete||
  Attachment #72462|0   |1
is obsolete||
  Attachment #72463|0   |1
is obsolete||
  Attachment #72464|0   |1
is obsolete||
  Attachment #72465|0   |1
is obsolete||
  Attachment #74119|0   |1
is obsolete||

--- Comment #137 from Roch D'Amour  ---
Created attachment 74379
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74379=edit
Bug 11317: Squash attachements to clean and fix merge errors: Add a way to
access files from the intranet

This squash contains all of these commits:
- Adds a page to access log files on the server from the intranet
- Update ID to allow for permalinking
- Rename config to "'accessdir' and fix qa
- Allows for multiple directories to be accessible
- Update the link under reports
- (Follow-up) Fixing merge error and cosmetic changes
- (Follow-up) Fix tab chars and move javascript to the footer
- (QA Follow-up) Fix datatable
- Make filename unicode-proof, renamed accessdir to access_dir and fix update

Test plans:
- Apply patch, update database
- Add to koha-conf:
/tmp/koha-public/one
/tmp/koha-public/two
/tmp/koha-public
- Create these directories ( mkdir /tmp/koha-public , etc...)
- Create these files:
echo "hello world!" > /tmp/koha-public/❤
echo "test" > /tmp/koha-public/one/samename.txt
echo "this is not the same" > /tmp/koha-public/two/samename.txt
- Login as Superadmin, go to tools > reports files
- Click on ❤, make sure it's downloadable and readable
- Click on both samename.txt, look inside and make sure the file is
different
- Login as NON-superadmin. Go under tools, see no Report/Log under the third
column
- Go to add tools/access_file permission to user
- See new entry under tools third column.
- validate link is ok.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11317] Add a way to access files from the intranet

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317

Roch D'Amour  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19030] Link order <-> subscription is lost when an order is edited

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19030

--- Comment #14 from Séverine Queune  ---
I tried different kind of subscriptions and didn't notice weird behaviour this
time.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19030] Link order <-> subscription is lost when an order is edited

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19030

Séverine Queune  changed:

   What|Removed |Added

  Attachment #74313|0   |1
is obsolete||

--- Comment #13 from Séverine Queune  ---
Created attachment 74378
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74378=edit
Bug 19030: Preserve link between order and subscription when editing an order

The aqorders.subscriptionid info is not sent to the template when the
order is edited. Which means we lose this link.

Test plan:
Create an order from a subscription
Edit the order
=> Without this patch, the aqorders.subscriptionid value is set to NULL
and items are created when receiving serial.

=> With this patch applied the link is preserved and expected behaviors
are preserved during all the acquisition workflow

You should also try and create several orders from the same subscription

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19030] Link order <-> subscription is lost when an order is edited

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19030

Séverine Queune  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20598] Accruing fines not closed out by longoverdue.pl if WhenLostForgiveFine is not enabled

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20598

Kyle M Hall  changed:

   What|Removed |Added

   Severity|enhancement |normal

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20598] Accruing fines not closed out by longoverdue.pl if WhenLostForgiveFine is not enabled

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20598

--- Comment #1 from Kyle M Hall  ---
Created attachment 74377
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74377=edit
Bug 20598: Accruing fines not closed out by longoverdue.pl if
WhenLostForgiveFine is not enabled

Test Plan:
1) Ensure WhenLostForgiveFine is disabled
2) Create an overdue with a fine
3) Mark it lost with longoverdue.pl
4) Note it is still marked as an accruing fine
5) Apply this patch
6) Repeat steps 1-3
7) Note it is no longer an accruing fine!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18327] Reception date when receiving multiple issues for a subscription is not the good one

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18327

--- Comment #3 from Jonathan Druart  
---
Created attachment 74376
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74376=edit
Bug 18327: Same change for serials-edit

And use an include file to avoid copy/paste

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18327] Add the ability to set the received date to today on multi receiving serials

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18327

Jonathan Druart  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c
   |ity.org |ommunity.org
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
Summary|Reception date when |Add the ability to set the
   |receiving multiple issues   |received date to today on
   |for a subscription is not   |multi receiving serials
   |the good one|
  Change sponsored?|Seeking developer   |Sponsored

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20598] Accruing fines not closed out by longoverdue.pl if WhenLostForgiveFine is not enabled

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20598

Kyle M Hall  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18327] Reception date when receiving multiple issues for a subscription is not the good one

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18327

--- Comment #2 from Jonathan Druart  
---
Created attachment 74375
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74375=edit
Bug 18327: Add the ability to set the received date to today on multi receiving
serials

When receiving several issues for a subscription (Serials > Serial
collection > Multi receiving), the reception date is always identical to the
publication date.
In some use cases we would like to set this "date received" value to
today.
Note: "date received" refers to the DB column serial.planneddate

To make this possible this patch replaces the JS prompt with a modal
dialog asking for
 1. the number of issues to receive
 2. if the received date must be set to today

Ergonomic note: bootstrap styled buttons are used, but they do not display
correctly
We may need to improve that (later)

Test plan:
- Receive 1 or more serials using the "Multi receiving" buttons
Note that this button appears twice, on the "serial collection
information" and the "serial edition" pages
- Try with and without the new checkbox ticked and confirm the behaviour
is correct (i.e. date received is set to today or set to the publish
date)
- Make sure "Edit serials" and "Generate next" buttons still work as
before

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18327] Reception date when receiving multiple issues for a subscription is not the good one

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18327

Jonathan Druart  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20589] Add field boosting and use elastic query fields parameter instead of depricated _all

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589

--- Comment #6 from David Gustafsson  ---
Had forgotten to take new "search" field into account for mappings, and also
fixed where had not removed all of the _all-field mapping (which would have
caused indexing to crash).

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11249] Add db indexes on borrowers names

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11249

David Gustafsson  changed:

   What|Removed |Added

 CC||glask...@gmail.com

--- Comment #8 from David Gustafsson  ---
Sorry, accidentally submitted new attachment by omitting HEAD with git bz apply
for another patch. Please ignore this last change.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736

--- Comment #47 from M. Tompsett  ---
Created attachment 74374
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74374=edit
Bug 18736: [DO NOT PUSH] C4/Acquisition print scaffolding.

Need to trigger all the print STDERR "C4/Acquisition.pm...
cases.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20598] Accruing fines not closed out by longoverdue.pl if WhenLostForgiveFine is not enabled

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20598

Kyle M Hall  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20598] New: Accruing fines not closed out by longoverdue.pl if WhenLostForgiveFine is not enabled

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20598

Bug ID: 20598
   Summary: Accruing fines not closed out by longoverdue.pl if
WhenLostForgiveFine is not enabled
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: k...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736

M. Tompsett  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #46 from M. Tompsett  ---
Need test for GetLateOrders with both settings of OrderPriceRounding.
Other feedback still may follow. I'll summarize in one final comment
afterwards.

It would be nice to also trigger the else case for the dbdriver, but that might
take some expert mocking, which is low priority as mysql/mariadb are the
preferred db drivers.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20589] Add field boosting and use elastic query fields parameter instead of depricated _all

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589

David Gustafsson  changed:

   What|Removed |Added

  Attachment #74301|0   |1
is obsolete||

--- Comment #5 from David Gustafsson  ---
Created attachment 74373
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74373=edit
Bug 20589: Add field boosting and use query_string fields parameter

Generate a list of fields for the query_string query fields parameter,
with possible boosts, instead of using "_all"-field. Also add "search"
flag in search_marc_to_field table so that certain mappings can be
excluded from searches. Add option to include/exclude fields in
query_string "fields" parameter depending on searching in OPAC or staff
client. Refactor code to remove all other dependencies on "_all"-field.

How to test:
1) No reindex is really required, but still, reindex authorities and
   biblios to verify that this still works.
2) Search biblios and try to verify that this works as expected.
3) Search authorities and try to verify that this works as expected.
4) Go to "Search engine configuration"
5) Change some "Boost", "Staff client", and "OPAC" settings and save.
6) Verify that those settings where saved accordingly.
7) Click the "Biblios" or "Authorities" tab and change one or more
   "Searchable" settings
8) Verfiy that those settings where saved accordingly.
9) Try to verify that these settings has taken effect by peforming
   some biblios and/or authorities searches.

Sponsorded-by: Gothenburg Univesity Library

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11249] Add db indexes on borrowers names

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11249

--- Comment #7 from David Gustafsson  ---
Created attachment 74372
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74372=edit
Bug 11249: DBRev 3.15.00.006

Signed-off-by: Galen Charlton 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12759] Add ability to pass list contents to batch record modification/deletion tools

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12759

--- Comment #16 from Owen Leonard  ---
(In reply to Jonathan Druart from comment #15)
> why not tabs then?

Tabs work too. But is it going to make someone mad if they paste a list of
barcodes, switch tabs, switch back, and find their input gone?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736

--- Comment #45 from M. Tompsett  ---
Created attachment 74371
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74371=edit
Bug 18736: Follow to clean up admin policy preference

Two preferences were merged into the same box. This likely
was unintended. This reformats them.

TEST PLAN
-
Go to Acquisitions tab of the system preference
-- in the policy section PurgeSuggestionsOlderThan and
   OrderPriceRounding are in the same box
Apply this patch
Refresh the page
-- OrderPriceRounding is in its own box, and better formatted.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12759] Add ability to pass list contents to batch record modification/deletion tools

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12759

--- Comment #15 from Jonathan Druart  
---
(In reply to Owen Leonard from comment #14)
> Would it make sense to completely reset the form if someone selects a
> different input method (file/list/numbers) ?
> 
> http://zivotdesign.com/p/#1/15239764835671

why not tabs then?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736

--- Comment #44 from M. Tompsett  ---
Created attachment 74370
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74370=edit
Bug 18736: Follow to prevent duplicate run noise

TEST PLAN
-
update the database twice
-- noise
apply patch
update the database
-- no noise

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20402] Implement OAuth2 authentication for REST API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20402

Julian Maurice  changed:

   What|Removed |Added

  Attachment #74070|0   |1
is obsolete||

--- Comment #36 from Julian Maurice  ---
Created attachment 74366
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74366=edit
Bug 20402: Fix oauth.t

GET /patrons now requires { "borrowers": 1 } instead of
{ "borrowers": "edit_borrowers" }

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20402] Implement OAuth2 authentication for REST API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20402

--- Comment #38 from Julian Maurice  ---
Created attachment 74368
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74368=edit
Bug 20402: Remove dependency on Mojo::Plugin::OAuth2::Server

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20402] Implement OAuth2 authentication for REST API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20402

--- Comment #39 from Julian Maurice  ---
Created attachment 74369
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74369=edit
Bug 20402: Use TestBuilder->build_object in oauth.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20402] Implement OAuth2 authentication for REST API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20402

Julian Maurice  changed:

   What|Removed |Added

  Attachment #74088|0   |1
is obsolete||

--- Comment #37 from Julian Maurice  ---
Created attachment 74367
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74367=edit
Bug 20402: Don't look at cookies if OAuth2 is attempted and has failed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20402] Implement OAuth2 authentication for REST API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20402

Julian Maurice  changed:

   What|Removed |Added

  Attachment #74069|0   |1
is obsolete||

--- Comment #35 from Julian Maurice  ---
Created attachment 74365
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74365=edit
Bug 20402: Implement OAuth2 authentication for REST API

It implements only the "client credentials" flow with no scopes
support. API clients are tied to an existing patron and have the same
permissions as the patron they are tied to.
API Clients are defined in $KOHA_CONF.

Test plan:
0. Install Net::OAuth2::AuthorizationServer 0.16
1. In $KOHA_CONF, add an  element under :
 
   $CLIENT_ID
   $CLIENT_SECRET
   X 
 
2. Apply patch, run updatedatabase.pl and reload starman
3. Install Firefox extension RESTer [1]
4. In RESTer, go to "Authorization" tab and create a new OAuth2
   configuration:
   - OAuth flow: Client credentials
   - Access Token Request Method: POST
   - Access Token Request Endpoint: http://$KOHA_URL/api/v1/oauth/token
   - Access Token Request Client Authentication: Credentials in request
 body
   - Client ID: $CLIENT_ID
   - Client Secret: $CLIENT_SECRET
5. Click on the newly created configuration to generate a new token
   (which will be valid only for an hour)
6. In RESTer, set HTTP method to GET and url to
   http://$KOHA_URL/api/v1/patrons then click on SEND
   If patron X has permission 'borrowers', it should return 200 OK
   with the list of patrons
   Otherwise it should return 403 with the list of required permissions
   (Please test both cases)
7. Wait an hour (or run the following SQL query:
   UPDATE oauth_access_tokens SET expires = 0) and repeat step 6.
   You should have a 403 Forbidden status, and the token must have been
   removed from the database.
8. Create a bunch of tokens using RESTer, make some of them expires
   using the previous SQL query, and run the following command:
 misc/cronjobs/cleanup_database.pl --oauth-tokens
   Verify that expired tokens were removed, and that the others are
   still there
9. prove t/db_dependent/api/v1/oauth.t

[1] https://addons.mozilla.org/en-US/firefox/addon/rester/

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20594] Revert Perl version to 5.10

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20594

Jonathan Druart  changed:

   What|Removed |Added

 Status|Needs Signoff   |RESOLVED
 Resolution|--- |INVALID
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #2 from Jonathan Druart  
---
I am going to revert bug 20104 to make the release notes clear.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20505] Selenium tests fail if server not running

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20505

Nick Clemens  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20505] Selenium tests fail if server not running

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20505

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com

--- Comment #3 from Nick Clemens  ---
To trigger the test plan I installed the dependencies but did not setup the
server

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20505] Selenium tests fail if server not running

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20505

Nick Clemens  changed:

   What|Removed |Added

  Attachment #73517|0   |1
is obsolete||

--- Comment #2 from Nick Clemens  ---
Created attachment 74364
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74364=edit
Bug 20505: Patch selenium tests to skip gracefully

TEST PLAN
-
1) In a koha shell on kohadevbox, run
prove -v t/db_dependent/selenium
   until it doesn't skip because of missing
   dependencies, but rather because of not running
   a selenium server.
2) apply this patch and restart_all
3) rerun the tests
   -- they will skip gracefully and informatively.
4) run koha qa test tools

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20597] koha-restore 17.x fails to restore dump from 16.x

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20597

Radek Šiman (R-Bit Technology, s.r.o.)  changed:

   What|Removed |Added

 CC||blac...@gmail.com,
   ||josef.mora...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20597] New: koha-restore 17.x fails to restore dump from 16.x

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20597

Bug ID: 20597
   Summary: koha-restore 17.x fails to restore dump from 16.x
 Change sponsored?: ---
   Product: Koha
   Version: 17.05
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Command-line Utilities
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: r...@rbit.cz
QA Contact: testo...@bugs.koha-community.org
CC: ro...@catalyst.net.nz

Koha instance dumped in 16.x cannot be restored in 17.x version because of
missing biblio_metadata table. Debian command koha-restore fails with the
following error:
DBD::mysql::db selectrow_array failed: Table 'koha_policka.biblio_metadata'
doesn't exist [for Statement "
SELECT metadata
FROM biblio_metadata
WHERE biblionumber=?
AND format='marcxml'
AND marcflavour=?
"] at /usr/share/koha/lib/C4/Biblio.pm line 1293.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19919] Writing off a Lost Item Fee marks as "Paid for by patron"

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919

George Williams (NEKLS)  changed:

   What|Removed |Added

 CC||geo...@nekls.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20595] EDI: Add support for LRP (Library Rotation Plan) for Koha with Stock Rotation enabled

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20595

--- Comment #1 from Martin Renvoize  ---
Created attachment 74363
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74363=edit
Bug 20595: Add handling for LRP field in EDI.

* EDI.pm - Add handling of the LRP EDI field to automatically add an
item to a stockrotation rota.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20581] Allow manual selection of custom ILL request statuses

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581

Andrew Isherwood  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20581] Allow manual selection of custom ILL request statuses

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581

--- Comment #7 from Andrew Isherwood  ---
Created attachment 74362
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74362=edit
Bug 20581: Unit tests for status_alias

This patch adds unit tests for the specific status_alias functionality
added in this bug

- Creation of the ILLSTATUS authorised value
- Illrequest->statusalias accessor
- Illrequest->status overloading to reset status_alias

To test:
1) Apply this patch
2) prove t/db_dependent/Illrequests.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16976] Authorities searches with double quotes gives ZOOM error 20003

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16976

--- Comment #27 from Marjorie Barry-Vila  ---
(In reply to Jonathan Druart from comment #26)
> (In reply to Marjorie Barry-Vila from comment #25)
> 
> Hi Marjorie,
> 
> Can you open a new bug report (link it with this one) and describe the
> different steps to recreate the issue you faced?
> 
> Regards,
> Jonathan

Hi Jonathan,
I create Bug 20596.

Regards,
Marjorie

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16976] Authorities searches with double quotes gives ZOOM error 20003

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16976

Marjorie Barry-Vila  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=20596

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20596] New: Error Zoom 20003 when import authority marc file (koha/tools/manage-marc-import.pl)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20596

Bug ID: 20596
   Summary: Error Zoom 20003 when import authority marc file
(koha/tools/manage-marc-import.pl)
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Searching
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: marjorie.barry-v...@collecto.ca
QA Contact: testo...@bugs.koha-community.org

Created attachment 74361
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74361=edit
authority to test

Hi,

We have a Zoom error when we apply a matching rule on a field (035) that
appears twice in the authority record.

ZOOM error 20003 "can't set prefix query" (addinfo: "@or @attr 7=1 @attr 4=109
@attr 1=Local-Number 0  @attr 1=Any  @attr 4=1  @attr 5=100 @attr 6=3 "F01"
@attr 1=Any  @attr 4=1  @attr 5=100 @attr 6=3 "4"") from diag-set 'ZOOM'

Test plan :
- Add a record matching rule for field 035$a (index control-number)
- upload a authority record file in tools/stage-marc-import.pl (attached file)
- go to Manage staged MARC records and open authority file
- apply matching rule for 035
- see error

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20596] Error Zoom 20003 when import authority marc file (koha/tools/manage-marc-import.pl)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20596

Marjorie Barry-Vila  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=16976

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12759] Add ability to pass list contents to batch record modification/deletion tools

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12759

--- Comment #14 from Owen Leonard  ---
Would it make sense to completely reset the form if someone selects a different
input method (file/list/numbers) ?

http://zivotdesign.com/p/#1/15239764835671

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11897] Stock Rotation for Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897

--- Comment #220 from Martin Renvoize  ---
Created attachment 74360
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74360=edit
Bug 11897: DO NOT PUSH: (follow-up) Update stock rotation schema files.

We we're missing a unique constraint on stockrationrota.title

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17674] Allow UI to delete serials in batch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674

Roch D'Amour  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17674] Allow UI to delete serials in batch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674

--- Comment #50 from Roch D'Amour  ---
Created attachment 74359
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74359=edit
Bug 17674: Remove delete related item checkbox when no items is available

When the number of items available is 0, the confirmation dialog still ask is
you
also want to delete related items. This patch remove the checkbox in the
confirmation dialog
when the number of related items is 0.

To test:
- Try to delete some serials that has items available, the confirmation dialog
does not ask
if you want to delete related items since there are none.
- Try to delete some serials which has items avaible. The confirmation dialog
should show a checkbox
and ask if you want to delete related items

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14716] Correctly URI-encode URLs in XSLT result lists and detail pages

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716

--- Comment #44 from Barton Chittenden  ---
... and Chrome will automagically URL encode at least *some* URLs (I'm reminded
as I accidentally paste a '?' from an actual question into a bugzilla url, then
have to delete '%3F' ). Again, the inspector is your friend.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/