[Koha-bugs] [Bug 20945] Report params not escaped when downloading
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20945 --- Comment #3 from Nick Clemens --- Ah, I don't see it in Chrome, but I do in Firefox, what browser are you using? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20921] Expose borrowernumber and branch when user is logged in to OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20921
Nick Clemens changed:
What|Removed |Added
Attachment #76005|0 |1
is obsolete||
--- Comment #7 from Nick Clemens ---
Created attachment 76200
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76200=edit
Bug 20921: Add borrowernumber and branchcode as html attributes
To test:
1 - Apply patch
2 - Visit the opac
3 - Sign in
4 - You should not see any difference
5 - Inspect the element 'Welcome, {username}'
6 - Note the attributes for borrowernumber and branchcode
7 - Add to OPACUserJS:
$(document).ready(function(){
console.log( $(".loggedinusername").attr('data-branchcode'));
console.log( $(".loggedinusername").attr('data-borrowernumber'));
});
8 - Check the console and note you can see the info expected
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20921] Expose borrowernumber and branch when user is logged in to OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20921 Nick Clemens changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20962] Overhaul to notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20962 --- Comment #6 from Lisette --- (In reply to Hugh Rundle from comment #0) > > # Step 3 - option to process all print notices together > It would be great if this could use the hierarchical groups function added in bug 16735 so that groups/districts in consortia could benefit from this enhancement. Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20962] Overhaul to notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20962 Lisette changed: What|Removed |Added CC||lisettesla...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19719] Add a new column for collection in the patron checkouts data table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19719 --- Comment #17 from Katrin Fischer --- Proposed a database update :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19719] Add a new column for collection in the patron checkouts data table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19719 --- Comment #16 from Katrin Fischer --- Created attachment 76199 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76199=edit Bug 19719: (follow-up) Add database update to keep collection column hidden For existing installations we want to keep the current behaviour. This patch adds the column configuration to hide the collection column from the details and checkouts tabs until toggled. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19799] Changing language on OPAC redirects back to homepage
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19799 --- Comment #4 from Katrin Fischer --- This seems to work alright in my devbox on master. Could someone confirm for 18.05? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20501] Unhighlight in search results when the search terms contain the same word twice removes the word
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20501 --- Comment #4 from Katrin Fischer --- I can reproduce this: I searched for "the the". Unhighlighting removes the first occurrence of the word in the result list. (intranet only) >From the sample data: The ideas behind the chess openings / Reuben Fine. Turns into: ideas behind the chess openings / Reuben Fine. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20702] Bind results of GetHostItemsInfo to the EasyAnalyticalRecords pref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20702 Katrin Fischer changed: What|Removed |Added Attachment #75194|0 |1 is obsolete|| --- Comment #10 from Katrin Fischer --- Created attachment 76197 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76197=edit Bug 20702: Add unit tests for GetHostItemsInfo Unfortunately, we did not have unit tests yet. Adding some simple tests that test basic operation of the sub when the pref is enabled/disabled and for MARC21/UNIMARC. Test plan: [1] Run t/db_dependent/Items/GetHostItemsInfo.t Signed-off-by: Marcel de Rooy Signed-off-by: Mark Tompsett Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20702] Bind results of GetHostItemsInfo to the EasyAnalyticalRecords pref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20702 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20702] Bind results of GetHostItemsInfo to the EasyAnalyticalRecords pref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20702 Katrin Fischer changed: What|Removed |Added Attachment #75195|0 |1 is obsolete|| --- Comment #11 from Katrin Fischer --- Created attachment 76198 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76198=edit Bug 20702: Bind results of GetHostItemsInfo to the EasyAnalyticalRecords pref Triggered by the finding on bug 20697. The three calls of GetHostItemsInfo should be controlled by the pref. This patch makes the sub return an empty list when the pref is disabled. The patch simplifies the sub by merging the two identical foreach loops depending on the field number in MARC21/UNIMARC. Will add a unit test on a follow-up patch. Test plan: See next patch. Signed-off-by: Marcel de Rooy Signed-off-by: Mark Tompsett Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20806] Item type in holds history table should be write as description, not code
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20806 Katrin Fischer changed: What|Removed |Added Status|In Discussion |Failed QA --- Comment #7 from Katrin Fischer --- I think with the change to "Requested item type" the patch makes sense to me. Only thing I'd is a check for the AllowHoldItemTypeSelection system preference to decide about showing it or not. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13680] Items list on edit items page separates add items form from header and sidebar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13680 Heather changed: What|Removed |Added CC||heather_hernan...@nps.gov --- Comment #16 from Heather --- I'm just looking at this for the first time, and I am a cataloger.:) I would love ANYTHING that gets me away from scrolling down through 200+ items to add an item!!! I can live with the modal--I often copy from an existing item in the table & paste into the new item, and with the model I'd simply do that from another browser tab, easy-peasy. My dream is that the "Actions" buttons (on the items in the item table) would have a "Duplicate" action that would allow me to clone an item that duplicated that item exactly except for $d and $p and I could then add a new barcode, edit the $h and/or $t and be done. Until then, this modal add item is a HUGE improvement. (Now, if I could get that "Duplicate" in the "Actions" button and launch that new item modal like this, I'd be living the dream!) I like the "View" button. I'm most often going directly from item editing to bib record editing (with Advanced Editor/Rancor), so don't mind one more click to get to "Normal." (I edit items first then go to Rancor because starting with Rancor then "Edit items" opens editing the items another tab, which I find annoying--I'd prefer it staying in the same tab.) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20863] Delete bib_list and intranet_bib_list cookies when cart is emptied out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20863 --- Comment #4 from Katrin Fischer --- Retested: In staff it worked nicely (apart from bug 20967 found), but in the OPAC the bib_selected cookie remained with a value of %5B%5D after emptying the cart. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20967] New: 'Add to cart' button in intranet doesn't work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20967 Bug ID: 20967 Summary: 'Add to cart' button in intranet doesn't work Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Searching Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org To test: - In intranet, check several search results - Click 'Add to cart' button on top of the results list - Nothing will happen There is a JavaScript error: ReferenceError: getContextBiblioNumbers is not defined[Learn More] Adding single entries using the link in the search entry itself still works alright. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20864] Only set bibs_selected cookie when BrowseResultSelection is activated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20864 Katrin Fischer changed: What|Removed |Added Attachment #75771|0 |1 is obsolete|| --- Comment #2 from Katrin Fischer --- Created attachment 76196 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76196=edit Bug 20864: Only set bibs_selected cookie when BrowseResultSelection is activated This patch adds a system preference check around the call to the JavaScript include which sets the bibs_selected cookie. With BrowseResultsSelection disabled, the cookie should never be set. To test you should be using a browser with a tool for inspecting cookies. View the cookies for your Koha domain under each of these conditions, clearing cookies between each step: Without the patch applied: - With BrowseResultSelection enabled, search for any item. Your cookie tool should report that you have a bibs_selected cookie stored. - With BrowseResultSelection disabled, search for any item. You should have a bibs_selected cookie. With the patch applied: - With the BrowseResultSelection system preference enabled, search for any item. Your cookie tool should report that you have a bibs_selected cookie stored. - With BrowseResultSelection disabled, search for any item. You should have no bibs_selected cookie. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20864] Only set bibs_selected cookie when BrowseResultSelection is activated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20864 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20962] Overhaul to notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20962 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #5 from Jonathan Druart --- is going to be deprecated, you should use the TT syntax for notice instead. It basically means there will certainly no need to dev anything to support that (apart of adapting the template to your needs). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20881] Order receiving: Price filter missing on_editing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20881 Katrin Fischer changed: What|Removed |Added Attachment #75809|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 76195 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76195=edit Bug 20881: Order receiving: Price filter missing on_editing When the Price-filter is used on editable data, it should have the on_editing -tag. Add it to the orderreceive.tt Signed-off-by: Pasi Kallinen Signed-off-by: Katrin Fischer To test: - Set CurrencyFormat to FR - Create a basket with orders in acq - Close it - Receive shipment and pick order line to receive - On this screen verify that the actual cost appears as comma-separated - Apply patch - Refresh page - Verify that the actual cost now appears .-separated -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20881] Order receiving: Price filter missing on_editing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20881 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20881] Order receiving: Price filter missing on_editing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20881 Katrin Fischer changed: What|Removed |Added Severity|trivial |normal CC||katrin.fisc...@bsz-bw.de --- Comment #2 from Katrin Fischer --- This is quite a problem working with comma-separated decimals, upping severity a bit. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19086] Multiple cross-site scripting vulnerabilities
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19086 --- Comment #45 from Jonathan Druart --- Interesting thing: on bug 13618 it was decided to not escape the patron's messages. So maybe this will be be considered as a bug by some libraries. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20963] Can check out not for loan items when temporarily overriding restriction
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20963 --- Comment #2 from Katrin Fischer --- I think it's a mistake in the logic, the override for restriction should just allow you to 'unlock' the circulation, not override all other rules. But yeah, probably not an easy fix. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20943] Cannot enable shibboleth and LDAP at the same time
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20943 --- Comment #3 from Katrin Fischer --- I was hoping to help narrow it down with the version comment - but not sure what setup we are using :( -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20921] Expose borrowernumber and branch when user is logged in to OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20921 --- Comment #6 from Katrin Fischer --- Talked to Owen on IRC - all things cleared up. I think only thing missing here is adding the data- prefix. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20813] Revamp user permissions system
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20813 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #7 from Katrin Fischer --- Kyle, would you be ok to make this dependent on some patches in PQA when rebasing? bug 11911 - new permission for managing suggestions bug 7651 - new permission for managing currencies Both are adding new permissions. I am keen on resolving as many permission bugs as possible this release and would be happy to help with this one to have a better foundation. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20951] Koha::Patron::Discharge is missing use Koha::Patron::Debarments
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20951 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20951] Koha::Patron::Discharge is missing use Koha::Patron::Debarments
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20951 Jonathan Druart changed: What|Removed |Added Attachment #76167|0 |1 is obsolete|| --- Comment #4 from Jonathan Druart --- Created attachment 76194 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76194=edit Bug 20951: add missing use Koha::Patron::Debarments in Koha::Patron::Discharge Koha::Patron::Discharge was missing use Koha::Patron::Debarments used in discharge() method. Test plan : 1) Enable pref useDischarge 2) Go to OPAC user page 3) Go to 'ask for a discharge' tab 4) Click on 'Ask for a discharge' 5) Go to staff interface : /cgi-bin/koha/members/discharges.pl 6) Click on Allow => Without patch you get software error => With patch the discharge is validated Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17602] Integrate support for OneClickdigital/Recorded Books API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 --- Comment #100 from Jonathan Druart --- Please keep changes to opac.css in a separated patch to ease rebases. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17602] Integrate support for OneClickdigital/Recorded Books API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 --- Comment #96 from Jonathan Druart --- Created attachment 76190 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76190=edit Bug 17602: Removed unused param to RecordedBooks API -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17602] Integrate support for OneClickdigital/Recorded Books API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 --- Comment #98 from Jonathan Druart --- Created attachment 76192 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76192=edit Bug 17602: update compiled opac.css -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17602] Integrate support for OneClickdigital/Recorded Books API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 --- Comment #99 from Jonathan Druart --- Created attachment 76193 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76193=edit Bug 17602: Use Asset TT plugin and fix indentation -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17602] Integrate support for OneClickdigital/Recorded Books API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 --- Comment #95 from Jonathan Druart --- Created attachment 76189 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76189=edit Bug 17602: fix RecordedBooks results pagination -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17602] Integrate support for OneClickdigital/Recorded Books API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 --- Comment #97 from Jonathan Druart --- Created attachment 76191 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76191=edit Bug 17602: (follow-up) Adjust js paths to use version add spinner Also included recompiled version of opac.css that we forgot. Signed-off-by: Srdjan -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17602] Integrate support for OneClickdigital/Recorded Books API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 --- Comment #92 from Jonathan Druart --- Created attachment 76186 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76186=edit Bug 17602: Adapt test plan to make the tests pass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17602] Integrate support for OneClickdigital/Recorded Books API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 --- Comment #93 from Jonathan Druart --- Created attachment 76187 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76187=edit Bug 17602: Fix few minor QA issues -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17602] Integrate support for OneClickdigital/Recorded Books API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 --- Comment #88 from Jonathan Druart --- Created attachment 76182 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76182=edit Bug 17602: OPAC integration of RecordedBooks Add RecordedBooks to the users page in the public interface To Test: 1/ Apply all 3 patches 2/ Set the sysprefs to valid values (you will need a test account with RecordedBooks) 3/ Try a search 4/ Login to the OPAC, try to place a hold, or check an item out 5/ Check the opac-user page, see if your items are showing on the oneclickdigital tab Signed-off-by: Nick Clemens Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17602] Integrate support for OneClickdigital/Recorded Books API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 --- Comment #94 from Jonathan Druart --- Created attachment 76188 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76188=edit Bug 17602: Translations rework -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17602] Integrate support for OneClickdigital/Recorded Books API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 --- Comment #89 from Jonathan Druart --- Created attachment 76183 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76183=edit Bug 17602 follow-up: t/Koha_ExternalContent_RecordedBooks.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17602] Integrate support for OneClickdigital/Recorded Books API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 --- Comment #90 from Jonathan Druart --- Created attachment 76184 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76184=edit Bug 17602: Ease translation Use String.format() to make translation easier -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17602] Integrate support for OneClickdigital/Recorded Books API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 Jonathan Druart changed: What|Removed |Added Attachment #73708|0 |1 is obsolete|| Attachment #73709|0 |1 is obsolete|| Attachment #73710|0 |1 is obsolete|| Attachment #73711|0 |1 is obsolete|| Attachment #73712|0 |1 is obsolete|| Attachment #73713|0 |1 is obsolete|| Attachment #73714|0 |1 is obsolete|| Attachment #73715|0 |1 is obsolete|| Attachment #73716|0 |1 is obsolete|| Attachment #73717|0 |1 is obsolete|| Attachment #73718|0 |1 is obsolete|| Attachment #73725|0 |1 is obsolete|| --- Comment #86 from Jonathan Druart --- Created attachment 76180 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76180=edit Bug 17602: Koha::ExternalContent->koha_patron() will retutn undef rather than die if user not logged in Signed-off-by: Nick Clemens Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17602] Integrate support for OneClickdigital/Recorded Books API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 --- Comment #91 from Jonathan Druart --- Created attachment 76185 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76185=edit Bug 17602: Handle '60+' if there are more than 60 results The service returns "60+" if there are more than 60 results. Without this patch the "Found %s results in RecordedBooks collection" line is removed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17602] Integrate support for OneClickdigital/Recorded Books API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 --- Comment #87 from Jonathan Druart --- Created attachment 76181 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76181=edit Bug 17602: RecordedBooks Integration to Koha This patch introduces the required sysprefs and Koha::ExternalContent::RecordedBooks Koha::ExternalContent::RecordedBooks - a wrapper around WebService::ILS::RecordedBooks::PartnerPatron RecordedBooks* sysprefs Nothing functional to test with this patch yet. But you can run the tests that come with it t/db_dependent/Koha_ExternalContent_RecordedBooks.t Signed-off-by: Nick Clemens Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17602] Integrate support for OneClickdigital/Recorded Books API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #85 from Jonathan Druart --- 1. Maybe add a ref to OneClickdigital in the pref? "No system preferences matched your search for: OneClickdigital" (not blocking) 2. Found 241+ results in the library's RecordedBooks collection "+" ? 3. /opac-tmpl/lib/jquery/plugins/themes/classic/throbber.gif must be using [% theme %]/[% interface %] 4. In the checkout list there is a link .epub (below "downloads"), but it downloads a .acsm file (??) Is it expected? 5. expires.toLocaleString() does not work what you are expecting, the date is always displayed in the same format (do not depend on dateformat) 6. https://screenshots.firefox.com/C5OmithULkvMQtTe/catalogue.kohadev.org "Check out" and "Place hold" button are too close and not well styled (not blocking) 7. Place hold, hit cgi-bin/koha/opac-user.pl, cancel the hold. The hold is still listed (not blocking) 8. /cgi-bin/koha/opac-recordedbooks-search.pl?q=d click on an image, https://carnegiestoutia.oneclickdigital.com/#titles/9781470360603 => "Your connection is not secure", awesome... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17168] Add a command line script for updating patron category based on status
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17168 --- Comment #22 from Martin Renvoize --- As a hint at where I'm going with it.. I had to throw something together quickly for customers to satisfy GDPR https://gist.github.com/mrenvoize/a0c37b1350d1fe532143784dee124b80.. It's basically pulling out the construction of the $where and $attr 'select' clause that I'm looking to put in a `filter_by` method -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17168] Add a command line script for updating patron category based on status
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17168 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com --- Comment #21 from Martin Renvoize --- I intend on writing a much more generic 'filter_by' method for the Koha::Patrons class which could easily be shared between bulk deletions, bulk anonymizations and this bulk category change enhancement along with some others down the line.. it seems somewhat crazy to add a method for each type of filtering (feels like we're backing ourselves into the same position we ended up in C4).. I'll submit that against bug 11983 which I've adopted.. and likely build a small tree of bugs hanging off it that could use this.. Obviously this is just my opinionated ramblings, but thought it worth highlighting the intention to write similar code. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20966] Add column configuration to table of orders in a basket
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20966 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Small patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20966] Add column configuration to table of orders in a basket
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20966 --- Comment #1 from Owen Leonard --- Created attachment 76179 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76179=edit Bug 20966: Add column configuration to table of orders in a basket This patch adds column configuration to the table of orders in a basket. It replaces the "Show all details" checkbox which previously was used to show the hidden "tax included" columns. Now those columns are hidden by default in the columns configuration file. To test, apply the patch and view a basket with multiple orders. Test all DataTables functionality (paging, sorting, filtering) including showing and hiding columns. Test with both an open and a closed basket. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20966] New: Add column configuration to table of orders in a basket
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20966 Bug ID: 20966 Summary: Add column configuration to table of orders in a basket Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org I think we should remove the "show all details" checkbox from acqui/basket.pl and replace it with DataTables column configuration. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570
--- Comment #79 from Jonathan Druart
---
Some more QA comments, I have not checked if previous requests have been
addressed.
1. Bug - add or edit a patron and add 2 fathers, one from an existing patron
and the other not. Only 1 is saved.
2. On the edit patron view, the "Delete" checkbox does not have the correct
label (i.e. when you click on it, it will not check/uncheck the checkbox).
(related to comment 52, 2/)
3.
a. It is not clear to me why you removed the contact* fields from the borrowers
table. It looks like they were also used when no guarantor existed.
b. Moreover `git grep contactfirstname|grep -v altcontactfirstname` returns
occurrences that should be removed (if we really want to remove them)
c. The fields are not removed from borrowermodification and deletedborrowers
(from the atomic update)
d. IMPORTANT - Should not we finally keep these fields and force the guarantors
to be existing patrons? We could have only 1 "contact" and several guarantors.
It seems that it will simplify a lot the code (for instance
Koha::Patron->guarantors would return Koha::Patrons, and
Koha::Patron::Relationship[s] would stay simple Koha::Object[s])
4. Should not the table name "relationships" be more specific?
("borrower_relationships"?)
5. add_guarantors should be moved to Koha::Patron
6. Koha::Patron->siblings is weird, we should not need to refetch the patron
list.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20947] Navigating to moremember.pl for a patron who has fines on deleted items causes software error.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20947 Nick Clemens changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME --- Comment #6 from Nick Clemens --- (In reply to Jonathan Druart from comment #5) > It's not a new constraint, no idea how it could be possible. We suspect these sites were either original liblime dbs or created using outdated info. Closing this bug out as it shouldn't occur without bad tables -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20943] Cannot enable shibboleth and LDAP at the same time
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20943 --- Comment #2 from Nick Clemens --- (In reply to Katrin Fischer from comment #1) > Interesting. Has that changed in recent versions? We have a library using > Shibboleth and LDAP with 16.11 It may be specific to the LDAP setup with 'auth_by_bind' activated - I think we are seeing the connection refused so login failed as we don't have good user/pass info for auth_by_bind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20906] Fix Debian 9 Test Failures
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20906 Tomás Cohen Arazi changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |tomasco...@gmail.com |y.org | Status|Signed Off |Passed QA --- Comment #13 from Tomás Cohen Arazi --- This is simple enough to skip other QA step. It was written by two QA team members... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20891] Lists in staff don't load when \ was used in the description
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20891 --- Comment #11 from Katrin Fischer --- The number of patrons in this libraries is so big that the answer is cut off in the developer tools in the browser... so you have to page until you can limit it to the right 'area'. I am open for ideas ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Séverine Queune changed: What|Removed |Added CC||severine.que...@bulac.fr -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20898] Replace OPAC detail's results browser with non-JavaScript version
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20898 Séverine Queune changed: What|Removed |Added CC||severine.que...@bulac.fr -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20959] Style checkin form more like the checkout form, with collapsed settings panel
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20959 Séverine Queune changed: What|Removed |Added CC||severine.que...@bulac.fr -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20935] Redesign system preferences interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935 Séverine Queune changed: What|Removed |Added CC||severine.que...@bulac.fr -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20810] Add filters and links in basketgroups page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20810 Séverine Queune changed: What|Removed |Added CC||severine.que...@bulac.fr -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20809] Link patron image to patron image add/edit form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20809 Séverine Queune changed: What|Removed |Added CC||severine.que...@bulac.fr -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11375] Improve patrons permissions display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11375 Séverine Queune changed: What|Removed |Added CC||severine.que...@bulac.fr -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20961] cn_sort for DDC callnumbers should between 1 and 99 should be formatted as 001.* - 099.*
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20961 --- Comment #2 from Barton Chittenden --- (In reply to Martin Renvoize from comment #1) > Given the conversation that took place in that email thread, do we actually > need to add a new sort class for this rather than changing the existing > one's behaviour to give the least surprise to users? Or perhaps create a > new UDC.pm class which is simply a copy of the current Dewey one before > altering the behaviour of Dewey at the very least? > > Universal Decimal Classification / UDC being effectively what the current > Dewey.pm acts correctly for UDC sorting... I think the second option -- - Create a UDC cn_source / UDC.pm that retains the current behavior of Dewey.pm - Update Dewey.pm to 0-pad the digits before the decimal point is the way to go, although this will require some care, because cn_source is used widely in Koha -- there are tests for 'ddc' in xslt files, Koha/EDI.pm, and C4/Labels/Label.pm. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20906] Fix Debian 9 Test Failures
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20906 Tomás Cohen Arazi changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20906] Fix Debian 9 Test Failures
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20906 Tomás Cohen Arazi changed: What|Removed |Added Attachment #75916|0 |1 is obsolete|| --- Comment #9 from Tomás Cohen Arazi --- Created attachment 76175 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76175=edit Bug 20906: Prevent test failures due to precision changes Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19617] Allow 'writeoff of selected'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19617 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Patch doesn't apply CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #6 from Jonathan Druart --- CONFLICT (content): Merge conflict in members/pay.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11897] Stock Rotation for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Needs Signoff --- Comment #263 from Martin Renvoize --- The whole set should apply atop master. I have two sets of customers currently testing and feeding back on it and hope to add them as signoffs once they're happy. But a further SO would be great if I can find someone to do it.. In the meantime I'd be interested in some QA/Const cutive Critisism on the Cron script as that was somewhat rush changed to try and make it for 18.05. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20906] Fix Debian 9 Test Failures
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20906 Tomás Cohen Arazi changed: What|Removed |Added Attachment #75929|0 |1 is obsolete|| --- Comment #12 from Tomás Cohen Arazi --- Created attachment 76178 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76178=edit Bug 20906: Fix translatable-templates.t From Jenkins: koha_1 | # Failed test 'staff_prog templates are translatable' koha_1 | # at xt/author/translatable-templates.t line 87. koha_1 | # Can't locate TmplTokenizer.pm in @INC (you may need to install the TmplTokenizer module) (@INC contains: /kohadevbox/koha /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.24.1 /usr/local/share/perl/5.24.1 /usr/lib/x86_64-linux-gnu/perl5/5.24 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl/5.24 /usr/share/perl/5.24 /usr/local/lib/site_perl /usr/lib/x86_64-linux-gnu/perl-base) at ./tmpl_process3.pl line 20. On Stretch, '.' is not longer added to @INC, see bug 17717 for more info Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20906] Fix Debian 9 Test Failures
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20906 Tomás Cohen Arazi changed: What|Removed |Added Attachment #75921|0 |1 is obsolete|| --- Comment #11 from Tomás Cohen Arazi --- Created attachment 76177 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76177=edit Bug 20906: Prevent test failures due to precision changes (2) Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20906] Fix Debian 9 Test Failures
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20906 Tomás Cohen Arazi changed: What|Removed |Added Attachment #75920|0 |1 is obsolete|| --- Comment #10 from Tomás Cohen Arazi --- Created attachment 76176 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76176=edit Bug 20906: Prevent test failures due to stricter perl Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20947] Navigating to moremember.pl for a patron who has fines on deleted items causes software error.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20947 --- Comment #5 from Jonathan Druart --- It's not a new constraint, no idea how it could be possible. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20947] Navigating to moremember.pl for a patron who has fines on deleted items causes software error.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20947 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com --- Comment #4 from Nick Clemens --- (In reply to Jonathan Druart from comment #3) > Could you confirm the FK is missing? Indeed, the foreign key appears to be missing on the affected site -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19482] Elasticsearch - prevent removal / editing of required indexes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19482 Alex Arnaud changed: What|Removed |Added Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19482] Elasticsearch - prevent removal / editing of required indexes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19482
--- Comment #16 from Alex Arnaud ---
Comment on attachment 72879
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72879
Bug 19482 - Add support for defining 'mandatory' mappings
Review of attachment 72879:
-->
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=19482=72879)
-
::: Koha/SearchEngine/Elasticsearch.pm
@@ +286,5 @@
> while ( my ( $field_name, $data ) = each %$fields ) {
> my $field_type = $data->{type};
> my $field_label = $data->{label};
> +my $field_mandatory = $data->{mandatory};
> +warn $field_mandatory;
Debug thing?
:::
koha-tmpl/intranet-tmpl/prog/en/modules/admin/searchengine/elasticsearch/mappings.tt
@@ +143,3 @@
>
> +[% IF is_readonly %]
> + value="[% search_field.type FILTER ucfirst%]" [% is_readonly %] />
Maybe this readonly input should be sized? This cause the input is larger than
the selects and so expand the "Type" column. Or maybe use a as
suggested by David
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19482] Elasticsearch - prevent removal / editing of required indexes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19482 Alex Arnaud changed: What|Removed |Added CC||alex.arn...@biblibre.com QA Contact||alex.arn...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20965] Batch patron anonymization logic is flawed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20965 Janet McGowan changed: What|Removed |Added CC||janet.mcgowan@ptfs-europe.c ||om -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20794] Don't show holds tab when user doesn't have circulate_remaining_permissions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20794 Jonathan Druart changed: What|Removed |Added Severity|minor |normal -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20794] Don't show holds tab when user doesn't have circulate_remaining_permissions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20794 Jonathan Druart changed: What|Removed |Added Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20794] Don't show holds tab when user doesn't have circulate_remaining_permissions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20794 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20794] Don't show holds tab when user doesn't have circulate_remaining_permissions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20794 Jonathan Druart changed: What|Removed |Added Attachment #75944|0 |1 is obsolete|| --- Comment #4 from Jonathan Druart --- Created attachment 76174 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76174=edit Bug 20794: Hide holds tab on details when user lacks circulate_remaining_permissions If a user doesn't have circulate_remaining permissions, but has borrowers: - checkouts tab is hidden - details tab is visible - holds tab on details is visible, but results in an error The problem is that the svc/holds script requires circulate_remaining_permissions. To test: - Create 2 staff users with and without circulate_remaining_permissions Both need borrowers permission - Go to the details tab in a patron's account who has holds - Verify that you get a datatables error for the staff patron without circulate_remaining_permissions - Apply patch - Verify that now the holds tab is no longer displayed for this patron Signed-off-by: Amit Gupta Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20794] Don't show holds tab when user doesn't have circulate_remaining_permissions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20794 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #3 from Jonathan Druart --- I have no idea if the permissions are ok but this patch makes sense as a quick fix at least. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20891] Lists in staff don't load when \ was used in the description
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20891 --- Comment #10 from Jonathan Druart --- (In reply to Katrin Fischer from comment #9) > (In reply to Jonathan Druart from comment #8) > > (In reply to Katrin Fischer from comment #7) > > > I think we had similar problems on patron search - anything we could pick > > > from there? > > > > We are using the same code for lists and patrons, so I supposed patron's > > result will explode if '\' is contained in the surname/firstname, which > > certainly does not exist in a production DB :) > > Actually, we had a lot of issues with patron search on migrating a lot of > libraries recently. You never know what is in the data you get and it's hard > to debug the JSON errors in some cases. open the web dev console, get the answer from the server, copy/paste it on a JSON validator website, and you will know exactly where the problem is. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20965] Batch patron anonymization logic is flawed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20965 --- Comment #1 from Martin Renvoize --- I think the feature should allow the Patron selection (for deletion or anonymization) in a first step (and filtering by branch should be te patrons home branch, not where the issues happened) and then proceed to a second step where you can select whether all issues (before the previously selected date) are anonymised regardless of checkout branch or whether the issues should be limited to the selected branch.. I'm not even sure if/when the second step would ever be required? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19502] Result sets limited to 10000
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19502 --- Comment #8 from Alex Arnaud --- Comment on attachment 74587 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74587 Bug 19520: (follow-up) Pass parameters to avoid making templates depend on search engine Review of attachment 74587: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=19502=74587) - ::: catalogue/search.pl @@ +677,4 @@ > last_page_offset => $last_page_offset, > previous_page_offset => > $previous_page_offset) unless $pages < 2; > $template->param( next_page_offset => $next_page_offset) > unless $pages eq $current_page_number; > +warn "topage $hits_to_paginate"; Debug thing ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11897] Stock Rotation for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 --- Comment #262 from Jonathan Druart --- (In reply to Martin Renvoize from comment #260) > Fully rebased and taken account of a few pieces of customer feedback in the > followups. Do they test on top of master? Should not we add their signed-off-by lines? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20650] Switch single-column templates to Bootstrap grid: Various, part 3
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20650 --- Comment #8 from Jonathan Druart --- Created attachment 76172 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76172=edit Bug 20650: (follow-up) Add missing include file This patch adds a missing include of doc-head-open.inc. To test, apply the patch and export a batch of patron cards. The modal view for downloading the card batch PDF should work correctly. Validating the iframe's source should show no relevant errors. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20650] Switch single-column templates to Bootstrap grid: Various, part 3
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20650 Jonathan Druart changed: What|Removed |Added Attachment #75301|0 |1 is obsolete|| Attachment #76170|0 |1 is obsolete|| --- Comment #7 from Jonathan Druart --- Created attachment 76171 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76171=edit Bug 20650: Switch single-column templates to Bootstrap grid: Various, part 3 This patch updates various unrelated templates to use the Bootstrap grid. In each case, confirm that the indicated page looks correct. This patch also corrects a couple of capitalization errors and removes an unused template: virtualshelves/merge.tt. - Tools -> Patron card creator -> Manage -> Card batches - Export a batch - The pages inside the modal window should look correct: Both the "X batch(es) to export" screen and the "download exported batch(es)" one. - Tools -> Patron lists -> Edit list - The patron list add/edit form should look correct. - Disable plugins in koha-conf.xml. - Tools -> Plugins - The "Plugins disabled" page should look correct. - Enable plugins in koha-conf.xml - Tools -> Plugins -> Upload plugins. - This page should look correct. - Tools - The tools home page should show three columns: Patrons and Circulation, Catalog, Additional tools. - At viewport width below 768 pixels content should reflow into one column. - virtualshelves/merge.tt has been removed as it is unused. Search the codebase for references to it. There should be none. Signed-off-by: Claire Gravely Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20650] Switch single-column templates to Bootstrap grid: Various, part 3
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20650 --- Comment #9 from Jonathan Druart --- Created attachment 76173 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76173=edit Bug 20650: Remove unused virtualshelves/merge.tt Committed by Jonathan Druart, get out from first patch of this patchset. It's a follow-up of bug 4019 which removed virtualshelves/merge.pl Moving this change to its own commit to make it clear in the git log and easier to backport if needed. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20650] Switch single-column templates to Bootstrap grid: Various, part 3
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20650 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 --- Comment #55 from Fridolin SOMERS --- Oups, looks like patch makes a lot of unwanted changes in koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20965] New: Batch patron anonymization logic is flawed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20965 Bug ID: 20965 Summary: Batch patron anonymization logic is flawed Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvo...@ptfs-europe.com QA Contact: testo...@bugs.koha-community.org There are two issues here: 1) The tool suggests you can limit by library and checkout date but in fact, the library is not the patrons' library but the library the items were issued at. This is not clear from the UI. 2) When it comes to the actual anonymisation, although we've got a filtered list of Patrons by issues before X and at Library, we then delete ALL issues before X by any of the Patrons selected by the previous query, regardless of which library the checkout took place and thus we ignore the selected Library. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20965] Batch patron anonymization logic is flawed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20965 Martin Renvoize changed: What|Removed |Added Priority|P5 - low|P3 Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20891] Lists in staff don't load when \ was used in the description
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20891 --- Comment #9 from Katrin Fischer --- (In reply to Jonathan Druart from comment #8) > (In reply to Katrin Fischer from comment #7) > > I think we had similar problems on patron search - anything we could pick > > from there? > > We are using the same code for lists and patrons, so I supposed patron's > result will explode if '\' is contained in the surname/firstname, which > certainly does not exist in a production DB :) Actually, we had a lot of issues with patron search on migrating a lot of libraries recently. You never know what is in the data you get and it's hard to debug the JSON errors in some cases. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20891] Lists in staff don't load when \ was used in the description
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20891 --- Comment #8 from Jonathan Druart --- (In reply to Katrin Fischer from comment #7) > I think we had similar problems on patron search - anything we could pick > from there? We are using the same code for lists and patrons, so I supposed patron's result will explode if '\' is contained in the surname/firstname, which certainly does not exist in a production DB :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20650] Switch single-column templates to Bootstrap grid: Various, part 3
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20650 --- Comment #6 from Owen Leonard --- Created attachment 76170 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76170=edit Bug 20650: (follow-up) Add missing include file This patch adds a missing include of doc-head-open.inc. To test, apply the patch and export a batch of patron cards. The modal view for downloading the card batch PDF should work correctly. Validating the iframe's source should show no relevant errors. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20963] Can check out not for loan items when temporarily overriding restriction
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20963
Jonathan Druart changed:
What|Removed |Added
CC||jonathan.dru...@bugs.koha-c
||ommunity.org
--- Comment #1 from Jonathan Druart
---
This sounds like a long standing bug.
It will be hard to deal with that bug, the permission { circulate =>
force_checkout } allows to force the checkout if the patron has a restriction.
When the forceallow flag is set, all other Allow*Override prefs are bypassed.
I guess we should deal with the permissions differently than the Allow*Override
prefs.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20813] Revamp user permissions system
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20813 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply --- Comment #6 from Owen Leonard --- I'm changing this to "patch doesn't apply" because the attached patch didn't work correctly and Kyle said it was probably a rebase issue. I'm not comfortable signing off based on the original code because of how behind master it is. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20964] search_patrons_to_anonymise selects different user than GetBorrowersWithIssuesHistoryOlderThan did.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20964 Martin Renvoize changed: What|Removed |Added Resolution|--- |INVALID Status|Needs Signoff |RESOLVED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20921] Expose borrowernumber and branch when user is logged in to OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20921 --- Comment #5 from Owen Leonard --- (In reply to paxed from comment #3) > Custom HTML attributes should be prefixed with "data-" (as per the HTML5 > spec) I agree with this. I think it makes sense to add data- attributes for branch and borrowernumber even with the branch information in a class. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
