[Koha-bugs] [Bug 21150] Data inconsistencies - item types

2018-08-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21150

Mason James  changed:

   What|Removed |Added

 CC||m...@kohaaloha.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18547] On shelf holds allowed > "If all unavailable" ignores default hold policy

2018-08-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18547

--- Comment #24 from Jonathan Druart  
---
Comment on attachment 69126
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69126
Bug 18547 - On shelf holds allowed > "If all unavailable" ignores default hold
policy

Review of attachment 69126:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=18547=69126)
-

::: C4/Reserves.pm
@@ +1161,5 @@
>  
>  foreach my $i (@items) {
> +
> +my $circ_control_branch = 
> C4::Circulation::_GetCircControlBranch( $i->unblessed(), $borrower );
> +my $branchitemrule = C4::Circulation::GetBranchItemRule( 
> $circ_control_branch, $i->itype );

Hum, should not $i->itype be $i->effective_itemtype?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21167] Printing fines on patron account tab -- amounts ending in 0 are truncated.

2018-08-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21167

--- Comment #1 from Barton Chittenden  ---
Created attachment 77518
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77518=edit
Screenshot from Home › Patrons › Account

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 21167] New: Printing fines on patron account tab -- amounts ending in 0 are truncated.

2018-08-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21167

Bug ID: 21167
   Summary: Printing fines on patron account tab -- amounts ending
in 0 are truncated.
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Fines and fees
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: bar...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

To re-create:

create a fine or a fee of 5.00.

Go to Home › Patrons › Account

Click the print button.

The line that says 'Payment, thanks' has an amount of '5' rather than '5.00'

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20970] Reformat basket information on acquisitions basket page

2018-08-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20970

Caroline Cyr La Rose  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #5 from Caroline Cyr La Rose  ---
The patch applies fine now. Everything works as advertised.

That might be beyond your remodeling changes, but maybe we could ditch the
"Save changes" button when adding/deleting users? It would save a click
(hehe!), and I don't find it super intuitive to have to save once the user
appears on the page. When deleting a user, I get that you need a confirmation
so that people don't delete users by accident, but even then, I don't find
"Save changes" intuitive. And also, if I make a change without saving, and
leave the page, there is no warning that I'm leaving unsaved changes (like in
the system preferences pages, for example).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21150] Data inconsistencies - item types

2018-08-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21150

Jonathan Druart  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=20855

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20855] transferstoreceive.pl returns internal server error

2018-08-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20855

Jonathan Druart  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=21150

--- Comment #6 from Jonathan Druart  
---
Paul, Do you agree that it's a data inconsistency you should fix on your side?
See bug 21150.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15184] Ability to duplicate existing order lines to a given basket

2018-08-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184

--- Comment #16 from Jonathan Druart  
---
Created attachment 77517
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77517=edit
Bug 15184: Add users ?

We certainly do not want this patch. What about users that are notified
on receiving?

Sponsored-by: BULAC - http://www.bulac.fr/

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15184] Ability to duplicate existing order lines to a given basket

2018-08-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184

--- Comment #14 from Jonathan Druart  
---
Created attachment 77515
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77515=edit
Bug 15184: Add the ordernumbers filters to GetHistory

It adds the ability to return the result of GetHistory given a list a
ordernumbers

Sponsored-by: BULAC - http://www.bulac.fr/

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15184] Ability to duplicate existing order lines to a given basket

2018-08-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184

--- Comment #15 from Jonathan Druart  
---
Created attachment 77516
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77516=edit
Bug 15184: Add the ability to duplicate existing order lines

This patchset adds the ability to duplicate existing order lines to a
given basket. It will help acquisitions of serials of when the same
publication is ordered frequently.

The workflow will be:
- Create a new basket
- Use the "Add to basket" button
- Select the new entry "From existing orders (copy)"
- Search and select the order you want to duplicate
- Define some default values for these orders
- Duplicate!

Sponsored-by: BULAC - http://www.bulac.fr/

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15184] Ability to duplicate existing order lines to a given basket

2018-08-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184

--- Comment #13 from Jonathan Druart  
---
Created attachment 77514
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77514=edit
Bug 15184: Prepare the ground - Move funds and sort fields autoupdate

We are going to reuse the same logic: when a fund is selected the
statistic values are automatically updated.
Let move it to make it reusable more easily and isolate the code.

Sponsored-by: BULAC - http://www.bulac.fr/

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15184] Ability to duplicate existing order lines to a given basket

2018-08-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #77314|0   |1
is obsolete||
  Attachment #77315|0   |1
is obsolete||
  Attachment #77316|0   |1
is obsolete||
  Attachment #77317|0   |1
is obsolete||
  Attachment #77318|0   |1
is obsolete||

--- Comment #12 from Jonathan Druart  
---
Created attachment 77513
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77513=edit
Bug 15184: Prepare the ground - Move order search filters

We are going to reuse these filters so we move it to a separate include
file.

Sponsored-by: BULAC - http://www.bulac.fr/

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21166] Add columns settings to the acquisition details table (record detail view)

2018-08-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21166

--- Comment #1 from Jonathan Druart  
---
Created attachment 77512
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77512=edit
Bug 21166: Add column settings to the acquisition table on bib detail

Sponsored-by: BULAC - http://www.bulac.fr/

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21166] Add columns settings to the acquisition details table (record detail view)

2018-08-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21166

Jonathan Druart  changed:

   What|Removed |Added

  Change sponsored?|--- |Sponsored

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21166] Add columns settings to the acquisition details table (record detail view)

2018-08-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21166

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21166] Add columns settings to the acquisition details table (record detail view)

2018-08-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21166

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||20366


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20366
[Bug 20366] More information about orders linked to subscriptions on
"Acquisition details" tab
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20366] More information about orders linked to subscriptions on "Acquisition details" tab

2018-08-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20366

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||21166

--- Comment #25 from Jonathan Druart  
---
(In reply to Jonathan Druart from comment #4)
> TODO: Add column settings (show/hide columns) to this table (?)

See bug 21166


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21166
[Bug 21166] Add columns settings to the acquisition details table (record
detail view)
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21166] New: Add columns settings to the acquisition details table (record detail view)

2018-08-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21166

Bug ID: 21166
   Summary: Add columns settings to the acquisition details table
(record detail view)
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Templates
  Assignee: jonathan.dru...@bugs.koha-community.org
  Reporter: jonathan.dru...@bugs.koha-community.org
QA Contact: testo...@bugs.koha-community.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20366] More information about orders linked to subscriptions on "Acquisition details" tab

2018-08-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20366

--- Comment #23 from Jonathan Druart  
---
Created attachment 77510
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77510=edit
Bug 20366: Add subscription info to the acq tab on the biblio detail page

On the "Acquisition details" tab of the bibliographic detail page, the
subscription information are missing.
This patch replace the call to GetHistory with Koha::Acquisition::Orders
in order to simplify the code and make use of new Koha::
packages/methods.

TODO: Add column settings (show/hide columns) to this table (?)

Sponsored-by: BULAC - http://www.bulac.fr/

Signed-off-by: Josef Moravec 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20366] More information about orders linked to subscriptions on "Acquisition details" tab

2018-08-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20366

--- Comment #24 from Jonathan Druart  
---
Created attachment 77511
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77511=edit
Bug 20366: (follow-up) Fix link to subscription

Sponsored-by: BULAC - http://www.bulac.fr/

Signed-off-by: Josef Moravec 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20366] More information about orders linked to subscriptions on "Acquisition details" tab

2018-08-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20366

--- Comment #22 from Jonathan Druart  
---
Created attachment 77509
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77509=edit
Bug 20366: Add new method Koha::Acquisition::Basket->basket_group

Can be moved to a separate bug report.

Sponsored-by: BULAC - http://www.bulac.fr/

Signed-off-by: Josef Moravec 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20366] More information about orders linked to subscriptions on "Acquisition details" tab

2018-08-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20366

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #77452|0   |1
is obsolete||
  Attachment #77453|0   |1
is obsolete||
  Attachment #77454|0   |1
is obsolete||
  Attachment #77455|0   |1
is obsolete||

--- Comment #21 from Jonathan Druart  
---
Created attachment 77508
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77508=edit
Bug 20366: Add new method Koha::Acquisition::Order->subscription

Can be moved to a separate bug report.

Sponsored-by: BULAC - http://www.bulac.fr/

Signed-off-by: Josef Moravec 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20962] Overhaul to notices

2018-08-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20962

Barton Chittenden  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=21165

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21165] Notice Module governs fields available in letter.pl, but this often doesn't fit letter.code

2018-08-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21165

Barton Chittenden  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=20962

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20365] Allow several open orders on subscription

2018-08-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20365

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #77437|0   |1
is obsolete||

--- Comment #12 from Jonathan Druart  
---
Created attachment 77507
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77507=edit
Bug 20365: Allow several orders on the same subscriptions

Do we really need this limitation?

Sponsored-by: BULAC - http://www.bulac.fr/

Signed-off-by: Séverine QUEUNE 

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20726] Display acquisition details on the subscription detail page

2018-08-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20726

--- Comment #42 from Jonathan Druart  
---
Created attachment 77504
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77504=edit
Bug 20726: Add show/hide already received orders links

Sponsored-by: BULAC - http://www.bulac.fr/

Signed-off-by: Séverine QUEUNE 

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20726] Display acquisition details on the subscription detail page

2018-08-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20726

--- Comment #43 from Jonathan Druart  
---
Created attachment 77505
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77505=edit
Bug 20726: Sort by statuses then ordernumbers

Not received and most recent at the top.

Sponsored-by: BULAC - http://www.bulac.fr/

Signed-off-by: Séverine QUEUNE 

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20726] Display acquisition details on the subscription detail page

2018-08-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20726

--- Comment #44 from Jonathan Druart  
---
Created attachment 77506
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77506=edit
Bug 20726: Add title to the price column headers

Sponsored-by: BULAC - http://www.bulac.fr/

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20726] Display acquisition details on the subscription detail page

2018-08-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20726

--- Comment #41 from Jonathan Druart  
---
Created attachment 77503
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77503=edit
Bug 20726: Add DataTables

Sponsored-by: BULAC - http://www.bulac.fr/

Signed-off-by: Séverine QUEUNE 

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20726] Display acquisition details on the subscription detail page

2018-08-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20726

--- Comment #39 from Jonathan Druart  
---
Created attachment 77501
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77501=edit
Bug 20726: Add new method Acquisition::Order->invoice

Can be moved to a separate bug report.

Sponsored-by: BULAC - http://www.bulac.fr/

Signed-off-by: Séverine QUEUNE 

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20726] Display acquisition details on the subscription detail page

2018-08-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20726

--- Comment #40 from Jonathan Druart  
---
Created attachment 77502
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77502=edit
Bug 20726: Add acquisition history on the subscription detail page

Since bug 20365 is going to add the ability to create several pending orders on
the same subscription we should display the history of the acquisitions on the
subscription detail page.

Sponsored-by: BULAC - http://www.bulac.fr/

Signed-off-by: Séverine QUEUNE 

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20726] Display acquisition details on the subscription detail page

2018-08-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20726

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #77428|0   |1
is obsolete||
  Attachment #77429|0   |1
is obsolete||
  Attachment #77430|0   |1
is obsolete||
  Attachment #77431|0   |1
is obsolete||
  Attachment #77432|0   |1
is obsolete||
  Attachment #77433|0   |1
is obsolete||
  Attachment #77434|0   |1
is obsolete||

--- Comment #38 from Jonathan Druart  
---
Created attachment 77500
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77500=edit
Bug 20726: Add new method Koha::Acquisition::Order->fund

Can be moved to a separate bug report.

Sponsored-by: BULAC - http://www.bulac.fr/

Signed-off-by: Séverine QUEUNE 

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 21165] Notice Module governs fields available in letter.pl, but this often doesn't fit letter.code

2018-08-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21165

--- Comment #1 from Barton Chittenden  ---
I should note that the DUEDGST and PREDUEDGST are probably the worst offenders
in terms of the available fields not fitting the notice; I think the
circulation module is the broadest, but any category that has more than one
letter code may have issues.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21165] New: Notice Module governs fields available in letter.pl, but this often doesn't fit letter.code

2018-08-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21165

Bug ID: 21165
   Summary: Notice Module governs fields available in letter.pl,
but this often doesn't fit letter.code
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Notices
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: bar...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

When or updating a new notice in Home › Tools › Notices & Slips › Modify
notice, staff can click on fields in the field list, then click 'Insert' and
the field will appear at the cursor position in the message body. So, for
example, when editing the 'DUEDGST' notice, one can select
'items.biblionumber', then click insert, and the text

<>

will appear in the body of the message.

The problem is that the available fields are selected based on letter.module.
In the case of 'DUEDGST', this will be circulation... and this does exactly the
wrong thing, because most of the fields available (items.*, biblio.*,
biblioitems.*, issue.s*) are *not* valid in DUEDGST -- only <>
<> and branches.* are valid in that notice.

Also, there are things missing that *could* be there -- for instance <>
and <>. Also, if we're going to use loops like




It should be possible to insert these from the list

As it stands, the field list is often misleading. If 'DUEDGST' *only* showed
<>, it would easier for educators to point to the field list and
as a reference. As it stands, at best, they have to qualify its usage, and at
worst, the list is actively misleading.

The list should probably be generated based on 'letter.code' -- the available
codes are best read from the call to C4::Letters::GetPreparedLetter, especially
the 'table' and 'repeat' hashrefs.

Also, as we go forward using template toolkit based notices, it would be great
if snippits of template toolkit code were available as well.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20855] transferstoreceive.pl returns internal server error

2018-08-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20855

--- Comment #5 from Paul Hoffman  ---
Sorry that my comment on the attachment was rather cryptic; this is only my
first or second bug comment.

I've upped the priority because the bug makes it impossible to view any list of
holds (using waitingreserves.pl) that includes an item with NULL itype.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20855] transferstoreceive.pl returns internal server error

2018-08-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20855

Paul Hoffman  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
   Priority|P5 - low|P2

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20855] transferstoreceive.pl returns internal server error

2018-08-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20855

Paul Hoffman  changed:

   What|Removed |Added

 CC||p...@flo.org

--- Comment #4 from Paul Hoffman  ---
Created attachment 77499
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77499=edit
Don't invoke _description_ on an undef itemtype

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20970] Reformat basket information on acquisitions basket page

2018-08-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20970

--- Comment #4 from Owen Leonard  ---
Thanks for testing Caroline. I proposed this change because I think the benefit
of a compact and (I hope) more readable display outweighs the downside of an
extra click.

I've rebased the patch. Can you try again?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20970] Reformat basket information on acquisitions basket page

2018-08-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20970

Owen Leonard  changed:

   What|Removed |Added

  Attachment #76214|0   |1
is obsolete||

--- Comment #3 from Owen Leonard  ---
Created attachment 77498
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77498=edit
Bug 20970: Reformat basket information on acquisitions basket page

This patch reformats the display of information on the acquisitions
basket page, hiding form controls until they are triggered. Some basket
information is now in the second column in order to balance the two
columns better.

The "Library" label has been replaced with the more precise "Managing
library."

Unrelated change: Removed script type attributes.

To test, apply the patch and view a basket in acquisitions. Test these
processes:

- Adding and removing managing users
- Setting and changing managing library
- Setting and changing basket group

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21141] Batch item modification tool throws error 500 when an itemnumber is invalid

2018-08-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21141

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21141] Batch item modification tool throws error 500 when an itemnumber is invalid

2018-08-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21141

--- Comment #8 from Jonathan Druart  
---
Created attachment 77497
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77497=edit
Bug 21141: Handle non-existent itemnumbers in batch item modification/deletion

The itemnumber list passed from a file in the batch item
modification/deletion tools is not tested.
Like barcodes we should make sure they refer to a valid items in the DB.

Test plan:
- Create a file with barcodes, itemnumbers and random lines
- Use the batch item modification and deletion tools with this file
You should see a table with a list of invalid barcodes and itemnumbers.

Without this patch you got the following error:
Can't call method "title" on an undefined value at
/home/vagrant/kohaclone/tools/batchMod.pl line 580

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18262] Koha::Biblios - Remove GetBiblioData - part 1

2018-08-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18262

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||21141


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21141
[Bug 21141] Batch item modification tool throws error 500 when an itemnumber is
invalid
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21141] Batch item modification tool throws error 500 when an itemnumber is invalid

2018-08-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21141

Jonathan Druart  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c
   |ity.org |ommunity.org
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
 Depends on||18262
 Status|NEW |ASSIGNED

--- Comment #7 from Jonathan Druart  
---
Caused by
  commit bd3b1c1a33e4bb14bbcd10a0fcf871b39362430d
  Bug 18262: Koha::Biblio - Remove GetBiblioData - part 1


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18262
[Bug 18262] Koha::Biblios - Remove GetBiblioData - part 1
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21164] Fix alignment on new basket form in acquisitions

2018-08-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21164

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21164] Fix alignment on new basket form in acquisitions

2018-08-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21164

--- Comment #1 from Owen Leonard  ---
Created attachment 77496
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77496=edit
Bug 21164: Fix alignment on new basket form in acquisitions

This patch removes some unnecessary ""'s from the template for
creating a new basket in acquisitions. This fixes the alignment on the
form fields.

To test, apply the patch and go to Acquisitions -> Vendor -> New basket.
All the form fields should be correctly left-aligned with each other.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21164] New: Fix alignment on new basket form in acquisitions

2018-08-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21164

Bug ID: 21164
   Summary: Fix alignment on new basket form in acquisitions
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: trivial
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org

There are some extraneous non-breaking spaces in the template for adding a new
basket in acquisitions. They're causing misalignment of the form fields.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19909] Show attributes in patron search results

2018-08-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19909

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #8 from Jonathan Druart  
---
(just linking similar stuffs -
https://gitlab.com/joubu/Koha/blob/bug_20443/Koha/Patron/Attribute.pm)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19722] Add a MaxItemsToDisplayForBatchMod preference

2018-08-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19722

Nick Clemens  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #12 from Nick Clemens  ---
You are correct, this should be updated to follow the system preference

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21132] Highlight active filters on saved report page

2018-08-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21132

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #77482|0   |1
is obsolete||

--- Comment #3 from Jonathan Druart  
---
Created attachment 77495
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77495=edit
Bug 21132: Highlight active filters on saved report page

This patch adds a more obvious way of see which search terms have been
submitted to filter the table of saved reports.

The patch also moves embedded CSS into a separate file.

To test you should have multiple saved reports.

- Apply the patch and go to Reports -> Use saved.
- Filter the table of reports by submitting one or more terms in the
  sidebar "Filter" form.
- Confirm that the terms you submit are shown at the top of the table of
  results.
- Confirm that clicking the "Clear" link clears the search filter.

Signed-off-by: Maryse Simard 
Followed the test plan and it works.

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21132] Highlight active filters on saved report page

2018-08-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21132

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21148] Dropdowns styled by the Select2 plugin do not highlight missing required fields

2018-08-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21148

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #77446|0   |1
is obsolete||

--- Comment #3 from Jonathan Druart  
---
Created attachment 77494
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77494=edit
Bug 21148: Dropdowns styled by the Select2 plugin do not highlight missing
required fields

This patch adds some CSS to target mandatory fields on the add item
screen which are styled by the Select2 plugin.

To test you must have at least one item field marked mandatory and
linked to an authorized value.

Open the add item form for an existing record. Try to submit the form
without making a selection in the mandatory dropdown. You should get an
alert warning you that you have empty mandatory fields, and the field
should be highlighted in yellow.

Signed-off-by: Katrin Fischer 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21148] Dropdowns styled by the Select2 plugin do not highlight missing required fields

2018-08-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21148

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21154] Remove unused subs from C4::Serials

2018-08-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21154

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #77480|0   |1
is obsolete||

--- Comment #3 from Jonathan Druart  
---
Created attachment 77493
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77493=edit
Bug 21154: Remove unused subs from C4::Serials

Test plan:
Run these commands, grep should not return any occurences, prove should
return green:

git grep GetSerialStatusFromSerialId
git grep GetDistributedTo
git grep SetDistributedTo
git grep SetDistributedto
git grep in_array
git grep is_barcode_in_use

kshell
prove t/db_dependent/Serials.t

Signed-off-by: Pierre-Luc Lapointe 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21154] Remove unused subs from C4::Serials

2018-08-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21154

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17047] Mana Knowledge Base : share data

2018-08-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

--- Comment #254 from Jonathan Druart  
---
- Message on the admin page - click here, then you enable, then? We should link
to a documentation page.

- log_path is not in the default yaml file or specify in any docs.
I did not manage to configure the server config file to make it work locally.
Can you share a working example please?

- What is supposed to happen when I click on "Send" in the ManaToken syspref
block? There is a wrong error handling, as my server is not setup properly, I
click and nothing happens.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17047] Mana Knowledge Base : share data

2018-08-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #253 from Jonathan Druart  
---
1. Unit tests:
[kohadev-koha@kohadevbox:/home/vagrant/kohaclone (BZ17047_s) ✹ ✭]% prove -r
t/db_dependent/Koha/SharedContent.t t/db_dependent/Koha/Subscription*
t/db_dependent/Serial*
t/db_dependent/Koha/SharedContent.t  Name
"Koha::SharedContent::MANA_IP" used only once: possible typo at
t/db_dependent/Koha/SharedContent.t line 44.

t/db_dependent/Koha/Subscription.t . "my" variable $builder
masks earlier declaration in same scope at t/db_dependent/Koha/Subscription.t
line 38.
t/db_dependent/Koha/Subscription.t . 1/9 Can't call method
"biblionumber" on an undefined value at
/home/vagrant/kohaclone/Koha/Subscription.pm line 143.
# Looks like your test exited with 255 just after 8.
t/db_dependent/Koha/Subscription.t . Dubious, test returned 255
(wstat 65280, 0xff00)
Failed 1/9 subtests 

t/db_dependent/Serials/ReNewSubscription.t . Undefined subroutine
::SharedContent::manaGetRequestWithId called at
/home/vagrant/kohaclone/C4/Serials.pm line 303.


2. QA script:

 FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt
   FAIL   forbidden patterns
forbidden pattern: Do *not* include full path to js files, use
the Asset TT plugin (bug 20538) (line 196)
forbidden pattern: intranet-tmpl should certainly replaced with
[% interface %] (line 196)


 FAIL   t/db_dependent/Koha/SharedContent.t
   FAIL   valid
Name "Koha::SharedContent::MANA_IP" used only once: possible
typo 

 FAIL   t/db_dependent/Koha/Subscription.t
   FAIL   valid
"my" variable $builder masks earlier declaration in same scope 


About MANA_IP, you should move it to a Koha::SharedContent method. It would be
the only way to retrieve mana_config from the config.
It will help to handle non-existent/invalid entry. Moreover I think we should
avoid having config at package level (because of usage of Memcached and Plack).
It will be easy to mock with mock_config.

3. There is a CamelCase/snake_case mix in method's names

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 21163] Basket group detail page layout is broken

2018-08-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21163

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #77489|0   |1
is obsolete||

--- Comment #4 from Jonathan Druart  
---
Created attachment 77492
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77492=edit
Bug 21163: Basket group detail page layout is broken

This fixes a problem with layout of the page when viewing a closed
basket group. Changed the grid options for basket information when a
basket group is closed.

To test, apply the patch and go to Acquisitions -> Vendor -> Basket
groups. You should have multiple baskets and basket groups to test with.

- Edit an open basket group. The layout should look correct, with basket
  group information in the form in the left column and ungrouped basket
  in the right column. Grouping and ungrouping baskets should work
  correctly.
- View a closed basket group. The basket group information should
  display in a single column that spans the main part of the page.

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21163] Basket group detail page layout is broken

2018-08-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21163

Jonathan Druart  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21163] Basket group detail page layout is broken

2018-08-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21163

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||20667


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20667
[Bug 20667] Update two-column templates with Bootstrap grid: Acquisitions part
1
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20667] Update two-column templates with Bootstrap grid: Acquisitions part 1

2018-08-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20667

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||21163


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21163
[Bug 21163] Basket group detail page layout is broken
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21028] www/history.t is failing on jenkins for Ubuntu 18.04

2018-08-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21028

Jonathan Druart  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #10 from Jonathan Druart  
---
We did not find the real cause of this issue, but it has been "fixed"
(workarounded) at koha-testing-docker level, see
https://gitlab.com/koha-community/koha-testing-docker/merge_requests/77

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14662] Allow blank values in pull downs in cataloguing forms when subfield is mandatory

2018-08-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14662

--- Comment #14 from Jonathan Druart  
---
Created attachment 77491
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77491=edit
Bug 14662: Add empty entries to pull downs in cataloguing form for mandatory
subfields

First patch deals with the problem on the item form, this
patch fixes the same problem on catalouging form for the
bibliographic record.

To test:
- Adapt your frameworks:
  - Make sure 942$c is mandatory
  - Link another field to an authorised value, for example: 942$n to YESNO
- Add a new record
  - Verify that the first value of each pull down is preselected,
there is no way to trigger the 'required' error
- Apply patch
  - Add a record
- Verify that classification source is preselected according to the
  DefaultClassificationSource system preference
- Verify that 942$c now defaults to empty
- Verify all your other mandatory subfields can be set to empty
- Verify that you can't save before correctly setting them
  - Chane your frameworks
- Add a default value for 942$c, for example: CF
  - Add another record
- Verify the itemtype is now preset to your default itemtype
  - Edit an existing record, verify all values show correctly

Signed-off-by: Owen Leonard 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14662] Allow blank values in pull downs in cataloguing forms when subfield is mandatory

2018-08-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14662

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #77443|0   |1
is obsolete||
  Attachment #77445|0   |1
is obsolete||

--- Comment #13 from Jonathan Druart  
---
Created attachment 77490
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77490=edit
Bug 14662: Add empty entries to pull downs on item form for mandatory subfields

The code assumed that if a subfield is marked as mandatory, there should be no
empty entry in the pull downs.

This assumption is not correct, as it leads to the first entry of the
pull down being preselected if there is no default set. Which means you
will never be alerted of any cataloguing errors and errors will be very
hard to find later on.

Correct behaviour would be to preselect the empty value when there is
no default. This means on saving the item an error message is triggered
and the cataloger is forced to set the value.

To test:
- Adapt your frameworks:
  - Make 942$c non-mandatory
  - In 952 make itemtype, classification source and some other pull downs
like location or collection mandatory
- Add a new item
  - Verify that the first value of each pull down is preselected,
there is no way to trigger the 'required' error
- Apply patch
  - Add a new item
- Verify that classification source is preselected according to the
  DefaultClassificationSource system preference
- Verify that the itemtype is preselected according to 942$c in
  the bibliographic record
- Verify all mandatory fields can be set to empty
- Verify that you can't save before correctly setting them
  - Change the 942$c in the record to empty
  - Add another item
- Verify the itemtype is now empty
  - Change your frameworks and set a default for itemtype (Ex: BK)
  - Repeat default check with another pull down like collection or location

Signed-off-by: Owen Leonard 

Signed-off-by: Jonathan Druart 
We do not want empty values for branches (holdingbranch and homebranch
must be mandatory, see bug 21011)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14662] Allow blank values in pull downs in cataloguing forms when subfield is mandatory

2018-08-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14662

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21163] Basket group detail page layout is broken

2018-08-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21163

--- Comment #3 from Owen Leonard  ---
Created attachment 77489
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77489=edit
Bug 21163: Basket group detail page layout is broken

This fixes a problem with layout of the page when viewing a closed
basket group. Changed the grid options for basket information when a
basket group is closed.

To test, apply the patch and go to Acquisitions -> Vendor -> Basket
groups. You should have multiple baskets and basket groups to test with.

- Edit an open basket group. The layout should look correct, with basket
  group information in the form in the left column and ungrouped basket
  in the right column. Grouping and ungrouping baskets should work
  correctly.
- View a closed basket group. The basket group information should
  display in a single column that spans the main part of the page.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21163] Basket group detail page layout is broken

2018-08-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21163

Owen Leonard  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20469] Add item status to staff article requests form

2018-08-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469

--- Comment #25 from Martin Renvoize  ---
This feels like it doesn't fit in either Koha::Items or Koha::Holds to me and
rather, as per my suggestion in bug 11983 comment 8
(https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11983#c8) a
Koha::Article::Requests module should be factored out.. we currently have too
much business logic directly tied up in the model classes.

I don't really see this as a case for filter_by_x and filter_by_y methods
actually as the filter, in my opinion, doesn't fit the 'involving complex joins
and stuff' category.. rather it's a simple dbic query.

I would probably subclass the class most appropriate (Holds or Items.. I'm not
sure here) and add the special accessor there.

Does this sound sane/make sense or do you want me to attempt to create a
counter patch as example code?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21163] Basket group detail page layout is broken

2018-08-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21163

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21163] Basket group detail page layout is broken

2018-08-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21163

Owen Leonard  changed:

   What|Removed |Added

  Attachment #77488|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21163] Basket group detail page layout is broken

2018-08-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21163

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #2 from Jonathan Druart  
---
I would have preferred a patch with only the needed changes, this wants does
too many things.

At least one bug: deliverycomment textarea is not displayed when creating a new
basket group.

Indentation of last patch of the patch looks weird, it should be 1 input per
line  (here it is sometimes 1, 2 or 3).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14662] Allow blank values in pull downs in cataloguing forms when subfield is mandatory

2018-08-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14662

--- Comment #12 from Jonathan Druart  
---
(In reply to Jonathan Druart from comment #11)
> It does not work for me when adding a new item.

Hum wait, let me follow the test plan without skipping lines :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21163] Basket group detail page layout is broken

2018-08-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21163

--- Comment #1 from Owen Leonard  ---
Created attachment 77488
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77488=edit
Bug 21163: Basket group detail page layout is broken

This patch makes markup changes and improvements to the basket groups
template. This fixes a problem with layout of the page when viewing a
closed basket group.

Fixed: Changed the grid options for basket information when a basket
group is closed.

Also changed: Removed some unnecessary script and style "type"
attributes. Rearranged some list markup in order to avoid validation
errors. Removed some id attributes which were causing validation error.
Added some minor style changes to improve readability.

To test, apply the patch and go to Acquisitions -> Vendor -> Basket
groups. You should have multiple baskets and basket groups to test with.

- Edit an open basket group. The layout should look correct, with basket
  group information in the form in the left column and ungrouped basket
  in the right column. Grouping and ungrouping baskets should work
  correctly.
- View a closed basket group. The basket group information should
  display in a single column that spans the main part of the page.
- HTML validation of the page should contain no relevant errors.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21163] Basket group detail page layout is broken

2018-08-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21163

Owen Leonard  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14662] Allow blank values in pull downs in cataloguing forms when subfield is mandatory

2018-08-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14662

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #11 from Jonathan Druart  
---
It does not work for me when adding a new item.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18947] Unexpected Active Directory LDAP authentication failure mode

2018-08-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18947

Jonathan Druart  changed:

   What|Removed |Added

 CC||alex.arn...@biblibre.com

--- Comment #10 from Jonathan Druart  
---
Alex, could you have a look at this one and QA it?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21161] The item has not been checked in due to a configuration issue in your system. you must ask an administrator to take a look at the about page and search for the data problems se

2018-08-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21161

Jonathan Druart  changed:

   What|Removed |Added

  Group|Koha security   |
 Status|NEW |RESOLVED
  Component|Koha|Architecture, internals,
   ||and plumbing
Product|Koha security   |Koha
   Assignee|ch...@bigballofwax.co.nz|koha-b...@lists.koha-commun
   ||ity.org
 QA Contact||testo...@bugs.koha-communit
   ||y.org
 Resolution|--- |INVALID

--- Comment #2 from Jonathan Druart  
---
You just need to read the error message carefully: "you must ask an
administrator to take a look at the about page and search for the data problems
section"

https://wiki.koha-community.org/wiki/DBMS_auto_increment_fix

This bug tracker must not be used for such support questions, please use the
mailing lists instead.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20273] Elasticsearch: Auth-finder.pl autocomplete must use search_auth_compat

2018-08-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20273

Martin Renvoize  changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable

--- Comment #27 from Martin Renvoize  ---
Pushed to 18.05.x for 18.05.03.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19604] Elasticsearch Fixes for build_authorities_query for auth searching

2018-08-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19604

Martin Renvoize  changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable

--- Comment #33 from Martin Renvoize  ---
Pushed to 18.05.x for 18.05.03. Thanks guys.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21163] Basket group detail page layout is broken

2018-08-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21163

Owen Leonard  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11375] Improve patrons permissions display

2018-08-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11375

Owen Leonard  changed:

   What|Removed |Added

 Status|Signed Off  |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19604] Elasticsearch Fixes for build_authorities_query for auth searching

2018-08-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19604

--- Comment #32 from Martin Renvoize  ---
Excellent, thanks Nicolas and Nick. I thought it was probably as simple as that
but as I'm not fully up to speed on ES myself yet it was good to have it
verified. The repo link is very helpful, I'll get this pushed today :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19604] Elasticsearch Fixes for build_authorities_query for auth searching

2018-08-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19604

--- Comment #31 from Nick Clemens  ---
(In reply to Nicolas Legrand from comment #30)
> Ay up Martin,
> 
> When I did test it against 17.12 it was very relevant and I quickly rebased
> it on 18.05.00 to have it in our production 18.05 before it will be rebased
> on Bug 20073.
> 
> Nick should confirm this, but it seems to me his last patch is only a rebase
> against Bug 20073, so maybe you could use the previous patch, or what I have
> done : https://github.com/BULAC/koha/commits/18.05.00_bug_19604
> 
> But maybe I am suggesting something terrible in the whole development
> process?

This is what I was going to suggest as well - it is mostly moving the changes
from the module into the files, earlier patches should work, just check the
tests to ensure nothing else changed and let me knwo if you need me to take a
crack

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21162] The item has not been checked in due to a configuration issue in your system. you must ask an administrator to take a look at the about page and search for the data problems se

2018-08-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21162

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com
 Resolution|--- |INVALID
 Status|NEW |RESOLVED

--- Comment #1 from Nick Clemens  ---
Hi Dinesh,

There is more info on this page:
https://wiki.koha-community.org/wiki/DBMS_auto_increment_fix

If you need some help you can ask on the mailing lists or in irc.

-Nick

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21163] New: Basket group detail page layout is broken

2018-08-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21163

Bug ID: 21163
   Summary: Basket group detail page layout is broken
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: major
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: josef.mora...@gmail.com
QA Contact: testo...@bugs.koha-community.org

See this screenshot:

https://screenshots.firefox.com/UXubeSlczdiSCxQg/localhost

the main part of the page is out of it's position

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21162] New: The item has not been checked in due to a configuration issue in your system. you must ask an administrator to take a look at the about page and search for the data proble

2018-08-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21162

Bug ID: 21162
   Summary: The item has not been checked in due to a
configuration issue in your system. you must ask an
administrator to take a look at the about page and
search for the data problems section
 Change sponsored?: ---
   Product: Koha
   Version: 18.05
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: dkumar9...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19604] Elasticsearch Fixes for build_authorities_query for auth searching

2018-08-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19604

--- Comment #30 from Nicolas Legrand  ---
Ay up Martin,

When I did test it against 17.12 it was very relevant and I quickly rebased it
on 18.05.00 to have it in our production 18.05 before it will be rebased on Bug
20073.

Nick should confirm this, but it seems to me his last patch is only a rebase
against Bug 20073, so maybe you could use the previous patch, or what I have
done : https://github.com/BULAC/koha/commits/18.05.00_bug_19604

But maybe I am suggesting something terrible in the whole development process?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/