[Koha-bugs] [Bug 21200] Allow default values for saved SQL report "date" parameters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21200 paxed changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |pasi.kalli...@joensuu.fi |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21200] New: Allow default values for saved SQL report "date" parameters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21200 Bug ID: 21200 Summary: Allow default values for saved SQL report "date" parameters Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: koha-bugs@lists.koha-community.org Reporter: pasi.kalli...@joensuu.fi QA Contact: testo...@bugs.koha-community.org It would be nice to let the saved SQL report define default date values, relative to the time the report is being run, for any "date" fields. Often such date fields require entering a date eg. 6 months past or similar, and having the default value in would make it much less likely for the user to choose the wrong date. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21159] Blank item shelving location (952$c) on issue and return based on syspref values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159 Alex Buckley changed: What|Removed |Added Status|Needs Signoff |ASSIGNED --- Comment #7 from Alex Buckley --- Hi Katrin Sorry for the delay I think I should be able to modify this commit so it depends on (builds on) whats in 14576. In other words instead of implementing the BlankShelvingLocationOnReturn syspref which I have in this commit I can leave that out as it is being covered by 14576. However, 14576 does not set/blank the items.locations field when an item is issued as the BlankShelvingLocationOnIssue syspref in this commit does so I can leverage some of the code of 14576 to implement this functionality. Being able to blank the shelving location of an item when it is issued was the main thing our client wanted to be able to do. Thanks for bringing 14576 to my attention I will make changes to my commits so it builds on 14576. Cheers, Alex -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21174] Sysprefs to enable the opening of OPAC cart in one click
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21174 Alex Buckley changed: What|Removed |Added Status|ASSIGNED|Needs Signoff --- Comment #4 from Alex Buckley --- Amended commit added containing a test plan. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21174] Sysprefs to enable the opening of OPAC cart in one click
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21174 --- Comment #3 from Alex Buckley --- Created attachment 77642 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77642=edit Bug 21174 - Implemented syspref to enable the loading of cart popup on one click Test plan: 1. In Koha OPAC click on the cart icon (making sure to have items in the cart and the dropdown box 'Items in your cart:..' appears. 2. Click this dropdown and the cart popup appears. 3. Confirm you can successfully remove items from and empty the cart 4. Apply patch 5. Restart memcached, plack and in koha-shell run ./updatedatabase.pl 6. By default the new syspref in this patch is turned off. Therefore repeat steps: 1,2,3 and confirm they work the same as before you applied the commit 7. In Koha staff client go to Administration->Global system preferences and enable the 'EnableOneClickToOpenCartPopup' preference 8. Back in the OPAC click on the cart icon (making sure to have items in the cart) and notice no 'Items in your: ..' dropdown appears instead the cart popup loads straight away. 9. Confirm the items in your cart is displayed by the cart popup 10. Confirm you can remove items from/empty the cart Sponsored-By: Toi Ohomai Insitute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21174] Sysprefs to enable the opening of OPAC cart in one click
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21174 Alex Buckley changed: What|Removed |Added Attachment #77550|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15971] Allow use of all biblio and biblioitems fields (like issn) in serial claim letters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15971 --- Comment #2 from Katrin Fischer --- Created attachment 77641 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77641=edit Bug 15971: Add biblioitems to available fields for serial claim notices and fix notices editor display This fixes 2 related problems: 1) The editor only offered 3 entries from biblio for adding to the notice: title, author, serial It was not clear that actually all fields from biblio can be used. 2) It was not possible to use fields from biblioitems in the notices which left out important fields like the ISSN. The patch adds the biblioitems table and changes the editor to show all entries from biblio and biblioitems table are shown on the left. To test: - Create a subscription - Generate next issue a few times to get late issues - Create a new notice in the "Claim serial issue" module - Use fields from different/all tables - Make sure an email address is set for - the vendor (also check for 'receives claims for late issues') - your staff user - Go to serials > claims - Claim multiple issues - Verify the email is generated and contains the correct information Example notice: Title: <> Author: <> ISSN: <> ISBN: <> Issue: <> -- -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15971] Allow use of all biblio and biblioitems fields (like issn) in serial claim letters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15971 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18586] Create module to mint RDF subject URIs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18586 --- Comment #9 from David Cook --- I'll be at Kohacon18, so happy to talk/work on RDF and OAI-PMH stuff there, if folk are interested! Since doing my work with RDF in Koha, I've actually been exposed to a lot more RDF with Fedora Commons and the IIIF protocol, so I have a lot more insight into how RDF is *actually* being used in the library world. I think there's a lot of issues with my other RDF work, and I'd probably even like to change this patch a bit, since it's hard-coded to mint URLs using the "bib" prefix, which is supported in the Apache configuration, but... hard-coded stuff isn't great. Anyway, cool to see some renewed interest in this! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15971] Allow use of all biblio and biblioitems fields (like issn) in serial claim letters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15971 Katrin Fischer changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |katrin.fisc...@bsz-bw.de |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12759] Add ability to pass list contents to batch record modification/deletion tools
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12759 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #29 from Katrin Fischer --- Took a look at this one too. I think the intended behaviour is that when you check the authorities checkbox, the list option is not offered as the lists can only contain bibliographic records. That does work ok when you start at the top, but when you've already switched to the list tab and then switch from bibliographic to authority, your conf remains visible. Maybe needs a little tweaking. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20689] Make it possible to add capital letter subfields to item search fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20689] Make it possible to add capital letter subfields to item search fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689 --- Comment #3 from Katrin Fischer --- Created attachment 77640 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77640=edit Bug 20689: Replace marc (sub)field pull downs with input fields on item search fields config The pull down for marc subfields on the item search fields config page is long and hard to use. It also doesn't include the commonly used upper case letters for custom item subfields. Also hard to use with its 999 entries is the marc field list. It doesn't allow for tags like 01e, which exist in our MARC21 default framework. To test: - Go to Administration > Item search fields - Add different mappings with and without subfields - Verify the entered values are stored correctly - Edit mappings - Verify editing works and changes save correctly -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20443] Move C4::Members::Attributes to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20443 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #9 from Jonathan Druart --- (In reply to Tomás Cohen Arazi from comment #6) > I don't think we can break GetPatronInfo (ILS-DI) like this. We should keep > the current behaviour and propose a behaviour change on a separate bug. I have pushed a follow-up to fix that. NOTES: 1. I do not think we should display info from the attribute's type 2. We should test the value of the description if linked with AV (value_description). Are we sure we want "attribute" vs "value". And "value_description"? Let's stick to current behaviours for now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20443] Move C4::Members::Attributes to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20443 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=21199 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14257] Add show_extended_attributes to ILS-DI call GetPatronInfo
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14257 Jonathan Druart changed: What|Removed |Added Blocks||21199 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20689] Make it possible to add capital letter subfields to item search fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689 Katrin Fischer changed: What|Removed |Added Summary|Make it possible to add |Make it possible to add |custom item subfields to|capital letter subfields to |item search fields |item search fields -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20689] Make it possible to add custom item subfields to item search fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689 Katrin Fischer changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |katrin.fisc...@bsz-bw.de |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20450] Add collection to list of items when placing hold on specific copy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20450 --- Comment #3 from Katrin Fischer --- Separate patches as the initial request was for staff, but I think useful in the OPAC too. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20450] Add collection to list of items when placing hold on specific copy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20450 --- Comment #1 from Katrin Fischer --- Created attachment 77637 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77637=edit Bug 20450: Add collection to item table when placing a hold on a specific copy (Intranet) This patch adds a new collection column to the item table when selecting a specific item for a hold. The column will only appear if at least one item has a collection set. To test, in staff: - Place a specific hold on - a record with one or more items with collections - a record with one or more items without collections - Verify the collections display correctly when they exist - Verify the table still works as expected -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20450] Add collection to list of items when placing hold on specific copy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20450 --- Comment #2 from Katrin Fischer --- Created attachment 77638 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77638=edit Bug 20450: Add collection to item table when placing a hold on a specific copy (OPAC) This patch adds a new collection column to the item table when selecting a specific item for a hold. The column will only appear if at least one item has a collection set. To test, in OPAC: - Place a specific hold on - a record with one or more items with collections - a record with one or more items without collections - Verify the collections display correctly when they exist - Verify the table still works as expected -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20450] Add collection to list of items when placing hold on specific copy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20450 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20217] Make header's catalog search menu into a split button
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20217 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20504] Language attribute in html tag is empty in system preference editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20504 Jonathan Druart changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |katrin.fisc...@bsz-bw.de |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20504] Language attribute in html tag is empty in system preference editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20504 Jonathan Druart changed: What|Removed |Added Attachment #77634|0 |1 is obsolete|| --- Comment #5 from Jonathan Druart --- Created attachment 77636 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77636=edit Bug 20504: Fix lang attribute in html tag on systempreferences page On the system preferences page the lang attribute of the html tag is always empty. To test: - Go to systempreferences - Check the html source and look at the html tag, it should read: - Apply patch - Check the html source again: Verify the language code shown matches the currently selected language in the staff interface - Verify the language system preferences work correctly Signed-off-by: Jonathan Druart The problem was actually that $lang = $template->param( 'lang' ); should certainly be $lang = $input->param( 'lang' ); and, as it, it overrides the value of 'lang' passed from C4::Auth -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20504] Language attribute in html tag is empty in system preference editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20504 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20450] Add collection to list of items when placing hold on specific copy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20450 Katrin Fischer changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |katrin.fisc...@bsz-bw.de |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20450] Add collection to list of items when placing hold on specific copy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20450 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Summary|Add Collection field to |Add collection to list of |list of items when placing |items when placing hold on |hold on specific copy |specific copy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21195] Makefile.t is failing due to new files for SCSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21195 Jonathan Druart changed: What|Removed |Added Attachment #77633|0 |1 is obsolete|| --- Comment #3 from Jonathan Druart --- Created attachment 77635 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77635=edit Bug 21195: Ignore files used for SCSS build process koha_1 | # Failed test 'All directories should be mapped: .sass-lint.yml,.scss-lint.yml,gulpfile.js,package.json,yarn.lock' koha_1 | # at t/Makefile.t line 47. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21195] Makefile.t is failing due to new files for SCSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21195 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297 --- Comment #70 from Katrin Fischer --- Comment on attachment 72061 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72061 Bug 11297 - Add support for custom PQF attributes for Z39.50 server searches. Review of attachment 72061: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=11297=72061) - ::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/z3950servers.tt @@ +28,5 @@ > +$("#syntax").val('[% server.syntax %]'); > +$("#encoding").val('[% server.encoding %]'); > +$("#recordtype").val('[% server.recordtype %]'); > +[% END %] > +// Disable recordtype (and default to bib) for non-Z3950 servers > until auth is supported Noticed this comment here earlier: bug 19436 has now been pushed, so it might need to be adapted now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #222 from Jonathan Druart --- (In reply to Owen Leonard from comment #221) > I did what I hope was a fairly thorough test of the staff client and found > these issues: > > - IntranetCirculationHomeHTML displays HTML tags as text Done, specific patch for this pref. > - Patron title include showing HTML: class="patron-title">Mr/span Done, see specific patch. > - Patron details -> Holds tab: Alerts data from the branches table Done, that was tricky and a part I forgot, we need to escape data using JS, see String.prototype.escapeHtml > - Search results page layout is broken. Looks like page-numbers.inc has a > section missing. Ooops, wrong merge conflict resolution. > - Crazy encoding of action buttons on Lists page > - Incorrectly escaped HTML in Notices & slips list Both fixed now. > - Label batch list title encoding wrong > - Spine label print shows HTML Fixed but follow-ups needed (TODO LATER) > - Administration -> Libraries: Alerts data from the branches table It comes from opac_info, which can contain html characters. See admin/branches.tt: library.opac_info is not escaped (" | $raw") > - Administration -> Item types: Alerts data from the items table Same as before for itemtype.checkinmsg. I have added a patch for the missing $raw filter to make it explicit. > - Item searching broken: "Unsupported format html at > /home/vagrant/kohaclone/catalogue/itemsearch.pl line 42." Done, that was a hard one! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21198] New: authenticate_api_request should stash the reason access is granted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21198 Bug ID: 21198 Summary: authenticate_api_request should stash the reason access is granted Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: REST api Assignee: koha-bugs@lists.koha-community.org Reporter: tomasco...@gmail.com There's a pattern we will be facing in the controllers where overloading the behaviour depending on the logged user permissions. We have the information on the request on the permissions check step, and it should be carried down to the controllers for its use. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21197] New: Search index list doesn't show other-control-number
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21197 Bug ID: 21197 Summary: Search index list doesn't show other-control-number Change sponsored?: --- Product: Koha Version: 17.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Documentation Assignee: koha-bugs@lists.koha-community.org Reporter: and...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org The search index list at https://koha-community.org/manual/17.11/html/13_searching.html#koha-search-indexes doesn't mention the indexing of the 035 as other-control-number established in Bug 6499 (https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6499) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20504] Language attribute in html tag is empty in system preference editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20504 Katrin Fischer changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20809] Link patron image to patron image add/edit form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20809 Owen Leonard changed: What|Removed |Added Status|Passed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20504] Language attribute in html tag is empty in system preference editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20504 --- Comment #4 from Katrin Fischer --- I am not totally sure about this one - it seems that the $lang variable in the preferences code was never set and not used in the template. But by overwriting the existing lang template variable, it broke the lang attribute in the html tag. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20504] Language attribute in html tag is empty in system preference editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20504 Katrin Fischer changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20504] Language attribute in html tag is empty in system preference editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20504 --- Comment #3 from Katrin Fischer --- Created attachment 77634 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77634=edit Bug 20504: Fix lang attribute in html tag on systempreferences page On the system preferences page the lang attribute of the html tag is always empty. To test: - Go to systempreferences - Check the html source and look at the html tag, it should read: - Apply patch - Check the html source again: Verify the language code shown matches the currently selected language in the staff interface - Verify the language system preferences work correctly -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21196] New: Allow calcfine to consider default item type replacement cost
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21196 Bug ID: 21196 Summary: Allow calcfine to consider default item type replacement cost Change sponsored?: --- Product: Koha Version: 17.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Fines and fees Assignee: koha-bugs@lists.koha-community.org Reporter: and...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org When circ rules are set to cap at item replacement cost, calcfine only checks the price in the item record, not the default replacement cost by item type. To test: - Set useDefaultReplacementCost to use - Set a default replacement cost for a given item type - Create an item of that type with a replacementcost=0 - Create a circ rule for that item type that accrues fines but caps at replacement cost - check the item out, forcing a due date in the past - check that item in - no fines are generated -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21195] Makefile.t is failing due to new files for SCSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21195 Tomás Cohen Arazi changed: What|Removed |Added Attachment #77631|0 |1 is obsolete|| --- Comment #2 from Tomás Cohen Arazi --- Created attachment 77633 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77633=edit Bug 21195: Ignore files used for SCSS build process Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21195] Makefile.t is failing due to new files for SCSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21195 Tomás Cohen Arazi changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21195] Makefile.t is failing due to new files for SCSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21195 Tomás Cohen Arazi changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20217] Make header's catalog search menu into a split button
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20217 Owen Leonard changed: What|Removed |Added Status|BLOCKED |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21178] Add Koha::Patron::set_password method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21178 --- Comment #6 from Tomás Cohen Arazi --- Created attachment 77632 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77632=edit Bug 21178: (QA follow-up) Rely on is_password_valid This patch makes set_password still rely on Koha::AuthUtils' is_password_valid method as the only source for truth regarding password validity. To test: - Run: $ kshell k$ prove t/db_dependent/Koha/Patrons.t => SUCCESS: Tests still pass! Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21195] Makefile.t is failing due to new files for SCSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21195 Nick Clemens changed: What|Removed |Added CC||oleon...@myacpl.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21195] Makefile.t is failing due to new files for SCSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21195 --- Comment #1 from Nick Clemens --- Created attachment 77631 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77631=edit Bug 21195: Ignore files used for SCSS build process I do not know if this is the correct way, it does work. Can we place these into a directory so that they can be ignored as one? that might be cleaner To test: prove t/Makefile.t -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21195] Makefile.t is failing due to new files for SCSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21195 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21195] Makefile.t is failing due to new files for SCSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21195 Nick Clemens changed: What|Removed |Added Depends on||19474 CC||jonathan.dru...@bugs.koha-c ||ommunity.org, ||mi...@abunchofthings.net, ||tomasco...@gmail.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 [Bug 19474] Convert staff client CSS to SCSS -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21154] Remove unused subs from C4::Serials
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21154 --- Comment #6 from Martin Renvoize --- Deprecation Warning pushed to 18.05.x for 18.05.03 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19474] Convert staff client CSS to SCSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 Nick Clemens changed: What|Removed |Added Blocks||21195 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21195 [Bug 21195] Makefile.t is failing due to new files for SCSS -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21195] New: Makefile.t is failing due to new files for SCSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21195 Bug ID: 21195 Summary: Makefile.t is failing due to new files for SCSS Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org not ok 1 - All directories should be mapped: .sass-lint.yml,.scss-lint.yml,gulpfile.js,package.json,yarn.lock -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21154] Remove unused subs from C4::Serials
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21154 Martin Renvoize changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||martin.renvoize@ptfs-europe ||.com --- Comment #5 from Martin Renvoize --- I'm opting to add a deprecation warning into these subs instead of removing them in the 18.05.x series. The hope is that it will serve as a friendly warning to those tracking 18.05.x who may be using these routines in local customisations stating it's removal in 18.11.x. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21186] Incorrect Bootstrap modal event name in multiple templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21186 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Small patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21186] Incorrect Bootstrap modal event name in multiple templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21186 --- Comment #1 from Owen Leonard --- Created attachment 77630 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77630=edit Bug 21186: Incorrect Bootstrap modal event name in multiple templates Modals in the staff client which load data via AJAX require an "on close" action in order to clear the modal of the loaded data. The problem presents itself the second time the modal is opened: The "loading" message doesn't appear, and the data from the previous link is shown until the new data loads. To test, apply the patch and test the following pages. In each case, click multiple instances of the modal trigger link/button to confirm that the "loading" message always appears between re-displays of the modal. - Acquisitions -> Vendor -> Add to basket -> From a staged file -> Add orders - Test the "MARC" and "Card" links - Acquisitions -> EDIFACT messages - Test the "View message" button - Acquisitions -> Vendor -> Add to basket -> From an existing record - Test "View MARC" link - Acquisitions -> Vendor -> Invoices -> Invoice -> Receipt page - Test the "Order," "MARC," and "Card" links. - Catalog -> Bibliographic record details - Test the MARC Preview link. - Cataloging -> Cataloging search results - Test the Actions -> MARC preview and Actions -> Card preview menu items - Cataloging -> Cataloging search results -> Merge - Test the "View MARC" linkscataloguing/merge.tt - Tools -> Patron lists -> Actions -> Print patron cards - Tools -> Batch record modification -> Results -> Show MARC - Tools -> Staged MARC record management -> View batch - Test MARC preview shown when you click a staged title -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21194] East analytics show wrong title when linking to host
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21194 --- Comment #1 from Nick Clemens --- hmmmmaybe I am wrong here now that I look again - I guess technically we linked the host to this record, but it seems like we linked this record to the host in my view. I think it could be better as: Record "Pikachu..." successfully linked to "Ash" -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21194] East analytics show wrong title when linking to host
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21194 Nick Clemens changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21194] New: East analytics show wrong title when linking to host
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21194 Bug ID: 21194 Summary: East analytics show wrong title when linking to host Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl To recreate: 1 - Enable easy analytics 2 - Find a record, say "Pikachu: A life in letters" 3 - Click 'Edit->Link to host item' 4 - Enter a barcode from a different record say "Ash: why was he compelled to catch them all?" 5 - Note the message after linking is 'The item has successfully been linked to Pikachu: a life in letters' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20443] Move C4::Members::Attributes to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20443 Tomás Cohen Arazi changed: What|Removed |Added Status|In Discussion |Failed QA --- Comment #7 from Tomás Cohen Arazi --- (In reply to Tomás Cohen Arazi from comment #6) > I don't think we can break GetPatronInfo (ILS-DI) like this. We should keep > the current behaviour and propose a behaviour change on a separate bug. This: my $attrs = $patron->extended_attributes->search({ opac_display => 1 })->unblessed; should be: my $attrs = grep { $_->type->opac_display } @{ $patron->extended_attributes->search }; my @attrs_unblessed = map { $_->unblessed } @{ $attrs }; Highlighted by: k$ prove t/db_dependent/ILSDI_Services.t t/db_dependent/ILSDI_Services.t .. 1/4 DBD::mysql::st execute failed: Unknown column 'opac_display' in 'where clause'... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21193] New: Develop a procedure for handling minified CSS at release only
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21193 Bug ID: 21193 Summary: Develop a procedure for handling minified CSS at release only Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org Since bug 19474 we have a build toll for css and can build minified or readable versions, we shoudl integrate this into the release pipeline so developers can commit only the readable version. >From bug 19474: Could we imagine to have a staff-global.css and staff-global.min.css It would depend on the dev_install config flag, devs will use .css whereas production installations will use .min.css The .min.css would be generated only on releasing (and will avoid to pollute the git log). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20427] Convert OPAC LESS to SCSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20427 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||n...@bywatersolutions.com --- Comment #15 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19474] Convert staff client CSS to SCSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||n...@bywatersolutions.com --- Comment #68 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21188] t/db_dependent/Circulation/issue.t is failing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21188 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #5 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21188] t/db_dependent/Circulation/issue.t is failing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21188 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #4 from Nick Clemens --- Minor fix, moving to PQA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6499] MARC21 035 -- Other-control-number -- Indexing & Matching
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6499 Paul Hoffman changed: What|Removed |Added CC||p...@flo.org --- Comment #27 from Paul Hoffman --- FYI, in our Koha instance (17.11.04) I had to use this in IntranetUserJS: Instead of this: Without ",phr" I found it was doing a ",wrdl" search which failed. Others may find that this is not necessary, but I mention it here for anyone who stumbles upon this only to find that the suggested code doesn't work for them. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #173 from Owen Leonard --- I'm trying to test this and running into trouble: Other comments: The changes to sample_notices.sql don't apply cleanly, but that can wait for a rebase. Easy to ignore at this stage of testing. I get this error in the staff client: Missing right curly or square bracket at /home/vagrant/kohaclone/C4/Circulation.pm line 4144, at end of line It looks like there is a missing curly bracket at line 2064, so I added that before continuing. Then: Checked-out items in the OPAC don't show a "recall" link on the detail page. I'm logged in as a different user than the one who has it checked out. Is there more I need to do to make something "available" for recall? Or was my correction to Circulation.pm incorrect, causing some other problems? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20443] Move C4::Members::Attributes to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20443 --- Comment #6 from Tomás Cohen Arazi --- I don't think we can break GetPatronInfo (ILS-DI) like this. We should keep the current behaviour and propose a behaviour change on a separate bug. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21182] acqui/check_duplicate_barcode_ajax.pl is not longer in use
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21182 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||martin.renvoize@ptfs-europe ||.com --- Comment #3 from Martin Renvoize --- Verified I can't find any uses of this at all before the patch and the reasoning is clear from Jonathans comments and the git logs. Verified the patch works as expected. Going straight to Passed QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21182] acqui/check_duplicate_barcode_ajax.pl is not longer in use
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21182 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21182] acqui/check_duplicate_barcode_ajax.pl is not longer in use
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21182 Martin Renvoize changed: What|Removed |Added Attachment #77583|0 |1 is obsolete|| --- Comment #2 from Martin Renvoize --- Created attachment 77629 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77629=edit Bug 21182: Remove acqui/check_duplicate_barcode_ajax.pl It has been added by commit 327be442bd6e63e5ff8c0a5e2461ae836e8deffb Bug 6963: Corrects a problem when a new order is created with a duplicate barcode. But its last call removed since: commit eefc774e274ce8167f1063be5f9204a0d5cf5650 Bug 7178: Acquisition item creation improvement Test plan: git grep check_duplicate_barcode should not return anything Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20443] Move C4::Members::Attributes to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20443 --- Comment #5 from Jonathan Druart --- Remote branch has been rebased against master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21192] New: Borrower Fields on OPAC's Personal Details Screen Use Self Register Field Options Incorrectly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21192 Bug ID: 21192 Summary: Borrower Fields on OPAC's Personal Details Screen Use Self Register Field Options Incorrectly Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: csl...@camdencountylibrary.org QA Contact: testo...@bugs.koha-community.org If a patron is logged into the OPAC and they attempt to submit changes to their personal details without having actually changed anything, the page reloads with a message stating 'No changes were made.' However, the fields that now appear are those that have been allowed/hidden according to the preferences set for patron self registration, even if patron self registration is disabled. This can lead to problems if there are discrepancies between the fields allowed for self register settings and those allowed for patron self modification settings. To replicate: 1.) In Administration › System preferences > OPAC, set PatronSelfRegistration to 'don't allow' 2.) Modify the unwanted fields for PatronSelfModificationBorrowerUnwantedField and PatronSelfRegistrationBorrowerUnwantedField so that at least one field is different between the two settings and save (for example, specify 'mobile' to be hidden in the former, but don't include in the list of fields to be hidden in the latter). 3.) Log into the OPAC and navigate to the 'your personal details' tab. Notice that the editable fields correspond to those not hidden by PatronSelfModificationBorrowerUnwantedField 4.) Without making any changes, click on 'Submit update request'. 5.) Note that on this page the fields correspond to those not hidden by PatronSelfRegistrationBorrowerUnwantedField and are now editable (including any fields that would otherwise be hidden by the Self Modification settings). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20248] Elasticsearch - Improvements to mappings UI and indexing script
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20248 --- Comment #33 from Jonathan Druart --- (In reply to Julian Maurice from comment #32) > > > > I was talking about this warning: > > > > "Warning: Any changes to the configuration [...]" > > > > > > > > I think it does not make sense to display it on the confirmation screen. > > > > > > Why not ? Resetting indexes is a change to the configuration, so the > > > warning > > > is relevant in my opinion. > > > > I guess the important part was "on the confirmation screen". > > I've read this part too, and I don't understand why you would want to hide > this warning on the confirmation screen. Can you explain why showing it does > not make sense to you ? It was minor, just saying that 2 warnings on the same page seems wrong. We could instead add a note about the full reindex to the confirmation box, like 'do not forget to reindex'. Let's push as it and improve later if needed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 --- Comment #89 from Cab Vinton --- The sandbox you've requested is not ready. Some problems occurred applying patches from bug 14957: Something went wrong !Applying: Bug 14957 - Rule based permission for MARC fields .git/rebase-apply/patch:871: trailing whitespace. } warning: 1 line adds whitespace errors. Using index info to reconstruct a base tree... M C4/Biblio.pm M cataloguing/addbiblio.pl M koha-tmpl/intranet-tmpl/prog/en/includes/admin-menu.inc M koha-tmpl/intranet-tmpl/prog/en/modules/admin/admin-home.tt M misc/migration_tools/bulkmarcimport.pl .git/rebase-apply/patch:871: trailing whitespace. } warning: 1 line adds whitespace errors. Falling back to patching base and 3-way merge... Auto-merging misc/migration_tools/bulkmarcimport.pl CONFLICT (content): Merge conflict in misc/migration_tools/bulkmarcimport.pl Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/admin-home.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/includes/admin-menu.inc Auto-merging cataloguing/addbiblio.pl Auto-merging C4/Biblio.pm Patch failed at 0001 Bug 14957 - Rule based permission for MARC fields The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run git bz apply --continue. If you would prefer to skip this patch, instead run git bz apply --skip. To restore the original branch and stop patching run git bz apply --abort. error: Failed to merge in the changes. Bug 14957 - Write protecting MARC fields based on source of import 76208 - Bug 14957 - Rule based permission for MARC fields 76209 - Bug 14957 - Refactor and fix tests and documentation 76210 - Bug 14957 - Remove exports of removed subroutines Apply? [(y)es, (n)o, (i)nteractive] Patch left in /tmp/Bug-14957---Rule-based-permission-for-MARC-fields-eC50px.patch . -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20443] Move C4::Members::Attributes to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20443 --- Comment #4 from Martin Renvoize --- I don't see the above as a blocker however and I'm happy to submit it as a qa followup myself once there are patches here ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20443] Move C4::Members::Attributes to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20443 --- Comment #3 from Martin Renvoize --- First QA comment.. and it's possibly a little mean.. You've introduced three 'filter_by_' methods: Awesome++. However, there's an inconsistency with their chainability.. I personally feel such a method should always allow chaining and as such would request, although currently, you don't use them within a chain, that `filter_by_attribute_type` and `filter_by_attribute_value` are altered such that they act upon self rather than instantiating a new object to pass as the return. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12759] Add ability to pass list contents to batch record modification/deletion tools
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12759 Cab Vinton changed: What|Removed |Added CC||bibli...@gmail.com --- Comment #28 from Cab Vinton --- Tested in Biblibre Sandbox no. 2. Unable to select Authorities radio button under either Batch Record Modification or Deletion tool. No problems deleting records, or modifying/ adding content to a MARC field appearing in the editor, using a list as a source of records. Perhaps unrelated, but was unable to add content to a field that was not visible in the MARC editor (e.g., 945, 970). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7376] Transfer limits should be checked at check-in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 --- Comment #50 from Jonathan Druart --- (In reply to Julian Maurice from comment #49) > Are you asking for a 2nd signoff ? Yes. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21133] Missing use C4::Accounts statement in Koha/Patron.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21133 --- Comment #13 from Jonathan Druart --- (In reply to Victor Grousset/tuxayo from comment #12) > (In reply to Martin Renvoize from comment #11) > > This one is somewhat of a nightmare to backport. I'm going to hold off and > > see if there are any side effects in master before attempting a port. > > Even just the first patch ? "Add missing use C4::Accounts statement in > Koha/Patron.pm" Then tests will fail? :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20427] Convert OPAC LESS to SCSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20427 --- Comment #14 from Owen Leonard --- Created attachment 77628 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77628=edit Bug 20427: (follow-up) Bring SCSS up to date with latest LESS changes This patch catches the SCSS up to the latest changes in master: Changes to opac.less: Bug 20756 Bug 20559 Bug 7547 Changes to print.less: Bug 16575 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20660] AddReturn should use return date override for debarments
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20660 --- Comment #13 from Jonathan Druart --- The description of this bug report and what the patch does are a bit different. There is a change in the behavior that should have been adverted in the commit message, and tested on the UI. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21188] t/db_dependent/Circulation/issue.t is failing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21188 Jonathan Druart changed: What|Removed |Added Attachment #77622|0 |1 is obsolete|| --- Comment #3 from Jonathan Druart --- Created attachment 77627 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77627=edit Bug 21188: Convert return_date to a DateTime object Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21188] t/db_dependent/Circulation/issue.t is failing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21188 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11897] Stock Rotation for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 --- Comment #276 from Martin Renvoize --- Rebased again. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11897] Stock Rotation for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Martin Renvoize changed: What|Removed |Added Attachment #76706|0 |1 is obsolete|| --- Comment #272 from Martin Renvoize --- Created attachment 77623 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77623=edit Bug 11897: Add Stock Rotation atomic update schema. * installer/data/mysql/atomicupdate/stockrot_tables.sql: New file. * installer/data/mysql/kohastructure.sql (stockrotationrotas) (stockrotationstages, stockrotationitems): New tables. * installer/data/mysql/sysprefs.sql: Add Stockrotation sysprefs. * installer/data/mysql/userflags.sql: Add Stockrotaiton userflag. * installer/data/mysql/userpermissions.sql: Add Stockrotation userpermissions. * koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref: Add Stockrotation menu. Signed-off-by: Kathleen Milne -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11897] Stock Rotation for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Martin Renvoize changed: What|Removed |Added Attachment #76710|0 |1 is obsolete|| --- Comment #275 from Martin Renvoize --- Created attachment 77626 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77626=edit Bug 11897: Stockrotation The stock rotation feature adds a batch process to automate rotation of catalgue items with a staff client page under tools to manage rotas/schedules. Once a rota is configured, and your staff user has the right permissions to allocate items, then an additional tab will appear on biblio records allowing the management of of which rota, if any, individual items belong to. It also includes a cron script to process the items on a daily basis. Signed-off-by: Kathleen Milne -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11897] Stock Rotation for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Martin Renvoize changed: What|Removed |Added Attachment #76708|0 |1 is obsolete|| --- Comment #274 from Martin Renvoize --- Created attachment 77625 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77625=edit Bug 11897: DBIX::Class::Ordered in Stockrotationstage. * Koha/Schema/Result/Stockrotationstage.pm: Load `Ordered`, add grouping_column. Signed-off-by: Kathleen Milne -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11897] Stock Rotation for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Martin Renvoize changed: What|Removed |Added Attachment #76707|0 |1 is obsolete|| --- Comment #273 from Martin Renvoize --- Created attachment 77624 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77624=edit Bug 11897: DO NOT PUSH: Add stock rotation schema files. * Koha/Schema/Result/Branch.pm: New file. * Koha/Schema/Result/Item.pm: New file. * Koha/Schema/Result/Stockrotationitem.pm: New file. * Koha/Schema/Result/Stockrotationrota.pm: New file. * Koha/Schema/Result/Stockrotationstage.pm: New file. Signed-off-by: Kathleen Milne -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21190] GDPR: Log successful/unsuccessful login attempts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21190 Vitor Fernandes changed: What|Removed |Added Blocks||21191 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21191 [Bug 21191] GDPR: Script to block inactive users (with no successful logins on a defined period) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21191] GDPR: Script to block inactive users (with no successful logins on a defined period)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21191 Vitor Fernandes changed: What|Removed |Added Depends on||21190 Priority|P5 - low|P2 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21190 [Bug 21190] GDPR: Log successful/unsuccessful login attempts -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21191] New: GDPR: Script to block inactive users (with no successful logins on a defined period)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21191 Bug ID: 21191 Summary: GDPR: Script to block inactive users (with no successful logins on a defined period) Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Authentication Assignee: koha-bugs@lists.koha-community.org Reporter: vfernan...@keep.pt QA Contact: testo...@bugs.koha-community.org CC: dpav...@rot13.org Under the auspices of the recently issued European legislation regarding data privacy (GDPR), the Portuguese government has issued a series of mandatory requirements, as well as general recommendations, for software applications that are implemented under the umbrella of public bodies (RCM 41/2018). Since Koha is mostly used by municipalities and universities in Portugal, some of these mandatory requirements need to be address by Koha implementers in Portugal. We believe that this requirement is also useful for the community at large. Here’s a description of the requirement. *** Requirement description *** The application MUST record the time of a user last logged in. It should have a method to inactivate users that haven’t logged into the application for over X number of months (new setting). *** Scope *** Applies to implementations where user authentication is handled by Koha. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20660] AddReturn should use return date override for debarments
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20660 Jonathan Druart changed: What|Removed |Added Keywords|additional_work_needed | --- Comment #12 from Jonathan Druart --- See bug 21188. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21188] t/db_dependent/Circulation/issue.t is failing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21188 --- Comment #2 from Nick Clemens --- (In reply to Nick Clemens from comment #1) > Created attachment 77622 [details] [review] > Bug 21188: Convert return_date to a DateTime object To test: 1 - Checkout an item 2 - Make it over due: update issues set date_due='1999-01-01'; 3 - Go to 'Circulation->Check-in' 4 - Specify a return date 5 - Check in the item 6 - Internal server error 7 - Apply patch 8 - Repeat 1-5 9 - Success! 10 - prove t/db_dependent/Circulation/issue.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20660] AddReturn should use return date override for debarments
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20660 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #11 from Jonathan Druart --- It broke a test: t/db_dependent/Circulation/issue.t .. 1/32 Argument "2014-04-01 23:42" isn't numeric in numeric eq (==) at /usr/lib/x86_64-linux-gnu/perl5/5.20/DateTime.pm line 1863. A DateTime object can only be compared to another DateTime object (DateTime=HASH(0x8b9dd28), 2014-04-01 23:42). at /home/vagrant/kohaclone/C4/Overdues.pm line 290. # Looks like your test exited with 255 just after 26. https://jenkins.koha-community.org/job/Koha_Master_D9/lastCompletedBuild/testReport/ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20660] AddReturn should use return date override for debarments
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20660 Jonathan Druart changed: What|Removed |Added Keywords||additional_work_needed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21068] NorwegianPatronDBEnable - Check for prior ModMember calls that passed 'sync'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21068 --- Comment #7 from Magnus Enger --- Sounds good! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21190] GDPR: Log successful/unsuccessful login attempts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21190 Vitor Fernandes changed: What|Removed |Added Priority|P5 - low|P2 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21190] New: GDPR: Log successful/unsuccessful login attempts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21190 Bug ID: 21190 Summary: GDPR: Log successful/unsuccessful login attempts Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Authentication Assignee: koha-bugs@lists.koha-community.org Reporter: vfernan...@keep.pt QA Contact: testo...@bugs.koha-community.org CC: dpav...@rot13.org Under the auspices of the recently issued European legislation regarding data privacy (GDPR), the Portuguese government has issued a series of mandatory requirements, as well as general recommendations, for software applications that are implemented under the umbrella of public bodies (RCM 41/2018). Since Koha is mostly used by municipalities and universities in Portugal, some of these mandatory requirements need to be address by Koha implementers in Portugal. We believe that this requirement is also useful for the community at large. Here’s a description of the requirement. *** Requirement description *** The application MUST log successful and unsuccessful authentication operations. This is useful, for example, to detect that a user account is being hacked. *** Scope *** Applies in all cases. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20660] AddReturn should use return date override for debarments
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20660 Nick Clemens changed: What|Removed |Added Blocks||21188 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21188 [Bug 21188] t/db_dependent/Circulation/issue.t is failing -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21188] t/db_dependent/Circulation/issue.t is failing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21188 --- Comment #1 from Nick Clemens --- Created attachment 77622 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77622=edit Bug 21188: Convert return_date to a DateTime object -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/