[Koha-bugs] [Bug 21121] New syspref to allow hiding of private patron data in circulation page

2018-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21121

--- Comment #7 from Alex Buckley  ---
Just a note to say this was sponsored-by: Toi Ohomai Institute of Technology in
New Zealand and Catalyst IT.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21497] Correctly format dates for ILL requests in OPAC

2018-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21497

M. Tompsett  changed:

   What|Removed |Added

  Attachment #80076|0   |1
is obsolete||

--- Comment #2 from M. Tompsett  ---
Created attachment 80650
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80650=edit
Bug 21497: Correctly format dates for ILL requests in OPAC

This patch updates the opac ILL template to use the $KohaDates plugin
for displaying dates. Also updated:

- Added "title-string" sorting to allow for correct sorting of dates in
  the table of requests.
- Corrected capitalization as per our capitalization rules.
- Added self-closing / to inputs as per coding guidelines.

To test, apply the patch and log in to the OPAC as a user who has
multiple outstanding ILL requests.

 - In the table of ILL requests, the "Request placed" and "Last updated"
   dates should be formatted according to your system's dateformat
   preference.
 - Sorting of those columns should work correctly.
 - View a request and confirm that "Request placed" and "Last updated"
   dates in this view are also formatted correctly.

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21497] Correctly format dates for ILL requests in OPAC

2018-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21497

M. Tompsett  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21241] Set suggestion notices message_transport_type to sms if patrons has no email but smsalertnumber set

2018-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21241

--- Comment #3 from Alex Buckley  ---
This is in use by Brimbank library so that acquisitions notices are not
attempted to be sent via email to patrons with no defined email address. This
would be a useful one to be tested and upstreamed.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20844] Reset a hold when it is missing after allocation

2018-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20844

--- Comment #4 from Alex Buckley  ---
Any chance we can move this one along with testing?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21526] TT variables used to build a link should be uri filtered

2018-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21526

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #80641|0   |1
is obsolete||

--- Comment #3 from Jonathan Druart  
---
Created attachment 80649
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80649=edit
Bug 21526: uri escape TT variables when used in 'a href'

This patch has been generated with the script provided on bug 21576.
It only affects variable used in the href attribute of a link *when*
href it the first attribute of the node (grep "a href")

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21526] TT variables used to build a link should be uri filtered

2018-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21526

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21576] Add a developer script to automatically fix missing filters

2018-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21576

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21576] Add a developer script to automatically fix missing filters

2018-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21576

Jonathan Druart  changed:

   What|Removed |Added

 Status|Needs Signoff   |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21526] TT variables used to build a link should be uri filtered

2018-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21526

Jonathan Druart  changed:

   What|Removed |Added

 Status|Needs Signoff   |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20078] Indexes 'arl' (Accelerated reading level) and 'arp' (Accelerated reading point) not usable in search menus.

2018-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20078

Barton Chittenden  changed:

   What|Removed |Added

  Attachment #79434|0   |1
is obsolete||

--- Comment #5 from Barton Chittenden  ---
Created attachment 80647
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80647=edit
Bug 20078: (follow-up) Prevent conflict from attribute duplication

To test:
1 - Apply first patch
2 - Attempt searching by arp, no results
3 - Apply this patch
4 - Copy bib1.att and ccl.properties to the correct locations
5 - Restart zebra
6 - Rebuild indexes
7 - Search agian, success!

Signed-off-by: Margie Sheppard - Central Kansas Library System CKLS


-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20078] Indexes 'arl' (Accelerated reading level) and 'arp' (Accelerated reading point) not usable in search menus.

2018-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20078

Barton Chittenden  changed:

   What|Removed |Added

  Attachment #79431|0   |1
is obsolete||

--- Comment #4 from Barton Chittenden  ---
Created attachment 80646
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80646=edit
Bug 20078: Add accelerated reading indexes to getIndexes

To test:
1 - Find a bib with 526$c and 526$d populated, or populate them
 e.g. 526$a 5.5 | 526$d 14
2 - Try searching for 'arl:5.5' or 'arp:14'
3 - Your record should be returned in results
4 - Add the indexes as dropdowns by entering the following in intranetuserjs:
$(document).ready(function(){
// Add Accelerated Reading Level to advanced search
if (window.location.href.indexOf("catalogue/search.pl") > -1) {
$(".advsearch").append('Accelerated Reading
Level');
}

// Add Accelerated Reading Point to advanced search
if (window.location.href.indexOf("catalogue/search.pl") > -1) {
$(".advsearch").append('Accelerated Reading
Point');
}
});
5 - Search using these in the dropdown, your record will not be found
6 - Apply patch
7 - Repeat searches directly and by using dropdown, your record should be
returned.
8 - prove t/db_dependent/Search.t

Signed-off-by: Margie Sheppard - Central Kansas Library System CKLS


-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20078] Indexes 'arl' (Accelerated reading level) and 'arp' (Accelerated reading point) not usable in search menus.

2018-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20078

Barton Chittenden  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21552] RoutingListNote should use raw filter and display HTML unescaped

2018-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21552

Chris Cormack  changed:

   What|Removed |Added

  Attachment #80564|0   |1
is obsolete||

--- Comment #10 from Chris Cormack  ---
Created attachment 80645
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80645=edit
Bug 21552: Use raw filter for displaying RoutingListNote

The RoutingListNote system preference works like other prefs
allowing you to insert your own content on the routling list
template using HTML. The default text even uses HTML, so it
looks broken without this patch.

To test:
- Add a subscription
- Add a new routing list to it
- Add some patrons to it
- Save
- preview routing list
- Verify that the note shows and is formatted correctly.

Signed-off-by: Pierre-Marc Thibault 
Signed-off-by: Chris Cormack 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21552] RoutingListNote should use raw filter and display HTML unescaped

2018-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21552

Chris Cormack  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21576] Add a developer script to automatically fix missing filters

2018-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21576

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #80642|0   |1
is obsolete||

--- Comment #3 from Jonathan Druart  
---
Created attachment 80644
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80644=edit
Bug 21576: Keep compatibility with QA script

The QA script call 'missing_filters', it sounds better to keep it in
order to avoid fixing it and have a weird condition (if
module->can('subroutine_name')) to maintain

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21479] Removing from cart removes 2 items

2018-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21479

--- Comment #22 from Jonathan Druart  
---
Created attachment 80643
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80643=edit
Bug 21479: "Mock" SearchEngine to use Zebra

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21576] Add a developer script to automatically fix missing filters

2018-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21576

--- Comment #2 from Jonathan Druart  
---
Created attachment 80642
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80642=edit
Bug 21576: Keep compatibility with QA script

The QA script call 'missing_filters', it sounds better to keep it in
order to avoid fixing it and have a weird condition (if
module->can('subroutine_name')) to maintain

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21526] TT variables used to build a link should be uri filtered

2018-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21526

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21526] TT variables used to build a link should be uri filtered

2018-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21526

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #80337|0   |1
is obsolete||

--- Comment #2 from Jonathan Druart  
---
Created attachment 80641
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80641=edit
Bug 21526: uri escape TT variables when used in 'a href'

This patch has been generated with the script provided on bug 21576.
It only affects variable used in the href attribute of a link *when*
href it the first attribute of the node (grep "a href")

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21576] Add a developer script to automatically fix missing filters

2018-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21576

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21576] Add a developer script to automatically fix missing filters

2018-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21576

--- Comment #1 from Jonathan Druart  
---
Created attachment 80640
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80640=edit
Bug 21576: Add a developer script to fix missing TT filters

See bug 13618 and bug 21526.

We need a script to add missing filters, or replace wrong ones.

Test plan:
- Add unescaped variables to .tt files
- prove xt/find-missing-filters.t
will warn about them
- perl misc/devel/add_missing_filters.pl
will add the missing/wrong filters
- prove xt/find-missing-filters.t
will now be happy

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21576] New: Add a developer script to automatically fix missing filters

2018-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21576

Bug ID: 21576
   Summary: Add a developer script to automatically fix missing
filters
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Command-line Utilities
  Assignee: jonathan.dru...@bugs.koha-community.org
  Reporter: jonathan.dru...@bugs.koha-community.org
QA Contact: testo...@bugs.koha-community.org
CC: ro...@catalyst.net.nz
Depends on: 13618
Blocks: 21526

Since bug 13618 developers have to escape TT variables when needed. It is not
easy to think about (as we are lazy) and hard to pick the good one (html vs
uri).
It would be great to help our brains and have a script to add them
automagically when needed.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618
[Bug 13618] Add additional template filter methods and a filter presence test
to Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21526
[Bug 21526] TT variables used to build a link should be uri filtered
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13618] Add additional template filter methods and a filter presence test to Koha

2018-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||21576


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21576
[Bug 21576] Add a developer script to automatically fix missing filters
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21526] TT variables used to build a link should be uri filtered

2018-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21526

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||21576


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21576
[Bug 21576] Add a developer script to automatically fix missing filters
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches

2018-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823

--- Comment #30 from Cori Lynn Arnold  ---
Created attachment 80639
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80639=edit
Bug 18823: Fix regression issues with search

Tests:

1) Open advanced cataloging edtior
2) Under settings select 'Import Batches'
3) Create a few import batches, some for searching and some as targets (and
some both)
 3.a) note that import batches for saving appear on the left side as
targets to save
4) Search for a bibliographic record, make changes and apply to an import batch
5) Search for the bibliographic record in the import batch by author, title,
isbn
6) Make changes to the import batch records and verify the changes are applied
(either through searching again, or through the Staged MARC management page in
Tools)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15184] Ability to duplicate existing order lines to a given basket

2018-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184

--- Comment #95 from Jonathan Druart  
---
Created attachment 80638
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80638=edit
Bug 15184: Add missing html filters

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches

2018-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823

Cori Lynn Arnold  changed:

   What|Removed |Added

  Attachment #80613|0   |1
is obsolete||

--- Comment #29 from Cori Lynn Arnold  ---
Created attachment 80637
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80637=edit
Bug 18823: Rancor - improve batch search/update ISBN handling

Rebase

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20629] Remove ability to 'reverse' payments

2018-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20629

--- Comment #19 from Kyle M Hall  ---
Created attachment 80636
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80636=edit
Bug 20629: Follow up to add POD for getcharges.

Signed-off-by: Mark Tompsett 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20629] Remove ability to 'reverse' payments

2018-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20629

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #80633|0   |1
is obsolete||
  Attachment #80634|0   |1
is obsolete||

--- Comment #18 from Kyle M Hall  ---
Created attachment 80635
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80635=edit
Bug 20629: Follow up - fix reverse_col value

Before this patch the Void button didn't appear.
After this patch the Void button appears on payments.

Signed-off-by: Mark Tompsett 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20629] Remove ability to 'reverse' payments

2018-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20629

Kyle M Hall  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20629] Remove ability to 'reverse' payments

2018-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20629

--- Comment #15 from M. Tompsett  ---
Created attachment 80632
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80632=edit
Bug 20629: Pass accountline objects to template instead of hashref

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20629] Remove ability to 'reverse' payments

2018-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20629

M. Tompsett  changed:

   What|Removed |Added

  Attachment #80621|0   |1
is obsolete||
  Attachment #80622|0   |1
is obsolete||
  Attachment #80629|0   |1
is obsolete||
  Attachment #80630|0   |1
is obsolete||

--- Comment #14 from M. Tompsett  ---
Created attachment 80631
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80631=edit
Bug 20629: Remove ability to 'reverse' payments

Test Plan:
1) Apply this patch
2) Note all references to reversing payments have been removed
3) Note ability to void payments remains unchanged

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20629] Remove ability to 'reverse' payments

2018-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20629

--- Comment #16 from M. Tompsett  ---
Created attachment 80633
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80633=edit
Bug 20629: Follow up - fix reverse_col value

Before this patch the Void button didn't appear.
After this patch the Void button appears on payments.

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20629] Remove ability to 'reverse' payments

2018-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20629

--- Comment #17 from M. Tompsett  ---
Created attachment 80634
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80634=edit
Bug 20629: Follow up to add POD for getcharges.

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20629] Remove ability to 'reverse' payments

2018-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20629

--- Comment #13 from M. Tompsett  ---
Created attachment 80630
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80630=edit
Bug 20629: Follow up to add POD for getcharges.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20629] Remove ability to 'reverse' payments

2018-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20629

--- Comment #12 from M. Tompsett  ---
Created attachment 80629
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80629=edit
Bug 20629: Follow up - fix reverse_col value

Before this patch the Void button didn't appear.
After this patch the Void button appears on payments.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21311] Remove locked message from opac-auth.tt

2018-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21311

--- Comment #10 from M. Tompsett  ---
(In reply to Jonathan Druart from comment #9)
> Maybe we could keep the link to recover the password?
> 
> -[% IF Koha.Preference('OpacResetPassword')
> %]
> - href="/cgi-bin/koha/opac-password-recovery.pl">You must reset your
> password.
> -[% ELSE %]

Do you want people to be able to unlock locked accounts?
Perhaps a wording change would be required so as to not let the person know
whether or not the account is locked. And does the reset password reset the
failed log in attempts? I thought there was another bug related to this.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches

2018-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823

Cori Lynn Arnold  changed:

   What|Removed |Added

  Attachment #80608|0   |1
is obsolete||

--- Comment #28 from Cori Lynn Arnold  ---
Created attachment 80628
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80628=edit
Bug 18823: Rancor - save override warnings

Rebase.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches

2018-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823

Cori Lynn Arnold  changed:

   What|Removed |Added

  Attachment #80606|0   |1
is obsolete||

--- Comment #27 from Cori Lynn Arnold  ---
Created attachment 80627
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80627=edit
Bug 18823: Improvements to import batch searching and enabled/disabled

Rebase.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches

2018-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823

Cori Lynn Arnold  changed:

   What|Removed |Added

  Attachment #80604|0   |1
is obsolete||

--- Comment #26 from Cori Lynn Arnold  ---
Created attachment 80626
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80626=edit
Bug 18823: Rancor - add support for editing/searching records from import
batches

Rebase.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21311] Remove locked message from opac-auth.tt

2018-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21311

--- Comment #9 from Jonathan Druart  
---
Maybe we could keep the link to recover the password?

-[% IF Koha.Preference('OpacResetPassword') %]
-You must reset your
password.
-[% ELSE %]

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21337] Add Koha::Patrons->delete (trivial wrapper)

2018-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21337

--- Comment #18 from Nick Clemens  ---
(In reply to Jonathan Druart from comment #16)
> Created attachment 80624 [details] [review]
> Bug 21337: Koha::Objects->delete must return the number of deleted rows
> 
> To follow DBIC behaviour
> 
> Signed-off-by: Jonathan Druart 

follow-up pushed to master, thanks Jonathan

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21479] Removing from cart removes 2 items

2018-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21479

--- Comment #21 from Jonathan Druart  
---
Created attachment 80625
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80625=edit
Bug 21479: Mock SearchEngine to use Zebra

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21337] Add Koha::Patrons->delete (trivial wrapper)

2018-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21337

--- Comment #17 from Jonathan Druart  
---
I have fixed a failing test in Objects.t

IMO the following line is wrong:
  $patron->delete == 1 || Koha::Exceptions::Patron::Delete->throw;

We must follow dbic behaviours and so we must not throw an exception if
something went wrong (what DBIC does)

Then I would not name an exception "Koha::Exceptions::Patron::Delete" but more
something like Koha::Exceptions::Patron::NotDeleted, or CannotDelete,
CannotBeDeleted, etc.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21337] Add Koha::Patrons->delete (trivial wrapper)

2018-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21337

--- Comment #16 from Jonathan Druart  
---
Created attachment 80624
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80624=edit
Bug 21337: Koha::Objects->delete must return the number of deleted rows

To follow DBIC behaviour

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20629] Remove ability to 'reverse' payments

2018-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20629

--- Comment #11 from M. Tompsett  ---
Comment on attachment 80622
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80622
Bug 20629 - Pass accountline objects to template instead of hashref

Review of attachment 80622:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=20629=80622)
-

::: members/boraccount.pl
@@ +80,3 @@
>  }
>  
>  my $reverse_col = 0; # Flag whether we need to show the reverse column

perhaps two Account lines searches, and merge the array? That will give you the
ability to set reverse_col correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20629] Remove ability to 'reverse' payments

2018-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20629

--- Comment #10 from M. Tompsett  ---
Comment on attachment 80622
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80622
Bug 20629 - Pass accountline objects to template instead of hashref

Review of attachment 80622:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=20629=80622)
-

::: koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt
@@ +75,5 @@
>  [% ELSE %]
> href="printinvoice.pl?action=printaccountlines_id=[% 
> account.accountlines_id | html %]borrowernumber=[% 
> account.borrowernumber | html %]" class="btn btn-default btn-xs"> Print
>  [% END %]
>   class="fa fa-list"> Details
>  [% IF ( reverse_col) %]

reverse_col is always 0, because it is passed as 0, and you don't set it above,
and you need to set it BEFORE the header.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21553] Javascript error on rota page

2018-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21553

Martin Renvoize  changed:

   What|Removed |Added

 Status|Pushed to Master|RESOLVED
 Resolution|--- |FIXED

--- Comment #6 from Martin Renvoize  ---
Caused by bug 11897 not in 18.05.x series.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21553] Javascript error on rota page

2018-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21553

Martin Renvoize  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe
   |y.org   |.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21536] t/Koha_ExternalContent_RecordedBooks.t skips more tests than scheduled

2018-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21536

Martin Renvoize  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|Pushed to Master|RESOLVED

--- Comment #7 from Martin Renvoize  ---
Caused by bug 17602 not in 18.05.x series.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21536] t/Koha_ExternalContent_RecordedBooks.t skips more tests than scheduled

2018-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21536

Martin Renvoize  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe
   |y.org   |.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21073] Improve plugin performance

2018-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073

M. Tompsett  changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com

--- Comment #10 from M. Tompsett  ---
Revised Test Plan.

0) Backup DB as desired && Install Kitchen Sink plugin
1) Apply this patch
2) Restart all the things
3) Run updatedatabase.pl (testing upgrade)
4) Verify you can use existing Kitchen Sink plugin
5) Remove Kitchen Sink plugin
6) Reset all the things (testing fresh install)
7) Verify you can install new Kitchen Sink plugin
8) Remove Kitchen Sink plugin && Restore DB if backed up.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17195] Split logging of item modifications from CataloguingLog into separate system preferences

2018-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17195

Barton Chittenden  changed:

   What|Removed |Added

 CC||bar...@bywatersolutions.com

--- Comment #3 from Barton Chittenden  ---
Is this still valid? I think that this might have been something that we were
working on because of cataloging log getting spammed by circulation, which was
fixed in Bug 18816.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21542] OverDrive password submission should use a password field to mask input

2018-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21542

Martin Renvoize  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #5 from Martin Renvoize  ---
Trivial patch so moving straight to Passed QA (especially as it's really just a
followup for bug 21082)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20758] Typo in BrowseResultSelection syspref description

2018-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20758

Katrin Fischer  changed:

   What|Removed |Added

   Keywords||Academy
 CC||katrin.fisc...@bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21550] DataTables four button pagination uses the wrong icon for disabled buttons

2018-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21550

Nick Clemens  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #4 from Nick Clemens  ---
Awesome work all!

Pushed to master for 18.11

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21537] Regression: typo in acquisitions template processor name

2018-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21537

Nick Clemens  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #5 from Nick Clemens  ---
Awesome work all!

Pushed to master for 18.11

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21479] Removing from cart removes 2 items

2018-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21479

--- Comment #20 from Nick Clemens  ---
(In reply to Jonathan Druart from comment #19)
> Created attachment 80605 [details] [review]
> Bug 21479: Zebra index can return different result
> 
> If the zebra index has been rebuilt by previous tests, the order/results
> will be different, and we will not have biblionumber 1, 3, 5
> 
> Let make this more flexible
> 
> Signed-off-by: Jonathan Druart 

Follow up pushed to  master for 18.11

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21409] Add column configuration to course reserves

2018-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21409

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com
 Status|Passed QA   |Pushed to Master

--- Comment #8 from Nick Clemens  ---
Awesome work all!

Pushed to master for 18.11

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21351] Traditional Chinese Language pack should have file name "zh-Hant-TW" not "zh-Hans-TW"

2018-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21351

Nick Clemens  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #6 from Nick Clemens  ---
Awesome work all!

Pushed to master for 18.11

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21365] Advanced MARC Editor - Rancor - BiblioAddsAuthorities not working

2018-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21365

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com
 Status|Passed QA   |Pushed to Master

--- Comment #8 from Nick Clemens  ---
Awesome work all!

Pushed to master for 18.11

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21337] Add Koha::Patrons->delete (trivial wrapper)

2018-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21337

Nick Clemens  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||n...@bywatersolutions.com

--- Comment #15 from Nick Clemens  ---
Awesome work all!

Pushed to master for 18.11

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21320] Holds to pull should honor syspref AllowHoldsOnDamagedItems

2018-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21320

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com
 Status|Passed QA   |Pushed to Master

--- Comment #7 from Nick Clemens  ---
Awesome work all!

Pushed to master for 18.11

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21291] Article requests page doesn't show MARC, LabeledMARC and ISBD in sidebar

2018-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21291

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com
 Status|Passed QA   |Pushed to Master

--- Comment #15 from Nick Clemens  ---
Awesome work all!

Pushed to master for 18.11

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21279] Transport cost matrix shows html entity in all empty cells

2018-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21279

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com
 Status|Passed QA   |Pushed to Master

--- Comment #10 from Nick Clemens  ---
Awesome work all!

Pushed to master for 18.11

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21115] Add multi_param call and add divider in cache key in svc/report and opac counterpart

2018-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21115

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com
 Status|Passed QA   |Pushed to Master

--- Comment #6 from Nick Clemens  ---
Awesome work all!

Pushed to master for 18.11

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21113] Hint Messages are misleading at "Merge Selected Patrons" in Patron Lists

2018-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21113

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com
 Status|Passed QA   |Pushed to Master

--- Comment #6 from Nick Clemens  ---
Awesome work all!

Pushed to master for 18.11

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20131] Inventory optional filters always shows "For loan" for value 0

2018-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20131

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com
 Status|Passed QA   |Pushed to Master

--- Comment #15 from Nick Clemens  ---
Awesome work all!

Pushed to master for 18.11

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21311] Remove locked message from opac-auth.tt

2018-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21311

M. Tompsett  changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com

--- Comment #8 from M. Tompsett  ---
The only thing that may be in question is whether or not we change the other
part of the message. A simple "Access Denied" without reasons is clearer in
that it doesn't say what was wrong. The failure to mention the possibility of
lock out seems wrong to me, but I'm not hung up on it. I'll let QA decide that
quandary with a follow up patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18480] Use modal for displaying patron details on add_user_search.pl to avoid redirect

2018-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18480

Nick Clemens  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #18 from Nick Clemens  ---
Awesome work all!

Pushed to master for 18.11

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18655] Unimarc field 210c fails on importing fields with a simple quote

2018-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18655

Nick Clemens  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||n...@bywatersolutions.com

--- Comment #14 from Nick Clemens  ---
Awesome work all!

Pushed to master for 18.11

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19687] Recent upgrade to 17.05.04.000 bulkmarcimport started to fail

2018-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19687

Nick Clemens  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||n...@bywatersolutions.com

--- Comment #22 from Nick Clemens  ---
Awesome work all!

Pushed to master for 18.11

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15139] Show non-public item note in overdues report

2018-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15139

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com
 Status|Passed QA   |Pushed to Master

--- Comment #15 from Nick Clemens  ---
Awesome work all!

Pushed to master for 18.11

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10382] collection not returning to null when removed from course reserves

2018-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382

Nick Clemens  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #79 from Nick Clemens  ---
This is not perfect, but it reduces the scope of the problem here greatly.

We probably should decide if there is a valid reason to have "" vs. undef for
some of the values in items.

Awesome work all on getting this moved along.

Pushed to master for 18.11

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21311] Remove locked message from opac-auth.tt

2018-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21311

M. Tompsett  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21311] Remove locked message from opac-auth.tt

2018-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21311

M. Tompsett  changed:

   What|Removed |Added

  Attachment #80388|0   |1
is obsolete||

--- Comment #7 from M. Tompsett  ---
Created attachment 80623
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80623=edit
Bug 21311: Remove locked message from opac-auth.tt

We should not expose more information than needed when someone tries
to login with invalid credentials. Saying that an account is locked
reveals that the account exists (or perhaps an email address).

Trivial fix. Keeping the var too_many_login_attempts for staff.
Note: We do not remove this distinction for the staff client here (in the
assumption that a library may well have additional security measures in
place for staff client). But it could be done too (on another report).

Test plan:
Enable lockout feature.
Enter invalid credentials until account locks out (on OPAC !!)
Note that message does no longer change to 'Account is locked'.

Signed-off-by: Marcel de Rooy 

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20629] Remove ability to 'reverse' payments

2018-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20629

--- Comment #9 from Kyle M Hall  ---
Created attachment 80622
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80622=edit
Bug 20629 - Pass accountline objects to template instead of hashref

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20629] Remove ability to 'reverse' payments

2018-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20629

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #80620|0   |1
is obsolete||

--- Comment #8 from Kyle M Hall  ---
Created attachment 80621
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80621=edit
Bug 20629 - Remove ability to 'reverse' payments

Test Plan:
1) Apply this patch
2) Note all references to reversing payments have been removed
3) Note ability to void payments remains unchanged

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21575] New: Fix ArticleRequestsMandatoryFieldsItem(s)Only variants

2018-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21575

Bug ID: 21575
   Summary: Fix ArticleRequestsMandatoryFieldsItem(s)Only variants
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org

The ArticleRequestsMandatoryFieldsItemsOnly shows up on the local use pref tab,
because there is a mismatch between what's in the database and what we have in
the yaml file and templates:


With S:

installer/data/mysql/sysprefs.sql:('ArticleRequestsMandatoryFieldsItemsOnly',
'', NULL, 'Comma delimited list of required fields for bibs where article
requests rule = ''item_only''', 'multiple'),
installer/data/mysql/updatedatabase.pl:   
('ArticleRequestsMandatoryFieldsItemsOnly', '', NULL, 'Comma delimited list of
required fields for bibs where article requests rule = ''item_only''',
'multiple'),

Without S:

ArticleRequestsMandatoryFieldsItemOnly
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref:
   - pref: ArticleRequestsMandatoryFieldsItemOnly
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-request-article.tt:[%
IF article_request_type == 'item_only' %] [% SET mandatory_fields =
Koha.Preference('ArticleRequestsMandatoryFieldsItemOnly') %]   [% END %]

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21572] Allow checkout an item with reserve that is not yet in waiting state

2018-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21572

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #2 from Katrin Fischer  ---
I think this should probably be controlled by the AllowItemsOnHoldCheckout
system preference?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20629] Remove ability to 'reverse' payments

2018-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20629

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #80590|0   |1
is obsolete||

--- Comment #7 from Kyle M Hall  ---
Created attachment 80620
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80620=edit
Bug 20629 - Remove ability to 'reverse' payments

Test Plan:
1) Apply this patch
2) Note all references to reversing payments have been removed
3) Note ability to void payments remains unchanged

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20629] Remove ability to 'reverse' payments

2018-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20629

Kyle M Hall  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21574] New: Local use system preferences page doesn't have the system preferences menu

2018-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21574

Bug ID: 21574
   Summary: Local use system preferences page doesn't have the
system preferences menu
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: System Administration
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: caroline.cyr-la-r...@inlibro.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

When looking through system preferences, you have a menu of all the sysprefs
categories on the left.

However, if you click on "Local use", the left side menu is the administration
menu.

To reproduce:
1) Go to Administration > Global system preferences
2) Click on categories on the left-hand side of the screen (for example,
"Circulation" or "Staff client", the left-hand side menu stays the same
3) Click on the "Local use" category
4) Notice the left-hand side menu is the administration menu and not the
sysprefs categories

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20968] Plugins: Add hooks to enable plugin integration into catalogue

2018-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968

Kyle M Hall  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20968] Plugins: Add hooks to enable plugin integration into catalogue

2018-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968

--- Comment #50 from Kyle M Hall  ---
Created attachment 80617
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80617=edit
Bug 20968: Add unit tests

Signed-off-by: Stephen Graham 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20968] Plugins: Add hooks to enable plugin integration into catalogue

2018-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968

--- Comment #52 from Kyle M Hall  ---
Created attachment 80619
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80619=edit
Bug 20968: (follow-up) Replace tabs with spaces

Signed-off-by: Stephen Graham 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20968] Plugins: Add hooks to enable plugin integration into catalogue

2018-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #80394|0   |1
is obsolete||
  Attachment #80395|0   |1
is obsolete||
  Attachment #80396|0   |1
is obsolete||
  Attachment #80397|0   |1
is obsolete||
  Attachment #80398|0   |1
is obsolete||

--- Comment #48 from Kyle M Hall  ---
Created attachment 80615
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80615=edit
Bug 20968: Add hooks into cat-toolbar.inc to display buttons

This commit adds hooks into cat-toolbar.inc to allow the display of
arbitrary buttons as supplied by plugins within the
intranet_catalog_biblio_enhancements class that provide the method
get_toolbar_button

To test:

1) Download the plugin from
https://github.com/PTFS-Europe/cla-permissions-check-plugin
2) Follow the installation instructions from:
https://github.com/PTFS-Europe/cla-permissions-check-plugin
3) TEST: Observe that the "CLA Check Permissions" button takes the user
to the Check Permissions page and a modal displays containing the
results of the query
4) Remove the API key from the plugin "Configuration" page
5) TEST: Ensure that the "CLA Check Permissions" button takes the user
to the Check Permissions page and message displays informing the user
that "Did not receive required request parameters"

https://bugs.koha-community.org/show_bug.cgi?id=20968

Signed-off-by: Stephen Graham 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20968] Plugins: Add hooks to enable plugin integration into catalogue

2018-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968

--- Comment #49 from Kyle M Hall  ---
Created attachment 80616
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80616=edit
Bug 20968: (follow-up) Respond to feedback

This patch:

- Removes the unecessary testing for
intranet_catalog_biblio_enhancements method in detail.pl
- Renames get_toolbar_button to get_intranet_catalog_toolbar_button

Signed-off-by: Stephen Graham 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20883] Display patron user id

2018-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20883

M. Tompsett  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20883] Display patron user id

2018-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20883

M. Tompsett  changed:

   What|Removed |Added

  Attachment #80611|0   |1
is obsolete||

--- Comment #7 from M. Tompsett  ---
Created attachment 80614
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80614=edit
Bug 20883: Add patron userid to display

This patch adds the display of patron userid to both the "illlist" and
"illview" pages.

Test plan (see bug 7317 for ILL deployment details):
1) Ensure you have at least one ILL request
2) Go to the main "List requests" page by clicking "ILL requests" from
the main staff interface
   TEST => Observe that you see a "Patron username" column the the
   table, containing the patron's correct userid
3) Click "Manage request" on a request
   TEST => Observe that, in the "Patron" row, you see the patron's
   correct userid in brackets (along with their name and barcode)

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21477] Use of REMOTE_ADDR causes problems when Koha is behind a proxy

2018-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21477

Eric Phetteplace  changed:

   What|Removed |Added

 CC||ephettepl...@cca.edu

--- Comment #1 from Eric Phetteplace  ---
I just wanted to chime in that this effects us, as we'd like to offer limited
access to media via the Restricted Page feature without forcing a sign-in from
on campus but are hosted behind a proxy by ByWater.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches

2018-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823

Cori Lynn Arnold  changed:

   What|Removed |Added

  Attachment #79244|0   |1
is obsolete||
  Attachment #80519|0   |1
is obsolete||

--- Comment #25 from Cori Lynn Arnold  ---
Created attachment 80613
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80613=edit
Bug 18823: Rancor - improve batch search/update ISBN handling

Rebase

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21573] Move lists barcode and biblionumber entry form to modal

2018-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21573

Owen Leonard  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21573] Move lists barcode and biblionumber entry form to modal

2018-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21573

--- Comment #1 from Owen Leonard  ---
Created attachment 80612
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80612=edit
Bug 21573: Move lists barcode and biblionumber entry form to modal

This patch modifies the staff client lists page so that the
barcode/biblionumber entry form from the left hand sidebar into a modal
window, triggered by a button in the toolbar.

To test, apply the patch and rebuild the staff client CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).

 - View the contents of a list in the staff client, logged in as a user
   who has permission to add items.
 - Click the "Add items" button. A modal window should appear with the
   barcode/biblionumber entry form.
 - Submit barcodes and/or biblionumbers and confirm that the correct
   titles are added to the list.
 - Log in again as a user who does not have permission to add to the
   list. Confirm that the button isn't present.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21573] Move lists barcode and biblionumber entry form to modal

2018-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21573

Owen Leonard  changed:

   What|Removed |Added

Summary|Move barcode and|Move lists barcode and
   |biblionumber entry form to  |biblionumber entry form to
   |modal   |modal

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21573] New: Move barcode and biblionumber entry form to modal

2018-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21573

Bug ID: 21573
   Summary: Move barcode and biblionumber entry form to modal
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org
CC: testo...@bugs.koha-community.org
Depends on: 21570

I propose to move the barcode/biblionumber entry form into a modal window
triggered by a button in the toolbar.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21570
[Bug 21570] Switch two-column templates to Bootstrap grid: Various
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21570] Switch two-column templates to Bootstrap grid: Various

2018-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21570

Owen Leonard  changed:

   What|Removed |Added

 Blocks||21573


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21573
[Bug 21573] Move barcode and biblionumber entry form to modal
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20883] Display patron user id

2018-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20883

--- Comment #6 from M. Tompsett  ---
Hopefully this is recovered from a non-existent "Patch Does Not Apply" state,
because I didn't want to leave it there. :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20883] Display patron user id

2018-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20883

M. Tompsett  changed:

   What|Removed |Added

  Attachment #75821|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   3   >