[Koha-bugs] [Bug 20028] Export all patron related personal data in one package
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028 --- Comment #11 from Josef Moravec --- (In reply to Jonathan Druart from comment #10) > IMO it's not conceivable to push this code as it. We cannot have such code > in .pl, without tests, etc. > > Why not just a $patron->unblessed then use columns.def instead of listing of > the patron's attributes? Hm, i am just thinking about using $RESULTSET_PATRON_ID_MAPPING from Koha::Patron and define the method Koha::Patron->takeout - does it make sense? > > Also found a typo: + 'dateoffbirth' => $patron->dateofbirth, -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21572] Allow checkout an item with reserve that is not yet in waiting state
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21572 --- Comment #5 from David Cook --- Actually, I just noticed that while you cannot renew an item that has a hold, you can check it in, ignore the hold, try to check it out again, and override the errors/warnings and check it out again to the original patron. So it looks like maybe you can already do what you want? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21572] Allow checkout an item with reserve that is not yet in waiting state
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21572 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #4 from David Cook --- I'm bumping into this issue as well, which is why I'm scouring Bugzilla for more information. I do find it weird that the intranet, SCO, and SIP have different ways of handling checkouts/renewals for items with holds... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19197] Lower case "or" results in broken ElasticSearch queries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19197 M. Tompsett changed: What|Removed |Added Attachment #75114|0 |1 is obsolete|| --- Comment #6 from M. Tompsett --- Created attachment 80688 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80688=edit Bug 19197: Change lower case "or" to upper case This makes the search queries compatible with ElasticSearch query syntax -- rebased by Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21005] Missing row/column defaults cause unexpected results in report wizards
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21005 M. Tompsett changed: What|Removed |Added Attachment #77644|0 |1 is obsolete|| --- Comment #4 from M. Tompsett --- Created attachment 80686 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80686=edit Bug 21005: Missing row/column defaults cause unexpected results in report wizards Some report wizards are missing row/column defaults, which sometimes return blank pages (borrowers_stats.pl) or results always equalling 0, which a non-discerning user may interpret incorrectly. If the DEBUG environmental variable is enabled, missing row/column choices will actually cause fatal software errors as well, which is also undesirable for users. This patch adds default choices for row and column on report wizards that had no radio buttons selected, so that a user can't submit the form without choosing a row and column. This prevents errors. To test: 1) Apply patch 2) Visit /cgi-bin/koha/reports/issues_avg_stats.pl 3) Visit /cgi-bin/koha/reports/borrowers_stats.pl 4) Visit /cgi-bin/koha/reports/catalogue_stats.pl 5) Visit /cgi-bin/koha/reports/issues_stats.pl 6) Observe that default choices for row/column are there Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21005] Missing row/column defaults cause unexpected results in report wizards
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21005 --- Comment #5 from M. Tompsett --- Created attachment 80687 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80687=edit Bug 21005: Address QA tool failures on tabs Only whitespace changes. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21005] Missing row/column defaults cause unexpected results in report wizards
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21005 M. Tompsett changed: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21556] Deleting same record twice leads to fatal software error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21556 M. Tompsett changed: What|Removed |Added CC||mtomp...@hotmail.com --- Comment #12 from M. Tompsett --- I think both patches should be used, because the javascript catches the client-side stuff and thus speed up ignoring things. However, if someone intentionally attempts to hack requests to the backend, the perl patch is necessary. This gives speed to the average user, and security from those trying to break Koha. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21556] Deleting same record twice leads to fatal software error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21556 M. Tompsett changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21556] Deleting same record twice leads to fatal software error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21556 M. Tompsett changed: What|Removed |Added Attachment #80670|0 |1 is obsolete|| --- Comment #11 from M. Tompsett --- Created attachment 80685 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80685=edit Bug 21556: Do not crash if a biblio is deleted twice To recreate: - Go to a bibliographic detail page - Delete it - Go back - Delete it again => Without this patch you will get a 500 Can't call method "holds" on an undefined value at /home/vagrant/kohaclone/C4/Biblio.pm line 406. => With this patch applied it will silently redirect you to the search form. Note: We could/should improve the behavior and display a message, but DelBiblio will need to be moved to Koha::Biblio->delete and other callers adjusted Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21583] Novelist Select staff client not working in staff client - ns2init.js not loading
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21583 Chris Cormack changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21583] Novelist Select staff client not working in staff client - ns2init.js not loading
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21583 Chris Cormack changed: What|Removed |Added Attachment #80681|0 |1 is obsolete|| --- Comment #4 from Chris Cormack --- Created attachment 80684 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80684=edit Bug 21583: Don't use Asset.js for external script files To test: 1 - Enable Novelist in staff client: NovelistSelectStaffEnabled: Add NovelistSelectStaffProfile: anything NovelistSelectPassword: anything ( these don't need to be valid, just not blank ) 2 - Pull up a record detail page in staff client 3 - View page source - search for ns2init.js 4 - You won't find it 5 - Apply patch 6 - Reload details 7 - Search page source for ns2init.js 8 - It loaded! Huzzah! Signed-off-by: George Williams Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21560] Optimize ODS export option for reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21560 Chris Cormack changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21560] Optimize ODS export option for reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21560 Chris Cormack changed: What|Removed |Added Attachment #80565|0 |1 is obsolete|| --- Comment #6 from Chris Cormack --- Created attachment 80683 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80683=edit Bug 21560: report ODS export optimization SQL reports can be exported with CSV, TSV of ODS format. When report has thousands of rows, using ODS format is around 10 times longer than other formats. It also loads CPU and RAM a lot. The longest call is expandTable(). I found that the call on OpenOffice-OODoc lib can be optimized. Based on https://grep.metacpan.org/search?qci==expandTable==OpenOffice-OODoc=examples%2Ftext2table Test plan : 1) Don't apply patch yet 2) Create a new SQL report : Home > Reports > Create from SQL 3) Enter a SQL that will return thousands of results 4) Run report 5) Click Download > Semicolon separated text (.csv), look execution time 6) Click Download > Open Document Spreadsheet, look execution time 7) Apply patch 8) Redo 5) and 6) and compare times, CSV export should be the same but ODS export should be better My tests shows 1,5 seconds for CSV export. And for ODS export : 18 seconds without patch and 8 seconds with patch. Signed-off-by: David Nind Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21556] Deleting same record twice leads to fatal software error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21556 --- Comment #10 from David Cook --- Good points, Jonathan. It would be good to have a more graceful handling of this scenario. I think disabling the "Delete Record" in the frontend UI after clicking it still makes sense, but I'm on board for fixing the backend too. Will look at testing/signing off later today... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16694] Limit SIP2 auth by patron attribute
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16694 Mark Alexander changed: What|Removed |Added CC||ma...@pobox.com --- Comment #22 from Mark Alexander --- Our library needs a similar feature, but our use case is more complicated. We use two different services that provide streamed movies and ebooks, respectively. So our patron validation code would look at the client IP address on the SIP2 "patron info" or "patron status" request to determine which of the two services made the request. Then it would use the appropriate criteria for that service to validate the patron, perhaps using a different patron attribute for each service. Right now I've hacked the SIP2 server for this purpose, but it might make more sense for the validation code to be placed in a plugin, to allow it to be customized for each library's special requirements. I'll try working on a patch for this. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15774] Additional fields for baskets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com --- Comment #47 from Martin Renvoize --- How's about 'filter_by' as per the suggestions/discussion over on bug 11983 ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21579] showdiffmarc tool during manage staged batches always looks for biblios even when matching authorities
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21579 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21579] showdiffmarc tool during manage staged batches always looks for biblios even when matching authorities
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21579 Jonathan Druart changed: What|Removed |Added Attachment #80674|0 |1 is obsolete|| --- Comment #8 from Jonathan Druart --- Created attachment 80682 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80682=edit Bug 21579: Make showdiffmarc.pl work for authorities and biblios To test: 1 - Have or make some authority records 2 - Have or make an authority matching rule 3 - Export your authrotities 4 - Import them using the matching rule 5 - On the 'Manage staged records' page view some diffs 6 - The import record is correct, but the existing records pull form bibs 7 - Apply patch 8 - Repeat 9 - Confirm you see the expected authority matches Signed-off-by: Mark Tompsett Signed-off-by: Marjorie Vila Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21583] Novelist Select staff client not working in staff client - ns2init.js not loading
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21583 George Williams (NEKLS) changed: What|Removed |Added CC||geo...@nekls.org Status|Needs Signoff |Signed Off --- Comment #3 from George Williams (NEKLS) --- Tested on ByWater sandbox. Works as advertised. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21583] Novelist Select staff client not working in staff client - ns2init.js not loading
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21583 ByWater Sandboxes changed: What|Removed |Added Attachment #80668|0 |1 is obsolete|| --- Comment #2 from ByWater Sandboxes --- Created attachment 80681 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80681=edit Bug 21583: Don't use Asset.js for external script files To test: 1 - Enable Novelist in staff client: NovelistSelectStaffEnabled: Add NovelistSelectStaffProfile: anything NovelistSelectPassword: anything ( these don't need to be valid, just not blank ) 2 - Pull up a record detail page in staff client 3 - View page source - search for ns2init.js 4 - You won't find it 5 - Apply patch 6 - Reload details 7 - Search page source for ns2init.js 8 - It loaded! Huzzah! Signed-off-by: George Williams -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15774] Additional fields for baskets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #46 from Katrin Fischer --- I think search_by doesn't sound quite right... search_on? search_in? Native speaker? :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15774] Additional fields for baskets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15774] Additional fields for baskets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774
--- Comment #45 from Jonathan Druart
---
* Tests missing for GetHistory
* +my $rs = Koha::Database->new->schema->resultset('AdditionalFieldValue');
must be Koha::AdditionalFieldValue instead.
I would suggest to have a look at Koha::Patron::Category and how the
'branch_limitation' add/update/remove is done, in order to follow an existing
pattern
* additional_field_values must return a Koha::Objects
* Should not search_additional_fields be more search_*by*_additional_fields?
I think we agreed on "filter_by_*" somewhere else (Martin?)
* +# TODO Add column additional_field_values.tablename to avoid
subquery ?
I do not think it is relevant, we want the tablename at additional_fields level
* +for my $field (Koha::AdditionalFields->search({ tablename => 'aqbasket'
})) {
Better to use while ->next instead
These patches are great, please provide a quick follow-up and we will make it
part of 18.11!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15774] Additional fields for baskets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #44 from Jonathan Druart --- Created attachment 80680 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80680=edit Bug 15774: Fix JS check when AV and MARC field are both selected -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21582] Use CodeMirror for *UserJS & *UserCSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21582 --- Comment #5 from Katrin Fischer --- That would work for me! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21585] Ignore missing firstname in ILL requests table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21585 Magnus Enger changed: What|Removed |Added Depends on||7317 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 Magnus Enger changed: What|Removed |Added Blocks||21585 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21585 [Bug 21585] Ignore missing firstname in ILL requests table -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21311] Remove locked message from opac-auth.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21311 --- Comment #17 from Katrin Fischer --- I think having a note about "please note that after X attempts you will be locked out" could be really helpful without revealing too much. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21585] Ignore missing firstname in ILL requests table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21585 Magnus Enger changed: What|Removed |Added Summary|Missing firstname shows as |Ignore missing firstname in |"null" in table of ILL |ILL requests table |requests| -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21311] Remove locked message from opac-auth.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21311 --- Comment #16 from Katrin Fischer --- They could be: bug 16282 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21585] Missing firstname shows as "null" in table of ILL requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21585 Magnus Enger changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21585] Missing firstname shows as "null" in table of ILL requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21585 --- Comment #2 from Magnus Enger --- Created attachment 80679 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80679=edit Bug 21585 - Ignore missing firstname in ILL requests table To test: - Make sure you have a patron with just a surname and no firstname - Create an ILL request so that the name of this patron shows up in the Patron column of the ILL requests table - Before the patch, the name will display as "null Surname" - Apply the patch - Reload the ILL requests page - The name should now display as just "Surname" - Sign ye merrily off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13098] Item lost multiple times by the same patron will create only be charged once
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13098 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com Version|unspecified |master --- Comment #4 from Tomás Cohen Arazi --- Ok, this is the more complete tests I came up with. Use cases: - PF + L + Full write off - PF + L + Full payment - PF + L + No write off or payment - PF + L + Partial write off, partial payment, some remaining debt (L, amountoutstanding) The idea is that _FixAccountForLostAndFound should: - Consider write offs as good enough (so no CR for writeoffs) - Generate a single CR for all payments that reduced amountoutstanding for L - Write offs should be identified by looking at the account_offsets table, specifically when credit_id IS NOT NULL, debit_id is the L accountlines_id and type <> 'Writeoff'. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13098] Item lost multiple times by the same patron will create only be charged once
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13098 Tomás Cohen Arazi changed: What|Removed |Added Attachment #80507|0 |1 is obsolete|| --- Comment #3 from Tomás Cohen Arazi --- Created attachment 80678 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80678=edit Bug 13098: Tests for _FixAccountForLostAndReturned on writeoff When a a write off is done on lost fees, but then the item is returned, the current behaviour is that a credit is added to the patron, for the amount the original lost fee was. This behaviour is wrong and this tests reproduce the situation. To test: - Run: $ kshell k$ prove t/db_dependent/Circulation.t => FAIL: Tests fail because a credit (CR) is added for the original amount, without taking into account the fact the amount was not payed, but written off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21585] Missing firstname shows as "null" in table of ILL requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21585 --- Comment #1 from Magnus Enger --- The JSON looks like this: "firstname":null,"surname":"Uppsala universitetsbibliotek" -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21585] New: Missing firstname shows as "null" in table of ILL requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21585 Bug ID: 21585 Summary: Missing firstname shows as "null" in table of ILL requests Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: ILL Assignee: koha-bugs@lists.koha-community.org Reporter: mag...@libriotech.no I have some libraries that are entered into Koha as borrowers, using the surname field for the name of the library and not using the firstname field. When these libraries are listed in the Patron column of the ILL requests table, the missing firstname is shown as "null", so the name is displayed as "null Some Library". I think the problem is somewhere in the conversion from DB "NULL" to JSON. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21311] Remove locked message from opac-auth.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21311 --- Comment #15 from Martin Renvoize --- Oops -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17509] Notify patrons to return items requested on hold by another person
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #54 from Jonathan Druart --- Quick code review: 1. +my $library = Koha::Libraries->find($borrower->branchcode)->unblessed; can be replaced by $patron->library 2. "lang" param must be passed to GetPreparedLetter to make the notice translatable 3. Use "patron" instead of "borrower", especially for Koha:: 4. +to_address => $borrower->email, To not enqueue with to_address, it must depend on AutoEmailPrimaryAddress. It is correctly handled when sent. 5. We will need native English speaker for "NotifyToReturnItemFromLibrary" (name, description, options) 6. Code in borrowers_to_satisfy could be simplify (no blocker, I can have a look later) 7. New template notices must use the TT syntax (I would recommend to provide the notice for 'en' only and wait for the QA stamp to provide the changes to other files) 8. Changes to AddReserve is not covered by tests. Maybe it should be moved to Koha::Hold? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21501] Remove dead code from course reserves module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21501 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21501] Remove dead code from course reserves module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21501 Jonathan Druart changed: What|Removed |Added Attachment #80146|0 |1 is obsolete|| --- Comment #3 from Jonathan Druart --- Created attachment 80677 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80677=edit Bug 21501: Remove dead code from course reserves module search_on parameter is not used in any templates so course-reserves.pl can be simplified a bit Test plan: 1. Go to course reserves module and verify that it is still working 2. `git grep search_on` should return nothing Signed-off-by: Pierre-Marc Thibault Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21311] Remove locked message from opac-auth.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21311 --- Comment #14 from Jonathan Druart --- (In reply to Martin Renvoize from comment #13) > >Usernames and passwords are case sensitive. Usernames are not. Thanks for your input! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21578] 'Pay fines' tab incorrectly describes the purpose
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21578 Tomás Cohen Arazi changed: What|Removed |Added CC||k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20028] Export all patron related personal data in one package
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #10 from Jonathan Druart --- IMO it's not conceivable to push this code as it. We cannot have such code in .pl, without tests, etc. Why not just a $patron->unblessed then use columns.def instead of listing of the patron's attributes? Also found a typo: +'dateoffbirth' => $patron->dateofbirth, -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21584] Wrong offset type for Lost Item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21584 Tomás Cohen Arazi changed: What|Removed |Added Depends on||20978, 2696 Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com |ity.org | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696 [Bug 2696] Fine payments should show what was paid for https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20978 [Bug 20978] Add Koha::Account::add_credit -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20978] Add Koha::Account::add_credit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20978 Tomás Cohen Arazi changed: What|Removed |Added Blocks||21584 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21584 [Bug 21584] Wrong offset type for Lost Item -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 2696] Fine payments should show what was paid for
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696 Tomás Cohen Arazi changed: What|Removed |Added Blocks||21584 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21584 [Bug 21584] Wrong offset type for Lost Item -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21311] Remove locked message from opac-auth.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21311 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com --- Comment #13 from Martin Renvoize --- I'd go with: >You entered an incorrect username or password, please try again. > >Usernames and passwords are case sensitive. > >Please contact a member of the library staff if you continue to have problems. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21584] New: Wrong offset type for Lost Item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21584 Bug ID: 21584 Summary: Wrong offset type for Lost Item Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: tomasco...@gmail.com QA Contact: testo...@bugs.koha-community.org Bug 20978 tried to add a single source of truth for this values, but an error was introduced. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21556] Deleting same record twice leads to fatal software error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21556 --- Comment #9 from Pierre-Marc Thibault --- I had the same issue for the second test, though I cannot tell if plack was on. I noticed that, when you click on "OK", the option to delete was still open afterwards. So, what I did is that, when "OK" appeared, instead of clicking "OK", I pressed "Enter" which does the same thing. Since you don't have to move the mouse, you can do Enter, click and Enter quickly enough to do the test. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20883] Display patron user id
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20883 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #8 from Jonathan Druart --- (In reply to Andrew Isherwood from comment #0) > Currently, when displaying a list of ILL requests, or viewing a single > request, the requester's userid is not displayed. This should be visible. Why? :) We usually do not display the username anywhere AFAIK. Here you are adding a new column, maybe it could fit into the same column as the firstname and surname? On the detail view we have: Patron: firstname surname [42] [username] Not sure the [] are good for visibility and tell what we are displaying. I am just asking :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Cori Lynn Arnold changed: What|Removed |Added Attachment #79056|0 |1 is obsolete|| --- Comment #24 from Cori Lynn Arnold --- Created attachment 80675 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80675=edit Bug 17385: Add tests for CustomXSLTExportList + Added tests for CustomXSLTExportList to C4::XSLT + Added an eval block in CustomXSLTExportList to handle invalid XML. * Removed Opac parameter, but now handle "OPACXSLTCustomExport" as equivalent + Added "Custom" option to OPACExportOptions preference. Tested with invalid XML (not originally on purpose, but...) and then added a new field to add to the simple export. Walked through the testing steps. Question: should this also apply to the cataloging page as an export option? It doesn't now. Signed-off-by: Cori Lynn Arnold -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Cori Lynn Arnold changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18584] Our legacy code contains trailing-spaces
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 Jonathan Druart changed: What|Removed |Added Assignee|carn...@dgiinc.com |koha-b...@lists.koha-commun ||ity.org Status|Pushed to Master|ASSIGNED --- Comment #30 from Jonathan Druart --- Resetting to New. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18584] Our legacy code contains trailing-spaces
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|NEW -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21579] showdiffmarc tool during manage staged batches always looks for biblios even when matching authorities
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21579 --- Comment #6 from sandbo...@biblibre.com --- Created attachment 80674 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80674=edit Bug 21579: Make showdiffmarc.pl work for authorities and biblios To test: 1 - Have or make some authority records 2 - Have or make an authority matching rule 3 - Export your authrotities 4 - Import them using the matching rule 5 - On the 'Manage staged records' page view some diffs 6 - The import record is correct, but the existing records pull form bibs 7 - Apply patch 8 - Repeat 9 - Confirm you see the expected authority matches Signed-off-by: Mark Tompsett Signed-off-by: Marjorie Vila -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21579] showdiffmarc tool during manage staged batches always looks for biblios even when matching authorities
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21579 sandbo...@biblibre.com changed: What|Removed |Added Attachment #80657|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21579] showdiffmarc tool during manage staged batches always looks for biblios even when matching authorities
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21579 sandbo...@biblibre.com changed: What|Removed |Added CC||sandbo...@biblibre.com --- Comment #5 from sandbo...@biblibre.com --- Patch tested with a sandbox, by Marjorie Vila -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21576] Add a developer script to automatically fix missing filters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21576 --- Comment #9 from Owen Leonard --- Created attachment 80673 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80673=edit Bug 21576: Handle complex uri Only the first TT params in a href was taken into account. This also takes care to replace into href attributes only (for instance not title, etc.) Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21576] Add a developer script to automatically fix missing filters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21576
--- Comment #8 from Owen Leonard ---
Created attachment 80672
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80672=edit
Bug 21576: Keep compatibility with QA script
The QA script call 'missing_filters', it sounds better to keep it in
order to avoid fixing it and have a weird condition (if
module->can('subroutine_name')) to maintain
Signed-off-by: Owen Leonard
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21576] Add a developer script to automatically fix missing filters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21576 Owen Leonard changed: What|Removed |Added Attachment #80640|0 |1 is obsolete|| Attachment #80659|0 |1 is obsolete|| Attachment #80660|0 |1 is obsolete|| --- Comment #7 from Owen Leonard --- Created attachment 80671 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80671=edit Bug 21576: Add a developer script to fix missing TT filters See bug 13618 and bug 21526. We need a script to add missing filters, or replace wrong ones. Test plan: - Add unescaped variables to .tt files - prove xt/find-missing-filters.t will warn about them - perl misc/devel/add_missing_filters.pl will add the missing/wrong filters - prove xt/find-missing-filters.t will now be happy Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21576] Add a developer script to automatically fix missing filters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21576 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21582] Use CodeMirror for *UserJS & *UserCSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21582 --- Comment #4 from Owen Leonard --- Perhaps since Codemirror doesn't actually write any code for you it there doesn't need to be a preference? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21556] Deleting same record twice leads to fatal software error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21556 --- Comment #7 from Jonathan Druart --- Created attachment 80670 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80670=edit Bug 21556: Do not crash if a biblio is deleted twice To recreate: - Go to a bibliographic detail page - Delete it - Go back - Delete it again => Without this patch you will get a 500 Can't call method "holds" on an undefined value at /home/vagrant/kohaclone/C4/Biblio.pm line 406. => With this patch applied it will silently redirect you to the search form. Note: We could/should improve the behavior and display a message, but DelBiblio will need to be moved to Koha::Biblio->delete and other callers adjusted -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21556] Deleting same record twice leads to fatal software error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21556 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21556] Deleting same record twice leads to fatal software error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21556 --- Comment #8 from Jonathan Druart --- Second patch needs a signoff, maybe first patch is not necessary now (?) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21579] showdiffmarc tool during manage staged batches always looks for biblios even when matching authorities
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21579 Marjorie Barry-Vila changed: What|Removed |Added CC||marjorie.barry-vila@collect ||o.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16280] purge_suggestions.pl: Cron job log should tell number of days used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16280 M. Tompsett changed: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16280] purge_suggestions.pl: Cron job log should tell number of days used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16280 M. Tompsett changed: What|Removed |Added Attachment #50298|0 |1 is obsolete|| --- Comment #3 from M. Tompsett --- Created attachment 80669 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80669=edit Bug 16280: purge_suggestions.pl: Cron job log should tell number of days used To test: - Apply patch - Set syspref CronjobLog to "Log" - Set syspref PurgeSuggestionsOlderThan e.g. to 20 - From console, run misc/cronjobs/purge_suggestions.pl - Check entry in cgi-bin/koha/admin/preferences.pl?op=search=log - Verify that log entry contains number of days (20, same as in syspref) - From console, run misc/cronjobs/purge_suggestions.pl -days 100 - Verify that log entry contains number of days (100, same as in param -days) Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21556] Deleting same record twice leads to fatal software error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21556 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #6 from Jonathan Druart --- (In reply to Pierre-Marc Thibault from comment #3) > 2) Click "Edit", then "Delete record", then "OK" > 3) While the browser is reloading, click "Edit", then "Delete record", > then "OK Under plack it's impossible for my (local install) to recreate that, I am not that fast! However I do recreate that: - Click "Edit", then "Delete record", then "OK" - You are redirected to the search form - Click back - Click "Edit", then "Delete record", then "OK" => Can't call method "holds" on an undefined value at /home/vagrant/kohaclone/C4/Biblio.pm line 387 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21560] Optimize ODS export option for reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21560 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Summary|report ODS export |Optimize ODS export option |optimization|for reports -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21579] showdiffmarc tool during manage staged batches always looks for biblios even when matching authorities
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21579 Katrin Fischer changed: What|Removed |Added CC||hector.hecax...@gmail.com --- Comment #4 from Katrin Fischer --- *** Bug 16954 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16954] Add the diff view to authorities in staged MARC records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16954 Katrin Fischer changed: What|Removed |Added Resolution|--- |DUPLICATE Status|Patch doesn't apply |RESOLVED CC||katrin.fisc...@bsz-bw.de --- Comment #6 from Katrin Fischer --- We just got some patches on the duplicate bug 21579 that are signed off. Marking this as duplicate. *** This bug has been marked as a duplicate of bug 21579 *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21579] showdiffmarc tool during manage staged batches always looks for biblios even when matching authorities
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21579 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #3 from Katrin Fischer --- Possible duplicate with bug 16954? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21578] 'Pay fines' tab incorrectly describes the purpose
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21578 --- Comment #2 from Tomás Cohen Arazi --- (In reply to Katrin Fischer from comment #1) > I think Pay is wrong then too - you can also writeoff/void... maybe manage? > It can also not only be debts I guess. What about credits? I'll leave to native speakers :-D -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21578] 'Pay fines' tab incorrectly describes the purpose
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21578 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #1 from Katrin Fischer --- I think Pay is wrong then too - you can also writeoff/void... maybe manage? It can also not only be debts I guess. What about credits? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21311] Remove locked message from opac-auth.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21311 --- Comment #12 from Jonathan Druart --- Current display: https://snag.gy/bsCa1J.jpg Waiting for a suggestion from a native English speaker. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21582] Use CodeMirror for *UserJS & *UserCSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21582 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #3 from Katrin Fischer --- (In reply to Owen Leonard from comment #1) > Should this be controlled by the existing UseWYSIWYGinSystemPreferences > preference, or a separate one? I'm inclined to say use the existing pref. Hm, feels like a different kind of thing to me. We would still write CSS/HTML code which is not WYSIWYG, so the description seems off. I think I'd still like to not use the WYSIWYG, but like to use syntax highlighting. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21311] Remove locked message from opac-auth.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21311
--- Comment #11 from Jonathan Druart
---
(In reply to M. Tompsett from comment #10)
> (In reply to Jonathan Druart from comment #9)
> > Maybe we could keep the link to recover the password?
> >
> > -[% IF Koha.Preference('OpacResetPassword')
> > %]
> > - > href="/cgi-bin/koha/opac-password-recovery.pl">You must reset your
> > password.
> > -[% ELSE %]
>
> Do you want people to be able to unlock locked accounts?
Yes, using the password recovery method. But actually the link appears under
the login form so no need to repeat it.
However I would recommend to keep something about "or you account has been
locked" if FailedLoginAttempts is set.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21560] report ODS export optimization
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21560 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #5 from Jonathan Druart --- Fridolin, I think it would make sense to fix misc/cronjobs/gather_print_notices.pl as well on the same bug report. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21583] Novelist Select staff client not working in staff client - ns2init.js not loading
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21583 Nick Clemens changed: What|Removed |Added Patch complexity|--- |Trivial patch Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21583] Novelist Select staff client not working in staff client - ns2init.js not loading
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21583 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21583] Novelist Select staff client not working in staff client - ns2init.js not loading
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21583 --- Comment #1 from Nick Clemens --- Created attachment 80668 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80668=edit Bug 21583: Don't use Asset.js for external script files To test: 1 - Enable Novelist in staff client: NovelistSelectStaffEnabled: Add NovelistSelectStaffProfile: anything NovelistSelectPassword: anything ( these don't need to be valid, just not blank ) 2 - Pull up a record detail page in staff client 3 - View page source - search for ns2init.js 4 - You won't find it 5 - Apply patch 6 - Reload details 7 - Search page source for ns2init.js 8 - It loaded! Huzzah! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21583] New: Novelist Select staff client not working in staff client - ns2init.js not loading
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21583 Bug ID: 21583 Summary: Novelist Select staff client not working in staff client - ns2init.js not loading Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21582] Use CodeMirror for *UserJS & *UserCSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21582 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com --- Comment #2 from Tomás Cohen Arazi --- (In reply to Andrew Isherwood from comment #0) > CodeMirror is already in use, most recently for the SQL reports editor > (https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20260) > > It would be a substantial UX improvement to add it to the editors for the > *UserJS & *UserCSS sysprefs, in additional to providing syntax highlighting, > features such as smart indenting and bracket matching would be welcome > additions. And validation? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18959] Text_CSV_Various.t must skip if Text::CSV::Unicode is not installed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18959 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18959] Text_CSV_Various.t must skip if Text::CSV::Unicode is not installed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18959 Jonathan Druart changed: What|Removed |Added Attachment #80578|0 |1 is obsolete|| Attachment #80579|0 |1 is obsolete|| --- Comment #5 from Jonathan Druart --- Created attachment 80666 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80666=edit Bug 18959: Text::CSV::Unicode missing from dependencies Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18959] Text_CSV_Various.t must skip if Text::CSV::Unicode is not installed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18959 --- Comment #6 from Jonathan Druart --- Created attachment 80667 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80667=edit Bug 18959: Skip xt/author/Text_CSV_Various.t if Text::CSV::Unicode missing Signed-off-by: Jonathan Druart Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18959] Text_CSV_Various.t must skip if Text::CSV::Unicode is not installed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18959 --- Comment #4 from Jonathan Druart --- (In reply to Jonathan Druart from comment #3) > Why not making it mandatory instead? Heh ok, we just need it for the tests! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18959] Text_CSV_Various.t must skip if Text::CSV::Unicode is not installed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18959 --- Comment #3 from Jonathan Druart --- Why not making it mandatory instead? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13618] Add additional template filter methods and a filter presence test to Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #262 from Jonathan Druart --- *** Bug 20909 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21581] Matching rules for authorities do not respect 'Search index' setting
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21581 M. Tompsett changed: What|Removed |Added Attachment #80658|0 |1 is obsolete|| --- Comment #2 from M. Tompsett --- Created attachment 80665 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80665=edit Bug 21581: Pass through authorities indexes FIXME: We need unit tests To test: 1 - Define a rule: Matching rule code: LCAUTH Match threshold: 100 Record type: Authority record MATCH POINTS Search index: LC-card-number Score: 100 Tag: 010 Subfield: a 2 - Have a record with an LC number in 010 3 - Export it 4 - Edit the record in Koha, move the value from 010 to another field 5 - Import the original record 6 - Use the matching rule above, you expect it won't match (nothing in 010 anymore) 7 - It matches?!?!?! 8 - Enable zebra logging in koha-conf.xml none,fatal,warn,request,info 9 - tail -f /var/log/koha/kohadev/zebra-output.log 10 - On manage marc apply matchign with no rule, then reapply with rule 11 - View the output in the log - the index searched is 'Any' 12 - Apply patch 13 - Reapply matching 14 - Note we search the expected index and no match is found NOTE: By applying bug 21579, I was able to view the difference, and see that it didn't match identically, because I had moved the value from 010 to 155. No log checking needed. clean/delete batch. Apply patch, no match. clean/delete batch. Edit authority back, matches. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21475] Error in the OPAC when viewing a record which has no biblio-level itemtype
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21475 --- Comment #8 from Jonathan Druart --- Bug 21150 added a check on the different item types configuration, but actually biblioitems.itemtype must be set to a valid itemtypes whatever is the value of the pref. This bug highlights the problem quite well, and we certainly have it for holds as well. I am in favor of workarounding it for now if incorrectly set, but what about adding a new check to the misc/maintenance/search_for_data_inconsistencies.pl script? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21582] Use CodeMirror for *UserJS & *UserCSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21582 --- Comment #1 from Owen Leonard --- Should this be controlled by the existing UseWYSIWYGinSystemPreferences preference, or a separate one? I'm inclined to say use the existing pref. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11300] Add a new authority linker which searches for authority links on a Z39.50 server.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11300 Cori Lynn Arnold changed: What|Removed |Added CC||carn...@dgiinc.com --- Comment #26 from Cori Lynn Arnold --- Can we add some test steps for this? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17602] Integrate support for RecordedBooks (formerly OneClickDigital) API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 Jonathan Druart changed: What|Removed |Added Blocks||21567 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21567 [Bug 21567] WebService:ILS related tests fail during package build -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21567] WebService:ILS related tests fail during package build
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21567 Jonathan Druart changed: What|Removed |Added Depends on||17602 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 [Bug 17602] Integrate support for RecordedBooks (formerly OneClickDigital) API -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21567] WebService:ILS related tests fail during package build
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21567 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #4 from Jonathan Druart --- I cannot recreate the failure and the output is not verbose enough. With this patch we could know what is the error. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21567] WebService:ILS related tests fail during package build
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21567 --- Comment #3 from Jonathan Druart --- Created attachment 80664 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80664=edit Bug 21567: Use like instead of ok in RecordedBooks.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21580] Order creation for edifact vendor fails
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21580 Colin Campbell changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |colin.campbell@ptfs-europe. |ity.org |com Status|NEW |Needs Signoff --- Comment #2 from Colin Campbell --- Created attachment 80663 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80663=edit pass the buyer_ean to order routine Call of the subroutine now matchs documentation and passes parameter validation -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
