[Koha-bugs] [Bug 20357] Pod Coverage checking for no public subs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20357 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #9 from Jonathan Druart --- Please provide tests Mark. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22481] Koha::Uploader does not work under Plack
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22481 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=8437 CC||jonathan.dru...@bugs.koha-c ||ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8437] Large database backups and large exports from export.pl fail under plack
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8437 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=22481 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21150] Data inconsistencies - item types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21150 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=22480 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21842] always test Koha::ItemType in defined
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21842 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=22480 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22480] itemtype/itype is used to join allot of tables, but often isn't defined as a key
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22480 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=21150, ||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=21842 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21953] Term "Lost item" untranslatable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21953 Jonathan Druart changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21953] Term "Lost item" untranslatable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21953 Jonathan Druart changed: What|Removed |Added Attachment #86210|0 |1 is obsolete|| Attachment #86211|0 |1 is obsolete|| --- Comment #11 from Jonathan Druart --- Created attachment 86405 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86405=edit Bug 21953: Add tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21953] Term "Lost item" untranslatable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21953 --- Comment #12 from Jonathan Druart --- Created attachment 86406 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86406=edit Bug 21953: Update existing rows in DB -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22483] haspermissions used to support passing 'undef' for $flagsrequired
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22483 Pierre-Marc Thibault changed: What|Removed |Added CC|pierre-marc.thibault@inlibr | |o.com | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22483] haspermissions used to support passing 'undef' for $flagsrequired
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22483 --- Comment #19 from Jonathan Druart --- (In reply to Martin Renvoize from comment #0) > This functionality was in use in two places. /svc/members/search and > /Koha/REST/V1/Auth.pm. About /svc/members/search: at first glance I think we should rewrite this code to adapt it, not the other way around. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22483] haspermissions used to support passing 'undef' for $flagsrequired
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22483 --- Comment #18 from Jonathan Druart --- 2087 return 1 unless defined($flagsrequired); # This is horrifying but restores behaviour prior to bug 22031 Are you sure about that? I do not see any situations where is returned 1 before 22031. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22483] haspermissions used to support passing 'undef' for $flagsrequired
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22483
Pierre-Marc Thibault changed:
What|Removed |Added
CC||pierre-marc.thibault@inlibr
||o.com
--- Comment #17 from Pierre-Marc Thibault ---
I found a bug related to this bugzilla. When one tries to create a course
reserve, a software error occurs with the following message :
Can't use string ("1") as a HASH ref while "strict refs" in use at /C4/Auth.pm
line 302.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22483] haspermissions used to support passing 'undef' for $flagsrequired
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22483
Jonathan Druart changed:
What|Removed |Added
Keywords||additional_work_needed
--- Comment #16 from Jonathan Druart
---
Login at the OPAC is impossible:
Can't use string ("1") as a HASH ref while "strict refs" in use at
/home/vagrant/kohaclone/C4/Auth.pm line 202.
at /home/vagrant/kohaclone/C4/Auth.pm line 192
Caught by t/db_dependent/selenium/authentication.t, always good to run those
tests to make sure there are no obvious regressions.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22476] MarkLostItemsAsReturned has wrong defaults for new installs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22476 Bin changed: What|Removed |Added Attachment #86303|0 |1 is obsolete|| --- Comment #2 from Bin --- Created attachment 86404 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86404=edit Bug 22476: Correct default for MarkLostItemsAsReturned Signed-off-by: Bin Wen -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22219] C4::Biblio->GetItemsForInventory can return wrong count / duplicated items when skipping waiting holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22219 Pierre-Marc Thibault changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||pierre-marc.thibault@inlibr ||o.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22219] C4::Biblio->GetItemsForInventory can return wrong count / duplicated items when skipping waiting holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22219 Pierre-Marc Thibault changed: What|Removed |Added Attachment #86031|0 |1 is obsolete|| --- Comment #4 from Pierre-Marc Thibault --- Created attachment 86403 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86403=edit Bug 22219: Remove duplicated items in inventory (when skipping waiting holds) Test plan: 0/ Do not apply this patch 1/ Place several holds on a given item 2/ Use the inventory with the "skip waiting holds" option to list this item. It will be displayed several times 3/ Apply this patch and confirm that the item is now only displayed once Signed-off-by: Pierre-Marc Thibault -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22219] C4::Biblio->GetItemsForInventory can return wrong count / duplicated items when skipping waiting holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22219 Pierre-Marc Thibault changed: What|Removed |Added Attachment #86030|0 |1 is obsolete|| --- Comment #3 from Pierre-Marc Thibault --- Created attachment 86402 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86402=edit Bug 22219: Add tests Signed-off-by: Pierre-Marc Thibault -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19046] IntranetCatalogSearchPulldown doesn't retain last selection
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19046 Pierre-Marc Thibault changed: What|Removed |Added CC||pierre-marc.thibault@inlibr ||o.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19046] IntranetCatalogSearchPulldown doesn't retain last selection
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19046 Pierre-Marc Thibault changed: What|Removed |Added Attachment #86024|0 |1 is obsolete|| --- Comment #5 from Pierre-Marc Thibault --- Created attachment 86401 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86401=edit Bug 19046: Make seach pulldown to retain index selection This patch also fixes add the term in the search input Test plan: Enable IntranetCatalogSearchPulldown Search for a term using the search input in the header (simple search) Re-do selecting different indices The selection must retain on the search result page. Signed-off-by: Pierre-Marc Thibault -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21030] Date widget on suspend modal not working correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21030 Pierre-Marc Thibault changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21030] Date widget on suspend modal not working correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21030 Pierre-Marc Thibault changed: What|Removed |Added Attachment #86111|0 |1 is obsolete|| --- Comment #5 from Pierre-Marc Thibault --- Created attachment 86400 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86400=edit Bug 21030: Date widget on suspend modal not working correctly This patch makes a change to the suspend hold modal markup in order to allow the datepicker to work properly. To test, apply the patch and locate a patron in the staff client who has holds. - On the checkout or patron detail page, open the holds tab. - Click the "Suspend" button for one of the holds. - In the modal, trigger the date picker and confirm that the dropdowns for selecting month and year work correctly. Signed-off-by: Pierre-Marc Thibault -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20830] Make sure a fund is selected when ordering from staged file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20830 Pierre-Marc Thibault changed: What|Removed |Added CC||pierre-marc.thibault@inlibr ||o.com Status|Needs Signoff |Patch doesn't apply --- Comment #6 from Pierre-Marc Thibault --- When I try to apply, I have this error message : Applying: Bug 20830: Make sure a fund is selected when ordering from staged file Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/en/modules/acqui/addorderiso2709.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/acqui/addorderiso2709.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/acqui/addorderiso2709.tt error: Failed to merge in the changes. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22300] Staff search results: Opt groups in 'sort' pull down are not well formatted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22300 Jesse Maseto changed: What|Removed |Added Resolution|--- |FIXED CC||je...@bywatersolutions.com Status|Pushed to Stable|RESOLVED --- Comment #8 from Jesse Maseto --- Patch doesn't apply cleanly. Please rebase if needed for 18.05.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22084] Plugin upgrade method and database plugin version storage will never be triggered for existing installs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22084 Jesse Maseto changed: What|Removed |Added CC||je...@bywatersolutions.com --- Comment #10 from Jesse Maseto --- Pushed to 18.05.x for 18.05.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22475] Shelving location doesn't appear on tags list view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22475 Pierre-Marc Thibault changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply --- Comment #2 from Pierre-Marc Thibault --- When I try to apply the patch, I have an error message : Applying: Bug 22475: Shelving location doesn't appear on tags list view fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/tags/list.tt). error: could not build fake ancestor -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22477] Missing DataTables configuration when searching patrons for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22477 Bin changed: What|Removed |Added Attachment #86398|0 |1 is obsolete|| --- Comment #3 from Bin --- Created attachment 86399 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86399=edit Bug 22477: Missing DataTables configuration when searching patrons for holds This patch adds columns configuration to the holds request page to fix a JavaScript error in the console and to allow the patron search results table to be enabled as a DataTable. To reproduce: Place a hold on a title in the staff client. When prompted for a patron, perform a search which will return multiple results. The patron search results will appear in an unsortable table. A JS error can be seen in the browser console. To test, apply the patch and repeat the steps above. The patron search results table should be sortable and there should be no JS error. Signed-off-by: Pierre-Marc Thibault Signed-off-by: Bin Wen -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21765] AutoUnsuspendReserves manually sets holds fields instead of calling ->resume
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21765 Jesse Maseto changed: What|Removed |Added CC||je...@bywatersolutions.com --- Comment #10 from Jesse Maseto --- Pushed to 18.05.x for 18.05.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22397] Wrong message in koha-sip --start
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22397 Jesse Maseto changed: What|Removed |Added CC||je...@bywatersolutions.com Status|Pushed to Stable|RESOLVED Resolution|--- |FIXED --- Comment #6 from Jesse Maseto --- Patch not needed for 18.05.x. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22477] Missing DataTables configuration when searching patrons for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22477 Pierre-Marc Thibault changed: What|Removed |Added Attachment #86328|0 |1 is obsolete|| --- Comment #2 from Pierre-Marc Thibault --- Created attachment 86398 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86398=edit Bug 22477: Missing DataTables configuration when searching patrons for holds This patch adds columns configuration to the holds request page to fix a JavaScript error in the console and to allow the patron search results table to be enabled as a DataTable. To reproduce: Place a hold on a title in the staff client. When prompted for a patron, perform a search which will return multiple results. The patron search results will appear in an unsortable table. A JS error can be seen in the browser console. To test, apply the patch and repeat the steps above. The patron search results table should be sortable and there should be no JS error. Signed-off-by: Pierre-Marc Thibault -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22477] Missing DataTables configuration when searching patrons for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22477 Pierre-Marc Thibault changed: What|Removed |Added CC||pierre-marc.thibault@inlibr ||o.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18251] SCO alerts - need a trigger for successful checkouts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18251 Bug 18251 depends on bug 22378, which changed state. Bug 22378 Summary: Fix sound alerts on SCO https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22378 What|Removed |Added Status|Pushed to Stable|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22441] SCO sound alerts need a selenium test
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22441 Bug 22441 depends on bug 22378, which changed state. Bug 22378 Summary: Fix sound alerts on SCO https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22378 What|Removed |Added Status|Pushed to Stable|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22378] Fix sound alerts on SCO
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22378 Jesse Maseto changed: What|Removed |Added Status|Pushed to Stable|RESOLVED Resolution|--- |FIXED CC||je...@bywatersolutions.com --- Comment #6 from Jesse Maseto --- Patch doesn't apply cleanly. Please rebase if needed for 18.05.x. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22483] haspermissions used to support passing 'undef' for $flagsrequired
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22483 Tomás Cohen Arazi changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |tomasco...@gmail.com |y.org | Target Milestone|--- |19.05 --- Comment #15 from Tomás Cohen Arazi --- I've pushed this follow-up bug that restores the previous behavior for haspermission regarding undef. It highlighted "interesting" bugs and flawed design in our mixed up authentication-authorization methods. Specially how the rest of the code adapts to those side effects. We will certainly file new bugs for things that where raised. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22411] Dates in log viewer not formatted correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22411 Jesse Maseto changed: What|Removed |Added CC||je...@bywatersolutions.com --- Comment #6 from Jesse Maseto --- Pushed to 18.05.x for 18.05.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22483] haspermissions used to support passing 'undef' for $flagsrequired
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22483 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #14 from Tomás Cohen Arazi --- Patches pushed to master for 19.05 Thanks all! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22483] haspermissions used to support passing 'undef' for $flagsrequired
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22483 Tomás Cohen Arazi changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22483] haspermissions used to support passing 'undef' for $flagsrequired
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22483 Tomás Cohen Arazi changed: What|Removed |Added Attachment #86394|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22483] haspermissions used to support passing 'undef' for $flagsrequired
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22483 Tomás Cohen Arazi changed: What|Removed |Added Attachment #86392|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22483] haspermissions used to support passing 'undef' for $flagsrequired
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22483 Tomás Cohen Arazi changed: What|Removed |Added Attachment #86395|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22483] haspermissions used to support passing 'undef' for $flagsrequired
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22483 Tomás Cohen Arazi changed: What|Removed |Added Attachment #86390|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22483] haspermissions used to support passing 'undef' for $flagsrequired
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22483 Tomás Cohen Arazi changed: What|Removed |Added Attachment #86391|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22483] haspermissions used to support passing 'undef' for $flagsrequired
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22483 Tomás Cohen Arazi changed: What|Removed |Added Attachment #86393|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15149] Serials: Test prediction pattern does not consider Subscription start and end date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15149 Jesse Maseto changed: What|Removed |Added CC||je...@bywatersolutions.com --- Comment #11 from Jesse Maseto --- Pushed to 18.05.x for 18.05.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22250] Clean up Mana KB integration with serials and reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22250 Michal Denar changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22250] Clean up Mana KB integration with serials and reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22250 Michal Denar changed: What|Removed |Added Attachment #85784|0 |1 is obsolete|| --- Comment #4 from Michal Denar --- Created attachment 86397 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86397=edit Bug 22250: Clean up Mana KB integration with serials and reports This patch makes many changes to templates and JavaScript related to the integration of Mana with serials reports: - Many incorrect uses of the raw filter with html - Corrections to Bootstrap modal markup - Untranslatable strings moved out of JavaScript - Removed markup and JavaScript related to reports comments, a feature which doesn't exist in this version. New include file: mana/mana-comment-status.inc This file contains hidden-by-default messages which are shown during the process of submitting a comment on a subscription. New include file: mana/mana-share-report.inc This file contains the "Share report" modal markup formerly in guided_reports_start.tt New JavaScript file: mana.js Previously mana.inc, an include file containing only JavaScript which didn't include any template processing. Changed: mana/mana-report-search-result.inc This include file is now a full template so that jQuery's load() function can be used to pull its contents into the reports search modal. Changed: svc/mana/search This script was returning json-encoded HTML. Now it returns regular HTML. To test you must have Mana configured and enabled. Apply the patch and go to Reports -> Saved reports. - Choose New report -> New SQL from Mana. A "Mana search" modal should appear. - Perform a search which will return results, e.g. "circulation." - A "Loading" indicator should appear while the results are being retrieved. It should disappear when results appear. - Results should appear in the DataTable with sorting, paging, and search options. - In the "Notes" column, notes longer than 200 characters should be truncated with a "Show more" link. Clicking it should expand the comment and reveal a "Show less" link in its place. - Click the "Import" button (previously "Use"). The button icon should change to a loading indicator. - When the import is complete you should be redirected to a view of your new report. Go to Serials and click the "Search on Mana" link in the sidebar. - Perform a search for a serial - Results should appear in a DataTable with sorting, paging, and search options. - Sorting by title should ignore articles "a," "an," and "the." Create a new subscription or edit an existing subscription which will match a record in Mana. - On the second step of adding/editing the subscription a message should appear at the top of the form, "Searching for subscription in Mana Knowledge Base," with a loading icon. - When searching has completed a "Show Mana results" link should appear. - Clicking the link should trigger a modal showing search results which match your subscription, displayed in a DataTable with sorting, paging, and search options. - The last column of the table should contain "Import" and "Report" buttons. - Clicking the "Report" button should trigger a menu. Any existing comments will be listed as well as a "New comment" item. - Clicking an existing comment should cause the menu to close and a "Submitting comment" message to appear. It should be shortly replaced with a "Your comment has been submitted" message. - Clicking "New comment" should reveal a comment form. - It should not be possible to submit an empty comment. - Clicking the "cancel" link should redisplay the search results. - Submitting a new comment should trigger a "Submitting comment" message followed by a "Your comment has been submitted" message. - In the table of search results, click the "Import" button (previously "Use"). The button icon should change to a loading indicator. - The modal should close and the data from Mana should be loaded into the subscription entry form. View the detail page of a subscription which has saved with Mana data. - There should be a "Report mistake" button in the toolbar. Clicking it should reveal a menu of comments like the one you saw previously. - Clicking an existing comment should cause the menu to close and a "Submitting comment" message to appear. It should be shortly replaced with a "Your comment has been submitted" message. - Clicking "New comment" should reveal a comment form modal. - It should not be possible to submit an empty comment. - Clicking the "cancel" link should hide the modal. - Submitting a new comment
[Koha-bugs] [Bug 18957] Item renewed online does not show the time of renewal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18957 Jesse Maseto changed: What|Removed |Added Resolution|--- |FIXED CC||je...@bywatersolutions.com Status|Pushed to Stable|RESOLVED --- Comment #16 from Jesse Maseto --- Doesn't apply cleanly to 18.05.x. Please rebase to 18.05.x if needed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14850] Funds from inactive budgets appear in 'Funds' dropdown on acqui/invoice.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14850 Jesse Maseto changed: What|Removed |Added Resolution|--- |FIXED CC||je...@bywatersolutions.com Status|Pushed to Stable|RESOLVED --- Comment #21 from Jesse Maseto --- Did not apply to 18.05.x. Please rebase to 18.05.x if needed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22405] Funds from inactive budgets appear in 'Funds' dropdown on acqui/orderreceive.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22405 Bug 22405 depends on bug 14850, which changed state. Bug 14850 Summary: Funds from inactive budgets appear in 'Funds' dropdown on acqui/invoice.pl https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14850 What|Removed |Added Status|Pushed to Stable|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17510] marc modification templates ignore subfield $0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17510 Sarah Cornell changed: What|Removed |Added CC||sbcornell@cityofportsmouth. ||com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22486] New: Limit Patron expiry notices by category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22486 Bug ID: 22486 Summary: Limit Patron expiry notices by category Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com Target Milestone: --- -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22222] Mana subscription search always returns all results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2 Michal Denar changed: What|Removed |Added Attachment #86043|0 |1 is obsolete|| --- Comment #2 from Michal Denar --- Created attachment 86396 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86396=edit Bug 2: Don't send empty params to mana service Test plan: 0) Do not apply the patch 1) Go to serials > Search on Mana 2) Insert some value into the form 3) Submit -> you get many (3000+) results 4) Apply the patch and restart_all 5) Repeat, now, you get only the subscription matching your query Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22222] Mana subscription search always returns all results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2 Michal Denar changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22483] haspermissions used to support passing 'undef' for $flagsrequired
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22483 Kyle M Hall changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22483] haspermissions used to support passing 'undef' for $flagsrequired
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22483 --- Comment #12 from Kyle M Hall --- Created attachment 86394 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86394=edit Bug 22483: (follow-up) Fix wrong tests higlighted by bug Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22483] haspermissions used to support passing 'undef' for $flagsrequired
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22483 --- Comment #13 from Kyle M Hall --- Created attachment 86395 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86395=edit Bug 22483: Restore undef behaviour Turns out that we rely heavily on the side effect that passing undef to haspermission would always return true no matter what permissions or lack of permissions you had. Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22483] haspermissions used to support passing 'undef' for $flagsrequired
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22483 --- Comment #11 from Kyle M Hall --- Created attachment 86393 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86393=edit Bug 22483: (QA follow-up) Tweaking call to haspermission This patch tweaks the logic to check the permissions is defined before passing to haspermission. Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22483] haspermissions used to support passing 'undef' for $flagsrequired
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22483 --- Comment #10 from Kyle M Hall --- Created attachment 86392 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86392=edit Bug 22483: (QA follow-up) Corrections to logic in check_cookie_auth check_cookie_auth needs to allow for cases where we wish to check for ANY permission and cases where we wish to skip the permissions check entirely and just authenticate the session. Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22483] haspermissions used to support passing 'undef' for $flagsrequired
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22483 --- Comment #9 from Kyle M Hall --- Created attachment 86391 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86391=edit Bug 22483: (follow-up) Improve POD as requested in bug 22031 Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22483] haspermissions used to support passing 'undef' for $flagsrequired
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22483 Kyle M Hall changed: What|Removed |Added Attachment #86379|0 |1 is obsolete|| Attachment #86380|0 |1 is obsolete|| Attachment #86385|0 |1 is obsolete|| Attachment #86386|0 |1 is obsolete|| Attachment #86388|0 |1 is obsolete|| Attachment #86389|0 |1 is obsolete|| --- Comment #8 from Kyle M Hall --- Created attachment 86390 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86390=edit Bug 22483: Explicitly ban 'undef' as a valid $flagsrequired Before bug 22031 the haspermission subroutine signature allowed for passing 'undef' to mean 'any permission' in $flagsrequired. This feels like a mistake and was only in practical use in two places in the codebase. This patch explicitly forbids this practice (`*` may be used to the same result and is more explicit in it's nature) and replaces the two instances of it's use. Test Plan 1. Before this patch, the API tests are all failing with authentication errors 2. After this patch the API tests should now all pass. 3. t/db_dependent/Auth/haspermission.t should continue to pass (with one addition subtest added herin) 3. /svc/members/search is not unit tested. Please check that patron searching still yields results in the UI after this patch. Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22396] koha-sip script does not start the server correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22396 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #8 from Lucas Gass --- missing 18562 dependency for 18.05.x, wont backport -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22170] Library group description input field should be longer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22170 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #10 from Lucas Gass --- backported to 18.05.x for 18.05.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22130] Batch checkout: authorized value description is never shown with notforloan status
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22130 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #13 from Lucas Gass --- backported to 18.05.x for 18.05.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22483] haspermissions used to support passing 'undef' for $flagsrequired
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22483 Martin Renvoize changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22483] haspermissions used to support passing 'undef' for $flagsrequired
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22483 --- Comment #7 from Martin Renvoize --- Created attachment 86389 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86389=edit Bug 22483: Restore undef behaviour Turns out that we rely heavily on the side effect that passing undef to haspermission would always return true no matter what permissions or lack of permissions you had. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22483] haspermissions used to support passing 'undef' for $flagsrequired
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22483 --- Comment #6 from Tomás Cohen Arazi --- Created attachment 86388 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86388=edit Bug 22483: (follow-up) Fix wrong tests higlighted by bug Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22080] Easier translation of ElasticSearch mappings page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22080 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #17 from Lucas Gass --- skipping this ES patch in 18.05.x, if I am wrong let me know -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21335] Remove redundant includes of right-to-left.css
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21335 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #8 from Lucas Gass --- i cant rebase this in 18.05.x and pass the qa tool: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/editor.tt SKIP filters OK forbidden patterns OK git manipulation OK js_in_body OK spelling OK tt_valid FAIL valid_template : filter not found skipping unless needed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18166] Show internal and vendor notes for received orders
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18166 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #7 from Lucas Gass --- backported to 18.05.x for 18.05.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21198] authenticate_api_request should stash the reason access is granted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21198 --- Comment #6 from Martin Renvoize --- In reality, what I believe would be considerably more useful is for us to implement the FIXME in C4::Auth->haspermission `#FIXME - This fcn should return the failed permission so a suitable error msg can be delivered.` Passing back the permission one is missing, perhaps as a catch-able Koha::Exception or something would be a distinctly more useful pattern. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21198] authenticate_api_request should stash the reason access is granted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21198 Martin Renvoize changed: What|Removed |Added Resolution|--- |INVALID Status|Failed QA |RESOLVED --- Comment #5 from Martin Renvoize --- At this point I'm not sure this really serves any purpose.. I'm going to mark it as invalid for now. We can always revisit it in the future should we choose to do so. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21063] Allow columns in intranet ILL request datatable to be customisable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21063 Chris Slone changed: What|Removed |Added CC||cslone@camdencountylibrary. ||org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22287] Correct new charts CSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22287 Chris Slone changed: What|Removed |Added CC||cslone@camdencountylibrary. ||org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22023] Further improve responsive layout handling of staff client menu bar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22023 Chris Slone changed: What|Removed |Added CC||cslone@camdencountylibrary. ||org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16149] Generate and send custom notices based on report output
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16149 Chris Slone changed: What|Removed |Added CC||cslone@camdencountylibrary. ||org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19266] Add ability to update 005 during import of records and check 001 uniqueness on save to batch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19266 Alex Arnaud changed: What|Removed |Added Attachment #77905|0 |1 is obsolete|| --- Comment #4 from Alex Arnaud --- Created attachment 86387 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86387=edit Bug 19266: Allow 001 checking on save to batch and 005 update on import of records To test: 1 - Export a set of records with control numbers from your system 2 - Stage those records 3 - Note during staging a new option to update the 005 4 - Check records after staging 5 - Note 005 is updated or not as the option is selected 6 - Open the advanced cataloging editor 7 - Under settings choose Import Batches 8 - Set the batch you just imported as a save target 9 - Select that batch only as save target 10 - Create a new record, give it the control number of a record in the batch 11 - Attempt to save to the batch 12 - You get an error 13 - Save overriding warnings 14 - The record is then added to the batch Rebased-on 2019-03-08 (alex.arn...@biblibre.com) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20563] ILL request list gives no indication of source and/or target
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20563 Chris Slone changed: What|Removed |Added CC||cslone@camdencountylibrary. ||org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18064] Long overdue cronjob does not follow the library's calendar and skip closed days
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18064 Chris Slone changed: What|Removed |Added CC||cslone@camdencountylibrary. ||org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17509] Notify patrons to return items requested on hold by another person
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509 Chris Slone changed: What|Removed |Added CC||cslone@camdencountylibrary. ||org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18589] Show ILLs as part of patron profile
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 Chris Slone changed: What|Removed |Added CC||cslone@camdencountylibrary. ||org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22413] Elasticsearch - Index title is lost after sorting
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22413 Margaret changed: What|Removed |Added CC||margaret@bywatersolutions.c ||om -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16440] Update report parameters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16440 Chris Slone changed: What|Removed |Added CC||cslone@camdencountylibrary. ||org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22483] haspermissions used to support passing 'undef' for $flagsrequired
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22483 --- Comment #5 from Martin Renvoize --- Created attachment 86386 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86386=edit Bug 22483: (QA follow-up) Tweaking call to haspermission This patch tweaks the logic to check the permissions is defined before passing to haspermission. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3342] Changes to holds priority list should be logged for accountability
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3342 Jessie Zairo changed: What|Removed |Added CC||jza...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22450] Show if due date or return date has been changed from circ rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22450 Chris Slone changed: What|Removed |Added CC||cslone@camdencountylibrary. ||org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20208] Custom file upload paths
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20208 Liz Rea changed: What|Removed |Added Status|Needs Signoff |In Discussion --- Comment #7 from Liz Rea --- I was unable to get this to work, I think I need some additional information regarding setup parameters. Namely: Where do the paths to be input into the authorised velue start from, / or /var/lib/koha//uploads or somewhere else? This needs documentation at least. I was expecting to be able to get to the hashless files by going to them at http://host/uploads/custom/path/file.jpg type of URL, but this didn't work that I could see. It could be related to the above question. The files did seem to get uploaded to the directory, but I was unable to retrieve them with a reasonable URL. I believe that's what the requester is probably looking for. The interface for finding uploaded files needs a LOT of work, though technically that is independent of this development (but actually, it's kinda not!). Users will have to be very disciplined with file names and potentially have external documentation to have a hope of finding files using a search only. I think this interface needs rework urgently to have either a gallery style or directory hierarchy style display. Even a link to "list all files" with their web URL and/or file system path (as security allows) would be a huge improvement. Cheers, Liz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21187] GDPR: Force patrons password renew
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21187 claire.hernan...@biblibre.com changed: What|Removed |Added CC||claire.hernandez@biblibre.c ||om -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22483] haspermissions used to support passing 'undef' for $flagsrequired
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22483 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |ASSIGNED --- Comment #4 from Martin Renvoize --- One step closer.. still another followup required to correct the logic for the /public endpoints where we are still inadvertently passing 'undef' to haspermission -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22483] haspermissions used to support passing 'undef' for $flagsrequired
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22483 --- Comment #3 from Martin Renvoize --- Created attachment 86385 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86385=edit Bug 22483: (QA follow-up) Corrections to logic in check_cookie_auth check_cookie_auth needs to allow for cases where we wish to check for ANY permission and cases where we wish to skip the permissions check entirely and just authenticate the session. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19265] Advanced Editor - Rancor - Add ability to export selected records from and import records into an import batch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19265 Alex Arnaud changed: What|Removed |Added Status|BLOCKED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21683] Remove accountlines.accountno
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 --- Comment #42 from Martin Renvoize --- Agreed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 --- Comment #163 from Martin Renvoize --- I think I'm happy with Nicks logic here.. Unfortunately, as we store calculated values we're open to having issues like this. EDI for example can often give you both tax inclusive and tax exclusive values and pretty often the rounding math at their end will be different from at our end and so yield different results. I think this patch improves the situation a fair amount and is a good compromise given our existing codebase.. perhaps it's the foundations for more work in a followup bug but I don't think that should hold up this work any longer really.. Did you have any more specific issues Marcel, that Nick could go on for keeping this moving? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22480] itemtype/itype is used to join allot of tables, but often isn't defined as a key
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22480 Martin Renvoize changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22462] Crash in patron card printing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22462 Victor Grousset/tuxayo changed: What|Removed |Added CC||cecile.jo...@biblibre.com, ||victor.grous...@biblibre.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20478] Advance notices: send separate digest messages per branch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20478 Martin Renvoize changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20478] Advance notices: send separate digest messages per branch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20478
Martin Renvoize changed:
What|Removed |Added
Status|Signed Off |Passed QA
CC||martin.renvoize@ptfs-europe
||.com
--- Comment #23 from Martin Renvoize ---
(In reply to Jonathan Druart from comment #18)
> Great to see tests for this code, even if done in an unusual way.
>
> Some quick remarks:
> 1. Transactions must be done using txn_begin (also note that you are setting
> AutoCommit off in the sub and rollback at the end => no sense)
>
> 2. $ENV{"OVERRIDE_SYSPREF_dateformat"} = 'metric';
> Why not set_preference? Note that for test we usually use mock_preference
> (from t::lib::Mocks) to avoid to mess with the cache.
>
> 3. You could use build_sample_item from bug 21971 to simplify the objects
> creation (not pushed yet)
>
> 4. use Koha::DateUtils instead of DateTime directly
>
> 5. You could use File::Slurp::read_file to simplify a bit the code
>
> I would have preferred to see the code moved to a module. It would have
> eased the write of the tests and made the code reusable.
>
> Keeping the SO status to get other QA opinions.
I've cleaned up the test a little to make it a bit more 'koha', but I've not
gone as far as Jonathan suggests above.. I feel these additional clean ups
could be handled separately, like the factoring out of code into a module for
example.
Code works and passes all tests.. It's also great to see a cronscript with
tests.
Passing QA
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20478] Advance notices: send separate digest messages per branch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20478 Martin Renvoize changed: What|Removed |Added Attachment #80902|0 |1 is obsolete|| --- Comment #20 from Martin Renvoize --- Created attachment 86382 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86382=edit Bug 20478: Refactor to remove code duplication. Signed-off-by: Magnus Enger Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20478] Advance notices: send separate digest messages per branch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20478 Martin Renvoize changed: What|Removed |Added Attachment #80903|0 |1 is obsolete|| --- Comment #21 from Martin Renvoize --- Created attachment 86383 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86383=edit Bug 20478: Have the cronjob script advance_notices.pl send digest messages per branch. Desired behavior of the script advance_notices.pl is that the sender address on the notice message is that of the branch of the issues in question. Thus, the solution is to generate digest messages per branch. To test: 1) Inspect unit test in t/db_dependent/cronjobs/advance_notices_digest.t and note that: - There are three libraries - There is a borrower - The borrower is registered at library1 - The borrower has message preference wants_digest set to 1 - The borrower has message preference days_in_advance set to 1 - The content of the letter PREDUEDGST is '<> <>' - There are three items - There is one issue per item - There is one issues at library2 - There are two issues at library3 - The date_due of the issues are set to tomorrow - For the default case (no -digest-per-message) - It is asserted that there is one message in the message queue after running the script - It is asserted that there are three items in the message. - It is asserted that the branchname is that of the borrower's home library. - For the case where -digest-per-message is enabled - It is asserted that there are two messages in the message queue after running the script - It is asserted that the item count of the message corresponding to library2 is 1 - It is asserted that the item count of the message corresponding to library3 is 2 - It is asserted that the branchnames are correct. 2) Run unit test: prove t/db_dependent/cronjobs/advance_notices_digest.t Sponsored-By: Bibliotek Mellansjö, which is a cooperation between Sponsored-By: Gullspångs kommunbibliotek Sponsored-By: Hjo stadsbibliotek Sponsored-By: Karlsborgs bibliotek Sponsored-By: Mariestads stadsbibliotek Sponsored-By: Skövde stadsbibliotek Sponsored-By: Tibro bibliotek Sponsored-By: Tidaholms stadsbibliotek Sponsored-By: Töreboda kommunbibliotek Signed-off-by: Andreas Jonsson Signed-off-by: Magnus Enger Adding the --digest-per-branch switch turns the digest into one digest per library. I think it makes perfect sense to keep the default behaviour and hide this new functionality behind a command line switch. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20478] Advance notices: send separate digest messages per branch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20478 Martin Renvoize changed: What|Removed |Added Attachment #80901|0 |1 is obsolete|| --- Comment #19 from Martin Renvoize --- Created attachment 86381 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86381=edit Bug 20478: Add unit test for advance_notices.pl cronjob. Signed-off-by: Magnus Enger Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
