[Koha-bugs] [Bug 14576] Allow automatic update of location on checkin

2019-03-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576

Martin Renvoize  changed:

   What|Removed |Added

   Keywords||Manual

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22547] C4::Overdues - UpdateFine is barely tested

2019-03-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22547

--- Comment #9 from Martin Renvoize  ---
Hmm, I've been debating this a bit today. I think I was really aiming for a
strict Unit Test here and as such wanted minimal reliance on thinks like the
pay functions.

I do agree, we really want to also have a level of integration tests but I'm
not sure it's appropriate in this case.

I'll ponder how/where to add such an integration tests too.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10345] Copy number should be incremented when adding multiple items at once

2019-03-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10345

Pierre-Marc Thibault  changed:

   What|Removed |Added

 CC||pierre-marc.thibault@inlibr
   ||o.com
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10345] Copy number should be incremented when adding multiple items at once

2019-03-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10345

Pierre-Marc Thibault  changed:

   What|Removed |Added

  Attachment #87153|0   |1
is obsolete||

--- Comment #5 from Pierre-Marc Thibault  ---
Created attachment 87237
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87237&action=edit
Bug 10345: Increment copy number when adding multiple copies.

To test:
1. Add multiple copies of an item with data in the 'Copy number' field. Note
that tha data will be identical for all items.
2. Apply patch.
3. Add multiple copies of an item with a positive integer (ie. only digits) in
the 'Copy number' field. Note that the copy number is incremented for each
item.
4. Add multiple copies of an item with some other type of data in the 'Copy
number' field. Note that the copy number field remains unchanged for the added
items.

Signed-off-by: Pierre-Marc Thibault 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12502] Add columns for note, order number and ISBN to late orders page

2019-03-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502

--- Comment #33 from Pierre-Marc Thibault  ---
Patch rebased. I am still waiting for advises before continuing.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12502] Add columns for note, order number and ISBN to late orders page

2019-03-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502

Pierre-Marc Thibault  changed:

   What|Removed |Added

  Attachment #80602|0   |1
is obsolete||

--- Comment #32 from Pierre-Marc Thibault  ---
Created attachment 87236
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87236&action=edit
Bug 12502: Add vendor note, internal note, ordernumber and isbn to late orders
page

Test plan:

0) Make sure you have a late order
a) Create a test vendor unless you have one
b) Create a test basket unless you have one
c) Close the basket to mark the order as late
1) Go to the late orders table
Before patch : Orderno, ISBN, vendor notes, internal notes are absent
After patch: fields are present

2) Edit the vendor note and/or the internal note
3) Press the save notes button
4) Refresh page and cache (CTRL+F5), if notes have been correctly saved, your
modifications should be displayed.

Signed-off-by: Alex Buckley 
Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19817] Merge local and online documentations

2019-03-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

aplicacoes.d...@cm-portimao.pt  changed:

   What|Removed |Added

 CC||aplicacoes.dmsi@cm-portimao
   ||.pt
 Resolution|FIXED   |---
 Status|RESOLVED|REOPENED

--- Comment #110 from aplicacoes.d...@cm-portimao.pt 
 ---
Setting KohaManualBaseURL to https://koha-community.org/manual and 
using user interface language pt~PT, the help link is redirected (for example)
to https://koha-community.org/manual/18.11/pt_BZ/html/systempreferences.html
displaying an error page.

I guess its related with a typo on line 22 in the file Manual.pm 
22my @available_languages = qw( en ar cs es fr it pt_BZ tz zh_TW );

Tested replacing the value pt_BZ by pt_BR and the link now works.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21481] Translation tool still references to help templates

2019-03-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21481
Bug 21481 depends on bug 19817, which changed state.

Bug 19817 Summary: Merge local and online documentations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21483] Translate script displays an error about missing "help" directory

2019-03-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21483
Bug 21483 depends on bug 19817, which changed state.

Bug 19817 Summary: Merge local and online documentations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22410] Software error while adding order on a MARC file record without an author

2019-03-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22410

Pierre-Marc Thibault  changed:

   What|Removed |Added

 Status|In Discussion   |RESOLVED
 Resolution|--- |INVALID

--- Comment #8 from Pierre-Marc Thibault  ---
Hi Liz,

I read your last comment and it seems like the patch problem wasn't a problem
in the end. By talking with a co-worker, I realize the software error occurred
because z3950NormalizeAuthor was set to Copy while marcflavour was at MARC21. I
didn't think a configuration problem could lead to this so I tried to make the
error disappears with this configuration. 

I will close this ticket since the problem is irrelevant and I can change
z3950NormalizeAuthor to fix my problem. Thank you for your feedback.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22575] Item type administration uses invalid error class for dialog

2019-03-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22575

Bin  changed:

   What|Removed |Added

  Attachment #87234|0   |1
is obsolete||

--- Comment #3 from Bin  ---
Created attachment 87235
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87235&action=edit
Bug 22575: Item type administration uses invalid error class for dialog

This patch modifies the item types administration script so that it
passes a valid message type to the template, where the type is used as a
CSS class. "Error" is a nonexistent dialog class. It should be "alert."

To test, apply the patch and go to Administration -> Item types.

 - Try to delete an item type which is in use. The style of the error
   dialog should be correct.
 - Try to add an item type using a code which already exists. The error
   should look correct.

Signed-off-by: Pierre-Marc Thibault 
Signed-off-by: Bin Wen 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library

2019-03-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

Kyle M Hall  changed:

   What|Removed |Added

 Status|Needs Signoff   |ASSIGNED

--- Comment #9 from Kyle M Hall  ---
Needs a test plan...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22575] Item type administration uses invalid error class for dialog

2019-03-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22575

Pierre-Marc Thibault  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22575] Item type administration uses invalid error class for dialog

2019-03-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22575

Pierre-Marc Thibault  changed:

   What|Removed |Added

  Attachment #87018|0   |1
is obsolete||

--- Comment #2 from Pierre-Marc Thibault  ---
Created attachment 87234
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87234&action=edit
Bug 22575: Item type administration uses invalid error class for dialog

This patch modifies the item types administration script so that it
passes a valid message type to the template, where the type is used as a
CSS class. "Error" is a nonexistent dialog class. It should be "alert."

To test, apply the patch and go to Administration -> Item types.

 - Try to delete an item type which is in use. The style of the error
   dialog should be correct.
 - Try to add an item type using a code which already exists. The error
   should look correct.

Signed-off-by: Pierre-Marc Thibault 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library

2019-03-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

--- Comment #8 from Kyle M Hall  ---
Created attachment 87233
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87233&action=edit
Bug 20256: Add unit tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library

2019-03-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

--- Comment #7 from Kyle M Hall  ---
Created attachment 87232
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87232&action=edit
Bug 20256: Use new methods

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library

2019-03-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

--- Comment #6 from Kyle M Hall  ---
Created attachment 87231
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87231&action=edit
Bug 20256: Update groups editor

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library

2019-03-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

--- Comment #5 from Kyle M Hall  ---
Created attachment 87230
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87230&action=edit
Bug 20256: Update Schema file

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library

2019-03-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

--- Comment #2 from Kyle M Hall  ---
Created attachment 87227
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87227&action=edit
Bug 20256: Add new permission to editor

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library

2019-03-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

--- Comment #4 from Kyle M Hall  ---
Created attachment 87229
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87229&action=edit
Bug 20256: Add new methods for checking item editing permissions

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library

2019-03-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

--- Comment #3 from Kyle M Hall  ---
Created attachment 87228
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87228&action=edit
Bug 20256: Refactor subs for rights to view patrons to make them generic for
general use

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library

2019-03-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

Kyle M Hall  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library

2019-03-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

--- Comment #1 from Kyle M Hall  ---
Created attachment 87226
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87226&action=edit
Bug 20256: Update database

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22312] BlockReturnOfLostItems does not prevent lost items filling holds

2019-03-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22312

--- Comment #1 from Phil Ringnalda  ---
Ah,
http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=C4/Circulation.pm;hb=918dd661b0207366becefd1480257197a353#l2050
checks for $item->withdrawn, but not for $item->itemlost, before filling holds.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21582] Use CodeMirror for *UserJS & *UserCSS

2019-03-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21582

--- Comment #15 from Owen Leonard  ---
(In reply to Pablo AB from comment #14)

> Never think about a WYSIWYG editor.

I will, because this bug isn't about removing the UseWYSIWYGinSystemPreferences
system preference.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21582] Use CodeMirror for *UserJS & *UserCSS

2019-03-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21582

--- Comment #14 from Pablo AB  ---
(In reply to Magnus Enger from comment #12)
> We already have a wysiwyg editor for sysprefs containing HTML, enabled by
> UseWYSIWYGinSystemPreferences

Never think about a WYSIWYG editor. Just syntax highlight would be enough
(following KISS principle).
Considering all the CSS that the HTML code will have over I found this syspref
useless, and therefore probably should be removed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22604] "Error : the selected language is not currently available" for French

2019-03-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22604

--- Comment #2 from houha.khadi...@gmail.com ---
thank you its done now.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21582] Use CodeMirror for *UserJS & *UserCSS

2019-03-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21582

--- Comment #13 from Owen Leonard  ---
(In reply to Magnus Enger from comment #12)
> We already have a wysiwyg editor for sysprefs containing HTML, enabled by
> UseWYSIWYGinSystemPreferences

My plan is to have CodeMirror handle all textareas which handle any kind of
code. If UseWYSIWYGinSystemPreferences is enabled, HTML textareas will be
WYSIWYG.

Anyone have an opinion on whether ISBD should be handled as HTML? I think yes.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21582] Use CodeMirror for *UserJS & *UserCSS

2019-03-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21582

--- Comment #12 from Magnus Enger  ---
We already have a wysiwyg editor for sysprefs containing HTML, enabled by
UseWYSIWYGinSystemPreferences and added in bug 11584.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21582] Use CodeMirror for *UserJS & *UserCSS

2019-03-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21582

Owen Leonard  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |oleon...@myacpl.org
   |ity.org |
 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21582] Use CodeMirror for *UserJS & *UserCSS

2019-03-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21582

--- Comment #11 from Tomás Cohen Arazi  ---
(In reply to Pablo AB from comment #10)
> On bug 13829 (2015) I was suggesting just syntax highlight. I would prefer
> just syntax highlight now than an overkill full editor on 2023.
> The suggestion was not only on *UserJS & *UserCSS but all textareas contain
> source code:
> 
> - Reports: SQL textareas
> - All sysprefs containing HTML, CSS and JS (AFAIK there is no JSON/YAML).
> 
> Probably a full editor is too much and unnecessary (more risk of
> compatibility issues...). For major work (with beautify and linting) I would
> work on a proper text editor.

CodeMirror is already in the codebase. The only difficulty is hooking the
initialization in the right templates... and adding the needed syntaxes support
(we only have it for SQL).

I asked for YAML support on bug 22584.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22611] Typo introduced into Koha::EDI by bug 15685

2019-03-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22611

Martin Renvoize  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22611] Typo introduced into Koha::EDI by bug 15685

2019-03-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22611

Martin Renvoize  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22611] Typo introduced into Koha::EDI by bug 15685

2019-03-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22611

Martin Renvoize  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |martin.renvoize@ptfs-europe
   |ity.org |.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22611] Typo introduced into Koha::EDI by bug 15685

2019-03-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22611

--- Comment #1 from Martin Renvoize  ---
Created attachment 87225
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87225&action=edit
Bug 22611: Correction for typo in Koha::EDI

A typo in Koha::EDI leads to 'The method is not tested' errors to be
thrown when the codepath is taken and can lead to subsequent data
corruption.

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22611] Typo introduced into Koha::EDI by bug 15685

2019-03-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22611

Martin Renvoize  changed:

   What|Removed |Added

 Depends on||15685


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685
[Bug 15685] Allow creation of items (AcqCreateItem) to be customizable
per-basket
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15685] Allow creation of items (AcqCreateItem) to be customizable per-basket

2019-03-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685

Martin Renvoize  changed:

   What|Removed |Added

 Blocks||22611


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22611
[Bug 22611] Typo introduced into Koha::EDI by bug 15685
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22611] New: Typo introduced into Koha::EDI by bug 15685

2019-03-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22611

Bug ID: 22611
   Summary: Typo introduced into Koha::EDI by bug 15685
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: critical
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: martin.renvo...@ptfs-europe.com
QA Contact: testo...@bugs.koha-community.org
  Target Milestone: ---

Koha/EDI.pm - $basket->effective_create_item (Missing the 's'), which will
cause Koha::Objects to throw an 'The method is untested' error whenever his
codepath is followed.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21582] Use CodeMirror for *UserJS & *UserCSS

2019-03-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21582

--- Comment #10 from Pablo AB  ---
On bug 13829 (2015) I was suggesting just syntax highlight. I would prefer just
syntax highlight now than an overkill full editor on 2023.
The suggestion was not only on *UserJS & *UserCSS but all textareas contain
source code:

- Reports: SQL textareas
- All sysprefs containing HTML, CSS and JS (AFAIK there is no JSON/YAML).

Probably a full editor is too much and unnecessary (more risk of compatibility
issues...). For major work (with beautify and linting) I would work on a proper
text editor.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15685] Allow creation of items (AcqCreateItem) to be customizable per-basket

2019-03-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685

Martin Renvoize  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com

--- Comment #87 from Martin Renvoize  ---
There's a typo in this:

Koha/EDI.pm - $basket->effective_create_item (Missing the 's'), which will
cause Koha::Objects to throw an 'The method is untested' error whenever his
codepath is followed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21683] Remove accountlines.accountno

2019-03-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683

Martin Renvoize  changed:

   What|Removed |Added

 Blocks|17702   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702
[Bug 17702] Create configuration for account types
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17702] Create configuration for account types

2019-03-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702

Martin Renvoize  changed:

   What|Removed |Added

 Depends on|21683   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683
[Bug 21683] Remove accountlines.accountno
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18786] Add ability to create custom payment types

2019-03-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786

Martin Renvoize  changed:

   What|Removed |Added

 Blocks||22610


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610
[Bug 22610] SIP Payment Types should be moved out of accountype
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17702] Create configuration for account types

2019-03-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702

Martin Renvoize  changed:

   What|Removed |Added

 Depends on||22610


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610
[Bug 22610] SIP Payment Types should be moved out of accountype
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22610] SIP Payment Types should be moved out of accountype

2019-03-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610

Martin Renvoize  changed:

   What|Removed |Added

 Blocks||17702
 Depends on||18786


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702
[Bug 17702] Create configuration for account types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786
[Bug 18786] Add ability to create custom payment types
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22610] New: SIP Payment Types should be moved out of accountype

2019-03-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610

Bug ID: 22610
   Summary: SIP Payment Types should be moved out of accountype
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: martin.renvo...@ptfs-europe.com
QA Contact: testo...@bugs.koha-community.org
  Target Milestone: ---

Bug 18786 introduced a dedicated payment_type field to the database and an
authorized value for it's population.. we should move the SIP payment type
appendages from accounttype into this AV list.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18786] Add ability to create custom payment types

2019-03-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786

Martin Renvoize  changed:

   What|Removed |Added

 CC||kohapa...@gmail.com

--- Comment #57 from Martin Renvoize  ---
*** Bug 5620 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5620] Capture Mode of payment

2019-03-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5620

Martin Renvoize  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|In Discussion   |RESOLVED

--- Comment #43 from Martin Renvoize  ---


*** This bug has been marked as a duplicate of bug 18786 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14825] Accounts Rewrite Omnibus

2019-03-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825
Bug 14825 depends on bug 5620, which changed state.

Bug 5620 Summary: Capture Mode of payment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5620

   What|Removed |Added

 Status|In Discussion   |RESOLVED
 Resolution|--- |DUPLICATE

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22410] Software error while adding order on a MARC file record without an author

2019-03-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22410

Liz Rea  changed:

   What|Removed |Added

 Status|Needs Signoff   |In Discussion

--- Comment #7 from Liz Rea  ---
Ok, Question.

 z3950NormalizeAuthor
z3950AuthorAuthFields (modified)
Copy|don't copy authors from the UNIMARC tags (separated by commas) [list of
tags] to the correct author tags when importing a record using Z39.50. 

This feature is UNIMARC only? If your catalogue is MARC21, why would you have
this preference set at all?

Cheers,
Liz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21159] Blank item shelving location (952$c) on issue and return based on syspref values

2019-03-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159

Liz Rea  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21159] Blank item shelving location (952$c) on issue and return based on syspref values

2019-03-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159

Liz Rea  changed:

   What|Removed |Added

 CC||wizzy...@gmail.com

--- Comment #24 from Liz Rea  ---
I'm a little confused - one of Alex's patches builds on bug 14576, but Hayley's
seems to want us to test the 2 sysprefs? It looks like it might just be a
commit message problem - i.e. we need alex's test plan, and this most recently
rebased patch to be put together.

Have a look? I'm happy to test this once I know all the bits are in the right
order. :)

Liz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22609] New: Adding a visual mark on the selected authority

2019-03-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22609

Bug ID: 22609
   Summary: Adding a visual mark on the selected authority
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Cataloging
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: alexandre.bre...@ccsr.qc.ca
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl
  Target Milestone: ---

Once we did a search into authorities (from items or from Authorities module),
the last selected authority has no visual mark to identify it in the
authorities list. 

It will be usefull if when we are editing an authority, this authority appears
in a different color (from others ones) until an another one was selected. 

The authorities list can be long and there is no indication where the last
édited one was when we return on the authorities list.

(Similar as bug #7501 for OPAC in 2012 ?)

Thanks,

Alexandre

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22511] Koha::Account::Line->void loses the original type of the credit

2019-03-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #87091|0   |1
is obsolete||

--- Comment #25 from Martin Renvoize  ---
Created attachment 87224
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87224&action=edit
Bug 22511: (follow-up) Fix test plans

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22511] Koha::Account::Line->void loses the original type of the credit

2019-03-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #87089|0   |1
is obsolete||

--- Comment #23 from Martin Renvoize  ---
Created attachment 87222
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87222&action=edit
Bug 22511: Update void method to use status

We added a 'status' field to 'accountlines' in bug 22512 to allow for
more fined grained control over 'types' and 'states'.

This patch updates the void method to utilise this new field so we may
keep the original credit type for later auditing should it be required.

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22511] Koha::Account::Line->void loses the original type of the credit

2019-03-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #87090|0   |1
is obsolete||

--- Comment #24 from Martin Renvoize  ---
Created attachment 87223
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87223&action=edit
Bug 22511: Update UI to use accountlines.status

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22511] Koha::Account::Line->void loses the original type of the credit

2019-03-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #87088|0   |1
is obsolete||

--- Comment #22 from Martin Renvoize  ---
Created attachment 87221
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87221&action=edit
Bug 22511: Update tests

Updated tests to check for 'status' change and fixed 'accounttype' and
moved from t/db_dependent/Accounts.t to the more appropriate
t/db_dependent/Koha/Account/Lines.t

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14169] Item Search csv export

2019-03-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14169

Peggy Thrasher  changed:

   What|Removed |Added

 Status|CLOSED  |REOPENED
 Resolution|INVALID |---

--- Comment #8 from Peggy Thrasher  ---
The issue is the spaces before the double quotes.


Original from Koha:

"Starry night : Macomber, Debbie.", "2013", "Ballantine Books,", "",
"34505003358304"

produces these fields (each field in a subsequent column):
Starry night : Macomber, Debbie.
 "2013" 
 "Ballantine Books  
, ", 34505003358304"

Removing spaces before double quotes results in:

"Starry night : Macomber, Debbie.","2013","Ballantine
Books,","","34505003358304"

which produces these fields:

Starry night : Macomber, Debbie.
2013
Ballantine Books,   
34505003358304

It seems that there isn't a universal standard for CSV files, but
https://en.wikipedia.org/wiki/Comma-separated_values says:

According to RFC 4180, spaces outside quotes in a field are not allowed;
however, the RFC also says that "Spaces are considered part of a field and
should not be ignored." and "Implementors should 'be conservative in what you
do, be liberal in what you accept from others' (RFC 793, section 2.10) when
processing CSV files."
1997, "Ford" ,E350

Reports that are downloaded from Koha in CSV format do not have the extra
space.  Can this code use the same functions as reports?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13829] Syntax highlighter on source code textareas

2019-03-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13829

Owen Leonard  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|NEW |RESOLVED

--- Comment #4 from Owen Leonard  ---


*** This bug has been marked as a duplicate of bug 21582 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21582] Use CodeMirror for *UserJS & *UserCSS

2019-03-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21582

Owen Leonard  changed:

   What|Removed |Added

 CC||pablo.bian...@gmail.com

--- Comment #9 from Owen Leonard  ---
*** Bug 13829 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22608] New: Authentication with Google oAuth does not inherit Default Messaging Preferences from default user category

2019-03-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22608

Bug ID: 22608
   Summary: Authentication with Google oAuth does not inherit
Default Messaging Preferences from default user
category
 Change sponsored?: ---
   Product: Koha
   Version: 18.05
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Authentication
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: cost...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: dpav...@rot13.org
  Target Milestone: ---

GoogleOpenIDConnectDefaultCategory defines the category of a new user when it
is created after oAuth authentication and GoogleOpenIDConnectAutoRegister is ON
(Allow). This procedure should inherit category's Default Messaging Preferences
but now it does not. It would be nice if it could.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22519] We have two accounttypes for "forgiven", 'FOR' and 'FFOR'

2019-03-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22519

Martin Renvoize  changed:

   What|Removed |Added

 Resolution|MOVED   |DUPLICATE

--- Comment #2 from Martin Renvoize  ---


*** This bug has been marked as a duplicate of bug 22521 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22519] We have two accounttypes for "forgiven", 'FOR' and 'FFOR'

2019-03-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22519

Martin Renvoize  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |martin.renvoize@ptfs-europe
   |ity.org |.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes

2019-03-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521

--- Comment #48 from Martin Renvoize  ---
*** Bug 22519 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes

2019-03-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #87213|0   |1
is obsolete||

--- Comment #46 from Martin Renvoize  ---
Created attachment 87219
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87219&action=edit
Bug 22521: (QA follow-up) Corrections to tests

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes

2019-03-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #87214|0   |1
is obsolete||

--- Comment #47 from Martin Renvoize  ---
Created attachment 87220
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87220&action=edit
Bug 22521: (follow-up) Update 'Offsets' test

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes

2019-03-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #87209|0   |1
is obsolete||

--- Comment #42 from Martin Renvoize  ---
Created attachment 87215
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87215&action=edit
Bug 22521: Increase varchar size for accounttype

accountlines.accounttype is currently a short varchar(5) field for to
store accounttype codes. Koha is moving towards more descriptive codes
which require a larger capacity varchar(16).

Signed-off-by: Martin Renvoize 
Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes

2019-03-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #87212|0   |1
is obsolete||

--- Comment #45 from Martin Renvoize  ---
Created attachment 87218
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87218&action=edit
Bug 22521: Update existing accounttypes

Signed-off-by: Martin Renvoize 
Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes

2019-03-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #87210|0   |1
is obsolete||

--- Comment #43 from Martin Renvoize  ---
Created attachment 87216
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87216&action=edit
Bug 22521: Update fines handling to use accountline.status

Signed-off-by: Martin Renvoize 
Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes

2019-03-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #87211|0   |1
is obsolete||

--- Comment #44 from Martin Renvoize  ---
Created attachment 87217
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87217&action=edit
Bug 22521: Update UI to use accountlines.status

Signed-off-by: Martin Renvoize 
Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes

2019-03-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521

--- Comment #41 from Martin Renvoize  ---
Created attachment 87214
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87214&action=edit
Bug 22521: (follow-up) Update 'Offsets' test

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes

2019-03-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #87101|0   |1
is obsolete||

--- Comment #40 from Martin Renvoize  ---
Created attachment 87213
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87213&action=edit
Bug 22521: (QA follow-up) Corrections to tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes

2019-03-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #87099|0   |1
is obsolete||

--- Comment #38 from Martin Renvoize  ---
Created attachment 87211
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87211&action=edit
Bug 22521: Update UI to use accountlines.status

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes

2019-03-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #87100|0   |1
is obsolete||

--- Comment #39 from Martin Renvoize  ---
Created attachment 87212
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87212&action=edit
Bug 22521: Update existing accounttypes

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes

2019-03-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #87098|0   |1
is obsolete||

--- Comment #37 from Martin Renvoize  ---
Created attachment 87210
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87210&action=edit
Bug 22521: Update fines handling to use accountline.status

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes

2019-03-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #87097|0   |1
is obsolete||

--- Comment #36 from Martin Renvoize  ---
Created attachment 87209
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87209&action=edit
Bug 22521: Increase varchar size for accounttype

accountlines.accounttype is currently a short varchar(5) field for to
store accounttype codes. Koha is moving towards more descriptive codes
which require a larger capacity varchar(16).

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21336] GDPR: Handle unsubscribe requests automatically by optional (administrative) lock, anonymize and remove

2019-03-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21336

Martin Renvoize  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe
   |y.org   |.com
 Status|Signed Off  |Failed QA
 CC||martin.renvoize@ptfs-europe
   ||.com

--- Comment #95 from Martin Renvoize  ---
QA Script is complaining.. though I'm not entirely sure what it means:

 FAIL   Koha/Patron.pm
   FAIL   valid
Constant subroutine Koha::Patron::ADMINISTRATIVE_LOCKOUT
redefined


Any thoughts?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22607] Default value in issues.renewals should be '0' not null

2019-03-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22607

Martin Renvoize  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #3 from Martin Renvoize  ---
Going straight for PQA on this one.. it's tiny and makes complete sense.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22607] Default value in issues.renewals should be '0' not null

2019-03-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22607

Martin Renvoize  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #4 from Martin Renvoize  ---
Works well, no test failures, no regressions I can see and qa scripts all
pass..

Passing QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22607] Default value in issues.renewals should be '0' not null

2019-03-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22607

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #87154|0   |1
is obsolete||

--- Comment #2 from Martin Renvoize  ---
Created attachment 87208
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87208&action=edit
Bug 22607: Change default value in issues.renewals to '0'.

This patch change renewals column of issues and old_issues tables.

Now it is NOT NULL default 0. It does not make sense when number of
renewals is undefined, it is always integer with value zero or more

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22607] Default value in issues.renewals should be '0' not null

2019-03-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22607

Martin Renvoize  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe
   |y.org   |.com
 CC||martin.renvoize@ptfs-europe
   ||.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22607] Default value in issues.renewals should be '0' not null

2019-03-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22607

Martin Renvoize  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22339] Elasticsearch - fixed field mappings should match MARC ranges

2019-03-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22339

--- Comment #4 from Frank Hansen  ---
Note that leader-fields should be spelled "LDR".

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13895] Add routes for checkouts retrieval and renewal

2019-03-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895

--- Comment #85 from Nick Clemens  ---
(In reply to Nick Clemens from comment #84)
> Created attachment 87200 [details] [review]
> Bug 13895: (follow-up) Add Modern::Perl

Followup pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19380] Add transfer informations in ILS-DI GetRecords response

2019-03-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19380

Nick Clemens  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #14 from Nick Clemens  ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22564] accounttype 'Rep' is still referred to but is never set

2019-03-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22564

Martin Renvoize  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

--- Comment #9 from Martin Renvoize  ---
Back to signed off.. I've added the requested DB update (and also added some UI
display just in case it actually picks any up).. Might be a useful 'status' in
the future anyway.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22564] accounttype 'Rep' is still referred to but is never set

2019-03-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22564

--- Comment #8 from Martin Renvoize  ---
Created attachment 87207
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87207&action=edit
Bug 22564: Add UI handling for 'Replaced'

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22564] accounttype 'Rep' is still referred to but is never set

2019-03-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22564

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #87195|0   |1
is obsolete||

--- Comment #7 from Martin Renvoize  ---
Created attachment 87206
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87206&action=edit
Bug 22564: Add database update 'just in case'

With the introduction of the 'status' field it's a clear oportunity to
convert any last remaining instances of 'Rep' to 'L' + 'REPLACED'.

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22564] accounttype 'Rep' is still referred to but is never set

2019-03-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22564

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #87194|0   |1
is obsolete||

--- Comment #6 from Martin Renvoize  ---
Created attachment 87205
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87205&action=edit
Bug 22564: Remove references to 'Rep' accounttype

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22605] Adding the option to modify search like in the OPAC (advanced search)

2019-03-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605

--- Comment #1 from Alexandre  ---
By "on site" I mean staff interface.

Thanks,

Alexandre

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20588] Elasticsearch - Apply dataTable on search fields and mapping tables

2019-03-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20588

Katrin Fischer  changed:

   What|Removed |Added

 Status|BLOCKED |Signed Off

--- Comment #15 from Katrin Fischer  ---
(In reply to Katrin Fischer from comment #14)
> BLOCKED by bug 20338 dependency being Needs Signoff.

Should be BLOCKED by bug 20388 - which is signed off now, so unlocking.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI

2019-03-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388

Björn Nylén  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI

2019-03-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388

Björn Nylén  changed:

   What|Removed |Added

  Attachment #87198|0   |1
is obsolete||

--- Comment #49 from Björn Nylén  ---
Created attachment 87203
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87203&action=edit
Bug 20388: Prevent user from using a search field for a mapping after removing
it

Test plan:

 - add a search field,
 - save,
 - remove this search field
 - check that it has been removed from the mapping lists (bottom
   select).

Signed-off-by: Björn Nylén 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI

2019-03-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388

Björn Nylén  changed:

   What|Removed |Added

  Attachment #87199|0   |1
is obsolete||

--- Comment #50 from Björn Nylén  ---
Created attachment 87204
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87204&action=edit
Bug 20388: Use live handler for deleting elements

Signed-off-by: Björn Nylén 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI

2019-03-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388

Björn Nylén  changed:

   What|Removed |Added

  Attachment #87197|0   |1
is obsolete||

--- Comment #48 from Björn Nylén  ---
Created attachment 87202
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87202&action=edit
Bug 20388 - Keep data consistency when adding/removing mapping

Test plan:
  - create a new search field, save,
  - create a mapping using it (don't save),
  - check that you can't delete the search field.

  - delete all the mapping related to a search field (biblios and
authorities), don't save,
  - check that you can delete this search field.

Signed-off-by: Nicolas Legrand 
Signed-off-by: Björn Nylén 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI

2019-03-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388

Björn Nylén  changed:

   What|Removed |Added

  Attachment #87196|0   |1
is obsolete||

--- Comment #47 from Björn Nylén  ---
Created attachment 87201
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87201&action=edit
Bug 20388 - Add/delete search fields from search engine configuration page

Test plan:

  - apply this patch,
  - check that SearchEngine system preference is set to Elasticsearch,
  - go to Admin > Search engine configuration,
  - on the search fields tab, fill a new line at the bottom of the table
(name, label, type)
  - click on the "Add" button and save,
  - check that the new search field has been saved,
  - also test field deletions,
  - check that you can't delete already mapped fields.

Signed-off-by: Nicolas Legrand 
Signed-off-by: Séverine QUEUNE 

Signed-off-by: Nick Clemens 
Signed-off-by: Björn Nylén 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13895] Add routes for checkouts retrieval and renewal

2019-03-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895

--- Comment #84 from Nick Clemens  ---
Created attachment 87200
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87200&action=edit
Bug 13895: (follow-up) Add Modern::Perl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16357] Plack error logs are not time stamped

2019-03-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com

--- Comment #36 from Tomás Cohen Arazi  ---
(In reply to Liz Rea from comment #35)
> So my test plan was
> 
> * make sure the modules required were installed
> Plack::Middleware::LogErrors
> Plack::Middleware::LogWarn
> * Copy the files in as before
> sudo cp debian/templates/plack.psgi /etc/koha/kohadev/plack.psgi
> sudo cp etc/log4perl.conf /etc/koha/sites/kohadev/log4perl.conf
> sudo cp debian/templates/log4perl-site.conf.in
> /etc/koha/log4perl-site.conf.in
> * EDIT those files once in situ to reflect the paths in your install - for
> kohadevbox (and any debian instance based test environment) it'll be
> /var/log/koha/kohadev/plack-error.log
> * Restart plack (kohadevbox is restart_all)
> 
> kohadevbox has a way to copy in the debian files but I didn't use that -  in
> the misc4dev there is a "cp_debian_files.pl" which updates the debian files.
> It might be good to try it.
> 
> Liz

That'd be cp_debian_files.pl plus gitify, or just the reset_all alias.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI

2019-03-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388

Alex Arnaud  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI

2019-03-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #86912|0   |1
is obsolete||

--- Comment #46 from Alex Arnaud  ---
Created attachment 87199
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87199&action=edit
Bug 20388: Use live handler for deleting elements

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   3   >