[Koha-bugs] [Bug 19817] Merge local and online documentations

2019-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

Martin Renvoize  changed:

   What|Removed |Added

   Keywords||additional_work_needed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21545] Update German web Installer for 18.11

2019-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21545

Hayley Mapley  changed:

   What|Removed |Added

 CC||hayleymap...@catalyst.net.n
   ||z

--- Comment #5 from Hayley Mapley  ---
(In reply to Katrin Fischer from comment #2)
> Created attachment 83376 [details] [review]
> Bug 21545: Translate 'Stock rotation slip'
> 
> Throwing in some capitalization fixes for the English
> version of the notice as well.
> 
> To test:
> - Verify the changes make sense and the SQL is still valid
>   and executes

Couldn't figure out how to amend this commit, but I followed the test plan for
it so please consider both patches signed off!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21545] Update German web Installer for 18.11

2019-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21545

Hayley Mapley  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21545] Update German web Installer for 18.11

2019-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21545

Hayley Mapley  changed:

   What|Removed |Added

  Attachment #83377|0   |1
is obsolete||

--- Comment #4 from Hayley Mapley  ---
Created attachment 87749
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87749=edit
Bug 21545: Translate new ACCOUNT_PAYMENT and ACCOUNT_WRITEOFF notices to German

To test:
- Apply patch
- Run the German web installer
- Verify the sample notices installs without error
- Verify it looks 'German' in the GUI :)

Signed-off-by: Hayley Mapley 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11523] Make framework code available to stylesheets to allow for more customized display

2019-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11523

--- Comment #5 from Eugene Espinoza  ---
Yeah certainly Liz! Galen Charlton's reply in the forum is this:
"..it would be simple to adjust C4::XSLT::XSLTParse4Display() so 
that it could make the framework code available to the stylesheet, 
which it turn would allow one to write conditional logic."
This bug is five years ago and I can't recall the use case for this, I will
reply to this once I recall the use case.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18011] Enrollment period date on patron category can be set in the past without any error/warning messages

2019-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18011

Hayley Mapley  changed:

   What|Removed |Added

 Status|ASSIGNED|NEW

--- Comment #3 from Hayley Mapley  ---
(In reply to Katrin Fischer from comment #2)
> Still valid, resetting to master and rephrasing/shortening bug title a bit.

I have tried to fix this to no avail. Min-max were specified but did not work.
Am resetting to new as someone more familiar with Javascript may wish to have a
crack at it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22625] Improvements to the onboarding tool

2019-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22625

Hayley Mapley  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #4 from Hayley Mapley  ---


*** This bug has been marked as a duplicate of bug 18308 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18308] Default value of minPasswordLength should be increased

2019-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18308

Hayley Mapley  changed:

   What|Removed |Added

 CC||hayleymap...@catalyst.net.n
   ||z

--- Comment #37 from Hayley Mapley  ---
*** Bug 22625 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15673] Accessibility: problems setting the renewal date

2019-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15673

Hayley Mapley  changed:

   What|Removed |Added

 CC||hayleymap...@catalyst.net.n
   ||z
 Resolution|--- |FIXED
 Status|NEW |RESOLVED

--- Comment #1 from Hayley Mapley  ---
(In reply to Katrin Fischer from comment #0)
> This is a report from a library using the keyboard, screen reader and
> braille line for navigating Koha.
> 
> When trying to set the renewal date below the checkouts table the checkbox
> for the "forgive fines on return" checkbox is set instead.
> 
> I think this might be the screen reader not being happy about how we have
> structured the page in this area, but I was not able to verify. Hoping
> someone else might have an idea on how to improve accessibility in this area
> of the page.

This looks to have been fixed on master, marking as resolved fixed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7867] Use consistent terminology for username and password

2019-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7867

Hayley Mapley  changed:

   What|Removed |Added

 CC||hayleymap...@catalyst.net.n
   ||z

--- Comment #32 from Hayley Mapley  ---
I started to fix this patch, then realised that tooltips don't display when
hovering over the Login text in the OPAC, so the patch doesn't really work
anymore. I am keen to standardise though, does anyone have any updated opinions
on the solution for this?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22681] Onboarder: buttons should say "next" instead of "submit"

2019-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22681

Hayley Mapley  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22681] Onboarder: buttons should say "next" instead of "submit"

2019-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22681

Hayley Mapley  changed:

   What|Removed |Added

  Attachment #87732|0   |1
is obsolete||

--- Comment #2 from Hayley Mapley  ---
Created attachment 87748
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87748=edit
Bug 22681: Onboarder buttons should say "Next" instead of "Submit"

To test:
1) Drop and recreate your database, then restart_all

2) Go through the onboarding tool, noting that the order matches the
following and progressing each step the button says "Next":
 1 Create a library
 2 Create patron category
 3 Set minPasswordLength
 4 Create Koha administrator
 5 Create item type
 6 Define currency (see step 3!)
 7 Circulation rule/Complete

All of the pages should work as normal and onboarding should be completed as
usual.

Signed-off-by: Hayley Mapley 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22682] New: Billing - Billing Rest API is not working as expected

2019-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22682

Bug ID: 22682
   Summary: Billing - Billing Rest API is not working as expected
 Change sponsored?: ---
   Product: Koha
   Version: 18.05
  Hardware: Other
OS: Windows
Status: NEW
  Severity: major
  Priority: P5 - low
 Component: REST api
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: sudhee@gmail.com
  Target Milestone: ---

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21159] Blank item shelving location (952$c) on issue and return based on syspref values

2019-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159

--- Comment #32 from Hayley Mapley  ---
(In reply to Liz Rea from comment #31)
> Hi Hayley,
> 
> Sorry to say but the tests don't pass, and that's before even testing the
> functionality itself. It looks to me like they are highlighting a legit
> problem though (both with the tests, and with the feature).
> 
> I'll be on IRC today in your morning and possibly afternoon if you want to
> talk about anything at all, look me up I'm wizzyrea. :)
> 
> Cheers,
> Liz

Hi Liz,

This was the result of me rebasing Alex's patch, and so I fixed the conflicts
and attached it with the plan to test it but I ran out of time to do so. Thank
you for testing it, it is obviously one I will have to look into further before
it can be completed!

Cheers,
Hayley

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18308] Default value of minPasswordLength should be increased

2019-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18308

--- Comment #36 from Hayley Mapley  ---
Created attachment 87747
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87747=edit
Bug 18308: Added missing onboardingstep8.tt

Sponsered-by: Catalyt IT

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import

2019-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

--- Comment #147 from Katrin Fischer  ---
8) Changes to syspref.sql are missing

9) There are some default values set in the database updat that can't go into
kohastructure.sql, might have to go into a new SQL file in the installers.

10) Looking at the setup table I'll also need documentation, pretty please!
Right now, I have no clue on how to use this.

Good stuff too: Unit tests pass, new permission is good too.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import

2019-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

--- Comment #146 from Katrin Fischer  ---
Comment on attachment 87711
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87711
Bug 14957: Merge rules system for merging of MARC records

Review of attachment 87711:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=14957=87711)
-

::: C4/Biblio.pm
@@ +262,3 @@
>  =cut
>  
>  sub ModBiblio {

4) Changes to ModBiblio should be covered by unit tests.

@@ +3615,4 @@
>  return $record;
>  }
>  
> +=head2 ApplyMarcMergeRules

5) New method needs to be covered by unit tests.

::: admin/marc-merge-rules.pl
@@ +15,5 @@
> +# You should have received a copy of the GNU General Public License
> +# along with Koha; if not, see .
> +
> +use strict;
> +use warnings;

6) Should be: Modern::Perl

7) Changes to kohastructure.sql are missing.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import

2019-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #145 from Katrin Fischer  ---
Taking a first view here, starting with the QA script:


1) QA script failures:
 FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc-merge-rules.tt
   FAIL   filters
missing_filter at line 376 ()
missing_filter at line 364 ([% rule.filter
%])
missing_filter at line 372 ( Delete)
missing_filter at line 317 (   
[% module.name %])
missing_filter at line 373 ( Edit)
missing_filter at line 363 ([% rule.module
%])
missing_filter at line 308 ()
missing_filter at line 315 (   
[% module.name %])
missing_filter at line 234 ()
missing_filter at line 328 ([% preset %])
missing_filter at line 357 ( Save)
missing_filter at line 323 ()
wrong_html_filter at line 373 ( Edit)
missing_filter at line 5 ()
missing_filter at line 310 ([% rule.id
%])
missing_filter at line 385 ()
missing_filter at line 365 ([% rule.tag
%])
missing_filter at line 241 ()
wrong_html_filter at line 372 ( Delete)
missing_filter at line 362 ([% rule.id
%])
missing_filter at line 263 ([% module.name %])
missing_filter at line 273 ([% preset %])
missing_filter at line 322 ()
   FAIL   forbidden patterns
forbidden pattern: Do *not* include full path to css files, use
the Asset TT plugin (bug 20538) (line 5)
forbidden pattern: Contains old bootstrap style for buttons
(see bug 16239) (line 372)
forbidden pattern: Contains old bootstrap style for buttons
(see bug 16239) (line 373)
forbidden pattern: Attribute type should not be used for script
tags (bug 20053) (line 14)
forbidden pattern: Contains old bootstrap style for buttons
(see bug 16239) (line 357)
forbidden pattern: Attribute type should not be used for style
tags (bug 20054) (line 8)
forbidden pattern: Contains old bootstrap style for buttons
(see bug 16239) (line 302)
forbidden pattern: Contains old bootstrap style for buttons
(see bug 16239) (line 358)
forbidden pattern: Contains old bootstrap style for buttons
(see bug 16239) (line 301)
   OK git manipulation
   FAIL   js_in_body
A 

[Koha-bugs] [Bug 19265] Advanced Editor - Rancor - Add ability to export selected records from and import records into an import batch

2019-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19265

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
 Status|Signed Off  |BLOCKED

--- Comment #23 from Katrin Fischer  ---
We need to work out bug 18823 first, blocked for now.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches

2019-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
 Status|Signed Off  |Failed QA

--- Comment #89 from Katrin Fischer  ---
Starting with a first code review and the tests. All in all this is quite a
MASSSIVE patch.
12 files changed, 992 insertions(+), 156 deletions(-)
 I can't shake the feeling that this should have been broken up into smaller
patches in a dependency tree.

1) QA test tools

a) FAIL koha-tmpl/intranet-tmpl/prog/en/includes/cateditor-ui.inc
   FAIL   filters
missing_filter at line 807 (   
Preferences.Save( [% loggelogged_in_user.borrowernumber %] );)
missing_filter at line 45 (name: _("Batch: ") +
`[% batch.file_name %]`,)
missing_filter at line 44 ('batch:[%
batch.import_batch_id %]': {)
missing_filter at line 327 ([%
batch.import_batch_id %]: {)
missing_filter at line 328 ('name': `[%
batch.file_name %]`,)

b)  FAILC4/Biblio.pm
   FAIL   pod coverage
POD is missing for 'UpdateMarcTimestamp'

2) Unit tests

There are no unit tests included in this patch, but it touches a lot of
methods:

a) New method C4/Biblio Upate005Time is untested - I can see it's just a copy
of existing code tho.
b) New method C4/ImportBatch _get_import_record_timestamp is untested and
should have POD.
c) Changes to existing methods are not accompanied by tests:
  - _update_import_record_marc
  - _add_biblio_fields
c) Changes to Koha/MetaSearcher are untested.
d) New svc/cataloguing/import_batches is untested.
e) New svc/cataloguing/metasearch

3) Question
+use C4::Koha qw(); # Purely for GetNormalizedISBN
Why not list the method inside qw if only GetNormalizedISBN is needed?

4) Can you point me to the most current and complete test plan? (including
Controlnumber handling etc.)

5) Some first notes from GUI testing

a) I am not completely sold on the placement of the 'Save to' box. It already
looks a bit 'squashed' and it will look worse in other languages (being German
I know our words for things tend to be longer)

b) Main issue: Should we not preselect something or at least remember what was
selected? I think 'Save to catalog' would probably the most common for normal
cataloguing. 

Once saved for the first time, both: 'new record' and 'catalog record #' are
checked. I'd expect it to create a duplicate in that case. (blocker for me -
please check)

c) When a record is saved, the message appears no longer centered, but far to
the right. I think it's easier to miss this way.

d) The modal for 'Import batches...' covers the whole screen. Changing
something there will take immediate effect. I wonder if a close button would
help usability or just making the modal a little smaller.

e) Why is it 'Save as MARC' but 'New MARCXML'?

e) When checking both, only the MARCXML is saved. I think maybe multi-select
should not allowed or should be handled?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18584] Our legacy code contains trailing-spaces

2019-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584

Owen Leonard  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18584] Our legacy code contains trailing-spaces

2019-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584

--- Comment #45 from Owen Leonard  ---
Created attachment 87746
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87746=edit
Bug 18584: Our legacy code contains trailing-spaces

This patch removes trailing spaces and replaces tab characters with
spaces in the branch transfer limits template.

Mentored-by: Owen Leonard 

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17171] Add a syspref to allow currently issued items to be issued to a new patron without staff confirmation

2019-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17171

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #87302|0   |1
is obsolete||
  Attachment #87303|0   |1
is obsolete||
  Attachment #87304|0   |1
is obsolete||

--- Comment #23 from Katrin Fischer  ---
Created attachment 87742
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87742=edit
Bug 17171: Add a syspref to allow currently issued items to be issued to a new
patron without staff confirmation

Some libraries don't want to force the librarians to manually confirm
each checkout when the item is checked out to another. Instead, they
would prefer to be alerted after the fact.

Test Plan:
1) Apply this patch
2) Run updatedatabase.pl
3) Enable the new syspref AutoReturnCheckedOutItems
4) Check an item out to a patron
5) Check the same item out to another patron
6) Note you are not prompted to confirm the checkout,
   but are instead alerted that is had been checked out to another patron!

Signed-off-by: Christopher Brannon 
Signed-off-by: BWS Sandboxes 

Signed-off-by: Katrin Fischer 

Signed-off-by: Liz Rea 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17171] Add a syspref to allow currently issued items to be issued to a new patron without staff confirmation

2019-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17171

--- Comment #24 from Katrin Fischer  ---
Created attachment 87743
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87743=edit
Bug 17171: (QA follow-up) Add message to batch checkout template

Signed-off-by: Liz Rea 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17171] Add a syspref to allow currently issued items to be issued to a new patron without staff confirmation

2019-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17171

--- Comment #27 from Katrin Fischer  ---

Fixed commit messages, please spell: (QA follow-up) (or QA tool will complain)
:)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17171] Add a syspref to allow currently issued items to be issued to a new patron without staff confirmation

2019-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17171

--- Comment #26 from Katrin Fischer  ---
Created attachment 87745
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87745=edit
Bug 17171: (QA follow-up) Remove cardnumber template variable

The INCLUDE already takes care of displaying the cardnumber, the
extra variable is not needed.

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17171] Add a syspref to allow currently issued items to be issued to a new patron without staff confirmation

2019-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17171

--- Comment #25 from Katrin Fischer  ---
Created attachment 87744
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87744=edit
Bug 17171: (QA follow-up) Using patron-title.inc for names

Signed-off-by: Liz Rea 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17171] Add a syspref to allow currently issued items to be issued to a new patron without staff confirmation

2019-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17171

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21411] Advanced cataloging editor - rancor - Allow configuration of Keyboard shortcuts

2019-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21411

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
 Status|Signed Off  |Failed QA

--- Comment #15 from Katrin Fischer  ---
Hi Nick, 

having a first look here:

1) FAIL Koha/KeyboardShortcuts.pm
   OK critic
   OK forbidden patterns
   OK git manipulation
   OK pod
   FAIL   pod coverage
POD is missing for 'object_class'

2) No tests?

3) Translation issues

a) Ctrl is not labelled Ctrl on German keyboards, it's Strg - so people might
not understand. Currently I can fix this in translation, but with the new
system that will not work. We could add another column for a 'spelled out'
mapping or we could add some replacing in the template that can be translated.
Not sure here. (Not quite blocker... but meh)

b) The new file is missing from the translated installers. (blocker)
I'd like to suggest a different approach here. As you can't invent your own
keyboard shortcuts, I'd deal with this like with the permissions. Have one SQL
file with the mandatory values on top level (not in language directories) and
deal with the description translation in the templates.

4) I am wondering if tools is the right place for this. I think I would put it
with Sound alerts and column configuration in Administration.

5) If we leave it in tools: It's missing from tools sidebar and start page. If
we move to admin, we'll also need sidebar and start page.
As the navigation of tools shows on the tool page, I think that makes it
currently a bit confusing.

6) Permissions: currently it doesn't require any permission:
flagsrequired   => {},
Do we want to leave it like this?
As the keyboard shortcuts are global and not per user I can imagine libraries
would not want anyone be able to reconfigure them.

7) "If combing multiple keys " - interesting idea :)

8) The button is a bit close to the table, could use a little template
clean-up.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20128] Permission for advanced editor

2019-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20128

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20128] Permission for advanced editor

2019-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20128

--- Comment #16 from Katrin Fischer  ---
Hi Nick, please check my follow-up!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20128] Permission for advanced editor

2019-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20128

--- Comment #14 from Katrin Fischer  ---
Created attachment 87740
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87740=edit
Bug 20128: (QA follow-up) Corrections to haspermission

The haspermission routine wrongly assumed that get_user_subpermissions
would return a list of all subpermissions if the user had the top level
permission, but instead if just returns 1.

Signed-off-by: Martin Renvoize 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20128] Permission for advanced editor

2019-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20128

--- Comment #15 from Katrin Fischer  ---
Created attachment 87741
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87741=edit
Bug 20128: Add new permission for new installations

Change was missing from userpermissions.sql

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20128] Permission for advanced editor

2019-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20128

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #86706|0   |1
is obsolete||
  Attachment #86840|0   |1
is obsolete||

--- Comment #12 from Katrin Fischer  ---
Created attachment 87738
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87738=edit
Bug 20128: Add permission for advanced cataloging editor

To test:
1 - Have a borrower with edit_catalogue permission and one with
editcatalogue top level
2 - Confirm they can both access the advanced editor from the
'Cataloguing' home page or from the basic editor
3 - Apply patch
4 - Update database
5 - Confirm borrower with 'edit_catalogue' has 'advanced_editor'
permission
6 - Confirm borrowers can access advanced editor as above
7 - Remove 'advanced_editor' permission from borrower
8 - Ensure they cannot access the advanced editor
9 - Ensure links to 'Edit record' from search results go to basic editor

Signed-off-by: Liz Rea 
Signed-off-by: Martin Renvoize 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20128] Permission for advanced editor

2019-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20128

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #86707|0   |1
is obsolete||

--- Comment #13 from Katrin Fischer  ---
Created attachment 87739
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87739=edit
Bug 20128: Problem when checking individual perms where borrower has top level

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21891] Remove non-XSLT detail view in the staff client

2019-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21891

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
 Status|Signed Off  |Failed QA

--- Comment #3 from Katrin Fischer  ---
Works really well, only one request: Let's set the XSLTDetailsDisplay to
default for those that have it empty now. It will advertise the change in the
database update then too.

Could we also remove staff results non-XSLT?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22501] OPAC course reserves notes should allow html links

2019-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22501

--- Comment #10 from Katrin Fischer  ---
Created attachment 87737
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87737=edit
Bug 22501: Add raw filter to course reserves summary page

Fixes another place where the public note is shown:
- Course reserves module start/summary page

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22501] OPAC course reserves notes should allow html links

2019-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22501

--- Comment #9 from Katrin Fischer  ---
Created attachment 87736
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87736=edit
Bug 22501: (QA follow-up) use $raw for the note in the intranet

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22501] OPAC course reserves notes should allow html links

2019-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22501

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22501] OPAC course reserves notes should allow html links

2019-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22501

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #87380|0   |1
is obsolete||
  Attachment #87658|0   |1
is obsolete||

--- Comment #8 from Katrin Fischer  ---
Created attachment 87735
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87735=edit
Bug 22501: OPAC course reserves notes should allow html links

Signed-off-by: Liz Rea 

Signed-off-by: Katrin Fischer 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22501] OPAC course reserves notes should allow html links

2019-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22501

--- Comment #7 from Katrin Fischer  ---
Hi Lucas, please use the QA tools on your patches - it will show you if there
are any complaints. In this case, there is a small 'typo' in the first commit
message. I will fix it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10215] Increase the size of opacnote and librariannote for table subscriptionhistory

2019-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10215

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #21 from Katrin Fischer  ---
Tests are still failing for me:

t/db_dependent/Serials.t .. 2/46 
#   Failed test 'NewSubscription should not set subscriptionhistory opacnotes'
#   at t/db_dependent/Serials.t line 95.
#  got: undef
# expected: ''

#   Failed test 'NewSubscription should not set subscriptionhistory
librariannotes'
#   at t/db_dependent/Serials.t line 96.
#  got: undef
# expected: ''
t/db_dependent/Serials.t .. 14/46 # Looks like you failed 2 tests of 46.
t/db_dependent/Serials.t .. Dubious, test returned 2 (wstat 512, 0x200)
Failed 2/46 subtests 

Wondering, should we correct the old data? I know have a mix of '' and NULL in
my db.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22646] Fix use of PrivacyPolicyURL

2019-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22646

Nick Clemens  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||n...@bywatersolutions.com

--- Comment #5 from Nick Clemens  ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22675] SCO broken on invalid barcodes

2019-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22675

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com
 Status|Passed QA   |Pushed to Master

--- Comment #6 from Nick Clemens  ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22618] Tests in t/Acquisition.t are actually context dependent

2019-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22618

Nick Clemens  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #4 from Nick Clemens  ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22641] Incorrect filter on SCO printslip

2019-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22641

Nick Clemens  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #4 from Nick Clemens  ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22553] Unchecking a subpermission does not uncheck the top level permission

2019-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22553

Nick Clemens  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #5 from Nick Clemens  ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22600] We should add an 'interface' field to accountlines

2019-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22600

Nick Clemens  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #28 from Nick Clemens  ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22512] accountlines.accountype mixes 'state' and 'type'

2019-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22512

Nick Clemens  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||n...@bywatersolutions.com

--- Comment #6 from Nick Clemens  ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22390] When duplicating existing order lines new items are not created

2019-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22390

Nick Clemens  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #12 from Nick Clemens  ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22295] Elasticsearch - Advanced search should group terms entered in a single input

2019-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22295

Nick Clemens  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #6 from Nick Clemens  ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22288] Barcode file does not work in modifying items in batch

2019-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22288

Nick Clemens  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #7 from Nick Clemens  ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17978] Include 'Next available'/title level holds in holds count when placing holds (opac and staff)

2019-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17978

Nick Clemens  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #28 from Nick Clemens  ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21013] Missing itemtype for checkut makes patron summary print explode

2019-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21013

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com
 Status|Passed QA   |Pushed to Master

--- Comment #4 from Nick Clemens  ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22628] FFOR and VOID show up as codes to end users in OPAC, SCO and staff

2019-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22628

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #87731|0   |1
is obsolete||

--- Comment #3 from Katrin Fischer  ---
Created attachment 87734
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87734=edit
Bug 22628: Add VOID and FFOR to relevant templates

This patch adds the VOID and FFOR codes to the releveant templates for
display purposes

Signed-off-by: Martin Renvoize 

Signed-off-by: Liz Rea 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22628] FFOR and VOID show up as codes to end users in OPAC, SCO and staff

2019-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22628

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11057] Bootstrap theme: Don't hide language chooser below the fold

2019-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11057

--- Comment #19 from Katrin Fischer  ---
I wonder if this is still needed. The display of the language chooser appears
ok now to me, especially with bug 22680.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22680] OPAC language footer not positioned correctly

2019-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22680

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #87730|0   |1
is obsolete||

--- Comment #3 from Katrin Fischer  ---
Created attachment 87733
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87733=edit
Bug 22680: OPAC language footer not positioned correctly

This patch modifies the OPAC CSS so that the language-selection footer
is positioned correctly.

To test, apply the patch and rebuild the OPAC CSS.

- Enable one or more translations in the OPAC
- View a page in the OPAC which can display in your browser without a
  vertical scrollbar (for instance, the OPAC main page with no news
  items or OpacMainUserBlock).
  - The language-selection footer should appear at the bottom of the
screen. At smaller browser heights the footer should scroll
offscreen.
  - Test with content in the opaccredits system preference, and with
OpacKohaUrl enabled. The footer should still be positioned
correctly.

Signed-off-by: Liz Rea 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22680] OPAC language footer not positioned correctly

2019-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22680

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22501] OPAC course reserves notes should allow html links

2019-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22501

Liz Rea  changed:

   What|Removed |Added

 CC||wizzy...@gmail.com
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22681] Onboarder: buttons should say "next" instead of "submit"

2019-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22681

--- Comment #1 from Liz Rea  ---
Created attachment 87732
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87732=edit
Bug 22681: Onboarder buttons should say "Next" instead of "Submit"

To test:
1) Drop and recreate your database, then restart_all

2) Go through the onboarding tool, noting that the order matches the
following and progressing each step the button says "Next":
 1 Create a library
 2 Create patron category
 3 Set minPasswordLength
 4 Create Koha administrator
 5 Create item type
 6 Define currency (see step 3!)
 7 Circulation rule/Complete

All of the pages should work as normal and onboarding should be completed as
usual.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22681] Onboarder: buttons should say "next" instead of "submit"

2019-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22681

Liz Rea  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22681] Onboarder: buttons should say "next" instead of "submit"

2019-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22681

Liz Rea  changed:

   What|Removed |Added

 Depends on||18308


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18308
[Bug 18308] Default value of minPasswordLength should be increased
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18308] Default value of minPasswordLength should be increased

2019-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18308

Liz Rea  changed:

   What|Removed |Added

 Blocks||22681


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22681
[Bug 22681] Onboarder: buttons should say "next" instead of "submit"
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22681] Onboarder: buttons should say "next" instead of "submit"

2019-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22681

Liz Rea  changed:

   What|Removed |Added

 Depends on||1
 CC||wizzy...@gmail.com


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1
[Bug 1] Include the definition of currency in onboarding tool
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18888] Include the definition of currency in onboarding tool

2019-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1

Liz Rea  changed:

   What|Removed |Added

 Blocks||22681


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22681
[Bug 22681] Onboarder: buttons should say "next" instead of "submit"
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22681] New: Onboarder: buttons should say "next" instead of "submit"

2019-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22681

Bug ID: 22681
   Summary: Onboarder: buttons should say "next" instead of
"submit"
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Installation and upgrade (web-based installer)
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: wizzy...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com
  Target Milestone: ---

Submit is a developer term, it's a wizard, we should use "next" instead.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21852] Add more columns and column configuration to overdues report

2019-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21852

Marjorie Barry-Vila  changed:

   What|Removed |Added

 CC||marjorie.barry-vila@collect
   ||o.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22628] FFOR and VOID show up as codes to end users in OPAC, SCO and staff

2019-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22628

Liz Rea  changed:

   What|Removed |Added

  Attachment #87604|0   |1
is obsolete||

--- Comment #2 from Liz Rea  ---
Created attachment 87731
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87731=edit
Bug 22628: Add VOID and FFOR to relevant templates

This patch adds the VOID and FFOR codes to the releveant templates for
display purposes

Signed-off-by: Martin Renvoize 

Signed-off-by: Liz Rea 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22628] FFOR and VOID show up as codes to end users in OPAC, SCO and staff

2019-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22628

Liz Rea  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22680] OPAC language footer not positioned correctly

2019-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22680

Liz Rea  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22680] OPAC language footer not positioned correctly

2019-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22680

Liz Rea  changed:

   What|Removed |Added

  Attachment #87729|0   |1
is obsolete||

--- Comment #2 from Liz Rea  ---
Created attachment 87730
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87730=edit
Bug 22680: OPAC language footer not positioned correctly

This patch modifies the OPAC CSS so that the language-selection footer
is positioned correctly.

To test, apply the patch and rebuild the OPAC CSS.

- Enable one or more translations in the OPAC
- View a page in the OPAC which can display in your browser without a
  vertical scrollbar (for instance, the OPAC main page with no news
  items or OpacMainUserBlock).
  - The language-selection footer should appear at the bottom of the
screen. At smaller browser heights the footer should scroll
offscreen.
  - Test with content in the opaccredits system preference, and with
OpacKohaUrl enabled. The footer should still be positioned
correctly.

Signed-off-by: Liz Rea 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18191] Add endpoint to list valid pickup locations

2019-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18191

Tomás Cohen Arazi  changed:

   What|Removed |Added

Summary|REST API: Add endpoint to   |Add endpoint to list valid
   |list valid pickup locations |pickup locations

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18191] REST API: Add endpoint to list valid pickup locations

2019-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18191

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com
   Assignee|lari.task...@hypernova.fi   |koha-b...@lists.koha-commun
   ||ity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22632] Add logging of merged patrons

2019-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632

Marjorie Barry-Vila  changed:

   What|Removed |Added

 CC||marjorie.barry-vila@collect
   ||o.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22680] OPAC language footer not positioned correctly

2019-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22680

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22680] OPAC language footer not positioned correctly

2019-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22680

--- Comment #1 from Owen Leonard  ---
Created attachment 87729
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87729=edit
Bug 22680: OPAC language footer not positioned correctly

This patch modifies the OPAC CSS so that the language-selection footer
is positioned correctly.

To test, apply the patch and rebuild the OPAC CSS.

- Enable one or more translations in the OPAC
- View a page in the OPAC which can display in your browser without a
  vertical scrollbar (for instance, the OPAC main page with no news
  items or OpacMainUserBlock).
  - The language-selection footer should appear at the bottom of the
screen. At smaller browser heights the footer should scroll
offscreen.
  - Test with content in the opaccredits system preference, and with
OpacKohaUrl enabled. The footer should still be positioned
correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22580] Remove deprecated delete_expired_opac_registrations.pl cronjob

2019-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22580

--- Comment #7 from Owen Leonard  ---
Created attachment 87728
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87728=edit
Bug 22680: OPAC language footer not positioned correctly

This patch modifies the OPAC CSS so that the language-selection footer
is positioned correctly.

To test, apply the patch and rebuild the OPAC CSS.

- Enable one or more translations in the OPAC
- View a page in the OPAC which can display in your browser without a
  vertical scrollbar (for instance, the OPAC main page with no news
  items or OpacMainUserBlock).
  - The language-selection footer should appear at the bottom of the
screen. At smaller browser heights the footer should scroll
offscreen.
  - Test with content in the opaccredits system preference, and with
OpacKohaUrl enabled. The footer should still be positioned
correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22580] Remove deprecated delete_expired_opac_registrations.pl cronjob

2019-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22580

Owen Leonard  changed:

   What|Removed |Added

  Attachment #87728|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22680] New: OPAC language footer not positioned correctly

2019-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22680

Bug ID: 22680
   Summary: OPAC language footer not positioned correctly
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: normal
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org
  Target Milestone: ---

Created attachment 87727
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87727=edit
Screenshot showing the desired layout

The language footer in the OPAC is supposed to appear at the bottom of the
screen if there is not enough content to require scrolling to reach the bottom.
Instead the language footer is always just below the visible area. I will
submit a patch to correct this.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13325] Add logs for budgets and funds

2019-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13325

karen.fell...@citruslibraries.org changed:

   What|Removed |Added

 CC||karen.fellows@citruslibrari
   ||es.org

--- Comment #6 from karen.fell...@citruslibraries.org ---
Agree with Rhonda and Sandy.  It definitely would be nice to have an audit
trail/log for the funds and budgets.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13325] Add logs for budgets and funds

2019-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13325

Sandy Allgood  changed:

   What|Removed |Added

 CC||sandy.allgood@citruslibrari
   ||es.org

--- Comment #5 from Sandy Allgood  ---
This would be a really nice feature to track our transfer of funds and budgets,
not only for history but for our County auditing.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22580] Remove deprecated delete_expired_opac_registrations.pl cronjob

2019-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22580

Martin Renvoize  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #6 from Martin Renvoize  ---
Going to go straight for a PQA on this one.. no references found anywhere and
it's a simple removal.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22580] Remove deprecated delete_expired_opac_registrations.pl cronjob

2019-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22580

Martin Renvoize  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #5 from Martin Renvoize  ---
+1

Signing off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 1232] Add Invoice/Credit/Fines Payed For Day on Issues (Print Page) (Print Slip)

2019-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1232

Liz Rea  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEW |RESOLVED

--- Comment #11 from Liz Rea  ---
You can do this with the TT notices on the slips, with the code snippet
provided by Josef.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22580] Remove deprecated delete_expired_opac_registrations.pl cronjob

2019-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22580

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #87690|0   |1
is obsolete||

--- Comment #4 from Martin Renvoize  ---
Created attachment 87726
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87726=edit
Bug 22580: Remove deprecated delete_expired_opac_registrations.pl cronjob

Removes the deprecated script and changes the hint on the
PatronSelfRegistrationExpireTemporaryAccountsDelay sytem preference.

To test:
- Make sure the script misc/cronjobs/delete_expired_opac_registrations.pl
  was deleted
- Make sure the hint on the PatronSelfRegistrationExpireTemporaryAccountsDelay
  system preference is correct
- Make sure there are no other reference to the removed script

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20912] Rental fees based on time period

2019-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912

Martin Renvoize  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20912] Rental fees based on time period

2019-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912

Martin Renvoize  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20912] Rental fees based on time period

2019-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912

Martin Renvoize  changed:

   What|Removed |Added

 Status|REOPENED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 4530] Circulation & fines rules aren't always applied from most specific to less specific

2019-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4530

Liz Rea  changed:

   What|Removed |Added

 Resolution|--- |WORKSFORME
 Status|In Discussion   |RESOLVED

--- Comment #26 from Liz Rea  ---
This seems to be working now.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5535] Show the logged-in user's unapproved tags on search results and detail pages

2019-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5535

--- Comment #5 from Liz Rea  ---
Do we still think this is a cool idea?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11523] Make framework code available to stylesheets to allow for more customized display

2019-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11523

--- Comment #4 from Liz Rea  ---
Do we still want this?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6138] Show local help and isbd punctuation automatically when we are cataloguing

2019-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6138

Liz Rea  changed:

   What|Removed |Added

 Resolution|--- |WONTFIX
 Status|Failed QA   |RESOLVED

--- Comment #11 from Liz Rea  ---
Abandoned dev for specific library, reopen if you want to revisit.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7588] adding reserve restrictions after cataloging items can cause non-holdable items to be picked for holds

2019-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7588

Liz Rea  changed:

   What|Removed |Added

 Resolution|--- |WORKSFORME
 Status|In Discussion   |RESOLVED

--- Comment #2 from Liz Rea  ---
I think this is ok now. Glad to have the workaround documented though.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7397] Patron search from Checkout tab does 'contains' instead of 'starts_with' search

2019-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7397

Liz Rea  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #7 from Liz Rea  ---
Yep!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5279] Add option to limit label item search by homebranch

2019-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5279

Liz Rea  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 CC||wizzy...@gmail.com
 Status|NEW |RESOLVED

--- Comment #2 from Liz Rea  ---
Good catch Aleisha :)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11524] Strange URL parameters in OPAC

2019-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11524

Liz Rea  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEW |RESOLVED

--- Comment #6 from Liz Rea  ---
This doesn't seem to be happening anymore:

http://127.0.0.1:8080/cgi-bin/koha/opac-search.pl?idx=kw=a_by=author_az=Add+to...

http://127.0.0.1:8080/cgi-bin/koha/opac-search.pl?idx=kw=a_by=title_az=Add+to...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5850] Should be able to define itypes or collection codes that generate "special handling" slip in SIP

2019-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5850

Liz Rea  changed:

   What|Removed |Added

 CC||wizzy...@gmail.com
 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #1 from Liz Rea  ---
I believe we can handle these cases now

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5246] Special characters in patron barcodes cause SIP2 connections to hang

2019-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5246

Liz Rea  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19014] Patrons should not get a on_reserve notification if the due date is far into the future

2019-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014

Barbara Johnson  changed:

   What|Removed |Added

 CC||barbara.johnson@bedfordtx.g
   ||ov

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >