[Koha-bugs] [Bug 23046] Add tax handling to accounts

2019-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23046

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #2 from Katrin Fischer  ---
Hi Martin, do you have a use case for this?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23048] Hide non-pickup branches from hold modification select

2019-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23048

--- Comment #7 from Katrin Fischer  ---
Makes the behaviour more consistent and also takes care of existing holds. +1

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23048] Hide non-pickup branches from hold modification select

2019-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23048

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #91048|0   |1
is obsolete||

--- Comment #6 from Katrin Fischer  ---
Created attachment 91453
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91453=edit
Bug 23048: Hide non-pickup branches from hold modification select

When modifying holds in staff client via reserve/request.pl or
the holds-tab in members/moremember.pl, the pickup library dropdown
lists libraries not marked for pickup. Hide those branches,
unless the branch is marked as a pick-up branch for already
existing hold.

The reason for showing a non-pickup branch for the holds created
before the branch was marked as non-pickup: If the non-pickup branch
wasn't shown, the branch in those holds would get set to the first
branch in the select if the hold was modified.

Test plan:
1) Create a hold for a patron, to be picked up from a certain branch.
2) Edit the branch and another branch so they are no longer
   pickup locations.
3) Go to members/moremember.pl for that patron, check the Holds-tab
   Pickup library -drop down. It lists both of the non-pickup branches.
4) Go to reserve/request.pl for that biblio. The hold-table
   Pickup library -drop down lists both of the non-pickup branches.
5) Apply patch.
6) Repeat 3 & 4, drop down no longer lists the non-pickup branch, but
   should still list the branch where the hold was marked to be picked
   from.

Signed-off-by: Pasi Kallinen 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23048] Hide non-pickup branches from hold modification select

2019-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23048

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23073] wiki.koha-community.org needs updating to a later version

2019-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23073

Thomas Dukleth  changed:

   What|Removed |Added

 CC||td-koha-b...@agogme.com

--- Comment #3 from Thomas Dukleth  ---
Perhaps the trend of consensus may point to starting over with a new instance
of MediaWiki or Dokuwiki which may simplify the problem even if the choice
would be an unfortunate consequence of my time having become less available for
Koha in recent years.

Updating the Koha instance of MediaWiki version while retaining the current
Postgres database implementation may prevent the best improvements to the Koha
MediaWiki implementation as too many extensions, scripts, etc. do not work
properly with Postgres.  If MediaWiki is updated and new content is added,
there may be no good way to migrate to MySQL from that point.  See
https://wiki.koha-community.org/wiki/Proposal_for_Wiki_Curator_17.05_Thomas_Dukleth#Migrating_to_MySQL
.   

I only ever found one set of scripts for migrating a MediaWiki instance from
Postgres to MySQL,
http://www.winterrodeln.org/trac/wiki/MediaWikiPostgresqlToMysql . 

First migrating to MySQL and then updating MediaWiki would allow using many
advantages of extensions such as SemanticMediaWiki which do not work properly
and are not supported in Postgres even if has been possible to install the
extension at one point.  We could have a good system of faceted categories
which would be easier and more useful than the currently implemented more
hierarchical categories modelled on what was implemented in the finding aid in
Docuwiki which only supported hierarchical namespaces in browsable manner and
thus lacked the flexibility provided by an extension such as SemanticMediaWiki.

Possibly breaking some installed extensions which can happen with any update is
not a significant issue holding back upgrading but merely a reason to test
updates before putting them into production.  The Koha MediaWiki instance did
become briefly broken in the past by installed extensions when it was updated
without testing and required some testing and modification of extensions which
are not necessarily at issue going forward presently.  However, anything not
core to the base software might lead to breakage in untested updates.

[While the details of issues relating to Dokuwiki should be out of scope for
this bug, it is worthwhile noting the importance of not allowing an historical
mistake in MediaWiki database choice and the subsequent neglect of the Koha
MediaWiki instance to become a permanent mistake preventing the use of features
dependent on MySQL.  In the practise of users on the previous Koha Wiki
implemented in Dokuwiki, most pages seemed to be frustratingly lost to anything
but guessing query terms in a search.  People did not have the habit of tagging
pages at all when created and when people did tag them it was too often in a
manner which did not aid findability.  Dokuwiki also did not provide any easy
means for a wiki maintainer to find untagged pages and then add a tag or tags
for findability, although, some people in the Dokuwiki community have been
raising the issue for a while.  See
https://github.com/dokufreaks/plugin-tag/issues/77 and
https://forum.dokuwiki.org/thread/9473 .]

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23296] Auto Renewal Notice does not use Library specific notices

2019-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23296

Kelly McElligott  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23296] New: Auto Renewal Notice does not use Library specific notices

2019-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23296

Bug ID: 23296
   Summary: Auto Renewal Notice does not use Library specific
notices
 Change sponsored?: ---
   Product: Koha
   Version: 18.11
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Notices
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: ke...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

All notices in Koha are created to be a default ALL libraries notice, however,
with branch systems, there is also the ability to create a library specific
notice that can be used instead.  However, the notice AUTO_RENEWALS is not
currently capable of being library specific - instead, the ALL Library Notice
for AUTO_RENEWALS is the only one that Koha send. 

To adjust this, it would be recommended that a library specific notice like all
the others in Koha can be created.  Following circ control, would be the
suggested way to go as with most notices in Koha.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15497] Limit Item Types by Branch

2019-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15497

--- Comment #12 from Agustín Moyano  ---
(In reply to Jessie Zairo from comment #8)
> When testing, I get to Administration > Itemtypes> Edit > select Centerville
> > Save and I get the following error 
> 
> Undefined subroutine
> ::Compile::ROOT::kohadevbox_koha_admin_itemtypes_2epl::p called at
> /kohadevbox/koha/admin/itemtypes.pl line 202.
>  at /kohadevbox/koha/admin/itemtypes.pl line 201

Sorry, my bad.. forgot to cleanup debug statements.

Please try again

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15497] Limit Item Types by Branch

2019-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15497

--- Comment #10 from Agustín Moyano  ---
Created attachment 91451
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91451=edit
Bug 15497: Modify schemas

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15497] Limit Item Types by Branch

2019-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15497

Agustín Moyano  changed:

   What|Removed |Added

  Attachment #91377|0   |1
is obsolete||
  Attachment #91378|0   |1
is obsolete||
  Attachment #91379|0   |1
is obsolete||
  Attachment #91446|0   |1
is obsolete||

--- Comment #9 from Agustín Moyano  ---
Created attachment 91450
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91450=edit
Bug 15497: Add itemtypes_branches table and atomic update

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15497] Limit Item Types by Branch

2019-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15497

--- Comment #11 from Agustín Moyano  ---
Created attachment 91452
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91452=edit
Bug 15497: Limit itemtypes by branch in additem.pl

This patch adds a select multiple when you add/edit an itemtype, creates
functions to return itemtypes by library, and filters the options of itemtype
select in additem

To test:
1) Apply this patch set
2) perl installer/data/mysql/updatedatabase.pl
3) In koha administration => item types, edit "Books" itemtype
CHECK => there is now a select multiple whith libraries at the bottom
4) select centerville and save
5) set centerville as current libary
6) search for any biblio in the catalog
7) click on "edit items"
CHECK => book item type is present
8) set any other libary as current library
SUCCESS => book item type is not present
9) Sign off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15497] Limit Item Types by Branch

2019-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15497

Agustín Moyano  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23295] Automatically debar patrons if SMS or email notice fail

2019-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23295

Alex Buckley  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||hayleymap...@catalyst.net.n
   ||z
  Change sponsored?|--- |Sponsored
   Assignee|koha-b...@lists.koha-commun |alexbuck...@catalyst.net.nz
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23295] New: Automatically debar patrons if SMS or email notice fail

2019-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23295

Bug ID: 23295
   Summary: Automatically debar patrons if SMS or email notice
fail
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Notices
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: alexbuck...@catalyst.net.nz
QA Contact: testo...@bugs.koha-community.org

When the sending of an SMS (or email) notice fails at the Koha level (i.e.
before it is passed to the SMS API) then librarians should have the ability to
enable automatic restriction (debarment) of patrons prompting them to update
their smsalertnumber (or email address) in their library accounts. 

Adding this ability will tie in nicely with the functionality implemented in
bug 13552 and bug 23291.

As the enhancement for this bug report would let us restrict when notices
failed at the Koha level, whereas 13552 and 23291 would let librarians restrict
when notices failed at the SMS API level in batch restriction jobs retrieving
patrons by SMS numbers in the SMS gateway report libraries get telling them
which notices failed at the SMS API level. 

So all three enhancements together will mean there will be end-to-end
functionality to restrict patrons when SMS notices fail, thereby prompting them
to update their smsalertnumber.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23151] Patron self modification sends null dateofbirth

2019-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23151

George Williams (NEKLS)  changed:

   What|Removed |Added

 CC||geo...@nekls.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15522] New interface for revamped circulation rules

2019-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522

Cab Vinton  changed:

   What|Removed |Added

 CC||bibli...@gmail.com

--- Comment #22 from Cab Vinton  ---
If it's not too late to add a suggestion, systems with multiple (N) branches
often end up with the same rule duplicated N times, once for each library.

Ideally, this would be simplified to a single rule that applies to all
branches.

Thinking a button to run a clean-up script might do the trick.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13199] Incoherence between 'en' sample notices and translated notices

2019-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13199

M. Tompsett  changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com

--- Comment #18 from M. Tompsett  ---
*** Bug 13808 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13808] sample_notices are inconsistent

2019-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13808

M. Tompsett  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #3 from M. Tompsett  ---
This was remedied by the xt/sample_notices.t catching everything.
bug 13199.

*** This bug has been marked as a duplicate of bug 13199 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23294] standing order not showing actual cost when modifying order

2019-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23294

Jessie Zairo  changed:

   What|Removed |Added

 CC||jza...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23020] Standing Order basket not reflecting payment on order line

2019-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23020

Jessie Zairo  changed:

   What|Removed |Added

 CC||jza...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23068] Add ability for Koha to handle X-Forwarded-For headers so REMOTE_ADDR features work behind a proxy

2019-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068

Kyle M Hall  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #11 from Kyle M Hall  ---
Found a problem. The middleware is working via plack so we can the real ip
address when we are on a script that uses plack. When we visit a script that
doesn't use plack, this code doesn't get executed and so Koha sees the proxy ip
instead.
And Koha does what it always does when a session changes ip addresses, it
forces a re-login

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11677] Limit to Only items currently available for loan or reference not working

2019-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11677

--- Comment #22 from rkui...@roundrocktexas.gov ---
I get comments on this broken function regularly.  Our staff would LOVE to have
this fixed.  I have voted for this fix.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15497] Limit Item Types by Branch

2019-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15497

Jessie Zairo  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #8 from Jessie Zairo  ---
When testing, I get to Administration > Itemtypes> Edit > select Centerville >
Save and I get the following error 

Undefined subroutine
::Compile::ROOT::kohadevbox_koha_admin_itemtypes_2epl::p called at
/kohadevbox/koha/admin/itemtypes.pl line 202.
 at /kohadevbox/koha/admin/itemtypes.pl line 201

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23294] New: standing order not showing actual cost when modifying order

2019-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23294

Bug ID: 23294
   Summary: standing order not showing actual cost when modifying
order
 Change sponsored?: ---
   Product: Koha
   Version: 18.11
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: and...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

Bug 23020 already details how received cost for standing orders is not shown on
basket.pl. 18.11 has changed how costs are calculated and displayed on
neworderempty.pl, exacerbating the problem

To Test:
- Create a standing order basket
- Add an order to that basket with no price information filled out
- Receive a copy of the standing order and record an actual price at receipt
- Go back to your basket and click Modify for your received order
- See that it still shows $0 for Total

Prior to 18.11, Total was derived from aqorders.unitprice, which reflected the
Actual Cost entered when receiving. Now it is only derived from budgeted cost.
This is an issue for standing orders, for which many libraries do not enter a
budgeted cost, only an actual cost at receipt.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23293] OPACFineNoRenewals compares against 'balance' not 'outstanding'

2019-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23293

--- Comment #3 from Martin Renvoize  ---
Test plan
1) Apply the patches
2) Run the DB update
3) Set the new systempreference to 'Do not'
4) Check the OPACFineNoRenewals functionality now takes account of only
outstanding debts and not ignores outstanding credits.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23293] OPACFineNoRenewals compares against 'balance' not 'outstanding'

2019-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23293

Martin Renvoize  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11677] Limit to Only items currently available for loan or reference not working

2019-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11677

Margaret  changed:

   What|Removed |Added

 CC||margaret@bywatersolutions.c
   ||om

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23293] OPACFineNoRenewals compares against 'balance' not 'outstanding'

2019-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23293

--- Comment #1 from Martin Renvoize  ---
Created attachment 91448
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91448=edit
Bug 23293: Add system preference

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23293] OPACFineNoRenewals compares against 'balance' not 'outstanding'

2019-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23293

--- Comment #2 from Martin Renvoize  ---
Created attachment 91449
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91449=edit
Bug 23293: Apply OPACFineNoRenewalsIncludeCredit preference

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23007] Make dialogs in returns.pl optionally modal

2019-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23007

Lisette Scheer  changed:

   What|Removed |Added

 CC||lisettesla...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23007] Make dialogs in returns.pl optionally modal

2019-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23007

koha-US bug tracker  changed:

   What|Removed |Added

 CC||bugzi...@koha-us.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11677] Limit to Only items currently available for loan or reference not working

2019-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11677

Chris Rohde  changed:

   What|Removed |Added

 CC||cro...@roseville.ca.us

--- Comment #21 from Chris Rohde  ---
Yes, this is pretty basic OPAC functionality--can someone please take a look at
fixing this bug?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22868] Separate Permissions for "Manage Purchase Suggestions" and "Enter Purchase Suggestions"

2019-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22868

koha-US bug tracker  changed:

   What|Removed |Added

 CC||bugzi...@koha-us.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11677] Limit to Only items currently available for loan or reference not working

2019-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11677

Christopher Brannon  changed:

   What|Removed |Added

 CC||cbran...@cdalibrary.org

--- Comment #20 from Christopher Brannon  ---
Is this going to get fixed???

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23129] Items holdingbranch should be set to the originating library when generating a transfer

2019-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23129

koha-US bug tracker  changed:

   What|Removed |Added

 CC||bugzi...@koha-us.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23145] Confirming transfer during checkin clears the table of previously checked-in items

2019-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23145

koha-US bug tracker  changed:

   What|Removed |Added

 CC||bugzi...@koha-us.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13325] Add logs for budgets and funds

2019-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13325

John Sterbenz  changed:

   What|Removed |Added

 CC||jster...@umich.edu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20948] Hold requests on detail.pl

2019-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20948

koha-US bug tracker  changed:

   What|Removed |Added

 CC||bugzi...@koha-us.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23068] Add ability for Koha to handle X-Forwarded-For headers so REMOTE_ADDR features work behind a proxy

2019-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #91174|0   |1
is obsolete||

--- Comment #10 from Kyle M Hall  ---
Created attachment 91447
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91447=edit
Bug 23068: Allow the list of proxy IPs to be set in the koha-conf.xml file

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15497] Limit Item Types by Branch

2019-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15497

--- Comment #7 from Kyle M Hall  ---
Created attachment 91446
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91446=edit
Bug 15497: Remove use of Data::Printer

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23283] cannot view/edit additional attributes in 18.11.x

2019-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23283

Fridolin SOMERS  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19618] Automatic/standing holds

2019-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19618

--- Comment #2 from Agustín Moyano  ---
This bug is intended to add the ability for clubs to place a hold for bibs

This means that when a club places a hold, what really happens is that a hold
will automatically be placed for each member in random order.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19618] Automatic/standing holds

2019-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19618

Agustín Moyano  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23214] OPAC add ability to pay guarantees fines

2019-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23214

Agustín Moyano  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

--- Comment #4 from Agustín Moyano  ---
(In reply to Arthur Bousquet from comment #2)
> I got these errors when trying to apply the patch
> 
> fatal: sha1 information is lacking or useless
> (koha-tmpl/opac-tmpl/bootstrap/en/includes/account-table.inc).
> error: could not build fake ancestor
> Patch failed at 0001 Bug 23214: Modify account-table.inc to enable payment
> of guarantees fines

Weird, patch applies for me with merge.. 

91007 - Bug 23214: Modify account-table.inc to enable payment of guarantees
fines

Apply? [(y)es, (n)o, (i)nteractive] y
Aplicando: Bug 23214: Modify account-table.inc to enable payment of guarantees
fines
Usando la información del índice para reconstruir un árbol base...
M   koha-tmpl/opac-tmpl/bootstrap/en/includes/account-table.inc
Retrocediendo para parchar base y fusión de 3-vías...
Auto-fusionando koha-tmpl/opac-tmpl/bootstrap/en/includes/account-table.inc

Maybe it's because I rebased 14570, and now applies nicely.

Please try again.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

2019-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

--- Comment #161 from Agustín Moyano  ---
Created attachment 91445
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91445=edit
Bug 14570: (follow-up) Fix patron type when "add child" button is pressed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

2019-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

Agustín Moyano  changed:

   What|Removed |Added

  Attachment #89911|0   |1
is obsolete||
  Attachment #89912|0   |1
is obsolete||
  Attachment #89921|0   |1
is obsolete||
  Attachment #89922|0   |1
is obsolete||
  Attachment #89929|0   |1
is obsolete||
  Attachment #90048|0   |1
is obsolete||
  Attachment #91231|0   |1
is obsolete||

--- Comment #155 from Agustín Moyano  ---
Created attachment 91439
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91439=edit
Bug 14570: Make it possible to add multiple guarantors to a record

This patch adds the ability to set an unlimited number of guarantors
for a given patron. As before, each guarantor may be linked to another
Koha patron, and all the behavior that applies to a given guarantor
remains the same.

Test Plan:
 1) Apply this patch
 2) Run updatedatabase.pl
 3) Find some patrons with guarantors, verify the still have their guarantor
 4) Test adding and removing guarantors on a patron record, both Koha users and
not
 5) Verify the "Add child" button works
 6) Verify NoIssuesChargeGuarantees still works
 7) Verify tools/cleanborrowers.pl will not delete a guarantor
 8) Verify the guarantors are displayed on moremember.pl
 9) Verify the guarantor is removed by members/update-child.pl
10) Verify the guarantor is removed by misc/cronjobs/j2a.pl
11) Verify import patrons converts guarantor_id, relationship,
contactfirstname,
  and contactsurname into a guarantor
12) prove t/Patron.t
13) prove t/db_dependent/Circulation.t
14) prove t/db_dependent/Circulation/NoIssuesChargeGuarantees.t
15) prove t/db_dependent/Items.t
16) prove t/db_dependent/Koha/Patrons.t
17) prove t/db_dependent/Members.t
18) prove t/db_dependent/Patron/Relationships.t

Signed-off-by: Kim Peine 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

2019-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

--- Comment #158 from Agustín Moyano  ---
Created attachment 91442
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91442=edit
Bug 14570: (follow-up) fix qa FAIL tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

2019-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

--- Comment #156 from Agustín Moyano  ---
Created attachment 91440
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91440=edit
Bug 14570: Update schema files [Do Not Push]

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

2019-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

--- Comment #159 from Agustín Moyano  ---
Created attachment 91443
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91443=edit
Bug 14570: (follow-up) Fix tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

2019-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

--- Comment #160 from Agustín Moyano  ---
Created attachment 91444
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91444=edit
Bug 14570: (QA follow-up) fix sample borrowers, remove guarantorid)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

2019-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

--- Comment #157 from Agustín Moyano  ---
Created attachment 91441
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91441=edit
Bug 14570: (follow-up) fix table name in j2a.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23057] If checked_in_ok is set and item is not checked out, alert flag is supressed for *any* reason

2019-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23057

--- Comment #29 from Kyle M Hall  ---
No problem! A second pair of eyes never hurts :)

(In reply to Marcel de Rooy from comment #28)
> (In reply to Kyle M Hall from comment #26)
> > Comment on attachment 91326 [details] [review] [review]
> > Bug 23057: (QA follow-up) Stay closer to old code
> > 
> > I agree with Liz of course ;)
> > 
> > The old code is messy and confusing. I put a lot of thought into the changes
> > I made to make the code clean, terse and understandable. I don't think we
> > should put back bad code just for the sake of leaving it unchanged in this
> > case. There is very real benefit to the new code consolidating logic for the
> > benefit of future developers who have to deal with this code.
> 
> No problem. But in that case it may not harm to have another QAer look at it
> too. Thanks for your feedback.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23112] Circulation of ILL items

2019-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112

--- Comment #8 from Martin Renvoize  ---
It's on the wiki

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22613] Add /patrons/patron_id/checkouts endpoints

2019-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22613

Josef Moravec  changed:

   What|Removed |Added

  Attachment #88450|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23112] Circulation of ILL items

2019-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #7 from Katrin Fischer  ---
Can the alternative be shared? There seemed to be agreement on this one (see
dicussion on wiki and comments here)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23293] New: OPACFineNoRenewals compares against 'balance' not 'outstanding'

2019-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23293

Bug ID: 23293
   Summary: OPACFineNoRenewals compares against 'balance' not
'outstanding'
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: martin.renvo...@ptfs-europe.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

The OPACFineNoRenewals (and consequently the OPACFineNoRenewalsBlockAutoRenew)
feature uses the patrons' account balance (which combines outstanding credits
and debits) as opposed to their outstanding debts.  This should either be
configurable (or perhaps coded to use outstanding debts instead) as it does not
accurately reflect what a patron may owe when AccountAutoReconcile is set to
'Do not' apply.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23057] If checked_in_ok is set and item is not checked out, alert flag is supressed for *any* reason

2019-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23057

--- Comment #28 from Marcel de Rooy  ---
(In reply to Kyle M Hall from comment #26)
> Comment on attachment 91326 [details] [review]
> Bug 23057: (QA follow-up) Stay closer to old code
> 
> I agree with Liz of course ;)
> 
> The old code is messy and confusing. I put a lot of thought into the changes
> I made to make the code clean, terse and understandable. I don't think we
> should put back bad code just for the sake of leaving it unchanged in this
> case. There is very real benefit to the new code consolidating logic for the
> benefit of future developers who have to deal with this code.

No problem. But in that case it may not harm to have another QAer look at it
too. Thanks for your feedback.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23057] If checked_in_ok is set and item is not checked out, alert flag is supressed for *any* reason

2019-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23057

--- Comment #27 from Marcel de Rooy  ---
(In reply to Liz Rea from comment #25)
> I don't understand why the last patch is necessary?

Explained in the commit message. Not much more to say

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17003] REST API: add route to get checkout's renewability

2019-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17003

Josef Moravec  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #31 from Josef Moravec  ---
Fridolin, are you going to backport this to 19.05?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23057] If checked_in_ok is set and item is not checked out, alert flag is supressed for *any* reason

2019-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23057

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #91326|0   |1
is obsolete||

--- Comment #26 from Kyle M Hall  ---
Comment on attachment 91326
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91326
Bug 23057: (QA follow-up) Stay closer to old code

I agree with Liz of course ;)

The old code is messy and confusing. I put a lot of thought into the changes I
made to make the code clean, terse and understandable. I don't think we should
put back bad code just for the sake of leaving it unchanged in this case. There
is very real benefit to the new code consolidating logic for the benefit of
future developers who have to deal with this code.

(In reply to Marcel de Rooy from comment #24)
> Kyle,
> Please have a look at the last follow-up. And let me know if you are
> comfortable with it. I am at least, since we stay closer to the old code
> while resolving the bug. If you are too, I will pass QA.
> 
> Marcel

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23112] Circulation of ILL items

2019-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112

--- Comment #6 from Martin Renvoize  ---
An alternative specification has been sent to the customer and agreed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23112] Circulation of ILL items

2019-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112

Martin Renvoize  changed:

   What|Removed |Added

  Change sponsored?|--- |Sponsored

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23292] Use TransferSlip when transfering item which is on hold

2019-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23292

Johanna Räisä  changed:

   What|Removed |Added

  Change sponsored?|--- |Sponsored
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23292] Use TransferSlip when transfering item which is on hold

2019-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23292

--- Comment #1 from Johanna Räisä  ---
Created attachment 91438
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91438=edit
Bug 23292: Use TransferSlip when transfering item which is on hold

Combining hold and transfer slips might get confusing for patrons. Those
represent quite different things.
Hold slip could be used on self-service pickup for patrons and transfer slip
has information for librarians.
There can also be data protection issue if same slip is used in both cases.

Test plan:
- Apply the patch
- Create hold for a record, define pickup branch different than your current
branch.
- Check in an item from your branch.
- Click 'Print slip, transfer, and confirm'
- See that the slip is TRANSFERSLIP
- Change your branch same as hold's pickup branch
- Check in the item again.
- Click 'Print slip and confirm'
- See that the slip is now HOLD_SLIP

Sponsored-by: Koha-Suomi Oy

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23048] Hide non-pickup branches from hold modification select

2019-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23048

Katrin Fischer  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=7534
 CC||katrin.fisc...@bsz-bw.de

--- Comment #5 from Katrin Fischer  ---
Would this be the same as bug 7534, but for staff?

Bug 7534 - New OPACAllowUserToChooseBranch setting for only showing libraries
allowing holds

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7534] New OPACAllowUserToChooseBranch setting for only showing libraries allowing holds

2019-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534

Katrin Fischer  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=23048

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15260] Option for extended loan with useDaysMode

2019-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15260

Martin Renvoize  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com
   Keywords||RM_priority

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23292] New: Use TransferSlip when transfering item which is on hold

2019-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23292

Bug ID: 23292
   Summary: Use TransferSlip when transfering item which is on
hold
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Notices
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: johanna.ra...@koha-suomi.fi
QA Contact: testo...@bugs.koha-community.org

Now when Koha asks to transfer an item which is on hold it will give HoldSlip
to a librarian. We have TransferSlip which is used in other transfering
situations, so we should use this also when transfering hold item. The HoldSlip
should trigger when the item is checked in after transfer to the right branch.

Combining the hold and transfer slips might get confusing if the slip is used
on self-service pickup as we are doing in Finnish public libraries. Also there
comes the data protection issue if other patrons can see too much information
about holds.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23292] Use TransferSlip when transfering item which is on hold

2019-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23292

Johanna Räisä  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |johanna.ra...@koha-suomi.fi
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22142] An item's current location changes to blank when it is removed from Course Reserves

2019-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22142

--- Comment #5 from Katrin Fischer  ---
We are losing data here... any chance for a fix?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22984] Holding branch disappears after saving to course and isn't restored when removing item from course

2019-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22984

Katrin Fischer  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #2 from Katrin Fischer  ---
I think this is a duplicate of bug 22142 - please undo if I was mistaken.

*** This bug has been marked as a duplicate of bug 22142 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22142] An item's current location changes to blank when it is removed from Course Reserves

2019-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22142

Katrin Fischer  changed:

   What|Removed |Added

 CC||jza...@bywatersolutions.com

--- Comment #4 from Katrin Fischer  ---
*** Bug 22984 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/