[Koha-bugs] [Bug 23663] Itemtype summary feature in search results is only used in deprecated opac results non-xslt view

2019-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23663

Katrin Fischer  changed:

   What|Removed |Added

   Keywords||Manual

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23663] Itemtype summary feature in search results is only used in deprecated opac results non-xslt view

2019-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23663

Katrin Fischer  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=17598

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17598] Make use of itemtypes.summary

2019-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17598

Katrin Fischer  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=23663

--- Comment #5 from Katrin Fischer  ---
Some working test plan is on bug 23663.

It has some issues, like displaying  in the result list when activated.

I think if we can't implement the feature for XSLT results, we should remove
it.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23663] Itemtype summary feature in search results is only used in deprecated opac results non-xslt view

2019-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23663

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23663] Itemtype summary feature in search results is only used in deprecated opac results non-xslt view

2019-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23663

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #93085|0   |1
is obsolete||

--- Comment #3 from Katrin Fischer  ---
Created attachment 93135
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93135=edit
Bug 23663: Only process itemtype summary if using non-xslt opac results

To test:
1 - Set OpacXSLTResultsDisplay to "" to use non-xslt view
2 - In Administration->Itemtypes define a summary for an itemtype:
This is the summary for [245a]
3 - Perform a search on the opac that will return results with this itemtype
4 - Note "This is the summary" appears in results with the title
5 - Set OPACXSLTResultsDisplay to 'default'
6 - Refresh your search results, note the summary disappears
7 - Try search in other places and note that summary never appears
8 - Apply patch
9 - Repeat 1-7 and note nothing changed

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23663] Itemtype summary feature in search results is only used in deprecated opac results non-xslt view

2019-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23663

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #2 from Katrin Fischer  ---
Note: you also need to have an itemtype on record level. And there are some
display issues witht he feature, it will print out line breaks (filters
suspected):
 The Thirty Years War :

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23086] Search for collection is broken

2019-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23086

--- Comment #3 from Katrin Fischer  ---
Hi Kyle, could you add a bit of a description of the fix and a test plan
please? Thx for taking this up!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23631] fr-CA translation of NEW_SUGGESTION notice

2019-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23631

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #93018|0   |1
is obsolete||

--- Comment #4 from Katrin Fischer  ---
Created attachment 93134
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93134=edit
Bug 23631 - fr-CA translation of NEW_SUGGESTION notice

This patch provides the fr-CA translation for the NEW_SUGGESTION notice.

Signed-off-by: Bin Wen 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23631] fr-CA translation of NEW_SUGGESTION notice

2019-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23631

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
   Patch complexity|String patch|Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import

2019-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

Carl  changed:

   What|Removed |Added

 CC||ct...@hcc.edu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23671] Elasticsearch shouldn't throw exception on an uppercase subfield identifier

2019-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23671

Nicolas Legrand  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23671] Elasticsearch shouldn't throw exception on an uppercase subfield identifier

2019-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23671

--- Comment #1 from Nicolas Legrand  ---
Created attachment 93133
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93133=edit
Bug 23671: Elasticsearch shouldn't throw exception on an uppercase subfield
identifier

Prevent Elasticsearch from throwing an exception when the mappings
include uppercase subfield identifier.

Though forbidden in MARC21, It doesn't seem to be the case for Unimarc
or ISO 2709 as a whole. It is also possible to define such a subfield
identifier in the Koha MARC Framework and in the Elasticsearch
mappings.

Test plan:

1. add a 995Z subfield identifier in Elasticsearch mappings
(Administration -> Search engine configuration)

2. run $KOHA_PATH/misc/search_tools/rebuild_elasticsearch.pl -v -d -b

3. see it throw: “Invalid MARC field expression: 995Z”

4. apply patch

5. rerun $KOHA_PATH/misc/search_tools/rebuild_elasticsearch.pl -v -d -b

6. sababa

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17721] Do we need utf8_bin collation on tagsubfield?

2019-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17721

Nicolas Legrand  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=23671

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23670] Load Koha::Exceptions::ElasticSearch module in Koha::SearchEngine::Elasticsearch

2019-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23670

Nicolas Legrand  changed:

   What|Removed |Added

 Blocks||23671


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23671
[Bug 23671] Elasticsearch shouldn't throw exception on an uppercase subfield
identifier
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23671] New: Elasticsearch shouldn't throw exception on an uppercase subfield identifier

2019-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23671

Bug ID: 23671
   Summary: Elasticsearch shouldn't throw exception on an
uppercase subfield identifier
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: trivial
  Priority: P5 - low
 Component: Searching - Elasticsearch
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: nicolas.legr...@bulac.fr
Depends on: 23670

MARC 21 specifies a subfield identifier “may be any any lowercase alphabetic or
numeric character” (https://www.loc.gov/marc/96principl.html section 8.4.2).

It is not that clear for Unimarc or even for ISO 2709 itself. Our catalogue in
Unimarc use uppercase alphabetic subfield identifier for items. When we try to
index it with Elasticsearch, it throws an exception (well, it tries to, this is
fixed by Bug 23670).

We think Elasticsearch shouldn't be picky about uppercase alphabetic subfield
identifier, especially when Koha permits their creation in the MARC Framework
or in the Elasticsearch mapping.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23670
[Bug 23670] Load Koha::Exceptions::ElasticSearch module in
Koha::SearchEngine::Elasticsearch
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23670] Load Koha::Exceptions::ElasticSearch module in Koha::SearchEngine::Elasticsearch

2019-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23670

Nicolas Legrand  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23670] Load Koha::Exceptions::ElasticSearch module in Koha::SearchEngine::Elasticsearch

2019-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23670

--- Comment #1 from Nicolas Legrand  ---
Created attachment 93132
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93132=edit
Bug 23670 Load Koha::Exceptions::ElasticSearch module in
Koha::SearchEngine::Elasticsearch

Prevent Koha::SearchEngine::Elasticsearch from dying when trying to run
Koha::Exceptions::Elasticsearch::MARCFieldExprParseError->throw()

Plan test:

1. Go to Administration -> Searchengine configuration, and add a mapping
   for 995Z, whatever the search field (I did it with local-classification),
   save
2. run $KOHA_PATH/misc/search_tools/rebuild_elasticsearch.pl -v -d -b
3. see it die asking for Koha::Exceptions::Elasticsearch
4. apply patch
5. rerun $KOHA_PATH/misc/search_tools/rebuild_elasticsearch.pl -v -d -b
6. see it throw: Invalid MARC field expression: 995Z

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23626] Add a system preference to limit the number of rows of data used in a chart when viewing report results

2019-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23626

--- Comment #22 from Nick Clemens  ---
(In reply to Katrin Fischer from comment #21)
> With the caching on the svc you can often see confusing results when testing
> JSON - I think using it in the GUI could give the same problem.

I think we could add some info to GUI to make it more clear how the caching
operates and why you would set it.

> Is it really such an issue that we should not allow people to get "all" if
> they explicitly check "all"? I think at least you'd want the GUI behave
> differently than a more restricted web service that might be used by third
> parties.

It is a big issue because loading a full set of results can crash the system.
Reports with a large amounts of rows/data must be loaded into memory to pass to
the template in either scenario.

(DON'T) Try running:
SELECT * FROM items JOIN biblio_metadata USING (itemnumber) JOIN items i ON
1=1;

It generates so much data it will lock the system (mine required a hard
reboot). This is a silly report, but honestly large reports that are legitimate
in production systems are triggering this issue.

Charts are neat, but I think we can limit the amount of data they get and rely
on exporting to tools meant for data analysis if large scale are needed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23670] New: Load Koha::Exceptions::ElasticSearch module in Koha::SearchEngine::Elasticsearch

2019-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23670

Bug ID: 23670
   Summary: Load Koha::Exceptions::ElasticSearch module in
Koha::SearchEngine::Elasticsearch
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: trivial
  Priority: P5 - low
 Component: Searching - Elasticsearch
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: nicolas.legr...@bulac.fr

When your mapping includes an Invalid MARC field expression, it tries to throw
an exception with Koha::Exceptions::Elasticsearch::MARCFieldExprParseError. But
since Koha::Exceptions::Elasticsearch isn't loaded in
Koha::SearchEngine::Elasticsearch, it dies like this:

Can't locate Koha/Exceptions/Elasticsearch/MARCFieldExprParseError.pm in @INC
(you may need to install the
Koha::Exceptions::Elasticsearch::MARCFieldExprParseError module)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23626] Add a system preference to limit the number of rows of data used in a chart when viewing report results

2019-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23626

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #21 from Katrin Fischer  ---
(In reply to Nick Clemens from comment #20)
> Presenting an alternate patch here. We should only fetch the additional
> chart data when needed, using the report/svc we can get the json on demand.
> This also allows us to utilize the existing syspref SvcMaxReportRows
> 
> Please test and let me know what you think.

With the caching on the svc you can often see confusing results when testing
JSON - I think using it in the GUI could give the same problem.

Is it really such an issue that we should not allow people to get "all" if they
explicitly check "all"? I think at least you'd want the GUI behave differently
than a more restricted web service that might be used by third parties.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23667] Add API route for listing items

2019-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23667

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23667] Add API route for listing items

2019-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23667

--- Comment #4 from Tomás Cohen Arazi  ---
Created attachment 93131
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93131=edit
Bug 23667: (follow-up) Cleanup

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22280] The ILL module assumes every status needs a next/previous status

2019-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22280

--- Comment #13 from Martin Renvoize  ---
I'd really like to see a unit test added for this however ;)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23667] Add API route for listing items

2019-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23667

--- Comment #3 from Tomás Cohen Arazi  ---
Created attachment 93130
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93130=edit
Bug 23667: Add route to GET /items

This patchset introduces a route to fetch items. It relies on the
already implemented code/mappings to get a single item.

To test:
- Apply this patches
- Run:
  $ kshell
 k$ prove t/db_dependent/api/v1/items.t
=> SUCCESS: Tests pass!
- Try the endpoint with your favourite API tool (Postman?)
- Sign off :-D

Note: to do exact searching on barcode, you need to build the query like
this:

GET /api/v1/items?external_id=&_match=exact

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23667] Add API route for listing items

2019-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23667

--- Comment #2 from Tomás Cohen Arazi  ---
Created attachment 93129
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93129=edit
Bug 23667: Add spec

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22280] The ILL module assumes every status needs a next/previous status

2019-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22280

Martin Renvoize  changed:

   What|Removed |Added

   Keywords||additional_work_needed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22280] The ILL module assumes every status needs a next/previous status

2019-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22280

--- Comment #12 from Martin Renvoize  ---
Created attachment 93128
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93128=edit
Bug 22280: (RM follow-up) Correction to POD

Minor correction to mislabled POD section for private method.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22280] The ILL module assumes every status needs a next/previous status

2019-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22280

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #93125|0   |1
is obsolete||

--- Comment #11 from Martin Renvoize  ---
Created attachment 93127
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93127=edit
Bug 22280: Fix typo in _status_graph_union

Signed-off-by: Tomas Cohen Arazi 
Signed-off-by: Andrew Isherwood 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23626] Add a system preference to limit the number of rows of data used in a chart when viewing report results

2019-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23626

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com

--- Comment #20 from Nick Clemens  ---
Presenting an alternate patch here. We should only fetch the additional chart
data when needed, using the report/svc we can get the json on demand. This also
allows us to utilize the existing syspref SvcMaxReportRows

Please test and let me know what you think.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23626] Add a system preference to limit the number of rows of data used in a chart when viewing report results

2019-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23626

--- Comment #19 from Nick Clemens  ---
Created attachment 93126
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93126=edit
Bug 23626: [alternate] Use svc/reports to fetch chart data

We have a method for getting json report data via svc, and this has a built in
limiter in the sysprefs. We can utilise this for our charts to avoid
passing all data in memory

To test:
1 - Write a report that can be charted, for example:
SELECT RIGHT(barcode,2), COUNT(*)
FROM items
WHERE RIGHT(barcode,1) != <>
GROUP BY RIGHT(barcode,2)
2 - Set the 'Cache expiry' to 1 for this report
3 - Run it and click 'Create chart' on results page
Chart type: Pie
x column RIGHT(barcode,2)
Include all rows: UNCHECKED
4 - Note you get a nice pie chart
5 - Click 'Create chart', same except check 'Include all rows'
6 - Note you get a different pie
7 - Apply patch
8 - Repeat above - note that 'all rows' is now 'Fetch additional rows' and
notes the sys pref control
9 - Increase SvcMaxReportRows and note chart changes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22280] The ILL module assumes every status needs a next/previous status

2019-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22280

Martin Renvoize  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #10 from Martin Renvoize  ---
Taking Andrews SO as a QA here as he's the topic expert when it comes to ILL.
:)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22280] The ILL module assumes every status needs a next/previous status

2019-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22280

Martin Renvoize  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22280] The ILL module assumes every status needs a next/previous status

2019-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22280

--- Comment #9 from Martin Renvoize  ---
*** Bug 20923 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20923] Merging backend status graph into main status graph incorrect use of grep

2019-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20923

Martin Renvoize  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com
 Resolution|--- |DUPLICATE
 Status|ASSIGNED|RESOLVED

--- Comment #2 from Martin Renvoize  ---


*** This bug has been marked as a duplicate of bug 22280 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21947] Filtering order generates html in notes

2019-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21947

Fridolin SOMERS  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=23412

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22280] The ILL module assumes every status needs a next/previous status

2019-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22280

Andrew Isherwood  changed:

   What|Removed |Added

  Attachment #91232|0   |1
is obsolete||

--- Comment #8 from Andrew Isherwood  ---
Created attachment 93125
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93125=edit
Bug 22280: Fix typo in _status_graph_union

Signed-off-by: Tomas Cohen Arazi 
Signed-off-by: Andrew Isherwood 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23412] HTML should be allowed in MARC notes. (5xx fields)

2019-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23412

Fridolin SOMERS  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=21947

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23412] HTML should be allowed in MARC notes. (5xx fields)

2019-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23412

Fridolin SOMERS  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #5 from Fridolin SOMERS  ---
I think we should use html_line_break filter like it used to be : to allow HTML
and also present simple multi-lines text.

Patch must cover staff and basket on MARCNOTES and notes.

I'm on a patch and a nice test plan.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous payments in a POS fashion

2019-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354

Sally  changed:

   What|Removed |Added

 CC||sally.healey@cheshireshared
   ||services.gov.uk

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23653] Plack stopped working - JSON validation timeout

2019-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653

--- Comment #3 from Rick Conrad  ---


rick@koha:~$ pmvers JSON::Validator
1.08
rick@koha:~$ pmvers Mojolicious
7.59
rick@koha:~$ pmvers Mojolicious::Plugin::OpenAPI
1.15


Also


rick@koha:~$ cd /
rick@koha:/$ sudo find . -name swagger
./usr/share/koha/api/v1/swagger
rick@koha:/$ cd /usr/share/koha/api/v1/swagger/
rick@koha:/usr/share/koha/api/v1/swagger$ ls
definitions   parameters   paths   swagger.json
definitions.json  parameters.json  paths.json  x-primitives.json
```

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21302] Link in 780/785 should search for $t in title and $a in author

2019-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21302

Carl  changed:

   What|Removed |Added

 CC|ct...@hcc.edu   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21302] Link in 780/785 should search for $t in title and $a in author

2019-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21302

Carl  changed:

   What|Removed |Added

 CC||ct...@hcc.edu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21860] Marc modification templates cannot check or change indicators

2019-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21860

Carl  changed:

   What|Removed |Added

 CC||ct...@hcc.edu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23667] Add API route for listing items

2019-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23667

Tomás Cohen Arazi  changed:

   What|Removed |Added

Summary|Add API route for getting   |Add API route for listing
   |an item by barcode  |items
   Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com
   |ity.org |
 Status|NEW |ASSIGNED
URL||https://wiki.koha-community
   ||.org/wiki/Items_endpoint_RF
   ||C

--- Comment #1 from Tomás Cohen Arazi  ---
We really need to implement the

GET /items

route. Which would include filters on many of the item attributes. including
barcode. It will, tough, return a list of matching items (probably only one if
filtering by barcode).

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15165] REST API routes to list, edit and pay borrower's accountlines

2019-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15165

--- Comment #66 from Tomás Cohen Arazi  ---
(In reply to Fridolin SOMERS from comment #65)
> Is this a duplicate of Bug 20942 ?

Somehow. It really depends on what you're planning to do with the API. I'd say
we should complete it the endpoint to add debits (minor work required to write
it).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23666] Add API route for additional patron attributes

2019-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23666

--- Comment #1 from Tomás Cohen Arazi  ---
Hi, Stefan. I think you should add this proposal for discussion and voting
here:

https://wiki.koha-community.org/wiki/REST_api_RFCs

One thing to note is that attributes might be repeatable, so using POST AND PUT
is valid (POST for adding, PUT for replacing).

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17721] Do we need utf8_bin collation on tagsubfield?

2019-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17721

--- Comment #6 from Nicolas Legrand  ---
I didn't find explicitly such a limitation in ISO 2709.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23653] Plack stopped working - JSON validation timeout

2019-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653

Tomás Cohen Arazi  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23653] Plack stopped working - JSON validation timeout

2019-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653

--- Comment #2 from Tomás Cohen Arazi  ---
Can you give us more information on your setup? The 'swagger file' is bundled
in Koha and there shouldn't be any external system reached out.

It would help if you additionally:

$ sudo apt install pmtools

and then we need the output for:

$ pmvers JSON::Validator
$ pmvers Mojolicious
$ pmvers Mojolicious::Plugin::OpenAPI

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous payments in a POS fashion

2019-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354

--- Comment #39 from Martin Renvoize  ---
Created attachment 93124
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93124=edit
Bug 23354: (follow-up) Use 'format_price' for totals

Sponsored-by: PTFS Europe
Sponsored-by: Cheshire Libraries Shared Services

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous payments in a POS fashion

2019-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #92895|0   |1
is obsolete||

--- Comment #36 from Martin Renvoize  ---
Created attachment 93121
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93121=edit
Bug 23354: Add tests for Koha::Charges::Sales

Sponsored-by: PTFS Europe
Sponsored-by: Cheshire Libraries Shared Services

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous payments in a POS fashion

2019-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354

--- Comment #38 from Martin Renvoize  ---
Created attachment 93123
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93123=edit
Bug 23354: (follow-up) Input type on jEditable

Update the jEditable plugin to a maintained version and use the new
'number' type to enable increment arrows on click and remap onblur event
to submit.

Sponsored-by: PTFS Europe
Sponsored-by: Cheshire Libraries Shared Services

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous payments in a POS fashion

2019-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354

--- Comment #37 from Martin Renvoize  ---
Created attachment 93122
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93122=edit
Bug 23354: (follow-up) Add till icon

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous payments in a POS fashion

2019-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #92894|0   |1
is obsolete||

--- Comment #35 from Martin Renvoize  ---
Created attachment 93120
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93120=edit
Bug 23354: Add permissions

Sponsored-by: PTFS Europe
Sponsored-by: Cheshire Libraries Shared Services

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous payments in a POS fashion

2019-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #92891|0   |1
is obsolete||

--- Comment #32 from Martin Renvoize  ---
Created attachment 93117
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93117=edit
Bug 23354: Add receipting to Pay page

This patch adds receipt printing to the new Point of Sale pay page.

Test plan:
1) Apply patch and run database update
2) Enable automatic receipt printing via the `` system preference.
3) Make a payment for an item via the new POS pay page.
4) Note that a receipt printing dialogue is shown automatically after
   payment.
5) Note that a new notice is available under tools where you can alter
   the content of the receipt.
6) Signoff

Sponsored-by: PTFS Europe
Sponsored-by: Cheshire Libraries Shared Services

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous payments in a POS fashion

2019-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #92893|0   |1
is obsolete||

--- Comment #34 from Martin Renvoize  ---
Created attachment 93119
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93119=edit
Bug 23354: (follow-up) Responses to feedback

This patch impliments a number of refinements requested after the first
round of feedback from the sponsors.

1) Fix padding on pay page
2) Switch 'items to add' from right to left on the page
3) Fix editable columns on pay page
4) Add explanitory text to pay page

Sponsored-by: PTFS Europe
Sponsored-by: Cheshire Libraries Shared Services

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous payments in a POS fashion

2019-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #92892|0   |1
is obsolete||

--- Comment #33 from Martin Renvoize  ---
Created attachment 93118
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93118=edit
Bug 23354: Add ability to remove items

This patch adds the ability to remove items from a transactions on the
new Point of Sale pay page.

Test plan:
1) Populate a transaction with at least one item.
2) Note the new button to 'Remove item' on the items table.
3) Click the button and confirm the item is removed
4) Signoff

Sponsored-by: PTFS Europe
Sponsored-by: Cheshire Libraries Shared Services

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous payments in a POS fashion

2019-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #92890|0   |1
is obsolete||

--- Comment #31 from Martin Renvoize  ---
Created attachment 93116
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93116=edit
Bug 23354: Add a Point Of Sale 'pay' screen

This patch adds a new Point Of Sale module to Koha's staff client front
page. The module button leads directly to a 'Pay' page giving the staff
user the ability to record anonymous payments for items that would not
normally require a patron to be registered at the library.

Test plan:
1) Enable `UseCashRegisters` via the system preferences.
2) Ensure your user has the 'manage_cash_registers' permission.
3) Add a cash register for your current branch.
4) Add at least one 'MANUAL_INV' authorized value.
5) Navigate to the new 'POS' pay page via the main menu.
6) Add an item to the 'sale' by clicking 'add' from the right side of
   the screen.
7) Note that said item was added to the table of items this sale on the
   left.
8) At this point you should be able to 'click to edit' the quantity or
   price of the item in the table on the left.
9) Enter an amount greater than the price of the item into the 'amount
   collected from patron' box.
10) Click 'Confirm'
11) Varify that the same change to give modal from the paycollect pages
appears here.
12) Click 'Confirm'
13) Payment will have been recorded (check the database) and you will be
back at a fresh 'Pay' page ready for the next transaction.
14) Signoff

Sponsored-by: PTFS Europe
Sponsored-by: Cheshire Libraries Shared Services

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous payments in a POS fashion

2019-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354

--- Comment #30 from Tomás Cohen Arazi  ---
(In reply to Martin Renvoize from comment #29)
> (In reply to Tomás Cohen Arazi from comment #28)
> > The feature works, and the code is pretty clean. I have a few remarks to be
> > considered:
> > 
> > - We should really have a separate table and stop using MANUAL_INV. It feels
> > really dirty to have a note field contain a decimal value to be used as a
> > number. To start with. I think we agree on this, and there's even work from
> > Josef that would do it.
> 
> Totally agree here.. I was taking the pragmatic approach of not letting that
> work hold this up as we already have the MANUAL_INV code in place.. I intend
> to switch to our own table as a further bug down the line as we have more
> sponsorship in the pipeline for adding features which would require that
> distinction.

Ok.

> > - Things look misaligned to me (hidpi laptop).
> 
> Did you run the yarn build?  I've tried to fix alignment once already, but
> perhaps there are some bits still needing a little work.

That must be it. Re-testing today.

> > - 'Collected from patron' should reuse some patron searching things already
> > exist in the codebase. Thinking of the dialog to pick a guarantor.
> 
> Not sure what you mean here? The 'Collected from patron' input is meant to
> be a monetary value. (Though I do also like the idea of enhancing the screen
> to allow a patron to be optionally linked to the transaction)

I got it wrong! Ok!

> > - Currency symbol is the pound one, no matter what the system is configured
> > to use.
> 
> Oops.. I'll post a followup for that now.
> 
> > - 'Click on the item cost' maybe instead of 'Click on the item'.
> 
> Good catch.
> 
> > - Are you planning on having an inventory of things to sell? I think the use
> > of authorised values is very limited, besides my criticism. I expect
> > librarians wanting to just scan the barcode and get the price on the screen.
> 
> I very much do want to add such functionality, including things like
> barcodes, tax rates etc.. but I see that as part of a bigger piece to
> migrate MANUAL_INC outside of authorized values.

I mentioned it only just in case we could spot something on the code preventing
such enhancement being a smooth addition.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23517] Add /holds/{hold_id}/priority route (PUT)

2019-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23517

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Text to go in the||This development enhances
  release notes||with API with routes to to
   ||change holds priorities.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous payments in a POS fashion

2019-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354

--- Comment #29 from Martin Renvoize  ---
(In reply to Tomás Cohen Arazi from comment #28)
> The feature works, and the code is pretty clean. I have a few remarks to be
> considered:
> 
> - We should really have a separate table and stop using MANUAL_INV. It feels
> really dirty to have a note field contain a decimal value to be used as a
> number. To start with. I think we agree on this, and there's even work from
> Josef that would do it.

Totally agree here.. I was taking the pragmatic approach of not letting that
work hold this up as we already have the MANUAL_INV code in place.. I intend to
switch to our own table as a further bug down the line as we have more
sponsorship in the pipeline for adding features which would require that
distinction.

> - Things look misaligned to me (hidpi laptop).

Did you run the yarn build?  I've tried to fix alignment once already, but
perhaps there are some bits still needing a little work.

> - 'Collected from patron' should reuse some patron searching things already
> exist in the codebase. Thinking of the dialog to pick a guarantor.

Not sure what you mean here? The 'Collected from patron' input is meant to be a
monetary value. (Though I do also like the idea of enhancing the screen to
allow a patron to be optionally linked to the transaction)

> - Currency symbol is the pound one, no matter what the system is configured
> to use.

Oops.. I'll post a followup for that now.

> - 'Click on the item cost' maybe instead of 'Click on the item'.

Good catch.

> - Are you planning on having an inventory of things to sell? I think the use
> of authorised values is very limited, besides my criticism. I expect
> librarians wanting to just scan the barcode and get the price on the screen.

I very much do want to add such functionality, including things like barcodes,
tax rates etc.. but I see that as part of a bigger piece to migrate MANUAL_INC
outside of authorized values.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves

2019-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261

Arthur Suzuki  changed:

   What|Removed |Added

 Blocks||23669


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23669
[Bug 23669] Verify if checkouts or reserves requests from ILS-DI periods
overlap with existing reserves
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23531] ILS-DI doesn't implement needed_before_date and pickup_expiry_date parameters.

2019-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531

Arthur Suzuki  changed:

   What|Removed |Added

 Blocks||23669


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23669
[Bug 23669] Verify if checkouts or reserves requests from ILS-DI periods
overlap with existing reserves
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23669] New: Verify if checkouts or reserves requests from ILS-DI periods overlap with existing reserves

2019-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23669

Bug ID: 23669
   Summary: Verify if checkouts or reserves requests from ILS-DI
periods overlap with existing reserves
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Web services
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: arthur.suz...@biblibre.com
QA Contact: testo...@bugs.koha-community.org
CC: julian.maur...@biblibre.com
Depends on: 15261, 23531

Same as BZ15261 but for WebServices


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261
[Bug 15261] Verify if checkouts or reserves requests periods overlap with
existing reserves
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531
[Bug 23531] ILS-DI doesn't implement needed_before_date and pickup_expiry_date
parameters.
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves

2019-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261

Arthur Suzuki  changed:

   What|Removed |Added

 CC||arthur.suz...@biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23292] Use TransferSlip when transfering item which is on hold

2019-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23292

Sally  changed:

   What|Removed |Added

 CC||sally.healey@cheshireshared
   ||services.gov.uk

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22744] Remove confusing 'Do not notify' checkboxes from messaging preferences

2019-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22744

--- Comment #30 from Martin Renvoize  ---
Nice work!

Pushed to master for 19.11.00

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22744] Remove confusing 'Do not notify' checkboxes from messaging preferences

2019-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22744

Martin Renvoize  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master
 Version(s)||19.11.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23517] Add /holds/{hold_id}/priority route (PUT)

2019-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23517

Martin Renvoize  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com
   Keywords||Manual,
   ||release-notes-needed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23517] Add /holds/{hold_id}/priority route (PUT)

2019-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23517

Martin Renvoize  changed:

   What|Removed |Added

 Version(s)||19.11.00
released in||
 Status|Passed QA   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23517] Add /holds/{hold_id}/priority route (PUT)

2019-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23517

--- Comment #22 from Martin Renvoize  ---
Nice work!

Pushed to master for 19.11.00

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23321] Add 'tills' to the accounts system

2019-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23321

Martin Renvoize  changed:

   What|Removed |Added

 Version(s)||19.11.00
released in||
 Status|Passed QA   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23321] Add 'tills' to the accounts system

2019-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23321

--- Comment #90 from Martin Renvoize  ---
Nice work!

Pushed to master for 19.11.00

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22744] Remove confusing 'Do not notify' checkboxes from messaging preferences

2019-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22744

Nick Clemens  changed:

   What|Removed |Added

  Attachment #93109|0   |1
is obsolete||

--- Comment #28 from Nick Clemens  ---
Created attachment 93114
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93114=edit
Bug 22744: Remove the 'do not notify' buttons

These checkboxes are simply a way to clear the prefs before editing. We are not
saving
a lot of click, and we are confusing people, this patch simply removes them

To test:
1 - Edit a patron's messaging preferences
2 - Think too hard about the 'Do not notify' boxes
3 - Feel confused
4 - Apply this patch
5 - Edit a patron's messaging preferences
6 - Confirm it feels better

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22744] Remove confusing 'Do not notify' checkboxes from messaging preferences

2019-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22744

--- Comment #29 from Nick Clemens  ---
Created attachment 93115
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93115=edit
Bug 22744: Changes for opac and remove JS

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23623] Use the new API and remove /svc scripts for privacy settings

2019-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23623

Martin Renvoize  changed:

   What|Removed |Added

 Version(s)||19.11.00
released in||
 Status|Passed QA   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23623] Use the new API and remove /svc scripts for privacy settings

2019-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23623

--- Comment #11 from Martin Renvoize  ---
Nice work!

Pushed to master for 19.11.00

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23584] Add public routes to change privacy settings

2019-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23584

--- Comment #8 from Martin Renvoize  ---
Nice work!

Pushed to master for 19.11.00

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23584] Add public routes to change privacy settings

2019-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23584

Martin Renvoize  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master
 Version(s)||19.11.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23537] Overdrive won't show complete results if the Overdrive object doesn't have a primaryCreator

2019-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23537

--- Comment #4 from Martin Renvoize  ---
Nice work!

Pushed to master for 19.11.00

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23537] Overdrive won't show complete results if the Overdrive object doesn't have a primaryCreator

2019-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23537

Martin Renvoize  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master
 Version(s)||19.11.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22837] Koha::Account::Line->apply should not require a 'set' of debits

2019-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22837

--- Comment #17 from Martin Renvoize  ---
Nice work!

Pushed to master for 19.11.00

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22837] Koha::Account::Line->apply should not require a 'set' of debits

2019-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22837

Martin Renvoize  changed:

   What|Removed |Added

 Version(s)||19.11.00
released in||
 Status|Passed QA   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23321] Add 'tills' to the accounts system

2019-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23321

--- Comment #89 from Martin Renvoize  ---
Thanks for the QA and follow-ups Tomas, much appreciated.

Totally agree that it would be great to use AJAX for at least some of the
actions, but at this point, I was aiming for pragmatic coding to 'get it done'
and concentrating mostly on the backend implementation. I hope to switch back
around to the UI again sometime soon and add API routes and correspondingly
AJAXifying the UI :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23526] Shibboleth login url with query has double encoded '?' %3F

2019-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23526

--- Comment #4 from Martin Renvoize  ---
Nice work!

Pushed to master for 19.11.00

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23605] Terminology: Branches limitations should be libraries limitations

2019-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23605

--- Comment #4 from Martin Renvoize  ---
Nice work!

Pushed to master for 19.11.00

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23605] Terminology: Branches limitations should be libraries limitations

2019-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23605

Martin Renvoize  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master
 Version(s)||19.11.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23526] Shibboleth login url with query has double encoded '?' %3F

2019-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23526

Martin Renvoize  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master
 Version(s)||19.11.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23425] Search explodes with "invalid data, cannot decode object"

2019-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23425

Martin Renvoize  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master
 Version(s)||19.11.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23425] Search explodes with "invalid data, cannot decode object"

2019-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23425

--- Comment #11 from Martin Renvoize  ---
Nice work!

Pushed to master for 19.11.00

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23668] Manual on patron import: Information on syntax for patron attributes

2019-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23668

Anke  changed:

   What|Removed |Added

Summary|Information on syntax for   |Manual on patron import:
   |patron attributes   |Information on syntax for
   ||patron attributes

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23668] New: Information on syntax for patron attributes

2019-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23668

Bug ID: 23668
   Summary: Information on syntax for patron attributes
 Change sponsored?: ---
   Product: Koha
   Version: 19.05
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Documentation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: anke.br...@gwdg.de
QA Contact: testo...@bugs.koha-community.org

In the manual at
https://koha-community.org/manual//19.05/en/html/tools.html#patron-import-label
the syntax for multiple patron attributes which, to complicate things, consist
of multiple words separated by blanks isn't described correctly.

It says:


"Note

If loading patron attributes, the ‘patron_attributes’ field should contain a
comma-separated list of attribute types and values.

The attribute type code and a colon should precede each value.
For example: “INSTID:12345,BASEBALL:Cubs”
This field must be wrapped in quotes if multiple values are defined.
Since values can contain spaces, additional doubled-quotes may be
required:
“INSTID:12345,BASEBALL:Cubs,””BASEBALL:White Sox””
"


After trying this, and all other possible combinations of attributes and quotes
I could come up with, I found that import only works if the attributes are
entered in the most simple way, namely in single quotes. The blanks can be
which, for the above example, would read:

“INSTID:12345,BASEBALL:Cubs,BASEBALL:White Sox”

I didn't test exactly this combination of attributes, but with similar ones it
worked. If this can be confirmed, maybe the manual can be updated accordingly?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23666] Add API route for additional patron attributes

2019-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23666

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de,
   ||tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23667] Add API route for getting an item by barcode

2019-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23667

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de,
   ||tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/