[Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields

2019-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

--- Comment #216 from Ere Maijala  ---
Thanks Martin! I found the YAZ documentation a bit scattered and didn't spot
that bit of information. We're running YAZ 5, and it seems to do a better job.
Or rather, it seems that YAZ 5 supports paths relative to the config file as
well as current working dir.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22706] Add plugin hooks to enable Norwegian national patron database

2019-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22706

Magnus Enger  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=20340

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20340] Ability to use authentication plugin

2019-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20340

Magnus Enger  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=22706

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23812] Download icon is an upload icon

2019-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23812

Lisette Scheer  changed:

   What|Removed |Added

 CC||lisettesla...@gmail.com

--- Comment #1 from Lisette Scheer  ---
Font awesome has a very similar download icon here:
https://fontawesome.com/icons/download?style=solid

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23820] Club Hold pickup locations should be able to default to patron's home branch

2019-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23820

Lisette Scheer  changed:

   What|Removed |Added

 CC||lisettesla...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23820] New: Club Hold pickup locations should be able to default to patron's home branch

2019-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23820

Bug ID: 23820
   Summary: Club Hold pickup locations should be able to default
to patron's home branch
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Hold requests
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: jr...@sekls.org
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

Currently club holds force you to choose a single, specific pickup location
when placing holds for the club. This isn't ideal in a multibranch/consortial
setting.

It would be nice if there were an option to default the pickup location to the
patron's home branch for holds placed with clubs.

My use case involves clubs for specific authors. For example, I want to create
a 'Stuart Woods' club that patrons can join, then whenever a new Stuart Woods
title is added, staff place a club hold that hits every patron enrolled.

Right now, if I take three different patrons from three different branches and
add them to a single club, I will be forced to select a single pickup location
which may be inaccessible to some or all of the patrons. To set three different
pickup locations, I would need to place three different club holds for three
different clubs. That has potential to get very messy, very quickly. Each
branch would need a club for each author, which then makes it easy to enroll
patrons in the wrong club and get their holds sent to the wrong branch.

Ideally, all three patrons should be able to join a single club and get their
holds sent to their respective home branches for pick up.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23819] New: Allow status to be set during creation of a purchase suggestion

2019-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23819

Bug ID: 23819
   Summary: Allow status to be set during creation of a purchase
suggestion
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: lisettesla...@gmail.com
QA Contact: testo...@bugs.koha-community.org

Here is the workflow where this would be helpful:
1. Patron asks if we have a book. 
2. Staff member checks in catalog that we don't have it, offers to make
purchase suggestion. 
3. Staff members fills out purchase suggestion and currently:
 Saves the suggestion and has to edit again to be able to edit status to "Sent
to Adult Librarian" 

Would be nice if they could instead set that status on creation to reduce
clicks. In this case 3 would say:

3. Staff member fills out purchase suggestion and sets status to "Sent to Adult
Librarian" then saves purchase suggestion. 


Lisette

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20682] Authorised values should have an option to set a default

2019-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20682

Lisette Scheer  changed:

   What|Removed |Added

 CC||lisettesla...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method

2019-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Lisette Scheer  changed:

   What|Removed |Added

 CC||lisettesla...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23818] Acquisitions receipt created when an item or invoice is received.

2019-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23818

rkui...@roundrocktexas.gov changed:

   What|Removed |Added

 CC||rkui...@roundrocktexas.gov

--- Comment #2 from rkui...@roundrocktexas.gov ---
Created attachment 94224
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94224=edit
Another example of a receipt slip

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23818] Acquisitions receipt created when an item or invoice is received.

2019-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23818

--- Comment #1 from rkui...@roundrocktexas.gov ---
Created attachment 94223
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94223=edit
Example of a receipt slip

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23818] New: Acquisitions receipt created when an item or invoice is received.

2019-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23818

Bug ID: 23818
   Summary: Acquisitions receipt created when an item or invoice
is received.
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: new feature
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: rkui...@roundrocktexas.gov
QA Contact: testo...@bugs.koha-community.org

Add a button on each acquisitions invoice that will print a receipt slip fr
each item on the invoice. The slip would contain basic information about the
item such as title, author and ISBN (to match item to slip) and then other
information such as number of holds, branch for multi-branch systems, nonpublic
note (we indicate things like NYTimes Best Seller here), and receipt date.
Currently we scan the items when they come in and write things like holds and
best seller on a slip of paper with the month of receipt on it.

I have attached photos of the slips I have seen to give you an idea of what
they contain.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23770] Add Koha::Object(s)->to_api method

2019-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23770

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

--- Comment #21 from Tomás Cohen Arazi  ---
(In reply to Marcel de Rooy from comment #15)
> Depending on strict mode I have two results of the Object.t test:
> 
> not ok 1 - Exception thrown correctly
> #   Failed test 'Exception thrown correctly'
> #   at t/db_dependent/Koha/Object.t line 411.
> # expecting: Koha::Exceptions::Object::BadValue
> # found: normal exit
> # Looks like you failed 1 test of 1.
> not ok 16 - Bad value tests
> 
> #   Failed test 'Exception thrown correctly'
> #   at t/db_dependent/Koha/Object.t line 411.
> # expecting: Koha::Exceptions::Object::BadValue
> # found: DBIx::Class::Exception
> (DBIx::Class::Storage::DBI::_dbh_execute(): Incorrect datetime value:
> 'wrong_value' for column `koha_master`.`borrowers`.`lastseen` at row 1 at
> /usr/share/koha/Koha/Object.pm line 156
> # )
> # Looks like you failed 1 test of 1.

Ok, but that's not something related to this bug, you just found that if we
manage not to run the tests in strict mode on a dev env (i.e. using perl
instead of prove) the exception is not thrown, fair enough.

I'm setting this one back to Signed-off.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23518] Problem with borrower search autocomplete

2019-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23518

Eric Phetteplace  changed:

   What|Removed |Added

 CC||ephettepl...@cca.edu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23770] Add Koha::Object(s)->to_api method

2019-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23770

--- Comment #20 from Tomás Cohen Arazi  ---
(In reply to Jonathan Druart from comment #19)
> (In reply to Tomás Cohen Arazi from comment #18)
> > (In reply to Jonathan Druart from comment #17)
> > > Looks great to me!
> > > 
> > > * Can we now remove ->_to_api (and so $to_api_mappinp) from
> > > Koha/REST/V1/Cities.pm
> > 
> > we still can't.
> 
> Why? That seems to be the very next step to me :)

Yes, yes. But we can't until we adapt Koha::REST::Plugin::Objects->search or
provide an alternative implementation (maybe in Koha::Objects->search_from_api)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23414] Improve performance of C4/XSLT/buildKohaItemsNamespace

2019-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23414

--- Comment #4 from Tomás Cohen Arazi  ---
I like this enhancement. But would like to mention that it looks like there's
an unnecessary processing of items from the MARC results, in the caller
(searchResults) that is also making several DB calls. So it seems we need to
make a decision, whether to use the data from Zebra, or use the one on the DB,
and reuse the retrieved objects as much as we can (so maybe doing the search at
a higher level, searchResults). Just a thought, and can be done later of
course.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8260] Routing List Ranking Needs Re-order After Patron Delete

2019-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8260

--- Comment #13 from Katrin Fischer  ---
(In reply to Nick Clemens from comment #11)
> (In reply to Katrin Fischer from comment #9)
> > (In reply to Katrin Fischer from comment #8)
> > > I think I like the idea of renumbering in the database a bit better, as it
> > > will also fix things for any reports and similar. And it always seems a
> > > little odd to display something different than what to is stored in the 
> > > db.
> > > That said, I guess David's patch would have to be reworked for the Koha
> > > namespace?
> > 
> > Another issue: Printing routing lists. I think Nick's patch only fixes the
> > view, not the print.
> 
> The print doesn't include the numbers, and the ordering will still be correct
> 
> In reports too, the numbering will still be ordered correctly, it just may
> have a gap.
> 
> happy to have someone supply an alternate

You got a point there. If we are sure it doesn't cause issues with reordering
or similar, I am ok.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23817] New: Searching by patron phone number is contingent on how it was entered

2019-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23817

Bug ID: 23817
   Summary: Searching by patron phone number is contingent on how
it was entered
 Change sponsored?: ---
   Product: Koha
   Version: 18.11
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Patrons
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: ke...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

If a library chooses to enter their patron phone numbers in as xxx-xxx-
when creating the patron record; then when the phone number is searched with
the filters, the library must always use hyphens when searching or the search
will not work.  

It would be nice that the number could be searched in the filters with either
hyphens or no hyphens and the library would get the same results.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results

2019-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #25 from Katrin Fischer  ---

> > Manually edited:
> > Items available for loan: Centerville[Call number: 005.13/3] (1).
> > Centerville Staff Collection[Call number: 005.13/3] (2), Centerville
> > Ordered[Call number: 005.13/3] (1). Damaged (1).

> 
> What do you mean about missing 'for reference'? From my perspective that is
> a goal of the patch here - to remove that label and use the notforloan
> descriptions - if a library wants items to appear that way then they can
> make that the description of the authorized value for the opac. This way
> those who want it can put it in place, and those who don't can provide their
> own description

But then we should also remove the "Items available for loan".
Because that is clearly giving a wrong idea?

Just: Items: ?

Or we can still assume that items that are marked with any 'not for loan' value
are for reference and list them with their individual status descriptions
behind the "Items available for reference" label.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23816] Allow to have different password strength and length settings for different patron categories

2019-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23816

Katrin Fischer  changed:

   What|Removed |Added

Summary|Password Enhancements   |Allow to have different
   ||password strength and
   ||length settings for
   ||different patron categories

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22445] Ability to define a URL for custom cover images

2019-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Failed QA   |ASSIGNED

--- Comment #79 from Tomás Cohen Arazi  ---
I agree, 3 out of 4 commenters have agreed on {}. Let's get this into master
ASAP!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23816] Password Enhancements

2019-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23816

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #1 from Katrin Fischer  ---
If you make them exempt, they could get away with '1' character passwords. I'd
like to suggest that we leave the preferences global, but allow an overwrite on
patron category level (we have other examples for this).

The default on patron category would be "inherit from pref", but allow to set
or unset.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23485] Holds to pull (pendingreserves.pl) should list barcodes

2019-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23485

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #5 from Katrin Fischer  ---
(In reply to Owen Leonard from comment #4)
> I'm concerned that the list of barcodes will be unmanageable for records
> which have a large number of items. On the holds queue report we say
> "3100234552 or any available." Would that work here?
> 
> Also: If it is an item-level hold I think the barcode should not be
> displayed as a list item, so that "Only 3200202225" displays together.

+1

Some libraries have a lot of copies for text books and similar. Agreeing with
Owen.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22445] Ability to define a URL for custom cover images

2019-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445

Katrin Fischer  changed:

   What|Removed |Added

   Keywords|Academy |rel_19_11_candidate
 Status|Signed Off  |Failed QA

--- Comment #78 from Katrin Fischer  ---
Switching to FQA meaning "Waiting for follow-up".

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22445] Ability to define a URL for custom cover images

2019-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445

--- Comment #77 from Katrin Fischer  ---
I like {} too, it's also used in other prefs like SearchForTitleIn.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17359] Patron import results use wrong encoding

2019-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17359

Katrin Fischer  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---

--- Comment #20 from Katrin Fischer  ---
(In reply to Caroline Cyr La Rose from comment #14)
> I was able to reproduce the problem mentionned by Mirko, i.e. that the error
> summary has encoding problems.
> The user's name was Chloé and it came out as Chloé

Hi Jonathan, reopening for this issue, something still seems a little odd
there.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21538] Show library on account page

2019-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21538

Owen Leonard  changed:

   What|Removed |Added

Summary|Show ilbrary on account |Show library on account
   |page|page

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23424] Cannot save edited patron record

2019-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23424

Owen Leonard  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |INVALID

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23081] Item search : Filter for Items with Zero Checkouts Returns No Results

2019-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23081

Aguayo  changed:

   What|Removed |Added

 CC||azucena.agu...@uvu.edu

--- Comment #1 from Aguayo  ---
My library has been using the Item Search and also noticed the same problem
with the checkout count.

I think the problem is related to the "issues" field in the "items" table. The
"issues" field is of type SMALLINT with a default value of "null"


Using a report, I can illustrate the behavior.

Example 1:
select barcode, issues
from items
where issues <= <>

Result 1:
Items with checkouts less or equal to the number you enter are listed but NOT
items with 0 checkouts. Same as the Item Search.


Example 2:
select barcode, issues
from items
where issues is null OR issues <= <>

Result 2:
Items with checkouts less or equal to the number you enter are listed AND any
items with no checkouts. What we would expect to get if looking for check count
= 0 or < #


My assumption is that Koha displays a '0' when viewing an item on the staff
client, however the "items" table stores a "null" value in the "issues" field.
Limiting the checkout count with a '0' gives no results because there is no '0'
in the "issues" field.


If possible the "issues" field needs to have the default value set to '0', or
the Item Search code needs to account for a "null" value.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11514] Untranslatable "Uncertain" text in acq

2019-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11514

--- Comment #12 from Katrin Fischer  ---
(In reply to Jonathan Druart from comment #11)
> I can confirm that:
> 
> 1) It's a bug fix for the existing behavior: "(Uncertain)" is not longer
> displayed, because of the use of the Price plugin.
> 
> 2) We cannot test the second part of the patch. Even if it cannot hurt it
> may make more sense to remove the code in the controller and don't touch the
> template file.

Thx, Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23704] Typo in itemtypes.tt

2019-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23704

--- Comment #1 from Owen Leonard  ---
Created attachment 94222
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94222=edit
Bug 23704: Typo in itemtypes.tt

This patch corrects a typo:

"for loans specifie in hours."

corrected to "for loans specified in hours."

To test, apply the patch and edit an existing item type. The description
of the "Hourly rental charge" field should be correct.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23704] Typo in itemtypes.tt

2019-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23704

Owen Leonard  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |String patch

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23757] Able to delete patron expiration date

2019-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23757

--- Comment #2 from Joy Nelson  ---
Yes please.  I like this solution.  +1

> make the batch patron
> modification tool auto-calculate the expiration date if the user checked the
> "delete value" check box? I feel like that would make the process more
> consistent to the way editing an individual patron works.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23816] Password Enhancements

2019-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23816

Joy Nelson  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |agustinmoy...@theke.io
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23816] New: Password Enhancements

2019-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23816

Bug ID: 23816
   Summary: Password Enhancements
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Patrons
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: j...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

Allow specified categories to be exempt from the system preferences of "Require
Strong Password" and "Minimum Password Length".  The goal is to force staff to
have long complex passwords while simultaneously allowing patrons to have
non-strong, shorter passwords if they wish.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23815] Cancel hold confirmation should display specific information

2019-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23815

Christopher Brannon  changed:

   What|Removed |Added

   Priority|P5 - low|P1 - high

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23815] New: Cancel hold confirmation should display specific information

2019-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23815

Bug ID: 23815
   Summary: Cancel hold confirmation should display specific
information
 Change sponsored?: ---
   Product: Koha
   Version: 18.11
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Hold requests
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: cbran...@cdalibrary.org
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

Any cancellation or deletion confirmations should display the information that
is being cancelled or deleted when confirmed.

request.pl uses and alert type confirmation that does not display any specific
information.  With items so close to each other, it would be easy enough to
click on the wrong X to cancel a hold and cancel the wrong hold.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23742] Language check on 2 characters only

2019-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23742

Owen Leonard  changed:

   What|Removed |Added

Summary|language check on 2 digits  |Language check on 2
   |only|characters only

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23223] Allow requested items to be checked out via SIP2

2019-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23223

Sally  changed:

   What|Removed |Added

 CC||sally.healey@cheshireshared
   ||services.gov.uk

--- Comment #2 from Sally  ---
(In reply to Katrin Fischer from comment #1)
> I digged out the original bug report for Adding AllowItemsOnHoldCheckout and
> it looked like it was supposed to cover SIP2 as well: bug 7090 
> 
> So maybe this is a bug/regression?

Yes, I'd say it was a bug/regression.  

If it helps to narrow it down, we have a Koha installation on 16.11 with
AllowItemsOnHoldCheckout set to Allow, and items on hold (not waiting) can be
checked out via SIP2.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23757] Able to delete patron expiration date

2019-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23757

--- Comment #1 from Owen Leonard  ---
The "clear" link deletes the date in the field but doing so shouldn't have any
affect on the batch update--empty values are assumed to be unchanged.

So I assume it's the "delete value" checkbox which is in question. We can make
a quick change to the template to hide it for the expiration date field but I
wonder if a more complete fix wouldn't be to make the batch patron modification
tool auto-calculate the expiration date if the user checked the "delete value"
check box? I feel like that would make the process more consistent to the way
editing an individual patron works.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21824] Add ability to format dates in various formats in templates

2019-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21824

Martin Renvoize  changed:

   What|Removed |Added

   Keywords||rel_19_11_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21824] Add ability to format dates in various formats in templates

2019-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21824

--- Comment #27 from Martin Renvoize  ---
Docs team, this might be something very useful to add to the notices and slips
area of the manual.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21824] Add ability to format dates in various formats in templates

2019-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21824

Martin Renvoize  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21824] Add ability to format dates in various formats in templates

2019-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21824

Martin Renvoize  changed:

   What|Removed |Added

   Keywords||Manual

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21824] Add ability to format dates in various formats in templates

2019-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21824

Martin Renvoize  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com

--- Comment #26 from Martin Renvoize  ---
I've elaborated a bit further on the wiki now too, listing the available
options for dateformat and giving examples of their output.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18532] AUTO_RENEWALS should be a patron messaging preference

2019-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532

Joy Nelson  changed:

   What|Removed |Added

 CC||j...@bywatersolutions.com
   Assignee|koha-b...@lists.koha-commun |agustinmoy...@theke.io
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23019] Ability to create 'matching profiles' when importing records

2019-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23019

Joy Nelson  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |agustinmoy...@theke.io
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19889] localholdspriority needs exclusions

2019-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19889

Joy Nelson  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |agustinmoy...@theke.io
   |ity.org |
 CC||j...@bywatersolutions.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22784] Archiving Purchase Suggestions

2019-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784

Joy Nelson  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |agustinmoy...@theke.io
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23223] Allow requested items to be checked out via SIP2

2019-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23223

Joy Nelson  changed:

   What|Removed |Added

   Assignee|k...@bywatersolutions.com   |agustinmoy...@theke.io

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22789] Establish Non-Priority Holds

2019-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22789

Joy Nelson  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |agustinmoy...@theke.io
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23814] New: make it easier to manage items in baskets

2019-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23814

Bug ID: 23814
   Summary: make it easier to manage items in baskets
 Change sponsored?: ---
   Product: Koha
   Version: 18.11
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: bwsdo...@gmail.com
QA Contact: testo...@bugs.koha-community.org

Currently in acquisitions, it is challenging to move items from one record to
another.  While it can sometimes be accomplished by re-opening baskets, and
manipulating data, it would be preferred to make item management easier.  There
should also be a permission to go along with this to control who has the
ability to do so.  An example of the situation from one library:

I've found a good number of errors from a few years ago, order records added to
bib records of older editions of similar titles, which causes payments to seem
to go 'missing'. It's causing a lot of headache.  We would definitely like to
be able to 1, move an order (any status, received or not) to another basket
without otherwise having to change the basket it was in, and without having to
manually re-enter the order (entailing that that order would be assigned to
whatever bib rec the new basket is attached to)  -- 2, assign an order to a
different bib record while leaving it in it's same basket (entailing that the
basket it is in would detach from the that bib rec, unless there are other
orders in the same basket attached to that bib rec).

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22640] GDPR_Policy and PrivacyPolicyURL undocumented

2019-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22640

Magnus Enger  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEW |RESOLVED

--- Comment #1 from Magnus Enger  ---
This has been fixed:
https://koha-community.org/manual/19.05/en/html/systempreferences.html#gdpr-policy

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21944] Fix waiting holds at wrong location bug

2019-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21944

Martin Renvoize  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||martin.renvoize@ptfs-europe
   ||.com

--- Comment #22 from Martin Renvoize  ---
Seems to work as described, Signing off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21944] Fix waiting holds at wrong location bug

2019-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21944

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #92610|0   |1
is obsolete||

--- Comment #21 from Martin Renvoize  ---
Created attachment 94221
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94221=edit
Bug 21944: Reroute waiting hold from wrong branch

To Test:
1) Place a hold on an item.
2) Check in the item to trigger the hold.  Item is now listed as
waiting.
3) Set branch to a different library.
4) Check in the item to trigger the hold.  Notice that nothing but a
local use is recorded.
5) Apply the patch.
6) Repeat steps 1-4.  Notice that the hold is triggered around routed to
its original pickup location.  A transfer is set and the hold status
is changed from waiting to correctly showing the item as in transit.

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21944] Fix waiting holds at wrong location bug

2019-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21944

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #92609|0   |1
is obsolete||

--- Comment #20 from Martin Renvoize  ---
Created attachment 94220
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94220=edit
Bug 21944: Test for Circulation.pm

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23695] Items holdingbranch should be set to the originating library when generating a manual transfer

2019-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23695

Martin Renvoize  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe
   |y.org   |.com
 CC||martin.renvoize@ptfs-europe
   ||.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23695] Items holdingbranch should be set to the originating library when generating a manual transfer

2019-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23695

Martin Renvoize  changed:

   What|Removed |Added

   Keywords||rel_19_11_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23780] Batch check out fails to inform or trap

2019-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23780

Christopher Brannon  changed:

   What|Removed |Added

 Status|Needs Signoff   |In Discussion

--- Comment #2 from Christopher Brannon  ---
(In reply to Jonathan Druart from comment #1)
> Created attachment 94216 [details] [review]
> Bug 23780: Add DEBT info to batch checkouts info
> 
> DEBT can be impossible or needs confirmation.
> 
> Test plan:
> Create an invoice of 50 (and make sure 50 is above the limit)
> Check an item out using the batch checkouts feature
> => You should see the warning in the "Information" column

Technically, it works for the fines, but if I have multiple reasons, it only
shows one reason and lets you blow past the other unknowingly.

For this to work as expected, it needs to show ALL reasons.

To test:
* Set checkout limit to 5 items.
* Set MaxFine to 3
* Set borrower with a manual invoice of $5.
* Batch checkout 6 items.  You will see information on every item that the
patron has a debt of 5.00, but on the 6th item, you should ALSO see "Too many
checked out".

The problem is other items are not already checked out to trap this.  SO, what
needs to happen is either 
A) the batch checkout needs to "Look ahead" at all issues and evaluate all
potential blocks, or
B) the batch checkout needs to run through the same process again on all the
checked items and catch the next block.

Process A would be preferable so you don't have to override over and over again
through each scenario.

I want to sign off, because this is a step in the right direction, but it does
not address the multiple blocks addressed in the description of the problem.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23813] DB error on upgrade from 18.12 to 19.05.04

2019-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23813

--- Comment #1 from Magnus Enger  ---
After the upgrade there is 0 rows in circulation_rules and 225 in issuingrules.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23695] Items holdingbranch should be set to the originating library when generating a manual transfer

2019-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23695

--- Comment #2 from Martin Renvoize  ---
Comment on attachment 93231
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93231
Bug 23695: Set holding branch to transferring branch when manually initiating a
transfer

Review of attachment 93231:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=23695=93231)
-

::: circ/branchtransfers.pl
@@ +127,5 @@
>  if ($barcode) {
>  
>  ( $transferred, $messages ) =
> +transferbook({
> +from_branch => C4::Context->userenv->{'branch'},

Hmm, not sure this is right.. you might be transferring from the branch you're
logged in at.. but you may also be transferring from elsewhere to you logged in
branch... I'd say we probably need to add a field to the form and default to
the items current holdingbranch if the user doesn't explicitly state the items
in their branch?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18925] Move maxissueqty and maxonsiteissueqty to circulation_rules

2019-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925

Magnus Enger  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=23813

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23813] DB error on upgrade from 18.12 to 19.05.04

2019-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23813

Magnus Enger  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=18925

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23813] New: DB error on upgrade from 18.12 to 19.05.04

2019-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23813

Bug ID: 23813
   Summary: DB error on upgrade from 18.12 to 19.05.04
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Installation and upgrade (command-line installer)
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: mag...@libriotech.no
QA Contact: testo...@bugs.koha-community.org

I just copied the DB from a gitified install running 18.1200014 to a standard
Debian install of 19.05.04. When I ran "sudo koha-upgrade-schema  I
got this error:

DBD::mysql::db do failed: Cannot add or update a child row: a foreign key
constraint fails (`koha_alingsas`.`circulation_rules`, CONSTRAINT
`circ_rules_ibfk_3` FOREIGN KEY (`itemtype`) REFERENCES `itemtypes`
(`itemtype`) ON DELETE CASCADE ON UPDATE CASCADE) [for Statement "
INSERT INTO circulation_rules ( categorycode, branchcode, itemtype,
rule_name, rule_value )
SELECT IF(categorycode='*', NULL, categorycode),
   IF(branchcode='*', NULL, branchcode),
   IF(itemtype='*', NULL, itemtype),
   'maxissueqty',
   COALESCE( maxissueqty, '' )
FROM issuingrules
"] at
/usr/share/koha/intranet/cgi-bin/installer/data/mysql/updatedatabase.pl line
17545.
DBD::mysql::db do failed: Cannot add or update a child row: a foreign key
constraint fails (`koha_alingsas`.`circulation_rules`, CONSTRAINT
`circ_rules_ibfk_3` FOREIGN KEY (`itemtype`) REFERENCES `itemtypes`
(`itemtype`) ON DELETE CASCADE ON UPDATE CASCADE) [for Statement "
INSERT INTO circulation_rules ( categorycode, branchcode, itemtype,
rule_name, rule_value )
SELECT IF(categorycode='*', NULL, categorycode),
   IF(branchcode='*', NULL, branchcode),
   IF(itemtype='*', NULL, itemtype),
   'maxonsiteissueqty',
   COALESCE( maxonsiteissueqty, '' )
FROM issuingrules
"] at
/usr/share/koha/intranet/cgi-bin/installer/data/mysql/updatedatabase.pl line
17554.
Upgrade to 18.12.00.020 done (Bug 18925 - Move maxissueqty and
maxonsiteissueqty to circulation_rules)

I have not looked further into this yet, just thought I'd report it sooner
rather than later.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23129] Items holdingbranch should be set to the originating library when generating a transfer

2019-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23129

Martin Renvoize  changed:

   What|Removed |Added

   Keywords||Manual

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23129] Items holdingbranch should be set to the originating library when generating a transfer

2019-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23129

--- Comment #15 from Martin Renvoize  ---
Discussed with Nick, the tests was wrong and so I have updated it in a
followup.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23129] Items holdingbranch should be set to the originating library when generating a transfer

2019-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23129

Martin Renvoize  changed:

   What|Removed |Added

   Keywords||release-notes-needed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23129] Items holdingbranch should be set to the originating library when generating a transfer

2019-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23129

Martin Renvoize  changed:

   What|Removed |Added

   Keywords|additional_work_needed  |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23129] Items holdingbranch should be set to the originating library when generating a transfer

2019-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23129

--- Comment #14 from Martin Renvoize  ---
Created attachment 94219
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94219=edit
Bug 23129: (RM follow-up) Fix failing test

This patch corrects a test that was testing for the oposite behaviour to
that introduced in this patchset.  We have agreed on the bug that the
new behaviour is desired and so I have updated the test to follow.

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23073] wiki.koha-community.org needs updating to a later version

2019-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23073

Owen Leonard  changed:

   What|Removed |Added

   Assignee|g...@esilibrary.com  |td-koha-b...@agogme.com
 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23129] Items holdingbranch should be set to the originating library when generating a transfer

2019-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23129

--- Comment #13 from Martin Renvoize  ---
CC'd Alex Buckley as he wrote the tests that's currently failing.. I'd be
interested in his thoughts regarding what the holdingbranch of the item should
end up as during lost in transfer processes.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23129] Items holdingbranch should be set to the originating library when generating a transfer

2019-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23129

Martin Renvoize  changed:

   What|Removed |Added

 CC||alexbuck...@catalyst.net.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23129] Items holdingbranch should be set to the originating library when generating a transfer

2019-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23129

Martin Renvoize  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com

--- Comment #12 from Martin Renvoize  ---
Hmm, so this breaks a test which expects the opposite behaviour when dealing
with items getting marked as lost from the transfers window.

Question is, is the test incorrect or the functionality?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23129] Items holdingbranch should be set to the originating library when generating a transfer

2019-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23129

Martin Renvoize  changed:

   What|Removed |Added

   Keywords||additional_work_needed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23812] New: Download icon is an upload icon

2019-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23812

Bug ID: 23812
   Summary: Download icon is an upload icon
 Change sponsored?: ---
   Product: Koha
   Version: 19.05
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Reports
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: carn...@dgiinc.com
QA Contact: testo...@bugs.koha-community.org

Created attachment 94218
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94218=edit
Download icon points up

The Download button on the SQL Reports page is an upload icon (an arrow
pointing up), can we change this to a download icon?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23804] Itemtype not checked when editing

2019-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23804

Owen Leonard  changed:

   What|Removed |Added

  Attachment #94211|0   |1
is obsolete||

--- Comment #7 from Owen Leonard  ---
Created attachment 94217
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94217=edit
Bug 23804: Correctly catch remote itemtype images

Bug 20216 missed the mark and although it did start display a URL for
the itemtype image in use, it was not limited to remote urls and as such
broke the checked handling for displaying which local image was
selected.

Test plan:
1) Select a local image for an itemtype.
2) Check the correct image is displayed in the admin table.
3) Edit the itemtype checking that the correct image is checked.
4) Change to a remote image for the itemtype
5) Check the correct image is displayed in the admin table.
6) Edit the itemtype again and check that the URL still displays and is
   checked in the 'Remote image' tab.
7) Signoff

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23804] Itemtype not checked when editing

2019-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23804

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23780] Batch check out fails to inform or trap

2019-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23780

Jonathan Druart  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23780] Batch check out fails to inform or trap

2019-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23780

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
   Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c
   |ity.org |ommunity.org
Version|18.11   |master

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23780] Batch check out fails to inform or trap

2019-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23780

--- Comment #1 from Jonathan Druart  
---
Created attachment 94216
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94216=edit
Bug 23780: Add DEBT info to batch checkouts info

DEBT can be impossible or needs confirmation.

Test plan:
Create an invoice of 50 (and make sure 50 is above the limit)
Check an item out using the batch checkouts feature
=> You should see the warning in the "Information" column

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8260] Routing List Ranking Needs Re-order After Patron Delete

2019-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8260

Owen Leonard  changed:

   What|Removed |Added

  Attachment #90393|0   |1
is obsolete||

--- Comment #12 from Owen Leonard  ---
Created attachment 94215
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94215=edit
Bug 8260: user rank order instead of absolute rank to set dropdowns on
routing.pl

When deleting a borrower on a routing list we leave a gap in the numbering. It
appears to only be a problem when viewing
or editing the list in the staff client.

Rather than use the rank in the DB to set the values, we use the implicit order

To test:
 1 - Create a subscription (or find one)
 2 - Add a routing list
 3 - Add five patrons
 4 - Delete the patron who is third in the list
 5 - Edit the routing list
 6 - Note the priority for the last patron is 1
 7 - Apply patch
 8 - Reload the page
 9 - Values look correct
10 - Confirm reordering works as expected

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8260] Routing List Ranking Needs Re-order After Patron Delete

2019-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8260

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22445] Ability to define a URL for custom cover images

2019-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445

--- Comment #76 from Martin Renvoize  ---
Comment on attachment 90013
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90013
Bug 22445: Add new pattern %normalized_isbn%

Review of attachment 90013:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=22445=90013)
-

Switching to `{` and `}` for the delimiters and adding the  `%field.subfield%`
into this doc line would get it past the PQA line for me.. be great to see this
feature in community :)

:::
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/enhanced_content.pref
@@ +346,4 @@
>  - "Using the following URL:"
>  - pref: CustomCoverImagesURL
>class: url
> +- "You can define it using the following patterns: %isbn%, 
> %issn%, %normalized_isbn%."

Could we also document the ` %field.subfield%` option here :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22445] Ability to define a URL for custom cover images

2019-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445

--- Comment #75 from Martin Renvoize  ---
Happy with bash style.. or just plain moustache templating style might be even
simpler for end users.

https://my_url/{normalized_isbn}.png

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23485] Holds to pull (pendingreserves.pl) should list barcodes

2019-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23485

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #4 from Owen Leonard  ---
I'm concerned that the list of barcodes will be unmanageable for records which
have a large number of items. On the holds queue report we say "3100234552
or any available." Would that work here?

Also: If it is an item-level hold I think the barcode should not be displayed
as a list item, so that "Only 3200202225" displays together.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22445] Ability to define a URL for custom cover images

2019-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com

--- Comment #74 from Tomás Cohen Arazi  ---
(In reply to Kyle M Hall from comment #69)
> This looks pretty good, but I have one request; can you use Template Toolkit
> syntax instead of yet another bespoke syntax? If we standardize on TT for
> all templating we'll make everyone's lives much simpler.

I personally prefer the bash-like syntax :-P

https://my_url/${normalized_isbn}.png

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8260] Routing List Ranking Needs Re-order After Patron Delete

2019-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8260

Owen Leonard  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8260] Routing List Ranking Needs Re-order After Patron Delete

2019-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8260

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20307] Language overlay for authorized values

2019-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20307

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23523] Unitprice tax column values are not populated if entered upon ordering

2019-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23523

Nick Clemens  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

--- Comment #8 from Nick Clemens  ---
(In reply to Katrin Fischer from comment #6)
> I am not sure about these fallbacks in the code - can you please explain?
> 
> +# we should use the unitprice if included
> +my $cost_tax_included = $order->{unitprice_tax_included} ||
> $order->{ecost_tax_included};
> +my $cost_tax_excluded = $order->{unitprice_tax_excluded} ||
> $order->{ecost_tax_excluded};
> +$order->{tax_value_on_ordering} = (
> get_rounded_price($cost_tax_included) -
> get_rounded_price($cost_tax_excluded) ) * $order->{quantity};

This only affects the 'tax_value_on_ordering' field
  -if you have entered an actual cost, then those values are used to determine
the tax
  -if you have not, we use the ecost as we did previously (fallback to original
behvaiour)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23523] Unitprice tax column values are not populated if entered upon ordering

2019-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23523

--- Comment #7 from Nick Clemens  ---
(In reply to Katrin Fischer from comment #5)
> I think usually the 'actual price' is entered on receive - can you explain
> the use case for entering it on order?

For standing orders, or orders that are completed in one step (i.e. purchasing
a database) sometimes the library knows the actual price before 'receiving'

Outside of these workflows, nothing changes, this only allows libraries who do
enter actual price on ordering to have values calculated correctly

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23551] Problem with renewal period when using the renewal tab

2019-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23551

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||7088
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088
[Bug 7088] Cannot renew items on hold even with override
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7088] Cannot renew items on hold even with override

2019-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||23551


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23551
[Bug 23551] Problem with renewal period when using the renewal tab
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23551] Problem with renewal period when using the renewal tab

2019-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23551

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #94105|0   |1
is obsolete||

--- Comment #13 from Jonathan Druart  
---
Created attachment 94214
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94214=edit
Bug 23551: Fix AddRenewal call in circ/renew.pl

Without the patch, renewing from the renewal tab/page
led to wrong renewal/due dates.

To test:
- Check an item out to your patron account
- Renew it from the patron account
- Note the due date
- Return the item
- Check the item out again
- Renew it using the renewal tab
- Verify a different due date was calculated
- Apply patch
- Repeat test - due dates now should be the same

Signed-off-by: Katrin Fischer 

Signed-off-by: Jonathan Druart 
It's ugly, but we are mimicking what is done in svc/renew so that's fine :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23551] Problem with renewal period when using the renewal tab

2019-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23551

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22814] Holds modal patron name display inconsistency

2019-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22814

Owen Leonard  changed:

   What|Removed |Added

  Attachment #94104|0   |1
is obsolete||

--- Comment #2 from Owen Leonard  ---
Created attachment 94213
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94213=edit
Bug 22814: Make patron names on holds modal consistent (second check-in)

Bug 22203 changed the behavior on the hold-found2 modal
that pops up when a hold is found so that whether or not
the patron's name is displayed is now governed by the
HidePatronName system preference.

However, if a hold is confirmed and you check the item
in a second time, the modal that pops up is hold-found1
and whether or not the patron's name is displayed in
the hold-found1 modal is not governed by the HidePatronName
system preference.

For the sake of consistency, the display of the patron's
name on hold-found2 and hold-found1 should both be governed
by the HidePatronName system preference.

To test:
- Place a hold on an item
- Check in the item to trigger the hold modal
- Confirm hold
- Check the item in again - verify name of patron displays
- Apply patch
- Repeat
- Verify name display now matches between the two modals
- change HidePatronName pref
- Repeat
- Name display should still match

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22814] Holds modal patron name display inconsistency

2019-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22814

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23770] Add Koha::Object(s)->to_api method

2019-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23770

--- Comment #19 from Jonathan Druart  
---
(In reply to Tomás Cohen Arazi from comment #18)
> (In reply to Jonathan Druart from comment #17)
> > Looks great to me!
> > 
> > * Can we now remove ->_to_api (and so $to_api_mappinp) from
> > Koha/REST/V1/Cities.pm
> 
> we still can't.

Why? That seems to be the very next step to me :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results

2019-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611

--- Comment #24 from Nick Clemens  ---
Created attachment 94212
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94212=edit
Bug 7611: (follow-up) Add missing space

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results

2019-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611

Nick Clemens  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   3   >