[Koha-bugs] [Bug 23829] New: Software error page during check in item that has fine {Software error: The 'days' parameter (undef) to Datetime::Duration::new which was an 'undef' which is not one of th
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23829
Bug ID: 23829
Summary: Software error page during check in item that has fine
{Software error: The 'days' parameter (undef) to
Datetime::Duration::new which was an 'undef' which is
not one of the allowed type: scalar (Duration.pm line
28)}
Change sponsored?: ---
Product: Koha
Version: 18.11
Hardware: Other
OS: Other
Status: NEW
Severity: major
Priority: P5 - low
Component: Circulation
Assignee: koha-bugs@lists.koha-community.org
Reporter: hams...@interxs.com.my
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com
Created attachment 94359
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94359=edit
Software error page during check in item that has fine
Hello community,
A software error page is returned when trying to Check In an item that has fine
(OVERDUE). The error is "Software error: The 'days' parameter (undef) to
Datetime::Duration::new which was an 'undef' which is not one of the allowed
type: scalar (Duration.pm line 28)". This error happened in koha version 18.11.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21920] Create Form Letters (not automated)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21920 --- Comment #3 from David Cook --- (In reply to Magnus Enger from comment #2) > This sounds like a familiar request to me too. But maybe it could be > implemented as a plugin? Ohhh that sounds intriguing. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21892] Robin Sheat is not a typo
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21892 --- Comment #23 from David Cook --- (In reply to Jonathan Druart from comment #22) > (In reply to Robin Sheat from comment #20) > > :( > > Note that I did not mark it "invalid" ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22677] Include hint on OAI-PMH URL for Koha in system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22677 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22677] Include hint on OAI-PMH URL for Koha in system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22677 --- Comment #4 from Lucas Gass --- Created attachment 94358 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94358=edit Bug 22677: Include hint to OAI page path on OAI-PMH preference This copies the way we are doing it for othe rprefs (ILSDI and similar) and adds a hint to the description to make it easier to find the right path for the OAI server. To test: - Apply patch - Verify that the system preference for OAI-PMH includes now a hint to: /cgi-bin/koha/oai.pl?verb=Identify - Verify the hint is correct (add OPAC base URL) Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23812] Download icon is an upload icon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23812 --- Comment #4 from Cori Lynn Arnold --- Gorgeous! Thank you! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23812] Download icon is an upload icon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23812 ByWater Sandboxes changed: What|Removed |Added Attachment #94356|0 |1 is obsolete|| --- Comment #3 from ByWater Sandboxes --- Created attachment 94357 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94357=edit Bug 23812: Download icon is an upload icon Signed-off-by: cori -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23812] Download icon is an upload icon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23812 --- Comment #2 from Lucas Gass --- Created attachment 94356 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94356=edit Bug 23812: Download icon is an upload icon test plan 1. run a report 2. the download icon is an upload icon 3. apply patch 4. the download icon is a download icon -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23812] Download icon is an upload icon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23812 Lucas Gass changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23812] Download icon is an upload icon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23812 Lucas Gass changed: What|Removed |Added Version|19.05 |master -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23812] Download icon is an upload icon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23812 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23165] Renewals for Self Checkout (SCO) module do not record branchcode in statistics
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23165 Tomás Cohen Arazi changed: What|Removed |Added Status|Needs Signoff |ASSIGNED --- Comment #14 from Tomás Cohen Arazi --- (In reply to Magnus Enger from comment #13) > I hope I can do a signoff on this as a demo at the hackfest in Lund > tomorrow, super awesome if noone beats me to it. :-) Reset the status. I will QA after your SO. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23165] Renewals for Self Checkout (SCO) module do not record branchcode in statistics
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23165 Tomás Cohen Arazi changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |tomasco...@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23165] Renewals for Self Checkout (SCO) module do not record branchcode in statistics
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23165 Magnus Enger changed: What|Removed |Added CC||mag...@libriotech.no --- Comment #13 from Magnus Enger --- I hope I can do a signoff on this as a demo at the hackfest in Lund tomorrow, super awesome if noone beats me to it. :-) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23826] Manual Invoice does not use new accounttype and status for fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23826 Josef Moravec changed: What|Removed |Added CC||josef.mora...@gmail.com QA Contact|testo...@bugs.koha-communit |josef.mora...@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23826] Manual Invoice does not use new accounttype and status for fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23826 Josef Moravec changed: What|Removed |Added Attachment #94322|0 |1 is obsolete|| --- Comment #6 from Josef Moravec --- Created attachment 94355 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94355=edit Bug 23826: Correction for missing "F" -> "OVERDUE" change When replacing F and FU with 'OVERDUE' + status in bug 22521 I missed the cases inside the maninvoice template. This patch should correct that mistake. Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23826] Manual Invoice does not use new accounttype and status for fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23826 Josef Moravec changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9565] Deleting a biblio should alert/fail if there are existent subscriptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9565 Marjorie Barry-Vila changed: What|Removed |Added CC||marjorie.barry-vila@collect ||o.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Martin Renvoize changed: What|Removed |Added Keywords||rel_19_11_candidate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937 --- Comment #217 from Martin Renvoize --- No worries Ere, you've done a fantastic job getting us this far. As you say, the yaz and zebra docs are cryptic at best, it from me a fair while to find it and a few pointers to get the right search terms to finally spot it. I'm very happy it all seems to be working now and am looking forward to seeing it running in production. Hoping we can get it thoroughly documented before release. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23800] Batch modification tool orders items by barcode incremental by default (regression to 17.11)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23800 Arthur Suzuki changed: What|Removed |Added Attachment #94353|0 |1 is obsolete|| --- Comment #6 from Arthur Suzuki --- Created attachment 94354 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94354=edit Bug 23800: fix regression in batch item modification tool Test plan : 1/ scan several items in the Tools / Batch Item Modification 2/ click continue 3/ check that items were not displayed in the order they appeared in 4/ apply patch 5/ repeat step 1 and 2 6/ verify that items now appear in the order they were scanned -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23800] Batch modification tool orders items by barcode incremental by default (regression to 17.11)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23800 Arthur Suzuki changed: What|Removed |Added Attachment #94034|0 |1 is obsolete|| --- Comment #5 from Arthur Suzuki --- Created attachment 94353 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94353=edit Bug 23800: fix regression in batch item modification tool Test plan : 1/ scan several items in the Tools / Batch Item Modification 2/ click continue 3/ check that items were not displayed in the order they appeared in 4/ apply patch 5/ repeat step 1 and 2 6/ verify that items now appear in the order they were scanned -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment #195 from Martin Renvoize --- (In reply to Kyle M Hall from comment #150) > DEV atomic update: bug_23049_debit.perl > DBD::mysql::db do failed: Table 'koha_kohadev.account_credit_types' doesn't > exist [for Statement " > INSERT IGNORE INTO account_credit_types ( > code, > description, > can_be_added_manually, > default_amount, > is_system > ) > SELECT > SUBSTR(accounttype, 1, 80), > "Unexpected type found during upgrade", > 1, > NULL, > 0 > FROM > accountlines > WHERE > amount > 0 > "] at (eval 1419) line 109. > Upgrade to XXX done (Bug 23049 - Add account debit_types) Rebase mistake.. should be better now :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #94329|0 |1 is obsolete|| --- Comment #194 from Martin Renvoize --- Created attachment 94352 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94352=edit Bug 23049: (follow-up) Handle unexpected types -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #94326|0 |1 is obsolete|| --- Comment #191 from Martin Renvoize --- Created attachment 94349 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94349=edit Bug 23049: More thorough param checking -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #94328|0 |1 is obsolete|| --- Comment #193 from Martin Renvoize --- Created attachment 94351 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94351=edit Bug 23049: (follow-up) Correction to includes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #94327|0 |1 is obsolete|| --- Comment #192 from Martin Renvoize --- Created attachment 94350 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94350=edit Bug 23049: (follow-up) VARCHAR(80) + ac -> account -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #94325|0 |1 is obsolete|| --- Comment #190 from Martin Renvoize --- Created attachment 94348 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94348=edit Bug 23049: Update API Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #94324|0 |1 is obsolete|| --- Comment #189 from Martin Renvoize --- Created attachment 94347 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94347=edit Bug 23049: Drop type lookup as it's now a foreign key Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #94319|0 |1 is obsolete|| --- Comment #185 from Martin Renvoize --- Created attachment 94343 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94343=edit Bug 23049: Capitalise type passed to add_debit for lost_item Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #94321|0 |1 is obsolete|| --- Comment #187 from Martin Renvoize --- Created attachment 94345 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94345=edit Bug 23049: Capitalise type passed to add_debit for `overdue` Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #94320|0 |1 is obsolete|| --- Comment #186 from Martin Renvoize --- Created attachment 94344 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94344=edit Bug 23049: Remove manual_debit as it's never called Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #94318|0 |1 is obsolete|| --- Comment #184 from Martin Renvoize --- Created attachment 94342 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94342=edit Bug 23049: Update 'HE' to 'RESERVE_EXPIRED' for consistency This patch updates all cases where debit_type_code was 'HE' to 'RESERVE_EXPIRED' which is more informative and consistent with the new style guidelines. Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #94323|0 |1 is obsolete|| --- Comment #188 from Martin Renvoize --- Created attachment 94346 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94346=edit Bug 23049: Update 'N' to 'NEW_CARD' for consistency Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #94317|0 |1 is obsolete|| --- Comment #183 from Martin Renvoize --- Created attachment 94341 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94341=edit Bug 23049: Capitalise type passed to add_debit for `account` Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #94316|0 |1 is obsolete|| --- Comment #182 from Martin Renvoize --- Created attachment 94340 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94340=edit Bug 23049: Update 'PF' to 'PROCESSING' for consistency Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #94315|0 |1 is obsolete|| --- Comment #181 from Martin Renvoize --- Created attachment 94339 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94339=edit Bug 23049: Capitalise type passed to add_debit for `rent` Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #94314|0 |1 is obsolete|| --- Comment #180 from Martin Renvoize --- Created attachment 94338 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94338=edit Bug 23049: Update debit_type_code 'Res' to 'RESERVE' This patch updates all cases where debit_type_code was 'Res' to 'RESERVE' which is more informative and consistent with the new style guidelines. The patch also ensure all calls to add_debit with a type or 'reserve' now pass the capitalised code instead. Signed-off-by: Séverine QUEUNE Capitalise reserve -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #94313|0 |1 is obsolete|| --- Comment #179 from Martin Renvoize --- Created attachment 94337 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94337=edit Bug 23049: Update existing code to use debit_type * Update C4::Accounts::chargelostitem * Update C4::Accounts::manualinvoice * Update C4::Circulation::_FixOverduesOnReturn * Update C4::Circulation::_FixAccountForLostAndReturned * Update C4::Overdues::UpdateFine * Update C4::Overdues::GetFine * Update C4::Overdues::GetOverduesForBranch * Update Koha::Account->pay * Update Koha::Account->add_debit * Update Koha::Account->non_issues_charges * Update Koha::Account::Line->apply * Update Koha::Account::Line->adjust * Update controller scripts * Update reports scripts * Update tests Test Plan 1) Run the test suit and ensure everything still passes 2) Test reports/cash_register_stats still works 3) Test that adding manual invoices still works 4) Test that making payments still works 5) Test that lost item fee handling still works 6) Test that invoice printing still works 7) Test that the sco still works Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #94311|0 |1 is obsolete|| --- Comment #177 from Martin Renvoize --- Created attachment 94335 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94335=edit Bug 23049: Update maninvoice to reference debit types Test plan: 1) Naviage to a patron record and select the accounts > manual invoice tab 2) Add some manual invoices and confirm they are working as expected 3) Signoff Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #94310|0 |1 is obsolete|| --- Comment #176 from Martin Renvoize --- Created attachment 94334 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94334=edit Bug 23049: Filter out system types by default Test Plan 1) Navigate to the debit types management page added in previous patches 2) Note that system types are now filtered out by default 3) Click on the new unfilter button to include system types 4) Signoff Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #94312|0 |1 is obsolete|| --- Comment #178 from Martin Renvoize --- Created attachment 94336 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94336=edit Bug 23049: Add tests Test plan: prove t/db_dependent/Koha/Account/DebitType.t prove t/db_dependent/Koha/Account/DebitTypes.t Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #94308|0 |1 is obsolete|| --- Comment #174 from Martin Renvoize --- Created attachment 94332 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94332=edit Bug 23049: Add CHECK constraint to accountlines Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #94309|0 |1 is obsolete|| --- Comment #175 from Martin Renvoize --- Created attachment 94333 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94333=edit Bug 23049: Account types configuration - Admin page Test plan: 1) Go to admin home, note there is new Debit types page in Accounting section 2) Go to any other admin page and confirm there is link to Debit types in the admin menu as well 3) Go to Debit types page 4) You should see a datatable listing existing debit types, ensure they are working as expected. 5) Try to create, edit and delete some debit types. Note: Some debit types cannot be deleted as they are needed for koha functionality. Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #94307|0 |1 is obsolete|| --- Comment #173 from Martin Renvoize --- Created attachment 94331 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94331=edit Bug 23049: Add debit_type * Add account_debit_types table * Add ac_debit_types_branches table * Add account_debit_types defaults * Add Koha::Account::DebitType and Koha::Account::DebitTypes * Prevent deletion of defaults * Migrate MANUAL_INV values * Remove MANUAL_INV references * Migrate accounttype values Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611 --- Comment #26 from Nick Clemens --- (In reply to Katrin Fischer from comment #25) > > > Manually edited: > > > Items available for loan: Centerville[Call number: 005.13/3] (1). > > > Centerville Staff Collection[Call number: 005.13/3] (2), Centerville > > > Ordered[Call number: 005.13/3] (1). Damaged (1). > > > > > What do you mean about missing 'for reference'? From my perspective that is > > a goal of the patch here - to remove that label and use the notforloan > > descriptions - if a library wants items to appear that way then they can > > make that the description of the authorized value for the opac. This way > > those who want it can put it in place, and those who don't can provide their > > own description > > But then we should also remove the "Items available for loan". > Because that is clearly giving a wrong idea? > > Just: Items: ? > > Or we can still assume that items that are marked with any 'not for loan' > value are for reference and list them with their individual status > descriptions behind the "Items available for reference" label. NVM, I got confused, yes, the conditional for 'reference' needs a fix, checking this one -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23824] Add a ‘Save and run’ button to reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23824 Lisette Scheer changed: What|Removed |Added CC||lisettesla...@gmail.com --- Comment #1 from Lisette Scheer --- This would be very helpful when writing reports! Lisette -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22922] Allow to modify hold and hold expiration date in staff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22922 Lucy Vaux-Harvey changed: What|Removed |Added CC||lucy.vaux-harvey@ptfs-europ ||e.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23818] Acquisitions receipt created when an item or invoice is received.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23818 --- Comment #3 from rkui...@roundrocktexas.gov --- Created attachment 94330 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94330=edit One idea for how the receipt slip would look -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23826] Manual Invoice does not use new accounttype and status for fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23826 Andrew Fuerste-Henry changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #5 from Andrew Fuerste-Henry --- - created Manual Invoice of type Fine - ran report to see that accountlines entry - confirmed it is accounttype=OVERDUE, status=NULL Thanks again, Martin! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #94152|0 |1 is obsolete|| --- Comment #171 from Martin Renvoize --- Created attachment 94328 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94328=edit Bug 23049: (follow-up) Correction to includes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #94165|0 |1 is obsolete|| --- Comment #172 from Martin Renvoize --- Created attachment 94329 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94329=edit Bug 23049: (follow-up) Handle unexpected types -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #94151|0 |1 is obsolete|| --- Comment #170 from Martin Renvoize --- Created attachment 94327 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94327=edit Bug 23049: (follow-up) VARCHAR(80) + ac -> account -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #94149|0 |1 is obsolete|| --- Comment #168 from Martin Renvoize --- Created attachment 94325 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94325=edit Bug 23049: Update API Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #94150|0 |1 is obsolete|| --- Comment #169 from Martin Renvoize --- Created attachment 94326 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94326=edit Bug 23049: More thorough param checking -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #94146|0 |1 is obsolete|| --- Comment #165 from Martin Renvoize --- Created attachment 94321 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94321=edit Bug 23049: Capitalise type passed to add_debit for `overdue` Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #94147|0 |1 is obsolete|| --- Comment #166 from Martin Renvoize --- Created attachment 94323 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94323=edit Bug 23049: Update 'N' to 'NEW_CARD' for consistency Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #94148|0 |1 is obsolete|| --- Comment #167 from Martin Renvoize --- Created attachment 94324 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94324=edit Bug 23049: Drop type lookup as it's now a foreign key Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23826] Manual Invoice does not use new accounttype and status for fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23826 ByWater Sandboxes changed: What|Removed |Added Attachment #94306|0 |1 is obsolete|| --- Comment #4 from ByWater Sandboxes --- Created attachment 94322 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94322=edit Bug 23826: Correction for missing "F" -> "OVERDUE" change When replacing F and FU with 'OVERDUE' + status in bug 22521 I missed the cases inside the maninvoice template. This patch should correct that mistake. Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #94145|0 |1 is obsolete|| --- Comment #164 from Martin Renvoize --- Created attachment 94320 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94320=edit Bug 23049: Remove manual_debit as it's never called Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #94143|0 |1 is obsolete|| --- Comment #162 from Martin Renvoize --- Created attachment 94318 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94318=edit Bug 23049: Update 'HE' to 'RESERVE_EXPIRED' for consistency This patch updates all cases where debit_type_code was 'HE' to 'RESERVE_EXPIRED' which is more informative and consistent with the new style guidelines. Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #94144|0 |1 is obsolete|| --- Comment #163 from Martin Renvoize --- Created attachment 94319 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94319=edit Bug 23049: Capitalise type passed to add_debit for lost_item Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #94140|0 |1 is obsolete|| --- Comment #159 from Martin Renvoize --- Created attachment 94315 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94315=edit Bug 23049: Capitalise type passed to add_debit for `rent` Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #94142|0 |1 is obsolete|| --- Comment #161 from Martin Renvoize --- Created attachment 94317 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94317=edit Bug 23049: Capitalise type passed to add_debit for `account` Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #94141|0 |1 is obsolete|| --- Comment #160 from Martin Renvoize --- Created attachment 94316 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94316=edit Bug 23049: Update 'PF' to 'PROCESSING' for consistency Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #94139|0 |1 is obsolete|| --- Comment #158 from Martin Renvoize --- Created attachment 94314 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94314=edit Bug 23049: Update debit_type_code 'Res' to 'RESERVE' This patch updates all cases where debit_type_code was 'Res' to 'RESERVE' which is more informative and consistent with the new style guidelines. The patch also ensure all calls to add_debit with a type or 'reserve' now pass the capitalised code instead. Signed-off-by: Séverine QUEUNE Capitalise reserve -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #94137|0 |1 is obsolete|| --- Comment #156 from Martin Renvoize --- Created attachment 94312 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94312=edit Bug 23049: Add tests Test plan: prove t/db_dependent/Koha/Account/DebitType.t prove t/db_dependent/Koha/Account/DebitTypes.t Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #94138|0 |1 is obsolete|| --- Comment #157 from Martin Renvoize --- Created attachment 94313 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94313=edit Bug 23049: Update existing code to use debit_type * Update C4::Accounts::chargelostitem * Update C4::Accounts::manualinvoice * Update C4::Circulation::_FixOverduesOnReturn * Update C4::Circulation::_FixAccountForLostAndReturned * Update C4::Overdues::UpdateFine * Update C4::Overdues::GetFine * Update C4::Overdues::GetOverduesForBranch * Update Koha::Account->pay * Update Koha::Account->add_debit * Update Koha::Account->non_issues_charges * Update Koha::Account::Line->apply * Update Koha::Account::Line->adjust * Update controller scripts * Update reports scripts * Update tests Test Plan 1) Run the test suit and ensure everything still passes 2) Test reports/cash_register_stats still works 3) Test that adding manual invoices still works 4) Test that making payments still works 5) Test that lost item fee handling still works 6) Test that invoice printing still works 7) Test that the sco still works Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #94136|0 |1 is obsolete|| --- Comment #155 from Martin Renvoize --- Created attachment 94311 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94311=edit Bug 23049: Update maninvoice to reference debit types Test plan: 1) Naviage to a patron record and select the accounts > manual invoice tab 2) Add some manual invoices and confirm they are working as expected 3) Signoff Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #94134|0 |1 is obsolete|| --- Comment #153 from Martin Renvoize --- Created attachment 94309 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94309=edit Bug 23049: Account types configuration - Admin page Test plan: 1) Go to admin home, note there is new Debit types page in Accounting section 2) Go to any other admin page and confirm there is link to Debit types in the admin menu as well 3) Go to Debit types page 4) You should see a datatable listing existing debit types, ensure they are working as expected. 5) Try to create, edit and delete some debit types. Note: Some debit types cannot be deleted as they are needed for koha functionality. Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #94135|0 |1 is obsolete|| --- Comment #154 from Martin Renvoize --- Created attachment 94310 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94310=edit Bug 23049: Filter out system types by default Test Plan 1) Navigate to the debit types management page added in previous patches 2) Note that system types are now filtered out by default 3) Click on the new unfilter button to include system types 4) Signoff Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #94133|0 |1 is obsolete|| --- Comment #152 from Martin Renvoize --- Created attachment 94308 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94308=edit Bug 23049: Add CHECK constraint to accountlines Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #94132|0 |1 is obsolete|| --- Comment #151 from Martin Renvoize --- Created attachment 94307 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94307=edit Bug 23049: Add debit_type * Add account_debit_types table * Add ac_debit_types_branches table * Add account_debit_types defaults * Add Koha::Account::DebitType and Koha::Account::DebitTypes * Prevent deletion of defaults * Migrate MANUAL_INV values * Remove MANUAL_INV references * Migrate accounttype values Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23828] New: Elasticsearch - ES - Authority record results not ordered correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23828 Bug ID: 23828 Summary: Elasticsearch - ES - Authority record results not ordered correctly Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs@lists.koha-community.org Reporter: n...@bywatersolutions.com For example: Catholic Church Addresses, essays, lectures Catholic Church El Salvador Addresses, essays, lectures . . . Catholic Church. The 'El Salvador' displays first, but is sorted as coming after Address... Catcholic hcurch with an ending period comes after Catholic Church with subfields We should ideally generate the sort fields in the same order that fields are listed in the record - that seems to be how the display of results is formed -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973 Lisette Scheer changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #35 from Lisette Scheer --- Works as expected. Very excited for this feature. I did notice that when checking the title it doesn't matter what the case of the letters are but with author it does on both the patron and staff side. (ie if the author is cataloged as Tyler, chris it won't warn if Tyler, Chris is entered instead.) Lisette -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23827] Cash register statistics uses old accounttype values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23827 --- Comment #5 from Andrew Fuerste-Henry --- Thanks for jumping right on this, Martin! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23827] Cash register statistics uses old accounttype values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23827 Andrew Fuerste-Henry changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #4 from Andrew Fuerste-Henry --- - created a circ rule that includes fines - checked out an item with a due date in the past - checked that item back in - verified patron had a fine - verified that fine shows in cash register stats when filtering for Fine -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23826] Manual Invoice does not use new accounttype and status for fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23826 --- Comment #3 from Martin Renvoize --- Created attachment 94306 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94306=edit Bug 23826: Correction for missing "F" -> "OVERDUE" change When replacing F and FU with 'OVERDUE' + status in bug 22521 I missed the cases inside the maninvoice template. This patch should correct that mistake. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23826] Manual Invoice does not use new accounttype and status for fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23826 Martin Renvoize changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23827] Cash register statistics uses old accounttype values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23827 ByWater Sandboxes changed: What|Removed |Added Attachment #94299|0 |1 is obsolete|| --- Comment #3 from ByWater Sandboxes --- Created attachment 94305 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94305=edit Bug 23827: Correction for missed 'F' and 'FU' case When replacing F and FU with 'OVERDUE' + status in bug 22521 I missed the cases inside the cash_register_stats template. This patch should correct that mistake. Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #150 from Kyle M Hall --- DEV atomic update: bug_23049_debit.perl DBD::mysql::db do failed: Table 'koha_kohadev.account_credit_types' doesn't exist [for Statement " INSERT IGNORE INTO account_credit_types ( code, description, can_be_added_manually, default_amount, is_system ) SELECT SUBSTR(accounttype, 1, 80), "Unexpected type found during upgrade", 1, NULL, 0 FROM accountlines WHERE amount > 0 "] at (eval 1419) line 109. Upgrade to XXX done (Bug 23049 - Add account debit_types) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973 ByWater Sandboxes changed: What|Removed |Added Attachment #94298|0 |1 is obsolete|| --- Comment #34 from ByWater Sandboxes --- Created attachment 94304 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94304=edit Bug 14973: Remove double textarea for notes Certainly a bad merge conflict resolution (I am certainly the one to blame). However I do not understand where this "note" variable come from. Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973 ByWater Sandboxes changed: What|Removed |Added Attachment #93141|0 |1 is obsolete|| --- Comment #31 from ByWater Sandboxes --- Created attachment 94301 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94301=edit Bug 14973: Check existing biblio when submitting a purchase suggestion (opac side) Test plan: - Go to opac suggestions page (opac-suggestions.pl) and click on "New purchase suggestion", - type the title (and author?) of a document that stand in you database - you should get a warning message about an exiting biblio. - clicking on confirm your suggestion add it, cancel does nothing Signed-off-by: Nicole Engard Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973 ByWater Sandboxes changed: What|Removed |Added Attachment #94297|0 |1 is obsolete|| --- Comment #33 from ByWater Sandboxes --- Created attachment 94303 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94303=edit Bug 14973: Do not skip validation step when submiting a suggestion - OPAC Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973 ByWater Sandboxes changed: What|Removed |Added Attachment #93142|0 |1 is obsolete|| --- Comment #32 from ByWater Sandboxes --- Created attachment 94302 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94302=edit Bug 14973: Check existing biblio when submitting a purchase suggestion (staff side) Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23826] Manual Invoice does not use new accounttype and status for fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23826 --- Comment #2 from Martin Renvoize --- Hi Andrew.. I presume your users were manually entering the accounttype code in the box. Could you check for me whether they were manually adding any other system accounttypes (like FU for instance) in he hope of triggering the standard processing again? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22379] ILS-DI Method "CancelHold" don't check CanReserveBeCanceledFromOpac
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22379 Arthur Suzuki changed: What|Removed |Added Severity|enhancement |minor Priority|P4 |P5 - low -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22922] Allow to modify hold and hold expiration date in staff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22922 Martin Renvoize changed: What|Removed |Added Keywords||rel_19_11_candidate CC||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18743] Filter suggestion lists correctly for IndependentBranches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18743 Jonathan Druart changed: What|Removed |Added Assignee|alexbuck...@catalyst.net.nz |jonathan.dru...@bugs.koha-c ||ommunity.org CC||jonathan.dru...@bugs.koha-c ||ommunity.org Change sponsored?|Seeking developer |Sponsored --- Comment #20 from Jonathan Druart --- I think I have tracked down the different weird behaviors. They have all been addressed in the last patch. Please test :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18743] Filter suggestion lists correctly for IndependentBranches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18743 Jonathan Druart changed: What|Removed |Added Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18743] Filter suggestion lists correctly for IndependentBranches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18743 Jonathan Druart changed: What|Removed |Added Attachment #72637|0 |1 is obsolete|| Attachment #72679|0 |1 is obsolete|| --- Comment #19 from Jonathan Druart --- Created attachment 94300 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94300=edit Bug 18743: Fix suggestion listing when organized by library There are some weird behaviors happening when using the "Organize by: library" dropdown along with the library filter (in the "Acquisition information" box). I am suggesting the following test plan: 0. Create several suggestion from different libraries A. You are superlibrarian and IndependentBranches is not set 1. Hit /suggestion/suggestion.pl => Default view shows the suggestions from your library 2. Filter by another library => You see the suggestions from this library 3. Filter by "Any" libraries => You see all the suggestions 4. "Organize by library" => You see all the suggestions, organized by library 5. Filter by a specific library => You see the suggestion from your library, all in one tab B. You are not superlibrarian and IndependentBranches Same as A. C. You are superlibrarian and IndependentBranches is set Same as A. D. You are not superlibrarian and IndependentBranches is not set You will never see suggestions coming from outside your library QA: To be clear: the whole script needs a rewrite, but here we are just trying to fix weird behaviors. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23826] Manual Invoice does not use new accounttype and status for fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23826 --- Comment #1 from Martin Renvoize --- OK, so this is a case I wasn't expecting at all :(. I'll have a quick ponder as to the best solution as I'm currently working towards the unification and clarification of these manual invoice types in bug 23049 and will need to account for this use case there as well as building something for working with here separately. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23827] Cash register statistics uses old accounttype values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23827 --- Comment #2 from Martin Renvoize --- That should do the trick. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23827] Cash register statistics uses old accounttype values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23827 Martin Renvoize changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23827] Cash register statistics uses old accounttype values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23827 --- Comment #1 from Martin Renvoize --- Created attachment 94299 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94299=edit Bug 23827: Correction for missed 'F' and 'FU' case When replacing F and FU with 'OVERDUE' + status in bug 22521 I missed the cases inside the cash_register_stats template. This patch should correct that mistake. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize changed: What|Removed |Added Blocks||23827 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23827 [Bug 23827] Cash register statistics uses old accounttype values -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23827] Cash register statistics uses old accounttype values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23827 Martin Renvoize changed: What|Removed |Added Depends on||22521 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23051] Optionally renew fine accruing items when all fines on item are paid off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23051 Nick Clemens changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #35 from Nick Clemens --- t/db_dependent/Koha/Account.t - test count needs adjustment t/db_dependent/Koha/Account/Lines.t - tests are failing The feedback is improved, it would be nice to get feedback on what was successfully renewed as well. Ideally SIP would get feedback in a screen message, and patrons would get a notice of renewal on the opac. I am also not sure about the code path if a patron paid fines on the opac (via paypal etc.) but renewals are not allowed on the opac. In general I think I would prefer to see 'ok' and 'not_ok' returned as a single 'renewal_results' array, then it can be parsed once and success and failure returned. Our trainers would very much like there to be feedback for any renewal, otherwise it feels a bit magic and unpredictable There is no listing of errors if I use the 'pay' button on an individual fine, but there is when I use 'pay amount' or 'pay selected' I don't really like that the functions are internal functions and then exported - fine_paid_renewable could be an accountline method? I think maybe_renew could also be an accountline method? it could act on the item attached to fine, and maybe names like: renewable renew_items For the last point, I think the pref description should highlight that if 'RenewalPeriodBase' is set to due date, there may be doubled charges I do really like the idea here, but I think it is a big change and needs some refining -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23780] Batch check out fails to inform or trap
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23780 --- Comment #4 from Christopher Brannon --- Well, either way, if all we are being told about is the fines and not the number of checkouts, overriding the fines completely bypasses other blocks, and this is a HUGE problem. Either Koha is going to have to look ahead at all potential blocks before checkout, or it is going to have to run through the checkout process multiple times. Theoretically, if all 6 items are showing the fines block, and you have all 6 items checked for override, shouldn't it check each item in again and then run into the next block on the 6th item? It seems what is happening is an overall override, rather than a specific block override. The override for the fines is also overriding or bypassing the block for the item limit. I'm wondering if Koha needs to have a smarter override system, in that the override targets a specific block, and is not just a general, ignore everything override. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23826] Manual Invoice does not use new accounttype and status for fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23826 Andrew Fuerste-Henry changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
