[Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 --- Comment #48 from Jonathan Druart --- FYI On bug 24152 I provide a flexible way to remove Koha::Object-based objects depending on date range. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24267] C4::Breeding::ImportBreedingAuth is ineffective
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24267 --- Comment #2 from Marcel de Rooy --- Looks good at first glance. You add: +#warn Data::Dumper::Dumper( $query ); -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 --- Comment #47 from Jonathan Druart --- (In reply to Agustín Moyano from comment #46) > (In reply to Jonathan Druart from comment #43) > > Why $class->_resultset->search instead of $self->search? > > I believe that's a question only you can reply (bug 16966 - > https://bugs.koha-community.org/bugzilla3/attachment. > cgi?id=60705=diff#a/Koha/Patrons.pm_sec1) ;P > > on a firt attempt, I copied what search_patron_to_anonymize does, but then > in follow-up removed it from Patrons and placed it in LastPatrons without > $class->_resultset->search. Heh ok, fair enough. I do not think it's correct (not incorrect either). We should return $class->search(), as you did then! I am still not happy with that new module. I do not think it really makes sense. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22569] Stock rotation: need transfer reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 --- Comment #20 from Martin Renvoize --- Created attachment 96479 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96479=edit Bug 22569: Add Unit Tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22569] Stock rotation: need transfer reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 --- Comment #19 from Martin Renvoize --- Created attachment 96478 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96478=edit Bug 22569: Add a 'Transfers to send' report This patch adds a 'Transfers to send' report to the circulation page which displays items which have been triggered for transfer by the stock rotation subsystem. Caveats: 1) It is currently limited to transfers prompted by stockrotation 2) There is no way to differentiate between a transfer that has been requested and a transfer than has been actually sent. (but we do filter out transfers that have been marked as received) 3) Both 'Advance' and 'Repatriate' actions will be listed and the 'Advance' listings should have the option to set the item as 'In demand' at the current branch and thus cancel the transfer and make the item wait an additional stage period before being automatically set to transfer again. I believe we should enhance the transfers system as a whole to allow this report to be more meaningful and include transfer initiated via other means (along with appropriate actions to be taken upon them) Test plan 1) Setup a rotation plan and add some items to it as per the manual 2) Run the stockrotation cronjob with the --execute flag 3) Check that the expected items appears in the new 'Transfers to send' page. It does not yet catch items that are due for transfer by any other means as at this time we do not store that sort of detail for other mechanisms. See bug 23092 for one proposed resolution to that. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22569] Stock rotation: need transfer reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 Martin Renvoize changed: What|Removed |Added Attachment #96474|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22569] Stock rotation: need transfer reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 Martin Renvoize changed: What|Removed |Added Attachment #96472|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22569] Stock rotation: need transfer reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 Martin Renvoize changed: What|Removed |Added Attachment #96473|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22569] Stock rotation: need transfer reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 Martin Renvoize changed: What|Removed |Added Attachment #96471|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22569] Stock rotation: need transfer reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 Martin Renvoize changed: What|Removed |Added Attachment #96475|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24268] advance_notices.pl dies on undefined letter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24268 --- Comment #7 from Jonathan Druart --- Created attachment 96477 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96477=edit Bug 24268: Break assignment and warn into separate actions Signed-off-by: Liz Rea Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24268] advance_notices.pl dies on undefined letter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24268 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24268] advance_notices.pl dies on undefined letter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24268 Jonathan Druart changed: What|Removed |Added Attachment #96462|0 |1 is obsolete|| Attachment #96463|0 |1 is obsolete|| --- Comment #6 from Jonathan Druart --- Created attachment 96476 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96476=edit Bug 24268: Unit tests Signed-off-by: Liz Rea Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20478] Advance notices: send separate digest messages per branch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20478 --- Comment #26 from Jonathan Druart --- There is something terribly wrong with this test file, the cronjob script is run outside the transaction and so changes are effective. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22569] Stock rotation: need transfer reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 --- Comment #16 from Martin Renvoize --- Created attachment 96473 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96473=edit Reverse transferstosend controller -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22569] Stock rotation: need transfer reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 --- Comment #18 from Martin Renvoize --- Created attachment 96475 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96475=edit Use inbound_transfers in transferstosend template -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22569] Stock rotation: need transfer reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 --- Comment #17 from Martin Renvoize --- Created attachment 96474 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96474=edit Add inbound_transfers to Koha::Library -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22569] Stock rotation: need transfer reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 Martin Renvoize changed: What|Removed |Added Attachment #94659|0 |1 is obsolete|| --- Comment #15 from Martin Renvoize --- Created attachment 96472 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96472=edit Bug 22569: Add Unit Tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22569] Stock rotation: need transfer reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 Martin Renvoize changed: What|Removed |Added Attachment #94658|0 |1 is obsolete|| --- Comment #14 from Martin Renvoize --- Created attachment 96471 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96471=edit Bug 22569: Add a 'Transfers to send' report This patch adds a 'Transfers to send' report to the circulation page which displays items which have been triggered for transfer by the stock rotation subsystem. Caveats: 1) It is currently limited to transfers prompted by stockrotation 2) There is no way to differentiate between a transfer that has been requested and a transfer than has been actually sent. (but we do filter out transfers that have been marked as received) 3) Both 'Advance' and 'Repatriate' actions will be listed and the 'Advance' listings should have the option to set the item as 'In demand' at the current branch and thus cancel the transfer and make the item wait an additional stage period before being automatically set to transfer again. I believe we should enhance the transfers system as a whole to allow this report to be more meaningful and include transfer initiated via other means (along with appropriate actions to be taken upon them) Test plan 1) Setup a rotation plan and add some items to it as per the manual 2) Run the stockrotation cronjob with the --execute flag 3) Check that the expected items appears in the new 'Transfers to send' page. It does not yet catch items that are due for transfer by any other means as at this time we do not store that sort of detail for other mechanisms. See bug 23092 for one proposed resolution to that. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24169] Advanced editor: icons/buttons for sorting the search results are missing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24169 --- Comment #9 from Jonathan Druart --- (In reply to Owen Leonard from comment #6) > (In reply to Jonathan Druart from comment #5) > > Owen, does not it sound more correct to copy the CSS definitions? > > It would be more correct, but I think the satisfaction of being technically > correct would be outweighed by the effort. I think a pragmatic fix is better. It seemed easy to copy the 5 lines, and I was going to propose an alternative patch. But then I realised that we may also want the other .dataTable definitions as well. I guess that why you thought the effort was consequent, I did not think about that at first. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24169] Advanced editor: icons/buttons for sorting the search results are missing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24169 --- Comment #8 from Jonathan Druart --- Created attachment 96470 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96470=edit Bug 24169: Add a comment to clarify the use of the dataTable class Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24169] Advanced editor: icons/buttons for sorting the search results are missing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24169 Jonathan Druart changed: What|Removed |Added Attachment #96386|0 |1 is obsolete|| --- Comment #7 from Jonathan Druart --- Created attachment 96469 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96469=edit Bug 24169: Advanced editor: icons/buttons for sorting the search results are missing This patch "manually" adds the "dataTable" class to the table of search results in the advanced cataloging editor. This allows the correct styles to get picked up from existing CSS. To test, go to Cataloging and open the advanced editor. Perform a search using the sidebar search form. In the table of results, confirm that table sorting indicators look correct and that sorting works correctly. Signed-off-by: Cori Lynn Arnold Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24169] Advanced editor: icons/buttons for sorting the search results are missing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24169 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24156] Basket - Make sort order and number of items to display configurable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24156 --- Comment #10 from Jonathan Druart --- (In reply to Owen Leonard from comment #9) > I notice the choices offered under "Default sort order" include columns > which are configured in the individual DataTable configuration to be > unsortable. I wonder if we need to move those settings into > columns_settings.yml too? Hi Owen, Thanks for taking a look at this. The "default sort order" dropdown list includes all the columns of the table, indeed. That could lead to inconsistencies but dealing with that on this page will add much more complexity. Moving the sortable bit to this config page is a good idea, if we agree on such move I think it should be done for all the tables in one go, which can be quite hard to do. I keep that in mind and will think about it to see what could be possible. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3426] change itemcallnumber system preference to allow multiple tags
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3426 Nick Clemens changed: What|Removed |Added Assignee|gmcha...@gmail.com |n...@bywatersolutions.com -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3426] change itemcallnumber system preference to allow multiple tags
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3426 --- Comment #7 from Nick Clemens --- Created attachment 96468 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96468=edit Bug 3426: Allow for multiple fields in itemcallnumber syspref Note that we change both cataloguing/additem.pl and C4/Items->PrepareItemrecordfordisplay I can find no code that uses callnumber from the C4/Items sub, except for the itemrecorddisplay script which is not called with an itemnumber from Koha and should be deprecated for REST or ILSDI or OAI (imho) To test: 1 - Define itemcallnumber syspref as "082ab,092ab,9520,245a" 2 - Find a record with no items 3 - Ensure it has no 082 field, but an 092 field 4 - Go to add an item - itemcallnumber is empty 5 - Apply patch 6 - Go to add item, itemcallnumber should be the 092ab fields 7 - Delete the 092 field 8 - Go to add item, itemcallnumber should be the 245a 9 - Edit the callnumber to be "testing" and save item 10 - For should now show itemcallnumber="testing" as default 11 - Browse to http://localhost:8081/cgi-bin/koha/services/itemrecorddisplay.pl?itemnumber=## subbing the correct itemnumber 12 - Ensure the callnumber is defaulting to testing 13 - delete the item you created 14 - browse to URL above - callnumber should now be 245 again 15 - Add an 092 field to record and ensure it is now default callnumber 16 - Add an 082 field, it should now be default -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3426] change itemcallnumber system preference to allow multiple tags
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3426 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24273] New: It is possible to incorporate IIIF compatibility in Koha Bibliographic catalog
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24273 Bug ID: 24273 Summary: It is possible to incorporate IIIF compatibility in Koha Bibliographic catalog Change sponsored?: --- Product: Koha Version: 19.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: urr...@gmail.com QA Contact: testo...@bugs.koha-community.org IIIF is becoming a "de facto" standard for image interoperability. Many libraries and other institutions are aligning to the IIIF framework for image visualization. It will very usefull If we can incorporate to the OPAC bibliographic record, the visualization of images representing the documents using IIIF manifests or using images served in IIIF compatible image servers. Today you can upload images linked to bibliographic records and you can visualize those images as part of the bibliographic record detailed view. With IIIF compatibility, that option can be very open interoperating with images collections that represent the bibliographic record. That will give KOHA a natural connection with digital representations of documents in a descentralized and interoperable way. There are client side solutions as openseadragon and others. The digital representations of documents in images can be in any IIIF images server and collections of images can be linked trough the manifest standarized in the IIIF presentation API. Other LIS are incorporating IIIF interoperability. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24272] Add a command line script to compare the syspref cache to the database
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24272 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24272] Add a command line script to compare the syspref cache to the database
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24272 --- Comment #1 from Nick Clemens --- Created attachment 96467 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96467=edit Bug 24272: add check_sysprefs_cache.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24272] New: Add a command line script to compare the syspref cache to the database
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24272 Bug ID: 24272 Summary: Add a command line script to compare the syspref cache to the database Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: n...@bywatersolutions.com Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: ro...@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24156] Basket - Make sort order and number of items to display configurable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24156 --- Comment #9 from Owen Leonard --- I notice the choices offered under "Default sort order" include columns which are configured in the individual DataTable configuration to be unsortable. I wonder if we need to move those settings into columns_settings.yml too? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24169] Advanced editor: icons/buttons for sorting the search results are missing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24169 --- Comment #6 from Owen Leonard --- (In reply to Jonathan Druart from comment #5) > Owen, does not it sound more correct to copy the CSS definitions? It would be more correct, but I think the satisfaction of being technically correct would be outweighed by the effort. I think a pragmatic fix is better. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24173] Advanced Editor: Show subtitle & published date on the search page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24173 Owen Leonard changed: What|Removed |Added Attachment #96454|0 |1 is obsolete|| --- Comment #3 from Owen Leonard --- Created attachment 96466 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96466=edit Bug 24173: Advanced Editor: Show subtitle & published date on the search page To test: Prior to patch: 1/Verify that EnableAdvancedCatalogingEditor syspref is set to "enable" 2/Go to Cataloging 3/Click on "Advanced Editor" button 4/In left hand box put "specious" under Keywords and hit "enter" 5/verify that "Library of Congress" (or some other server) Z39.50 is checked 6/Verify that there are no headings for "Subtitle" and "Published" Apply Patch 1/Go to Administration->Koha to MARC mapping 2/Add or verify that there are entries for "biblio.subtitle" and "biblio.copyrightdate" 3/Go to Cataloging 4/Click on "Advanced Editor" button 5/In left hand box put "specious" under Keywords and hit "enter" 6/verify that "Library of Congress" (or some other server) Z39.50 is checked 7/Verify that there are headings for "Subtitle" and "Published" and the data matches with the fields from Koha to MARC mapping when you click on "View MARC" link for that record. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24173] Advanced Editor: Show subtitle & published date on the search page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24173 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13897] Use YAML files for installer data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897 --- Comment #31 from David Cook --- Couldn't we just use the DEFAULT keyword to specify a default value? (I haven't tried it so just a suggestion.) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18532] AUTO_RENEWALS should be a patron messaging preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 --- Comment #17 from Tomás Cohen Arazi --- (In reply to David Murguia from comment #16) > We have recently started receiving complaints about the individual emails > for auto-renewals. It would be great to see this development happen. It would help if you tested it -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18532] AUTO_RENEWALS should be a patron messaging preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 dav...@ranchomiragelibrary.org changed: What|Removed |Added CC||davidm@ranchomiragelibrary. ||org --- Comment #16 from dav...@ranchomiragelibrary.org --- We have recently started receiving complaints about the individual emails for auto-renewals. It would be great to see this development happen. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18729] Librarian unable to update hold pickup library from patron pages without "modify_holds_priority" permission
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18729 --- Comment #12 from Katrin Fischer --- > Thinking of an upgrade path, would you agree users with > modify_holds_priority should inherit the new modify_holds_pickup_location > permission? I think I would even make it simpler and use reserve_for_others or place_holds. As Kyle wrote it's already possible to change the pickup location without the modify_holds_priority permission - just from another page. The API way to do things was added later - so people have probably been doing the other way for a long time with the lower permission. Short: I'd match what the holds page for the record has. And if we add a new permission we should probably change it there as well? comment#0 >A librarian can update a hold's pickup library from the record details page, >>but not from the patron details or checkout pages unless he or she has the >>"modify_holds_priority". If the librarian does not, an error is displayed >>instead. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23089] Elasticsearch - cannot sort on non-text fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23089 Hayley Mapley changed: What|Removed |Added CC||hayleymap...@catalyst.net.n ||z Version(s)|19.11.00|19.11.00, 18.11.12 released in|| Status|Pushed to oldstable |Pushed to oldoldstable --- Comment #23 from Hayley Mapley --- This patchset has not been pushed to 18.11.11, rather it has been pushed to 18.11.x for 18.11.12 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21665] Advanced editor - Double clicking on value brings subfield code as well
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21665 Cori Lynn Arnold changed: What|Removed |Added Status|NEW |Needs Signoff --- Comment #4 from Cori Lynn Arnold --- To test, apply patch: 0/Verify that the advanced editor is enabled by going to "Administration" and searching for "EnableAdvancedCatalogingEditor" 1/Set it to "Enable" if it isn't already. 2/Go to "Cataloging", click on "Advanced editor" 3/Search for a record by entering "specious" in the keyword box and hitting enter 4/Click "import" on a record 5/For any subfield (maybe specifically the text in an 020 field) double click on the text 6/Hit CNTRL-V into your favorite text editor, verify that the subfield code was not pasted with the text from the subfield. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21665] Advanced editor - Double clicking on value brings subfield code as well
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21665 --- Comment #3 from Cori Lynn Arnold --- Created attachment 96465 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96465=edit Bug 21665: Advanced editor - double clicking on value brings subfield code as well To test, apply patch: 0/Verify that the advanced editor is enabled by going to "Administration" and searching for "EnableAdvancedCatalogingEditor" 1/Set it to "Enable" if it isn't already. 2/Go to "Cataloging", click on "Advanced editor" 3/Search for a record by entering "specious" in the keyword box and hitting enter 4/Click "import" on a record 5/For any subfield (maybe specifically the text in an 020 field) double click on the text 6/Hit CNTRL-V into your favorite text editor, verify that the subfield code was not pasted with the text from the subfield. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3426] change itemcallnumber system preference to allow multiple tags
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3426 Jessie Zairo changed: What|Removed |Added CC||jza...@bywatersolutions.com --- Comment #6 from Jessie Zairo --- I can confirm, this is something we get requests from libraries pretty frequently. This would be a helpful enhancement to be able to define multiple call numbers to check. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24185] 'If all unavailable' state for 'on shelf holds' makes holds page very slow if there's a lot of items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24185
--- Comment #9 from Andrew Nugged ---
Created attachment 96464
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96464=edit
Bug 24185: Make holds page fast when 'on shelf holds' set to 'If all
unavailable'
When "reserve/request.pl -> C4/Reserves.pm::IsAvailableForItemLevelRequest"
called many times with hundred of items and "on shelf holds" parameter set to
"If all unavailable" for these items + patron, it goes slow.
It happens because in subloop there is checking if all items available so it is
O(n^2) and it re-checks each time the same info for each item with repeating
DB/data requests.
Fix:
The inner loop 1:1 picked out from another loop and put before that items
processing loop,
'items_any_available' variable precalculated,
this variable passed to IsAvailableForItemLevelRequest to be used inside as the
precalculated result.
On tests it gave a drastic improvement in execution time.
How to reproduce:
1) on freshly installed kohadevbox create/import one book,
remember that biblionumber for later use it in down below,
2) add 100 items for that book for some library,
3) find some patron, that patron's card number we will
use as a borrower down below to open holds page,
4) check for the rule or set up a single circulation rule
in admin "/cgi-bin/koha/admin/smart-rules.pl",
that rule should match above book items/library/patron,
check that rule to have a non-zero number of holds (total, daily, count)
allowed,
and, IMPORTANT: set up "On shelf holds allowed" to "If all unavailable",
("item level holds" doesn't matter).
5) open "Home > Catalog > THAT_BOOK > Place a hold on THAT_BOOK" page
("holds" tab), and enter patron code in the search field,
or you can create a direct link by yourself, for example, in my case it was:
/cgi-bin/koha/reserve/request.pl?biblionumber=4=23529000686353
6) it should be pretty long page generation time on old code, densely
increasing for every hundred items added. In the case of this solution, it's
fast, and time increases a little only, linear.
I tested on my computer in VirtualBox for page generation times,
did 3-5 runs for same case to check if results are stable, and got such values:
(old code):
100 items:38 seconds
200 items: 2.5 minutes
300 items: 5.4 minutes
(version with fix):
100 items: 3.7 seconds
200 items: 6.4 seconds
300 items: 8.7 seconds
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3426] change itemcallnumber system preference to allow multiple tags
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3426 Andrew Fuerste-Henry changed: What|Removed |Added CC||n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9156] itemcallnumber not pulling more than 2 subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9156 Andrew Fuerste-Henry changed: What|Removed |Added CC||and...@bywatersolutions.com ||, n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3426] change itemcallnumber system preference to allow multiple tags
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3426 Andrew Fuerste-Henry changed: What|Removed |Added CC||and...@bywatersolutions.com --- Comment #5 from Andrew Fuerste-Henry --- Hi all! Giving this old bug a bump. I talk to lots of libraries that would like to be able to define something like "050ab, 090ab" so that Koha will first check the 050 and use that call number if present, but, if no 050 is found, will then check the 090 and use that call number instead. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24268] advance_notices.pl dies on undefined letter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24268 Liz Rea changed: What|Removed |Added Attachment #96459|0 |1 is obsolete|| --- Comment #5 from Liz Rea --- Created attachment 96463 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96463=edit Bug 24268: Unit tests Signed-off-by: Liz Rea -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24268] advance_notices.pl dies on undefined letter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24268 Liz Rea changed: What|Removed |Added Attachment #96458|0 |1 is obsolete|| --- Comment #4 from Liz Rea --- Created attachment 96462 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96462=edit Bug 24268: Break assignment and warn into separate actions Signed-off-by: Liz Rea -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24268] advance_notices.pl dies on undefined letter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24268 Liz Rea changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24185] 'If all unavailable' state for 'on shelf holds' makes holds page very slow if there's a lot of items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24185 --- Comment #8 from Andrew Nugged --- Created attachment 96461 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96461=edit Bug 24185: Make holds page faster - call to subroutine moved below "if" `$on_shelf_holds` was assigned before "return .. if" but not used in that code piece, so sometimes it was useless. Moved assignment after "return .. if". -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24185] 'If all unavailable' state for 'on shelf holds' makes holds page very slow if there's a lot of items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24185 Andrew Nugged changed: What|Removed |Added Attachment #96354|0 |1 is obsolete|| --- Comment #7 from Andrew Nugged --- Created attachment 96460 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96460=edit Bug 24185: Make holds page faster - improved "if" `$can_item_be_reserved eq 'OK'` moved in `&&` before `IsAvailableForItemLevelRequest` to cut away with static known values before calling to more resource consuming subroutine. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21446] Improve display of changed values on course reserves and show permanent location instead of cart
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21446 Myka Kennedy Stephens changed: What|Removed |Added Resolution|FIXED |--- CC||mkstephens@lancasterseminar ||y.edu Status|RESOLVED|REOPENED --- Comment #15 from Myka Kennedy Stephens --- I have noticed a typo that I think is related to this bug. In course reserves, when a course is inactive, the normal item type is lacking a closing parentheses in the item table. To Test: 1) Create a course in course reserves, make it inactive 2) Add an item to it, changing item type and location 3) Note that the normal item type is in bold with an opening parentheses but no closing parentheses; Note that the normal location is in bold with both opening and closing parentheses. 4) Make the course active 5) Note that the normal item type is no longer bold and has both opening and closing parentheses; Note that the normal location is also not bold and has both opening and closing parentheses. Please fix to add closing parentheses to the normal item type when a course is inactive. Thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8838] Digest option for HOLD notice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8838 Michal Denar changed: What|Removed |Added CC||blac...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24269] Authority matching in Elasticsearch is broken when authority has subdivisions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24269 Nick Clemens changed: What|Removed |Added CC||alex.arn...@biblibre.com, ||ere.maij...@helsinki.fi, ||glask...@gmail.com, ||jonathan.dru...@bugs.koha-c ||ommunity.org, ||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24269] New: Authority matching in Elasticsearch is broken when authority has subdivisions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24269
Bug ID: 24269
Summary: Authority matching in Elasticsearch is broken when
authority has subdivisions
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: major
Priority: P5 - low
Component: Searching - Elasticsearch
Assignee: koha-bugs@lists.koha-community.org
Reporter: n...@bywatersolutions.com
In C4/Heading/MARC21.pm when we call _get_search_heading we look at the heading
and turn some subfields into terms so:
150 $aChess$xOpenings
becomes
'Chess generalsubdiv openings'
126 my %subdivisions = (
127 'v' => 'formsubdiv',
128 'x' => 'generalsubdiv',
129 'y' => 'chronologicalsubdiv',
130 'z' => 'geographicsubdiv',
131 );
267 $heading .= " $subdivisions{$code} $value";
We don't do this when indexing into ES so we will never find matches for these
records
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21309] Enforce password change on login
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21309 Michal Denar changed: What|Removed |Added CC||blac...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7999] Send test notice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7999 Michal Denar changed: What|Removed |Added CC||blac...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11858] RFID for circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11858 Michal Denar changed: What|Removed |Added CC||blac...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24268] advance_notices.pl dies on undefined letter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24268 --- Comment #3 from Nick Clemens --- Created attachment 96459 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96459=edit Bug 24268: Unit tests -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24268] advance_notices.pl dies on undefined letter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24268 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24268] advance_notices.pl dies on undefined letter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24268 Nick Clemens changed: What|Removed |Added CC||danielle@bywatersolutions.c ||om, ||l...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24268] advance_notices.pl dies on undefined letter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24268 --- Comment #2 from Nick Clemens --- This should probably be covered by tests, shoudl be able to recreate the situation by having a patron request messages in a transport not defined in a digest message -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24268] advance_notices.pl dies on undefined letter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24268 Nick Clemens changed: What|Removed |Added Depends on||20478 CC||jonathan.dru...@bugs.koha-c ||ommunity.org, ||k...@bywatersolutions.com, ||martin.renvoize@ptfs-europe ||.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20478 [Bug 20478] Advance notices: send separate digest messages per branch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20478] Advance notices: send separate digest messages per branch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20478 Nick Clemens changed: What|Removed |Added Blocks||24268 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24268 [Bug 24268] advance_notices.pl dies on undefined letter -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24268] advance_notices.pl dies on undefined letter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24268 --- Comment #1 from Nick Clemens --- Created attachment 96458 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96458=edit Bug 24268: Break assignment and warn into separate actions -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24268] New: advance_notices.pl dies on undefined letter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24268
Bug ID: 24268
Summary: advance_notices.pl dies on undefined letter
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: major
Priority: P5 - low
Component: Notices
Assignee: koha-bugs@lists.koha-community.org
Reporter: n...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
Bug 20478 changed the assignment/warn in advance_notices - it seems that new we
either assign a letter, or the value of the warn (1) to the letter. This
causes:
Can't use string ("1") as a HASH ref while "strict refs" in use at
advance_notices.pl line 589.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21667] Advanced Editor - advanced search - result set is lost after repeated clicks on “next” button
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21667 Cori Lynn Arnold changed: What|Removed |Added Severity|enhancement |minor --- Comment #1 from Cori Lynn Arnold --- Verified this is still happening, and consistently on the second pressing of "Next" -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24232] Deleting a bib record after attaching the last item to another bib
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24232 --- Comment #17 from Jonathan Druart --- Created attachment 96456 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96456=edit Bug 24232: Fix required permissions in DELETE /biblios/:biblio_id This patch fixes the required permissions defined on the spec for the mentioned endpoint. To test: 1. Apply the tests patch 2. Run: $ kshell k$ prove t/db_dependent/api/v1/biblios.t => FAIL: Tests fail due to badly defined permissions 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! Notice parameters: edit_catelogue didn't exist 5. Sign off :-D Signed-off-by: Kelly McElligott Signed-off-by: Kelly McElligott Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24232] Deleting a bib record after attaching the last item to another bib
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24232 --- Comment #18 from Jonathan Druart --- Created attachment 96457 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96457=edit Bug 24232: Hide the "Delete biblio" if permission edit_catalogue not set The script moveitem.pl requires editcatalogue => 'edit_items', the deletion of a biblio editcatalogue => edit_catalogue. Even if weird I guess we could have a librarian with edit_items but edit_catalogue. Signed-off-by: Kelly McElligott Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24232] Deleting a bib record after attaching the last item to another bib
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24232 Jonathan Druart changed: What|Removed |Added Attachment #96434|0 |1 is obsolete|| Attachment #96435|0 |1 is obsolete|| Attachment #96436|0 |1 is obsolete|| --- Comment #16 from Jonathan Druart --- Created attachment 96455 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96455=edit Bug 24232: Regression tests This patch enhances the tests for the DELETE /biblios/:biblio_id endpoint so more fine grained permissions are tested. It highlights the fact that the required permissions defined on the spec are not correcttly defined. To test: 1. Run: $ kshell k$ prove t/db_dependent/api/v1/biblios.t => FAIL: Tests fail because the user (that now has subpermissions only) does not have enough permissions for a non-existent subpermission Signed-off-by: Kelly McElligott Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24232] Deleting a bib record after attaching the last item to another bib
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24232 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24173] Advanced Editor: Show subtitle & published date on the search page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24173 Cori Lynn Arnold changed: What|Removed |Added Status|NEW |Needs Signoff --- Comment #2 from Cori Lynn Arnold --- Patch adds "Subtitle" and "Published" (date) field to the Advanced Editor search overlay. To test: Prior to patch: 1/Verify that EnableAdvancedCatalogingEditor syspref is set to "enable" 2/Go to Cataloging 3/Click on "Advanced Editor" button 4/In left hand box put "specious" under Keywords and hit "enter" 5/verify that "Library of Congress" (or some other server) Z39.50 is checked 6/Verify that there are no headings for "Subtitle" and "Published" Apply Patch 1/Go to Administration->Koha to MARC mapping 2/Add or verify that there are entries for "biblio.subtitle" and "biblio.copyrightdate" 3/Go to Cataloging 4/Click on "Advanced Editor" button 5/In left hand box put "specious" under Keywords and hit "enter" 6/verify that "Library of Congress" (or some other server) Z39.50 is checked 7/Verify that there are headings for "Subtitle" and "Published" and the data matches with the fields from Koha to MARC mapping when you click on "View MARC" link for that record. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24173] Advanced Editor: Show subtitle & published date on the search page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24173 --- Comment #1 from Cori Lynn Arnold --- Created attachment 96454 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96454=edit Bug 24173: Advanced Editor: Show subtitle & published date on the search page To test: Prior to patch: 1/Verify that EnableAdvancedCatalogingEditor syspref is set to "enable" 2/Go to Cataloging 3/Click on "Advanced Editor" button 4/In left hand box put "specious" under Keywords and hit "enter" 5/verify that "Library of Congress" (or some other server) Z39.50 is checked 6/Verify that there are no headings for "Subtitle" and "Published" Apply Patch 1/Go to Administration->Koha to MARC mapping 2/Add or verify that there are entries for "biblio.subtitle" and "biblio.copyrightdate" 3/Go to Cataloging 4/Click on "Advanced Editor" button 5/In left hand box put "specious" under Keywords and hit "enter" 6/verify that "Library of Congress" (or some other server) Z39.50 is checked 7/Verify that there are headings for "Subtitle" and "Published" and the data matches with the fields from Koha to MARC mapping when you click on "View MARC" link for that record. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24267] C4::Breeding::ImportBreedingAuth is ineffective
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24267 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24267] C4::Breeding::ImportBreedingAuth is ineffective
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24267 --- Comment #1 from Nick Clemens --- Created attachment 96453 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96453=edit Bug 24267: Improve ImportBreedingAuth -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24267] C4::Breeding::ImportBreedingAuth is ineffective
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24267 Nick Clemens changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org, ||m.de.r...@rijksmuseum.nl, ||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24267] New: C4::Breeding::ImportBreedingAuth is ineffective
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24267 Bug ID: 24267 Summary: C4::Breeding::ImportBreedingAuth is ineffective Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: MARC Authority data support Assignee: koha-bugs@lists.koha-community.org Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org git grep ImportBreedingAuth - there is only one call to this routine from SearchZ3950Auth We pass it a MARC record, '2' for overwrite_auth We then check for this record in the DB and get the breeding id, however, when overwrite_auth is 2 we always add the auth to the batch and return the new breeding id. We don't actually use any of the other parameters returned here either To recreate: 1 - Browse to Authorities 2 - Select New form Z3950 3 - Perform a search that returns results 4 - SELECT COUNT(*) FROM import_auths 5 - Repeat the search 6 - SELECT COUNT(*) FROM import_auths 7 - There are 20 more records 8 - SELECT * FROM import_auths - note the repeated rows -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23673] Separate time sent from time created in message_queue table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23673 Agustín Moyano changed: What|Removed |Added Attachment #96346|0 |1 is obsolete|| Attachment #96392|0 |1 is obsolete|| --- Comment #11 from Agustín Moyano --- Created attachment 96451 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96451=edit Bug 23673: change db structure Signed-off-by: Kelly McElligott -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23673] Separate time sent from time created in message_queue table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23673 --- Comment #12 from Agustín Moyano --- Created attachment 96452 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96452=edit Bug 23673: Add "Time status changed" column to patron's notices This patch adds "Time status changed" column to patron's notices tab. It also adds logic to C4::Letters to update time_status_changed column when status is changed, and leaves time_queued with message creation time. To test: 1. Apply patches. 2. Restart plack. 3. Choose a patron and add a purchase suggestion. 4. Change suggestion status. 5. Open patron's notifications. CHECK => Messages table has now "Time status changed" and "Time created" columns, and "Time" column is gone. SUCCESS => There is a message with status pending, with a "time created" and no "time status changed" 6. Execute in the shell in Koha directory $ ./misc/cronjobs/process_message_queue.pl 7. Open patron's notifications one more time. SUCCESS => The message changed status. Time created remained the same, and now "time status changed" has the current timestamp. 8. Resend the message and repeat sep 6. SUCCESS => Every time you change the status, time created remains the same and time status changed updates. 9. prove t/db_dependant/Letters.t 10. Sign off Signed-off-by: Kelly McElligott Signed-off-by: Kelly McElligott -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23673] Separate time sent from time created in message_queue table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23673 Agustín Moyano changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #259 from Agustín Moyano --- Created attachment 96438 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96438=edit Bug 22284: Add new checkbox in Library Groups This patch adds a new checkbox option 'Is local hold group' when you create a new root group. To test: 1) In intranet go to Library Groups in admin module 2) Add new root group 3) Check that there is no 'Is local hold group' checkbox 4) Apply this patch 5) Add new root group SUCCESS => a new 'Is local hold group' checkbox appears 6) Select 'Is local hold group' and save 7) Click edit button for root group SUCCESS => 'Is local hold group' is checked 8) Sign off Sponsored-by: VOKAL Signed-off-by: Tomas Cohen Arazi Signed-off-by: Josef Moravec Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #270 from Agustín Moyano --- Created attachment 96449 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96449=edit Bug 22284: (Do not push) Schema update Signed-off-by: Josef Moravec Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #271 from Agustín Moyano --- Created attachment 96450 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96450=edit Bug 22284: (follow-up) Anotate boolean values in Koha::Schema::Result::LibraryGroup -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #267 from Agustín Moyano --- Created attachment 96446 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96446=edit Bug 22284: (follow-up) Squash multiple follow-ups * Bug 22284: (follow-up) Remove commented warn and address test failures Signed-off-by: Tomas Cohen Arazi Signed-off-by: Josef Moravec * Bug 22284: (follow-up) fix test count after merge Signed-off-by: Tomas Cohen Arazi Signed-off-by: Josef Moravec * Bug 22284: (follow-up) fixes after 15496 Signed-off-by: Josef Moravec * Bug 22284: (follow-up) fixes after 18936 Signed-off-by: Josef Moravec * Bug 22284: (follow-up) Remove HomeOrHolding from reserves Signed-off-by: Josef Moravec Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #268 from Agustín Moyano --- Created attachment 96447 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96447=edit Bug 22284: Add "patron's hold group" as new hold_fulfillment_policy option This patch adds "patron's hold group" as a new option to Hold pickup library match To test: 1. Set ReservesControlBranch preference to item. 2. Create a hold group 3. Go to circulation and fines rules SUCCESS => in 'Hold pickup library match' there is a new option called "patron's hold group" 4. In a library not in hold group set 'Hold policy' to "any" and 'Hold pickup library match' to "patron's hold group" 5. Search for a user in the hold group 6. 'Search to hold' for items of the library of step 4 7. Select an item and 'Place hold for [user]' SUCCESS => in 'Pickup at' you should see patron's hold group as options 8. In OPAC sign in as the same user of step 5 9. Search for the item in step 7 SUCCESS => in 'Pick up locations' you should see patron's hold group as options 10. Sign off Signed-off-by: Josef Moravec Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #265 from Agustín Moyano --- Created attachment 96444 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96444=edit Bug 22284: New message, new column and filter pickup locations in reserve/request.tt This patch adds a new message to 'Hold' column in 'Place a hold on a specific item' table. The message is "Cannot place hold from patrons's library". It appears when patron's homebranch is not in item's hold group, and hold_fulfillment_policy is set to 'holdgroup'. This patch also adds a new column "Allowed pickup locations" that lists allowed pickup locations per item. Finally, the select that displays pickup locations is filtered by allowed pickup locations, when multi_hold is not enabled To test: 1) Apply this patch 2) In library groups add a root group and check it as hold group. 3) Add two libraries to the group 4) In circulation and fines rules, in 'Default checkout, hold and return policy', in Hold policy change the value to 'From local hold group' 5) Search a patron from a different library than step 3, select one and click 'search to hold' 6) Search by location for items in any library of step 3 7) On any item, clic on 'Place hold for ...' SUCCESS => when the page is loaded, in the 'Place a hold on a specific item', you should see the message "Cannot place hold from patrons's library" in 'Hold' column => You should see a new column called "Allowed pickup locations" and the message is "Any library" 8) In circulation and fines rules, in 'Default checkout, hold and return policy', in 'Hold policy' change the value again to 'From any library' and change 'Hold pickup library match' to "Item's hold group" 8) Repeat steps 5 to 7 SUCCESS => when the page is loaded, you should see the "Pickup at" select filtered by libraries in hold group => You should see in "Allowed pickup locations" a coma separated list of the libraries in item's hold group => If biblio has an item whose control branch is not in a hold group, you should see the control branch name in "Allowed pickup locations" 9) Sign off Sponsored-by: VOKAL Signed-off-by: Tomas Cohen Arazi Signed-off-by: Josef Moravec Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #269 from Agustín Moyano --- Created attachment 96448 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96448=edit Bug 22284: (follow-up) Squash multiple follow-ups * Bug 22284: (follow-up) Use GetReserveControlBranch in Koha::Item->pickup_locations Signed-off-by: Josef Moravec * Bug 22284: (follow-up) Fix tests Signed-off-by: Josef Moravec * Bug 22284: (follow-up) Fix typo in request.tt Signed-off-by: Josef Moravec * Bug 22284: (follow-up) Filter pickup on specific item click Signed-off-by: Josef Moravec * Bug 22284: (follow-up) Fix typos transfered -> transferred Signed-off-by: Josef Moravec Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284
--- Comment #262 from Agustín Moyano ---
Created attachment 96441
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96441=edit
Bug 22284: New methods in Koha::Library::Groups and Koha::Library
This patch adds new methods in Koha::Library::Groups and Koha::Library.
1) For Koha::Library::Groups adds get_root_ancestor that returns all root
groups for a given search parameters, for example
Koha::Library::Groups->get_root_ancestor( { id => $group_id } )
2) For Koha::Library adds
2.1) get_hold_libraries: returns all libraries (including self) that
belongs to the same holdgroups. If $self belongs to several holdgroups
it will return a distinct list of all libraries belonging to them.
2.2) validate_hold_sibling: Returns 1 if the given parameters matches any of
the
libraries that belong to any of the holdgroups this library belongs. For
example
$library->validate_hold_sibling( { branchcode => $branchcode } )
To test:
1) apply this patch
2) prove t/db_dependent/Koha/Libraries.t t/db_dependent/LibraryGroups.t
SUCCESS => green letters :-D
3) Sign off
Sponsored-by: VOKAL
Signed-off-by: Tomas Cohen Arazi
Signed-off-by: Josef Moravec
Signed-off-by: Liz Rea
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #266 from Agustín Moyano --- Created attachment 96445 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96445=edit Bug 22284: Filter item's pickup locations in holds_table.inc This patch filters pickup locations per item in holds_table.inc To test: 1) Go to Circulation and fines rules and change max holds allowed to > 0, and change 'Hold pickup library match' to homebranch 2) Search for a patron 3) Click on "Search to hold" 4) Search for any bilio 5) Place hold on a specific item CHECK => Item's pickup location is a select with all libraries 6) Apply this patch 7) Repeat steps 2 to 5 SUCCESS => Item's pickup location is filtered by allowed pickup locations 8) Sign off Sponsored-by: VOKAL Signed-off-by: Josef Moravec Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #264 from Agustín Moyano --- Created attachment 96443 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96443=edit Bug 22284: (follow-up) Default to circulation control branch when no hold libraries are found Signed-off-by: Josef Moravec Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #260 from Agustín Moyano --- Created attachment 96439 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96439=edit Bug 22284: New hold group options in smart-rules This patch adds new options for 'Default checkout, hold and return policy' and 'Default holds policy by item type', both in 'Hold policy' and 'Hold pickup library match' columns To test: 1) Go to 'Circulation and fines rules' in admin 2) Check that there are no options for hold group in 'Hold policy' and 'Hold pickup library match' columns 3) Apply this patch SUCCESS => in 'Hold policy' you should see 'From local hold group' option, and in 'Hold pickup library match' you should see "Item's hold group" 4) Select any of those options and save SUCCESS => options should be selected when page reloads 5) Sign off Sponsored-by: VOKAL Signed-off-by: Tomas Cohen Arazi Signed-off-by: Josef Moravec Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #263 from Agustín Moyano --- Created attachment 96442 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96442=edit Bug 22284: Opac pickup_locations This patch modifies Koha::Libraries->pickup_location and moves most of the logic to Koha::Item and Koha::Biblio in preparation for api endpoints in the future. There where 2 methods added 1) Koha::Item->pickup_locations that given a patron, returns all pickup locations of this item, considering hold fulfillment rules, and hold allowed rules. 2) Koha::Biblio->pickup_locations that given a patron, returns a distinct list of libraries returned by each of this biblio items pickup location. Koha::Libraries->pickup_location analyzes input param and calls Koha::Item->pickup_locations or Koha::Biblio->pickup_locations as needed. Also in opac-reserve.tt the way options where obtained to fill the pickup location select was modified to pass the patron as a parameter. To test: 1) opac: try to place hold on a item and check that all libraries are shown in the pickup location select. 2) intranet: in Library groups, add 2 root groups marked as local hold group and add different libraries to each. 3) opac: login as a user of a library belonging to one hold group, and search try to place a hold on an item belongin to the other hold group. 4) intranet: in Circulation and fines rules, play with 'Hold policy' and 'Hold pickup library match' rules. 5) opac: On each modification of the rules reload the page. SUCCESS => Every time you reload the page, the number of pickup locations showed in select varies. 6) prove t/db_dependent/Koha/Biblios.t t/db_dependent/Koha/Items.t SUCCESS => Result: PASS 7) Sign off Sponsored-by: VOKAL Signed-off-by: Tomas Cohen Arazi Signed-off-by: Josef Moravec Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #261 from Agustín Moyano --- Created attachment 96440 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96440=edit Bug 22284: Control hold groups in C4::Reserves This patch modifies C4::Reserves to control when hold group options where selected in smart rules. In CanItemBeReserved adds 2 new error status messages 1) branchNotInHoldGroup: when a patron's homebranch is not in item's hold group 2) pickupNotInHoldGroup: when a selected pickup location is not in item's hold group Also CheckReserves is modified when item's priority is defined, to control by hold group when required. Finally, IsAvailableForItemLevelRequest was also modified to control by hold group when required. To test: 1) Apply this patch 2) prove t/db_dependent/Holds.t SUCCESS => Result: PASS 3) Sign off Sponsored-by: VOKAL Signed-off-by: Tomas Cohen Arazi Signed-off-by: Josef Moravec Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22284] Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Agustín Moyano changed: What|Removed |Added Attachment #94483|0 |1 is obsolete|| Attachment #94484|0 |1 is obsolete|| Attachment #94485|0 |1 is obsolete|| Attachment #94486|0 |1 is obsolete|| Attachment #94487|0 |1 is obsolete|| Attachment #94488|0 |1 is obsolete|| Attachment #94489|0 |1 is obsolete|| Attachment #94490|0 |1 is obsolete|| Attachment #94491|0 |1 is obsolete|| Attachment #94492|0 |1 is obsolete|| Attachment #94493|0 |1 is obsolete|| Attachment #94494|0 |1 is obsolete|| Attachment #94495|0 |1 is obsolete|| --- Comment #258 from Agustín Moyano --- Created attachment 96437 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96437=edit Bug 22284: New ft_local_hold_group column, and 'holgroup' enum option In order to add groups for holds, this patch provides a new column in library_groups to identify them. Also provides new enum option for hold_fulfillment_policy column of default_branch_circ_rules, default_circ_rules, default_branch_item_rules and branch_item_rules. To test: 1) check that there is no ft_local_hold_group column in library_groups and that there are no 'holdgroup' enum option in hold_fulfillment_policy in default_branch_circ_rules, default_circ_rules, default_branch_item_rules and branch_item_rules 2) apply this patch 3) perl installer/data/mysql/updatedatabase.pl && dbic SUCCESS => !(step 1) ;-D 4) Sign off Sponsored-by: VOKAL Signed-off-by: Tomas Cohen Arazi Signed-off-by: Josef Moravec Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24232] Deleting a bib record after attaching the last item to another bib
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24232 Kelly McElligott changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24232] Deleting a bib record after attaching the last item to another bib
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24232 --- Comment #15 from Kelly McElligott --- Permissions: If staff member has Edit Catalog and Edit Items, this process can be done. If a staff member has Edit Items but not Edit Catalog, they can still attach the item, however the option to delete is not given. If a staff member has only Edit Catalog (and not Edit Items), the option is not there to Attach an Item. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24232] Deleting a bib record after attaching the last item to another bib
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24232 ByWater Sandboxes changed: What|Removed |Added Attachment #96398|0 |1 is obsolete|| --- Comment #14 from ByWater Sandboxes --- Created attachment 96436 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96436=edit Bug 24232: Hide the "Delete biblio" if permission edit_catalogue not set The script moveitem.pl requires editcatalogue => 'edit_items', the deletion of a biblio editcatalogue => edit_catalogue. Even if weird I guess we could have a librarian with edit_items but edit_catalogue. Signed-off-by: Kelly McElligott -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24265] Create a cron job to delete Label Batches after time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24265 Andrew Fuerste-Henry changed: What|Removed |Added CC||and...@bywatersolutions.com --- Comment #1 from Andrew Fuerste-Henry --- Seems like something that would make sense to work into cleanup_database. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24232] Deleting a bib record after attaching the last item to another bib
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24232 ByWater Sandboxes changed: What|Removed |Added Attachment #96393|0 |1 is obsolete|| --- Comment #13 from ByWater Sandboxes --- Created attachment 96435 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96435=edit Bug 24232: Fix required permissions in DELETE /biblios/:biblio_id This patch fixes the required permissions defined on the spec for the mentioned endpoint. To test: 1. Apply the tests patch 2. Run: $ kshell k$ prove t/db_dependent/api/v1/biblios.t => FAIL: Tests fail due to badly defined permissions 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! Notice parameters: edit_catelogue didn't exist 5. Sign off :-D Signed-off-by: Kelly McElligott Signed-off-by: Kelly McElligott -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
