[Koha-bugs] [Bug 24161] Late orders improvements - keeping track of claims

2020-01-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161

Katrin Fischer  changed:

   What|Removed |Added

 QA Contact|katrin.fisc...@bsz-bw.de|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21586] Add generic OpenIDConnect client implementation

2020-01-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21586

--- Comment #10 from David Cook  ---
I don't have plans to work on this at present, but it is an interest of mine,
so if I find myself with spare time, I would work on it (although the OAI-PMH
harvester is a competing albeit much more complex interest).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21586] Add generic OpenIDConnect client implementation

2020-01-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21586

--- Comment #9 from David Cook  ---
Actually, this one would be great to add as an "Authentication Plugin" for
Koha. 

Looking at my code, the only part of it which doesn't lend itself to a plugin
architecture are the changes to Auth.pm and opac-auth.tt. 

However, we could probably remove the necessity for opac-auth.tt changes.

And we could add hooks into Auth.pm for login and logout. Looking at my code,
those shouldn't be that hard to add. 

--

One of the interesting things with this work was setting up multiple OpenID
Connect providers. I'm not sure how often that would actually be a requirement
(as I think people sometimes use another IdP to federate others together) but
it was originally a requirement for my work, and it's something I've seen other
people ask for online. 

--

Really we should be able to use OpenID Connect against Google and any other
compliant IdP (like Keycloak).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20888] Allow use of boolean operator 'not' in item search

2020-01-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20888

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #26 from Katrin Fischer  ---
Hi Matts, have been testing:

+
+   is
+[% IF params.op == 'not like' %]
+   is not
+[% ELSE %]
+   is not
+[% END 

IF = not like... else = not like?

I tested with a custom item search option for "Withdrawn" linked to the
WITHDRAWN authorised value. If I pick "is not" Withdrawn I get the only
withdrawn item. If I pick 'is' withdrawn... I get all the other items. It works
ok on master for the 'is' case.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21586] Add generic OpenIDConnect client implementation

2020-01-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21586

--- Comment #8 from David Cook  ---
This code is out of date, and has a few known problems. However, I have a newer
version, which I actually have working with the Keycloak OpenID Connect
Identity Provider.

For testing purposes, I very easily ran up an instance in Docker
(https://hub.docker.com/r/jboss/keycloak/), and after resolving a bug in my
code, I was able to successfully authenticate and auto-add a patron to Koha. 

It's worth noting that I have used Keycloak for other projects for a while now,
so the server configuration was trivial for me, but it might not be obvious at
a glance. There is lots of documentation though. 

Might also be worth noting that Keycloak is sponsored by Red Hat and forms the
core of RH-SSO, which Red Hat actually uses for all its own AuthN purposes. 

Note that even though I have a new version of the code that works, I'd actually
like to redo my code for this one.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19793] Add a field for email in batch patron modification

2020-01-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19793

--- Comment #17 from Katrin Fischer  ---
(In reply to David Roberts from comment #16)
> Thanks Katrin, I didn't know that. I'll try to do that in future! Thanks for
> QA'ing the patch and for your changes.
> 
> David (apparently AKA Patrick! :-D )

Sorry for that, apparently I was looking at the wrong comments :(

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19793] Add a field for email in batch patron modification

2020-01-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19793

--- Comment #16 from David Roberts  ---
Thanks Katrin, I didn't know that. I'll try to do that in future! Thanks for
QA'ing the patch and for your changes.

David (apparently AKA Patrick! :-D )


(In reply to Katrin Fischer from comment #13)
> Hi Patrick, there are some small things that I've fixed in the patch for you:
> 
> 1) Please make sure your editor uses 4 spaces instead of tabs, tabs are
> forbidden :)
> 
>  FAIL tools/modborrowers.pl
>OK   critic
>FAIL forbidden patterns
>   forbidden pattern: tab char (line 267)
>   forbidden pattern: tab char (line 268)
>   forbidden pattern: tab char (line 269)
>   forbidden pattern: tab char (line 270)
>   forbidden pattern: tab char (line 271)
>   forbidden pattern: tab char (line 272)
> 
> 2) Make sure you include the test plan in your commit message.
> 
> 3) Make sure you start the first line of your commit message with Bug :
> (not - as in bugzilla).
> 
> I'll continue testing and upload the patch later.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24336] Ask for confirmation before deleting a suggestion in the OPAC

2020-01-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24336

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #96809|0   |1
is obsolete||

--- Comment #8 from Katrin Fischer  ---
Created attachment 97649
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97649=edit
Bug 24336: Ask for confirmation before deleting a suggestion in the OPAC

This patch modifies the OPAC suggestions interface so that patrons will
be asked for confirmation before deleting suggestions.

The patch also makes some minor markup changes to improve consistency
between this interface and others in the OPAC.

To test, apply the patch and log in to the OPAC as a user who has
submitted multiple suggestions.

 - From the list of your suggestions, confirm that the "New purchase
   suggestion" and "Delete" links have Font Awesome icons.
 - Check the checkbox corresponding to one of your suggestions. You can
   also now click the title of the suggestions to control the checkbox.
 - When you check a box the "Delete" link at the top of the page should
   activate.
 - Clicking the delete link should trigger a confirmation modal showing
   the title(s) you selected.
   - The message and button labels should reflect whether one or
 multiple titles are being deleted.
   - Test that the confirm and cancel controls work correctly.
 - Also test this process via the delete button at the bottom of the
   table of suggestions.

Signed-off-by: Maryse Simard 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24336] Ask for confirmation before deleting a suggestion in the OPAC

2020-01-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24336

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19793] Add a field for email in batch patron modification

2020-01-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19793

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19793] Add a field for email in batch patron modification

2020-01-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19793

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #97347|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23594] Batch modification for itemtypes on suggestions page

2020-01-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23594

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Patch doesn't apply
 CC||katrin.fisc...@bsz-bw.de

--- Comment #10 from Katrin Fischer  ---
Hi Jonathan, can you please rebase?

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 23594: Batch modification for itemtypes on suggestions page
.git/rebase-apply/patch:345: trailing whitespace.
}  
warning: 1 line adds whitespace errors.
Using index info to reconstruct a base tree...
M   koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt
M   suggestion/suggestion.pl
.git/rebase-apply/patch:345: trailing whitespace.
}  
warning: 1 line adds whitespace errors.
Falling back to patching base and 3-way merge...
Auto-merging suggestion/suggestion.pl
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt
CONFLICT (content): Merge conflict in
koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt
error: Failed to merge in the changes.
Patch failed at 0001 Bug 23594: Batch modification for itemtypes on suggestions
page
The copy of the patch that failed is found in: .git/rebase-apply/patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in
/tmp/Bug-23594-Batch-modification-for-itemtypes-on-sugg-BKdhvf.patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19793] Add a field for email in batch patron modification

2020-01-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19793

--- Comment #15 from Katrin Fischer  ---
Created attachment 97648
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97648=edit
Bug 19793: Change label to match patron record: Primary email

As we have multiple email fields in the patron record, we should
be clear which one can be changed from the batch mod now. Easiest
is to use the same label.

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19793] Add a field for email in batch patron modification

2020-01-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19793

--- Comment #14 from Katrin Fischer  ---
Created attachment 97647
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97647=edit
Bug 19793: Add a field for email in batch patron modification

This adds the email field to the patron batch modification tool.

To test:

1) Install patch
2) Open Batch Patron Modification tool, and input a borrowernumber to edit
3) Add some data (e.g. t...@foobar.com) into the Email address field, and click
Save
4) The Primary Email address in the user record should now contain your email
address
5) Test that running the tool again with the option to delete the data clears
the field correctly
6) Repeat steps 1-5 with a file of user borrowernumbers

Signed-off-by: Sal 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19793] Add a field for email in batch patron modification

2020-01-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19793

Katrin Fischer  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19793] Add a field for email in batch patron modification

2020-01-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19793

--- Comment #13 from Katrin Fischer  ---
Hi Patrick, there are some small things that I've fixed in the patch for you:

1) Please make sure your editor uses 4 spaces instead of tabs, tabs are
forbidden :)

 FAIL   tools/modborrowers.pl
   OK critic
   FAIL   forbidden patterns
forbidden pattern: tab char (line 267)
forbidden pattern: tab char (line 268)
forbidden pattern: tab char (line 269)
forbidden pattern: tab char (line 270)
forbidden pattern: tab char (line 271)
forbidden pattern: tab char (line 272)

2) Make sure you include the test plan in your commit message.

3) Make sure you start the first line of your commit message with Bug :
(not - as in bugzilla).

I'll continue testing and upload the patch later.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19793] Add a field for email in batch patron modification

2020-01-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19793

Katrin Fischer  changed:

   What|Removed |Added

Version|unspecified |master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7468] Add label to batch by barcode range

2020-01-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7468

--- Comment #59 from Katrin Fischer  ---
Created attachment 97646
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97646=edit
Bug 7468: Use Modern::Perl

Just a tiny coding guidelines fix.

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7468] Add label to batch by barcode range

2020-01-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7468

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #97558|0   |1
is obsolete||

--- Comment #58 from Katrin Fischer  ---
Created attachment 97645
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97645=edit
Bug 7468: fix the export labels popup header

When exporting a barcode range, the export popup should display "1 batch
to export" instead of "0 batches to export". In this context, it can be
considered a label batch and should be counted as such.

To test:
When clicking the "Print range" button, the popup should show "1 batch
to export".

Signed-off-by: David Nind 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7468] Add label to batch by barcode range

2020-01-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7468

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #97557|0   |1
is obsolete||

--- Comment #57 from Katrin Fischer  ---
Created attachment 97644
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97644=edit
Bug 7468: (follow-up) Add missing filters

Signed-off-by: David Nind 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7468] Add label to batch by barcode range

2020-01-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7468

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #97556|0   |1
is obsolete||

--- Comment #56 from Katrin Fischer  ---
Created attachment 97643
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97643=edit
Bug 7468: (follow-up) fix label-edit-range template

Edit the labels/label-edit-range.tt template to follow current
standards :
- Use footer javascript
- Use bootstrap grid
- Use jQuery Validation plugin for validation

Also fixes breadcrumbs to be more specific.

To test:
Make sure the page looks correct and still works as expected.

Signed-off-by: David Nind 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7468] Add label to batch by barcode range

2020-01-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7468

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #97555|0   |1
is obsolete||

--- Comment #55 from Katrin Fischer  ---
Created attachment 97642
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97642=edit
Bug 7468: (follow-up) Make sure only integers are accepted as from/to values

Signed-off-by: David Nind 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7468] Add label to batch by barcode range

2020-01-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7468

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #97553|0   |1
is obsolete||

--- Comment #53 from Katrin Fischer  ---
Created attachment 97640
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97640=edit
Bug 7468: Add warning when range has non-existent barcodes

+ Added a warning when the user selects a range with some non-existent
barcodes, and a layout without barcodes.
This allows the user to print barcodes of items not in the database if he so
desires, but will warn him if he tries to print only biblios (which results in
missing entries or a blank page).

Signed-off-by: David Nind 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7468] Add label to batch by barcode range

2020-01-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7468

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #97552|0   |1
is obsolete||

--- Comment #52 from Katrin Fischer  ---
Created attachment 97639
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97639=edit
Bug 7468: Fix 'false' message on Firefox

It seems I was using an href to a javascript function in the 'Print Range'
button, which Chrome didn't mind, but Firefox did understand.

Signed-off-by: David Nind 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7468] Add label to batch by barcode range

2020-01-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7468

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #97554|0   |1
is obsolete||

--- Comment #54 from Katrin Fischer  ---
Created attachment 97641
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97641=edit
Bug 7468: Showing the error message according to the community interface
patterns, fixing a javascript condition

TEST PLAN++

1) Apply all the patches
2) Connect to the intranet with an account with permissions to visit the
"Tools" page
3) Go to /cgi-bin/koha/labels/label-home.pl
. Either by entering the URL directly
. OR, from the front page, by clicking "Tools", followed by the hyperlink
"Label creator" under the "Catalog" section
4) Under the "+ New" button, a new option should be available: "Barcode range"
5) Fill the "From:" and the "To:" fields of the "Print barcode range" form
. Keeping both fields at "0" should trigger a warning beside the first
field: "*Cannot be smaller than 1"
. If the value "From:" is greater the "To:" value, a warning should appear
beside the second field: "*Cannot be smaller than the starting value"
. Make sure the form doesn't let you enter non-numerical values
. For a casual test, use "From: 1000" and "To: 1100"
6) After pressing the "Print Range" button, choose a template, a layout, and a
starting position
. The "DEFAULT TEMPLATE 01" has a page height of 5pt and a page width of
0pt, don't use it
. All the default layouts should look alike, since we're only printing a
barcode over a number, and not bibliographic information
. Using a layout not defined as 'Barcode' will show a warning message
7) Clicking the "Export" button should lead to a second dialog window with a
"Download as PDF" hyperlink. Clicking the link should prop up a download dialog
box
8) Save the PDF locally, or simply open it, and make sure the options you used
were taken into account

Signed-off-by: David Nind 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7468] Add label to batch by barcode range

2020-01-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7468

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #97551|0   |1
is obsolete||

--- Comment #51 from Katrin Fischer  ---
Created attachment 97638
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97638=edit
Bug 7468: Print barcodes by range

Adds an option to the label creator to print a range of barcodes.
Only allows printing to PDF.

C4/Label.pm had to get minor changes to override database-based barcode
generation. Same with labels/label-create-pdf.pl. By default, the
barcode is fetched from the database using the itemnumber, but when
printing ranges, you might not have a corresponding  database entry.

Signed-off-by: David Nind 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7468] Add label to batch by barcode range

2020-01-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7468

Katrin Fischer  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24465] New: Label creator requires catalogue permission instead of label_creator permission from tools

2020-01-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24465

Bug ID: 24465
   Summary: Label creator requires catalogue permission instead of
label_creator permission from tools
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Tools
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org

Checking bug 7468 I noticed that all the templates in labels use the catalogue
permission instead of the expected tools->label_creator permission.

The permission description manages creating labels from patron and catalog
data, so it seems it should be used for the label creator?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 3426] Change itemcallnumber system preference to allow multiple tags

2020-01-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3426

--- Comment #16 from Katrin Fischer  ---
Created attachment 97637
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97637=edit
Bug 3426: Keep note about sequence of subfields

Bug 9156 changed the wording of the pref slightly to make it
clear that the subfield sequence of the record will be used,
not the sequence of the subfields defined in the pref.

This just reinstates the note:
The order of the subfields in the record will be preserved.

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 3426] Change itemcallnumber system preference to allow multiple tags

2020-01-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3426

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #96559|0   |1
is obsolete||

--- Comment #15 from Katrin Fischer  ---
Created attachment 97636
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97636=edit
Bug 3426: Allow for multiple fields in itemcallnumber syspref

Note that we change both cataloguing/additem.pl and
C4/Items->PrepareItemrecordfordisplay

I can find no code that uses callnumber from the C4/Items sub, except for the
itemrecorddisplay script
which is not called with an itemnumber from Koha and should be deprecated for
REST or ILSDI or OAI (imho)

To test:
 1 - Define itemcallnumber syspref as "082ab,092ab,9520,245a"
 2 - Find a record with no items
 3 - Ensure it has no 082 field, but an 092 field
 4 - Go to add an item - itemcallnumber is empty
 5 - Apply patch
 6 - Go to add item, itemcallnumber should be the 092ab fields
 7 - Delete the 092 field
 8 - Go to add item, itemcallnumber should be the 245a
 9 - Edit the callnumber to be "testing" and save item
10 - For should now show itemcallnumber="testing" as default
11 - Browse to
http://localhost:8081/cgi-bin/koha/services/itemrecorddisplay.pl?itemnumber=##
subbing the correct itemnumber
12 - Ensure the callnumber is defaulting to testing
13 - delete the item you created
14 - browse to URL above - callnumber should now be 245 again
15 - Add an 092 field to record and ensure it is now default callnumber
16 - Add an 082 field, it should now be default

Signed-off-by: Andrew Fuerste-Henry 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 3426] Change itemcallnumber system preference to allow multiple tags

2020-01-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3426

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20212] Slowness in Receiving in Acquisitions

2020-01-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #97634|0   |1
is obsolete||

--- Comment #16 from Tomás Cohen Arazi  ---
Created attachment 97635
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97635=edit
[WIP] Bug 20212: Use the API to render orders

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22658] aqbasket.authorisedby is missing a foreign key constraint

2020-01-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22658

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org,
   ||kyle.m.h...@gmail.com,
   ||n...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22658] aqbasket.authorisedby is missing a foreign key constraint

2020-01-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22658

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com

--- Comment #1 from Tomás Cohen Arazi  ---
I propose we create a new column: creator_id INT(11) NULL DEFAULT NULL, with FK
constraint on the borrowers table, and we move/copy there the values of
authorisedby that look like a number. If there's no remaining value on
authorisedby, then drop the column. Otherwise, just leave it and print a
noticeable message about manually removing the column once inconsistencies are
solved.

I haven't found references to the column in contexts in which it is not tested
against the borrowers.borrowernumber column, but there might be old/legacy data
there, or I'm sure Jonathan will find that spot I missed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20212] Slowness in Receiving in Acquisitions

2020-01-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212

--- Comment #14 from Tomás Cohen Arazi  ---
Created attachment 97633
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97633=edit
Bug 20212: Add more embeddable objects to orders

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20212] Slowness in Receiving in Acquisitions

2020-01-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #97630|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20212] Slowness in Receiving in Acquisitions

2020-01-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212

--- Comment #15 from Tomás Cohen Arazi  ---
Created attachment 97634
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97634=edit
[WIP] Bug 20212: Use the API to render orders

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20212] Slowness in Receiving in Acquisitions

2020-01-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #97629|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24464] Add K::A::Basket->creator

2020-01-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24464

--- Comment #1 from Tomás Cohen Arazi  ---
Created attachment 97631
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97631=edit
Bug 24464: Unit tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24464] Add K::A::Basket->creator

2020-01-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24464

--- Comment #2 from Tomás Cohen Arazi  ---
Created attachment 97632
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97632=edit
Bug 24464: Add K::A::Basket->creator

This patch adds a ->creator method to Koha::Acquisition::Basket to
retrieve the related Koha::Patron object.

Note: this should be re-done once 22658 is pushed, but at the time
being, there's not patch submitted, and it is not a trivial task because
of the column type missmatch. That said, the implementation of ->creator
in this class is simple enough to just rewrite it once 22658 is
submitted, and the tests will reflect the expected/unchanged behavior.

To test:
1. Apply this patches
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Acquisition/Basket.t
=> SUCCESS: Tests pass!
3. Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24464] Add K::A::Basket->creator

2020-01-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24464

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com
   |ity.org |
 Depends on||24463
 Blocks||20212


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212
[Bug 20212] Slowness in Receiving in Acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24463
[Bug 24463] Consistent accessor-relationship naming for basket_group in
Basket.pm
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24463] Consistent accessor-relationship naming for basket_group in Basket.pm

2020-01-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24463

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Blocks||24464


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24464
[Bug 24464] Add K::A::Basket->creator
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20212] Slowness in Receiving in Acquisitions

2020-01-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Depends on||24464


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24464
[Bug 24464] Add K::A::Basket->creator
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24464] New: Add K::A::Basket->creator

2020-01-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24464

Bug ID: 24464
   Summary: Add K::A::Basket->creator
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: REST API
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: tomasco...@gmail.com

We need an accessor to fetch the Koha::Patron for the basket creator (a.k.a.
authorisedby on the DB).

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24419] Add Koha::Suggestion->suggester accessor

2020-01-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24419

Martin Renvoize  changed:

   What|Removed |Added

 Version(s)||20.05.00
released in||
 Status|Passed QA   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24419] Add Koha::Suggestion->suggester accessor

2020-01-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24419

--- Comment #8 from Martin Renvoize  ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24418] Add Koha::Biblio->suggestions

2020-01-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24418

--- Comment #12 from Martin Renvoize  ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24418] Add Koha::Biblio->suggestions

2020-01-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24418

Martin Renvoize  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master
 Version(s)||20.05.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24343] Show subtitle, number and parts in course reserves list of titles in staff client

2020-01-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24343

Martin Renvoize  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master
 Version(s)||20.05.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24343] Show subtitle, number and parts in course reserves list of titles in staff client

2020-01-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24343

--- Comment #5 from Martin Renvoize  ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24344] Modify OPAC link to suggest existing record for purchase

2020-01-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24344

--- Comment #4 from Martin Renvoize  ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24344] Modify OPAC link to suggest existing record for purchase

2020-01-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24344

Martin Renvoize  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master
 Version(s)||20.05.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16784] Add table configuration on suggestions table

2020-01-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16784

Martin Renvoize  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master
 Version(s)||20.05.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16784] Add table configuration on suggestions table

2020-01-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16784

--- Comment #11 from Martin Renvoize  ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15686] Rename "item level holds" circ rule column to "OPAC item level holds"

2020-01-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15686

--- Comment #7 from Martin Renvoize  ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15686] Rename "item level holds" circ rule column to "OPAC item level holds"

2020-01-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15686

Martin Renvoize  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master
 Version(s)||20.05.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12502] Add columns for note, order number and ISBN to late orders page

2020-01-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502

--- Comment #51 from Martin Renvoize  ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12502] Add columns for note, order number and ISBN to late orders page

2020-01-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502

Martin Renvoize  changed:

   What|Removed |Added

 Version(s)||20.05.00
released in||
 Status|Passed QA   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22831] Elasticsearch - add a maintenance script for checking DB vs index counts

2020-01-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22831

Martin Renvoize  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com

--- Comment #26 from Martin Renvoize  ---
Haha, I agree.. I would have preferred not to add a new dependancy...
especially as it doesn't appear to be packaged for Jessie (having said that..
we are dropping supoprt for Jessie with 20.05 and this is an enhancement so
that shouldn't be a problem).

However.. I am wondering a little about the code having had a little read.

You seem to do an array_diff and then two more iterations to catch where the
diffs came from.. couldn't you have just done two array_minus calls (from the
same module) to directly get the two different types of problem and saved
yourself a loop and a few lines of code?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23753] Background job JavaScript should not try to call humanMsg library

2020-01-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23753

Cori Lynn Arnold  changed:

   What|Removed |Added

 CC||carn...@dgiinc.com
 Status|Needs Signoff   |Failed QA

--- Comment #2 from Cori Lynn Arnold  ---

I tested these and they worked as expected with the alert:

Tools -> Batch record modification
Tools -> Batch item modification
Tools -> Stage MARC records for import
Tools -> Staged MARC record management

I did *not* get an alert for the following interfaces:

Tools -> Upload local cover image
Circulation -> Upload offline circulation data (but I wasn't giving it a real
file... if it needs a real-ish file, can you provide a test one that I can
manipulate?)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20212] Slowness in Receiving in Acquisitions

2020-01-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212

--- Comment #13 from Tomás Cohen Arazi  ---
Ok, this last version of the patchset completely implements the table. It is
only missing the search boxes which are not trivial to implement. More on that
soon.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20212] Slowness in Receiving in Acquisitions

2020-01-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212

--- Comment #12 from Tomás Cohen Arazi  ---
Created attachment 97630
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97630=edit
[WIP] Bug 20212: Use the API to render orders

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20212] Slowness in Receiving in Acquisitions

2020-01-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212

--- Comment #11 from Tomás Cohen Arazi  ---
Created attachment 97629
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97629=edit
Bug 20212: Add more embeddable objects to orders

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20212] Slowness in Receiving in Acquisitions

2020-01-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #97546|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20212] Slowness in Receiving in Acquisitions

2020-01-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #97547|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24463] Consistent accessor-relationship naming for basket_group in Basket.pm

2020-01-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24463

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24463] Consistent accessor-relationship naming for basket_group in Basket.pm

2020-01-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24463

--- Comment #1 from Tomás Cohen Arazi  ---
Created attachment 97628
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97628=edit
Bug 24463: Add a basket_group relationship for baskets

This patch aims to bring consistency between the accessor name and the
underlying relationship to ease things when using it from the API.

To test:
1. Apply this patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Acquisition/Basket.t
=> SUCCESS: Tests pass! No behavior change!
3. Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24463] Consistent accessor-relationship naming for basket_group in Basket.pm

2020-01-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24463

Tomás Cohen Arazi  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|NEW |ASSIGNED
   Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24463] New: Consistent accessor-relationship naming for basket_group in Basket.pm

2020-01-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24463

Bug ID: 24463
   Summary: Consistent accessor-relationship naming for
basket_group in Basket.pm
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: tomasco...@gmail.com
QA Contact: testo...@bugs.koha-community.org

We agreed there needs to be consistency. This will be a blocker for dealing
with related data from the API (prefetching, filternig, etC).

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20888] Allow use of boolean operator 'not' in item search

2020-01-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20888

Matthias Meusburger  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20888] Allow use of boolean operator 'not' in item search

2020-01-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20888

--- Comment #25 from Matthias Meusburger  ---
Frido, you were right, this change was unnecessary and has been reverted.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20888] Allow use of boolean operator 'not' in item search

2020-01-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20888

--- Comment #24 from Matthias Meusburger  ---
Created attachment 97627
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97627=edit
Bug 20888: Follow-up: revert unecessary change on jquery selector

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20888] Allow use of boolean operator 'not' in item search

2020-01-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20888

--- Comment #23 from Matthias Meusburger  ---
Katrin, here's the modification you asked for: 'is not' now behaves like 'not
like' (just like 'is' behaves like 'like')

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24462] Adjust K::A::Invoice API mapping to voted RFC

2020-01-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24462

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||nicolas.legr...@bulac.fr

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20888] Allow use of boolean operator 'not' in item search

2020-01-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20888

--- Comment #22 from Matthias Meusburger  ---
Created attachment 97626
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97626=edit
Bug 20888: Follow-up: 'is not' operator behaves as 'not like'

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24462] Adjust K::A::Invoice API mapping to voted RFC

2020-01-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24462

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de,
   ||td-koha-b...@agogme.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24462] Adjust K::A::Invoice API mapping to voted RFC

2020-01-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24462

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24462] Adjust K::A::Invoice API mapping to voted RFC

2020-01-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24462

--- Comment #1 from Tomás Cohen Arazi  ---
Created attachment 97624
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97624=edit
Bug 24462: Adapt mapping to voted RFC (Invoices)

This trivial patch changes the attribute names for API reprensentation
of Koha::Acquisition::Invoice objects.

To test:
1. Open https://wiki.koha-community.org/wiki/Acquisitions_invoices_endpoint_RFC
2. Check the mappings are correct
=> SUCCESS: The patch makes the right changes to the mappings
3. Sign off :-D

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23702] New UNIMARC XSLT according to last IFLA updates

2020-01-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23702

--- Comment #22 from delaye  ---
Created attachment 97625
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97625=edit
OPAX -xslt utils

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20212] Slowness in Receiving in Acquisitions

2020-01-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Depends on||24462


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24462
[Bug 24462] Adjust K::A::Invoice API mapping to voted RFC
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18731] Add routes for acquisition orders

2020-01-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Blocks||24462


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24462
[Bug 24462] Adjust K::A::Invoice API mapping to voted RFC
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24462] Adjust K::A::Invoice API mapping to voted RFC

2020-01-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24462

Tomás Cohen Arazi  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Depends on||18731
   Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com
   |ity.org |
URL||https://wiki.koha-community
   ||.org/wiki/Acquisitions_invo
   ||ices_endpoint_RFC
 Status|NEW |Needs Signoff
 Blocks||20212


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731
[Bug 18731] Add routes for acquisition orders
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212
[Bug 20212] Slowness in Receiving in Acquisitions
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24462] New: Adjust K::A::Invoice API mapping to voted RFC

2020-01-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24462

Bug ID: 24462
   Summary: Adjust K::A::Invoice API mapping to voted RFC
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: REST API
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: tomasco...@gmail.com

Now it has been voted, it needs to be adjusted.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24457] K::A::Basket->to_api is not passing the parameters to the parent class implementation

2020-01-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24457

Nicolas Legrand  changed:

   What|Removed |Added

 CC||nicolas.legr...@bulac.fr

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24430] Remove C4::Biblio::CountBiblioInOrders

2020-01-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430

Nicolas Legrand  changed:

   What|Removed |Added

 CC||nicolas.legr...@bulac.fr

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24440] Add ->holds and ->holds_count to Koha::Acquisition::Order

2020-01-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24440

Nicolas Legrand  changed:

   What|Removed |Added

 CC||nicolas.legr...@bulac.fr

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24461] Add to_api_mapping to Koha::Acquisition::BasketGroup

2020-01-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24461

Nicolas Legrand  changed:

   What|Removed |Added

 CC||nicolas.legr...@bulac.fr

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24448] Add Koha::Biblio->subscriptions_count

2020-01-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24448

Nicolas Legrand  changed:

   What|Removed |Added

 CC||nicolas.legr...@bulac.fr

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24461] Add to_api_mapping to Koha::Acquisition::BasketGroup

2020-01-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24461

Tomás Cohen Arazi  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20212] Slowness in Receiving in Acquisitions

2020-01-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Depends on||24461


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24461
[Bug 24461] Add to_api_mapping to Koha::Acquisition::BasketGroup
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24433] OPAC account page no longer asks for confirmation before deleting hold

2020-01-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24433

Martin Renvoize  changed:

   What|Removed |Added

 Version(s)||20.05.00
released in||
 Status|Passed QA   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24461] Add to_api_mapping to Koha::Acquisition::BasketGroup

2020-01-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24461

--- Comment #1 from Tomás Cohen Arazi  ---
Created attachment 97623
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97623=edit
Bug 24461: Add to_api_mapping to Koha::Acquisition::BasketGroup

This patch adds to_api_mapping to the Koha::Acquistion::BasketGroup
class.

To test:
1. Compare the mapping with the one on the RFC
=> SUCCESS: They match
2. Sigh off :-D

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24433] OPAC account page no longer asks for confirmation before deleting hold

2020-01-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24433

--- Comment #4 from Martin Renvoize  ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24423] Broken link to return to record after batch item modification

2020-01-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24423

--- Comment #9 from Martin Renvoize  ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24461] Add to_api_mapping to Koha::Acquisition::BasketGroup

2020-01-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24461

Tomás Cohen Arazi  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com
   |ity.org |
 Blocks||20212


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212
[Bug 20212] Slowness in Receiving in Acquisitions
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24423] Broken link to return to record after batch item modification

2020-01-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24423

Martin Renvoize  changed:

   What|Removed |Added

 Version(s)||20.05.00
released in||
 Status|Passed QA   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24404] Add missing space on invoices page

2020-01-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24404

--- Comment #4 from Martin Renvoize  ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24404] Add missing space on invoices page

2020-01-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24404

Martin Renvoize  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master
 Version(s)||20.05.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24395] Floats in cash registers have 6 decimals

2020-01-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24395

Martin Renvoize  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master
 Version(s)||20.05.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24395] Floats in cash registers have 6 decimals

2020-01-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24395

--- Comment #8 from Martin Renvoize  ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >