[Koha-bugs] [Bug 22543] Patron might be logged in again using browser back button
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22543 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #31 from David Cook --- Just noting that the problem behaviour still persists in the staff client. On one hand, it might not be a problem, because the staff client probably wouldn't be used on a public terminal. On the other hand, a savvy person could impersonate another staff member (e.g. a low privilege user gaining a higher privilege user's session) using this tactic. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22217] error "Connection to the memcached servers '__MEMCACHED_SERVERS__' failed" during install
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22217 --- Comment #3 from David Cook --- (In reply to Tomás Cohen Arazi from comment #2) > This weird warning should be removed. +1 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24495] Reword change collection feature
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24495 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #9 from David Nind --- Note that current master says "Collected from patron" rather than "Collect from patron". I updated the test plan to reflect that, including the system preferences to enable the point of sale feature. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24495] Reword change collection feature
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24495 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24495] Reword change collection feature
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24495 David Nind changed: What|Removed |Added Attachment #98009|0 |1 is obsolete|| --- Comment #8 from David Nind --- Created attachment 98010 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98010=edit Bug 24495: Reword change collection feature This patch changes the text of the "Collected from patron" field to read "Amount tendered" To Test: 0) Enable the point of sale system (EnablePointOfSale + UseCashRegister) 1) In the Point of Sale screen, check that the text inside the "Collect payment" box reads "Collected from patron" 2) Go into a patron record, and create a manual invoice. 3) Go to Make a payment, and select to "Pay an amount". Check the text reads "Collected from patron". 4) Repeat the process with the "Pay Selected", and "Pay" button (listed next to the individual invoice) 5) Install the patch 6) Repeat steps 1-4, but the text should now read "Amount tendered", instead of "Collected from patron" in all payment options in the patron record, and in the Point of Sale screen. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22217] error "Connection to the memcached servers '__MEMCACHED_SERVERS__' failed" during install
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22217 --- Comment #2 from Tomás Cohen Arazi --- This weird warning should be removed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22217] error "Connection to the memcached servers '__MEMCACHED_SERVERS__' failed" during install
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22217 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com Version|18.11 |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23070] Use Koha::Hold in C4::Reserves::RevertWaitingStatus
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23070
--- Comment #9 from Tomás Cohen Arazi ---
(In reply to Martin Renvoize from comment #3)
> (In reply to Jonathan Druart from comment #2)
> > I am missing a DBIx::Class trick to make this better.
>
> If we were not getting rid of being able to call dbic's 'update' routine
> there might be.. though even then I think you'd need to pass some raw sql
> via a scalar ref.. something along the lines
>
> `Koha::Holds->search({ biblionumber => $hold->biblionumber, priority => {
> '>' => 0 } })->update({ priority => \'priority + 1' });`
>
> However, as we're keen to ensure we always go via our 'store' codepath to
> catch triggers then that is the equivalent to having to call ->update_all in
> DBIx::Class::ResultSet world.. which as that triggers a loop internally and
> a db hit per row rather than a db hit for the set then what you've got here
> seems the best we can do.
>
> We could possibly get clever when we work on a solution for our version of
> update and check whether there are triggers in the local store routing and
> either call dbics underlying update directly or manipulate it into a loop
> which calls our store routines much like dbic does for update_all.
I'm leaning towards thinking we shouldn't use a catch-all ->store method, but
an ->insert and an ->update methods... There's a reasoning behind how DBIC does
things... We've gone too far with our use of ->update_or_insert and we end up
having a big IF clause on the more interesting Koha::Object-derived classes, to
detect if it is an update or an insert...
And I also belive many business stuffs should be on the controllers instead. We
are inserting too many things in the DAO (not exactly the pattern, I know) only
to be backwards compatible.
That said, this patches look correct the way our codebase is going forward.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22835] Serve static files from plugins through the API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22835 Tomás Cohen Arazi changed: What|Removed |Added CC||lu...@bywatersolutions.com Keywords|release-notes-needed| --- Comment #26 from Tomás Cohen Arazi --- It applies to the 19.05.x branch! And works! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24495] Reword change collection feature
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24495 David Roberts changed: What|Removed |Added Status|NEW |Needs Signoff --- Comment #7 from David Roberts --- I've now changed the text of the "Collect from patron" box to "Amount tendered" in both the POS and Paycollect pages. No other fields have been altered. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24495] Reword change collection feature
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24495 --- Comment #6 from David Roberts --- Created attachment 98009 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98009=edit Bug 24495: Reword change collection feature This patch changes the text of the "Collect from patron" field to read "Amount tendered" To Test: 1) In the Point of Sale screen, check that the text inside the "Collect payment" box reads "Collect from patron" 2) Go into a patron record, and create a manual invoice. 3) Go to Make a payment, and select to "Pay an amount". Check the text reads "Collect from patron". 4) Repeat the process with the "Pay Selected", and "Pay" button (listed next to the individual invoice) 5) Install the patch 6) Repeat steps 1-4, but the text should now read "Amount tendered", instead of "Collect from patron" in all payment options in the patron record, and in the Point of Sale screen. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24495] Reword change collection feature
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24495 --- Comment #5 from Andrew Fuerste-Henry --- Let's try: - "Total amount payable" - "Amount being paid" - "Amount tendered" - "Change to give" So that's nothing changed except "Collected from patron" changed to "Amount tendered." I talked to other folks here and in all the cases where libraries have gotten confused about this, they just asked us to hide it entirely so we don't have much for specific wording feedback. Thanks for looking at this! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24523] Fix opac-password-recovery markup mistake
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24523 David Roberts changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||david.roberts@ptfs-europe.c ||om --- Comment #3 from David Roberts --- Works OK as per test, as long as the OpacResetPassword system preference is also enabled. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24523] Fix opac-password-recovery markup mistake
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24523 PTFS Europe Sandboxes changed: What|Removed |Added Attachment #98007|0 |1 is obsolete|| --- Comment #2 from PTFS Europe Sandboxes --- Created attachment 98008 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98008=edit Bug 24523: add missing Signed-off-by: David Roberts -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21608] Arranging holds priority with dropdowns is faulty when there are waiting/intransit holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608 Margaret changed: What|Removed |Added Version(s)||18.11.01 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24488] Holds to Pull sometimes shows the wrong 'first patron' details
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24488 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Status|Needs Signoff |Failed QA --- Comment #6 from Katrin Fischer --- Hi Aleisha, I think this is related to bug 21941/bug 17258 - a DBMS version problem. Can you please check? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24495] Reword change collection feature
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24495 --- Comment #4 from David Roberts --- So you are happy with "Amount tendered"? I agree that is normal cash register terminology. What about "Amount due" or "Amount owed" for the other field, or shall we just leave that as it is? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24523] Fix opac-password-recovery markup mistake
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24523 Lucas Gass changed: What|Removed |Added Assignee|oleon...@myacpl.org |lu...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24523] Fix opac-password-recovery markup mistake
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24523
--- Comment #1 from Lucas Gass ---
Created attachment 98007
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98007=edit
Bug 24523: add missing
TEST PLAN:
1. Add this jQuery to OPACUserJS ( $('p:contains("To reset your password, enter
your login or your email address.")').text('I want to change this text'); )
2. Reload the opac-password-recovery page.
3. The text is changed but the rest of the form is now gone
4. Apply patch and reload the opac-password-recovery page.
5. Reload the page and the text should be changed but the form should be there!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23113] members/pay.tt account_grp is not longer used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23113 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24523] Fix opac-password-recovery markup mistake
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24523 Lucas Gass changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24488] Holds to Pull sometimes shows the wrong 'first patron' details
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24488 Aleisha Amohia changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #5 from Aleisha Amohia --- (In reply to Kelly McElligott from comment #4) > Hi Aleisha, > I have done what you have recommended. I am now getting an error when I try > to go to the Holds to Pull report > > DBIx::Class::Storage::DBI::_dbh_execute(): 'koha_hold.reserve.reserve_id' > isn't in GROUP BY at /kohadevbox/koha/Koha/Objects.pm line 130 > at /usr/share/perl5/DBIx/Class/Exception.pm line 77 Hi Kelly, I can't reproduce this error. There might be a problem in your database? Sorry! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23113] members/pay.tt account_grp is not longer used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23113
Katrin Fischer changed:
What|Removed |Added
Attachment #97952|0 |1
is obsolete||
--- Comment #5 from Katrin Fischer ---
Created attachment 98006
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98006=edit
Bug 23113: members/pay.tt account_grp is not longer used
This patch removes obsolete markup from pay.tt.
To test, apply the patch and search the Koha codebase for instances of
"account_grp" There should be none.
Log in to the staff client and go to the account of a patron who has
fines. Confirm that the "Accounting" page ("Make a payment" tab) works
correctly.
Signed-off-by: David Nind
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24523] Fix opac-password-recovery markup mistake
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24523 Lucas Gass changed: What|Removed |Added Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24523] New: Fix opac-password-recovery markup mistake
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24523 Bug ID: 24523 Summary: Fix opac-password-recovery markup mistake Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: lu...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org ON the opac-password-recovery page the paragraph "To reset your password, enter your login or your email address." is missing a closing . This is trivial but it does make it nearly impossible to update or hide that element with jQuery as it will effect the entire form below it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23856] Split author and ISBN/ISSN out of citation in staged MARC record management
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23856 Katrin Fischer changed: What|Removed |Added Attachment #97953|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 98005 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98005=edit Bug 23856: Split author and ISBN/ISSN out of citation in staged MARC record management This patch modifies the way data is passed to the staged MARC record management template, splitting author, ISBN, and ISSN out of the "citation" variable and passing them separately. The DataTables configuration for the staged MARC record management page is modified so that those now-separate variables are conditionally displayed. Unrelated minor change: Added a class to the MARC preview modal so that it displays wider. To test, apply the patch and view the "Staged MARC management" page for both batches of bibliographic records and batches of authority records. In each case the title or authority heading should be displayed as a link while author, ISBN, and ISSN (if any) should not. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23856] Split author and ISBN/ISSN out of citation in staged MARC record management
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23856 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23885] Move staff client search results JavaScript into separate file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23885 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23885] Move staff client search results JavaScript into separate file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23885 Katrin Fischer changed: What|Removed |Added Attachment #97964|0 |1 is obsolete|| --- Comment #5 from Katrin Fischer --- Created attachment 98004 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98004=edit Bug 23885: Move staff client search results JavaScript into separate file This patch moves most of the JavaScript embedded in results.tt into a separate file. The JavaScript that remains on the page is everything which requires processing by Template Toolkit. This is limited to variable definition. To test, apply the patch and perform a catalog search in the staff client. On the results page, test that JavaScript functionality has not been affected: - The search results toolbar should "float" as you scroll - Select all and Clear all - Default search term highlighting; Unhighlight and highlight controls - Adding and removing one or more items from the cart - Adding one or more items to a list - Placing one or more holds my making selections and clicking "Place hold" - Browse selected records - Z39.50 search (search form should be populated with your search terms) - "Show more" and "Show less" links in the facets sidebar - Book cover image services: Amazon, Coce, local covers, etc. - Open a patron record and click "Search to hold" - Perform a search and select one or more results - Test "Place hold" from the hold menu in the toolbar - Test "Place hold for..." from the hold menu in the toolbar - Test "Forget..." from the hold menu in the toolbar - In Tools -> Patron clubs, locate a club with enrolled members - From the "Actions" menu, select "Search to hold" - Perform a search and select one or more results - Test "Place hold" from the hold menu in the toolbar - Test "Place hold for..." from the hold menu in the toolbar - Test "Forget..." from the hold menu in the toolbar Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24521] Usability for cart handling from OPAC search results could be slightly improved
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24521 Katrin Fischer changed: What|Removed |Added Summary|Removing a record from the |Usability for cart handling |cart doesn't remove the |from OPAC search results |(remove) label |could be slightly improved --- Comment #2 from Katrin Fischer --- Another small thing: when scrolling down, the floating toolbar can hide the cart messages. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24522] New: Nothing happens when trying to add nothing to a list in staff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24522 Bug ID: 24522 Summary: Nothing happens when trying to add nothing to a list in staff Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com When no entries are selected in a staff search results list and 'add to list' is used, nothing happens. Try the same in the OPAC and a message "No item was selected" will display. We should have a message for the staff client as well. Note: For better translatability it would be nice to avoid item here - maybe 'search result' or 'record' would work? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24488] Holds to Pull sometimes shows the wrong 'first patron' details
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24488 Aleisha Amohia changed: What|Removed |Added Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24521] Removing a record from the cart doesn't remove the (remove) label
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24521 Katrin Fischer changed: What|Removed |Added Severity|normal |enhancement --- Comment #1 from Katrin Fischer --- Just realized you have to click on the 'remove' part. :) When you click on 'in your cart' the message about items in the cart flashes really quickly. Maybe we could improve the usability a bit? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23885] Move staff client search results JavaScript into separate file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23885 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #4 from Katrin Fischer --- (In reply to David Nind from comment #3) > Created attachment 97970 [details] > Bug 23885: Screenshots of potential problem > > A potential problem identified during testing is placing a hold for a Patron > club. > > This didn’t work for me before the patch was applied as well as when the > patch was applied, so it is either something I did or it is another issue. > > When you select an item with a tick and then try to place a hold for the > Patron Club from the drop down list (screenshot 1 in attachment) you get “No > items are available” (see screenshot 2 in attachment). > > Selecting ‘Place hold for ...’ from the links works fine though. I haven't managed to get the pull down to display when testing without the patch - maybe someone else can give this a try? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24476] Allow patrons to opt-out of Auto-renewal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476 Andrew Fuerste-Henry changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13121] Move search results "action" links ("Place hold, " "Add tag, " etc) into include file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13121
Katrin Fischer changed:
What|Removed |Added
Attachment #97803|0 |1
is obsolete||
--- Comment #9 from Katrin Fischer ---
Created attachment 98003
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98003=edit
Bug 13121: Move search results "action" links ("Place hold," "Add tag," etc)
into include file
This patch moves markup for controls repeated across several OPAC
templates into a single include: Place hold, Request article, Add tag,
Save to lists, and Add to cart.
To test, apply the patch and view the following OPAC pages:
- Search results
- Shelf contents view
- User tags list
On each of these pages all the controls should work correctly:
- Place hold
- Request art
- Add tag
- Save to lists
- Add to cart
Signed-off-by: David Nind
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13121] Move search results "action" links ("Place hold, " "Add tag, " etc) into include file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13121 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13121] Move search results "action" links ("Place hold, " "Add tag, " etc) into include file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13121 --- Comment #8 from Katrin Fischer --- Hi Owen, I am passing this, but it looks like with and without this patch removing a title from the cart no longer works quite right. The (remove) link remains. Also: the cart message is hiding behind the floating toolbar for me. I filed bug 24521. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24521] New: Removing a record from the cart doesn't remove the (remove) label
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24521 Bug ID: 24521 Summary: Removing a record from the cart doesn't remove the (remove) label Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org When adding a record to the cart from the result list, the entry changes to "In your cart (remove)", but clicking on it again doesn't change the label back. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13121] Move search results "action" links ("Place hold, " "Add tag, " etc) into include file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13121 --- Comment #7 from Katrin Fischer --- (In reply to Owen Leonard from comment #6) > (In reply to Katrin Fischer from comment #5) > > forbidden pattern: Contains old bootstrap style for buttons > > (see bug > > It's a false positive. The OPAC still uses the "old bootstrap." The warning > should only be triggered for staff client templates. Thx! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24476] Allow patrons to opt-out of Auto-renewal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476 ByWater Sandboxes changed: What|Removed |Added Attachment #97927|0 |1 is obsolete|| --- Comment #30 from ByWater Sandboxes --- Created attachment 98001 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98001=edit Bug 24476: DO NOT PUSH - Schema updates Signed-off-by: Andrew -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24476] Allow patrons to opt-out of Auto-renewal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476 ByWater Sandboxes changed: What|Removed |Added Attachment #97928|0 |1 is obsolete|| --- Comment #31 from ByWater Sandboxes --- Created attachment 98002 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98002=edit Bug 24476: Add boolean for all TINYINT Signed-off-by: Andrew -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24476] Allow patrons to opt-out of Auto-renewal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476 ByWater Sandboxes changed: What|Removed |Added Attachment #97926|0 |1 is obsolete|| --- Comment #29 from ByWater Sandboxes --- Created attachment 98000 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98000=edit Bug 24476: Allow patrons to opt out of auto-renewal To test: 1 - Verify on staff side that patron can be edited to opt in our out of auto renewal 2 - Check out some items to a patron opted in to auto renewal 3 - Ensure the items are checked out and set to autorenew 4 - Login on the opac at the patron 5 - Verify items cannot be renewed as scheduled for auto-renewal 6 - On staff side, opt patron out of auto renewal 7 - Verify on opac items are no longer marked for auto renewal 8 - Run the auto renewal cron job, items are not renewed 9 - Set 'no renewal before' to a setting that would prevent renewal 10 - Verify that opting patron in or out of auto renewal changes only the reason items cannot be renewed 11 - Set 'no renewal before' to a setting that would allow for renewal 12 - Verify that opting patron in/out changes their ability to renew 13 - Verify that when opted out cron does not renew 14 - Verify that when opted in the item is auto renewed 15 - Reset the due date, opt out, verify manual renewal succeeds Signed-off-by: Andrew -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24476] Allow patrons to opt-out of Auto-renewal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476 ByWater Sandboxes changed: What|Removed |Added Attachment #97925|0 |1 is obsolete|| --- Comment #28 from ByWater Sandboxes --- Created attachment 97999 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97999=edit Bug 24476: Change CanBookBeRenewed and adjust tests Signed-off-by: Andrew -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24476] Allow patrons to opt-out of Auto-renewal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476 ByWater Sandboxes changed: What|Removed |Added Attachment #97924|0 |1 is obsolete|| --- Comment #27 from ByWater Sandboxes --- Created attachment 97998 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97998=edit Bug 24476: API Updates Signed-off-by: Andrew -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24476] Allow patrons to opt-out of Auto-renewal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476 ByWater Sandboxes changed: What|Removed |Added Attachment #97923|0 |1 is obsolete|| --- Comment #26 from ByWater Sandboxes --- Created attachment 97997 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97997=edit Bug 24476: Database updates Signed-off-by: Andrew -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24476] Allow patrons to opt-out of Auto-renewal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476 --- Comment #25 from Andrew Fuerste-Henry --- New test plan: 1 - Set loan period and No Renewal Before such than an item is eligable for renewal immediately upon checkout 2 - Check out an item to a patron opted in to auto renewal 3 - Ensure the item is checked out and set to autorenew 4 - Opt patron out of auto-renew 5 - Verify that patron's checkout now shows as available for manual renewal 6 - Make sure OpacRenewalAllowed is set to Allow and "autorenewal" is not in PatronSelfModificationBorrowerUnwantedField 7 - Login on the opac at the patron 8 - Verify checkout shows as available for manual renewal 9 - Verify you can submit change request from OPAC to opt patron in to auto-renew 10 - Find change request on intranet, verify it shows change to autorenew opt-in, accept change request 11 - Reload patron summary on OPAC, verify it now shows checkout is scheduled for auto-renewal 12 - On staff side, opt patron out of auto-renew 13 - Run misc/cronjobs/automatic_renewals.pl, verify item is not renewed 14 - Manually renew item from the intranet 15 - Manually renew item from the OPAC 16 - Opt patron in for auto-renew 17 - Run misc/cronjobs/automatic_renewals.pl, verify item is renewed 18 - Set No Renewal Before value so item is no longer eligable for renewal 19 - Verify intranet and OPAC still show checkout scheduled for auto-renewal 20 - Opt patron out of auto-renew 21 - Verify intranet and OPAC show checkout ineligible for manual renewal due to No Renewal Before 22 - Opt patron in to auto-renew 22 - Add "autorenewal to PatronSelfModificationBorrowerUnwantedField and BorrowerUnwantedField 23 - Confirm patron can no longer be opted out of auto-renew on intranet or OPAC -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22690] Merging records with many items too slow (Elasticsearch)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22690 --- Comment #17 from Michal Denar --- Hi Ere, prove t/db_dependent/Koha/Item.t: not ok 3 - Value is mapped correctly for column biblionumber # Failed test 'Value is mapped correctly for column biblionumber' # at t/db_dependent/Koha/Item.t line 109. # got: undef # expected: '462' not ok 4 - Value is mapped correctly for column biblioitemnumber # Failed test 'Value is mapped correctly for column biblioitemnumber' # at t/db_dependent/Koha/Item.t line 109. # got: undef # expected: '461' not ok 28 - Value is mapped correctly for column timestamp # Failed test 'Value is mapped correctly for column timestamp' # at t/db_dependent/Koha/Item.t line 109. # got: undef # expected: '2020-01-24 22:23:22' not ok 42 - Value is mapped correctly for column biblionumber # Failed test 'Value is mapped correctly for column biblionumber' # at t/db_dependent/Koha/Item.t line 124. # got: undef # expected: '462' not ok 67 - Value is mapped correctly for column timestamp # Failed test 'Value is mapped correctly for column timestamp' # at t/db_dependent/Koha/Item.t line 124. # got: undef # expected: '2020-01-24 22:23:22' # Looks like you failed 6 tests of 79. not ok 3 - as_marc_field() tests It's problem with my mappings? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24269] Authority matching in Elasticsearch is broken when authority has subdivisions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24269 --- Comment #7 from Nick Clemens --- (In reply to Martin Renvoize from comment #4) > Comment on attachment 97982 [details] [review] > Bug 24269: Adjust C4::Heading to generate headings from auth tags > > Review of attachment 97982 [details] [review]: > - > > ::: C4/Heading.pm > @@ +52,5 @@ > > > > Given a C object containing a heading from a > > bib record, create a C object. > > > > +The optional third parameter is 'auth' - it is handled as boolean. If > > supplied we treat the field as an auth record field. Otherwise if it is a > > bib field. The fields checked are the same in a UNIMARC system and this > > parameter is ignored > > I'm not sure I understand this rewording.. you've removed the > '$marc_flavour' param right, and instead, always use the application > context? I think this could be more clearly worded. I did, I didn't mention it in the POD, meant to mention in the commit message - we had that option, but it was never used and I didn't see a reason to preserve it -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24269] Authority matching in Elasticsearch is broken when authority has subdivisions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24269 Nick Clemens changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 --- Comment #64 from Tomás Cohen Arazi --- About the timestamp handling: shouldn't we better implement Koha::Object->set_and_store of similar, that instead of overwriting the whole object, just sets the really changed fields, and we leave the DB do the heavy lifting? It looks wrong (as you also say, Jonathan) to be setting the timestamp manually on the ->store method (be it in the Koha::Item class, or as a generic approach in Koha::Object) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10869] Can't cancel order line if title deleted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869 Martin Renvoize changed: What|Removed |Added Keywords||RM_priority -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10869] Can't cancel order line if title deleted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869 Martin Renvoize changed: What|Removed |Added Keywords||additional_work_needed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10869] Can't cancel order line if title deleted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com QA Contact|paul.poul...@biblibre.com |testo...@bugs.koha-communit ||y.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23915] Replace OPAC list sort menu with Bootstrap menu button
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23915 --- Comment #5 from David Nind --- Everything looks and works fine except for the sort by copyright date. - Copyright date (newest to oldest): sorts as asc when it should be desc (for example, lists an 1875 item before 2009) - Copyright date (oldest to newest): sorts as desc when it should be asc (for example, lists an 2009 item before 1875) It looks like this was introduced by Bug 23913 - the above behaviour is in master, but not in 19.11.x. Should this be fixed in this bug, or should it be a new bug? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24269] Authority matching in Elasticsearch is broken when authority has subdivisions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24269 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #6 from Martin Renvoize --- Signing off as this logically all makes sense, the tests pass and it passes it's test plan. Minor comment about rewording the updated POD slightly as it's not entirely clear without reading the code. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24269] Authority matching in Elasticsearch is broken when authority has subdivisions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24269 Martin Renvoize changed: What|Removed |Added Attachment #97982|0 |1 is obsolete|| --- Comment #5 from Martin Renvoize --- Created attachment 97996 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97996=edit Bug 24269: Adjust C4::Heading to generate headings from auth tags To test: 1 - Be using Elasticsearch 2 - Check that field 150 is mapped to 'Match-heading' or add it (the subfields don't matter) 3 - Add a topic term authority record like "150 $aCats$vFiction" 4 - Add a 650 with $aCats and $vFiction and $e depicted to a bibliographic record 5 - Run the linker for the bib perl misc/link_bibs_to_authorities.pl --bib-limit "biblionumber=89" -v 6 - Confirm the record is not correctly linked to the record 7 - Apply patch 8 - Reindex authorities for ES perl misc/search_tools/rebuild_elasticsearch.pl -v -d -a 9 - Run the linker and confirm record is correctly linked perl misc/link_bibs_to_authorities.pl --bib-limit "biblionumber=89" -v Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24269] Authority matching in Elasticsearch is broken when authority has subdivisions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24269 --- Comment #4 from Martin Renvoize --- Comment on attachment 97982 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97982 Bug 24269: Adjust C4::Heading to generate headings from auth tags Review of attachment 97982: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=24269=97982) - ::: C4/Heading.pm @@ +52,5 @@ > > Given a C object containing a heading from a > bib record, create a C object. > > +The optional third parameter is 'auth' - it is handled as boolean. If > supplied we treat the field as an auth record field. Otherwise if it is a bib > field. The fields checked are the same in a UNIMARC system and this parameter > is ignored I'm not sure I understand this rewording.. you've removed the '$marc_flavour' param right, and instead, always use the application context? I think this could be more clearly worded. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24516] Column Configuration does not hide Return Date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24516 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #1 from Lucas Gass --- I cannot reproduce this in master now. I believe the problem was solved by bz24515. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24485] Sys Pref AllowHoldPolicyOverride will not Staff override a Holds Per Record Rule
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24485 Andrew Fuerste-Henry changed: What|Removed |Added CC||and...@bywatersolutions.com ||, n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13420] Holdings table sorting on volume information incorrect
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13420 Martin Renvoize changed: What|Removed |Added Attachment #92026|0 |1 is obsolete|| --- Comment #24 from Martin Renvoize --- Created attachment 97995 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97995=edit Bug 13420: Fallback to the previous behavior if published date is not used Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13420] Holdings table sorting on volume information incorrect
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13420 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||martin.renvoize@ptfs-europe ||.com --- Comment #25 from Martin Renvoize --- This works as described and seems a suitable interim solution to me.. Signing off. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13420] Holdings table sorting on volume information incorrect
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13420 Martin Renvoize changed: What|Removed |Added Attachment #88995|0 |1 is obsolete|| --- Comment #23 from Martin Renvoize --- Created attachment 97994 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97994=edit Bug 13420: Sort "Serial enumeration" by published date So far the sorting on volume information is incorrect. It sorts by the string displayed in the cell, which may not have any logics. A better solution would be to use Kyle's suggestion, see comments 7, 8, but it will need much more work. This patch suggests to use the publication date to sort this column. Note: In the code there is a switch depending on the existence of items.publisheddate, but I do not think it is valid, this valid should always exist if the item is received (did I miss something?) Test plan: You need to have different existing subscription, using different numbering. On the detail page of the bibliographic record you should be able to sort the serials (tab "Holdings") by "Serial enumeration". The sort will now use the publication dates. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds on them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 --- Comment #43 from Martin Renvoize --- Still testing this Kelly? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18532] AUTO_RENEWALS should be a patron messaging preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 --- Comment #24 from Agustín Moyano --- Sorry, I was almost abducted by another (evil) bug. I'll remove those lines from atomicupdate ASAP, so this can move forward. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24348] Record matching rules: required match checks does not work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24348 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Status|Needs Signoff |Signed Off --- Comment #4 from Martin Renvoize --- Works as expected, signing off.. it would be great to see an accompanying regression test though. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24348] Record matching rules: required match checks does not work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24348 Martin Renvoize changed: What|Removed |Added Attachment #96825|0 |1 is obsolete|| --- Comment #3 from Martin Renvoize --- Created attachment 97993 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97993=edit Bug 24348: Pass marc record to _passes_required_checks Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23128] Missing Net::OAuth2::AuthorizationServer dependency
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23128 --- Comment #9 from Martin Renvoize --- https://meetings.koha-community.org/2019/development_irc_meeting_26_june_2019.2019-06-26-19.00.html -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24361] Fix warnings (or failing tests) from bug 24217
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24361 --- Comment #11 from Martin Renvoize --- Bug 24361: Silent t/db_dependent/Items.t pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23673] Separate time sent from time created in message_queue table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23673 --- Comment #17 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #16) > (In reply to Agustín Moyano from comment #14) > > Hi Jonathan > > > > > 1. Should not we have the new column with the "default CURRENT_TIMESTAMP > > > on > > > update CURRENT_TIMESTAMP" clause in order to delegate the update of this > > > value to the DBMS? > > > > Mysql doesn't accept a table with 2 columns with "default > > CURRENT_TIMESTAMP".. there can be only one. > > Hola Agustín, Yes I know and that's why I suggested to have it on the new > column :) > > Take a look at library_groups or borrowers tables for instance. Note that > article_requests does the reverse. You mean making the 'time_queued' column TIMESTAMP DEFAULT NULL (and so making us set it manually), and making 'updated_on' be the one with the trigger? (so we don't do the update manually?). I'm fine with either. Just trying to clarify so we move this forward. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24476] Allow patrons to opt-out of Auto-renewal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476 Phil Ringnalda changed: What|Removed |Added CC||p...@chetcolibrary.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18532] AUTO_RENEWALS should be a patron messaging preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 Phil Ringnalda changed: What|Removed |Added CC||p...@chetcolibrary.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271
--- Comment #195 from Tomás Cohen Arazi ---
(In reply to Jonathan Druart from comment #193)
> Note for myself:
>
> * comment 182
>
> * comment 183
>
> * comment 184
>
> * deal with reports
This should be done using DB views. What is the 'deleted' column name we
picked?
> * my $item_object = Koha::Items->find({barcode => $barcode });
> => We need to remove the barcode unique index
We need to rely on the DB to handle barcode uniqueness... we should move the
barcode to another column, say... deleted_barcode.
> * Prevent regression and deal with Koha::Items->find Koha::Items->search
> Ideas:
> - ->find returns only non-deleted items when ->find_deleted returns only
> deleted items
> - same for ->search, ->search_deleted
>
> Or keep Koha::Old::Items that could inherit from Koha::Items
>
> Or update all the occurrences (how many?)
On the API I would expect the endpoint to return non-deleted ones as default,
and I would prefer to handle it explicitly: manually adding deleted => 0 to the
query. And have ?include_deleted=true and/or ?deleted=true be mandatory to get
the deleted ones.
Maybe we could encapsulate this pattern in Koha::Objects::Deleted, which
extended Koha::Objects with new generic methods: ->search_without_deleted
I haven't made up my mind yet, but I feel it smells to have ->search have a
weird behaviour other than the expected.
I'm also worried how we would handle:
my $items = $biblio->items;
so it doesn't return deleted ones.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 Jonathan Druart changed: What|Removed |Added Attachment #76513|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 Jonathan Druart changed: What|Removed |Added Attachment #76511|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 Jonathan Druart changed: What|Removed |Added Attachment #76509|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 Jonathan Druart changed: What|Removed |Added Attachment #76512|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 Jonathan Druart changed: What|Removed |Added Attachment #76510|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 Jonathan Druart changed: What|Removed |Added Attachment #76514|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 Jonathan Druart changed: What|Removed |Added Attachment #76504|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 Jonathan Druart changed: What|Removed |Added Attachment #76505|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 Jonathan Druart changed: What|Removed |Added Attachment #76508|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 Jonathan Druart changed: What|Removed |Added Attachment #76503|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 Jonathan Druart changed: What|Removed |Added Attachment #76506|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 Jonathan Druart changed: What|Removed |Added Attachment #76507|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 Jonathan Druart changed: What|Removed |Added Attachment #76501|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 Jonathan Druart changed: What|Removed |Added Attachment #76502|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 Jonathan Druart changed: What|Removed |Added Attachment #76498|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 Jonathan Druart changed: What|Removed |Added Attachment #76499|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 Jonathan Druart changed: What|Removed |Added Attachment #76500|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 Jonathan Druart changed: What|Removed |Added Attachment #76494|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 Jonathan Druart changed: What|Removed |Added Attachment #76495|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 Jonathan Druart changed: What|Removed |Added Attachment #76493|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 Jonathan Druart changed: What|Removed |Added Attachment #76496|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 Jonathan Druart changed: What|Removed |Added Attachment #76497|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 Jonathan Druart changed: What|Removed |Added URL||https://gitlab.com/joubu/Ko ||ha/commits/bug_20271 --- Comment #194 from Jonathan Druart --- Up-to-date patches are on https://gitlab.com/joubu/Koha/commits/bug_20271 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271
--- Comment #193 from Jonathan Druart
---
Note for myself:
* comment 182
* comment 183
* comment 184
* deal with reports
* my $item_object = Koha::Items->find({barcode => $barcode });
=> We need to remove the barcode unique index
* Prevent regression and deal with Koha::Items->find Koha::Items->search
Ideas:
- ->find returns only non-deleted items when ->find_deleted returns only
deleted items
- same for ->search, ->search_deleted
Or keep Koha::Old::Items that could inherit from Koha::Items
Or update all the occurrences (how many?)
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24490] Clarify wording and function of Purchase Items link on POS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24490 ByWater Sandboxes changed: What|Removed |Added Attachment #97985|0 |1 is obsolete|| --- Comment #17 from ByWater Sandboxes --- Created attachment 97992 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97992=edit Bug 24490: Clarify wording and function of Purchase Items link on POS This patch changes the wording of the links on the POS side menu To test: 1) Apply the patch 2) Check that the links on the left hand side of the screen read "Configure cash registers" and "Configure items for purchase" 3) Click both links to ensure you are taken to the relevant config pages. Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24490] Clarify wording and function of Purchase Items link on POS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24490 Andrew Fuerste-Henry changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #18 from Andrew Fuerste-Henry --- Ok, actually signing off this time. Thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24361] Fix warnings (or failing tests) from bug 24217
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24361 --- Comment #10 from Jonathan Druart --- Created attachment 97991 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97991=edit Bug 24361: Silent t/db_dependent/Items.t its output is displaying tons of Use of uninitialized value $field in regexp compilation at /kohadevbox/koha/C4/Items.pm line 2106. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
