[Koha-bugs] [Bug 24527] misc/cronjobs/update_totalissues.pl problem with multiple items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24527 anne-cecile.bor...@iepg.fr changed: What|Removed |Added CC||anne-cecile.bor...@iepg.fr -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 Katrin Fischer changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=9011, ||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=14945 --- Comment #75 from Katrin Fischer --- I guess what I was trying to say is that this was designed to fall out of sync with the other tables - so we should not break that use case and allow for separate treatment of both. Added see also the bugs with former discussion. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Katrin Fischer changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=23260 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14945] Add the ability to store the last patron to return an item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14945 Katrin Fischer changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=23260 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #74 from Katrin Fischer --- When the option to store the last patron was introduced separately from the normal reading history feature, I was quite happy as it would allow us to keep that information, without necessarily keeping all the history. What libraries often ask for is to know the last person that checked out an item, in case they have missed damage on return (like it can happen in times of self checks). In my opinion, by synching those with no option to not delete both at the same time - we make the StoreLastPatron obsolete. We could always have used the other tables to retrieve the information, but it was added with a new table as a separate thing with the reasoning of avoiding automatic anonymization. See the bug description from the initial feature add (bug 14945): "Currently if the AnonymousPatron system preference is in use, all patron data is anonymized. Some libraries would like to be able to see the last patron who returned out an item ( in case of damage ) but still keep all other patrons anonymized." -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23425] Search explodes with "invalid data, cannot decode object"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23425 Katrin Fischer changed: What|Removed |Added Blocks||24574 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24574 [Bug 24574] Broken MARC records cause "invalid data, cannot decode object" on ISBDdetail and MARCdetail pages. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24574] Broken MARC records cause "invalid data, cannot decode object" on ISBDdetail and MARCdetail pages.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24574 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Depends on||23425 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23425 [Bug 23425] Search explodes with "invalid data, cannot decode object" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9993] On editing basket group delivery place resets to logged in library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9993 Katrin Fischer changed: What|Removed |Added Summary|On editing basket group |On editing basket group |delivery place resets to|delivery place resets to |logged in branch|logged in library -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9993] On editing basket group delivery place resets to logged in branch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9993 Katrin Fischer changed: What|Removed |Added Attachment #98269|0 |1 is obsolete|| --- Comment #10 from Katrin Fischer --- Created attachment 98364 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98364=edit Bug 9993: On editing basket group delivery place resets to logged in branch This patch modifies basketgroups.pl so that existing data about a basket group's billing and delivery place are correctly preselected in the edit form. These fields shouldn't reset to the logged-in user's home branch just because they have an empty value. To test, apply the patch and go to Acquisitions -> Vendor -> Basket groups. When adding or editing a basket group the pre-selected value for "Billing place" and "Delivery place" should be correct: - When creating a new basket group: The logged-in user's library should be pre-selected. - When editing a basket group which has a library defined for either the billing or delivery places, the correct library should be pre-selected. - When editing a basket group which has no library defined for either the billing or delivery place there should be no library pre-selected (the "--" option should be pre-selected). Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9993] On editing basket group delivery place resets to logged in branch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9993 --- Comment #11 from Katrin Fischer --- Reported this in 2013 - so happy to see it fixed! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9993] On editing basket group delivery place resets to logged in branch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9993 Katrin Fischer changed: What|Removed |Added Patch complexity|Trivial patch |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24573] Catmandu::Store::ElasticSearch and Catmandu::MARC are missing from PerlDependencies.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24573 Julian Maurice changed: What|Removed |Added Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10879] OverDrive should check for OverDriveLibraryID before performing search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10879 --- Comment #4 from Katrin Fischer --- Trusting Owen and Lucas to have tested with OverDrive - small template change, reads well, should have no side effects. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10879] OverDrive should check for OverDriveLibraryID before performing search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10879 Katrin Fischer changed: What|Removed |Added Attachment #98191|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 98363 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98363=edit Bug 10879: OverDrive should check for OverDriveLibraryID before performing search This patch modifies the OPAC search results template to check for three populated system preferences before performing an OverDrive search: OverDriveLibraryID, OverDriveClientKey, and OverDriveClientSecret. Previously OverDriveLibraryID was not checked, but without it the interface reports an error performing the search. To test you must have credentials for the OverDrive API as defined in OverDriveClientKey, OverDriveClientSecret, and OverDriveLibraryID system preferences. - With OverDriveLibraryID defined, the catalog search results page in the OPAC should show a link to results in the library's OverDrive collection. - With no value in the OverDriveLibraryID preference the catalog search page should not show any message about an OverDrive collection. Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10879] OverDrive should check for OverDriveLibraryID before performing search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10879 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24560] Don't show "Public Lists" in OPAC List menu if no public lists exist
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24560 Martin Renvoize changed: What|Removed |Added Severity|enhancement |minor CC||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24560] Don't show "Public Lists" in OPAC List menu if no public lists exist
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24560 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #8 from Katrin Fischer --- Hi Lucas, please make sure that you include a description of the problem and a test plan in your commit messages - I've fixed it this time around :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24574] New: Broken MARC records cause "invalid data, cannot decode object" on ISBDdetail and MARCdetail pages.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24574 Bug ID: 24574 Summary: Broken MARC records cause "invalid data, cannot decode object" on ISBDdetail and MARCdetail pages. Change sponsored?: --- Product: Koha Version: 19.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: rudolfby...@gmail.com QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl Broken MARC records cause "invalid data, cannot decode object" on ISBDdetail and MARCdetail pages. Although this is fixed on the /cgi-bin/koha/catalogue/detail.pl page (see Bug #23425 ), it's still not handled gracefully on these pages: /cgi-bin/koha/catalogue/ISBDdetail.pl /cgi-bin/koha/catalogue/MARCdetail.pl Use case: Some of our staff have to update books. They use "cataloging search", enter the barcode, then click the title of the book. This takes them directly to the MARCdetail page. To fix the MARC data, they need to work around the problem by editing the URL and replacing "MARCdetail.pl" with "detail.pl". Since most of our staff is not very technically apt, this is a problem. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24560] Don't show "Public Lists" in OPAC List menu if no public lists exist
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24560 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24560] Don't show "Public Lists" in OPAC List menu if no public lists exist
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24560 Katrin Fischer changed: What|Removed |Added Attachment #98350|0 |1 is obsolete|| --- Comment #7 from Katrin Fischer --- Created attachment 98362 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98362=edit Bug 24560: Remove No public list text from OPAC On the OPAC, the dropdown for Lists always includes the heading Public Lists, even if no public lists exist. This is sub-optimal for libraries that want VirtualShelves enabled for private lists but don't want to use public lists. TEST PLAN: 1. have no public list and look at the List dropdown on the OPAC. It says No Public Lists. 2. Apply patch 3. It should now not say anything about public lists but still be formatted nice. 4. Add some public lists and confirm that everything looks normal. 5. Sign off Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24573] Catmandu::Store::ElasticSearch and Catmandu::MARC are missing from PerlDependencies.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24573 Julian Maurice changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24573] Catmandu::Store::ElasticSearch and Catmandu::MARC are missing from PerlDependencies.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24573 --- Comment #1 from Julian Maurice --- Created attachment 98361 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98361=edit Bug 24573: Add missing dependencies to PerlDependencies.pm Catmandu::Store::ElasticSearch is required for search, and Catmandu::MARC is required for indexation The `max_ver` for Catmandu::Store::ElasticSearch is only informative and is not used anywhere. Koha is not compatible with Catmandu::Store::ElasticSearch 0.9_01 and later versions -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24573] New: Catmandu::Store::ElasticSearch and Catmandu::MARC are missing from PerlDependencies.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24573 Bug ID: 24573 Summary: Catmandu::Store::ElasticSearch and Catmandu::MARC are missing from PerlDependencies.pm Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: julian.maur...@biblibre.com QA Contact: testo...@bugs.koha-community.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23533] Reindent patron entry form (memberentrygen.tt)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23533 Katrin Fischer changed: What|Removed |Added Attachment #98190|0 |1 is obsolete|| --- Comment #14 from Katrin Fischer --- Created attachment 98360 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98360=edit Bug 23533: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the interface or functionality. https://bugs.koha-community.org/show_bug.cgi?id=23533 Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23533] Reindent patron entry form (memberentrygen.tt)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23533 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23533] Reindent patron entry form (memberentrygen.tt)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23533 Katrin Fischer changed: What|Removed |Added Attachment #98189|0 |1 is obsolete|| --- Comment #13 from Katrin Fischer --- Created attachment 98359 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98359=edit Bug 23533: Reindent patron entry form (memberentrygen.tt) This patch re-indents the template for patron entry/editing. It makes only whitespace changes. It should have no effect on the behavior of the page. To test, create or edit a patron. Test every aspect of the process. At each step the page should work correctly. Including: - Adult patron - Child patron - Organizational patron - Quick patron add - Duplicate patron - With mandatory fields - With 'BorrowerUnwantedField's defined - With ExtendedPatronAttributes enabled Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24530] Show a number in title notes just as in the other tabs of opac detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24530 --- Comment #5 from Marcel de Rooy --- (In reply to David Nind from comment #3) > Signed-off-by: David Nind Thanks -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24490] Clarify wording and function of Purchase Items link on POS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24490 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |String patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24490] Clarify wording and function of Purchase Items link on POS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24490 Katrin Fischer changed: What|Removed |Added Attachment #97992|0 |1 is obsolete|| --- Comment #19 from Katrin Fischer --- Created attachment 98358 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98358=edit Bug 24490: Clarify wording and function of Purchase Items link on POS This patch changes the wording of the links on the POS side menu To test: 1) Apply the patch 2) Check that the links on the left hand side of the screen read "Configure cash registers" and "Configure items for purchase" 3) Click both links to ensure you are taken to the relevant config pages. Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24279] Claims Returned does not work when set from moredetail.pl or additem.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24279 Katrin Fischer changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24200] Borrower_PrevCheckout.t failing randomly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24200 Joy Nelson changed: What|Removed |Added Version(s)|20.05.00, 19.11.03 |20.05.00 released in|| --- Comment #8 from Joy Nelson --- Reverted from 19.11.03 until fixed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7660] Enhanced messaging preferences are not set when creating a child patron from the adult
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7660 Michelle Carrillo changed: What|Removed |Added CC||mcarri...@roseville.ca.us -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14697] Extend and enhance "Claims returned" lost status
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14697 Agnes Rivers-Moore changed: What|Removed |Added CC||a...@hanover.ca --- Comment #78 from Agnes Rivers-Moore --- Maybe this Wiki entry could be updated, or deleted? https://wiki.koha-community.org/wiki/Claimed_Returned_RFC -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24572] Add books from mysql manually
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24572 Katrin Fischer changed: What|Removed |Added Resolution|--- |INVALID CC||katrin.fisc...@bsz-bw.de Status|NEW |RESOLVED --- Comment #1 from Katrin Fischer --- Hi, Koha needs a full valid and well-formed MARC record in metadata (depends on version), I think you'd have much more 'fun' with getting records into Koha using the build in import tools like staged marc impord or bulkmarcimport.pl or one of the available APIs. Doing things on SQL level you run at a high risk of missing things or importing things that won't fit your configuration later on - like the mappings in your frameworks and keyword to MARC mappings. And as you need a full MARC record in any case, there is no advantage to using SQL over the other available options. For more help/discussion, please ask on the mailing list - the bug tracker is read only by a few and should be only used for enhancement requests and bugs. koha-devel is read by most of the developers: https://koha-community.org/support/koha-mailing-lists/ -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24203] overduerules.pl does not work with bug 20436
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24203 --- Comment #7 from Andrew Fuerste-Henry --- Hi y'all. The long overdue cronjob and the overdue notice system are two fundamentally disconnected things in Koha. However, it's been standard practice with ByWater partners to use the third overdue notice to alert patrons to the replacement charge generated by the long overdue cron. That already presented some issues based on holidays. As Christopher points out, Bug 20436 moves the potential behavior of the long overdue cron further away from the rather inflexible behavior of the overdue notices. If we want to maintain our practice of using the third overdue notice to alert patrons to the charges generated by the long overdue cronjob, then we need to do some work to make the two processes able to line up better. That would mean teaching the overdues to differ by item type and also teaching the long overdue cron to skip holidays (again, bug 18064. However, the new patron_emailer cron cron could be used to send a notice about items impacted by the long overdue cron without involving the overdues process at all. I'd suggest that approach at least as a short term answer (if not as an alternative to this bug entirely). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24568] Allow selection of multiple authorised values in runtime parameters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24568 --- Comment #2 from Andrew Fuerste-Henry --- Ahha! Thanks! That seemed like something that would have already been filed but I couldn't find it. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16002] MULTI choices in report dropdowns
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16002 Katrin Fischer changed: What|Removed |Added CC||and...@bywatersolutions.com --- Comment #4 from Katrin Fischer --- *** Bug 24568 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24568] Allow selection of multiple authorised values in runtime parameters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24568 Katrin Fischer changed: What|Removed |Added Resolution|--- |DUPLICATE Status|NEW |RESOLVED CC||katrin.fisc...@bsz-bw.de --- Comment #1 from Katrin Fischer --- Hi Andrew, I think this is a duplicate to bug 16002 - please unlink if I am mistaken. *** This bug has been marked as a duplicate of bug 16002 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24203] overduerules.pl does not work with bug 20436
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24203 --- Comment #6 from Katrin Fischer --- Are we maybe talking about different things? For me 'long overdue' refers to the longoverdue.pl cronjob and the system preferences available for it. Overdues and notice triggers refer to the overdue_notices.pl cronjob. Both jobs have different functionality and different options available to them and are not tied together. I meant instead of changing how the overdue_notices work, enhance the longoverdue process by adding more configuration options in the interface. Maybe a second table like the one already on the overdues page, but instead having the "delay" tabs, the tabs would refer to different itemtypes. Or: - pages for libraries - tabs for delays - An option to add new rules to the notice triggers with an adiditional column for itemtype - A new checkbox at the end to set the long overdue status -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24516] Column Configuration does not hide Return Date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24516 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #4 from David Nind --- (In reply to Lucas Gass from comment #1) > I cannot reproduce this in master now. I believe the problem was solved by > bz24515. I was able to reproduce on master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24516] Column Configuration does not hide Return Date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24516 David Nind changed: What|Removed |Added Attachment #98351|0 |1 is obsolete|| --- Comment #3 from David Nind --- Created attachment 98357 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98357=edit Bug 24516: Add account_type to the columns settings on boraccount The column was missing from the yml file. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24516] Column Configuration does not hide Return Date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24516 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24572] New: Add books from mysql manually
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24572
Bug ID: 24572
Summary: Add books from mysql manually
Change sponsored?: ---
Product: Koha
Version: unspecified
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Cataloging
Assignee: koha-bugs@lists.koha-community.org
Reporter: chrs.mark...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl
Hi everyone,
I'm trying to bulk import book items into Koha database using a custom script
that I have created (in python).
Here are some of the mysql commands I use for it:
insert into biblio (title, biblionumber, frameworkcode, datecreated)
values('{}',{},'{}',NOW())".format(title, biblionumber, biblio_framework)
so as to create a new book, and then
insert into biblio_metadata (id, biblionumber, format, marcflavour, metadata)
values ({},{},'{}','{}','{}')".format(id, biblionumber, "marcxml", "UNIMARC",
meta)
in order to attach metadata to it.
The result is that the sql entries are successfully inserted however I cannot
search the book from the basic search at
http://192.168.1.12/cgi-bin/koha/opac-main.pl
I guess that some more date need to be populated so as to have the books
available from the search bar?
Could you please point me which tables are required to be populated so as to
have books listed in searches like the one I described above?
Thank you in advance,
C.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24571] Attempting to place multi hold requests on Firefox only places some of them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24571 --- Comment #1 from Nick Clemens --- While this does work in Chrome, there is no feedback as to what is happening - the submit button is not disabled. Testing with 200 holds there is a lot of waiting with no feedback -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24571] New: Attempting to place multi hold requests on Firefox only places some of them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24571 Bug ID: 24571 Summary: Attempting to place multi hold requests on Firefox only places some of them Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: agustinmoy...@theke.io Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com In the staff client do a search that returns 20+ results that can be held Select all Place hold Confirm The api submits ~8 requests, then the page moves to the hold results, but not alll records are held -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24571] Attempting to place multi hold requests on Firefox only places some of them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24571 Nick Clemens changed: What|Removed |Added CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24094] Authority punctuation mismatch prevents linking to correct records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24094 Nick Clemens changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com |ity.org | CC||n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24530] Show a number in title notes just as in the other tabs of opac detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24530 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #4 from David Nind --- I have no particular view on whether to display the number of title notes or not. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24530] Show a number in title notes just as in the other tabs of opac detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24530 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24530] Show a number in title notes just as in the other tabs of opac detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24530 David Nind changed: What|Removed |Added Attachment #98084|0 |1 is obsolete|| --- Comment #3 from David Nind --- Created attachment 98356 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98356=edit Bug 24530: Show a number for title notes on opac-detail A number (just as on most other tabs) tells more than a boolean (i.e. the tab does not appear for zero marc notes). Intuitively, you might be misled by "Holdings (1), Descriptions" and think there are none. Test plan: Verify that the number of title notes on opac detail page matches your expectations. Signed-off-by: Marcel de Rooy Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24363] Datepicker calendar is not always sexy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24363 --- Comment #17 from David Nind --- Created attachment 98355 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98355=edit Bug 24363 - Browse button broken Actually, the patch "breaks" the 'Browse' button in Firefox. Displays fine in Google Chrome. See the attachment with before and after screenshots. It did this as well when originally tested. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24570] New: Cart location showing/duplicated when editing item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24570 Bug ID: 24570 Summary: Cart location showing/duplicated when editing item Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: cbran...@cdalibrary.org QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl When using the CART location to show recently returned items, that location displays in field c when editing or duplicating the item. This causes problems with cataloging as it will cause that location to permanently be assigned to that item or duplicated items. Field c should be reflecting the location in the permanent_location field, not the location field. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23031] Improve UX of buttons on order search page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23031 Nick Clemens changed: What|Removed |Added Blocks||24569 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24569 [Bug 24569] Cannot add to basket if it is the only action -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24569] New: Cannot add to basket if it is the only action
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24569 Bug ID: 24569 Summary: Cannot add to basket if it is the only action Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org When "Add to basket" is the only action the modal is not created so one cannot add to the basket from booksellers.pl Regression caused by Bug 23031 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24569] Cannot add to basket if it is the only action
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24569 Nick Clemens changed: What|Removed |Added Depends on||23031 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23031 [Bug 23031] Improve UX of buttons on order search page -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24363] Datepicker calendar is not always sexy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24363 --- Comment #16 from David Nind --- This now looks good to me! (Firefox + Google Chrome on Ubuntu 18.04) Should Jonathan's patch include the updated CSS file? Originally I had to regenerate the CSS. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24568] New: Allow selection of multiple authorised values in runtime parameters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24568 Bug ID: 24568 Summary: Allow selection of multiple authorised values in runtime parameters Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: koha-bugs@lists.koha-community.org Reporter: and...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org It'd be really useful to be able to run a report and pick multiple values on a runtime parameter. So, given a library with collection codes A,B,C, and D, I'd like to be able to set a runtime parameter that allowed one to pick collections A and C, for example. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24568] Allow selection of multiple authorised values in runtime parameters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24568 Andrew Fuerste-Henry changed: What|Removed |Added CC||n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24567] Elasticsearch: CCL syntax does not allow for multiple indexes to be searched at once
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24567 Nick Clemens changed: What|Removed |Added Summary|CCL syntax does not allow |Elasticsearch: CCL syntax |for multiple indexes to be |does not allow for multiple |searched at once|indexes to be searched at ||once -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24338] CASH is missing from the default payment_types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24338 David Nind changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply --- Comment #4 from David Nind --- Patch doesn't apply on 19.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24356] objects.search prefetch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24356 David Nind changed: What|Removed |Added Attachment #98348|0 |1 is obsolete|| --- Comment #19 from David Nind --- Created attachment 98354 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98354=edit Bug 24356: Make objects.search prefetch embedded relations This patch makes the Koha::Object(s) derived classes expose information about prefetch-able relations. This is then used by a new helper to generate the prefetch information for the DBIC query. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Object* \ t/db_dependent/Koha/REST/Plugin/Objects.t \ t/Koha/REST/Plugin/Query.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24356] objects.search prefetch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24356 David Nind changed: What|Removed |Added Attachment #98261|0 |1 is obsolete|| --- Comment #18 from David Nind --- Created attachment 98353 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98353=edit Bug 24356: prefetch_whitelist tests This patch adds tests for the introduced methods. To test: 1. Run the tests :-D => SUCCESS: They pass! 2. Sign off :-D Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24356] objects.search prefetch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24356 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 --- Comment #73 from Martin Renvoize --- Created attachment 98352 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98352=edit Bug 23260: Proposed preference driven filtering -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24197] Custom destination for failed overdue notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24197 Sally changed: What|Removed |Added CC||sally.healey@cheshireshared ||services.gov.uk -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #72 from Martin Renvoize --- Setting to Failed QA whilst I code the followup -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24516] Column Configuration does not hide Return Date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24516 --- Comment #2 from Jonathan Druart --- Created attachment 98351 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98351=edit Bug 24516: Add account_type to the columns settings on boraccount The column was missing from the yml file. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12166] Improve display of hold charges in patron account
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12166 Jonathan Druart changed: What|Removed |Added Blocks||24516 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24516 [Bug 24516] Column Configuration does not hide Return Date -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24516] Column Configuration does not hide Return Date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24516 Jonathan Druart changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c |ity.org |ommunity.org CC||jonathan.dru...@bugs.koha-c ||ommunity.org Depends on||12166 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12166 [Bug 12166] Improve display of hold charges in patron account -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24516] Column Configuration does not hide Return Date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24516 Jonathan Druart changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 --- Comment #71 from Martin Renvoize --- I see Right.. I totally missed that `but not if the item is lost, damaged, or withdrawn.` in the original request is different to how the existing anonymisation logic works. Personally (and I've checked with a few people now) I feel that the two locations this data is stored should be anonymised equally so they don't fall out of sync. As this is a change in a privacy feature I think we probably need to govern whether we filter out by item status based on a system preference to keep everyone happy. I'll add that as a followup now and update the test to correspond. Good catch Jonathan! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24560] Don't show "Public Lists" in OPAC List menu if no public lists exist
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24560 Andrew Fuerste-Henry changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24560] Don't show "Public Lists" in OPAC List menu if no public lists exist
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24560 ByWater Sandboxes changed: What|Removed |Added Attachment #98265|0 |1 is obsolete|| --- Comment #6 from ByWater Sandboxes --- Created attachment 98350 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98350=edit Bug 24560: Remove No public list text from OPAC Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment #70 from Jonathan Druart --- (In reply to Jonathan Druart from comment #68) > (In reply to Martin Renvoize from comment #66) > > Seems I forgot to reset the status when I added the followup.. ready for QA > > The test was not passing. I have updated it, as I think we are expecting 1 > checkout to be anonymised here. Still not passing. Forget that, I misread the code. We want 4 checkouts to be anonymised. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 Jonathan Druart changed: What|Removed |Added Attachment #98282|0 |1 is obsolete|| --- Comment #69 from Jonathan Druart --- Created attachment 98349 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98349=edit Bug 23260: Add a new test -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24356] objects.search prefetch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24356
--- Comment #17 from Agustín Moyano ---
(In reply to David Nind from comment #15)
> Tests for prove t/db_dependent/Koha/REST/Plugin/Query.t generate this error
> message:
>
> Cannot detect source of 't/db_dependent/Koha/REST/Plugin/Query.t'! at
> /usr/share/perl/5.24/TAP/Parser/IteratorFactory.pm line 261.
> TAP::Parser::IteratorFactory::detect_source(TAP::Parser::
> IteratorFactory=HASH(0x562a13917438),
> TAP::Parser::Source=HASH(0x562a13917510)) called at
> /usr/share/perl/5.24/TAP/Parser/IteratorFactory.pm line 211
> TAP::Parser::IteratorFactory::make_iterator(TAP::Parser::
> IteratorFactory=HASH(0x562a13917438),
> TAP::Parser::Source=HASH(0x562a13917510)) called at
> /usr/share/perl/5.24/TAP/Parser.pm line 472
> TAP::Parser::_initialize(TAP::Parser=HASH(0x562a139170f0),
> HASH(0x562a136dc0e0)) called at /usr/share/perl/5.24/TAP/Object.pm line 55
> TAP::Object::new("TAP::Parser", HASH(0x562a136dc0e0)) called at
> /usr/share/perl/5.24/TAP/Object.pm line 130
> TAP::Object::_construct(TAP::Harness=HASH(0x562a1314e3f0),
> "TAP::Parser",
> HASH(0x562a136dc0e0)) called at /usr/share/perl/5.24/TAP/Harness.pm line 852
> TAP::Harness::make_parser(TAP::Harness=HASH(0x562a1314e3f0),
> TAP::Parser::Scheduler::Job=HASH(0x562a13837648)) called at
> /usr/share/perl/5.24/TAP/Harness.pm line 651
> TAP::Harness::_aggregate_single(TAP::Harness=HASH(0x562a1314e3f0),
> TAP::Parser::Aggregator=HASH(0x562a13168d48),
> TAP::Parser::Scheduler=HASH(0x562a138375e8)) called at
> /usr/share/perl/5.24/TAP/Harness.pm line 743
> TAP::Harness::aggregate_tests(TAP::Harness=HASH(0x562a1314e3f0),
> TAP::Parser::Aggregator=HASH(0x562a13168d48),
> "t/db_dependent/Koha/REST/Plugin/Query.t") called at
> /usr/share/perl/5.24/TAP/Harness.pm line 558
> TAP::Harness::__ANON__() called at /usr/share/perl/5.24/TAP/Harness.pm
> line
> 571
> TAP::Harness::runtests(TAP::Harness=HASH(0x562a1314e3f0),
> "t/db_dependent/Koha/REST/Plugin/Query.t") called at
> /usr/share/perl/5.24/App/Prove.pm line 546
> App::Prove::_runtests(App::Prove=HASH(0x562a13143888),
> HASH(0x562a135b1c90), "t/db_dependent/Koha/REST/Plugin/Query.t") called at
> /usr/share/perl/5.24/App/Prove.pm line 504
> App::Prove::run(App::Prove=HASH(0x562a13143888)) called at
> /usr/bin/prove
> line 13
Ups!.. the path of Query.t was not in db_dependent.
Sorry
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #154 from Jonathan Druart --- Created attachment 98345 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98345=edit Bug 18936: Remove 2 new occurrences of Koha::IssuingRules Fix conflict with bug 13121 Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #156 from Jonathan Druart --- Created attachment 98347 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98347=edit Bug 18936: Fix failing test in api/v1/holds.t Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24356] objects.search prefetch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24356 Agustín Moyano changed: What|Removed |Added Attachment #98262|0 |1 is obsolete|| --- Comment #16 from Agustín Moyano --- Created attachment 98348 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98348=edit Bug 24356: Make objects.search prefetch embedded relations This patch makes the Koha::Object(s) derived classes expose information about prefetch-able relations. This is then used by a new helper to generate the prefetch information for the DBIC query. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Object* \ t/db_dependent/Koha/REST/Plugin/Objects.t \ t/Koha/REST/Plugin/Query.t => SUCCESS: Tests pass! 3. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24203] overduerules.pl does not work with bug 20436
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24203 --- Comment #5 from Christopher Brannon --- > Hi Christopher, we don't use the longoverdue process ourselves, I was not > aware that it's used in combination with the overdue notices. I am confused. If you were not aware that it is used in combination with the overdue notices, what is it intended for? The header says 'Defining default overdue actions', and the choices include sending a letter. Without this pl, how else do overdue notices get sent? > For our libraries the major concern is that it should be timed > with the creating of fines, which is usually happening in a weekly interval > here. Many of our libraries are no longer charging fines. > I wonder if it could make sense to not tie it overdue notices but to their > own set of notices by itemtype? Both could live on the same configuration > page tho. I'm not sure what you mean? Can you elaborate? How would you implement this? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #155 from Jonathan Druart --- Created attachment 98346 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98346=edit Bug 18936: (QA follow-up) Fix failing test Using categorycode as a scope is not possible for any of these rules so lets remove it. Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #153 from Jonathan Druart --- Created attachment 98344 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98344=edit Bug 18936: (QA follow-up) Convert remaining tests to use Koha::CirculationRules These two uses of Koha::IssuingRule were forgotten so this converts them to use the new Koha::CirculationRules object. Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #149 from Jonathan Druart --- Created attachment 98340 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98340=edit Bug 18936: (follow-up2) Adjust circ rule related tests so that they pass The itemtype did not exist in the DB. We create it at the beginning of the tests. Ideally we would like to create it filling the form. Signed-off-by: Minna Kivinen Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #150 from Jonathan Druart --- Created attachment 98341 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98341=edit Bug 18936: (follow-up) Fix checkouts endpoint and its tests - Fixes a bug caused by the refactoring in Koha/REST/V1/Checkouts.pm (run the tests without this patch and you will see the tests fails because 'rule_name' parameter was forgotten). - Changes the tests to use the new Koha::CirculationRule objects instead of directly using issuingrules DB table Signed-off-by: Minna Kivinen Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #152 from Jonathan Druart --- Created attachment 98343 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98343=edit Bug 18936: (follow-up) More fixes Previous "More fixes" patch added a debugging statement, not needed. Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #151 from Jonathan Druart --- Created attachment 98342 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98342=edit Bug 18936: (QA follow-up) Add missing POD Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #148 from Jonathan Druart --- Created attachment 98339 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98339=edit Bug 18936: (follow-up) Adjust circ rule related tests so that they pass Bunch of tests broke after moving from issuingrules to circulation_rules. This accomodates the tests for this refactoring and DB change. Signed-off-by: Minna Kivinen Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #147 from Jonathan Druart --- Created attachment 98338 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98338=edit Bug 18936: Fix IssuingRules/guess_article_requestable_itemtypes.t Signed-off-by: Minna Kivinen Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #144 from Jonathan Druart --- Created attachment 98335 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98335=edit Bug 18936: (follow-up) Add cloning of circulation rules back to Koha The "Clone these rules" feature in admin/smart-rules.pl was dropped. This re-implements the cloning using Koha objects. Signed-off-by: Minna Kivinen Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #146 from Jonathan Druart --- Created attachment 98337 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98337=edit Bug 18936: (follow-up2) Make possible to have unlimited value for holds_per_day Signed-off-by: Minna Kivinen Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #145 from Jonathan Druart --- Created attachment 98336 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98336=edit Bug 18936: (follow-up) Make possible to have unlimited value for holds_per_day Without this it is not possible to make for a specific patron category or itemtype a more specific unlimited holds_per_day rule if you have a catch all rule (categorycode = *, itemtype = *) with limited holds_per_day value. Signed-off-by: Minna Kivinen Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #142 from Jonathan Druart --- Created attachment 98333 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98333=edit Bug 18936: Fix inconsistencies in IssuingRules.t * get_effective_rule should not pass rule_value * indentation fix * add comment to list the rules we have when the test _is_row_match is executed * compare ->rule_name and ->rule_value returns Signed-off-by: Minna Kivinen Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #143 from Jonathan Druart --- Created attachment 98334 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98334=edit Bug 18936: (follow-up2) Fix tests, replace old get_onshelfholds_policy method Previous change to this file was different from the one that existed prior to this patchset. Restoring value for onshelfholds, note that it did not change anything in the test result. Signed-off-by: Minna Kivinen Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #141 from Jonathan Druart --- Created attachment 98332 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98332=edit Bug 18936: (follow-up) Add missing import of Koha::CirculationRules Signed-off-by: Minna Kivinen Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #138 from Jonathan Druart --- Created attachment 98329 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98329=edit Bug 18936: Fix the delete rule buttons The itemtype and categorycode were always set to '*' Signed-off-by: Minna Kivinen Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #139 from Jonathan Druart --- Created attachment 98330 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98330=edit Bug 18936: (follow-up 2) Add foreign key and scope enhancement to circ rules The previous patch modifies: -categorycode => undef, -itemtype => undef, -branchcode => $branch, +branchcode => undef, But in that condition $branchcode is not '*' and so we should not set it to undef Signed-off-by: Minna Kivinen Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #140 from Jonathan Druart --- Created attachment 98331 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98331=edit Bug 18936: (follow-up) Fix typo in documentation Signed-off-by: Minna Kivinen Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #137 from Jonathan Druart --- Created attachment 98328 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98328=edit Bug 18936: Replace '*' with undef No test was provided initially so considering out of the scope for this one as well, but that's lacking terribly! Signed-off-by: Minna Kivinen Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #133 from Jonathan Druart --- Created attachment 98324 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98324=edit Bug 18936: Fix some more tests * CanItemBeReserved Prior to "Bug 18936: Convert issuingrules fields to circulation_rules", GetHoldRule returned holds_per_record even if no reservesallowed was defined. This change restores this behavior. FIXME Note: In GetHoldRule we return itemtype only if reservesallowed is set, not sure it is correct. * t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t When setting returnbranch, holdallowed and hold_fulfillment_policy, we should not provide categorycode. * t/db_dependent/Holds.t Prefer to keep the existing rules instead of removing them. It got quite hard to understand what was going on here because of the mixup with the rule reservesallowed that was in issuingrules, and the other rules we used for the tests. Also, categorycode should not be passed to set those 3 rules (holdallowed, hold_fulfillment_policy and returnbranch) * t/db_dependent/Circulation.t Setting lengthunit to 'hours', no need to make sure the rule has been correctly be saved * t/db_dependent/Circulation/CalcDateDue.t It uses hardcoded data that is not in the sample data (categorycode=C). Let use K that exists and postpone a refactore of the whole script (to make it create the data it needs). * t/db_dependent/Circulation/ReturnClaims.t * t/db_dependent/Circulation/IssuingRules/maxsuspensiondays.t Simple replace Koha::IssuingRule with Koha::CirculationRules * t/db_dependent/Koha/Charges/Fees.t => FIXME Still failing, stuck here, need help Signed-off-by: Minna Kivinen Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #132 from Jonathan Druart --- Created attachment 98323 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98323=edit Bug 18936: (follow-up) Don't retrieve unused issuing rule The chargename rule is not used anywhere in the code Signed-off-by: Minna Kivinen Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
