[Koha-bugs] [Bug 13881] Add ability to defined circulation desks

2020-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13881

--- Comment #62 from Josef Moravec  ---
(In reply to David Cook from comment #61)
> (In reply to Katrin Fischer from comment #60)
> > I know that this is a common feature in at least one ILS widely used here in
> > Germany in academic libraries. I could also imagine it being useful in
> > public libraries with different desks for adult and children services.
> 
> Oh right! Good one! Now that I think about it, I have gone to a public
> library that had different circulation areas for adults and children. I
> wonder if they treated them as separate branches or as separate desks in the
> same branch. Interesting...

In a public library with three circulation desk, we had to set them as
branches, as there was no other option in Koha... It's not big issue in
relatively small public library. But when the library has more branches and
more desks at each of them, the branches and desks combination could be more
precise and semantically much more meaningful

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13881] Add ability to defined circulation desks

2020-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13881

--- Comment #61 from David Cook  ---
(In reply to Katrin Fischer from comment #60)
> I know that this is a common feature in at least one ILS widely used here in
> Germany in academic libraries. I could also imagine it being useful in
> public libraries with different desks for adult and children services.

Oh right! Good one! Now that I think about it, I have gone to a public library
that had different circulation areas for adults and children. I wonder if they
treated them as separate branches or as separate desks in the same branch.
Interesting...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13881] Add ability to defined circulation desks

2020-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13881

--- Comment #60 from Katrin Fischer  ---
I know that this is a common feature in at least one ILS widely used here in
Germany in academic libraries. I could also imagine it being useful in public
libraries with different desks for adult and children services.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25560] New: Exclude itemtypes from UpdateNotForLoanStatusOnCheckin

2020-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560

Bug ID: 25560
   Summary: Exclude itemtypes from UpdateNotForLoanStatusOnCheckin
 Change sponsored?: Sponsored
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Circulation
  Assignee: alexbuck...@catalyst.net.nz
  Reporter: alexbuck...@catalyst.net.nz
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

Currently the UpdateNotForLoanStatusOnCheckin syspref will update the
items.notforloan value of ALL items checked in regardless of itemtype.

It would be useful to be able to exclude specific itemtypes.

This enhancement will add a checkbox 'Update not for loan status on check-in'
to the administration item types page (Administration > Item types). 

When the UpdateNotForLoanStatusOnCheckin syspref contains content and this
checkbox is unticked then that itemtype is excluded from having its
items.notforloan changed upon checkin.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25559] SPAM

2020-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25559

Owen Leonard  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
Summary|Hacked  |SPAM
 Resolution|--- |INVALID

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25559] New: Hacked

2020-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25559

Bug ID: 25559
   Summary: Hacked
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Authentication
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: anonymouus...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: dpav...@rot13.org

Created attachment 105165
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105165=edit
Ffg

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25411] Plugin routes cannot have anonymous access

2020-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25411

--- Comment #12 from David Cook  ---
I've only skimmed the code, but it looks good at a glance.

For a second, I thought it was making all plugin API routes public, but then I
noticed that's only if they don't have 'x-koha-authorization' defined. 

I wonder if there's anything we need or can do in the API documentation to make
it more obvious what (plugin) routes require auth and which don't?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25411] Plugin routes cannot have anonymous access

2020-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25411

--- Comment #13 from David Cook  ---
(In reply to David Cook from comment #12)
> I've only skimmed the code, but it looks good at a glance.
> 
> For a second, I thought it was making all plugin API routes public, but then
> I noticed that's only if they don't have 'x-koha-authorization' defined. 
> 
> I wonder if there's anything we need or can do in the API documentation to
> make it more obvious what (plugin) routes require auth and which don't?

Just a general question. Not directly related to this bug report per se...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24854] Remove IDreamBooks integration

2020-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24854

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client

2020-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662

--- Comment #295 from David Cook  ---
Now that I know the basics of Koha plugins and OpenAPI specs for API routes, I
think the plugin progress will be quite quick.

I am hoping that "koha-plugin-oaipmh-import" may actually be leveraged by many
different OAI-PMH harvester tools. 

The standalone OAI-PMH harvester was required by Stockholm University Library,
as they wanted a high performance interactive tool, but it might be overkill
for many other libraries, which might just want to run a nightly cronjob. This
plugin would allow any OAI-PMH harvester to feed records into Koha via the REST
API.

So I think this plugin is probably the most important component of the work
really, as it will add the fundamental ability to ingest MARCXML records
encapsulated within OAI-PMH records. 

With the "koha-plugin-oaipmh-import" plugin, people could use any number of
existing OAI-PMH tools to create their own OAI-PMH harvesters to import records
into Koha.

But I'll still be working on creating an OAI-PMH harvester that meets the
original stated needs of Stockholm University Library, as I still want them to
be able to meet their goals.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18585] Connect to RDF triplestore

2020-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18585

David Cook  changed:

   What|Removed |Added

 Status|Needs Signoff   |In Discussion

--- Comment #35 from David Cook  ---
In practice, I've found you only really need a RDF triplestore if you want to
query your data or provide public access to your data. Before doing that, we'd
wnat to store the RDF in the database first and then "index" it into a
triplestore.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21359] Add RDF support to OAI-PMH harvester

2020-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21359

David Cook  changed:

   What|Removed |Added

 Status|NEW |In Discussion

--- Comment #5 from David Cook  ---
My thoughts on this one have changed a lot over the years due to research and
experience.

Really we need to add RDF support to Koha before we do anything else.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18713] Add support for named graphs and rfds:seeAlso to Koha::RDF

2020-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18713

David Cook  changed:

   What|Removed |Added

 Status|Needs Signoff   |In Discussion

--- Comment #34 from David Cook  ---
We need to actually implement RDF in Koha before we think about this sort of
thing.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25524] Debian packages always append to /etc/koha/sites/$site/log4perl.conf

2020-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25524

--- Comment #8 from Tomás Cohen Arazi  ---
(In reply to Joy Nelson from comment #7)
> backported to 19.11.x for 19.11.06

\o/

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client

2020-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662

--- Comment #294 from David Cook  ---
(In reply to Michal Denar from comment #293)
> I really like this idea. Czech Koha community want to help change this idea
> to project. How can we cooperate? If we'll work together, we'll finish this
> sooner. I hope.
> 
> Michal

That's great to hear, Michal!

The thing that I will probably need most is testers. I don't have anything to
test yet, but I am hoping to have something soon.

Here's the list of components I'll be developing:
1. Koha UI - Koha plugin (Web UI to interact with OAI-PMH harvester HTTP
management API)
2. Koha Import API - Koha plugin (Import API to receive harvested OAI-PMH
records)
3. Standalone OAI-PMH harvester (Statically compiled Golang daemon with HTTP
API for management)

Last night, I started work on the "Koha Import API" plugin
(https://github.com/minusdavid/koha-plugin-oaipmh-import). My next steps for
that are clear, so I just need to sit down and do some work on that. Maybe
tomorrow night. 

I've done experimental work on the "Standalone OAI-PMH harvester", but I
haven't posted that to Github yet. I think that I've mostly settled on a
scheduler methodology so hoping to make rapid progress on this one too. The
plan with this will be to post the source code on Github, but also to provide a
compiled binary that people can just download and run. (I might start with a
Linux binary, but I've been thinking about doing a Windows binary too.) I may
also provide a Docker image for the harvester as well to ease testing and
deployment. 

The "Koha UI" plugin will probably be the last thing I do, since it depends on
the HTTP API for the "Standalone OAI-PMH harvester". However, it should be
fairly straight forward. 

Sorry for all the words! Just sharing my current plans! A lot of the work will
be modeled off what I did for Bug 10662, but will probably be simpler.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25532] Add a wikipedia-style search suggestion feature to the OPAC

2020-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25532

--- Comment #6 from David Cook  ---
Ahhh I thought it was a "Did you mean" feature for after you've done a search,
but it's a search suggestion before the search is done. Neato. 

I agree with what Owen has said.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25510] Typo in koha-common.postinst causing shell errors

2020-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25510

--- Comment #39 from David Cook  ---
(In reply to Victor Grousset/tuxayo from comment #37)
> Is 19.05 also affected?

I don't think so. Since Bug 24905 wasn't pushed to 19.05, it should be safe.

We skipped over 19.05 and are doing many upgrades to 19.11, so that's all I've
been targeting at the moment for my work.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25510] Typo in koha-common.postinst causing shell errors

2020-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25510

--- Comment #38 from David Cook  ---
(In reply to Joy Nelson from comment #36)
> 19.11.x patches reviewed by Kyle and pushed by me for 19.11.06
> Thanks!

Woo! You're welcome ^_^.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13881] Add ability to defined circulation desks

2020-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13881

--- Comment #59 from David Cook  ---
(In reply to Nicolas Legrand from comment #58)
> At first it was doing more but I cut it up into three
> after rewrite to help the work for QA. 

Makes sense to me.

> I'm surprised it sounds niche :), I
> know not so few libraries with multiple desks and waiting reserves. Truth is
> it's even odd for me it wasn't there. 

What sort of libraries are these? Public libraries? I've worked in academic
libraries and special libraries and we always had just 1 circulation desk per
library branch, which had all the waiting reserves for that branch behind it. 

I don't think that I've even used a library (in Canada or Australia) that has
had multiple circulation desks? 

Not that I'm being negative. I'm really intrigued! Very different to my
experience, so it's interesting to learn about different setups.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25284] Can't open /var/log/koha/kohadev/opac-error.log (Permission denied)

2020-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25284

Joy Nelson  changed:

   What|Removed |Added

 CC||j...@bywatersolutions.com

--- Comment #23 from Joy Nelson  ---
missing dependency no backported to 19.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25535] Hold API mapping maps cancellationdate to cancelation_date, but it should be cancellation_date

2020-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25535

Joy Nelson  changed:

   What|Removed |Added

 Status|Pushed to master|Pushed to stable
 Version(s)|20.05.00|20.05.00, 19.11.06
released in||
 CC||j...@bywatersolutions.com

--- Comment #11 from Joy Nelson  ---
pushed to 19.11.x for 19.11.06

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25524] Debian packages always append to /etc/koha/sites/$site/log4perl.conf

2020-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25524

Joy Nelson  changed:

   What|Removed |Added

 Status|Pushed to master|Pushed to stable
 Version(s)|20.05.00|20.05.00, 19.11.06
released in||
 CC||j...@bywatersolutions.com

--- Comment #7 from Joy Nelson  ---
backported to 19.11.x for 19.11.06

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25377] Transfer does not change current item location

2020-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25377

Martin Renvoize  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |martin.renvoize@ptfs-europe
   |ity.org |.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25377] Transfer does not change current item location

2020-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25377

Martin Renvoize  changed:

   What|Removed |Added

   Keywords||rel_20_11_target

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25377] Transfer does not change current item location

2020-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25377

--- Comment #6 from Martin Renvoize  ---
My apologies, this has only just hit my radar.

My work within the transfers system that date has really just been around
improved logging so we can see what triggered and transfer and when.

I can try to investigate this after the 20.05 release..

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24229] /items API tests fail on Ubuntu 18.04

2020-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24229

--- Comment #8 from Tomás Cohen Arazi  ---
(In reply to Jonathan Druart from comment #4)
> I have tried to extend Mojo timeout
> https://mojolicious.org/perldoc/Mojolicious/Guides/FAQ#What-does-Inactivity-
> timeout-mean
> 
> export MOJO_INACTIVITY_TIMEOUT=120
> for i in {1..6}; do timeout 120 prove -v t/db_dependent/api/v1/items.t& done
> 
> I do no longer get the tests failing, but they all get stuck at this test.

I reproduced the problem easily with your loop. My patch fixes that.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24229] /items API tests fail on Ubuntu 18.04

2020-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24229

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24229] /items API tests fail on Ubuntu 18.04

2020-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24229

--- Comment #7 from Tomás Cohen Arazi  ---
Created attachment 105163
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105163=edit
Bug 24229: Avoid fetching ALL items in test

I'm not sure what we need to test here, besides we get results. I'm
pretty sure we shouldn't allow a plain GET return all objects because it
could cause a DOS very easily. But it certainly belongs to a separate
bug/discussion.

In this case, I put a constraint on the items domain (by using
_per_page=10 in the query params) so it won't happen that under certain
conditions the user agent used by Test::Mojo time outs.

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25531] Patron may not be debarred if backdated return

2020-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25531

Joy Nelson  changed:

   What|Removed |Added

 CC||j...@bywatersolutions.com

--- Comment #14 from Joy Nelson  ---
tests do not pass on 19.11.x  
  FAIL   valid
Global symbol "$now" requires explicit package name (did you
forget to declare "my $now"?)
Global symbol "$now" requires explicit package name (did you
forget to declare "my $now"?)
Global symbol "$now" requires explicit package name (did you
forget to declare "my $now"?)
t/db_dependent/Circulation.t had compilation errors.


Not backported to 19.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25502] /advanced_editor/macros doesn't follow coding guidelines

2020-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25502

Joy Nelson  changed:

   What|Removed |Added

 CC||j...@bywatersolutions.com

--- Comment #6 from Joy Nelson  ---
missing dependency -not backported to 19.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25493] Koha::Logger is not suitable for using as Mojo::Log

2020-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25493

Joy Nelson  changed:

   What|Removed |Added

 CC||j...@bywatersolutions.com

--- Comment #6 from Joy Nelson  ---
missing dependencies-not backported to 19.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25501] Encoding issues in the translation process

2020-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25501

Joy Nelson  changed:

   What|Removed |Added

 CC||j...@bywatersolutions.com

--- Comment #27 from Joy Nelson  ---
not backported to 19.11.x due to missing dependencies

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25516] Item/pickup_locations wantarray removed, so dies on Perl >=5.24 where "autoderef" feature absent

2020-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25516

Joy Nelson  changed:

   What|Removed |Added

 CC||j...@bywatersolutions.com

--- Comment #9 from Joy Nelson  ---
missing dependency - not backported to 19.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24458] Search results don't use Koha::Filter::MARC::ViewPolicy

2020-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24458

Joy Nelson  changed:

   What|Removed |Added

 Status|Pushed to master|Pushed to stable
 Version(s)|20.05.00|20.05.00, 19.11.06
released in||

--- Comment #13 from Joy Nelson  ---
thanks to tomas' help on 25416 i was able to push this to 19.11.x.  Will be in
19.11.06

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25416] Add information about anonymous session for XSLT use

2020-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25416

Joy Nelson  changed:

   What|Removed |Added

 Status|Pushed to master|Pushed to stable
 Version(s)|20.05.00|20.05.00, 19.11.06
released in||

--- Comment #26 from Joy Nelson  ---
Pushed to 19.11.x for 19.11.06

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23403] SIP2 lends to wrong patron if cardnumber is missing

2020-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23403

--- Comment #34 from Joy Nelson  ---
First commit when cherry-picked gives this error:
<<< HEAD
 51 syslog('LOG_DEBUG', "ILS::Transaction::Checkout performing
checkout...");
 52 my $shelf  = $self->{item}->hold_shelf;
 53 my $barcode= $self->{item}->id;
 54 my $patron_barcode = $self->{patron}->id;
 55 my $overridden_duedate; # usually passed as undef to AddIssue
 56 $debug and warn "do_checkout: patron (" . $patron_barcode . ")";
 57 my $patron = Koha::Patrons->find( { cardnumber => $patron_barcode } );
 58 my $borrower = $patron->unblessed;
 59 $debug and warn "do_checkout borrower: . " . Dumper $borrower;
 60 ===
 61 siplog('LOG_DEBUG', "ILS::Transaction::Checkout performing
checkout...");
 62 my $shelf  = $self->{item}->hold_shelf;
 63 my $barcode= $self->{item}->id;
 64 my $patron =
Koha::Patrons->find($self->{patron}->{borrowernumber});
 65 my $overridden_duedate; # usually passed as undef to AddIssue
 66 $debug and warn "do_checkout borrower: . " . $patron->borrowernumber;
 67 >>> 23dd6651f8... Bug 23403: Remove cardnumber from SIP

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22232] Advanced Cataloguing Editor (Rancor) to edit authority records?

2020-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22232

Heather  changed:

   What|Removed |Added

 CC||heather_hernan...@nps.gov

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25364] Add "Other" to the gender options in a patron record

2020-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25364

Devinim  changed:

   What|Removed |Added

 Attachment #104617|0   |1
is obsolete||

--- Comment #21 from Devinim  ---
Created attachment 105162
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105162=edit
Bug 25364: Add "Other" to the gender options in a patron record

This patch adds "Other" as an option, and also changes the wording of
"None specified" slightly.

To test:

1) Apply the patch
2) Check that there is an "Other" radio button in the patron record, and
that the wording of "None specified" has changed to "None specified /
Prefer not to say".
3) Check that you can save changes to the gender of this patron record,
both on create and modify.
4) Check that these changes also work in the Opac Self-Registration
functionality.

Correct typos in previous commit

Signed-off-by: Devinim 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25364] Add "Other" to the gender options in a patron record

2020-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25364

Devinim  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25416] Add information about anonymous session for XSLT use

2020-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25416

--- Comment #25 from Tomás Cohen Arazi  ---
(In reply to Joy Nelson from comment #21)
> enhancement not backported to 19.11.x

Just in case you would reconsider it, I submitted the 19.11 version, which is
just adjusting the name of the XSLT class (Koha::XSLT_handler vs
Koha::XSLT::Base) and the tests count (removal of QueryParser in master).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25416] Add information about anonymous session for XSLT use

2020-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25416

--- Comment #24 from Tomás Cohen Arazi  ---
Created attachment 105161
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105161=edit
[19.11.x] Bug 25416: Unit tests

This patch adds tests for the new 'feature': i.e. searchResults passes
the added $xslt_variables to the XSLTParse4Display method.

Signed-off-by: Tomas Cohen Arazi 
Signed-off-by: Victor Grousset/tuxayo 
Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25416] Add information about anonymous session for XSLT use

2020-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25416

--- Comment #23 from Tomás Cohen Arazi  ---
Created attachment 105160
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105160=edit
[19.11.x] Bug 25416: Let OPAC XSLTs know if the context is an anonymous session

This patch makes use of the 'variables' parameter in XSLTParse4Display
method in the different places that it is used in the OPAC. It does by
passing this parameter with

anonymous_session => 1|0

The value will depend on the output from get_template_and_user (i.e. if
there's a returned borrowernumber).

A special case takes place in search results, as the call to
XSLTParse4Display happens in C4::Search::searchResults. So a new
parameter 'xslt_variables' is added to it.

To test:
1. Apply the [DO NOT PUSH] patch
2. Open the OPAC in your browser
3. Try detail pages, search results, tags and lists/shelves pages with
   or without an active session
=> FAIL: It always says (somewhere) 'Anonymous session: Yes'
4. Apply this patch, restart_all
5. Repeat 3
=> SUCCESS: It will tell the Yes/No correctly regarding anonymous
sessions!
6. Sign off :-D

Sponsored-by: Universidad ORT Uruguay

Signed-off-by: Victor Grousset/tuxayo 
Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25557] New: Column config table in Acquisitions Order Does not Match the Acq table in Baskets

2020-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25557

Bug ID: 25557
   Summary: Column config table in Acquisitions Order Does not
Match the Acq table in Baskets
 Change sponsored?: ---
   Product: Koha
   Version: 19.11
  Hardware: All
OS: All
Status: NEW
  Severity: major
  Priority: P5 - low
 Component: Tools
  Assignee: lu...@bywatersolutions.com
  Reporter: ke...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

The actual way that the Acq table appears in the basket view (basket.pl), 

1.Basket #
2. Order information
3. RRP Tax Exc
4. Actual Cost Exc
5. Budgeted Cost Tax Exc
6. RRP Tax Included
7. Actual Cost Tax Inc
8. Budgeted Cost Tax Inc
9. Replacement Price
10. Quantity

But in the column config table

1.Basket #
2. Order Info
3. RRP tax Exc
4. Ecost Exc (Actual Exc)
5. RRP tax Included
6. Ecost Tax Included (Actual Inc)
7. Replacement Prie
8. Quantity
9. Total Tax Excluded
10. Total Tax Included

We will need to change the column configuration to match the table so it is
easy to hide the correct columns.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25492] Your Account Menu button does nothing on mobile devices

2020-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25492

Owen Leonard  changed:

   What|Removed |Added

 Depends on||18084

--- Comment #1 from Owen Leonard  ---
Bisecting: 0 revisions left to test after this (roughly 0 steps)
[fed5158d66abafbe482a3625fa010c160c82a529] Bug 18084: Language selector hidden
in user menu on mobile interfaces


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18084
[Bug 18084] Language selector is hidden in user menu on mobile interfaces
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18084] Language selector is hidden in user menu on mobile interfaces

2020-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18084

Owen Leonard  changed:

   What|Removed |Added

 Blocks||25492


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25492
[Bug 25492] Your Account Menu button does nothing on mobile devices
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25492] Your Account Menu button does nothing on mobile devices

2020-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25492

Owen Leonard  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
Version|19.11   |master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25555] Holds Queue sorts patrons by firstname

2020-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2

Lucas Gass  changed:

   What|Removed |Added

Summary|Holds Queue sorts patrons   |Holds Queue sorts patrons
   |my firstname|by firstname

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25556] New: Holds blocked when empty holdallowed value present in circulation_rules

2020-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25556

Bug ID: 25556
   Summary: Holds blocked when empty holdallowed value present in
circulation_rules
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Hold requests
  Assignee: stalkern...@gmail.com
  Reporter: nug...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, slavashish...@gmail.com

Holds blocked ("Cannot place hold" yellow notification window) for default rule
after onboarding.pl (web installation process). 

That happens because /cgi-bin/koha/installer/onboarding.pl script creates the
empty (holdallowed="") key/value pair in the circulation_rules table.

Probably empty ("") holdallowed key assumed to have the same behavior as
undef/NULL, because:

  - in the interface (/cgi-bin/koha/admin/smart-rules.pl) both are interpreted
as "Not set" (undef or ""),

  - if to remove this empty value for holdallowed from circulation_rules
table at all (so have it undef) holds allowed and not blocked.

  - in other cases if "holdallowed" has correct values from
the dropdown list (0, 1, 2, 3) - all works as expected.


I.e.:

  1. ="" has behavior as ="0",

  2. value absence (NULL/undef) has behavior as ="2" ("from any library").

  3. but for both values site interface shows "not set".

This makes confusion: in 1. it blocks holds, and in 2. it allows.

I propose we make both "" and undef work similarly as "not set" in "check if
holds allowed" code, and both to allow holds like undef now does.

And at the same time remove "" creation but use undef instead in the onboarding
process when done first rule creation.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25555] Holds Queue sorts patrons my firstname

2020-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2

Lucas Gass  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |lu...@bywatersolutions.com
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25555] Holds Queue sorts patrons my firstname

2020-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2

--- Comment #1 from Lucas Gass  ---
Created attachment 105159
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105159=edit
Bug 2: Invert patron name in holdsqueue.tt

TEST PLAN:
1. Have multiple holds from multiple patrons and run the holds queue cron to
populate the holds queue list.
2. Try sorting by patron and see that is sorts based on first name.
3. Apply patch
4. Try sorting again and now it should sort by surname.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25555] Holds Queue sorts patrons my firstname

2020-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2

Lucas Gass  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client

2020-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662

--- Comment #293 from Michal Denar  ---
I really like this idea. Czech Koha community want to help change this idea to
project. How can we cooperate? If we'll work together, we'll finish this
sooner. I hope.

Michal

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25555] New: Holds Queue sorts patrons my firstname

2020-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2

Bug ID: 2
   Summary: Holds Queue sorts patrons my firstname
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Hold requests
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: lu...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

The Holds Queue table sorts name by firstname which is less helpful than
sorting by surname

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25510] Typo in koha-common.postinst causing shell errors

2020-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25510

--- Comment #37 from Victor Grousset/tuxayo  ---
Is 19.05 also affected?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19889] LocalHoldsPriority needs exclusions

2020-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19889

Tomás Cohen Arazi  changed:

   What|Removed |Added

Version|unspecified |master
 CC||tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25411] Plugin routes cannot have anonymous access

2020-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25411

--- Comment #11 from Tomás Cohen Arazi  ---
(In reply to Jonathan Druart from comment #10)
> Created attachment 105157 [details] [review]
> Bug 25411: Group conditions in if elsif
> 
> Signed-off-by: Jonathan Druart 

Thanks, my initial implementation was a bit more complex (it involved forcing a
new layout on the plugins side) and when I rolled it back I forgot this).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25411] Plugin routes cannot have anonymous access

2020-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25411

Tomás Cohen Arazi  changed:

   What|Removed |Added

 QA Contact||jonathan.dru...@bugs.koha-c
   ||ommunity.org
   Patch complexity|--- |Small patch
   Assignee|jonathan.dru...@bugs.koha-c |tomasco...@gmail.com
   |ommunity.org|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25551] [OMNIBUS] Some tests are failing randomly

2020-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25551

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 CC||vic...@tuxayo.net

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24854] Remove IDreamBooks integration

2020-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24854

--- Comment #18 from Joy Nelson  ---
(In reply to Jonathan Druart from comment #17)
> (In reply to Joy Nelson from comment #16)
> > Thanks for the rebase - pushed to 19.11.x for 19.11.06
> 
> I should note that it's not really a rebase: the patch for 19.11 is only
> adding a DB update entry to disable the sysprefs.

heh- i noticed that!  Nick mentioned I do the same as you did, but I thought
y'all might want to remove all the related code as well.  :D

Removing the sysprefs is pretty effective I'd say!

Thanks
joy

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24301] Holds to pull: Name of borrower on list

2020-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24301

Nick Clemens  changed:

   What|Removed |Added

 Status|Passed QA   |Failed QA

--- Comment #10 from Nick Clemens  ---
This breaks the count of holds:
place 2 holds
"pull this many items" on report says 2
Apply patch
Now it says 1

The information will still be wrong if the holds queue is running, because it
may select a hold that is not priority one when associating items

Additionally,  transfer limits and localholdspriority will affect which hold is
pulled

This is similar to bug 19288

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22660] Allow use of CodeMirror for editing HTML in the news editor

2020-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22660

Lucas Gass  changed:

   What|Removed |Added

 Attachment #105129|0   |1
is obsolete||

--- Comment #12 from Lucas Gass  ---
Created attachment 105158
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105158=edit
Bug 22660: Add system pref to allow switching of editors in News Tool

This patch adds a system preference called 'NewsToolEditor' which allows for
the choice between TinyMCE and CodeMirror in the News Feature.

TEST PLAN:
1. Apply patch and run updatedatabase
2. Go to Tools > News and make a new entry or edit an existing News item.
3. When you initially load you should gte the TinyMCE editor (WYSIWYG)
4. Search for the NewsToolEditor system preference and switch to CodeMirror.
5. Reload your News item and now you should see the CodeMirror editor.
6. Try saving content with both and maki sure it works.
7. Try adding some different HTML tags in CodeMirror mode, saving, and making
sure it looks right when you switch back to TinyMCE

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24347] Add a 'search to order' function

2020-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24347

--- Comment #21 from Martin Renvoize  ---
Did anyone sponsor this one?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24675] No update of the list of MARC21 subfields in C4/Heading/MARC21.pm, Generated authorities are missing subfields

2020-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24675

Martin Renvoize  changed:

   What|Removed |Added

   Severity|critical|normal
 CC||martin.renvoize@ptfs-europe
   ||.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24854] Remove IDreamBooks integration

2020-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24854

--- Comment #17 from Jonathan Druart  
---
(In reply to Joy Nelson from comment #16)
> Thanks for the rebase - pushed to 19.11.x for 19.11.06

I should note that it's not really a rebase: the patch for 19.11 is only adding
a DB update entry to disable the sysprefs.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25517] Koha.mo not found on pacakge installations / Translations not working

2020-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25517

Katrin Fischer  changed:

   What|Removed |Added

Summary|Translation of item/items   |Koha.mo not found on
   |in availability on staff|pacakge installations /
   |search results broken   |Translations not working
 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW

--- Comment #5 from Katrin Fischer  ---
Needs to be confirmed for other versions than 18.11, but I18N.pm hasn't
changed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25411] Plugin routes cannot have anonymous access

2020-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25411

--- Comment #10 from Jonathan Druart  
---
Created attachment 105157
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105157=edit
Bug 25411: Group conditions in if elsif

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25449] Make itemtype mandatory by default

2020-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25449

Jonathan Druart  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c
   |ity.org |ommunity.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25411] Plugin routes cannot have anonymous access

2020-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25411

--- Comment #9 from Jonathan Druart  
---
Created attachment 105156
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105156=edit
Bug 25411: Add special handling for public plugin routes

This patch implements the required logic in the API code so plugins are
not affected by the new RESTPublicAnonymousRequests system preference.
It is up to the plugin develpers to handle this

To test:
1. Apply the tests patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/REST/Plugin/PluginRoutes.t
=> FAIL: Notice the tests fail
3. Apply this patch
4. Repeat 2
=> SUCCESS: Tests pass! Yay! Not bad for a friday evening!
5. Sign off :-D

Sponsored-by: ByWater Solutions
Signed-off-by: Victor Grousset/tuxayo 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25411] Plugin routes cannot have anonymous access

2020-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25411

Jonathan Druart  changed:

   What|Removed |Added

 Attachment #104978|0   |1
is obsolete||
 Attachment #104979|0   |1
is obsolete||

--- Comment #8 from Jonathan Druart  
---
Created attachment 105155
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105155=edit
Bug 25411: Regression tests

This patch adds tests the new RESTPublicAnonymousRequests syspref
doesn't apply to routes added by plugins.

It is up to the plugin developer to handle those conditions.

To test:
1. Apply this patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/REST/Plugin/PluginRoutes.t
=> FAIL: Notice the tests fail

Signed-off-by: Victor Grousset/tuxayo 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25411] Plugin routes cannot have anonymous access

2020-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25411

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25449] Make itemtype mandatory by default

2020-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25449

--- Comment #1 from Jonathan Druart  
---
*** Bug 24331 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25532] Add a wikipedia-style search suggestion feature to the OPAC

2020-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25532

David Roberts  changed:

   What|Removed |Added

 Status|Needs Signoff   |ASSIGNED

--- Comment #5 from David Roberts  ---
(In reply to Owen Leonard from comment #4)
> This is really interesting, and works well. However, I'm concerned about the
> possibility of confusion on the part of the user.
> 
> My assumption is that if a user is familiar with how autocomplete works,
> they will assume that autocomplete is pulling from a list of existing
> values. I think it will be confusing for a patron to select from the
> suggested Wikipedia terms only to find that nothing in the catalog matches.
> 
> It's nonsensical to see in the suggestions an entry like "Harry Potter and
> the Deathly Hallows – Part 1 (disambiguation)."
> 
> A partial solution might be to add more explicit labeling to the
> autocomplete. Something like, "Search terms by Wikipedia" or something like
> that. I would suggest that the preference be renamed as well to something
> like "OPACWikipediaSearchSuggestions."

I'd go along with that - I had trouble thinking what to call this feature when
I was writing it! I'll change the naming.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24331] Internal server error when placing hold on item if itemtype undefined

2020-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24331

Jonathan Druart  changed:

   What|Removed |Added

 Status|Failed QA   |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #7 from Jonathan Druart  
---
https://meetings.koha-community.org/2020/development_irc_meeting_20_may_2020.2020-05-20-14.00.log.html

Search for "bug 24331".

We agreed on making it mandatory, see bug 25449.

*** This bug has been marked as a duplicate of bug 25449 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25554] Refactor rule kinds assignments in CirculationRules.pm

2020-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25554

Peter Vashchuk  changed:

   What|Removed |Added

 CC||nug...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25554] Refactor rule kinds assignments in CirculationRules.pm

2020-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25554

Peter Vashchuk  changed:

   What|Removed |Added

 CC||slavashish...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25554] Refactor rule kinds assignments in CirculationRules.pm

2020-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25554

--- Comment #1 from Peter Vashchuk  ---
Created attachment 105154
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105154=edit
Bug 25554: Refactor rule kinds assignments in CirculationRules.pm

CirculationRules.pm have repeated code with the same values assigned many times
to rule kinds and also same hardcoded values appear in foreach loop.
Refactored by creating arrays once and then assigning and looping their values.

Mentored-by: Andrew Nugged 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25554] Refactor rule kinds assignments in CirculationRules.pm

2020-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25554

Peter Vashchuk  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24854] Remove IDreamBooks integration

2020-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24854

Joy Nelson  changed:

   What|Removed |Added

 Version(s)|20.05.00|20.05.00, 19.11.06
released in||
 Status|Pushed to master|Pushed to stable

--- Comment #16 from Joy Nelson  ---
Thanks for the rebase - pushed to 19.11.x for 19.11.06

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15985] Include checkout library in fines

2020-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15985

Martin Renvoize  changed:

   What|Removed |Added

   Keywords||rel_20_11_target

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25517] Translation of item/items in availability on staff search results broken

2020-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25517

Katrin Fischer  changed:

   What|Removed |Added

 CC||ulrich.klei...@bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25517] Translation of item/items in availability on staff search results broken

2020-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25517

Katrin Fischer  changed:

   What|Removed |Added

 Resolution|WONTFIX |---
 Ever confirmed|1   |0
Summary|[18.11] Translation of  |Translation of item/items
   |item/items in availability  |in availability on staff
   |on staff search results |search results broken
   |broken  |
 Status|RESOLVED|UNCONFIRMED
 CC||julian.maur...@biblibre.com
Version|18.11   |unspecified

--- Comment #4 from Katrin Fischer  ---
We finally found a solution:

Koha/I18N.pm looks for the Koha.mo in the wrong path for package based
installations. It works fine on git, gitified etc. but not for an installatione
done from packages.

We solved it for now by creating a symlink.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25554] New: Refactor rule kinds assignments in CirculationRules.pm

2020-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25554

Bug ID: 25554
   Summary: Refactor rule kinds assignments in CirculationRules.pm
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Circulation
  Assignee: stalkern...@gmail.com
  Reporter: stalkern...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

Rule kinds in CirculationRules.pm have repeated code with the same values
assigned many times. Refactored code is already in a patch that will be pushed
promptly to this ticket.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25510] Typo in koha-common.postinst causing shell errors

2020-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25510

Joy Nelson  changed:

   What|Removed |Added

 Version(s)|20.05.00|20.05.00, 19.11.06
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25510] Typo in koha-common.postinst causing shell errors

2020-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25510

Joy Nelson  changed:

   What|Removed |Added

 Status|Pushed to master|Pushed to stable

--- Comment #36 from Joy Nelson  ---
19.11.x patches reviewed by Kyle and pushed by me for 19.11.06
Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25510] Typo in koha-common.postinst causing shell errors

2020-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25510

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com
 Attachment #105053|1   |0
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25510] Typo in koha-common.postinst causing shell errors

2020-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25510

Kyle M Hall  changed:

   What|Removed |Added

 Attachment #105153|Bug 25510: Put space|[19.11] Bug 25510: Put
description|between negation operator   |space between negation
   |and function name   |operator and function name

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25510] Typo in koha-common.postinst causing shell errors

2020-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25510

Kyle M Hall  changed:

   What|Removed |Added

 Attachment #105152|Bug 25510: Fix syntax error |[19.11] Bug 25510: Fix
description|in koha-common.postinst |syntax error in
   ||koha-common.postinst

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25510] Typo in koha-common.postinst causing shell errors

2020-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25510

Kyle M Hall  changed:

   What|Removed |Added

 Attachment #105053|0   |1
is obsolete||

--- Comment #35 from Kyle M Hall  ---
Created attachment 105153
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105153=edit
Bug 25510: Put space between negation operator and function name

This patch puts a space between the negation operator ! and
the function name (ie log4perl_component).

Signed-off-by: David Cook 
Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25510] Typo in koha-common.postinst causing shell errors

2020-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25510

Kyle M Hall  changed:

   What|Removed |Added

 Attachment #105134|0   |1
is obsolete||
 Attachment #105135|0   |1
is obsolete||

--- Comment #34 from Kyle M Hall  ---
Created attachment 105152
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105152=edit
Bug 25510: Fix syntax error in koha-common.postinst

Signed-off-by: David Cook 
Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25449] Make itemtype mandatory by default

2020-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25449

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org,
   ||l...@catalyst.net.nz,
   ||n...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25449] Make itemtype mandatory by default

2020-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25449

Martin Renvoize  changed:

   What|Removed |Added

   Keywords||rel_20_11_target
 CC||martin.renvoize@ptfs-europe
   ||.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24331] Internal server error when placing hold on item if itemtype undefined

2020-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24331

Martin Renvoize  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=25449
 CC||martin.renvoize@ptfs-europe
   ||.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25449] Make itemtype mandatory by default

2020-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25449

Martin Renvoize  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=24331

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25534] Add ability to send an email specifying a reason when canceling a hold

2020-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534

ByWater Sandboxes  changed:

   What|Removed |Added

 Attachment #105122|0   |1
is obsolete||

--- Comment #31 from ByWater Sandboxes  ---
Created attachment 105151
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105151=edit
Bug 25534: Add reason to pendingreserves.pl

Signed-off-by: Andrew Fuerste-Henry 

Signed-off-by: Rebecca Coert 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25534] Add ability to send an email specifying a reason when canceling a hold

2020-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534

ByWater Sandboxes  changed:

   What|Removed |Added

 Attachment #105119|0   |1
is obsolete||

--- Comment #28 from ByWater Sandboxes  ---
Created attachment 105148
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105148=edit
Bug 25534: Add ability to send an email specifying a reason when canceling a
hold

Some libraries would like to be able to cancel a hold with the option to
specify a reason. Providing a reason would generate an email to that
patron.

Test Plan:
1) Apply this patch
2) Run updatedatabase.pl
3) Restart all the things!
4) Create new AV category "HOLD_CANCELLATION", add some cancelation reasons
5) Add new Holds module notice "HOLD_CANCELLATION", add an email version.
   A quick test version would be "Reason: <>"
--
[% USE AuthorisedValues %]
Reason: [% AuthorisedValues.GetByCode( 'CANCELLATION_REASON',
hold.cancellation_reason, 'IS_OPAC' ) %]

[% IF hold.cancellation_reason == "MY_AV_VALUE" %]
IF perhaps you'd like to have a much longer explanation than just the
one sentence in the AV description, you can use IF blocks using Template
Toolkit markup!
[% END %]
--
6) Place a hold for a patron
7) On request.pl, select the 'del' option for the hold
8) Select a cancellation reason and choose "Update hold(s)"
9) Note a new message has been queue for the patron with the cancelation reason
11) Test again from circulation.pl
12) Test again from moremember.pl
10) Cancel a hold with no reason, note no email is generated
11) Delete your authorised values, not the feature is disabled
12) Reinstate the authorised values, but delete the notice,
you should now be able to cancel a hold with a reason,
but no email will be generated

Signed-off-by: Andrew Fuerste-Henry 

Signed-off-by: Rebecca Coert 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25534] Add ability to send an email specifying a reason when canceling a hold

2020-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534

ByWater Sandboxes  changed:

   What|Removed |Added

 Attachment #105121|0   |1
is obsolete||

--- Comment #30 from ByWater Sandboxes  ---
Created attachment 105150
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105150=edit
Bug 25534: Use the cancelation reasion for the 'X' hold cancelation links

Signed-off-by: Andrew Fuerste-Henry 

Signed-off-by: Rebecca Coert 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25534] Add ability to send an email specifying a reason when canceling a hold

2020-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534

ByWater Sandboxes  changed:

   What|Removed |Added

 Attachment #105120|0   |1
is obsolete||

--- Comment #29 from ByWater Sandboxes  ---
Created attachment 105149
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105149=edit
Bug 25534: Update Schema Files [DO NOT PUSH]

Signed-off-by: Andrew Fuerste-Henry 

Signed-off-by: Rebecca Coert 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25534] Add ability to send an email specifying a reason when canceling a hold

2020-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534

ByWater Sandboxes  changed:

   What|Removed |Added

 Attachment #105118|0   |1
is obsolete||

--- Comment #27 from ByWater Sandboxes  ---
Created attachment 105147
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105147=edit
Bug 25534: Update database

Signed-off-by: Andrew Fuerste-Henry 

Signed-off-by: Rebecca Coert 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20168] Update of the OPAC bootstrap template to bootstrap v4

2020-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25411] Plugin routes cannot have anonymous access

2020-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25411

Jonathan Druart  changed:

   What|Removed |Added

   Assignee|tomasco...@gmail.com|jonathan.dru...@bugs.koha-c
   ||ommunity.org
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   3   >