[Koha-bugs] [Bug 25889] Increase performance of debian/list-deps script
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25889 Mason James changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org, ||martin.renvoize@ptfs-europe ||.com, tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25943] New: Haii
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25943 Bug ID: 25943 Summary: Haii Change sponsored?: --- Product: Koha Version: 19.11 Hardware: HP OS: Other Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: chresstivenr...@gmail.com QA Contact: testo...@bugs.koha-community.org Created attachment 106622 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106622=edit Halo -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17314] Routes to create, list and delete a purchase suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314 --- Comment #41 from Arthur Suzuki --- Hi Tomas, Since you've been doing most of the rework on this patch i thought maybe it would be best to have you as assignee. I've just tried to test it and maybe signoff (also a good reason for not being assignee myself) but failed to apply on current master. Kr, Arthur arthur@carl9000:~/repos/koha$ git bz apply 17314 Bug 17314 - Routes to create, list and delete a purchase suggestion 93761 - Bug 17314: Routes to handle purchase suggestions 93762 - Bug 17314: Migration from Swagger2 to OpenApi 93763 - Bug 17314: QA Followup 93764 - Bug 17314 : Added _to_model and _to_api methods and changed attirbutes naming 93765 - Bug 17314: (QA follow-up) Adjust spec Apply? [(y)es, (n)o, (i)nteractive] y Application de Bug 17314: Routes to handle purchase suggestions Utilisation de l'information de l'index pour reconstruire un arbre de base... M Koha/Patron.pm M api/v1/swagger/definitions.json M api/v1/swagger/parameters.json M api/v1/swagger/paths.json Retour à un patch de la base et fusion à 3 points... Fusion automatique de api/v1/swagger/paths.json CONFLIT (contenu) : Conflit de fusion dans api/v1/swagger/paths.json Fusion automatique de api/v1/swagger/parameters.json Fusion automatique de api/v1/swagger/definitions.json CONFLIT (contenu) : Conflit de fusion dans api/v1/swagger/definitions.json Fusion automatique de Koha/Patron.pm CONFLIT (contenu) : Conflit de fusion dans Koha/Patron.pm error: Échec d'intégration des modifications. le patch a échoué à 0001 Bug 17314: Routes to handle purchase suggestions astuce: Utilisez 'git am --show-current-patch' pour visualiser le patch en échec When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-17314-Routes-to-handle-purchase-suggestions-OvK0GF.patch arthur@carl9000:~/repos/koha$ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17314] Routes to create, list and delete a purchase suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314 Arthur Suzuki changed: What|Removed |Added Assignee|arthur.suz...@biblibre.com |tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24480] Fields added with Marc modifications templates are not added in an ordered way
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24480 --- Comment #8 from Arthur Suzuki --- done, sry for the delay :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24480] Fields added with Marc modifications templates are not added in an ordered way
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24480 --- Comment #7 from Arthur Suzuki --- Created attachment 106621 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106621=edit Bug 24480: (QA follow-up) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24480] Fields added with Marc modifications templates are not added in an ordered way
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24480 Arthur Suzuki changed: What|Removed |Added Status|Failed QA |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25942] Batch biblio operations on report results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25942 Nick Clemens changed: What|Removed |Added Depends on||24886 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24886 [Bug 24886] Reports template should be reindented -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24886] Reports template should be reindented
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24886 Nick Clemens changed: What|Removed |Added Blocks||25942 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25942 [Bug 25942] Batch biblio operations on report results -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25942] New: Batch biblio operations on report results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25942 Bug ID: 25942 Summary: Batch biblio operations on report results Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Reports Assignee: koha-bugs@lists.koha-community.org Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org Bug 24886 cleaned up the templates and removed a new line in the recordnumber_list textarea loop Now if one tries to send biblionumbers from a report to batch operations they are all sent as a single string -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25801] Add itemnumber parameter to opac-detail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25801 --- Comment #18 from David Cook --- (In reply to Marcel de Rooy from comment #17) > See also comment1. This is a first attempt to quickly have an item landing > page (hacking just a few lines). And yes, the item persistent identifier to > be used in RDF subjects should be resolved by the opac-detail item page when > content negotiation comes down to HTML. I don't see a use case in Comment 1. RDF subjects was my first thought, although reading more about RPC and REST APIs and thinking that having a canonical item URL (or PID) could be useful for a REST API (better to return a URL rather than an itemnumber for instance). I was wondering if you had a particular use case that you plan to use this for in the short term is all. Like is the HTML representation important in your use case? Or is it just to uniquely identify the resource (say for a RDF subject or REST API)? I think it's a great idea, but I'm just curious about the implementation. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24157] Additional acquisitions permissions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24157 Katrin Fischer changed: What|Removed |Added Component|Architecture, internals,|Acquisitions |and plumbing| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23796] Convert OpacCustomSearch system preference to news block
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23796 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23796] Convert OpacCustomSearch system preference to news block
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23796 Katrin Fischer changed: What|Removed |Added Attachment #103324|0 |1 is obsolete|| --- Comment #5 from Katrin Fischer --- Created attachment 106620 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106620=edit Bug 23796: Convert OpacCustomSearch system preference to news block This patch moves the OpacCustomSearch system preference into the Koha news system, making it possible to have language- and library-specific content. To test you should have some content in the OpacCustomSearch system preference. Apply the patch and run the database update process. - Go to the OPAC and confirm that the content which was previously in the OpacCustomSearch system preference now displays correctly where it was before. - In the staff client, go to Tools -> News and verify that the content from OpacCustomSearch is now stored in news items. There should be one entry for each of the enabled translations in your system, for instance 'OpacCustomSearch_en', 'OpacCustomSearch_fr-FR', 'OpacCustomSearch_cs-CZ' - Go to Administration -> System preferences and confirm that the OpacCustomSearch preference has been removed. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22544] Move C4:NewsChannels to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #66 from Katrin Fischer --- (In reply to Martin Renvoize from comment #65) > I've looked at this a fair bit the past couple of days, and it certainly > does move us from C4 to Koha.. and does an amount of tidying.. > > However, I'm torn as I feel we could afford to go a fair bit further. The > field names are out right confusing and the logic is somewhat weird. > > Are you intending on treating this as a first step Josef or was this as far > as you intended going? > > I think we've missed 20.05 now I'm afraid, but as we're moving lots of > preferences over to this area perhaps it's time to focus on it more and > further clean and improve both the db structure and logic early next > release.? Setting to Failed QA to trigger a comment from Josef :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25237] Accessibility: The 'Author details' in the full record display contains semantically incorrect headings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25237 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25237] Accessibility: The 'Author details' in the full record display contains semantically incorrect headings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25237 Katrin Fischer changed: What|Removed |Added Attachment #106182|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 106619 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106619=edit Bug 25237: Fix semantic heading for opac-details Prior to this patch the opac-details view contained semantically incorrect h3 headings for the author information. Test plan 1/ Perform a search in the OPAC that will yield results 2/ Navigate to any results detailed view 3/ Inspect the page and note that there are semantically incorrect headings H1 (Page title) > H2 (Item title) > H5 (Author) 4/ Apply the patch 5/ Reload the page 6/ Inspect the page and note that the semantically incorrect author block has been converted to a span with an 'h3' class for styling 7/ Note the page still appears nicely 8/ Signoff Bonus points: Check with XSLT views enabled and disabled. Signed-off-by: Sally Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25155] Accessibility: The 'Login modal' contains semantically incorrect headings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25155 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25155] Accessibility: The 'Login modal' contains semantically incorrect headings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25155 Katrin Fischer changed: What|Removed |Added Attachment #105757|0 |1 is obsolete|| --- Comment #13 from Katrin Fischer --- Created attachment 106618 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106618=edit Bug 25155: (follow-up) Increase headings levels by 1 In the previous patch we reduced the headings levels by 2, but this was one level too many as we already have an H1 in the navbar and so all other heading sets should start at level 2 to semantically follow the title heading. Signed-off-by: Sally Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25427] Make authority subfield management interface consistent with bibliographic subfield management view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25427 Katrin Fischer changed: What|Removed |Added Attachment #106263|0 |1 is obsolete|| --- Comment #4 from Katrin Fischer --- Created attachment 106617 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106617=edit Bug 25427: Make authority subfield management interface consistent MARC view This patch makes a couple of minor changes to the authority MARC subfield structure administration interface to make it more consistent with the corresponding MARC subfield interface. To test, apply the patch and go to Administration -> Authority types. - Pick an authority type to edit, for instance PERSO_NAME, and choose 'MARC structure' from the Actions menu. - Pick a tag to edit and select "Subfields" from the Actions menu. - In the table of subfields for that tag, each subfield in the first column should link to the edit interface for that subfield (its tab pre-selected). - The "Edit" button in that table should do the same. Signed-off-by: Heather Hernandez Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25427] Make authority subfield management interface consistent with bibliographic subfield management view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25427 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25427] Make authority subfield management interface consistent with bibliographic subfield management view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25427 Katrin Fischer changed: What|Removed |Added Summary|Make authority subfield |Make authority subfield |management interface|management interface |consistent MARC view|consistent with ||bibliographic subfield ||management view -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25869] Coce images not loading for lists (virtualshelves)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25869 Katrin Fischer changed: What|Removed |Added Attachment #106259|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 106616 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106616=edit Bug 25869: Fix Coce display for lists To test: 1 - Enable Coce for Opac CoceHost: https://coce.bywatersolutions.com CoceProviders: Select all OpacCoce: Enable 2 - Do a search on the Opac, confirm you see some covers 3 - Add some of the items with covers to a public list 4 - View the public list 5 - Note no covers display 6 - Apply patch 7 - Success! Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25869] Coce images not loading for lists (virtualshelves)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25869 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 --- Comment #239 from Victor Grousset/tuxayo --- > is there a way to disable the output Found. The declarations of the views can be found with `git grep "ResultSource::View"` Beside from me removing them now to check for other warnings. We might want later to not have the tests logs cluttered with this right? Should I create a followup bug about hiding the output of view creations? (happens more than 100 times in the full suite) So the results: no suspicious difference found in the output between running the test suite without and with the patch set. Typo found: installer/data/mysql/atomicupdate/bug_20271_-_merge_deletedbiblio_and_deleteitems_tables_with_their_alive_cousins.perl > # Create the views for backward compatibility in reportrs «reportrs» -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25890] Checkouts table not sorting on check out date correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25890 Katrin Fischer changed: What|Removed |Added Attachment #106600|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 106615 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106615=edit Bug 25890: Update sorting column for checkouts table Test plan: - Check some items out, all from different libraries - Modify the checkout and due dates, like: 2018-10-22 2018-01-23 2018-05-27 - Sort by checkout date, verify it is actually sorting on homebranch - Apply patch - Reload page - Note you can now sort items correctly Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25890] Checkouts table not sorting on check out date correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25890 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25799] Edition information to Holds queue report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25799 Katrin Fischer changed: What|Removed |Added Attachment #106454|0 |1 is obsolete|| --- Comment #7 from Katrin Fischer --- Created attachment 106614 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106614=edit Bug 25799: Add edition information to "Holds queue" report Added a feature that displays edition information of the book together with title in "Holds queue" report. Edition information is fetched from "biblioitem" table as "editionstatement" and transferred to template. 1. Place a hold on a book with edition information. 2. Run build_holds_queue.pl cron job. 3. Go to /cgi-bin/koha/circ/view_holdsqueue.pl and check the "title" table of that book that you placed hold on. 4. Observe that there's no information about edition of that book. 5. Apply patch. 6. Repeat step 3. 7. Observe that cinformation about edition of that book appeared in the title table after book's title and author. Mentored-by: Andrew Nugged Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25799] Edition information to Holds queue report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25799 Katrin Fischer changed: What|Removed |Added Version|20.05 |master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25799] Edition information to Holds queue report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25799 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25940] Two separate print dialogs when checking in/transferring an item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25940 Lisette Scheer changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25031] Improve handling of multiple covers on the biblio detail page in the staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25031 Katrin Fischer changed: What|Removed |Added Attachment #105987|0 |1 is obsolete|| --- Comment #14 from Katrin Fischer --- Created attachment 106613 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106613=edit Bug 25031: (QA follow-up) Improve handling of one or fewer images This patch addresses a few issues raised during QA: 1. If there are no images, avoid the momentary appearance of an empty borered box. The class controlling the appearance of the box is now added after initialization. 2. If there is only one image, remove the control for switching between covers. 3. Add "preventDefault" to cover naviation click handler. 4. Correct translation function in localcovers.js. This patch modifies SCSS, so rebuilding the staff client CSS is necessary for testing. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25031] Improve handling of multiple covers on the biblio detail page in the staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25031 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25031] Improve handling of multiple covers on the biblio detail page in the staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25031 Katrin Fischer changed: What|Removed |Added Attachment #105986|0 |1 is obsolete|| --- Comment #13 from Katrin Fischer --- Created attachment 106612 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106612=edit Bug 25031: Improve handling of multiple covers on the biblio detail page in the staff client This patch modifies the template, JS, and CSS for the bibliographic detail page in order to gracefully handle multiple cover images. The changed version loops through any cover images which might be embedded and checks that they are successfully loaded. Only successfully-loaded images are shown. Only the first image is shown, and the others can be "paged through" using generated navigation controls. To test, apply the page and rebuild the staff client CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). Enable multiple cover image services. The patch was developed with these services available: - Amazon - Local cover images (including multiple local cover images) - Coce (serving up Amazon, Google, and OpenLibrary images) - Images from the CustomCoverImages preference View a variety of titles and confirm that the cover images are displaying correctly, whether there be 0, 1, 2, or more covers available. Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25940] Two separate print dialogs when checking in/transferring an item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25940 ByWater Sandboxes changed: What|Removed |Added Attachment #106605|0 |1 is obsolete|| --- Comment #2 from ByWater Sandboxes --- Created attachment 106611 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106611=edit Bug 25940: Check for reserve_id before Dopop TEST PLAN: 1. Have an item belonging to a different branch and check it in. 2. When the modal pops up hit 'Yes, print slip' or 'Print slip' if AutomaticItemReturn is set to 'don't' 3. The first print dialog should appear with a URL like '/cgi-bin/koha/circ/transfer-slip.pl?transferitem=18&=CPL=slip' 4. Close that print dialog and you will immediately see another one that says 'No slip template found'. 5. Notice the URL of the second pop-up is: /cgi-bin/koha/circ/hold-transfer-slip.pl?reserve_id= 6. There is no reserve id so the template is not found. 7. Apply patch 8. Repeat 1-6 9. You should no longer have two print dialogs Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25031] Improve handling of multiple covers on the biblio detail page in the staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25031 --- Comment #12 from Katrin Fischer --- I really like this, would love to see results changed as well! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25940] Two separate print dialogs when checking in/transferring an item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25940 Lisette Scheer changed: What|Removed |Added CC||lisettesla...@gmail.com Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24519] Change calculation and validation in Point of Sale should match Paycollect
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24519 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Patch doesn't apply --- Comment #3 from Katrin Fischer --- Please rebase! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23092] Transfers should record 'requested' as well as 'sent' and 'arrived' dates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23092 --- Comment #15 from Katrin Fischer --- Is there a situation currently where date requested and date sent will be different? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23092] Transfers should record 'requested' as well as 'sent' and 'arrived' dates.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23092 Katrin Fischer changed: What|Removed |Added Attachment #105916|0 |1 is obsolete|| --- Comment #13 from Katrin Fischer --- Created attachment 106609 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106609=edit Bug 23092: Add 'daterequested' to branchtransfers table Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23092] Transfers should record 'requested' as well as 'sent' and 'arrived' dates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23092 Katrin Fischer changed: What|Removed |Added Summary|Transfers should record |Transfers should record |'requested' as well as |'requested' as well as |'sent' and 'arrived' dates. |'sent' and 'arrived' dates -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23092] Transfers should record 'requested' as well as 'sent' and 'arrived' dates.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23092 Katrin Fischer changed: What|Removed |Added Attachment #105917|0 |1 is obsolete|| --- Comment #14 from Katrin Fischer --- Created attachment 106610 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106610=edit Bug 23092: Add unit tests Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23092] Transfers should record 'requested' as well as 'sent' and 'arrived' dates.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23092 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20815] Add ability to choose if lost fee is refunded based on length of time item has been lost
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20815 Katrin Fischer changed: What|Removed |Added Attachment #106575|0 |1 is obsolete|| --- Comment #15 from Katrin Fischer --- Created attachment 106607 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106607=edit Bug 20815: Do not use compare float with precision Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20815] Add ability to choose if lost fee is refunded based on length of time item has been lost
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20815 Katrin Fischer changed: What|Removed |Added Attachment #105141|0 |1 is obsolete|| --- Comment #14 from Katrin Fischer --- Created attachment 106606 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106606=edit Bug 20815: Add ability to choose if lost fee is refunded based on length of time item has been lost This adds the ability to not refund lost item fees on return if the item has been lost for more than a given number of days. Test Plan: 1) Set the new system preference NoRefundOnLostReturnedItemsAge to a number of days 2) Find a lost item that has been lost longer than that NoRefundOnLostReturnedItemsAge days which would have otherwise been refunded 3) Return the item 4) Note no refund on the lost item fee was processed, the fee remains unchanged 5) prove t/db_dependent/Circulation.t Signed-off-by: Deb Stephenson Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20815] Add ability to choose if lost fee is refunded based on length of time item has been lost
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20815 --- Comment #16 from Katrin Fischer --- Created attachment 106608 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106608=edit Bug 20815: (QA follow-up) Add message to database update / rephrase pref - Make pref use "checked in" instead of "returned". - Add message to database update Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20815] Add ability to choose if lost fee is refunded based on length of time item has been lost
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20815 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25940] Two separate print dialogs when checking in/transferring an item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25940 --- Comment #1 from Lucas Gass --- Created attachment 106605 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106605=edit Bug 25940: Check for reserve_id before Dopop TEST PLAN: 1. Have an item belonging to a different branch and check it in. 2. When the modal pops up hit 'Yes, print slip' or 'Print slip' if AutomaticItemReturn is set to 'don't' 3. The first print dialog should appear with a URL like '/cgi-bin/koha/circ/transfer-slip.pl?transferitem=18&=CPL=slip' 4. Close that print dialog and you will immediately see another one that says 'No slip template found'. 5. Notice the URL of the second pop-up is: /cgi-bin/koha/circ/hold-transfer-slip.pl?reserve_id= 6. There is no reserve id so the template is not found. 7. Apply patch 8. Repeat 1-6 9. You should no longer have two print dialogs -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25941] Reindent Upload local cover image page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25941 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Small patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25941] Reindent Upload local cover image page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25941 --- Comment #2 from Owen Leonard --- Created attachment 106604 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106604=edit Bug 25941: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25941] Reindent Upload local cover image page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25941 --- Comment #1 from Owen Leonard --- Created attachment 106603 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106603=edit Bug 25941: Reindent Upload local cover image page This patch reindents the "Upload local cover image" template to make indentation consistent. Some lines have been split up. Some markup inconsistencies have been corrected. To test, apply the patch and enable the LocalCoverImages system preference. - Go to Tools -> Upload local cover image. - Test uploading single images or ZIP files of images. - Confirm that everything works as expected. Use your preferred method for checking the differences between files while ignoring whitespace. I use diff with the "-w" flag, but I'm not some kind of diff deity. The only changes you see should be split lines. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25941] New: Reindent Upload local cover image page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25941 Bug ID: 25941 Summary: Reindent Upload local cover image page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org Blocks: 25025 I propose to reformat the "Upload local cover image" template (tools/upload-images.tt) so that it has consistent spacing and indentation. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25025 [Bug 25025] Drag-and-drop cover image upload -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25025] Drag-and-drop cover image upload
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25025 Owen Leonard changed: What|Removed |Added Depends on||25941 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25941 [Bug 25941] Reindent Upload local cover image page -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25940] New: Two separate print dialogs when checking in/transferring an item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25940 Bug ID: 25940 Summary: Two separate print dialogs when checking in/transferring an item Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: lu...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com When transferring an item returns.tt is generating multiple print dialogs. I can only recreate this is Chrome but I have heard reports that this is happening in FireFox as well. TO RECREATE: (in Chrome) 1. Have an item belonging to a different branch and check it in. 2. When the modal pops up hit 'Yes, print slip' or 'Print slip' if AutomaticItemReturn is set to 'don't' 3. The first print dialog should appear with a URL like '/cgi-bin/koha/circ/transfer-slip.pl?transferitem=18&=CPL=slip' 4. Close that print dialog and you will immediately see another one that says 'No slip template found'. 5. Notice the URL of the second pop-up is: /cgi-bin/koha/circ/hold-transfer-slip.pl?reserve_id= 6. There is no reserve id so the template is not found. I cannot recreate this in FireFox and I am unsure why not. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 rkui...@roundrocktexas.gov changed: What|Removed |Added Blocks||25916 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25916 [Bug 25916] Create function and UI to modify budgets and funds. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24190] Add additional Acquisition logging
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 rkui...@roundrocktexas.gov changed: What|Removed |Added Blocks||25916 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25916 [Bug 25916] Create function and UI to modify budgets and funds. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25916] Create function and UI to modify budgets and funds.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25916 rkui...@roundrocktexas.gov changed: What|Removed |Added Depends on||23971 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 [Bug 23971] Add logging for basket related actions -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25916] Create function and UI to modify budgets and funds.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25916 rkui...@roundrocktexas.gov changed: What|Removed |Added Depends on||24190 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190 [Bug 24190] Add additional Acquisition logging -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611 Pablo AB changed: What|Removed |Added CC||pablo.bian...@gmail.com --- Comment #56 from Pablo AB --- On 20.05 this seems to add an untranslatable "Not for loan" near span.notforloan, on MARC21slim2OPACResults.xsl. I reproduce it on Michael Kuhn's Koha demo: 1. On a biblio, add an item to an item type flagged with "not for loan"=Yes 2. Search for it on the OPAC - German: "Verfügbarkeit: Ausleihbare Exemplare: (1). Verfügbarer Präsenzbestand: Not for loan (1).". http://koha.adminkuhn.ch/cgi-bin/koha/opac-search.pl?q=Dictionary - Spanish: "Disponibilidad: Not for loanSignatura topográfica: 520 A552 (1). :". -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22728] Manual for BorrowerMandatoryField should include note on extended attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22728 Christopher Brannon changed: What|Removed |Added CC||cbran...@cdalibrary.org --- Comment #16 from Christopher Brannon --- (In reply to Andrew Fuerste-Henry from comment #14) > Given enough time, I could probably get around to arguing either side of > this. But I think I'm leaning more toward putting it in the attribute setup. > There's enough specific setup stuff for each attribute there already that I > think that's where folks are more likely to expect this. +1 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22818] ILL should be able to send notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818
Katrin Fischer changed:
What|Removed |Added
Status|Patch doesn't apply |Signed Off
--- Comment #50 from Katrin Fischer ---
I am still working on this, but adding some first notes and questions:
1) QA test tools
FAIL Koha/MessageAttributes.pm
FAIL forbidden patterns
forbidden pattern: Incorrect license statement (using postal
address), may be a false positive if the file is coming from outside Koha (bug
24545) (line 16)
FAIL Koha/MessageAttribute.pm
FAIL forbidden patterns
forbidden pattern: Incorrect license statement (using postal
address), may be a false positive if the file is coming from outside Koha (bug
24545) (line 16)
2) Unit tests
While tests pass, they produce some non-good looking output:
kohadev-koha@kohadevbox:/home/vagrant/kohaclone$ prove
t/db_dependent/Illrequests.t
t/db_dependent/Illrequests.t .. 7/12 Use of uninitialized value $staff_to_send
in pattern match (m//) at /home/vagrant/kohaclone/Koha/Illrequest.pm line 1522.
Koha::Illrequest::send_staff_notice(Koha::Illrequest=HASH(0x55b06c17ba40),
"ILL_REQUEST_CANCEL") called at /home/vagrant/kohaclone/Koha/Illrequest.pm line
288
Koha::Illrequest::status(Koha::Illrequest=HASH(0x55b06c17ba40),
"CANCREQ") called at t/db_dependent/Illrequests.t line 788
main::__ANON__() called at /usr/share/perl5/Test/Builder.pm line 310
eval {...} called at /usr/share/perl5/Test/Builder.pm line 310
Test::Builder::subtest(Test::Builder=HASH(0x55b06bac3bf8), "Helpers",
CODE(0x55b063112be8)) called at /usr/share/perl5/Test/More.pm line 807
Test::More::subtest("Helpers", CODE(0x55b063112be8)) called at
t/db_dependent/Illrequests.t line 934
t/db_dependent/Illrequests.t .. ok
All tests successful.
Files=1, Tests=12, 32 wallclock secs ( 0.09 usr 0.03 sys + 21.40 cusr 6.88
csys = 28.40 CPU)
Result: PASS
3) Code Review
3.1) Email addressing
I feel like here is a general issue here in that we will have problems with
spam protection if the mail server is not in the same domain as the
branchillemail given.
Is the the new ILL staff email is to be used as the sender or the recipient of
the ILL emails to staff? It looks like it's actually used as both? As the pref
only reads "to", maybe we could just keep the current from and it would resolve
a lot of the possible issues with spam.
I think we need to at least make use of $library->inbound_email_address in a
couple of cases replacing the branchemail here:
+my $from = $branch->branchillemail || $branch->branchemail;
get_staff_to_address seems ok in that regard, but send_staff_notice from_adress
does not.
Reply-to and From are the spam critical ones.
Use of Koha::Email is removed?
3.2) Translatability
The "N/A" here are problematic. I think it would be better to just create an
empty string? With TT libraries can still resolve that to another text.
+substitute => {
+ill_bib_title => $title ? $title->value : 'N/A',
+ill_bib_author => $author ? $author->value : 'N/A',
3.3) Sample letters
I need to take a closer look for typos and such, but the sample letters need to
also be added to the new sample .yml and to the translated installers.
3.4) Sysprefs.sql
New prefs are in the wrong alphabetic spot :)
3.5) Notices & slips
The module in the letters summary table is not translatable yet and shows as
"ill".
-
Most of those are not bad ones, only 3.1 Email addressing worries me a fair
bit. Clearing up intentions and intended behaviour would be a good firs step
here.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25893] Log viewer no longer searches using wildcards
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25893
--- Comment #5 from Nick Clemens ---
(In reply to Matthias Meusburger from comment #3)
> The patch works as intended.
>
> However, using a wildcard on object (which is an identifier) does not seem
> to be a good idea, since you will retrieve many unwanted results.
>
> Moreover, the wildcard in C4::Logs::GetLogs was only on info, and not on
> object:
>
> if ($object) {
> $query .= " AND object = ? ";
> push( @parameters, $object );
> }
>
> Hence, it doesn't restore the old behavior, but changes it.
>
> What do you think?
Yup, I just got mixed up, removed wildcards from object
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25893] Log viewer no longer searches using wildcards
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25893 --- Comment #4 from Nick Clemens --- Created attachment 106602 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106602=edit Bug 25893: Don't wildcard object -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25893] Log viewer no longer searches using wildcards
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25893 Nick Clemens changed: What|Removed |Added Status|In Discussion |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25709] Rename systempreference from NotesBlacklist to NotesDenylist
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25709 --- Comment #10 from Nick Clemens --- Removed old update and release note changes Renamed to OpacHiddenNotes (like OpacHiddenItems) There is an atomic update to change existing installs -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25709] Rename systempreference from NotesBlacklist to NotesDenylist
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25709 Nick Clemens changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25709] Rename systempreference from NotesBlacklist to NotesDenylist
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25709 Nick Clemens changed: What|Removed |Added Attachment #105702|0 |1 is obsolete|| --- Comment #9 from Nick Clemens --- Created attachment 106601 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106601=edit Bug 25709: Rename systemprefrence to OpacHiddenNotes To test: 1 - Apply patch and updatedatabase 2 - git grep NotesBlacklist 3 - Note all remaining occurrences are translations, db updates, and release notes 4 - Add a field (e.g. '520' ) to the OpacHiddenNotes systempreference 5 - View a record with a 520 field on the opac 6 - Confirm the field does not show in the 'Title notes' tab -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19889] LocalHoldsPriority needs exclusions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19889
--- Comment #21 from Tomás Cohen Arazi ---
(In reply to Christopher Brannon from comment #20)
> * This system preference would take a list of patron categories
> * Alter code to ignore local holds priority for these
>
> Talk to me about the reasoning for the placement of the patron exclusion in
> the patron category rather than a central preference that was outlined here.
> I just want to understand before you do anything.
The original idea was to add a syspref, as you outline. I'm the one that
decided it was better to make it a patron category attribute. This, because the
syspref is basically a way to say something about the category, but in a place
that is not tied to categories (and thus unnatural).
This is the reasoning:
From the coding point of view, we might need/want to ask if a patron belongs to
a category that is excluded from localholdspriority, and we would do it like
this:
# Find the patron
my $patron = Koha::Patrons->find($request->{borrowernumber});
# skip the patron if its category is excluded
next if $patron->category->exclude_from_local_holds_priority;
if we go the sysprefs way it would read like:
my @excluded_categories = split(/\|/,
C4::Context->preference("CategoriesToExcludeFromLocalHoldsPriority")) // ();
my $patron = Koha::Patrons->find($request->{borrowernumber});
next if any { $_ eq $patron->categorycode } @excluded_categories;
So the result is similar, but ugly-ish. And involves an error prone free-text
field with pipe-separated values. So I don't see any advantage on it. If we
were to expose this condition on the API also, we would need to add methods to
extract the boolean with this kind of comparison, instead of just reading
what's on the category table.
That said, we can absolutely roll back to the syspref approach and come back to
refactor this later. Once we have a more clear interface for setting all things
related to local holds priorities in a single place. As I understand your point
of the whole setting being sparse in different places being counter-intuitive.
> My comment about the priority for the item not showing as set still stands.
> That is confusing.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22844] Simplify the process of selecting database columns for system preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844 Christopher Brannon changed: What|Removed |Added CC||cbran...@cdalibrary.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19889] LocalHoldsPriority needs exclusions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19889 --- Comment #20 from Christopher Brannon --- Please the last paragraph in my comment about the criteria. I was going off the original description in this bug rather than the signed contract. This is what the contract called for: * Add a new column to the items table - 'ExcludeFromLoaclHoldsPriority' or similar * Addd the ability to mark the item from the items tab or the batch item modification page * Add a system preference 'CategoriesToExcludeFromLocalHoldsPriority' * This system preference would take a list of patron categories * Alter code to ignore local holds priority for these Talk to me about the reasoning for the placement of the patron exclusion in the patron category rather than a central preference that was outlined here. I just want to understand before you do anything. My comment about the priority for the item not showing as set still stands. That is confusing. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22844] Simplify the process of selecting database columns for system preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844 Katrin Fischer changed: What|Removed |Added CC||cmurd...@ccfls.org --- Comment #120 from Katrin Fischer --- *** Bug 4030 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4030] Patron attribute types cannot be made mandatory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4030 Katrin Fischer changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |DUPLICATE --- Comment #11 from Katrin Fischer --- Good news here! This is implemented, but a little hidden in a patch I just tested: Bug 22844 - Simplify the process of selecting database columns for system preferences *** This bug has been marked as a duplicate of bug 22844 *** -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22818] ILL should be able to send notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 --- Comment #49 from Katrin Fischer --- (In reply to Katrin Fischer from comment #48) > (In reply to Andrew Isherwood from comment #47) > > Hi Katrin - This is now rebased, so all should be well! > > Hi Andrew, I tried to test, but it doesn't apply against master, because of > a conflict in branches.tt caused by bug 25288 (pushed on 24 June). It's not > a trivial fix, so I'd be happy if you could take a look, before I try. I might have gotten it fixed for now so I can continue testing... fingers crossed. Note: might need to re-add ill staff email to the library summary table. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22818] ILL should be able to send notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Patch doesn't apply --- Comment #48 from Katrin Fischer --- (In reply to Andrew Isherwood from comment #47) > Hi Katrin - This is now rebased, so all should be well! Hi Andrew, I tried to test, but it doesn't apply against master, because of a conflict in branches.tt caused by bug 25288 (pushed on 24 June). It's not a trivial fix, so I'd be happy if you could take a look, before I try. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25937] Notify patrons about failed login attempts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25937 George Williams (NEKLS) changed: What|Removed |Added CC||geo...@nekls.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25935] Use time-based mechanism for account lockout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25935 George Williams (NEKLS) changed: What|Removed |Added CC||geo...@nekls.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25936] Notify users if their password has changed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25936 George Williams (NEKLS) changed: What|Removed |Added CC||geo...@nekls.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4030] Patron attribute types cannot be made mandatory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4030 Lisette Scheer changed: What|Removed |Added CC||lisettesla...@gmail.com --- Comment #10 from Lisette Scheer --- +1 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25025] Drag-and-drop cover image upload
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25025 Owen Leonard changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25939] New: Print multiple copies with quick spine label creator
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25939 Bug ID: 25939 Summary: Print multiple copies with quick spine label creator Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Label/patron card printing Assignee: cnighswon...@foundations.edu Reporter: and...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org For libraries that purchase several copies of the same title, it'd be nice to have a quicker way to print several copies of the same spine label. Maybe something on spinelabel-home.pl that would let the user specify a number of copies? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25890] Checkouts table not sorting on check out date correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25890 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25890] Checkouts table not sorting on check out date correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25890 Owen Leonard changed: What|Removed |Added Attachment #106389|0 |1 is obsolete|| --- Comment #2 from Owen Leonard --- Created attachment 106600 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106600=edit Bug 25890: Update sorting column for checkouts table Test plan: - Check some items out, all from different libraries - Modify the checkout and due dates, like: 2018-10-22 2018-01-23 2018-05-27 - Sort by checkout date, verify it is actually sorting on homebranch - Apply patch - Reload page - Note you can now sort items correctly Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23391] Hide finished ILL requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23391 --- Comment #14 from Katrin Fischer --- I've heard about huge performance issues here as well for busy libraries and I think this is a good first step to fix the issue. In the future we could think about another option to pre-filter, but still allow to search with a limit on one of these status. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23391] Hide finished ILL requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23391 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23391] Hide finished ILL requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23391 Katrin Fischer changed: What|Removed |Added Attachment #106411|0 |1 is obsolete|| --- Comment #13 from Katrin Fischer --- Created attachment 106599 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106599=edit Bug 23391: Hide finished ILL requests Currently, the main table of ILL requests will display all ILL requests in the database, regardless of their status. For libraries with active ILL this quickly leads to a lot of requests being displayed, and the main page of the ILL module taking a long time to load. This patch proposes to fix this by introducing the ILLHiddenRequestStatuses syspref, which can take a pipe-separated list of ILL statuses that will be hidden from view in the ILL module. This means that the only way to find a hidden request will be through a report. To test: - Apply the patch and make sure the atomic database update is run - Make sure you have a few ILL requests, with at least two different statuses - Check that all requests are still displayed in the main table of ILL requests - Add one of the statuses* you have in your database to the ILLHiddenRequestStatuses syspref, reload the ILL module frontpage and verify that requests with the given status are not displayed - Change the syspref to another status and verify requests with that status are now hidden - Change the syspref to hold both statuses, separated by the pipe symbol (e.g.: A|B). Verify that no requests with the given statuses are now displayed - Run the ILL REST API tests, e.g.: $ sudo koha-shell -c "prove t/db_dependent/api/v1/illrequests.t" kohadev * = The ILLHiddenRequestStatuses syspref should hold status codes, like "REQ" and "NEW", not their human readable counterparts. Signed-off-by: Andrew Isherwood Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23258] Batch holding
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23258 Owen Leonard changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |matthias.meusburger@biblibr |ity.org |e.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23258] Batch holding
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23258 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #10 from Owen Leonard --- This looks like it's working pretty well but I'd like to see a couple of improvements to the information provided to the user during the process. Can we add title information to the lists of submitted barcodes? Both on the screen with the checkboxes and on the confirmation page after submission. I think it would also be good to show the patron and pickup branch information on these screens. The final result screen should provide links to both the bibliographic record detail page and the holds page for that title. At the very least the result screen needs to have more useful information. Right now it has something like: The following items have been placed on hold: itemnumber 816, reserve_id 168 The itemnumber and reserve_id numbers are not useful to the librarian. Not a QA problem but a suggestion: How hard would it be to offer the option of placing or cancelling title-level holds instead of item-level holds? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23258] Batch holding
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23258
--- Comment #9 from Owen Leonard ---
Created attachment 106598
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106598=edit
Bug 23258: (follow-up) Batch holds template followup
This patch revises the batch holds template to bring it up to date with
current guidelines including corrected indentation, Bootstrap grid,
terminology fixes ("hold" instead of "reserve") and JavaScript in the
footer.
Also changed:
- Add specificity to page title and breadcrumbs
- Add "Select all" and "Clear all" links to confirmation page
- Add jQuery validation of the form, enforcing barcode and patron entry
- Swith from "Batch holding" to "Batch place and cancel holds."
- Made suggested change to avoid errors in the log:
my $op = $input->param('op') // '';
- Fixed some other QA tool errors
To test, apply the patch and test the process of placing and cancelling
holds in batches:
- By uploading a file of barcodes
- By submitting barcodes in the textarea
- Confirm that holds are placed and cancelled
At each step of the process confirm that everything looks good and
works properly.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23258] Batch holding
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23258 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15085] Require confirmation before check in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15085 Vitor Fernandes changed: What|Removed |Added CC||vfernan...@keep.pt --- Comment #7 from Vitor Fernandes --- Hi, This is a nice enhancement to returns interface. We can have one system preference to turn on/off the confirmation. This can be also expanded to add a message confirmation to checkouts interface (I don't know if there is a bug filled for that). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24860] Add ability to place volume level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #52 from Kyle M Hall --- Created attachment 106596 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106596=edit Bug 24860: Add hold's volume to holds table on circulation.pl and moremember.pl Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24860] Add ability to place volume level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #53 from Kyle M Hall --- Created attachment 106597 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106597=edit Bug 24860: Update existing Schema files [DO NOT PUSH] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24860] Add ability to place volume level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #51 from Kyle M Hall --- Created attachment 106595 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106595=edit Bug 24860: Skip non-matching volume holds in HoldsQueue Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24860] Add ability to place volume level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #50 from Kyle M Hall --- Created attachment 106594 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106594=edit Bug 24860: Skip non-matching volume holds in CheckReserves Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24860] Add ability to place volume level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #49 from Kyle M Hall --- Created attachment 106593 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106593=edit Bug 24860: Add ability to select a volume when placing a hold - OPAC Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24860] Add ability to place volume level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #46 from Kyle M Hall --- Created attachment 106590 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106590=edit Bug 24860: Add new syspref EnableVolumeHolds Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24860] Add ability to place volume level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Kyle M Hall changed: What|Removed |Added Attachment #102239|0 |1 is obsolete|| Attachment #102240|0 |1 is obsolete|| Attachment #102241|0 |1 is obsolete|| Attachment #102242|0 |1 is obsolete|| Attachment #102243|0 |1 is obsolete|| Attachment #102244|0 |1 is obsolete|| Attachment #102245|0 |1 is obsolete|| Attachment #102246|0 |1 is obsolete|| Attachment #102247|0 |1 is obsolete|| --- Comment #45 from Kyle M Hall --- Created attachment 106589 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106589=edit Bug 24860: Add reserves.volume_id This feature builds upon bug 24857 and allows placing holds that target a specific volume of a record. It is patterned after the feature that allows limiting hold selection by itemtype ( AllowHoldItemTypeSelection ). Test Plan: 1) Apply bug 24857 and this bug's patches 2) Run updatedatabase.pl 3) Restart all the things! 4) Enable the sysprefs EnableVolumes and EnableVolumeHolds 5) Create a record, items and volumes, with each item being assigned to a volume 6) Place a hold for a patron 7) Note the new selector to choose a volume in addition to record and item level holds 8) Place a volume level hold 9) Check in an item from the record that is not part of that volume 10) Note the hold is not trapped for that item 11) Check in an item from the record that *is* part of that volume 12) Note the hold is trapped for that item 13) Place a volume level hold for another item 14) Run the holds queue builder 15) Note the holds queue targets only items from that volume 16) Check out all the items of that volume to other patrosn 17) Re-run the holds queue builder 18) Note the holds queue no longer has a line for that hold, as all items that could fill that hold are now unavailable Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24860] Add ability to place volume level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #47 from Kyle M Hall --- Created attachment 106591 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106591=edit Bug 24860: Implement reserves.volume_id Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24860] Add ability to place volume level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #48 from Kyle M Hall --- Created attachment 106592 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106592=edit Bug 24860: Add ability to select a volume when placing a hold Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25934] RequireStrongPassword should be more complex (password policy complexity)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25934 George Williams (NEKLS) changed: What|Removed |Added CC||geo...@nekls.org --- Comment #4 from George Williams (NEKLS) --- #1 - I completely disagree with #1. Why should we have a patch that will inevitably force libraries to change their password policies without giving them any choice in the matter? Koha gives libraries the flexibility to set their own policies and this would take that flexibility away. I agree that a 3 character minimum password is a bad idea, but I don't think that the Koha community should be forcing libraries from implementing bad ideas. I'm sure there are instances were, in the right circumstances, short passwords make sense for the libraries that are using them. #2 - Bug 12617 would allow individual Koha libraries to define password complexity on a patron-category-by-patron-category basis. I'd rather see work proceed on that bug than force system-wide password complexity for all accounts. #3 - I could get behind this if it can be implemented on a patron-category-by-patron-category basis. After the work is completed on bug 23816, that was something I was considering proposing as a development (along with forcing password changes after XX days on a patron-category-by-patron-category basis). #4 - This should be optional. If Bug 12617 was patched, that would address this issue, wouldn't it? #5 - I can get behind this one. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
