[Koha-bugs] [Bug 26814] Add onsite_checkout to circulation rules

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26814

Lari Taskula  changed:

   What|Removed |Added

 Attachment #112628|0   |1
is obsolete||

--- Comment #23 from Lari Taskula  ---
Created attachment 112632
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112632=edit
Bug 26814: (SMART-RULES GUI) Disable hold rules when on-site option selected

SMART-RULES GUI tag means that this patch will apply before Bug 15522.

To test:
1. Apply patch
2. Go to Circulation and fine rules in staff client
3. Observe the main circulation rules matrix, observe the following columns:

   Holds allowed (total)
   Holds allowed (daily)
   Holds per record (count)
   On shelf holds allowed
   OPAC item level holds
   Article requests

4. Set "On-site checkout" to "No" or "On-site"
5. Observe the columns in step 3, they should now be disabled
6. Set "On-site checkout" to "All"
7. Observe the columns in step 3, they should now be enabled
8. Add a new rule:

   On-site checkout: "On-site"
   Current checkouts allowed: 1

   and click Save.

9. Find the row you just added and press Edit.
10. Observe the columns in step 3, they should now be disabled
11. Press Edit for any other row where On-site checkout is "All"
12. Observe the columns in step 3, they should now be enabled

Sponsored-by: The National Library of Finland

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 26814] Add onsite_checkout to circulation rules

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26814

Lari Taskula  changed:

   What|Removed |Added

 Attachment #112627|0   |1
is obsolete||

--- Comment #22 from Lari Taskula  ---
Created attachment 112631
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112631=edit
Bug 26814: (SMART-RULES GUI) Indent and add onsite_checkout to all_rules hash

SMART-RULES GUI tag means that this patch will apply before Bug 15522.

No other changes in this patch.

To test:
1. git diff --word-diff=color --ignore-all-space HEAD~1 --
koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt
2. Observe only $osc has been added

Sponsored-by: The National Library of Finland

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 26814] Add onsite_checkout to circulation rules

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26814

Lari Taskula  changed:

   What|Removed |Added

 Attachment #112626|0   |1
is obsolete||

--- Comment #21 from Lari Taskula  ---
Created attachment 112630
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112630=edit
Bug 26814: (SMART-RULES GUI) Add onsite_checkout into user interface

SMART-RULES GUI tag means that this patch will apply before Bug 15522.

To test:
1. Go to Circulation rules page in Koha
2. Observe checkout type column in the rule matrix
3. Test circulation rules matrix by setting, modifying and deleting
   rules.
4. Test default checkout, hold and return policy settings.
5. Test default checkout, hold policy by patron category settings.

Sponsored-by: The National Library of Finland

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 26804] Limit the size of the news content column in newst table (News tool)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26804

Lucas Gass  changed:

   What|Removed |Added

 Attachment #112407|0   |1
is obsolete||

--- Comment #5 from Lucas Gass  ---
Created attachment 112629
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112629=edit
Bug 26804: Add modal content preview

This patch turns the 'News' column into a preview button. That preview button
displays a modal with content of that rows news item.

To test:
1. Apply patch
2. Add some HTML to a News Item. I am using a bunch of lorem ipsum HTML and
this image set to 1000px. 'https://koha-community.org/files/2013/09/cropped-kohabanner3.jpg;
width="1000" />'.
3. Make sure and have some content with a lot of width and some content with a
lot of height.
4. Test the Preview content button
5. Make sure you can scroll through long modals and across modals that are wide
6. Try at different screen sizes and with different combonations of News items

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 26814] Add onsite_checkout to circulation rules

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26814

Lari Taskula  changed:

   What|Removed |Added

 Attachment #112610|0   |1
is obsolete||

--- Comment #19 from Lari Taskula  ---
Created attachment 112627
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112627=edit
Bug 26814: (SMART-RULES GUI) Indent and add onsite_checkout to all_rules hash

SMART-RULES GUI tag means that this patch will apply before Bug 15522.

No other changes in this patch.

To test:
1. git diff --word-diff=color --ignore-all-space HEAD~1 --
koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt
2. Observe only $osc has been added

Sponsored-by: The National Library of Finland

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 26814] Add onsite_checkout to circulation rules

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26814

Lari Taskula  changed:

   What|Removed |Added

 Attachment #112611|0   |1
is obsolete||

--- Comment #20 from Lari Taskula  ---
Created attachment 112628
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112628=edit
Bug 26814: (SMART-RULES GUI) Disable hold rules when on-site option selected

SMART-RULES GUI tag means that this patch will apply before Bug 15522.

To test:
1. Apply patch
2. Go to Circulation and fine rules in staff client
3. Observe the main circulation rules matrix, observe the following columns:

   Holds allowed (total)
   Holds allowed (daily)
   Holds per record (count)
   On shelf holds allowed
   OPAC item level holds
   Article requests

4. Set "On-site checkout" to "No" or "On-site"
5. Observe the columns in step 3, they should now be disabled
6. Set "On-site checkout" to "All"
7. Observe the columns in step 3, they should now be enabled
8. Add a new rule:

   On-site checkout: "On-site"
   Current checkouts allowed: 1

   and click Save.

9. Find the row you just added and press Edit.
10. Observe the columns in step 3, they should now be disabled
11. Press Edit for any other row where On-site checkout is "All"
12. Observe the columns in step 3, they should now be enabled

Sponsored-by: The National Library of Finland

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19532] Recalls for Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

--- Comment #619 from Aleisha Amohia  ---
Thanks so much for your detailed comments David!

(In reply to David Nind from comment #606)
> 1. In the OPAC under your account, the your recalls history pages don't
> display correctly. The menu options under your account take up the whole
> width of the screen, and the your recalls history lists, forms and messages
> appear at the bottom of the page. I've attached screenshots so you can see
> what Imean.

fixed
> 
> 2. When setting up an item for a course reserve (steps 33-36) an error
> occurs when listing items for a course reserve in the staff interface. I've
> created bug 26819 for this as it occurs on master before the recalls patches
> are applied, but does not occur on 20.05.x. An item is actually added to the
> course reserve, and you can view it in the OPAC to successfully complete
> these steps.

I couldn't reproduce this problem but even so, I guess this is not a problem
with Bug 19532 and there's nothing for me to do here.

> - Step 84: Circulation > Recalls to pull - get error trace when I try to
> access the page (file with error trace attached)

fixed 

> 
> - Step 118: had to use UPDATE recalls SET waitingdate = NOW() - interval 5
> day WHERE recall_id = X; (using MariaDb, so not sure if this makes a
> difference).

yes good catch, the query I provided in the test plan doesn't work. please use
this one instead!

> 
> - I can't seem to get Circulation to work as expected (steps 137-149). I
> will have another go.
>   . Step 143: the item is not renewable, but I can't see a "Recalled link".
>   . Step 145: recall is not cancelled, and remains checked out.

both fixed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 26814] Add onsite_checkout to circulation rules

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26814

Lari Taskula  changed:

   What|Removed |Added

 Attachment #112609|0   |1
is obsolete||

--- Comment #18 from Lari Taskula  ---
Created attachment 112626
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112626=edit
Bug 26814: (SMART-RULES GUI) Add onsite_checkout into user interface

SMART-RULES GUI tag means that this patch will apply before Bug 15522.

To test:
1. Go to Circulation rules page in Koha
2. Observe checkout type column in the rule matrix
3. Test circulation rules matrix by setting, modifying and deleting
   rules.
4. Test default checkout, hold and return policy settings.
5. Test default checkout, hold policy by patron category settings.

Sponsored-by: The National Library of Finland

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 26814] Add onsite_checkout to circulation rules

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26814

Lari Taskula  changed:

   What|Removed |Added

 Attachment #112382|0   |1
is obsolete||

--- Comment #16 from Lari Taskula  ---
Created attachment 112624
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112624=edit
Bug 26814: Add onsite_checkout to get_effective_rule

To test:
1. Find all occurrences of get_effective_rule that are missing
   onsite_checkout where required

grep --exclude-dir '.git' --exclude-dir 'misc/translator' \
--exclude-dir 'koha-tmpl' \
-Przo '(?s)(::|->)get_effective_rule(?!s).*?\)' | \
grep -avz 'onsite_checkout' | \
grep -Pavz 'hold|reserves|article_requests' && echo ""

   The only occasions this should return anything are cases where
   a HASH or HASHref is given to get_effective_rule(), or that we
   are explicitly testing missing parameters in an unit test.

   1.2 Verify the HASH/HASHref cases. The hash should contain
   a onsite_checkout (unless the rule is related to holds)

   1.3 Verify the other cases. If you find another result than
   what is mentioned above, then this test fails.

2. Find all subroutines using get_effective_rule()

git grep --no-index -n -p -P 'get_effective_rule\s*\(' \
| grep -v 'sub {' | grep -P 'sub .*'

This list should be returned:

C4/Circulation.pm=394=sub TooMany {
C4/Circulation.pm=1375=sub AddIssue {
C4/Circulation.pm=1697=sub GetBranchBorrowerCircRule {
C4/Circulation.pm=1753=sub GetBranchItemRule {
C4/Circulation.pm=3040=sub GetRenewCount {
C4/Reserves.pm=359=sub CanItemBeReserved {
C4/Reserves.pm=2245=sub GetHoldRule {
Koha/Biblio.pm=295=sub article_request_type_for_bib {
Koha/Charges/Fees.pm=93=sub accumulate_rentalcharge {
Koha/CirculationRules.pm=221=sub get_effective_rules {
Koha/CirculationRules.pm=395=sub get_opacitemholds_policy {
Koha/CirculationRules.pm=421=sub get_onshelfholds_policy {
Koha/CirculationRules.pm=443=sub get_lostreturn_policy {
Koha/CirculationRules.pm=538=sub get_effective_daysmode {
Koha/Item.pm=617=sub article_request_type {
Koha/REST/V1/Checkouts.pm=192=sub allows_renewal {
Koha/Template/Plugin/CirculationRules.pm=26=sub Get {

Check these subroutines and make sure they are using
get_effective_rule() with the new scope, unless not needed.
When fetching a hold-related rules, onsite_checkout is not needed.

These subroutines and classes need changes to sub params:

2.1. Check modifications to Koha::Charges::Fees
2.2. Check modification made to C4::Circulation::_debar_user_on_return().
2.3. Check modification made to C4::Circulation::_calculate_new_debar_dt().

3. Find all occurrences of get_effective_rule with the following command:
  grep --exclude-dir='.git' -Prn 'get_effective_rule(?!s)'

Make sure all matches (where rule scope allows onsite_checkout) are
updated.

Sponsored-by: The National Library of Finland

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 26814] Add onsite_checkout to circulation rules

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26814

Lari Taskula  changed:

   What|Removed |Added

 Attachment #112381|0   |1
is obsolete||

--- Comment #15 from Lari Taskula  ---
Created attachment 112623
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112623=edit
Bug 26814: Add onsite_checkout to set_rules

To test:
1. Find all occurrences of set_rules that are missing onsite_checkout
   where required

grep --exclude-dir '.git' --exclude-dir 'misc/translator' \
--exclude-dir 'koha-tmpl' -Przo '(?s)(::|->)set_rules.*?\)' \
--exclude="smart-rules.pl" --exclude="smart-rules.tt" | \
grep -avz 'onsite_checkout' && echo ""

   The only occasions this should return anything are cases where
   a HASH or HASHref is given to set_rules(), or that we are
   explicitly testing missing parameters in an unit test.

   1.2 Verify the HASH/HASHref cases. The hash should contain
   a onsite_checkout (unless the rule is related to holds)

2. Find all subroutines using set_rules()

git grep --no-index -n -p -P 'set_rules\s*\(' | grep -v 'sub {' \
| grep -P 'sub .*'

   2.1 The only return should be
   t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t=401=
 sub set_holdallowed_rule {

3. The boring step. Find all occurrences of set_rules() with
   the following command:

grep --exclude-dir='.git' -Prn 'set_rules'

Go through this list and make sure all neccessary locations are
updated. A change is required when the rule scope includes
onsite_checkout. See Koha/CirculationRules.pm for scopes.
Hold/reserve related rules do not require it.

Sponsored-by: The National Library of Finland

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 26814] Add onsite_checkout to circulation rules

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26814

Lari Taskula  changed:

   What|Removed |Added

 Attachment #112383|0   |1
is obsolete||

--- Comment #17 from Lari Taskula  ---
Created attachment 112625
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112625=edit
Bug 26814: Add onsite_checkout to get_effective_rules

To test:
1. Find all occurrences of get_effective_rules that are missing
   onsite_checkout where required

grep --exclude-dir '.git' --exclude-dir 'misc/translator' \
--exclude-dir 'koha-tmpl' \
-Przo '(?s)(::|->)get_effective_rules.*?\)' | \
grep -avz 'onsite_checkout' && echo ""

   1.1. Verify command output. Only reserve related calls to
get_effective_rules() should be returned.

2. Find all subroutines using get_effective_rules()

git grep --no-index -n -p -P 'get_effective_rules\s*\(' \
| grep -v 'sub {' | grep -P 'sub .*'

This list should be returned:

C4/Circulation.pm=1611=sub GetLoanLength {
C4/Circulation.pm=1650=sub GetHardDueDate {
C4/Circulation.pm=2301=sub _calculate_new_debar_dt {
C4/Circulation.pm=2654=sub CanBookBeRenewed {
C4/Circulation.pm=3107=sub GetSoonestRenewDate {
C4/Circulation.pm=3171=sub GetLatestAutoRenewDate {
C4/Overdues.pm=224=sub CalcFine {
C4/Reserves.pm=2245=sub GetHoldRule {

Check these subroutines and make sure they are using
get_effective_rules() with the new scope, unless not needed.
When fetching a hold-related rules, checkout_type is not needed.

3. Check modification made to C4::Circulation::CalcDateDue()
4. Check modification made to C4::Circulation::CalcFine()
5. Check modification made to C4::Circulation::GetLoanLength()
6. Check modification made to C4::Circulation::GetHardDueDate()

Make sure all matches (where rule scope allows onsite_checkout) are
updated.

7. Run these unit tests:

grep -Prl --color=never 'get_effective_rule\(|set_rule\(|set_rules\(' \
t/db_dependent/ | grep '^.*\.t$' | xargs prove

8. Test onboarding tool
8.1. Drop your database (take backups first if needed)
8.2. Navigate to web installer
8.3. Continue until you reach onboarding tool step where circulation
 rules are added.
8.4. Observe new drop down selection "Checkout type".
8.5. Select any checkout type and continue the onboarding process.
8.6. Investigate your database table "circulation_rules". You should
 now have rules with onsite_checkout of your choice.

Sponsored-by: The National Library of Finland

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19532] Recalls for Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

--- Comment #618 from Aleisha Amohia  ---
Created attachment 112622
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112622=edit
Bug 19532: (follow-up) Fixing OPAC display and staff client errors

- fixes the displays of opac-recalls.pl and opac-recall.pl
- fix the error on Recalls to pull page
- fix JS error preventing Recalled link from showing in checkouts table
- fix cancelling of recall when checking out item

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19532] Recalls for Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #112472|0   |1
is obsolete||

--- Comment #617 from Aleisha Amohia  ---
Created attachment 112621
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112621=edit
Bug 19532: (follow-up) Fixing failing CalcFine.t test

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19532] Recalls for Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #112326|0   |1
is obsolete||

--- Comment #615 from Aleisha Amohia  ---
Created attachment 112619
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112619=edit
Bug 19532: Recalls on intranet

See recalls on Intranet
- old recalls (all inactive recalls)
- recalls queue (all active recalls) - cancel, expire, revert waiting status,
multiple cancel, mark overdue
- recalls to pull (available but not yet waiting) - cancel
- recalls awaiting pickup (awaiting pickup, awaiting pickup more than
RecallMaxPickUpDelay days) - expire, revert waiting status
- overdue recalls (overdue to be returned) - cancel, multiple cancel
- biblio recalls tab (all active recalls relevant to this bib) - cancel,
expire, revert waiting status, mark overdue
- patron recalls tab (all active recalls relevant to this patron) - cancel,
expire, revert waiting status, mark overdue
- patron recalls history tab (all recalls relevant to this patron) - cancel,
expire, revert waiting status, mark overdue
- log viewer

and the general circulation of recalls

Test plan in Comment 482.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19532] Recalls for Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #112346|0   |1
is obsolete||

--- Comment #616 from Aleisha Amohia  ---
Created attachment 112620
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112620=edit
Bug 19532: (follow-up) aria-hidden attr on OPAC, and more

- removing authnotrequired flag from scripts
- fixing opac buttons
- chmod +x for recalls test files

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19532] Recalls for Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #112325|0   |1
is obsolete||

--- Comment #614 from Aleisha Amohia  ---
Created attachment 112618
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112618=edit
Bug 19532: Recalls on OPAC

- place a biblio-level or item-level recall via the biblio detail page, OPAC
search results, or course reserves
- view or cancel your active recalls from 'your summary' recalls tab
- view all active and inactive (and cancel active) recalls from 'your recall
history'
- stopped from placing a reserve on an item that the patron has already
recalled

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19532] Recalls for Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #112324|0   |1
is obsolete||

--- Comment #613 from Aleisha Amohia  ---
Created attachment 112617
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112617=edit
Bug 19532: Other objects used in recalls feature

- biblio->recalls
- biblio->can_be_recalled
- item->recall
- item->can_be_recalled
- item->can_set_waiting_recall
- item->check_recalls
- patron->recalls
- Biblio.RecallsCount

and relevant tests
- t/db_dependent/Stats.t
- t/db_dependent/Koha/Item.t
- t/db_dependent/Koha/Biblio.t
- t/db_dependent/Koha/Patron.t
- t/db_dependent/XSLT.t
- t/db_dependent/Search.t
- t/db_dependent/Holds.t
- t/db_dependent/Circulation/transferbook.t
- t/db_dependent/Circulation.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19532] Recalls for Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #112317|0   |1
is obsolete||

--- Comment #609 from Aleisha Amohia  ---
Created attachment 112613
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112613=edit
Bug 19532: Updated schema files

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19532] Recalls for Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #112323|0   |1
is obsolete||

--- Comment #612 from Aleisha Amohia  ---
Created attachment 112616
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112616=edit
Bug 19532: Expiry and overdue cronjobs, and overdue fine calculation

- misc/cronjobs/recalls/expire_recalls.pl
- misc/cronjobs/recalls/overdue_recalls.pl
- tests for overdue fines in t/db_dependent/Circulation/CalcFine.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19532] Recalls for Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #112322|0   |1
is obsolete||

--- Comment #611 from Aleisha Amohia  ---
Created attachment 112615
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112615=edit
Bug 19532: Recalls objects and tests

Koha/Recall.pm
- biblio
- item
- patron
- library
- checkout
- requested
- waiting
- overdue
- in_transit
- expired
- cancelled
- finished
- calc_expirationdate
- start_transfer
- revert_transfer
- set_waiting
- revert_waiting
- set_overdue
- set_expired
- set_cancelled
- set_finished
- should_be_overdue

Koha/Recalls.pm
- add_recall
- move_recall

and relevant tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19532] Recalls for Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #112321|0   |1
is obsolete||

--- Comment #610 from Aleisha Amohia  ---
Created attachment 112614
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112614=edit
Bug 19532: Add boolean flags to recalls.old and recalls.item_level_recall

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19532] Recalls for Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #112316|0   |1
is obsolete||

--- Comment #608 from Aleisha Amohia  ---
Created attachment 112612
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112612=edit
Bug 19532: Database and installer stuff

- Add recalls table
- Add recalls circulation rules - recalls allowed, recalls per record, on shelf
recalls, recall due date interval, recall overdue fine, recall shelf time
- Add system preferences - useRecalls, RecallsMaxPickUpDelay, RecallsLog
- Add email notices (RETURN_RECALLED_ITEM, PICKUP_RECALLED_ITEM)
- Add print notice (RECALL_REQUESTER_DET)
- Add user permission - recalls, manage_recalls
- Add Recall and CancelRecall enum options for branchtransfers reason

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 26814] Add onsite_checkout to circulation rules

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26814

Lari Taskula  changed:

   What|Removed |Added

 Attachment #112608|0   |1
is obsolete||

--- Comment #14 from Lari Taskula  ---
Created attachment 112611
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112611=edit
Bug 26814: (SMART-RULES GUI) Disable hold rules when on-site option selected

SMART-RULES GUI tag means that this patch will apply before Bug 15522.

To test:
1. Apply patch
2. Go to Circulation and fine rules in staff client
3. Observe the main circulation rules matrix, observe the following columns:

   Holds allowed (total)
   Holds allowed (daily)
   Holds per record (count)
   On shelf holds allowed
   OPAC item level holds
   Article requests

4. Set "On-site checkout" to "No" or "On-site"
5. Observe the columns in step 3, they should now be disabled
6. Set "On-site checkout" to "All"
7. Observe the columns in step 3, they should now be enabled
8. Add a new rule:

   On-site checkout: "On-site"
   Current checkouts allowed: 1

   and click Save.

9. Find the row you just added and press Edit.
10. Observe the columns in step 3, they should now be disabled
11. Press Edit for any other row where On-site checkout is "All"
12. Observe the columns in step 3, they should now be enabled

Sponsored-by: The National Library of Finland

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 26814] Add onsite_checkout to circulation rules

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26814

Lari Taskula  changed:

   What|Removed |Added

 Attachment #112385|0   |1
is obsolete||

--- Comment #13 from Lari Taskula  ---
Created attachment 112610
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112610=edit
Bug 26814: (SMART-RULES GUI) Indent and add onsite_checkout to all_rules hash

SMART-RULES GUI tag means that this patch will apply before Bug 15522.

No other changes in this patch.

To test:
1. git diff --word-diff=color --ignore-all-space HEAD~1 --
koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt
2. Observe only $osc has been added

Sponsored-by: The National Library of Finland

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 26814] Add onsite_checkout to circulation rules

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26814

Lari Taskula  changed:

   What|Removed |Added

 Attachment #112384|0   |1
is obsolete||

--- Comment #12 from Lari Taskula  ---
Created attachment 112609
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112609=edit
Bug 26814: (SMART-RULES GUI) Add onsite_checkout into user interface

SMART-RULES GUI tag means that this patch will apply before Bug 15522.

To test:
1. Go to Circulation rules page in Koha
2. Observe checkout type column in the rule matrix
3. Test circulation rules matrix by setting, modifying and deleting
   rules.
4. Test default checkout, hold and return policy settings.
5. Test default checkout, hold policy by patron category settings.

Sponsored-by: The National Library of Finland

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 26814] Add onsite_checkout to circulation rules

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26814

Lari Taskula  changed:

   What|Removed |Added

 Blocks||24101


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24101
[Bug 24101] Due date to on-site loans according to the calendar and possibility
to renew on-site loans
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 25037] Add checkout_type to checkouts

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037

Lari Taskula  changed:

   What|Removed |Added

 Blocks|24101   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24101
[Bug 24101] Due date to on-site loans according to the calendar and possibility
to renew on-site loans
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 25089] Add checkout_type to circulation rules

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25089

Lari Taskula  changed:

   What|Removed |Added

 Blocks|24101   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24101
[Bug 24101] Due date to on-site loans according to the calendar and possibility
to renew on-site loans
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 24101] Due date to on-site loans according to the calendar and possibility to renew on-site loans

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24101

Lari Taskula  changed:

   What|Removed |Added

 Depends on|25037, 25089|26814


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037
[Bug 25037] Add checkout_type to checkouts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25089
[Bug 25089] Add checkout_type to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26814
[Bug 26814] Add onsite_checkout to circulation rules
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 26814] Add onsite_checkout to circulation rules

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26814

--- Comment #11 from Lari Taskula  ---
Created attachment 112608
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112608=edit
Bug 26814: (SMART-RULES GUI) Disable hold rules when on-site option selected

To test:
1. Apply patch
2. Go to Circulation and fine rules in staff client
3. Observe the main circulation rules matrix, observe the following columns:

   Holds allowed (total)
   Holds allowed (daily)
   Holds per record (count)
   On shelf holds allowed
   OPAC item level holds
   Article requests

4. Set "On-site checkout" to "No" or "On-site"
5. Observe the columns in step 3, they should now be disabled
6. Set "On-site checkout" to "All"
7. Observe the columns in step 3, they should now be enabled
8. Add a new rule:

   On-site checkout: "On-site"
   Current checkouts allowed: 1

   and click Save.

9. Find the row you just added and press Edit.
10. Observe the columns in step 3, they should now be disabled
11. Press Edit for any other row where On-site checkout is "All"
12. Observe the columns in step 3, they should now be enabled

Sponsored-by: The National Library of Finland

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #110990|0   |1
is obsolete||

--- Comment #108 from Aleisha Amohia  ---
Created attachment 112606
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112606=edit
Bug 14242: Remove TT conditional from HTML tags

It brakes the translation script

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242

--- Comment #109 from Aleisha Amohia  ---
Created attachment 112607
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112607=edit
Bug 14242: (follow-up) Remove well class, weird gap, fix clear form

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #110498|0   |1
is obsolete||

--- Comment #104 from Aleisha Amohia  ---
Created attachment 112602
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112602=edit
Bug 14242: (follow-up) Move English strings out of JavaScript

In order for English strings to be translatable they must be defined in
the template, not in the JS file.

Signed-off-by: Maryse Simard 

Signed-off-by: Lisette Scheer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #110499|0   |1
is obsolete||

--- Comment #105 from Aleisha Amohia  ---
Created attachment 112603
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112603=edit
Bug 14242: Styling of buttons, get copyright date, fixing plugin comment

And other code-y bits. Addressing comments in Comment 59.

Sponsored-by: Catalyst IT

Signed-off-by: Lisette Scheer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #110501|0   |1
is obsolete||

--- Comment #107 from Aleisha Amohia  ---
Created attachment 112605
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112605=edit
Bug 14242: (QA follow-up) Fix buttons for new bootstrap version

Stole the mark-up from bug 26478.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #110497|0   |1
is obsolete||

--- Comment #103 from Aleisha Amohia  ---
Created attachment 112601
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112601=edit
Bug 14242: (follow-up) Translateable js strings, $raw filter

Sponsored-by: Region Halland
Signed-off-by: Maryse Simard 

Signed-off-by: Lisette Scheer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #110500|0   |1
is obsolete||

--- Comment #106 from Aleisha Amohia  ---
Created attachment 112604
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112604=edit
Bug 14242: (follow-up) Adding publication year hint and fix js translations

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #110496|0   |1
is obsolete||

--- Comment #102 from Aleisha Amohia  ---
Created attachment 112600
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112600=edit
Bug 14242: (follow-up) Strip hyphen from ISBN for search purposes

To test, enter a valid ISBN complete with -
eg
978-1-78416-110-1

The search should still work

Signed-off-by: Marc 
Signed-off-by: Maryse Simard 

Signed-off-by: Lisette Scheer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #110493|0   |1
is obsolete||

--- Comment #99 from Aleisha Amohia  ---
Created attachment 112597
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112597=edit
Bug 14242: Use ISBN-field to automatically fill out purchase suggestions

Add new jQuery plugin "autofill" which transforms selected element(s) into
search fields for Google Books API and automatically fills requested fields
with
search result.

Use in OPAC purchase suggestions to automatically fill out fields when entering
ISBN-number.

Test plan:
1. Run updatedatabase.pl
2. Enable system precference "OPACAutoFill"
3. Log into OPAC and go to purchase suggetions page
4. Write a valid ISBN into the ISBN field and press the edit icon next to the
   field, or unfocus the field.
5. Title, Author, Publisher and Item Type fields should now be filled
   automaticly.
6. Press "undo" to undo - should restore all changed fields to original values

Tested all patches together, works as expected.
Signed-off-by: Marc 

Signed-off-by: Maryse Simard 

Signed-off-by: Lisette Scheer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #110494|0   |1
is obsolete||

--- Comment #100 from Aleisha Amohia  ---
Created attachment 112598
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112598=edit
Bug 14242: (follow up) renaming syspref

OPACAutoFill -> OPACSuggestionAutoFill

Signed-off-by: Marc 
Signed-off-by: Maryse Simard 

Signed-off-by: Lisette Scheer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #110495|0   |1
is obsolete||

--- Comment #101 from Aleisha Amohia  ---
Created attachment 112599
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112599=edit
Bug 14242: (follow-up) Change the icon to words

Fix a bug that meant it would search on empty ISBN

To test
1. Fill in a valid ISBN (Book data is correctly loaded)
2. Clear the ISBN from the field (Book data is correctly removed)
3. Tab away from the empty ISBN field: Data is loaded for a title
  "ISBN 0-9690745-2-2"
4. Apply patch
5. Repeat 1,2 and 3 notice a search is no longer done

Signed-off-by: Marc 
Signed-off-by: Maryse Simard 

Signed-off-by: Lisette Scheer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242

Aleisha Amohia  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 26790] Refactor Koha configuration (koha-conf.xml)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26790

--- Comment #6 from David Cook  ---
Julian, after reviewing your comments, I used TOML in a small Perl project, and
found it very nice to work with.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18595] Move C4::Members::Messaging to Koha namespace

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18595

--- Comment #110 from Lari Taskula  ---
(In reply to Joonas Kylmälä from comment #109)
> What do the last two commits do
> ===
> 
> Bug 18595: Disable digest checkbox when forced on:
>  - This one maybe I don't understand because of the first error caused by
> missing email. Specifically I don't understand in which situation the digest
> checkbox should be disabled.
There are libraries that wish to only send notifications as digests. IIRC, the
only way to achieve this was to configure it directly in the database via
"message_transports" table by removing rows where "is_digest" is 0. This patch
disables digest checkbox elements in such cases.

> Bug 18595: Validate days_in_advance
>  - What does this do exactly? I see it change days_in_advance=NULL but what
> is the reason behind that?
It's been 3 years since I provided these patches so I can't exactly remember
why and where but some patron messaging preferences had invalid values for
borrower_message_preferences.days_in_advance column and it caused plenty of
"Internal Server Error" messages in production. No idea whether it came from
Koha bugs at some point in the history, or from sysadmins themselves, but I
suppose it's safer to do a little database cleanup and run such query because
it simply nulls days_in_advance for every option that does not allow it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 26840] Add a 'date added' feature to the facets

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26840

Owen Leonard  changed:

   What|Removed |Added

   Assignee|oleon...@myacpl.org |koha-b...@lists.koha-commun
   ||ity.org
Version|19.11   |master
  Component|OPAC|Searching

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 26839] Add a 'date published' feature to the facets

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26839

Owen Leonard  changed:

   What|Removed |Added

  Component|OPAC|Searching
Version|19.11   |master
   Assignee|oleon...@myacpl.org |koha-b...@lists.koha-commun
   ||ity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 26840] New: Add a 'date added' feature to the facets

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26840

Bug ID: 26840
   Summary: Add a 'date added' feature to the facets
 Change sponsored?: ---
   Product: Koha
   Version: 19.11
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: barbara.john...@bedfordtx.gov
QA Contact: testo...@bugs.koha-community.org

Our patrons often want to see the newest materials that we've added to the
collection.  We provide a lot of canned searches to point them to our newest
items.  But when they do an author or subject search it would be helpful to
them to have a 'date added' feature in the facets in the OPAC to allow them to
zero in on materials added within the past xxx number of days.  

For example:

Past 30 Days (3)
Past 60 Days (3)
Past 90 Days (4)
Past 180 Days (5)
Over 180 Days (221)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 26592] XSS vulnerability when ysearch is used

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26592

Lucas Gass  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to oldoldstable
 Version(s)|19.11.11, 19.05.16  |20.11.00, 20.05.05,
released in||19.11.11, 19.05.16
Product|Koha security   |Koha
  Group|Koha security   |
  Component|Koha|Tools
 QA Contact||testo...@bugs.koha-communit
   ||y.org

--- Comment #23 from Lucas Gass  ---
backported to 20.05.x for 20.05.05

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 26839] New: Add a 'date published' feature to the facets

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26839

Bug ID: 26839
   Summary: Add a 'date published' feature to the facets
 Change sponsored?: ---
   Product: Koha
   Version: 19.11
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: barbara.john...@bedfordtx.gov
QA Contact: testo...@bugs.koha-community.org

Add a 'date published' facet to the OPAC so that patrons can limit their search
results.  For example: 

2021 (2)
2020 (9)
2019 (14)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17598] Make use of itemtypes.summary

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17598

Caroline Cyr La Rose  changed:

   What|Removed |Added

 CC||caroline.cyr-la-rose@inlibr
   ||o.com

--- Comment #6 from Caroline Cyr La Rose  ---
I vote for removing it entirely

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 24968] Add Syspref controls for cronjobs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24968

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

--- Comment #5 from David Cook  ---
(In reply to Magnus Enger from comment #4)
> Duplicate of "Bug 7972 - GUI for Crons"?

Hmm possibly. That bug seems to want to have full crontab access from the web,
especially in regards to time scheduling, which sounds terrible to me as a
vendor. But maybe I was misinterpreting the comments there.

Nick's suggestion seems to be more about just enabling/disabling and
configuring scheduled tasks, which sounds good to me. It wouldn't actually
affect cron's operation. Rather, it would affect the scripts executed by cron.
Much more reasonable.

I suppose an easy way to bolt this on would be to expand Koha::Script (or a
Koha::Script::* module). There could be an "is_enabled" function, and a
"get_script_config" function. 

(Regarding Bug 7972, you could perhaps have some config that prevents the
script from running during certain times. I think process_message_queue.pl runs
every 15 minutes, but we've hard-coded our crontab to only run between
8:00-20:00 so emails don't go out late at night. With this feature, a library
could designate their own "do not run" hours. Of course, this would only work
if the cronjob is ordinarily set to run during those "do not run" hours, if
that makes sense.)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 26838] New: Improve styling of checkin message

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26838

Bug ID: 26838
   Summary: Improve styling of checkin message
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: caroline.cyr-la-r...@inlibro.com
QA Contact: testo...@bugs.koha-community.org

Created attachment 112596
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112596=edit
Checkin message box

When an item type has a checkin message of the type "message" (rather than
"alert"), the styling of the box is weird. The box is blue, but the background
of the text is yellow.

To replicate:
1) Go to Administration > Item types
2) Edit an item type and include a checkin message, the checkin message type
should be "message"
3) Check in an item of that type

I attached a screen capture of the blue/yellow message. In the manual, we can
see what it used to look like :
https://koha-community.org/manual/20.11/en/html/_images/itemtype-msg.png

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 26837] New: Display SMS providers in alphabetical order

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26837

Bug ID: 26837
   Summary: Display SMS providers in alphabetical order
 Change sponsored?: ---
   Product: Koha
   Version: 19.11
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: System Administration
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: barbara.john...@bedfordtx.gov
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

It would be helpful to display the list of SMS providers on sms_providers.pl in
alphabetical order.  In addition, when adding/editing a patron record the list
of providers should also display in alphabetical order.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 26836] New: Add ability to assign Z39.50 servers to groups for searching

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26836

Bug ID: 26836
   Summary: Add ability to assign Z39.50 servers to groups for
searching
 Change sponsored?: ---
   Product: Koha
   Version: 19.11
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Cataloging
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: barbara.john...@bedfordtx.gov
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

It would be nice if there was a way to assign Z39.50 servers to groups so you
could search for similar titles in a batch.  For example, it might be helpful
to assign several servers to a Spanish group or a DVD group.  Then when you are
searching you could click on the server group name and the search would execute
across all the servers in the group.  It would provide efficiency and accuracy
in cataloging.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 26805] Remove remaining instances of jquery.checkboxes plugin from the OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26805

David Nind  changed:

   What|Removed |Added

 Attachment #112568|0   |1
is obsolete||

--- Comment #10 from David Nind  ---
Created attachment 112594
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112594=edit
Bug 26805: Remove remaining instances of jquery.checkboxes plugin from the OPAC

This patch removes the use of the jquery.checkboxes plugin from the 5
templates in the OPAC which still use it. The plugin itself is removed.

To test, apply the patch and test the "Select all" and "Clear all" links
work to select and deselect checkboxes on the following pages:

- The catalog search results page: The controls should also enable
  and disable the "Select titles to..." menu.
- The list contents page:  The controls should also enable
  and disable the "Select titles to..." links.
- The suggestions page: The controls should also enable
  and disable the "Select suggestions to..." link.
- The search history page: The controls should affect only the
  corresponding table ("Current" or "Previous") and should enable and
  disable the "Select searches to..." link.

This patch also modifies the template for grouped search results, as
enabled by the OpacGroupResults system preference, but I don't know how
to test it.

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 26805] Remove remaining instances of jquery.checkboxes plugin from the OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26805

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 26830] Set focus for cursor to name input box when creating a new list in the OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26830

Barbara Johnson  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 26373] Add ability to used different font color or background color for specific MARC tags in Advanced Editor

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26373

Barbara Johnson  changed:

   What|Removed |Added

 CC||barbara.johnson@bedfordtx.g
   ||ov

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22690] Merging records with many items too slow (Elasticsearch)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22690

--- Comment #80 from David Nind  ---
I'm getting test failures with prove -v t/db_dependent/Koha/Item.t after the
patch is applied. I ran this after applying the patches, but before adding the
1000 items and merging.

They passed before the patch was applied.

Note: I couldn't get the tests to complete after adding the 1000 items and
merging.

Apart from this, everything else in the test plan works.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 26830] Set focus for cursor to name input box when creating a new list in the OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26830

ByWater Sandboxes  changed:

   What|Removed |Added

 Attachment #112548|0   |1
is obsolete||

--- Comment #3 from ByWater Sandboxes  ---
Created attachment 112593
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112593=edit
Bug 26830: Set focus for cursor to name input box when creating a new list in
the OPAC

This patch adds the "focus" class to the list name input box in order to
automatically set focus on the field.

To test, apply the patch and log in to the OPAC.

- Go to Lists -> New list.
- The cursor focus should automatically be on the "list name" field.

Signed-off-by: B Johnson 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 26835] Ability to remove Lost Items from Patrons Account without Checking in

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26835

Christopher Brannon  changed:

   What|Removed |Added

 CC||cbran...@cdalibrary.org

--- Comment #1 from Christopher Brannon  ---
+1

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17515] Advanced Editor - Rancor - Z39 sources not sorted properly

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17515

Barbara Johnson  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17515] Advanced Editor - Rancor - Z39 sources not sorted properly

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17515

Barbara Johnson  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

--- Comment #5 from Barbara Johnson  ---
I signed off on this bug because the test plan worked as described.  One thing
to note is that if you rank some of the servers and not others the list
displays with the unranked servers first in alphabetical order followed by the
ranked servers in rank order. Additionally you can leave all of the servers
unranked and they will display in alphabetical order.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17515] Advanced Editor - Rancor - Z39 sources not sorted properly

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17515

ByWater Sandboxes  changed:

   What|Removed |Added

 Attachment #112585|0   |1
is obsolete||

--- Comment #4 from ByWater Sandboxes  ---
Created attachment 112592
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112592=edit
Bug 17515: Order Z3950 server by rank and preserve ordering

Previously we put all the servers into an object with keys of the server id

This patch converts it to an array of objects to preserve order, and adjusts
code to use the array index
where necessary and store the server id within the array

To test:
1 - Add some new Z3950 servers, they don't need to be valid
FIRST
SECOND
THIRD
FOURTH
2 - Adjust the ranking so FOURTH:1 THIRD:2 SECOND:3 FIRST:4
3 - Enable and launch the advanced editor
4 - Click 'Advanced' under search on the left
5 - Note the list displays in the order you entered the servers
6 - Apply patch
7 - Reload
8 - Order is correct
9 - With valid servers, confirm that searching still works and servers can be
checked or unchecked to include/remove from results

https://bugs.koha-community.org/show_bug.cgi?id=17515

Signed-off-by: B Johnson 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 26828] Set focus for cursor to current password field when updating in the OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26828

Barbara Johnson  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 26828] Set focus for cursor to current password field when updating in the OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26828

ByWater Sandboxes  changed:

   What|Removed |Added

 Attachment #112566|0   |1
is obsolete||

--- Comment #2 from ByWater Sandboxes  ---
Created attachment 112591
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112591=edit
Bug 26828: Set focus for cursor to current password field when updating in the
OPAC

This patch adds the "focus" class to the first field in the
OPAC's password update form so that the field automatically receives
focus upon page load.

To test, apply the patch and make sure the OpacPasswordChange system
preference is enabled.

- Log in to the OPAC
- Open the "Change your password" page
- The cursor should automatically be in the "Current password" field
  when the page loads.

Signed-off-by: B Johnson 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 26826] Set focus for cursor to name input box when creating a new list

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26826

Barbara Johnson  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 26826] Set focus for cursor to name input box when creating a new list

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26826

ByWater Sandboxes  changed:

   What|Removed |Added

 Attachment #112549|0   |1
is obsolete||

--- Comment #2 from ByWater Sandboxes  ---
Created attachment 112590
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112590=edit
Bug 26826: Set focus for cursor to name input box when creating a new list

This patch adds the "focus" class to the list name input field so that
it automatically has focus when the page loads.

To test, apply the patch and open the lists page in the staff client.

- Click "New list."
- When the list creation page loads the "Name" field should have focus.

Signed-off-by: B Johnson 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 26825] Add span for publication date in OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26825

Barbara Johnson  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 26825] Add span for publication date in OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26825

ByWater Sandboxes  changed:

   What|Removed |Added

 Attachment #112580|0   |1
is obsolete||

--- Comment #2 from ByWater Sandboxes  ---
Created attachment 112589
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112589=edit
Bug 26825: Add span for publication date in OPAC

This patch modifies the XSL templates for OPAC results and OPAC details
so that the parts of the publisher details are wrapped separate s:
Publisher place, name, and date.

To test, apply the patch "restart_all" if necessary.

You can add this to the OPACUserCSS system preference to better see the
change:

.publisher_place { color: red; }
.publisher_name { color: green; }
.publisher_date { color: orange; }

- Peform a search in the OPAC
- In the search results, confirm that the publisher plac, name, and date
  are wrapped in separate s, either by confirming the custom
  colors or by inspecting the source.
- View the details for one of the results. Confirm that the same change
  has been made to the detail page.

Signed-off-by: B Johnson 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 26835] Ability to remove Lost Items from Patrons Account without Checking in

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26835

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 CC||and...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 26835] New: Ability to remove Lost Items from Patrons Account without Checking in

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26835

Bug ID: 26835
   Summary: Ability to remove Lost Items from Patrons Account
without Checking in
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: ke...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

Libraries all have unique ways of handling lost statuses.  At the moment, Koha
allows libraries to remove a lost item from the patron's account when set to a
lost status and also to not remove it. Great!  However, we would like to see
Koha go one step forward after the library chooses to not remove the lost item
from the patron's account, to allow for the item to be removed at a later date.
 A preference would be to have the Batch Item Modification allow for libraries
to change an item's lost status to another lost status, and also remove it from
the patron's account.  Using the batch item modification will allow for
libraries to do this operation in bulk ! Currently, if a library has the option
to credit the patron if they do return a lost item, the library has no way of
telling Koha (at check-in) don't refund, don't remove the lost status, just
remove it from the patron's account.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 26683] Fix Modules::RequireFilenameMatchesPackage Perl Critic Violations

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26683

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8179] Receiving multiple order lines at once

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179

Agustín Moyano  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8179] Receiving multiple order lines at once

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179

--- Comment #17 from Agustín Moyano  ---
Created attachment 112588
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112588=edit
Bug 8179: Set render functions in every column

Because when AcqReceiveMultipleOrderLines is set to allow, we add an
extra column at the beginning, general columnDefs of datatables config
pointed to the wrong column. So, instead of using general columnDef,
this patch sets the render function to each column.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 26633] Add advanced editor for transfer limits

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633

--- Comment #10 from Kyle M Hall  ---
Created attachment 112587
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112587=edit
Bug 26633: (QA follow-up) Action buttons should not remain grayed out if the
same action is used multiple times in a row

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 26633] Add advanced editor for transfer limits

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633

Kyle M Hall  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 26724] Improve link text for downloading the CSV file on patron import page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26724

David Nind  changed:

   What|Removed |Added

 Attachment #112582|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 26724] Improve link text for downloading the CSV file on patron import page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26724

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 26724] Improve link text for downloading the CSV file on patron import page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26724

--- Comment #10 from David Nind  ---
Created attachment 112586
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112586=edit
Bug: Improve link text for downloading the CSV file on patron import page.

On tools > Patron Import there is a a link labelled "here" on the right
side that should be more descriptive. This patch updates the link.

To test:
1. Go to tools
2. Under patrons select "Import Patrons"
3. On the right side of the screen, observe the "here" link in the
second list item.
4. Apply patch.
5. Reload page
6. Observe the updated link text.
7. Sign off

https://bugs.koha-community.org/show_bug.cgi?id=26724

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 26834] Hiding Branches from the Libraries Link on the OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26834

--- Comment #1 from Owen Leonard  ---
This sounds like a job for the library groups feature.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 26834] Hiding Branches from the Libraries Link on the OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26834

Owen Leonard  changed:

   What|Removed |Added

   Assignee|oleon...@myacpl.org |koha-b...@lists.koha-commun
   ||ity.org
 CC||gmcha...@gmail.com
  Component|OPAC|System Administration

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 26434] Plugin dirs duplicates in @INC with plack

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26434

--- Comment #13 from Victor Grousset/tuxayo  ---
Backport to 19.05.x fixed, thanks James! :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17515] Advanced Editor - Rancor - Z39 sources not sorted properly

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17515

Nick Clemens  changed:

   What|Removed |Added

 Attachment #112583|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 26834] Hiding Branches from the Libraries Link on the OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26834

Kelly McElligott  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 26834] New: Hiding Branches from the Libraries Link on the OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26834

Bug ID: 26834
   Summary: Hiding Branches from the Libraries Link on the OPAC
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: ke...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

With the introduction of including the "Libraries" link on the OPAC. Bug 13388
(https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13388)

Each library's branch information will display on the OPAC by default.  There
are library systems that have branches that will not want to be shown on the
OPAC, as they are more for the library not for the public to see.  Can we have
something to be added to the Libraries portion of the Admin module to allow
libraries to identify if this branch can be visible on the OPAC.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17515] Advanced Editor - Rancor - Z39 sources not sorted properly

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17515

--- Comment #3 from Nick Clemens  ---
Created attachment 112585
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112585=edit
Bug 17515: Order Z3950 server by rank and preserve ordering

Previously we put all the servers into an object with keys of the server id

This patch converts it to an array of objects to preserve order, and adjusts
code to use the array index
where necessary and store the server id within the array

To test:
1 - Add some new Z3950 servers, they don't need to be valid
FIRST
SECOND
THIRD
FOURTH
2 - Adjust the ranking so FOURTH:1 THIRD:2 SECOND:3 FIRST:4
3 - Enable and launch the advanced editor
4 - Click 'Advanced' under search on the left
5 - Note the list displays in the order you entered the servers
6 - Apply patch
7 - Reload
8 - Order is correct
9 - With valid servers, confirm that searching still works and servers can be
checked or unchecked to include/remove from results

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 26833] Logged in library doesn't show with suggestions count

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26833

--- Comment #4 from Séverine Queune  ---
I've got a slightly different display from what is described.
Using 'independentbanches', a staff user sees only 'logged-in library: nb' on
both pages while a superlibrarian sees 'logged-in library: nb / All libraries:
nb'.
Without 'independentbanches', the 2 informations for the 'logged-in library'
and 'all librairies' are display including in the home page.
I signed thought, because that's completely relevant and what I expected as
display.
Let me know if I shouldn't have to.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 26833] Logged in library doesn't show with suggestions count

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26833

Séverine Queune  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 26833] Logged in library doesn't show with suggestions count

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26833

Séverine Queune  changed:

   What|Removed |Added

 Attachment #112576|0   |1
is obsolete||

--- Comment #3 from Séverine Queune  ---
Created attachment 112584
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112584=edit
Bug 26833: Logged in library doesn't show with suggestions count

This patch corrects the template variables used by the suggestions
counts shown on the staff interface home page and the acquisitions home
page. They should use [% Branches.GetLoggedInBranchname %]

To test you should have some suggestions from multiple libraries.

- Log in to the staff interface.
- On the home page you should see "Suggestions pending approval,"
  followed by the name of your logged-in library and the count of
  suggestions for your library.
- Go to the acquisitions page.
- In the "Pending suggestions" section you should see the same
  information: Your logged-in library name, suggestion count, and the
  count of suggestions at all libraries.

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 24012] Display 'Locked' budget in red

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24012

--- Comment #7 from Caroline Cyr La Rose  ---
Hi Alex!

Do you think you could add a space between the lock icon and the word "locked"?

Otherwise, it works perfectly!

Caroline

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17515] Advanced Editor - Rancor - Z39 sources not sorted properly

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17515

--- Comment #2 from Nick Clemens  ---
Created attachment 112583
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112583=edit
Bug 17151: Order Z3950 server by rank and preserve ordering

Previously we put all the servers into an object with keys of the server id

This patch converts it to an array of objects to preserve order, and adjusts
code to use the array index
where necessary and store the server id within the array

To test:
1 - Add some new Z3950 servers, they don't need to be valid
FIRST
SECOND
THIRD
FOURTH
2 - Adjust the ranking so FOURTH:1 THIRD:2 SECOND:3 FIRST:4
3 - Enable and launch the advanced editor
4 - Click 'Advanced' under search on the left
5 - Note the list displays in the order you entered the servers
6 - Apply patch
7 - Reload
8 - Order is correct
9 - With valid servers, confirm that searching still works and servers can be
checked or unchecked to include/remove from results

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8179] Receiving multiple order lines at once

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179

Séverine Queune  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #16 from Séverine Queune  ---
Hi Augustin,
I got an issue with the /cgi-bin/koha/acqui/parcel.pl? page which stays
'Processing' (see here with the console log : https://snipboard.io/V1WPGy.jpg).
I had the same issue testing Bug 20212 last week, but the last version proposed
by Tomas on Friday fixed that.
Loading this page is correct when I switch to master, I also try creating a
branch with 20212 only and it was correctly display too, so no idea from which
other patch it can come from...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 26724] Improve link text for downloading the CSV file on patron import page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26724

Lisette Scheer  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 26724] Improve link text for downloading the CSV file on patron import page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26724

Lisette Scheer  changed:

   What|Removed |Added

 Attachment #112479|0   |1
is obsolete||

--- Comment #9 from Lisette Scheer  ---
Created attachment 112582
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112582=edit
Attachment to Bug 26724 - Improve link text for downloading the CSV file on
patron import page

Bug: Improve link text for downloading the CSV file on patron import page.

On tools > Patron Import there is a a link labelled "here" on the right
side that should be more descriptive. This patch updates the link.

To test:
1. Go to tools
2. Under patrons select "Import Patrons"
3. On the right side of the screen, observe the "here" link in the
second list item.
4. Apply patch.
5. Reload page
6. Observe the updated link text.
7. Sign off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 26808] Improve tab key access to circulation confirmation dialog

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26808

--- Comment #1 from Owen Leonard  ---
Created attachment 112581
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112581=edit
Bug 26808: Improve tab key access to circulation confirmation dialog

This patch modifies the checkout template so that the checkout
confirmation message can receive focus, improving tab access to the form
buttons in the dialog.

A "-1" value "tabindex" attribute makes the dialog focusable, and a
"focus" class automatically triggers focus. The focus and tabindex are
only set when the template logic says that the alert will require
confirmation.

To test, apply the patch and open a patron's account for checkout.

- Submit a barcode for checkout which will trigger a confirmation
  dialog. For instance:
  - A barcode they already have checked out
  - A barcode which is checked out to another patron
- When the page reloads you should see an alert-style dialog, "Please
  confirm checkout." The browser should show a focus outline around the
  dialog.
- Hitting the tab key should move the focus to the first focusable
  element inside the dialog. If there is a link in the text, this may be
  the first element. If not the confirmation button should be the next
  tabbable element.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 26808] Improve tab key access to circulation confirmation dialog

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26808

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 26825] Add span for publication date in OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26825

--- Comment #1 from Owen Leonard  ---
Created attachment 112580
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112580=edit
Bug 26825: Add span for publication date in OPAC

This patch modifies the XSL templates for OPAC results and OPAC details
so that the parts of the publisher details are wrapped separate s:
Publisher place, name, and date.

To test, apply the patch "restart_all" if necessary.

You can add this to the OPACUserCSS system preference to better see the
change:

.publisher_place { color: red; }
.publisher_name { color: green; }
.publisher_date { color: orange; }

- Peform a search in the OPAC
- In the search results, confirm that the publisher plac, name, and date
  are wrapped in separate s, either by confirming the custom
  colors or by inspecting the source.
- View the details for one of the results. Confirm that the same change
  has been made to the detail page.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 26825] Add span for publication date in OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26825

Owen Leonard  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 26825] Add span for publication date in OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26825

Owen Leonard  changed:

   What|Removed |Added

 Depends on||16696
Version|19.11   |master
 Status|NEW |ASSIGNED


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16696
[Bug 16696] Rename "Publisher" on detail and result lists
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/