[Koha-bugs] [Bug 27080] Add --statute-barred-fees option to cleanup_database.pl to purge all fees where the item has been returned and the fee is older than the given number of days.

2020-12-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27080

Timothy Alexis Vass  changed:

   What|Removed |Added

Summary|Add --statute-barred option |Add --statute-barred-fees
   |to cleanup_database.pl to   |option to
   |purge all fees where the|cleanup_database.pl to
   |item has been returned and  |purge all fees where the
   |the fee is older than the   |item has been returned and
   |given number of days.   |the fee is older than the
   ||given number of days.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27080] Add --statute-barred option to cleanup_database.pl to purge all fees where the item has been returned and the fee is older than the given number of days.

2020-12-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27080

Timothy Alexis Vass  changed:

   What|Removed |Added

 Status|Failed QA   |ASSIGNED

--- Comment #14 from Timothy Alexis Vass  ---
I will make it --statue-barred-fees.
The fees are literally statute-barred.

Thank you everyone for the clarifications.
I will refactor this according to the insights shared in the comments above.
I will make another bug report and patch for the relating parts and correct
those too.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26890] opac-detail plugin like intranet/cgi-bin/catalogue/detail.pl

2020-12-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26890

--- Comment #18 from Mark Hofstetter  ---
I still think plugabiltiy would be a good idea (even if it would be just for
the sake of concistency)

but thanks to all your advice I was able to to todo it in a plugin
(https://github.com/HKS3/koha-plugin-subordinate-items) just create the tab
with js

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27143] New: Error Occured during Koha Installation

2020-12-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27143

Bug ID: 27143
   Summary: Error Occured during Koha Installation
 Change sponsored?: ---
   Product: Koha
   Version: 20.05
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Installation and upgrade (web-based installer)
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: muhd.rai...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

Created attachment 114133
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114133=edit
The menu that was mentioned in post description

Hello and Good day everyone,

I was wondering if anyone could tell or help on how to solve this error that i
encountered during the 2nd stage of Koha installation? The error
"DBIx::Class::Storage::DBI::_dbh_execute(): Table
'koha_bookreader.search_marc_map' doesn't exist at
/usr/share/koha/lib/Koha/Objects.pm line 207" occurred after the menu of
"Selecting default settings". 

Anyone that knows or experience on how to solve the matter? Thank you on
advance!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27140] koha-zebra doesn't properly stop Zebra

2020-12-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27140

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl

--- Comment #1 from Marcel de Rooy  ---
Remember some similar experience. But is the info clear enough for someone to
solve this ticket ? :)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27142] New: Patron batch update from report module - no patrons loaded into view

2020-12-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27142

Bug ID: 27142
   Summary: Patron batch update from report module - no patrons
loaded into view
 Change sponsored?: ---
   Product: Koha
   Version: 20.05
  Hardware: All
OS: All
Status: NEW
  Severity: critical
  Priority: P5 - low
 Component: Reports
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: somesecretem...@mailinator.com
QA Contact: testo...@bugs.koha-community.org

Can't batch update patrons from reports module. 

Steps to reproduce: 

1. Navigate to reports module 
2. Create sql report with `select * from borrowers`
3. Save report 
4. Run report 
5. Click "Batch operation with 20 visible patrons" 
6. Click "Batch patron modification" 

Result: no patrons are loaded in the view. Koha shows message "Warning, the
following cardnumbers were not found:" and presents all cardnumbers of patrons
from the sql query. 

I verified that the same steps in Koha version 19.11 works fine.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9715] Various combinations of prefs QueryAutoTruncate, QueryFuzzy and QueryWeightFields conflict

2020-12-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9715

--- Comment #12 from David Cook  ---
I would note that QueryStemming, based on my tests on Bug 25900, is also
problematic.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9715] Various combinations of prefs QueryAutoTruncate, QueryFuzzy and QueryWeightFields conflict

2020-12-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9715

David Cook  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=27141

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27141] QueryWeightFields should be 0 on new installs since QueryAutoTruncate is 1

2020-12-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27141

David Cook  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=9715

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27141] New: QueryWeightFields should be 0 on new installs since QueryAutoTruncate is 1

2020-12-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27141

Bug ID: 27141
   Summary: QueryWeightFields should be 0 on new installs since
QueryAutoTruncate is 1
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: System Administration
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: dc...@prosentient.com.au
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

Since QueryAutoTruncate automatically disables QueryWeightFields, it does not
make sense that both are set to 1 in "./installer/data/mysql/sysprefs.sql"

I think that we should have QueryWeightFields set to 0 for new installations.

It would even be tempting to set QueryWeightFields to 0 where QueryAutoTruncate
is set to 1 on existing installs, except that someone might be (unwisely)
trialling different Query* settings before/during a Koha upgrade.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9715] Various combinations of prefs QueryAutoTruncate, QueryFuzzy and QueryWeightFields conflict

2020-12-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9715

--- Comment #11 from David Cook  ---
We could just not use QueryFuzzy when UseICU is enabled and then add a warning
to the syspref description?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9715] Various combinations of prefs QueryAutoTruncate, QueryFuzzy and QueryWeightFields conflict

2020-12-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9715

David Cook  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=25900

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25900] Double quotes breaks search with Zebra and QueryWeightFields

2020-12-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25900

David Cook  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=9715

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25900] Double quotes breaks search with Zebra and QueryWeightFields

2020-12-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25900

--- Comment #14 from David Cook  ---
I'm tempted to mark this as a duplicate of Bug 9715

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12430] Relevance ranking should also be used without QueryWeightFields system preference

2020-12-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430

David Cook  changed:

   What|Removed |Added

 CC||bernard.scaife@ptfs-europe.
   ||com

--- Comment #71 from David Cook  ---
*** Bug 24006 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24006] Switching on QueryWeightFields (relevance ranking) breaks search

2020-12-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24006

David Cook  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|NEW |RESOLVED
 CC||dc...@prosentient.com.au

--- Comment #3 from David Cook  ---
I think that this is a duplicate of Bug 12430

*** This bug has been marked as a duplicate of bug 12430 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12430] Relevance ranking should also be used without QueryWeightFields system preference

2020-12-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430

David Cook  changed:

   What|Removed |Added

Summary|Search truncation disables  |Relevance ranking should
   |relevance ranking   |also be used without
   ||QueryWeightFields system
   ||preference

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12430] Search truncation disables relevance ranking

2020-12-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430

David Cook  changed:

   What|Removed |Added

 Attachment #114130|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12430] Search truncation disables relevance ranking

2020-12-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430

--- Comment #70 from David Cook  ---
Created attachment 114132
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114132=edit
Bug 12430: Add unit tests for C4::Search::buildQuery

This patch adds unit tests for buildQuery, especially focusing on
the use of the (rk=()) wrapper.

Note that the Net::Z3950::ZOOM library is used to test the queries
for CCL validity on top of the string matching used in the
got/expected comparisons.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12430] Search truncation disables relevance ranking

2020-12-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430

David Cook  changed:

   What|Removed |Added

 Attachment #114129|0   |1
is obsolete||

--- Comment #69 from David Cook  ---
Created attachment 114131
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114131=edit
Bug 12430: Use releance ranking without QueryWeightFields

The system preference "QueryWeightFields" is mutually exclusive with
the system preference "QueryAutoTruncate" and the * truncation
modifier, when not using QueryParser.

If you use truncation, relevance won't work anymore. (N.B. Relevance
doesn't work probably when using QueryParser, but for a very different
reason beyond the current scope of this bug.)

This patch adds relevance ranking when using truncation (or basically
when QueryWeightFields is disabled).

_TEST PLAN_

1) Turn on "QueryWeightFields" and set "QueryAutoTruncate" to auto
2) Turn off "UseQueryParser"
3) Do a keyword search in the OPAC
4) Note that the results are ordered by biblionumber ascending

5) Apply patch

6) Do the same keyword search in the OPAC
7) Note that the results are never ordered differently
(presumably in relevance order :P)

If you're a stickler, throw in some warns so that you can see
what CCL query is being sent to Zebra.

Signed-off-by: Victor Grousset/tuxayo 

Signed-off-by: Katrin Fischer 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12430] Search truncation disables relevance ranking

2020-12-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430

--- Comment #68 from David Cook  ---
Very old style commit message name. I might just fix that up now...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25900] Double quotes breaks search with Zebra and QueryWeightFields

2020-12-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25900

--- Comment #13 from David Cook  ---
Hmm I've just noticed that I didn't have "UseICU" turned on... but that doesn't
look relevant.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12430] Search truncation disables relevance ranking

2020-12-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430

--- Comment #67 from David Cook  ---
When this is pushed, I'm half tempted to push for a removal of
"QueryWeightFields" completely as I reckon it causes more grief than it's
worth...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25900] Double quotes breaks search with Zebra and QueryWeightFields

2020-12-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25900

--- Comment #12 from David Cook  ---
(In reply to David Cook from comment #10)
> Using koha-testing-docker w/o patch using CHR in
> /etc/koha/zebradb/etc/default.idx:

Note I have a typo in the QueryAutoTruncate section. By accident, a @attr 2=102
snuck in there.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25900] Double quotes breaks search with Zebra and QueryWeightFields

2020-12-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25900

David Cook  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #11 from David Cook  ---
Using koha-testing-docker w/o patch using ICU in
/etc/koha/zebradb/etc/default.idx:

For "index w", replace "charmap word-phrase-utf.chr" with "icuchain
words-icu.xml"

For "index p", replace "charmap word-phrase-utf.chr" with "icuchain
phrases-icu.xml"

koha-rebuild-zebra -f -b -v kohadev

QueryAutoTruncate:
Query: test
Request: Search biblios OK 3 1 1+0 RPN @attrset Bib-1 @attr 1=1016 @attr 4=6
@attr 5=1 test

Query: "test"
Request: Search biblios OK 3 1 1+0 RPN @attrset Bib-1 @attr 1=1016 @attr 4=6
@attr 5=1 test

QueryWeightFields:
Query: test
Request: Search biblios ERROR 120 1 1+0 RPN @attrset Bib-1 @or @or @or @or @or
@or @attr 1=36 @attr 4=1 @attr 6=3 @attr 9=32 @attr 2=102 test @attr 1=4 @attr
4=1 @attr 6=3 @attr 9=28 @attr 2=102 test @attr 1=3
6 @attr 4=1 @attr 9=26 @attr 2=102 test @attr 1=4 @attr 4=6 @attr 9=24 @attr
2=102 test @attr 4=6 @attr 5=103 @attr 9=16 @attr 2=102 test @attr 4=6 @attr
5=1 @attr 9=14 @attr 2=102 "test? " @attr 4=6 @attr 9=14 @attr 2=102 test

Query: "test"
Request: Search biblios ERROR 120 1 1+0 RPN @attrset Bib-1 @or @or @or @or @or
@or @attr 1=36 @attr 4=1 @attr 6=3 @attr 9=32 @attr 2=102 " test " @attr 1=4
@attr 4=1 @attr 6=3 @attr 9=28 @attr 2=102 " test " @
attr 1=36 @attr 4=1 @attr 9=26 @attr 2=102 " test " @attr 1=4 @attr 4=6 @attr
9=24 @attr 2=102 " test " @attr 4=6 @attr 5=103 @attr 9=16 @attr 2=102 " test "
@attr 4=6 @attr 5=1 @attr 9=14 @attr 2=102 "test? " @attr 4=6 @attr 9=14 @attr
2=102 " test "

(Via yaz-client this query yields: [120] Unsupported Truncation attribute -- v2
addinfo '103')

--

Actually, it doesn't look like this problem is related to double quotes at all.

Interesting... if I disable QueryFuzzy it will work:

Query: test
Request: Search biblios OK 3 1 1+0 RPN @attrset Bib-1 @or @or @or @or @or @attr
1=36 @attr 4=1 @attr 6=3 @attr 9=32 @attr 2=102 test @attr 1=4 @attr 4=1 @attr
6=3 @attr 9=28 @attr 2=102 test @attr 1=36 @attr 4
=1 @attr 9=26 @attr 2=102 test @attr 1=4 @attr 4=6 @attr 9=24 @attr 2=102 test
@attr 4=6 @attr 5=1 @attr 9=14 @attr 2=102 "test? " @attr 4=6 @attr 9=14 @attr
2=102 test

Query: "test"
Request: 
Search biblios OK 3 1 1+0 RPN @attrset Bib-1 @or @or @or @or @or @attr 1=36
@attr 4=1 @attr 6=3 @attr 9=32 @attr 2=102 " test " @attr 1=4 @attr 4=1 @attr
6=3 @attr 9=28 @attr 2=102 " test " @attr 1=36
 @attr 4=1 @attr 9=26 @attr 2=102 " test " @attr 1=4 @attr 4=6 @attr 9=24 @attr
2=102 " test " @attr 4=6 @attr 5=1 @attr 9=14 @attr 2=102 "test? " @attr 4=6
@attr 9=14 @attr 2=102 " test "

--

If I re-enable QueryFuzzy *but* DISABLE QueryStemming it causes catastrophic
problems:

Query: test
Request: Search biblios ERROR 120 1 1+0 RPN @attrset Bib-1 @or @or @or @or @or
@attr 1=36 @attr 4=1 @attr 6=3 @attr 9=32 @attr 2=102 test @attr 1=4 @attr 4=1
@attr 6=3 @attr 9=28 @attr 2=102 test @attr 1=36 @a
ttr 4=1 @attr 9=26 @attr 2=102 test @attr 1=4 @attr 4=6 @attr 9=24 @attr 2=102
test @attr 4=6 @attr 5=103 @attr 9=16 @attr 2=102 test @attr 4=6 @attr 9=14
@attr 2=102 test

Query: "test"
Request:  Search biblios ERROR 120 1 1+0 RPN @attrset Bib-1 @or @or @or @or @or
@attr 1=36 @attr 4=1 @attr 6=3 @attr 9=32 @attr 2=102 " test " @attr 1=4 @attr
4=1 @attr 6=3 @attr 9=28 @attr 2=102 " test " @att
r 1=36 @attr 4=1 @attr 9=26 @attr 2=102 " test " @attr 1=4 @attr 4=6 @attr 9=24
@attr 2=102 " test " @attr 4=6 @attr 5=103 @attr 9=16 @attr 2=102 " test "
@attr 4=6 @attr 9=14 @attr 2=102 " test "

(Via yaz-client this query yield: [120] Unsupported Truncation attribute -- v2
addinfo '103')

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12430] Search truncation disables relevance ranking

2020-12-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430

David Cook  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12430] Search truncation disables relevance ranking

2020-12-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430

--- Comment #66 from David Cook  ---
To run the unit tests:

root@kohadevbox:koha(bug_12430)$ prove t/Search/buildQuery.t
t/Search/buildQuery.t .. ok
All tests successful.
Files=1, Tests=10,  3 wallclock secs ( 0.03 usr  0.01 sys +  2.87 cusr  0.15
csys =  3.06 CPU)
Result: PASS

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12430] Search truncation disables relevance ranking

2020-12-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430

David Cook  changed:

   What|Removed |Added

  Attachment #99158|0   |1
is obsolete||

--- Comment #65 from David Cook  ---
Created attachment 114130
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114130=edit
Unit tests for buildQuery

This patch adds unit tests for buildQuery, especially focusing on
the use of the (rk=()) wrapper.

Note that the Net::Z3950::ZOOM library is used to test the queries
for CCL validity on top of the string matching used in the
got/expected comparisons.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12430] Search truncation disables relevance ranking

2020-12-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430

David Cook  changed:

   What|Removed |Added

  Attachment #99141|0   |1
is obsolete||

--- Comment #64 from David Cook  ---
Created attachment 114129
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114129=edit
Bug 12430: Force relevance ranking when not using QueryParser

The system preference "QueryWeightFields" is mutually exclusive with
the system preference "QueryAutoTruncate" and the * truncation
modifier, when not using QueryParser.

If you use truncation, relevance won't work anymore. (N.B. Relevance
doesn't work probably when using QueryParser, but for a very different
reason beyond the current scope of this bug.)

This patch adds relevance ranking when using truncation (or basically
when QueryWeightFields is disabled).

_TEST PLAN_

0) Use koha-testing-docker
1) Ensure that "QueryWeightFields" is enabled and "QueryAutoTruncate" is set to
auto
2) Go to http://localhost:8080/cgi-bin/koha/opac-search.pl?q=e
3) Note that the results are ordered by biblionumber ascending

4) Apply patch

5) Go to http://localhost:8080/cgi-bin/koha/opac-search.pl?q=e
6) Note that the results are not ordered by biblionumber ascending
(presumably they are in relevance order)

If you edit /etc/koha/sites/kohadev/koha-conf.xml and add "requests"
to the end of "zebra_loglevels", uncomment that option, and carefully
restart Zebra, you should be able to see the following in
/var/log/koha/kohadev/zebra-output.log:

Search biblios OK 394 1 1+0 RPN @attrset Bib-1 @attr 1=1016 @attr 4=6 @attr 5=1
@attr 2=102 e

The 2=102 indicates a relevance search.

Signed-off-by: Victor Grousset/tuxayo 

Signed-off-by: Katrin Fischer 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25900] Double quotes breaks search with Zebra and QueryWeightFields

2020-12-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25900

--- Comment #10 from David Cook  ---
Using koha-testing-docker w/o patch using CHR in
/etc/koha/zebradb/etc/default.idx:

QueryAutoTruncate:
Query: test
Request: @attrset Bib-1 @attr 1=1016 @attr 4=6 @attr 5=1 test

Query: "test"
Request: @attrset Bib-1 @attr 1=1016 @attr 4=6 @attr 5=1 @attr 2=102 test

QueryWeightFields:
Query: test
Request: @attrset Bib-1 @or @or @or @or @or @or @attr 1=36 @attr 4=1 @attr 6=3
@attr 9=32 @attr 2=102 test @attr 1=4 @attr 4=1 @attr 6=3 @attr 9=28 @attr
2=102 test @attr 1=
36 @attr 4=1 @attr 9=26 @attr 2=102 test @attr 1=4 @attr 4=6 @attr 9=24
@attr 2=102 test @attr 4=6 @attr 5=103 @attr 9=16 @attr 2=102 test @attr 4=6
@attr 5=1 @attr 9=14 @attr 2=102 "test? " @attr 4=6 @attr 9=14 @attr 2=102 test

Query: "test"
Request: @attrset Bib-1 @or @or @or @or @or @or @attr 1=36 @attr 4=1 @attr 6=3
@attr 9=32 @attr 2=102 " test " @attr 1=4 @attr 4=1 @attr 6=3 @attr 9=28 @attr
2=102 " test " @att
r 1=36 @attr 4=1 @attr 9=26 @attr 2=102 " test " @attr 1=4 @attr 4=6 @attr 9=24
@attr 2=102 " test " @attr 4=6 @attr 5=103 @attr 9=16 @attr 2=102 " test "
@attr 4=6 @attr 5=1 @attr 9=14 @attr 2=102 "test? " @attr 4=6 @attr 9=14 @attr
2=1
02 " test "

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27140] New: koha-zebra doesn't properly stop Zebra

2020-12-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27140

Bug ID: 27140
   Summary: koha-zebra doesn't properly stop Zebra
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: dc...@prosentient.com.au
QA Contact: testo...@bugs.koha-community.org

So I just tried "koha-zebra --restart kohadev" after making a change to log
levels to include request in koha-conf.xml in koha-testing-docker and it's a
mess:

root@kohadevbox:koha(bug_12430)$ ps -efww | grep "zebrasrv"
kohadev+   808 1  0 02:04 ?00:00:00 daemon
--name=kohadev-koha-zebra --pidfiles=/var/run/koha/kohadev/
--errlog=/var/log/koha/kohadev/zebra-error.log
--output=/var/log/koha/kohadev/zebra-output.log --verbose=1 --respawn --del
ay=30 --user=kohadev-koha.kohadev-koha -- /usr/bin/zebrasrv -v none,fatal,warn
-k 1024 -f /etc/koha/sites/kohadev/koha-conf.xml
kohadev+   840   808  0 02:04 ?00:00:00 [zebrasrv] 
kohadev+  5183 1  0 04:28 ?00:00:00 /usr/bin/zebrasrv -v
none,fatal,warn -k 1024 -f /etc/koha/sites/kohadev/koha-conf.xml
root  5373  3959  0 04:31 pts/100:00:00 grep zebrasrv

Using "kill -9", I kill off all those.

I run "koha-zebra --start kohadev":

root@kohadevbox:koha(bug_12430)$ ps -efww | grep "zebrasrv"
kohadev+  5418 1  0 04:31 ?00:00:00 daemon
--name=kohadev-koha-zebra --pidfiles=/var/run/koha/kohadev/
--errlog=/var/log/koha/kohadev/zebra-error.log
--output=/var/log/koha/kohadev/zebra-output.log --verbose=1 --respawn --del
ay=30 --user=kohadev-koha.kohadev-koha -- /usr/bin/zebrasrv -v
none,fatal,warn,request -k 1024 -f /etc/koha/sites/kohadev/koha-conf.xml
kohadev+  5422  5418  0 04:31 ?00:00:00 /usr/bin/zebrasrv -v
none,fatal,warn,request -k 1024 -f /etc/koha/sites/kohadev/koha-conf.xml
root  5424  3959  0 04:31 pts/100:00:00 grep zebrasrv

That's much better now.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12430] Search truncation disables relevance ranking

2020-12-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430

--- Comment #63 from David Cook  ---
Changing the 2nd patch to use t/Search/buildQuery.t instead of t/Search.t
because it's so complex it deserves to be in its own file...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12430] Search truncation disables relevance ranking

2020-12-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430

--- Comment #62 from David Cook  ---
(In reply to David Nind from comment #51)
> Everything works as per the the test plan, but tests fail:
> 
> Test Summary Report
> ---
> t/Search.t (Wstat: 256 Tests: 6 Failed: 1)
>   Failed test:  5
>   Non-zero exit status: 1
> Files=1, Tests=6,  4 wallclock secs ( 0.03 usr  0.01 sys +  3.42 cusr  0.12
> csys =  3.58 CPU)
> Result: FAIL

It looks like the first patch is good, but my "Unit tests for buildQuery" patch
is not.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16581] ICU tokenization bug in idzebra-2.0 2.0.59-1

2020-12-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16581

--- Comment #11 from David Cook  ---
We should probably update debian/control to require a newer version of Zebra
since we know that 2.0.59 is buggy...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12430] Search truncation disables relevance ranking

2020-12-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430

--- Comment #61 from David Cook  ---
root@kohadevbox:koha(master)$ git checkout bug12430
Switched to branch 'bug12430'
Your branch and 'origin/master' have diverged,
and have 1 and 19114 different commits each, respectively.
  (use "git pull" to merge the remote branch into yours)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27137] Move item doesn't show the title of the target record

2020-12-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27137

Aleisha Amohia  changed:

   What|Removed |Added

  Text to go in the||This patch fixes a small
  release notes||bug to ensure that the
   ||title of the target
   ||bibliographic record shows
   ||as expected upon
   ||successfully attaching an
   ||item.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27137] Move item doesn't show the title of the target record

2020-12-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27137

Aleisha Amohia  changed:

   What|Removed |Added

  Change sponsored?|--- |Sponsored
   Assignee|koha-b...@lists.koha-commun |alei...@catalyst.net.nz
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27137] Move item doesn't show the title of the target record

2020-12-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27137

--- Comment #1 from Aleisha Amohia  ---
Created attachment 114128
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114128=edit
Bug 27137: Correctly show biblio title after successfully moving item

In Bug 11529 we changed the variable that was passed to the template but
missed updating the template.

This patch ensures we correctly access the variable to show the title of
the biblio.

To test:
1) Create two biblios (Biblio A and Biblio B)
2) Add an item to Biblio A (Item A)
3) Go to Biblio B
4) In the cataloguing toolbar, click Edit, then Attach item
5) Enter the barcode for Item A and submit
6) Notice the item has successfully moved by Biblio B's title does not
show
7) Apply patch
8) Go to Biblio A
9) In the cataloguing toolbar, click Edit, then Attach item
10) Enter the barcode for Item A and submit
11) Confirm Biblio A's title shows correctly

Sponsored-by: Toi Ohomai Institute of Technology

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27137] Move item doesn't show the title of the target record

2020-12-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27137

Aleisha Amohia  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool

2020-12-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150

--- Comment #9 from Aleisha Amohia  ---
Created attachment 114127
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114127=edit
Bug 3150: WIP

This is not ready yet!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27139] Search errors are incorrectly shown to users as no results found

2020-12-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27139

--- Comment #1 from David Cook  ---
Related note:

If you're using Zebra, you have QueryAutoTruncate enabled, and
QueryWeightFields enabled, you'll have fairly simple query building happening.
It leads to the following situation:

Search:
"Emperor penguin (Aptenodytes forsteri) foraging ecology" 
Query:
@attrset Bib-1 @attr 1=1016 @attr 4=6 @attr 5=1 "Emperor penguin (Aptenodytes
forsteri) foraging ecology"

Search:
Emperor penguin (Aptenodytes forsteri) foraging ecology
Query:
ZOOM error 10014 "CCL parsing error" (addinfo: "Operator expected") from
diag-set 'ZOOM'

Search:
Emperor penguin \(Aptenodytes forsteri\) foraging ecology
Query:
@attrset Bib-1 @attr 1=1016 @attr 4=6 @attr 5=1 "Emperor penguin (Aptenodytes
forsteri) foraging ecology"

ZOOM::Query::CCL2RPN returns an exception with code, addinfo, message, and
diagset fields:
$VAR1 = bless( {
 'code' => 10014,
 'addinfo' => 'Operator expected',
 'message' => 'CCL parsing error',
 'diagset' => 'ZOOM'
   }, 'ZOOM::Exception' );

We would need to return this exception or derived data from
C4::Search::getRecords() and then from
Koha::SearchEngine::Zebra::Search::search_compat().

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27088] Searching with just OR or AND gives error

2020-12-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27088

--- Comment #8 from David Cook  ---
(In reply to Jonathan Druart from comment #6)
> IMO it's not a good idea to parse the query for such problems before we sent
> it to ES. We should request ES and eventually provide feedback to the user
> about why their query might have been syntactically wrong.

I'm sure it's probably a duplicate but I've raised Bug 27139 about showing
users that there has been a search query error.

That being said... you can type gibberish into Google and Google will never
tell you that you have a syntax error.

(Although I just tried doing an "any of these words" advanced search in Google
using  "miniature OR" and it created a search query for "miniature OR OR" so
even Google is a bit buggy / incorrectly documented when it comes to complex
search.)

(Typing '"urban keith" and "pickles"' into Google without the single quotes
also gives different results to what I'd expect. I want to know about Urban
Keith and not Keith Urban, although it seems that Google thinks I've made a
typo.)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27139] New: Search errors are incorrectly shown to users as no results found

2020-12-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27139

Bug ID: 27139
   Summary: Search errors are incorrectly shown to users as no
results found
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Searching
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: dc...@prosentient.com.au
QA Contact: testo...@bugs.koha-community.org

When there is an error submitting a query to Zebra or Elasticsearch, the user
should be informed that their query could not be completed due to an error with
their search.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27138] Host items are not included in Z39 results when using EasyAnalytics

2020-12-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27138

Nick Clemens  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com
   |ity.org |
 CC||katrin.fisc...@bsz-bw.de

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27138] Host items are not included in Z39 results when using EasyAnalytics

2020-12-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27138

--- Comment #1 from Nick Clemens  ---
Created attachment 114126
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114126=edit
Bug 27138: Index host items in child records when sending to search engine

On the Koha side we seperate the items from the MARC record but we do put them
in
the search engines

For easy analytics we embed host items when displaying results after fetching
from the search engine

We can simpify things and improve results by including the host items when
indexing

To test:
 1 - Enable EasyAnalyticalRecords
 2 - Find a record in the staff client
 3 - From details page select Edit->Link to host record
 4 - Attach a barcode from a different record
 5 - Search for that barcode in the staff client
 6 - Only host record is returned
 7 - Perform a search that returns the child record and others
 8 - Note the host item is listed on the child record in the results page
 9 - Repeat on OPAC
10 - Note on opac that host item is missing on results
11 - Apply patch
12 - Search for barcode
13 - Child and host record returned on both staff and OPAC
14 - Child record correctly includes host item on staff and OPAC
15 - Connect to the Z3950 responder or zebra directly
 yaz-client localhost:2100
 yaz-client unix:/var/run/koha/kohadev/bibliosocket
16 - Search for the child record
 base biblios
 find record_keyword
 show 1+10
17 - Note the record includes the host item
18 - Repeat tests for Elasticsearch

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27138] Host items are not included in Z39 results when using EasyAnalytics

2020-12-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27138

Nick Clemens  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27138] New: Host items are not included in Z39 results when using EasyAnalytics

2020-12-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27138

Bug ID: 27138
   Summary: Host items are not included in Z39 results when using
EasyAnalytics
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Searching
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: n...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

If a library enables EasyAnalytics and links two records in the catalog then
the host items show on the child record.

If you search for these records via Z3950 (via zebra directly or the responder)
the host items are not shown

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table

2020-12-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529

Aleisha Amohia  changed:

   What|Removed |Added

 Blocks||27137


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27137
[Bug 27137] Move item doesn't show the title of the target record
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27137] Move item doesn't show the title of the target record

2020-12-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27137

Aleisha Amohia  changed:

   What|Removed |Added

 Depends on||11529
   Severity|enhancement |minor


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529
[Bug 11529] Add subtitle, medium and part fields to biblio table
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27137] New: Move item doesn't show the title of the target record

2020-12-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27137

Bug ID: 27137
   Summary: Move item doesn't show the title of the target record
 Change sponsored?: ---
   Product: Koha
   Version: 20.05
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Cataloging
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: alei...@catalyst.net.nz
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

Bug 11529 added this change to cataloguing/moveitem.pl

 my $biblio = Koha::Biblios->find( $biblionumber );
-$template->param(bibliotitle => $biblio->title);
+$template->param(biblio => $biblio);

But the template was not updated so it still tries to access the bibliotitle
variable

 The item has successfully been attached to [%
INCLUDE 'biblio-default-view.inc' %][% bibliotitle | html %].

Which no longer exists. So when the item is successfully moved, no biblio title
is shown.

This bug exists in 19.11 and 20.05 but not 20.11.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12430] Search truncation disables relevance ranking

2020-12-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430

--- Comment #60 from David Cook  ---
Actually, I got caught out by this one today, so I think I will have another
crack at this one.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26890] opac-detail plugin like intranet/cgi-bin/catalogue/detail.pl

2020-12-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26890

--- Comment #17 from David Cook  ---
After looking at Bug 27114 and Bug 27120, I reckon that it would be a good idea
to get an "opac_catalog_biblio_tab" enhancement done. 

In fact, I just did a local customization recently which I could've done as a
plugin instead, if an OPAC equivalent of those above bugs was completed.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27114] Use Template Toolkit plugin for Koha plugins hook 'intranet_catalog_biblio_tab'

2020-12-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27114

David Cook  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=26890

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27120] Send biblio to Koha plugins hook 'intranet_catalog_biblio_tab'

2020-12-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27120

David Cook  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=26890

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26890] opac-detail plugin like intranet/cgi-bin/catalogue/detail.pl

2020-12-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26890

David Cook  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=27120,
   ||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=27114

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27114] Use Template Toolkit plugin for Koha plugins hook 'intranet_catalog_biblio_tab'

2020-12-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27114

--- Comment #4 from David Cook  ---
Hmm ok. I think I was opposed to this idea yesterday, but for some reason I
seem in favour of it today heh.

Since it's not modifying any existing data in detail.pl, I suppose there's no
reason why it shouldn't just be handled in detail.tt, since it's really just
updating the view.

And then Bug 27120 makes sense too. 

In fact... I recently did a local customization that probably could've been
done as a plugin, if Bug 27120 were pushed. (Actually, it was an OPAC one... so
not relevant here, so having an OPAC equivalent would be good after all...)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25026] RaiseError must be set for the UI

2020-12-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25026

--- Comment #11 from David Cook  ---
(In reply to Victor Grousset/tuxayo from comment #9)
> It works! 
> 

This could give me my first opportunity to QA! Looking forward to it...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25026] RaiseError must be set for the UI

2020-12-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25026

--- Comment #10 from David Cook  ---
(In reply to Jonathan Druart from comment #7)
> diff --git a/populate_db.pl b/populate_db.pl
> index 097bbda..7d07aa6 100755
> --- a/populate_db.pl
> +++ b/populate_db.pl
> @@ -92,8 +92,8 @@ if ( $marcflavour ne 'MARC21'
>  
>  my $dbh = C4::Context->dbh; # At the beginning to die if DB does not exist.
>  
> -my ( $prefs_count ) = $dbh->selectrow_array(q|SELECT COUNT(*) FROM
> systempreferences|);
> -my ( $patrons_count ) = $dbh->selectrow_array(q|SELECT COUNT(*) FROM
> borrowers|);
> +my ( $prefs_count ) = eval { $dbh->selectrow_array(q|SELECT COUNT(*) FROM
> systempreferences|) };
> +my ( $patrons_count ) = eval { $dbh->selectrow_array(q|SELECT COUNT(*) FROM
> borrowers|) };
>  if ( $prefs_count or $patrons_count ) {
>  die "Database is not empty!";
>  }
> 
> You will need to apply this to koha-misc4dev first.

Can you clarify why we need to do this? Is koha-misc4dev currently broken?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27080] Add --statute-barred option to cleanup_database.pl to purge all fees where the item has been returned and the fee is older than the given number of days.

2020-12-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27080

--- Comment #13 from David Cook  ---
(In reply to Katrin Fischer from comment #12)
> I was wondering about the term too, but the translations to German make
> sense and it appears to be an existing English term :) It's a legal term
> meaning kind of "expired". There has so much time passed, that the fee has
> "expired". In German: verjährt.

Thanks for the clarification, Katrin. It does appear to be an English legal
term, and that it typically refers to debts. I love learning new things.

Maybe --statue-barred-fees or --statute-barred-debts might be a little more
explicit? Before Katrin explained the term to me, I probably could've intuited
the meaning of "statue-barred-fees" or "statute-barred-debts", but I was
confused what "thing" that "statute-barred" would refer to without my newfound
knowledge.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27068] HoldsQueue doesn't know how to use holds groups

2020-12-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27068

Agustín Moyano  changed:

   What|Removed |Added

 CC||agustinmoy...@theke.io

--- Comment #5 from Agustín Moyano  ---
Hello Kyle, could you please checkout this patch?

I've placed holds policy checking (including hold groups) inside a function
called _checkHoldsPolicy, and call it whenever it's needed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27068] HoldsQueue doesn't know how to use holds groups

2020-12-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27068

Agustín Moyano  changed:

   What|Removed |Added

 Attachment #113900|0   |1
is obsolete||

--- Comment #4 from Agustín Moyano  ---
Created attachment 114125
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114125=edit
Bug 27068: Control hold group logic in HoldsQueue

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26713] Add pagination to bottom of saved SQL reports table

2020-12-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26713

Lisette Scheer  changed:

   What|Removed |Added

 CC||lisettesla...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27080] Add --statute-barred option to cleanup_database.pl to purge all fees where the item has been returned and the fee is older than the given number of days.

2020-12-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27080

--- Comment #12 from Katrin Fischer  ---
(In reply to David Cook from comment #11)
> Can you elaborate on what "statute-barred" means? At a glance, it doesn't
> mean anything obvious in English. At a stretch, I'd guess that it means
> something isn't allowed by law (ie statute), but it's not clear what's not
> allowed. 
> 
> There might not be a problem with the wording per se, but we might want to
> add some more description about the meaning of the wording, since it's not
> clear.

I was wondering about the term too, but the translations to German make sense
and it appears to be an existing English term :) It's a legal term meaning kind
of "expired". There has so much time passed, that the fee has "expired". In
German: verjährt.

Timothy - it's usually not good to broaden the scope, keep it to small steps. I
suggest to do the refactoring of the existing code on a separate bug, making
sure the havaviour is kept and then add the new option on top if you want to
change both subs.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12224] Allow easy printing of patron check-in slip

2020-12-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12224

--- Comment #49 from Aleisha Amohia  ---
Created attachment 114124
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114124=edit
Bug 12224: (follow-up) Switching to TT notice

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12224] Allow easy printing of patron check-in slip

2020-12-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12224

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #110578|0   |1
is obsolete||

--- Comment #48 from Aleisha Amohia  ---
Created attachment 114123
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114123=edit
Bug 12224: (follow-up) Access old_issues table when editing notice

This QA follow-up allows access to the old_issues table when editing the
notice in Tools.

Signed-off-by: Alexandra Speer 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12224] Allow easy printing of patron check-in slip

2020-12-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12224

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #110577|0   |1
is obsolete||

--- Comment #47 from Aleisha Amohia  ---
Created attachment 114122
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114122=edit
Bug 12224: (follow-up) Move button to patron column in checkins table

This patch moves the "Print checkin slip" out of its own column and into
the colum containing patron information. I think this makes more sense
because the slip is specific to a patron, not the individual item which
has been checked in.

Also changed: printcheckinslip function should be triggered via a class,
not a non-unique ID. The function should handle the click using
"preventDefault" rather than "return false."

To test, apply the patch and check in some items checked out to various
patrons.

- In the table of checked-in items, confirm that the "Print checkin
  slip" appears correctly in the column of patron information.
- Confirm that the button works correctly to print the correct slip for
  the associated patron.

Signed-off-by: David Nind 

Signed-off-by: Alexandra Speer 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12224] Allow easy printing of patron check-in slip

2020-12-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12224

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #110576|0   |1
is obsolete||

--- Comment #46 from Aleisha Amohia  ---
Created attachment 114121
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114121=edit
Bug 12224: Print a slip of borrower's checkins for today

To test:

1) Apply patch and run installer
2) Check out two items (or more) to a borrower
3) Check in two items (or more) for this borrower (you should end up on
circ/returns.pl)
4) Notice the checked-in items table has started building. There should
be a new column with the button 'Print checkin slip' in each row.
5) Click the button and confirm the checkin slip opens for printing in a
new window.
6) Go to the patron's account
7) Click the Print dropdown. Confirm there is a 'Print checkin slip'
option. Click this and confirm the checkin slip opens for printing in a
new window.

Sponsored-by: Bibliotheksservice-Zentrum Baden-Württemberg (BSZ)

Signed-off-by: Owen Leonard 

Signed-off-by: David Nind 

Signed-off-by: Alexandra Speer 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12224] Allow easy printing of patron check-in slip

2020-12-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12224

Aleisha Amohia  changed:

   What|Removed |Added

 Status|In Discussion   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27080] Add --statute-barred option to cleanup_database.pl to purge all fees where the item has been returned and the fee is older than the given number of days.

2020-12-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27080

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

--- Comment #11 from David Cook  ---
Can you elaborate on what "statute-barred" means? At a glance, it doesn't mean
anything obvious in English. At a stretch, I'd guess that it means something
isn't allowed by law (ie statute), but it's not clear what's not allowed. 

There might not be a problem with the wording per se, but we might want to add
some more description about the meaning of the wording, since it's not clear.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26976] When renewalsallowed is empty the UI is not correct

2020-12-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26976

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26976] When renewalsallowed is empty the UI is not correct

2020-12-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26976

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 CC||vic...@tuxayo.net
 QA Contact|testo...@bugs.koha-communit |vic...@tuxayo.net
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26976] When renewalsallowed is empty the UI is not correct

2020-12-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26976

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Attachment #113883|0   |1
is obsolete||

--- Comment #3 from Victor Grousset/tuxayo  ---
Created attachment 114120
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114120=edit
Bug 26976: Display 0 if renewalsallowed is not defined

If the circulation rule "renewalsallowed" is not set (or an empty
string) then the checkout list displays
(0 of  renewals remaining)
It should display "0 of 0"

Test plan:
Set renewalsallowed to an empty string
Check an item out
Notice the change

Signed-off-by: David Nind 
Signed-off-by: Victor Grousset/tuxayo 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25583] When ClaimReturnedLostValue is not set, the claim returned tab doesn't appear

2020-12-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25583

--- Comment #8 from Victor Grousset/tuxayo  ---
It works :)

About the phrasing, should we say "Claim returned is disabled" or "Return
claims are disabled"?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27136] Add languages and avoid displaying nothing in facet

2020-12-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27136

Alexis Ripetti  changed:

   What|Removed |Added

 Attachment #114107|0   |1
is obsolete||

--- Comment #2 from Alexis Ripetti  ---
Created attachment 114119
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114119=edit
Bug 27136 - Add languages and avoid displaying nothing in facet

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17314] Routes to create, list and delete a purchase suggestion

2020-12-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314

--- Comment #58 from Arthur Suzuki  ---
Created attachment 114118
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114118=edit
Bug 17314: (QA follow-up)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17314] Routes to create, list and delete a purchase suggestion

2020-12-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314

--- Comment #57 from Arthur Suzuki  ---
Created attachment 114117
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114117=edit
Bug 17314: (QA follow-up) Adjust spec

This patch makes the exposed attribute names match what is defined in
the internal mapping in the code, and also the query parameters.

It also:
- Makes 'status' an enum, as we know the list of possible values/codes...
- Removes allow-owner and allow-guarantor, as said before, endpoints in
/public namespace are allowed to use those. I didn't go and write those
endpoints becuase I wasn't sure about the restrictions that apply in the
OPAC and might differ from the ones in the staff interface.
- Some numeric values are marked as such
- Dates are strings in OpenAPI, but there's a way to specify the format
inside the string: "format": "date". Use it

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17314] Routes to create, list and delete a purchase suggestion

2020-12-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314

--- Comment #56 from Arthur Suzuki  ---
Created attachment 114116
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114116=edit
Bug 17314: Added _to_model and _to_api methods and changed attirbutes naming

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17314] Routes to create, list and delete a purchase suggestion

2020-12-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314

--- Comment #55 from Arthur Suzuki  ---
Created attachment 114115
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114115=edit
Bug 17314: (QA follow-up)

Test plan unchanged

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17314] Routes to create, list and delete a purchase suggestion

2020-12-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314

--- Comment #54 from Arthur Suzuki  ---
Created attachment 114114
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114114=edit
Bug 17314: Migration from Swagger2 to OpenApi

This patch migrates the original implementation so it uses the new
OpenAPI plugin.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17314] Routes to create, list and delete a purchase suggestion

2020-12-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314

Arthur Suzuki  changed:

   What|Removed |Added

 Attachment #109972|0   |1
is obsolete||
 Attachment #109973|0   |1
is obsolete||
 Attachment #109974|0   |1
is obsolete||
 Attachment #109975|0   |1
is obsolete||
 Attachment #109976|0   |1
is obsolete||
 Attachment #109977|0   |1
is obsolete||

--- Comment #53 from Arthur Suzuki  ---
Created attachment 114113
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114113=edit
Bug 17314: Routes to handle purchase suggestions

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17314] Routes to create, list and delete a purchase suggestion

2020-12-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314

Arthur Suzuki  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24429] Advanced editor - Add ability to generate an export file as cataloger saves

2020-12-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24429

--- Comment #11 from Cori Lynn Arnold  ---
Created attachment 114112
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114112=edit
Bug 24429 - Advanced editor - Add ability to generate an export file as
cataloger saves

Adds the ability for catalogers to *automatically* save a list of bibs
to export as they are cataloging.

To test, apply patch:
0/Verify that the advanced editor is enabled by going to
"Administration" and searching for "EnableAdvancedCatalogingEditor"
1/Set it to "Enable" if it isn't already.
2/Go to "Cataloging", click on "Advanced editor"
3/Click on "Export" button (verify a modal window comes up)
4/Click on the link for "New Export File", name the export file
5/Close the modal window
6/Search for a record by entering "specious" in the keyword box and
hitting enter
7/Click "import" on a record
8/Make some changes and hit "Save", note the bib number
9/Repeat steps 6-8 for several records, getting records from the catalog
and importing through the "import" button in the UI
10/Click on "Export..." button
11/Click on the link for the name you created in step 4
12/Verify the bib numbers from step 8 are in the Export Files Editor
13/Click "Generate Export File"
14/Verify that all the records for every bib listed is in the file
generated
15/Repeat steps with different file names / records

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24429] Advanced editor - Add ability to generate an export file as cataloger saves

2020-12-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24429

Cori Lynn Arnold  changed:

   What|Removed |Added

 Attachment #114110|0   |1
is obsolete||

--- Comment #10 from Cori Lynn Arnold  ---
Created attachment 114111
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114111=edit
Bug 24429: Advanced editor - Add ability to generate an export file as
cataloger saves

Adds the ability for catalogers to *automatically* save a list of bibs
to export as they are cataloging.

To test, apply patch:
0/Verify that the advanced editor is enabled by going to
"Administration" and searching for "EnableAdvancedCatalogingEditor"
1/Set it to "Enable" if it isn't already.
2/Go to "Cataloging", click on "Advanced editor"
3/Click on "Export" button (verify a modal window comes up)
4/Click on the link for "New Export File", name the export file
5/Close the modal window
6/Search for a record by entering "specious" in the keyword box and
hitting enter
7/Click "import" on a record
8/Make some changes and hit "Save", note the bib number
9/Repeat steps 6-8 for several records, getting records from the catalog
and importing through the "import" button in the UI
10/Click on "Export..." button
11/Click on the link for the name you created in step 4
12/Verify the bib numbers from step 8 are in the Export Files Editor
13/Click "Generate Export File"
14/Verify that all the records for every bib listed is in the file
generated
15/Repeat steps with different file names / records

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24429] Advanced editor - Add ability to generate an export file as cataloger saves

2020-12-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24429

Cori Lynn Arnold  changed:

   What|Removed |Added

 Attachment #114109|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24429] Advanced editor - Add ability to generate an export file as cataloger saves

2020-12-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24429

--- Comment #9 from Cori Lynn Arnold  ---
Created attachment 114110
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114110=edit
Bug 24429 - Advanced editor - Add ability to generate an export file as
cataloger saves

Adds the ability for catalogers to *automatically* save a list of bibs
to export as they are cataloging.

To test, apply patch:
0/Verify that the advanced editor is enabled by going to
"Administration" and searching for "EnableAdvancedCatalogingEditor"
1/Set it to "Enable" if it isn't already.
2/Go to "Cataloging", click on "Advanced editor"
3/Click on "Export" button (verify a modal window comes up)
4/Click on the link for "New Export File", name the export file
5/Close the modal window
6/Search for a record by entering "specious" in the keyword box and
hitting enter
7/Click "import" on a record
8/Make some changes and hit "Save", note the bib number
9/Repeat steps 6-8 for several records, getting records from the catalog
and importing through the "import" button in the UI
10/Click on "Export..." button
11/Click on the link for the name you created in step 4
12/Verify the bib numbers from step 8 are in the Export Files Editor
13/Click "Generate Export File"
14/Verify that all the records for every bib listed is in the file
generated
15/Repeat steps with different file names / records

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24429] Advanced editor - Add ability to generate an export file as cataloger saves

2020-12-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24429

Cori Lynn Arnold  changed:

   What|Removed |Added

  Attachment #97404|0   |1
is obsolete||
  Attachment #97566|0   |1
is obsolete||
  Attachment #98728|0   |1
is obsolete||

--- Comment #8 from Cori Lynn Arnold  ---
Created attachment 114109
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114109=edit
Bug 24429 - Advanced editor - Add ability to generate an export file as
cataloger saves

Adds the ability for catalogers to *automatically* save a list of bibs
to export as they are cataloging.

To test, apply patch:
0/Verify that the advanced editor is enabled by going to
"Administration" and searching for "EnableAdvancedCatalogingEditor"
1/Set it to "Enable" if it isn't already.
2/Go to "Cataloging", click on "Advanced editor"
3/Click on "Export" button (verify a modal window comes up)
4/Click on the link for "New Export File", name the export file
5/Close the modal window
6/Search for a record by entering "specious" in the keyword box and
hitting enter
7/Click "import" on a record
8/Make some changes and hit "Save", note the bib number
9/Repeat steps 6-8 for several records, getting records from the catalog
and importing through the "import" button in the UI
10/Click on "Export..." button
11/Click on the link for the name you created in step 4
12/Verify the bib numbers from step 8 are in the Export Files Editor
13/Click "Generate Export File"
14/Verify that all the records for every bib listed is in the file
generated
15/Repeat steps with different file names / records

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26905] Purchase suggestion button hidden for users with suggestion permission but not acq permission

2020-12-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26905

--- Comment #6 from Owen Leonard  ---
(In reply to Jonathan Druart from comment #5)
> And... maybe we weird "suggestion", but shouldn't we display it only if it's
> not accessible from the acquisition module?

I don't see any reason to hide it. Whether or not the user has acquisitions
permissions it's still a tool that one might want to access directly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25583] When ClaimReturnedLostValue is not set, the claim returned tab doesn't appear

2020-12-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25583

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Attachment #113878|0   |1
is obsolete||

--- Comment #7 from Victor Grousset/tuxayo  ---
Created attachment 114108
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114108=edit
Bug 25583: Disable the "claim returned" button if the feature is disabled

It's possible to display the "Return claims" column on the checkout
list, even if the feature is disabled.
We should disable the link and add an explanation.

Test plan:
- Make sure ClaimReturnedLostValue is empty
- Go to a patron account
- Check out an item
- Make the claims returned column visible in the table of checkouts
=> The button is disabled and a tooltip explains that the feature is
disabled

Signed-off-by: Kyle M Hall 
Signed-off-by: Victor Grousset/tuxayo 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27136] Add languages and avoid displaying nothing in facet

2020-12-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27136

--- Comment #1 from Alexis Ripetti  ---
Created attachment 114107
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114107=edit
Bug 27136 - Add languages and avoid displaying nothing in facet

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27136] Add languages and avoid displaying nothing in facet

2020-12-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27136

Alexis Ripetti  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27136] New: Add languages and avoid displaying nothing in facet

2020-12-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27136

Bug ID: 27136
   Summary: Add languages and avoid displaying nothing in facet
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Searching - Elasticsearch
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: alexis.ripe...@inlibro.com

Adding some languages : Cree, Afrikaans and Multiple languages, Undetermined
and No linguistic content.
Also adding a way to avoid displaying nothing in facet for opac and client
staff when using elasticsearch as SearchEngine.

Test plan:
1) Do a search, like 'a'
2) Look in the bottom of the sidebar on the left and see that there is an empty
language
3) Apply patch
4) Update database
5) Do the same research
6) See that there is now "No information provided"

You can test translation :
TESTING TRANSLATABILITY

- Update a translation, e.g. fr-FR:

> cd misc/translator
> perl translate update fr-FR

- Open the corresponding .po file for opac, e.g.
  misc/translator/po/fr-FR-opac-bootstrap.po
- Locate strings pulled from
  koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-facets.inc for
  translation, e.g.:

  msgid "%s%s%sNo information provided%s"
  msgstr ""

- Edit the "msgstr" string however you want (it's just for testing),
example : msgstr "%s%s%sAucune information fournie%s"

Do the same for the client staff :

- Open the corresponding .po file for opac, e.g.
  misc/translator/po/fr-FR-staff-prog.po
- Locate strings pulled from
  koha-tmpl/intranet-tmpl/prog/en/includes/facets.inc for
  translation, e.g.:

  msgid "%s%s%sNo information provided%s"
  msgstr ""

- Edit the "msgstr" string however you want (it's just for testing),
example : msgstr "%s%s%sAucune information fournie%s"

- Install the updated translation:

> perl translate install fr-FR

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25583] When ClaimReturnedLostValue is not set, the claim returned tab doesn't appear

2020-12-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25583

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |vic...@tuxayo.net
   |y.org   |
 CC||vic...@tuxayo.net

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26991] Add action logs to search engine administration

2020-12-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26991

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||da...@davidnind.com

--- Comment #2 from David Nind  ---
Patch no longer applies 8-(..

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27068] HoldsQueue doesn't know how to use holds groups

2020-12-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27068

Tomás Cohen Arazi  changed:

   What|Removed |Added

   Assignee|agustinmoy...@theke.io  |tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24254] Add Koha::Biblio get_visible_items method

2020-12-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24254

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org,
   ||martin.renvoize@ptfs-europe
   ||.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25026] RaiseError must be set for the UI

2020-12-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25026

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 CC||vic...@tuxayo.net
 Status|Needs Signoff   |Signed Off

--- Comment #9 from Victor Grousset/tuxayo  ---
It works! 

About comment 7 , in koha-testing-docker, I edited misc4dev/populate_db.pl and
did reset_all, was that correct?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25026] RaiseError must be set for the UI

2020-12-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25026

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Attachment #114059|0   |1
is obsolete||

--- Comment #8 from Victor Grousset/tuxayo  ---
Created attachment 114106
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114106=edit
Bug 25026: Turn on RaiseError

This is a follow-up for bug 22001.

The patch "Bug 22001: Set unsafe only if RaiseError is not set" proved that
unsafe => 1 and RaiseError => 0 was wrong.
We should move forward and turn RaiseError for the UI, and... see what's
happening.
The change goes to the right direction, but we need to know how big is the task
to have a stable release with these parameters correctly set.

We will have a lot of fun once this patch is pushed! :)

Test plan:
0. Does not apply the patch
1. Add, somewhere in mainpage.pl
  C4::Acquisition::NewBasket();
2. restart_all
3. Hit the mainpage
=> Hum... nothing happens! However there is an error in the logs
 DBI Exception: DBD::mysql::db do failed: Column 'booksellerid' cannot be null
No basket has been created!
4. Apply the patch, restart_all
5. Hit the mainpage
=> Here we go, there was something wrong and the user is aware of that!

Signed-off-by: Victor Grousset/tuxayo 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26943] Show not for loan descriptions in cataloging search (addbooks.pl)

2020-12-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26943

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Attachment #113429|0   |1
is obsolete||

--- Comment #2 from Andrew Fuerste-Henry  ---
Created attachment 114105
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114105=edit
Bug 26943: Add notforloan statuses to catalog search

- create a positive value and a description of "Positive"
- set an item to your "Positive" value
- pull up the related bib in a cataloging search
- confirm it shows "Not for loan" in the Location column
- create a negative value and a description of "Negative"
- set an item to your "Negative" value
- pull up the related bib in a cataloging search
- confirm it shows "On order" in the Location column
- Apply patch
- re-do the cataloing search, instead of 'Not for loan' or 'On order' you
should instead see the actual nfl description

Signed-off-by: Andrew Fuerste-Henry 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26943] Show not for loan descriptions in cataloging search (addbooks.pl)

2020-12-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26943

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26145] Add the ability to attach a cover image at item level

2020-12-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26145

Fridolin Somers  changed:

   What|Removed |Added

 Blocks||27135


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27135
[Bug 27135] Viewing local cover images at item level shows a link to upload
image at record level
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   3   >