[Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles

2021-03-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516

--- Comment #293 from Aleisha Amohia  ---
(In reply to Kyle M Hall from comment #284)
> What impact will this feature have on the holds queue. As it stands, there
> will be a request in the queue for each available item in the hold group. I
> see the holds to pull report gives a link to the holds group. I think the
> same functionality would be needed for the holds queue report as well.
> 
> In addition, we'll need to make sure this bug and bug 24359 work together.

Have rebased and addressed these points!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles

2021-03-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516

--- Comment #292 from Aleisha Amohia  ---
Created attachment 118286
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118286=edit
Bug 15516: (follow-up) Remove other holds in hold_group from holds_queue

When one hold is fulfilled or set waiting

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles

2021-03-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516

--- Comment #291 from Aleisha Amohia  ---
Created attachment 118285
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118285=edit
Bug 15516: (follow-up) Add hold group message to holds queue

A hold that is part of a hold group will be indicated as such in the
holds queue.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles

2021-03-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #117426|0   |1
is obsolete||

--- Comment #290 from Aleisha Amohia  ---
Created attachment 118284
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118284=edit
Bug 15516: Schema updates

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles

2021-03-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #117425|0   |1
is obsolete||

--- Comment #289 from Aleisha Amohia  ---
Created attachment 118283
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118283=edit
Bug 15516: Allow to reserve first available item from a group of titles

It can be useful, for instance, if a library has the same title from
different publishers (so 1 title but several biblio records) but the
user only wants a copy of the book, regardless of the publisher.

This feature only applies to the staff client.

Test plan:
0. Run updatedatabase.pl and misc/devel/update_dbix_class_files.pl
1. Go to intranet search, display some results, click on some checkboxes
and click on 'Place hold' button at the top of the results.
2. Search for a patron
3. Check the 'Treat as hold group' checkbox
4. Click on 'Place hold'
5. In the next screen you should see all the holds you placed with the
additional text '(part of a hold group)' in Details column.
6. Click on the "hold group" link. A modal window should appear with
the content of the hold group (a list of holds)
7. Check in an item of one of the reserved biblios and confirm the hold
8. The hold status is changed to Waiting, and all other holds are deleted.
Note: the "hold group" link is displayed in the following pages:
- reserve/request.pl
- circ/circulation.pl
- members/moremember.pl
- circ/pendingreserves.pl
Note: A hold group is counted as only one hold

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles

2021-03-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #117424|0   |1
is obsolete||

--- Comment #288 from Aleisha Amohia  ---
Created attachment 118282
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118282=edit
Bug 15516: Relevant controller changes and tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles

2021-03-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #117423|0   |1
is obsolete||

--- Comment #287 from Aleisha Amohia  ---
Created attachment 118281
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118281=edit
Bug 15516: Database and installer updates

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2021-03-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #116134|0   |1
is obsolete||

--- Comment #714 from Aleisha Amohia  ---
Created attachment 118280
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118280=edit
Bug 19532: (follow-up) Remove bad merge conflict markers

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2021-03-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #116133|0   |1
is obsolete||

--- Comment #713 from Aleisha Amohia  ---
Created attachment 118279
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118279=edit
Bug 19532: (follow-up) Fixing tests and QA tools

And making reverted ajax message clearer

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2021-03-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #116132|0   |1
is obsolete||

--- Comment #712 from Aleisha Amohia  ---
Created attachment 118278
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118278=edit
Bug 19532: (follow-up) Fix undef recall_id preventing fulfillment of recall

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2021-03-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #116131|0   |1
is obsolete||

--- Comment #711 from Aleisha Amohia  ---
Created attachment 118277
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118277=edit
Bug 19532: (follow-up) Fixing OPAC display and staff client errors

- fixes the displays of opac-recalls.pl and opac-recall.pl
- fix the error on Recalls to pull page
- fix JS error preventing Recalled link from showing in checkouts table
- fix cancelling of recall when checking out item

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2021-03-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #116130|0   |1
is obsolete||

--- Comment #710 from Aleisha Amohia  ---
Created attachment 118276
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118276=edit
Bug 19532: (follow-up) Fixing failing CalcFine.t test

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2021-03-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #116129|0   |1
is obsolete||

--- Comment #709 from Aleisha Amohia  ---
Created attachment 118275
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118275=edit
Bug 19532: (follow-up) aria-hidden attr on OPAC, and more

- removing authnotrequired flag from scripts
- fixing opac buttons
- chmod +x for recalls test files

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2021-03-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #116128|0   |1
is obsolete||

--- Comment #708 from Aleisha Amohia  ---
Created attachment 118274
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118274=edit
Bug 19532: Recalls on intranet

See recalls on Intranet
- old recalls (all inactive recalls)
- recalls queue (all active recalls) - cancel, expire, revert waiting status,
multiple cancel, mark overdue
- recalls to pull (available but not yet waiting) - cancel
- recalls awaiting pickup (awaiting pickup, awaiting pickup more than
RecallMaxPickUpDelay days) - expire, revert waiting status
- overdue recalls (overdue to be returned) - cancel, multiple cancel
- biblio recalls tab (all active recalls relevant to this bib) - cancel,
expire, revert waiting status, mark overdue
- patron recalls tab (all active recalls relevant to this patron) - cancel,
expire, revert waiting status, mark overdue
- patron recalls history tab (all recalls relevant to this patron) - cancel,
expire, revert waiting status, mark overdue
- log viewer

and the general circulation of recalls

== TEST PLAN FOR RECALLS ==

ADMINISTRATION

1. Apply all patches
2. Run database updates, update schema files and confirm everything applies
cleanly
3. Run tests and confirm everything passes:
t/db_dependent/Koha/Recall.t
t/db_dependent/Koha/Recalls.t
t/db_dependent/Stats.t
t/db_dependent/Circulation/CalcFine.t
t/db_dependent/Koha/Item.t
t/db_dependent/Koha/Biblio.t
t/db_dependent/Koha/Patron.t
t/db_dependent/XSLT.t
t/db_dependent/Search.t
t/db_dependent/Holds.t
t/db_dependent/Circulation/transferbook.t
t/db_dependent/Circulation.t

4. Go to Administration -> system preferences. Find the UseRecalls system
preference. It should be DISABLED. Confirm RecallsMaxPickUpDelay is set to 7 by
default.
5. Go to Administration -> circulation rules. Confirm there are no recalls
circulation rules showing.
6. Test a few circulation flows: checking out, placing a reserve, checking in,
fulfilling a reserve, etc. Confirm everything works as normal.

7. Go to Administration -> system preferences. Enable the UseRecalls system
preference.
8. Go to Administration -> circulation rules. Set the following rules:
Recalls allowed (count) = 0
Recalls per record (count) = 0
On shelf recalls allowed ( If any unavailable / If all unavailable ) = If any
unavailable
Recall due date interval (days) = 3
Recall overdue fine amount = (something different to your normal fine amount)
Recall pickup period (days) = 1

Throughout your testing, try with different combinations of these rules and
itemtype / branchcode / categorycode. Also try with null values. Keep the
circulation rules open in another tab so you can refer to and update these
easily. You should also have at least one other tab open for the staff client,
and a third tab open for the OPAC, for ease of testing.

9. Go to your account -> More -> Set permissions. Confirm the recalls
permission is checked.
10. Set up a test user with OPAC login details (Borrower A). This could also be
your own user, as long as you have OPAC login access.
11. Set up a test record (Biblio A) with at least two items (Item A and Item B)
of the same item type (or an item type with the same recall circ rules).

PLACING A RECALL

12. Log in to the OPAC as Borrower A. Do a catalogue search with a term that
will return multiple results, including Biblio A.
13. Click on Biblio A.
14. Notice there is a 'Place recall' button on the sidebar menu. Click this
button. There will be a message saying that there are no items to recall - this
is because all items are available.

15. Check out Item A to another borrower (Borrower B).
16. Refresh the 'Place recall' page. You will still NOT be able to place a
recall - this is because Recalls allowed = 0 and Recalls per record = 0.

17. Edit the circulation rules to have the following values:
Recalls allowed (count) = 1
Recalls per record (count) = 1
18. Refresh the 'Place recall' page. You will now see the form to place a
recall.

BIBLIO-LEVEL RECALL, NO TRANSFER

19. Place a biblio-level recall.
Pickup location: Branch A, the set branch when you are logged into the staff
client
Recall not needed after (expiration date): whatever you want
Select 'recall next available item'
Click confirm
20. Confirm the recall is placed successfully. Confirm that the new due date
displayed is correctly calculated to be today's date, plus 3 days (taken from
the 'recall due date interval' circ rule)
21. In the staff client, look at Borrower B's account, and go to their Notices
tab. Confirm they have received a 'Notification to return recalled item'
notice.
22. Look at Borrower B's checkouts table. Notice the due date for their
checkout has been adjusted, and there is now a note 

[Koha-bugs] [Bug 19532] Recalls for Koha

2021-03-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #116127|0   |1
is obsolete||

--- Comment #707 from Aleisha Amohia  ---
Created attachment 118273
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118273=edit
Bug 19532: Recalls on OPAC

- place a biblio-level or item-level recall via the biblio detail page, OPAC
search results, or course reserves
- view or cancel your active recalls from 'your summary' recalls tab
- view all active and inactive (and cancel active) recalls from 'your recall
history'
- stopped from placing a reserve on an item that the patron has already
recalled

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2021-03-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #116126|0   |1
is obsolete||

--- Comment #706 from Aleisha Amohia  ---
Created attachment 118272
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118272=edit
Bug 19532: Other objects used in recalls feature

- biblio->recalls
- biblio->can_be_recalled
- item->recall
- item->can_be_recalled
- item->can_set_waiting_recall
- item->check_recalls
- patron->recalls
- Biblio.RecallsCount

and relevant tests
- t/db_dependent/Stats.t
- t/db_dependent/Koha/Item.t
- t/db_dependent/Koha/Biblio.t
- t/db_dependent/Koha/Patron.t
- t/db_dependent/XSLT.t
- t/db_dependent/Search.t
- t/db_dependent/Holds.t
- t/db_dependent/Circulation/transferbook.t
- t/db_dependent/Circulation.t

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2021-03-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #116125|0   |1
is obsolete||

--- Comment #705 from Aleisha Amohia  ---
Created attachment 118271
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118271=edit
Bug 19532: Expiry and overdue cronjobs, and overdue fine calculation

- misc/cronjobs/recalls/expire_recalls.pl
- misc/cronjobs/recalls/overdue_recalls.pl
- tests for overdue fines in t/db_dependent/Circulation/CalcFine.t

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2021-03-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #116124|0   |1
is obsolete||

--- Comment #704 from Aleisha Amohia  ---
Created attachment 118270
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118270=edit
Bug 19532: Recalls objects and tests

Koha/Recall.pm
- biblio
- item
- patron
- library
- checkout
- requested
- waiting
- overdue
- in_transit
- expired
- cancelled
- finished
- calc_expirationdate
- start_transfer
- revert_transfer
- set_waiting
- revert_waiting
- set_overdue
- set_expired
- set_cancelled
- set_finished
- should_be_overdue

Koha/Recalls.pm
- add_recall
- move_recall

and relevant tests

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2021-03-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #116123|0   |1
is obsolete||

--- Comment #703 from Aleisha Amohia  ---
Created attachment 118269
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118269=edit
Bug 19532: Add boolean flags to recalls.old and recalls.item_level_recall

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2021-03-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #116122|0   |1
is obsolete||

--- Comment #702 from Aleisha Amohia  ---
Created attachment 118268
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118268=edit
Bug 19532: Updated schema files

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2021-03-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #116121|0   |1
is obsolete||

--- Comment #701 from Aleisha Amohia  ---
Created attachment 118267
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118267=edit
Bug 19532: Database and installer stuff

- Add recalls table
- Add recalls circulation rules - recalls allowed, recalls per record, on shelf
recalls, recall due date interval, recall overdue fine, recall shelf time
- Add system preferences - useRecalls, RecallsMaxPickUpDelay, RecallsLog
- Add email notices (RETURN_RECALLED_ITEM, PICKUP_RECALLED_ITEM)
- Add print notice (RECALL_REQUESTER_DET)
- Add user permission - recalls, manage_recalls
- Add Recall and CancelRecall enum options for branchtransfers reason

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20844] Reset a hold when it is missing after allocation

2021-03-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20844

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #113210|0   |1
is obsolete||

--- Comment #44 from Aleisha Amohia  ---
Created attachment 118266
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118266=edit
Bug 20844: (follow-up) Get working with transfers

Test:

1) Change branch to Branch B
2) Place a biblio-level hold at Branch B
3) Change branch to Branch A
4) Check in item at Branch A and set waiting and trigger transfer
5) Go to edit item and set item as lost
6) Check borrower's notices tab and confirm the lost_waiting_hold notice
was enqueued
7) Follow test plan again with item-level hold

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20844] Reset a hold when it is missing after allocation

2021-03-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20844

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #113209|0   |1
is obsolete||

--- Comment #43 from Aleisha Amohia  ---
Created attachment 118265
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118265=edit
Bug 20844: (follow-up) SendLostHoldNotices

This patch adds a new syspref SendLostHoldNotices

Test:
1) Update database and restart memcached
2) Enable the SendLostHoldNotices system preference
3) Place a hold on an item
4) Check in the item and set the hold to waiting
5) Go to edit the item and set an item lost status
6) Check the borrower's notices and confirm the notice has been enqueued
7) Confirm the notice is not sent twice when reverting or cancelling the
hold
8) Confirm notice enqueues as expected for a bib-level hold

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20844] Reset a hold when it is missing after allocation

2021-03-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20844

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #113208|0   |1
is obsolete||

--- Comment #42 from Aleisha Amohia  ---
Created attachment 118264
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118264=edit
Bug 20844: Revert or cancel lost holds

This patch introduces the RevertLostBibLevelHolds syspref. When an item
is marked as lost, if there is a bib-level hold on it waiting, the hold
is reverted. If there is an item-level hold on it waiting, there is an
alert box asking if the library would like to revert the hold or cancel
it.

Test:

1) Update database and restart memcached/plack
2) Place a hold on Biblio A
3) Check in Item A from Biblio A and set the hold as waiting
4) Edit Item A and give it a lost status (952$1, you may need to edit
your MARC frameworks to have this visible in the Editor)
5) Look at your hold. Notice it is still waiting.
6) Go to Administration -> System preferences. Find the
RevertLostBibLevelHolds system preference and enable it.
7) Cancel your hold and remove Item A's lost status. Place another biblio-level
hold on the same biblio
8) Check in Item A from Biblio A and set the hold as waiting
9) Go to the Items tab for Biblio A (catalogue/moredetail.pl)
10) Edit Item A and give it a lost status
11) Once the page reloads, go to view your hold. It should no longer be
waiting and have no item allocated.
12) Cancel your hold and remove Item A's lost status. Place an item-level hold
on Item A
13) Check in Item A and set the hold as waiting
14) Go to the catalogue detail page for Biblio A (catalogue/detail.pl) and
click
'Edit' for Item A (end up on cataloguing/additem.pl)
15) Give Item A a lost status and save changes
16) Once the page reloads, confirm there is an alert box asking you to
revert or cancel the hold. Click Revert
17) Confirm your hold is no longer waiting, but the item is still
allocated
18) Remove Item A's lost status
19) Check in Item A and set the hold as waiting
20) Go to the catalogue detail page for Biblio A (catalogue/detail.pl) and
click
'Edit' for Item A (end up on cataloguing/additem.pl)
21) Give Item A a lost status and save changes
22) Once the page reloads, confirm there is an alert box asking you to
revert or cancel the hold. Click Cancel
23) Confirm the hold is now cancelled
24) Remove Item A's lost status
25) Place an item-level hold on Item A
26) Check in Item A and set the hold as waiting
27) Go to the Items tab for Biblio A (catalogue/moredetail.pl)
28) Give Item A a lost status and save changes
29) Once the page reloads, confirm there is an alert box asking you to
revert or cancel the hold. Click Revert
30) Confirm your hold is no longer waiting, but the item is still
allocated
31) Remove Item A's lost status
32) Check in Item A and set the hold as waiting
33) Go to the Items tab for Biblio A (catalogue/moredetail.pl)
34) Give Item A a lost status and save changes
35) Once the page reloads, confirm there is an alert box asking you to
revert or cancel the hold. Click Cancel
36) Confirm the hold is now cancelled
37) Remove Item A's lost status
38) Place an item-level hold on Item A. Check in Item A and set the hold
as waiting
39) Place an item-level hold on Item B (same biblio) for another borrower.
Check in
Item B and set the hold as waiting.
40) Give both Items A and B lost statuses.
41) Confirm that both Items are included in the alert box on page when
editing items (cataloguing/additem.pl)
42) Confirm that both Items have individual alert boxes on the Items tab
(catalogue/moredetail.pl)
43) Confirm tests pass t/db_dependent/Reserves.t

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20844] Reset a hold when it is missing after allocation

2021-03-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20844

Aleisha Amohia  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24194] Add system preference to disable the use of expiration dates for holds

2021-03-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194

--- Comment #45 from Aleisha Amohia  ---
Created attachment 118263
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118263=edit
Bug 24194: (follow-up) Use ReservesExpiration in other places

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24194] Add system preference to disable the use of expiration dates for holds

2021-03-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #117101|0   |1
is obsolete||

--- Comment #44 from Aleisha Amohia  ---
Created attachment 118262
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118262=edit
Bug 24194: (follow-up) Link references to new preference

As was done in Bug 27263, references to one system preference in another
system preference's description should be a link back to the mentioned
preference.

To test, apply the patch go to Administration -> Global system
preferences.

- Search for "ReserveExpiration."
- Besides the preference itself, you should get four other preferences
  which have mentions of "ReserveExpiration" in their descriptions.
- Confirm that each mention in the description is a link to a search for
  "ReserveExpiration."

Signed-off-by: David Nind 

https://bugs.koha-community.org/show_bug.cgi?id=24914

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24194] Add system preference to disable the use of expiration dates for holds

2021-03-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #117100|0   |1
is obsolete||

--- Comment #43 from Aleisha Amohia  ---
Created attachment 118261
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118261=edit
Bug 24194: (follow-up) Correct some missing instances

This patch fixes some instances where hold expiration dates are set or
referenced.

To test, apply the patch and test the following pages with the
ReserveExpiration preference both on and off to confirm that expiration
dates are shown or hidden correctly.

Pages in the staff interface:

- Check out to a patron and check the holds tab
- View patron details and check the holds tab
- Patron hold history
- Patron details -> Print -> Print summary
- Place a hold on a title which already has at least one hold on it,
  check the table of existing holds.

Pages in the OPAC:

- Log in to the OPAC as a patron with holds
  - Your summary -> Holds tab
  - Your holds history (OPACHoldsHistory must be enabled).

Signed-off-by: David Nind 

https://bugs.koha-community.org/show_bug.cgi?id=24914

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24194] Add system preference to disable the use of expiration dates for holds

2021-03-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #117099|0   |1
is obsolete||

--- Comment #42 from Aleisha Amohia  ---
Created attachment 118260
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118260=edit
Bug 24194: (follow-up) Renaming syspref to ReserveExpiration

Signed-off-by: David Nind 

https://bugs.koha-community.org/show_bug.cgi?id=24914

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24194] Add system preference to disable the use of expiration dates for holds

2021-03-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #117098|0   |1
is obsolete||

--- Comment #41 from Aleisha Amohia  ---
Created attachment 118259
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118259=edit
Bug 24914: (follow-up) Clarifying sysprefs, hiding columns, and more

- change syspref description to say 'holds' instead of reserves
- clarify descriptions of related sysprefs
- hide expiration column on reserves page
- move syspref to 'hold policy' section
- fix cancel_expired_holds.pl cron to consider syspref
- set expirationdate to undef always

https://bugs.koha-community.org/show_bug.cgi?id=24194

Signed-off-by: David Nind 

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24194] Add system preference to disable the use of expiration dates for holds

2021-03-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #117097|0   |1
is obsolete||

--- Comment #40 from Aleisha Amohia  ---
Created attachment 118258
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118258=edit
Bug 24194: Add DisableReserveExpiration system preference to hide expiration
date options for reserves

To test:
1) Update database
2) Go to place a hold on any biblio in the staff intranet and confirm
you can see the 'Hold expires on date' field.
3) In another tab, go to place a hold on any biblio in the OPAC and
confirm you can see the 'Hold not needed after' field as an option.
4) In yet another tab, open the staff intranet and place a reserve for a user.
Check it in and set the reserve as
waiting. Notice that an expiration date has now been generated for this
reserve.
5) Attempt to check out the item you reserved to some other borrower.
Revert waiting status. Notice that the expiration date that was
generated remains.
6) Go to Administration -> system preferences and set DisableReserveExpiration
system preference to 'Disable'
7) Refresh the hold request page in the intranet. Confirm the expiration
date field disappears.
8) Refresh the hold request page in the OPAC. Confirm the expiration
date field disappears.
9) Place another reserve. Check it in and set the reserve as waiting.
Notice that no expiration date was generated for this reserve.
10) Attempt to check out the item you reserved to some other borrower.
Revert waiting status. The expiration date should remain null.
11) Confirm tests pass
t/db_dependent/Hold.t
t/db_dependent/Reserves.t

Sponsored-by: Horowhenua Library Trust

Signed-off-by: David Nind 

Signed-off-by: David Nind 

Signed-off-by: David Nind 

https://bugs.koha-community.org/show_bug.cgi?id=24914

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24194] Add system preference to disable the use of expiration dates for holds

2021-03-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194

Aleisha Amohia  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24194] Add system preference to disable the use of expiration dates for holds

2021-03-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194

--- Comment #39 from Aleisha Amohia  ---
(In reply to Joonas Kylmälä from comment #36)
> ReserveExpiration should be moved out of set_waiting() method because it
> makes using set_waiting method really confusing because you are really
> expecting it to only set the waiting status and not do much more,
> documentation and testing of the function becomes also more difficult. 

I'm not sure I understand what you mean here, expiration date logic is already
in the set_waiting method before my patch. I think moving that logic out is
beyond the scope of this work. 

> The best way to do this would be to block adding expiration date already when
> creating a new hold. So please add the necessary code to OPAC, Staff and
> REST. For OPAC and Staff I see there is already some code, REST is missing
> completely. 

What code is missing for OPAC and staff? I will add it to REST in a follow-up.

> Also if I'm not mistaken the reason you added ReserveExpiration
> to set_waiting() is because of ReservesMaxPickUpDelay not working really
> well – what you could do here is do a DB upgrade so that
> ReservesMaxPickUpDelay value '' => 0 so then when ReservesMaxPickUpDelay is
> not an integer value it would simply not add expiration date.

I added it to set_waiting because the code already exists there - when we set a
hold as waiting it may have a specified shelf time for awaiting pickup.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26533] Searching authorities using 'is exactly' doesn't work as expected

2021-03-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26533

David Cook  changed:

   What|Removed |Added

 Attachment #118255|0   |1
is obsolete||

--- Comment #12 from David Cook  ---
Created attachment 118257
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118257=edit
Bug 26533: Fix 'is exactly' search for authorities

The exact search 6=3 is implemented, but it isn't used as expected when
you select 'is exactly' from the authorities search dropdown. This patch
remedies that.

To test:
1) Ensure you have an authority with more than one word in the name,
i.e. Electric power production
2) Go to Authorities in the staff client.
3) Change the dropdown to 'is exactly' and search for one of the words
in your record's title, i.e. 'power' in the 'main heading' search
4) Confirm your authority shows in the results, even though it is not an
exact match.
5) Search for a biblio record and go to edit the record.
6) Go to Tab 6 and click the plugin button next to one of the 6xx$a
fields to trigger the authority finder plugin
7) Repeat Step 3 and Step 4
8) Go to the OPAC and go to Authority Search
9) Repeat Step 3 and Step 4

Apply patch

10) Repeat Steps 1 to 9, confirm that this time the record does NOT show
in search results.
11) Repeat Steps 1 to 9 but this time search for the authority record's
full title, i.e. 'Electric power production'. Confirm the record does
show in the search results because the search term now matches title exactly.

Sponsored-by: Education Services Australia SCIS

Signed-off-by: David Cook 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26533] Searching authorities using 'is exactly' doesn't work as expected

2021-03-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26533

David Cook  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26533] Searching authorities using 'is exactly' doesn't work as expected

2021-03-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26533

--- Comment #11 from David Cook  ---
My test plan:

0) Start koha-testing-docker
1) Determine "Advanced language series." as suitable authority for testing
2) Go to Authorities in staff client
3) Change dropdown to "is exactly" and search "language"
4) Confirm "Advanced language series." is the first hit
5) Go to
http://localhost:8081/cgi-bin/koha/cataloguing/addbiblio.pl?biblionumber=37
6) Go to field 830 and click the Tag Editor
7) Repeat steps 3 and 4
8) Go to http://localhost:8080/cgi-bin/koha/opac-authorities-home.pl
9) Repeat steps 3 and 4

Apply patch and run koha-plack --restart kohadev

10) Repeat steps 1-9 but confirm that this time the record does not show in the
search results
11) Repeat steps 1-9 but this time search for Advanced language series.

--

Note that I did get 2 hits for step 10 for the OPAC's Authority search, because
it's searching through the whole record and there are some general subdivisions
that are exactly Language.

A bit unexpected but reasonable.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26533] Searching authorities using 'is exactly' doesn't work as expected

2021-03-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26533

--- Comment #10 from David Cook  ---
(In reply to David Cook from comment #9)
>
> I wonder if we should actually get rid of the 'is' operator all together.
> Not that you'd need to do that now, but I figure if we have eyes on it now
> it might be good to think about.

Grepping around for 'is' and I see C4/Heading.pm, C4/AuthoritiesMarc.pm,
cataloguing/value_builder/unimarc_field_225a.pl,
Koha/SearchEngine/Elasticsearch/QueryBuilder.pm,
t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t...

Grepping for "is" finds the following:
koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_210c.tt
koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_686a.tt
koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_686a.tt
koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_686a.tt

So we can't get rid of 'is' as it looks like those UNIMARC plugins are using it
at least

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26533] Searching authorities using 'is exactly' doesn't work as expected

2021-03-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26533

--- Comment #9 from David Cook  ---
(In reply to Aleisha Amohia from comment #8)
> > Regarding Bug 27299, it has been in master for a little while, so probably
> > not relevant here.
> 
> We had the patch from Bug 27299 applied and it didn't seem to solve the
> problem for us
> 

Yeah it wouldn't help with 'is' but would help with 'exact'.

> > 
> > I'm looking at C4::AuthoritiesMarc and I'm loving how the comments for 'is'
> > and 'exactly' are the same, but clearly they're not the same, since 'is'
> > uses the 'w' register and 'exactly' uses the 'p' register.
> 
> Yes a little strange! Hopefully this switch to using the 'exact' operator
> means we're doing the right search now.

Yeah, I think your patch is good. I'll spin up a KTD to test it in a minute. I
should be doing other things but search issues always tickle me. 

I wonder if we should actually get rid of the 'is' operator all together. Not
that you'd need to do that now, but I figure if we have eyes on it now it might
be good to think about.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26533] Searching authorities using 'is exactly' doesn't work as expected

2021-03-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26533

--- Comment #8 from Aleisha Amohia  ---
(In reply to David Cook from comment #7)
> (In reply to Aleisha Amohia from comment #6)
> > (In reply to David Cook from comment #4)
> > > Aleisha, is this using ICU or CHR?
> > > 
> > > I know Katrin and I were talking about this sort of things recently.
> > 
> > This is using ICU
> 
> That would be good to include in the test plan, although I think the problem
> probably exists for both CHR and ICU.

Yes I am pretty sure it does

> 
> Regarding Bug 27299, it has been in master for a little while, so probably
> not relevant here.

We had the patch from Bug 27299 applied and it didn't seem to solve the problem
for us

> 
> I'm looking at C4::AuthoritiesMarc and I'm loving how the comments for 'is'
> and 'exactly' are the same, but clearly they're not the same, since 'is'
> uses the 'w' register and 'exactly' uses the 'p' register.

Yes a little strange! Hopefully this switch to using the 'exact' operator means
we're doing the right search now.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26533] Searching authorities using 'is exactly' doesn't work as expected

2021-03-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26533

--- Comment #7 from David Cook  ---
(In reply to Aleisha Amohia from comment #6)
> (In reply to David Cook from comment #4)
> > Aleisha, is this using ICU or CHR?
> > 
> > I know Katrin and I were talking about this sort of things recently.
> 
> This is using ICU

That would be good to include in the test plan, although I think the problem
probably exists for both CHR and ICU.

Regarding Bug 27299, it has been in master for a little while, so probably not
relevant here.

I'm looking at C4::AuthoritiesMarc and I'm loving how the comments for 'is' and
'exactly' are the same, but clearly they're not the same, since 'is' uses the
'w' register and 'exactly' uses the 'p' register.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26533] Searching authorities using 'is exactly' doesn't work as expected

2021-03-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26533

--- Comment #6 from Aleisha Amohia  ---
(In reply to David Cook from comment #4)
> Aleisha, is this using ICU or CHR?
> 
> I know Katrin and I were talking about this sort of things recently.

This is using ICU

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26533] Searching authorities using 'is exactly' doesn't work as expected

2021-03-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26533

--- Comment #5 from David Cook  ---
Bug 27299 for ICU but if it's CHR then nevermind.

I'll make a note to come back to this too..

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26533] Searching authorities using 'is exactly' doesn't work as expected

2021-03-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26533

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

--- Comment #4 from David Cook  ---
Aleisha, is this using ICU or CHR?

I know Katrin and I were talking about this sort of things recently.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27961] External track clicks links should get uri filtered

2021-03-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27961

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

--- Comment #2 from David Cook  ---
I feel like I've had an issue related to this but don't have the time to look
at it right now...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27961] External track clicks links should get uri filtered

2021-03-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27961

--- Comment #1 from Aleisha Amohia  ---
Created attachment 118256
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118256=edit
Bug 27961: Ensure external URLs are filtered

TT variables are used to build the link in items.uri . This is a problem
particularly when TrackClicks is enabled because the items.uri value
doesn't get escaped, resulting in a 404.

To test:
1) Enable the TrackClicks system preference (set to Track or Track
anonymously)
2) Find a record with an item
3) Edit the item and put an external URL under the Uniform Resource
Identifier field
4) Go to that record in the OPAC
5) Click on Link to resource
6) Confirm you are not redirected to the URL and instead see a 404
7) Apply the patch and refresh the page
8) Click on Link to resource
9) Confirm you are redirected as expected
10) Go back to the staff client to edit your item. This time put two
URLs in the Uniform Resource Identifier field, separated by ' | '.
(Don't forget the spaces around the pipe, and don't forget to add a
 trailing slash to the URL).
11) Go back to the OPAC and refresh the page.
12) Confirm both URLs redirect as expected.

Sponsored-by: Parliamentary Library New Zealand

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27961] External track clicks links should get uri filtered

2021-03-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27961

Aleisha Amohia  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27961] New: External track clicks links should get uri filtered

2021-03-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27961

Bug ID: 27961
   Summary: External track clicks links should get uri filtered
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: alei...@catalyst.net.nz
QA Contact: testo...@bugs.koha-community.org

TT variables are used to build the link in items.uri . This is a problem
particularly when TrackClicks is enabled because the items.uri value doesn't
get escaped, resulting in a 404

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26533] Searching authorities using 'is exactly' doesn't work as expected

2021-03-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26533

Aleisha Amohia  changed:

   What|Removed |Added

  Change sponsored?|--- |Sponsored

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26533] Searching authorities using 'is exactly' doesn't work as expected

2021-03-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26533

--- Comment #3 from Aleisha Amohia  ---
Created attachment 118255
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118255=edit
Bug 26533: Fix 'is exactly' search for authorities

The exact search 6=3 is implemented, but it isn't used as expected when
you select 'is exactly' from the authorities search dropdown. This patch
remedies that.

To test:
1) Ensure you have an authority with more than one word in the name,
i.e. Electric power production
2) Go to Authorities in the staff client.
3) Change the dropdown to 'is exactly' and search for one of the words
in your record's title, i.e. 'power' in the 'main heading' search
4) Confirm your authority shows in the results, even though it is not an
exact match.
5) Search for a biblio record and go to edit the record.
6) Go to Tab 6 and click the plugin button next to one of the 6xx$a
fields to trigger the authority finder plugin
7) Repeat Step 3 and Step 4
8) Go to the OPAC and go to Authority Search
9) Repeat Step 3 and Step 4

Apply patch

10) Repeat Steps 1 to 9, confirm that this time the record does NOT show
in search results.
11) Repeat Steps 1 to 9 but this time search for the authority record's
full title, i.e. 'Electric power production'. Confirm the record does
show in the search results because the search term now matches title exactly.

Sponsored-by: Education Services Australia SCIS

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26533] Searching authorities using 'is exactly' doesn't work as expected

2021-03-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26533

Aleisha Amohia  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27069] Change holdallowed values from numbers to strings

2021-03-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27069

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||agustinmoy...@theke.io,
   ||k...@bywatersolutions.com,
   ||martin.renvoize@ptfs-europe
   ||.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27960] New: Adding guarantee from parent record allows choosing invalid card type

2021-03-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27960

Bug ID: 27960
   Summary: Adding guarantee from parent record allows choosing
invalid card type
 Change sponsored?: ---
   Product: Koha
   Version: 20.05
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Patrons
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: bwsdo...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

Koha does not currently permit two ADULT type patron categories to be linked as
guarantor/guarantee.  However, if a user selects the "Add Guarantee" button
from an adult card, they are able to change the guarantee's card type to
another ADULT type account and save, creating the guarantor/guarantee link. 
This should not be permitted.  

Bug 12446 would appropriately allow these connections.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27934] Table sorting using title-string option is obsolete

2021-03-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27934

Owen Leonard  changed:

   What|Removed |Added

Summary|Using 'title' attributes on |Table sorting using
   |span fields for sorting is  |title-string option is
   |wrong   |obsolete

--- Comment #8 from Owen Leonard  ---
I agree that we should update the templates to use the newer sorting option.
I've updated the bug title to make it clear that it's about an obsolete option.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27827] Authority type input field for new authority types should be wider

2021-03-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27827

--- Comment #4 from Owen Leonard  ---
Testing with Firefox on macOS I see exactly what is in the screeshot. I think
it's a problem especially when using all capital letters. I'm inclined to go
with the proposed solution. I think the confusion about the max length could be
mitigated by a hint: 10 characters maximum

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27069] Change holdallowed values from numbers to strings

2021-03-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27069

--- Comment #4 from Tomás Cohen Arazi  ---
Created attachment 118254
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118254=edit
Bug 27069: Update existing rules

This patch adds an atomic update file that takes care of translating
existing rules. It constrains the rules to translate to those currently
expected by Koha and leaves any other value out.

To test:
1. Have some manually added rules:
   $ koha-mysql kohadev
   > INSERT INTO circulation_rules (rule_name,rule_value) VALUES
   ('holdallowed', -1);
   > INSERT INTO circulation_rules (rule_name,rule_value) VALUES
   ('holdallowed', 1);
   > INSERT INTO circulation_rules (rule_name,rule_value) VALUES
   ('holdallowed', 2);
   > INSERT INTO circulation_rules (rule_name,rule_value) VALUES
   ('holdallowed', 3);
   > INSERT INTO circulation_rules (rule_name,rule_value) VALUES
   ('holdallowed', 0);
   > INSERT INTO circulation_rules (rule_name,rule_value) VALUES
   ('holdallowed', 4);
2. Apply this patch
3. Run:
   $ updatedatabase
=> SUCCESS: It doesn't explode
4. Verify the created rules were updated correctly:
   > SELECT * FROM circulation_rules WHERE rule_name='holdallowed';
5: Verify all the tests that dealt with this rule still pass!
   $ kshell
  k$ git diff origin/master --name-only | grep -e '\.t$' | \
 xargs prove
=> SUCCESS: Tests pass!
6. Verify the UI handles setting things correctly
7. Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27069] Change holdallowed values from numbers to strings

2021-03-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27069

--- Comment #3 from Tomás Cohen Arazi  ---
Created attachment 118253
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118253=edit
Bug 27069: Adapt uses of holdallowed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27069] Change holdallowed values from numbers to strings

2021-03-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27069

--- Comment #2 from Tomás Cohen Arazi  ---
Created attachment 118252
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118252=edit
Bug 27069: Adjust tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27069] Change holdallowed values from numbers to strings

2021-03-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27069

--- Comment #1 from Tomás Cohen Arazi  ---
Holds rules are complex enough to get lost fairly easily. No need to ALSO
remember what each integer means :-D

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27069] Change holdallowed values from numbers to strings

2021-03-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27069

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27069] Change holdallowed values from numbers to strings

2021-03-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27069

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com
   |ity.org |
 CC||tomasco...@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27816] "Click to edit" in Point of sale is untranslatable

2021-03-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27816

Owen Leonard  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |oleon...@myacpl.org
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27870] Add holds table at /opac-user.pl#opac-user-holds to Table Settings

2021-03-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27870

--- Comment #2 from Andrew Fuerste-Henry  ---
(In reply to Owen Leonard from comment #1)
> Is the goal to allow the user to show and hide columns or to allow the
> library to set the configuration? 

To allow the library to do so.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27870] Add holds table at /opac-user.pl#opac-user-holds to Table Settings

2021-03-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27870

--- Comment #1 from Owen Leonard  ---
Is the goal to allow the user to show and hide columns or to allow the library
to set the configuration? At the moment I don't believe we expose the column
selection option anywhere in the OPAC.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27816] "Click to edit" in Point of sale is untranslatable

2021-03-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27816

--- Comment #4 from Martin Renvoize  ---
Nice, thanks Owen, I hadn't got to working out where the magic happens for this
one yet 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27816] "Click to edit" in Point of sale is untranslatable

2021-03-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27816

--- Comment #3 from Martin Renvoize  ---
Nice, thanks Owen, I hadn't got to working out where the magic happens for this
one yet 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27816] "Click to edit" in Point of sale is untranslatable

2021-03-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27816

--- Comment #2 from Owen Leonard  ---
Created attachment 118251
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118251=edit
Bug 27816: "Click to edit" in Point of sale is untranslatable

This patch adds an option to the Point of sale jEditable configuration
to explicitly set the title attribute to "Click to edit." This will
allow the string to be picked up for translation.

To test, apply the patch and test that the correct string is
translated. In this example I'm testing fr-FR:

  - Update a translation:

> cd misc/translator
> perl translate update fr-FR

  The "Click to edit" string should already have been translated, so
  it's not necessary to update the .po file.

  - Install the updated translation:

> perl translate install fr-FR

In the staff interface, switch to the language you're testing and open
the point of sale page. Add some items for purchase. They should appear
in the "This sale" table. Hover your mouse over the values in the "Coût"
and "Quantité" columns. You should see the translated string, "Cliquer
pour modifier."

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27816] "Click to edit" in Point of sale is untranslatable

2021-03-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27816

Owen Leonard  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22160] OMNIBUS: Transfers enhancements

2021-03-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22160
Bug 22160 depends on bug 12362, which changed state.

Bug 12362 Summary: Branch transfer records orphaned on cancelled holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12362

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12362] Branch transfer records orphaned on cancelled holds

2021-03-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12362

Martin Renvoize  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

--- Comment #3 from Martin Renvoize  ---
I agree with Owen.. simply cancelling the hold shouldn't mark an in-progress
transfer as completed.. we need to perform a check-in to know where the item
actually is.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22160] OMNIBUS: Transfers enhancements

2021-03-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22160
Bug 22160 depends on bug 14170, which changed state.

Bug 14170 Summary: branchtransfers items need to be cancelled when on loan or a 
waiting reserve
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14170

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24620] Existing transfers not closed when hold is set to waiting

2021-03-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24620

Martin Renvoize  changed:

   What|Removed |Added

 CC||cbran...@cdalibrary.org

--- Comment #21 from Martin Renvoize  ---
*** Bug 14170 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14170] branchtransfers items need to be cancelled when on loan or a waiting reserve

2021-03-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14170

Martin Renvoize  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|NEW |RESOLVED

--- Comment #7 from Martin Renvoize  ---


*** This bug has been marked as a duplicate of bug 24620 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14170] branchtransfers items need to be cancelled when on loan or a waiting reserve

2021-03-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14170

Martin Renvoize  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com

--- Comment #6 from Martin Renvoize  ---
This looks to be fixed with bug 24620 to me.. can you verify Christopher? (That
bug has been pushed for 20.05.00 and 19.11.06)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20344] Transferring an item while on hold results in a transfer where the destination is the same as the source

2021-03-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20344

Martin Renvoize  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com

--- Comment #6 from Martin Renvoize  ---
Quietly wondering if all the transfers refactoring has resolved this one now?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26618] C4/RotatingCollections.pm should not use C4::Circulation::transferbook

2021-03-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26618

Martin Renvoize  changed:

   What|Removed |Added

 Blocks|4234|


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4234
[Bug 4234] Automatic transfer shouldn't take precedence over a hold transit
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25754] Deprecate C4::Items::ModItemTransfer

2021-03-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25754

Martin Renvoize  changed:

   What|Removed |Added

 Blocks|4234|


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4234
[Bug 4234] Automatic transfer shouldn't take precedence over a hold transit
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25753] Replace transferbook in circ/branchtransfers with Koha::Object method calls

2021-03-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25753

Martin Renvoize  changed:

   What|Removed |Added

 Blocks|4234|


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4234
[Bug 4234] Automatic transfer shouldn't take precedence over a hold transit
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24446] Stockrotation: Update to use daterequested in branchtransfers

2021-03-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446

Martin Renvoize  changed:

   What|Removed |Added

 Blocks|4234|


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4234
[Bug 4234] Automatic transfer shouldn't take precedence over a hold transit
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24297] Record if a transfer was triggered 'manually'

2021-03-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24297

Martin Renvoize  changed:

   What|Removed |Added

 Blocks|4234|


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4234
[Bug 4234] Automatic transfer shouldn't take precedence over a hold transit
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22161] Move C4::Circulation::transferbook and C4::Items::ModItemTransfer to Koha namespace

2021-03-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22161

Martin Renvoize  changed:

   What|Removed |Added

 Blocks||4234


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4234
[Bug 4234] Automatic transfer shouldn't take precedence over a hold transit
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 4234] Automatic transfer shouldn't take precedence over a hold transit

2021-03-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4234

Martin Renvoize  changed:

   What|Removed |Added

 Depends on|24446, 25753, 25754, 26618, |22161
   |24297   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22161
[Bug 22161] Move C4::Circulation::transferbook and C4::Items::ModItemTransfer
to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24297
[Bug 24297] Record if a transfer was triggered 'manually'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446
[Bug 24446] Stockrotation: Update to use daterequested in branchtransfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25753
[Bug 25753] Replace transferbook in circ/branchtransfers with Koha::Object
method calls
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25754
[Bug 25754] Deprecate C4::Items::ModItemTransfer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26618
[Bug 26618] C4/RotatingCollections.pm should not use
C4::Circulation::transferbook
-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25754] Deprecate C4::Items::ModItemTransfer

2021-03-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25754

Martin Renvoize  changed:

   What|Removed |Added

 Blocks||4234


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4234
[Bug 4234] Automatic transfer shouldn't take precedence over a hold transit
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 4234] Automatic transfer shouldn't take precedence over a hold transit

2021-03-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4234

Martin Renvoize  changed:

   What|Removed |Added

 Depends on||25754


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25754
[Bug 25754] Deprecate C4::Items::ModItemTransfer
-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25753] Replace transferbook in circ/branchtransfers with Koha::Object method calls

2021-03-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25753

Martin Renvoize  changed:

   What|Removed |Added

 Blocks||4234


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4234
[Bug 4234] Automatic transfer shouldn't take precedence over a hold transit
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 4234] Automatic transfer shouldn't take precedence over a hold transit

2021-03-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4234

Martin Renvoize  changed:

   What|Removed |Added

 Depends on||25753


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25753
[Bug 25753] Replace transferbook in circ/branchtransfers with Koha::Object
method calls
-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26618] C4/RotatingCollections.pm should not use C4::Circulation::transferbook

2021-03-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26618

Martin Renvoize  changed:

   What|Removed |Added

 Blocks||4234


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4234
[Bug 4234] Automatic transfer shouldn't take precedence over a hold transit
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 4234] Automatic transfer shouldn't take precedence over a hold transit

2021-03-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4234

Martin Renvoize  changed:

   What|Removed |Added

 Depends on||26618


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26618
[Bug 26618] C4/RotatingCollections.pm should not use
C4::Circulation::transferbook
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead

2021-03-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295

Martin Renvoize  changed:

   What|Removed |Added

 Depends on|27281   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27281
[Bug 27281] Replace call to `C4::Circulation::DeleteTransfer` with
`Koha::Item::Transfer->cancel({ comment => $comment })` in
`C4::Circulation::LostItem`
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27281] Replace call to `C4::Circulation::DeleteTransfer` with `Koha::Item::Transfer->cancel({ comment => $comment })` in `C4::Circulation::LostItem`

2021-03-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27281

Martin Renvoize  changed:

   What|Removed |Added

 Blocks|24295   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295
[Bug 24295] C4::Circulation::GetTransfers should be removed, use
Koha::Item->get_transfer instead
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead

2021-03-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295

Martin Renvoize  changed:

   What|Removed |Added

 Depends on||27896


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27896
[Bug 27896] Remove C4::Circulation::DeleteTransfer
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22160] OMNIBUS: Transfers enhancements

2021-03-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22160

Martin Renvoize  changed:

   What|Removed |Added

 Depends on|27896   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27896
[Bug 27896] Remove C4::Circulation::DeleteTransfer
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27896] Remove C4::Circulation::DeleteTransfer

2021-03-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27896

Martin Renvoize  changed:

   What|Removed |Added

 Blocks|22160   |24295


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22160
[Bug 22160] OMNIBUS: Transfers enhancements
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295
[Bug 24295] C4::Circulation::GetTransfers should be removed, use
Koha::Item->get_transfer instead
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead

2021-03-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295

Martin Renvoize  changed:

   What|Removed |Added

 Blocks|4234|


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4234
[Bug 4234] Automatic transfer shouldn't take precedence over a hold transit
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 4234] Automatic transfer shouldn't take precedence over a hold transit

2021-03-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4234

Martin Renvoize  changed:

   What|Removed |Added

 Depends on|24295   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295
[Bug 24295] C4::Circulation::GetTransfers should be removed, use
Koha::Item->get_transfer instead
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27281] Replace call to `C4::Circulation::DeleteTransfer` with `Koha::Item::Transfer->cancel({ comment => $comment })` in `C4::Circulation::LostItem`

2021-03-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27281

Martin Renvoize  changed:

   What|Removed |Added

 Blocks||24295


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295
[Bug 24295] C4::Circulation::GetTransfers should be removed, use
Koha::Item->get_transfer instead
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead

2021-03-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295

Martin Renvoize  changed:

   What|Removed |Added

 Depends on||27281


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27281
[Bug 27281] Replace call to `C4::Circulation::DeleteTransfer` with
`Koha::Item::Transfer->cancel({ comment => $comment })` in
`C4::Circulation::LostItem`
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead

2021-03-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295

--- Comment #9 from Martin Renvoize  ---
Created attachment 118250
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118250=edit
Bug 24295: Replace mock in t/db_dependent/Circulation/transferbook.t

Replace the call to GetTransfers with the get_transfer method in
Koha::Item in transferbook.t

Test plan
1/ Run t/db_dependent/Circulation/transferbook.t
2/ Confirm it passes
3/ Apply patch
4/ Repeat steps 1-2

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead

2021-03-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295

--- Comment #8 from Martin Renvoize  ---
Created attachment 118249
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118249=edit
Bug 24295: Replace mock in t/db_dependent/Search.t

Replace the mock of GetTransfers in this test with a mock of transfers
data

Test plan
1/ Run t/db_dependent/Search.t
2/ Confirm it passes
3/ Apply patch
4/ Repeat steps 1-2

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26205] News Changes aren't Logged

2021-03-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26205

--- Comment #3 from Lucas Gass  ---
I think this needs to be higher priority. Combined with Bug 26205 librarians
are losing large sections of HTML because the WYSIWYG is doing automatic code
clean up. Without logs there is no way to recover the old data.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead

2021-03-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295

Martin Renvoize  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >