[Koha-bugs] [Bug 28729] Return-path header not set in emails
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28729 --- Comment #22 from David Cook --- (In reply to David Cook from comment #21) > I wouldn't be surprised if this were related to Bug 26705. I mean... not the same problem/fix, but that the new library might be messing with things. I could be totally wrong though. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28729] Return-path header not set in emails
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28729 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #21 from David Cook --- I wouldn't be surprised if this were related to Bug 26705. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13188] Make it possible to configure mandatory patron data differently between OPAC registration and modification
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13188 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #21 from David Cook --- Excited for this one -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28413] background job worker is running with all the modules in RAM
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28413 --- Comment #5 from David Cook --- On my radar but I'm catching up on a backlog atm. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28445] Use the task queue for the batch delete and update items tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28445 --- Comment #15 from David Cook --- (In reply to Jonathan Druart from comment #14) > > (note that you can use 'é' for more fun, don't try more funny characters) > > This is not correct, any 4-byte character is supposed to work. Should that be 1-4 byte character since UTF-8 characters are all between 1-4 bytes long? (J'adore couper les cheveux en quatre... ) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28567] Pick-up location is not saved correctly when creating a new library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28567 David Nind changed: What|Removed |Added Text to go in the||This fixes an issue when release notes||adding a new library - the ||pick-up location was always ||saving as "Yes", even when ||no was selected. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 David Nind changed: What|Removed |Added Text to go in the||This fixes an issue where release notes||irregularities are lost ||when renewing a ||subscription. Now when ||renewing a subscription ||irregularities are kept for ||daily, weekly and monthly ||serials (1 unit per issue ||only). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27505] Add new itemtype controller image for carredart
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27505 David Nind changed: What|Removed |Added Text to go in the||This enhancement adds a release notes||video game controller image ||to the carredart icon set ||for item types. CC||da...@davidnind.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27505] Add new itemtype controller image for carredart
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27505 David Nind changed: What|Removed |Added Attachment #123192|0 |1 is obsolete|| --- Comment #12 from David Nind --- Created attachment 123276 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123276=edit Bug 27505: Add new itemtype controller image for carredart This patch adds a new video game controller icon to the carredart icon set. The icon is based on this one which is in the public domain: https://commons.wikimedia.org/wiki/File:Controller.svg Test Plan 1. Go to Administration > Item types > Modify item type 2. There should be a controller item type under the carredart 3. Modify the item type so one of the new icons is used 4. Search for an item using the above item type 5. Check that the icon displays properly in both the staff client and OPAC Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27505] Add new itemtype controller image for carredart
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27505 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27523] Adding new itemtype lock image to carredart
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27523 David Nind changed: What|Removed |Added CC||da...@davidnind.com Text to go in the||This enhancement adds a release notes||lock image to the carredart ||icon set for item types. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27521] Adding new itemtype headset image for carredart
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27521 David Nind changed: What|Removed |Added Text to go in the|This enhancement adds a |This enhancement adds a release notes|headset image to the|headset image to the |carredart icons for item|carredart icon set for item |types. |types. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27523] Adding new itemtype lock image to carredart
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27523 David Nind changed: What|Removed |Added Attachment #123189|0 |1 is obsolete|| --- Comment #9 from David Nind --- Created attachment 123275 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123275=edit Bug 27523: Adding new itemtype lock image to carredart This patch adds a new "lock" image to the carredart icon set. The source of the image is in the public domain: https://thenounproject.com/icon/89649. Test Plan 1. Go to Administration > Item types > Modify item type 2. There should be a lock item type under the carredart 3. Modify the item type so the lock item type is used 4. Search for an item using the above item type 5. Check that the icon displays properly in both the staff client and OPAC Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27523] Adding new itemtype lock image to carredart
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27523 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27521] Adding new itemtype headset image for carredart
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27521 David Nind changed: What|Removed |Added CC||da...@davidnind.com Text to go in the||This enhancement adds a release notes||headset image to the ||carredart icons for item ||types. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13188] Make it possible to configure mandatory patron data differently between OPAC registration and modification
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13188 Lucas Gass changed: What|Removed |Added Text to go in the||Adds the system preference release notes||PatronSelfModificationManda ||toryField in order to ||separate borrower ||registration from borrower ||modification. Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27521] Adding new itemtype headset image for carredart
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27521 David Nind changed: What|Removed |Added Attachment #122932|0 |1 is obsolete|| --- Comment #11 from David Nind --- Created attachment 123274 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123274=edit Bug 27521: (follow-up) Adding new itemtype headset image for carredart This patch adds new version of the image which was created based on a CC0-licensed public domain image: https://commons.wikimedia.org/wiki/File:Headphones_(17471)_-_The_Noun_Project.svg Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27521] Adding new itemtype headset image for carredart
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27521 David Nind changed: What|Removed |Added Attachment #115748|0 |1 is obsolete|| --- Comment #10 from David Nind --- Created attachment 123273 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123273=edit Bug 27521: (follow-up) Add copy of image to carredart icons in the OPAC Signed-off-by: Sally Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27521] Adding new itemtype headset image for carredart
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27521 David Nind changed: What|Removed |Added Attachment #115747|0 |1 is obsolete|| --- Comment #9 from David Nind --- Created attachment 123272 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123272=edit Bug 27521: Add new item type headset image for carredart TEST PLAN: 1) Go to administration 2) Go to item types 3) Click edit on one of the item types 4) Go to the category "carredart" 5) Check that there is a small headset icon Signed-off-by: Sally Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27521] Adding new itemtype headset image for carredart
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27521 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28761] Item status shows incorrectly on opac-course-details.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28761 Lucas Gass changed: What|Removed |Added Version(s)||Fixes a problem in the OPAC released in||course reserves table where ||restricted and not for loan ||statues were not displaying ||properly in the Status ||column. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28717] NewsLog doesn't work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28717 Lucas Gass changed: What|Removed |Added Patch complexity|--- |Small patch Text to go in the||This patch fixes a release notes||regression in the NewsLog ||caused by Bug 28718. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28777] SPAM
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28777 Owen Leonard changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |INVALID Summary|Demon Alvien|SPAM -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14783] Allow patrons to change pickup location for non-waiting holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14783 --- Comment #12 from Owen Leonard --- Created attachment 123271 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123271=edit Bug 14783: (follow-up) Move pickup library form into modal This patch attemps to simplify the list of holds by moving the form for changing a hold's pickup library into a modal dialog. This patch also makes minor tweaks to the CSS for the "X" close button shown in modal in windows. Instances where modal markup used "x" have been updated to use the Bootstrap 4 standard "" To test, apply the patch and rebuild the OPAC SCSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client) - Turn on the OPACAllowUserToChangeBranch system preference. - Log in to the OPAC as a user with holds. - In the view of your holds, confirm that each hold which can be modified shows a "Change" link. - Clicking the link should show a modal window with the title of the item on hold shown in the header. - Confirm that changing the pickup location works correctly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14783] Allow patrons to change pickup location for non-waiting holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14783 Owen Leonard changed: What|Removed |Added Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28766] Fix remaining instance of missing sub checkHoldPolicy in C4/HoldsQueue.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28766 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12561] Remove non-XSLT views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12561 --- Comment #26 from Owen Leonard --- Created attachment 123270 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123270=edit Bug 12561: Add warning on about page If a default xslt file has been removed or if the one filled in one of the syspref does not exist. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12561] Remove non-XSLT views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12561 --- Comment #25 from Owen Leonard --- Created attachment 123269 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123269=edit Bug 12561: Change prototype of XSLTParse4Display Use a hash for better readability and reusability. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12561] Remove non-XSLT views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12561 --- Comment #24 from Owen Leonard --- Created attachment 123268 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123268=edit Bug 12561: Remove non-XSLT views Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12561] Remove non-XSLT views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12561 Owen Leonard changed: What|Removed |Added Attachment #123262|0 |1 is obsolete|| Attachment #123263|0 |1 is obsolete|| Attachment #123264|0 |1 is obsolete|| Attachment #123265|0 |1 is obsolete|| --- Comment #23 from Owen Leonard --- Created attachment 123267 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123267=edit Bug 12561: Remove HighlightOwnItemsOnOPAC and HighlightOwnItemsOnOPACWhich This is the only remaining non-XSLT only feature. We should remove the non-XSLT views that have been deprecated for a while now, and remove this feature. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12561] Remove non-XSLT views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12561 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28057] Confusion of biblionumber and biblioitemnumber in request.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28057 --- Comment #13 from Nick Clemens --- Created attachment 123266 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123266=edit Bug 28057: (follow-up) Get the biblionumber column When we fetch the biblioitems we use a select to limit the columns fetched, we must include the biblionumber as well -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28057] Confusion of biblionumber and biblioitemnumber in request.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28057 Nick Clemens changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25260] Merge 'reserves' and 'old_reserves' into a new 'holds' table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25260 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #93 from Owen Leonard --- I get an error from pendingreserves.pl: DBIx::Class::ResultSource::_resolve_join(): No such relationship itembib on Hold at /kohadevbox/koha/Koha/Objects.pm line 444 at /usr/share/perl5/DBIx/Class/Exception.pm line 77 When checking in an item which has a hold, the modal dialog has incomplete information: Hold for: A patron from library - Transfer to: The hold isn't marked as "Waiting" even though it's at its destination library. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28057] Confusion of biblionumber and biblioitemnumber in request.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28057 --- Comment #12 from Joonas Kylmälä --- (In reply to Nick Clemens from comment #9) > I believe that this fix is still 'correct' though, i.e. we are fixing a > separate issue that is definitely wrong. It leaves more work to do, but that > should eb another bug. Well, we shouldn't be passing the biblionumber of the host record here at all but I don't think it makes a huge difference here whether we use biblioitemnumber or bibitem's biblionumber. So it is fine by me to merge this given the regression I just spotted is fixed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28057] Confusion of biblionumber and biblioitemnumber in request.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28057
--- Comment #11 from Joonas Kylmälä ---
(In reply to Joonas Kylmälä from comment #10)
> This causes an regression for normal usage, to reproduce:
>
> 1. Set circ rule as follows: on shelf holds: If all unavailable
> 2. Add one (available) item to biblio
> 3. Notice that you get error message when trying to place a hold
> 4. Apply patch
> 5. Refresh the hold page and notice the error message is gone!
>
> This patch should not break the on shelf hold reservation rules for
> non-analytic record items the very least.
The problem appears to be that the new variable is undefined. I added some
debugging code:
+warn "Checking with: " . $biblioitem->{biblionumber} . "\n";
this produces the following log result:
[2021/07/28 15:58:11] [WARN] Checking with:
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28057] Confusion of biblionumber and biblioitemnumber in request.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28057 Joonas Kylmälä changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #10 from Joonas Kylmälä --- This causes an regression for normal usage, to reproduce: 1. Set circ rule as follows: on shelf holds: If all unavailable 2. Add one (available) item to biblio 3. Notice that you get error message when trying to place a hold 4. Apply patch 5. Refresh the hold page and notice the error message is gone! This patch should not break the on shelf hold reservation rules for non-analytic record items the very least. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 --- Comment #54 from Tomás Cohen Arazi --- Hi, get_infos_syspref() should be using C4::Context->yaml_preference instead of manually dealing with YAML. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12561] Remove non-XSLT views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12561 --- Comment #22 from Jonathan Druart --- Created attachment 123265 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123265=edit Bug 12561: Add warning on about page If a default xslt file has been removed or if the one filled in one of the syspref does not exist. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12561] Remove non-XSLT views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12561 --- Comment #21 from Jonathan Druart --- Created attachment 123264 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123264=edit Bug 12561: Change prototype of XSLTParse4Display Use a hash for better readability and reusability. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12561] Remove non-XSLT views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12561 --- Comment #20 from Jonathan Druart --- Created attachment 123263 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123263=edit Bug 12561: Remove non-XSLT views -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12561] Remove non-XSLT views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12561 Jonathan Druart changed: What|Removed |Added Attachment #122607|0 |1 is obsolete|| Attachment #122608|0 |1 is obsolete|| Attachment #122609|0 |1 is obsolete|| Attachment #122610|0 |1 is obsolete|| --- Comment #19 from Jonathan Druart --- Created attachment 123262 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123262=edit Bug 12561: Remove HighlightOwnItemsOnOPAC and HighlightOwnItemsOnOPACWhich This is the only remaining non-XSLT only feature. We should remove the non-XSLT views that have been deprecated for a while now, and remove this feature. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12561] Remove non-XSLT views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12561 Jonathan Druart changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25260] Merge 'reserves' and 'old_reserves' into a new 'holds' table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25260 --- Comment #92 from Tomás Cohen Arazi --- Created attachment 123261 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123261=edit Bug 25260: (follow-up) Remove warning Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25260] Merge 'reserves' and 'old_reserves' into a new 'holds' table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25260 --- Comment #91 from Tomás Cohen Arazi --- Created attachment 123260 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123260=edit Bug 25260: (QA follow-up) Rename id => hold_id The guidelines clearly specify this is how the primary key needs to be named. https://wiki.koha-community.org/wiki/Coding_Guidelines#SQL7:_Primary_keys Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25260] Merge 'reserves' and 'old_reserves' into a new 'holds' table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25260 --- Comment #90 from Tomás Cohen Arazi --- Created attachment 123259 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123259=edit Bug 25260: ILSDI is tied to old DB structure for holds Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25260] Merge 'reserves' and 'old_reserves' into a new 'holds' table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25260 --- Comment #89 from Tomás Cohen Arazi --- Created attachment 123258 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123258=edit Bug 25260: (QA follow-up) Fix any bad dates prior to migration Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25260] Merge 'reserves' and 'old_reserves' into a new 'holds' table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25260 --- Comment #88 from Tomás Cohen Arazi --- Created attachment 123257 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123257=edit Bug 25260: Adapt all the things This patch adapts many pm and test files to work with unified holds table. To test: 1. Remove all previous holds in reserves and old_reserves tables. 2. Create 6 holds. Cancel 2 of them, fulfill one, set one in waiting and another in transit. CHECK => "select reserve_id, found from reserves" query in mysql should return 3 rows, where in found column should find 'W', 'T' and another with null values. => "select reserve_id, found from old_reserves" query in mysql should return 3 rows, where in found column you should find 2 with 'C', and one with 'F' values. 3. in mysql change reserve_id to the value of a hold in reserve table. 4. apply patches 5. updatedatabase SUCCESS => you should get the following warning "There were 1 old reserves that could not be moved, please check '_old_reserves'" => "select id, status, completed from holds" query in mysql should return 5 rows. => The hold that had null value in found column, now should have 'placed' status and 0 in completed. => The one that had 'W' in found column, now should have 'waiting' status and 0 in completed. => The one that had 'T' in found column, now should have 'in_transit' status and 0 in completed. => The one that had 'F' in found column, now should have 'fulfilled' status and 1 in completed. => The unmodified cancelled hold, now should have 'cancelled' status and 1 in completed. => "select * from _old_reserves" should give you one row with the modified hold. 6. in staff interface create, cancel, modify priorities, etc and everything should work exactly as before. # Run every test that has reserve and hold word wihtin # check that you are in main koha directory # check you have correctly setted KOHA_INTRANET_URL and KOHA_OPAC_URL environment variables # check plack is up and running.. tests will use selenium # prepare yourself a mug of coffe/te or take a nap.. this will take a while 7. prove $(grep -ilr -e reserve -e hold t|grep "\.t$") # finally 8. Sign off Sponsored-by: ByWater Solutions Sponsored-by: Theke Solutions Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28057] Confusion of biblionumber and biblioitemnumber in request.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28057
--- Comment #9 from Nick Clemens ---
I think I follow some of the logic, this is all very complex.
I believe that this fix is still 'correct' though, i.e. we are fixing a
separate issue that is definitely wrong. It leaves more work to do, but that
should eb another bug.
(In reply to Joonas Kylmälä from comment #8)
> Even after this change I think we still calculate the availability wrong, in
> version f09e2ca27ee8 where the analytics item reserve support was added it
> seems to have really checked just based on the analytic record's
> reservability without considering whether a hold can be placed to the item
> also in the host record. The issue is that after the analytics code was
> merged the following incompatible code was introduced:
>
> > } elsif ( $on_shelf_holds == 2 ) {
>
> This is in IsAvailableForItemLevelRequest(). This code block checks in this
> case the host record's result for:
>
> > ItemsAnyAvailableAndNotRestricted( { biblionumber => $item->biblionumber,
> > patron => $patron });
>
> which as far as I understand differs from the original implementation in
> f09e2ca27ee8 (though back then there seemingly was no on shelf circ rules).
> The bug seems to have started occuring after the following commit:
>
> Bug 15534 - Add the ability to prevent a patron from placing a hold on a
> record with available items (4e1d7a16896787)
>
> It appears to not have taken into account that for analytic items' case we
> need to check the items for the biblio we are placing the hold for and not
> the host biblio's items.
>
> Quite many things should be changed in our code to fix the situation. Nick,
> did you get a hold of what I just explained, do you see the problem?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25260] Merge 'reserves' and 'old_reserves' into a new 'holds' table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25260 Tomás Cohen Arazi changed: What|Removed |Added Attachment #123079|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25260] Merge 'reserves' and 'old_reserves' into a new 'holds' table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25260 Tomás Cohen Arazi changed: What|Removed |Added Attachment #123078|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25260] Merge 'reserves' and 'old_reserves' into a new 'holds' table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25260 Tomás Cohen Arazi changed: What|Removed |Added Attachment #123077|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25260] Merge 'reserves' and 'old_reserves' into a new 'holds' table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25260 Tomás Cohen Arazi changed: What|Removed |Added Attachment #123076|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25260] Merge 'reserves' and 'old_reserves' into a new 'holds' table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25260 Tomás Cohen Arazi changed: What|Removed |Added Attachment #123080|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12561] Remove non-XSLT views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12561 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28057] Confusion of biblionumber and biblioitemnumber in request.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28057
--- Comment #8 from Joonas Kylmälä ---
Even after this change I think we still calculate the availability wrong, in
version f09e2ca27ee8 where the analytics item reserve support was added it
seems to have really checked just based on the analytic record's reservability
without considering whether a hold can be placed to the item also in the host
record. The issue is that after the analytics code was merged the following
incompatible code was introduced:
> } elsif ( $on_shelf_holds == 2 ) {
This is in IsAvailableForItemLevelRequest(). This code block checks in this
case the host record's result for:
> ItemsAnyAvailableAndNotRestricted( { biblionumber => $item->biblionumber,
> patron => $patron });
which as far as I understand differs from the original implementation in
f09e2ca27ee8 (though back then there seemingly was no on shelf circ rules). The
bug seems to have started occuring after the following commit:
Bug 15534 - Add the ability to prevent a patron from placing a hold on a record
with available items (4e1d7a16896787)
It appears to not have taken into account that for analytic items' case we need
to check the items for the biblio we are placing the hold for and not the host
biblio's items.
Quite many things should be changed in our code to fix the situation. Nick, did
you get a hold of what I just explained, do you see the problem?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28778] New: Demon Alvien
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28778 Bug ID: 28778 Summary: Demon Alvien Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Authentication Assignee: koha-bugs@lists.koha-community.org Reporter: alvingans...@gmail.com QA Contact: testo...@bugs.koha-community.org CC: dpav...@rot13.org Created attachment 123256 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123256=edit Halo semua Demon Alvien -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28777] New: Demon Alvien
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28777 Bug ID: 28777 Summary: Demon Alvien Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Authentication Assignee: koha-bugs@lists.koha-community.org Reporter: alvingans...@gmail.com QA Contact: testo...@bugs.koha-community.org CC: dpav...@rot13.org Created attachment 123255 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123255=edit Halo semua Demon Alvien -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28749] All backups behave as if --without-db-name is passed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28749 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #4 from Nick Clemens --- Trivial, passing QA Thanks Jason! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28749] All backups behave as if --without-db-name is passed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28749 Nick Clemens changed: What|Removed |Added Attachment #123114|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28749] All backups behave as if --without-db-name is passed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28749 --- Comment #3 from Nick Clemens --- Created attachment 123254 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123254=edit Bug 28749: Restore the database name to Koha dumps The line to use the --databases flag with mysqldump by default was accidentally removed from koha-dump when the --schema-only option was added. This makes all backups act as if koha-dump is called with the --without-db-name flag, causing koha-restore to fail to restore the database because it's neither CREATEd or USEd. This patch restores that line To test: 1 - sudo debian/scripts/koha-dump kohadev 2 - zcat /var/spool/koha/kohadev/kohadev-2021-07-28.sql.gz | grep DATABASE 3 - Notice no output 4 - Apply patch 5 - sudo debian/scripts/koha-dump kohadev 6 - zcat /var/spool/koha/kohadev/kohadev-2021-07-28.sql.gz | grep DATABASE 7 - You get the line: CREATE DATABASE /*!32312 IF NOT EXISTS*/ `koha_kohadev` /*!40100 DEFAULT CHARACTER SET latin1 */; Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28749] All backups behave as if --without-db-name is passed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28749 Nick Clemens changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25078] Update DB process - wrap each DBRev inside a transaction and better error handling
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com QA Contact|testo...@bugs.koha-communit |k...@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28729] Return-path header not set in emails
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28729 --- Comment #20 from Ulrich Kleiber --- Hi Jonathan, the configuration of the MTA was not changed when upgrading to 20.11. It is the same on all our Koha Servers. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28261] Add visual feedback on overridden pickup locations on patron's page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28261 --- Comment #8 from Nick Clemens --- Created attachment 123253 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123253=edit Bug 28261: (QA follow-up) Fix width after adding visual feedback Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28261] Add visual feedback on overridden pickup locations on patron's page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28261 Nick Clemens changed: What|Removed |Added Attachment #120493|0 |1 is obsolete|| --- Comment #7 from Nick Clemens --- Created attachment 123252 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123252=edit Bug 28261: Add visual feedback on overridden pickup locations on patron's page This patch makes the patron pages in the staff interface use the API and Select2 to render the pickup locations list. This has the effect of adding visual feedback on those pickup locations that need an override, based on the current configuration options. All the checks are done in the GET /holds/:hold_id/pickup_locations route, so this is a fairly trivial change. To test: 1. Have a couple holds for a patron, some overrriden, some not 2. Visit the patrons' detail page, holds tab. => SUCCESS: You see the holds, pickup location has a dropdown 3. Repeat in the circulation tab for the patron => SUCCESS: You see the holds, pickup location has a dropdown 4. Apply this patch 5. Repeat 2 and 3 => SUCCESS: Same behavior as before, but the dropdown is rendered with Select2 and has a search feature. Overridden pickup locations have an icon telling so 6. Sign off :-D Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28261] Add visual feedback on overridden pickup locations on patron's page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28261 Nick Clemens changed: What|Removed |Added Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28775] Warn when viewing itemtypes.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28775 Nick Clemens changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28776] Warns from GetItemsInfo when biblio marked as serial
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28776 Nick Clemens changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28776] Warns from GetItemsInfo when biblio marked as serial
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28776 --- Comment #1 from Nick Clemens --- Created attachment 123251 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123251=edit Bug 28776: Warns from GetItemsInfo when biblio marked as serial GetItemsInfo sorts the items using serial fields if the biblio is defined as a serial The fields may not be defined. We can add a fallback to blank in this case To test: 1 - Mark a record with items as serial in the marc (942$s) 2 - At least one of the items should have no enumchron defined 3 - Load the detail page 4 - Warns in logs: [WARN] Use of uninitialized value in string comparison (cmp) at /kohadevbox/koha/C4/Items.pm line 811. 5 - Apply patch and restart all 6 - Reload the details page 7 - No more warns -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28776] Warns from GetItemsInfo when biblio marked as serial
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28776 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28057] Confusion of biblionumber and biblioitemnumber in request.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28057 Peter Vashchuk changed: What|Removed |Added Attachment #119598|0 |1 is obsolete|| --- Comment #7 from Peter Vashchuk --- Created attachment 123250 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123250=edit Bug 28057: Use the biblioitem's biblionumber for checking availability The loop here gets items from the record, plus analytic items. Because of this we need to check more than 1 record - we decide to do this via biblioitems. We need to preserve that, but when checking ItemsAnyAvailableAndNotRestricted we cannot assume that the biblionumber and biblioitemnumber are the same (they should be but this may not be the best of all possible worlds) I simply switch the call here To test: 1 - Apply patch 2 - Test placing holds on single bibs and multiple bibs 3 - Confirm it works as expected Signed-off-by: Petro Vashchuk -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28773] Aquisitions from external source not working for non english language
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28773 --- Comment #3 from Mark Hofstetter --- Honestly - I wouldn't have done it differently, and if so only worse. But I tested it and it works now. On my behalf I'd sign it off, thx a lot -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28057] Confusion of biblionumber and biblioitemnumber in request.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28057 Peter Vashchuk changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28776] New: Warns from GetItemsInfo when biblio marked as serial
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28776 Bug ID: 28776 Summary: Warns from GetItemsInfo when biblio marked as serial Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org To recreate: 1 - Mark a record with items as serial in the marc (942$s) 2 - At least one of the items should have no enumchron defined 3 - Load the detail page 4 - Warns in logs: [WARN] Use of uninitialized value in string comparison (cmp) at /kohadevbox/koha/C4/Items.pm line 811. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20844] Reset a hold when it is missing after allocation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20844 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28775] Warn when viewing itemtypes.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28775 --- Comment #1 from Nick Clemens --- Created attachment 123249 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123249=edit Bug 28775: Pass interface to getTranslatedLanguages Don't pass undef for interface, we are on the staff client To test: 1 - Browse to Administration -> Item types administration 2 - See in logs: [WARN] Use of uninitialized value $interface in concatenation (.) or string at /kohadevbox/koha/C4/Languages.pm line 121. 3 - Apply patch 4 - Reload page 5 - No warn -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28775] Warn when viewing itemtypes.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28775 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28775] New: Warn when viewing itemtypes.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28775 Bug ID: 28775 Summary: Warn when viewing itemtypes.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com Browse to: Administration -> Item types administration [WARN] Use of uninitialized value $interface in concatenation (.) or string at /kohadevbox/koha/C4/Languages.pm line 121. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28729] Return-path header not set in emails
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28729 --- Comment #19 from Jonathan Druart --- Did you check the MTA config? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28729] Return-path header not set in emails
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28729 --- Comment #18 from Jonathan Druart --- Tried on 18.11.x -- MESSAGE FOLLOWS -- Sender: returnpathdefa...@default.org Mime-Version: 1.0 Charset: utf8 Content-Transfer-Encoding: quoted-printable Subject: =?UTF-8?B?Q2hlY2tvdXRz?= Content-Type: text/plain; charset="UTF-8" Date: Wed, 28 Jul 2021 12:59:39 + To: e...@example.org From: r...@example.org X-Peer: 127.0.0.1 The following items have been checked out: E Street shuffle=20 Thank you for visiting Centerville.= END MESSAGE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28729] Return-path header not set in emails
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28729 --- Comment #17 from Katrin Fischer --- (In reply to Jonathan Druart from comment #16) > Looks like we never set the "Return-Path" from Koha and haven't found > anything related in the Mail::Sendmail library. But it worked. Just because we haven't found out why it changed yet, doesn't mean this isn't a regression. Because the behaviour change can be proved. The Return-path functionality was developed, tested and agreed on in bug 9350 in 2014. I can promise it worked when added to Koha and has worked since then at least up to 18.11 but probably in later versions as well. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28770] Add request date to order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28770 --- Comment #2 from Michael Sutherland --- The requested date is when a patron submitted the request. We receive and approve patron requests from several different platforms and not just the purchase request form in Koha. We might receive them via a librarian liaison, for example. Since that is the case, we do not currently have a way to keep track of when a request was submitted, except through an excel spreadsheet. It would be time consuming to enter a purchase request while at the same time creating an order. Therefore, it would be simple to add a 'requested date' - when the item was requested - to the order when it was created. aqorders already has date fields in it, such as the budgetdate - according to the database schema it says budgetdate - 'not used? always NULL' - perhaps something like that could be recycled into a requesteddate? But, the order form itself does not have a text or date field for a date, as you can see in the attachment. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28729] Return-path header not set in emails
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28729 --- Comment #16 from Jonathan Druart --- Looks like we never set the "Return-Path" from Koha and haven't found anything related in the Mail::Sendmail library. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28261] Add visual feedback on overridden pickup locations on patron's page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28261 --- Comment #6 from Jonathan Druart --- (In reply to Nick Clemens from comment #5) > Created attachment 123111 [details] > Too long library name makes the icon drop down > > Display issue when library name is long I haven't tried but maybe it's not caused by this patch. I opened bug 26288 some times ago, that seems related. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28445] Use the task queue for the batch delete and update items tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28445 --- Comment #14 from Jonathan Druart --- > (note that you can use 'é' for more fun, don't try more funny characters) This is not correct, any 4-byte character is supposed to work. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28729] Return-path header not set in emails
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28729 Katrin Fischer changed: What|Removed |Added Keywords||regression -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Joonas Kylmälä changed: What|Removed |Added CC||joonas.kylm...@helsinki.fi --- Comment #186 from Joonas Kylmälä --- Adds unused function _get_sub_length which should be removed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28729] Return-path header not set in emails
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28729 Katrin Fischer changed: What|Removed |Added Severity|normal |major --- Comment #15 from Katrin Fischer --- Any library relying on the return-path paramters might be likely to no longer receive emails bouncing back. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28729] Return-path header not set in emails
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28729 --- Comment #14 from Katrin Fischer --- (In reply to Jonathan Druart from comment #13) > So if I understand correctly this is a new enhancement request, not a > regression? No, it's a regression and a bug. We have configuration options for the Return-Path in Koha that now are no longer used/functional. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28567] Pick-up location is not saved correctly when creating a new library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28567 --- Comment #25 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #24) > As noted before, I would have split this report in two. And I do not really > see the need for replacing the empty strings here. > But the bug is resolved. Thanks for your time QAing this one, Marcel. I added the DBrev to have all the values identical before and after this patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28749] All backups behave as if --without-db-name is passed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28749 Jonathan Druart changed: What|Removed |Added CC||n...@bywatersolutions.com Assignee|koha-b...@lists.koha-commun |jbo...@equinoxoli.org |ity.org | Summary|All backups on 21.05 behave |All backups behave as if |as if --without-db-name is |--without-db-name is passed |passed | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28729] Return-path header not set in emails
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28729 Jonathan Druart changed: What|Removed |Added Severity|critical|normal Summary|Return-path header not |Return-path header not set |correctly set in emails |in emails Version|20.11 |unspecified --- Comment #13 from Jonathan Druart --- So if I understand correctly this is a new enhancement request, not a regression? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28774] Warnings from GetIssuingCharge when rental discount is not set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28774 Nick Clemens changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28774] Warnings from GetIssuingCharge when rental discount is not set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28774 --- Comment #1 from Nick Clemens --- Created attachment 123248 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123248=edit Bug 28774: Don't store blank values for rental discount This patch adds 'can_be_blank => 0' for the rentaldiscount rule to prevent storing blank values in the database Additionally, if there is no charge we do not need to check for a discount and can simply return To test: 1 - Set rental discount to "" to a rule in circulation rules 2 - Checkout an item that will follow this rule 3 - Check the intranet log: [WARN] Argument "" isn't numeric in subtraction (-) at /kohadevbox/koha/C4/Circulation.pm line 3385. 4 - Apply patch and restart all 5 - Update database 6 - Set the rule to "" again 7 - Check the DB, no rule is stored SELECT * FROM circulation_rules WHERE rule_name = 'rentaldiscount'; 8 - Checkout the item again 9 - No warns in log -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28774] Warnings from GetIssuingCharge when rental discount is not set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28774 Nick Clemens changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28774] New: Warnings from GetIssuingCharge when rental discount is not set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28774 Bug ID: 28774 Summary: Warnings from GetIssuingCharge when rental discount is not set Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com If you set the rental discount field blank in circ rules it is stored as "" Checkout an item: [2021/07/28 12:11:25] [WARN] Argument "" isn't numeric in subtraction (-) at /kohadevbox/koha/C4/Circulation.pm line 3385. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28445] Use the task queue for the batch delete and update items tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28445 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=28687 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28687] Add Koha::Item::Attribute(s)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28687 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=28445 CC||jonathan.druart+koha@gmail. ||com --- Comment #1 from Jonathan Druart --- Note that bug 28445 is adding a Koha::Item::Attributes class. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26302] OPAC XSLT Results: List variable number of itemcallnumbers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 --- Comment #30 from Marcel de Rooy --- (In reply to Nick Clemens from comment #29) > I am seeing the same callnumbers for every branch, to recreate: > 1 - sudo koha-mysql kohadev > 2 - UPDATE items SET itemcallnumber=barcode; > 3 - Add 5 items for a single branch (IPT) with IPT1-5 as barcodes and "IPT" > as item callnumber > 4 - Display in opac: > Availability: Items available for loan: Midway (1) Call number: > 313351, 313375, 313399, Centerville (3) Call number: > 313351, 313375, 313399, Fairview (1) Call number: > 313351, 313375, 313399, Institut Protestant de > Théologie (5) Call number: 313351, 313375, 313399, > ... Thx for testing, Nick. Will have another look -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
