[Koha-bugs] [Bug 29107] item_type should be item_type_id on item response object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29107 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29104] Add dateexpiry column to circulation patron search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29104 --- Comment #4 from Cab Vinton --- Unable to test on sandbox.bywatersolutions.com. Tested on biblibre.eu sandbox. Patch failed to apply: Bug 29104 - Add dateexpiry column to circulation patron search results 125249 - Bug 29104: Add date expiry column to patron search borrower table Applying: Bug 29104: Add date expiry column to patron search borrower table Apply? [(y)es, (n)o, (i)nteractive] C4::Installer::run_atomic_updates(): DBI Exception: DBD::mysql::db do failed: Duplicate column name 'ft_local_float_group' at koha/installer/data/mysql/updatedatabase.pl line 24298 DEV atomic update /kohadevbox/koha/installer/data/mysql/atomicupdate/bug_28854.perl [04:23:38] DEV atomic update /kohadevbox/koha/installer/data/mysql/atomicupdate/Bug-9525-Add_ft_local_float_group_column.perl [04:23:38] ERROR - C4::Installer::run_atomic_updates(): DBI Exception: DBD::mysql::db do failed: Duplicate column name 'ft_local_float_group' at koha/installer/data/mysql/updatedatabase.pl line 24298 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29020] Missing Background jobs link in admin-home
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29020 David Cook changed: What|Removed |Added CC||wizzy...@gmail.com --- Comment #1 from David Cook --- *** Bug 29141 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29141] The rabbitmq task queue results page is very hard to find
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29141 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #1 from David Cook --- Agreed. This is a duplicate of bug 29020 which has a bit more of a following, so going to close this one in favour of that one. *** This bug has been marked as a duplicate of bug 29020 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26764] schema.koha-community.org 'display all' ?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26764 --- Comment #2 from Chris Cormack --- Could be, if someone can tell me the option, ill make the generator use it :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29135] OAI should not include biblionumbers from deleteditems when determining deletedbiblios
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29135 --- Comment #2 from David Cook --- (In reply to David Cook from comment #1) > Good catch. > > I think there's some additional relevant lines lower down in > Koha/OAI/Server/ListBase.pm as well when the max timestamp is fetched. > Koha/OAI/Server/GetRecord.pm has that same weird logic, although it would just be a performance degradation rather than a wrong classification... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23678] Cancel holds in bulk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678 Tomás Cohen Arazi changed: What|Removed |Added Text to go in the||This developments adds a release notes||way to choose multiple ||holds using checkboxes, to ||cancel them in bulk. || ||It ||uses the new background ||jobs infrastructure ||recently introduced. Patch complexity|Trivial patch |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29135] OAI should not include biblionumbers from deleteditems when determining deletedbiblios
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29135 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #1 from David Cook --- Good catch. I think there's some additional relevant lines lower down in Koha/OAI/Server/ListBase.pm as well when the max timestamp is fetched. $sql = " SELECT MAX(timestamp) FROM ( SELECT timestamp FROM deletedbiblio_metadata WHERE biblionumber = ? UNION SELECT timestamp FROM deleteditems WHERE biblionumber = ? ) bis "; I mean it should be impossible to deleted an item after the bib has been deleted. But this SQL would return a timestamp where there is a deleted item but not a deleted bib. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23678] Cancel holds in bulk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678 Tomás Cohen Arazi changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29134] Patron search has poor performance when ExtendedAttributes enabled and many attributes match
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29134 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #5 from David Nind --- I attempted to test (using koha-testing-docker - started with ku). For whatever reason, the SQL in step 1 didn't add the new patrons to the database - I still just have the standard 53 patrons you normally get with KTD. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23678] Cancel holds in bulk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678 --- Comment #23 from Tomás Cohen Arazi --- Created attachment 125470 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125470=edit Bug 23678: (QA follow-up) Use correct indentation Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21729] When reverting a hold the expirationdate should be reset
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26346] Add option to make a public list editable by library staff only
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346
--- Comment #74 from Tomás Cohen Arazi ---
(In reply to Alex Buckley from comment #73)
> (In reply to Tomás Cohen Arazi from comment #69)
> > Shouldn't we have a single 'allowed_to_change' column as an
> > ENUM('owner','everyone','staff') ?
>
> Hi Tomás,
>
> I've had more of a think about this, and discussed with Chris C and Aleisha.
> Here are our thoughts:
>
> 1. Introducing a single 'allowed_to_change' column should be done on a
> different bug report. This bug report is adding an enhancement. Introducing
> a single 'allowed_to_change' column would require existing permission logic
> for 'owners' and 'everyone' to be altered which is outside the scope of this
> enhancement.
>
> 2. As we understand it currently a list can have a combination of
> permissions, hence why multiple columns were originally introduced. See
> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18228#c2
>
> Furthermore in comment #67 I noted a 'staff only' list has both
> allow_change_from_owner=1 and allow_change_from_staff=1.
>
> Merging these separate columns into a single 'allowed_to_change' column
> would eliminate the granularity that's currently available, so we wonder if
> it's not the best solution.
>
> All of that being the case, I'm marking this patchset as 'Needs signoff', as
> it's been rebased. Happy to hear your thoughts though!
Sounds like a good review of the current status of the feature. And makes
sense. I will poke at it tomorrow. My 'fear' is we could be adding some
technical debt.
As I said, I'll be happy to review this.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26949] Upgrade TinyMCE in the staff interface from 5.0.16 to 5.5.1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26949 --- Comment #7 from David Nind --- Awesome - thanks for fixing Owen. Happy to ad my sign off. David -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26346] Add option to make a public list editable by library staff only
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346
Alex Buckley changed:
What|Removed |Added
Status|ASSIGNED|Needs Signoff
--- Comment #73 from Alex Buckley ---
(In reply to Tomás Cohen Arazi from comment #69)
> Shouldn't we have a single 'allowed_to_change' column as an
> ENUM('owner','everyone','staff') ?
Hi Tomás,
I've had more of a think about this, and discussed with Chris C and Aleisha.
Here are our thoughts:
1. Introducing a single 'allowed_to_change' column should be done on a
different bug report. This bug report is adding an enhancement. Introducing a
single 'allowed_to_change' column would require existing permission logic for
'owners' and 'everyone' to be altered which is outside the scope of this
enhancement.
2. As we understand it currently a list can have a combination of permissions,
hence why multiple columns were originally introduced. See
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18228#c2
Furthermore in comment #67 I noted a 'staff only' list has both
allow_change_from_owner=1 and allow_change_from_staff=1.
Merging these separate columns into a single 'allowed_to_change' column would
eliminate the granularity that's currently available, so we wonder if it's not
the best solution.
All of that being the case, I'm marking this patchset as 'Needs signoff', as
it's been rebased. Happy to hear your thoughts though!
Many thanks
Alex
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29137] Unwanted authorised values are too easily created via the cataloging module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29137 Joy Nelson changed: What|Removed |Added CC||j...@bywatersolutions.com --- Comment #4 from Joy Nelson --- Most catalogers (even non super librarians) will need the ability to manage authorised values. But what they need/value most of all is 'efficiency' in cataloging. For their workflows, they need the ability to quickly select a value in the drop down by typing the first couple letters and select the value, move on to the next dropdown. (reduction of number of clicks) What this featuer does is change their workflow and requires them to scroll instead of using the keyboard. We will see a cataloger revolt if we do not find a way to make this optional for catalogers. joy (In reply to Andrew Fuerste-Henry from comment #3) > Removing the permission would be effective for wholly disabling this feature > for folks who are not superlibrarians. > Ideally, superlibrarians who don't wish to use this would also have a way to > turn it off. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27266] Move C4::Biblio::GetMarcAuthors to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 --- Comment #29 from Aleisha Amohia --- Created attachment 125469 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125469=edit Bug 27266: (follow-up) Remove get_marc_authors from opac-detail There's no way to use 'no' XSLT now, so don't need to use this to show authors on the detail page. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27266] Move C4::Biblio::GetMarcAuthors to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 Aleisha Amohia changed: What|Removed |Added Attachment #125443|0 |1 is obsolete|| --- Comment #28 from Aleisha Amohia --- Created attachment 125468 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125468=edit Bug 27266: (follow-up) Using biblio frameworkcode to get rid of FIXME -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27266] Move C4::Biblio::GetMarcAuthors to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 Aleisha Amohia changed: What|Removed |Added Attachment #125442|0 |1 is obsolete|| --- Comment #27 from Aleisha Amohia --- Created attachment 125467 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125467=edit Bug 27266: (follow-up) Remove instances of GetMarcAuthors Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27266] Move C4::Biblio::GetMarcAuthors to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 Aleisha Amohia changed: What|Removed |Added Attachment #125441|0 |1 is obsolete|| --- Comment #26 from Aleisha Amohia --- Created attachment 125466 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125466=edit Bug 27266: (QA follow-up) Rename to get_marc_authors Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27266] Move C4::Biblio::GetMarcAuthors to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 Aleisha Amohia changed: What|Removed |Added Attachment #125440|0 |1 is obsolete|| Attachment #125444|0 |1 is obsolete|| --- Comment #25 from Aleisha Amohia --- Created attachment 125465 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125465=edit Bug 27266: Move GetMarcAuthors to Koha namespace This patch moves C4::Biblio::GetMarcAuthors to Koha::Biblio->get_authors_from_MARC. This is so the method can be used in templates and notices. To test: 1. Find a record that has an author in the added entry field (700-720). 2. Add the record to the cart and a list. 3. View your cart and click 'more details'. Confirm authors show as normal. 4. Click 'send' and confirm the email sent shows the authors as normal. 5. Go to the list you added the record to and click 'send list'. Confirm the email sent shows the authors as normal. xslt) 6. Log in to the OPAC. Find the record and add it to the cart and a list 7. View the cart and click 'more details'. Confirm authors show as normal. 8. Click 'send' and confirm the email sent shows the authors as normal. 9. Go to the list you added the record to and click 'send list'. Confirm the email sent shows the authors as normal. 10. Confirm tests pass: - t/Biblio.t - t/db_dependent/Koha/Biblio.t Sponsored-by: Bibliotheksservice-Zentrum Baden-Württemberg (BSZ) Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26764] schema.koha-community.org 'display all' ?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26764 Liz Rea changed: What|Removed |Added CC||wizzy...@gmail.com Assignee|wizzy...@gmail.com |ch...@bigballofwax.co.nz --- Comment #1 from Liz Rea --- I agree this is annoying and I think is an option that can be set when the schemas are generated - Chris? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29141] New: The rabbitmq task queue results page is very hard to find
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29141 Bug ID: 29141 Summary: The rabbitmq task queue results page is very hard to find Change sponsored?: --- Product: Koha Version: 21.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: wizzy...@gmail.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com It appears that this page /cgi-bin/koha/admin/background_jobs.pl isn't linked from anywhere but the "we've enqueued this" pages on biblio modification. Librarians ought to be able to find this page easily so if they click off of the page and go about their lives, they can come back to make sure their jobs completed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28919] When placing a multi-hold from results in staff pickup location is empty
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28919 Katrin Fischer changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28919] When placing a multi-hold from results in staff pickup location is empty
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28919 --- Comment #7 from Katrin Fischer --- > > The pull down from the top, the "Pickup at:"? > > https://snipboard.io/pRHAMn.jpg Oh! I never noticed the one on top - will try to retry :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28717] NewsLog doesn't work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28717 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply --- Comment #20 from Lucas Gass --- this patch, the one for master, no longer cleanly applies. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20844] Reset a hold when it is missing after allocation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20844 --- Comment #49 from Aleisha Amohia --- Hi Andrew, it seems that bug exists regardless of this new work. I can work on Bug 21729 but waiting on that patch shouldn't hold up the signoff for this enhancement. Thanks -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29137] Unwanted authorised values are too easily created via the cataloging module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29137 --- Comment #3 from Andrew Fuerste-Henry --- Removing the permission would be effective for wholly disabling this feature for folks who are not superlibrarians. Ideally, superlibrarians who don't wish to use this would also have a way to turn it off. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29137] Unwanted authorised values are too easily created via the cataloging module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29137 Andrew Fuerste-Henry changed: What|Removed |Added Summary|Unwanted to authorised |Unwanted authorised values |values are too easily |are too easily created via |created via the cataloging |the cataloging module |module | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20844] Reset a hold when it is missing after allocation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20844 Andrew Fuerste-Henry changed: What|Removed |Added CC||and...@bywatersolutions.com --- Comment #48 from Andrew Fuerste-Henry --- On initial testing, this technically works, but is severely hampered by bug 21729 -- when a hold goes to Waiting, the expiration date is set based on ReservesMaxPickUpDelay. When the hold is reverted, that expiration date remains. Without patching 21729, this feature will leave most libraries with a bunch of bib-level holds that expire within a week or so. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 --- Comment #337 from Martin Renvoize --- Still interested but just haven't been able to commit any more time to it. Honestly it's a complicated enough patch that I get lost in it for days every time I start to look at it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28373] Items fields not used in default XSLT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28373 Nick Clemens changed: What|Removed |Added Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29139] Paying gives ISE if UseEmailReceipts is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29139
Andrew Fuerste-Henry changed:
What|Removed |Added
Attachment #125463|0 |1
is obsolete||
--- Comment #2 from Andrew Fuerste-Henry ---
Created attachment 125464
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125464=edit
Bug 29139: $line->debit_offsets doesn't honor list context
Being based on _new_from_dbic (discussion on bug 28883), makes the
assignment incorrect:
my @account_offsets = $payment->debit_offsets;
This patch explicitly makes the resultset be assigned as a list by
calling *as_list*.
To test:
1. Have UseEmailReceipts disabled
2. Have a patron with a debt of 6
3. Make a payment of 2
=> SUCCESS: All good
4. Enable UseEmailReceipts
5. Repeat 3
=> FAIL: You get something like:
ERROR PROCESSING TEMPLATE: undef error - The method
Koha::Account::Offsets->debit is not covered by tests!
Trace begun at /kohadevbox/koha/Koha/Objects.pm line 595
Koha::Objects::AUTOLOAD('Koha::Account::Offsets=HASH(0x561cbe2ac930)') called
at input text line 6
eval {...} at input text line 6
eval {...} at input text line 23
6. Apply this patch
7. Repeat 3
=> SUCCESS: It doesn't explode anymore!
8. Sign off :-D
Signed-off-by: Tomas Cohen Arazi
Signed-off-by: Andrew Fuerste-Henry
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29139] Paying gives ISE if UseEmailReceipts is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29139 Andrew Fuerste-Henry changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29140] Suppress some warnings in codemirror js editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29140 Nick Clemens changed: What|Removed |Added CC||k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29140] New: Suppress some warnings in codemirror js editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29140 Bug ID: 29140 Summary: Suppress some warnings in codemirror js editor Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com When editing user JS preferences there are warns for: 'let' is available in ES6 I think we could suppress these and allow that usage -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29139] Paying gives ISE if UseEmailReceipts is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29139
--- Comment #1 from Tomás Cohen Arazi ---
Created attachment 125463
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125463=edit
Bug 29139: $line->debit_offsets doesn't honor list context
Being based on _new_from_dbic (discussion on bug 28883), makes the
assignment incorrect:
my @account_offsets = $payment->debit_offsets;
This patch explicitly makes the resultset be assigned as a list by
calling *as_list*.
To test:
1. Have UseEmailReceipts disabled
2. Have a patron with a debt of 6
3. Make a payment of 2
=> SUCCESS: All good
4. Enable UseEmailReceipts
5. Repeat 3
=> FAIL: You get something like:
ERROR PROCESSING TEMPLATE: undef error - The method
Koha::Account::Offsets->debit is not covered by tests!
Trace begun at /kohadevbox/koha/Koha/Objects.pm line 595
Koha::Objects::AUTOLOAD('Koha::Account::Offsets=HASH(0x561cbe2ac930)') called
at input text line 6
eval {...} at input text line 6
eval {...} at input text line 23
6. Apply this patch
7. Repeat 3
=> SUCCESS: It doesn't explode anymore!
8. Sign off :-D
Signed-off-by: Tomas Cohen Arazi
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29139] Paying gives ISE if UseEmailReceipts is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29139 Tomás Cohen Arazi changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29138] LoadSearchHistoryToTheFirstLoggedUser should save 0 instead of "no"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29138 Andrew Fuerste-Henry changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |and...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29138] LoadSearchHistoryToTheFirstLoggedUser should save 0 instead of "no"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29138 --- Comment #1 from Andrew Fuerste-Henry --- Created attachment 125462 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125462=edit Bug 29138: Use zero instead of no in LoadSearchHistoryToTheFirstLoggedUser To test: - apply patch - set LoadSearchHistoryToTheFirstLoggedUser to 'Don't add' - confirm via sql that value=0 - confirm on OPAC that search history is not loaded to account on login -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29138] LoadSearchHistoryToTheFirstLoggedUser should save 0 instead of "no"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29138 Andrew Fuerste-Henry changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28883] Koha::Objects->_new_from_dbic doesn't work correctly in list context
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28883 Tomás Cohen Arazi changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=29139 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29139] Paying gives ISE if UseEmailReceipts is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29139 Tomás Cohen Arazi changed: What|Removed |Added Status|NEW |ASSIGNED See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=28883 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29139] Paying gives ISE if UseEmailReceipts is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29139 Tomás Cohen Arazi changed: What|Removed |Added CC||and...@bywatersolutions.com ||, l...@bywatersolutions.com, ||martin.renvoize@ptfs-europe ||.com Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29139] New: Paying gives ISE if UseEmailReceipts is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29139
Bug ID: 29139
Summary: Paying gives ISE if UseEmailReceipts is enabled
Change sponsored?: ---
Product: Koha
Version: unspecified
Hardware: All
OS: All
Status: NEW
Severity: major
Priority: P5 - low
Component: Architecture, internals, and plumbing
Assignee: koha-bugs@lists.koha-community.org
Reporter: tomasco...@gmail.com
QA Contact: testo...@bugs.koha-community.org
To reproduce:
1. Have UseEmailReceipts disabled
2. Have a patron with a debt of 4
3. Make a payment of 2
=> SUCCESS: All good
4. Enable UseEmailReceipts
5. Repeat 3
=> FAIL: You get something like:
ERROR PROCESSING TEMPLATE: undef error - The method
Koha::Account::Offsets->debit is not covered by tests!
Trace begun at /kohadevbox/koha/Koha/Objects.pm line 595
Koha::Objects::AUTOLOAD('Koha::Account::Offsets=HASH(0x561cbe2ac930)') called
at input text line 6
eval {...} at input text line 6
eval {...} at input text line 23
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29138] New: LoadSearchHistoryToTheFirstLoggedUser should save 0 instead of "no"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29138 Bug ID: 29138 Summary: LoadSearchHistoryToTheFirstLoggedUser should save 0 instead of "no" Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching Assignee: koha-bugs@lists.koha-community.org Reporter: and...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org The syspref LoadSearchHistoryToTheFirstLoggedUser saves a 1 when turned on, but a "no" when turned off. It should be a 0 when turned off. When a "no" is saved, the syspref behaves as if it's turned on. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11723] Message "A refund has been applied" on all lost item returns
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11723 Donna changed: What|Removed |Added CC||bwsdo...@gmail.com --- Comment #7 from Donna --- This is still an issue, and with the changes to refund options, it is even more confusing. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29137] Unwanted to authorised values are too easily created via the cataloging module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29137 Margaret Hade changed: What|Removed |Added CC||margaret@bywatersolutions.c ||om -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29137] Unwanted to authorised values are too easily created via the cataloging module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29137 --- Comment #2 from Katrin Fischer --- Have you looked into removing the authorised values managing permission? I think it would be consequential, if you don't want people to add auth values to not allow it in another spot. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29137] Unwanted to authorised values are too easily created via the cataloging module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29137 --- Comment #1 from Andrew Fuerste-Henry --- part of this issue was resolved by bug 29030. But we absolutely need a way for this to be turned off entirely. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29030] Problems introduced by bug 25728
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29030 Margaret Hade changed: What|Removed |Added CC||margaret@bywatersolutions.c ||om -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25728] Add the ability to create a new authorised value within the cataloguing module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25728 Andrew Fuerste-Henry changed: What|Removed |Added Blocks||29137 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29137 [Bug 29137] Unwanted to authorised values are too easily created via the cataloging module -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29137] New: Unwanted to authorised values are too easily created via the cataloging module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29137 Bug ID: 29137 Summary: Unwanted to authorised values are too easily created via the cataloging module Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: and...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl Depends on: 25728 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25728#c50 "I don't like this patch at all! After just a few weeks we have dozens of new locations created by mistake, like HORS, FICT, NON-FI , Staff type just the first letters of a location and then hit enter, and voila, there is a new location! Please make a syspref for this, and make it disabled by default - or set it as a permission that could be turned off, even for superlibrarians" I very much agree with Klas here. This makes to much much too easy to create authorised values in error. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25728 [Bug 25728] Add the ability to create a new authorised value within the cataloguing module -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29136] Patron search on request.pl has performance and display issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29136 Andrew Fuerste-Henry changed: What|Removed |Added CC||and...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29136] New: Patron search on request.pl has performance and display issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29136 Bug ID: 29136 Summary: Patron search on request.pl has performance and display issues Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com Similar to bug 15812, the patron search on request.pl retrieves all patrons from a search without pagination, so broad searches can have poor performance. Additionally, the datatables call on that page doesn't paginate, so all but the first 20 results are unavailable -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29135] OAI should not include biblionumbers from deleteditems when determining deletedbiblios
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29135 Nick Clemens changed: What|Removed |Added Keywords||rel_21_11_candidate CC||jonathan.druart+koha@gmail. ||com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27584] Improve OAI-PMH provider performance
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27584 Nick Clemens changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=29135 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29135] OAI should not include biblionumbers from deleteditems when determining deletedbiblios
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29135 Nick Clemens changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=27584 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29135] New: OAI should not include biblionumbers from deleteditems when determining deletedbiblios
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29135
Bug ID: 29135
Summary: OAI should not include biblionumbers from deleteditems
when determining deletedbiblios
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: major
Priority: P5 - low
Component: Architecture, internals, and plumbing
Assignee: koha-bugs@lists.koha-community.org
Reporter: n...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
When including items in OAI we add the biblionumbers of deleted items into the
deleted list
This is from this line:
93 if ( $include_items ) {
94 $sql = "($sql) UNION (SELECT DISTINCT(biblionumber) FROM
deleteditems $criteria)";
95 push @bind_params, @part_bind_params;
This is wrong because deletion of a single item does not indicate a record is
deleted
To recreate:
1 - Create /var/lib/koha/kohadev/OAI.yaml with:
format:
marcxml:
metadataPrefix: marcxml
metadataNamespace: http://www.loc.gov/MARC21/slim
http://www.loc.gov/standards/marcxml/schema/MARC21slim
schema: http://www.loc.gov/MARC21/slim
http://www.loc.gov/standards/marcxml/schema/MARC21slim.xsd
include_items: 1
2 - Set OAI-PMH:ConfFile to '/var/lib/koha/kohadev/OAI.yaml'
3 - Delete an item from a record
4 - View the page:
http://localhost:8080/cgi-bin/koha/oai.pl?verb=ListRecords=marcxml
5 - Note the record is now listed as deleted
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29133] Wrong string format in select2.inc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29133 Martin Renvoize changed: What|Removed |Added CC||bgkrie...@gmail.com, ||katrin.fisc...@bsz-bw.de, ||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29134] Patron search has poor performance when ExtendedAttributes enabled and many attributes match
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29134 --- Comment #4 from Nick Clemens --- (In reply to Jonathan Druart from comment #3) > (In reply to Jonathan Druart from comment #2) > > Created attachment 125453 [details] [review] [review] > > Bug 29134: [ALTERNATIVE patch] Keep filter_by_attribute_value > > > > And build the IN using the existing @matching_borrowernumbers. > > We have a method for that, we should not use raw SQL. > > ~600-700ms with Nick's patch > 22s on master > ~600-700ms with this alternative patch. At 500k patrons with 100k attributes the alternate is a bit slower The query can still be large (caharacter count) with the IN, and requires 2 db calls, one for filter_borrowers_by_attribute, another to search the borrower DV Moving to Objects is nice, but I think pure SQL here makes more sense than mixing the two - I opened bug 29125 to remove all the SQL here -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29133] Wrong string format in select2.inc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29133 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Status|Needs Signoff |Signed Off --- Comment #4 from Martin Renvoize --- Followup was required.. but feel free to squash it. Signing off as all cases now work as expected. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29133] Wrong string format in select2.inc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29133 --- Comment #3 from Martin Renvoize --- Created attachment 125461 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125461=edit Bug 29133: (follow-up) Fix for arguament mismatch Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29133] Wrong string format in select2.inc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29133 Martin Renvoize changed: What|Removed |Added Attachment #125445|0 |1 is obsolete|| --- Comment #2 from Martin Renvoize --- Created attachment 125460 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125460=edit Bug 29133: Correct select2 strings We are using 'max'/'min' when the arguments are 'maximum'/'minimum'. Also using %n, %d when only %s is working in .format() Have a look at https://github.com/select2/select2/blob/45f2b83ceed5231afa7b3d5b12b58ad335edd82e/src/js/select2/i18n/en.js It's Select2 v.4.0.13, the one we are using. We should match what's there. Test plan: Bug 29002 is using minimumInputLength, you can see the difference when selecting a patron: "Please enter %s or more characters" vs "Please enter 3 or more characters" Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27032] CanBookBeRenewed is not understandable and needs refactoring
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27032 Joonas Kylmälä changed: What|Removed |Added CC||joonas.kylm...@iki.fi --- Comment #16 from Joonas Kylmälä --- (In reply to Jonathan Druart from comment #15) > Joonas, don't you think we should have the same return than CanBookBeRenewed? > > ($boolean, $reason); > > The 'return "no";' seems weird to me. > > We could then replace: > > $auto_renew = _CanBookBeAutoRenewed($borrowernumber, $itemnumber); > return ( 0, $auto_renew ) if $auto_renew =~ 'auto_account_expired'; > return ( 0, $auto_renew ) if $auto_renew =~ 'auto_too_late'; > return ( 0, $auto_renew ) if $auto_renew =~ 'auto_too_much_oweing'; > > with: > > my ( $can_be_auto_renewed, $reason ) = > _CanBookBeAutoRenewed($borrowernumber, $itemnumber); > return ( 0, $reason ) unless $can_be_auto_renewed; This is a good plan but I purposefully left it out from this refactoring because we would have to touch the code in the bottom of CanBookBeRenewed() where there is the cron section doing magic with "$auto_renew =~ 'too_soon'" or alternatively make _CanBookBeAutoRenewed return 1 for "too_soon". It was too big of a task for me to verify the correctness of the code and given Circulation.pm module is frequently changed I didn't want to have to do it again due to a merge conflict so I decided to do that work after the code is merged. Currently this was simply just copy of the existing code with variable assignments changed to returns. Having the auto renew code now in a separate function I can start doing more changes to it without having to worry about it merge conflicting and having to start tedious verification process for correct logic again. Also clarifying the return "no" since you mentioned it: it is to keep intact the > my $auto_renew = "no"; value assigned in the beginning of CanBookBeRenewed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29002] Add ability to book items ahead of time
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 --- Comment #6 from Martin Renvoize --- Lots more to do.. but the basics of creating a booking and being able to see the bookings for a biblio are now there.. Next steps... 1) Either add bookings to the 'Holds to pull' page or add a now 'Bookings to collect' page 2) Integrate booking fulfilment into circulation -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29002] Add ability to book items ahead of time
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 --- Comment #5 from Martin Renvoize --- Created attachment 125459 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125459=edit Bug 29002: Add ability to book material This patch introduces a new modal to the biblio details page to allow booking of materials. Test plan 1) Navigate to the details page of a biblio 2) Note the new 'Place booking' button in the toolbar 3) Click the new button and note the new modal dialogue 4) Enter part of a patron name or cardnumber and then select from the presented results 5) Select a start date and end date from the calender 6) Submit -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29002] Add ability to book items ahead of time
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 --- Comment #4 from Martin Renvoize --- Created attachment 125458 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125458=edit Bug 29002: Add Booking objects and API classes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29002] Add ability to book items ahead of time
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 --- Comment #3 from Martin Renvoize --- Created attachment 125457 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125457=edit Bug 29002: DBIC Schema Build -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29002] Add ability to book items ahead of time
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 --- Comment #2 from Martin Renvoize --- Created attachment 125456 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125456=edit Bug 29002: Add bookings table to kohastructure -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20058] Option to use shelving location instead of homebranch for sorting
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20058 David Gustafsson changed: What|Removed |Added Attachment #125366|0 |1 is obsolete|| --- Comment #9 from David Gustafsson --- Created attachment 125455 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125455=edit Bug 20058: Add tests -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20058] Option to use shelving location instead of homebranch for sorting
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20058 David Gustafsson changed: What|Removed |Added Attachment #125364|0 |1 is obsolete|| --- Comment #8 from David Gustafsson --- Created attachment 125454 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125454=edit Bug 20058: Add option to send permanent_location as AQ in SIP response -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20058] Option to use shelving location instead of homebranch for sorting
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20058 --- Comment #7 from David Gustafsson --- Yes! Will fix this. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29131] Row striping breaks color coding on item circulation alerts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29131 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29125] Use Koha::Patron object in C4:Utils::DataTables::Members.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29125 Jonathan Druart changed: What|Removed |Added CC||jonathan.druart+koha@gmail. ||com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28919] When placing a multi-hold from results in staff pickup location is empty
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28919 --- Comment #6 from Jonathan Druart --- (In reply to Katrin Fischer from comment #5) > I am sorry, I tried "restart_all" multiple times, but the pull downs remain > empty. > > I am using the admin user (42), logged in at Centerville. > > When placing a single hold, Centerville is selected. The pull down from the top, the "Pickup at:"? https://snipboard.io/pRHAMn.jpg -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29134] Patron search has poor performance when ExtendedAttributes enabled and many attributes match
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29134 Jonathan Druart changed: What|Removed |Added CC||jonathan.druart+koha@gmail. ||com --- Comment #3 from Jonathan Druart --- (In reply to Jonathan Druart from comment #2) > Created attachment 125453 [details] [review] > Bug 29134: [ALTERNATIVE patch] Keep filter_by_attribute_value > > And build the IN using the existing @matching_borrowernumbers. > We have a method for that, we should not use raw SQL. ~600-700ms with Nick's patch 22s on master ~600-700ms with this alternative patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29134] Patron search has poor performance when ExtendedAttributes enabled and many attributes match
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29134 --- Comment #2 from Jonathan Druart --- Created attachment 125453 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125453=edit Bug 29134: [ALTERNATIVE patch] Keep filter_by_attribute_value And build the IN using the existing @matching_borrowernumbers. We have a method for that, we should not use raw SQL. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28821] OPAC Advanced search: Improve operation of button plus/less
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28821 --- Comment #9 from Marcel de Rooy --- Created attachment 125452 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125452=edit Bug 28821: (QA follow-up) Adjust javascript test The test did not work when SearchEngine == Elasticsearch. Test plan: Verify if it works now for Elasticsearch. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28821] OPAC Advanced search: Improve operation of button plus/less
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28821 Marcel de Rooy changed: What|Removed |Added Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15812] Checkout search with too many results (single character search) causes poor performance or timeout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812 Nick Clemens changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=29134 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29134] Patron search has poor performance when ExtendedAttributes enabled and many attributes match
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29134 Nick Clemens changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=15812 Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29134] Patron search has poor performance when ExtendedAttributes enabled and many attributes match
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29134 --- Comment #1 from Nick Clemens --- Created attachment 125451 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125451=edit Bug 29134: Use a subquery to increase performance of patron attributes search This patch generates a subquery and checks if a borrowrnumber is in the results to add patrons to search results To test: 1 - Generate a bunch of patrons: SELECT surname, firstname, branchcode, categorycode FROM ( SELECT surname FROM borrowers ORDER BY rand() ) a,( SELECT firstname FROM borrowers ORDER BY rand() ) b,( SELECT branchcode FROM borrowers ORDER BY rand() ) c,( SELECT categorycode FROM borrowers ORDER BY rand() ) d LIMIT 5 2 - Add a patron attribute to the system and make it searchable - I used code 'TEST' 3 - Add a value for this attribute to many patrons: INSERT INTO borrower_attributes (borrowernumber,code,attribute) SELECT borrowernumber, 'TEST','alphabet' FROM borrowers LIMIT 1; 4 - In staff client got 'Patrons' 5 - Open the browser console (F12) and view the netwrok tab 6 - Perform a patron search for 'a' 7 - Note the time it takes for 'search' to complete in console 8 - Apply patch, restart_all 9 - Repeat search 10 - Note it is much faster 11 - prove -v t/db_dependent/Utils/Datatables_Members.t NOTE: I tested with 500k patrons and 100k attributes - search returned in ~2 seconds with patch and did not return before I got impatient without patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29134] Patron search has poor performance when ExtendedAttributes enabled and many attributes match
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29134 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28821] OPAC Advanced search: Improve operation of button plus/less
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28821 --- Comment #8 from Jonathan Druart --- From IRC: 14:29 < Joubu> marcelr: ok, got it. I am using ES and I am seeing a " Apply field weights to search " checkox 14:29 < Joubu> it's a sibling 14:30 < Joubu> it indeed works correctly with searchengine=zebra -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29134] New: Patron search has poor performance when ExtendedAttributes enabled and many attributes match
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29134
Bug ID: 29134
Summary: Patron search has poor performance when
ExtendedAttributes enabled and many attributes match
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: major
Priority: P5 - low
Component: Architecture, internals, and plumbing
Assignee: koha-bugs@lists.koha-community.org
Reporter: n...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
When system preference ExtendedPatronAttributes is enabled the patron search
finds all patrons with a matching attribute and builds a where string with all
the borrowernumbers concatted into an 'IN'
my @matching_borrowernumbers =
Koha::Patrons->filter_by_attribute_value($searchmember)->get_column('borrowernumber');
for my $borrowernumber ( @matching_borrowernumbers ) {
push @where_strs_or, "borrowers.borrowernumber = ?";
push @where_args, $borrowernumber;
}
When there are too many matches on a system with many patrons/attributes this
generates a very large query which takes a very long time to return
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28673] An encoded ampersand missing the ampersand
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28673 --- Comment #5 from Marcel de Rooy --- Applies on 20.11 with me. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29093] Article requests: Checkbox for table of contents
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29093 --- Comment #12 from Marcel de Rooy --- Created attachment 125450 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125450=edit Bug 29093: (QA follow-up) Adding two hover texts See QA request. Adding TOC hover text to: - OPAC user page, tab Article requests - Patron details page, Check out, tab Article requests Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29093] Article requests: Checkbox for table of contents
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29093 --- Comment #11 from Marcel de Rooy --- (In reply to Nick Clemens from comment #10) Thanks ! > A few things to mention, not blockers: > 1 - The DBIC patch includes changes from other bugs, I had to generate my > own for testing Yes, sorry for that. But the RM will disregard it anyway and do a fresh DBIx update. > 2 - Why TINYINT(4) - it seems to be treated as a TINYINT(1) / Boolean? Tinyint is just a byte. The four positions is display width and actually irrelevant for our templates. But theoretically, you are right :) > 3 - While it makes display easier, is TOC friendly for translations? It > would be nice to have a hover text with the full 'Table of Contents' at least Good point. Will have a look. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29093] Article requests: Checkbox for table of contents
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29093 --- Comment #10 from Nick Clemens --- A few things to mention, not blockers: 1 - The DBIC patch includes changes from other bugs, I had to generate my own for testing 2 - Why TINYINT(4) - it seems to be treated as a TINYINT(1) / Boolean? 3 - While it makes display easier, is TOC friendly for translations? It would be nice to have a hover text with the full 'Table of Contents' at least -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29093] Article requests: Checkbox for table of contents
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29093 --- Comment #9 from Nick Clemens --- Created attachment 125449 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125449=edit Bug 29093: Interface changes Show the TOC checkbox on OPAC and staff. Test plan: Add new article request on OPAC or staff. Tick checkbox. Verify if TOC is Yes on opac-user or staff patron details. Check the list view on circ/article-requests.pl. Signed-off-by: Marcel de Rooy Signed-off-by: David Nind Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29093] Article requests: Checkbox for table of contents
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29093 Nick Clemens changed: What|Removed |Added Attachment #125288|0 |1 is obsolete|| Attachment #125290|0 |1 is obsolete|| --- Comment #8 from Nick Clemens --- Created attachment 125448 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125448=edit Bug 29093: Database revision for article_requests.toc_request Test plan: Run dbrev or new install. Signed-off-by: Marcel de Rooy Signed-off-by: David Nind Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29093] Article requests: Checkbox for table of contents
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29093 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28821] OPAC Advanced search: Improve operation of button plus/less
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28821
--- Comment #7 from Marcel de Rooy ---
(In reply to Jonathan Druart from comment #6)
> I can remove the 3 lines. That's why it was done that way. You certainly
> need JS code to prevent that.
+if($(this).parent().parent().siblings().length < 2 ) {
$('.ButtonLess').hide();
Please explain how to reproduce.
Or refresh browser cache etc ?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 Kyle M Hall changed: What|Removed |Added Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 --- Comment #101 from Kyle M Hall --- Created attachment 125447 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125447=edit Bug 26351: Revert improper change to unit test, fix number of tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29030] Problems introduced by bug 25728
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29030 --- Comment #8 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29030] Problems introduced by bug 25728
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29030 Jonathan Druart changed: What|Removed |Added Version(s)||21.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28937] Use Flatpickr on circulation and patron pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28937 --- Comment #14 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28937] Use Flatpickr on circulation and patron pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28937 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||21.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
