[Koha-bugs] [Bug 28734] Koha::Biblio->get_marc_notes should parse authorised values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28734 Aleisha Amohia changed: What|Removed |Added Summary|Koha::Biblio->get_marc_note |Koha::Biblio->get_marc_note |s should use|s should parse authorised |XSLTParse4Display |values -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28734] Koha::Biblio->get_marc_notes should use XSLTParse4Display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28734 --- Comment #9 from Aleisha Amohia --- Created attachment 125575 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125575=edit Bug 28734: (follow-up) Use transformMARCXML4XSLT and tests Confirm the following tests pass: - t/db_dependent/Koha/Biblio.t - t/db_dependent/XSLT.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28734] Koha::Biblio->get_marc_notes should use XSLTParse4Display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28734 Aleisha Amohia changed: What|Removed |Added Attachment #124231|0 |1 is obsolete|| --- Comment #8 from Aleisha Amohia --- Created attachment 125574 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125574=edit Bug 28734: Parse display in $biblio->get_marc_notes 1. Go to Koha Administration, MARC bibliographic frameworks 2. Edit a framework, find tag 590, edit the $z subfield to use an authorised value. 3. Do a catalogue search and edit a record using this framework. Edit 590$z and select an authorised value. Save the record. 4. Add the record to your cart. 5. View your cart. Click More Details. 6. Scroll down to the Notes section. Notice the authorised value code is displayed instead of the description. 7. Apply the patch, restart services. 8. Refresh your cart. Click More Details again if you need to. 9. Scroll down to the Notes section. The description of the authorised value should now be displayed. Sponsored-by: Catalyst IT Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28734] Koha::Biblio->get_marc_notes should use XSLTParse4Display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28734 Aleisha Amohia changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29148] Holds to Pull doesn't reflect item-level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29148 Azucena Aguayo changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29148] Holds to Pull doesn't reflect item-level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29148 sandbo...@biblibre.com changed: What|Removed |Added Attachment #125572|0 |1 is obsolete|| --- Comment #5 from sandbo...@biblibre.com --- Created attachment 125573 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125573=edit Bug 29148: Check if hold is item or bib level To test: 1 - place an item level hold, it says: [one of the barcodes] or any available 2 - place a bib level hold, it says: [one of the barcodes] or any available 3 - Apply patch 4 - item level hold should say: Only [barcode] 5 - bib level hold should say: [one of the barcodes] or any available Signed-off-by: Azucena -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29148] Holds to Pull doesn't reflect item-level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29148 Andrew Fuerste-Henry changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |lu...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29148] Holds to Pull doesn't reflect item-level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29148 Lucas Gass changed: What|Removed |Added Attachment #125566|0 |1 is obsolete|| --- Comment #4 from Lucas Gass --- Created attachment 125572 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125572=edit Bug 29148: Check if hold is item or bib level To test: 1 - place an item level hold, it says: [one of the barcodes] or any available 2 - place a bib level hold, it says: [one of the barcodes] or any available 3 - Apply patch 4 - item level hold should say: Only [barcode] 5 - bib level hold should say: [one of the barcodes] or any available -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29148] Holds to Pull doesn't reflect item-level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29148 Lucas Gass changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24488] Holds to Pull sometimes shows the wrong 'first patron' details
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24488 Lucas Gass changed: What|Removed |Added Blocks||29148 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29148 [Bug 29148] Holds to Pull doesn't reflect item-level holds -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29148] Holds to Pull doesn't reflect item-level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29148 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com Depends on||24488 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24488 [Bug 24488] Holds to Pull sometimes shows the wrong 'first patron' details -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15812] Checkout search with too many results (single character search) causes poor performance or timeout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812 --- Comment #12 from Fridolin Somers --- Super, permission is OK now. (In reply to Fridolin Somers from comment #6) > Note than cardnumber column may be hidden. > Isn't that a problem ? Also for consistency, everywhere in tables buttons are in actions column. But it is minor. It is a great change. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 --- Comment #85 from Tomás Cohen Arazi --- Created attachment 125571 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125571=edit Bug 27945: (QA follow-up) Validate the input in the form Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945
--- Comment #84 from Tomás Cohen Arazi ---
(In reply to Jonathan Druart from comment #81)
> 3.
>
> +if ($article_request_limit ne '' && $article_request_limit !~ /^\d+$/) {
> +push @messages, {type => 'error', code =>
> 'article_request_numeric_limit' };
> +$op = 'add_form';
> +} elsif ($article_request_limit ne '' && $article_request_limit < 0) {
> +push @messages, {type => 'error', code =>
> 'article_request_negative_limit' };
> +$op = 'add_form';
> +} else {
>
> Why that?
> I am expecting to see a JS validation and an exception raised in
> Koha::Category->store. But not in the controller.
Is this a blocker for inclusion?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29148] Holds to Pull doesn't reflect item-level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29148 Andrew Fuerste-Henry changed: What|Removed |Added Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29062] Patron check-in slip repeats data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29062 Lisette Scheer changed: What|Removed |Added CC||lisettesla...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13376] Include a user-editable area/page for terms and conditions of use in the opac
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13376 Lisette Scheer changed: What|Removed |Added CC||lisettesla...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18543] Emails for new patron accounts with the AutoEmailOpacUser preference require to enter password manually
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18543 Lisette Scheer changed: What|Removed |Added CC||lisettesla...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14771] Allow patrons to pick a username
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14771 Lisette Scheer changed: What|Removed |Added CC||lisettesla...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9097] 'Welcome mail' for new library users
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9097 Lisette Scheer changed: What|Removed |Added CC||lisettesla...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29148] Holds to Pull doesn't reflect item-level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29148 Azucena Aguayo changed: What|Removed |Added CC||azucena.agu...@uvu.edu --- Comment #3 from Azucena Aguayo --- Patch solves the item-level hold issue. However, patch breaks title-level hold barcode display. To test: - have an 2 records with multiple copies - place an item-level hold on one of the copies for record A - place a title-level hold for record B - go to Holds to Pull (/cgi-bin/koha/circ/pendingreserves.pl) - confirm it shows "only barcode" on BOTH holds when it should show specifically the barcode of one item on the hold for record A, but show the same on the title hold for record B. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29135] OAI should not include biblionumbers from deleteditems when determining deletedbiblios
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29135 --- Comment #6 from Ere Maijala --- This should fix the issues. I haven't had a chance to manually test much yet, but at least the tests added failed miserably without the changes. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29135] OAI should not include biblionumbers from deleteditems when determining deletedbiblios
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29135 --- Comment #5 from Ere Maijala --- Created attachment 125570 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125570=edit Bug 29135: Fix handling of deleted items in OAI-PMH provider Test plan: 1. Make sure this scenario now works properly: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29135#c0 2. Run prove -v t/db_dependent/OAI/ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29135] OAI should not include biblionumbers from deleteditems when determining deletedbiblios
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29135 Ere Maijala changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29137] Unwanted authorised values are too easily created via the cataloging module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29137 Jason Vasche changed: What|Removed |Added CC||jvas...@roundrocktexas.gov --- Comment #12 from Jason Vasche --- Joy described my (and my RRPL colleagues') need for efficiency in cataloging workflow perfectly in comment 4. We would love to have a way to completely turn off AV creation in the cataloging module, thanks to all involved for patching this bug! *hides unlit torch behind back and whistles nonchalantly* -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11723] Message "A refund has been applied" on all lost item returns
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11723 Lisette Scheer changed: What|Removed |Added CC||lisettesla...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 --- Comment #83 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #81) > 1. +my $can_request = $borrower->can_request_article > $patron is better now Done. > 2. > +my $compdate = dt_from_string->add( days => -1 ); > I don't understand, what are we doing here? Can you add a line in the POD > about that? Done. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 --- Comment #82 from Tomás Cohen Arazi --- Created attachment 125569 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125569=edit Bug 27945: (QA follow-up) Clarify behavior in POD Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29134] Patron search has poor performance when ExtendedAttributes enabled and many attributes match
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29134 --- Comment #10 from David Nind --- (In reply to Nick Clemens from comment #6) > (In reply to David Nind from comment #5) .. > That was a typo, it should be:" > INSERT into borrowers(surname, firstname, branchcode, categorycode) SELECT > surname, firstname, branchcode, categorycode FROM ( SELECT surname FROM > borrowers ORDER BY rand() ) a,( SELECT firstname FROM borrowers ORDER BY > rand() ) b,( SELECT branchcode FROM borrowers ORDER BY rand() ) c,( SELECT > categorycode FROM borrowers ORDER BY rand() ) d LIMIT 5 Thanks Nick - now works as expected, and was able to test. Before patch applied (koha-testing-docker): 19.71 s After: 1.81 s -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27944] Add new stages to the article request process
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 --- Comment #90 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #84) > 1. Missing POD in Koha::ArticleRequest Done. > 2. Koha::ArticleRequest->request is not covered by tests Done. > 3. Changes to Koha::ArticleRequest->cancel are not covered by tests Done. > 4. Koha::ArticleRequests->requested is not covered by tests Done. > 4. Not a big deal (not blocker of course) but > $reason = $av->lib_opac ? $av->lib_opac : $av->lib if $av; > Is more readable (IMO) like: > $reason = $av->lib_opac || $av->lib if $av; This is another bug, will fix in the right place. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29134] Patron search has poor performance when ExtendedAttributes enabled and many attributes match
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29134 David Nind changed: What|Removed |Added Attachment #125451|0 |1 is obsolete|| --- Comment #9 from David Nind --- Created attachment 125568 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125568=edit Bug 29134: Use a subquery to increase performance of patron attributes search This patch generates a subquery and checks if a borrowrnumber is in the results to add patrons to search results To test: 1 - Generate a bunch of patrons: SELECT surname, firstname, branchcode, categorycode FROM ( SELECT surname FROM borrowers ORDER BY rand() ) a,( SELECT firstname FROM borrowers ORDER BY rand() ) b,( SELECT branchcode FROM borrowers ORDER BY rand() ) c,( SELECT categorycode FROM borrowers ORDER BY rand() ) d LIMIT 5 2 - Add a patron attribute to the system and make it searchable - I used code 'TEST' 3 - Add a value for this attribute to many patrons: INSERT INTO borrower_attributes (borrowernumber,code,attribute) SELECT borrowernumber, 'TEST','alphabet' FROM borrowers LIMIT 1; 4 - In staff client got 'Patrons' 5 - Open the browser console (F12) and view the netwrok tab 6 - Perform a patron search for 'a' 7 - Note the time it takes for 'search' to complete in console 8 - Apply patch, restart_all 9 - Repeat search 10 - Note it is much faster 11 - prove -v t/db_dependent/Utils/Datatables_Members.t NOTE: I tested with 500k patrons and 100k attributes - search returned in ~2 seconds with patch and did not return before I got impatient without patch Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29134] Patron search has poor performance when ExtendedAttributes enabled and many attributes match
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29134 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27944] Add new stages to the article request process
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 Tomás Cohen Arazi changed: What|Removed |Added Attachment #125565|0 |1 is obsolete|| --- Comment #89 from Tomás Cohen Arazi --- Created attachment 125567 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125567=edit Bug 27944: Add missing tests Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26646] Holds to Pull should show distinct item-level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26646 Andrew Fuerste-Henry changed: What|Removed |Added Status|ASSIGNED|NEW -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29148] Holds to Pull doesn't reflect item-level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29148 --- Comment #2 from Andrew Fuerste-Henry --- I'm honestly not sure why the existing code started to fail here, but I changed it to check for item_level_hold=1, rather than presence of an itemnumber. It seems like a more reliable check anyway. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29148] Holds to Pull doesn't reflect item-level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29148 --- Comment #1 from Andrew Fuerste-Henry --- Created attachment 125566 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125566=edit Bug 29148: Check reserves.item_level_hold in Holds to Pull To test: 1 - place an item level hold 2 - go to Holds to Pull, see it shows "[barcode] or any available" 3- apply patch, restart 4- reload Holds to Pull, see it shows "only [barcode]" -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29148] Holds to Pull doesn't reflect item-level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29148 Andrew Fuerste-Henry changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29148] New: Holds to Pull doesn't reflect item-level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29148 Bug ID: 29148 Summary: Holds to Pull doesn't reflect item-level holds Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: and...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com To test: - have an item with multiple copies - place an item-level hold on one of the copies - go to Holds to Pull (/cgi-bin/koha/circ/pendingreserves.pl) - confirm it shows "[one of the barcodes] or any available" when it should show specifically the barcode of the item on which your hold was placed and should not show "or any available" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26949] Upgrade TinyMCE in the staff interface from 5.0.16 to 5.9.2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26949 David Nind changed: What|Removed |Added Summary|Upgrade TinyMCE in the |Upgrade TinyMCE in the |staff interface from 5.0.16 |staff interface from 5.0.16 |to 5.5.1|to 5.9.2 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29135] OAI should not include biblionumbers from deleteditems when determining deletedbiblios
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29135 --- Comment #4 from Ere Maijala --- And yes, you're both right about the deleted records. I had missed the most logical shortcut that a deleted biblio can't have items deleted later. I think I have a fix which mostly just makes things more simple, but I'm still working on adding tests to cover all cases. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27944] Add new stages to the article request process
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 Tomás Cohen Arazi changed: What|Removed |Added Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27944] Add new stages to the article request process
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 --- Comment #88 from Tomás Cohen Arazi --- Created attachment 125565 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125565=edit Bug 27944: Add missing tests Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28988] Reindent calendar template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28988 --- Comment #9 from Owen Leonard --- (In reply to Jonathan Druart from comment #8) > Unfortunately there are several accessibility patches in the queue currently > that are modifying this template. I've tried to move Bug 27631 along (Accessibility: Staff Client - on each page is Logo but should be page description/title). I rebased and signed off on the existing patches and submitted a follow-up that addresses the concerns which led me to mark it Failed QA. Other patches in that series don't apply anymore. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27877] Accessibility: Staff Client - Reduce heading redundancy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27877 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28243] Accessibility: Staff Client - add captions to tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28243 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27741] Accessibility: Staff Client - Headings should have correct tags and hierarchy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27741 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply --- Comment #39 from Owen Leonard --- I'm not sure if it was my rebase of Bug 27631 or something else, but this doesn't apply: Applying: Bug 27741: admin folder error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/admin/patron-attr-types.tt). error: could not build fake ancestor Patch failed at 0001 Bug 27741: admin folder -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 --- Comment #372 from David Gustafsson --- (In reply to Jonathan Druart from comment #369) > I've spent a lost of time on this patch set to make it part of 21.05. Added > follow-ups and written test. > > Then I had some questions, and didn't get the answers I needed to write the > missing bit. I was not asking anybody else to write anything. > > I wish I had people asking me to write follow-up for my patches.. Sorry I missed some of those questions (i for some reason read comment 221-333 so I was not referring to you regarding requesting new features). Regarding the question in comment 324: > 4. We need a wiki page, or at least more info/examples for the release notes. There is only 2 very succinct example in the test plan but the feature allows much more. I have written a manual entry, it might now be partly out dated since it was 2 years ago, there are some links to it further up in the thread: https://gitlab.com/gnucifer/koha-manual/-/commit/eb07dd1abcb357de27d294cee49c287c6f5bfe6c The reason I pointed out that we have been running this in production for a long time is that there appears to be great hesitancy in merging this which is understandable due to the large surface area of changes and and relative high complexity. That serious bugs could lurk is not impossible, but is highly unlikely as we would probably have encountered them by now. There are for example certain contexts that we do not use, like batchmod, z3950 and import_lexile, but it can be good to know that the core functionality appears to be pretty solid. The scariest part of this by far is the potential for unexpected data loss or corruption when records are taken apart and put back together again, and that part appears to be solid. As a side note I don't really get why MergeRules were renamed to OverlayRules, it's not that much worse than merge, but is it really better? To me merge is more intuitive as we basically have to revisions of a record and use certain rules to resolve the diff, merging the two. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27631] Accessibility: Staff Client - on each page is Logo but should be page description/title
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 Owen Leonard changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27944] Add new stages to the article request process
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 --- Comment #87 from Jonathan Druart --- Can be done on a follow-up bug, yes. But I will wait for the tests to push. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27631] Accessibility: Staff Client - on each page is Logo but should be page description/title
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 --- Comment #62 from Owen Leonard --- Created attachment 125564 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125564=edit Bug 27631: (follow-up) Some minor corrections This patch makes some corrections to issues found during testing: Some duplicate headings, a markup error in labeledMARCdetail.tt, a change of the transfers heading from "Branch transfers" to "Item transfers." This patch also undoes the changes to the position of the toolbar on several pages. I think those changes don't belong in this bug. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27631] Accessibility: Staff Client - on each page is Logo but should be page description/title
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 --- Comment #61 from Owen Leonard --- Created attachment 125563 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125563=edit Bug 27631: (follow-up) circ/branchtransfers.tt Changed file to have one tag showing that describes the page, rather than the around the logo. The hierarchy of other heading tags may be wrong, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to circ/branchtransfers and check that it has an obvious and descriptive heading 4) Ensure that the heading is Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27631] Accessibility: Staff Client - on each page is Logo but should be page description/title
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 --- Comment #60 from Owen Leonard --- Created attachment 125562 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125562=edit Bug 27631: (follow-up) reports/guided_reports_start.tt Changed file to have one tag showing that describes the page, rather than the around the logo. The hierarchy of other heading tags may be wrong, but this wil be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to reports/guided_reports_start and check that it has an obvious and descriptive heading 4) Ensure that the heading is Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27631] Accessibility: Staff Client - on each page is Logo but should be page description/title
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 --- Comment #59 from Owen Leonard --- Created attachment 125561 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125561=edit Bug 27631: (follow-up) tools/marc_modification_templates.tt Changed file to have one tag showing that describes the page, rather than the around the logo. The hierarchy of other heading tags may be wrong, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to tools/marc_modification_templates and check that it has an obvious and descriptive heading 4) Ensure that the heading is Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27631] Accessibility: Staff Client - on each page is Logo but should be page description/title
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 --- Comment #58 from Owen Leonard --- Created attachment 125560 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125560=edit Bug 27631: (follow-up) course_reserves/course-details.tt Changed file to have one tag showing that describes the page, rather than the around the logo. The hierarchy of other heading tags may be wrong, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to course_reserves/course-details and check that it has an obvious and descriptive heading 4) Ensure that the heading is Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27631] Accessibility: Staff Client - on each page is Logo but should be page description/title
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 --- Comment #57 from Owen Leonard --- Created attachment 125559 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125559=edit Bug 27631: admin folder Changed each of the pages in the admin folder to have one tag showing that describes the page, rather than the describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the admin folder and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27631] Accessibility: Staff Client - on each page is Logo but should be page description/title
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 --- Comment #56 from Owen Leonard --- Created attachment 125558 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125558=edit Bug 27631: Hidden on intranet-main.tt This patch visually hides a on intranet-main.tt so that the heading is available to be read out by screenreaders in the summary of headings on the page. Test plan: 1) Ensure the "Koha home" heading on the staff client main/home page is hidden visually, but in the source code you can see it Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27631] Accessibility: Staff Client - on each page is Logo but should be page description/title
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 --- Comment #55 from Owen Leonard --- Created attachment 125557 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125557=edit Bug 27631: acqui folder Changed each of the pages in the acqui folder to have one tag showing that describes the page, rather than the describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the acqui folder and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27631] Accessibility: Staff Client - on each page is Logo but should be page description/title
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 --- Comment #54 from Owen Leonard --- Created attachment 125556 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125556=edit Bug 27631: cataloguing folder Changed each of the pages in the cataloguing folder to have one tag showing that describes the page, rather than the describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the cataloguing folder and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27631] Accessibility: Staff Client - on each page is Logo but should be page description/title
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 --- Comment #53 from Owen Leonard --- Created attachment 12 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12=edit Bug 27631: reports and serials folders Changed each of the pages in the reports and serials folders to have one tag showing that describes the page, rather than the describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the reports and serials folders and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27631] Accessibility: Staff Client - on each page is Logo but should be page description/title
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 --- Comment #52 from Owen Leonard --- Created attachment 125554 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125554=edit Bug 27631: tools and virtualshelves folders Changed each of the pages in the tools and virtualshelves folders to have one tag showing that describes the page, rather than the describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the tools and virtualshelves folders and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27631] Accessibility: Staff Client - on each page is Logo but should be page description/title
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 --- Comment #51 from Owen Leonard --- Created attachment 125553 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125553=edit Bug 27631: catalogue and tags folders Changed each of the pages in the catalogue and tags folders to have one tag showing that describes the page, rather than the describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the catalogue and tags folders and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27631] Accessibility: Staff Client - on each page is Logo but should be page description/title
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 --- Comment #50 from Owen Leonard --- Created attachment 125552 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125552=edit Bug 27631: offline_circ, patroncards, plugins, pos, reserve, rotating_collections folders Changed each of the pages in the offline_circ, patroncards, plugins, pos, reserve, rotating_collections folders to have one tag showing that describes the page, rather than the describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the offline_circ, patroncards, plugins, pos, reserve, rotating_collections folders and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27631] Accessibility: Staff Client - on each page is Logo but should be page description/title
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 --- Comment #49 from Owen Leonard --- Created attachment 125551 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125551=edit Bug 27631: installer and onboarding folders Changed each of the pages in the installer and onboarding folders to have one tag showing that describes the page, rather than the describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Ensure that the page source shows logo inside and not inside 4) Go to each of the pages in the installer and onboarding folders and check that they have an obvious and descriptive heading 5) Ensure that the heading in the page is Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27631] Accessibility: Staff Client - on each page is Logo but should be page description/title
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 --- Comment #48 from Owen Leonard --- Created attachment 125550 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125550=edit Bug 27631: authorities, clubs, common, course_reserves folders Changed each of the pages in the authorities, clubs, common, course_reserves folders to have one tag showing that describes the page, rather than the describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the authorities, clubs, common, course_reserves folders and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27631] Accessibility: Staff Client - on each page is Logo but should be page description/title
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 --- Comment #47 from Owen Leonard --- Created attachment 125549 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125549=edit Bug 27631: labels and members folders Changed each of the pages in the labels and members folders to have one tag showing that describes the page, rather than the describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the labels and members folders and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27631] Accessibility: Staff Client - on each page is Logo but should be page description/title
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 --- Comment #46 from Owen Leonard --- Created attachment 125548 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125548=edit Bug 27631: circ folder Changed each of the pages in the circ folder to have one tag showing that describes the page, rather than the describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the circ folder and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27631] Accessibility: Staff Client - on each page is Logo but should be page description/title
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 Owen Leonard changed: What|Removed |Added Attachment #119830|0 |1 is obsolete|| Attachment #119832|0 |1 is obsolete|| Attachment #119834|0 |1 is obsolete|| Attachment #119835|0 |1 is obsolete|| Attachment #119836|0 |1 is obsolete|| Attachment #119837|0 |1 is obsolete|| Attachment #119838|0 |1 is obsolete|| Attachment #119839|0 |1 is obsolete|| Attachment #119840|0 |1 is obsolete|| Attachment #119841|0 |1 is obsolete|| Attachment #119842|0 |1 is obsolete|| Attachment #119843|0 |1 is obsolete|| Attachment #120191|0 |1 is obsolete|| Attachment #121469|0 |1 is obsolete|| Attachment #121470|0 |1 is obsolete|| Attachment #121522|0 |1 is obsolete|| Attachment #121559|0 |1 is obsolete|| --- Comment #45 from Owen Leonard --- Created attachment 125547 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125547=edit Bug 27631: Changed around logo to To test: 1) Look at Staff Client and the logo 2) Apply patch 3) Check Koha logo moves to the middle of the page when zooming in 4) Ensure page source shows logo inside and not Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27944] Add new stages to the article request process
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 --- Comment #86 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #84) > 1. Missing POD in Koha::ArticleRequest > > 2. Koha::ArticleRequest->request is not covered by tests > > 3. Changes to Koha::ArticleRequest->cancel are not covered by tests > > 4. Koha::ArticleRequests->requested is not covered by tests > > 4. Not a big deal (not blocker of course) but > $reason = $av->lib_opac ? $av->lib_opac : $av->lib if $av; > Is more readable (IMO) like: > $reason = $av->lib_opac || $av->lib if $av; Can this be pushed as is? I move the tests to another file in a later bug and can happily add tests. Some already exist on Article requests.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29137] Unwanted authorised values are too easily created via the cataloging module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29137 Nick Clemens changed: What|Removed |Added Attachment #125542|0 |1 is obsolete|| --- Comment #11 from Nick Clemens --- Created attachment 125546 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125546=edit Bug 29137: Add new syspref to disable AV creation within the cataloguing module "I don't like this patch at all!" "We will see a cataloger revolt if we do not find a way to make this optional for catalogers." I imagined a hord of catalogers running behind me and I got scared. This patch will allow to turn the new feature added by bug 25728 off. Test plan: Confirm that the new CreateAVFromCataloguing will permit to turn the feature off. Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29137] Unwanted authorised values are too easily created via the cataloging module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29137 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24387] Rename News tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24387 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com --- Comment #56 from Nick Clemens --- (In reply to Jonathan Druart from comment #54) > Created attachment 124867 [details] [review] > Bug 24387: Entries with parent are missing a code > > We executed the same 2 queries, we want to adjust the code for the > parent and the language specific row. (In reply to Nick Clemens from comment #55) > Created attachment 125545 [details] [review] > Bug 24387: Entries with parent are missing a code > > We executed the same 2 queries, we want to adjust the code for the > parent and the language specific row. > > Signed-off-by: Nick Clemens Read code, did not test, but the change makes logical sense -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24387] Rename News tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24387 Nick Clemens changed: What|Removed |Added Attachment #124867|0 |1 is obsolete|| --- Comment #55 from Nick Clemens --- Created attachment 125545 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125545=edit Bug 24387: Entries with parent are missing a code We executed the same 2 queries, we want to adjust the code for the parent and the language specific row. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 --- Comment #371 from David Gustafsson --- (In reply to Martin Renvoize from comment #370) > > I did forget about one thing though, that actually is a show-stopper, and > > that is if this bug is merged without the fix in bug 25539, this will > > trigger a bug with this current patch. I discovered that bug 25539 was set > > as depending on this bug when it should have been the other way around which > > I now fixed. > > Pretty sure we reversed the dependencies deliberately to unblock this.. we > disable this feature for use with bulkmarcimport in one of the patches. Yes, now I remember. I mistakenly misremembered the bug in bug 25539 appearing when saving using the staff interface. In that case there should be no blockers for this patch (with bulkmarcimport.pl disabled, which would be a show-stopper for us, but we would in case this got merged address with a local patch). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 --- Comment #370 from Martin Renvoize --- > I did forget about one thing though, that actually is a show-stopper, and > that is if this bug is merged without the fix in bug 25539, this will > trigger a bug with this current patch. I discovered that bug 25539 was set > as depending on this bug when it should have been the other way around which > I now fixed. Pretty sure we reversed the dependencies deliberately to unblock this.. we disable this feature for use with bulkmarcimport in one of the patches. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27944] Add new stages to the article request process
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 --- Comment #85 from Tomás Cohen Arazi --- Created attachment 125544 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125544=edit Bug 27944: (follow-up) Add POD The library didn't contain real POD. This patch adds it. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 --- Comment #369 from Jonathan Druart --- I've spent a lost of time on this patch set to make it part of 21.05. Added follow-ups and written test. Then I had some questions, and didn't get the answers I needed to write the missing bit. I was not asking anybody else to write anything. I wish I had people asking me to write follow-up for my patches.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29137] Unwanted authorised values are too easily created via the cataloging module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29137 --- Comment #10 from Joy Nelson --- Thank you everyone! This fix will really make 'hi-efficiency', keyboard centric catalogers very happy. :D joy (In reply to Andrew Fuerste-Henry from comment #9) > I'll admit to a bit of pearl-clutching overreaction on this. I hadn't yet > seen 29030 when I filed this. Like Joy and Jonathan, I also fear > torch-wielding catalogers. Thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28717] NewsLog doesn't work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28717 --- Comment #24 from Jonathan Druart --- Sorry, Lucas! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28717] NewsLog doesn't work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28717 Jonathan Druart changed: What|Removed |Added Attachment #125471|0 |1 is obsolete|| --- Comment #23 from Jonathan Druart --- Created attachment 125543 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125543=edit Bug 28717: Fix additional content logs The logging for additional contents added by bug 26205 has been broken by but 22544. This patch is a revisited version as bug 24387 has been pushed. It does not log MODIFY if no modification has been made on a template (useful when only 1 version/lang of a content has been modified) Test plan: Turn on NewsLog Add/modify and delete additional contents/News and confirm that modification are logged. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28717] NewsLog doesn't work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28717 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27944] Add new stages to the article request process
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Failed QA --- Comment #84 from Jonathan Druart --- 1. Missing POD in Koha::ArticleRequest 2. Koha::ArticleRequest->request is not covered by tests 3. Changes to Koha::ArticleRequest->cancel are not covered by tests 4. Koha::ArticleRequests->requested is not covered by tests 4. Not a big deal (not blocker of course) but $reason = $av->lib_opac ? $av->lib_opac : $av->lib if $av; Is more readable (IMO) like: $reason = $av->lib_opac || $av->lib if $av; -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27947] Add default cancellation reasons to article requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947
--- Comment #64 from Jonathan Druart ---
1. Not blocker, but:
-my ( $self, $notes ) = @_;
+my ( $self, $cancellation_reason, $notes ) = @_;
You should have used a hashref, especially because we have Koha::Hold->cancel
that is getting a reason as well:
my $cancel_hold = $hold->cancel(
{
[ charge_cancel_fee => 1||0, ]
[ cancellation_reason => $cancellation_reason, ]
}
);
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23678] Cancel holds in bulk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678
Jonathan Druart changed:
What|Removed |Added
CC||jonathan.druart+koha@gmail.
||com
Status|Passed QA |In Discussion
--- Comment #24 from Jonathan Druart ---
1. I don't understand why we pass patron_name when we have the patron_id (same
for biblio_title).
If you modify the patron's name, the name won't match.
If you cannot do it now, you may need Koha::BackgroundJob->additional_report
from "Bug 28445: Add the capability to provide more info to the background job
detail view"
2.
+push @messages, {
+type => 'error',
+code => 'hold_not_cancelled',
+patron_id => defined $patron?$patron->borrowernumber:'',
+patron_name => defined
$patron?($patron->firstname?$patron->firstname.', ':'').$patron->surname:'',
+biblio_id => defined $biblio?$biblio->biblionumber:'',
+biblio_title => defined $biblio?$biblio->title:'',
+hold_id => $hold_id,
+error => defined $hold?($@ ? $@ : 0):'No hold with id
'.$hold_id.' found',
+};
Erk, spaces, indentation? I can fix that.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945
Jonathan Druart changed:
What|Removed |Added
Status|Passed QA |Failed QA
--- Comment #81 from Jonathan Druart ---
1. +my $can_request = $borrower->can_request_article
$patron is better now
2.
+my $compdate = dt_from_string->add( days => -1 );
I don't understand, what are we doing here? Can you add a line in the POD about
that?
3.
+if ($article_request_limit ne '' && $article_request_limit !~ /^\d+$/) {
+push @messages, {type => 'error', code =>
'article_request_numeric_limit' };
+$op = 'add_form';
+} elsif ($article_request_limit ne '' && $article_request_limit < 0) {
+push @messages, {type => 'error', code =>
'article_request_negative_limit' };
+$op = 'add_form';
+} else {
Why that?
I am expecting to see a JS validation and an exception raised in
Koha::Category->store. But not in the controller.
4.
circ/request-article.pl
+error_message => 'Patron cannot request more articles for today'
[% error_message | html %]
Hum? Non translatable message.
Same for the exception actually:
+error_message => $_->{message}
And same in opac-request-article.pl
5. opac-request-article.pl
+exit unless $_->[0] && $_->[0] eq 'EXIT';
This is very awkward. Why not simply having the print+exit outside of the try?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29147] New: Add option to specify Zebra is not being used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29147 Bug ID: 29147 Summary: Add option to specify Zebra is not being used Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching - Zebra Assignee: koha-bugs@lists.koha-community.org Reporter: n...@bywatersolutions.com During ES development it was advantageuos to preserve Zebra as a backup, and it was necessary for the Z3950 server We now have z3950_responder and Koha can be run without Zebra There should be a switch that: 1 - Prevents ZebraQueue from being populated 2 - Removes Zebra info from about page (currently there is a warn if not running) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 --- Comment #368 from David Gustafsson --- (In reply to Jonathan Druart from comment #339) > There are several questions waiting for answers, see comments 321-333. I read through those comments again, and the questions where not addressing stability issues but feature requests and refactoring suggestions. Probably one of the reasons this has taken so long is that instead of concentrating on minimal viable functionality there are continuous suggestions for new features and improvements. Some of which are actually pretty complicated to implement (like user feedback). As I said we have been running this in production for years, and it more or less covers our needs (as pretty decently sized university library with 200+ employees. I did forget about one thing though, that actually is a show-stopper, and that is if this bug is merged without the fix in bug 25539, this will trigger a bug with this current patch. I discovered that bug 25539 was set as depending on this bug when it should have been the other way around which I now fixed. The reason everything works for us is that we use the fix in bug 25539. We also have large and unruly patch for bulkmarcimport.pl (a which I believe is now deactivated in the current iteration of this patch) so that also source works. Can't remember at the top of my head what the issues in bulkmarcimport.pl was that caused us to disable it, but the fix in bug 25539 will not solve this issue I think (but is still needed to avoid the bug causing rules to be ignored on updates. So I think focusing on sorting out the issue addressed in bug 25539, and possibly address the problems with bulkmarcimport.pl would be reasonable thing to prioritize. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25030] IncludeSeeFromInSearches not honoured in Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25030 --- Comment #10 from Séverine Queune --- Hi everyone ! Any chance to see this patch updated soon ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 David Gustafsson changed: What|Removed |Added Blocks|25539 | Depends on||25539 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25539 [Bug 25539] Remove AddBiblio "defer_marc_save" option -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25539] Remove AddBiblio "defer_marc_save" option
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25539 David Gustafsson changed: What|Removed |Added Depends on|14957 | Blocks||14957 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 [Bug 14957] Write protecting MARC fields based on source of import -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29137] Unwanted authorised values are too easily created via the cataloging module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29137 --- Comment #9 from Andrew Fuerste-Henry --- I'll admit to a bit of pearl-clutching overreaction on this. I hadn't yet seen 29030 when I filed this. Like Joy and Jonathan, I also fear torch-wielding catalogers. Thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29137] Unwanted authorised values are too easily created via the cataloging module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29137 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #125473|0 |1 is obsolete|| --- Comment #8 from Andrew Fuerste-Henry --- Created attachment 125542 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125542=edit Bug 29137: Add new syspref to disable AV creation within the cataloguing module "I don't like this patch at all!" "We will see a cataloger revolt if we do not find a way to make this optional for catalogers." I imagined a hord of catalogers running behind me and I got scared. This patch will allow to turn the new feature added by bug 25728 off. Test plan: Confirm that the new CreateAVFromCataloguing will permit to turn the feature off. Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29137] Unwanted authorised values are too easily created via the cataloging module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29137 Andrew Fuerste-Henry changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29146] Should framework default values be applied to existing records?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29146 Marcel de Rooy changed: What|Removed |Added Text to go in the||This patch makes Koha no release notes||longer apply default values ||to empty fields in an ||existing biblio record in ||the regular cataloguing ||editor. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29146] Should framework default values be applied to existing records?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29146 --- Comment #3 from Marcel de Rooy --- Created attachment 125541 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125541=edit Bug 29146: Apply framework defaultvalue only to new records This applies only to the 'regular' cataloguing editor. Another report could be opened for the advanced one, if needed. Test plan: [1] Add a default value to some field X in framework Y. [2] Open an existing biblio record in that fw. Clear field X. Save. [3] Reopen the record. The default should not be in field X. [4] Add a new record in that fw. You should see default value in X. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29146] Should framework default values be applied to existing records?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29146 Marcel de Rooy changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29146] Should framework default values be applied to existing records?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29146 Marcel de Rooy changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |m.de.r...@rijksmuseum.nl |ity.org | Severity|enhancement |normal Status|NEW |ASSIGNED --- Comment #2 from Marcel de Rooy --- Changing enhancement to bug status normal. What Koha does for years, is actually just wrong. The positive side is that many people will add the record, and not edit it any longer ;) But my cataloger tells me: I reopen the record, and remove the wrong defaults. Which is obviously kind of job creation. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 --- Comment #367 from Martin Renvoize --- Another rebase.. another follow-up to fix things that have moved on. I'm not sure what more I can do... 6 years is too long for an important feature like this to languish. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 --- Comment #366 from Martin Renvoize --- Created attachment 125540 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125540=edit Bug 14957: Fix imports in tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 Martin Renvoize changed: What|Removed |Added Attachment #120705|0 |1 is obsolete|| --- Comment #365 from Martin Renvoize --- Created attachment 125539 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125539=edit Bug 14957: Improve readbility of tests Not saying that they were not readable before, but I had to do some changes to compare the before/after records and it was easier that way. Feel free to obsolete if you disagree. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 Martin Renvoize changed: What|Removed |Added Attachment #120671|0 |1 is obsolete|| --- Comment #364 from Martin Renvoize --- Created attachment 125538 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125538=edit Bug 14957: Clean controller Too many imports and unecessary complicated init of $rules There are certainly other things to improve, like the "op" handling, standardize names of "op", etc. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
