[Koha-bugs] [Bug 29493] SPAM
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29493 Jonathan Druart changed: What|Removed |Added Assignee|ch...@bigballofwax.co.nz|koha-b...@lists.koha-commun ||ity.org Group|Koha security | Component|Koha|Architecture, internals, ||and plumbing Product|Koha security |Koha QA Contact||testo...@bugs.koha-communit ||y.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29498] Remove usage of deprecated Mojolicious::Routes::Route::detour
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29498 Julian Maurice changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29498] Remove usage of deprecated Mojolicious::Routes::Route::detour
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29498 --- Comment #1 from Julian Maurice --- Created attachment 127705 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127705=edit Bug 29498: Remove usage of deprecated Mojolicious::Routes::Route::detour Mojolicious::Routes::Route::detour was deprecated in Mojolicious 8.67 and removed in Mojolicious 9 It was used in Koha::App::Plugin::RESTV1 to connect the "REST API" Mojolicious app to the other Mojolicious apps (Koha::App::Intranet and Koha::App::Opac), so it's only a problem when running Koha as a Mojolicious app. This patch makes use of the "partial" attribute instead, which does the same thing. Test plan: 1. Run `morbo bin/intranet` 2. Point your browser to what morbo says (should be localhost:3000) 3. Log in, and go to Administration » Libraries. This table uses the REST API, so if you see data in it, that means the API (and the patch) works -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29498] New: Remove usage of deprecated Mojolicious::Routes::Route::detour
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29498 Bug ID: 29498 Summary: Remove usage of deprecated Mojolicious::Routes::Route::detour Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: julian.maur...@biblibre.com Reporter: julian.maur...@biblibre.com QA Contact: testo...@bugs.koha-community.org Mojolicious::Routes::Route::detour was deprecated in Mojolicious 8.67 and removed in Mojolicious 9 The method is used in Koha::App::Plugin::RESTV1 to connect the "REST API" Mojolicious app to the other Mojolicious apps (Koha::App::Intranet and Koha::App::Opac), so it's only a problem when running Koha as a Mojolicious app. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 500] [INTRANET]Only 21 items are displayed in the search result
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=500 Minerva.hernández changed: What|Removed |Added OS|All |Linux Hardware|PC |Other CC||atenea.m...@gmail.com Resolution|FIXED |INVALID --- Comment #1 from Minerva.hernández --- No permite desplegar la plantilla de catalogación, así como no recupera la información y cuando migro en protocolo z39.50 no me permite guardar la información -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28709] Fetching biblio objects for custom covers is inefficient
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28709 --- Comment #13 from David Cook --- (In reply to Nick Clemens from comment #12) > > Did you benchmark this patch? > with numSearchResults at 50 - standard sample data, search for 'a' > Before patch ~2 second > After patch ~1.85 seconds Is that averaged or based on 1 test each? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29485] selenium/administration_tasks.t is failing randomly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29485 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net --- Comment #3 from Victor Grousset/tuxayo --- thanks, I'll try to reproduce and see if that can still happen when I'll upgrade Selenium to v4. Fingers crossed to not need the dirty fix after that. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29195] Highlighting broken on odd rows in circ-patron-search-results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29195 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED --- Comment #9 from Victor Grousset/tuxayo --- Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29416] Regression: information from existing bib no longer populating on suggest for purchase
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29416 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net Version(s)|21.11.00,21.05.05,20.11.12 |21.11.00,21.05.05,20.11.12, released in||20.05.18 Status|Pushed to oldstable |Pushed to oldoldstable --- Comment #12 from Victor Grousset/tuxayo --- Backported: Pushed to 20.05.x branch for 20.05.18 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20956] BorrowersLog is not logging permission changes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20956 Lisette Scheer changed: What|Removed |Added CC||lisettesla...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29418] Zebra clean_search_term does not clean search and so results in error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29418 Abbey Holt changed: What|Removed |Added CC||ah...@dubuque.lib.ia.us -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29497] New: Add ability to link authorities automatically in the advanced editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29497 Bug ID: 29497 Summary: Add ability to link authorities automatically in the advanced editor Change sponsored?: --- Product: Koha Version: 21.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: esth...@sodaspringsid.com QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl It would be nice to add the link authorities automatically button in the advanced editor. Right now catalogers must use the basic editor in order to use this option. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29275] Use the API to render checkout history for a biblio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29275 --- Comment #17 from Tomás Cohen Arazi --- Created attachment 127704 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127704=edit Bug 29275: (follow-up) Split columns settings and handle upgrade This patch splits the table settings as we now have two tables. The atomic update takes care of setting the right values (if present) on the new tables entries. To test: 1. Do not apply this patch 2. Set some values you will remember for the checkoutshistory-table table 3. Run: $ koha-mysql kohadev > SELECT * FROM columns_settings WHERE tablename='checkoutshistory-table'; => SUCCESS: Koha currently works :-D 4. Apply this patch 5. Run: $ updatedatabase 6. Repeat 3 => SUCCESS: Things have been deleted 7. Run: $ koha-mysql kohadev > SELECT * FROM columns_settings WHERE tablename LIKE '%_checkouts-table'; => SUCCESS: old_checkouts-table and current_checkouts-table have the right setting 8. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29275] Use the API to render checkout history for a biblio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29275 Tomás Cohen Arazi changed: What|Removed |Added Summary|issuehistory.pl is very |Use the API to render |slow when there are many|checkout history for a |historical issues |biblio -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29275] issuehistory.pl is very slow when there are many historical issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29275 --- Comment #16 from Tomás Cohen Arazi --- (In reply to Victor Grousset/tuxayo from comment #8) > A diff between current_checkouts and old_checkouts functions show that they > have a lot of duplication. > Is there a way to deduplicate without making something messy? > I wonder if there is a way to assign old_checkouts as a copy of > current_checkouts and then re assign so it it's properties to add and change > stuff. > The only difference is the URL param and a render function. Not just that. But I made a function to avoid duplication. > Also a call to encodeURIComponent() might be missing in current_checkouts Solved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29275] issuehistory.pl is very slow when there are many historical issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29275 --- Comment #15 from Tomás Cohen Arazi --- Created attachment 127703 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127703=edit Bug 29275: (follow-up) Remove use of CountSubscriptionFromBiblionumber Signed-off-by: Tomas Cohen Arazi Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29275] issuehistory.pl is very slow when there are many historical issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29275 --- Comment #14 from Tomás Cohen Arazi --- Created attachment 127702 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127702=edit Bug 29275: Use the API to fetch checkouts information This patch changes issuehistory.pl so it leverages on the API for fetching checkouts information in the template. Workflow changes: This development splits the 'current' checkouts and the 'past' checkouts in two different tables. Terminology could be revisited by native english speakers. To test: 1. Have records with and without current/past checkouts 2. Notice how the Checkouts history tab presents the information on each case. => SUGGESTION: Keep each of them open on separate tabs for comparing 3. Apply this patchset and its dependencies 4. Restart plack, run: $ koha-plack --restart kohadev 5. Follow the same steps you followed for those open tabs, in new ones => SUCCESS: What you see makes sense, information is displayed as it used to, with the different tables now. 6. Try searching on the datatables => SUCCESS: Search works correctly! 7. Revisit the new texts I added => SUGGESTION: If you have better wordings, submit a patch, or just comment on the bug so I do it inline. 8. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29275] issuehistory.pl is very slow when there are many historical issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29275 Tomás Cohen Arazi changed: What|Removed |Added Attachment #126634|0 |1 is obsolete|| Attachment #126635|0 |1 is obsolete|| Attachment #126636|0 |1 is obsolete|| --- Comment #13 from Tomás Cohen Arazi --- Created attachment 127701 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127701=edit Bug 29275: Add $patron_to_html to render patron information in JS Signed-off-by: Tomas Cohen Arazi Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29275] issuehistory.pl is very slow when there are many historical issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29275 Tomás Cohen Arazi changed: What|Removed |Added Patch complexity|--- |Small patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29491] Improve display of notices in patron details
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29491 Barbara Johnson changed: What|Removed |Added CC||barbara.johnson@bedfordtx.g ||ov --- Comment #1 from Barbara Johnson --- Increasing the width of the display box would be helpful. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29496] New: can't save an order with mandatory items subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29496 Bug ID: 29496 Summary: can't save an order with mandatory items subfields Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: k...@univ-lyon3.fr QA Contact: testo...@bugs.koha-community.org Here is the plan to reproduce it : - Unimarc flavour - Items in 995 field whith 3 mandatory / > Tab:10, | Koha field: items.homebranch, Not repeatable, Mandatory, Not Important, | Auth value:branches, > Tab:10, | Koha field: items.holdingbranch, Not repeatable, Mandatory, Not important, | Auth value:branches, > Tab:10, | Koha field: items.location, Not repeatable, Mandatory, Not important, | Auth value:LOC, - AcqCreateItem="placing an order" When adding an order from a new empty record,I filled - the title - the 3 mandatory items subfields (and clicked on add item) - the fund - the currency - the vendor price - the tax rate - the discount - the retail price - the replacement cost - the budgeted cost - the total When saving, I have the message : "Form not submitted because of the > following problem(s): - 3 item mandatory fields empty". You can try here : http://staff-master.sandboxes.ptfs-europe.co.uk/cgi-bin/koha/acqui/basket.pl?basketno=2 Sonia -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28627] Revert the order receive page to display 'Actual cost' as ecost_tax_included/ecost_tax_excluded if unitprice not set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28627 Koha Team University Lyon 3 changed: What|Removed |Added CC||k...@univ-lyon3.fr --- Comment #11 from Koha Team University Lyon 3 --- Hi Nick, The issue exists but I can reproduce it on the master git branch dating from yesterday (I don't understand why it has worked yesterday.. damn cache..) and on a sandbox. So, it's not linked to this patch, sorry for the wrong alert. I'm going to open a new BZ. (By the way, I haven't managed to have the sandbox provided on the bywatersolutions sandbox system) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26802] Improve speed with records with many items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26802 mathieu saby changed: What|Removed |Added CC||mathsaby...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29394] Remove flatpickr instantiations from .tt files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29394 --- Comment #5 from Owen Leonard --- One problem I wasn't able to understand: If you configure an input with the "pastdate" or "pastinclusive" option AND enable the time picker the defaultHour and defaultMinute options are lost. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29394] Remove flatpickr instantiations from .tt files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29394 --- Comment #4 from Owen Leonard --- Created attachment 127700 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127700=edit Bug 29394: (follow-up) Pass correct time format and other corrections This patch makes a few corrections, including adding the correct Flatpickr date format option when the timepicker is enabled. Besides past and future date options, I've added a "pastinclusive" option which allows dates in the past OR today. This option was previously applied to the checkin page. The patch also corrects a couple of places where the wrong date field was modified with the new data attributes. To test, apply the patch and test the datepickers on the batch checkout and renew pages. When you select a date and time the "TimeFormat" system preference should be correctly applied. The calendar widget on the checkin page should allow you to select today's date. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29394] Remove flatpickr instantiations from .tt files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29394 Owen Leonard changed: What|Removed |Added Attachment #127699|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29394] Remove flatpickr instantiations from .tt files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29394 --- Comment #3 from Owen Leonard --- Created attachment 127699 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127699=edit Bug 29394: (follow-up) Pass correct time format and other corrections This patch makes a few corrections, including adding the correct Flatpickr date format option when the timepicker is enabled. The patch also corrects a couple of places where the wrong date field was modified with the new data attributes. To test, apply the patch and test the datepickers on the batch checkout and renew pages. When you select a date and time the "TimeFormat" system preference should be correctly applied. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29341] If OpacRenewalBranch = opacrenew, pseudonymization process leads to "internal server error" when patrons renew the loans at OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29341 Jonathan Druart changed: What|Removed |Added Status|In Discussion |ASSIGNED --- Comment #23 from Jonathan Druart --- Sonia confirmed me that it's ok to keep the branchcode and so remove the FK. I personally still don't think it's a good idea, but I understand the use case. This is also a bad use case: Create branch CPL, for testing purpose (hey you just installed the software and want to try it) Do some stuffs, it will create stats entries Remove CPL to start from scratch and clean state Reuse CPL as branchcode Stats are accumulating using the test data I will provide an alternate patch tomorrow if nobody beats me to it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29394] Remove flatpickr instantiations from .tt files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29394 Owen Leonard changed: What|Removed |Added Assignee|oleon...@myacpl.org |jonathan.druart+koha@gmail. ||com Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29477] flatpickr default time should be 23:59 (11:59 pm as well, probably), not 12:00
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29477 Owen Leonard changed: What|Removed |Added Blocks||29394 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29394 [Bug 29394] Remove flatpickr instantiations from .tt files -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29394] Remove flatpickr instantiations from .tt files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29394 Owen Leonard changed: What|Removed |Added Depends on||29477 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29477 [Bug 29477] flatpickr default time should be 23:59 (11:59 pm as well, probably), not 12:00 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29239] [OMNIBUS] Replace jQueryUI's timepicker with flatpickr
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29239 Owen Leonard changed: What|Removed |Added Blocks|29477 | Depends on||29477 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29477 [Bug 29477] flatpickr default time should be 23:59 (11:59 pm as well, probably), not 12:00 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29477] flatpickr default time should be 23:59 (11:59 pm as well, probably), not 12:00
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29477 Owen Leonard changed: What|Removed |Added Blocks||29239 Depends on|29239 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29239 [Bug 29239] [OMNIBUS] Replace jQueryUI's timepicker with flatpickr -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28279] mappings.yaml no longer in sync
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28279 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff |RESOLVED Resolution|--- |FIXED --- Comment #8 from Jonathan Druart --- Has been regenerated by commit 0760045e0b10a80643b90cac77f653d5cda42e75 Bug 18984: Remove ES mapping for NORMARC -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29436] Cannot reorder facets in staff interface elasticsearch configuration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29436 --- Comment #4 from Jonathan Druart --- (In reply to Jonathan Druart from comment #2) > There is still something wrong that should be improve, but this patch > should be safe for backport. hum... bug 19482 comment 70 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29488] NumSavedReports system preference doesn't work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29488 Barbara Johnson changed: What|Removed |Added CC||barbara.johnson@bedfordtx.g ||ov Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29488] NumSavedReports system preference doesn't work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29488 PTFS Europe Sandboxes changed: What|Removed |Added Attachment #127677|0 |1 is obsolete|| --- Comment #3 from PTFS Europe Sandboxes --- Created attachment 127698 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127698=edit Bug 29488: make NumSavedReports work 1. Have a bunch of saved reports 2. Try to use the sys pref NumSavedReports to limit how many show by default 3. It doesn't work 4. Apply patch 5. Try again, now it should work Signed-off-by: Barbara Johnson -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19482] Elasticsearch - prevent removal / editing of required indexes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19482 Jonathan Druart changed: What|Removed |Added Blocks||29436 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29436 [Bug 29436] Cannot reorder facets in staff interface elasticsearch configuration -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29436] Cannot reorder facets in staff interface elasticsearch configuration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29436 Jonathan Druart changed: What|Removed |Added Depends on||19482 --- Comment #3 from Jonathan Druart --- Looks like it has been caused by commit 975e06bd7c3e198048c60d4a0f9968ba89079de7 Bug 19482: Add support for defining 'mandatory' mappings Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19482 [Bug 19482] Elasticsearch - prevent removal / editing of required indexes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29436] Cannot reorder facets in staff interface elasticsearch configuration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29436 Jonathan Druart changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |jonathan.druart+koha@gmail. |ity.org |com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29436] Cannot reorder facets in staff interface elasticsearch configuration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29436 --- Comment #2 from Jonathan Druart --- Created attachment 127697 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127697=edit Bug 29436: ES mappings not saved if zebra is configured The mappings must be editable even if ES is not turned on yet. Using a separate array to store the errors as we are testing for $@ || @messages. There is still something wrong that should be improve, but this patch should be safe for backport. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29436] Cannot reorder facets in staff interface elasticsearch configuration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29436 Jonathan Druart changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29436] Cannot reorder facets in staff interface elasticsearch configuration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29436 Jonathan Druart changed: What|Removed |Added CC||jonathan.druart+koha@gmail. ||com --- Comment #1 from Jonathan Druart --- I actually get this error when searchengine=zebra, and the message is... "elasticsearch_disabled"... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29494] html-template-to-template-toolkit.pl no longer required
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29494 Owen Leonard changed: What|Removed |Added Attachment #127691|0 |1 is obsolete|| --- Comment #2 from Owen Leonard --- Created attachment 127696 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127696=edit Bug 29494: html-template-to-template-toolkit.pl no longer required This helper script was used to transition from HTML::Template to Template::Toolkit, which happened 11 (?) years ago. The file is part of Koha history, but we don't need it in current master. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Owen -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29494] html-template-to-template-toolkit.pl no longer required
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29494 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29002] Add ability to book items ahead of time
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 Barbara Johnson changed: What|Removed |Added CC||barbara.johnson@bedfordtx.g ||ov -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29416] Regression: information from existing bib no longer populating on suggest for purchase
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29416 David Nind changed: What|Removed |Added CC||da...@davidnind.com Text to go in the||This restores the behaviour release notes||for purchase suggestions ||for an existing title, so ||that the suggestion form is ||pre-filled with the details ||from the existing record. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17600] Standardize the EXPORT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Jonathan Druart changed: What|Removed |Added Blocks||29469 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29469 [Bug 29469] Error when approving and rejecting tags -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29469] Error when approving and rejecting tags
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29469 Jonathan Druart changed: What|Removed |Added Depends on||17600 Version(s)||21.11.00 released in|| Status|Passed QA |Pushed to master --- Comment #2 from Jonathan Druart --- Patch pushed to master for 21.11.00 Thanks, Owen! Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 [Bug 17600] Standardize the EXPORT -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29469] Error when approving and rejecting tags
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29469 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29469] Error when approving and rejecting tags
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29469 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29469] Error when approving and rejecting tags
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29469 Jonathan Druart changed: What|Removed |Added Severity|normal |major CC||jonathan.druart+koha@gmail. ||com Status|NEW |Needs Signoff Assignee|koha-b...@lists.koha-commun |jonathan.druart+koha@gmail. |ity.org |com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29469] Error when approving and rejecting tags
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29469
--- Comment #1 from Jonathan Druart ---
Created attachment 127695
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127695=edit
Bug 29469: (bug 17600 follow-up) Fix tag approval/rejection from staff
Usage: POSIX::exit(status) at /kohadevbox/koha/tags/review.pl line 72.
at
/usr/share/perl/5.28/Carp.pm line 289
Carp::croak('Usage: POSIX::exit(status)') called at
/usr/lib/x86_64-linux-gnu/perl/5.28/POSIX.pm line 22
POSIX::usage('exit(status)') called at (eval 2066) line 3
Signed-off-by: Jonathan Druart
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29478] flatpickr misses quick shortcut to "Today" date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29478 --- Comment #6 from Jonathan Druart --- (In reply to Owen Leonard from comment #5) > (In reply to Jonathan Druart from comment #2) > > > Confirm that flatpickr instances now have a yesterday, today and > > tomorrow buttons. > > I thought of an issue when testing my follow-up: Should the shortcut > controls reflect the date limitations of the flatpickr instance? For > instance, if selection is limited to a date before today, should the "today" > and "tomorrow" controls be disabled? Currently clicking a shortcut for a > date which is disallowed will empty the date field. Good point! Yes definitely, if not too hard to implement. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29264] SIP config allows use of non-branchcode institution ids causes workers to die without responding
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29264 David Nind changed: What|Removed |Added Text to go in the||This adds a warning to the release notes||logs where a SIP login uses ||an institution id that is ||*not* a valid library code. || ||If a SIP login uses an ||institution with an id that ||doesn't match a valid ||branchcode, everything will ||appear to work, but the SIP ||worker will die anywhere ||that Koha gets the branch ||from the userenv and ||assumes it is valid. || ||The ||repercussions of this are ||that actions such as the ||checkout message simply die ||and do not return a ||response message to the ||requestor. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29334] Do not apply framework defaultvalue to existing authority records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29334 David Nind changed: What|Removed |Added Text to go in the||This fixes an issue where release notes||the default value for a ||field in a framework was ||being applied when records ||were edited, rather than ||only when first created. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29478] flatpickr misses quick shortcut to "Today" date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29478 --- Comment #5 from Owen Leonard --- (In reply to Jonathan Druart from comment #2) > Confirm that flatpickr instances now have a yesterday, today and > tomorrow buttons. I thought of an issue when testing my follow-up: Should the shortcut controls reflect the date limitations of the flatpickr instance? For instance, if selection is limited to a date before today, should the "today" and "tomorrow" controls be disabled? Currently clicking a shortcut for a date which is disallowed will empty the date field. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29478] flatpickr misses quick shortcut to "Today" date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29478
--- Comment #4 from Owen Leonard ---
Created attachment 127694
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127694=edit
Bug 29478: (follow-up) Provide default style for shortcut buttons
This patch adds some CSS to _flatpickr.scss in order to give a deafult
style to the "yesterday," "today," and "tomorrow" controls added by the
shortcut plugin.
A missed translatable string is now wrapped in the __() function:
__("or").
The patch also updates the date calculation for those shortcuts to use
Flatpickr's date calculation shorthand. This isn't strictly necessary
but I think it makes the code more readable.
To test, apply the patch and build the staff interface CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).
In the staff client, view some pages with date-picker widgets. A
calendar widget time selection:
- Circulation -> Check out -> Checkout settings -> Select date:
- The calendar widget should have "yesterday," "today," and "tomorrow"
controls styled like links appearing after the time selector. The
controls should be centered, with the "or" label on the same line.
A calendar widget without time selection:
- Tools -> Log viewer -> Display from.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28374] Convert pos/printreceipt.pl to use GetPreparedLetter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28374 David Nind changed: What|Removed |Added Text to go in the||This patch converts the release notes||point of sale receipt ||printer controller to using ||GetPreparedLetter instead ||of calling getletter ||directly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29456] "Auto renewal" notice shown as "unknown" on the patron category list view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29456 Kelly McElligott changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #3 from Kelly McElligott --- Works great! Signing off through sandboxes. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29456] "Auto renewal" notice shown as "unknown" on the patron category list view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29456 PTFS Europe Sandboxes changed: What|Removed |Added Attachment #127692|0 |1 is obsolete|| --- Comment #2 from PTFS Europe Sandboxes --- Created attachment 127693 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127693=edit Bug 29456: (bug 18532 follow-up) handle Auto_Renewals messages in category The new message appears in the list on the edit view, but the list view is showing "unknown" Test plan: Set AutoRenewalNotices to "according to patron messaging prefs" Edit a patron category Tick all the checkboxes On the category list view you should see a correct display in the "Messaging" column Signed-off-by: Kelly McElligott -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28898] Context for translation: term (word) vs. term (semester)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28898 David Nind changed: What|Removed |Added Text to go in the|This disambiguates the term |This disambiguates and release notes|"term" used in course |provides a hint for |reserves, where the meaning |translating the term "term" |is "semester". This allows |used in course reserves, |it to be translated, rather |where the meaning is |than having to use JQuery |"semester" rather than |to change the text |something like search term. |displayed for languages |This allows it to be |other then English. |translated, rather than ||having to use JQuery to ||change the text displayed ||for languages other then ||English. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29455] 505$t - change in line break/display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29455 --- Comment #3 from Katrin Fischer --- Subfield g, r, t are repeatable, a is not. For defining "items" this is all I could find back then and asusmeed that each item should go on a new line: In records formulated according to AACR 2, a space-hyphen-hyphen-space ( -- ) is recorded between each item in the contents note unless a delimiter/subfield code follows in which case there is no ending space. In pre-AACR 2 records, items are separated by a period-hyphen-hyphen (.--). I am not sure what indications the subfield sequence can give. Here it's tg tg... 505 00$tQuatrain II$g(16:35) --$tWater ways$g(1:57) --$tWaves$g(10:49). But then the next example is already different with gt gt gt: 505 10$gNr. 1.$tRegion Neusiedlersee --$gNr. 2.$tRegion Rosalia/Lithagebirge --$gNr. 3.$tRegion Mettelburgenland --$gNr. 4.$tRegion südliches Burgenland --$gNr. 5.$tRegion Südburgland You'd need to keep the ones corresponding on one line togehter, but if the subfield sequence can change like this, I saw no other option than using the --. Example from LOC documentation: https://www.loc.gov/marc/bibliographic/bd505.html -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29495] Issue link is lost in return claims when using 'MarkLostItemsAsReturned'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 Martin Renvoize changed: What|Removed |Added CC||and...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29495] New: Issue link is lost in return claims when using 'MarkLostItemsAsReturned'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 Bug ID: 29495 Summary: Issue link is lost in return claims when using 'MarkLostItemsAsReturned' Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvo...@ptfs-europe.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com We have a foreign key constraint in return_claims for issue_id.. this means that if you have 'MarkLostItemsAsReturned' enabled, we first add the issue_id linking to the original checkout, then immediately move the checkout to old_issues and nuke the issue_id from the claims_return table :( -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29456] "Auto renewal" notice shown as "unknown" on the patron category list view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29456 Jonathan Druart changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |jonathan.druart+koha@gmail. |ity.org |com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29456] "Auto renewal" notice shown as "unknown" on the patron category list view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29456 Jonathan Druart changed: What|Removed |Added Summary|Notice overview on Patron |"Auto renewal" notice shown |Category|as "unknown" on the patron ||category list view -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29456] Notice overview on Patron Category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29456 --- Comment #1 from Jonathan Druart --- Created attachment 127692 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127692=edit Bug 29456: (bug 18532 follow-up) handle Auto_Renewals messages in category The new message appears in the list on the edit view, but the list view is showing "unknown" Test plan: Set AutoRenewalNotices to "according to patron messaging prefs" Edit a patron category Tick all the checkboxes On the category list view you should see a correct display in the "Messaging" column -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21105] oai.pl returns invalid earliestDatestamp
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21105 David Nind changed: What|Removed |Added Text to go in the||This fixes the date format release notes||in OAI-PMH for ||Identify.earliestDatestamp ||so that it uses ||"-MM-DDThh:mm:ssZ" and ||is in UTC, instead of the ||SQL formsat "-MM-DD ||hh:mm:ss" currently used. ||For OAI-PMH all date and ||time values must be in the ||format ||"-MM-DDThh:mm:ssZ" and ||in UTC. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29456] Notice overview on Patron Category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29456 Jonathan Druart changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18532] Messaging preferences for auto renewals
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 Jonathan Druart changed: What|Removed |Added Blocks||29456 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29456 [Bug 29456] Notice overview on Patron Category -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29456] Notice overview on Patron Category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29456 Jonathan Druart changed: What|Removed |Added CC||jonathan.druart+koha@gmail. ||com Keywords||rel_21_05_candidate, ||rel_21_11_candidate Depends on||18532 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 [Bug 18532] Messaging preferences for auto renewals -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29455] 505$t - change in line break/display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29455 Jonathan Druart changed: What|Removed |Added CC||jonathan.druart+koha@gmail. ||com --- Comment #2 from Jonathan Druart --- Say you have several 505 with several $t$r$g, what's the expected behaviour then? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29113] New "code" field for additional contents is not useful for the end users
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113 --- Comment #27 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #26) > (In reply to Jonathan Druart from comment #24) > > > additional_contents > > - id > > - category > > - published_on > > - updated_on > > - expirationdate > > - number > > > > Another table for translations: > > - fk > > - lang (or eventually fk to a lang table) > > - title > > - content > > This looks better. But this is not for now :D However I still think we should hide the code for 21.11. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29113] New "code" field for additional contents is not useful for the end users
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113 --- Comment #26 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #24) > additional_contents > - id > - category > - published_on > - updated_on > - expirationdate > - number > > Another table for translations: > - fk > - lang (or eventually fk to a lang table) > - title > - content This looks better. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29447] authority that begins with a number isn't found in tag editor search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29447 Jonathan Druart changed: What|Removed |Added CC||jonathan.druart+koha@gmail. ||com --- Comment #1 from Jonathan Druart --- It seems to work for me on master. Did you try on a sandbox? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29426] borrower_debarments.created is "ON UPDATE current_timestamp()"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29426 Jonathan Druart changed: What|Removed |Added CC||jonathan.druart+koha@gmail. ||com --- Comment #1 from Jonathan Druart --- Yes it does, can you provide a patch please? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29428] Where is css/holds.css ?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29428 Jonathan Druart changed: What|Removed |Added Resolution|--- |FIXED Status|NEW |RESOLVED CC||jonathan.druart+koha@gmail. ||com --- Comment #3 from Jonathan Druart --- New commit pushed commit ff2fbfe35f20e767d0c47374ef9d366e62b8e848 Bug 28816: (follow-up) Compiled CSS -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28692] Reduce DB action_log table size
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28692 --- Comment #47 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28692] Reduce DB action_log table size
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28692 Jonathan Druart changed: What|Removed |Added Version(s)||21.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29341] If OpacRenewalBranch = opacrenew, pseudonymization process leads to "internal server error" when patrons renew the loans at OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29341 --- Comment #22 from Jonathan Druart --- If you delete the library then recreate another one with the same branchcode, do we want the stats to be linked to the new library? I don't think so. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29341] If OpacRenewalBranch = opacrenew, pseudonymization process leads to "internal server error" when patrons renew the loans at OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29341 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com --- Comment #21 from Nick Clemens --- (In reply to Jonathan Druart from comment #17) > I disagree with removing the FK. Statistics should not keep a wrong/obsolete > code, they are kept (ON DELETE SET NULL) however. > > There are different things, and different fixes: Statistics table is missing > the FK (or does not have it on purpose), and the OpacRenewalBranch behaviour > is badly designed. > > I don't think removing the FK is going into the correct direction, adding a > separate column is definitely out of the scope here. We need a quick bugfix > for the ugly 500 (that is blocker), and this patch is the way to go in my > opinion. I disagree here, I think we should remove the FK to branches as the quick fix. While we may have opinions about how that feature was implemented, it has been implemented. Statistics is a ledger of transactions - foreign keys are going to remove/nullify data after the fact and I think that would be incorrect. If Pseudonymized transactions are meant to mirror the statistics table then I feel we should remove the FK for now, and fix the larger issue with OPACRenew etc on a new bug. Adding a new branch is going to add the branch in many places throughout Koha and will impact workflows -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17981] Add the ability to preview generated notice templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981 Martin Renvoize changed: What|Removed |Added Blocks||29490 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29490 [Bug 29490] Preview for more notices -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29490] Preview for more notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29490 Martin Renvoize changed: What|Removed |Added Depends on||17981 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981 [Bug 17981] Add the ability to preview generated notice templates -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28627] Revert the order receive page to display 'Actual cost' as ecost_tax_included/ecost_tax_excluded if unitprice not set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28627 --- Comment #10 from Nick Clemens --- (In reply to Sonia Bouis from comment #9) > Sorry, but I found a problem with this patch. > > I have just tried and compared with a master from this morning. > The preference system AcqCreateItem is on "placing an order" > > If I tried to save an order with this patch with an item where all mandatory > item are filled, I have the message : "Form not submitted because of the > following problem(s): > - 4 item mandatory fields empty". > > If I tried the same on a master branch, my order is saved normally. > > Can you reproduce this issue ? > Sonia I don't recreate Sonia. This patch only touches the template on the receiving page. Can you provide a few more steps, or a screenshot? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29492] SPAM
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29492 Jonathan Druart changed: What|Removed |Added Group|Koha security | QA Contact||testo...@bugs.koha-communit ||y.org Product|Koha security |Koha Component|Koha|Architecture, internals, ||and plumbing Assignee|ch...@bigballofwax.co.nz|koha-b...@lists.koha-commun ||ity.org Summary|10 |SPAM -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29494] html-template-to-template-toolkit.pl no longer required
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29494 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 127691 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127691=edit Bug 29494: html-template-to-template-toolkit.pl no longer required This helper script was used to transition from HTML::Template to Template::Toolkit, which happened 11 (?) years ago. The file is part of Koha history, but we don't need it in current master. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29494] html-template-to-template-toolkit.pl no longer required
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29494 Tomás Cohen Arazi changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29494] html-template-to-template-toolkit.pl no longer required
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29494 Tomás Cohen Arazi changed: What|Removed |Added CC||jonathan.druart+koha@gmail. ||com, ||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29494] html-template-to-template-toolkit.pl no longer required
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29494 Tomás Cohen Arazi changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29494] New: html-template-to-template-toolkit.pl no longer required
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29494 Bug ID: 29494 Summary: html-template-to-template-toolkit.pl no longer required Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: tomasco...@gmail.com QA Contact: testo...@bugs.koha-community.org This file was used in the transition from HMTL::Template to Template::Toolkit and there's no need to carry it on the current codebase. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5229] OPACItemsResultsDisplay preference must be removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5229 --- Comment #12 from Tomás Cohen Arazi --- Created attachment 127690 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127690=edit Bug 5229: Remove from searching.pref Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5229] OPACItemsResultsDisplay preference must be removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5229 Tomás Cohen Arazi changed: What|Removed |Added Attachment #127655|0 |1 is obsolete|| --- Comment #11 from Tomás Cohen Arazi --- Created attachment 127689 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127689=edit Bug 5229: Remove system preference 'OPACItemsResultsDisplay' We dropped it on bug 12561 when removing the non-XSLT view. This feature has never been implemented for XSLT views and the pref must then be removed. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5229] OPACItemsResultsDisplay preference must be removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5229 Tomás Cohen Arazi changed: What|Removed |Added Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28709] Fetching biblio objects for custom covers is inefficient
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28709 --- Comment #12 from Nick Clemens --- (In reply to Jonathan Druart from comment #8) > Are you sure we don't only need to pass/cache the MARC record? I suppose we could, but we have already called TransformMarcToKoha, why would we not pass the values we calculated? > Did you benchmark this patch? with numSearchResults at 50 - standard sample data, search for 'a' Before patch ~2 second After patch ~1.85 seconds -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28709] Fetching biblio objects for custom covers is inefficient
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28709
Nick Clemens changed:
What|Removed |Added
Attachment #127657|0 |1
is obsolete||
--- Comment #11 from Nick Clemens ---
Created attachment 127688
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127688=edit
Bug 28709: Refactor Koha::Biblio->custom_cover_image_url to allow passing
parameters
Currently the search result template receive a Koha::Biblio object and call the
method.
The searchResults routine already has the isbn, issn, and normalized_isbn
calculated.
Rather than fetching the object and passing to the template we can pass the
parameters,
generate the url, and pass only the URL to the template
To test:
1 - Set the system preferences:
CustomCoverImages : Display
OPACCustomCoverImages: Display
CustomCoverImagesURL:
https://images-na.ssl-images-amazon.com/images/P/{normalized_isbn}.01.LZZZ.jpg
2 - Search on staff and opac for a term that returns titles with covers, e.g.
'shuffle'
3 - Confirm the covers show
4 - Apply patch
5 - Restart all
6 - Confirm covers still show
7 - prove -v t/db_dependent/Koha/Biblios.t
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29477] flatpickr default time should be 23:59 (11:59 pm as well, probably), not 12:00
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29477 --- Comment #4 from Tomás Cohen Arazi --- Works as expected, trivial fix. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29477] flatpickr default time should be 23:59 (11:59 pm as well, probably), not 12:00
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29477 Tomás Cohen Arazi changed: What|Removed |Added Attachment #127668|0 |1 is obsolete|| --- Comment #3 from Tomás Cohen Arazi --- Created attachment 127687 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127687=edit Bug 29477: Flatpickr - default to 23:59 for the time part It was defaulting to 12:00 which was an unexpected change in behaviour caused by flatpickr switch. Test plan: On the circulation view, check some items out and play with the time part and "Remember for session". The behaviour must be correct, ie. the same as prior to flatpickr switch. Signed-off-by: David Nind Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29477] flatpickr default time should be 23:59 (11:59 pm as well, probably), not 12:00
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29477 Tomás Cohen Arazi changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29477] flatpickr default time should be 23:59 (11:59 pm as well, probably), not 12:00
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29477 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com QA Contact|testo...@bugs.koha-communit |tomasco...@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
