[Koha-bugs] [Bug 28186] Use Koha::Authority in C4::AuthoritiesMarc::AddAuthority

2021-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28186

--- Comment #4 from Julian Maurice  ---
Patch rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28186] Use Koha::Authority in C4::AuthoritiesMarc::AddAuthority

2021-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28186

Julian Maurice  changed:

   What|Removed |Added

 Attachment #119935|0   |1
is obsolete||

--- Comment #3 from Julian Maurice  ---
Created attachment 128117
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128117=edit
Bug 28186: Use Koha::Authority in C4::AuthoritiesMarc::AddAuthority

This patch replaces the use of $dbh->do by corresponding use of
Koha::Authority object

Test plan:
1. Verify that creating/modifying authority still work
2. prove t/db_dependent/AuthoritiesMarc.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28186] Use Koha::Authority in C4::AuthoritiesMarc::AddAuthority

2021-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28186

Fridolin Somers  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #2 from Fridolin Somers  ---
Needs a rebase on current master since Bug 27173

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28273] Multi-holds allow invalid pickup locations

2021-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28273

--- Comment #21 from David Cook  ---
Oh and it looks possible to nix the pickup location manually anyway... I'll
have to test this on master...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28273] Multi-holds allow invalid pickup locations

2021-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28273

--- Comment #20 from David Cook  ---
I'm looking into null branchcodes being used for reserves (and breaking the
Reserves display in Circ), and I think that it's being caused by multiholds,
since their default value for "Pickup location" is blank. 

I'm thinking that the solution is probably to remove the empty options...

I am working on an instance with customized hold functionality, so it is
possible that the customizations are preventing some error handling that is in
master, but exploring currently...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29589] Translation issue with formatting in MARC overlay rules page

2021-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29589

David Nind  changed:

   What|Removed |Added

 Attachment #128103|0   |1
is obsolete||

--- Comment #2 from David Nind  ---
Created attachment 128116
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128116=edit
Bug 29589: MARCOverlayRules - fix translatability issue

Strings must not contain html tags, we should use KohaSpan instead.

Test plan:
Apply the patch, update translation for a given language, edit
XX-YY-staff-prog.po

Notice that the string is now
"The %s preference is not set, don't forget to enable it for rules to take
effect."

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29589] Translation issue with formatting in MARC overlay rules page

2021-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29589

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24988] autorenew_checkouts should default to yes

2021-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24988

--- Comment #11 from David Cook  ---
(In reply to Marcel de Rooy from comment #8)
> Who opens a bug report like 'auto_renewal should not default to Yes' ?

Does this seem like a productive question?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24988] autorenew_checkouts should default to yes

2021-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24988

--- Comment #10 from David Cook  ---
(In reply to Marcel de Rooy from comment #8)
> I do not really understand why autorenewal should default to Yes.

I suspect most people would be in favour of autorenewal (I know I am as a
library patron - very handy functionality), and it's more likely there would be
a minority of people wanting to refuse it. Hence default to yes.

> Suppose that you have set Autorenewal off for all your circ rules. And now
> you see allow auto-renewal popping up everywhere..
> This is quite confusing.
> Imo we need more checks than just default to Yes.

As I noted on bug 24476, I don't think it's quite that simple. Even if all the
autorenewals are turned off in the circ rules, you might have current checkouts
that are still marked as autorenewal (which I think still get processed as
autorenewals although I should double-check that), and you can choose to make
an item an "Automatic renewal" by going into "Checkout settings" when checking
out an item.

I do agree though that it's complicated. On the surface, it seems silly to
allow a patron to control an autorenewal setting if the library doesn't
actually use autorenewals, but I think they're conceptually two different
things. One is marking an item as an autorenewal, and the other is the patron
allowing items to be autorenewed. 

(Of course, I wonder why a patron should be able to turn off autorenewal, but I
don't really like how autorenewal has been implemented overall and how it
prevents manual renewals. But that's another matter...)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24476] Allow patrons to opt-out of auto-renewal

2021-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

--- Comment #77 from David Cook  ---
(In reply to Marcel de Rooy from comment #76)
> See also bug 24988. But if a patron has no autorenewal, he should not even
> have this choice. It would be useless and confusing.

It could be confusing for patrons to view and update an autorenewal setting if
no autorenewals are allowed, but I'm not sure that there is a simple reasonable
alternative.

On one hand, you could calculate the circulation rules to determine if a patron
is allowed to have autorenewals.

On the other hand, that wouldn't take into account their existing autorenewal
checkouts *plus* it's possible to set autorenewals at checkout time.

So determining if an item is autorenewable and whether a patron allows
autorenewals seems to me like 2 completely separate things in the end.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29587] Test mail option in SMTP servers

2021-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29587

vimal kumar  changed:

   What|Removed |Added

 CC||vimali...@gmail.com
   Priority|P5 - low|P1 - high

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29020] Missing Background jobs link in admin-home

2021-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29020

--- Comment #24 from David Cook  ---
(This is an aside not directly related to Koha, but I was thinking about this a
little bit the other day, while working with Discourse. It uses Sidekiq
(https://en.wikipedia.org/wiki/Sidekiq) for running it's background tasks. A
top level administrator can just go to http:///sidekiq to see
everything related to background tasks. As far as I can tell, there's no link
to sidekiq from Discourse, but it is handy for the administrators to be able to
trigger and review jobs from there.)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23873] Allow marc modification templates to use capturing groups in substitutions

2021-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23873

AspenCat Team  changed:

   What|Removed |Added

 CC||aspencatt...@clicweb.org

--- Comment #2 from AspenCat Team  ---
I would also like to see substitution work in marc modification templates - or
really anywhere we can use regex (such as batch item modification).  This would
really power-up the regex capabilities. Agree with Andrew that it would be
hugely useful not just for date modification.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29602] We must be nicer with translators

2021-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29602

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16994] Import and export MARC modification templates

2021-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16994

AspenCat Team  changed:

   What|Removed |Added

 CC||aspencatt...@clicweb.org

--- Comment #5 from AspenCat Team  ---
I like to test our marc modification template in sandbox.  If successful and
complicated it would be nice to be able to move to production without manually
copying each line.  I would also like to see a library that we could borrow
modification templates.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29420] HTTP status code incorrect when calling error pages directly under Plack/PSGI

2021-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29420

--- Comment #18 from David Cook  ---
I don't love the solution in my patch as it seems a bit fragile, but it seems
to work in koha-testing-docker and I think it might be the best we can do for
now.

I think the only other viable alternative right now would be not proxying the
ErrorDocument pages from Apache to Starman, which would also be suboptimal. 

But open to other solutions.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29420] HTTP status code incorrect when calling error pages directly under Plack/PSGI

2021-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29420

--- Comment #17 from David Cook  ---
For Liz's use case:

To test:

- mkdir /var/lib/koha/kohadev/public_html
- create an alias in your /etc/apache2/sites-enabled/kohadev.conf file for
something like files
   Alias /files "/var/lib/koha/kohadev/public_html/"
   
 Options +Indexes
 AuthUserFile /var/lib/koha/kohadev/.htpasswd
 AuthName ByPassword
 AuthType Basic
 
   require valid-user
 
   
- make a .htpasswd file: https://hostingcanada.org/htpasswd-generator/ and put
it in /var/lib/koha/kohadev
- service apache2 reload
- navigate to http://localhost:8080/files/, note that the response header in
the browser inspector says "200 OK" and the basic auth user/pass is not shown
- Apply this patch, restart the things
- navigate to http://localhost:8080/files/, note that the response header in
the browser inspector says "401 Unauthorized" and the basic auth user/pass
is now shown

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29420] HTTP status code incorrect when calling error pages directly under Plack/PSGI

2021-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29420

David Cook  changed:

   What|Removed |Added

 Attachment #127364|0   |1
is obsolete||

--- Comment #16 from David Cook  ---
Created attachment 128115
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128115=edit
Bug 29420: HTTP status code incorrect when calling error pages directly under
Plack/PSGI

The error pages wrote a HTTP status code of 200 for all PSGI requests, even
though it should have only done it for PSGI requests from the ErrorDocument
middleware. This patch fixes that.

0) Do not apply patch
1) Open F12 dev tools and go to Network tab
2) Go to http://localhost:8081/files/blah
3) Note that the webpage is a 404 error but HTTP status code is 200
4) Go to http://localhost:8081/cgi-bin/koha/circ/blah
5) Note that the webpage is a 404 error and HTTP status code is 404

6) Apply patch
7) Go to http://localhost:8081/files/blah
8) Note that the webpage is a 404 error and HTTP status code is 404
9) Go to http://localhost:8081/cgi-bin/koha/circ/blah
10) Note that the webpage is a 404 error and HTTP status code is 404

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29420] HTTP status code incorrect when calling error pages directly under Plack/PSGI

2021-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29420

David Cook  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29420] HTTP status code incorrect when calling error pages directly under Plack/PSGI

2021-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29420

David Cook  changed:

   What|Removed |Added

   Assignee|l...@bywatersolutions.com|dc...@prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29420] HTTP status code incorrect when calling error pages directly under Plack/PSGI

2021-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29420

David Cook  changed:

   What|Removed |Added

Summary|401 Unauthorized pages come |HTTP status code incorrect
   |back as 200 OK under plack  |when calling error pages
   ||directly under Plack/PSGI

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29420] 401 Unauthorized pages come back as 200 OK under plack

2021-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29420

--- Comment #15 from David Cook  ---
The ErrorDocument middleware does set up environmental variables prefixed with
"psgix.errordocument" but CGI::Emulate::PSGI strips those out...
https://metacpan.org/dist/CGI-Emulate-PSGI/source/lib/CGI/Emulate/PSGI.pm#L53

So that's annoying.

It's too bad we don't have a Plack-enabled controller for handling these so we
didn't have to emulate the PSGI for CGI scripts, but that's easier said than
done. (I don't have the time/energy for refactoring C4/Templates.pm and
C4/Auth.pm to make things like Bug 26791 or Bug 28325 possible ;).)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29420] 401 Unauthorized pages come back as 200 OK under plack

2021-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29420

--- Comment #14 from David Cook  ---
An easier to maintain option would be to not proxy "/cgi-bin/koha/errors/*"
files to Starman, but... that would probably be short-sighted, since there are
times where we redirect manually to 404.pl as well. For instance:

members/apikeys.pl:print $cgi->redirect("/cgi-bin/koha/errors/404.pl"); #
escape early

So that's not that long-term of a solution...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29420] 401 Unauthorized pages come back as 200 OK under plack

2021-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29420

--- Comment #13 from David Cook  ---
Side note: In /etc/koha/sites/kohadev/plack.psgi I should've put
'/errors/404.pl' instead of 'errors/404.pl' but it seems to work anyway.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29420] 401 Unauthorized pages come back as 200 OK under plack

2021-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29420

David Cook  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #12 from David Cook  ---
Thanks, Martin. I really appreciate your comments.

Since I authored Bug 26048, it probably does make sense for me to make more of
an effort here...

I found something interesting with the status quo:

http://localhost:8081/files/blah
This returns a 404 page with a 200 status. That's bad!

http://localhost:8081/cgi-bin/koha/circ/blahblah
This returns a 404 page with a 404 status. That's good but a bit confusing!

(NOTE: If you do change 404.pl to return a 404 status instead of a 200 status,
it does cause a regression, so that this page now returns a blank page that
just says "not found".)

If we look at /etc/koha/apache-shared-intranet-plack.conf, only /index.html and
path /cgi-bin/koha are proxied to Starman. So it makes sense that they're the
only ones invoking the middleware. 

But if http://localhost:8081/blahblah is using Apache and not Starman, it
shouldn't be setting the environmental variables that cause 404.pl to return a
200 status instead of a 404 status...

Except that Apache's error documents themselves end up calling Starman! 

ErrorDocument 400 /cgi-bin/koha/errors/400.pl
ErrorDocument 401 /cgi-bin/koha/errors/401.pl
ErrorDocument 403 /cgi-bin/koha/errors/403.pl
ErrorDocument 404 /cgi-bin/koha/errors/404.pl
ErrorDocument 500 /cgi-bin/koha/errors/500.pl

So of course the error pages called by Apache will return a 200 page whereas
the ones using the ErrorDocument middleware return the actual error code. (Let
me know if I'm not being clear enough here.)

--

So that's... challenging.

We need a way of differentiating if these error scripts are being called
directly (e.g. Apache asking Starman for it) or by the ErrorDocument
middleware...

One way of doing that might be to inspect the REQUEST_URI environmental
variable. When coming from ErrorDocument, the REQUEST_URI is "errors/404.pl".
When coming from Apache, it's "/intranet/errors/404.pl". 

It doesn't seem like a super robust method, but it's the best I have at the
moment.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29564] Use List::MoreUtils so SIP U16/Xenial does not break

2021-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29564

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Version(s)|21.11.00,21.05.07,20.11.12  |21.11.00,21.05.07,20.11.12,
released in||20.05.18
 Status|Pushed to oldstable |Pushed to oldoldstable

--- Comment #12 from Victor Grousset/tuxayo  ---
Backported: Pushed to 20.05.x branch for 20.05.18

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29605] Add missing UNIQUE constraints in kohastructure.sql (Bug 15067 follow-up)

2021-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605

--- Comment #2 from Tomás Cohen Arazi  ---
Created attachment 128114
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128114=edit
Bug 29605: (follow-up) Add language_script_mapping primary key

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29605] Add missing UNIQUE constraints in kohastructure.sql (Bug 15067 follow-up)

2021-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605

--- Comment #1 from Tomás Cohen Arazi  ---
Created attachment 128113
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128113=edit
Bug 29605: Add missing constraints from bug 15067

This patch fixes a missed update to kohastructure.sql.

To test:
1. Checkout prior to bug 15067
(ab270c026be06f08745a14d1aea992877d20f812) would work.
2.  Run:
   $ reset_all
3. Checkout v21.11.00
4. Run:
   $ updatedatabase
   $ koha-mysql kohadev
   > SHOW CREATE TABLE language_subtag_registry;
=> SUCCESS: There's UNIQUE KEY uniq_lang (subtag, type)
5. Run:
   > SHOW CREATE TABLE language_descriptions;
=>  SUCCESS: There's UNIQUE KEY uniq_desc (subtag, type, lang)
6. Run:
   > SHOW CREATE TABLE language_rfc4646_to_iso639;
=> SUCCESS: There's UNIQUE KEY uniq_code (rfc4646_subtag, iso639_2_code)
7. Replicate a fresh install. Run:
   $ reset_all
8. Repeat 4, 5 and 6
=> FAIL: The UNIQUE constraints are not there!
9. Apply this patch
10. Run:
   $ reset_all
11. Repeat 8
=> SUCCESS: The UNIQUE constraints are there!
12. Sign off :-D

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29605] Add missing UNIQUE constraints in kohastructure.sql (Bug 15067 follow-up)

2021-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26790] Refactor Koha configuration (koha-conf.xml)

2021-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26790

--- Comment #14 from David Cook  ---
I've only used k8s once to play around on my desktop, so I don't know it very
well, but I think it has more robust methods than AWS ECS for deploying
configuration files and managing secrets. 

But overall I think developing in a way that makes it easier to use containers
is a great idea.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26790] Refactor Koha configuration (koha-conf.xml)

2021-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26790

--- Comment #13 from David Cook  ---
(In reply to Tomás Cohen Arazi from comment #12)
> My vote would be:
> - Use separate files with expected names (config.yaml, shibboleth.yaml, etc)
> - No includes
> - Have C4::Context->config rebuild the 'old structure we already have, and
> deal with a different new handling on a separate bug (Koha::Config singleton
> implementation?)
> - Have a way for C4::Context->config to override any configuration if an env
> variable exists. e.g. KOHA_DATABASE_NAME should override the relevant entry.
> 
> My two cents as well

I was thinking something like this as well. 

The other day I was setting up a Dockerized program on AWS ECS using Fargate,
and I used a combination of file-based configuration with environmental
variables passed by the orchestrator (ie AWS ECS) to override particular
relevant entries. 

Using Fargate was very cost effective (the bill is $0 since it's a very short
lived program) but it did make it more challenging in terms of providing
customized configuration files, since you don't have any control of the Docker
host. The de facto ECS approach there seemed to be to have an additional custom
container for pulling in configuration files from external sources and then
mounting them into to shared volume with the application container.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29605] Add missing UNIQUE constraints in kohastructure.sql (Bug 15067 follow-up)

2021-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605

Tomás Cohen Arazi  changed:

   What|Removed |Added

   Keywords||rel_21_11_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29605] Add missing UNIQUE constraints in kohastructure.sql (Bug 15067 follow-up)

2021-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m,
   ||jonathan.druart+koha@gmail.
   ||com,
   ||n...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25078] Update DB process - wrap each DBRev inside a transaction and better error handling

2021-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078

Fridolin Somers  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #119 from Fridolin Somers  ---
Note than new process is explained in wiki :
https://wiki.koha-community.org/wiki/Database_updates#Pushing_to_a_branch

Great job \o/

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29564] Use List::MoreUtils so SIP U16/Xenial does not break

2021-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29564

Fridolin Somers  changed:

   What|Removed |Added

 Version(s)|21.11.00,20.11.12,21.05.07  |21.11.00,21.05.07,20.11.12
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29564] Use List::MoreUtils so SIP U16/Xenial does not break

2021-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29564

Fridolin Somers  changed:

   What|Removed |Added

 Status|Pushed to stable|Pushed to oldstable

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15067] Add additional languages to advanced search language search

2021-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15067

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Blocks||29605


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605
[Bug 29605] Add missing UNIQUE constraints in kohastructure.sql (Bug 15067
follow-up)
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29605] Add missing UNIQUE constraints in kohastructure.sql (Bug 15067 follow-up)

2021-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605

Tomás Cohen Arazi  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com
   |ity.org |
 Status|NEW |ASSIGNED
 Depends on||15067


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15067
[Bug 15067] Add additional languages to advanced search language search
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29605] New: Add missing UNIQUE constraints in kohastructure.sql (Bug 15067 follow-up)

2021-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605

Bug ID: 29605
   Summary: Add missing UNIQUE constraints in kohastructure.sql
(Bug 15067 follow-up)
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Database
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: tomasco...@gmail.com
QA Contact: testo...@bugs.koha-community.org

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15067] Add additional languages to advanced search language search

2021-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15067

--- Comment #34 from Tomás Cohen Arazi  ---
(In reply to Tomás Cohen Arazi from comment #32)
> The latest patch should be pushed before the 21.11 packages are out. If not,
> a new DBREv is needed for fresh 21.11.00 installs. Upgrading works fine.

We agreed the patch can wait for .01 so I'm moving to a separate bug, to better
handle it by the QA team.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15067] Add additional languages to advanced search language search

2021-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15067

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Attachment #128112|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29596] Add Yiddish language

2021-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29596

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Depends on|15067   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15067
[Bug 15067] Add additional languages to advanced search language search
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18493] Add more languages to advanced search languages dropdown

2021-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18493
Bug 18493 depends on bug 15067, which changed state.

Bug 15067 Summary: Add additional languages to advanced search language search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15067

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15067] Add additional languages to advanced search language search

2021-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15067

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|REOPENED|RESOLVED
 Blocks|29596   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29596
[Bug 29596] Add Yiddish language
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15067] Add additional languages to advanced search language search

2021-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15067

Mason James  changed:

   What|Removed |Added

 CC||m...@kohaaloha.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29600] Sorting Checkout History no longer supports Author Sort

2021-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29600

--- Comment #1 from Owen Leonard  ---
If it were up to me I'd advise users to use the quick search filter at the top
of the table instead because adding a table column makes everything spread out
wider. That's just my personal preference though.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29602] We must be nicer with translators

2021-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29602

--- Comment #6 from Owen Leonard  ---
What about Bug 26392?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29602] We must be nicer with translators

2021-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29602

Jonathan Druart  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29596] Add Yiddish language

2021-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29596

--- Comment #8 from David Nind  ---
I have tested on top of bug 15067.

After applying 29956 I ran databaseupdate several times (x4) - this makes the
language appear multiple times (x4) as well.

I'm not sure that is what you meant though...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29564] Use List::MoreUtils so SIP U16/Xenial does not break

2021-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29564

Kyle M Hall  changed:

   What|Removed |Added

 Version(s)|21.11.00,20.11.12,21.05.05  |21.11.00,20.11.12,21.05.07
released in||

--- Comment #11 from Kyle M Hall  ---
Pushed to 21.05.x for 21.05.07, not .05

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29564] Use List::MoreUtils so SIP U16/Xenial does not break

2021-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29564

Kyle M Hall  changed:

   What|Removed |Added

 Version(s)|21.11.00,20.11.12   |21.11.00,20.11.12,21.05.05
released in||
 Status|Pushed to master|Pushed to stable

--- Comment #10 from Kyle M Hall  ---
Pushed to 21.05.x for 21.05.05

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15067] Add additional languages to advanced search language search

2021-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15067

David Nind  changed:

   What|Removed |Added

 Attachment #128105|0   |1
is obsolete||

--- Comment #33 from David Nind  ---
Created attachment 128112
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128112=edit
Bug 15067: (QA follow-up) Add missing UNIQUE constraint in kohastructure.sql

To test:
1. Run:
   $ reset_all
   $ koha-mysql kohadev
   > SHOW CREATE TABLE language_descriptions;
=> FAIL: There is KEY `subtag_type_lang` (`subtag`,`type`,`lang`)
2. Apply this patch
3. Repeat 1
=> SUCCESS: UNIQUE KEY `subtag_type_lang` (`subtag`,`type`,`lang`)

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29604] New: term highlighting adds unwanted pseudo element in the contentblock of OPAC details page

2021-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29604

Bug ID: 29604
   Summary: term highlighting adds unwanted pseudo element in the
contentblock of OPAC details page
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: lu...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

Created attachment 128111
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128111=edit
example

To recreate:

1. Do a search that will give you lots of term highlighting, I just searched
for 'e' in koha-testing-docker.
2. Go to a record with some MARC 505 notes, this HTML element is
'contentblock'. 
3. Notice the CSS pseudo element with this property 'content: "→ ";'
4. The very first time you see a match in the term highlight ( in my case 'e'),
the → is added. 

This is because of this:


.contentblock :first-child::before {
content: "→ ";
}

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29603] New: Fix responsive behavior of facets menu in OPAC search results

2021-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29603

Bug ID: 29603
   Summary: Fix responsive behavior of facets menu in OPAC search
results
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: normal
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org

Created attachment 128110
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128110=edit
Screen grab showing the transition from sidebar to collapsed menu (19.11.x)

We have some JS in the OPAC which is supposed to help gracefully hide and show
the OPAC search results facets menu at narrower browser widths. It was working
in 19.11.x At some point this was broken and the menu shows below the search
results.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29420] 401 Unauthorized pages come back as 200 OK under plack

2021-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29420

--- Comment #11 from Martin Renvoize  ---
OK.. the documentation for Plack::Middleware::ErrorDocument clearly states:

> When using a subrequest, the subrequest should return a regular '200' 
> response.

So, as we're enabling subrequest => 1 I'm sure David has got a point.. Now,
I've not dug into it deeply myself yet and I'm no expert in this area.. but
that does raise alarm bells in my mind.. We certainly need to be diligent in
checking for regressions here.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29599] addorderiso2709.pl - Discount is stored as value below 1 instead of actual percentage

2021-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29599

Christophe TORIN  changed:

   What|Removed |Added

 Resolution|--- |INVALID
 Status|NEW |RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29602] We must be nicer with translators

2021-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29602

--- Comment #5 from Jonathan Druart  ---
With this second patch we get:

+#. For the first occurrence,
+#. %1$s:  e | html 
+#: koha-tmpl/intranet-tmpl/prog/en/modules/about.tt:288
+#:
koha-tmpl/intranet-tmpl/prog/en/includes/background_jobs/batch_hold_cancel.inc:38
+msgid "Unknown error '%s'."

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29602] We must be nicer with translators

2021-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29602

Jonathan Druart  changed:

   What|Removed |Added

 Attachment #128108|0   |1
is obsolete||

--- Comment #4 from Jonathan Druart  ---
Created attachment 128109
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128109=edit
Bug 29602: Surround strings with span tag

To be nicer with translators.

Update the PO files for whichever languages will show how this is
useful.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29420] 401 Unauthorized pages come back as 200 OK under plack

2021-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29420

Martin Renvoize  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com

--- Comment #10 from Martin Renvoize  ---
Take a step back everyone ;)

David was merely suggesting things to check to whoever takes on the QA.. I
don't see that as a blocker. I see that as someone trying to lend a hand where
they can.

We're all battling with various pressures on our time and we do what we can do.
 It's not at all constructive to call people out on their lack of time unless
you can somehow help free up some time for them to contribute more ;).

Also, remember that Koha is an aging beast... we're trying hard to make it more
modern and the move to Plack is part of that.. David has taken us in the right
direction by improving our error pages when they're served under this way of
running.  None of us are experts in everything.. and our poor QA team are
expected to dig in and get to grips with all area's even if their expertise is
being stretched.. we're all Human.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29602] We must be nicer with translators

2021-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29602

--- Comment #3 from Jonathan Druart  ---
An example with "Unknown error":


-#. %1$s:  END 
-#. %2$s:  SWITCH m.error 
-#. %3$s:  CASE 'hold_not_found' 
-#. %4$s:  m.hold_id | html 
-#. %5$s:  CASE 
-#. %6$s:  m.error | html 
-#. %7$s:  END 
-#. %8$s:  CASE 'hold_cancelled' 
-#:
koha-tmpl/intranet-tmpl/prog/en/includes/background_jobs/batch_hold_cancel.inc:31
-#, c-format
-msgid ""
-"has not been cancelled. %s An error occurred on cancelling. %s %s No hold "
-"with id %s found. %sUnknown error '%s'. %s %s Hold on "
-msgstr ""


-#. %1$s:  FOR e IN log4perl_errors 
-#. %2$s:  SWITCH e 
-#. %3$s:  CASE 'missing_config_entry' 
-#. %4$s:  CASE 'cannot_read_config_file' 
-#. %5$s:  CASE 'logfile_not_writable' 
-#. %6$s:  CASE 'cannot_init_module' 
-#. %7$s:  CASE 
-#. %8$s:  e | html 
-#. %9$s:  END 
-#. %10$s:  END 
-#. %11$s:  END 
-#. %12$s:  IF warnConnectBroker 
-#: koha-tmpl/intranet-tmpl/prog/en/modules/about.tt:281
-#, c-format
-msgid ""
-"%s %s %sThere is no 'log4perl_conf' entry in the config file. %sThe log4perl
"
-"config file cannot be opened. %sOne of the logfiles listed in the config "
-"file is not writable. %sThe Koha::Logger module cannot be initiated "
-"correctly (check the log file). %sUnknown error \"%s\" %s %s %s %s "
-msgstr ""
-"%s %s %sIl n'y a pas d'entrée \"log4perl_conf\" dans le fichier de config. "
-"%sImpossible d'ouvrir le fichier de config log4perl. %sUn des fichiers de "
-"log recensé dans le fichier de config n'est pas accessible en écriture. "
-"%sImpossible d'initialiser correctement le module Koha::Logger (vérifier le "
-"fichier de log). %sErreur inconnue \"%s\" %s %s %s %s "



+#. %1$s:  e | html 
+#: koha-tmpl/intranet-tmpl/prog/en/modules/about.tt:288
+#, fuzzy, c-format
+msgid "Unknown error \"%s\""
+msgstr "Erreur inconnue."
+
+#. %1$s:  m.error | html 
+#:
koha-tmpl/intranet-tmpl/prog/en/includes/background_jobs/batch_hold_cancel.inc:38
+#, fuzzy, c-format
+msgid "Unknown error '%s'."
+msgstr "Erreur inconnue."

Could even be improved as there is a " vs ', but you got the idea.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29602] We must be nicer with translators

2021-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29602

Jonathan Druart  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m,
   ||katrin.fisc...@bsz-bw.de,
   ||martin.renvoize@ptfs-europe
   ||.com, tomasco...@gmail.com
 Status|ASSIGNED|In Discussion

--- Comment #2 from Jonathan Druart  ---
This is a nightmare. For translators (current situation) and for developer (to
write the patch).
I think we need the work to be done very quickly to push it very soon this
cycle. I can continue the work but I need to get commitment for SO and QA. It
must be pushed in the week it has been written, it will be impossible to
rebase.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29602] We must be nicer with translators

2021-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29602

--- Comment #1 from Jonathan Druart  ---
Created attachment 128108
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128108=edit
Bug 29602: Surround strings with span tag

To be nicer with translators.

Update the PO files for whichever languages will show how this is
useful.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29602] We must be nicer with translators

2021-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29602

Jonathan Druart  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=29589

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29589] Translation issue with formatting in MARC overlay rules page

2021-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29589

Jonathan Druart  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=29602
 CC||jonathan.druart+koha@gmail.
   ||com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29602] New: We must be nicer with translators

2021-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29602

Bug ID: 29602
   Summary: We must be nicer with translators
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Templates
  Assignee: jonathan.druart+k...@gmail.com
  Reporter: jonathan.druart+k...@gmail.com
QA Contact: testo...@bugs.koha-community.org

The PO files are really ugly sometimes, the number of %s and the inclusion of
TT tags make the translation a nightmare for translators.

We can improve that.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29601] The list download option ISBD is useless when you cleared OPACISBD

2021-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29601

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #3 from Marcel de Rooy  ---
More than trivial: self signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29601] The list download option ISBD is useless when you cleared OPACISBD

2021-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29601

--- Comment #2 from Marcel de Rooy  ---
Created attachment 128107
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128107=edit
Bug 29601: Lists: Test OPACISBD before showing ISBD download

Test plan:
Check if you see Download/ISBD for a list on OPAC.
Clear OPACISBD.
Check if the link is gone.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29601] The list download option ISBD is useless when you cleared OPACISBD

2021-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29601

Marcel de Rooy  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29601] The list download option ISBD is useless when you cleared OPACISBD

2021-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29601

--- Comment #1 from Marcel de Rooy  ---
Note that the option is not even listed on the staff counterpart.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29601] The list download option ISBD is useless when you cleared OPACISBD

2021-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29601

Marcel de Rooy  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|koha-b...@lists.koha-commun |m.de.r...@rijksmuseum.nl
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29601] New: The list download option ISBD is useless when you cleared OPACISBD

2021-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29601

Bug ID: 29601
   Summary: The list download option ISBD is useless when you
cleared OPACISBD
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Lists
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: m.de.r...@rijksmuseum.nl
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

Template just contains:

ISBD

We c/should test OPACISBD here?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29600] New: Sorting Checkout History no longer supports Author Sort

2021-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29600

Bug ID: 29600
   Summary: Sorting Checkout History no longer supports Author
Sort
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: ke...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

Prior to 21.05, patrons could sort their reading history by title, author,
checkout date. Unfortunately, a change that happened in 21.05 created arrows
for patrons to sort by the specific columns in the checkout history. This fix
makes it so patrons can't sort by author, as it is combined with the title. Can
we bring back this ability to sort by author?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15067] Add additional languages to advanced search language search

2021-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15067

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Blocks||29596
   See Also|https://bugs.koha-community |
   |.org/bugzilla3/show_bug.cgi |
   |?id=29596   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29596
[Bug 29596] Add Yiddish language
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29596] Add Yiddish language

2021-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29596

Tomás Cohen Arazi  changed:

   What|Removed |Added

   See Also|https://bugs.koha-community |
   |.org/bugzilla3/show_bug.cgi |
   |?id=15067   |
 Depends on||15067

--- Comment #7 from Tomás Cohen Arazi  ---
David, please retest now. Your question made me dig a bit further on the
subject and an adjustment was needed for RTL, specifying hebrew scripts are
used to write yiddish, etc.

And found a bug on bug 15067, so please test on top of the latest follow-up on
that bug if interested in checking the atomic update can be run many times and
results will be the same (i.e. language is added only once).


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15067
[Bug 15067] Add additional languages to advanced search language search
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29596] Add Yiddish language

2021-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29596

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Attachment #128104|0   |1
is obsolete||

--- Comment #6 from Tomás Cohen Arazi  ---
Created attachment 128106
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128106=edit
Bug 29596: Add Yiddish language

This patch adds the Yiddish language to Koha. The language codes were
taken from https://www.loc.gov/standards/iso639-2/php/code_list.php

Sponsored-by: Universidad Nacional de San Martín

Signed-off-by: Tomas Cohen Arazi 
Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15067] Add additional languages to advanced search language search

2021-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15067

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18493] Add more languages to advanced search languages dropdown

2021-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18493
Bug 18493 depends on bug 15067, which changed state.

Bug 15067 Summary: Add additional languages to advanced search language search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15067

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15067] Add additional languages to advanced search language search

2021-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15067

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
   Keywords|Academy |additional_work_needed
 CC||tomasco...@gmail.com
 Resolution|FIXED   |---

--- Comment #32 from Tomás Cohen Arazi  ---
The latest patch should be pushed before the 21.11 packages are out. If not, a
new DBREv is needed for fresh 21.11.00 installs. Upgrading works fine.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15067] Add additional languages to advanced search language search

2021-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15067

--- Comment #31 from Tomás Cohen Arazi  ---
Created attachment 128105
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128105=edit
Bug 15067: (QA follow-up) Add missing UNIQUE constraint in kohastructure.sql

To test:
1. Run:
   $ reset_all
   $ koha-mysql kohadev
   > SHOW CREATE TABLE language_descriptions;
=> FAIL: There is KEY `subtag_type_lang` (`subtag`,`type`,`lang`)
2. Apply this patch
3. Repeat 1
=> SUCCESS: UNIQUE KEY `subtag_type_lang` (`subtag`,`type`,`lang`)

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29599] New: addorderiso2709.pl - Discount is stored as value below 1 instead of actual percentage

2021-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29599

Bug ID: 29599
   Summary: addorderiso2709.pl - Discount is stored as value below
1 instead of actual percentage
 Change sponsored?: ---
   Product: Koha
   Version: 20.11
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: christophe.to...@univ-rennes2.fr
QA Contact: testo...@bugs.koha-community.org

When adding an order from a staged file, the discount amount is stored as the
value below 1 instead of the actual percentage.
e.g. if you enter a disount of 25%, the stored value is 0.25 instead of 25.

The percentage is currently stored as is everywhere else (when you add from
suggestions, or the discount amount stored in the bookseller info)

The discounted price is correctly calculated at first, but if the order is
modified afterwards, the wrong discount is used, and the resulting prices are
false.

This was seen on version 20.11, but is still relevant on the latest versions.

In the code, it is because of the way the value is handled :
in addorderiso2709.pl, lines 166, 279 & 340 , the discount value is divided by
100 and later it is stored like this.

The value should be used as is, then when calculating the prices, divide it by
100 if necessary.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29596] Add Yiddish language

2021-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29596

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Attachment #128097|0   |1
is obsolete||

--- Comment #5 from Tomás Cohen Arazi  ---
Created attachment 128104
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128104=edit
Bug 29596: Add Yiddish language

This patch adds the Yiddish language to Koha. The language codes were
taken from https://www.loc.gov/standards/iso639-2/php/code_list.php

Sponsored-by: Universidad Nacional de San Martín

Signed-off-by: Tomas Cohen Arazi 
Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29598] New: Add a preference for default borrower's notice language

2021-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29598

Bug ID: 29598
   Summary: Add a preference for default borrower's notice
language
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Patrons
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: m.de.r...@rijksmuseum.nl
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

Notice language for a new borrower via staff interface defaults to language of
the staff interface user.
In the OPAC self registration does not list the field and the value will be set
to the database default called ... 'default'.

Would be nice if we could make that more consistent.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29589] Translation issue with formatting in MARC overlay rules page

2021-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29589

--- Comment #1 from Jonathan Druart  ---
Created attachment 128103
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128103=edit
Bug 29589: MARCOverlayRules - fix translatability issue

Strings must not contain html tags, we should use KohaSpan instead.

Test plan:
Apply the patch, update translation for a given language, edit
XX-YY-staff-prog.po

Notice that the string is now
"The %s preference is not set, don't forget to enable it for rules to take
effect."

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29589] Translation issue with formatting in MARC overlay rules page

2021-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29589

Jonathan Druart  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15067] Add additional languages to advanced search language search

2021-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15067

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Blocks||18493


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18493
[Bug 18493] Add more languages to advanced search languages dropdown
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18493] Add more languages to advanced search languages dropdown

2021-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18493

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com
 Depends on||15067


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15067
[Bug 15067] Add additional languages to advanced search language search
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18493] Add more languages to advanced search languages dropdown

2021-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18493

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Depends on||29596


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29596
[Bug 29596] Add Yiddish language
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29596] Add Yiddish language

2021-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29596

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Blocks||18493
 CC||frede...@tamil.fr
  Component|OPAC|I18N/L10N


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18493
[Bug 18493] Add more languages to advanced search languages dropdown
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29440] Refactor/clean up bulkmarcimport.pl

2021-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29440

David Gustafsson  changed:

   What|Removed |Added

 Blocks||29597


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29597
[Bug 29597] Add tomarcplugin option to bulkmarcimport.pl
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29597] Add tomarcplugin option to bulkmarcimport.pl

2021-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29597

David Gustafsson  changed:

   What|Removed |Added

 Depends on||29440


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29440
[Bug 29440] Refactor/clean up bulkmarcimport.pl
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29597] New: Add tomarcplugin option to bulkmarcimport.pl

2021-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29597

Bug ID: 29597
   Summary: Add tomarcplugin option to bulkmarcimport.pl
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Tools
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: glask...@gmail.com
QA Contact: testo...@bugs.koha-community.org

This patch provides a tomarcplugin option for bulkmarcimport.pl. There already
is a "localcust" option that provides kind of the same functionality, but an
option for providing a plugin is for example useful as "to_marc"-plugins can
also selected in the "Format" dropdown when staging imports in the staff
interface. So if there for example are some marc transformations/processing
that should be enforced both routes of import a plugin can be created and used
in both cases.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29592] Imported records should not be completed with defaultvalues

2021-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29592

Marcel de Rooy  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com,
   ||n...@bywatersolutions.com

--- Comment #3 from Marcel de Rooy  ---
Martin, Nick: What do you think?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29556] MARC21slim2MODS.xsl broken by duplicate template name "part"

2021-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29556

--- Comment #6 from Owen Leonard  ---
> koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2MADS.xsl

This seems to be an authority record export format which can be tested by
viewing an authority in the staff interface and choosing Save -> MADS. The
export appears to work correctly.

> koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2MODS3-1.xsl

This seems to be a bibliographic record export format which can be tested by
viewing a bibliographic record in the staff interface and choosing Save ->
MODS. The export appears to work correctly.

> koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2MODS3.xsl
> koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2MODS32.xsl

These two files appear to be unused. I could only find references to them in
.po files.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29588] Yesterday and tomorrow in datepicker don't translate

2021-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29588

Jonathan Druart  changed:

   What|Removed |Added

   Keywords||rel_21_11_candidate
   Assignee|koha-b...@lists.koha-commun |jonathan.druart+koha@gmail.
   |ity.org |com
 CC||jonathan.druart+koha@gmail.
   ||com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29588] Yesterday and tomorrow in datepicker don't translate

2021-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29588

--- Comment #7 from Jonathan Druart  ---
Created attachment 128102
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128102=edit
Bug 29588: (bug 29478 follow-up) Make strings translatable

"or", "Yesterday", "Today" and "Tomorrow" are not translatable, we are
using __ when _ should be used (__ is for .js files only).

Test plan:
0. Apply the patch
1. cd misc/translator && perl translate update fr-FR
2. Edit misc/translator/po/fr-FR-staff-prog.po
Search for "or", "Yesterday", "Today" and "Tomorrow" and translate them
3. cd misc/translator && perl translate install fr-FR
4. Enable fr-FR (syspref 'language')
5. Edit a patron and an item and confirm that the flatpickr widget has
the strings correctly translated

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29588] Yesterday and tomorrow in datepicker don't translate

2021-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29588

Jonathan Druart  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24119] Records indexed into ES during tests are not removed by rollback

2021-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24119

Andreas Jonsson  changed:

   What|Removed |Added

 CC||andreas.jons...@kreablo.se

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11055] Add 'minutes' as a load period unit

2021-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11055

Janet McGowan  changed:

   What|Removed |Added

 CC||janet.mcgowan@ptfs-europe.c
   ||om

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8822] Public calendar

2021-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8822

Janet McGowan  changed:

   What|Removed |Added

 CC||janet.mcgowan@ptfs-europe.c
   ||om

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6796] Overnight checkouts taking into account opening and closing hours

2021-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796

Janet McGowan  changed:

   What|Removed |Added

 CC||janet.mcgowan@ptfs-europe.c
   ||om

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >