[Koha-bugs] [Bug 29875] Update text on MaxReserves system preference to describe functionality.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29875 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29875] Update text on MaxReserves system preference to describe functionality.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29875 Marcel de Rooy changed: What|Removed |Added Attachment #129455|0 |1 is obsolete|| --- Comment #8 from Marcel de Rooy --- Created attachment 129463 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129463=edit Bug 29875: Update wording on maxreserves system preference To test: 1 - see the current wording 2 - apply patch 3 - words are changed Test to confirm accuracy of wording: 1 - set maxreserves to 1 2 - set all/all circ rule to unlimited holds allowed total, holds allowed daily, and holds per record 3 - confirm you can place 1 hold for a patron, but the second is blocked 4 - set maxreserves to 0 5 - confirm you can place and number of holds for the patron 6 - set maxreserves to blank 7 - confirm you can place any number of holds for the patron Signed-off-by: Tomas Cohen Arazi Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29875] Update text on MaxReserves system preference to describe functionality.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29875 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29705] Test suite has some IssuingRules left-overs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29705 Fridolin Somers changed: What|Removed |Added Status|Passed QA |Failed QA --- Comment #4 from Fridolin Somers --- Oups t/db_dependent/Koha/IssuingRules.t fails. We can remove the file. And there is still t/db_dependent/Koha/IssuingRules/guess_article_requestable_itemtypes.t. We should simply rename forder. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29869] Add Koha::Hold->fill
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29869 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29523] Add a way to prevent embedding objects that should not be allowed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29523 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #42 from Marcel de Rooy --- Looking at the complete patch set, this raises enough questions to consider it as not ready for production. Should we discuss this in a larger audience? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29523] Add a way to prevent embedding objects that should not be allowed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29523 Marcel de Rooy changed: What|Removed |Added Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29523] Add a way to prevent embedding objects that should not be allowed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29523 Marcel de Rooy changed: What|Removed |Added QA Contact||m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29523] Add a way to prevent embedding objects that should not be allowed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29523
--- Comment #41 from Marcel de Rooy ---
+sub is_accessible_in_context {
+my ( $self, $params ) = @_;
+
+# FIXME? It felt tempting to return 0 instead
+# but it would mean needing to explicitly add the 'user'
+# param in all tests...
+return 1
+ unless $params->{user};
+
+my $consumer = $params->{user};
+return $consumer->can_see_patron_infos($self);
+}
User, consumer, patron. Unclear.
The FIXME tells me that we should think a little bit more about what we really
want to do here?
We should obviously try to avoid adding it like this.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29838] No string interpolation when expected in t/db_dependent/ImportBatch.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29838 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #3 from Fridolin Somers --- Patch obsolete by mistake ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29523] Add a way to prevent embedding objects that should not be allowed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29523
--- Comment #40 from Marcel de Rooy ---
-sub accessible {
+sub is_accessible_in_context {
my ($self) = @_;
-return $self->_get_objects_class->search_limited(
-{
-map { $_ => $self->$_ }
- $self->_result->result_source->primary_columns
-}
- )->count > 0
- ? 1
- : 0;
+return 1;
}
This happens in the last patch (from another author). This mystifies matters.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29813] skeleton.pl missing semicolon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29813 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #6 from Fridolin Somers --- I impacted wiki page https://wiki.koha-community.org/wiki/Database_updates#How_to_write_an_atomicupdate_file -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29523] Add a way to prevent embedding objects that should not be allowed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29523 --- Comment #39 from Marcel de Rooy --- -return unless $self->accessible; +return unless $self->is_accessible_in_context($params); Not sure if this is an improvement. Access probably always needs a context, so it seems implicit. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29523] Add a way to prevent embedding objects that should not be allowed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29523
--- Comment #38 from Marcel de Rooy ---
+sub accessible {
+my ($self) = @_;
+
+return $self->_get_objects_class->search_limited(
+{
+map { $_ => $self->$_ }
+ $self->_result->result_source->primary_columns
+}
+ )->count > 0
+ ? 1
+ : 0;
+}
At first glance this looks like a great performance killer.
If we are in the singular object already, it should be very cheap to see if
user A has access.
Okay, we might have to duplicate a bit of code in accessible and search_limited
to make that work, but save performance. Which might be a more important gain.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28670] api/v1/patrons_holds.t is failing randomly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28670 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #1 from Fridolin Somers --- Still valid : https://jenkins.koha-community.org/view/master/job/Koha_Master_D11_CPAN/510/testReport/ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29523] Add a way to prevent embedding objects that should not be allowed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29523 --- Comment #37 from Marcel de Rooy --- Out of scope, but heh: libraries_where_can_see_patrons This is a really awful name -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29523] Add a way to prevent embedding objects that should not be allowed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29523 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl --- Comment #36 from Marcel de Rooy --- +my $type = ref($self); + +$type =~ s|Schema::Result::||; +return $type . "s"; Frowning. Educated guess? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29882] remove unrequired package definitions in list-deps script
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29882 --- Comment #1 from Mason James --- Created attachment 129462 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129462=edit Bug 29882 - remove unrequired package definitions in list-deps script to test... - apply patch, rebuild new package - install new koha-common pkg successfully -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29882] remove unrequired package definitions in list-deps script
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29882 Mason James changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29882] New: remove unrequired package definitions in list-deps script
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29882 Bug ID: 29882 Summary: remove unrequired package definitions in list-deps script Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Packaging Assignee: koha-bugs@lists.koha-community.org Reporter: m...@kohaaloha.com QA Contact: testo...@bugs.koha-community.org CC: m...@kohaaloha.com to test... - apply patch, rebuild new package - install new koha-common pkg on successfully -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29881] libdbd-sqlite2-perl is unavailable on deb12 (koha-common wont install)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29881 --- Comment #1 from Mason James --- Created attachment 129461 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129461=edit Bug 29881: libdbd-sqlite2-perl is unavailable on deb12 (koha-common wont install) to test... - attempt to install koha-common pkg on deb12 confirm error... The following packages have unmet dependencies: koha-common : Depends: libdbd-sqlite2-perl but it is not installable - apply patch, rebuild new package - install new koha-common pkg on deb12 successfully -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29881] libdbd-sqlite2-perl is unavailable on deb12 (koha-common wont install)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29881 Mason James changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4269] Module DBD::SQLite2 requirement will cause problems
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4269 Mason James changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=29881 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29881] libdbd-sqlite2-perl is unavailable on deb12 (koha-common wont install)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29881 Mason James changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=4269 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29881] New: libdbd-sqlite2-perl is unavailable on deb12 (koha-common wont install)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29881 Bug ID: 29881 Summary: libdbd-sqlite2-perl is unavailable on deb12 (koha-common wont install) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Packaging Assignee: koha-bugs@lists.koha-community.org Reporter: m...@kohaaloha.com QA Contact: testo...@bugs.koha-community.org CC: m...@kohaaloha.com to test... - attempt to install koha-common pkg on deb12 confirm error... The following packages have unmet dependencies: koha-common : Depends: libdbd-sqlite2-perl but it is not installable - apply patch, rebuild new package - install new koha-common pkg on deb12 successfully -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19501] New list category to restrict specific lists to staff & hide from OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19501 Alex Buckley changed: What|Removed |Added Status|ASSIGNED|NEW --- Comment #10 from Alex Buckley --- Correction: Set it back to 'New'! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19501] New list category to restrict specific lists to staff & hide from OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19501 Alex Buckley changed: What|Removed |Added Status|In Discussion |ASSIGNED --- Comment #9 from Alex Buckley --- (In reply to Marcel de Rooy from comment #8) > If I am reading the comment from Jeremy again (from 2017..) and my response > in 2017, they could have used private lists shared between the needed staff > members at that time already (but using OPAC) without the need for any code > changes. > > I think there is a report about adding code for supporting shared lists in > staff too. > > But I would certainly not oppose a permission scheme that allows selected > staff members to view *some* lists. Just another road. In the past we were > very cautious here in view of privacy issues though. But there should be > ways to address that and inform users accordingly. Hi Marcel, Thanks for your reply. Yep, that makes sense. I may revisit this and try to submit a patch for it, separately from my work on bug 26346. But will leave the assignee as 'koha-bugs@lists.koha-community.org' for now and set it back to 'Assigned', in case someone else wants to work on it. Thanks, Alex -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22827] Automatic item modifications by age: add age depencency on other field(s) than dateaccessioned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22827 Alex Buckley changed: What|Removed |Added Status|ASSIGNED|Needs Signoff --- Comment #11 from Alex Buckley --- Hi Andrew and Martin, Martin: Thank you for your reply in comment #6. My concerns with hard coding were: 1. Everytime a datetime column is added to the items table then the community would have to remember to update this hardcoded list of columns. 2. If an existing datetime column is removed/renamed then the hardcoded list would have to be updated otherwise my alterations to C4::Items->ToggleNewStatus() would throw an error. As the hardcoded list determines what column is queried. But as you say doing an introspect of the koha::Object may not be worthwhile. So I have left the hardcoded list for now. I'm happy to add it later though if that is what QA wants. Andrew: I have corrected the test plan. That error you encountered was because my test plan noted an incorrect unit test filepath. So it was not your error :) Could you please re-test now? Many thanks! Alex -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22827] Automatic item modifications by age: add age depencency on other field(s) than dateaccessioned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22827 --- Comment #10 from Alex Buckley --- Created attachment 129460 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129460=edit Bug 22827: Add age dependency on other fields than dateaccessioned A new agefield has been added to the 'Automatic item modifications by age' tool. The options for the agefield are: replacementpricedate, datelastborrowed, datelastseen, damaged_on, itemlost_on, withdrawn_on If no option is selected then Koha will default to saving 'agefield' = items.dateaccessioned Similarly, if a Koha instance has an old item rule without 'agefield' defined then Koha will default to using 'items.dateaccessioned'. This is confirmed by the AutomaticItemModificationByAge.t unit test. Test plan: 1. Go to: Tools > Catalog > Automatic item modifications by age 2. Observe there is a new 'Age field' dropdown in the rule form. 3. Create a rule, set the values: - 'Age in days' = 20 - Leave 'Age field' = 'Choose an age field' - 'Substitutions': 'items.barcode' = 'test' - Save the rule 4. Confirm the 'List of rules' page displays 'items.dateaccessioned in the 'Age field' column 5. Add another rule: - 'Age in days' = 2 - 'Age field' = 'items.datelastseen' - 'Substitutions': 'items.barcode' = 'test2' - Save the rule 6. Confirm the 'List of rules' page displays 'items.datelastseen' in the 'Age field' column for that second rule 7. Add some more rules and confirm you can delete them 8. Edit a record: - Make the items.dateaccessioned = 3 day ago (so rule 1 is false) - Make the items.datelastseen = 3 days ago (so rule 2 is true) 9. Run the automatic_items_modification_by_age.pl: - sudo koha-shell - cd misc/cronjobs - ./automatic_item_modification_by_age.pl -v -c 10. Confirm the item has it's barcode set to 'test2' 11. Run unit tests: - sudo koha-shell - prove t/db_dependent/Items/AutomaticItemModificationByAge.t -v Sponsored-By: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22827] Automatic item modifications by age: add age depencency on other field(s) than dateaccessioned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22827 Alex Buckley changed: What|Removed |Added Attachment #129371|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29875] Update text on MaxReserves system preference to describe functionality.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29875 Tomás Cohen Arazi changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #7 from Tomás Cohen Arazi --- (In reply to Andrew Fuerste-Henry from comment #5) > Added a sentence: "Additional limits may apply based on circulation rules." Great. Hope Katrin signs it so it can be added before string freeze! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29736] Error when placing a hold for a club without members
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29736 --- Comment #10 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 濾 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29736] Error when placing a hold for a club without members
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29736 Fridolin Somers changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||22.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29735] Remove flatpickr instantiations from .js files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29735 --- Comment #5 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 濾 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29735] Remove flatpickr instantiations from .js files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29735 Fridolin Somers changed: What|Removed |Added Version(s)||22.05.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29552] flatpickr quick shortcuts should be 'Disabled' for invalid dates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29552 --- Comment #21 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 濾 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29552] flatpickr quick shortcuts should be 'Disabled' for invalid dates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29552 Fridolin Somers changed: What|Removed |Added Version(s)||22.05.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29530] When NumSavedReports is set, show value in pull down of entries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29530 --- Comment #11 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 濾 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29530] When NumSavedReports is set, show value in pull down of entries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29530 Fridolin Somers changed: What|Removed |Added Version(s)||22.05.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29516] Remove dependency on IO::Scalar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29516 --- Comment #4 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 濾 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29516] Remove dependency on IO::Scalar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29516 Fridolin Somers changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||22.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29491] Improve display of notices in patron details
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29491 --- Comment #11 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 濾 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29491] Improve display of notices in patron details
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29491 Fridolin Somers changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||22.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29476] Earliest renewal date is displayed wrong in circ/renew.pl for issues with auto renewing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29476 --- Comment #18 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 濾 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29476] Earliest renewal date is displayed wrong in circ/renew.pl for issues with auto renewing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29476 Fridolin Somers changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||22.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20076] Overdues: remove redundant message when patrons don't have email addresses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20076 --- Comment #34 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 濾 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20076] Overdues: remove redundant message when patrons don't have email addresses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20076 Fridolin Somers changed: What|Removed |Added Version(s)||22.05.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20076] Overdues: remove redundant message when patrons don't have email addresses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20076 Fridolin Somers changed: What|Removed |Added Attachment #129458|0 |1 is obsolete|| --- Comment #33 from Fridolin Somers --- Created attachment 129459 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129459=edit Bug 20076: (RM follow-up) Fix system preference boolean logic A Yes/No system preference must use 1 for Yes and 0 for No. So "Send" for 1/Yes and "Don't send" for 0/No. We add too much problems with double-negation boolean system preferences (such as dontmerge). Previous patch changed default value to 1 in atomicupdate, do the same in installer/data/mysql/mandatory/sysprefs.sql Also to be consistant, sets options = NULL instead of '' in atomicupdate Also removed useless added empty line in /misc/cronjobs/overdue_notices.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20076] Overdues: remove redundant message when patrons don't have email addresses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20076 Fridolin Somers changed: What|Removed |Added Keywords||release-notes-needed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20076] Overdues: remove redundant message when patrons don't have email addresses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20076 --- Comment #32 from Fridolin Somers --- Created attachment 129458 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129458=edit Bug 20076: (RM follow-up) Fix default value in installer/data/mysql/mandatory/sysprefs.sql Previous patch changed default value to 1 in atomicupdate, do the same in installer/data/mysql/mandatory/sysprefs.sql Also to be consistant, sets options = NULL instead of '' in atomicupdate Also removed useless added empty line in /misc/cronjobs/overdue_notices.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20076] Overdues: remove redundant message when patrons don't have email addresses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20076 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #31 from Fridolin Somers --- I've fixed a bit wiki page : https://wiki.koha-community.org/wiki/Database_updates#How_to_write_an_atomicupdate_file The perl file must contain "return" and have execute permissions. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24220] Convert OpacMoreSearches system preference to news block
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24220 Lucas Gass changed: What|Removed |Added Attachment #129456|0 |1 is obsolete|| --- Comment #2 from Lucas Gass --- Created attachment 129457 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129457=edit Bug 24220: Move OpacMoreSearches to HTML customizations in additional-contents To test: 1- Before applying the patch add some content to the system preference OpacMoreSearches 2- Apply patch 3- restart_all and updatedatabase 4. Go to additional-content.pl ( HTML customizations ) 5. You should now see your content from the system preference under OpacMoreSearches in HTML customizations 6. Try searching for the system preference, OpacMoreSeaches. It has been removed and you should not be able to find it. 7. Try changing/removing/adding content from OpacMoreSearches in HTML customizations 8. Make sure your edits are reflected when you look at the OpacMoreSearch area in the OPAC. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24220] Convert OpacMoreSearches system preference to news block
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24220 Lucas Gass changed: What|Removed |Added Assignee|oleon...@myacpl.org |lu...@bywatersolutions.com Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24220] Convert OpacMoreSearches system preference to news block
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24220 --- Comment #1 from Lucas Gass --- Created attachment 129456 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129456=edit Bug 24220: Move OpacMoreSearches to HTML customizations in additional-contents To test: 1- Before applying the patch add some content to the system preference OpacMoreSearches 2- Apply patch 3- restart_all and updatedatabase 4. Go to additional-content.pl ( HTML customizations ) 5. You should now see your content from the system preference under OpacMoreSearches in HTML customizations 6. Try searching for the system preference, OpacMoreSeaches. It has been removed and you should not be able to find it. 7. Try changing/removing/adding content from OpacMoreSearches in HTML customizations 8. Make sure your edits are reflected when you look at the OpacMoreSearch area in the OPAC. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24220] Convert OpacMoreSearches system preference to news block
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24220 Lucas Gass changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29491] Improve display of notices in patron details
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29491 Fridolin Somers changed: What|Removed |Added Keywords|release-notes-needed| Text to go in the||In patron notices table, release notes||notices are now shown in a ||modal dialog instead of ||inline in the table. ||The ||"Resend" button is shown in ||the modal window controls. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29491] Improve display of notices in patron details
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29491 Fridolin Somers changed: What|Removed |Added Keywords||release-notes-needed CC||fridolin.som...@biblibre.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7374] Add remote image option for authorized values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7374 Christopher Brannon changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #15 from Christopher Brannon --- I'm testing on a sandbox, and before I add the patch, everything work right. But when I add the patch, if I try to edit an existing CCODE, it acts like it is creating a new value instead of editing the existing one. All fields are blank. This patch is messing with existing functionality. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29875] Update text on MaxReserves system preference to describe functionality.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29875 Tomás Cohen Arazi changed: What|Removed |Added Attachment #129444|0 |1 is obsolete|| --- Comment #6 from Tomás Cohen Arazi --- Created attachment 129455 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129455=edit Bug 29875: Update wording on maxreserves system preference To test: 1 - see the current wording 2 - apply patch 3 - words are changed Test to confirm accuracy of wording: 1 - set maxreserves to 1 2 - set all/all circ rule to unlimited holds allowed total, holds allowed daily, and holds per record 3 - confirm you can place 1 hold for a patron, but the second is blocked 4 - set maxreserves to 0 5 - confirm you can place and number of holds for the patron 6 - set maxreserves to blank 7 - confirm you can place any number of holds for the patron Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29875] Update text on MaxReserves system preference to describe functionality.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29875 Tomás Cohen Arazi changed: What|Removed |Added Patch complexity|--- |String patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22827] Automatic item modifications by age: add age depencency on other field(s) than dateaccessioned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22827 Alex Buckley changed: What|Removed |Added Status|Failed QA |ASSIGNED --- Comment #9 from Alex Buckley --- (In reply to Andrew Fuerste-Henry from comment #8) > That said, I'm super excited to see a patch here and am eager to test again! Thanks Andrew. Hmm I'll fix up those 2 problems and attach a new patch to this ASAP! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22827] Automatic item modifications by age: add age depencency on other field(s) than dateaccessioned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22827 --- Comment #8 from Andrew Fuerste-Henry --- That said, I'm super excited to see a patch here and am eager to test again! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22827] Automatic item modifications by age: add age depencency on other field(s) than dateaccessioned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22827
Andrew Fuerste-Henry changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
--- Comment #7 from Andrew Fuerste-Henry ---
I followed the test plan successfully except:
- your directions are inconsistent. To make step 8 work, the rule in step 3
should use dateaccessioned and the rule in step 5 should use datelastseen
- I get a messy error on the test at the end. I don't have a clue what this
means, so it could be my error:
Cannot detect source of 't/db_dependent/Item/AutomaticItemModificationByAge'!
at /usr/share/perl/5.32/TAP/Parser/IteratorFactory.pm line 256.
TAP::Parser::IteratorFactory::detect_source(TAP::Parser::IteratorFactory=HASH(0x55d2dc3c5c48),
TAP::Parser::Source=HASH(0x55d2dc292438)) called at
/usr/share/perl/5.32/TAP/Parser/IteratorFactory.pm line 211
TAP::Parser::IteratorFactory::make_iterator(TAP::Parser::IteratorFactory=HASH(0x55d2dc3c5c48),
TAP::Parser::Source=HASH(0x55d2dc292438)) called at
/usr/share/perl/5.32/TAP/Parser.pm line 472
TAP::Parser::_initialize(TAP::Parser=HASH(0x55d2dc030148),
HASH(0x55d2dc03fee0)) called at /usr/share/perl/5.32/TAP/Object.pm line 55
TAP::Object::new("TAP::Parser", HASH(0x55d2dc03fee0)) called at
/usr/share/perl/5.32/TAP/Object.pm line 130
TAP::Object::_construct(TAP::Harness=HASH(0x55d2dbad1678),
"TAP::Parser", HASH(0x55d2dc03fee0)) called at
/usr/share/perl/5.32/TAP/Harness.pm line 852
TAP::Harness::make_parser(TAP::Harness=HASH(0x55d2dbad1678),
TAP::Parser::Scheduler::Job=HASH(0x55d2dc268728)) called at
/usr/share/perl/5.32/TAP/Harness.pm line 651
TAP::Harness::_aggregate_single(TAP::Harness=HASH(0x55d2dbad1678),
TAP::Parser::Aggregator=HASH(0x55d2dbad2128),
TAP::Parser::Scheduler=HASH(0x55d2dc2686f8)) called at
/usr/share/perl/5.32/TAP/Harness.pm line 743
TAP::Harness::aggregate_tests(TAP::Harness=HASH(0x55d2dbad1678),
TAP::Parser::Aggregator=HASH(0x55d2dbad2128),
"t/db_dependent/Item/AutomaticItemModificationByAge.t") called at
/usr/share/perl/5.32/TAP/Harness.pm line 558
TAP::Harness::__ANON__() called at /usr/share/perl/5.32/TAP/Harness.pm
line 571
TAP::Harness::runtests(TAP::Harness=HASH(0x55d2dbad1678),
"t/db_dependent/Item/AutomaticItemModificationByAge.t") called at
/usr/share/perl/5.32/App/Prove.pm line 548
App::Prove::_runtests(App::Prove=HASH(0x55d2dba9c538),
HASH(0x55d2dbf17978), "t/db_dependent/Item/AutomaticItemModificationByAge.t")
called at /usr/share/perl/5.32/App/Prove.pm line 506
App::Prove::run(App::Prove=HASH(0x55d2dba9c538)) called at
/usr/bin/prove line 13
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29057] Use font awesome icons on request.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29057 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #6 from Lucas Gass --- I like Owen's patch. The only thing I would say is that the use of the using the 'fa-rotate-90 fa-fast-foward' icon in the 'Toggle set to lowest priority' column looks awkward. Is it nessesary to have it in the ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29483] AllowRenewalIfOtherItemsAvailable has poor performance for records with many items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29483 --- Comment #12 from Andrew Fuerste-Henry --- Created attachment 129454 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129454=edit Bug 29843: Use in tools/cleanborrowers.pl This patch makes tools/cleanborrowers.pl use the new methods. Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29483] AllowRenewalIfOtherItemsAvailable has poor performance for records with many items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29483 --- Comment #11 from Andrew Fuerste-Henry --- Created attachment 129453 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129453=edit Bug 29843: Use in opac/opac-privacy.pl This patch makes the opac/opac-privacy.pl OPAC page use the new anonymize method. To test: 1. Have some checked-in materiales 2. Have OPACPrivacy enabled 3. Notice your checkouts history contains what you expect 4. Go to 'your privacy' 5. Click on 'Delete checkout history' => SUCCESS: It works, no crash. 6. Sign off :-D Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29483] AllowRenewalIfOtherItemsAvailable has poor performance for records with many items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29483 --- Comment #10 from Andrew Fuerste-Henry --- Created attachment 129452 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129452=edit Bug 29843: Use in batch_anonymise.pl This patch makes the batch_anonymise.pl cronjob script use the newly introduced methods instead of the old ones. To test: 1. Try the tool => SUCCESS: No behavior change 2. Sign off :-D Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29483] AllowRenewalIfOtherItemsAvailable has poor performance for records with many items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29483 --- Comment #9 from Andrew Fuerste-Henry --- Created attachment 129451 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129451=edit Bug 29843: Add ->anonymize and ->filter_by_anonymizable to Koha::Old::Checkouts This patch implements high-level methods for: * Filtering a Koha::Old::Checkouts resultset so only anonymizable rows are left * Anonymizing the rows in a resultset To test: 1. Apply this patches 2. Run: $ kshell k$ prove t/db_dependent/Koha/Old/Checkouts.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29483] AllowRenewalIfOtherItemsAvailable has poor performance for records with many items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29483 --- Comment #8 from Andrew Fuerste-Henry --- Created attachment 129450 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129450=edit Bug 29843: Unit tests This patch adds unit tests for the introduced methods. Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29483] AllowRenewalIfOtherItemsAvailable has poor performance for records with many items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29483 Andrew Fuerste-Henry changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29843] Add ->anonymize and ->filter_by_anonymizable to Koha::Old::Checkouts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29843 --- Comment #19 from Tomás Cohen Arazi --- Created attachment 129449 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129449=edit Bug 29843: Use in tools/cleanborrowers.pl This patch makes tools/cleanborrowers.pl use the new methods. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29843] Add ->anonymize and ->filter_by_anonymizable to Koha::Old::Checkouts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29843 --- Comment #18 from Tomás Cohen Arazi --- Created attachment 129448 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129448=edit Bug 29843: Use in opac/opac-privacy.pl This patch makes the opac/opac-privacy.pl OPAC page use the new anonymize method. To test: 1. Have some checked-in materiales 2. Have OPACPrivacy enabled 3. Notice your checkouts history contains what you expect 4. Go to 'your privacy' 5. Click on 'Delete checkout history' => SUCCESS: It works, no crash. 6. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29843] Add ->anonymize and ->filter_by_anonymizable to Koha::Old::Checkouts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29843 --- Comment #17 from Tomás Cohen Arazi --- Created attachment 129447 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129447=edit Bug 29843: Use in batch_anonymise.pl This patch makes the batch_anonymise.pl cronjob script use the newly introduced methods instead of the old ones. To test: 1. Try the tool => SUCCESS: No behavior change 2. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29843] Add ->anonymize and ->filter_by_anonymizable to Koha::Old::Checkouts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29843 --- Comment #16 from Tomás Cohen Arazi --- Created attachment 129446 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129446=edit Bug 29843: Add ->anonymize and ->filter_by_anonymizable to Koha::Old::Checkouts This patch implements high-level methods for: * Filtering a Koha::Old::Checkouts resultset so only anonymizable rows are left * Anonymizing the rows in a resultset To test: 1. Apply this patches 2. Run: $ kshell k$ prove t/db_dependent/Koha/Old/Checkouts.t => SUCCESS: Tests pass! 3. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29843] Add ->anonymize and ->filter_by_anonymizable to Koha::Old::Checkouts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29843 --- Comment #15 from Tomás Cohen Arazi --- Created attachment 129445 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129445=edit Bug 29843: Unit tests This patch adds unit tests for the introduced methods. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29843] Add ->anonymize and ->filter_by_anonymizable to Koha::Old::Checkouts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29843 Tomás Cohen Arazi changed: What|Removed |Added Attachment #129439|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29843] Add ->anonymize and ->filter_by_anonymizable to Koha::Old::Checkouts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29843 Tomás Cohen Arazi changed: What|Removed |Added Attachment #129438|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29843] Add ->anonymize and ->filter_by_anonymizable to Koha::Old::Checkouts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29843 Tomás Cohen Arazi changed: What|Removed |Added Attachment #129442|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29843] Add ->anonymize and ->filter_by_anonymizable to Koha::Old::Checkouts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29843 Tomás Cohen Arazi changed: What|Removed |Added Attachment #129441|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29843] Add ->anonymize and ->filter_by_anonymizable to Koha::Old::Checkouts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29843 Tomás Cohen Arazi changed: What|Removed |Added Attachment #129440|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29875] Update text on MaxReserves system preference to describe functionality.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29875 --- Comment #5 from Andrew Fuerste-Henry --- Added a sentence: "Additional limits may apply based on circulation rules." -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29875] Update text on MaxReserves system preference to describe functionality.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29875 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #129443|0 |1 is obsolete|| --- Comment #4 from Andrew Fuerste-Henry --- Created attachment 129444 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129444=edit Bug 29875: Update wording on maxreserves system preference To test: 1 - see the current wording 2 - apply patch 3 - words are changed Test to confirm accuracy of wording: 1 - set maxreserves to 1 2 - set all/all circ rule to unlimited holds allowed total, holds allowed daily, and holds per record 3 - confirm you can place 1 hold for a patron, but the second is blocked 4 - set maxreserves to 0 5 - confirm you can place and number of holds for the patron 6 - set maxreserves to blank 7 - confirm you can place any number of holds for the patron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29875] Update text on MaxReserves system preference to describe functionality.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29875 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #129437|0 |1 is obsolete|| --- Comment #3 from Andrew Fuerste-Henry --- Created attachment 129443 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129443=edit Bug 29875: Update wording on maxreserves system preference To test: 1 - see the current wording 2 - apply patch 3 - words are changed Test to confirm accuracy of wording: 1 - set maxreserves to 1 2 - set all/all circ rule to unlimited holds allowed total, holds allowed daily, and holds per record 3 - confirm you can place 1 hold for a patron, but the second is blocked 4 - set maxreserves to 0 5 - confirm you can place and number of holds for the patron 6 - set maxreserves to blank 7 - confirm you can place any number of holds for the patron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29526] Add 'Immediately delete holds history' button to patron privacy tab in opac
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29526 Tomás Cohen Arazi changed: What|Removed |Added Blocks||29843 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29843 [Bug 29843] Add ->anonymize and ->filter_by_anonymizable to Koha::Old::Checkouts -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29843] Add ->anonymize and ->filter_by_anonymizable to Koha::Old::Checkouts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29843 Tomás Cohen Arazi changed: What|Removed |Added Depends on||29526 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29526 [Bug 29526] Add 'Immediately delete holds history' button to patron privacy tab in opac -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29880] New: Add_items permission needed for patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29880 Bug ID: 29880 Summary: Add_items permission needed for patrons Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: jenday...@gmail.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com Currently, the edit_items permission allows users to both add and edit items. We have a central department that does all the library processing and we'd like to ensure that only the staff in that department be allowed to add items in order to ensure consistency and quality in our records. Ideally, the central department would be able to use the add_items and edit_items option and our staff on the campuses would be able to edit_items only (combined with the edit_items_restricted option). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29525] Privacy settings for patrons should also affect holds history
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 Tomás Cohen Arazi changed: What|Removed |Added Depends on|29869 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29869 [Bug 29869] Add Koha::Hold->fill -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29869] Add Koha::Hold->fill
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29869 Tomás Cohen Arazi changed: What|Removed |Added Blocks|29525 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 [Bug 29525] Privacy settings for patrons should also affect holds history -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29843] Add ->anonymize and ->filter_by_anonymizable to Koha::Old::Checkouts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29843 --- Comment #14 from Tomás Cohen Arazi --- Created attachment 129442 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129442=edit Bug 29843: Use in tools/cleanborrowers.pl This patch makes tools/cleanborrowers.pl use the new methods. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29843] Add ->anonymize and ->filter_by_anonymizable to Koha::Old::Checkouts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29843 --- Comment #13 from Tomás Cohen Arazi --- Created attachment 129441 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129441=edit Bug 29843: Use in opac/opac-privacy.pl This patch makes the opac/opac-privacy.pl OPAC page use the new anonymize method. To test: 1. Have some checked-in materiales 2. Have OPACPrivacy enabled 3. Notice your checkouts history contains what you expect 4. Go to 'your privacy' 5. Click on 'Delete checkout history' => SUCCESS: It works, no crash. 6. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29843] Add ->anonymize and ->filter_by_anonymizable to Koha::Old::Checkouts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29843 --- Comment #12 from Tomás Cohen Arazi --- Created attachment 129440 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129440=edit Bug 29843: Use in batch_anonymise.pl This patch makes the batch_anonymise.pl cronjob script use the newly introduced methods instead of the old ones. To test: 1. Try the tool => SUCCESS: No behavior change 2. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29843] Add ->anonymize and ->filter_by_anonymizable to Koha::Old::Checkouts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29843 --- Comment #11 from Tomás Cohen Arazi --- Created attachment 129439 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129439=edit Bug 29843: Add ->anonymize and ->filter_by_anonymizable to Koha::Old::Checkouts This patch implements high-level methods for: * Filtering a Koha::Old::Checkouts resultset so only anonymizable rows are left * Anonymizing the rows in a resultset To test: 1. Apply this patches 2. Run: $ kshell k$ prove t/db_dependent/Koha/Old/Checkouts.t => SUCCESS: Tests pass! 3. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29843] Add ->anonymize and ->filter_by_anonymizable to Koha::Old::Checkouts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29843 --- Comment #10 from Tomás Cohen Arazi --- Created attachment 129438 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129438=edit Bug 29843: Unit tests This patch adds unit tests for the introduced methods. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29843] Add ->anonymize and ->filter_by_anonymizable to Koha::Old::Checkouts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29843 Tomás Cohen Arazi changed: What|Removed |Added Attachment #129278|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29843] Add ->anonymize and ->filter_by_anonymizable to Koha::Old::Checkouts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29843 Tomás Cohen Arazi changed: What|Removed |Added Attachment #129277|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29843] Add ->anonymize and ->filter_by_anonymizable to Koha::Old::Checkouts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29843 Tomás Cohen Arazi changed: What|Removed |Added Attachment #129276|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29843] Add ->anonymize and ->filter_by_anonymizable to Koha::Old::Checkouts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29843 Tomás Cohen Arazi changed: What|Removed |Added Attachment #129275|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29843] Add ->anonymize and ->filter_by_anonymizable to Koha::Old::Checkouts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29843 Tomás Cohen Arazi changed: What|Removed |Added Attachment #129274|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29843] Add ->anonymize and ->filter_by_anonymizable to Koha::Old::Checkouts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29843 Tomás Cohen Arazi changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29875] Update text on MaxReserves system preference to describe functionality.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29875 --- Comment #2 from Andrew Fuerste-Henry --- Created attachment 129437 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129437=edit Bug 29875: Update wording on maxreserves system preference To test: 1 - see the current wording 2 - apply patch 3 - words are changed Test to confirm accuracy of wording: 1 - set maxreserves to 1 2 - set all/all circ rule to unlimited holds allowed total, holds allowed daily, and holds per record 3 - confirm you can place 1 hold for a patron, but the second is blocked 4 - set maxreserves to 0 5 - confirm you can place and number of holds for the patron 6 - set maxreserves to blank 7 - confirm you can place any number of holds for the patron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
